On 06/08/2018 05:05 PM, Laurent Vivier wrote:
> I'm rebasing some of these patches for seven years now,
> too many years...
>
> It's an RFC because things have changed in QEMU in seven years,
> for instance the VIA has a new implementation (mos6522) introduced
> by Mark Cave-Ayland and I didn't
On Fri, Jun 08, 2018 at 02:48:10PM +0200, David Hildenbrand wrote:
> I'll be messing with machine hotplug handlers of pc/spapr/s390x in the
> context of
> [PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers
>
> So this is a spin-off of the cleanup patches in the context of hotplug
Sorry missed dgilbert's comment about RAMBLOCK_FOREACH_MIGRATABLE in previous
revision.
From: Qemu-devel on behalf of
junyan...@gmx.com
Sent: Saturday, June 9, 2018 1:12:31 AM
To: qemu-devel@nongnu.org
Cc: xiaoguangrong.e...@gmail.com;
From: Junyan He
Because we need to make sure the pmem kind memory data is synced
after migration, we choose to call pmem_persist() when the migration
finish. This will make sure the data of pmem is safe and will not
lose if power is off.
Signed-off-by: Junyan He
---
include/qemu/pmem.h | 1 +
On Fri, Jun 8, 2018 at 7:25 PM, Marc-André Lureau
wrote:
> Hi
>
> On Mon, Jun 4, 2018 at 11:37 AM, Gerd Hoffmann wrote:
>> On Fri, Jun 01, 2018 at 06:27:48PM +0200, Marc-André Lureau wrote:
>>> Add to virtio-gpu devices a "vhost-user" property. When set, the
>>> associated vhost-user backend is
It seems to me that no one has really looked into the matter, I can't
find any comments,that this issue has been worked on.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1463812
Title:
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Friday, June 8, 2018 2:50 PM
> To: Moger, Babu
> Cc: ge...@hostfission.com; k...@vger.kernel.org; m...@redhat.com;
> k...@tripleback.net; mtosa...@redhat.com; xiaoguangr...@tencent.com;
>
If the CPU model supports topoext feature, enabled the
feature automatically if it can be supported.
Signed-off-by: Babu Moger
---
target/i386/cpu.c | 40
1 file changed, 40 insertions(+)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index
Add support for cpuid leaf CPUID_8000_001E. Build the config that closely
match the underlying hardware. Please refer to the Processor Programming
Reference (PPR) for AMD Family 17h Model for more details.
Signed-off-by: Babu Moger
---
target/i386/cpu.c | 86
Remove generic non-intel check while validating hyperthreading support.
Certain AMD CPUs can support hyperthreading now.
CPU family with TOPOEXT feature can support hyperthreading now.
Signed-off-by: Babu Moger
Tested-by: Geoffrey McRae
Reviewed-by: Eduardo Habkost
---
target/i386/cpu.c | 17
This series enables the TOPOEXT feature for AMD CPUs. This is required to
support hyperthreading on kvm guests.
This addresses the issues reported in these bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1481253
https://bugs.launchpad.net/qemu/+bug/1703506
v13:
Patches are based off of
Introduce the auto_topoext bit to to control topoext feature.
Also add new field auto_topoext(in X86CPUDefinition). This will
be used to enable topoext on newer CPU models where topoext can
be supported.
Signed-off-by: Babu Moger
---
include/hw/i386/pc.h | 4
target/i386/cpu.c| 12
Enable TOPOEXT feature on EPYC CPU. This is required to support
hyperthreading on VM guests. Also extend xlevel to 0x801E.
TOPOEXT feature is disabled for legacy machines.
Signed-off-by: Babu Moger
---
target/i386/cpu.c | 7 +++
1 file changed, 7 insertions(+)
diff --git
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180608123307.24773-1-alex.ben...@linaro.org
Subject: [Qemu-devel] [PATCH v6 00/49] fix building of tests/tcg
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
Hi,
This series failed docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180608205830.308627-1-...@redhat.com
Subject: [Qemu-devel] [RFC untested PATCH]
On 6/6/2018 9:20 AM, Daniel P. Berrangé wrote:
> On Tue, Jun 05, 2018 at 08:31:41AM -0500, Tom Lendacky wrote:
>> On 6/4/2018 3:07 PM, Eduardo Habkost wrote:
>>> On Fri, Jun 01, 2018 at 11:38:08AM -0400, Konrad Rzeszutek Wilk wrote:
AMD future CPUs expose _two_ ways to utilize the Intel
On 06/08/2018 04:45 PM, Cornelia Huck wrote:
On Fri, 8 Jun 2018 15:13:28 +0200
Halil Pasic wrote:
On 06/08/2018 02:20 PM, Cornelia Huck wrote:
My proposal is to do the same
copying to scsw(r) again, which would mean we get a request with both
the halt and the start bit set. The vfio code
When guest CPU PM is enabled, and with -cpu host, expose the host CPU
MWAIT leaf to guest so guest can make good PM decisions.
Signed-off-by: Michael S. Tsirkin
---
This builds but is untested. Is this a reasonable way to go about it?
target/i386/cpu.h | 9 +
target/i386/cpu.c | 18
On 06/08/2018 12:44 AM, Philippe Mathieu-Daudé wrote:
> On 01/09/2018 11:01 AM, Peter Maydell wrote:
>> Since omap_mmc is still using the legacy SD card API, the SD
>> card created by sd_init() is not plugged into any bus. This
>> means that the controller has to reset it manually.
>>
>> Failing
On 06/07/2018 06:34 PM, Cornelia Huck wrote:
On Thu, 7 Jun 2018 18:17:57 +0200
Halil Pasic wrote:
On 06/07/2018 11:54 AM, Cornelia Huck wrote:
Hm, I think we need to be more precise as to what scsw we're talking
about. Bad ascii art time:
--
| scsw(g) | ssch
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180608200558.386-1-laur...@vivier.eu
Subject: [Qemu-devel] [RFC 00/13] hw/m68k: add Apple Machintosh Quadra 800
machine
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
Hi,
This series failed docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180608152353.98712-1-vsement...@virtuozzo.com
Subject: [Qemu-devel] [PATCH v4 0/6] NBD
When using SCSI passthrough and running in Linux, QEMU edits the
reply of the SCSI Inquiry VPD Block Limits message with the value
of the /sys/bus//queue/max_sectors_kb parameter the device
has in the host. Doing so allows the Linux guest to proper setup
the device.
But the Block Limits message
The previous patches implemented a way to deliver an emulated
Block Limits (BL) response for the guest in case the underlying
hardware does not support this page.
However, the approach used is crude. We're executing the logic for
all SCSI devices, regardless of whether they need it or not.
This is needed by Quadra 800, this card can run on little-endian
or big-endian bus.
Signed-off-by: Laurent Vivier
---
hw/net/dp8393x.c | 101 ++-
1 file changed, 70 insertions(+), 31 deletions(-)
diff --git a/hw/net/dp8393x.c
The previous commit added Block Limits emulation for scsi-block devices
if the underlying hardware does not implement it. But this is not
enough to fix the issue of max_io_sectors mismatch between the
guest and the host - the guest is not aware of the Block
Limits support we're now providing.
Signed-off-by: Laurent Vivier
---
hw/input/adb.c| 99 -
hw/misc/Makefile.objs | 1 +
hw/misc/mac_via.c | 940 ++
include/hw/input/adb.h| 8 +
include/hw/misc/mac_via.h | 45 +++
5 files changed, 1092 insertions(+),
On 08.06.2018 17:58, Patryk Olszewski wrote:
> W dniu 08.06.2018 o 17:25, Peter Maydell pisze:
>> On 8 June 2018 at 06:47, Thomas Huth wrote:
>>> On 07.06.2018 23:08, Philippe Mathieu-Daudé wrote:
Remove the 'stair-step output' on stdio.
This partially reverts commit 12fb0ac05,
The VPD Block Limits Inquiry page is optional, allowing SCSI devices
to not implement it. This is the case for devices like the MegaRAID
SAS 9361-8i and Microsemi PM8069.
In case of SCSI passthrough, the response of this request is used by
the QEMU SCSI layer to set the max_io_sectors that the
From: Laurent Vivier
Signed-off-by: Laurent Vivier
---
arch_init.c | 4 +
hw/display/Makefile.objs| 1 +
hw/display/macfb-template.h | 158 +
hw/display/macfb.c | 283
qemu-options.hx
Signed-off-by: Laurent Vivier
---
hw/Makefile.objs | 1 +
hw/display/macfb.c | 67 +++-
hw/nubus/Makefile.objs | 4 +
hw/nubus/mac.c | 112 +++
hw/nubus/nubus-bridge.c | 34 ++
hw/nubus/nubus-bus.c | 60 +++
It's only 32 bytes, and this simplifies the dp8393x_get()/
dp8393x_put() interface.
Signed-off-by: Laurent Vivier
---
hw/net/dp8393x.c | 107 ++-
1 file changed, 51 insertions(+), 56 deletions(-)
diff --git a/hw/net/dp8393x.c
From: Laurent Vivier
Signed-off-by: Laurent Vivier
---
default-configs/m68k-softmmu.mak | 12 ++
hw/display/macfb.c | 31 ++--
hw/m68k/Makefile.objs| 6 +-
hw/m68k/bootinfo.h | 99 ++
hw/m68k/mac.c| 384
Signed-off-by: Laurent Vivier
---
hw/block/Makefile.objs | 1 +
hw/block/swim.c| 325 +
2 files changed, 326 insertions(+)
create mode 100644 hw/block/swim.c
diff --git a/hw/block/Makefile.objs b/hw/block/Makefile.objs
index
The card is not able to exit from exhaustion state, because
while the drive consumes the buffers, the RRP is incremented
(when the driver clears the ISR RBE bit), so it stays equal
to RWP, and while RRP == RWP, the card thinks it is always
in exhaustion state. So the driver consumes all the
From: Laurent Vivier
This is broken as the linux driver seems broken too...
Signed-off-by: Laurent Vivier
---
hw/audio/Makefile.objs | 1 +
hw/audio/asc.c | 492 +
include/hw/audio/asc.h | 21 +++
3 files changed, 514 insertions(+)
Signed-off-by: Laurent Vivier
---
hw/input/adb-kbd.c | 4
hw/input/adb-mouse.c | 4
hw/input/adb.c | 33 +
hw/misc/mac_via.c | 27 ++-
include/hw/input/adb.h | 1 +
5 files changed, 60 insertions(+), 9
From: Laurent Vivier
Signed-off-by: Laurent Vivier
---
hw/mips/mips_jazz.c | 2 +-
hw/scsi/esp.c | 330 +-
include/hw/scsi/esp.h | 15 ++-
3 files changed, 313 insertions(+), 34 deletions(-)
diff --git a/hw/mips/mips_jazz.c
address_space_rw() access size must be multiplied by width.
dp8393x_receive() must return the number of bytes read, not the length
of the last memory access.
Signed-off-by: Laurent Vivier
---
hw/net/dp8393x.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git
I'm rebasing some of these patches for seven years now,
too many years...
It's an RFC because things have changed in QEMU in seven years,
for instance the VIA has a new implementation (mos6522) introduced
by Mark Cave-Ayland and I didn't rework my implementation to
fit into this new one (any
From: Laurent Vivier
On Sparc and PowerMac, the bit 0 of the address
selects the register type (control or data) and
bit 1 selects the channel (B or A).
On m68k Macintosh, the bit 0 selects the channel and
bit 1 the register type.
This patch introduces a new parameter (bit_swap) to
the device
Fix the cocoa front-end to correctly be able to use absolute mode.
Signed-off-by: John Arbuckle
---
ui/cocoa.m | 32
1 file changed, 24 insertions(+), 8 deletions(-)
diff --git a/ui/cocoa.m b/ui/cocoa.m
index 2991ed4f19..dda99ad638 100644
--- a/ui/cocoa.m
+++
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Friday, June 8, 2018 2:50 PM
> To: Moger, Babu
> Cc: ge...@hostfission.com; k...@vger.kernel.org; m...@redhat.com;
> k...@tripleback.net; mtosa...@redhat.com; xiaoguangr...@tencent.com;
>
On 08.06.2018 20:41, Michael S. Tsirkin wrote:
> On Fri, Jun 08, 2018 at 07:23:06PM +0200, Thomas Huth wrote:
>> On 08.06.2018 18:24, Michael S. Tsirkin wrote:
>>> On Fri, Jun 08, 2018 at 05:16:30PM +0100, Peter Maydell wrote:
[...]
If there's a situation that shouldn't exist in the tree (ie
On Fri, Jun 08, 2018 at 07:36:05PM +, Moger, Babu wrote:
>
> > -Original Message-
> > From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> > Sent: Friday, June 8, 2018 2:23 PM
> > To: Moger, Babu
> > Cc: m...@redhat.com; marcel.apfelb...@gmail.com; pbonz...@redhat.com;
> >
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Friday, June 8, 2018 2:23 PM
> To: Moger, Babu
> Cc: m...@redhat.com; marcel.apfelb...@gmail.com; pbonz...@redhat.com;
> r...@twiddle.net; mtosa...@redhat.com; qemu-devel@nongnu.org;
>
On Thu, Jun 07, 2018 at 04:31:11PM -0600, Ross Zwisler wrote:
> Replace the "nvdimm-cap" option which took numeric arguments such as "2"
> with a more user friendly "nvdimm-persistence" option which takes symbolic
> arguments "cpu" or "mem-ctrl".
>
> Signed-off-by: Ross Zwisler
> Suggested-by:
On 06/06/2018 02:24 PM, John Snow wrote:
> This is largely the same series that Vladimir sent in January, but at
> the time I was unsure of if we'd want these commands or not in QEMU.
>
> After discussing with Virtuozzo their plans for a checkpoint-like API
> implemented primarily in libvirt,
commit f548222c added PC_COMPAT_2_12 to the 3.0 PC machine-types.
I believe this happened during manual conflict resolution when
applying the patch.
Cc: Xiao Guangrong
Cc: Juan Quintela
Fixes: f548222c24342ca74689de7794f9006b43f86a54
Signed-off-by: Eduardo Habkost
---
hw/i386/pc_piix.c | 1 -
On 06/08/2018 02:01 PM, Philippe Mathieu-Daudé wrote:
qemu-version.h and qemu-options.def are generated files
that should be deleted during 'make distclean'.
This solves building issues with out-of-tree builds from
a source tree that has been built in (see d1bd2423a90):
Well, it prevents
On Fri, Jun 08, 2018 at 06:40:16PM +, Moger, Babu wrote:
> Hi Eduardo,
> Sorry for the late response. Got pulled into something else.
>
> > -Original Message-
> > From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> > Sent: Wednesday, June 6, 2018 5:40 PM
> > To: Moger, Babu
> > Cc:
On 06/08/2018 01:02 PM, Markus Armbruster wrote:
> We banned use of certain g_assert_FOO() functions outside tests, and
> made checkpatch.pl flag them (commit 6e9389563e5). We neglected to
> purge existing uses. Do that now.
>
> Signed-off-by: Markus Armbruster
I've apparently got a real
Make a separate function for compression to be parallelized later.
- use .avail_aut field instead of .next_out to calculate size of
compressed data. It looks more natural and it allows to keep dest to
be void pointer
- set avail_out to be at least one byte less than input, to be sure
Do data compression in separate threads. This significantly improve
performance for qemu-img convert with -W (allow async writes) and -c
(compressed) options.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2.h | 3 +++
block/qcow2.c | 62
Hi all!
Here are compress threads for qcow2, to increase performance of
compressed writes.
I've created the following test:
[]# cat ../gen.sh
#!/bin/bash
echo 'create pattern-file t_pat'
./qemu-img create -f raw t_pat 1000m
./qemu-io -c 'write -P 0xab 0 1000m' t_pat
echo 'create randod
No reason to forbid them, and they are needed to improve performance
with compress-threads in further patches.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
qemu-img.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 75f1610aa0..df2657b9cb 100644
---
On 06/08/2018 10:30 AM, Eduardo Habkost wrote:
> All of the supported build platforms documented in qemu-doc.texi
> should already support Python 2.7.
>
> Removing support for Python 2.6 will allow us to remove some
> compatibility modules we carry in the QEMU tree:
>
> * scripts/argparse.py
From: Farhan Ali
Register a crypto algo with the Linux crypto layer only if
the algorithm is supported by the backend virtio-crypto
device.
Also route crypto requests to a virtio-crypto
device, only if it can support the requested service and
algorithm.
Signed-off-by: Farhan Ali
---
Read the crypto services and algorithm masks which provides
information about the services and algorithms supported by
virtio-crypto backend.
Signed-off-by: Farhan Ali
---
drivers/crypto/virtio/virtio_crypto_common.h | 14 ++
drivers/crypto/virtio/virtio_crypto_core.c | 29
Hi,
Currently the Linux virtio-crypto driver registers the crypto
algorithm without verifying if the backend actually supports the
algorithm.
This kernel patch series adds support for registering algorithm
with Linux crypto layer, only if the algorithm is supported by
the backend device. This
On 06/08/2018 02:52 PM, Eduardo Habkost wrote:
> Changes v1 -> v2:
> * Remove references to ordereddict.py from Makefiles
> (oops)
>
> Now that we require Python >= 2.7, we don't need
> scripts/argparse.py and scripts/ordereddict.py anymore.
>
> Eduardo Habkost (2):
> python: Remove
qemu-version.h and qemu-options.def are generated files
that should be deleted during 'make distclean'.
This solves building issues with out-of-tree builds from
a source tree that has been built in (see d1bd2423a90):
- /qemu-version.h existing in source tree:
/source/qemu/qemu-nbd.c: In
qemu-version.h and qemu-options.def are generated files
that should be deleted during 'make distclean'.
This solves building issues with out-of-tree builds from
a source tree that has been built in (see d1bd2423a90).
This solves:
- /qemu-version.h existing in source tree:
On 06/08/2018 02:52 PM, Philippe Mathieu-Daudé wrote:
> On 06/04/2018 07:28 AM, Peter Maydell wrote:
>> On 1 June 2018 at 17:26, Michael S. Tsirkin wrote:
>>> The following changes since commit 63b88968f139b6a77f2f81e6f1eedf70c0170a85:
>>>
>>> intel-iommu: rework the page walk logic (2018-05-23
On Fri, Jun 08, 2018 at 07:23:06PM +0200, Thomas Huth wrote:
> On 08.06.2018 18:24, Michael S. Tsirkin wrote:
> > On Fri, Jun 08, 2018 at 05:16:30PM +0100, Peter Maydell wrote:
> >> On 8 June 2018 at 17:03, Michael S. Tsirkin wrote:
> >>> Pull requests are somewhat different, they are usually
Hi Eduardo,
Sorry for the late response. Got pulled into something else.
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Wednesday, June 6, 2018 5:40 PM
> To: Moger, Babu
> Cc: m...@redhat.com; marcel.apfelb...@gmail.com; pbonz...@redhat.com;
>
Hi,
I had time to investigate more on this problem.
On 16/05/2018 15:43, Laurent Vivier wrote:
> Hi Bala,
>
> I've tested you patch migrating a pseries between a P9 host and a P8
> host with 1G huge page size on the P9 side and 16MB on P8 side and the
> information are strange now.
>
>
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Wednesday, June 6, 2018 4:26 PM
> To: Moger, Babu
> Cc: m...@redhat.com; marcel.apfelb...@gmail.com; pbonz...@redhat.com;
> r...@twiddle.net; mtosa...@redhat.com; qemu-devel@nongnu.org;
>
On Fri, Jun 08, 2018 at 07:57:55PM +0200, Lukáš Doktor wrote:
> Hello guys,
>
> Dne 7.6.2018 v 01:06 Philippe Mathieu-Daudé napsal(a):
> > On 06/06/2018 05:05 PM, Eduardo Habkost wrote:
> >> On Wed, Jun 06, 2018 at 04:27:31PM -0300, Philippe Mathieu-Daudé wrote:
> >>> The readline() call returns
On 06/08/2018 02:39 PM, Greg Kurz wrote:
> On Thu, 31 May 2018 19:16:05 +0200
> Paolo Bonzini wrote:
>
>> From: Patryk Olszewski
>>
>> This patch fixes a bug in serial that made it almost impossible for guest
>> to communicate with devices through host's serial.
>>
>> OPOST flag in c_oflag
On 06/08/2018 12:41 PM, Ross Zwisler wrote:
-"Set on/off to enable/disable igd passthrou", _abort);
+"Set on/off to enable/disable igd passthru", _abort);
Shouldn't that rather be "passthrough" instead?
Either works, I think. "thru" and "passthru" are short informal
Changes v1 -> v2:
* Remove references to ordereddict.py from Makefiles
(oops)
Now that we require Python >= 2.7, we don't need
scripts/argparse.py and scripts/ordereddict.py anymore.
Eduardo Habkost (2):
python: Remove scripts/argparse.py
python: Remove scripts/ordereddict.py
Makefile
Hello guys,
Dne 7.6.2018 v 01:06 Philippe Mathieu-Daudé napsal(a):
> On 06/06/2018 05:05 PM, Eduardo Habkost wrote:
>> On Wed, Jun 06, 2018 at 04:27:31PM -0300, Philippe Mathieu-Daudé wrote:
>>> The readline() call returns partial data.
>>
>> How can this be reproduced? Despite not being
Le 08/06/2018 à 19:48, Richard Henderson a écrit :
> On 06/07/2018 10:25 AM, Laurent Vivier wrote:
>> do you want I take this through my m68k tree or do you take this in a
>> TCG pull requests?
>
> Would you take it through your m68k tree please?
OK, I take.
Thanks,
Laurent
Python 2.7 (the minimum Python version we require) already
provides the argparse module on the standard library.
Signed-off-by: Eduardo Habkost
---
scripts/argparse.py | 2406 ---
1 file changed, 2406 deletions(-)
delete mode 100644 scripts/argparse.py
On 06/08/2018 02:12 PM, Daniel P. Berrangé wrote:
> On Fri, Jun 08, 2018 at 07:02:31PM +0200, Markus Armbruster wrote:
>> We banned use of certain g_assert_FOO() functions outside tests, and
>> made checkpatch.pl flag them (commit 6e9389563e5). We neglected to
>> purge existing uses. Do that
On 06/08/2018 06:16 PM, BALATON Zoltan wrote:
> On Fri, 8 Jun 2018, Cédric Le Goater wrote:
>> On 06/06/2018 03:31 PM, BALATON Zoltan wrote:
>>> Basic emulation of the M41T80 serial (I2C) RTC chip. Only getting time
>>> of day is implemented. Setting time and RTC alarm are not supported.
>>>
>>>
Python 2.7 (the minimum Python version we require) provides
collections.OrderedDict on the standard library, so we don't need
to carry our own implementation.
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2:
* Remove ordereddict.py reference from Makefiles
---
Makefile | 1 -
On 06/04/2018 07:28 AM, Peter Maydell wrote:
> On 1 June 2018 at 17:26, Michael S. Tsirkin wrote:
>> The following changes since commit 63b88968f139b6a77f2f81e6f1eedf70c0170a85:
>>
>> intel-iommu: rework the page walk logic (2018-05-23 17:34:05 +0300)
>>
>> are available in the Git repository
W dniu 08.06.2018 o 19:39, Greg Kurz pisze:
> On Thu, 31 May 2018 19:16:05 +0200
> Paolo Bonzini wrote:
>
>> From: Patryk Olszewski
>>
>> This patch fixes a bug in serial that made it almost impossible for guest
>> to communicate with devices through host's serial.
>>
>> OPOST flag in c_oflag
From: Paolo Bonzini
For the case where the end_transfer_func is also the caller of
ide_transfer_start, the mutual recursion can lead to unlimited
stack usage. Introduce a new version that can be used to change
tail recursion into a loop, and use it in trace_ide_atapi_cmd_reply_end.
On 06/07/2018 10:25 AM, Laurent Vivier wrote:
> do you want I take this through my m68k tree or do you take this in a
> TCG pull requests?
Would you take it through your m68k tree please?
r~
The PIO Setup FIS is written in the PIO:Entry state, which comes before
the ATA and ATAPI data transfer states. As a result, the PIO Setup FIS
interrupt is now raised before DMA ends for ATAPI commands, and tests have
to be adjusted.
This is also hinted by the description of the command header
From: Paolo Bonzini
The code can simply be moved to the sole caller that has notify == true.
Signed-off-by: Paolo Bonzini
Signed-off-by: John Snow
Reviewed-by: John Snow
Reviewed-by: Philippe Mathieu-Daudé
Message-id: 20180606190955.20845-5-js...@redhat.com
Signed-off-by: John Snow
---
On 06/07/2018 10:17 AM, Laurent Vivier wrote:
> If you agree, I will remove tabs when I'll commit the patches for the
> pull-request.
Yes please. I should have noticed them there when making my change.
r~
From: Paolo Bonzini
The ATAPI_INT_REASON_IO interrupt is raised when I/O starts, but in the
AHCI case ide_set_irq was actually called at the end of a mutual recursion.
Move it early, with the side effect that ide_transfer_start becomes a tail
call in ide_atapi_cmd_reply_end.
Signed-off-by:
From: Paolo Bonzini
There is code checking s->end_transfer_func and it was not taught about
ide_transfer_cancel. We can just use ide_transfer_stop because
s->end_transfer_func is only ever called in the DRQ phase.
ide_transfer_cancel can then be removed, since it would just be
calling
From: Paolo Bonzini
Now that end_transfer_func is a tail call in ahci_start_transfer,
formalize the fact that the callback (of which ahci_start_transfer is
the sole implementation) takes care of the transfer too: rename it to
pio_transfer and, if it is present, call the end_transfer_func as soon
From: Thomas Huth
Commit 1454509726719e0933c800 recently broke the "-cdrom" parameter
on a couple of boards without us noticing it immediately. Thus let's
add a test which checks that "-cdrom" can at least be used to start
QEMU with certain machine types.
Reviewed-by: Philippe Mathieu-Daudé
It's not always 512, and it does wind up mattering for PIO tranfers,
because this means DRQ blocks are four times as big for ATAPI.
Replace an instance of 2048 with the correct define, too.
This patch by itself winds changing no behavior. fis->count is ignored
for CMD_PACKET, and sect_count only
From: Thomas Huth
The cdrom-test checks various block types - IDE, SCSI and
virtio, so it's a little bit hard to decide where this should
belong to in the MAINTAINERS file. But John volunteered to take
it, so let's put it into the IDE section for now.
Signed-off-by: Thomas Huth
Acked-by: John
Actually, this function looks pretty broken, but for now, let's finish
up what this series of commits came here to do.
Signed-off-by: John Snow
Reviewed-by: Philippe Mathieu-Daudé
Message-id: 20180531222835.16558-15-js...@redhat.com
Signed-off-by: John Snow
---
hw/ide/ahci.c | 15
From: Thomas Huth
We already have the code for a boot file in tests/boot-sector.c,
so if the genisoimage program is available, we can easily create
a bootable CD ISO image that we can use for testing whether our
CD-ROM emulation and the BIOS CD-ROM boot works correctly.
Reviewed-by: Philippe
Signed-off-by: John Snow
Reviewed-by: Philippe Mathieu-Daudé
Message-id: 20180531222835.16558-8-js...@redhat.com
[Changed format specifier. --js]
Signed-off-by: John Snow
---
hw/ide/ahci.c | 8 +++-
hw/ide/trace-events | 3 ++-
2 files changed, 9 insertions(+), 2 deletions(-)
diff
Signed-off-by: John Snow
Reviewed-by: Philippe Mathieu-Daudé
Message-id: 20180531222835.16558-14-js...@redhat.com
Signed-off-by: John Snow
---
hw/ide/ahci.c | 47 +++
1 file changed, 23 insertions(+), 24 deletions(-)
diff --git a/hw/ide/ahci.c
Signed-off-by: John Snow
Reviewed-by: Philippe Mathieu-Daudé
Message-id: 20180531222835.16558-16-js...@redhat.com
Signed-off-by: John Snow
---
hw/ide/ahci_internal.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/hw/ide/ahci_internal.h b/hw/ide/ahci_internal.h
index
From: Thomas Huth
We're going to use the s390x boot code for testing CD-ROM booting.
But the ISO loader of the s390-ccw bios is a little bit more picky
than the network loader and expects some magic bytes in the header
of the file (see linux_s390_magic in pc-bios/s390-ccw/bootmap.c), so
we've
Churn.
Signed-off-by: John Snow
Reviewed-by: Philippe Mathieu-Daudé
Message-id: 20180531222835.16558-5-js...@redhat.com
[Fix patchew/checkpatch nit. --js]
Signed-off-by: John Snow
---
hw/ide/ahci.c | 142 +-
1 file changed, 71
Instead of tracking offsets, lets count the registers.
Signed-off-by: John Snow
Reviewed-by: Philippe Mathieu-Daudé
Message-id: 20180531222835.16558-2-js...@redhat.com
Signed-off-by: John Snow
---
hw/ide/ahci.c | 25 +
hw/ide/ahci_internal.h | 29
Signed-off-by: John Snow
Reviewed-by: Philippe Mathieu-Daudé
Message-id: 20180531222835.16558-13-js...@redhat.com
Signed-off-by: John Snow
---
hw/ide/ahci.c | 7 +--
hw/ide/trace-events | 3 +++
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/hw/ide/ahci.c
1 - 100 of 460 matches
Mail list logo
