Re: [Qemu-devel] [PATCH 2/2] tests: add precopy multifd migration with fd protocol

2018-07-05 Thread Balamuruhan S
On Fri, Jul 06, 2018 at 12:37:40PM +0800, Peter Xu wrote: > On Thu, Jul 05, 2018 at 06:22:31PM +0530, Balamuruhan S wrote: > > On Thu, Jul 05, 2018 at 05:26:09PM +0800, Peter Xu wrote: > > > On Thu, Jul 05, 2018 at 01:30:17PM +0530, Balamuruhan S wrote: > > > > This patch adds test for multifd

Re: [Qemu-devel] [PATCH v3 1/3] spapr: introduce a fixed IRQ number space

2018-07-05 Thread David Gibson
On Tue, Jul 03, 2018 at 05:19:56PM +0200, Cédric Le Goater wrote: > On 07/02/2018 01:11 PM, Cédric Le Goater wrote: > > On 07/02/2018 12:03 PM, Cédric Le Goater wrote: > >>> --- a/hw/ppc/spapr_vio.c > >>> +++ b/hw/ppc/spapr_vio.c > >>> @@ -436,6 +436,9 @@ static void

Re: [Qemu-devel] [PATCH 2/2] tests: add precopy multifd migration with fd protocol

2018-07-05 Thread Peter Xu
On Thu, Jul 05, 2018 at 06:22:31PM +0530, Balamuruhan S wrote: > On Thu, Jul 05, 2018 at 05:26:09PM +0800, Peter Xu wrote: > > On Thu, Jul 05, 2018 at 01:30:17PM +0530, Balamuruhan S wrote: > > > This patch adds test for multifd migration feature with fd protocol. > > > > > > Signed-off-by:

Re: [Qemu-devel] [PATCH 03/14] timer: ds1338 persist 12-hour mode selection

2018-07-05 Thread Michael Davidsaver
On 07/05/2018 08:39 PM, David Gibson wrote: > On Thu, Jul 05, 2018 at 11:19:50AM -0700, Michael Davidsaver wrote: > 11;rgb://> Need to save HOUR[HOUR12] bit to keep >> track of guest selection of 12-hour mode. >> Write through current time registers to >> achieve this. Will be

Re: [Qemu-devel] [PATCH] monitor: fix double-free of request error

2018-07-05 Thread Peter Xu
On Thu, Jul 05, 2018 at 06:42:01PM +0200, Marc-André Lureau wrote: > qmp_error_response() will free the given error. Fix double-free in > later qmp_request_free(). > > Signed-off-by: Marc-André Lureau Reviewed-by: Peter Xu And not related to current patch... > --- > monitor.c | 1 + > 1

Re: [Qemu-devel] [PATCH 5/9] monitor: suspend monitor instead of send CMD_DROP

2018-07-05 Thread Peter Xu
On Thu, Jul 05, 2018 at 11:47:30AM -0500, Eric Blake wrote: > On 07/04/2018 03:45 AM, Peter Xu wrote: > > When we received too many qmp commands, previously we'll send > > COMMAND_DROPPED events to monitors, then we'll drop the requests. It > > can only solve the flow control of the request

Re: [Qemu-devel] [PATCH 03/14] timer: ds1338 persist 12-hour mode selection

2018-07-05 Thread David Gibson
On Thu, Jul 05, 2018 at 11:19:50AM -0700, Michael Davidsaver wrote: 11;rgb://> Need to save HOUR[HOUR12] bit to keep > track of guest selection of 12-hour mode. > Write through current time registers to > achieve this. Will be overwritten > by the next read/latch. > > This was only

Re: [Qemu-devel] VGA cirrus patch prevents video output

2018-07-05 Thread David Gibson
On Thu, Jul 05, 2018 at 10:41:43PM -0400, Programmingkid wrote: > I noticed that the video in QEMU stopped working. When I start > qemu-system-ppc all I see is a black window. Not even OpenBIOS displays > anything. After some bisecting I found out it was this patch that causes the > problem: >

[Qemu-devel] [PATCH v2] ui/cocoa.m: replace scrollingDeltaY with deltaY

2018-07-05 Thread John Arbuckle
The NSEvent class method scrollingDeltaY is available for Mac OS 10.7 and newer. Since QEMU supports Mac OS 10.5 and up, we need to be using a method that is available on these version of Mac OS X. The deltaY method is a method that does the same thing as scrollingDeltaY and is available on Mac OS

[Qemu-devel] VGA cirrus patch prevents video output

2018-07-05 Thread Programmingkid
I noticed that the video in QEMU stopped working. When I start qemu-system-ppc all I see is a black window. Not even OpenBIOS displays anything. After some bisecting I found out it was this patch that causes the problem: Commit 29f9cef39eb1ae55e82c6763eb22d7a1bdff7276 Author: Sebastian Bauer

Re: [Qemu-devel] [PATCH for-3.0 4/9] tests: introduce migrate_postcopy_* helpers

2018-07-05 Thread Peter Xu
On Thu, Jul 05, 2018 at 03:01:44PM +0530, Balamuruhan S wrote: > On Thu, Jul 05, 2018 at 11:17:50AM +0800, Peter Xu wrote: > > Separate the old postcopy UNIX socket test into three steps, provide a > > helper for each step. With these helpers, we can do more compliated > > tests like postcopy

Re: [Qemu-devel] [PATCH] pci: remove pci_del_option_rom()

2018-07-05 Thread Peter Xu
On Thu, Jul 05, 2018 at 11:44:44PM +0200, Paolo Bonzini wrote: > On 05/07/2018 21:30, Alex Williamson wrote: > > On Thu, 5 Jul 2018 20:11:48 +0200 > > Cédric Le Goater wrote: > > > >> PCI devices needing a ROM allocate an optional MemoryRegion with > >> pci_add_option_rom().

Re: [Qemu-devel] [PATCH 02/14] timer: ds1338 use registerfields.h

2018-07-05 Thread David Gibson
On Thu, Jul 05, 2018 at 11:19:49AM -0700, Michael Davidsaver wrote: > Use names for registers and bits except > for R_CTRL which will be dealt with later, > and isn't modeled anyway. > > Signed-off-by: Michael Davidsaver > Reviewed-by: Peter Maydell Reviewed-by: David Gibson > --- >

Re: [Qemu-devel] [PULL v3 0/7] riscv-pull queue

2018-07-05 Thread Alistair Francis
On Wed, Jul 4, 2018 at 2:37 PM, Peter Maydell wrote: > On 3 July 2018 at 17:34, Alistair Francis wrote: >> The following changes since commit f988c7e191141e92de2059d04a5f9a9bb01f399c: >> >> Merge remote-tracking branch 'remotes/shorne/tags/pull-or-20180703' into >> staging (2018-07-03

[Qemu-devel] [PULL v4 7/7] hw/riscv/sifive_u: Connect the Cadence GEM Ethernet device

2018-07-05 Thread Alistair Francis
Connect the Cadence GEM ethernet device. This also requires us to expose the plic interrupt lines. Signed-off-by: Alistair Francis Reviewed-by: Michael Clark --- default-configs/riscv32-softmmu.mak | 2 ++ default-configs/riscv64-softmmu.mak | 2 ++ hw/riscv/sifive_u.c | 50

[Qemu-devel] [PULL v4 3/7] hw/riscv/sifive_plic: Use gpios instead of irqs

2018-07-05 Thread Alistair Francis
Instead of creating the interrupt in lines with qemu_allocate_irq() use qdev_init_gpio_in() as this gives us the ability to use the qdev*gpio*() helpers later on. Signed-off-by: Alistair Francis Suggested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael Clark

[Qemu-devel] [PULL v4 1/7] hw/riscv/sifive_u: Create a SiFive U SoC object

2018-07-05 Thread Alistair Francis
Create a SiFive Unleashed U54 SoC and use that in the sifive_u machine. We leave the SoC, RAM, device tree and reset/fdt loading as part of the machine. All the other device creation has been moved to the SoC. Signed-off-by: Alistair Francis Reviewed-by: Michael Clark --- hw/riscv/sifive_u.c

[Qemu-devel] [PULL v4 4/7] hw/riscv/sifive_u: Set the soc device tree node as a simple-bus

2018-07-05 Thread Alistair Francis
To allow Linux to ennumerate devices on the /soc/ node set it as a "simple-bus". Signed-off-by: Alistair Francis Reviewed-by: Michael Clark --- hw/riscv/sifive_u.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c index

[Qemu-devel] [PULL v4 6/7] hw/riscv/sifive_u: Move the uart device tree node under /soc/

2018-07-05 Thread Alistair Francis
Signed-off-by: Alistair Francis Reviewed-by: Michael Clark --- hw/riscv/sifive_u.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c index 4d3ba4e624..445fe4f7fb 100644 --- a/hw/riscv/sifive_u.c +++ b/hw/riscv/sifive_u.c @@ -194,7

[Qemu-devel] [PULL v4 0/7] riscv-pull queue

2018-07-05 Thread Alistair Francis
/qemu.git tags/pull-riscv-pull-20180705 for you to fetch changes up to 5a7f76a3d47a75290868968682c0585d380764a4: hw/riscv/sifive_u: Connect the Cadence GEM Ethernet device (2018-07-05 15:24:25 -0700) RISC-V: SoCify SiFive boards

[Qemu-devel] [PULL v4 5/7] hw/riscv/sifive_u: Set the interrupt controller number of interrupts

2018-07-05 Thread Alistair Francis
Set the interrupt-controller ndev to the correct number taken from the HiFive Unleashed board. Signed-off-by: Alistair Francis Reviewed-by: Michael Clark --- hw/riscv/sifive_u.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c index

[Qemu-devel] [PULL v4 2/7] hw/riscv/sifive_e: Create a SiFive E SoC object

2018-07-05 Thread Alistair Francis
Signed-off-by: Alistair Francis Reviewed-by: Michael Clark --- hw/riscv/sifive_e.c | 94 +++-- include/hw/riscv/sifive_e.h | 16 ++- 2 files changed, 83 insertions(+), 27 deletions(-) diff --git a/hw/riscv/sifive_e.c b/hw/riscv/sifive_e.c index

Re: [Qemu-devel] [PATCH] sam460ex: Add comment explaining ignored errors from fdt operations

2018-07-05 Thread David Gibson
On Thu, Jul 05, 2018 at 04:06:28PM +0200, Paolo Bonzini wrote: > On 05/07/2018 15:51, Guenter Roeck wrote: > > +/* Failure to set serial port clocks is not fatal, so just ignore > > + * errors when trying to do so. > > + */ > > +(void)fdt_setprop_cell(fdt, offset,

Re: [Qemu-devel] [PATCH 7/7] target/ppc: Use non-arithmetic conversions for fp load/store

2018-07-05 Thread David Gibson
On Thu, Jul 05, 2018 at 12:51:00PM -0400, Programmingkid wrote: > > > On Jul 5, 2018, at 12:48 PM, Richard Henderson > > wrote: > > > > On 07/05/2018 09:31 AM, Programmingkid wrote: > >>> On Jul 3, 2018, at 11:17 AM, Richard Henderson > >>> wrote: > >>> > >>> Memory operations have no side

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-05 Thread Siwei Liu
On Wed, Jul 4, 2018 at 5:15 AM, Cornelia Huck wrote: > On Tue, 3 Jul 2018 16:31:03 -0700 > Siwei Liu wrote: > >> On Tue, Jul 3, 2018 at 7:52 AM, Cornelia Huck wrote: >> > From my point of view, there are several concerns: >> > - This approach assumes a homogeneous pairing (same transport), and

Re: [Qemu-devel] [PATCH] acpi: generalize aml_package / aml_varpackage

2018-07-05 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180705235305.124423-1-...@redhat.com Subject: [Qemu-devel] [PATCH] acpi: generalize aml_package / aml_varpackage === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PATCH] acpi: generalize aml_package / aml_varpackage

2018-07-05 Thread Michael S. Tsirkin
VarPackage can accept an expression evaluating to int, not just an int. Change the API to make it more generic. Further, rather than have users call the correct API depending on value passed, use either PackageOp or VarPackageOp automatically. Signed-off-by: Michael S. Tsirkin ---

[Qemu-devel] [PATCH v2] target/arm: Forbid unprivileged mode for M Baseline

2018-07-05 Thread Julia Suvorova via Qemu-devel
MSR handling is the only place where CONTROL.nPRIV is modified. Signed-off-by: Julia Suvorova --- v2: * Add the check in the CONTROL_NS case target/arm/helper.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index

[Qemu-devel] [RFC v3 2/2] tests: Add ARMv6-M reserved register test

2018-07-05 Thread Julia Suvorova via Qemu-devel
Check that reserved SCS registers return 0 at read, and writes are ignored. Based-on: <20180627143815.1829-1-j...@jms.id.au> Based-on: <20180630091343.14391-1-stefa...@redhat.com> Signed-off-by: Julia Suvorova --- Test will work if Joel's patches will use ARMv6-M. tests/Makefile.include

[Qemu-devel] [PATCH v3 1/2] nvic: Handle ARMv6-M SCS reserved registers

2018-07-05 Thread Julia Suvorova via Qemu-devel
Handle SCS reserved registers listed in ARMv6-M ARM D3.6.1. All reserved registers are RAZ/WI. ARM_FEATURE_M_MAIN is used for the checks, because these registers are reserved in ARMv8-M Baseline too. Signed-off-by: Julia Suvorova --- hw/intc/armv7m_nvic.c | 51

[Qemu-devel] [PATCH v3 0/2] nvic: Handle ARMv6-M SCS reserved registers

2018-07-05 Thread Julia Suvorova via Qemu-devel
v3: * Fix indents v2: * Use ARM_FEATURE_M_MAIN instead of ARM_FEATURE_V7 in most cases * Remove CPUID registers check * Use bad_offset instead of return * Misc style fixes Julia Suvorova (2): nvic: Handle ARMv6-M SCS reserved registers tests: Add ARMv6-M reserved register

Re: [Qemu-devel] [PATCH v2 0/2] nvic: Handle ARMv6-M SCS reserved registers

2018-07-05 Thread Julia Suvorova via Qemu-devel
On 06.07.2018 00:50, Julia Suvorova wrote: v2: * Use ARM_FEATURE_M_MAIN instead of ARM_FEATURE_V7 in most cases * Remove CPUID registers check * Use bad_offset instead of return * Misc style fixes Julia Suvorova (2): nvic: Handle ARMv6-M SCS reserved registers tests:

[Qemu-devel] [RFC v2 2/2] tests: Add ARMv6-M reserved register test

2018-07-05 Thread Julia Suvorova via Qemu-devel
Check that reserved SCS registers return 0 at read, and writes are ignored. Based-on: <20180627143815.1829-1-j...@jms.id.au> Based-on: <20180630091343.14391-1-stefa...@redhat.com> Signed-off-by: Julia Suvorova --- Test will work if Joel's patches will use ARMv6-M. tests/Makefile.include

[Qemu-devel] [PATCH v2 1/2] nvic: Handle ARMv6-M SCS reserved registers

2018-07-05 Thread Julia Suvorova via Qemu-devel
Handle SCS reserved registers listed in ARMv6-M ARM D3.6.1. All reserved registers are RAZ/WI. ARM_FEATURE_M_MAIN is used for the checks, because these registers are reserved in ARMv8-M Baseline too. Signed-off-by: Julia Suvorova --- hw/intc/armv7m_nvic.c | 51

[Qemu-devel] [PATCH v2 0/2] nvic: Handle ARMv6-M SCS reserved registers

2018-07-05 Thread Julia Suvorova via Qemu-devel
v2: * Use ARM_FEATURE_M_MAIN instead of ARM_FEATURE_V7 in most cases * Remove CPUID registers check * Use bad_offset instead of return * Misc style fixes Julia Suvorova (2): nvic: Handle ARMv6-M SCS reserved registers tests: Add ARMv6-M reserved register test

Re: [Qemu-devel] [PATCH] pci: remove pci_del_option_rom()

2018-07-05 Thread Paolo Bonzini
On 05/07/2018 21:30, Alex Williamson wrote: > On Thu, 5 Jul 2018 20:11:48 +0200 > Cédric Le Goater wrote: > >> PCI devices needing a ROM allocate an optional MemoryRegion with >> pci_add_option_rom(). pci_del_option_rom() does the cleanup when the >> device is destroyed. The only action taken

Re: [Qemu-devel] Byte ordering of VM Generation ID in Windows VMs

2018-07-05 Thread Richard W.M. Jones
On Thu, Jul 05, 2018 at 08:10:15PM +0300, Michael S. Tsirkin wrote: > On Thu, Jul 05, 2018 at 05:43:43PM +0100, Richard W.M. Jones wrote: > > On Thu, Jul 05, 2018 at 04:20:33PM +0200, Laszlo Ersek wrote: > > > QEMU does the right thing. If other hypervisors don't do this -- while > > > still

Re: [Qemu-devel] [PATCH 2/2] qapi: add transaction support for x-block-dirty-bitmap-merge

2018-07-05 Thread John Snow
On 07/03/2018 06:53 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/transaction.json | 2 ++ > blockdev.c| 53 > ++- > 2 files changed, 54 insertions(+), 1 deletion(-) > > diff

Re: [Qemu-devel] [PATCH] pci: remove pci_del_option_rom()

2018-07-05 Thread Cédric Le Goater
On 07/05/2018 09:11 PM, Michael S. Tsirkin wrote: > On Thu, Jul 05, 2018 at 08:11:48PM +0200, Cédric Le Goater wrote: >> PCI devices needing a ROM allocate an optional MemoryRegion with >> pci_add_option_rom(). pci_del_option_rom() does the cleanup when the >> device is destroyed. The only action

Re: [Qemu-devel] [PATCH V3] qemu-img: align result of is_allocated_sectors

2018-07-05 Thread Peter Lieven
> Am 05.07.2018 um 17:15 schrieb Kevin Wolf : > > Am 05.07.2018 um 12:52 hat Peter Lieven geschrieben: >> We currently don't enforce that the sparse segments we detect during convert >> are >> aligned. This leads to unnecessary and costly read-modify-write cycles either >> internally in Qemu

[Qemu-devel] [PATCH v8 2/3] qga: update guest-suspend-ram and guest-suspend-hybrid descriptions

2018-07-05 Thread Daniel Henrique Barboza
This patch updates the descriptions of 'guest-suspend-ram' and 'guest-suspend-hybrid' to mention that both commands relies now on the proper support for wake up from suspend, retrieved by the 'wakeup-suspend-support' attribute of the 'query-current-machine' QMP command. Reported-by: Balamuruhan S

[Qemu-devel] [PATCH v8 3/3] qmp hmp: Make system_wakeup check wake-up support and run state

2018-07-05 Thread Daniel Henrique Barboza
The qmp/hmp command 'system_wakeup' is simply a direct call to 'qemu_system_wakeup_request' from vl.c. This function verifies if runstate is SUSPENDED and if the wake up reason is valid before proceeding. However, no error or warning is thrown if any of those pre-requirements isn't met. There is

[Qemu-devel] [PATCH v8 0/3] wakeup-from-suspend and system_wakeup changes

2018-07-05 Thread Daniel Henrique Barboza
changes in v8: - created 'query-current-machine' API to hold the wakeup-suspend-support flag - wake-up flag now considers the --no-acpi config option for PC archs - fixes in patch 3 proposed by Markus. Previous series link: https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg04234.html

[Qemu-devel] [PATCH v8 1/3] qmp: query-current-machine with wakeup-suspend-support

2018-07-05 Thread Daniel Henrique Barboza
When issuing the qmp/hmp 'system_wakeup' command, what happens in a nutshell is: - qmp_system_wakeup_request set runstate to RUNNING, sets a wakeup_reason and notify the event - in the main_loop, all vcpus are paused, a system reset is issued, all subscribers of wakeup_notifiers receives a

Re: [Qemu-devel] [PATCH] pci: remove pci_del_option_rom()

2018-07-05 Thread Alex Williamson
On Thu, 5 Jul 2018 20:11:48 +0200 Cédric Le Goater wrote: > PCI devices needing a ROM allocate an optional MemoryRegion with > pci_add_option_rom(). pci_del_option_rom() does the cleanup when the > device is destroyed. The only action taken by this routine is to call > vmstate_unregister_ram()

[Qemu-devel] [PATCH 2/2] target/arm: Fix do_predset for large VL

2018-07-05 Thread Richard Henderson
Use MAKE_64BIT_MASK instead of open-coding. Remove an odd vector size check that is unlikely to be more profitable than 3 64-bit integer stores. Correct the iteration for WORD to avoid writing too much data. Fixes RISU tests of PTRUE for VL 256. Signed-off-by: Richard Henderson ---

[Qemu-devel] [PATCH 1/2] tcg: Restrict check_size_impl to multiples of the line size

2018-07-05 Thread Richard Henderson
Normally this is automatic in the size restrictions that are placed on vector sizes coming from the implementation. However, for the legitimate size tuple [oprsz=8, maxsz=32], we need to clear the final 24 bytes of the vector register. Without this check, do_dup selects TCG_TYPE_V128 and clears

[Qemu-devel] [PATCH 0/2] target/arm: SVE fixes

2018-07-05 Thread Richard Henderson
RISU testing with ARM Fast Models and VQ=16 showed up two bugs, both affecting the PTRUE instruction. r~ Richard Henderson (2): tcg: Restrict check_size_impl to multiples of the line size target/arm: Fix do_predset for large VL target/arm/translate-sve.c | 10 ++

Re: [Qemu-devel] [RFC 00/15] s390: vfio-ccw dasd ipl support

2018-07-05 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1530811543-6881-1-git-send-email-jjhe...@linux.ibm.com Subject: [Qemu-devel] [RFC 00/15] s390: vfio-ccw dasd ipl support === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH] pci: remove pci_del_option_rom()

2018-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2018 at 08:11:48PM +0200, Cédric Le Goater wrote: > PCI devices needing a ROM allocate an optional MemoryRegion with > pci_add_option_rom(). pci_del_option_rom() does the cleanup when the > device is destroyed. The only action taken by this routine is to call >

Re: [Qemu-devel] [PATCH 1/2] drity-bitmap: refactor merge: separte can_merge

2018-07-05 Thread John Snow
On 07/05/2018 02:55 PM, Eric Blake wrote: > On 07/05/2018 01:51 PM, John Snow wrote: > >> >>> -    assert(!bdrv_dirty_bitmap_readonly(dest)); >>> - >>> -    if (!hbitmap_merge(dest->bitmap, src->bitmap)) { >>> -    error_setg(errp, "Bitmaps are incompatible and can't be >>> merged"); >>> + 

Re: [Qemu-devel] [PATCH 1/2] drity-bitmap: refactor merge: separte can_merge

2018-07-05 Thread Eric Blake
On 07/05/2018 01:51 PM, John Snow wrote: -assert(!bdrv_dirty_bitmap_readonly(dest)); - -if (!hbitmap_merge(dest->bitmap, src->bitmap)) { -error_setg(errp, "Bitmaps are incompatible and can't be merged"); +if (bdrv_can_merge_dirty_bitmap(dest, src, errp)) { +bool

Re: [Qemu-devel] [PATCH 1/2] drity-bitmap: refactor merge: separte can_merge

2018-07-05 Thread John Snow
On 07/03/2018 06:53 AM, Vladimir Sementsov-Ogievskiy wrote: > Separate can_merge, to reuse it for transaction support for merge > command. > > Also, switch some asserts to errors. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/dirty-bitmap.h | 3 +++ >

[Qemu-devel] [PATCH 14/14] tests: drop ds1338-test

2018-07-05 Thread Michael Davidsaver
redundant to ds-rtc-*-test.c Signed-off-by: Michael Davidsaver --- tests/Makefile.include | 2 -- tests/ds1338-test.c| 75 -- 2 files changed, 77 deletions(-) delete mode 100644 tests/ds1338-test.c diff --git a/tests/Makefile.include

[Qemu-devel] [PATCH 13/14] timer: ds-rtc model ds1375

2018-07-05 Thread Michael Davidsaver
differences from ds1338 * Has alarms (not modeled) * different control register (not modeled) * smaller address space (0x20 vs. 0x40) Signed-off-by: Michael Davidsaver Reviewed-by: Peter Maydell --- hw/timer/ds-rtc.c | 30 -- 1 file changed, 28 insertions(+), 2

[Qemu-devel] [PATCH 09/14] timer: rename file ds1338.c -> ds-rtc.c

2018-07-05 Thread Michael Davidsaver
Signed-off-by: Michael Davidsaver Reviewed-by: Peter Maydell --- default-configs/arm-softmmu.mak | 2 +- hw/timer/Makefile.objs | 2 +- hw/timer/{ds1338.c => ds-rtc.c} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename hw/timer/{ds1338.c => ds-rtc.c} (100%) diff --git

[Qemu-devel] [PATCH 06/14] tests: ds-rtc test 12 hour mode

2018-07-05 Thread Michael Davidsaver
Signed-off-by: Michael Davidsaver --- tests/ds-rtc-set-test.c | 52 + 1 file changed, 52 insertions(+) diff --git a/tests/ds-rtc-set-test.c b/tests/ds-rtc-set-test.c index 35e1a36281..c48406ee2c 100644 --- a/tests/ds-rtc-set-test.c +++

[Qemu-devel] [PATCH 12/14] timer: ds-rtc handle CENTURY bit

2018-07-05 Thread Michael Davidsaver
Signed-off-by: Michael Davidsaver Reviewed-by: Peter Maydell --- hw/timer/ds-rtc.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/timer/ds-rtc.c b/hw/timer/ds-rtc.c index 6d3a8b5586..9abac38628 100644 --- a/hw/timer/ds-rtc.c +++ b/hw/timer/ds-rtc.c @@ -70,6 +70,7

[Qemu-devel] [PATCH 10/14] timer: ds1338 remove vestige of un-modeled OSF

2018-07-05 Thread Michael Davidsaver
Oscillator stop has never been modeled, so the Oscillator Stop Flag can never be set. Signed-off-by: Michael Davidsaver --- hw/timer/ds-rtc.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/hw/timer/ds-rtc.c b/hw/timer/ds-rtc.c index 3c5781d53c..126566ce1f

[Qemu-devel] [PATCH 01/14] tests: more thorough tests of ds1338

2018-07-05 Thread Michael Davidsaver
Test current time and set+get round trip. Separate current time test from set/get tests to avoid test needing to impose order, or to have a magic handshaketo reset RTC to current time. Signed-off-by: Michael Davidsaver --- tests/Makefile.include | 4 ++ tests/ds-rtc-common.h | 67

[Qemu-devel] [PATCH 05/14] timer: ds1338 change write handling and fix wday_offset handling

2018-07-05 Thread Michael Davidsaver
instead of a read-modify-write, do direct translation of device registers to struct tm members. This new ds1338_update() is the reverse of the existing capture_current_time(). Simplifies later handling of CENTURY bit in similar Dallas RTC chips. Correctly handle different real weekday in guest

[Qemu-devel] [PATCH 08/14] timer: rename ds1338 -> dsrtc

2018-07-05 Thread Michael Davidsaver
Prepare to generalize with a more generic name. Keep device name and vmstate name "ds1338" for compatibility. Signed-off-by: Michael Davidsaver Reviewed-by: Peter Maydell --- hw/timer/ds1338.c | 72 +++ 1 file changed, 36 insertions(+), 36

[Qemu-devel] [PATCH 04/14] timer: ds1338 clarify HOUR handling

2018-07-05 Thread Michael Davidsaver
Simplify and comment the translation between registers and struct tm. Signed-off-by: Michael Davidsaver --- hw/timer/ds1338.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/timer/ds1338.c b/hw/timer/ds1338.c index b56db5852e..637a0f4246 100644 ---

[Qemu-devel] [PATCH 00/14] Generalize Dallas/Maxim I2C RTC devices v3

2018-07-05 Thread Michael Davidsaver
This series generalizes the ds1338 model to also support the ds1375. As previously, only the time of day registers are modeled. This series (v3) is a minor iteration on the previous v2. No changes were made to the unittests. Summary of changes by patch name in response to comments by Peter

[Qemu-devel] [PATCH 03/14] timer: ds1338 persist 12-hour mode selection

2018-07-05 Thread Michael Davidsaver
Need to save HOUR[HOUR12] bit to keep track of guest selection of 12-hour mode. Write through current time registers to achieve this. Will be overwritten by the next read/latch. This was only being done in two of three arms of this conditional block. Signed-off-by: Michael Davidsaver ---

[Qemu-devel] [PATCH 07/14] tests: ds-rtc test wday offset

2018-07-05 Thread Michael Davidsaver
Signed-off-by: Michael Davidsaver --- tests/ds-rtc-common.h | 10 +++--- tests/ds-rtc-current-test.c | 9 - tests/ds-rtc-set-test.c | 6 -- 3 files changed, 19 insertions(+), 6 deletions(-) diff --git a/tests/ds-rtc-common.h b/tests/ds-rtc-common.h index

[Qemu-devel] [PATCH 02/14] timer: ds1338 use registerfields.h

2018-07-05 Thread Michael Davidsaver
Use names for registers and bits except for R_CTRL which will be dealt with later, and isn't modeled anyway. Signed-off-by: Michael Davidsaver Reviewed-by: Peter Maydell --- hw/timer/ds1338.c | 80 +-- 1 file changed, 54 insertions(+), 26

[Qemu-devel] [PATCH] pci: remove pci_del_option_rom()

2018-07-05 Thread Cédric Le Goater
PCI devices needing a ROM allocate an optional MemoryRegion with pci_add_option_rom(). pci_del_option_rom() does the cleanup when the device is destroyed. The only action taken by this routine is to call vmstate_unregister_ram() which clears the id string of the optional ROM RAMBlock and now, also

[Qemu-devel] [RFC 14/15] s390-bios: Support booting from real dasd device

2018-07-05 Thread Jason J. Herne
From: "Jason J. Herne" Allows guest to boot from a vfio configured real dasd device. Signed-off-by: Jason J. Herne Signed-off-by: Jason J. Herne --- docs/devel/s390-dasd-ipl.txt | 132 +++ pc-bios/s390-ccw/Makefile| 2 +- pc-bios/s390-ccw/dasd-ipl.c | 249

[Qemu-devel] [RFC 15/15] s390-bios: Use sense ccw to ensure consistent device state at boot time

2018-07-05 Thread Jason J. Herne
If a vfio-ccw device is left in an error state (example: pending unit check) then it is possible for that state to persist for a vfio-ccw device even after the enable subchannel that we do to bring the device online. If this state is allowed to persist then even simple I/O operations will

[Qemu-devel] [RFC 13/15] s390-bios: Add channel command codes/structs needed for dasd-ipl

2018-07-05 Thread Jason J. Herne
From: "Jason J. Herne" The dasd IPL procedure needs to execute a few previously unused channel commands. Let's define them and their associated data structures. Signed-off-by: Jason J. Herne Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/cio.h | 23 +++ 1 file

[Qemu-devel] [RFC 11/15] s390-bios: Refactor virtio to run channel programs via cio

2018-07-05 Thread Jason J. Herne
From: "Jason J. Herne" Now that we have a Channel I/O library let's modify virtio boot code to make use of it for running channel programs. Signed-off-by: Jason J. Herne Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/virtio.c | 21 ++--- 1 file changed, 2 insertions(+),

[Qemu-devel] [RFC 12/15] s390-bios: Use control unit type to determine boot method

2018-07-05 Thread Jason J. Herne
From: "Jason J. Herne" The boot method is different depending on which device type we are booting from. Let's examine the control unit type to determine if we're a virtio device. We'll eventually add a case to check for a real dasd device here as well. Signed-off-by: Jason J. Herne

[Qemu-devel] [RFC 09/15] s390-bios: ptr2u32 and u32toptr

2018-07-05 Thread Jason J. Herne
From: "Jason J. Herne" Introduce inline functions to convert between pointers and unsigned 32-bit ints. These are used to hide the ugliness required to avoid compiler warnings. Signed-off-by: Jason J. Herne Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/libc.h | 12 1 file

Re: [Qemu-devel] [PULL v3 00/20] Travis, Code Coverage and Cross Build updates

2018-07-05 Thread Peter Maydell
On 5 July 2018 at 17:03, Alex Bennée wrote: > The following changes since commit 6cf495be0b445789eeb7e88a6015c8cf74d4c1cf: > > Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' > into staging (2018-07-05 13:33:52 +0100) > > are available in the Git repository at: > >

[Qemu-devel] [RFC 07/15] s390-bios: Decouple channel i/o logic from virtio

2018-07-05 Thread Jason J. Herne
From: "Jason J. Herne" Create a separate library for channel i/o related code. This decouples channel i/o operations from virtio and allows us to make use of them for the real dasd boot path. Signed-off-by: Jason J. Herne Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/Makefile|

[Qemu-devel] [RFC 04/15] s390-bios: Extend find_dev() for non-virtio devices

2018-07-05 Thread Jason J. Herne
From: "Jason J. Herne" We need a method for finding the subchannel of a dasd device. Let's modify find_dev to handle this since it mostly does what we need. Up to this point find_dev has been specific to only virtio devices. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic Signed-off-by:

[Qemu-devel] [RFC] target/arm: Suppress Coverity warning for PRF

2018-07-05 Thread Richard Henderson
These instructions must perform the sve_access_check, but since they are implemented as NOPs there is no generated code to elide when the access check fails. Fixes: Coverity issues 1393780 & 1393779. Signed-off-by: Richard Henderson --- Does anyone know if this actually works for Coverity? I'd

[Qemu-devel] [RFC 03/15] s390-bios: decouple common boot logic from virtio

2018-07-05 Thread Jason J. Herne
From: "Jason J. Herne" Create a boot_setup function to handle getting boot information from the machine/hypervisor. This decouples common boot logic from the virtio code path and allows us to make use of it for the real dasd boot scenario. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic

[Qemu-devel] [RFC 02/15] s390-bios: decouple cio setup from virtio

2018-07-05 Thread Jason J. Herne
From: "Jason J. Herne" Move channel i/o setup code out to a separate function. This decouples cio setup from the virtio code path and allows us to make use of it for booting dasd devices. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic Reviewed-by: Collin Walling Signed-off-by: Jason J.

Re: [Qemu-devel] [RFC] target/arm: Suppress Coverity warning for PRF

2018-07-05 Thread Peter Maydell
On 5 July 2018 at 19:04, Richard Henderson wrote: > These instructions must perform the sve_access_check, but > since they are implemented as NOPs there is no generated > code to elide when the access check fails. > > Fixes: Coverity issues 1393780 & 1393779. > Signed-off-by: Richard Henderson >

[Qemu-devel] [RFC 05/15] s390-bios: Factor finding boot device out of virtio code path

2018-07-05 Thread Jason J. Herne
From: "Jason J. Herne" Make a new routine find_boot_device to locate the boot device for all cases. not just virtio. In one case no boot device is specified and a suitable boot device can not be auto detected. The error message for this case was specific to virtio devices. We update this

[Qemu-devel] [RFC 10/15] s390-bios: Support for running format-0/1 channel programs

2018-07-05 Thread Jason J. Herne
From: "Jason J. Herne" Add struct for format-0 ccws. Support executing format-0 channel programs and waiting for their completion before continuing execution. This will be used for real dasd ipl. Add cu_type() to channel io library. This will be used to query control unit type which is used to

[Qemu-devel] [RFC 01/15] s390 vfio-ccw: Add bootindex property and IPLB data

2018-07-05 Thread Jason J. Herne
From: "Jason J. Herne" Add bootindex property and iplb data for vfio-ccw devices. This allows us to forward boot information into the bios for vfio-ccw devices. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic Signed-off-by: Jason J. Herne --- hw/s390x/ipl.c | 15

[Qemu-devel] [RFC 08/15] s390-bios: Map low core memory

2018-07-05 Thread Jason J. Herne
From: "Jason J. Herne" Create a new header for basic architecture specific definitions and add a mapping of low core memory. This mapping will be used by the real dasd boot process. Signed-off-by: Jason J. Herne Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/main.c | 2 +

[Qemu-devel] [RFC 06/15] s390-bios: Clean up cio.h

2018-07-05 Thread Jason J. Herne
From: "Jason J. Herne" Add proper typedefs to all structs and modify all bit fields to use consistent formatting. Signed-off-by: Jason J. Herne Reviewed-by: Collin Walling Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/cio.h | 86 ++---

[Qemu-devel] [RFC 00/15] s390: vfio-ccw dasd ipl support

2018-07-05 Thread Jason J. Herne
This is to support booting from vfio-ccw dasd devices. We basically implement the real hardware ipl procedure. This allows for booting Linux guests on vfio-ccw devices. vfio-ccw's channel program prefetch algorithm complicates ipl because most ipl channel programs dynamically modify themselves.

Re: [Qemu-devel] [PATCH] qga: fix 'driver' leak in guest-get-fsinfo

2018-07-05 Thread Laszlo Ersek
On 07/05/18 18:16, Marc-André Lureau wrote: > 'driver' is leaked when the loop is not broken. > > Leak introduced by commit 743c71d03c20d64f2bae5fba6f26cdf5e4b1bda6, > spotted by ASAN. > > Signed-off-by: Marc-André Lureau > --- > qga/commands-posix.c | 1 + > 1 file changed, 1 insertion(+) >

Re: [Qemu-devel] Byte ordering of VM Generation ID in Windows VMs

2018-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2018 at 07:15:34PM +0200, Laszlo Ersek wrote: > > It has to be said that after reading the spec again [the MSFT spec, > > not qemu's spec] and what other hypervisors are doing, I'm not sure > > qemu is doing the right thing here. > > That's the thing about specs -- interpretation.

Re: [Qemu-devel] [PULL 0/1] Coverity model patches for 2018-07-05

2018-07-05 Thread Peter Maydell
On 5 July 2018 at 14:14, Markus Armbruster wrote: > The following changes since commit 4fd1cbaf146d4ab35f465bba0fe23115c33cd5a7: > > Merge remote-tracking branch > 'remotes/armbru/tags/pull-monitor-2018-07-03-v2' into staging (2018-07-05 > 11:25:14 +0100) > > are available in the Git

Re: [Qemu-devel] [RFC v2] arm: Add NRF51 SOC non-volatile memory controller

2018-07-05 Thread Peter Maydell
On 5 July 2018 at 18:14, Steffen Görtz wrote: > I would like to provide all four devices (NVMC, CODE, FICR, UICR) from > one module and rename nrf51_nvmc.[ch] to nrf51_nvm.[ch]. Is this > acceptable or would you rather prefer three modules? Yeah, that would be ok too. thanks -- PMM

Re: [Qemu-devel] [RFC 5/8] arm: Add NRF51 random number generator peripheral

2018-07-05 Thread Steffen Görtz
Hi Peter, > Hi -- a couple of general notes about device modelling > which might apply to other devices in this series as well: > >> +static void nrf51_rng_class_init(ObjectClass *klass, void *data) >> +{ >> +DeviceClass *dc = DEVICE_CLASS(klass); >> + >> +dc->props =

Re: [Qemu-devel] Byte ordering of VM Generation ID in Windows VMs

2018-07-05 Thread Laszlo Ersek
On 07/05/18 18:43, Richard W.M. Jones wrote: > On Thu, Jul 05, 2018 at 04:20:33PM +0200, Laszlo Ersek wrote: >> QEMU does the right thing. If other hypervisors don't do this -- while >> still taking and displaying the value in UUID / GUID textual format --, >> they are wrong. The VMGENID spec from

Re: [Qemu-devel] [RFC v2] arm: Add NRF51 SOC non-volatile memory controller

2018-07-05 Thread Steffen Görtz
Hello Peter, thank you for your very elaborate remarks! > [ CPU ] -+- [ NVM, either FICR, UICR or CODE ] > | | > \- [ NVMC ] > > where the CPU can talk to either the NVMC or the NVMs, and the > NVMC also has a control connection to the NVM. (See the block > diagram in

Re: [Qemu-devel] Byte ordering of VM Generation ID in Windows VMs

2018-07-05 Thread Daniel P . Berrangé
On Thu, Jul 05, 2018 at 05:43:43PM +0100, Richard W.M. Jones wrote: > On Thu, Jul 05, 2018 at 04:20:33PM +0200, Laszlo Ersek wrote: > > QEMU does the right thing. If other hypervisors don't do this -- while > > still taking and displaying the value in UUID / GUID textual format --, > > they are

Re: [Qemu-devel] Byte ordering of VM Generation ID in Windows VMs

2018-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2018 at 05:43:43PM +0100, Richard W.M. Jones wrote: > On Thu, Jul 05, 2018 at 04:20:33PM +0200, Laszlo Ersek wrote: > > QEMU does the right thing. If other hypervisors don't do this -- while > > still taking and displaying the value in UUID / GUID textual format --, > > they are

Re: [Qemu-devel] [PATCH 2/2] cli qmp: Mark --preconfig, exit-preconfig experimental

2018-07-05 Thread Eric Blake
On 07/05/2018 04:14 AM, Markus Armbruster wrote: Committing to the current --preconfig / exit-preconfig interface before it has seen any use is premature. Mark both as experimental, the former in documentation, the latter by renaming it to x-exit-preconfig. See the previous commit for more

Re: [Qemu-devel] [PATCH v3 1/1] s390x/storage attributes: fix CMMA_BLOCK_SIZE usage

2018-07-05 Thread Cornelia Huck
On Thu, 5 Jul 2018 12:39:30 +0200 Claudio Imbrenda wrote: > The macro CMMA_BLOCK_SIZE was defined but not used, and a hardcoded > value was instead used in the code. > > This patch fixes the value of CMMA_BLOCK_SIZE and uses it in the > appropriate place in the code, and fixes another case of

Re: [Qemu-devel] [RFC 5/8] arm: Add NRF51 random number generator peripheral

2018-07-05 Thread Peter Maydell
On 27 June 2018 at 08:33, Steffen Görtz wrote: > Add a model of the NRF51 random number generator peripheral. > > Changes since v2: > - Add missing 'qapi/error.h' for error_abort > > Changes since v1: > - Add implementation access size hints to MemoryRegionOps > - Fail on error if

Re: [Qemu-devel] [RFC v2] arm: Add NRF51 SOC non-volatile memory controller

2018-07-05 Thread Peter Maydell
On 3 July 2018 at 10:31, Stefan Hajnoczi wrote: > On Mon, Jul 02, 2018 at 01:18:35PM +0100, Peter Maydell wrote: >> It's not clear to me what this device is doing with its >> AddressSpace, though; comments that went into more detail >> about what the device is and what the "memory" property is >>

  1   2   3   4   >