Re: [Qemu-devel] [PATCH 2/7 V10] memory, exec: switch file ram allocation functions to 'flags' parameters

OK, I wil chang all flags to 32bits It is a little strange that the compiler give no warning when losing precision. -Original Message- From: Richard Henderson [mailto:richard.hender...@linaro.org] Sent: Wednesday, July 18, 2018 12:03 AM To: junyan...@gmx.com; qemu-devel@nongnu.org Cc:

Re: [Qemu-devel] [PATCH for-3.0] target/arm: Correctly handle overlapping small MPU regions

On 07/17/2018 12:40 PM, Peter Maydell wrote: > On 17 July 2018 at 18:29, Richard Henderson > wrote: >> I don't understand why this is necessary in the v8m case. >> >>AP APL >> >> >> >> Your comment posits two regions

Re: [Qemu-devel] hw/display/sm501* status

On Mon, Jul 16, 2018 at 09:43:05PM +0100, Peter Maydell wrote: > On 16 July 2018 at 21:26, BALATON Zoltan wrote: > > I could list sm501 in the sam460ex section thus formally taking > > sub-maintainership but this would only go as far that I'll get cc-d on > > changes and try to review them. I

Re: [Qemu-devel] [PATCH] target/ppc: bcdsub fix sign when result is zero

On Mon, Jul 16, 2018 at 07:03:12PM +, Yasmin Beatriz wrote: > When the result of bcdsub is equal to zero, the result sign may be > set to negative in some cases, and this does not follow the Power ISA > specifications as to decimal integer arithmetic instructions. > > Signed-off-by: Yasmin

Re: [Qemu-devel] [PATCH 1/1] hw/misc/macio: Fix device introspection problems in macio devices

On Tue, Jul 17, 2018 at 04:51:54PM +0200, Thomas Huth wrote: 11;rgb://> Valgrind reports an error when introspecting the macio devices, e.g.: > > echo "{'execute':'qmp_capabilities'} {'execute':'device-list-properties'," \ > "'arguments':{'typename':'macio-newworld'}}" \ >

Re: [Qemu-devel] Native Memory Virtualization in qemu-system-aarch64

I am indeed attempting to implement a non-standard extension to the ARMv8 architecture for experimental purposes. My high-level goal for the extension is to completely isolate *N* execution environments (for example, I even prohibit inter-environment communication) using purely HW-based isolation

Re: [Qemu-devel] [PATCH for-3.0] i386: Rename enum CacheType members

On 07/17/2018 04:40 PM, Eduardo Habkost wrote: > Rename DCACHE to DATA_CACHE and ICACHE to INSTRUCTION_CACHE. Effective, thanks. > This avoids conflict with Linux asm/cachectl.h macros and fixes > build failure on mips hosts. > > Reported-by: Philippe Mathieu-Daudé > Signed-off-by: Eduardo

[Qemu-devel] [PATCH for-3.1] qemu-iotests: Adapt to moved location of StringIO module in py3

Since 356dc290f the Fedora image default to Python3. This fixes: $ make docker-test-block@fedora [...] 045 [failed, exit status 1] - output mismatch (see 045.out.bad) --- /tmp/qemu-test/src/tests/qemu-iotests/045.out 2018-07-17 16:56:18.0 + +++

[Qemu-devel] qemu-iotests: workaround to avoid Python3 while running tests on Fedora Docker image

I noticed this while running "make docker-test-block@fedora": $ make docker-test-block@fedora NETWORK=1 BUILD fedora RUN test-block in qemu:fedora Configure options: --enable-werror --prefix=/tmp/qemu-test/install --python=/usr/bin/python3 --target-list=x86_64-softmmu ... python

[Qemu-devel] [RFC PATCH 3/3] vfio: Inhibit ballooning

For all directly assigned devices and potentially some mdev devices, internal management of pinned pages is incompatible with ballooning. In the case of mdev devices, QEMU cannot know which pages the vendor driver has mapped for the device. It could be only the working set, which should never be

[Qemu-devel] [RFC PATCH 2/3] kvm: Use inhibit to prevent ballooning without synchronous mmu

Remove KVM specific tests in balloon_page(), instead marking ballooning as inhibited without KVM_CAP_SYNC_MMU support. Signed-off-by: Alex Williamson --- accel/kvm/kvm-all.c|4 hw/virtio/virtio-balloon.c |4 +--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [RFC PATCH 0/3] Balloon inhibit enhancements

Directly assigned vfio devices have never been compatible with ballooning. Zapping MADV_DONTNEED pages happens completely independent of vfio page pinning and IOMMU mapping, leaving us with inconsistent GPA to HPA mapping between vCPUs and assigned devices when the balloon deflates. Mediated

[Qemu-devel] [RFC PATCH 1/3] balloon: Allow nested inhibits

A simple true/false internal state does not allow multiple users. Fix this within the existing interface by converting to a counter, so long as the counter is elevated, ballooning is inhibited. Signed-off-by: Alex Williamson --- balloon.c |7 --- 1 file changed, 4 insertions(+), 3

[Qemu-devel] [PATCH] target/riscv/pmp.c: Fix PMP NAPOT decoding bug

According to the RISC-V priv. v1.10 ISA document, pmpaddr register stores (base_addr | (size/2 - 1)) >> 2 for a NAPOT-encoded address. However, the current code decodes (base_addr | (size - 1)) >> 3 which leads to a wrong base address and size. Signed-off-by: Dayeol Lee Reviewed-by: Alistair

[Qemu-devel] [PATCH] target/riscv/pmp.c: Fix PMP range boundary address bug

A wrong address is passed to `pmp_is_in_range` while checking if a memory access is within a PMP range. Since the ending address of the pmp range (i.e., pmp_state.addr[i].ea) is set to the last address in the range (i.e., pmp base + pmp size - 1), memory accesses containg the last address in the

Re: [Qemu-devel] [Qemu-ppc] Profiling results

On 17 July 2018 at 21:46, BALATON Zoltan wrote: > On Tue, 17 Jul 2018, Mark Cave-Ayland wrote: >> Good question. A quick grep for 'asidx_from_attrs' shows that >> cc->asidx_from_attrs() isn't set for PPC targets, so as a quick test does >> replacing the inline function cpu_asidx_from_attrs() in

Re: [Qemu-devel] [PATCH] headers: fix linux/mod_devicetable.h inclusions

On Mon, Jul 9, 2018 at 6:19 PM, Arnd Bergmann wrote: > A couple of drivers produced build errors after the mod_devicetable.h > header was split out from the platform_device one, e.g. > > drivers/media/platform/davinci/vpbe_osd.c:42:40: error: array type has > incomplete element type 'struct

Re: [Qemu-devel] [PATCH v1 2/5] sifive_u: Fix crash when introspecting the device

On Wed, Jul 18, 2018 at 8:28 AM, Alistair Francis wrote: > Use the new object_initialize_child() and sysbus_init_child_obj() to > fix the issue. > > Signed-off-by: Alistair Francis > Reviewed-by: Michael Clark > --- > hw/riscv/sifive_u.c | 15 +++ > 1 file changed, 7

Re: [Qemu-devel] [PATCH v1 5/5] spike: Fix crash when introspecting the device

On Wed, Jul 18, 2018 at 8:28 AM, Alistair Francis wrote: > Use the new object_initialize_child() and sysbus_init_child_obj() to > fix the issue. > > Signed-off-by: Alistair Francis > Reviewed-by: Michael Clark > --- > hw/riscv/spike.c | 10 -- > 1 file changed, 4 insertions(+), 6

Re: [Qemu-devel] [PATCH v1 4/5] riscv_hart: Fix crash when introspecting the device

On Wed, Jul 18, 2018 at 8:28 AM, Alistair Francis wrote: > Use the new object_initialize_child() and sysbus_init_child_obj() to > fix the issue. > > Signed-off-by: Alistair Francis > Reviewed-by: Michael Clark > --- > hw/riscv/riscv_hart.c | 7 +++ > 1 file changed, 3 insertions(+), 4

Re: [Qemu-devel] [PATCH v1 3/5] virt: Fix crash when introspecting the device

On Wed, Jul 18, 2018 at 8:28 AM, Alistair Francis wrote: > Use the new object_initialize_child() and sysbus_init_child_obj() to > fix the issue. > > Signed-off-by: Alistair Francis > Reviewed-by: Michael Clark > --- > hw/riscv/virt.c | 5 ++--- > 1 file changed, 2 insertions(+), 3

Re: [Qemu-devel] [PATCH v1 1/5] sifive_e: Fix crash when introspecting the device

On Wed, Jul 18, 2018 at 8:27 AM, Alistair Francis wrote: > Use the new object_initialize_child() and sysbus_init_child_obj() to > fix the issue. > > Signed-off-by: Alistair Francis > Reviewed-by: Michael Clark > --- > hw/riscv/sifive_e.c | 12 ++-- > 1 file changed, 6

Re: [Qemu-devel] [BUG?] aio_get_linux_aio: Assertion `ctx->linux_aio' failed

On 17.07.2018 [13:25:53 -0400], Farhan Ali wrote: > Hi, > > I am seeing some strange QEMU assertion failures for qemu on s390x, > which prevents a guest from starting. > > Git bisecting points to the following commit as the source of the error. > > commit

Re: [Qemu-devel] [Qemu-ppc] Profiling results

On Tue, 17 Jul 2018, Mark Cave-Ayland wrote: On 17/07/18 20:35, BALATON Zoltan wrote: On Tue, 17 Jul 2018, Mark Cave-Ayland wrote: MorphOS on mac99 this seems to be significant. This is with default configure (--enable-qom-cast-debug): %?? cum. % linenr info symbol

Re: [Qemu-devel] [qemu-s390x] [RFC 14/15] s390-bios: Support booting from real dasd device

On 05.07.2018 19:25, Jason J. Herne wrote: > From: "Jason J. Herne" > > Allows guest to boot from a vfio configured real dasd device. > > Signed-off-by: Jason J. Herne > Signed-off-by: Jason J. Herne > --- > docs/devel/s390-dasd-ipl.txt | 132 +++ >

Re: [Qemu-devel] [PATCH v2 for 3.0 00/16] various docker fixes

On 07/17/2018 03:53 PM, Alex Bennée wrote: > Philippe Mathieu-Daudé writes: >> On 07/13/2018 09:17 AM, Alex Bennée wrote: >>> Hi, >>> >>> Unfortunately this series grew a little while I was re-basing as I >>> noticed a couple of bugs. An upstream change in debootstrap which I'd >>> been happily

[Qemu-devel] [PATCH v1 5/5] spike: Fix crash when introspecting the device

Use the new object_initialize_child() and sysbus_init_child_obj() to fix the issue. Signed-off-by: Alistair Francis --- hw/riscv/spike.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/riscv/spike.c b/hw/riscv/spike.c index f94e2b6707..c8c056c50b 100644 ---

[Qemu-devel] [PATCH v1 2/5] sifive_u: Fix crash when introspecting the device

Use the new object_initialize_child() and sysbus_init_child_obj() to fix the issue. Signed-off-by: Alistair Francis --- hw/riscv/sifive_u.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c index 3a6ffeb437..59ae1ce24a

[Qemu-devel] [PATCH v1 4/5] riscv_hart: Fix crash when introspecting the device

Use the new object_initialize_child() and sysbus_init_child_obj() to fix the issue. Signed-off-by: Alistair Francis --- hw/riscv/riscv_hart.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/riscv/riscv_hart.c b/hw/riscv/riscv_hart.c index 75ba7ed579..e34a26a0ef

[Qemu-devel] [PATCH v1 3/5] virt: Fix crash when introspecting the device

Use the new object_initialize_child() and sysbus_init_child_obj() to fix the issue. Signed-off-by: Alistair Francis --- hw/riscv/virt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index aeada2498d..248bbdffd3 100644 ---

[Qemu-devel] [PATCH v1 1/5] sifive_e: Fix crash when introspecting the device

Use the new object_initialize_child() and sysbus_init_child_obj() to fix the issue. Signed-off-by: Alistair Francis --- hw/riscv/sifive_e.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/riscv/sifive_e.c b/hw/riscv/sifive_e.c index 8a8dbe1c00..4577d72037

[Qemu-devel] [PATCH v1 0/5] riscv: Fix introspection problems

This is based on Thomas's work fixing introspection problems [1] and applied to the RISC-V port. 1: https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03261.html Alistair Francis (5): sifive_e: Fix crash when introspecting the device sifive_u: Fix crash when introspecting the device

Re: [Qemu-devel] [PATCH 01/25] configure: We don't want to clean configuration files

Peter Maydell wrote: > On 17 July 2018 at 18:27, Juan Quintela wrote: >> On the other hand, sometimes it looks like I am the only user that use >> this. The original reason for this was to be able to compile out >> drivers that downstream don't care about. There were a couple of >> intents to

[Qemu-devel] [PATCH v3 for 3.0 13/18] docker: add --hint to docker.py check

When a check fails we currently just report why we failed. This is not totally helpful to people who want to boot-strap a new image. Add a --hint option which we can pass down to give a bit more information. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe

[Qemu-devel] [PATCH v3 for 3.0 14/18] docker: Update debootstrap script after Debian migration from Alioth to Salsa

From: Philippe Mathieu-Daudé This silents the following warning: Cloning into './debootstrap.git'... warning: redirecting to https://salsa.debian.org/installer-team/debootstrap.git/ See https://lists.debian.org/debian-devel-announce/2018/01/msg4.html Signed-off-by: Philippe

[Qemu-devel] [PATCH v3 for 3.0 16/18] docker: ignore distro versioning of debootstrap

We do a minimum version check for the debootstrap but if the distro has added their own minor version tick it would fail and fall-back to the SCM version. This is sub-optimal as the latest/greatest version may be broken at any one particular time. We fix that with a little sed magic on the version

[Qemu-devel] [PATCH v3 for 3.0 15/18] docker: add commentary to debian-bootstrap.docker

This is just a note that later versions of debootstrap don't technically need this hack. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/debian-bootstrap.docker | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Qemu-devel] [Qemu-ppc] Profiling results

On 17/07/18 20:35, BALATON Zoltan wrote: On Tue, 17 Jul 2018, Mark Cave-Ayland wrote: MorphOS on mac99 this seems to be significant. This is with default configure (--enable-qom-cast-debug): %?? cum. % linenr info symbol name 9.7057?? 9.7057???

Re: [Qemu-devel] Why do we typedef every struct on QEMU?

On 17 July 2018 at 20:50, Eduardo Habkost wrote: > I have been looking at patches that touch typedefs.h and > wondering: why do we make typedefs.h necessary at all? Why do we > always add typedefs for every struct and union type in QEMU? > > Why do we prefer to write this: > > -

[Qemu-devel] [PATCH v3 for 3.0 12/18] docker: drop QEMU_TARGET check, fallback in EXECUTABLE not set

The addition of QEMU_TARGET was intended to ensure we fall back to checking for the existence of an image if the build system was not currently configured to build it. However this breaks the direct use of the rule for building custom binfmt_misc images. We already check for EXECUTABLE so let us

[Qemu-devel] [PATCH v3 for 3.0 17/18] docker: perform basic binfmt_misc validation in docker.py

Setting up binfmt_misc is outside of the scope of the docker.py script but we can at least validate it with any given executable so we have a more useful error message than the sed line of deboostrap failing cryptically. Signed-off-by: Alex Bennée Reported-by: Richard Henderson ---

[Qemu-devel] [PATCH v3 for 3.0 07/18] docker: gracefully skip check_qemu

Not all our images are able to run the tests. Rather than use features we can just check for the existence and run-ability of gtester. If the image has been setup for binfmt_misc it will be able to run anyway. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe

[Qemu-devel] [PATCH v3 for 3.0 18/18] tests/tcg: remove runcom test

The combination of being rather esoteric and needing to support mmap @ 0 means this only ever worked under translation. It has now regressed even further and is no longer useful. Kill it. Signed-off-by: Alex Bennée --- tests/tcg/i386/Makefile.target | 5 - tests/tcg/i386/README | 3

[Qemu-devel] [PATCH v3 for 3.0 04/18] docker: fail more gracefully on docker.py check

As this is called directly from the Makefile while determining dependencies and it is possible the user was configured in one window but not have credentials in the other. Let's catch the Exceptions and deal with it quietly. Signed-off-by: Alex Bennée Reported-by: Peter Maydell Reviewed-by:

[Qemu-devel] [PATCH v3 for 3.0 09/18] docker: disable debian-powerpc-user-cross

While we can build we can't run the unit tests due to a missing system call (249 - swapcontext). This could be a code generation issue as other architectures don't seem to have this system call. Signed-off-by: Alex Bennée Tested-by: Philippe Mathieu-Daudé Cc: David Gibson Cc: Alexander Graf

[Qemu-devel] [PATCH v3 for 3.0 03/18] docker: par down QEMU_CONFIGURE_OPTS in debian-tricore-cross

This image isn't going to build anything significant as it is just intended for building test cases. In case it does end up getting inadvertently included in a build lets aim for the minimal possible product. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé ---

[Qemu-devel] [PATCH v3 for 3.0 10/18] docker: add test-unit runner

This test doesn't even build QEMU, it just builds and runs all the unit tests. Intended to make checking unit tests on all docker images easier. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- v2 - make script -e to error out on failure

[Qemu-devel] [PATCH v3 for 3.0 00/18] docker fixes (and one tcg test tweak)

Hi, I've missed the boat for today's rc1 but I'd like to get this merged before rc2. The new docker.py change is technically new functionality but I'm counting it as a usability bug fix as it replaces a random back trace failure with a preemptive failure and message mentioning binfmt_misc

[Qemu-devel] [PATCH v3 for 3.0 11/18] docker: add expansion for docker-test-FOO to Makefile.include

This allows us to run a particular test on all docker images. For example: make docker-test-unit Will run the unit tests on every supported image. At the same time rename docker-test to docker-all-tests to be clearer. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by:

[Qemu-devel] [PATCH v3 for 3.0 06/18] docker: move make check into check_qemu helper

Not all docker images can run the check step. Let's move everything into a common helper so we don't need to replicate checks in the future. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- v2 - add "move" to Let's everything in commit

[Qemu-devel] [PATCH v3 for 3.0 01/18] tests/.gitignore: don't ignore docker tests

The .gitignore was being a little over enthusiastic hiding files. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- v2 - minor wording tweak for more explicitness --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore

[Qemu-devel] [PATCH v3 for 3.0 02/18] docker: base debian-tricore on qemu:debian9

We need both git and a working compiler to build the tools. Although the qemu:debian9 image also has a bunch of extra dependencies it would be fairly unusual for a user not to already have this layer available for one of our many other docker images so lets not complicate things. Signed-off-by:

[Qemu-devel] [PATCH v3 for 3.0 05/18] docker: split configure_qemu from build_qemu

This allows some tests that just want to configure QEMU's source tree to do so. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- tests/docker/common.rc | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v3 for 3.0 08/18] docker: Makefile.include don't include partial images

Rename DOCKER_INTERMEDIATE_IMAGES to DOCKER_PARTIAL_IMAGES and add the incomplete cross compiler images that can build tests but can't build QEMU itself. We also add debian, debian-bootstrap and the tricode images to the list. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé

[Qemu-devel] Why do we typedef every struct on QEMU?

I have been looking at patches that touch typedefs.h and wondering: why do we make typedefs.h necessary at all? Why do we always add typedefs for every struct and union type in QEMU? Why do we prefer to write this: - qemu/typedefs.h: typedef struct SomeType SomeType; --

[Qemu-devel] [ANNOUNCE] QEMU 3.0.0-rc1 is now available

Hello, On behalf of the QEMU Team, I'd like to announce the availability of the second release candidate for the QEMU 3.0 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-3.0.0-rc1.tar.xz

Re: [Qemu-devel] [PATCH for-3.0] target/arm: Correctly handle overlapping small MPU regions

On 17 July 2018 at 18:29, Richard Henderson wrote: > I don't understand why this is necessary in the v8m case. > >AP APL > > > > Your comment posits two regions [B1,L1] and [B2,L2], that A is not within > [B1,L1] but is

Re: [Qemu-devel] [PATCH] hw/microblaze/xlnx-zynqmp-pmu: Fix introspection problem in 'xlnx, zynqmp-pmu-soc'

On 17 July 2018 at 18:37, Edgar E. Iglesias wrote: > On Tue, Jul 17, 2018 at 04:55:43PM +0200, Thomas Huth wrote: >> Valgrind complains: >> >> echo "{'execute':'qmp_capabilities'} {'execute':'device-list-properties'," \ >> "'arguments':{'typename':'xlnx,zynqmp-pmu-soc'}}" \ >> "{'execute':

[Qemu-devel] [PATCH for-3.0] i386: Rename enum CacheType members

Rename DCACHE to DATA_CACHE and ICACHE to INSTRUCTION_CACHE. This avoids conflict with Linux asm/cachectl.h macros and fixes build failure on mips hosts. Reported-by: Philippe Mathieu-Daudé Signed-off-by: Eduardo Habkost --- target/i386/cpu.h | 4 +- target/i386/cpu.c | 128

Re: [Qemu-devel] [Qemu-ppc] Profiling results

On Tue, 17 Jul 2018, Mark Cave-Ayland wrote: MorphOS on mac99 this seems to be significant. This is with default configure (--enable-qom-cast-debug): %?? cum. % linenr info symbol name 9.7057?? 9.7057??? exec-all.h:410? helper_lookup_tb_ptr 8.0330?

Re: [Qemu-devel] [PATCH 01/25] configure: We don't want to clean configuration files

On 17 July 2018 at 18:27, Juan Quintela wrote: > On the other hand, sometimes it looks like I am the only user that use > this. The original reason for this was to be able to compile out > drivers that downstream don't care about. There were a couple of > intents to integrate with something

Re: [Qemu-devel] [PATCH 3/6] bloc/qcow2: drop dirty_bitmaps_loaded state variable

On 07/10/2018 03:43 AM, Vladimir Sementsov-Ogievskiy wrote: > 10.07.2018 02:25, John Snow wrote: >> >> On 06/26/2018 09:50 AM, Vladimir Sementsov-Ogievskiy wrote: >>> This variable doesn't work as it should, because it is actually cleared >>> in qcow2_co_invalidate_cache() by memset(). Drop it,

Re: [Qemu-devel] [PATCH v2 for 3.0 00/16] various docker fixes

Philippe Mathieu-Daudé writes: > On 07/13/2018 09:17 AM, Alex Bennée wrote: >> Hi, >> >> Unfortunately this series grew a little while I was re-basing as I >> noticed a couple of bugs. An upstream change in debootstrap which I'd >> been happily using for Ubuntu images caused a breakage which

Re: [Qemu-devel] [PATCH v2 for-2.11.2] spapr: make pseries-2.11 the default machine type

* Michael Roth (mdr...@linux.vnet.ibm.com) wrote: > Quoting David Gibson (2018-07-17 05:50:06) > > On Thu, Jun 21, 2018 at 03:23:21PM +0200, Greg Kurz wrote: > > > On Thu, 21 Jun 2018 11:18:09 +1000 > > > David Gibson wrote: > > > > > > > On Wed, Jun 20, 2018 at 02:54:15PM +0200, Greg Kurz

Re: [Qemu-devel] [qemu-s390x] [RFC 12/15] s390-bios: Use control unit type to determine boot method

On 05.07.2018 19:25, Jason J. Herne wrote: > From: "Jason J. Herne" > > The boot method is different depending on which device type we are > booting from. Let's examine the control unit type to determine if we're > a virtio device. We'll eventually add a case to check for a real dasd device >

Re: [Qemu-devel] [qemu-s390x] [RFC 06/15] s390-bios: Clean up cio.h

On 07/17/2018 11:15 AM, Thomas Huth wrote: >> -__u32 isc:3; >> -__u32 ena:1; >> -__u32 mme:2; >> -__u32 mp:1; >> -__u32 csense:1; >> -__u32 mbfc:1; >> +__u32 isc: 3; >> +__u32 ena: 1; >> +__u32 mme: 2; >> +__u32 mp : 1; >> +__u32 csense :

Re: [Qemu-devel] [qemu-s390x] [RFC 06/15] s390-bios: Clean up cio.h

On 05.07.2018 19:25, Jason J. Herne wrote: > From: "Jason J. Herne" > > Add proper typedefs to all structs and modify all bit fields to use consistent > formatting. > > Signed-off-by: Jason J. Herne > Reviewed-by: Collin Walling > Signed-off-by: Jason J. Herne > --- > pc-bios/s390-ccw/cio.h

Re: [Qemu-devel] [qemu-s390x] [RFC 08/15] s390-bios: Map low core memory

On 05.07.2018 19:25, Jason J. Herne wrote: > From: "Jason J. Herne" > > Create a new header for basic architecture specific definitions and add a > mapping of low core memory. This mapping will be used by the real dasd boot > process. > > Signed-off-by: Jason J. Herne > Signed-off-by: Jason J.

Re: [Qemu-devel] [PATCH] hw/microblaze/xlnx-zynqmp-pmu: Fix introspection problem in 'xlnx, zynqmp-pmu-soc'

On Tue, Jul 17, 2018 at 04:55:43PM +0200, Thomas Huth wrote: > Valgrind complains: > > echo "{'execute':'qmp_capabilities'} {'execute':'device-list-properties'," \ > "'arguments':{'typename':'xlnx,zynqmp-pmu-soc'}}" \ > "{'execute': 'human-monitor-command', " \ > "'arguments': {'command-line':

Re: [Qemu-devel] [PATCH for-3.0] target/arm: Correctly handle overlapping small MPU regions

On 07/16/2018 06:33 AM, Peter Maydell wrote: > @@ -9963,6 +9994,21 @@ static bool pmsav8_mpu_lookup(CPUARMState *env, > uint32_t address, > } > > if (address < base || address > limit) {> +/*> + > * Address not in this region. We must

Re: [Qemu-devel] [PATCH 01/25] configure: We don't want to clean configuration files

Peter Maydell wrote: > On 17 July 2018 at 18:05, Juan Quintela wrote: >> Daniel P. Berrangé wrote: >>> On Tue, Jul 17, 2018 at 01:33:38PM +0200, Juan Quintela wrote: If you don't want to compile everything, you configure config-devices.mak. And then make clean remove it, and make

[Qemu-devel] [BUG?] aio_get_linux_aio: Assertion `ctx->linux_aio' failed

Hi, I am seeing some strange QEMU assertion failures for qemu on s390x, which prevents a guest from starting. Git bisecting points to the following commit as the source of the error. commit ed6e2161715c527330f936d44af4c547f25f687e Author: Nishanth Aravamudan Date: Fri Jun 22 12:37:00 2018

Re: [Qemu-devel] [PATCH 09/14] check: Only test virtio-balloon when it is compiled in

Cornelia Huck wrote: > On Tue, 17 Jul 2018 14:04:09 +0200 > Juan Quintela wrote: > >> Signed-off-by: Juan Quintela >> --- >> hw/virtio/virtio-pci.c | 5 - >> tests/Makefile.include | 6 +++--- >> 2 files changed, 7 insertions(+), 4 deletions(-) >> >> diff --git a/hw/virtio/virtio-pci.c

Re: [Qemu-devel] [PATCH 01/25] configure: We don't want to clean configuration files

On 17 July 2018 at 18:05, Juan Quintela wrote: > Daniel P. Berrangé wrote: >> On Tue, Jul 17, 2018 at 01:33:38PM +0200, Juan Quintela wrote: >>> If you don't want to compile everything, you configure >>> config-devices.mak. And then make clean remove it, and make will >>> create a default one

Re: [Qemu-devel] [PULL RESEND] Misc fixes for QEMU 3.0.0-rc1

On 17 July 2018 at 16:32, Paolo Bonzini wrote: > The following changes since commit 9277d81f5c2c6f4d0b5e47c8476eb7ee7e5c0beb: > > docs: Grammar and spelling fixes (2018-07-13 10:16:04 +0100) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git tags/for-upstream >

Re: [Qemu-devel] [Qemu-ppc] Profiling results

On 17/07/18 16:09, BALATON Zoltan wrote: On Mon, 16 Jul 2018, Peter Maydell wrote: Is this coming up as significant in profiling? In the past we've This seems to depend on the workload. From the cases I'm interested in AROS and AmigaOS on qemu-system-ppc -M sam460ex does not seem to be

Re: [Qemu-devel] [PATCH 20/25] check: Only test usb-xhci-nec when it is compiled in

Thomas Huth wrote: > On 17.07.2018 13:33, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> tests/Makefile.include | 8 >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/tests/Makefile.include b/tests/Makefile.include >> index b3e707e8c3..ccf71bddcc

Re: [Qemu-devel] [PATCH 01/25] configure: We don't want to clean configuration files

Daniel P. Berrangé wrote: > On Tue, Jul 17, 2018 at 01:33:38PM +0200, Juan Quintela wrote: >> If you don't want to compile everything, you configure >> config-devices.mak. And then make clean remove it, and make will >> create a default one without your configuration. Fix it by not >> removing

Re: [Qemu-devel] [PATCH v2 for-2.11.2] spapr: make pseries-2.11 the default machine type

Quoting David Gibson (2018-07-17 05:50:06) > On Thu, Jun 21, 2018 at 03:23:21PM +0200, Greg Kurz wrote: > > On Thu, 21 Jun 2018 11:18:09 +1000 > > David Gibson wrote: > > > > > On Wed, Jun 20, 2018 at 02:54:15PM +0200, Greg Kurz wrote: > > > > The spapr capability framework was introduced in

Re: [Qemu-devel] [RFC 00/14] More patches to disable stuff

Paolo Bonzini wrote: > On 17/07/2018 14:04, Juan Quintela wrote: >> Hi >> >> Notice that this is an RFC because they don't work. As said on my >> previous submmision, we need -softmmu/config-devices.h to make >> this work. This series just allow us to disable the devices, but not >> to enable

Re: [Qemu-devel] [RFC 00/14] More patches to disable stuff

Thomas Huth wrote: > On 17.07.2018 14:04, Juan Quintela wrote: >> Hi >> >> Notice that this is an RFC because they don't work. As said on my >> previous submmision, we need -softmmu/config-devices.h to make >> this work. This series just allow us to disable the devices, but not >> to enable it

Re: [Qemu-devel] [PATCH 5/7 V10] mem/nvdimm: ensure write persistence to PMEM in label emulation

On 07/16/2018 11:32 PM, junyan...@gmx.com wrote: > +++ b/stubs/pmem.c > @@ -0,0 +1,19 @@ > +/* > + * Stubs for libpmem. > + * > + * Copyright (c) 2018 Intel Corporation. > + * > + * Author: Haozhong Zhang > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or later. > + *

Re: [Qemu-devel] [RFC v3] arm: Add NRF51 random number generator peripheral

On 13 July 2018 at 16:40, Steffen Görtz wrote: > Add a model of the NRF51 random number generator peripheral. > > Signed-off-by: Steffen Görtz > --- > Changes since v3: > - Replace bitfields > - Add VMState / reset > - Add reference to reference manual > > Changes since v2: > - Add

Re: [Qemu-devel] [PATCH 4/7 V10] hostmem-file: add the 'pmem' option

On 07/16/2018 11:32 PM, junyan...@gmx.com wrote: > @@ -34,6 +35,7 @@ struct HostMemoryBackendFile { > bool discard_data; > char *mem_path; > uint64_t align; > +bool is_pmem; > }; Sort all the bool's to the end? > +/* Just support these ram flags by now. */ > +

Re: [Qemu-devel] [PATCH v5 13/13] target/arm: Send interrupts on PMU counter overflow

On 22 June 2018 at 21:32, Aaron Lindsay wrote: > Setup a QEMUTimer to get a callback when we expect counters to next > overflow and trigger an interrupt at that time. > > Signed-off-by: Aaron Lindsay > --- > target/arm/cpu.c| 11 + > target/arm/cpu.h| 7 +++ > target/arm/helper.c

Re: [Qemu-devel] [PATCH v5 08/13] target/arm: Finish implementation of PM[X]EVCNTR and PM[X]EVTYPER

On 22 June 2018 at 21:32, Aaron Lindsay wrote: > Add arrays to hold the registers, the definitions themselves, access > functions, and logic to reset counters when PMCR.P is set. Update > filtering code to support counters other than PMCCNTR. > > Signed-off-by: Aaron Lindsay > --- >

Re: [Qemu-devel] [PATCH v3] dump: add kernel_gs_base to QEMU CPU state

On 16/07/2018 23:16, Eduardo Habkost wrote: > On Sat, Jul 14, 2018 at 03:30:00PM +0300, Viktor Prutyanov wrote: >> This patch adds field with content of KERNEL_GS_BASE MSR to QEMU note in >> ELF dump. >> >> On Windows, if all vCPUs are running usermode tasks at the time the dump is >> created,

Re: [Qemu-devel] [PATCH v5 09/13] target/arm: PMU: Add instruction and cycle events

On 22 June 2018 at 21:32, Aaron Lindsay wrote: > The instruction event is only enabled when icount is used, cycles are > always supported. Always defining get_cycle_count (but altering its > behavior depending on CONFIG_USER_ONLY) allows us to remove some > CONFIG_USER_ONLY #defines throughout

Re: [Qemu-devel] [PATCH v5 07/13] target/arm: Add array for supported PMU events, generate PMCEID[01]

On 22 June 2018 at 21:32, Aaron Lindsay wrote: > This commit doesn't add any supported events, but provides the framework > for adding them. We store the pm_event structs in a simple array, and > provide the mapping from the event numbers to array indexes in the > supported_event_map array.

Re: [Qemu-devel] [PATCH 12/12] RFC: qmp: rework 'id' handling

Copying the guest agent maintainer Michael Roth. Patch needs a rebase. Marc-André Lureau writes: > Let qmp_dispatch() copy the 'id' field. That way any qmp client will > conform to the specification, including QGA. Before this patch, users of the common core shared by QMP and QGA have to do

Re: [Qemu-devel] [PATCH 3/7 V10] configure: add libpmem support

On 07/16/2018 11:32 PM, junyan...@gmx.com wrote: > From: Junyan He > > Add a pair of configure options --{enable,disable}-libpmem to control > whether QEMU is compiled with PMDK libpmem [1]. > > QEMU may write to the host persistent memory (e.g. in vNVDIMM label > emulation and live migration),

Re: [Qemu-devel] [PATCH 2/7 V10] memory, exec: switch file ram allocation functions to 'flags' parameters

On 07/16/2018 11:32 PM, junyan...@gmx.com wrote: > RAMBlock *qemu_ram_alloc_from_fd(ram_addr_t size, MemoryRegion *mr, > - bool share, int fd, > + uint64_t ram_flags, int fd, > Error **errp) > { >

Re: [Qemu-devel] [PATCH] qga-win: Handle fstrim for OSes lower than Win8

Quoting Daniel P. Berrangé (2018-07-17 04:34:18) > On Mon, Jul 16, 2018 at 03:10:38PM -0500, Michael Roth wrote: > > Quoting Sameeh Jubran (2018-06-24 07:45:40) > > > From: Sameeh Jubran > > > > > > The defrag.exe tool which is used for executing the fstrim command > > > on Windows doesn't

Re: [Qemu-devel] [PATCH v2 for 3.0 00/16] various docker fixes

On 07/13/2018 09:17 AM, Alex Bennée wrote: > Hi, > > Unfortunately this series grew a little while I was re-basing as I > noticed a couple of bugs. An upstream change in debootstrap which I'd > been happily using for Ubuntu images caused a breakage which I've > hopefully now fixed: > >

Re: [Qemu-devel] [PATCH 1/7 V10] memory, exec: Expose all memory block related flags.

On 07/16/2018 11:32 PM, junyan...@gmx.com wrote: > From: Junyan He > > We need to use these flags in other files rather than just in exec.c, > For example, RAM_SHARED should be used when create a ram block from file. > We expose them the exec/memory.h > > Signed-off-by: Junyan He >

Re: [Qemu-devel] [PATCH] hw/sd/bcm2835_sdhost: Fix PIO mode writes

On Mon, Jul 16, 2018 at 10:20:37PM -0300, Philippe Mathieu-Daudé wrote: > Cc'ing ANTField folks who might have the specs. > > On 07/16/2018 07:23 PM, Guenter Roeck wrote: > > Writes in PIO mode have two requirements: > > > > - A data interrupt must be generated after a write command has been > >

Re: [Qemu-devel] [PATCH] arm: Add ARMv6-M programmer's model support

On 17.07.2018 16:49, Peter Maydell wrote: On 17 July 2018 at 14:42, Julia Suvorova wrote: On 17.07.2018 16:09, Peter Maydell wrote: This should be outside the "if v8" if(), because you also want it for v6M (giving you the v6M CCR value of STKALIGN and UNALIGN_TRP set and all other bits

Re: [Qemu-devel] [PATCH v2 for 3.0 09/16] docker: disable debian-powerpc-user-cross

On 07/13/2018 09:17 AM, Alex Bennée wrote: > While we can build we can't run the unit tests due to a missing system > call (249 - swapcontext). This could be a code generation issue as > other architectures don't seem to have this system call. > > Signed-off-by: Alex Bennée Tested-by: Philippe

Re: [Qemu-devel] [PATCH v2 for 3.0 16/16] docker: ignore distro versioning of debootstrap

On 07/13/2018 09:17 AM, Alex Bennée wrote: > We do a minimum version check for the debootstrap but if the distro > has added their own minor version tick it would fail and fall-back to > the SCM version. This is sub-optimal as the latest/greatest version > may be broken at any one particular time.

Re: [Qemu-devel] [PATCH v2 for 3.0 12/16] docker: drop QEMU_TARGET check, fallback in EXECUTABLE not set

On 07/13/2018 09:17 AM, Alex Bennée wrote: > The addition of QEMU_TARGET was intended to ensure we fall back to > checking for the existence of an image if the build system was not > currently configured to build it. However this breaks the direct use > of the rule for building custom binfmt_misc

  1   2   3   >