Re: [Qemu-devel] [PATCH v5 23/24] replay: add BH oneshot event for block layer

2018-08-01 Thread Pavel Dovgalyuk
> -Original Message- > From: Alex Bennée [mailto:alex.ben...@linaro.org] > Sent: Friday, July 27, 2018 7:45 PM > To: Pavel Dovgalyuk > Cc: 'Pavel Dovgalyuk'; qemu-devel@nongnu.org; kw...@redhat.com; > peter.mayd...@linaro.org; > war2jor...@live.com; crosthwaite.pe...@gmail.com;

Re: [Qemu-devel] 'make vm-build-freebsd' don't work if KVM isn't enabled

2018-08-01 Thread Fam Zheng
On Mon, 07/30 16:20, Peter Maydell wrote: > On 30 July 2018 at 14:40, Peter Maydell wrote: > > On 30 July 2018 at 14:36, Peter Maydell wrote: > >> On 30 July 2018 at 14:23, Peter Maydell wrote: > >>> The tests in tests/vm/ seem to make some attempt to cope with the > >>> host system not

Re: [Qemu-devel] [PATCH v2 21/23] libqtest: Remove qtest_qmp_discard_response() & friends

2018-08-01 Thread Thomas Huth
On 08/02/2018 06:53 AM, Markus Armbruster wrote: > Thomas Huth writes: > >> On 07/30/2018 08:32 AM, Markus Armbruster wrote: >>> Eric Blake writes: >>> On 07/27/2018 11:46 AM, Thomas Huth wrote: > On 07/27/2018 05:13 PM, Markus Armbruster wrote: >> qtest_qmp_discard_response(...)

Re: [Qemu-devel] [RFC v3 0/6] pci_expander_brdige: Put pxb-pcie host bridge into separate pci domain

2018-08-01 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 1533177924-24765-1-git-send-email-whois.zihan.y...@gmail.com Subject: [Qemu-devel] [RFC

Re: [Qemu-devel] [RFC v3 0/6] pci_expander_brdige: Put pxb-pcie host bridge into separate pci domain

2018-08-01 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1533177924-24765-1-git-send-email-whois.zihan.y...@gmail.com Subject: [Qemu-devel] [RFC v3 0/6] pci_expander_brdige: Put pxb-pcie host bridge into separate pci domain ===

Re: [Qemu-devel] [PATCH v2 21/23] libqtest: Remove qtest_qmp_discard_response() & friends

2018-08-01 Thread Markus Armbruster
Thomas Huth writes: > On 07/30/2018 08:32 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 07/27/2018 11:46 AM, Thomas Huth wrote: On 07/27/2018 05:13 PM, Markus Armbruster wrote: > qtest_qmp_discard_response(...) is shorthand for > qobject_unref(qtest_qmp(...), except

Re: [Qemu-devel] microblaze build failure due to definition clash on riscv

2018-08-01 Thread Michael Clark
On Thu, Aug 2, 2018 at 3:57 PM, Philippe Mathieu-Daudé wrote: > Oops I just realized I forgot to Cc the QEMU list, doing it now. > > On 07/31/2018 07:40 AM, Edgar E. Iglesias wrote: > > On Mon, Jul 30, 2018 at 03:22:46PM -0300, Philippe Mathieu-Daudé wrote: > >> Hi, I'm getting this error while

Re: [Qemu-devel] microblaze build failure due to definition clash on riscv

2018-08-01 Thread Philippe Mathieu-Daudé
Oops I just realized I forgot to Cc the QEMU list, doing it now. On 07/31/2018 07:40 AM, Edgar E. Iglesias wrote: > On Mon, Jul 30, 2018 at 03:22:46PM -0300, Philippe Mathieu-Daudé wrote: >> Hi, I'm getting this error while building microblaze on riscv host: >> >> ... >> CC

Re: [Qemu-devel] [RFC v3 0/6] pci_expander_brdige: Put pxb-pcie host bridge into separate pci domain

2018-08-01 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 1533177743-20894-1-git-send-email-whois.zihan.y...@gmail.com Subject: [Qemu-devel] [RFC

Re: [Qemu-devel] [RFC v3 0/6] pci_expander_brdige: Put pxb-pcie host bridge into separate pci domain

2018-08-01 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1533177743-20894-1-git-send-email-whois.zihan.y...@gmail.com Subject: [Qemu-devel] [RFC v3 0/6] pci_expander_brdige: Put pxb-pcie host bridge into separate pci domain ===

[Qemu-devel] QEMU 3.0 RC3 mouse problem with Windows 3.1 and NT 4.0

2018-08-01 Thread Programmingkid
The mouse cursor stops working properly under Windows 3.1 and Windows NT 4.0 after a few minutes of use. The cursor will want to stay at the very edges of the QEMU window.

[Qemu-devel] [RFC v3 6/6] pci_expander_bridge: add start_bus property

2018-08-01 Thread Zihan Yang
The former bus_nr property indicates the bus number of pxb-pcie device on pcie.0 bus, not the Base Bus Number of pxb-pcie host bridge. Use start_bus property to represent this BBN when building acpi table Signed-off-by: Zihan Yang --- hw/i386/acpi-build.c| 22

[Qemu-devel] [RFC v3 4/6] pci_expander_bridge: Add config_read callback

2018-08-01 Thread Zihan Yang
This allows SeaBIOS to retrieve MCFG base and size when it initializes pxb host bridges. A backlink to PXBPCIEHost is added in PXBDev to achieve above goal Signed-off-by: Zihan Yang --- hw/pci-bridge/pci_expander_bridge.c | 55 +

[Qemu-devel] [RFC v3 2/6] acpi-build: allocate mcfg for pxb-pcie host bridges

2018-08-01 Thread Zihan Yang
Allocate new segment for pxb-pcie host bridges in MCFG table, and reserve corresponding MCFG space for them. This allows user-defined pxb-pcie host bridges to be placed in different pci domain than q35 host. The pci_host_bridges list is changed to be tail list to ensure the q35 host is always the

[Qemu-devel] [RFC v3 0/6] pci_expander_brdige: Put pxb-pcie host bridge into separate pci domain

2018-08-01 Thread Zihan Yang
(Forgot about the cc, repost it here) NOTE: This patch set relies on seabios change. Unfortunately, I haven't got it fully working in seabios, but I still post them here because patches involve some port layout change to be reviewed, and it has been a long delay since my last version. I'm trying

[Qemu-devel] [RFC v3 5/6] pci_expander_bridge: Add ioport for pxb host bus

2018-08-01 Thread Zihan Yang
This enables seabios to read config file in pxb host bus other than sysbus Signed-off-by: Zihan Yang --- hw/pci-bridge/pci_expander_bridge.c | 15 +++ include/hw/pci-bridge/pci_expander_bridge.h | 3 +++ 2 files changed, 18 insertions(+) diff --git

[Qemu-devel] [RFC v3 1/6] pci_expander_bridge: add type TYPE_PXB_PCIE_HOST

2018-08-01 Thread Zihan Yang
The inner host bridge created by pxb-pcie is TYPE_PXB_PCI_HOST by default, change it to a new type TYPE_PXB_PCIE_HOST to better utilize ECAM of PCIe Signed-off-by: Zihan Yang --- hw/pci-bridge/pci_expander_bridge.c | 127 ++-- 1 file changed, 122 insertions(+), 5

[Qemu-devel] [RFC v3 6/6] pci_expander_bridge: add start_bus property

2018-08-01 Thread Zihan Yang
The former bus_nr property indicates the bus number of pxb-pcie device on pcie.0 bus, not the Base Bus Number of pxb-pcie host bridge. Use start_bus property to represent this BBN when building acpi table Signed-off-by: Zihan Yang --- hw/i386/acpi-build.c| 22

[Qemu-devel] [RFC v3 1/6] pci_expander_bridge: add type TYPE_PXB_PCIE_HOST

2018-08-01 Thread Zihan Yang
The inner host bridge created by pxb-pcie is TYPE_PXB_PCI_HOST by default, change it to a new type TYPE_PXB_PCIE_HOST to better utilize ECAM of PCIe Signed-off-by: Zihan Yang --- hw/pci-bridge/pci_expander_bridge.c | 127 ++-- 1 file changed, 122 insertions(+), 5

[Qemu-devel] [RFC v3 5/6] pci_expander_bridge: Add ioport for pxb host bus

2018-08-01 Thread Zihan Yang
This enables seabios to read config file in pxb host bus other than sysbus Signed-off-by: Zihan Yang --- hw/pci-bridge/pci_expander_bridge.c | 15 +++ include/hw/pci-bridge/pci_expander_bridge.h | 3 +++ 2 files changed, 18 insertions(+) diff --git

[Qemu-devel] [RFC v3 4/6] pci_expander_bridge: Add config_read callback

2018-08-01 Thread Zihan Yang
This allows SeaBIOS to retrieve MCFG base and size when it initializes pxb host bridges. A backlink to PXBPCIEHost is added in PXBDev to achieve above goal Signed-off-by: Zihan Yang --- hw/pci-bridge/pci_expander_bridge.c | 55 +

[Qemu-devel] [RFC v3 3/6] i386/acpi-build: describe new pci domain in AML

2018-08-01 Thread Zihan Yang
Describe new pci segments of host bridges in AML as new pci devices, with _SEG and _BBN to let them be in DSDT Signed-off-by: Zihan Yang --- hw/i386/acpi-build.c | 78 +++- 1 file changed, 53 insertions(+), 25 deletions(-) diff --git

[Qemu-devel] [RFC v3 3/6] i386/acpi-build: describe new pci domain in AML

2018-08-01 Thread Zihan Yang
Describe new pci segments of host bridges in AML as new pci devices, with _SEG and _BBN to let them be in DSDT Signed-off-by: Zihan Yang --- hw/i386/acpi-build.c | 78 +++- 1 file changed, 53 insertions(+), 25 deletions(-) diff --git

[Qemu-devel] [RFC v3 0/6] pci_expander_brdige: Put pxb-pcie host bridge into separate pci domain

2018-08-01 Thread Zihan Yang
NOTE: This patch set relies on seabios change. Unfortunately, I haven't got it fully working in seabios, but I still post them here because patches involve some port layout change to be reviewed, and it has been a long delay since my last version. I'm trying to catch things up recently. If you

[Qemu-devel] [RFC v3 2/6] acpi-build: allocate mcfg for pxb-pcie host bridges

2018-08-01 Thread Zihan Yang
Allocate new segment for pxb-pcie host bridges in MCFG table, and reserve corresponding MCFG space for them. This allows user-defined pxb-pcie host bridges to be placed in different pci domain than q35 host. The pci_host_bridges list is changed to be tail list to ensure the q35 host is always the

Re: [Qemu-devel] [virtio-dev] Re: [v23 1/2] virtio-crypto: Add virtio crypto device specification

2018-08-01 Thread Longpeng (Mike)
Hi Halil, On 2018/8/2 4:21, Halil Pasic wrote: > > > On 07/27/2018 01:51 PM, Michael S. Tsirkin wrote: >> On Thu, Jul 26, 2018 at 06:55:44PM +0200, Halil Pasic wrote: >>> Sorry I did not have any time for this last days. And this >>> to make it worse this is a follow up to something that was

Re: [Qemu-devel] [PATCH for-3.1] s390x: remove 's390-squash-mcss' option

2018-08-01 Thread Fam Zheng
On Wed, Aug 1, 2018 at 9:18 PM Cornelia Huck wrote: > > On Wed, 1 Aug 2018 15:11:23 +0200 > Cornelia Huck wrote: > > > On Wed, 1 Aug 2018 14:54:51 +0200 > > Cornelia Huck wrote: > > > > > On Wed, 1 Aug 2018 18:21:27 +0800 > > > Fam Zheng wrote: > > > > > > > On Tue, 07/24 11:24, Cornelia Huck

[Qemu-devel] [Bug 1784900] Re: QEMU (frontend) crashes upon warm reboot with virtio-gpu device and vga=775 on Linux cmdline

2018-08-01 Thread Stefan Berger
This patch here fixes the issue, but is likely introducing inefficiency. There are two if statements above the patch that should set full_update = 1 due to 'some change', but none of them triggers it. So I think the surface is wrong and needs to be recreated. diff --git a/hw/display/vga.c

[Qemu-devel] [PATCH] qga: Support Unicode paths in guest-file-open on win32

2018-08-01 Thread Jonathon Reinhart
Currently, the win32 port of QEMU Guest Agent does not properly handle Unicode paths. The JSON decoder produces a valid UTF-8 path string, but this is passed directly to CreateFileA, which is expecting an ANSI string and not UTF-8. This leads to mangled filenames. This patch follows the example

[Qemu-devel] [Bug 1784900] Re: QEMU (frontend) crashes upon warm reboot with virtio-gpu device and vga=775 on Linux cmdline

2018-08-01 Thread Stefan Berger
The reason for this bug is memory corruption in glibc's memory chunk header that is in front of some bitmap pixman is allocating and maintaining as image->bits.free_me. I set a memory watchpoint to this memory location and this code here triggered it and corrupted what seems to be a memory chunk

Re: [Qemu-devel] [PATCH] sdl2: redraw correctly when scanout_mode enabled.

2018-08-01 Thread 吴涛@Eng
On Fri, Jul 27, 2018 at 6:59 AM Tao Wu wrote: > > When scanout_mode enabled, surface is out of sync with actual screen. > In such case, we just call sdl2_gl_scanout_flush to do redraw. This > fixes bug reported in > https://lists.freedesktop.org/archives/virglrenderer-devel/2018-July/001330.html

Re: [Qemu-devel] [PATCH QEMU] hw/char/sh_serial: Add timeout handling to unbreak serial input

2018-08-01 Thread Rich Felker
On Tue, Jul 31, 2018 at 11:36:46AM -0500, Rob Landley wrote: > On 07/30/2018 10:18 AM, Ulrich Hecht wrote:>> On July 30, 2018 at 3:02 PM > Geert > Uytterhoeven wrote: > >> Fix this by adding basic timeout handling. As the QEMU SCIF emulation > >> ignores any serial speed programming, the

Re: [Qemu-devel] [PATCH 4/6] dirty-bitmaps: clean-up bitmaps loading and migration logic

2018-08-01 Thread John Snow
On 08/01/2018 04:47 PM, Denis V. Lunev wrote: > On 08/01/2018 09:56 PM, John Snow wrote: >> >> On 08/01/2018 02:42 PM, Denis V. Lunev wrote: >>> On 08/01/2018 08:40 PM, Dr. David Alan Gilbert wrote: * John Snow (js...@redhat.com) wrote: > On 08/01/2018 06:20 AM, Dr. David Alan Gilbert

Re: [Qemu-devel] [PATCH] vhost: check region type before casting

2018-08-01 Thread Michael S. Tsirkin
On Wed, Aug 01, 2018 at 11:13:34AM +0100, Peter Maydell wrote: > On 1 August 2018 at 09:22, Tiwei Bie wrote: > > Ping.. > > > > It seems that the final release for QEMU 3.0 will be > > out soon [1]. But this fix hasn't been merged yet. > > > > [1]

Re: [Qemu-devel] [PATCH 4/6] dirty-bitmaps: clean-up bitmaps loading and migration logic

2018-08-01 Thread Denis V. Lunev
On 08/01/2018 09:56 PM, John Snow wrote: > > On 08/01/2018 02:42 PM, Denis V. Lunev wrote: >> On 08/01/2018 08:40 PM, Dr. David Alan Gilbert wrote: >>> * John Snow (js...@redhat.com) wrote: On 08/01/2018 06:20 AM, Dr. David Alan Gilbert wrote: > * John Snow (js...@redhat.com) wrote: >

Re: [Qemu-devel] [PATCH v5 07/76] elf: Remove duplicate preprocessor constant definition

2018-08-01 Thread Laurent Vivier
Le 01/08/2018 à 22:01, Aleksandar Markovic a écrit : >> >> From: Peter Maydell >> Sent: Wednesday, August 1, 2018 9:37 PM >> >>> The simplest way to do that is just to delete >>> the second (original) EF_MIPS_ARCH #define, the one just >>> below the EF_MIPS_NAN2008 define. >>> >>> We could line

Re: [Qemu-devel] [PATCH 4/6] dirty-bitmaps: clean-up bitmaps loading and migration logic

2018-08-01 Thread Denis V. Lunev
On 08/01/2018 09:56 PM, John Snow wrote: > > On 08/01/2018 02:42 PM, Denis V. Lunev wrote: >> On 08/01/2018 08:40 PM, Dr. David Alan Gilbert wrote: >>> * John Snow (js...@redhat.com) wrote: On 08/01/2018 06:20 AM, Dr. David Alan Gilbert wrote: > * John Snow (js...@redhat.com) wrote: >

Re: [Qemu-devel] [PATCH 4/6] dirty-bitmaps: clean-up bitmaps loading and migration logic

2018-08-01 Thread Denis V. Lunev
On 08/01/2018 09:55 PM, Dr. David Alan Gilbert wrote: > * Denis V. Lunev (d...@openvz.org) wrote: >> On 08/01/2018 08:40 PM, Dr. David Alan Gilbert wrote: >>> * John Snow (js...@redhat.com) wrote: On 08/01/2018 06:20 AM, Dr. David Alan Gilbert wrote: > * John Snow (js...@redhat.com)

Re: [Qemu-devel] [virtio-dev] Re: [v23 1/2] virtio-crypto: Add virtio crypto device specification

2018-08-01 Thread Halil Pasic
On 07/27/2018 01:51 PM, Michael S. Tsirkin wrote: On Thu, Jul 26, 2018 at 06:55:44PM +0200, Halil Pasic wrote: Sorry I did not have any time for this last days. And this to make it worse this is a follow up to something that was half a year ago. That means I have to re-familiarize myself

Re: [Qemu-devel] [PATCH 0/4] target/arm sve fixes

2018-08-01 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180801123111.3595-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH 0/4] target/arm sve fixes === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] [PATCH v5 07/76] elf: Remove duplicate preprocessor constant definition

2018-08-01 Thread Aleksandar Markovic
> > From: Peter Maydell > Sent: Wednesday, August 1, 2018 9:37 PM > > > The simplest way to do that is just to delete > > the second (original) EF_MIPS_ARCH #define, the one just > > below the EF_MIPS_NAN2008 define. > > > > We could line up with the order the glibc headers use, but > > that

Re: [Qemu-devel] [PATCH v5 07/76] elf: Remove duplicate preprocessor constant definition

2018-08-01 Thread Peter Maydell
On 1 August 2018 at 19:51, Aleksandar Markovic wrote: > Hi, Laurent. > >> From: Laurent Vivier >> Sent: Monday, July 30, 2018 6:49 PM >> >> Le 30/07/2018 à 18:11, Aleksandar Markovic a écrit : >> > diff --git a/include/elf.h b/include/elf.h >> > index 934dbbd..c8aaa2a 100644 >> > ---

Re: [Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers

2018-08-01 Thread Samuel Thibault
Pavel Dovgalyuk, le mar. 31 juil. 2018 09:58:26 +0300, a ecrit: > > From: Samuel Thibault [mailto:samuel.thiba...@gnu.org] > > Pavel Dovgalyuk, le jeu. 26 juil. 2018 11:37:57 +0300, a ecrit: > > > Or the timers are related to the network devices (e.g., servers in the > > > outer world)? > > > >

Re: [Qemu-devel] [PATCH v5 07/76] elf: Remove duplicate preprocessor constant definition

2018-08-01 Thread Aleksandar Markovic
Hi again, Laurent. Did you mean to move the comment from THE CURRENT to THE RIGHT position, as displayed here: QEMU's elf.h: /* MIPS architecture level. */ <--- THE CURRENT POSITION #define EF_MIPS_ARCH0xf000 <- duplicate /* Legal values for MIPS architecture

Re: [Qemu-devel] [PATCH 4/6] dirty-bitmaps: clean-up bitmaps loading and migration logic

2018-08-01 Thread John Snow
On 08/01/2018 02:42 PM, Denis V. Lunev wrote: > On 08/01/2018 08:40 PM, Dr. David Alan Gilbert wrote: >> * John Snow (js...@redhat.com) wrote: >>> >>> On 08/01/2018 06:20 AM, Dr. David Alan Gilbert wrote: * John Snow (js...@redhat.com) wrote: > I'd rather do something

Re: [Qemu-devel] [PATCH 4/6] dirty-bitmaps: clean-up bitmaps loading and migration logic

2018-08-01 Thread Dr. David Alan Gilbert
* Denis V. Lunev (d...@openvz.org) wrote: > On 08/01/2018 08:40 PM, Dr. David Alan Gilbert wrote: > > * John Snow (js...@redhat.com) wrote: > >> > >> On 08/01/2018 06:20 AM, Dr. David Alan Gilbert wrote: > >>> * John Snow (js...@redhat.com) wrote: > >>> > >>> > >>> > I'd rather do something

Re: [Qemu-devel] [PATCH v5 07/76] elf: Remove duplicate preprocessor constant definition

2018-08-01 Thread Aleksandar Markovic
Hi, Laurent. > From: Laurent Vivier > Sent: Monday, July 30, 2018 6:49 PM > > Le 30/07/2018 à 18:11, Aleksandar Markovic a écrit : > > From: Aleksandar Markovic > > > > Remove duplicate preprocessor constant definition for EF_MIPS_ARCH. > > > > The duplicate was introduced in commit 45506bdd.

Re: [Qemu-devel] [PATCH v4 0/2] s390x: Enable KVM huge page backing support

2018-08-01 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180801131905.148778-1-fran...@linux.ibm.com Subject: [Qemu-devel] [PATCH v4 0/2] s390x: Enable KVM huge page backing support === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [Bug 1784919] [NEW] native libgfapi glusterfs support for virtio 9p filesystem passthrough

2018-08-01 Thread Hans
Public bug reported: I can add block devices on glusterfs natively to my virtual machines since qemu 1.3 I would like to see the same feature for virtio 9p filesystems added on my VM. Accessing a filesystem mounted on the Metal is my favorite solution for storage that is to be shared between

Re: [Qemu-devel] [PATCH 4/6] dirty-bitmaps: clean-up bitmaps loading and migration logic

2018-08-01 Thread Denis V. Lunev
On 08/01/2018 08:40 PM, Dr. David Alan Gilbert wrote: > * John Snow (js...@redhat.com) wrote: >> >> On 08/01/2018 06:20 AM, Dr. David Alan Gilbert wrote: >>> * John Snow (js...@redhat.com) wrote: >>> >>> >>> I'd rather do something like this: - Always flush bitmaps to disk on

Re: [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target

2018-08-01 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180801102944.23457-1-laur...@vivier.eu Subject: [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH 4/6] dirty-bitmaps: clean-up bitmaps loading and migration logic

2018-08-01 Thread Dr. David Alan Gilbert
* John Snow (js...@redhat.com) wrote: > > > On 08/01/2018 06:20 AM, Dr. David Alan Gilbert wrote: > > * John Snow (js...@redhat.com) wrote: > > > > > > > >> I'd rather do something like this: > >> - Always flush bitmaps to disk on inactivate. > > > > Does that increase the time taken by the

Re: [Qemu-devel] [PATCH 4/6] dirty-bitmaps: clean-up bitmaps loading and migration logic

2018-08-01 Thread John Snow
On 08/01/2018 06:20 AM, Dr. David Alan Gilbert wrote: > * John Snow (js...@redhat.com) wrote: > > > >> I'd rather do something like this: >> - Always flush bitmaps to disk on inactivate. > > Does that increase the time taken by the inactivate measurably? > If it's small relative to

[Qemu-devel] [Bug 1784900] Re: QEMU (frontend) crashes upon warm reboot with virtio-gpu device and vga=775 on Linux cmdline

2018-08-01 Thread Dr. David Alan Gilbert
I also hit this with gtk frontend rather than vnc althought he backtrace looks very different. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1784900 Title: QEMU (frontend) crashes upon warm reboot

Re: [Qemu-devel] [PATCH] es1370: simplify MemoryRegionOps

2018-08-01 Thread Philippe Mathieu-Daudé
On 08/01/2018 02:06 PM, Paolo Bonzini wrote: > Use the automatic subregister extraction from the memory API, and avoid > that Coverity complains about missing fallthrough comments. > Signed-off-by: Paolo Bonzini > --- > hw/audio/es1370.c | 235 +- > 1

Re: [Qemu-devel] [PATCH v5 19/76] target/mips: Add emulation of nanoMIPS 16-bit arithmetic instructions

2018-08-01 Thread Richard Henderson
On 08/01/2018 12:02 PM, Aleksandar Markovic wrote: >> I suggest a "target_long imm;" at the top of the function to handle all such >> that will be required when this function is filled out. > > gen_arith_imm() and similar functions have "int" as the type of offset/imm > parameter (in this case

[Qemu-devel] [PATCH] es1370: simplify MemoryRegionOps

2018-08-01 Thread Paolo Bonzini
Use the automatic subregister extraction from the memory API, and avoid that Coverity complains about missing fallthrough comments. Signed-off-by: Paolo Bonzini --- hw/audio/es1370.c | 235 +- 1 file changed, 25 insertions(+), 210 deletions(-) diff

Re: [Qemu-devel] [PATCH v5 23/24] replay: add BH oneshot event for block layer

2018-08-01 Thread Paolo Bonzini
On 26/07/2018 19:17, Alex Bennée wrote: >> + >> +void replay_bh_schedule_oneshot_event(AioContext *ctx, >> +QEMUBHFunc *cb,void *opaque) >> +{ >> +aio_bh_schedule_oneshot(ctx, cb, opaque); >> +} > It seems wrong to have something in stubs that actively does stuff. > Isn't this meant to be

[Qemu-devel] [Bug 1784900] Re: QEMU (frontend) crashes upon warm reboot with virtio-gpu device and vga=775 on Linux cmdline

2018-08-01 Thread Daniel Berrange
** Summary changed: - QEMU (frontend) crashes upon warm reboot with vga=775 on Linux cmdline + QEMU (frontend) crashes upon warm reboot with virtio-gpu device and vga=775 on Linux cmdline -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [Bug 1784900] [NEW] QEMU (frontend) crashes upon warm reboot with virtio-gpu device and vga=775 on Linux cmdline

2018-08-01 Thread Stefan Berger
Public bug reported: With vga=775 on the Linux command line a first boot of the VM running Linux works fine. After a warm reboot it crashes during Linux boot. The VM was used remotely via virt-manager and VNC. Bisecting the code lead to the following patch that introduced the bug: commit

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 2/2] s390x: Enable KVM huge page backing support

2018-08-01 Thread Thomas Huth
On 08/01/2018 03:19 PM, Janosch Frank wrote: > QEMU has had huge page support for a longer time already, but KVM > memory management under s390x needed some changes to work with huge > backings. > > Now that we have support, let's enable it if requested and > available. Otherwise we now properly

Re: [Qemu-devel] [qemu-s390x] [PATCH] tests: virtio: separate ccw tests from libqos

2018-08-01 Thread Paolo Bonzini
On 01/08/2018 18:39, Thomas Huth wrote: > I think you could omit the virtio_net_nop test here, since we already > check that device in tests/pxe-test.c (and maybe also virtio_blk and > virtio_scsi since they are tested in tests/cdrom-test.c). > > Anyway: > > Reviewed-by: Thomas Huth Thanks

Re: [Qemu-devel] [qemu-s390x] [PATCH] tests: virtio: separate ccw tests from libqos

2018-08-01 Thread Thomas Huth
On 08/01/2018 03:27 PM, Paolo Bonzini wrote: > Because qtest does not support s390 channel I/O, s390 only performs smoke > tests on > those few devices that do not have any functional tests. Therefore, every > time we > add functional tests for a virtio device, the choice is between removing >

[Qemu-devel] [Bug 1783362] Re: qemu-user: mmap should return failure (MAP_FAILED, -1) instead of success (NULL, 0) when len==0

2018-08-01 Thread umarcor
2018-08-01 8:25 GMT+01:00 Laurent Vivier: > "Reviewed-By:", it's a tag I've sent in answer to his e-email to say I've reviewed his patch, and it is good for me. It's clear now. Thanks. > I didn't update the Changelog, but the fix is now committed. It will be released soon (07/08 or 14/08). But

[Qemu-devel] [Bug 1783362] Re: qemu-user: mmap should return failure (MAP_FAILED, -1) instead of success (NULL, 0) when len==0

2018-08-01 Thread umarcor
** Changed in: qemu Status: In Progress => Fix Committed ** Changed in: qemu (Ubuntu) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1783362 Title:

Re: [Qemu-devel] [PATCH v4 0/2] s390x: Enable KVM huge page backing support

2018-08-01 Thread Cornelia Huck
On Wed, 1 Aug 2018 14:19:03 +0100 Janosch Frank wrote: > v4: > * Now using MiB > * Now supporting 4k memory backings > > v3: > * Fixed Cap name > * Added mempath page size check and error reporting > > Janosch Frank (2): > kvm: sync linux headers > s390x: Enable

Re: [Qemu-devel] [PATCH] fix "Missing break in switch" coverity reports

2018-08-01 Thread Paolo Bonzini
On 01/08/2018 17:59, Peter Maydell wrote: > > We could improve the somewhat cryptic comment: > /* > * 0x41 is documented as setting the output sample rate, > * and 0x42 the input sample rate, but in fact SB16 hardware > * seems to have only a single sample rate under the hood,

Re: [Qemu-devel] [PATCH v5 19/76] target/mips: Add emulation of nanoMIPS 16-bit arithmetic instructions

2018-08-01 Thread Aleksandar Markovic
Hi, Richard. > > +case NM_P16_A2: > > +switch (extract32(ctx->opcode, 3, 1)) { > > +case NM_ADDIUR2: > > +rd = extract32(ctx->opcode, 0, 3) << 2; > > +gen_arith_imm(ctx, OPC_ADDIU, rt, rs, rd); > > +break; > > +case NM_P_ADDIURS5: >

Re: [Qemu-devel] [PATCH] fix "Missing break in switch" coverity reports

2018-08-01 Thread Peter Maydell
On 1 August 2018 at 16:14, Paolo Bonzini wrote: > Many of these are marked as "intentional/fix required" because they > just need adding a fall through comment. This is exactly what this > patch does, except for target/mips/translate.c where it is easier to > duplicate the code, and

Re: [Qemu-devel] [[PATH for 3.1] v2 12/18] check: Only test sdhci when it is compiled in

2018-08-01 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180801110952.5590-13-quint...@redhat.com Subject: [Qemu-devel] [[PATH for 3.1] v2

Re: [Qemu-devel] qemu NBD client behaviour when device size is not a multiple of 512

2018-08-01 Thread Eric Blake
On 07/31/2018 01:25 PM, Eric Blake wrote: On 07/31/2018 01:00 PM, Richard W.M. Jones wrote: Hi Eric.  Is this a bug? Note that with qemu as server: $ truncate --size=1023 file $ qemu-nbd -f raw -x '' file the client now sees: 423068@1533060754.229106:nbd_opt_go_info_block_size Block

Re: [Qemu-devel] [PATCH] fix "Missing break in switch" coverity reports

2018-08-01 Thread Paolo Bonzini
On 01/08/2018 17:25, Philippe Mathieu-Daudé wrote: > > @@ -12277,6 +12277,7 @@ int arm_rmode_to_sf(int rmode) >          /* FIXME: add support for TIEAWAY and ODD */ >          qemu_log_mask(LOG_UNIMP, "arm: unimplemented rounding mode: > %d\n", >                        

Re: [Qemu-devel] [PATCH] fix "Missing break in switch" coverity reports

2018-08-01 Thread Philippe Mathieu-Daudé
Le mer. 1 août 2018 12:15, Paolo Bonzini a écrit : > Many of these are marked as "intentional/fix required" because they > just need adding a fall through comment. This is exactly what this > patch does, except for target/mips/translate.c where it is easier to > duplicate the code, and

Re: [Qemu-devel] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

2018-08-01 Thread Eric Blake
On 08/01/2018 06:47 AM, Niels de Vos wrote: If glusterfs-5 releases in October, that may line up with 3.1 or 3.2. Ok, I'll keep these kind of patches in my tree as work-in-progress and when the glusterfs-5 gets tagged for alpha/beta send it again. Even if not optimal, would you accept this as

[Qemu-devel] [PATCH] fix "Missing break in switch" coverity reports

2018-08-01 Thread Paolo Bonzini
Many of these are marked as "intentional/fix required" because they just need adding a fall through comment. This is exactly what this patch does, except for target/mips/translate.c where it is easier to duplicate the code, and hw/audio/sb16.c where I consulted the DOSBox sources and decide to

Re: [Qemu-devel] [PATCH 0/4] target/arm sve fixes

2018-08-01 Thread Alex Bennée
Richard Henderson writes: > These four patches are minor, reported by Laurent this week. > > If there happens to be an -rc4 release, it would be nice if > they were included. But if not, no biggie. I suspect that > other minor issues will be found past these four, so I would > hope everyone

[Qemu-devel] [Bug 1776224] Re: QEMU's SPICE server not getting leds callback when sending capslock

2018-08-01 Thread Bastien Orivel
This is in fact https://bugs.launchpad.net/ubuntu/+source/console-setup/+bug/425704 Sorry for the noise ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH] monitor: avoid potential dead-lock when cleaning up

2018-08-01 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Wed, Aug 1, 2018 at 3:19 PM, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >>> When a monitor is connected to a Spice chardev, the monitor cleanup >>> can dead-lock: >>> >>> #0 0x7f43446637fd in __lll_lock_wait () at /lib64/libpthread.so.0

Re: [Qemu-devel] [PATCH] throttle-groups: fix hang when group member leaves

2018-08-01 Thread Alberto Garcia
On Tue 31 Jul 2018 06:47:53 PM CEST, Alberto Garcia wrote: > On Wed 04 Jul 2018 04:54:10 PM CEST, Stefan Hajnoczi wrote: >> Throttle groups consist of members sharing one throttling state >> (including bps/iops limits). Round-robin scheduling is used to ensure >> fairness. If a group member

Re: [Qemu-devel] [PULL 1/1] slirp: fix ICMP handling on macOS hosts

2018-08-01 Thread Andrew Oates via Qemu-devel
On Wed, Aug 1, 2018 at 6:10 AM Peter Maydell wrote: > On 1 August 2018 at 00:25, Andrew Oates wrote: > > Both CONFIG_BSD and not-CONFIG_LINUX work on macOS. I unfortunately > don't > > have access to any other BSDs to test them, though. > > Is there an easy way to test it? The QEMU makefiles

Re: [Qemu-devel] [PATCH] scsi: mptsas: Mark as storage device

2018-08-01 Thread Paolo Bonzini
On 01/08/2018 00:28, Guenter Roeck wrote: > mptsas1068 is currently listed as uncategorized device. > Mark it as storage device. > > Signed-off-by: Guenter Roeck > --- > hw/scsi/mptsas.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c > index

Re: [Qemu-devel] [RFC] target/mips: Initial support for MIPS R5900

2018-08-01 Thread Richard Henderson
On 08/01/2018 09:39 AM, Fredrik Noring wrote: > Can QEMU be instructed to emulate > the FPU only for Linux user space programs as opposed to hardware emulation? Yes, that can be done. I would suggest something like /* * Hardware traps to the operating system for emulation. * For user-only,

Re: [Qemu-devel] [Qemu-arm] [PATCH 1/4] target/arm: Fix sign of sve_cmpeq_ppzw/sve_cmpne_ppzw

2018-08-01 Thread Alex Bennée
Richard Henderson writes: > The normal vector element is sign-extended before > comparing with the wide vector element. > > Reported-by: Laurent Desnogues > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/sve_helper.c | 12 ++-- > 1 file changed, 6

Re: [Qemu-devel] [Qemu-arm] [PATCH 4/4] target/arm: Fix typo in helper_sve_movz_d

2018-08-01 Thread Alex Bennée
Richard Henderson writes: > Reported-by: Laurent Desnogues > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/sve_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c > index

[Qemu-devel] [PATCH v4 3/4] pc: drop memory region alignment check for 0

2018-08-01 Thread David Hildenbrand
All applicable memory regions always have an alignment > 0. All memory backends result in file_ram_alloc() or qemu_anon_ram_alloc() getting called, setting the alignment to > 0. So a PCDIMM memory region always has an alignment > 0. NVDIMM copy the alignment of the original memory memory region

[Qemu-devel] [PATCH v4 2/4] util/oslib-win32: indicate alignment for qemu_anon_ram_alloc()

2018-08-01 Thread David Hildenbrand
Let's set the alignment just like for the posix variant. This will implicitly set the alignment of the underlying memory region and therefore make memory_region_get_alignment(mr) return something > 0 for all memory backends applicable to PCDIMM/NVDIMM. The allocation granularity is ususally 64k,

Re: [Qemu-devel] [RFC] target/mips: Initial support for MIPS R5900

2018-08-01 Thread Fredrik Noring
Thank you for your review, Maciej, > > The MIPS R5900 is normally taken to be MIPS3, but it has MOVN, MOVZ and PREF > > defined in MIPS4 which is why ISA_MIPS4 is chosen for this patch. > > It also has several instructions removed, so I don't think you can really > just mark it MIPS IV without

[Qemu-devel] [PATCH v4 1/4] pc-dimm: assign and verify the "slot" property during pre_plug

2018-08-01 Thread David Hildenbrand
We can assign and verify the slot before realizing and trying to plug. reading/writing the slot property should never fail, so let's reduce error handling a bit by using _abort. To do this during pre_plug, add and use (x86, ppc) pc_dimm_pre_plug(). Reviewed-by: David Gibson Reviewed-by: Igor

[Qemu-devel] [PATCH v4 0/4] pc-dimm: pre_plug "slot" and "addr" assignment

2018-08-01 Thread David Hildenbrand
This is basically a resend of v3 with commit message changes. Paolo, if there are no further comments, can you please pick this up for 3.1? Thanks! --- As requested by Igor, assign and verify "slot" and "addr" in the pre_plug handler. Factor out the compatibility handling/configuration for

Re: [Qemu-devel] [PATCH for-3.1] tests/cpu-plug-test: check CPU hotplug on ppc64 with KVM

2018-08-01 Thread Greg Kurz
On Tue, 31 Jul 2018 13:27:15 +1000 David Gibson wrote: > On Mon, Jul 30, 2018 at 11:59:00AM +0200, Greg Kurz wrote: > > On Mon, 30 Jul 2018 10:41:45 +0200 > > Greg Kurz wrote: > > > > > On Mon, 30 Jul 2018 15:57:15 +1000 > > > David Gibson wrote: > > [...] > > > > > > I'm pretty sure

[Qemu-devel] [PATCH v4 4/4] pc-dimm: assign and verify the "addr" property during pre_plug

2018-08-01 Thread David Hildenbrand
We can assign and verify the address before realizing and trying to plug. reading/writing the address property should never fail for DIMMs, so let's reduce error handling a bit by using _abort. Getting access to the memory region now might however fail. So forward errors from get_memory_region()

Re: [Qemu-devel] [PATCH] monitor: avoid potential dead-lock when cleaning up

2018-08-01 Thread Marc-André Lureau
Hi On Wed, Aug 1, 2018 at 3:19 PM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> When a monitor is connected to a Spice chardev, the monitor cleanup >> can dead-lock: >> >> #0 0x7f43446637fd in __lll_lock_wait () at /lib64/libpthread.so.0 >> #1 0x7f434465ccf4 in

Re: [Qemu-devel] [PATCH] tests: virtio: separate ccw tests from libqos

2018-08-01 Thread Cornelia Huck
On Wed, 1 Aug 2018 15:27:33 +0200 Paolo Bonzini wrote: > Because qtest does not support s390 channel I/O, s390 only performs smoke > tests on > those few devices that do not have any functional tests. Therefore, every > time we > add functional tests for a virtio device, the choice is

Re: [Qemu-devel] [PATCH 2/4] target/arm: Fix typo in do_sat_addsub_64

2018-08-01 Thread Laurent Desnogues
On Wed, Aug 1, 2018 at 2:31 PM, Richard Henderson wrote: > Used the wrong temporary in the computation of subtractive overflow. > > Reported-by: Laurent Desnogues > Signed-off-by: Richard Henderson Reviewed-by: Laurent Desnogues Tested-by: Laurent Desnogues Laurent > --- >

Re: [Qemu-devel] [PATCH 0/4] target/arm sve fixes

2018-08-01 Thread Laurent Desnogues
On Wed, Aug 1, 2018 at 2:31 PM, Richard Henderson wrote: > These four patches are minor, reported by Laurent this week. This fixes the reported issues, thanks! > If there happens to be an -rc4 release, it would be nice if > they were included. But if not, no biggie. I suspect that > other

Re: [Qemu-devel] [PATCH 3/4] target/arm: Reorganize SVE WHILE

2018-08-01 Thread Laurent Desnogues
On Wed, Aug 1, 2018 at 2:31 PM, Richard Henderson wrote: > The pseudocode for this operation is an increment + compare loop, > so comparing <= the maximum integer produces an all-true predicate. > > Rather than bound in both the inline code and the helper, pass the > helper the number of

Re: [Qemu-devel] [PATCH 1/4] target/arm: Fix sign of sve_cmpeq_ppzw/sve_cmpne_ppzw

2018-08-01 Thread Laurent Desnogues
On Wed, Aug 1, 2018 at 2:31 PM, Richard Henderson wrote: > The normal vector element is sign-extended before > comparing with the wide vector element. > > Reported-by: Laurent Desnogues > Signed-off-by: Richard Henderson Reviewed-by: Laurent Desnogues Tested-by: Laurent Desnogues Laurent

Re: [Qemu-devel] [PATCH 4/4] target/arm: Fix typo in helper_sve_movz_d

2018-08-01 Thread Laurent Desnogues
On Wed, Aug 1, 2018 at 2:31 PM, Richard Henderson wrote: > Reported-by: Laurent Desnogues > Signed-off-by: Richard Henderson Reviewed-by: Laurent Desnogues Tested-by: Laurent Desnogues Laurent > --- > target/arm/sve_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[Qemu-devel] [PATCH] tests: virtio: separate ccw tests from libqos

2018-08-01 Thread Paolo Bonzini
Because qtest does not support s390 channel I/O, s390 only performs smoke tests on those few devices that do not have any functional tests. Therefore, every time we add functional tests for a virtio device, the choice is between removing those tests from the s390 suite (so that s390 actually

Re: [Qemu-devel] [PATCH v4 2/2] s390x: Enable KVM huge page backing support

2018-08-01 Thread David Hildenbrand
On 01.08.2018 15:19, Janosch Frank wrote: > QEMU has had huge page support for a longer time already, but KVM > memory management under s390x needed some changes to work with huge > backings. > > Now that we have support, let's enable it if requested and > available. Otherwise we now properly

  1   2   >