On Sat, 2018-08-18 at 11:10 +0800, Robert Hoo wrote:
> On Fri, 2018-08-17 at 00:10 -0300, Eduardo Habkost wrote:
> [trim...]
> > > +
> > > typedef struct FeatureWordInfo {
> > > -/* feature flags names are taken from "Intel Processor
> > > Identification and
> > > +FeatureWordType type;
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1777293
Title:
[REQUEST]
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1534507432-2873-1-git-send-email-hans-erik.flo...@rt-labs.com
Subject: [Qemu-devel] [PATCH v2] sdhci: add i.MX SD Stable Clock bit
=== TEST SCRIPT BEGIN ===
#!/bin/bash
On Fri, 2018-08-17 at 00:10 -0300, Eduardo Habkost wrote:
[trim...]
> > +
> > typedef struct FeatureWordInfo {
> > -/* feature flags names are taken from "Intel Processor Identification
> > and
> > +FeatureWordType type;
> > + /* feature flags names are taken from "Intel Processor
When a container fails, it leaves a dangling tarball which name is
based on a timestamp. Further uses of make won't clean those files,
neither calling the 'docker-clean' target.
Use the .DELETE_ON_ERROR built-in target to let make remove those
temporary tarballs in case of failure.
Fedora 29 comes with GCC 8.1 which added the 'stringop-truncation' checks.
Replace the strncpy() calls by g_strlcpy() to avoid the following warning:
migration/global_state.c: In function 'global_state_store_running':
migration/global_state.c:45:5: error: 'strncpy' specified bound 100 equals
Fedora 29 comes with GCC 8.1 which added the 'stringop-truncation' checks.
Replace the strncpy() calls by g_strlcpy() to avoid the following warning:
block/sheepdog.c: In function 'find_vdi_name':
block/sheepdog.c:1239:5: error: 'strncpy' specified bound 256 equals
destination size
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180817051853.23792-1-c...@braap.org
Subject: [Qemu-devel] [PATCH v2 0/9] synchronization profiler
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log
As recommended in
https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#sort-multi-line-arguments
"This helps to avoid duplication of packages and make the
list much easier to update. This also makes PRs a lot easier
to read and review."
Signed-off-by: Philippe
As recommended in
https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#sort-multi-line-arguments
"This helps to avoid duplication of packages and make the
list much easier to update. This also makes PRs a lot easier
to read and review."
Signed-off-by: Philippe
Trivial cleanup patches.
Per the Docker recommendation, "this helps to avoid duplication of
packages and make the list much easier to update. This also makes PRs
a lot easier to read and review."
Regards,
Phil.
Philippe Mathieu-Daudé (4):
docker: Sort Fedora packages
docker: Sort Fedora
As recommended in
https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#sort-multi-line-arguments
"This helps to avoid duplication of packages and make the
list much easier to update."
Signed-off-by: Philippe Mathieu-Daudé
---
tests/docker/dockerfiles/centos7.docker |
As recommended in
https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#sort-multi-line-arguments
"This helps to avoid duplication of packages and make the
list much easier to update. This also makes PRs a lot easier
to read and review."
Signed-off-by: Philippe
On 08/16/2018 03:02 PM, Peter Maydell wrote:
> Ping for code review, please?
I let patch #7 for someone else (or later) and few comments before
adding R-b for the rest.
>
> (It's only been a week so this is a little bit eager, but
> I have some more MPS patches which wire up the PL022 SPI
>
On 08/09/2018 10:01 AM, Peter Maydell wrote:
> The Arm Cortex-M System Design Kit includes a simple watchdog module
> based on a 32-bit down-counter. Implement this.
>
> Signed-off-by: Peter Maydell
> ---
> Makefile.objs| 1 +
> hw/watchdog/Makefile.objs
On 08/09/2018 10:01 AM, Peter Maydell wrote:
> Implement a model of the TrustZone Master Securtiy Controller,
Security
> as documented in the Arm CoreLink SIE-200 System IP for
> Embedded TRM (DDI0571G):
> https://developer.arm.com/products/architecture/m-profile/docs/ddi0571/g
Your link
On 08/09/2018 10:01 AM, Peter Maydell wrote:
> The AN505 FPGA image includes four PL081 DMA controllers, each
> of which is gated by a Master Security Controller that allows
> the guest to prevent a non-secure DMA controller from accessing
> memory that is used by secure guest code. Create and
On 08/09/2018 10:01 AM, Peter Maydell wrote:
> The IoTKit doesn't have any MSCs itself but it does need
> some wiring to connect the external signals from MSCs
> in the outer board model up to the registers and the
> NVIC IRQ line.
>
> We also need to expose a MemoryRegion corresponding to
> the
On 08/09/2018 10:01 AM, Peter Maydell wrote:
> The PL080 and PL081 have three outgoing interrupt lines:
> * DMACINTERR signals DMA errors
> * DMACINTTC is the DMA count interrupt
> * DMACINTR is a combined interrupt, the logical OR of the other two
>
> We currently only implement DMACINTR,
On 08/09/2018 10:01 AM, Peter Maydell wrote:
> The IoTKit does not have any Master Security Contollers itself,
> but it does provide registers in the secure privilege control
> block which allow control of MSCs in the external system.
> Add support for these registers.
>
> Signed-off-by: Peter
Hi,
This series failed docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180817054758.14515-1-f...@redhat.com
Subject: [Qemu-devel] [PATCH v3 0/3] file-posix:
Hi Peter,
On 08/09/2018 10:01 AM, Peter Maydell wrote:
> The Arm IoTKit includes a system control element which
> provides a block of read-only ID registers and a block
> of read-write control registers. Implement a minimal
> version of this.
>
> Signed-off-by: Peter Maydell
> ---
>
Hi Peter,
On 08/09/2018 10:01 AM, Peter Maydell wrote:
> Wire up the system control element's register banks.
>
> This is the last of the previously completely unimplemented
> components in the IoTKit.
>
> Signed-off-by: Peter Maydell
> ---
> include/hw/arm/iotkit.h | 4 +++-
>
On 08/09/2018 10:01 AM, Peter Maydell wrote:
> The IoTKit has a CMSDK timer device that runs on the S32KCLK.
> Create this and wire it up.
>
> Signed-off-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
> ---
> include/hw/arm/iotkit.h | 2 +-
> hw/arm/iotkit.c | 9 +
> 2
This currently has no users, but the use case is so common that I
think we must support it.
Note that without the appended we cannot safely remove a set of
elements; a 2-step approach (i.e. qht_iter first, keep track of
the to-be-deleted elements, and then a bunch of qht_remove calls)
would be
Hi Peter,
On 08/09/2018 10:01 AM, Peter Maydell wrote:
> The IoTKit includes three different instances of the
> CMSDK APB watchdog; create and wire them up.
>
> Signed-off-by: Peter Maydell
> ---
> include/hw/arm/iotkit.h | 6 +
> hw/arm/iotkit.c | 58
A small series with:
- The addition of qht_iter_remove, necessary to safely remove
a set of elements. This currently has no users, but it's
easy to implement and very useful to have. (I initially wrote
it for the sync-profiler, but for unrelated reasons I ended up
changing the profiler's
Perform first the tests that exercise code paths that are
easier to hit at small table sizes, and then resize the table
to speed up subsequent tests. If this resize is not too large,
we can make the test faster with no code coverage loss.
- With gcov enabled:
Before: 20.568s, 90.28% qht.c
This improves coverage by one (!) LoC in qht.c, bringing the
coverage rate up from 90.00% to 90.28%.
Signed-off-by: Emilio G. Cota
---
tests/test-qht.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/tests/test-qht.c b/tests/test-qht.c
index
This improves qht.c code coverage from 89.44% to 90.00%.
Signed-off-by: Emilio G. Cota
---
tests/test-qht.c | 26 --
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a/tests/test-qht.c b/tests/test-qht.c
index 283fb3db39..05b1d6807a 100644
---
Signed-off-by: Emilio G. Cota
---
util/qht.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/util/qht.c b/util/qht.c
index c138777a9c..7b57b50a24 100644
--- a/util/qht.c
+++ b/util/qht.c
@@ -665,8 +665,7 @@ static inline void qht_bucket_remove_entry(struct
qht_bucket
Signed-off-by: Emilio G. Cota
---
tests/test-qht.c | 50 ++--
1 file changed, 48 insertions(+), 2 deletions(-)
diff --git a/tests/test-qht.c b/tests/test-qht.c
index dda6a067be..283fb3db39 100644
--- a/tests/test-qht.c
+++ b/tests/test-qht.c
@@ -108,6
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180817013400.13353-1-ehabk...@redhat.com
Subject: [Qemu-devel] [PULL 0/8] x86 queue, 2018-08-16
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log
Hi Alistair,
On 08/16/2018 01:11 PM, Alistair Francis wrote:
> To allow Linux to ennumerate devices on the /soc/ node set it as a
enumerate
> "simple-bus".
>
> Signed-off-by: Alistair Francis
> ---
> hw/riscv/virt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
On 2018-08-14 19:01, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
>
> [v2 is just a resend. I forget to add Den an me to cc, and I don't see the
> letter in my thunderbird at all. strange. sorry for that]
>
> Hi all!
>
> Here is an idea and kind of
On 2018-08-17 22:32, Eric Blake wrote:
> On 08/17/2018 01:04 PM, Vladimir Sementsov-Ogievskiy wrote:
>> Add a new command, returning block nodes graph.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy
>> ---
>> qapi/block-core.json | 116
>> ++
>
Hi,
This series failed docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180814170126.56461-1-vsement...@virtuozzo.com
Subject: [Qemu-devel] [RFC v2] new,
On 08/17/2018 02:28 PM, Programmingkid wrote:
-o Used with a comma separated list of format specific options in
a
name=value format. Use "-o ?" for an overview of the options
Please spell that "-o help", not "-o ?". Otherwise, the user has to quote the
? to
Hi,
This series failed docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180814170126.56461-1-vsement...@virtuozzo.com
Subject: [Qemu-devel] [RFC v2] new,
On 08/17/2018 01:04 PM, Vladimir Sementsov-Ogievskiy wrote:
Add a new command, returning block nodes graph.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
qapi/block-core.json | 116 ++
+##
+# @BlockGraphEdge:
+#
+# Block Graph edge
On 2018-08-16 08:40, Markus Armbruster wrote:
> Max Reitz writes:
>
>> On 2018-08-15 10:12, Markus Armbruster wrote:
>>> Max Reitz writes:
>>
>> [...]
>>
To me personally the issue is that if you can specify a plain filename,
bdrv_refresh_filename() should give you that plain filename
On 2018-08-16 08:02, Markus Armbruster wrote:
> Max Reitz writes:
>
>> On 2018-08-15 05:43, no-re...@patchew.org wrote:
>>> Hi,
>>>
>>> This series seems to have some coding style problems. See output below for
>>> more information:
>>
>> [...]
>>
>>> === OUTPUT BEGIN ===
>>> Checking PATCH
On 08/17/2018 10:34 PM, Max Reitz wrote:
> On 2018-08-16 15:58, Vladimir Sementsov-Ogievskiy wrote:
>> 16.08.2018 03:51, Max Reitz wrote:
>>> On 2018-08-07 19:43, Vladimir Sementsov-Ogievskiy wrote:
Hi all!
Here is an asynchronous scheme for handling fragmented qcow2
reads and
On 2018-08-16 15:58, Vladimir Sementsov-Ogievskiy wrote:
> 16.08.2018 03:51, Max Reitz wrote:
>> On 2018-08-07 19:43, Vladimir Sementsov-Ogievskiy wrote:
>>> Hi all!
>>>
>>> Here is an asynchronous scheme for handling fragmented qcow2
>>> reads and writes. Both qcow2 read and write functions loops
> On Aug 17, 2018, at 9:44 AM, Eric Blake wrote:
>
> On 08/16/2018 08:27 PM, Programmingkid wrote:
>
>> I am by no means an expert at qemu-img. But I did try my best to create what
>> I think should be the new output for qemu-img --help. This is just
>> the text I plan on using in a future
On 2018-08-16 09:15, Kevin Wolf wrote:
> Am 16.08.2018 um 04:49 hat Max Reitz geschrieben:
>> On 2018-08-16 04:39, Eric Blake wrote:
>>> If convert were more powerful, I'd be fine dropping 'qemu-img dd' after
>>> a proper deprecation period.
>>
>> Technically it has those features already, with
On 08/17/2018 03:04 PM, John Snow wrote:
> Change the manual deferment to commit_complete into the implicit
> callback to job_exit, renaming commit_complete to commit_exit.
>
> This conversion does change the timing of when job_completed is
> called to after the bdrv_replace_node and
Jobs presently use both an Error object in the case of the create job,
and char strings in the case of generic errors elsewhere.
Unify the two paths as just j->err, and remove the extra argument from
job_completed. The integer error code for job_completed is kept for now
for use by pre-emptive
17.08.2018 21:25, Eduardo Habkost wrote:
On Fri, Aug 17, 2018 at 09:04:39PM +0300, Vladimir Sementsov-Ogievskiy wrote:
Render block nodes graph with help of graphviz. This new function is
for debugging, so there is no sense to put it into qemu.py as a method
of QEMUMachine. Let's instead put it
All jobs do the same thing when they leave their running loop:
- Store the return code in a structure
- wait to receive this structure in the main thread
- signal job completion via job_completed
Few jobs do anything beyond exactly this. Consolidate this exit
logic for a net reduction in SLOC.
Presently we codify the entry point for a job as the "start" callback,
but a more apt name would be "run" to clarify the idea that when this
function returns we consider the job to have "finished," except for
any cleanup which occurs in separate callbacks later.
As part of this clarification,
Change the manual deferment to commit_complete into the implicit
callback to job_exit, renaming commit_complete to commit_exit.
This conversion does change the timing of when job_completed is
called to after the bdrv_replace_node and bdrv_unref calls, which
could have implications for bjob->blk
First, it's redundant to have each job manage this itself.
Second, doing so allows us to remove a tricky case where the completion
code is called under an aio_context lock, which then calls the
finalization code which is itself executed under a second aio_context
lock.
Removing this recursive
Now that the job infrastructure is handling the job_completed call for
all implemented jobs, we can remove the interface that allowed jobs to
schedule their own completion.
Signed-off-by: John Snow
---
include/qemu/job.h | 17 -
job.c | 40
Utilize the job_exit shim by not calling job_defer_to_main_loop, and
where applicable, converting the deferred callback into the job_exit
callback.
This converts backup, stream, create, and the unit tests all at once.
None of these jobs undergo and order of operations changes, so it should
be a
Change the manual deferment to mirror_exit into the implicit
callback to job_exit and the mirror_exit callback.
This does change the order of some bdrv_unref calls and job_completed,
but thanks to the new context in which we call .job_exit, this is safe
to defer the possible flushing of any nodes
On Fri, Aug 17, 2018 at 09:59:41PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 17.08.2018 21:25, Eduardo Habkost wrote:
> > On Fri, Aug 17, 2018 at 09:04:39PM +0300, Vladimir Sementsov-Ogievskiy
> > wrote:
> > > Render block nodes graph with help of graphviz. This new function is
> > > for
From: Mark Cave-Ayland
For the older machines (such as Mac and SPARC) the DT nodes representing
bootdevices for disk nodes are irregular for mainly historical reasons.
Since the majority of bootdevice nodes for these machines either do not have a
separate disk node or require different (custom)
From: Dou Liyang
Commit 7747abf11487 ("hw/machine: Remove the Zero check of
nb_numa_nodes for numa_complete_configuration()") removed the
curly brackets. Re-add them.
Signed-off-by: Dou Liyang
Message-Id: <20180710105129.23296-1-douly.f...@cn.fujitsu.com>
Reviewed-by: Igor Mammedov
From: Mark Cave-Ayland
Some SysBusDevices either use sysbus_init_mmio() without
sysbus_mmio_map() or the first MMIO memory region doesn't represent the
bus address, causing a firmware device path with an invalid address to
be generated.
SysBusDeviceClass does provide a virtual
The following changes since commit bb16c0412a572c2c9cd44496deb3ad430bc49c1a:
Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20180816'
into staging (2018-08-16 14:35:50 +0100)
are available in the Git repository at:
git://github.com/ehabkost/qemu.git
On Fri, Aug 17, 2018 at 09:04:39PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Render block nodes graph with help of graphviz. This new function is
> for debugging, so there is no sense to put it into qemu.py as a method
> of QEMUMachine. Let's instead put it separately.
>
> Signed-off-by:
attached generated block graph (with help of "[PATCH v2 0/3] block nodes
graph visualization")
--
Best regards,
Vladimir
On 08/17/2018 10:05 AM, Markus Armbruster wrote:
The previous commit makes JSON strings containing '%' awkward to
express in templates: you'd have to mask the '%' with an Unicode
s/an Unicode/a Unicode/
escape \u0025. No template currently contains such JSON strings.
Support the printf
On 08/17/2018 10:05 AM, Markus Armbruster wrote:
The JSON parser optionally supports interpolation. This is used to
build QObjects by parsing string templates. The templates are C
literals, so parse errors (such as invalid interpolation
specifications) are actually programming errors.
On Fri, Aug 17, 2018 at 07:59:40PM +0200, Paolo Bonzini wrote:
> On 17/08/2018 19:48, Eduardo Habkost wrote:
> > So let's do what's necessary to remove it. But I don't think the
> > removal of "feature-words" should block the inclusion of this
> > series.
> >
> > Now, should QOM properties
On 08/17/2018 10:05 AM, Markus Armbruster wrote:
The recursive descent parser passes along a pointer to
JSONParserContext. It additionally passes a pointer to interpolation
state (a va_alist *) as needed to reach its consumer
parse_interpolation().
Stuffing the latter pointer into
On Fri, Aug 17, 2018 at 1:38 PM Paolo Bonzini wrote:
> On 16/08/2018 03:19, and...@andrewoates.com wrote:
> > From: Andrew Oates
> >
> > The current implementation has three bugs,
> > * segment limits are not enforced in protected mode if the L bit is set
> >in the target segment
Add a new command, returning block nodes graph.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
qapi/block-core.json | 116 ++
include/block/block.h | 1 +
block.c | 80 ++
blockdev.c|
Render block nodes graph with help of graphviz. This new function is
for debugging, so there is no sense to put it into qemu.py as a method
of QEMUMachine. Let's instead put it separately.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
scripts/render_block_graph.py | 78
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/222 | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/qemu-iotests/222 b/tests/qemu-iotests/222
index 0ead56d574..c2e647fa83 100644
--- a/tests/qemu-iotests/222
+++ b/tests/qemu-iotests/222
@@ -137,6 +137,9 @@ with
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1534431497-1385-1-git-send-email-aleksandar.marko...@rt-rk.com
Subject: [Qemu-devel] [PATCH v9 00/84] Add nanoMIPS support to QEMU
=== TEST SCRIPT BEGIN ===
#!/bin/bash
On 17/08/2018 19:48, Eduardo Habkost wrote:
> So let's do what's necessary to remove it. But I don't think the
> removal of "feature-words" should block the inclusion of this
> series.
>
> Now, should QOM properties follow our feature deprecation policy,
> or they were never a supported external
Den fre 17 aug 2018 19:51Peter Maydell skrev
> (Your indentation was off-by-one -- we use 4-space indent -- but I fixed
> that.)
-- PMM
>
Thanks! I think i fixed that in a new patch so please ignore v3.
/Hans-Erik Floryd
>
On 08/09/2018 09:35 AM, Zihan Yang wrote:
The bus_nr indicates the bus number of pxb-pcie under pcie.0, but since pxb
host can be put into different pci domain, the start bus should always be 0
I am not sure about this limitation. Do you know where is coming from?
Why do we must start a
On 15/08/2018 02:34, Emilio G. Cota wrote:
> On Tue, Aug 14, 2018 at 08:26:54 +0200, Paolo Bonzini wrote:
>> On 13/08/2018 18:38, Emilio G. Cota wrote:
>>> Fix it by implementing the CPU list as an RCU QLIST. This requires
>>> a little bit of extra work to insert CPUs at the tail of
>>> the list
On 17 August 2018 at 13:10, Hans-Erik Floryd
wrote:
> Add the ESDHC PRSSTAT_SDSTB bit, using the value of SDHC_CLOCK_INT_STABLE.
> Freescale recommends checking this bit when changing clock frequency.
>
> Signed-off-by: Hans-Erik Floryd
> ---
> hw/sd/sdhci-internal.h | 2 ++
> hw/sd/sdhci.c
Hi
On Wed, Aug 1, 2018 at 5:09 PM Markus Armbruster wrote:
>
> Marc-André Lureau writes:
>
> > Hi
> >
> > On Wed, Aug 1, 2018 at 3:19 PM, Markus Armbruster wrote:
> >> Marc-André Lureau writes:
> >>
> >>> When a monitor is connected to a Spice chardev, the monitor cleanup
> >>> can dead-lock:
On 08/09/2018 09:35 AM, Zihan Yang wrote:
This enables seabios to read config file in pxb host bus other than sysbus
Signed-off-by: Zihan Yang
---
hw/pci-bridge/pci_expander_bridge.c | 15 +++
include/hw/pci-bridge/pci_expander_bridge.h | 3 +++
2 files changed, 18
On 08/09/2018 09:34 AM, Zihan Yang wrote:
Describe new pci segments of host bridges in AML as new pci devices,
with _SEG and _BBN to let them be in DSDT.
Besides, bus_nr indicates the bus number of pxb-pcie under pcie.0 bus,
but since we put it into separate domain, it should be zero,
Why
On Fri, Aug 17, 2018 at 07:34:13PM +0200, Paolo Bonzini wrote:
> On 17/08/2018 17:55, Eduardo Habkost wrote:
> >> The names will be X86_CPU_FEATURE_WORD_TYPE_CPUID and
> >> X86_CPU_FEATURE_WORD_TYPE_MSR.
> > I wouldn't like to make this an external API unless really
> > necessary. I would rather
Hi Zihan,
On 08/09/2018 09:33 AM, Zihan Yang wrote:
Allocate new segment for pxb-pcie host bridges in MCFG table, and reserve
corresponding MCFG space for them. This allows user-defined pxb-pcie
host bridges to be placed in different pci domain than q35 host.
The pci_host_bridges list is
On 15/08/2018 19:57, prasad.singamse...@oracle.com wrote:
> From: Prasad Singamsetty
>
> qemu command fails to process -overcommit option. Add the missing
> call to qemu_add_opts() in vl.c.
>
> Signed-off-by: Prasad Singamsetty
> ---
> vl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff
On 16/08/2018 03:19, and...@andrewoates.com wrote:
> From: Andrew Oates
>
> The current implementation has three bugs,
> * segment limits are not enforced in protected mode if the L bit is set
>in the target segment descriptor[1]
> * segment limits are not enforced in compatability mode
A chardev may stop trying to write if the associated can_read()
callback returned 0. This happens when the monitor is suspended.
The frontend is supposed to call qemu_chr_fe_accept_input() when it is
ready to accept data again.
An issue was observed with a spice port: pending commands may be
On 08/17/2018 12:24 PM, Paolo Bonzini wrote:
On 07/12/2017 22:46, miny...@acm.org wrote:
From: Corey Minyard
Fix some spacing issues, remove extraneous comments, add some
defines instead of hard-coding numbers.
Signed-off-by: Corey Minyard
Cc: Michael S. Tsirkin
Cc: Paolo Bonzini
---
On 17/08/2018 17:55, Eduardo Habkost wrote:
>> The names will be X86_CPU_FEATURE_WORD_TYPE_CPUID and
>> X86_CPU_FEATURE_WORD_TYPE_MSR.
> I wouldn't like to make this an external API unless really
> necessary. I would rather deprecate the "feature-words" property
> because nobody ended up using
On 17/08/2018 17:59, Marc-André Lureau wrote:
> Use kernel common header for fw_cfg.
>
> (unfortunately, optionrom.h must have its own define, since it's
> actually an assembler header)
>
> Signed-off-by: Marc-André Lureau
> ---
> include/hw/misc/vmcoreinfo.h | 12 +--
>
VNC server is calling sasl_server_init() during startup of QEMU, even
if SASL auth has not been enabled.
This may create undesirable warnings like "Could not find keytab file:
/etc/qemu/krb5.tab" when the user didn't configure SASL on host and
started VNC server.
Instead, only initialize SASL
On 17/08/18 17:14, Peter Maydell wrote:
> On a SPARC host that I'm using as a build test machine, the
> boot-serial-test for the SPARC guest machines takes about 65
> seconds to execute. This means that it hits the current
> 60 second timer on these tests. Push the timeout up so
> that it doesn't
On 20/11/2017 17:50, Anton Nefedov wrote:
> qmp query-blockstats provides stats info for write/read/flush ops.
>
> Patches 1-5 implement the similar for discard (unmap) command for scsi
> and ide disks.
> Discard stat "unmap_ops / unmap_bytes" is supposed to account the ops that
> have completed
Hi,
This series failed docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180816120533.6587-1-...@sysgo.com
Subject: [Qemu-devel] [PATCH v2] target/arm: crash
On 11/12/2017 18:11, George Kennedy wrote:
> "Signed-off-by: George Kennedy "
Queued, thanks. Better late than never.
Paolo
On 07/12/2017 22:46, miny...@acm.org wrote:
> From: Corey Minyard
>
> Fix some spacing issues, remove extraneous comments, add some
> defines instead of hard-coding numbers.
>
> Signed-off-by: Corey Minyard
> Cc: Michael S. Tsirkin
> Cc: Paolo Bonzini
> ---
> hw/i2c/pm_smbus.c | 58
>
While it may be convenient to accept NULL value in
qobject_unref() (for similar reasons as free() accepts NULL), it is
not such a good idea for qobject_ref(): now assert() on NULL.
Some code relied on that behaviour, but it's best to be explicit that
NULL is accepted. We have to rely on testing,
On 15/08/2018 16:19, Markus Armbruster wrote:
> When read() from the qtest socket or the QMP socket fails or EOFs, we
> report "Broken pipe" and exit(1). This commonly happens when QEMU
> crashes. It also happens when QEMU refuses to run because the test
> passed it bad arguments. Sadly, we
Add a new function qdict_steal(), that deletes a key from a dict, and
returns the associated value, if any. Simplify related code.
Signed-off-by: Marc-André Lureau
---
include/qapi/qmp/qdict.h | 1 +
monitor.c| 3 +--
qobject/block-qdict.c| 7 ++-
qobject/qdict.c
On Wed, Aug 15, 2018 at 19:54:52 -0700, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> target/ppc/helper.h | 2 +-
> target/ppc/mem_helper.c | 33 ++--
> target/ppc/translate.c | 115 +---
> 3 files changed, 88
Hi,
"qobject: modify qobject_ref() to assert on NULL" was left out during
the merge of "Simplify qobject refcount" series. Rebased, and added a
preliminary simplification patch.
thanks
Marc-André Lureau (2):
qdict: add qdict_steal()
qobject: modify qobject_ref() to assert on NULL
On Fri, Aug 17, 2018 at 4:46 AM, Peter Maydell wrote:
> The mmio_interface device was a purely internal artifact
> of the implementation of the memory subsystem's request_ptr
> APIs. Now that we have removed those APIs, we can remove
> the mmio_interface device too.
>
> Signed-off-by: Peter
1 - 100 of 405 matches
Mail list logo
