Re: [Qemu-devel] [SeaBIOS] [RFC v2 0/3] Support multiple pci domains in pci_device

2018-08-27 Thread Gerd Hoffmann
On Tue, Aug 28, 2018 at 04:12:17AM +, Zihan Yang wrote: > Gerd Hoffmann 于2018年8月27日周一 上午7:04写道: > > > > Hi, > > > > > > However, QEMU only binds port 0xcf8 and 0xcfc to > > > > bus pcie.0. To avoid bus confliction, we should use other port pairs for > > > > busses under new domains. > > >

Re: [Qemu-devel] [SeaBIOS] [RFC v2 0/3] Support multiple pci domains in pci_device

2018-08-27 Thread Marcel Apfelbaum
Hi Gerd On 08/28/2018 07:12 AM, Zihan Yang wrote: Gerd Hoffmann 于2018年8月27日周一 上午7:04写道: Hi, However, QEMU only binds port 0xcf8 and 0xcfc to bus pcie.0. To avoid bus confliction, we should use other port pairs for busses under new domains. I would skip support for IO based

Re: [Qemu-devel] [PATCH 4/6] json: Nicer recovery from lexical errors

2018-08-27 Thread Markus Armbruster
Eric Blake writes: > On 08/27/2018 02:00 AM, Markus Armbruster wrote: >> When the lexer chokes on an input character, it consumes the >> character, emits a JSON error token, and enters its start state. This >> can lead to suboptimal error recovery. For instance, input >> >> 0123 , >> >>

Re: [Qemu-devel] [PATCH 5/6] json: Eliminate lexer state IN_ERROR

2018-08-27 Thread Markus Armbruster
Eric Blake writes: > On 08/27/2018 02:00 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> qobject/json-lexer.c | 9 + >> qobject/json-parser-int.h | 8 >> 2 files changed, 9 insertions(+), 8 deletions(-) > >> - >> typedef enum

Re: [Qemu-devel] [PATCH 6/6] json: Eliminate lexer state IN_WHITESPACE, pseudo-token JSON_SKIP

2018-08-27 Thread Markus Armbruster
Eric Blake writes: > On 08/27/2018 02:00 AM, Markus Armbruster wrote: >> The lexer ignores whitespace like this: >> >> on whitespace on non-ws spontaneously >> IN_START --> IN_WHITESPACE --> JSON_SKIP --> IN_START >> ^| >> \__/

Re: [Qemu-devel] [PATCH 2/6] json: Clean up how lexer consumes "end of input"

2018-08-27 Thread Markus Armbruster
Eric Blake writes: > On 08/27/2018 02:00 AM, Markus Armbruster wrote: >> When the lexer isn't in its start state at the end of input, it's >> working on a token. To flush it out, it needs to transit to its start >> state on "end of input" lookahead. >> >> There are two ways to the start state,

Re: [Qemu-devel] [PATCH 1/6] json: Fix lexer for lookahead character beyond '\x7F'

2018-08-27 Thread Markus Armbruster
Eric Blake writes: > On 08/27/2018 02:00 AM, Markus Armbruster wrote: >> The lexer fails to end a valid token when the lookahead character is >> beyond '\x7F'. For instance, input >> >> true\xC2\xA2 >> >> produces the tokens >> >> JSON_ERROR true\xC2 >> JSON_ERROR \xA2 >>

Re: [Qemu-devel] [SeaBIOS] [RFC v2 0/3] Support multiple pci domains in pci_device

2018-08-27 Thread Zihan Yang
Gerd Hoffmann 于2018年8月27日周一 上午7:04写道: > > Hi, > > > > However, QEMU only binds port 0xcf8 and 0xcfc to > > > bus pcie.0. To avoid bus confliction, we should use other port pairs for > > > busses under new domains. > > > > I would skip support for IO based configuration and use only MMCONFIG >

Re: [Qemu-devel] [PATCH 6/9] terminal3270: do not use backend timer sources

2018-08-27 Thread Peter Xu
On Tue, Aug 28, 2018 at 12:23:19AM +0200, Marc-André Lureau wrote: > terminal3270 is uses the front-end side of the chardev. It shouldn't > create sources from backend side context. Fwiw, send_timing_mark_cb > calls qemu_chr_fe_write_all() which should be thread safe. > > This partially reverts

Re: [Qemu-devel] [PATCH v3] editorconfig: set emacs mode

2018-08-27 Thread Markus Armbruster
Marc-André Lureau writes: > Some time ago, I proposed to use an (eval) in .dir-locals.el to set > the mode for all json files and Makefile. Unfortunately, this isn't > safe, and emacs will prompt the user, which isn't very friendly. > > Fortunately, editorconfig provides a special config key

Re: [Qemu-devel] [PATCH v6 06/13] qapi: remove COMMAND_DROPPED event

2018-08-27 Thread Peter Xu
On Mon, Aug 27, 2018 at 02:30:12PM -0500, Eric Blake wrote: > On 08/15/2018 08:37 AM, Peter Xu wrote: > > Now it was not used any more. Drop it, especially if we can do that > > before we release QEMU 3.0. > > Stale commit message, now that 3.0 has been released. But still doable, > since the

Re: [Qemu-devel] [PATCH v6 03/13] qapi: remove error checks for event emission

2018-08-27 Thread Peter Xu
On Mon, Aug 27, 2018 at 02:14:25PM +0200, Markus Armbruster wrote: [...] > Let's improve the commit message a bit. Here's my try: > > qapi: Drop qapi_event_send_FOO()'s Error ** argument > > The generated qapi_event_send_FOO() take an Error ** argument. They > can't actually

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v25 0/2] virtio-crypto: virtio crypto device specification

2018-08-27 Thread Gonglei (Arei)
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Friday, August 24, 2018 8:54 PM > > On Fri, Aug 24, 2018 at 12:07:44PM +, Gonglei (Arei) wrote: > > Hi Michael, > > > > > -Original Message- > > > From: virtio-...@lists.oasis-open.org >

Re: [Qemu-devel] [PATCH v6 01/13] monitor: simplify monitor_qmp_setup_handlers_bh

2018-08-27 Thread Peter Xu
On Mon, Aug 27, 2018 at 01:29:29PM +0200, Markus Armbruster wrote: > > @@ -4624,15 +4624,10 @@ static void monitor_qmp_setup_handlers_bh(void > > *opaque) > > Monitor *mon = opaque; > > GMainContext *context; > > > > -if (mon->use_io_thread) { > > -/* Use @mon_iothread

Re: [Qemu-devel] [PATCH v5 3/3] intel-iommu: replace more vtd_err_* traces

2018-08-27 Thread Peter Xu
On Mon, Aug 27, 2018 at 03:17:45PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > Replace all the trace_vtd_err_*() hooks with the new error_report_once() > > since they are similar to trace_vtd_err() - dumping the first error > > would be mostly enough, then we have them on by default

[Qemu-devel] [PATCH] vmdk: align end of file to a sector boundary

2018-08-27 Thread yuchenlin--- via Qemu-devel
From: yuchenlin There is a rare case which the size of last compressed cluster is larger than the cluster size, which will cause the file is not aligned at the sector boundary. Signed-off-by: yuchenlin --- block/vmdk.c | 18 ++ 1 file changed, 18 insertions(+) diff --git

[Qemu-devel] [Bug 1755912] Re: qemu-system-x86_64 crashed with SIGABRT when using option -vga qxl

2018-08-27 Thread Leonardo Müller
Thank you for the effort to backport this bug fix, I have tested the proposed version 2.11.1(Debian 1:2.11+dfsg-1ubuntu7.5) and the crash when changing resolution is no longer happening. Unfortunately, after some time (about 10 minutes, much longer than without this fix), the guest freezes. I

Re: [Qemu-devel] [PATCH v2] vl.c deprecate incorrect CPUs topology

2018-08-27 Thread Eduardo Habkost
On Mon, Aug 27, 2018 at 03:53:26PM +0200, Igor Mammedov wrote: > -smp [cpus],sockets/cores/threads[,maxcpus] should describe topology > so that total number of logical CPUs [sockets * cores * threads] > would be equal to [maxcpus], however historically we didn't have > such check in QEMU and it is

Re: [Qemu-devel] [PATCH] blkdebug: Add support for latency rules

2018-08-27 Thread Marc Olson via Qemu-devel
On 08/24/2018 09:11 AM, Eric Blake wrote: On 08/24/2018 12:06 AM, Marc Olson via Qemu-devel wrote: Allow rules to be created to inject latency into I/O operations. Signed-off-by: Marc Olson ---   block/blkdebug.c    | 101 ++--  

Re: [Qemu-devel] [PATCH] pc: make sure that guest isn't able to unplug the first cpu

2018-08-27 Thread David Gibson
On Mon, Aug 27, 2018 at 04:02:39PM +0200, Greg Kurz wrote: > On Mon, 27 Aug 2018 13:07:10 +0200 > Igor Mammedov wrote: > > > The first cpu unplug wasn't ever supported and corresponding > > monitor/qmp commands refuse to unplug it. However guest is able > > to issue eject request either using

Re: [Qemu-devel] [Qemu-ppc] [PATCH] 40p: fix PCI interrupt routing

2018-08-27 Thread David Gibson
On Mon, Aug 27, 2018 at 07:12:29PM +0200, BALATON Zoltan wrote: > On Mon, 27 Aug 2018, Mark Cave-Ayland wrote: > > According to the PReP specification section 6.1.6 "System Interrupt > > Assignments", all PCI interrupts are routed via IRQ 15. > > > > With this patch applied it is now possible to

[Qemu-devel] Guest crash when VNC connection is established with password (QEMU 2.5.1.1)

2018-08-27 Thread John Y.
(Sorry for repost, I had asked in qemu-stable, but someone told me that I should send to qemu-devel.) After I updated my Centos to 7.5.1804, my virtual machine crashed when I connected with vnc password. *1. My problem:* Here what I tested: (1). started a guest with : qemu-system-x86_64 -m

Re: [Qemu-devel] [PATCH v3 8/9] qga: process_event() simplification

2018-08-27 Thread Michael Roth
Quoting Marc-André Lureau (2018-08-25 08:57:23) > Simplify the code around qmp_dispatch(): > - rely on qmp_dispatch/check_obj() for message checking > - have a single send_response() point > - constify send_response() argument > > It changes a couple of error messages: > > * When @req isn't a

[Qemu-devel] [PATCH v3] editorconfig: set emacs mode

2018-08-27 Thread Marc-André Lureau
Some time ago, I proposed to use an (eval) in .dir-locals.el to set the mode for all json files and Makefile. Unfortunately, this isn't safe, and emacs will prompt the user, which isn't very friendly. Fortunately, editorconfig provides a special config key which does allow to set the emacs mode.

[Qemu-devel] [PATCH 7/9] chardev: add a note about frontend sources and context switch

2018-08-27 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- include/chardev/char-fe.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/chardev/char-fe.h b/include/chardev/char-fe.h index 4677a9e65a..25fe62e1cf 100644 --- a/include/chardev/char-fe.h +++ b/include/chardev/char-fe.h @@ -166,6 +166,9 @@ void

[Qemu-devel] [PATCH 9/9] char-pty: remove write_lock usage

2018-08-27 Thread Marc-André Lureau
The lock usage was described with its introduction in commit 9005b2a7589540a3733b3abdcfbccfe7746cd1a1. It was necessary because PTY write() shares more state than GIOChannel with other operations. This made char-pty a bit different from other chardev, that only lock around the write operation.

[Qemu-devel] [PATCH 6/9] terminal3270: do not use backend timer sources

2018-08-27 Thread Marc-André Lureau
terminal3270 is uses the front-end side of the chardev. It shouldn't create sources from backend side context. Fwiw, send_timing_mark_cb calls qemu_chr_fe_write_all() which should be thread safe. This partially reverts changes from commit 2c716ba1506769c9be2caa02f0f6d6e7c00f4304. CC: Peter Xu

[Qemu-devel] [PATCH 8/9] char-pty: remove check for connection on write

2018-08-27 Thread Marc-André Lureau
This doesn't give much compared to the 1 second timer: there is no reliable / unracy way to have slave connect & master write. However, we can simplify the code around chr_write() since the write lock is no longer needed for various other char-pty callbacks (see following patch). Signed-off-by:

[Qemu-devel] [PATCH 5/9] char-fe: set_handlers() needs an associted chardev

2018-08-27 Thread Marc-André Lureau
It is futile to call qemu_chr_fe_set_handlers() without an associated chardev, because the function is doing nothing in that case, not even reporting an error, it would likely be a programming error. Let's not handle that hypothetical case. (fwiw, I introduced the check in commit

[Qemu-devel] [PATCH 1/9] char.h: fix gtk-doc comment style

2018-08-27 Thread Marc-André Lureau
Use the gtk-doc function comment style, as documented in: https://developer.gnome.org/gtk-doc-manual/stable/documenting_symbols.html.en Signed-off-by: Marc-André Lureau --- include/chardev/char-fe.h | 81 ++- include/chardev/char.h| 61

[Qemu-devel] [PATCH 3/9] chardev: use a child source for qio input source

2018-08-27 Thread Marc-André Lureau
GLib child source were added with version 2.28. We can use them now that we bumped our requirement to 2.40. Signed-off-by: Marc-André Lureau --- chardev/char-io.c | 48 +-- 1 file changed, 5 insertions(+), 43 deletions(-) diff --git

[Qemu-devel] [PATCH 0/9] chardev: various cleanups and improvements

2018-08-27 Thread Marc-André Lureau
Hi, Some chardev-related patches I have accumulated. Please review, thanks! Marc-André Lureau (9): char.h: fix gtk-doc comment style chardev: mark the calls that allow an implicit mux monitor chardev: use a child source for qio input source char: update the mux hanlders in class callback

[Qemu-devel] [PATCH 2/9] chardev: mark the calls that allow an implicit mux monitor

2018-08-27 Thread Marc-André Lureau
This is mostly for readability of the code. Let's make it clear which callers can create an implicit monitor when the chardev is muxed. This will also enforce a safer behaviour, as we don't really support creating monitor anywhere/anytime at the moment. Add an assert() to make sure the programmer

[Qemu-devel] [PATCH 4/9] char: update the mux hanlders in class callback

2018-08-27 Thread Marc-André Lureau
Instead of handling mux chardev in a special way in qemu_chr_fe_set_handlers(), we may use the chr_update_read_handler class callback instead. Signed-off-by: Marc-André Lureau --- include/chardev/char-mux.h | 1 - chardev/char-fe.c | 4 chardev/char-mux.c | 5 +++-- 3

Re: [Qemu-devel] [PATCH] RFC: chardev: mark the calls that allow an implicit mux monitor

2018-08-27 Thread Marc-André Lureau
Hi On Mon, Aug 27, 2018 at 10:10 AM Markus Armbruster wrote: > > Marc-André Lureau writes: > > > Hi > > On Fri, Aug 24, 2018 at 9:37 AM Markus Armbruster wrote: > >> > >> Marc-André Lureau writes: > >> > >> > This is mostly for readability of the code. Let's make it clear which > >> > callers

[Qemu-devel] [PATCH v2 2/2] qapi: Add comments to aid debugging generated introspection

2018-08-27 Thread Eric Blake
We consciously chose in commit 1a9a507b to hide QAPI type names from the introspection output on the wire, but added a command line option -u to unmask the type name when doing a debug build. The unmask option still remains useful to some other forms of automated analysis, so it will not be

[Qemu-devel] [PATCH v2 1/2] qapi: Minor introspect.py cleanups

2018-08-27 Thread Eric Blake
Commit 7d0f982b changed generated introspection output to no longer produce long lines in the generated .c file, but failed to adjust comments to match. Add some clarity that the shorter length that matters most is the overall QMP response on the wire. Commit 25b1ef31 triggers a pep8 formatting

[Qemu-devel] [PATCH v2 0/2] qapi: easier debugging of introspection file

2018-08-27 Thread Eric Blake
When inspecting the generated qapi-introspect.c (for debugging, or to see what QAPI changes are user visible vs. internal only), the fact that we've intentionally masked names from the QMP client makes it harder to tie back generated code back to the original QAPI .json files. We have a -u switch

Re: [Qemu-devel] [PATCH v6 06/13] qapi: remove COMMAND_DROPPED event

2018-08-27 Thread Eric Blake
On 08/15/2018 08:37 AM, Peter Xu wrote: Now it was not used any more. Drop it, especially if we can do that before we release QEMU 3.0. Stale commit message, now that 3.0 has been released. But still doable, since the event could not be emitted without use of the experimental x-oob option.

Re: [Qemu-devel] [PATCH 4/4] net: Remove the deprecated -tftp, -bootp, -redir and -smb options

2018-08-27 Thread Samuel Thibault
Thomas Huth, le lun. 27 août 2018 16:54:12 +0200, a ecrit: > These options likely do not work as expected as soon as the user > tries to use more than one network interface at once. The parameters > have been marked as deprecated since QEMU v2.6, so users had plenty > of time to move their scripts

Re: [Qemu-devel] [PATCH v2 8/9] jobs: remove ret argument to job_completed; privatize it

2018-08-27 Thread John Snow
On 08/27/2018 06:52 AM, Max Reitz wrote: > On 2018-08-24 00:08, John Snow wrote: >> Jobs are now expected to return their retcode on the stack, from the >> .run callback, so we can remove that argument. >> >> job_cancel does not need to set -ECANCELED because job_completed will >> update the

[Qemu-devel] [PATCH v2 0/2] chardev: Add websocket support

2018-08-27 Thread Julia Suvorova via Qemu-devel
v2: * Fixed initialization order [Daniel] * Function arguments refactoring [Paolo] * Added test [Stefan] * Added meaningful error message [Stefan] * Added "websock:" URI prefix support Julia Suvorova (2): chardev: Add websocket support tests/test-char: Check websocket

[Qemu-devel] [PATCH v2 2/2] tests/test-char: Check websocket chardev functionality

2018-08-27 Thread Julia Suvorova via Qemu-devel
Test order: Creating server websocket chardev Creating usual tcp chardev client Sending handshake message from client Receiving handshake reply Sending ping frame with "hello" payload Receiving pong reply Sending binary data "world" Checking the received data on

[Qemu-devel] [PATCH v2 1/2] chardev: Add websocket support

2018-08-27 Thread Julia Suvorova via Qemu-devel
New option "websock" added to allow using websocket protocol for chardev socket backend. Example: -chardev socket,websock,id=... Signed-off-by: Julia Suvorova --- chardev/char-socket.c | 124 +++--- chardev/char.c| 8 ++- qapi/char.json|

Re: [Qemu-devel] [PATCH v2 1/6] target/mips: Add MXU instructions S32I2M and S32M2I

2018-08-27 Thread Aleksandar Markovic
> From: Craig Janeczek > Sent: Monday, August 27, 2018 4:38 PM > Subject: [PATCH v2 1/6] target/mips: Add MXU instructions S32I2M and S32M2I > > This commit makes the MXU registers and the utility functions for > reading/writing to them. This is required for full MXU instruction > support. > >

[Qemu-devel] Hints for a networkable console

2018-08-27 Thread Vincenzo Romano
I'd like to work on an idea that could be explained with the examples below. -nographic \ -chardev socket,id=console,host=127.1.2.3,port=1234,server \ -display curses,chardev=console and -nographic \ -chardev socket,id=console,path=/tmp/asocket,server \ -display curses,chardev=console This

Re: [Qemu-devel] [PATCH 5/6] json: Eliminate lexer state IN_ERROR

2018-08-27 Thread Eric Blake
On 08/27/2018 02:00 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- qobject/json-lexer.c | 9 + qobject/json-parser-int.h | 8 2 files changed, 9 insertions(+), 8 deletions(-) - typedef enum json_token_type { -JSON_MIN = 100, -JSON_LCURLY

Re: [Qemu-devel] [PATCH 6/6] json: Eliminate lexer state IN_WHITESPACE, pseudo-token JSON_SKIP

2018-08-27 Thread Eric Blake
On 08/27/2018 02:00 AM, Markus Armbruster wrote: The lexer ignores whitespace like this: on whitespace on non-ws spontaneously IN_START --> IN_WHITESPACE --> JSON_SKIP --> IN_START ^| \__/ on whitespace This accumulates a

Re: [Qemu-devel] [PATCH 4/6] json: Nicer recovery from lexical errors

2018-08-27 Thread Eric Blake
On 08/27/2018 02:00 AM, Markus Armbruster wrote: When the lexer chokes on an input character, it consumes the character, emits a JSON error token, and enters its start state. This can lead to suboptimal error recovery. For instance, input 0123 , produces the tokens JSON_ERROR

Re: [Qemu-devel] [Qemu-ppc] [PATCH] 40p: fix PCI interrupt routing

2018-08-27 Thread BALATON Zoltan
On Mon, 27 Aug 2018, Mark Cave-Ayland wrote: According to the PReP specification section 6.1.6 "System Interrupt Assignments", all PCI interrupts are routed via IRQ 15. With this patch applied it is now possible to boot the sandalfoot zImage all the way through to a working userspace when using

Re: [Qemu-devel] [PATCH 5/6] json: Eliminate lexer state IN_ERROR

2018-08-27 Thread Eric Blake
On 08/27/2018 02:00 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- qobject/json-lexer.c | 9 + qobject/json-parser-int.h | 8 2 files changed, 9 insertions(+), 8 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red

Re: [Qemu-devel] [PATCH 3/6] json: Make lexer's "character consumed" logic less confusing

2018-08-27 Thread Eric Blake
On 08/27/2018 02:00 AM, Markus Armbruster wrote: The lexer uses macro TERMINAL_NEEDED_LOOKAHEAD() to decide whether a state transition consumes the input character. It returns true when the state transition is defined with the TERMINAL() macro. To detect that, it checks whether input '\0'

Re: [Qemu-devel] [PATCH 2/6] json: Clean up how lexer consumes "end of input"

2018-08-27 Thread Eric Blake
On 08/27/2018 02:00 AM, Markus Armbruster wrote: When the lexer isn't in its start state at the end of input, it's working on a token. To flush it out, it needs to transit to its start state on "end of input" lookahead. There are two ways to the start state, depending on the current state: *

Re: [Qemu-devel] [PULL v2 0/3] Error reporting patches for 2018-08-27

2018-08-27 Thread Peter Maydell
On 27 August 2018 at 14:48, Markus Armbruster wrote: > The following changes since commit 235c82acca0491465e94be3cae2583b42d37c859: > > Merge remote-tracking branch 'remotes/otubo/tags/pull-seccomp-20180823' > into staging (2018-08-25 13:08:57 +0100) > > are available in the Git repository at:

Re: [Qemu-devel] [PATCH 1/6] json: Fix lexer for lookahead character beyond '\x7F'

2018-08-27 Thread Eric Blake
On 08/27/2018 02:00 AM, Markus Armbruster wrote: The lexer fails to end a valid token when the lookahead character is beyond '\x7F'. For instance, input true\xC2\xA2 produces the tokens JSON_ERROR true\xC2 JSON_ERROR \xA2 The first token should be JSON_KEYWORD

Re: [Qemu-devel] [PATCH 4/4] net: Remove the deprecated -tftp, -bootp, -redir and -smb options

2018-08-27 Thread Thomas Huth
On 2018-08-27 18:11, Peter Maydell wrote: > On 27 August 2018 at 15:54, Thomas Huth wrote: >> These options likely do not work as expected as soon as the user >> tries to use more than one network interface at once. The parameters >> have been marked as deprecated since QEMU v2.6, so users had

Re: [Qemu-devel] [PATCH 4/4] net: Remove the deprecated -tftp, -bootp, -redir and -smb options

2018-08-27 Thread Peter Maydell
On 27 August 2018 at 15:54, Thomas Huth wrote: > These options likely do not work as expected as soon as the user > tries to use more than one network interface at once. The parameters > have been marked as deprecated since QEMU v2.6, so users had plenty > of time to move their scripts to the new

Re: [Qemu-devel] [Qemu-block] [PATCH v0 0/2] Postponed actions

2018-08-27 Thread John Snow
On 08/27/2018 03:05 AM, Denis Plotnikov wrote: > PING! PING! > Sorry, Kevin and Stefan are both on PTO right now, I think. I can't promise I have the time to look soon, but you at least deserve an answer for the radio silence the last week. --js > On 14.08.2018 10:08, Denis Plotnikov wrote:

Re: [Qemu-devel] [PATCH 1/7] jobs: change start callback to run callback

2018-08-27 Thread John Snow
On 08/25/2018 09:33 AM, Max Reitz wrote: > On 2018-08-23 01:01, John Snow wrote: >> >> >> On 08/22/2018 06:51 AM, Max Reitz wrote: >>> On 2018-08-17 21:04, John Snow wrote: Presently we codify the entry point for a job as the "start" callback, but a more apt name would be "run" to

Re: [Qemu-devel] [PATCH 3/7] jobs: add exit shim

2018-08-27 Thread John Snow
On 08/25/2018 09:05 AM, Max Reitz wrote: > On 2018-08-22 23:52, John Snow wrote: >> >> >> On 08/22/2018 07:43 AM, Max Reitz wrote: >>> On 2018-08-17 21:04, John Snow wrote: All jobs do the same thing when they leave their running loop: - Store the return code in a structure -

Re: [Qemu-devel] [PULL 0/9] Disable tests when device is not compiled in

2018-08-27 Thread Peter Maydell
the Git repository at: > > git://github.com/juanquintela/qemu.git tags/check/20180827 > > for you to fetch changes up to ee1f6c812b3240420dff07a3860060b7d4abfe09: > > check: Move wdt_ib700 test to common (2018-08-27 11:27:07 +0200) > > ---

Re: [Qemu-devel] [libvirt] [PATCH 0/4] Remove more deprecated options

2018-08-27 Thread Ján Tomko
On Mon, Aug 27, 2018 at 05:08:45PM +0200, Peter Krempa wrote: On Mon, Aug 27, 2018 at 16:54:08 +0200, Thomas Huth wrote: These options are deprecated since at least two releases, and nobody complained. Time to remove them now. (I'm sending these patches as a series since Paolo asked me to send

Re: [Qemu-devel] [PATCH V4 4/4] target-i386: add i440fx 0xcf8 portascoalesced_pio

2018-08-27 Thread peng.hao2
>On Mon, Aug 27, 2018 at 04:25:00PM +0800, peng.h...@zte.com.cn wrote: >> >> On 25 Aug 2018, at 15:19, Peng Hao wrote: >> >> >> >> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c >> >> index 0e60834..da73743 100644 >> >> --- a/hw/pci-host/piix.c >> >> +++ b/hw/pci-host/piix.c >> >> @@

Re: [Qemu-devel] [PATCH v2] vl.c deprecate incorrect CPUs topology

2018-08-27 Thread Andrew Jones
On Mon, Aug 27, 2018 at 03:53:26PM +0200, Igor Mammedov wrote: > -smp [cpus],sockets/cores/threads[,maxcpus] should describe topology > so that total number of logical CPUs [sockets * cores * threads] > would be equal to [maxcpus], however historically we didn't have > such check in QEMU and it is

Re: [Qemu-devel] [libvirt] [PATCH 0/4] Remove more deprecated options

2018-08-27 Thread Peter Krempa
On Mon, Aug 27, 2018 at 16:54:08 +0200, Thomas Huth wrote: > These options are deprecated since at least two releases, and nobody > complained. Time to remove them now. > > (I'm sending these patches as a series since Paolo asked me to send a PULL > request on my own for them ... but if one of

[Qemu-devel] [PATCH 3/4] Remove the deprecated options -startdate, -localtime and -rtc-td-hack

2018-08-27 Thread Thomas Huth
Deprecated since two releases, nobody complained, thus it's time to remove them now. Signed-off-by: Thomas Huth --- qemu-deprecated.texi | 13 - qemu-options.hx | 7 - vl.c | 76 +++- 3 files changed, 22

[Qemu-devel] [PATCH 1/4] Remove the deprecated -balloon option

2018-08-27 Thread Thomas Huth
The "-balloon" option has been replaced by "-device virtio-balloon". It's been marked as deprecated since two releases, and nobody complained, so let's remove it now. Acked-by: Paolo Bonzini Reviewed-by: Daniel P. Berrangé Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PATCH 4/4] net: Remove the deprecated -tftp, -bootp, -redir and -smb options

2018-08-27 Thread Thomas Huth
These options likely do not work as expected as soon as the user tries to use more than one network interface at once. The parameters have been marked as deprecated since QEMU v2.6, so users had plenty of time to move their scripts to the new syntax. Time to remove the old parameters now.

[Qemu-devel] [PATCH 2/4] Remove the deprecated -nodefconfig option

2018-08-27 Thread Thomas Huth
It's the same as -no-user-config and marked as deprecated since three releases already. Time to remove it now. Signed-off-by: Thomas Huth --- docs/interop/live-block-operations.rst | 4 ++-- qemu-deprecated.texi | 4 qemu-options.hx| 4 ++-- vl.c

[Qemu-devel] [PATCH 0/4] Remove more deprecated options

2018-08-27 Thread Thomas Huth
These options are deprecated since at least two releases, and nobody complained. Time to remove them now. (I'm sending these patches as a series since Paolo asked me to send a PULL request on my own for them ... but if one of the subsystems maintainers prefers to take the patches through their

[Qemu-devel] [PATCH v2 4/6] target/mips: Add MXU instruction D16MAC

2018-08-27 Thread Craig Janeczek via Qemu-devel
Adds support for emulating the D16MAC instruction. Signed-off-by: Craig Janeczek --- v1 - initial patch v2 - changed bitfield usage to extract32 - used sextract_tl instructions instead of shift and ext target/mips/translate.c | 62 - 1 file

[Qemu-devel] [PATCH v2 3/6] target/mips: Add MXU instruction D16MUL

2018-08-27 Thread Craig Janeczek via Qemu-devel
Adds support for emulating the D16MUL instruction. Signed-off-by: Craig Janeczek --- v1 - initial patch v2 - changed bitfield usage to extract32 - used sextract_tl instructions instead of shift and ext target/mips/translate.c | 51 +++-- 1 file

Re: [Qemu-devel] [PATCH v5 12/13] target/arm: Mark PMINTENSET accesses as possibly doing IO

2018-08-27 Thread Aaron Lindsay
On Jun 28 17:25, Peter Maydell wrote: > Shouldn't PMINTENCLR and PMINTENCLR_EL1 also be ARM_CP_IO ? Yes, that was an oversight - I've added a patch addressing this for v6. -Aaron

[Qemu-devel] [PATCH v2 5/6] target/mips: Add MXU instructions Q8MUL and Q8MULSU

2018-08-27 Thread Craig Janeczek via Qemu-devel
Adds support for emulating the Q8MUL and Q8MULSU instructions. Signed-off-by: Craig Janeczek --- v1 - initial patch v2 - changed bitfield usage to extract32 target/mips/translate.c | 70 - 1 file changed, 69 insertions(+), 1 deletion(-) diff

[Qemu-devel] [PATCH v2 6/6] target/mips: Add MXU instructions S32LDD and S32LDDR

2018-08-27 Thread Craig Janeczek via Qemu-devel
Adds support for emulating the S32LDD and S32LDDR MXU instructions. Signed-off-by: Craig Janeczek --- v1 - initial patch v2 - changed bitfield usage to extract32 target/mips/translate.c | 43 - 1 file changed, 38 insertions(+), 5 deletions(-)

[Qemu-devel] [PATCH v2 0/6] Add limited MXU instruction support

2018-08-27 Thread Craig Janeczek via Qemu-devel
This patch set begins to add MXU instruction support for mips emulation. Craig Janeczek (6): target/mips: Add MXU instructions S32I2M and S32M2I target/mips: Add MXU instruction S8LDD target/mips: Add MXU instruction D16MUL target/mips: Add MXU instruction D16MAC target/mips: Add MXU

[Qemu-devel] [PATCH v2 1/6] target/mips: Add MXU instructions S32I2M and S32M2I

2018-08-27 Thread Craig Janeczek via Qemu-devel
This commit makes the MXU registers and the utility functions for reading/writing to them. This is required for full MXU instruction support. Adds support for emulating the S32I2M and S32M2I MXU instructions. Signed-off-by: Craig Janeczek --- v1 - initial patch v2 - Fix checkpatch.pl

Re: [Qemu-devel] [PATCH] pc: make sure that guest isn't able to unplug the first cpu

2018-08-27 Thread Igor Mammedov
On Mon, 27 Aug 2018 16:02:39 +0200 Greg Kurz wrote: > On Mon, 27 Aug 2018 13:07:10 +0200 > Igor Mammedov wrote: > > > The first cpu unplug wasn't ever supported and corresponding > > monitor/qmp commands refuse to unplug it. However guest is able > > to issue eject request either using

Re: [Qemu-devel] [Qemu-ppc] [PULL 25/26] spapr_pci: factorize the use of SPAPR_MACHINE_GET_CLASS()

2018-08-27 Thread Greg Kurz
On Mon, 27 Aug 2018 11:03:39 +0200 Greg Kurz wrote: > On Mon, 27 Aug 2018 08:21:48 +0200 > Thomas Huth wrote: > > > On 2018-08-24 18:43, Cédric Le Goater wrote: > > > On 08/24/2018 05:38 PM, Greg Kurz wrote: > > >> On Fri, 24 Aug 2018 17:30:12 +0200 > > >> Cédric Le Goater wrote: > > >>

[Qemu-devel] [Bug 1755912] Re: qemu-system-x86_64 crashed with SIGABRT when using option -vga qxl

2018-08-27 Thread Łukasz Zemczak
Hello Leonardo, or anyone else affected, Accepted qemu into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/qemu/1:2.11+dfsg- 1ubuntu7.5 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Qemu-devel] [Bug 1780812] Re: Full-Screen Switch Does Nothing When Using SDL

2018-08-27 Thread Thomas Huth
Fix has been merged: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=6fb34ffcaae0823 ** Changed in: qemu Status: New => Fix Committed ** Changed in: qemu Assignee: (unassigned) => Thomas Huth (th-huth) -- You received this bug notification because you are a member of qemu-

[Qemu-devel] [PATCH v2 2/6] target/mips: Add MXU instruction S8LDD

2018-08-27 Thread Craig Janeczek via Qemu-devel
Adds support for emulating the S8LDD MXU instruction. Signed-off-by: Craig Janeczek --- v1 - initial patch v2 - changed bitfield usage to extract32 - used deposit_tl instructions instead of shift and bitmask target/mips/translate.c | 62 +++--

Re: [Qemu-devel] [PATCH v2 13/13] block/backup: qapi documentation fixup

2018-08-27 Thread Max Reitz
On 2018-08-24 00:22, John Snow wrote: > Fix documentation to match the other jobs amended for 3.1. > > Signed-off-by: John Snow > --- > qapi/block-core.json | 18 ++ > 1 file changed, 10 insertions(+), 8 deletions(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP

Re: [Qemu-devel] [PATCH v2 12/13] qapi/block-stream: expose new job properties

2018-08-27 Thread Max Reitz
On 2018-08-24 00:22, John Snow wrote: > Signed-off-by: John Snow > --- > blockdev.c | 9 + > hmp.c| 5 +++-- > qapi/block-core.json | 16 +++- > 3 files changed, 27 insertions(+), 3 deletions(-) [...] > diff --git a/hmp.c b/hmp.c > index

Re: [Qemu-devel] [PATCH] tests: vm: auto_install OpenBSD

2018-08-27 Thread Brad Smith
On 8/27/2018 5:18 AM, Fam Zheng wrote: On Fri, 08/24 10:36, Brad Smith wrote: I very much appreciate the effort to bump up to 6.3 as I was going to suggest doing that at some point. But bumping up to 6.3 at the moment will fail with the configure script. We've switched from GCC 4.2 to Clang.

Re: [Qemu-devel] [PATCH v9 6/6] tpm: add ACPI memory clear interface

2018-08-27 Thread Stefan Berger
On 08/14/2018 06:02 AM, Marc-André Lureau wrote: --- a/docs/specs/tpm.txt +++ b/docs/specs/tpm.txt @@ -121,6 +121,8 @@ layout: +--+++---+ | next_step| 0x1 | 0x159 | Operation to execute after reboot by | |

[Qemu-devel] [PULL v2 2/3] intel-iommu: start to use error_report_once

2018-08-27 Thread Markus Armbruster
From: Peter Xu Replace existing trace_vtd_err() with error_report_once() then stderr will capture something if any of the error happens, meanwhile we don't suffer from any DDOS. Then remove the trace point. Since at it, provide more information where proper (now we can pass parameters into the

[Qemu-devel] [PULL v2 1/3] qemu-error: introduce {error|warn}_report_once

2018-08-27 Thread Markus Armbruster
From: Peter Xu There are many error_report()s that can be used in frequently called functions, especially on IO paths. That can be unideal in that malicious guest can try to trigger the error tons of time which might use up the log space on the host (e.g., libvirt can capture the stderr of QEMU

[Qemu-devel] [PULL v2 3/3] intel-iommu: replace more vtd_err_* traces

2018-08-27 Thread Markus Armbruster
From: Peter Xu Replace all the trace_vtd_err_*() hooks with the new error_report_once() since they are similar to trace_vtd_err() - dumping the first error would be mostly enough, then we have them on by default too. Signed-off-by: Peter Xu Message-Id:

Re: [Qemu-devel] [PATCH v2 09/13] jobs: remove .exit callback

2018-08-27 Thread Max Reitz
On 2018-08-24 00:22, John Snow wrote: > Now that all of the jobs use the component finalization callbacks, > there's no use for the heavy-hammer .exit callback anymore. > > job_exit becomes a glorified type shim so that we can call > job_completed from aio_bh_schedule_oneshot. > > Move these

Re: [Qemu-devel] [PATCH] pc: make sure that guest isn't able to unplug the first cpu

2018-08-27 Thread Greg Kurz
On Mon, 27 Aug 2018 13:07:10 +0200 Igor Mammedov wrote: > The first cpu unplug wasn't ever supported and corresponding > monitor/qmp commands refuse to unplug it. However guest is able > to issue eject request either using following command: > # echo 1

[Qemu-devel] [PULL v2 0/3] Error reporting patches for 2018-08-27

2018-08-27 Thread Markus Armbruster
The following changes since commit 235c82acca0491465e94be3cae2583b42d37c859: Merge remote-tracking branch 'remotes/otubo/tags/pull-seccomp-20180823' into staging (2018-08-25 13:08:57 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git

Re: [Qemu-devel] [PATCH] vl.c deprecate incorrect CPUs topology

2018-08-27 Thread Igor Mammedov
On Mon, 27 Aug 2018 14:13:43 +0200 Andrew Jones wrote: > On Mon, Aug 27, 2018 at 01:56:08PM +0200, Igor Mammedov wrote: > > -smp [cpus],sockets/cores/threads[,maxcpus] should describe topology > > so that total number of logical CPUs [sockets * cores * threads] > > would be equal to [maxcpus],

Re: [Qemu-devel] [PATCH] input-linux: toggle for lock keys

2018-08-27 Thread Ryan El Kochta via Qemu-devel
I personally use the Scroll Lock key. On Linux, Scroll Lock (along with all the other lock keys) is easy to disable with an xmodmap command. On Windows (or, I'd assume, other guests), it requires third party software, which is why it's likely easier to just filter them out from QEMU.

[Qemu-devel] [PATCH v2] vl.c deprecate incorrect CPUs topology

2018-08-27 Thread Igor Mammedov
-smp [cpus],sockets/cores/threads[,maxcpus] should describe topology so that total number of logical CPUs [sockets * cores * threads] would be equal to [maxcpus], however historically we didn't have such check in QEMU and it is possible to start VM with an invalid topology. Deprecate invalid

Re: [Qemu-devel] [PATCH v2 10/13] qapi/block-commit: expose new job properties

2018-08-27 Thread Max Reitz
On 2018-08-24 00:22, John Snow wrote: > Signed-off-by: John Snow > --- > blockdev.c | 8 > qapi/block-core.json | 16 +++- > 2 files changed, 23 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PULL 00/12] Ui 20180827 v4 patches

2018-08-27 Thread Peter Maydell
the git repository at: > > git://git.kraxel.org/qemu tags/ui-20180827-v4-pull-request > > for you to fetch changes up to b1d380372f31672da9318431e84e79bccd8ef3bf: > > util: promote qemu_egl_rendernode_open() to libqe

Re: [Qemu-devel] [PATCH v2 11/13] qapi/block-mirror: expose new job properties

2018-08-27 Thread Max Reitz
On 2018-08-24 00:22, John Snow wrote: > Signed-off-by: John Snow > --- > blockdev.c | 14 ++ > qapi/block-core.json | 30 -- > 2 files changed, 42 insertions(+), 2 deletions(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP

Re: [Qemu-devel] [PATCH] 40p: fix PCI interrupt routing

2018-08-27 Thread Mark Cave-Ayland
On 27/08/18 12:05, Mark Cave-Ayland wrote: > According to the PReP specification section 6.1.6 "System Interrupt > Assignments", all PCI interrupts are routed via IRQ 15. > > With this patch applied it is now possible to boot the sandalfoot > zImage all the way through to a working userspace

Re: [Qemu-devel] [PATCH v2 08/13] tests/test-blockjob: remove exit callback

2018-08-27 Thread Max Reitz
On 2018-08-24 00:22, John Snow wrote: > We remove the exit callback and the completed boolean along with it. > We can simulate it just fine by waiting for the job to defer to the > main loop, and then giving it one final kick to get the main loop > portion to run. > > Signed-off-by: John Snow >

  1   2   3   >