[Qemu-devel] [PATCH] fw_cfg: print error message when reading splashfile failed

2018-10-23 Thread Li Qiang
Also remove unnecessary 'res' variable. Signed-off-by: Li Qiang --- hw/nvram/fw_cfg.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 946f765..f4a52d8 100644 --- a/hw/nvram/fw_cfg.c +++ b/hw/nvram/fw_cfg.c @@ -68,15 +68,14

Re: [Qemu-devel] [PULL v2 00/40] Error reporting patches for 2018-10-22

2018-10-23 Thread Markus Armbruster
Peter Maydell writes: > On 23 October 2018 at 14:04, Markus Armbruster wrote: >> The following changes since commit b312532fd03413d0e6ae6767ec793a3e30f487b8: >> >> Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into >> staging (2018-10-19 19:01:07 +0100) >> >> are available

Re: [Qemu-devel] [PATCH v2] s390x/pci: add common fmb

2018-10-23 Thread Yi Min Zhao
在 2018/10/24 上午5:25, Cornelia Huck 写道: On Mon, 22 Oct 2018 13:17:34 +0100 Thomas Huth wrote: On 2018-10-22 10:02, Yi Min Zhao wrote: Common function measurement block is used to report counters of successfully issued pcilg/stg/stb and rpcit instructions. This patch introduces a new struct

[Qemu-devel] [PATCH] vl.c: print error message if loading fw_cfg file failed

2018-10-23 Thread Li Qiang
It makes sense to print the error message while reading file failed. Signed-off-by: Li Qiang --- vl.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index b2a405f..ee6f982 100644 --- a/vl.c +++ b/vl.c @@ -2234,8 +2234,10 @@ static int parse_fw_cfg(void

[Qemu-devel] [PATCH] linux-user/flatload: fix initial stack pointer alignment

2018-10-23 Thread Max Filippov
Stack pointer alignment code incorrectly adds stack_size to sp instead of subtracting it. It also does not take flat_argvp_envp_on_stack() into account when calculating stack_size. This results in initial stack pointer misalignment with certain set of command line arguments and environment

[Qemu-devel] [PULL 26/28] piix: use TYPE_FOO constants than string constats

2018-10-23 Thread Michael S. Tsirkin
From: Li Qiang Make them more QOMConventional. Cc:qemu-triv...@nongnu.org Signed-off-by: Li Qiang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/pci-host/piix.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-)

[Qemu-devel] [PULL 20/28] tests/bios-tables-test: add 64-bit PCI MMIO aperture round-up test on Q35

2018-10-23 Thread Michael S. Tsirkin
From: Laszlo Ersek In commit 9fa99d2519cb ("hw/pci-host: Fix x86 Host Bridges 64bit PCI hole", 2017-11-16), we meant to expose such a 64-bit PCI MMIO aperture in the ACPI DSDT that would be at least as large as the new "pci-hole64-size" property (2GB on i440fx, 32GB on q35). The goal was to

[Qemu-devel] [PULL 28/28] vhost-scsi: prevent using uninitialized vqs

2018-10-23 Thread Michael S. Tsirkin
From: yuchenlin There are 3 virtqueues (ctrl, event and cmd) for virtio scsi device, but seabios will only set the physical address for the 3rd one (cmd). Then in vhost_virtqueue_start(), virtio_queue_get_desc_addr() will be 0 for ctrl and event vq. In this case, ctrl and event vq are not

[Qemu-devel] [PULL 19/28] hw/pci-host/x86: extend the 64-bit PCI hole relative to the fw-assigned base

2018-10-23 Thread Michael S. Tsirkin
From: Laszlo Ersek In commit 9fa99d2519cb ("hw/pci-host: Fix x86 Host Bridges 64bit PCI hole", 2017-11-16), we meant to expose such a 64-bit PCI MMIO aperture in the ACPI DSDT that would be at least as large as the new "pci-hole64-size" property (2GB on i440fx, 32GB on q35). The goal was to

[Qemu-devel] [PULL 15/28] x86_iommu/amd: Enable Guest virtual APIC support

2018-10-23 Thread Michael S. Tsirkin
From: "Singh, Brijesh" Now that amd-iommu support interrupt remapping, enable the GASup in IVRS table and GASup in extended feature register to indicate that IOMMU support guest virtual APIC mode. GASup provides option to guest OS to make use of 128-bit IRTE. Note that the GAMSup is set to zero

[Qemu-devel] [PULL 22/28] hw/pci-bridge/ioh3420: Remove unuseful header

2018-10-23 Thread Michael S. Tsirkin
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/pci-bridge/ioh3420.h | 6 -- hw/pci-bridge/ioh3420.c | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) delete mode 100644

[Qemu-devel] [PULL 27/28] piix_pci: fix i440fx data sheet link

2018-10-23 Thread Michael S. Tsirkin
From: Li Qiang It seems that the intel link is unavailable, change it to point to the qemu site. Signed-off-by: Li Qiang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Marcel Apfelbaum Acked-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- hw/pci-host/piix.c | 2 +- 1 file

[Qemu-devel] [PULL 14/28] x86_iommu/amd: Add interrupt remap support when VAPIC is enabled

2018-10-23 Thread Michael S. Tsirkin
From: "Singh, Brijesh" Emulate the interrupt remapping support when guest virtual APIC is enabled. For more information refer: IOMMU spec rev 3.0 (section 2.2.5.2) When VAPIC is enabled, it uses interrupt remapping as defined in Table 22 and Figure 17 from IOMMU spec. Signed-off-by: Brijesh

[Qemu-devel] [PULL 23/28] hw/pci: Add missing include

2018-10-23 Thread Michael S. Tsirkin
From: Philippe Mathieu-Daudé Noted while refactoring: CC mips-softmmu/hw/mips/gt64xxx_pci.o In file included from include/hw/pci-host/gt64xxx.h:2, from hw/mips/gt64xxx_pci.c:30: include/hw/pci/pci_bus.h:23:5: error: unknown type name ‘PCIIOMMUFunc’

[Qemu-devel] [PULL 03/28] intel_iommu: better handling of dmar state switch

2018-10-23 Thread Michael S. Tsirkin
From: Peter Xu QEMU is not handling the global DMAR switch well, especially when from "on" to "off". Let's first take the example of system reset. Assuming that a guest has IOMMU enabled. When it reboots, we will drop all the existing DMAR mappings to handle the system reset, however we'll

[Qemu-devel] [PULL 25/28] i440fx: use ARRAY_SIZE for pam_regions

2018-10-23 Thread Michael S. Tsirkin
From: Li Qiang Cc: qemu-triv...@nongnu.org Signed-off-by: Li Qiang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/pci-host/piix.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/piix.c

[Qemu-devel] [PULL 12/28] x86_iommu/amd: Add interrupt remap support when VAPIC is not enabled

2018-10-23 Thread Michael S. Tsirkin
From: "Singh, Brijesh" Emulate the interrupt remapping support when guest virtual APIC is not enabled. For more info Refer: AMD IOMMU spec Rev 3.0 - section 2.2.5.1 When VAPIC is not enabled, it uses interrupt remapping as defined in Table 20 and Figure 15 from IOMMU spec. Signed-off-by:

[Qemu-devel] [PULL 24/28] pci_bridge: fix typo in comment

2018-10-23 Thread Michael S. Tsirkin
From: Mao Zhongyi Signed-off-by: Mao Zhongyi Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/pci/pci_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c index

[Qemu-devel] [PULL 17/28] pci-testdev: add optional memory bar

2018-10-23 Thread Michael S. Tsirkin
From: Gerd Hoffmann Add memory bar to pci-testdev. Size is configurable using the membar property. Setting the size to zero (default) turns it off. Can be used to check whether guests handle large pci bars correctly. Reviewed-by: Marc-André Lureau Reviewed-by: Laszlo Ersek Tested-by:

[Qemu-devel] [PULL 11/28] x86_iommu/amd: Prepare for interrupt remap support

2018-10-23 Thread Michael S. Tsirkin
From: "Singh, Brijesh" Register the interrupt remapping callback and read/write ops for the amd-iommu-ir memory region. amd-iommu-ir is set to higher priority to ensure that this region won't be masked out by other memory regions. Signed-off-by: Brijesh Singh Cc: Peter Xu Cc: "Michael S.

[Qemu-devel] [PULL 16/28] MAINTAINERS: list "tests/acpi-test-data" files in ACPI/SMBIOS section

2018-10-23 Thread Michael S. Tsirkin
From: Laszlo Ersek The "tests/acpi-test-data" files are currently not covered by any section in MAINTAINERS, and "scripts/checkpatch.pl" complains when new data files are added. Cc: "Michael S. Tsirkin" Cc: Alex Williamson Cc: Gerd Hoffmann Cc: Igor Mammedov Cc: Marcel Apfelbaum

[Qemu-devel] [PULL 00/28] pci, pc, virtio: fixes, features

2018-10-23 Thread Michael S. Tsirkin
The following changes since commit 13399aad4fa87b2878c49d02a5d3bafa6c966ba3: Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-10-22' into staging (2018-10-23 17:20:23 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git

[Qemu-devel] [PULL 09/28] x86_iommu/amd: remove V=1 check from amdvi_validate_dte()

2018-10-23 Thread Michael S. Tsirkin
From: "Singh, Brijesh" Currently, the amdvi_validate_dte() assumes that a valid DTE will always have V=1. This is not true. The V=1 means that bit[127:1] are valid. A valid DTE can have IV=1 and V=0 (i.e address translation disabled and interrupt remapping enabled) Remove the V=1 check from

[Qemu-devel] [PULL 08/28] x86_iommu: move vtd_generate_msi_message in common file

2018-10-23 Thread Michael S. Tsirkin
From: "Singh, Brijesh" The vtd_generate_msi_message() in intel-iommu is used to construct a MSI Message from IRQ. A similar function will be needed when we add interrupt remapping support in amd-iommu. Moving the function in common file to avoid the code duplication. Rename it to

[Qemu-devel] [PULL 18/28] hw/pci-host/x86: extract get_pci_hole64_start_value() helpers

2018-10-23 Thread Michael S. Tsirkin
From: Laszlo Ersek Expose the calculated "hole64 start" GPAs as plain uint64_t values, extracting the internals of the current property getters. This patch doesn't change behavior. Cc: "Michael S. Tsirkin" Cc: Alex Williamson Cc: Gerd Hoffmann Cc: Igor Mammedov Cc: Marcel Apfelbaum

[Qemu-devel] [PULL 05/28] intel_iommu: handle invalid ce for shadow sync

2018-10-23 Thread Michael S. Tsirkin
From: Peter Xu We should handle VTD_FR_CONTEXT_ENTRY_P properly when synchronizing shadow page tables. Having invalid context entry there is perfectly valid when we move a device out of an existing domain. When that happens, instead of posting an error we invalidate the whole region. Without

[Qemu-devel] [PULL 21/28] hw/pci-bridge/xio3130: Remove unused functions

2018-10-23 Thread Michael S. Tsirkin
From: Philippe Mathieu-Daudé Introduced in 48ebf2f90f8 and faf1e708d5b, these functions were never used. Remove them. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/pci-bridge/xio3130_downstream.h | 11 ---

[Qemu-devel] [PULL 06/28] vhost-user-blk: start vhost when guest kicks

2018-10-23 Thread Michael S. Tsirkin
From: Yongji Xie Some old guests (before commit 7a11370e5: "virtio_blk: enable VQs early") kick virtqueue before setting VIRTIO_CONFIG_S_DRIVER_OK. This violates the virtio spec. But virtio 1.0 transitional devices support this behaviour. So we should start vhost when guest kicks in this case.

[Qemu-devel] [PULL 10/28] x86_iommu/amd: make the address space naming consistent with intel-iommu

2018-10-23 Thread Michael S. Tsirkin
From: "Singh, Brijesh" To be consistent with intel-iommu: - rename the address space to use '_' instead of '-' - update the memory region relationships Signed-off-by: Brijesh Singh Reviewed-by: Peter Xu Cc: Peter Xu Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: Richard Henderson Cc:

[Qemu-devel] [PULL 01/28] virtio-blk: fix comment for virtio_blk_rw_complete

2018-10-23 Thread Michael S. Tsirkin
From: Yaowei Bai Here should be submit_requests, there is no submit_merged_requests function. Signed-off-by: Yaowei Bai Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/block/virtio-blk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PULL 07/28] x86_iommu: move the kernel-irqchip check in common code

2018-10-23 Thread Michael S. Tsirkin
From: "Singh, Brijesh" Interrupt remapping needs kernel-irqchip={off|split} on both Intel and AMD platforms. Move the check in common place. Signed-off-by: Brijesh Singh Reviewed-by: Peter Xu Cc: Peter Xu Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost

[Qemu-devel] [PULL 13/28] i386: acpi: add IVHD device entry for IOAPIC

2018-10-23 Thread Michael S. Tsirkin
From: "Singh, Brijesh" When interrupt remapping is enabled, add a special IVHD device (type IOAPIC). Signed-off-by: Brijesh Singh Acked-by: Peter Xu Cc: Peter Xu Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: Tom Lendacky

[Qemu-devel] [PULL 02/28] intel_iommu: introduce vtd_reset_caches()

2018-10-23 Thread Michael S. Tsirkin
From: Peter Xu Provide the function and use it in vtd_init(). Used to reset both context entry cache and iotlb cache for the whole IOMMU unit. Signed-off-by: Peter Xu Reviewed-by: Eric Auger Reviewed-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[Qemu-devel] [PULL 04/28] intel_iommu: move ce fetching out when sync shadow

2018-10-23 Thread Michael S. Tsirkin
From: Peter Xu There are two callers for vtd_sync_shadow_page_table_range(): one provided a valid context entry and one not. Move that fetching operation into the caller vtd_sync_shadow_page_table() where we need to fetch the context entry. Meanwhile, remove the error_report_once() directly

Re: [Qemu-devel] [RFC v1] block/NVMe: introduce a new vhost NVMe host device to QEMU

2018-10-23 Thread Michael S. Tsirkin
On Tue, Jan 16, 2018 at 06:06:56PM +0100, Paolo Bonzini wrote: > Second, virtio-based vhost-user remains QEMU's preferred method for > high-performance I/O in guests. Discard support is missing and that is > important for SSDs; that should be fixed in the virtio spec. BTW could you reply on the

[Qemu-devel] [Bug 1798451] Re: HVF linux on OSX hangs 2nd time started after adding socket

2018-10-23 Thread Roman Bolshakov
Considering the fact that both Ubuntu and Elementary require SSE to boot, I'd wait to get decoding fixed. I wrote a test kernel module that reliably reproduces your issue on qemu edu device. Whenever QEMU prints Unimplemented handler Instruction pointer only moves two bytes further, instead of the

Re: [Qemu-devel] [PATCH 00/27] ACPI hardware-reduced support

2018-10-23 Thread Paolo Bonzini
On 22/10/2018 20:36, Samuel Ortiz wrote: > This patch set implements support for the ACPI hardware-reduced > specification. > > The changes are coming from the NEMU [1] project where we're defining > a new x86 machine type: i386/virt. This is an EFI only, ACPI > hardware-reduced platform and as

Re: [Qemu-devel] [PATCH v2] piix_pci: change the i440fx data sheet link

2018-10-23 Thread Michael S. Tsirkin
On Thu, Oct 11, 2018 at 09:18:20AM -0700, Li Qiang wrote: > Seems the intel link is unavailable, change it to qemu site. > > Signed-off-by: Li Qiang > Reviewed-by: Philippe Mathieu-Daudé BTW you need to fix up your setup: patches you sent confuse git am and other tools. Somethig to do with

Re: [Qemu-devel] [PATCH] vhost-user: fix qemu crash caused by failed backend

2018-10-23 Thread Michael S. Tsirkin
On Tue, Oct 02, 2018 at 01:54:25PM +0400, Marc-André Lureau wrote: > Hi > > On Thu, Sep 27, 2018 at 7:37 PM Liang Li wrote: > > > > During live migration, when stopping vhost-user device, 'vhost_dev_stop' > > will be called, 'vhost_dev_stop' will call a batch of 'vhost_user_read' > > and

Re: [Qemu-devel] [PATCH v2] lsi: Reselection needed to remove pending commands from queue

2018-10-23 Thread Paolo Bonzini
On 24/10/2018 00:11, George Kennedy wrote: >>> >> What about "req->hba_private != s->current"?  That should cause a call >> to lsi_queue_req, and then you can check s->want_resel in lsi_queue_req. > > For the extended period of time where lsi_queue_req() is not being > called from

Re: [Qemu-devel] [PATCH 18/26] hw: acpi: Initial hardware-reduced support

2018-10-23 Thread Paolo Bonzini
On 22/10/2018 20:36, Samuel Ortiz wrote: > + > +static void acpi_reduced_build_update(void *build_opaque) > +{ > +MachineState *ms = MACHINE(build_opaque); > +AcpiBuildState *build_state = ms->firmware_build_state.acpi.state; > +AcpiConfiguration *conf =

Re: [Qemu-devel] [PATCH 01/26] hw: i386: Decouple the ACPI build from the PC machine type

2018-10-23 Thread Paolo Bonzini
On 22/10/2018 20:36, Samuel Ortiz wrote: > +static void acpi_conf_pc_init(MachineState *machine) This should take a PCMachineState*, since you never use "machine" except for downcasting. Paolo > +{ > +PCMachineState *pcms = PC_MACHINE(machine); > +PCMachineClass *pcmc =

Re: [Qemu-devel] [PATCH 17/26] hw: i386: Convert PC machine type to firmware build methods

2018-10-23 Thread Paolo Bonzini
On 22/10/2018 20:36, Samuel Ortiz wrote: > +/* Firmware building handler */ > +mc->firmware_build_methods.acpi.madt = build_madt; > +mc->firmware_build_methods.acpi.rsdp = build_rsdp_rsdt; > +mc->firmware_build_methods.acpi.setup = acpi_setup; > +

Re: [Qemu-devel] [PATCH v8 00/38] target/mips: Limited support for the R5900

2018-10-23 Thread Maciej W. Rozycki
Hi Fredrik, > > target/mips/translate.c:4888:38: error: passing argument 3 of > > ‘tcg_gen_add2_i32’ from incompatible pointer type > > [-Werror=incompatible-pointer-types] > > tcg_gen_add2_i32(t2, t3, cpu_LO[acc], cpu_HI[acc], t2, t3); > >

Re: [Qemu-devel] [PATCH v4 0/2] intel_iommu: better handling of dmar state switch

2018-10-23 Thread Peter Xu
Hi, Michael, Just a kind reminder that this series has got enough ACKs and please consider to merge it in your next pull. Thanks! On Sat, Sep 29, 2018 at 11:36:13AM +0800, Peter Xu wrote: > v4: > - add a patch to introduce vtd_reset_caches() > - reset the caches in the two places where GCMD

Re: [Qemu-devel] [PATCH 18/26] hw: acpi: Initial hardware-reduced support

2018-10-23 Thread Paolo Bonzini
On 22/10/2018 20:36, Samuel Ortiz wrote: > We build a minimal set of ACPI hardware-reduced tables: XSDT, > FADT, MADT and a DSDT pointed by a RSDP. > The DSDT only contains one PCI host bridge for now. > > This API will be consumed by new x86 machine type but also potentially > by the ARM virt

Re: [Qemu-devel] [PATCH v3 0/2] intel_iommu: handle invalid ce for shadow sync

2018-10-23 Thread Peter Xu
Hi, Michael, Just a kind reminder that this series has got enough ACKs and please consider to merge it in your next pull. Thanks! On Tue, Oct 09, 2018 at 03:45:41PM +0800, Peter Xu wrote: > v3: > - pick r-b > - return when -VTD_FR_CONTEXT_ENTRY_P is detected (v1 is correct here, > but I did

Re: [Qemu-devel] [PATCH v2] lsi: Reselection needed to remove pending commands from queue

2018-10-23 Thread George Kennedy
On 10/23/2018 5:50 PM, Paolo Bonzini wrote: On 23/10/2018 23:36, George Kennedy wrote: On 10/23/2018 10:33 AM, Paolo Bonzini wrote: On 22/10/2018 23:28, George Kennedy wrote: As you suggested I moved the loading of "s->resel_dsp" down to the "Wait Reselect" case. The address of the

Re: [Qemu-devel] [PATCH v2] lsi: Reselection needed to remove pending commands from queue

2018-10-23 Thread Paolo Bonzini
On 23/10/2018 23:36, George Kennedy wrote: > > > On 10/23/2018 10:33 AM, Paolo Bonzini wrote: >> On 22/10/2018 23:28, George Kennedy wrote: >>> As you suggested I moved the loading of "s->resel_dsp" down to the >>> "Wait Reselect" >>> case. The address of the Reselection Scripts, though, is

[Qemu-devel] [PATCH] vl: Avoid crash when -mon is underspecified

2018-10-23 Thread Eric Blake
A quick coredump on an incomplete command line: ./x86_64-softmmu/qemu-system-x86_64 -mon mode=control,pretty=on #0 0x7723d9e4 in g_str_hash () at /lib64/libglib-2.0.so.0 #1 0x7723ce38 in g_hash_table_lookup () at /lib64/libglib-2.0.so.0 #2 0x55cc0073 in

Re: [Qemu-devel] [PATCH] vl: Avoid crash when -mon is underspecified

2018-10-23 Thread Paolo Bonzini
On 23/10/2018 23:35, Eric Blake wrote: > A quick coredump on an incomplete command line: > ./x86_64-softmmu/qemu-system-x86_64 -mon mode=control,pretty=on > > #0 0x7723d9e4 in g_str_hash () at /lib64/libglib-2.0.so.0 > #1 0x7723ce38 in g_hash_table_lookup () at

Re: [Qemu-devel] [PATCH v2] lsi: Reselection needed to remove pending commands from queue

2018-10-23 Thread George Kennedy
On 10/23/2018 10:33 AM, Paolo Bonzini wrote: On 22/10/2018 23:28, George Kennedy wrote: As you suggested I moved the loading of "s->resel_dsp" down to the "Wait Reselect" case. The address of the Reselection Scripts, though, is contained in "s->dsp - 8" and not in s->dnad. Are you sure?

Re: [Qemu-devel] [PATCH v2] s390x/pci: add common fmb

2018-10-23 Thread Cornelia Huck
On Mon, 22 Oct 2018 13:17:34 +0100 Thomas Huth wrote: > On 2018-10-22 10:02, Yi Min Zhao wrote: > > Common function measurement block is used to report counters of > > successfully issued pcilg/stg/stb and rpcit instructions. This patch > > introduces a new struct ZpciFmb and schedules a timer

Re: [Qemu-devel] [PATCH] qemu-iotests: convert `pwd` and $(pwd) to $PWD

2018-10-23 Thread Eric Blake
On 10/22/18 2:48 PM, Mao Zhongyi wrote: The subject line says "what", but the commit body should say "why". My suggestion: POSIX requires $PWD to be reliable, and we expect all shells used by qemu scripts to be relatively close to POSIX. Thus, it is smarter to avoid forking the pwd

Re: [Qemu-devel] [PATCH] qapi: Fix COLOStatus and query-colo-status since version

2018-10-23 Thread Eric Blake
On 10/22/18 5:41 PM, Zhang Chen wrote: This structure and command have missed qemu version 3.0, so fix it to since version 3.1. Signed-off-by: Zhang Chen --- qapi/migration.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake diff --git

Re: [Qemu-devel] [PATCH v8 00/38] target/mips: Limited support for the R5900

2018-10-23 Thread Fredrik Noring
Hi Peter, Aleksandar, > Hi: I get compile errors on 32-bit hosts: > > /home/petmay01/qemu-for-merges/disas/mips.c:615:35: error: large > integer implicitly truncated to unsigned type [-Werror=overflow] > #define INSN_5900 0x1 >^ >

[Qemu-devel] [Bug 1796754] Re: ioctl SIOCGIFCONF causes qemu-aarch64-static to crash with "received signal outside vCPU context"

2018-10-23 Thread Alex Bennée
** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1796754 Title: ioctl SIOCGIFCONF causes qemu-aarch64-static to crash with "received signal

Re: [Qemu-devel] [PATCH v2 1/3] linux-user: Add support for statx() syscall

2018-10-23 Thread Laurent Vivier
On 23/10/2018 14:07, Aleksandar Markovic wrote: > From: Aleksandar Rikalo > > Implement support for translation of system call statx(). The > implementation includes invoking other (more mature) syscalls > (from the same 'stat' family) on the host side. This way, > problems of availability of

[Qemu-devel] [Bug 1737444] Re: gccgo setcontext conftest crashes qemu-sh4

2018-10-23 Thread Alex Bennée
** Tags added: linux-user sh4 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1737444 Title: gccgo setcontext conftest crashes qemu-sh4 Status in QEMU: New Bug description: While testing gccgo

[Qemu-devel] [Bug 1775702] Re: High host CPU load and slower guest after upgrade guest OS Windows 10 to ver 1803

2018-10-23 Thread Alex Bennée
** Tags added: windows10 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1775702 Title: High host CPU load and slower guest after upgrade guest OS Windows 10 to ver 1803 Status in QEMU: New

Re: [Qemu-devel] [RFC v3 30/56] i386: convert to cpu_interrupt_request

2018-10-23 Thread Emilio G. Cota
On Sun, Oct 21, 2018 at 14:27:22 +0100, Richard Henderson wrote: > On 10/19/18 2:05 AM, Emilio G. Cota wrote: > > @@ -713,9 +713,9 @@ int hvf_vcpu_exec(CPUState *cpu) > > switch (exit_reason) { > > case EXIT_REASON_HLT: { > > macvm_set_rip(cpu, rip + ins_len); > > -

Re: [Qemu-devel] [RFC v3 46/56] accel/tcg: convert to cpu_interrupt_request

2018-10-23 Thread Emilio G. Cota
On Tue, Oct 23, 2018 at 03:17:11 +0100, Richard Henderson wrote: > On 10/23/18 12:50 AM, Emilio G. Cota wrote: > > On Sun, Oct 21, 2018 at 14:34:25 +0100, Richard Henderson wrote: > >> On 10/19/18 2:06 AM, Emilio G. Cota wrote: > >>> @@ -540,16 +540,16 @@ static inline bool

Re: [Qemu-devel] [PULL 00/34] MIPS queue for October 2018 - part 2

2018-10-23 Thread Peter Maydell
On 22 October 2018 at 13:57, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > The following changes since commit b312532fd03413d0e6ae6767ec793a3e30f487b8: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2018-10-19 19:01:07 +0100) > > are

Re: [Qemu-devel] [PATCH v8 00/38] target/mips: Limited support for the R5900

2018-10-23 Thread Fredrik Noring
Hi Maciej, > target/mips/translate.c:4888:38: error: passing argument 3 of > ‘tcg_gen_add2_i32’ from incompatible pointer type > [-Werror=incompatible-pointer-types] > tcg_gen_add2_i32(t2, t3, cpu_LO[acc], cpu_HI[acc], t2, t3); > ^~ Would

Re: [Qemu-devel] [PATCH 00/27] ACPI hardware-reduced support

2018-10-23 Thread Peter Maydell
On 23 October 2018 at 20:08, Samuel Ortiz wrote: > Hi Peter, > > On Tue, Oct 23, 2018 at 08:01:26PM +0100, Peter Maydell wrote: >> Hi -- I'd appreciate it if you don't send pull-requests for >> patch series. They show up in my queue of things to merge directly >> into master otherwise. Just send

Re: [Qemu-devel] [PATCH v8 00/38] target/mips: Limited support for the R5900

2018-10-23 Thread Fredrik Noring
Hi Maciej, > I have no authority to approve such a change for the kernel, but it looks > reasonable to me and I will support you with it, with one reservation > however. As this is an ISA extension in the vendor-specific space, I > think it belongs to a vendor-specific namespace, so as to

Re: [Qemu-devel] [PATCH 00/27] ACPI hardware-reduced support

2018-10-23 Thread Samuel Ortiz
Hi Peter, On Tue, Oct 23, 2018 at 08:01:26PM +0100, Peter Maydell wrote: > On 22 October 2018 at 19:36, Samuel Ortiz wrote: > > This patch set implements support for the ACPI hardware-reduced > > specification. > > > > The changes are coming from the NEMU [1] project where we're defining > > a

Re: [Qemu-devel] [PATCH 00/27] ACPI hardware-reduced support

2018-10-23 Thread Peter Maydell
On 22 October 2018 at 19:36, Samuel Ortiz wrote: > This patch set implements support for the ACPI hardware-reduced > specification. > > The changes are coming from the NEMU [1] project where we're defining > a new x86 machine type: i386/virt. This is an EFI only, ACPI > hardware-reduced platform

Re: [Qemu-devel] [PULL v2 00/40] Error reporting patches for 2018-10-22

2018-10-23 Thread Peter Maydell
On 23 October 2018 at 14:04, Markus Armbruster wrote: > The following changes since commit b312532fd03413d0e6ae6767ec793a3e30f487b8: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2018-10-19 19:01:07 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PULL 00/40] Error reporting patches for 2018-10-22

2018-10-23 Thread Peter Maydell
On 22 October 2018 at 13:33, Markus Armbruster wrote: > The following changes since commit 1b7490446bf41f54130c2d495dd4c8768c8e1ce3: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-3.1-pull-request' into staging > (2018-10-19 11:20:05 +0100) > > are available in the

Re: [Qemu-devel] [PATCH 1/7] decodetree: Add !extern flag to argument sets

2018-10-23 Thread Philippe Mathieu-Daudé
On 23/10/18 15:54, Richard Henderson wrote: On 10/23/18 2:27 PM, Philippe Mathieu-Daudé wrote: +    if re_fullmatch('!extern', t): +    extern = True It looks odd to match a negative form then use a positive one. Why not simply use 'extern'? "!" is an escape character here.

Re: [Qemu-devel] [PATCH v2 2/3] linux-user: Add support for semtimedop() syscall

2018-10-23 Thread Laurent Vivier
On 23/10/2018 14:07, Aleksandar Markovic wrote: > From: Aleksandar Rikalo > > Add support for semtimedop() emulation. > > Signed-off-by: Aleksandar Rikalo > Signed-off-by: Aleksandar Markovic > --- > linux-user/syscall.c | 27 +++ > 1 file changed, 27 insertions(+) >

Re: [Qemu-devel] [PATCH v2 3/3] linux-user: Add support for SO_REUSEPORT

2018-10-23 Thread Laurent Vivier
On 23/10/2018 14:07, Aleksandar Markovic wrote: > From: Yunqiang Su > > Add support for SO_REUSEPORT, including strace support. SO_REUSEPORT > was introduced relatively recently, since Linux 3.9, so use > '#if defined SO_REUSEPORT'. > > Signed-off-by: Yunqiang Su > Signed-off-by: Aleksandar

Re: [Qemu-devel] [PATCH 00/10] cputlb: track dirty tlbs and general cleanup

2018-10-23 Thread Emilio G. Cota
On Tue, Oct 23, 2018 at 08:02:42 +0100, Richard Henderson wrote: > The motivation here is reducing the total overhead. > > Before a few patches went into target-arm.next, I measured total > tlb flush overhead for aarch64 at 25%. This appears to reduce the > total overhead to about 5% (I do need

[Qemu-devel] [PATCH v6 15/18] target/mips: Add emulation of MXU instruction D16MUL

2018-10-23 Thread Aleksandar Markovic
From: Craig Janeczek Add support for emulating the D16MUL MXU instruction. Signed-off-by: Craig Janeczek Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 66 ++--- 1 file changed, 63 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v6 09/18] target/mips: Add bit encoding for MXU operand getting pattern 'optn2'

2018-10-23 Thread Aleksandar Markovic
From: Craig Janeczek Add bit encoding for MXU operand getting pattern 'optn2'. Signed-off-by: Craig Janeczek Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/mips/translate.c b/target/mips/translate.c index

[Qemu-devel] [PATCH v6 11/18] target/mips: Add emulation of non-MXU MULL within MXU decoding engine

2018-10-23 Thread Aleksandar Markovic
From: Craig Janeczek Add emulation of non-MXU MULL within MXU decoding engine. Signed-off-by: Craig Janeczek Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/target/mips/translate.c

[Qemu-devel] [PATCH v6 12/18] target/mips: Add emulation of MXU instructions S32I2M and S32M2I

2018-10-23 Thread Aleksandar Markovic
From: Craig Janeczek Add support for emulating the S32I2M and S32M2I MXU instructions. This commit also contains utility functions for reading/writing to MXU registers. This is required for overall MXU instruction support. Signed-off-by: Craig Janeczek Signed-off-by: Aleksandar Markovic ---

[Qemu-devel] [PATCH v6 13/18] target/mips: Move MUL, S32M2I, S32I2M handling out of main MXU switch

2018-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic Move MUL, S32M2I, S32I2M handling out of switch. These are all instructions that do not depend on MXU_EN flag of MXU_CR. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 41 +++-- 1 file changed, 23 insertions(+),

[Qemu-devel] [PATCH v6 18/18] target/mips: Add emulation of MXU instructions S32LDD and S32LDDR

2018-10-23 Thread Aleksandar Markovic
From: Craig Janeczek Add support for emulating the S32LDD and S32LDDR MXU instructions. Signed-off-by: Craig Janeczek Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 54 ++--- 1 file changed, 47 insertions(+), 7 deletions(-) diff

[Qemu-devel] [PATCH v6 06/18] target/mips: Add bit encoding for MXU accumulate add/sub 1-bit pattern 'aptn1'

2018-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic Add bit encoding for MXU accumulate add/subtract 1-bit pattern 'aptn1'. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/mips/translate.c b/target/mips/translate.c index ed72b32..f274ac1

[Qemu-devel] [PATCH v6 17/18] target/mips: Add emulation of MXU instructions Q8MUL and Q8MULSU

2018-10-23 Thread Aleksandar Markovic
From: Craig Janeczek Adds support for emulating the Q8MUL and Q8MULSU MXU instructions. Signed-off-by: Craig Janeczek Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 101 1 file changed, 94 insertions(+), 7 deletions(-) diff

[Qemu-devel] [PATCH v6 05/18] target/mips: Add MXU decoding engine

2018-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic Add MXU decoding engine: add handlers for all instruction pools, and main decode handler. The handlers, for now, for the purpose of this patch, contain only sceleton in the form of a single switch statement. Signed-off-by: Aleksandar Markovic ---

[Qemu-devel] [PATCH v6 16/18] target/mips: Add emulation of MXU instruction D16MAC

2018-10-23 Thread Aleksandar Markovic
From: Craig Janeczek Add support for emulating the D16MAC MXU instruction. Signed-off-by: Craig Janeczek Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 90 +++-- 1 file changed, 87 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v6 14/18] target/mips: Add emulation of MXU instruction S8LDD

2018-10-23 Thread Aleksandar Markovic
From: Craig Janeczek Add support for emulating the S8LDD MXU instruction. Signed-off-by: Craig Janeczek Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 90 +++-- 1 file changed, 87 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v6 03/18] target/mips: Amend MXU instruction opcodes

2018-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic Amend MXU instruction opcodes. Pool04 is actually only instruction OPC_MXU_S16MAD. Two cases within S16MAD are recognized by 1-bit subfield 'aptn1'. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 142 +---

Re: [Qemu-devel] [PULL 0/2] slirp updates

2018-10-23 Thread Peter Maydell
On 21 October 2018 at 20:30, Samuel Thibault wrote: > The following changes since commit b312532fd03413d0e6ae6767ec793a3e30f487b8: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2018-10-19 19:01:07 +0100) > > are available in the Git repository at: > >

[Qemu-devel] [PATCH v6 08/18] target/mips: Add bit encoding for MXU execute add/sub pattern 'eptn2'

2018-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic Add bit encoding for MXU execute 2-bit add/subtract pattern 'eptn2'. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/mips/translate.c b/target/mips/translate.c index 97fb2e0..665a584

[Qemu-devel] [PATCH v6 02/18] target/mips: Define a bit for MXU in insn_flags

2018-10-23 Thread Aleksandar Markovic
From: Craig Janeczek Define a bit for MXU in insn_flags. This is the first non-MIPS (third party) ASE supported in QEMU for MIPS, so it is placed in the section "bits 56-63: vendor-specific ASEs". Signed-off-by: Craig Janeczek Signed-off-by: Aleksandar Markovic --- target/mips/mips-defs.h |

[Qemu-devel] [PATCH v6 10/18] target/mips: Add bit encoding for MXU operand getting pattern 'optn3'

2018-10-23 Thread Aleksandar Markovic
From: Craig Janeczek Add bit encoding for MXU operand getting pattern 'optn3'. Signed-off-by: Craig Janeczek Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/target/mips/translate.c b/target/mips/translate.c index

[Qemu-devel] [PATCH v6 07/18] target/mips: Add bit encoding for MXU accumulate add/sub 2-bit pattern 'aptn2'

2018-10-23 Thread Aleksandar Markovic
From: Craig Janeczek Add bit encoding for MXU accumulate add/subtract 2-bit pattern 'aptn2'. Signed-off-by: Craig Janeczek Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/mips/translate.c

[Qemu-devel] [PATCH v6 04/18] target/mips: Add and integrate MXU decoding engine placeholder

2018-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic Provide the placeholder and add the invocation logic for MXU decoding engine. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 8 1 file changed, 8 insertions(+) diff --git a/target/mips/translate.c b/target/mips/translate.c index

[Qemu-devel] [PATCH v6 01/18] target/mips: Introduce MXU registers

2018-10-23 Thread Aleksandar Markovic
From: Craig Janeczek Define and initialize the 16 MXU registers - 15 general computational register, and 1 control register). There is also a zero register, but it does not have any corresponding variable. Reviewed-by: Richard Henderson Signed-off-by: Craig Janeczek Signed-off-by: Aleksandar

[Qemu-devel] [PATCH v6 00/18] target/mips: Add limited support for Ingenic's MXU ASE

2018-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic This patch set begins to add MXU ASE instruction support. v5->v6: - added bit definitions for 'aptn1' and 'eptn2'. - pool04 eliminated, since it is covered by a single instruction. - moved MUL, S32M2I, S32I2M handling out of main MXU switch. - rebased to the

[Qemu-devel] [PATCH v3 6/7] memory-device: avoid overflows on very huge devices

2018-10-23 Thread David Hildenbrand
Should not be a problem right now, but it could theoretically happen in the future. Signed-off-by: David Hildenbrand --- hw/mem/memory-device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c index 996ad1490f..8be63c8032

[Qemu-devel] [PATCH v3 0/7] qapi/range/memory-device: fixes and cleanups

2018-10-23 Thread David Hildenbrand
While working on memory device code, I noticed that specifiying an uint64_t on command line does not work in all cases as we always parse an int64_t. So I fix that and also cleanup the old int64_t parser. To be able to fix some overflows in memory-device code in a clean way, I am reusing the

Re: [Qemu-devel] [PULL 04/45] numa: Fix QMP command set-numa-node error handling

2018-10-23 Thread David Gibson
On Thu, Oct 18, 2018 at 05:03:41PM -0300, Eduardo Habkost wrote: > From: Markus Armbruster > > Calling error_report() in a function that takes an Error ** argument > is suspicious. parse_numa_node() does that, and then exit()s. It > also passes _fatal to machine_set_cpu_numa_node(). Both

[Qemu-devel] [PATCH v3 1/7] qapi: use qemu_strtoi64() in parse_str

2018-10-23 Thread David Hildenbrand
The qemu api claims to be easier to use, and the resulting code seems to agree. Signed-off-by: David Hildenbrand --- qapi/string-input-visitor.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c index

Re: [Qemu-devel] [PULL 07/45] hw/timer/sun4v-rtc: Use DeviceState::realize rather than SysBusDevice::init

2018-10-23 Thread David Gibson
On Thu, Oct 18, 2018 at 05:03:44PM -0300, Eduardo Habkost wrote: > From: Philippe Mathieu-Daudé > > Move from the legacy SysBusDevice::init method to using DeviceState::realize. > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Thomas Huth > Reviewed-by: Cédric Le Goater > Message-Id:

[Qemu-devel] [PATCH v3 5/7] memory-device: use QEMU_IS_ALIGNED

2018-10-23 Thread David Hildenbrand
Shorter and easier to read. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: David Hildenbrand --- hw/mem/memory-device.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c index 7de1ccd497..996ad1490f 100644 ---

  1   2   3   >