Re: [Qemu-devel] [PATCH] docker: Use a stable snapshot for Debian Sid

2018-11-01 Thread Fam Zheng
On Thu, 11/01 19:37, Philippe Mathieu-Daudé wrote: > The Debian Sid repository is not garanteed to be stable, as his > 'unstable' name suggest :) > To allow quick testing, packages are pushed various time a day, > which my be annoying when trying to use it for stable development > (which is not rec

Re: [Qemu-devel] [PATCH] block/nvme: optimize the performance of nvme driver based on vfio-pci

2018-11-01 Thread Fam Zheng
On Thu, 11/01 18:38, Li Feng wrote: > When the IO size is larger than 2 pages, we move the the pointer one by > one in the pagelist, this is inefficient. > > This is a simple benchmark result: > > Before: > $ qemu-io -c 'write 0 1G' nvme://:00:04.0/1 > > wrote 1073741824/1073741824 bytes at

Re: [Qemu-devel] [PULL 0/3] decodetree improvements

2018-11-01 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181031165321.4422-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PULL 0/3] decodetree improvements === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git l

[Qemu-devel] [PATCH 1/1] virtio: pass argument by value for virtqueue_map_iovec()

2018-11-01 Thread Dongli Zhang
Pass num_sg by value instead of by pointer, as num_sg is never modified in virtqueue_map_iovec(). Signed-off-by: Dongli Zhang --- hw/virtio/virtio.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 4136d23..a5cb4e6 100644 -

Re: [Qemu-devel] [PATCH RFC v7 4/9] migration: fix some segmentation faults when using multifd

2018-11-01 Thread Fei Li
On 11/02/2018 10:31 AM, Peter Xu wrote: On Thu, Nov 01, 2018 at 06:17:10PM +0800, Fei Li wrote: When multifd is used during migration, a segmentaion fault will occur in the source when multifd_save_cleanup() is called again if the multifd_send_state has been freed in earlier error handling. T

Re: [Qemu-devel] [PATCH v2 0/3] decodetree improvments

2018-11-01 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181031121443.605-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH v2 0/3] decodetree improvments === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-01 Thread Liran Alon
> On Thu, Nov1, 2018 at 09:45 AM, Jim Mattson wrote: >> On Thu, Nov 1, 2018 at 8:56 AM, Dr. David Alan Gilbert >> wrote: >> So if I have matching host kernels it should always work? >> What happens if I upgrade the source kernel to increase it's maximum >> nested size, can I force it to keep t

Re: [Qemu-devel] [PATCH RFC v7 5/9] migration: fix the multifd code when sending less channels

2018-11-01 Thread Peter Xu
On Fri, Nov 02, 2018 at 11:00:24AM +0800, Fei Li wrote: > > > On 11/02/2018 10:37 AM, Peter Xu wrote: > > On Thu, Nov 01, 2018 at 06:17:11PM +0800, Fei Li wrote: > > > Set the migration state to "failed" instead of "setup" when failing > > > to send packet via some channel. > > Could you please p

Re: [Qemu-devel] [PATCH RFC v7 5/9] migration: fix the multifd code when sending less channels

2018-11-01 Thread Fei Li
On 11/02/2018 10:37 AM, Peter Xu wrote: On Thu, Nov 01, 2018 at 06:17:11PM +0800, Fei Li wrote: Set the migration state to "failed" instead of "setup" when failing to send packet via some channel. Could you please provide more information in the commit message? E.g., what will happen if with

Re: [Qemu-devel] [PATCH for 3.2 v2 0/7] hw/arm/bcm2835: Add basic support for cprman (clock subsystem)

2018-11-01 Thread Guenter Roeck
On 11/1/18 5:12 PM, Philippe Mathieu-Daudé wrote: Hi, This series is a mix of a previous work I had for the raspi, and a patch from Guenter: https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03153.html The final patch keep Guenter ideas and comments, but is mostly a rewrite. I dropped th

Re: [Qemu-devel] [PATCH RFC v7 6/9] migration: fix the multifd code when receiving less channels

2018-11-01 Thread Peter Xu
On Thu, Nov 01, 2018 at 06:17:12PM +0800, Fei Li wrote: [...] > @@ -1339,7 +1339,7 @@ bool multifd_recv_all_channels_created(void) > } > > /* Return true if multifd is ready for the migration, otherwise false */ > -bool multifd_recv_new_channel(QIOChannel *ioc) > +bool multifd_recv_new_channe

Re: [Qemu-devel] [PATCH RFC v7 4/9] migration: fix some segmentation faults when using multifd

2018-11-01 Thread Peter Xu
On Thu, Nov 01, 2018 at 06:17:10PM +0800, Fei Li wrote: > When multifd is used during migration, a segmentaion fault will > occur in the source when multifd_save_cleanup() is called again if > the multifd_send_state has been freed in earlier error handling. This > can happen when migrate_fd_connect

Re: [Qemu-devel] [PATCH RFC v7 5/9] migration: fix the multifd code when sending less channels

2018-11-01 Thread Peter Xu
On Thu, Nov 01, 2018 at 06:17:11PM +0800, Fei Li wrote: > Set the migration state to "failed" instead of "setup" when failing > to send packet via some channel. Could you please provide more information in the commit message? E.g., what will happen if without this patch? Will it crash the source

Re: [Qemu-devel] [PATCH V2] net/filter-rewriter.c: Fix coverity static analysis issue

2018-11-01 Thread Jason Wang
On 2018/10/31 上午8:50, Zhang Chen wrote: The original code just follow the TCP state diagram, but in this case, we can skip the TCPS_TIME_WAIT state to simplify the implementation. Signed-off-by: Zhang Chen --- net/filter-rewriter.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) d

Re: [Qemu-devel] [PULL v3 00/24] qemu-ga patch queue for soft-freeze

2018-11-01 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181031141925.30026-1-mdr...@linux.vnet.ibm.com Subject: [Qemu-devel] [PULL v3 00/24] qemu-ga patch queue for soft-freeze === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=

[Qemu-devel] [PATCH] nvme: fix oob access issue(CVE-2018-16847)

2018-11-01 Thread Li Qiang
Currently, the nvme_cmb_ops mr doesn't check the addr and size. This can lead an oob access issue. This is triggerable in the guest. Add check to avoid this issue. Fixes CVE-2018-16847. Reported-by: Li Qiang Reviewed-by: Paolo Bonzini Signed-off-by: Li Qiang --- hw/block/nvme.c | 7 +++ 1

Re: [Qemu-devel] [PATCH v5 00/11] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-11-01 Thread Thomas Huth
On 2018-10-30 13:39, Laurent Vivier wrote: > Le 30/10/2018 à 14:12, Mark Cave-Ayland a écrit : >> On 30/10/2018 12:49, Laurent Vivier wrote: >> >>> Le 30/10/2018 à 12:48, Mark Cave-Ayland a écrit : On 30/10/2018 08:15, Richard Henderson wrote: > On 10/29/18 1:39 PM, Mark Cave-Ayland w

[Qemu-devel] [PATCH 2/2] contrib/elf2dmp: elf2dmp for Windows hosts

2018-11-01 Thread Viktor Prutyanov
After this patch elf2dmp can be built by mingw64 for Windows hosts. Signed-off-by: Viktor Prutyanov --- Makefile | 4 ++-- contrib/elf2dmp/kdbg.h | 12 contrib/elf2dmp/main.c | 27 +++ contrib/elf2dmp/pdb.c | 4 +++- contrib/elf2dmp/pdb.h |

[Qemu-devel] [PATCH 1/2] contrib/elf2dmp: use GLib file mapping

2018-11-01 Thread Viktor Prutyanov
Replace POSIX mmap with GLib g_mapped_file_new to make elf2dmp cross-paltform. After this patch there are no direct POSIX calls. Signed-off-by: Viktor Prutyanov --- Makefile | 2 +- contrib/elf2dmp/Makefile.objs | 2 +- contrib/elf2dmp/addrspace.c | 7 --- contrib/e

[Qemu-devel] [PATCH 0/2] contrib/elf2dmp: elf2dmp for Windows hosts

2018-11-01 Thread Viktor Prutyanov
In most cases, it is more convenient to convert a dump on the same machine on which the analysis is performed. Because of WinDbg, the analysis of guest Windows problems needs Windows host anyway, so it is useful to have dump convertion tool near the debugger. After these patches elf2dmp can be buil

[Qemu-devel] [PATCH for 3.2 v2 7/7] MAINTAINERS: Volunteer to review Raspi patches

2018-11-01 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index c41ea5ed3f..a76d047659 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -684,6 +684,7 @@ F: hw/arm/microbit.c F: include/hw/arm/nrf51_soc.h Raspberry Pi +R: P

Re: [Qemu-devel] [PATCH] target/arm: Conditionalize arm_div assert on aarch32 support

2018-11-01 Thread Philippe Mathieu-Daudé
On 1/11/18 22:57, Richard Henderson wrote: When populating id registers from kvm, on a host that doesn't support aarch32 mode at all, aa32_arm_div will not be supported either. Signed-off-by: Richard Henderson --- "Tested" on an APM Mustang, which does support AArch32. I'm not sure, off hand,

[Qemu-devel] [PATCH for 3.2 v2 6/7] hw/arm/bcm2835: Add basic support for cprman (clock subsystem)

2018-11-01 Thread Philippe Mathieu-Daudé
Add basic support for BCM283x CPRMAN. Provide support for reading and writing CPRMAN registers and initialize registers with sensible default values. During runtime retain any written values. Basic CPRMAN support is necessary and sufficient to boot Linux on raspi2 and raspi3 systems. Without this

[Qemu-devel] [PATCH for 3.2 v2 5/7] hw/arm/bcm2835: Add various unimplemented peripherals

2018-11-01 Thread Philippe Mathieu-Daudé
Base addresses and sizes taken from the "BCM2835 ARM Peripherals" datasheet from February 06 2012: https://www.raspberrypi.org/app/uploads/2012/02/BCM2835-ARM-Peripherals.pdf Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/bcm2835_peripherals.c | 26 ++ include/h

[Qemu-devel] [PATCH for 3.2 v2 0/7] hw/arm/bcm2835: Add basic support for cprman (clock subsystem)

2018-11-01 Thread Philippe Mathieu-Daudé
Hi, This series is a mix of a previous work I had for the raspi, and a patch from Guenter: https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03153.html The final patch keep Guenter ideas and comments, but is mostly a rewrite. I dropped the A2W code from this work, it doesn't seems unuseful

[Qemu-devel] [PATCH for 3.2 v2 4/7] hw/arm/bcm2835: Rename some definitions

2018-11-01 Thread Philippe Mathieu-Daudé
The UART1 is part of the AUX peripheral, the PCM_CLOCK (yet unimplemented) is part of the CPRMAN. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/bcm2835_peripherals.c| 2 +- include/hw/arm/raspi_platform.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/arm/bcm2

[Qemu-devel] [PATCH for 3.2 v2 2/7] hw/misc/bcm2835_property: Handle the 'domain state' property

2018-11-01 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/bcm2835_property.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c index 145427ae0f..5d332324bd 100644 --- a/hw/misc/bcm2835_property.c +++ b/hw/misc/bcm2835_property.c @@ -121,6 +1

[Qemu-devel] [PATCH for 3.2 v2 3/7] hw/arm/bcm2835: Use 0x prefix for hex numbers

2018-11-01 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/char/bcm2835_aux.c | 2 +- hw/intc/bcm2836_control.c | 4 ++-- hw/misc/bcm2835_property.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/char/bcm2835_aux.c b/hw/char/bcm2835_aux.c index 0364596c55..9632e8972c 100644 ---

[Qemu-devel] [PATCH for 3.1 v2 1/7] MAINTAINERS: Add an entry for the Raspberry Pi machines

2018-11-01 Thread Philippe Mathieu-Daudé
So far the Raspi machines use the BCM2836 SoC which includes a BCM2835 for the peripherals. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f2360efe3e..c41ea5ed3f 100644 --- a/MAINTAINERS +++ b/MAINTA

[Qemu-devel] [PULL 1/3] target/riscv/pmp.c: pmpcfg_csr_read returns bogus value on RV64

2018-11-01 Thread Palmer Dabbelt
From: Dayeol Lee pmp_read_cfg() returns 8-bit value, which is combined together to form a single pmpcfg CSR. The default promotion rules will result in an integer here ("i*8" is integer, which flows through) resulting in a 32-bit signed value on most hosts. That's bogus on RV64I, with the high

[Qemu-devel] [PULL 3/3] Add qemu-ri...@nongnu.org as the RISC-V list

2018-11-01 Thread Palmer Dabbelt
We now have a RISC-V specific QEMU development list. Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Palmer Dabbelt --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d550fd8b80

[Qemu-devel] [PULL] RISC-V Patches for the 3.1 Soft Freeze, Part 2

2018-11-01 Thread Palmer Dabbelt
The following changes since commit a2e002ff7913ce93aa0f7dbedd2123dce5f1a9cd: Merge remote-tracking branch 'remotes/vivier2/tags/qemu-trivial-for-3.1-pull-request' into staging (2018-10-30 15:49:55 +) are available in the Git repository at: git://github.com/riscv/riscv-qemu.git tags/ris

[Qemu-devel] [PULL 2/3] Add Alistair as a RISC-V Maintainer

2018-11-01 Thread Palmer Dabbelt
Alistair has been contributing to the RISC-V QEMU port for a while now so I'd like him to be officially listed as a maintainer. I've checked with the other RISC-V maintainers and there are no objections, and I've also checked with Alistair so he knows I'm volunteering him. Signed-off-by: Palmer D

Re: [Qemu-devel] [PATCH] softfloat: Don't execute divdeu without power7

2018-11-01 Thread Laurent Vivier
On 01/11/2018 21:26, Richard Henderson wrote: > The divdeu instruction was added to ISA 2.06 (Power7). > Exclude this block from older cpus. > > Fixes: 27ae5109a2ba (softfloat: Specialize udiv_qrnnd for ppc64) > Reported-by: Laurent Vivier > Signed-off-by: Richard Henderson > --- > include/fpu/

[Qemu-devel] [PATCH] target/arm: Conditionalize arm_div assert on aarch32 support

2018-11-01 Thread Richard Henderson
When populating id registers from kvm, on a host that doesn't support aarch32 mode at all, aa32_arm_div will not be supported either. Signed-off-by: Richard Henderson --- "Tested" on an APM Mustang, which does support AArch32. I'm not sure, off hand, which cpu(s) don't have it, and Alex didn't

[Qemu-devel] strange situation, guest cpu thread spinning at ~100%, but display not yet initialized

2018-11-01 Thread Chris Friesen
Hi all, I have an odd situation which occurs very infrequently and I'm hoping to get some advice on how to debug. Apologies for the length of this message, I tried to include as much potentially useful information as possible. In the context of an OpenStack compute node I have a qemu guest

[Qemu-devel] [PATCH] softfloat: Don't execute divdeu without power7

2018-11-01 Thread Richard Henderson
The divdeu instruction was added to ISA 2.06 (Power7). Exclude this block from older cpus. Fixes: 27ae5109a2ba (softfloat: Specialize udiv_qrnnd for ppc64) Reported-by: Laurent Vivier Signed-off-by: Richard Henderson --- include/fpu/softfloat-macros.h | 4 ++-- 1 file changed, 2 insertions(+),

Re: [Qemu-devel] [PATCH] softfloat: don't execute ppc64 ISA 3.0B instruction if it is not supported

2018-11-01 Thread Richard Henderson
On 11/1/18 5:38 PM, Laurent Vivier wrote: > commit 27ae5109a2 has introduced an assembly instruction only supported > by ISA 3.0B and it fails to execute on previous versions of the POWER > CPU (like PowerPC G5). > > This patch fixes that by checking the ISA level, and falls back to > the default

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-01 Thread Jim Mattson via Qemu-devel
On Thu, Nov 1, 2018 at 12:07 PM, Dr. David Alan Gilbert wrote: > OK; the tricky thing is when you upgrade one host in a small cluster as > you start doing an upgrade, and then once it's got it's first VM you > can't migrate away from it until others are updated; that gets messy. One must always

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-01 Thread Dr. David Alan Gilbert
* Liran Alon (liran.a...@oracle.com) wrote: > > > > On 1 Nov 2018, at 17:56, Dr. David Alan Gilbert wrote: > > > > * Liran Alon (liran.a...@oracle.com) wrote: > >> > >> > >>> On 1 Nov 2018, at 15:10, Dr. David Alan Gilbert > >>> wrote: > >>> > >>> * Liran Alon (liran.a...@oracle.com) wrote

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-01 Thread Liran Alon
> On 1 Nov 2018, at 17:56, Dr. David Alan Gilbert wrote: > > * Liran Alon (liran.a...@oracle.com) wrote: >> >> >>> On 1 Nov 2018, at 15:10, Dr. David Alan Gilbert wrote: >>> >>> * Liran Alon (liran.a...@oracle.com) wrote: > On 31 Oct 2018, at 20:59, Dr. David Alan Gilbert

[Qemu-devel] [PATCH] docker: Use a stable snapshot for Debian Sid

2018-11-01 Thread Philippe Mathieu-Daudé
The Debian Sid repository is not garanteed to be stable, as his 'unstable' name suggest :) To allow quick testing, packages are pushed various time a day, which my be annoying when trying to use it for stable development (which is not recommended, but Sid provides edge packages we use for testing).

Re: [Qemu-devel] [PATCH v3] arm: exynos4: Add dma support for smdkc210

2018-11-01 Thread Guenter Roeck
On Thu, Nov 01, 2018 at 05:24:15PM +, Peter Maydell wrote: > On 30 October 2018 at 19:30, Philippe Mathieu-Daudé wrote: > > From: Guenter Roeck > > > > QEMU already supports pl330. Instantiate it for smdkc210. > > Reviewed-by: Peter Maydell > > I don't suppose anybody has the SoC datasheet

[Qemu-devel] [PATCH 4/7] qcow2: refactor decompress_buffer

2018-11-01 Thread Vladimir Sementsov-Ogievskiy
- make it look more like a pair of qcow2_compress - rename the function and its parameters - drop extra out_len variable, check filling of output buffer by strm structure itself - fix code style - add some documentation Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 56 +

[Qemu-devel] [PATCH 3/7] qcow2: move decompression from qcow2-cluster.c to qcow2.c

2018-11-01 Thread Vladimir Sementsov-Ogievskiy
Compression is done in threads in qcow2.c. We want to do decompression in the same way, so, firstly, move it to the same file. The only change is braces around if-body in decompress_buffer, to satisfy checkpatch. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-cluster.c | 70 ---

Re: [Qemu-devel] [PULL v3 00/24] qemu-ga patch queue for soft-freeze

2018-11-01 Thread Peter Maydell
On 31 October 2018 at 14:19, Michael Roth wrote: > The following changes since commit a2e002ff7913ce93aa0f7dbedd2123dce5f1a9cd: > > Merge remote-tracking branch > 'remotes/vivier2/tags/qemu-trivial-for-3.1-pull-request' into staging > (2018-10-30 15:49:55 +) > > are available in the Git re

[Qemu-devel] [PATCH 7/7] qcow2: do decompression in threads

2018-11-01 Thread Vladimir Sementsov-Ogievskiy
Do decompression in threads, like it is already done for compression. This improves asynchronous compressed reads performance. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 35 --- 1 file changed, 28 insertions(+), 7 deletions(-) diff --git a/bl

[Qemu-devel] [PATCH 6/7] qcow2: aio support for compressed cluster read

2018-11-01 Thread Vladimir Sementsov-Ogievskiy
Allocate buffers locally and release qcow2 lock. Than, reads inside qcow2_co_preadv_compressed may be done in parallel, however all decompression is still done synchronously. Let's improve it in the following commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h | 4 --- block/q

[Qemu-devel] [PATCH 0/7] qcow2 decompress in threads

2018-11-01 Thread Vladimir Sementsov-Ogievskiy
Hi all! The series brings threads to qcow2 decompression path, like it is already done for compression. Performance gain is illustrated by the following test: []# cat gen.sh #!/bin/bash echo 'create pattern-file /ssd/t_pat' ./qemu-img create -f raw /ssd/t_pat 10g for i in {0..9}; do ./qemu

[Qemu-devel] [PATCH 2/7] qcow2: make more generic interface for qcow2_compress

2018-11-01 Thread Vladimir Sementsov-Ogievskiy
Give explicit size both for source and destination buffers, to make it similar with decompression path and than cleanly reuse parameter structure for decompression threads. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 30 ++ 1 file changed, 18 inser

[Qemu-devel] [PATCH 1/7] qcow2: use Z_OK instead of 0 for deflateInit2 return code check

2018-11-01 Thread Vladimir Sementsov-Ogievskiy
Use appropriate macro, corresponding to deflateInit2 spec. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2.c b/block/qcow2.c index 30689b7688..3e9367c449 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @

[Qemu-devel] [PATCH 5/7] qcow2: use byte-based read in qcow2_decompress_cluster

2018-11-01 Thread Vladimir Sementsov-Ogievskiy
We are gradually moving away from sector-based interfaces, towards byte-based. Get rid of it here too. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index e9d24b80

[Qemu-devel] Regarding: Migration of VM created using qemu source code built

2018-11-01 Thread aditya bhardwaj
Respected Sir, I followed https://wiki.qemu.org/Hosts/Linux to build qemu from source code. Its installed successfully with Ubuntu 16.04 VM created using VNC server. *Now, Could you please suggest me how to migrate VM from one host to another?.* I goggled lot but not getting any solution. --

[Qemu-devel] [Bug 1801073] [NEW] util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Wer

2018-11-01 Thread Martin Liska
Public bug reported: For qemu-3.0.0 I see with GCC 9 compiler a new warning: $ make -j1 -C roms pxerom VERBOSE=1 V=1 make: Entering directory '/home/abuild/rpmbuild/BUILD/qemu-3.0.0/roms' make -C ipxe/src CONFIG=qemu \ PACKAGING_TIMESTAMP=1534273834 \ CROSS_COMPILE= \ bin/

Re: [Qemu-devel] [PATCH 0/5] target/arm: KVM vs ARMISARegisters

2018-11-01 Thread Peter Maydell
On 1 November 2018 at 17:30, Peter Maydell wrote: > On 1 November 2018 at 17:26, Alex Bennée wrote: >> I think the problem is the we trip over the assert because: >> >> /* Some features automatically imply others: */ >> if (arm_feature(env, ARM_FEATURE_V8)) { >> if (arm_feature(en

Re: [Qemu-devel] Correction needed for R5900 instruction decoding

2018-11-01 Thread Aleksandar Markovic
Fredrik, please do not include handling of any opcode other than those currently in the tree. There are good and bad patterns in the code, and not every pattern is OK to follow. Thanks, Aleksandar From: Fredrik Noring Sent: Thursday, November 1, 2018 6

Re: [Qemu-devel] [PATCH] softfloat: don't execute ppc64 ISA 3.0B instruction if it is not supported

2018-11-01 Thread Laurent Vivier
On 01/11/2018 18:49, Peter Maydell wrote: > On 1 November 2018 at 17:38, Laurent Vivier wrote: >> commit 27ae5109a2 has introduced an assembly instruction only supported >> by ISA 3.0B and it fails to execute on previous versions of the POWER >> CPU (like PowerPC G5). >> >> This patch fixes that b

Re: [Qemu-devel] [PATCH v4 03/23] hw: acpi: Export the RSDP build API

2018-11-01 Thread Philippe Mathieu-Daudé
Hey Samuel, On 1/11/18 11:22, Samuel Ortiz wrote: The hardware-reduced API will need to build RSDP as well, so we should export this routine. While doing so, we also slightly change the function prototype. Since no caller needs it, and to make it more consistent with the rest of the AML build AP

Re: [Qemu-devel] [PATCH] softfloat: don't execute ppc64 ISA 3.0B instruction if it is not supported

2018-11-01 Thread Peter Maydell
On 1 November 2018 at 17:38, Laurent Vivier wrote: > commit 27ae5109a2 has introduced an assembly instruction only supported > by ISA 3.0B and it fails to execute on previous versions of the POWER > CPU (like PowerPC G5). > > This patch fixes that by checking the ISA level, and falls back to > the

Re: [Qemu-devel] [PATCH for-3.1] hw/ppc/mac_newworld: Free openpic_irqs array after use

2018-11-01 Thread Philippe Mathieu-Daudé
On 1/11/18 17:17, Peter Maydell wrote: In ppc_core99_init(), we allocate an openpic_irqs array, which we then use to collect up the various qemu_irqs which we're going to connect to the interrupt controller. Once we've called sysbus_connect_irq() to connect them all up, the array is no longer req

[Qemu-devel] [PATCH v2 07/12] tests/tcg/mips: Test R5900 three-operand MADD1

2018-11-01 Thread Fredrik Noring
Signed-off-by: Fredrik Noring --- tests/tcg/mips/mipsr5900/madd.c | 43 + 1 file changed, 38 insertions(+), 5 deletions(-) diff --git a/tests/tcg/mips/mipsr5900/madd.c b/tests/tcg/mips/mipsr5900/madd.c index 9ad2ea6dbb..f6f215e1c3 100644 --- a/tests/tcg/mips/mipsr

[Qemu-devel] [PATCH] softfloat: don't execute ppc64 ISA 3.0B instruction if it is not supported

2018-11-01 Thread Laurent Vivier
commit 27ae5109a2 has introduced an assembly instruction only supported by ISA 3.0B and it fails to execute on previous versions of the POWER CPU (like PowerPC G5). This patch fixes that by checking the ISA level, and falls back to the default C function if the instruction is not supported. Fixes

[Qemu-devel] [PATCH v2 06/12] tests/tcg/mips: Test R5900 three-operand MADD

2018-11-01 Thread Fredrik Noring
Signed-off-by: Fredrik Noring --- tests/tcg/mips/mipsr5900/Makefile | 1 + tests/tcg/mips/mipsr5900/madd.c | 45 +++ 2 files changed, 46 insertions(+) create mode 100644 tests/tcg/mips/mipsr5900/madd.c diff --git a/tests/tcg/mips/mipsr5900/Makefile b/tests/tcg/mi

[Qemu-devel] [PATCH v2 11/12] disas/mips: Define R5900 disassembly constants

2018-11-01 Thread Fredrik Noring
Signed-off-by: Fredrik Noring --- disas/mips.c | 8 1 file changed, 8 insertions(+) diff --git a/disas/mips.c b/disas/mips.c index d73d4094d8..9f01fda8bd 100644 --- a/disas/mips.c +++ b/disas/mips.c @@ -611,6 +611,9 @@ struct mips_opcode /* ST Microelectronics Loongson 2F. */ #define

[Qemu-devel] [PATCH v2 04/12] target/mips: Support Toshiba specific three-operand MADD and MADDU

2018-11-01 Thread Fredrik Noring
From: Philippe Mathieu-Daudé The three-operand MADD and MADDU are specific to the Toshiba TX19/TX39/TX79 cores. The "32-Bit TX System RISC TX39 Family Architecture manual" is available at https://wiki.qemu.org/File:DSAE0022432.pdf Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Fredrik Nor

[Qemu-devel] [PATCH v2 09/12] tests/tcg/mips: Test R5900 three-operand MADDU1

2018-11-01 Thread Fredrik Noring
Signed-off-by: Fredrik Noring --- tests/tcg/mips/mipsr5900/maddu.c | 37 ++-- 1 file changed, 35 insertions(+), 2 deletions(-) diff --git a/tests/tcg/mips/mipsr5900/maddu.c b/tests/tcg/mips/mipsr5900/maddu.c index e4e552102d..30936fb2b4 100644 --- a/tests/tcg/mips/mip

[Qemu-devel] [PATCH v2 10/12] disas/mips: Increase 'member of ISAs' flag holder size

2018-11-01 Thread Fredrik Noring
From: Philippe Mathieu-Daudé Increase the size of 'membership' holder size to 64 bits. This is needed for future extensions since existing bits are almost all used. This change is related to commit f9c9cd63e3 "target/mips: Increase 'supported ISAs/ASEs' flag holder size". Signed-off-by: Philippe

[Qemu-devel] [PATCH v2 05/12] target/mips: Support R5900 three-operand MADD1 and MADDU1

2018-11-01 Thread Fredrik Noring
Signed-off-by: Fredrik Noring --- target/mips/translate.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 4808cb49c3..57b17ad8f6 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -5021,7 +

[Qemu-devel] [PATCH v2 08/12] tests/tcg/mips: Test R5900 three-operand MADDU

2018-11-01 Thread Fredrik Noring
Signed-off-by: Fredrik Noring --- tests/tcg/mips/mipsr5900/Makefile | 1 + tests/tcg/mips/mipsr5900/maddu.c | 37 +++ 2 files changed, 38 insertions(+) create mode 100644 tests/tcg/mips/mipsr5900/maddu.c diff --git a/tests/tcg/mips/mipsr5900/Makefile b/tests/tcg/m

[Qemu-devel] [PATCH v2 12/12] disas/mips: Disassemble R5900 DIV[U]1, M{F, T}{LO, HI}1 and MULT[U]1

2018-11-01 Thread Fredrik Noring
Disassemble the R5900 instructions DIV1, DIVU1, MFLO1, MTLO1, MFHI1, MTHI1, MULT1 and MULTU1. The opcodes for MADD1 and MADDU1 clash with the opcodes for CLZ and CLO, resulting in incorrect disassembly. They are therefore omitted here. Signed-off-by: Fredrik Noring --- disas/mips.c | 12

[Qemu-devel] [PATCH v2 02/12] target/mips: Generate R5900 DIV1 and DIVU1 in gen_div1_tx79

2018-11-01 Thread Fredrik Noring
DIV1 and DIVU1 are generated in gen_div1_tx79 instead of the generic gen_muldiv. Signed-off-by: Fredrik Noring --- target/mips/translate.c | 65 + 1 file changed, 59 insertions(+), 6 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translat

[Qemu-devel] [PATCH v2 03/12] target/mips: R5900 LQ and SQ also belong to the Toshiba MMI ASE

2018-11-01 Thread Fredrik Noring
Signed-off-by: Fredrik Noring --- target/mips/translate.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 6e5a8a2565..624e53644d 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -27992,7 +27992,

[Qemu-devel] [PATCH v2 01/12] target/mips: Generate R5900 MFLO1, MFHI1, MTLO1 and MTHI1 in gen_HILO1_tx79

2018-11-01 Thread Fredrik Noring
MFLO1, MFHI1, MTLO1 and MTHI1 are generated in gen_HILO1_tx79 instead of the generic gen_HILO. Signed-off-by: Fredrik Noring --- target/mips/translate.c | 67 ++--- 1 file changed, 56 insertions(+), 11 deletions(-) diff --git a/target/mips/translate.c b/targe

[Qemu-devel] [PATCH v2 00/12] target/mips: Amend R5900 support

2018-11-01 Thread Fredrik Noring
This series amends the R5900 support with the following noncritical features: - R5900 MFLO1, MFHI1, MTLO1 and MTHI1 are generated in gen_HILO1_tx79. - R5900 DIV1 and DIVU1 are generated in gen_div1_tx79. - The R5900 LQ and SQ instructions are now also covered by the Toshiba MMI ASE, as per the

Re: [Qemu-devel] [PATCH 0/5] target/arm: KVM vs ARMISARegisters

2018-11-01 Thread Peter Maydell
On 1 November 2018 at 17:26, Alex Bennée wrote: > > Richard Henderson writes: > >> My previous patch set for replacing feature bits with id registers >> failed to consider that these id registers are beginning to control >> migration, and thus we must fill them in for KVM as well. >> >> Thus, we

Re: [Qemu-devel] [PATCH 0/5] target/arm: KVM vs ARMISARegisters

2018-11-01 Thread Alex Bennée
Richard Henderson writes: > My previous patch set for replacing feature bits with id registers > failed to consider that these id registers are beginning to control > migration, and thus we must fill them in for KVM as well. > > Thus, we want to initialize these values within CPU from the host.

Re: [Qemu-devel] Maintainer attn for 3.1 release changelog

2018-11-01 Thread Peter Maydell
On 1 November 2018 at 17:12, Daniel P. Berrangé wrote: > [1] Maybe we should in fact create the changelog pages at the very start > of each release cycle. Yes, that would be a good idea. thanks -- PMM

Re: [Qemu-devel] [PULL 0/7] x86 queue, 2018-10-30

2018-11-01 Thread Peter Maydell
On 31 October 2018 at 14:07, Eduardo Habkost wrote: > Peter, my S-o-b line was missing on some commits, I have just pushed a new > x86-next-pull-request tag, with exactly the same tree. Sorry for the noise. > > Thanks to Eric Blake for reporting the issue. > > The following changes since commit a

Re: [Qemu-devel] [PATCH v3] arm: exynos4: Add dma support for smdkc210

2018-11-01 Thread Peter Maydell
On 30 October 2018 at 19:30, Philippe Mathieu-Daudé wrote: > From: Guenter Roeck > > QEMU already supports pl330. Instantiate it for smdkc210. Reviewed-by: Peter Maydell I don't suppose anybody has the SoC datasheet to crosscheck the irq/address values (and maybe see if it lists any of the oth

Re: [Qemu-devel] Correction needed for R5900 instruction decoding

2018-11-01 Thread Fredrik Noring
[ Philippe and Emilio -- thank you for cc-ing me. Good catch, since I'm not subscribed to the QEMU mailing list. Changes to the R5900 emulation are certainly of interest. ] Hi Aleksandar, Philippe, On Thu, Nov 01, 2018 at 03:31:54PM +0100, Philippe Mathieu-Daudé wrote: > Cc'ing Fredrik. > > On 1

Re: [Qemu-devel] [PATCH v2 0/2] hw/arm/exynos4: Add DMA support for SMDKC210 board

2018-11-01 Thread Peter Maydell
On 31 October 2018 at 16:00, Philippe Mathieu-Daudé wrote: > > The following patch fixes this crash, but I'm not sure this is the correct > fix: > > -- >8 -- > --- a/hw/intc/exynos4210_gic.c > +++ b/hw/intc/exynos4210_gic.c > @@ -213,6 +213,8 @@ void exynos4210_init_board_irqs(Exynos4210Irq *s) >

[Qemu-devel] Maintainer attn for 3.1 release changelog

2018-11-01 Thread Daniel P . Berrangé
It is that time[1] of the release cycle when maintainers can make a start on filling in the release changelog info for 3.1. I created the basic page structure copying from 3.0 : https://wiki.qemu.org/ChangeLog/3.1 Anyone who has sent a pull request in this dev cycle should fill in the info abo

Re: [Qemu-devel] [PULL 8/8] softfloat: Specialize udiv_qrnnd for ppc64

2018-11-01 Thread Laurent Vivier
On 31/10/2018 19:46, Laurent Vivier wrote: > On 05/10/2018 20:02, Richard Henderson wrote: >> The ISA has a 128/64-bit division instruction, though it assumes the >> low 64-bits of the numerator are 0, and so requires a bit more fixup >> than a full 128-bit division insn. >> >> Reviewed-by: David G

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-01 Thread Jim Mattson via Qemu-devel
On Thu, Nov 1, 2018 at 8:56 AM, Dr. David Alan Gilbert wrote: > So if I have matching host kernels it should always work? > What happens if I upgrade the source kernel to increase it's maximum > nested size, can I force it to keep things small for some VMs? Any change to the format of the nested

Re: [Qemu-devel] [PATCH v1 0/7] pci: hotplug handler reworks

2018-11-01 Thread David Hildenbrand
On 01.11.18 15:55, Igor Mammedov wrote: > On Wed, 31 Oct 2018 18:31:30 +0100 > David Hildenbrand wrote: > >> On 24.10.18 12:19, David Hildenbrand wrote: >>> This series reworks some pci hotplug handlers (except for s390, that will >>> require more work but is not required for now). >>> >>> 1. Rou

Re: [Qemu-devel] [Qemu-block] [PATCH for-3.1] blockdev: Consistently use snapshot_node_name in external_snapshot_prepare()

2018-11-01 Thread Alberto Garcia
On Thu 01 Nov 2018 05:30:37 PM CET, Peter Maydell wrote: > In the function external_snapshot_prepare() we have a > BlockdevSnapshotSync struct, which has the usual combination > of has_snapshot_node_name and snapshot_node_name fields for an > optional field. We set up a local variable > con

Re: [Qemu-devel] [PULL 00/10] cputlb: track dirty tlbs and general cleanup

2018-11-01 Thread Peter Maydell
On 31 October 2018 at 12:21, Richard Henderson wrote: > The following changes since commit a2e002ff7913ce93aa0f7dbedd2123dce5f1a9cd: > > Merge remote-tracking branch > 'remotes/vivier2/tags/qemu-trivial-for-3.1-pull-request' into staging > (2018-10-30 15:49:55 +) > > are available in the G

[Qemu-devel] [PATCH for-3.1] blockdev: Consistently use snapshot_node_name in external_snapshot_prepare()

2018-11-01 Thread Peter Maydell
In the function external_snapshot_prepare() we have a BlockdevSnapshotSync struct, which has the usual combination of has_snapshot_node_name and snapshot_node_name fields for an optional field. We set up a local variable const char *snapshot_node_name = s->has_snapshot_node_name

[Qemu-devel] [PATCH for-3.1] hw/ppc/mac_newworld: Free openpic_irqs array after use

2018-11-01 Thread Peter Maydell
In ppc_core99_init(), we allocate an openpic_irqs array, which we then use to collect up the various qemu_irqs which we're going to connect to the interrupt controller. Once we've called sysbus_connect_irq() to connect them all up, the array is no longer required, but we forgot to free it. Since b

Re: [Qemu-devel] [PATCH v3 26/35] target/riscv: Remove shift and slt insn manual decoding

2018-11-01 Thread Palmer Dabbelt
On Wed, 31 Oct 2018 15:38:08 PDT (-0700), richard.hender...@linaro.org wrote: On 10/31/18 1:20 PM, Bastian Koppelmann wrote: static bool trans_slt(DisasContext *ctx, arg_slt *a) { -gen_arith(ctx, OPC_RISC_SLT, a->rd, a->rs1, a->rs2); +TCGv source1 = tcg_temp_new(); +TCGv source2 =

Re: [Qemu-devel] [PATCH v2 05/10] qom/globals: generalize object_property_set_globals()

2018-11-01 Thread Igor Mammedov
On Thu, 1 Nov 2018 12:27:45 -0300 Eduardo Habkost wrote: > On Thu, Nov 01, 2018 at 11:18:42AM +0100, Igor Mammedov wrote: > > On Wed, 31 Oct 2018 17:12:56 -0300 > > Eduardo Habkost wrote: > > > > > On Tue, Oct 30, 2018 at 07:04:48PM +0400, Marc-André Lureau wrote: > > > > Handle calls of ob

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-01 Thread Dr. David Alan Gilbert
* Liran Alon (liran.a...@oracle.com) wrote: > > > > On 1 Nov 2018, at 15:10, Dr. David Alan Gilbert wrote: > > > > * Liran Alon (liran.a...@oracle.com) wrote: > >> > >> > >>> On 31 Oct 2018, at 20:59, Dr. David Alan Gilbert > >>> wrote: > >>> > >>> * Liran Alon (liran.a...@oracle.com) wrot

Re: [Qemu-devel] [RFC PATCH spice v2 1/2] QXL interface: add functions to identify monitors in the guest

2018-11-01 Thread Lukáš Hrázký
Hello, On Mon, 2018-10-22 at 13:46 +0200, Lukáš Hrázký wrote: > Hello, > > On Thu, 2018-10-18 at 03:16 -0400, Frediano Ziglio wrote: > > > > > > Adds two functions to let QEMU provide information to identify graphics > > > devices and their monitors in the guest: > > > > > > * device address -

Re: [Qemu-devel] [PATCH 1/9] qom/user-creatable: add a few helper macros

2018-11-01 Thread Igor Mammedov
On Thu, 1 Nov 2018 12:02:03 -0300 Eduardo Habkost wrote: > On Thu, Nov 01, 2018 at 01:16:37PM +0100, Igor Mammedov wrote: > > On Tue, 30 Oct 2018 20:07:17 -0300 > > Eduardo Habkost wrote: > > > > > On Tue, Oct 30, 2018 at 03:22:43PM +0100, Igor Mammedov wrote: > > > > On Tue, 30 Oct 2018 13

Re: [Qemu-devel] [PATCH v2 10/10] hostmem: use object id for memory region name with >= 3.1

2018-11-01 Thread Eduardo Habkost
On Thu, Nov 01, 2018 at 04:16:12PM +0100, Igor Mammedov wrote: > On Wed, 31 Oct 2018 17:27:57 -0300 > Eduardo Habkost wrote: > > > On Tue, Oct 30, 2018 at 07:04:53PM +0400, Marc-André Lureau wrote: > > > hostmem-file and hostmem-memfd use the whole object path for the > > > memory region name, an

Re: [Qemu-devel] [PATCH v4 16/23] hw: acpi: Export the PCI hotplug API

2018-11-01 Thread Philippe Mathieu-Daudé
On 1/11/18 11:22, Samuel Ortiz wrote: From: Sebastien Boeuf The ACPI hotplug support for PCI devices APIs are not x86 or even machine type specific. In order for future machine types to be able to re-use that code, we export it through the architecture agnostic hw/acpi folder. Reviewed-by: Phi

Re: [Qemu-devel] [PATCH v2 05/10] qom/globals: generalize object_property_set_globals()

2018-11-01 Thread Eduardo Habkost
On Thu, Nov 01, 2018 at 11:18:42AM +0100, Igor Mammedov wrote: > On Wed, 31 Oct 2018 17:12:56 -0300 > Eduardo Habkost wrote: > > > On Tue, Oct 30, 2018 at 07:04:48PM +0400, Marc-André Lureau wrote: > > > Handle calls of object_property_set_globals() with any object type, > > > but only apply glob

Re: [Qemu-devel] [PATCH v4 17/23] hw: i386: Export the MADT build method

2018-11-01 Thread Philippe Mathieu-Daudé
On 1/11/18 16:12, Philippe Mathieu-Daudé wrote: Hi Samuel, On 1/11/18 11:22, Samuel Ortiz wrote: It is going to be used by the PC machine type as the MADT table builder method and thus needs to be exported outside of acpi-build.c Also, now that the generic build_madt() API is exported, we have

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-01 Thread Liran Alon
> On 1 Nov 2018, at 15:10, Dr. David Alan Gilbert wrote: > > * Liran Alon (liran.a...@oracle.com) wrote: >> >> >>> On 31 Oct 2018, at 20:59, Dr. David Alan Gilbert >>> wrote: >>> >>> * Liran Alon (liran.a...@oracle.com) wrote: > On 31 Oct 2018, at 20:19, Paolo Bonzini wro

Re: [Qemu-devel] [PATCH] ivshmem: fix memory backend leak

2018-11-01 Thread Igor Mammedov
On Thu, 1 Nov 2018 15:27:02 +0100 Philippe Mathieu-Daudé wrote: > On 1/11/18 11:44, Igor Mammedov wrote: > > object_new() returns a new backend with refcount == 1 and > > then later object_property_add_child() increases refcount to 2 > > So when ivshmem is desroyed, the backend it has created isn

  1   2   3   >