Driver checks error code let's set it.
Signed-off-by: Yuval Shaia
---
hw/rdma/vmw/pvrdma_cmd.c | 67
1 file changed, 48 insertions(+), 19 deletions(-)
diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
index 0d3c818c20..a326c5d470 100644
Add ability to pass specific WC attributes to CQE such as GRH_BIT flag.
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_backend.c | 59 +++--
hw/rdma/rdma_backend.h | 4 +--
hw/rdma/vmw/pvrdma_qp_ops.c | 31 +++
3 files changed, 58
Commit 6e7dba23af ("hw/pvrdma: Make default pkey 0x") exports
default pkey as external definition but omit the change from 0x7FFF to
0x.
Fixes: 6e7dba23af ("hw/pvrdma: Make default pkey 0x")
Signed-off-by: Yuval Shaia
---
hw/rdma/vmw/pvrdma.h | 2 +-
1 file changed, 1 insertion(+),
In order to clean some external resources such as GIDs, QPs etc,
register to receive notification when VM is shutdown.
Signed-off-by: Yuval Shaia
---
hw/rdma/vmw/pvrdma.h | 2 ++
hw/rdma/vmw/pvrdma_main.c | 12
2 files changed, 14 insertions(+)
diff --git
The control over the RDMA device's GID table is done by updating the
device's Ethernet function addresses.
Usually the first GID entry is determine by the MAC address, the second
by the first IPv6 address and the third by the IPv4 address. Other
entries can be added by adding more IP addresses.
User should be able to control the device by changing Ethernet function
state so if user runs 'ifconfig ens3 down' the PVRDMA function should be
down as well.
Signed-off-by: Yuval Shaia
---
hw/rdma/vmw/pvrdma_cmd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
The function pvrdma_post_cqe populates CQE entry with opcode from the
given completion element. For receive operation value was not set. Fix
it by setting it to IBV_WC_RECV.
Signed-off-by: Yuval Shaia
---
hw/rdma/vmw/pvrdma_qp_ops.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
Guest driver enforces it, we should also.
Signed-off-by: Yuval Shaia
---
hw/rdma/vmw/pvrdma.h | 2 ++
hw/rdma/vmw/pvrdma_main.c | 3 +++
2 files changed, 5 insertions(+)
diff --git a/hw/rdma/vmw/pvrdma.h b/hw/rdma/vmw/pvrdma.h
index b019cb843a..10a3c4fb7c 100644
--- a/hw/rdma/vmw/pvrdma.h
Device is not supporting QP0, only QP1.
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_backend.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/rdma/rdma_backend.h b/hw/rdma/rdma_backend.h
index 86e8fe8ab6..3ccc9a2494 100644
--- a/hw/rdma/rdma_backend.h
+++
Notifier will be used for signaling shutdown event to inform system is
shutdown. This will allow devices and other component to run some
cleanup code needed before VM is shutdown.
Signed-off-by: Yuval Shaia
---
include/sysemu/sysemu.h | 1 +
vl.c| 15 ++-
2
Function create_ah might return NULL, let's exit with an error.
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_backend.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c
index d7a4bbd91f..1e148398a2 100644
--- a/hw/rdma/rdma_backend.c
+++
Upon completion of incoming packet the device pushes CQE to driver's RX
ring and notify the driver (msix).
While for data-path incoming packets the driver needs the ability to
control whether it wished to receive interrupts or not, for control-path
packets such as incoming MAD the driver needs to
MAD (Management Datagram) packets are widely used by various modules
both in kernel and in user space for example the rdma_* API which is
used to create and maintain "connection" layer on top of RDMA uses
several types of MAD packets.
To support MAD packets the device uses an external utility
This function cannot fail - fix it to return void
Signed-off-by: Yuval Shaia
---
hw/rdma/vmw/pvrdma_main.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c
index 6c8c0154fa..fc2abd34af 100644
---
RDMA MAD kernel module (ibcm) disallow more than one MAD-agent for a
given MAD class.
This does not go hand-by-hand with qemu pvrdma device's requirements
where each VM is MAD agent.
Fix it by adding implementation of RDMA MAD multiplexer service which on
one hand register as a sole MAD agent with
Hi all.
This is a major enhancement to the pvrdma device to allow it to work with
state of the art applications such as MPI.
As described in patch #5, MAD packets are management packets that are used
for many purposes including but not limited to communication layer above IB
verbs API.
Patch 1
On 11/8/18 3:45 AM, Markus Armbruster wrote:
> Cleber Rosa writes:
>
>> On 11/7/18 1:05 AM, Markus Armbruster wrote:
>>> Eduardo Habkost writes:
>>>
The $(SHELLSTATUS) variable requires GNU make >= 4.2, but Travis
seems to provide an older version. Change the existing rules to
The current OSX job often reach the 50min Travis-CI time limit.
Split it in two jobs, which as of this commit took:
- system: ~39min
- user:~9min
Signed-off-by: Philippe Mathieu-Daudé
---
.travis.yml | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/.travis.yml
On 8 November 2018 at 13:39, Richard Henderson wrote:
> On 11/8/18 1:52 PM, Peter Maydell wrote:
>> The tcg-op.h header was missing the usual guard against multiple
>> inclusion; add it.
>>
>> (Spotted by lgtm.com's static analyzer.)
>>
>> Signed-off-by: Peter Maydell
>> ---
>> tcg/tcg-op.h | 5
On 11/8/18 1:06 PM, Bastian Koppelmann wrote:
> while going through the reviews of the riscv-decodetree patches, two bugs came
> up that I fix here. There is one more problem [1] mentioned by Richard but
> I don't have the time to investigate it further.
>
> [1]
On 11/8/18 1:06 PM, Bastian Koppelmann wrote:
> Signed-off-by: Bastian Koppelmann
> ---
> target/riscv/translate.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
> -Original Message-
> From: Kevin Wolf [mailto:kw...@redhat.com]
> Sent: 08 November 2018 15:21
> To: Paul Durrant
> Cc: 'Markus Armbruster' ; Anthony Perard
> ; Tim Smith ; Stefano
> Stabellini ; qemu-bl...@nongnu.org; qemu-
> de...@nongnu.org; Max Reitz ; xen-
>
On 11/8/18 1:06 PM, Bastian Koppelmann wrote:
> sfence.vm has been replaced in priv v1.10 spec by sfence.vma.
>
> Reported-by: Richard Henderson
> Signed-off-by: Bastian Koppelmann
> ---
> target/riscv/translate.c | 18 +-
> 1 file changed, 13 insertions(+), 5 deletions(-)
Am 08.11.2018 um 15:00 hat Paul Durrant geschrieben:
> > -Original Message-
> > From: Markus Armbruster [mailto:arm...@redhat.com]
> > Sent: 05 November 2018 15:58
> > To: Paul Durrant
> > Cc: 'Kevin Wolf' ; Tim Smith ;
> > Stefano Stabellini ; qemu-bl...@nongnu.org; qemu-
> >
On Thu, Nov 8, 2018 at 3:30 PM Laurent Vivier wrote:
> On 08/11/2018 11:24, Stefan Hajnoczi wrote:
> > On Tue, Nov 06, 2018 at 05:16:14PM +0100, Laurent Vivier wrote:
> >> On 06/11/2018 16:15, Philippe Mathieu-Daudé wrote:
> >>> On 6/11/18 15:13, Michael S. Tsirkin wrote:
> On Tue, Nov 06,
On 8 November 2018 at 14:45, Eric Blake wrote:
> On 11/8/18 6:16 AM, David Gibson wrote:
>>
>> The following changes since commit
>> 4de6bb0c02ad3f0ec48f0f84ba1a65ab06e81b86:
>>
>>Update version for v3.1.0-rc0 release (2018-11-06 18:27:35 +)
>>
>
>>
>> Maria Klimushenkova (1):
>>
Am 05.11.2018 um 21:56 hat Vitaly Mayatskikh geschrieben:
> This driver uses the kernel-mode acceleration for virtio-blk and
> allows to get a near bare metal disk performance inside a VM.
>
> Signed-off-by: Vitaly Mayatskikh
> ---
> configure | 10 +
>
On 8 November 2018 at 14:43, Thomas Huth wrote:
> On 2018-11-08 14:41, Peter Maydell wrote:
>> In practice for most of the more-or-less orphan Arm board models,
>> I will review patches and put them in via the target-arm tree.
>> So list myself as an "Odd Fixes" status maintainer for them.
>>
>>
On 08.11.18 15:42, Eric Blake wrote:
> On 11/8/18 7:05 AM, David Hildenbrand wrote:
>
Thanks for the excessive answer! I think that should be enough to come
up with a RFC of a *rewrite* of the string input visitor :)
>>>
>>> You're welcome! I love great questions, they make me *think*.
On 08.11.18 15:36, Markus Armbruster wrote:
> David Hildenbrand writes:
>
>> I found some more ugliness, looking at the tests. I am not sure the test
>> is correct here.
>>
>> test_visitor_in_intList():
>>
>> v = visitor_input_test_init(data, "1,2,0,2-4,20,5-9,1-8");
>>
>> -> we expect { 0, 1,
On 08/11/2018 15:33, Li Qiang wrote:
> Though there is no inconsistency between 'queues'
> and 'peers[i]' currently, this makes the 'peers[i] == NULL'
> meaningful.
>
> Signed-off-by: Li Qiang
> ---
> hw/core/qdev-properties-system.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
On Thu, 8 Nov 2018 15:16:23 +0100
Igor Mammedov wrote:
[...]
> patch 4: convert arm's impl. to build_append_int_noprefix() API (commit
> 5d7a334f7)
>... move out to aml-build.c
my mistake, generally when we move something out,
we should do it in separate path preferably without
On 11/8/18 6:16 AM, David Gibson wrote:
The following changes since commit 4de6bb0c02ad3f0ec48f0f84ba1a65ab06e81b86:
Update version for v3.1.0-rc0 release (2018-11-06 18:27:35 +)
Maria Klimushenkova (1):
This patch fixes processing of rfi instructions in icount mode.
On 11/8/18 7:05 AM, David Hildenbrand wrote:
Thanks for the excessive answer! I think that should be enough to come
up with a RFC of a *rewrite* of the string input visitor :)
You're welcome! I love great questions, they make me *think*.
Besides, if something's worth doing, it's probably
On 8/11/18 15:40, Peter Maydell wrote:
On 8 November 2018 at 14:23, Philippe Mathieu-Daudé wrote:
Hi Corey,
On 7/11/18 16:54, miny...@acm.org wrote:
From: Corey Minyard
There is no vmstate handling for SMBus, so no device sitting on SMBus
can have a state transfer that works reliable.
On 2018-11-08 14:41, Peter Maydell wrote:
> In practice for most of the more-or-less orphan Arm board models,
> I will review patches and put them in via the target-arm tree.
> So list myself as an "Odd Fixes" status maintainer for them.
>
> This commit downgrades these boards to "Odd Fixes":
>
Though there is no inconsistency between 'queues'
and 'peers[i]' currently, this makes the 'peers[i] == NULL'
meaningful.
Signed-off-by: Li Qiang
---
hw/core/qdev-properties-system.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/qdev-properties-system.c
Hi,
This series failed docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 1541616504-68526-1-git-send-email-bijan.mottahe...@oracle.com
Subject: [Qemu-devel] [RFC
On 6 November 2018 at 22:19, Paolo Bonzini wrote:
> On 06/11/2018 16:33, Peter Maydell wrote:
>> Currently replay_get_byte() does not check for an error
>> from getc(). Coverity points out (CID 1390622) that this
>> could result in unexpected behaviour (such as looping
>> forever, if we use the
Hi Igor,
On Thu, Nov 08, 2018 at 03:16:23PM +0100, Igor Mammedov wrote:
> On Mon, 5 Nov 2018 02:40:28 +0100
> Samuel Ortiz wrote:
>
> > XSDT is the 64-bit version of the legacy ACPI RSDT (Root System
> > Description Table). RSDT only allow for 32-bit addressses and have thus
> > been
Hi,
This series failed docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 1541616504-68526-1-git-send-email-bijan.mottahe...@oracle.com
Subject: [Qemu-devel] [RFC
Reported-by: LGTM code review
Signed-off-by: Philippe Mathieu-Daudé
---
scripts/analyse-locks-simpletrace.py | 1 -
scripts/analyze-migration.py | 1 -
scripts/device-crash-test| 1 -
scripts/simpletrace.py | 1 -
On 08/11/2018 11:24, Stefan Hajnoczi wrote:
> On Tue, Nov 06, 2018 at 05:16:14PM +0100, Laurent Vivier wrote:
>> On 06/11/2018 16:15, Philippe Mathieu-Daudé wrote:
>>> On 6/11/18 15:13, Michael S. Tsirkin wrote:
On Tue, Nov 06, 2018 at 02:27:18PM +0100, Philippe Mathieu-Daudé wrote:
> On
David Hildenbrand writes:
> I found some more ugliness, looking at the tests. I am not sure the test
> is correct here.
>
> test_visitor_in_intList():
>
> v = visitor_input_test_init(data, "1,2,0,2-4,20,5-9,1-8");
>
> -> we expect { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 20 }, implying that the
> visitor
On 8 November 2018 at 14:23, Philippe Mathieu-Daudé wrote:
> Hi Corey,
>
>
> On 7/11/18 16:54, miny...@acm.org wrote:
>>
>> From: Corey Minyard
>>
>> There is no vmstate handling for SMBus, so no device sitting on SMBus
>> can have a state transfer that works reliable. So add it.
>>
>>
On Mon, 5 Nov 2018 02:40:26 +0100
Samuel Ortiz wrote:
> For both x86 and ARM architectures, the internal RSDP build API can
> return void as the current return value is unused.
>
> Signed-off-by: Samuel Ortiz
Reviewed-by: Igor Mammedov
> ---
> hw/arm/virt-acpi-build.c | 4 +---
>
Hi Corey,
On 7/11/18 16:54, miny...@acm.org wrote:
From: Corey Minyard
There is no vmstate handling for SMBus, so no device sitting on SMBus
can have a state transfer that works reliable. So add it.
Signed-off-by: Corey Minyard
Cc: Paolo Bonzini
Cc: Michael S. Tsirkin
Cc: Dr. David Alan
On Mon, 5 Nov 2018 02:40:39 +0100
Samuel Ortiz wrote:
> From: Yang Zhong
>
> When using the generated memory hotplug AML, the iasl
> compiler would give the following error:
>
> dsdt.dsl 266: Return (MOST (_UID, Arg0, Arg1, Arg2))
> Error 6080 - Called method returns no value ^
>
>
The code was using the qemu UUID for the BMC. But that's really
not a good method. In general, you don't want the GUID to change
when you migrate, and you want the GUID to be the same between
invocations of qemu (if you have a GUID).
Plus, if you have multiple BMCs, they need to have different
On 11/7/18 7:48 PM, Bijan Mottahedeh wrote:
>
> +static void set_system_clock_scale(void)
> +{
> +unsigned long cntfrq_el0;
> +
> +asm volatile("mrs %0, cntfrq_el0" : "=r"(cntfrq_el0));
> +
> +if (cntfrq_el0 == 0) {
> +cntfrq_el0 = GTIMER_SCALE_DEF;
> +}
> +
> +
From: Corey Minyard
This is for IPMI, which will behave differently if the UUID is
not set.
Signed-off-by: Corey Minyard
Cc: Fam Zheng
Cc: Michael S. Tsirkin
Cc: Marc-André Lureau
---
include/hw/qdev-properties.h | 7 +++
1 file changed, 7 insertions(+)
diff --git
From: Corey Minyard
Using the UUID that qemu generates probably isn't the best thing
to do, allow it to be passed in via properties, and use QemuUUID
for the type.
If the UUID is not set, return an unsupported command error. This
way we are not providing an all-zero (or randomly generated)
On Mon, 5 Nov 2018 02:40:28 +0100
Samuel Ortiz wrote:
> XSDT is the 64-bit version of the legacy ACPI RSDT (Root System
> Description Table). RSDT only allow for 32-bit addressses and have thus
> been deprecated. Since ACPI version 2.0, RSDPs should point at XSDTs and
> no longer RSDTs,
On Mon, 5 Nov 2018 03:10:28 +0100
Samuel Ortiz wrote:
> Hi Igor,
>
> On Fri, Nov 02, 2018 at 01:29:25PM +0100, Igor Mammedov wrote:
> > On Thu, 1 Nov 2018 11:22:40 +0100
> > Samuel Ortiz wrote:
[...]
> > > some ACPI code reorganization with the following goals:
> > >
> > > * Share as much as
It looks the kernel space vhost-blk can only process raw image.
How about to verify that only raw image is used in the drive command line when
vhost-blk-pci is paired with it?
Otherwise, vhost-blk-pci might be working with qcow2 image without any warning
on qemu side.
Dongli Zhang
On
On 8/11/18 14:17, Peter Maydell wrote:
On 8 November 2018 at 13:08, Philippe Mathieu-Daudé wrote:
On 8/11/18 13:52, Peter Maydell wrote:
The tcg-op.h header was missing the usual guard against multiple
inclusion; add it.
(Spotted by lgtm.com's static analyzer.)
I'm pretty sure there are
On 7 November 2018 at 15:54, wrote:
> From: Corey Minyard
>
> This was if the eeprom is accessed during a state transfer, the
> transfer will be reliable.
>
> Signed-off-by: Corey Minyard
> Cc: Paolo Bonzini
> Cc: Michael S. Tsirkin
> Cc: Dr. David Alan Gilbert
> ---
>
Signed-off-by: Alexandro Sanchez Bach
---
target/i386/Makefile.objs | 5 -
target/i386/hax-i386.h| 10 +-
target/i386/{hax-darwin.c => hax-posix.c} | 0
target/i386/{hax-darwin.h => hax-posix.h} | 0
4 files changed, 13 insertions(+), 2
> -Original Message-
> From: Markus Armbruster [mailto:arm...@redhat.com]
> Sent: 05 November 2018 15:58
> To: Paul Durrant
> Cc: 'Kevin Wolf' ; Tim Smith ;
> Stefano Stabellini ; qemu-bl...@nongnu.org; qemu-
> de...@nongnu.org; Max Reitz ; Anthony Perard
> ;
Sorry if this sounds dumb, where do I find my CLI Parameters for my
Windows VM?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1734810
Title:
Windows guest virtual PC running abnormally slow
On 08.11.18 14:35, Cornelia Huck wrote:
> On Mon, 5 Nov 2018 12:03:13 +0100
> David Hildenbrand wrote:
>
>> Right now, errors during realize()/pre_plug/plug of the zPCI device
>> would result in QEMU crashing instead of failing nicely when creating
>> a zPCI device for a PCI device.
>>
>>
On 7 November 2018 at 16:27, Alex Williamson wrote:
> On Tue, 6 Nov 2018 19:42:12 +0100
> Eric Auger wrote:
>
>> Commit af7d64ede0b9 (hw/arm/sysbus-fdt: Allow device matching with DT
>> compatible value) introduced a match_fn callback which gets called
>> for each registered combo to check
On 8/11/18 14:41, Peter Maydell wrote:
In practice for most of the more-or-less orphan Arm board models,
I will review patches and put them in via the target-arm tree.
So list myself as an "Odd Fixes" status maintainer for them.
This commit downgrades these boards to "Odd Fixes":
*
On 6 November 2018 at 18:17, Thomas Huth wrote:
> There is no active maintainer, but since Peter is picking up
> patches via qemu-...@nongnu.org, I think we could at least use
> "Odd Fixes" as status here.
>
> Signed-off-by: Thomas Huth
> ---
> MAINTAINERS | 6 ++
> 1 file changed, 6
On 08/11/2018 14:06, Eduardo Habkost wrote:
> On Thu, Nov 08, 2018 at 10:55:21AM +0100, Paolo Bonzini wrote:
>> On 07/11/2018 20:30, Thomas Huth wrote:
>>> On 2018-11-07 20:24, Eduardo Habkost wrote:
On Wed, Nov 07, 2018 at 06:39:54PM +0100, Paolo Bonzini wrote:
> On 07/11/2018 16:41,
In practice for most of the more-or-less orphan Arm board models,
I will review patches and put them in via the target-arm tree.
So list myself as an "Odd Fixes" status maintainer for them.
This commit downgrades these boards to "Odd Fixes":
* Allwinner-A10
* Exynos
* Calxeda Highbank
* Canon
On 11/8/18 1:52 PM, Peter Maydell wrote:
> The tcg-op.h header was missing the usual guard against multiple
> inclusion; add it.
>
> (Spotted by lgtm.com's static analyzer.)
>
> Signed-off-by: Peter Maydell
> ---
> tcg/tcg-op.h | 5 +
> 1 file changed, 5 insertions(+)
Reviewed-by: Richard
On Mon, 5 Nov 2018 12:03:13 +0100
David Hildenbrand wrote:
> Right now, errors during realize()/pre_plug/plug of the zPCI device
> would result in QEMU crashing instead of failing nicely when creating
> a zPCI device for a PCI device.
>
> Signed-off-by: David Hildenbrand
> ---
>
On Thu, 8 Nov 2018 23:16:44 +1100
David Gibson wrote:
> From: Maria Klimushenkova
>
> In this mode writing to interrupt/peripheral state is controlled
> by can_do_io flag. This flag must be set explicitly before helper
> function invocation.
>
> Signed-off-by: Maria Klimushenkova
>
On 8 November 2018 at 13:08, Philippe Mathieu-Daudé wrote:
> On 8/11/18 13:52, Peter Maydell wrote:
>>
>> The tcg-op.h header was missing the usual guard against multiple
>> inclusion; add it.
>>
>> (Spotted by lgtm.com's static analyzer.)
>
>
> I'm pretty sure there are more occurences.
The
Hi
On Thu, Nov 8, 2018 at 4:52 PM Peter Maydell wrote:
>
> The guest-agent-core.h header was missing the usual guards
> against multiple inclusion; add them.
>
> (Spotted by lgtm.com's static analyzer.)
neat,
Reviewed-by: Marc-André Lureau
>
> Signed-off-by: Peter Maydell
> ---
>
On 08.11.18 10:13, Markus Armbruster wrote:
> David Hildenbrand writes:
>
Would it be valid to do something like this (skipping elements without a
proper visit_type_int)
visit_start_list();
visit_next_list(); more input, returns "there's more"
visit_next_list();
Cc'ing qemu-trivial@
On 8/11/18 13:21, Mao Zhongyi wrote:
Signed-off-by: Mao Zhongyi
Reviewed-by: Philippe Mathieu-Daudé
---
hw/pci/pci_bridge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c
index ee9dff2d3a..da8daa3ff2
On 8/11/18 13:52, Peter Maydell wrote:
The tcg-op.h header was missing the usual guard against multiple
inclusion; add it.
(Spotted by lgtm.com's static analyzer.)
I'm pretty sure there are more occurences.
Signed-off-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
Tested-by:
On Thu, Nov 8, 2018 at 4:53 PM Peter Maydell wrote:
>
> The tcg-op.h header was missing the usual guard against multiple
> inclusion; add it.
>
> (Spotted by lgtm.com's static analyzer.)
>
> Signed-off-by: Peter Maydell
Reviewed-by: Marc-André Lureau
> ---
> tcg/tcg-op.h | 5 +
> 1 file
On 8/11/18 13:52, Peter Maydell wrote:
The guest-agent-core.h header was missing the usual guards
against multiple inclusion; add them.
(Spotted by lgtm.com's static analyzer.)
Signed-off-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
---
On Thu, Nov 08, 2018 at 10:55:21AM +0100, Paolo Bonzini wrote:
> On 07/11/2018 20:30, Thomas Huth wrote:
> > On 2018-11-07 20:24, Eduardo Habkost wrote:
> >> On Wed, Nov 07, 2018 at 06:39:54PM +0100, Paolo Bonzini wrote:
> >>> On 07/11/2018 16:41, Samuel Ortiz wrote:
> - The Kconfig parser
The tcg-op.h header was missing the usual guard against multiple
inclusion; add it.
(Spotted by lgtm.com's static analyzer.)
Signed-off-by: Peter Maydell
---
tcg/tcg-op.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h
index 7513c1eb7c5..db4e9188f42 100644
The guest-agent-core.h header was missing the usual guards
against multiple inclusion; add them.
(Spotted by lgtm.com's static analyzer.)
Signed-off-by: Peter Maydell
---
qga/guest-agent-core.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/qga/guest-agent-core.h
Paolo Bonzini writes:
> On 08/11/2018 09:46, Philippe Mathieu-Daudé wrote:
>>
>> Almost; if there's a conflict between the decision from "depends on" and
>> "select" says, it's an error. (Likewise if there's a conflict between
>> default-configs/ on one side, and "depends
On 11/7/18 11:02 PM, Alexey Kardashevskiy wrote:
This adds a "KVM" marker to the "into mtree -f" to tell the user if
a particular memory section is registered as a KVM memory slot; useful
for debugging purposes.
Since it is memory sections which get registered in KVM (rather than
memory
Philippe Mathieu-Daudé writes:
> Hi Markus,
>
>
> Le jeu. 8 nov. 2018 09:46, Markus Armbruster a écrit :
>
>> Cleber Rosa writes:
>>
>> > On 11/7/18 1:05 AM, Markus Armbruster wrote:
[...]
>> >> PEP 394 recommends software distributions install Python 3 into the
>> >> default path as python3,
On Mon, 5 Nov 2018 11:20:37 +0100
David Hildenbrand wrote:
> The callbacks are also called for cold plugged devices. Drop the "hot"
> to better match the actual callback names.
>
> Signed-off-by: David Hildenbrand
> ---
> hw/s390x/s390-pci-bus.c | 12 ++--
> 1 file changed, 6
08.11.2018 13:33, Kevin Wolf wrote:
> Am 08.11.2018 um 11:02 hat Vladimir Sementsov-Ogievskiy geschrieben:
>> 07.11.2018 21:16, Kevin Wolf wrote:
>>> (Broken quoting in text/plain again)
>>>
>>> Am 01.11.2018 um 13:17 hat Vladimir Sementsov-Ogievskiy geschrieben:
27.09.2018 20:35, Max Reitz
Signed-off-by: Mao Zhongyi
---
hw/pci/pci_bridge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c
index ee9dff2d3a..da8daa3ff2 100644
--- a/hw/pci/pci_bridge.c
+++ b/hw/pci/pci_bridge.c
@@ -310,7 +310,7 @@ void
Hi
On Fri, Jul 6, 2018 at 2:59 PM Marc-André Lureau
wrote:
>
> Hi,
>
> This is the second part of the "add #if pre-processor conditions to
> generated code" series, adding schema member conditions (roughly
> 16-38/49).
>
> Members can be exploded as dictionnary with 'type'/'if' keys:
>
> {
From: Maria Klimushenkova
In this mode writing to interrupt/peripheral state is controlled
by can_do_io flag. This flag must be set explicitly before helper
function invocation.
Signed-off-by: Maria Klimushenkova
Signed-off-by: Pavel Dovgalyuk
Tested-by: Mark Cave-Ayland
Signed-off-by: David
From: Greg Kurz
When allocating an array, it is a recommended coding practice to call
g_new(FooType, n) instead of g_malloc(n * sizeof(FooType)) because
it takes care to avoid overflow when calculating the size of the
allocated block and it returns FooType *, which allows the compiler
to perform
From: Suraj Jitindar Singh
Add the spapr cap SPAPR_CAP_NESTED_KVM_HV to be used to control the
availability of nested kvm-hv to the level 1 (L1) guest.
Assuming a hypervisor with support enabled an L1 guest can be allowed to
use the kvm-hv module (and thus run it's own kvm-hv guests) by
From: Alexander Graf
I haven't really been maintaining any PowerPC code for quite a while now,
so let's reflect reality: David does all the work and embedded PPC is in
"Odd Fixes" state rather than supported now.
Signed-off-by: Alexander Graf
Signed-off-by: David Gibson
---
MAINTAINERS | 30
From: Peter Maydell
Coverity points out in CID 1390588 that the test for sh == 0
in sdram_size() can never fire, because we calculate sh with
sh = 1024 - ((bcr >> 6) & 0x3ff);
which must result in a value between 1 and 1024 inclusive.
Without the relevant manual for the SoC, we're not
From: Prasad J Pandit
While performing PowerNV memory r/w operations, the access length
'sz' could exceed the data[4] buffer size. Add check to avoid OOB
access.
Reported-by: Moguofang
Signed-off-by: Prasad J Pandit
Reviewed-by: Cédric Le Goater
Signed-off-by: David Gibson
---
From: Richard Henderson
Having a separate, logical classifiation of numbers will
unify more error paths for different formats.
Signed-off-by: Richard Henderson
Signed-off-by: David Gibson
---
target/ppc/fpu_helper.c | 94 ++---
1 file changed, 51
From: Suraj Jitindar Singh
The ptcr (partition table control register) is used to store the address
and size of the partition table. For nested kvm-hv we have a level 1
guest register the location of it's partition table with the hypervisor.
Thus to support migration we need to be able to read
From: Peter Maydell
In ppc_core99_init(), we allocate an openpic_irqs array, which
we then use to collect up the various qemu_irqs which we're
going to connect to the interrupt controller. Once we've
called sysbus_connect_irq() to connect them all up, the
array is no longer required, but we
From: "Dr. David Alan Gilbert"
Fix missing terminator in VMStateDescription
Fixes: d811d61fbc6ca5f2be2185fd7cfa916e7ba613ce
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Mark Cave-Ayland
Reviewed-by: Laurent Vivier
Signed-off-by: David Gibson
---
hw/misc/macio/pmu.c | 1 +
1 file
From: Richard Henderson
Use do_float_check_status directly, so that we don't get confused
about which return address we're using. And definitely don't use
helper_float_check_status.
Signed-off-by: Richard Henderson
Signed-off-by: David Gibson
---
target/ppc/fpu_helper.c | 77
From: Pavel Dovgalyuk
This patch fixes processing of mtmsr instructions in icount mode.
In this mode writing to interrupt/peripheral state is controlled
by can_do_io flag. This flag must be set explicitly before helper
function invocation.
Signed-off-by: Maria Klimushenkova
Signed-off-by:
From: Richard Henderson
Signed-off-by: Richard Henderson
Signed-off-by: David Gibson
---
target/ppc/fpu_helper.c | 52 +++--
1 file changed, 24 insertions(+), 28 deletions(-)
diff --git a/target/ppc/fpu_helper.c b/target/ppc/fpu_helper.c
index
From: Thomas Huth
The spapr-rng device is suboptimal when compared to virtio-rng, so
users might want to disable it in their builds. Thus let's introduce
a proper CONFIG switch to allow us to compile QEMU without this device.
The function spapr_rng_populate_dt is required for linking, so move it
101 - 200 of 309 matches
Mail list logo
