Re: [Qemu-devel] [RFC v9 06/17] virtio-iommu: Endpoint and domains structs and helpers

2018-11-22 Thread Auger Eric
Hi Bharat, On 11/23/18 7:38 AM, Bharat Bhushan wrote: > Hi Eric, > >> -Original Message- >> From: Eric Auger >> Sent: Thursday, November 22, 2018 10:45 PM >> To: eric.auger@gmail.com; eric.au...@redhat.com; qemu- >> de...@nongnu.org; qemu-...@nongnu.org; peter.mayd...@linaro.org; >>

Re: [Qemu-devel] [Qemu-block] [PATCH 3/5] iotests: allow resume_drive by node name

2018-11-22 Thread Peter Krempa
On Thu, Nov 22, 2018 at 21:48:05 +0300, Andrey Shinkevich wrote: > After node graph changes, we may not be able to resume_drive by device > name (backing files are not recursively searched). So, lets allow to > resume by node-name. Set constant name for breakpoints, to avoid > introducing extra

Re: [Qemu-devel] [Qemu-block] [PATCH 0/5] Discrad blocks during block-stream operation

2018-11-22 Thread Peter Krempa
On Thu, Nov 22, 2018 at 21:48:02 +0300, Andrey Shinkevich wrote: > Hello everyone! > > The given feature discards blocks with copy-on-read operation while the > streaming process runs. Adding the 'discard' argument to the QMP block-stream > command allows dropping a block in the backing chain

Re: [Qemu-devel] [PATCH v4] hw/arm: Add arm SBSA reference machine

2018-11-22 Thread Hongbo Zhang
On Fri, 23 Nov 2018 at 15:14, Hongbo Zhang wrote: > > On Fri, 16 Nov 2018 at 00:05, Peter Maydell wrote: > > > > On 19 October 2018 at 09:55, Hongbo Zhang wrote: > > > For the Aarch64, there is one machine 'virt', it is primarily meant to > > > run on KVM and execute virtualization workloads,

Re: [Qemu-devel] [PATCH v5 06/36] ppc/xive: add support for the END Event State buffers

2018-11-22 Thread Cédric Le Goater
On 11/23/18 5:36 AM, David Gibson wrote: > On Thu, Nov 22, 2018 at 10:58:56PM +0100, Cédric Le Goater wrote: >> On 11/22/18 6:13 AM, David Gibson wrote: >>> On Fri, Nov 16, 2018 at 11:56:59AM +0100, Cédric Le Goater wrote: The Event Notification Descriptor also contains two Event State

Re: [Qemu-devel] [PATCH v4] hw/arm: Add arm SBSA reference machine

2018-11-22 Thread Hongbo Zhang
On Fri, 16 Nov 2018 at 00:05, Peter Maydell wrote: > > On 19 October 2018 at 09:55, Hongbo Zhang wrote: > > For the Aarch64, there is one machine 'virt', it is primarily meant to > > run on KVM and execute virtualization workloads, but we need an > > environment as faithful as possible to

Re: [Qemu-devel] 答复: Can't see mouse cursor on VNC viewer

2018-11-22 Thread Heyi Guo
Thanks; I'll try it. Heyi On 2018/11/22 18:04, Gerd Hoffmann wrote: On Thu, Nov 22, 2018 at 05:08:16PM +0800, Heyi Guo wrote: Hi Gerd, One more question: do you know any VNC client which supports rich cursor extension? We'd like to try such client to see the real effect. remote-viewer

[Qemu-devel] [PATCH] cirrus_vga/migration: update the bank offset before use

2018-11-22 Thread linzhecheng
From: Wang Xin The cirrus bank0/1 offset should be updated before we update the vram's alias offset. Signed-off-by: Wang Xin diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index d9b854d..a0e7146 100644 --- a/hw/display/cirrus_vga.c +++ b/hw/display/cirrus_vga.c @@ -2746,11

Re: [Qemu-devel] [PATCH v5 1/6] fsdev-throttle-qmp: factor out throttle code to reuse code

2018-11-22 Thread xiezhide
> -Original Message- > From: Greg Kurz [mailto:gr...@kaod.org] > Sent: Thursday, November 22, 2018 10:46 PM > To: xiezhide > Cc: qemu-devel@nongnu.org; aneesh.ku...@linux.vnet.ibm.com; > ebl...@redhat.com; arm...@redhat.com; be...@igalia.com; zengcanfu > 00215970 ; Jinxuefeng ; >

[Qemu-devel] [PATCH v2] audio/hda: fix guest triggerable assert

2018-11-22 Thread Gerd Hoffmann
Guest writes to a readonly register trigger the assert in intel_hda_reg_write(). Add a check and just ignore them. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1628433 Signed-off-by: Gerd Hoffmann Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daudé ---

Re: [Qemu-devel] [RFC v9 06/17] virtio-iommu: Endpoint and domains structs and helpers

2018-11-22 Thread Bharat Bhushan
Hi Eric, > -Original Message- > From: Eric Auger > Sent: Thursday, November 22, 2018 10:45 PM > To: eric.auger@gmail.com; eric.au...@redhat.com; qemu- > de...@nongnu.org; qemu-...@nongnu.org; peter.mayd...@linaro.org; > m...@redhat.com; jean-philippe.bruc...@arm.com > Cc:

Re: [Qemu-devel] [PATCH-for-3.1] [REGRESSION FIX] ps2kbd: default to scan enabled after reset

2018-11-22 Thread Gerd Hoffmann
On Thu, Nov 22, 2018 at 07:30:41PM +0100, Hervé Poussineau wrote: > Ping again. Queued up for 3.1 thanks, Gerd

Re: [Qemu-devel] [PATCH] audio/hda: fix guest triggerable assert

2018-11-22 Thread Gerd Hoffmann
On Thu, Nov 22, 2018 at 03:52:12PM +, Dr. David Alan Gilbert wrote: > * Gerd Hoffmann (kra...@redhat.com) wrote: > > Guest writes to a readonly register trigger the assert in > > intel_hda_reg_write(). Add a check and just ignore them. > > > > Buglink:

Re: [Qemu-devel] [PATCH v5 04/36] ppc/xive: introduce the XiveRouter model

2018-11-22 Thread David Gibson
On Thu, Nov 22, 2018 at 08:53:00AM +0100, Cédric Le Goater wrote: > On 11/22/18 5:11 AM, David Gibson wrote: > > On Fri, Nov 16, 2018 at 11:56:57AM +0100, Cédric Le Goater wrote: > >> The XiveRouter models the second sub-engine of the overall XIVE > >> architecture : the Interrupt Virtualization

Re: [Qemu-devel] [PATCH v5 07/36] ppc/xive: introduce the XIVE interrupt thread context

2018-11-22 Thread David Gibson
On Fri, Nov 16, 2018 at 11:57:00AM +0100, Cédric Le Goater wrote: > Each POWER9 processor chip has a XIVE presenter that can generate four > different exceptions to its threads: > > - hypervisor exception, > - O/S exception > - Event-Based Branch (EBB) > - msgsnd (doorbell). > > Each

Re: [Qemu-devel] [PATCH v5 04/36] ppc/xive: introduce the XiveRouter model

2018-11-22 Thread David Gibson
On Thu, Nov 22, 2018 at 05:50:07PM +1100, Benjamin Herrenschmidt wrote: > On Thu, 2018-11-22 at 15:44 +1100, David Gibson wrote: > > > > Sorry, didn't think of this in my first reply. > > > > 1) Does the hardware ever actually write back to the EAS? I know it > > does for the END, but it's not

Re: [Qemu-devel] [PATCH v5 05/36] ppc/xive: introduce the XIVE Event Notification Descriptors

2018-11-22 Thread David Gibson
On Thu, Nov 22, 2018 at 10:47:44PM +0100, Cédric Le Goater wrote: > On 11/22/18 5:41 AM, David Gibson wrote: > > On Fri, Nov 16, 2018 at 11:56:58AM +0100, Cédric Le Goater wrote: > >> To complete the event routing, the IVRE sub-engine uses an internal > >> table containing Event Notification

Re: [Qemu-devel] [PATCH v5 02/36] ppc/xive: add support for the LSI interrupt sources

2018-11-22 Thread David Gibson
On Thu, Nov 22, 2018 at 08:39:41AM +0100, Cédric Le Goater wrote: > On 11/22/18 4:19 AM, David Gibson wrote: > > On Fri, Nov 16, 2018 at 11:56:55AM +0100, Cédric Le Goater wrote: > >> The 'sent' status of the LSI interrupt source is modeled with the 'P' > >> bit of the ESB and the assertion status

Re: [Qemu-devel] [PATCH v3] qapi: add query-display-options command

2018-11-22 Thread Gerd Hoffmann
On Thu, Nov 22, 2018 at 03:58:02PM +0100, Erik Skultety wrote: > On Thu, Nov 22, 2018 at 08:16:13AM +0100, Gerd Hoffmann wrote: > > Add query-display-options command, which allows querying the qemu > > display configuration, and -- as an intentional side effect -- makes > > DisplayOptions

Re: [Qemu-devel] [PATCH v5 06/36] ppc/xive: add support for the END Event State buffers

2018-11-22 Thread David Gibson
On Thu, Nov 22, 2018 at 10:58:56PM +0100, Cédric Le Goater wrote: > On 11/22/18 6:13 AM, David Gibson wrote: > > On Fri, Nov 16, 2018 at 11:56:59AM +0100, Cédric Le Goater wrote: > >> The Event Notification Descriptor also contains two Event State > >> Buffers providing further coalescing of

Re: [Qemu-devel] [PATCH v5 05/36] ppc/xive: introduce the XIVE Event Notification Descriptors

2018-11-22 Thread David Gibson
On Thu, Nov 22, 2018 at 05:49:09PM +1100, Benjamin Herrenschmidt wrote: > On Thu, 2018-11-22 at 15:41 +1100, David Gibson wrote: > > > > > +void xive_end_reset(XiveEND *end) > > > +{ > > > +memset(end, 0, sizeof(*end)); > > > + > > > +/* switch off the escalation and notification ESBs */

Re: [Qemu-devel] [PATCH v5 04/36] ppc/xive: introduce the XiveRouter model

2018-11-22 Thread David Gibson
On Thu, Nov 22, 2018 at 08:59:32AM +0100, Cédric Le Goater wrote: > On 11/22/18 7:50 AM, Benjamin Herrenschmidt wrote: > > On Thu, 2018-11-22 at 15:44 +1100, David Gibson wrote: > >> > >> Sorry, didn't think of this in my first reply. > >> > >> 1) Does the hardware ever actually write back to the

Re: [Qemu-devel] SeaBIOS booting time optimization

2018-11-22 Thread Gerd Hoffmann
On Thu, Nov 22, 2018 at 04:13:38PM +0100, Stefano Garzarella wrote: > On Thu, Nov 22, 2018 at 12:51 PM Gerd Hoffmann wrote: > > > > On Thu, Nov 22, 2018 at 12:08:55PM +0100, Stefano Garzarella wrote: > > > Hi, > > > I continued to investigate how to reduce the boot time with SeaBIOS > > > and

Re: [Qemu-devel] [PATCH v1 00/16] packed ring virtio-net backend support

2018-11-22 Thread Wei Xu
On Thu, Nov 22, 2018 at 06:57:31PM +0100, Maxime Coquelin wrote: > Hi Wei, > > I just tested your series with Tiwei's v3, and it fails > with ctrl vq enabled: > qemu-system-x86_64: virtio-net ctrl missing headers OK, I haven't tried Tiwei's v3 yet, will give it a try. Wei > > Regards, >

[Qemu-devel] [PATCH] MAINTAINERS: Fix ACPI tests data files path

2018-11-22 Thread Philippe Mathieu-Daudé
Missed while moving those files in 438c78dab75. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1032406c56..6c4f25fb05 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1216,8 +1216,7 @@ F:

Re: [Qemu-devel] [PATCH 1/5] VFIO KABI for migration interface

2018-11-22 Thread Zhao Yan
On Wed, Nov 21, 2018 at 04:39:39AM +0800, Kirti Wankhede wrote: > - Defined MIGRATION region type and sub-type. > - Defined VFIO device states during migration process. > - Defined vfio_device_migration_info structure which will be placed at 0th > offset of migration region to get/set VFIO

Re: [Qemu-devel] [PATCH 3/5] Add migration functions for VFIO devices

2018-11-22 Thread Zhao Yan
On Fri, Nov 23, 2018 at 02:51:39AM +0530, Kirti Wankhede wrote: > > > On 11/21/2018 1:09 PM, Zhao, Yan Y wrote: > > > > > >> -Original Message- > >> From: Qemu-devel [mailto:qemu-devel- > >> bounces+yan.y.zhao=intel@nongnu.org] On Behalf Of Kirti Wankhede > >> Sent: Wednesday,

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2018-11-22 Thread Philippe Mathieu-Daudé
Hi Zoltan, On 22/11/18 22:56, BALATON Zoltan wrote: > On Thu, 22 Nov 2018, Thomas Huth wrote: >>> 19 hw/display/sm501.c >> >> Maybe Balaton wants to adopt this file? > > As discussed before this was originally part of SH4 but since that seems > to be not actively maintained any more and

Re: [Qemu-devel] [PATCH] MAINTAINERS: add missing xtensa patterns

2018-11-22 Thread Philippe Mathieu-Daudé
On 23/11/18 0:08, Max Filippov wrote: > Signed-off-by: Max Filippov Reviewed-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 1032406c5607..f4a7e453c06f 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS >

Re: [Qemu-devel] [PATCH] Xen PCI passthrough: fix passthrough failure when irq map failure

2018-11-22 Thread Zhao Yan
On Thu, Nov 22, 2018 at 03:18:05PM +0100, Roger Pau Monné wrote: > On Thu, Nov 22, 2018 at 08:11:20AM -0500, Zhao Yan wrote: > > On Thu, Oct 18, 2018 at 03:56:36PM +0100, Roger Pau Monné wrote: > > > On Thu, Oct 18, 2018 at 08:22:41AM +, Zhao, Yan Y wrote: > > > > Hi > > > > The background for

Re: [Qemu-devel] [PATCH 06/22] dma/puv3_dma: Convert sysbus initfunction to realize function

2018-11-22 Thread maozy
On 11/20/18 10:46 PM, Peter Maydell wrote: On 19 November 2018 at 12:08, Mao Zhongyi wrote: Use DeviceClass rather than SysBusDeviceClass in puv3_dma_class_init(). Cc: g...@mprc.pku.edu.cn Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju --- hw/dma/puv3_dma.c | 10 --

Re: [Qemu-devel] [PATCH 22/22] core/sysbus: remove the SysBusDeviceClass::initpath

2018-11-22 Thread maozy
Hi, Eduardo On 11/20/18 7:31 AM, Eduardo Habkost wrote: On Mon, Nov 19, 2018 at 08:08:20PM +0800, Mao Zhongyi wrote: Currently, all sysbus devices have been converted to realize(), so remove this path. Cc: ehabk...@redhat.com Cc: th...@redhat.com Cc: pbonz...@redhat.com Cc: arm...@redhat.com

Re: [Qemu-devel] [PATCH v5 01/36] ppc/xive: introduce a XIVE interrupt source model

2018-11-22 Thread David Gibson
On Thu, Nov 22, 2018 at 08:25:06AM +0100, Cédric Le Goater wrote: > On 11/22/18 4:05 AM, David Gibson wrote: > > On Fri, Nov 16, 2018 at 11:56:54AM +0100, Cédric Le Goater wrote: > >> The first sub-engine of the overall XIVE architecture is the Interrupt > >> Virtualization Source Engine (IVSE).

Re: [Qemu-devel] [PATCH] spapr: drop redundant statement in spapr_populate_drconf_memory()

2018-11-22 Thread David Gibson
On Thu, Nov 22, 2018 at 03:31:36PM +0100, Greg Kurz wrote: > Signed-off-by: Greg Kurz Applied to ppc-for-3.2. > --- > hw/ppc/spapr.c |2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 9c41098b5781..7771a628f879 100644 > --- a/hw/ppc/spapr.c >

Re: [Qemu-devel] [PATCH for 3.1 v3] spapr: Fix ibm, max-associativity-domains property number of nodes

2018-11-22 Thread David Gibson
On Thu, Nov 22, 2018 at 08:19:27AM -0500, Serhii Popovych wrote: > Laurent Vivier reported off by one with maximum number of NUMA nodes > provided by qemu-kvm being less by one than required according to > description of "ibm,max-associativity-domains" property in LoPAPR. > > It appears that I

[Qemu-devel] [PATCH] MAINTAINERS: add missing xtensa patterns

2018-11-22 Thread Max Filippov
Signed-off-by: Max Filippov --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1032406c5607..f4a7e453c06f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -311,6 +311,8 @@ F: target/xtensa/ F: hw/xtensa/ F: tests/tcg/xtensa/ F: disas/xtensa.c

Re: [Qemu-devel] [PATCH] audio/hda: fix guest triggerable assert

2018-11-22 Thread Philippe Mathieu-Daudé
Hi Gerd, On 22/11/18 14:32, Gerd Hoffmann wrote: > Guest writes to a readonly register trigger the assert in > intel_hda_reg_write(). Add a check and just ignore them. Is this 3.1 material? It seems to apply. > > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1628433 > Signed-off-by:

Re: [Qemu-devel] [PATCH for-3.1] MAINTAINERS: Add an ARM SMMU section

2018-11-22 Thread Philippe Mathieu-Daudé
Hi Eric, On 22/11/18 19:01, Eric Auger wrote: > Add a new ARM SMMU section and set Eric Auger as the maintainer > for ARM SMMU emulation sources. > > Signed-off-by: Eric Auger > Suggested-by: Peter Maydell > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git

Re: [Qemu-devel] [PATCH v2 for-4.0 3/3] elf_ops.h: Use address_space_write() to write memory

2018-11-22 Thread Philippe Mathieu-Daudé
On 22/11/18 18:26, Peter Maydell wrote: > Currently the load_elf function in elf_ops.h uses > cpu_physical_memory_write() to write the ELF file to > memory if it is not handling it as a ROM blob. This > means we ignore the AddressSpace that the function > is passed to define where it should be

Re: [Qemu-devel] [PATCH v2 for-4.0 2/3] monitor: Use address_space_read() to read memory

2018-11-22 Thread Philippe Mathieu-Daudé
On 22/11/18 18:26, Peter Maydell wrote: > Currently monitor.c reads physical memory using > cpu_physical_memory_read(). This effectively hard-codes > assuming that all CPUs have the same view of physical > memory. Switch to address_space_read() instead, which > lets us use the AddressSpace for the

Re: [Qemu-devel] [PATCH v5 06/36] ppc/xive: add support for the END Event State buffers

2018-11-22 Thread Cédric Le Goater
On 11/22/18 6:13 AM, David Gibson wrote: > On Fri, Nov 16, 2018 at 11:56:59AM +0100, Cédric Le Goater wrote: >> The Event Notification Descriptor also contains two Event State >> Buffers providing further coalescing of interrupts, one for the >> notification event (ESn) and one for the escalation

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2018-11-22 Thread BALATON Zoltan
On Thu, 22 Nov 2018, Thomas Huth wrote: 19 hw/display/sm501.c Maybe Balaton wants to adopt this file? As discussed before this was originally part of SH4 but since that seems to be not actively maintained any more and latest changes were for sam460ex I can add it to sam460ex. I

Re: [Qemu-devel] [PATCH v3 0/5] migration: improve multithreads

2018-11-22 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20181122072028.22819-1-xiaoguangr...@tencent.com Type: series Subject: [Qemu-devel] [PATCH v3 0/5] migration: improve multithreads === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH v5 05/36] ppc/xive: introduce the XIVE Event Notification Descriptors

2018-11-22 Thread Cédric Le Goater
On 11/22/18 5:41 AM, David Gibson wrote: > On Fri, Nov 16, 2018 at 11:56:58AM +0100, Cédric Le Goater wrote: >> To complete the event routing, the IVRE sub-engine uses an internal >> table containing Event Notification Descriptor (END) structures. >> >> An END specifies on which Event Queue (EQ)

Re: [Qemu-devel] [PATCH v3 0/5] migration: improve multithreads

2018-11-22 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Message-id: 20181122072028.22819-1-xiaoguangr...@tencent.com Type: series Subject: [Qemu-devel] [PATCH v3 0/5]

Re: [Qemu-devel] [PATCH 3/5] Add migration functions for VFIO devices

2018-11-22 Thread Kirti Wankhede
On 11/21/2018 1:09 PM, Zhao, Yan Y wrote: > > >> -Original Message- >> From: Qemu-devel [mailto:qemu-devel- >> bounces+yan.y.zhao=intel@nongnu.org] On Behalf Of Kirti Wankhede >> Sent: Wednesday, November 21, 2018 4:40 AM >> To: alex.william...@redhat.com; c...@nvidia.com >> Cc:

Re: [Qemu-devel] [PATCH 0/5] Add migration support for VFIO device

2018-11-22 Thread Kirti Wankhede
On 11/21/2018 11:17 AM, Peter Xu wrote: > On Wed, Nov 21, 2018 at 02:09:38AM +0530, Kirti Wankhede wrote: >> Add migration support for VFIO device > > Hi, Kirti, > > I failed to apply the series cleanly onto master. Could you push the > tree somewhere so that people might read the work

Re: [Qemu-devel] [PATCH 1/5] VFIO KABI for migration interface

2018-11-22 Thread Kirti Wankhede
On 11/23/2018 12:24 AM, Dr. David Alan Gilbert wrote: > * Kirti Wankhede (kwankh...@nvidia.com) wrote: >> - Defined MIGRATION region type and sub-type. >> - Defined VFIO device states during migration process. >> - Defined vfio_device_migration_info structure which will be placed at 0th >>

Re: [Qemu-devel] [PATCH v2 1/2] RFC: Acceptance tests: add the build directory to the system PATH

2018-11-22 Thread Wainer dos Santos Moschetta
On 11/21/2018 07:48 PM, Cleber Rosa wrote: So that when binaries such as qemu-img are searched for, those in the build tree will be favored. As a clarification, SRC_ROOT_DIR is dependent on the location from where tests are executed, so they are equal to the build directory if one is being

Re: [Qemu-devel] [PATCH 0/2] Update the inherits_from pointer after stream and commit

2018-11-22 Thread Alberto Garcia
On Thu 22 Nov 2018 06:52:00 PM CET, Kevin Wolf wrote: > Not a problem with the series, but I tried to run the test case without > the fix, and this is what I got: > > -{"return": ""} > +{"return": "Cannot change the option 'backing.detect-zeroes'rn"} > > Where does that final "rn" come from?

Re: [Qemu-devel] [PATCH 3/5] Add migration functions for VFIO devices

2018-11-22 Thread Dr. David Alan Gilbert
* Kirti Wankhede (kwankh...@nvidia.com) wrote: > - Migration function are implemented for VFIO_DEVICE_TYPE_PCI device. > - Added SaveVMHandlers and implemented all basic functions required for live > migration. > - Added VM state change handler to know running or stopped state of VM. > - Added

Re: [Qemu-devel] [PATCH 4/5] Add vfio_listerner_log_sync to mark dirty pages

2018-11-22 Thread Dr. David Alan Gilbert
* Kirti Wankhede (kwankh...@nvidia.com) wrote: > vfio_listerner_log_sync gets list of dirty pages from vendor driver and mark > those pages dirty. > > Signed-off-by: Kirti Wankhede > Reviewed-by: Neo Jia > --- > hw/vfio/common.c | 32 > 1 file changed, 32

Re: [Qemu-devel] [PATCH 1/5] VFIO KABI for migration interface

2018-11-22 Thread Kirti Wankhede
On 11/21/2018 11:43 AM, Tian, Kevin wrote: >> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] >> Sent: Wednesday, November 21, 2018 12:24 PM >> >> >> On 11/21/2018 5:56 AM, Tian, Kevin wrote: From: Kirti Wankhede [mailto:kwankh...@nvidia.com] Sent: Wednesday, November 21, 2018 4:40

Re: [Qemu-devel] [PATCH 1/5] VFIO KABI for migration interface

2018-11-22 Thread Dr. David Alan Gilbert
* Kirti Wankhede (kwankh...@nvidia.com) wrote: > - Defined MIGRATION region type and sub-type. > - Defined VFIO device states during migration process. > - Defined vfio_device_migration_info structure which will be placed at 0th > offset of migration region to get/set VFIO device related

[Qemu-devel] [PATCH 5/5] iotests: 030 with block-stream discard

2018-11-22 Thread Andrey Shinkevich
The classes that set tests for the block-stream command with discard option on are inherited from the existent classes in the 030 file. Some QMP commands do not have the optional 'discard' argument because the WRITE permission is not being granted when the filter is inserted. For instance, it is

[Qemu-devel] [PATCH 3/5] iotests: allow resume_drive by node name

2018-11-22 Thread Andrey Shinkevich
After node graph changes, we may not be able to resume_drive by device name (backing files are not recursively searched). So, lets allow to resume by node-name. Set constant name for breakpoints, to avoid introducing extra parameters. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

[Qemu-devel] [PATCH 1/5] Discard blocks while copy-on-read

2018-11-22 Thread Andrey Shinkevich
Discards the block duplicated in an intermediate backing file after the block have been copied into the active layer during QMP block-stream operation. It saves the disk space while merging external snapshots. Signed-off-by: Andrey Shinkevich --- block/stream.c | 428

[Qemu-devel] [PATCH 0/5] Discrad blocks during block-stream operation

2018-11-22 Thread Andrey Shinkevich
Hello everyone! The given feature discards blocks with copy-on-read operation while the streaming process runs. Adding the 'discard' argument to the QMP block-stream command allows dropping a block in the backing chain after it has been copied to the active layer. That will elude the block

[Qemu-devel] [PATCH 4/5] iotests: prepare 030 for graph change

2018-11-22 Thread Andrey Shinkevich
The discard option for block-stream command requires insertion of the filter to write into the backing chain. In that case, the job will not resume by device name. So, the node name is specified. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/030 | 20 1 file

[Qemu-devel] [PATCH 2/5] The discard flag for block stream operation

2018-11-22 Thread Andrey Shinkevich
Adding a parameter to QMP block-stream command to allow discarding blocks in the backing chain while blocks are being copied to the active layer. Signed-off-by: Andrey Shinkevich --- block/stream.c| 3 +-- blockdev.c| 8 +++- hmp-commands.hx | 4 ++--

Re: [Qemu-devel] [PATCH] nvme: fix CMB endianness confusion

2018-11-22 Thread Kevin Wolf
Am 22.11.2018 um 19:23 hat Paolo Bonzini geschrieben: > The CMB is marked as DEVICE_LITTLE_ENDIAN, so the data must be > read/written as if it was little-endian output (in the case of > big endian, we get two swaps, one in the memory core and one > in nvme.c). > > Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL v2 00/16] Block layer patches

2018-11-22 Thread Kevin Wolf
The following changes since commit 47c1cc30e440860aa695358f7c2dd0b9d7b53d16: Update version for v3.1.0-rc2 release (2018-11-20 18:10:26 +) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch changes up to

Re: [Qemu-devel] [PATCH-for-3.1] [REGRESSION FIX] ps2kbd: default to scan enabled after reset

2018-11-22 Thread Hervé Poussineau
Ping again. Le 18/11/2018 à 11:09, Hervé Poussineau a écrit : Ping again. v3.0 didn't contain 143c04c7e0639e53086519592ead15d2556bfbf2, so this commit fixes a regression. Le 10/11/2018 à 21:53, Hervé Poussineau a écrit : Ping. Le 21/10/2018 à 21:07, Hervé Poussineau a écrit : A check for

Re: [Qemu-devel] [PATCH] nvme: fix CMB endianness confusion

2018-11-22 Thread Peter Maydell
On 22 November 2018 at 18:23, Paolo Bonzini wrote: > The CMB is marked as DEVICE_LITTLE_ENDIAN, so the data must be > read/written as if it was little-endian output (in the case of > big endian, we get two swaps, one in the memory core and one > in nvme.c). > > Signed-off-by: Paolo Bonzini > ---

[Qemu-devel] [PATCH] nvme: fix CMB endianness confusion

2018-11-22 Thread Paolo Bonzini
The CMB is marked as DEVICE_LITTLE_ENDIAN, so the data must be read/written as if it was little-endian output (in the case of big endian, we get two swaps, one in the memory core and one in nvme.c). Signed-off-by: Paolo Bonzini --- hw/block/nvme.c | 7 ++- 1 file changed, 2 insertions(+), 5

Re: [Qemu-devel] [RFC PATCH v2 1/3] target/ppc: Add macro definitions for relocated interrupt vectors offsets

2018-11-22 Thread Fabiano Rosas
David Gibson writes: > On Wed, Nov 21, 2018 at 04:13:45PM -0200, Fabiano Rosas wrote: >> The PowerISA prescribes that depending on the values of MSR_IR, >> MSR_DR, MSR_HV and LPCR_AIL, the interrupt vectors might be relocated >> by specific offsets. >> >> This patch defines macros for these

[Qemu-devel] [PATCH for-3.1] MAINTAINERS: Add an ARM SMMU section

2018-11-22 Thread Eric Auger
Add a new ARM SMMU section and set Eric Auger as the maintainer for ARM SMMU emulation sources. Signed-off-by: Eric Auger Suggested-by: Peter Maydell --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1032406c56..3cac9f0a0c 100644 ---

Re: [Qemu-devel] [PATCH 0/2] Update the inherits_from pointer after stream and commit

2018-11-22 Thread Kevin Wolf
Am 31.10.2018 um 17:16 hat Alberto Garcia geschrieben: > Hi all, > > when you open an image [A] with a few more images on the backing chain > you get something like this: > > [E] <- [D] <- [C] <- [B] <- [A] > > Here you can go from [A] to [E] by following the bs->backing > pointer. At the

Re: [Qemu-devel] [PATCH v1 00/16] packed ring virtio-net backend support

2018-11-22 Thread Maxime Coquelin
Hi Wei, I just tested your series with Tiwei's v3, and it fails with ctrl vq enabled: qemu-system-x86_64: virtio-net ctrl missing headers Regards, Maxime On 11/22/18 3:06 PM, w...@redhat.com wrote: From: Wei Xu Code base: https://github.com/Whishay/qemu.git rfc v3 -> v1 - migration

[Qemu-devel] [PATCH v2 for-4.0 1/3] disas.c: Use address_space_read() to read memory

2018-11-22 Thread Peter Maydell
Currently disas.c reads physical memory using cpu_physical_memory_read(). This effectively hard-codes assuming that all CPUs have the same view of physical memory. Switch to address_space_read() instead, which lets us use the AddressSpace for the CPU we're disassembling for. Signed-off-by: Peter

[Qemu-devel] [RFC v9 10/17] virtio-iommu: Implement probe request

2018-11-22 Thread Eric Auger
This patch implements the PROBE request. At the moment, no reserved regions are returned as none are registered per device. Only a NONE property is returned. Signed-off-by: Eric Auger --- v8 -> v9: - fix filling of properties (changes induced by v0.7 -> v0.8 spec evolution) v7 -> v8: - adapt

[Qemu-devel] [RFC v9 06/17] virtio-iommu: Endpoint and domains structs and helpers

2018-11-22 Thread Eric Auger
This patch introduce domain and endpoint internal datatypes. Both are stored in RB trees. The domain owns a list of endpoints attached to it. Helpers to get/put end points and domains are introduced. get() helpers will become static in subsequent patches. Signed-off-by: Eric Auger --- v6 ->

[Qemu-devel] [RFC v9 03/17] virtio-iommu: Add skeleton

2018-11-22 Thread Eric Auger
This patchs adds the skeleton for the virtio-iommu device. Signed-off-by: Eric Auger --- v8 -> v9: - properly initialize tail v7 -> v8: - expose VIRTIO_IOMMU_F_BYPASS and VIRTIO_F_VERSION_1 features - set_config dummy implementation + tracing - add trace in get_features - set the features on

[Qemu-devel] [PATCH v2 for-4.0 3/3] elf_ops.h: Use address_space_write() to write memory

2018-11-22 Thread Peter Maydell
Currently the load_elf function in elf_ops.h uses cpu_physical_memory_write() to write the ELF file to memory if it is not handling it as a ROM blob. This means we ignore the AddressSpace that the function is passed to define where it should be loaded. Use address_space_write() instead.

[Qemu-devel] [RFC v9 02/17] linux-headers: Partial update for virtio-iommu v0.8

2018-11-22 Thread Eric Auger
Partial sync against Jean-Philippe's branch: git://linux-arm.org/linux-jpb.git virtio-iommu/v0.8 Signed-off-by: Eric Auger --- include/standard-headers/linux/virtio_ids.h | 1 + include/standard-headers/linux/virtio_iommu.h | 159 ++ linux-headers/linux/virtio_iommu.h

[Qemu-devel] [RFC v9 14/17] virtio-iommu-pci: Add virtio iommu pci support

2018-11-22 Thread Eric Auger
This patch adds virtio-iommu-pci, which is the pci proxy for the virtio-iommu device. Signed-off-by: Eric Auger --- v8 -> v9: - add the msi-bypass property --- hw/virtio/virtio-pci.c | 51 ++ hw/virtio/virtio-pci.h | 14

[Qemu-devel] [RFC v9 01/17] update-linux-headers: Import virtio_iommu.h

2018-11-22 Thread Eric Auger
Update the script to update the virtio_iommu.h header. Signed-off-by: Eric Auger --- scripts/update-linux-headers.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh index 0a964fe240..55fd271a32 100755 ---

[Qemu-devel] [RFC v9 15/17] hw/arm/virt: Add the virtio-iommu device tree mappings

2018-11-22 Thread Eric Auger
Adds the "virtio,pci-iommu" node in the host bridge node and the RID mapping, excluding the IOMMU RID. Signed-off-by: Eric Auger --- v8 -> v9: - disable msi-bypass property - addition of the subnode is handled is the hotplug handler and IOMMU RID is notimposed anymore v6 -> v7: - align to

Re: [Qemu-devel] [PULL 00/13] Block layer patches

2018-11-22 Thread Peter Maydell
On 22 November 2018 at 16:54, Kevin Wolf wrote: > The following changes since commit 47c1cc30e440860aa695358f7c2dd0b9d7b53d16: > > Update version for v3.1.0-rc2 release (2018-11-20 18:10:26 +) > > are available in the Git repository at: > > git://repo.or.cz/qemu/kevin.git

[Qemu-devel] [RFC v9 04/17] virtio-iommu: Decode the command payload

2018-11-22 Thread Eric Auger
This patch adds the command payload decoding and introduces the functions that will do the actual command handling. Those functions are not yet implemented. Signed-off-by: Eric Auger --- v7 -> v8: - handle new domain parameter in detach - remove reserved checks v5 -> v6: - change map/unmap

[Qemu-devel] [RFC v9 11/17] virtio-iommu: Expose the IOAPIC MSI reserved region when relevant

2018-11-22 Thread Eric Auger
We introduce a new msi_bypass field which indicates whether the IOAPIC MSI window [0xFEE0 - 0xFEEF] must be exposed as a reserved region. By default the field is set to true at instantiation time. Later on we will introduce a property at virtio pci proxy level to turn it off.

[Qemu-devel] [PATCH v2 for-4.0 2/3] monitor: Use address_space_read() to read memory

2018-11-22 Thread Peter Maydell
Currently monitor.c reads physical memory using cpu_physical_memory_read(). This effectively hard-codes assuming that all CPUs have the same view of physical memory. Switch to address_space_read() instead, which lets us use the AddressSpace for the CPU we're reading memory for (falling back to

[Qemu-devel] [RFC v9 16/17] hw/arm/virt-acpi-build: Introduce fill_iort_idmap helper

2018-11-22 Thread Eric Auger
To avoid code duplication, let's introduce an helper that fills one IORT ID mappings array index. Signed-off-by: Eric Auger --- v8: new --- hw/arm/virt-acpi-build.c | 43 1 file changed, 26 insertions(+), 17 deletions(-) diff --git

Re: [Qemu-devel] [RFC 11/48] atomic_template: fix indentation in GEN_ATOMIC_HELPER

2018-11-22 Thread Alex Bennée
Emilio G. Cota writes: > Signed-off-by: Emilio G. Cota Reviewed-by: Alex Bennée > --- > accel/tcg/atomic_template.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/accel/tcg/atomic_template.h b/accel/tcg/atomic_template.h > index efde12fdb2..8d177fefef 100644 >

[Qemu-devel] [PATCH v2 for-4.0 0/3] Avoid cpu_physical_memory_read() in generic code

2018-11-22 Thread Peter Maydell
This patchset takes three places in generic code which use cpu_physical_memory_read(), and changes them to use address_space_read() instead. Changes v1->v2: * patches 1, 2 unchanged (and reviewed) * patch 3: handle as being NULL (which for the load_elf APIs means "use address_space_memory")

[Qemu-devel] [RFC v9 13/17] virtio_iommu: Handle reserved regions in translation process

2018-11-22 Thread Eric Auger
When translating an address we need to check if it belongs to a reserved virtual address range. If it does, there are 2 cases: - it belongs to a RESERVED region: the guest should neither use this address in a MAP not instruct the end-point to DMA on them. We report an error - It belongs to

[Qemu-devel] [RFC v9 09/17] virtio-iommu: Implement translate

2018-11-22 Thread Eric Auger
This patch implements the translate callback Signed-off-by: Eric Auger --- v6 -> v7: - implemented bypass-mode v5 -> v6: - replace error_report by qemu_log_mask v4 -> v5: - check the device domain is not NULL - s/printf/error_report - set flags to IOMMU_NONE in case of all translation faults

Re: [Qemu-devel] [RFC 10/48] exec: export do_tb_flush

2018-11-22 Thread Alex Bennée
Emilio G. Cota writes: > This will be used by plugin code to flush the code cache as well > as doing other bookkeeping in a safe work environment. This seems a little excessive given the plugin code could just call tb_flush() directly. Wouldn't calling tb_flush after scheduling the

[Qemu-devel] [RFC v9 07/17] virtio-iommu: Implement attach/detach command

2018-11-22 Thread Eric Auger
This patch implements the endpoint attach/detach to/from a domain. Signed-off-by: Eric Auger --- --- hw/virtio/virtio-iommu.c | 40 ++-- 1 file changed, 34 insertions(+), 6 deletions(-) diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c index

[Qemu-devel] [RFC v9 08/17] virtio-iommu: Implement map/unmap

2018-11-22 Thread Eric Auger
This patch implements virtio_iommu_map/unmap. Signed-off-by: Eric Auger --- v5 -> v6: - use new v0.6 fields - replace error_report by qemu_log_mask v3 -> v4: - implement unmap semantics as specified in v0.4 --- hw/virtio/trace-events | 3 ++ hw/virtio/virtio-iommu.c | 94

[Qemu-devel] [RFC v9 17/17] hw/arm/virt-acpi-build: Add virtio-iommu node in IORT table

2018-11-22 Thread Eric Auger
This patch builds the virtio-iommu node in the ACPI IORT table. The RID space of the root complex, which spans 0x0-0x1 maps to streamid space 0x0-0x1 in the virtio-iommu which in turn maps to deviceid space 0x0-0x1 in the ITS group. The iommu RID is excluded as described in

[Qemu-devel] [RFC v9 05/17] virtio-iommu: Add the iommu regions

2018-11-22 Thread Eric Auger
This patch initializes the iommu memory regions so that PCIe end point transactions get translated. The translation function is not yet implemented though. Signed-off-by: Eric Auger --- v6 -> v7: - use primary_bus - rebase on new translate proto featuring iommu_idx v5 -> v6: - include

[Qemu-devel] [PATCH 2/2] vfio-ccw: support async command subregion

2018-11-22 Thread Cornelia Huck
A vfio-ccw device may provide an async command subregion for issuing halt/clear subchannel requests. If it is present, use it for sending halt/clear request to the device; if not, fall back to emulation (as done today). Signed-off-by: Cornelia Huck --- hw/s390x/css.c | 27

[Qemu-devel] [RFC v9 00/17] VIRTIO-IOMMU device

2018-11-22 Thread Eric Auger
This series rebases the virtio-iommu device on qemu 3.1.0-rc2 and implements the v0.8(.1) virtio-iommu spec [1]. The pci proxy for the virtio-iommu device is now available and needs to be instantiated from the command line using "-device virtio-iommu-pci". The iommu machvirt option is not used

[Qemu-devel] [RFC v9 12/17] virtio-iommu: Implement fault reporting

2018-11-22 Thread Eric Auger
The event queue allows to report asynchronous errors. The translate function now injects faults when relevant. Signed-off-by: Eric Auger --- hw/virtio/trace-events | 1 + hw/virtio/virtio-iommu.c | 67 ++-- 2 files changed, 65 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH 1/2] vfio-ccw: new capability chain support

2018-11-22 Thread Cornelia Huck
To be replaced with a real linux-headers update. Signed-off-by: Cornelia Huck --- linux-headers/linux/vfio.h | 4 linux-headers/linux/vfio_ccw.h | 12 2 files changed, 16 insertions(+) diff --git a/linux-headers/linux/vfio.h b/linux-headers/linux/vfio.h index

Re: [Qemu-devel] [PATCH] nvme: fix out-of-bounds access to the CMB

2018-11-22 Thread Peter Maydell
On 20 November 2018 at 18:41, Paolo Bonzini wrote: > Because the CMB BAR has a min_access_size of 2, if you read the last > byte it will try to memcpy *2* bytes from n->cmbuf, causing an off-by-one > error. This is CVE-2018-16847. Maybe we should change the MemoryRegionOps API so that devices

Re: [Qemu-devel] [RFC 13/48] xxhash: add qemu_xxhash8

2018-11-22 Thread Alex Bennée
Emilio G. Cota writes: > It will be used for TB hashing soon. > > Signed-off-by: Emilio G. Cota > --- > include/qemu/xxhash.h | 40 +++- > 1 file changed, 27 insertions(+), 13 deletions(-) > > diff --git a/include/qemu/xxhash.h b/include/qemu/xxhash.h >

[Qemu-devel] [PATCH 0/2] vfio-ccw: support hsch/csch (QEMU part)

2018-11-22 Thread Cornelia Huck
[This is the QEMU part, git tree is available at https://github.com/cohuck/qemu vfio-ccw-caps The companion Linux kernel patches are available at https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/vfio-ccw.git vfio-ccw-caps] Currently, vfio-ccw only relays START SUBCHANNEL requests to the

[Qemu-devel] [PATCH for-4.0] ui/console: Remove qemu_create_display_surface_guestmem()

2018-11-22 Thread Peter Maydell
The qemu_create_display_surface_guestmem() function was added in commit a77549b3ffcc24c32ee4e but apparently never used. Remove it. (The API of this function is in any case awkward as a generic function: it assumes that a physical address uniquely identifies a piece of memory in the system, which

  1   2   3   >