From: Marc-André Lureau
Use the glib function for the work, fix a potential crash on >256 words.
Signed-off-by: Marc-André Lureau
Signed-off-by: Samuel Thibault
---
slirp/misc.c | 21 +++--
1 file changed, 3 insertions(+), 18 deletions(-)
diff --git a/slirp/misc.c
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Samuel Thibault
---
slirp/slirp_config.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/slirp/slirp_config.h b/slirp/slirp_config.h
index 47811e36dc..e95284071a 100644
---
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Samuel Thibault
---
slirp/slirp.h| 2 +-
slirp/slirp_config.h | 6 --
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/slirp/slirp.h b/slirp/slirp.h
index
From: Marc-André Lureau
Use a global variable instead (similar to slirp_debug)
Signed-off-by: Marc-André Lureau
Signed-off-by: Samuel Thibault
---
slirp/slirp.c| 3 +++
slirp/slirp.h| 6 +++---
slirp/slirp_config.h | 12
slirp/tcp_input.c| 2 +-
From: Marc-André Lureau
Looking at git history, this looks like something from the past, when
there was a tty layer. Let's remove it.
Signed-off-by: Marc-André Lureau
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Samuel Thibault
---
slirp/if.c | 2 --
slirp/slirp_config.h | 7
From: Marc-André Lureau
The soread() function may be used on datagram sockets, and would
provide different behaviour if HAVE_READV was set, on empty datagrams.
This looks like a minor optimization, that never has been a strong
goal for slirp.
Signed-off-by: Marc-André Lureau
Reviewed-by:
From: Marc-André Lureau
Let them accept multiple arguments. Simplify the inner argument
handling of DEBUG_ARGS/DEBUG_MISC_DEBUG_ERROR.
Signed-off-by: Marc-André Lureau
Signed-off-by: Samuel Thibault
---
slirp/arp_table.c | 12 ++--
slirp/bootp.c | 3 +--
slirp/cksum.c |
From: Marc-André Lureau
One more step towards making the project independent from QEMU.
Signed-off-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Samuel Thibault
---
slirp/ip.h | 8 +---
slirp/ip6.h | 3 ++-
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Samuel Thibault
---
slirp/mbuf.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/slirp/mbuf.h b/slirp/mbuf.h
index bfdf8c4577..cbf17e136b 100644
--- a/slirp/mbuf.h
+++ b/slirp/mbuf.h
@@
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Samuel Thibault
---
slirp/slirp_config.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/slirp/slirp_config.h b/slirp/slirp_config.h
index 833f25a965..5126711849 100644
---
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Samuel Thibault
---
slirp/slirp.h| 4
slirp/slirp_config.h | 3 ---
2 files changed, 7 deletions(-)
diff --git a/slirp/slirp.h b/slirp/slirp.h
index 4c3c672ee6..57955a8965
The following changes since commit e85c577158a2e8e252414959da9ef15c12eec63d:
Merge remote-tracking branch
'remotes/huth-gitlab/tags/pull-request-2018-12-17' into staging (2018-12-18
14:31:06 +)
are available in the Git repository at:
https://people.debian.org/~sthibault/qemu.git
From: Marc-André Lureau
An overdue cleanup. Remaining declarations could probably be moved in
other headers, such as slirp.h.
Signed-off-by: Marc-André Lureau
Signed-off-by: Samuel Thibault
---
slirp/main.h | 29 -
1 file changed, 29 deletions(-)
diff --git
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Samuel Thibault
---
slirp/slirp.h| 3 ---
slirp/slirp_config.h | 3 ---
2 files changed, 6 deletions(-)
diff --git a/slirp/slirp.h b/slirp/slirp.h
index f7c087456a..4c3c672ee6
From: Marc-André Lureau
Originally, the patch was fixing a bunch of issues, but Peter beat me
to it with earlier commit "slirp: fork_exec(): create and connect
child socket before fork()".
Factor out socket pair creation, to simplify the fork_exec() code.
Use the name socketpair_with_oob()
From: Marc-André Lureau
Clarify that those functions are internal to slirp.
Signed-off-by: Marc-André Lureau
Signed-off-by: Samuel Thibault
---
slirp/libslirp.h | 3 ---
slirp/slirp.h| 3 +++
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/slirp/libslirp.h
From: Marc-André Lureau
Now it's only used for the chardev pointer.
Signed-off-by: Marc-André Lureau
Signed-off-by: Samuel Thibault
---
slirp/slirp.c| 4 ++--
slirp/socket.h | 2 +-
slirp/tcp_subr.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/slirp/slirp.c
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Samuel Thibault
---
slirp/slirp.h| 4
slirp/slirp_config.h | 3 ---
2 files changed, 7 deletions(-)
diff --git a/slirp/slirp.h b/slirp/slirp.h
index 400f585cec..1f47848271
From: Gerd Hoffmann
Useful when debugging pxeboot, to see what the guest tries to do.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Liam Merwick
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Signed-off-by: Samuel Thibault
---
Makefile.objs | 1 +
slirp/tftp.c
From: Marc-André Lureau
Free the list elements allocated in add_exec().
Signed-off-by: Marc-André Lureau
Signed-off-by: Samuel Thibault
---
slirp/misc.h | 2 +-
slirp/slirp.c | 8
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/slirp/misc.h b/slirp/misc.h
index
From: Marc-André Lureau
Let's make the slirp interface a bit more library-like.
Associate the slirp_output() with a Slirp context.
Signed-off-by: Marc-André Lureau
Signed-off-by: Samuel Thibault
---
net/slirp.c | 5 +++--
slirp/libslirp.h | 9 +
slirp/ncsi.c | 2 +-
From: Marc-André Lureau
Let's not mix command line and chardev pointers.
Signed-off-by: Marc-André Lureau
Signed-off-by: Samuel Thibault
---
net/slirp.c | 8
slirp/libslirp.h | 2 +-
slirp/misc.c | 11 +++
slirp/misc.h | 4 ++--
slirp/slirp.c| 5 +++--
From: Marc-André Lureau
do_pty == 3 means to talk to a chardev.
Signed-off-by: Marc-André Lureau
Signed-off-by: Samuel Thibault
---
slirp/misc.c | 2 +-
slirp/misc.h | 2 +-
slirp/slirp.c| 4 ++--
slirp/tcp_subr.c | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff
From: Marc-André Lureau
EMU_RSH handling was dropped in commit
0d62c4cfe21752df4c1d6e2c2398f15d5eaa794a.
The assignment, and subsequent free() of ex_ptr->ex_exec to so->extra
looks unsafe (double free is likely to occur).
Signed-off-by: Marc-André Lureau
Signed-off-by: Samuel Thibault
---
From: Marc-André Lureau
QEMU uses fork_exec() with do_pty values 0 or 3.
Let's clean up some unused code.
Signed-off-by: Marc-André Lureau
Signed-off-by: Samuel Thibault
---
slirp/misc.c | 55 ++--
slirp/misc.h | 2 +-
slirp/tcp_subr.c |
From: Vladimir Sementsov-Ogievskiy
Reduce extra noise of nbd-client, change 083 correspondingly.
In various commits (be41c100 in 2.10, f140e300 in 2.11, 78a33ab
in 2.12), we added spots where qemu as an NBD client would report
problems communicating with the server to stderr, because there
was
Not all servers send free-form text alongside option error replies, but
for servers that do (such as qemu), we pass the server's message as a
hint alongside our own error reporting. However, it would also be
useful to trace such server messages, since we can't guarantee how the
hint may be
This is a counter-proposal to Vladimir's initial post for
reducing the noise in iotest 083. The difference is that
I dropped error_get_hint, since I couldn't find any useful
hint to be traced during transmission phase in the first place,
and instead added a trace message for the one place where
From: Vladimir Sementsov-Ogievskiy
These functions are used for formatting pretty trace points. We are
going to add some in block/nbd-client, so, let's publish all these
functions at once. Note, that nbd_reply_type_lookup is already
published, and constants, "named" by these functions live in
On Tue, 18 Dec 2018, Ben Hekster via Qemu-devel wrote:
I had the exact same issue; for me it was just the addition of Günther's
"rootwait" option that resolved it, so:
$ qemu-system-arm \
-m 256m \
-M raspi2 \
-cpu cortex-a7 \
-append "console=ttyAMA0,115200
On 12/18/18 3:23 PM, Eric Blake wrote:
On 11/2/18 10:11 AM, Vladimir Sementsov-Ogievskiy wrote:
Reduce extra noise of nbd-client, change 083 correspondingly.
This says what, but not why. The details from the cover letter are
important to include here, namely:
It was discussed, that error
Hi, Zoltan—
> On Thu, 29 Nov 2018, Guenter Roeck wrote:
> On 11/29/18 6:42 PM, BALATON Zoltan wrote:
> On Thu, 29 Nov 2018, Guenter Roeck wrote:
> On 11/29/18 4:43 PM, Philippe Mathieu-Daudé wrote:
> Hi Zoltan,
>
> On 29/11/18 21:29, BALATON Zoltan wrote:
> Hello,
>
> I could not boot Raspbian
The XIVE internal structures (EAS, END, NVT) are architected to be Big
Endian. The XIVE models, today, access the different fields of these
structures using wrappers around the GETFIELD/SETFIELD macros. The
definitions of these macros depend on the host which seems unnecessary
for guest only
On 12/18/18 11:51 AM, Philippe Mathieu-Daudé wrote:
> GCC 8 added a -Wstringop-truncation warning:
>
>The -Wstringop-truncation warning added in GCC 8.0 via r254630 for
>bug 81117 is specifically intended to highlight likely unintended
>uses of the strncpy function that truncate the
On 18/12/18 20:33, Eric Blake wrote:
>> diff --git a/migration/global_state.c b/migration/global_state.c
>> index 6e19333422..c19030ef62 100644
>> --- a/migration/global_state.c
>> +++ b/migration/global_state.c
>> @@ -106,7 +106,7 @@ static int global_state_pre_save(void *opaque)
>>
On 11/2/18 10:11 AM, Vladimir Sementsov-Ogievskiy wrote:
Reduce extra noise of nbd-client, change 083 correspondingly.
This says what, but not why. The details from the cover letter are
important to include here, namely:
It was discussed, that error messages, produced by error_reprt_err's,
On 18/12/18 20:13, Eduardo Habkost wrote:
> On Tue, Dec 18, 2018 at 06:15:06PM +0100, Paolo Bonzini wrote:
>> On 18/12/18 16:57, Eduardo Habkost wrote:
>>> On Tue, Dec 18, 2018 at 04:44:25PM +0100, Thomas Huth wrote:
On 2018-12-18 16:31, Philippe Mathieu-Daudé wrote:
> Hi Paolo, Eduardo,
On 11/2/18 10:11 AM, Vladimir Sementsov-Ogievskiy wrote:
These functions are used for formatting pretty trace points. We are
going to add some in block/nbd-client, so, let's publish all these
functions at once. Note, that nbd_reply_type_lookup is already
published, and constants, "named" by
On 11/2/18 10:11 AM, Vladimir Sementsov-Ogievskiy wrote:
Add a function to export error hint - a pair to error_get_pretty. It's
needed to handle errors by hand, where we can't just report it or
propagate.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/qapi/error.h | 5 +
Hi
On Tue, Dec 18, 2018 at 10:26 PM Markus Armbruster wrote:
>
> Marc-André posted v1 that relies on a QAPI schema language extension
> 'top-unit' to permit splitting the generated code. Here is his cover
> letter:
>
> The thrid and last part (of "[PATCH v2 00/54] qapi: add #if
>
Am Mon, 17 Dec 2018 12:48:31 +0100 (CET)
schrieb BALATON Zoltan :
> On Sun, 16 Dec 2018, Thomas Huth wrote:
> > The sun4u/sun4v machine currently always creates a VGA device, even
> > if the user started QEMU with "-nodefaults" or "-vga none". That's
> > likely not what the users expect in this
On 11/15/18 3:17 PM, Eric Blake wrote:
Prompted by my review of xiezhide's work. No semantic change, but
not technically a bug fix, so I don't care if it goes in 3.1 or
waits for 4.0.
Eric Blake (2):
typedefs: (Re-)sort entries alphabetically
numa: Match struct to typedef name
Ping.
On 12/18/18 12:22 PM, Markus Armbruster wrote:
The qapi_event_send_FOO() functions emit events like this:
QMPEventFuncEmit emit;
emit = qmp_event_get_func_emit();
if (!emit) {
return;
}
emit(QAPI_EVENT_FOO, qmp);
More seriously: how does this work even
On 12/18/18 7:29 PM, Eric Blake wrote:
> On 12/18/18 11:51 AM, Philippe Mathieu-Daudé wrote:
>> GCC 8 introduced the -Wstringop-truncation checker to detect
>> truncation by
>> the strncat and strncpy functions (closely related to
>> -Wstringop-overflow,
>> which detect buffer overflow by
Hi
On Tue, Dec 18, 2018 at 10:27 PM Markus Armbruster wrote:
>
> This reverts commit 7bd263490590ee6fcf34ecb6203437e22f6e5a9c.
>
> The commit applied the events' conditions to the members of enum
> QAPIEvent. Awkward, because it renders QAPIEvent unusable in
> target-independent code as soon as
On Tue, Dec 18, 2018 at 10:27 PM Markus Armbruster wrote:
>
> The qapi_event_send_FOO() functions emit events like this:
>
> QMPEventFuncEmit emit;
>
> emit = qmp_event_get_func_emit();
> if (!emit) {
> return;
> }
>
> qmp = qmp_event_build_dict("FOO");
> [put
Hi
On Tue, Dec 18, 2018 at 10:30 PM Markus Armbruster wrote:
>
> query-events doesn't reflect compile-time configuration. Instead of
> fixing that, deprecate the command in favor of query-qmp-schema.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
> ---
> monitor.c
On 12/18/18 11:51 AM, Philippe Mathieu-Daudé wrote:
> GCC 8 added a -Wstringop-truncation warning:
>
>The -Wstringop-truncation warning added in GCC 8.0 via r254630 for
>bug 81117 is specifically intended to highlight likely unintended
>uses of the strncpy function that truncate the
On 12/18/18 11:51 AM, Philippe Mathieu-Daudé wrote:
> GCC 8 introduced the -Wstringop-overflow, which detect buffer overflow
> by string-modifying functions declared in , such strncpy(),
> used in global_state_store_running().
>
> Since the global_state.runstate does not necessarily contains a
>
On Tue, 18 Dec 2018, Daniel P. Berrangé wrote:
I don't see any difference depending on whether I use Ctrl-Alt-3 before
or after the yellow screen - both work as expected. The fact that you
see a difference though does suggest that there's something odd being
done in the ppc emulation that is in
On Tue, Dec 18, 2018 at 10:22 PM Markus Armbruster wrote:
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
> ---
> docs/devel/qapi-code-gen.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/devel/qapi-code-gen.txt
On Tue, Dec 18, 2018 at 06:15:06PM +0100, Paolo Bonzini wrote:
> On 18/12/18 16:57, Eduardo Habkost wrote:
> > On Tue, Dec 18, 2018 at 04:44:25PM +0100, Thomas Huth wrote:
> >> On 2018-12-18 16:31, Philippe Mathieu-Daudé wrote:
> >>> Hi Paolo, Eduardo,
> >>>
> >>> On 12/18/18 4:22 PM, Eduardo
On Thu, Feb 22, 2018 at 08:05:13AM +0100, Gerd Hoffmann wrote:
> Pass the modifier state to the keymap lookup function. In case multiple
> keysym -> keycode mappings exist look at the modifier state and prefer
> the mapping where the modifier state matches.
>
> Signed-off-by: Gerd Hoffmann
>
Indeed the bug does not exist in this exact form any more, but it seems
the stray '86' keymap entry *does* still cause problems in current qemu
in one specific case:
https://bugzilla.redhat.com/show_bug.cgi?id=1658676
basically, if using 'usb-kbd', we still get trouble when openQA (os-
autoinst)
Hi
On Tue, Dec 11, 2018 at 10:56 PM Michael S. Tsirkin wrote:
>
> On Tue, Dec 11, 2018 at 09:29:44AM +, Daniel P. Berrangé wrote:
> > On Tue, Dec 11, 2018 at 08:42:41AM +0100, Hoffmann, Gerd wrote:
> > > Hi,
> > >
> > > > Right. The main issue is that we need to make sure only
> > > >
Thomas Huth writes:
> The last user of blk_attach_dev_legacy() is the code in xen_disk.c.
> It passes a pointer to a XenBlkDev as second parameter. XenBlkDev
> is derived from XenDevice which in turn is derived from DeviceState
> since commit 3a6c9172ac5951e ("xen: create qdev for each backend
On 12/18/18 11:51 AM, Philippe Mathieu-Daudé wrote:
> GCC 8 added a -Wstringop-truncation warning:
>
>The -Wstringop-truncation warning added in GCC 8.0 via r254630 for
>bug 81117 is specifically intended to highlight likely unintended
>uses of the strncpy function that truncate the
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Acked-by: Cornelia Huck
---
hw/s390x/s390-skeys.c | 2 +-
include/sysemu/arch_init.h | 7 --
monitor.c | 14 ---
qapi/misc.json | 137
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
monitor.c| 11 ---
qapi/misc.json | 43 --
qapi/target.json | 45
target/arm/monitor.c | 2 +-
4 files changed, 46
On 12/18/18 11:51 AM, Philippe Mathieu-Daudé wrote:
GCC 8 introduced the -Wstringop-truncation checker to detect truncation by
the strncat and strncpy functions (closely related to -Wstringop-overflow,
which detect buffer overflow by string-modifying functions declared in
).
This paragraph
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Acked-by: Cornelia Huck
---
qapi/target.json | 6 ++
1 file changed, 6 insertions(+)
diff --git a/qapi/target.json b/qapi/target.json
index 17671d77c1..010df35ebb 100644
--- a/qapi/target.json
+++ b/qapi/target.json
@@ -275,6
From: Marc-André Lureau
It depends on TARGET_PPC || TARGET_ARM || TARGET_I386 || TARGET_S390X.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eduardo Habkost
Acked-by: Cornelia Huck
---
include/sysemu/arch_init.h | 1 -
monitor.c | 22
qapi/misc.json
query-events doesn't reflect compile-time configuration. Instead of
fixing that, deprecate the command in favor of query-qmp-schema.
Signed-off-by: Markus Armbruster
---
monitor.c| 5 +
qapi/misc.json | 7 +--
qemu-deprecated.texi | 5 +
3 files changed, 15
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Eduardo Habkost
Acked-by: Cornelia Huck
---
include/sysemu/arch_init.h | 3 --
monitor.c | 3 --
qapi/misc.json | 51 -
From: Marc-André Lureau
This command is no longer needed, the schema has compile-time
configuration conditions.
Signed-off-by: Marc-André Lureau
---
include/qapi/qmp/dispatch.h | 1 -
qapi/qmp-registry.c | 8
2 files changed, 9 deletions(-)
diff --git
From: Marc-André Lureau
Move rtc-reset-reinjection and SEV in target.json and make them
conditional on TARGET_I386.
Signed-off-by: Marc-André Lureau
---
hw/timer/mc146818rtc.c | 2 +-
monitor.c | 31
qapi/misc.json | 166 --
This reverts commit 7bd263490590ee6fcf34ecb6203437e22f6e5a9c.
The commit applied the events' conditions to the members of enum
QAPIEvent. Awkward, because it renders QAPIEvent unusable in
target-independent code as soon as we make an event target-dependent.
Reverting this has the following
The qapi_event_send_FOO() functions emit events like this:
QMPEventFuncEmit emit;
emit = qmp_event_get_func_emit();
if (!emit) {
return;
}
qmp = qmp_event_build_dict("FOO");
[put event arguments into @qmp...]
emit(QAPI_EVENT_FOO, qmp);
The value of
We can't add appropriate target-specific conditionals to misc.json,
because that would make all of misc.json unusable in
target-independent code. To keep misc.json target-independent, we
need to split off target-dependent target.json.
This commit doesn't actually split off anything, it merely
Marc-André posted v1 that relies on a QAPI schema language extension
'top-unit' to permit splitting the generated code. Here is his cover
letter:
The thrid and last part (of "[PATCH v2 00/54] qapi: add #if
pre-processor conditions to generated code") is about adding schema
conditions
From: Marc-André Lureau
The following patches are going to introduce per-target #ifdef in the
schemas.
The introspection data is statically generated once, and must thus be
built per-target to reflect target-specific configuration.
Drop "do_test_visitor_in_qmp_introspect(_schema_qlit)" since
From: Marc-André Lureau
A few targets don't emit RTC_CHANGE, we could restrict the event to
the tagets that do emit it.
Note: There is a lot more of events & commands that we could restrict
to capable targets, with the cost of some additional complexity, but
the benefit of added correctness and
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt
index 43bd853e69..418a607842 100644
--- a/docs/devel/qapi-code-gen.txt
+++
Having to include qapi-events.h just for QAPIEvent is suboptimal, but
quite tolerable. It'll become problematic when we have events
conditional on the target, because then qapi-events.h won't be usable
from target-independent code anymore. Avoid that by generating it
into separate files.
This
I think, this bug also can be triggered in qcow2. Unfortunately it is
not so easy for me to find roots of the bug.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1806196
Title:
qed leaked clusters
Marc-André Lureau writes:
> Hi,
>
> The thrid and last part (of "[PATCH v2 00/54] qapi: add #if
> pre-processor conditions to generated code") is about adding schema
> conditions based on the target.
>
> For now, the qapi code is compiled in common objects (common to all
> targets). This makes
Marc-André Lureau writes:
> It depends on TARGET_PPC || TARGET_ARM || TARGET_I386 || TARGET_S390X.
>
> Signed-off-by: Marc-André Lureau
> Reviewed-by: Eduardo Habkost
> Acked-by: Cornelia Huck
[...]
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 18579bc5e8..dc0a7413a4 100644
>
On 12/18/18 5:43 PM, Richard Henderson wrote:
> Use "register" TBFLAG_ANY to indicate shared state between
> A32 and A64, and "registers" TBFLAG_A32 & TBFLAG_A64 for
> fields that are specific to the given cpu state.
>
> Move ARM_TBFLAG_BE to shared state, instead of its current
> placement
Hi
On Tue, Dec 18, 2018 at 6:20 PM Michael S. Tsirkin wrote:
>
> On Tue, Dec 18, 2018 at 01:28:53PM +0400, Marc-André Lureau wrote:
> > Hi Michael,
> >
> > On Tue, Dec 18, 2018 at 5:42 AM Michael S. Tsirkin wrote:
> > >
> > > On Thu, Dec 13, 2018 at 02:26:42AM +0400, Marc-André Lureau wrote:
>
Marc-André Lureau writes:
> Signed-off-by: Marc-André Lureau
> Acked-by: Cornelia Huck
> ---
[...]
> diff --git a/qapi/target.json b/qapi/target.json
> index f277b69a2a..d751e1623a 100644
> --- a/qapi/target.json
> +++ b/qapi/target.json
> @@ -7,6 +7,8 @@
>
> { 'pragma': { 'top-unit':
On 12/18/18 6:51 PM, Philippe Mathieu-Daudé wrote:
> GCC 8 new warning prevents builds to success since quite some time.
> First report on the mailing list is in July 2018:
> https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03723.html
>
> Various intents has been sent to fix this:
> -
On 12/18/2018 12:24 PM, Cornelia Huck wrote:
On Mon, 17 Dec 2018 16:53:34 -0500
Eric Farman wrote:
On 11/22/2018 11:54 AM, Cornelia Huck wrote:
...snip...
diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h
index 813102810f53..565669f95534 100644
---
GCC 8 added a -Wstringop-truncation warning:
The -Wstringop-truncation warning added in GCC 8.0 via r254630 for
bug 81117 is specifically intended to highlight likely unintended
uses of the strncpy function that truncate the terminating NUL
character from the source string.
This new
GCC 8 introduced the -Wstringop-overflow, which detect buffer overflow
by string-modifying functions declared in , such strncpy(),
used in global_state_store_running().
Since the global_state.runstate does not necessarily contains a
terminating NUL character, We had to use the QEMU_NONSTRING
GCC 8 added a -Wstringop-truncation warning:
The -Wstringop-truncation warning added in GCC 8.0 via r254630 for
bug 81117 is specifically intended to highlight likely unintended
uses of the strncpy function that truncate the terminating NUL
character from the source string.
This new
GCC 8 introduced the -Wstringop-truncation checker to detect truncation by
the strncat and strncpy functions (closely related to -Wstringop-overflow,
which detect buffer overflow by string-modifying functions declared in
).
Add the QEMU_NONSTRING macro which checks if the compiler supports this
Thomas Huth writes:
> It's been marked as deprecated in QEMU v2.6.0 already, so really nobody
> should use the legacy "ivshmem" device anymore (but use ivshmem-plain or
> ivshmem-doorbell instead). Time to remove the deprecated device now.
>
> Signed-off-by: Thomas Huth
> ---
>
GCC 8 added a -Wstringop-truncation warning:
The -Wstringop-truncation warning added in GCC 8.0 via r254630 for
bug 81117 is specifically intended to highlight likely unintended
uses of the strncpy function that truncate the terminating NUL
character from the source string.
This new
GCC 8 new warning prevents builds to success since quite some time.
First report on the mailing list is in July 2018:
https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03723.html
Various intents has been sent to fix this:
- Incorrectly using g_strlcpy()
On 17/12/18 17:48, remy.n...@blade-group.com wrote:
> Also, we do not call aio_epoll_update for deleted handlers as this has
> no impact whatsoever.
Why? epoll is used in level-triggered mode, so you do have to remove
the file descriptor...
> atomic_read(>poll_disable_cnt) +
On 18/12/18 18:17, Michael S. Tsirkin wrote:
> On Tue, Dec 18, 2018 at 06:12:05PM +0100, Paolo Bonzini wrote:
>> On 18/12/18 17:55, Philippe Mathieu-Daudé wrote:
strpadcpy will instead just silence the warning.
>>> migration/global_state.c:109:15: error: 'strlen' argument 1 declared
>>>
On Tue, Dec 18, 2018 at 12:03:34PM -0500, Michael S. Tsirkin wrote:
> On Tue, Dec 18, 2018 at 05:38:17PM +0100, Paolo Bonzini wrote:
> > On 18/12/18 15:54, Michael S. Tsirkin wrote:
> > > On Tue, Dec 18, 2018 at 03:45:08PM +0100, Paolo Bonzini wrote:
> > >> On 18/12/18 15:31, Michael S. Tsirkin
From: Yi Min Zhao
Common function measurement block is used to report zPCI internal
counters of successful pcilg/stg/stb and rpcit instructions to
a memory location provided by the program.
This patch introduces a new ZpciFmb structure and schedules a timer
callback to copy the zPCI measures to
After the last review round I suppressed the fmb_do_update64()
function to have only one single fmb_do_update() to handle
all cases 1,2,4 or 8 bytes.
Patch is tested (for the good case) on Z(KVM) and X(TCG).
Yi Min Zhao (1):
s390x/pci: add common function measurement block
On Mon, 17 Dec 2018 16:53:34 -0500
Eric Farman wrote:
> On 11/22/2018 11:54 AM, Cornelia Huck wrote:
>
> ...snip...
>
> > diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h
> > index 813102810f53..565669f95534 100644
> > --- a/include/uapi/linux/vfio.h
> > +++
> +Virtual devices can also use realtime clock for the events that do not
change
> +the guest state directly. When the clock ticking should depend on VM
execution
> +speed, use virtual ext clock. It is not deterministic, but its speed
depends
> +on the guest execution. This clock is used by the
On Tue, Dec 18, 2018 at 06:12:05PM +0100, Paolo Bonzini wrote:
> On 18/12/18 17:55, Philippe Mathieu-Daudé wrote:
> >> strpadcpy will instead just silence the warning.
> > migration/global_state.c:109:15: error: 'strlen' argument 1 declared
> > attribute 'nonstring' [-Werror=stringop-overflow=]
>
On Mon, 17 Dec 2018 at 16:23, Thomas Huth wrote:
>
> Hi Peter,
>
> the following changes since commit 139108f68486550869bd201f903f1884b78a4ae1:
>
> .shippable.yml: disable the win cross tests (2018-12-17 13:02:12 +)
>
> are available in the git repository at:
>
>
On 18/12/2018 10:55, Cornelia Huck wrote:
On Fri, 14 Dec 2018 17:53:42 +0100
Pierre Morel wrote:
From: Yi Min Zhao
Common function measurement block is used to report zPCI internal
counters of successful pcilg/stg/stb and rpcit instructions to
a memory location provided by the program.
With certain USB devices passed through via usb-host, a guest attempting to
reset a usb-host device can trigger a reset loop that renders the USB device
unusable. In my use case, the device was an iPhone XR that was passed through to
a Mac OS X Mojave guest. Upon connecting the device, the
101 - 200 of 438 matches
Mail list logo
