Re: [Qemu-devel] Monitor and serial output window broken with SDL2

2018-12-18 Thread BALATON Zoltan
On Tue, 18 Dec 2018, Daniel P. Berrangé wrote: On Tue, Dec 18, 2018 at 10:54:06AM +, Mark Cave-Ayland wrote: On 17/12/2018 14:56, BALATON Zoltan wrote: I still have this problem after updating everything on my machine, latest QEMU and SDL 2.0.9 so it's not likely to be a bug in some

[Qemu-devel] [PATCH v2 04/12] MAINTAINERS: Add missing entries to VFIO and NVMe

2018-12-18 Thread Philippe Mathieu-Daudé
The VFIO helpers are used by the NVMe block driver, add the entries to both sections. Signed-off-by: Philippe Mathieu-Daudé --- v2: add util/vfio-helpers.c, add entries to NVMe section --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [Qemu-devel] [PATCH 4/6] target/mips: MXU: Add handlers for logic instructions

2018-12-18 Thread Stefan Markovic
On 17.12.18. 21:04, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Add translation handlers for logic MXU instructions. > > Signed-off-by: Aleksandar Markovic > --- > target/mips/translate.c | 182 +--- > 1 file changed, 170 insertions(+), 12

[Qemu-devel] [PATCH v2 12/12] MAINTAINERS: Add maintainer to the TCG/i386 subsystem

2018-12-18 Thread Philippe Mathieu-Daudé
Richard obviously maintains this subdirectory, make this official :) Remove the qemu-devel@nongnu.org entry because the list is always selected by the 'All patches CC here' section. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH v2 06/22] qemu-nbd: Fail earlier for -c/-d on non-linux

2018-12-18 Thread Vladimir Sementsov-Ogievskiy
15.12.2018 16:53, Eric Blake wrote: > Connecting to a /dev/nbdN device is a Linux-specific action. > We were already masking -c and -d from 'qemu-nbd --help' on > non-linux. However, while -d fails with a sensible error > message, it took hunting through a couple of files to prove > that. What's

Re: [Qemu-devel] [PATCH 1/6] target/mips: MXU: Add missing opcodes/decoding for LX* instructions

2018-12-18 Thread Stefan Markovic
On 17.12.18. 21:04, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Add missing opcodes and decoding engine for LXB, LXH, LXW, LXBU, > and LXHU instructions. They were for some reason forgotten in > previous commits. The MXU opcode list and decoding engine should > be now complete. >

Re: [Qemu-devel] [PATCH v2 0/3] Fix strncpy() warnings for GCC8 new -Wstringop-truncation

2018-12-18 Thread Michael S. Tsirkin
On Tue, Dec 18, 2018 at 12:03:30PM +0100, Philippe Mathieu-Daudé wrote: > GCC 8 new warning prevents builds to success since quite some time. > First report on the mailing list is in July 2018: > https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03723.html > > Various intents has been sent

[Qemu-devel] [PATCH 2/3] ui: fix icon display for GTK frontend under GNOME Shell with Wayland

2018-12-18 Thread Daniel P . Berrangé
The icon associated with a GtkWindow is just a hint to window managers and not all of them will honour it. Some will instead want to show the icon listed by the .desktop file. The desktop file is located based on the application ID, which is set using g_set_prgname. QEMU has not historically

[Qemu-devel] [PATCH 0/3] Fix & improve icon display on GTK and SDL frontends

2018-12-18 Thread Daniel P . Berrangé
This series improves the GTK and SDL frontends so that they display the high quality QEMU logo. Daniel P. Berrangé (3): ui: install logo icons to $prefix/share/icons ui: fix icon display for GTK frontend under GNOME Shell with Wayland sdl: add support for high resolution window icon

Re: [Qemu-devel] [PATCH v13 0/6] Add support for TPM Physical Presence interface

2018-12-18 Thread Michael S. Tsirkin
On Tue, Dec 18, 2018 at 01:28:53PM +0400, Marc-André Lureau wrote: > Hi Michael, > > On Tue, Dec 18, 2018 at 5:42 AM Michael S. Tsirkin wrote: > > > > On Thu, Dec 13, 2018 at 02:26:42AM +0400, Marc-André Lureau wrote: > > > Hi, > > > > > > The following patches implement the TPM Physical

Re: [Qemu-devel] [PATCH v2 for-4.0 2/7] vhost-user: Support providing shared memory to backend

2018-12-18 Thread Michael S. Tsirkin
On Tue, Dec 18, 2018 at 05:59:57PM +0800, elohi...@gmail.com wrote: > From: Xie Yongji > > This patch introduces two new messages VHOST_USER_GET_SHM_SIZE > and VHOST_USER_SET_SHM_FD to support providing shared > memory to backend. > > Firstly, qemu uses VHOST_USER_GET_SHM_SIZE to get the >

Re: [Qemu-devel] [PATCH v2 1/3] hw/acpi: Replace strncpy() by strpadcpy(pad='\0')

2018-12-18 Thread Igor Mammedov
On Tue, 18 Dec 2018 12:03:31 +0100 Philippe Mathieu-Daudé wrote: > From: Marc-André Lureau > > GCC 8 added a -Wstringop-truncation warning: > > The -Wstringop-truncation warning added in GCC 8.0 via r254630 for > bug 81117 is specifically intended to highlight likely unintended > uses

Re: [Qemu-devel] [PATCH v2 for-4.0 6/7] vhost-user-blk: Add support to reconnect backend

2018-12-18 Thread Yongji Xie
On Tue, 18 Dec 2018 at 20:30, Yury Kotov wrote: > > + wrfsh@ > > Hi, > > 18.12.2018, 13:01, "elohi...@gmail.com" : > > From: Xie Yongji > > > > Since we now support the message VHOST_USER_GET_SHM_SIZE > > and VHOST_USER_SET_SHM_FD. The backend is able to restart > > safely because it can record

[Qemu-devel] [PATCH v2 08/12] MAINTAINERS: Add maintainers to the Linux subsystem

2018-12-18 Thread Philippe Mathieu-Daudé
Add Michael, Cornelia and Paolo as maintainers of the Linux subsystem. Remove the qemu-devel@nongnu.org entry because the list is always selected by the 'All patches CC here' section. Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 5 +++-- 1 file changed,

[Qemu-devel] [PULL 3/4] vl: Use error_fatal to simplify obvious fatal errors (again)

2018-12-18 Thread Laurent Vivier
From: Markus Armbruster Patch created mechanically by rerunning: $ spatch --in-place --sp-file scripts/coccinelle/use-error_fatal.cocci \ --macro-file scripts/cocci-macro-file.h vl.c Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Laurent Vivier

[Qemu-devel] [PATCH v2 01/12] MAINTAINERS: Add missing entries to the X86 section (AMD SEV)

2018-12-18 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- v2: Moved from TCG to KVM section --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 83c127f0d6..771b1c7b94 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -392,7 +392,9 @@ M: Marcelo Tosatti L:

Re: [Qemu-devel] [PATCH v3 2/2] intel-iommu: extend VTD emulation to allow 57-bit IOVA address width.

2018-12-18 Thread Yu Zhang
On Tue, Dec 18, 2018 at 07:43:28AM -0500, Michael S. Tsirkin wrote: > On Tue, Dec 18, 2018 at 06:01:16PM +0800, Yu Zhang wrote: > > On Tue, Dec 18, 2018 at 05:47:14PM +0800, Yu Zhang wrote: > > > On Mon, Dec 17, 2018 at 02:29:02PM +0100, Igor Mammedov wrote: > > > > On Wed, 12 Dec 2018 21:05:39

[Qemu-devel] [PATCH v2 05/12] MAINTAINERS: Add missing entries for the QObject section

2018-12-18 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- v2: Removed qdist --- MAINTAINERS | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7a94b0dab3..a381882c27 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1900,10 +1900,14 @@ F: include/qapi/qmp/ X:

[Qemu-devel] [PATCH v2 10/12] MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

2018-12-18 Thread Philippe Mathieu-Daudé
Nobody is looking at those files, downgrade this subsystem as orphan. Remove the qemu-devel@nongnu.org entry because the list is always selected by the 'All patches CC here' section. Suggested-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 3 +-- 1 file changed,

[Qemu-devel] [PATCH v2 11/12] MAINTAINERS: Orphanize the 'GDB stub' subsystem

2018-12-18 Thread Philippe Mathieu-Daudé
Nobody is looking at those files, downgrade this subsystem as orphan. Remove the qemu-devel@nongnu.org entry because the list is always selected by the 'All patches CC here' section. Suggested-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé --- Luc: interested in stepping in? :)

Re: [Qemu-devel] [PATCH V7 2/6] util/mmap-alloc: switch qemu_ram_mmap() to 'flags' parameter

2018-12-18 Thread Michael S. Tsirkin
On Tue, Dec 18, 2018 at 04:17:04PM +0800, Zhang Yi wrote: > As more flag parameters besides the existing 'shared' are going to be > added to qemu_ram_mmap(), let's switch 'shared' to a 'flags' parameter > in advance, so as to ease the further additions. > > Signed-off-by: Haozhong Zhang >

Re: [Qemu-devel] [PATCH v3 1/2] intel-iommu: differentiate host address width from IOVA address width.

2018-12-18 Thread Michael S. Tsirkin
On Tue, Dec 18, 2018 at 05:27:23PM +0800, Yu Zhang wrote: > On Mon, Dec 17, 2018 at 02:17:40PM +0100, Igor Mammedov wrote: > > On Wed, 12 Dec 2018 21:05:38 +0800 > > Yu Zhang wrote: > > > > > Currently, vIOMMU is using the value of IOVA address width, instead of > > > the host address width(HAW)

[Qemu-devel] [PATCH v2 00/12] MAINTAINERS: Add various missing entries

2018-12-18 Thread Philippe Mathieu-Daudé
Hi, This cleanup effort is inspired by Markus "Full list of unmaintained files" from the "MAINTAINERS leaves too many files uncovered" thread: https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04270.html v1: https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04994.html Regards,

[Qemu-devel] [PATCH 3/3] sdl: add support for high resolution window icon

2018-12-18 Thread Daniel P . Berrangé
Modern desktop environments can render icons at very large sizes, especially with high DPI screens. Providing a 32x32 pixel bitmap is nowhere near sufficient anymore. When displayed in GNOME shell the QEMU icon looks awful, having been scaled up to at least x4 its base size. This is compounded by

Re: [Qemu-devel] [PATCH v3 01/16] virtio: split vhost vsock bits from virtio-pci

2018-12-18 Thread Stefan Hajnoczi
On Thu, Dec 13, 2018 at 10:00:42PM +0100, Juan Quintela wrote: > Reviewed-by: Laurent Vivier > Signed-off-by: Juan Quintela > > --- > > Updated copyright info > Also split virtio-pci.h bits > --- > hw/virtio/Makefile.objs | 3 ++ > hw/virtio/vhost-vsock-pci.c | 82

[Qemu-devel] [PATCH v2 06/12] MAINTAINERS: Add missing test entries to the Cryptography section

2018-12-18 Thread Philippe Mathieu-Daudé
Acked-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a381882c27..bdf3534478 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2028,6 +2028,8 @@ F: crypto/ F: include/crypto/ F:

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2018-12-18 Thread Igor Mammedov
On Mon, 17 Dec 2018 10:57:30 -0500 Tony Krowiak wrote: > The qbus_is_full(BusState *bus) function (qdev_monitor.c) compares the > max_index > value of the BusState structure with the max_dev value of the BusClass > structure > to determine whether the maximum number of children has been

Re: [Qemu-devel] [QEMU-devel][PATCH v3] aio-posix: Fix concurrent aio_poll/set_fd_handler.

2018-12-18 Thread Stefan Hajnoczi
On Mon, Dec 17, 2018 at 05:48:47PM +0100, remy.n...@blade-group.com wrote: > From: Remy Noel > > It is possible for an io_poll callback to be concurrently executed along > with an aio_set_fd_handlers. This can cause all sorts of problems, like > a NULL callback or a bad opaque pointer. > > This

Re: [Qemu-devel] [PATCH 10/10] display: add -display app launching external application

2018-12-18 Thread Marc-André Lureau
Hi On Tue, Aug 7, 2018 at 6:30 PM Gerd Hoffmann wrote: > > Hi, > > > > spice arguments over time. So if we want auto-launching of a remote app, > > > I think it is preferrable to do it via extra args to the existing > > > "-display spice" format. eg we could add a "client=yes|no" to control >

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-18 Thread Michael S. Tsirkin
On Tue, Dec 18, 2018 at 04:17:39PM +0800, Zhang Yi wrote: > This option controls whether QEMU mmap(2) will mmap > the memory backend file with > MAP_SYNC flag, which could consistent filesystem metadata I'm not sure what does "which could consistent" above mean. > for each guest > write, if

Re: [Qemu-devel] [PATCH v2 2/5] disas: nanoMIPS: Remove functions that are not used

2018-12-18 Thread Stefan Markovic
On 17.12.18. 18:10, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Some functions were not used at all. Compiler doesn't complain > since they are class memebers. Remove them - no future usage is > planned. > > Signed-off-by: Aleksandar Markovic > --- > disas/nanomips.cpp | 208

Re: [Qemu-devel] [PATCH v2 for-4.0 6/7] vhost-user-blk: Add support to reconnect backend

2018-12-18 Thread Yury Kotov
+ wrfsh@ Hi, 18.12.2018, 13:01, "elohi...@gmail.com" : > From: Xie Yongji > > Since we now support the message VHOST_USER_GET_SHM_SIZE > and VHOST_USER_SET_SHM_FD. The backend is able to restart > safely because it can record inflight I/O in shared memory. > This patch allows qemu to reconnect

Re: [Qemu-devel] [PATCH v2 for-4.0 1/7] chardev: Add disconnected option for chardev socket

2018-12-18 Thread Marc-André Lureau
Hi On Tue, Dec 18, 2018 at 2:01 PM wrote: > > From: Xie Yongji > > New option "disconnected" is added to init the chardev socket > in disconnected state. Then we can use qemu_chr_fe_wait_connected() > to connect when necessary. Now it would be used for unix domain > socket of vhost-user-blk

Re: [Qemu-devel] [PATCH v3 07/16] virtio: split vhost user blk bits from virtio-pci

2018-12-18 Thread Stefan Hajnoczi
On Thu, Dec 13, 2018 at 10:00:48PM +0100, Juan Quintela wrote: > Reviewed-by: Thomas Huth > Reviewed-by: Laurent Vivier > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs| 1 + > hw/virtio/vhost-user-blk-pci.c | 101 + >

Re: [Qemu-devel] [PATCH v2 08/12] MAINTAINERS: Add maintainers to the Linux subsystem

2018-12-18 Thread Cornelia Huck
On Tue, 18 Dec 2018 12:56:11 +0100 Philippe Mathieu-Daudé wrote: > Add Michael, Cornelia and Paolo as maintainers of the Linux subsystem. > > Remove the qemu-devel@nongnu.org entry because the list is always > selected by the 'All patches CC here' section. > > Suggested-by: Paolo Bonzini >

Re: [Qemu-devel] [PULL v3 00/15] Hardfloat + softfloat maintainers update and gitdm

2018-12-18 Thread Peter Maydell
On Mon, 17 Dec 2018 at 10:56, Alex Bennée wrote: > > The following changes since commit b019f5e5375224a003f260c89d424fea7767b7fc: > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-misc-20181214' > into staging (2018-12-16 16:32:43 +) > > are available in the Git repository at: >

Re: [Qemu-devel] [PATCH v2 02/22] nbd: Document timeline of various features

2018-12-18 Thread Vladimir Sementsov-Ogievskiy
15.12.2018 16:53, Eric Blake wrote: > It can be useful to figure out which NBD protocol features are > exposed by a server, as well as what features a client will > take advantage of if available, for a given qemu release. It's > not always precise to base features on version numbers (thanks > to

Re: [Qemu-devel] Monitor and serial output window broken with SDL2

2018-12-18 Thread Daniel P . Berrangé
On Tue, Dec 18, 2018 at 02:11:35PM +0100, BALATON Zoltan wrote: > On Tue, 18 Dec 2018, Daniel P. Berrangé wrote: > > On Tue, Dec 18, 2018 at 10:54:06AM +, Mark Cave-Ayland wrote: > > > On 17/12/2018 14:56, BALATON Zoltan wrote: > > > > > > > I still have this problem after updating everything

Re: [Qemu-devel] [PATCH v3 11/16] virtio: split virtio blk bits rom virtio-pci

2018-12-18 Thread Stefan Hajnoczi
On Thu, Dec 13, 2018 at 10:00:52PM +0100, Juan Quintela wrote: > Reviewed-by: Thomas Huth > Reviewed-by: Laurent Vivier > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs| 1 + > hw/virtio/virtio-blk-pci.c | 97 ++ > hw/virtio/virtio-pci.c

Re: [Qemu-devel] [PATCH V7 3/6] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2018-12-18 Thread Michael S. Tsirkin
On Tue, Dec 18, 2018 at 04:17:12PM +0800, Zhang Yi wrote: > When a file supporting DAX is used as vNVDIMM backend, mmap it with > MAP_SYNC flag in addition can guarantee the persistence of guest write > to the backend file without other QEMU actions (e.g., periodic fsync() > by QEMU). > > A set

Re: [Qemu-devel] [PATCH v2 5/5] disas: nanoMIPS: Name some function in a more descriptive way

2018-12-18 Thread Stefan Markovic
On 17.12.18. 18:10, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Rename some functions that have names hard to understand. > > Signed-off-by: Aleksandar Markovic > --- > disas/nanomips.cpp | 112 ++--- > disas/nanomips.h | 32

Re: [Qemu-devel] [PATCH v2 03/22] maint: Allow for EXAMPLES in texi2pod

2018-12-18 Thread Vladimir Sementsov-Ogievskiy
15.12.2018 16:53, Eric Blake wrote: > The next commit will add an EXAMPLES section to qemu-nbd.8; > for that to work, we need to recognize EXAMPLES in texi2pod, > and we need to make all man pages be regenerated since the > output of texi2pod can be different. > > Signed-off-by: Eric Blake > >

[Qemu-devel] [Bug 1803872] Re: [PATCH v2 3/3] migration: Replace strncpy() by strpadcpy(pad='\0')

2018-12-18 Thread elmarco
On Tue, Dec 18, 2018 at 3:09 PM Philippe Mathieu-Daudé wrote: > > GCC 8 added a -Wstringop-truncation warning: > > The -Wstringop-truncation warning added in GCC 8.0 via r254630 for > bug 81117 is specifically intended to highlight likely unintended > uses of the strncpy function that

Re: [Qemu-devel] [PATCH v2 3/5] disas: nanoMIPS: Fix a function misnomer

2018-12-18 Thread Stefan Markovic
On 17.12.18. 18:10, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Fix wrong name of a function. The convention in this file is that > names of extraction functions should reflect bit patterns they are > extracting. > > Signed-off-by: Aleksandar Markovic > --- > disas/nanomips.cpp

Re: [Qemu-devel] [PATCH] pcie: set link state inactive/active after hot unplug/plug

2018-12-18 Thread Marcel Apfelbaum
On 12/18/18 4:18 AM, Michael S. Tsirkin wrote: On Wed, Dec 05, 2018 at 08:23:35AM +0200, Marcel Apfelbaum wrote: On 12/3/18 9:05 AM, Zheng Xiang wrote: When VM boots from the latest version of linux kernel, after hot-unpluging virtio-blk disks which are hotplugged into pcie-root-port, the

[Qemu-devel] [Bug 1806196] Re: qed leaked clusters

2018-12-18 Thread Stefan Hajnoczi
Thanks for reporting this. QED is not widely used and its features have been incorporated into qcow2, QEMU's native image format. Since there is no development effort behind QED it is unlikely that this bug will be addressed. Patches are always welcome though! -- You received this bug

[Qemu-devel] [PATCH] tests: Move qdict-test-data.txt to tests/data/qobject/

2018-12-18 Thread Philippe Mathieu-Daudé
Move qdict-test-data.txt to the tests/data/qobject/ subdirectory, and remove the unnecessary symlinking. (See 4b2ff65a1f3 for similar test-data cleanup). Suggested-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 +

Re: [Qemu-devel] [PATCH 2/3] mac_newworld: enable access to EDID data for the VGA device

2018-12-18 Thread Programmingkid
> On 12/12/2018 13:38, Gerd Hoffmann wrote: > >> On Wed, Dec 12, 2018 at 08:54:37AM +, Mark Cave-Ayland wrote: >>> On 12/12/2018 08:32, Gerd Hoffmann wrote: >>> On Fri, Dec 07, 2018 at 04:08:05PM +, Mark Cave-Ayland wrote: > This is in preparation for some upcoming QEMU NDRV

[Qemu-devel] [PATCH v8 19/20] replay: init rtc after enabling the replay

2018-12-18 Thread Pavel Dovgalyuk
This patch postpones the call of 'configure_rtc' function. This call uses host clock to configure the rtc, but host clock access should be recorded when using icount record/replay mode. Therefore now rtc is configured after switching record/replay mode on. Signed-off-by: Pavel Dovgalyuk ---

[Qemu-devel] [PATCH v8 17/20] replay: describe reverse debugging in docs/replay.txt

2018-12-18 Thread Pavel Dovgalyuk
This patch updates the documentation and describes usage of the reverse debugging in QEMU+GDB. Signed-off-by: Pavel Dovgalyuk --- docs/replay.txt | 33 + 1 file changed, 33 insertions(+) diff --git a/docs/replay.txt b/docs/replay.txt index 2c2c5f6..8447fdd

[Qemu-devel] [PATCH v8 16/20] gdbstub: add reverse continue support in replay mode

2018-12-18 Thread Pavel Dovgalyuk
This patch adds support of the reverse continue operation for gdbstub. Reverse continue finds the last breakpoint that would happen in normal execution from the beginning to the current moment. Implementation of the reverse continue replays the execution twice: to find the breakpoints that were

[Qemu-devel] [PATCH v8 09/20] replay: provide and accessor for rr filename

2018-12-18 Thread Pavel Dovgalyuk
This patch adds an accessor function for the name of the record/replay log file. Adding an accessor instead of making variable global, prevents accidental modification of this variable by other modules. Signed-off-by: Pavel Dovgalyuk --- include/sysemu/replay.h |2 ++ replay/replay.c

[Qemu-devel] [PATCH v8 14/20] replay: flush rr queue before loading the vmstate

2018-12-18 Thread Pavel Dovgalyuk
Non-empty record/replay queue prevents saving and loading the VM state, because it includes pending bottom halves and block coroutines. But when the new VM state is loaded, we don't have to preserve the consistency of the current state anymore. Therefore this patch just flushes the queue allowing

[Qemu-devel] [PATCH v8 15/20] gdbstub: add reverse step support in replay mode

2018-12-18 Thread Pavel Dovgalyuk
GDB remote protocol supports two reverse debugging commands: reverse step and reverse continue. This patch adds support of the first one to the gdbstub. Reverse step is intended to step one instruction in the backwards direction. This is not possible in regular execution. But replayed execution is

[Qemu-devel] [PATCH v8 20/20] replay: document development rules

2018-12-18 Thread Pavel Dovgalyuk
This patch introduces docs/devel/replay.txt which describes the rules that should be followed to make virtual devices usable in record/replay mode. Signed-off-by: Pavel Dovgalyuk --- docs/devel/replay.txt | 45 + 1 file changed, 45 insertions(+)

[Qemu-devel] [PATCH v8 13/20] replay: refine replay-time module

2018-12-18 Thread Pavel Dovgalyuk
This patch removes refactoring artifacts from the replay/replay-time.c Signed-off-by: Pavel Dovgalyuk --- replay/replay-time.c | 32 +--- 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/replay/replay-time.c b/replay/replay-time.c index

[Qemu-devel] [PATCH v8 07/20] qcow2: introduce icount field for snapshots

2018-12-18 Thread Pavel Dovgalyuk
This patch introduces the icount field for saving within the snapshot. It is required for navigation between the snapshots in record/replay mode. Signed-off-by: Pavel Dovgalyuk Acked-by: Kevin Wolf -- v2: - documented format changes in docs/interop/qcow2.txt (suggested by Eric Blake) ---

[Qemu-devel] [PATCH v8 11/20] replay: introduce breakpoint at the specified step

2018-12-18 Thread Pavel Dovgalyuk
This patch introduces replay_break, replay_delete_break qmp and hmp commands. These commands allow stopping at the specified instruction. It may be useful for debugging when there are some known events that should be investigated. replay_break command has one argument - number of instructions

[Qemu-devel] [PATCH v8 12/20] replay: implement replay-seek command to proceed to the desired step

2018-12-18 Thread Pavel Dovgalyuk
This patch adds hmp/qmp commands replay_seek/replay-seek that proceed the execution to the specified step. The commands automatically loads nearest snapshot and replay the execution to find the desired step. Signed-off-by: Pavel Dovgalyuk -- v2: - renamed replay_seek qmp command into

[Qemu-devel] [PATCH v8 06/20] replay: finish record/replay before closing the disks

2018-12-18 Thread Pavel Dovgalyuk
After recent updates block devices cannot be closed on qemu exit. This happens due to the block request polling when replay is not finished. Therefore now we stop execution recording before closing the block devices. Signed-off-by: Pavel Dovgalyuk --- replay/replay.c |2 ++ vl.c

[Qemu-devel] [PATCH v8 18/20] replay: add BH oneshot event for block layer

2018-12-18 Thread Pavel Dovgalyuk
Replay is capable of recording normal BH events, but sometimes there are single use callbacks scheduled with aio_bh_schedule_oneshot function. This patch enables recording and replaying such callbacks. Block layer uses these events for calling the completion function. Replaying these calls makes

[Qemu-devel] [PATCH v8 08/20] migration: introduce icount field for snapshots

2018-12-18 Thread Pavel Dovgalyuk
Saving icount as a parameters of the snapshot allows navigation between them in the execution replay scenario. This information can be used for finding a specific snapshot for rewinding the recorded execution to the specific moment of the time. E.g., 'reverse step' action needs to load the nearest

[Qemu-devel] [PATCH v8 03/20] replay: disable default snapshot for record/replay

2018-12-18 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch disables setting '-snapshot' option on by default in record/replay mode. This is needed for creating vmstates in record and replay modes. Signed-off-by: Pavel Dovgalyuk --- vl.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v8 02/20] block: implement bdrv_snapshot_goto for blkreplay

2018-12-18 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch enables making snapshots with blkreplay used in block devices. This function is required to make bdrv_snapshot_goto without calling .bdrv_open which is not implemented. Signed-off-by: Pavel Dovgalyuk --- block/blkreplay.c |8 1 file changed, 8

[Qemu-devel] [PATCH v8 10/20] replay: introduce info hmp/qmp command

2018-12-18 Thread Pavel Dovgalyuk
This patch introduces 'info replay' monitor command and corresponding qmp request. These commands request the current record/replay mode, replay log file name, and the execution step (number or recorded/replayed instructions). User may use step number for replay_seek/replay_break commands and for

[Qemu-devel] [PATCH v8 05/20] replay: don't drain/flush bdrv queue while RR is working

2018-12-18 Thread Pavel Dovgalyuk
In record/replay mode bdrv queue is controlled by replay mechanism. It does not allow saving or loading the snapshots when bdrv queue is not empty. Stopping the VM is not blocked by nonempty queue, but flushing the queue is still impossible there, because it may cause deadlocks in replay mode.

[Qemu-devel] [PATCH v8 04/20] replay: update docs for record/replay with block devices

2018-12-18 Thread Pavel Dovgalyuk
This patch updates the description of the command lines for using record/replay with attached block devices. Signed-off-by: Pavel Dovgalyuk --- docs/replay.txt | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/docs/replay.txt b/docs/replay.txt index

[Qemu-devel] [PATCH v8 00/20] Fixing record/replay and adding reverse debugging

2018-12-18 Thread Pavel Dovgalyuk
GDB remote protocol supports reverse debugging of the targets. It includes 'reverse step' and 'reverse continue' operations. The first one finds the previous step of the execution, and the second one is intended to stop at the last breakpoint that would happen when the program is executed

[Qemu-devel] [PATCH v8 01/20] replay: add missing fix for internal function

2018-12-18 Thread Pavel Dovgalyuk
From: pbonz...@redhat.com This is a fix which was missed by patch 74c0b816adfc6aa1b01b4426fdf385e32e35cbac, which added current_step parameter to the replay_advance_current_step function. Signed-off-by: Pavel Dovgalyuk --- replay/replay-internal.c |2 +- 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] Monitor and serial output window broken with SDL2

2018-12-18 Thread Daniel P . Berrangé
On Tue, Dec 18, 2018 at 10:54:06AM +, Mark Cave-Ayland wrote: > On 17/12/2018 14:56, BALATON Zoltan wrote: > > > I still have this problem after updating everything on my machine, latest > > QEMU and > > SDL 2.0.9 so it's not likely to be a bug in some external component. If I > > just

Re: [Qemu-devel] [PATCH v2 1/3] hw/acpi: Replace strncpy() by strpadcpy(pad='\0')

2018-12-18 Thread Philippe Mathieu-Daudé
On 12/18/18 12:03 PM, Philippe Mathieu-Daudé wrote: > From: Marc-André Lureau > > GCC 8 added a -Wstringop-truncation warning: > > The -Wstringop-truncation warning added in GCC 8.0 via r254630 for > bug 81117 is specifically intended to highlight likely unintended > uses of the strncpy

Re: [Qemu-devel] Monitor and serial output window broken with SDL2

2018-12-18 Thread Daniel P . Berrangé
On Mon, Dec 17, 2018 at 10:57:14PM +0100, BALATON Zoltan wrote: > On Mon, 17 Dec 2018, Daniel P. Berrangé wrote: > > On Mon, Dec 17, 2018 at 03:56:49PM +0100, BALATON Zoltan wrote: > > > On Wed, 21 Mar 2018, BALATON Zoltan wrote: > > > > On Wed, 21 Mar 2018, Gerd Hoffmann wrote: > > > > > > while

[Qemu-devel] [PATCH v2 1/3] hw/acpi: Replace strncpy() by strpadcpy(pad='\0')

2018-12-18 Thread Philippe Mathieu-Daudé
From: Marc-André Lureau GCC 8 added a -Wstringop-truncation warning: The -Wstringop-truncation warning added in GCC 8.0 via r254630 for bug 81117 is specifically intended to highlight likely unintended uses of the strncpy function that truncate the terminating NUL character from the

[Qemu-devel] [PATCH v2 0/3] Fix strncpy() warnings for GCC8 new -Wstringop-truncation

2018-12-18 Thread Philippe Mathieu-Daudé
GCC 8 new warning prevents builds to success since quite some time. First report on the mailing list is in July 2018: https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03723.html Various intents has been sent to fix this: - Incorrectly using g_strlcpy()

Re: [Qemu-devel] [PULL v3 08/15] tests/fp: add fp-bench

2018-12-18 Thread Alex Bennée
Emilio G. Cota writes: > On Mon, Dec 17, 2018 at 10:56:43 +, Alex Bennée wrote: >> From: "Emilio G. Cota" >> +static void update_random_ops(int n_ops, enum precision prec) >> +{ >> +int i; >> + >> +for (i = 0; i < n_ops; i++) { >> +uint64_t r = random_ops[i]; >> + >> +

[Qemu-devel] [PATCH v2 2/3] block/sheepdog: Replace strncpy() by strpadcpy(pad='\0')

2018-12-18 Thread Philippe Mathieu-Daudé
GCC 8 added a -Wstringop-truncation warning: The -Wstringop-truncation warning added in GCC 8.0 via r254630 for bug 81117 is specifically intended to highlight likely unintended uses of the strncpy function that truncate the terminating NUL character from the source string. This new

Re: [Qemu-devel] [PATCH-for-4.0 v2 2/2] hw/arm/virt-acpi-build: IORT Update for revision D

2018-12-18 Thread Auger Eric
Hi Drew, On 12/17/18 7:25 PM, Andrew Jones wrote: > On Mon, Dec 17, 2018 at 05:49:02PM +0100, Auger Eric wrote: >> Hi Drew, >> >> On 12/17/18 5:27 PM, Andrew Jones wrote: >>> On Thu, Dec 06, 2018 at 06:07:33PM +0100, Eric Auger wrote: Let's update the structs according to revision D of the

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: Add H-Call H_HOME_NODE_ASSOCIATIVITY

2018-12-18 Thread Laurent Vivier
On 18/12/2018 11:50, Greg Kurz wrote: > On Tue, 18 Dec 2018 11:00:01 +0100 > Laurent Vivier wrote: > >> On 18/12/2018 10:23, Greg Kurz wrote: >>> On Tue, 18 Dec 2018 08:50:00 +0100 ... >>> Also, even if linux only seems to call this with 0x1, this is a >>> limitation from a LoPAPR standpoint.

Re: [Qemu-devel] Monitor and serial output window broken with SDL2

2018-12-18 Thread Mark Cave-Ayland
On 17/12/2018 14:56, BALATON Zoltan wrote: > I still have this problem after updating everything on my machine, latest > QEMU and > SDL 2.0.9 so it's not likely to be a bug in some external component. If I > just start > qemu-system-ppc (compiled with --disable-gtk) and try to open monitor

[Qemu-devel] [PATCH v2 3/3] migration: Replace strncpy() by strpadcpy(pad='\0')

2018-12-18 Thread Philippe Mathieu-Daudé
GCC 8 added a -Wstringop-truncation warning: The -Wstringop-truncation warning added in GCC 8.0 via r254630 for bug 81117 is specifically intended to highlight likely unintended uses of the strncpy function that truncate the terminating NUL character from the source string. This new

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: Add H-Call H_HOME_NODE_ASSOCIATIVITY

2018-12-18 Thread Greg Kurz
On Tue, 18 Dec 2018 11:00:01 +0100 Laurent Vivier wrote: > On 18/12/2018 10:23, Greg Kurz wrote: > > On Tue, 18 Dec 2018 08:50:00 +0100 > > Laurent Vivier wrote: > > > >> On 18/12/2018 05:29, David Gibson wrote: > >>> On Mon, Dec 17, 2018 at 03:00:55PM +0100, Laurent Vivier wrote: >

Re: [Qemu-devel] [PATCH v2 1/5] disas: nanoMIPS: Fix preamble text

2018-12-18 Thread Stefan Markovic
On 17.12.18. 18:10, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Fix several mistakes in preambles of nanomips disassembler source > files. > > Signed-off-by: Aleksandar Markovic > --- > disas/nanomips.cpp | 7 --- > disas/nanomips.h | 7 --- > 2 files changed, 8

Re: [Qemu-devel] sheepdog build warning

2018-12-18 Thread Daniel P . Berrangé
On Mon, Dec 17, 2018 at 11:16:05PM -0500, Michael S. Tsirkin wrote: > On Mon, Dec 17, 2018 at 11:03:11PM -0500, Michael S. Tsirkin wrote: > > mingw32 build on fedora fails with this warning: > > > > /scm/qemu/block/sheepdog.c: In function 'find_vdi_name': > > /scm/qemu/block/sheepdog.c:1239:5:

Re: [Qemu-devel] [RFC 2/2] qemu-thread: Don't block SEGV, ILL and FPE

2018-12-18 Thread Daniel P . Berrangé
On Mon, Dec 17, 2018 at 11:26:02PM +0300, Roman Bolshakov wrote: > If any of these signals happen on macOS, they are not delivered to other > threads and signalfd_compat receives nothing. Indeed, POSIX reference > and sigprocmask(2) note that an attempt to block the signals results in > undefined

Re: [Qemu-devel] [RFC 1/2] util: Implement debug-threads for macOS

2018-12-18 Thread Daniel P . Berrangé
On Mon, Dec 17, 2018 at 11:26:01PM +0300, Roman Bolshakov wrote: > macOS provides pthread_setname_np that doesn't have thread id argument. > > Signed-off-by: Roman Bolshakov > --- > configure| 32 ++-- > qemu-options.hx | 4 ++-- >

Re: [Qemu-devel] [PATCH] qapi: fix flat union on uncovered branches conditionals

2018-12-18 Thread Thomas Huth
On 2018-12-17 21:40, Marc-André Lureau wrote: > Default branches variant should use the member conditional. > > This fixes compilation with --disable-replication. > > Fixes: 335d10cd8e2c3bb6067804b095aaf6371fc1983e > > Signed-off-by: Marc-André Lureau > --- > scripts/qapi/common.py | 2 +- >

[Qemu-devel] [PULL 6/7] qmp hmp: Make system_wakeup check wake-up support and run state

2018-12-18 Thread Markus Armbruster
From: Daniel Henrique Barboza The qmp/hmp command 'system_wakeup' is simply a direct call to 'qemu_system_wakeup_request' from vl.c. This function verifies if runstate is SUSPENDED and if the wake up reason is valid before proceeding. However, no error or warning is thrown if any of those

[Qemu-devel] [PULL 0/7] QAPI patches for 2018-12-18

2018-12-18 Thread Markus Armbruster
The following changes since commit f163448536e5f7ae8905b14547eab37a41a75f6c: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20181216' into staging (2018-12-17 13:04:25 +) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2018-12-18 for

Re: [Qemu-devel] sheepdog build warning

2018-12-18 Thread Philippe Mathieu-Daudé
Hi Michael, On 12/18/18 5:16 AM, Michael S. Tsirkin wrote: > On Mon, Dec 17, 2018 at 11:03:11PM -0500, Michael S. Tsirkin wrote: >> mingw32 build on fedora fails with this warning: >> >> /scm/qemu/block/sheepdog.c: In function 'find_vdi_name': >> /scm/qemu/block/sheepdog.c:1239:5: error:

[Qemu-devel] [PULL 3/7] qmp: Split ShutdownCause host-qmp into quit and system-reset

2018-12-18 Thread Markus Armbruster
From: Dominik Csapak It is interesting to know whether the shutdown cause was 'quit' or 'reset', especially when using "--no-reboot". In that case, a management layer can now determine if the guest wanted a reboot or shutdown, and can act accordingly. Changes the output of the reason in the

Re: [Qemu-devel] [PATCH] qapi: fix flat union on uncovered branches conditionals

2018-12-18 Thread Markus Armbruster
Marc-André Lureau writes: > Default branches variant should use the member conditional. > > This fixes compilation with --disable-replication. > > Fixes: 335d10cd8e2c3bb6067804b095aaf6371fc1983e > > Signed-off-by: Marc-André Lureau Queued, thanks!

[Qemu-devel] [PULL 7/7] qapi: fix flat union on uncovered branches conditionals

2018-12-18 Thread Markus Armbruster
From: Marc-André Lureau Default branches variant should use the member conditional. This fixes compilation with --disable-replication. Fixes: 335d10cd8e2c3bb6067804b095aaf6371fc1983e Signed-off-by: Marc-André Lureau Message-Id: <20181217204046.14861-1-marcandre.lur...@redhat.com>

[Qemu-devel] [PULL 4/7] qmp: query-current-machine with wakeup-suspend-support

2018-12-18 Thread Markus Armbruster
From: Daniel Henrique Barboza When issuing the qmp/hmp 'system_wakeup' command, what happens in a nutshell is: - qmp_system_wakeup_request set runstate to RUNNING, sets a wakeup_reason and notify the event - in the main_loop, all vcpus are paused, a system reset is issued, all subscribers of

Re: [Qemu-devel] Regression test with --disable options

2018-12-18 Thread Markus Armbruster
Thomas Huth writes: > This is the second time in 2 months that compilation with > --disable-replication broke. So instead of relying on reviews here, I > think we should catch this with Patchew / some docker based compilation > test instead that configures the build process with everything

[Qemu-devel] [PULL 2/7] qmp: Add reason to SHUTDOWN and RESET events

2018-12-18 Thread Markus Armbruster
From: Dominik Csapak This makes it possible to determine what the exact reason was for a RESET or a SHUTDOWN. A management layer might need the specific reason of those events to determine which cleanups or other actions it needs to do. This patch also updates the iotests to the new expected

[Qemu-devel] [PULL 5/7] qga: update guest-suspend-ram and guest-suspend-hybrid descriptions

2018-12-18 Thread Markus Armbruster
From: Daniel Henrique Barboza This patch updates the descriptions of 'guest-suspend-ram' and 'guest-suspend-hybrid' to mention that both commands relies now on the proper support for wake up from suspend, retrieved by the 'wakeup-suspend-support' attribute of the 'query-current-machine' QMP

[Qemu-devel] [PULL 1/7] qapi: Turn ShutdownCause into QAPI enum

2018-12-18 Thread Markus Armbruster
From: Dominik Csapak Needed so the patch after next can add ShutdownCause to QMP events SHUTDOWN and RESET. Signed-off-by: Dominik Csapak Message-Id: <20181205110131.23049-2-d.csa...@proxmox.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- include/sysemu/sysemu.h |

[Qemu-devel] [PATCH v2 for-4.0 6/7] vhost-user-blk: Add support to reconnect backend

2018-12-18 Thread elohimes
From: Xie Yongji Since we now support the message VHOST_USER_GET_SHM_SIZE and VHOST_USER_SET_SHM_FD. The backend is able to restart safely because it can record inflight I/O in shared memory. This patch allows qemu to reconnect the backend after connection closed. Signed-off-by: Xie Yongji

[Qemu-devel] [PATCH v2 for-4.0 5/7] vhost-user-blk: Add support to provide shared memory to backend

2018-12-18 Thread elohimes
From: Xie Yongji This patch add supports for vhost-user-blk device to provide shared memory to backend. Signed-off-by: Xie Yongji Signed-off-by: Zhang Yu --- hw/block/vhost-user-blk.c | 26 ++ include/hw/virtio/vhost-user-blk.h | 1 + 2 files changed, 27

[Qemu-devel] [PATCH v2 for-4.0 3/7] libvhost-user: Introduce vu_queue_map_desc()

2018-12-18 Thread elohimes
From: Xie Yongji Introduce vu_queue_map_desc() which should be independent with vu_queue_pop(); Signed-off-by: Xie Yongji Signed-off-by: Zhang Yu Reviewed-by: Marc-André Lureau --- contrib/libvhost-user/libvhost-user.c | 88 --- 1 file changed, 51 insertions(+), 37

<    1   2   3   4   5   >