[Qemu-devel] [PATCH v2] softfloat: enforce softfloat if the host's FMA is broken

2018-12-24 Thread Emilio G. Cota
The added branch to the FMA ops is marked as unlikely and therefore its impact on performance (measured with fp-bench) is within noise range when measured on an Intel(R) Xeon(R) Gold 6142 CPU @ 2.60GHz. Reported-by: Laurent Desnogues Signed-off-by: Emilio G. Cota --- v2: drop the cpuid bits,

Re: [Qemu-devel] [PATCH] softfloat: enforce softfloat if the host's FMA is broken

2018-12-24 Thread Emilio G. Cota
On Mon, Dec 24, 2018 at 21:38:52 +, Peter Maydell wrote: > On Mon, 24 Dec 2018 at 19:16, Emilio G. Cota wrote: > > The added branch to the FMA ops is marked as unlikely and therefore > > its impact on performance (measured with fp-bench) is within noise range > > when measured on an Intel(R)

Re: [Qemu-devel] [RFC PATCH 1/1] hw/core: add qom getter for kernel-irqchip property

2018-12-24 Thread Peter Xu
On Mon, Dec 24, 2018 at 06:52:35AM -0500, Wainer dos Santos Moschetta wrote: > Allows to access the kernel-irqchip property of a Machine > Class object via QOM get method. > > Before this patch the property cannot be read although it is > listed by qom-list: > > qemu-system-x86_64 -M

Re: [Qemu-devel] what is the behavier precisely if a tb was interrupted by a interrupt or signal?

2018-12-24 Thread tugouxp
thank you. if so ,the interrupt granularity cant be instructions precisely, but tb precisely, for qemu cant check the interrupt at each instructions execution stage, right? At 2018-12-24 21:49:07, "Peter Maydell" wrote: >On Mon, 24 Dec 2018 at 10:11, tugouxp <13824125...@163.com>

Re: [Qemu-devel] [PATCH v5 0/8] linux-user: Split do_syscall

2018-12-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20181219042113.7364-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20181219042113.7364-1-richard.hender...@linaro.org Type: series Subject: [Qemu-devel] [PATCH

Re: [Qemu-devel] [PULL 00/64] slirp updates

2018-12-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20181218230442.27887-1-samuel.thiba...@ens-lyon.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST

Re: [Qemu-devel] [PULL 00/64] slirp updates

2018-12-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20181218230442.27887-1-samuel.thiba...@ens-lyon.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20181218230442.27887-1-samuel.thiba...@ens-lyon.org Type: series Subject: [Qemu-devel] [PULL

Re: [Qemu-devel] [PULL 00/64] slirp updates

2018-12-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20181218230442.27887-1-samuel.thiba...@ens-lyon.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [Qemu-devel] [PATCH v3 2/2] intel-iommu: extend VTD emulation to allow 57-bit IOVA address width.

2018-12-24 Thread Tian, Kevin
> From: Yu Zhang > Sent: Saturday, December 22, 2018 1:34 AM > [...] > > > > > As to the check against hardware IOMMU, Peter once had a proposal in > > > http://lists.nongnu.org/archive/html/qemu-devel/2018- > 11/msg02281.html > > > > > > Do you have any comment or suggestion on Peter's proposal?

[Qemu-devel] [Bug 1809684] [NEW] amdgpu passthrough on POWER9 (ppc64el) not working

2018-12-24 Thread Timothy Pearson
Public bug reported: When attempting to pass a Vega 56 GPU to a virtualized guest using QEMU 3.1 on ppc64el (POWER9), the guest is unable to initialize the GPU. Further digging reveals the driver attempting to allocate a large BAR, which then fails: [6.058544] [drm] PCI I/O BAR is not found.

Re: [Qemu-devel] [PATCH v3 0/5] Fix strncpy() warnings for GCC8 new -Wstringop-truncation

2018-12-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20181218175122.3229-1-phi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20181218175122.3229-1-phi...@redhat.com Type: series Subject: [Qemu-devel] [PATCH v3 0/5] Fix strncpy()

Re: [Qemu-devel] [PATCH 4/4] tcg: Add reachable_code_pass

2018-12-24 Thread Emilio G. Cota
On Mon, Nov 26, 2018 at 15:04:50 -0800, Richard Henderson wrote: > Delete trivially dead code that follows unconditional branches and > noreturn helpers. These can occur either via optimization or via > the structure of a target's translator following an exception. > > Signed-off-by: Richard

Re: [Qemu-devel] [PATCH 00/12] tcg: Improve register allocation for calls

2018-12-24 Thread Emilio G. Cota
On Tue, Nov 27, 2018 at 21:38:22 -0800, Richard Henderson wrote: > The intent here is to remove several move insns putting the > function arguments into the proper place. I'm hoping that > this will solve the skylake regression with spec2006, as > seen with the ool softmmu patch set.

Re: [Qemu-devel] [PATCH] softfloat: enforce softfloat if the host's FMA is broken

2018-12-24 Thread Peter Maydell
On Mon, 24 Dec 2018 at 19:16, Emilio G. Cota wrote: > The added branch to the FMA ops is marked as unlikely and therefore > its impact on performance (measured with fp-bench) is within noise range > when measured on an Intel(R) Xeon(R) Gold 6142 CPU @ 2.60GHz. > +/* check whether avx is

Re: [Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX

2018-12-24 Thread Kővágó Zoltán
On 2018-12-24 18:16, Philippe Mathieu-Daudé wrote: > On 12/24/18 3:16 AM, Zoltán Kővágó wrote: >> Hi Phil, >> >> On 2018-12-24 00:49, Philippe Mathieu-Daudé wrote: >>> Hi Zoltán, >>> >>> On 12/23/18 9:51 PM, Kővágó, Zoltán wrote: There's already a MIN and MAX macro in include/qemu/osdep.h,

Re: [Qemu-devel] [Qemu-block] do not lseek in qcow2 block_status

2018-12-24 Thread Nir Soffer
On Mon, Dec 24, 2018 at 5:50 PM Vladimir Sementsov-Ogievskiy < vsement...@virtuozzo.com> wrote: > Hi all! > > bdrv_co_block_status digs bs->file for additional, more accurate search > for hole > inside region, reported as DATA by bs since long-ago > >commit

[Qemu-devel] [Bug 1809304] Re: qemu-img convert is freezing for some DMG files.

2018-12-24 Thread Julio Faracco
Additional info: tested with version 3.0.0. So, before pushing my commits. Conclusion: This is not a new bug. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1809304 Title: qemu-img convert is

[Qemu-devel] [PATCH] softfloat: enforce softfloat if the host's FMA is broken

2018-12-24 Thread Emilio G. Cota
The added branch to the FMA ops is marked as unlikely and therefore its impact on performance (measured with fp-bench) is within noise range when measured on an Intel(R) Xeon(R) Gold 6142 CPU @ 2.60GHz. In addition, when the host doesn't have a hardware FMA instruction we force the use of

Re: [Qemu-devel] [PATCH v8 00/20] Fixing record/replay and adding reverse debugging

2018-12-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20181218112056.11727.96529.stgit@pasha-VirtualBox/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20181218112056.11727.96529.stgit@pasha-VirtualBox Type: series Subject: [Qemu-devel] [PATCH v8

[Qemu-devel] [PATCH v4 05/11] disas: nanoMIPS: Name some functions in a more descriptive way

2018-12-24 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename some functions that have names that are hard to understand. Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 112 ++--- disas/nanomips.h | 32 +++ 2 files

[Qemu-devel] [PATCH v4 08/11] disas: nanoMIPS: Fix an FP-related misnomer 3

2018-12-24 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename NMD::extract_ft_20_19_18_17_16(uint64 instruction) to NMD::extract_ft_25_24_23_22_21(uint64 instruction). Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 258 ++--- disas/nanomips.h | 2 +- 2

[Qemu-devel] [PATCH v4 09/11] disas: nanoMIPS: Name more functions in a more descriptive way

2018-12-24 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename more functions that have names that are hard to understand. Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 212 ++--- disas/nanomips.h | 28 +++ 2 files changed, 120 insertions(+), 120

[Qemu-devel] [PATCH v4 10/11] disas: nanoMIPS: Fix order of more invocations

2018-12-24 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix order of extraction function invocations so that extraction goes from MSB side to LSB side of the given instruction coding content. This is desireable because of consistency and easier visual spotting of errors. After this patch, all such invocations should be in

[Qemu-devel] [PATCH v4 03/11] disas: nanoMIPS: Fix a function misnomer

2018-12-24 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix wrong function name. The convention in these files is that names of extraction functions should reflect bit patterns they are extracting. Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 264

[Qemu-devel] [PATCH v4 06/11] disas: nanoMIPS: Fix an FP-related misnomer 1

2018-12-24 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename NMD::extract_fd_10_9_8_7_6(uint64 instruction) to NMD::extract_fd_15_14_13_12_11(uint64 instruction). Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 142 ++--- disas/nanomips.h | 2 +- 2 files

[Qemu-devel] [PATCH v4 07/11] disas: nanoMIPS: Fix an FP-related misnomer 2

2018-12-24 Thread Aleksandar Markovic
From: Aleksandar Markovic -uint64 NMD::extract_fs_15_14_13_12_11(uint64 instruction) +uint64 NMD::extract_fs_20_19_18_17_16(uint64 instruction) Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 242 ++--- disas/nanomips.h | 2 +- 2

[Qemu-devel] [PATCH v4 11/11] disas: nanoMIPS: Fix comments for 48-bit instructions

2018-12-24 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix comments for 48-bit nanoMIPS instructions: - ADDIU[48] - ADDIU[GP48] - ADDIUPC[48] - LI[48] - LWPC[48] - SWPC[48] Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 70 -- 1 file changed,

[Qemu-devel] [PATCH v4 02/11] disas: nanoMIPS: Remove functions that are not used

2018-12-24 Thread Aleksandar Markovic
From: Aleksandar Markovic Some functions were not used at all. Compiler doesn't complain since they are class memebers. Remove them - no future usage is planned. Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 208

[Qemu-devel] [PATCH v4 01/11] disas: nanoMIPS: Fix preamble text in nanomips.* files

2018-12-24 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix several mistakes in preambles of nanomips disassembler source files. Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 7 --- disas/nanomips.h | 7 --- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH v4 00/11] disas: nanoMIPS: Clean up several issues

2018-12-24 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up several misc issues in nanoMIPS disassembler. There are more issues to be cleaned, and this is meant to be just the first phase. Complete cleanup should happen over the course of next few months. All these changes should not and do not affect any

Re: [Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX

2018-12-24 Thread Philippe Mathieu-Daudé
On 12/24/18 3:16 AM, Zoltán Kővágó wrote: > Hi Phil, > > On 2018-12-24 00:49, Philippe Mathieu-Daudé wrote: >> Hi Zoltán, >> >> On 12/23/18 9:51 PM, Kővágó, Zoltán wrote: >>> There's already a MIN and MAX macro in include/qemu/osdep.h, use them >>> instead. >>> >>> Signed-off-by: Kővágó, Zoltán

Re: [Qemu-devel] [PULL 00/31] pci, pc, virtio: fixes, features

2018-12-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20181218041625.24969-1-...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20181218041625.24969-1-...@redhat.com Type: series Subject: [Qemu-devel] [PULL 00/31] pci, pc, virtio:

[Qemu-devel] [Bug 1809665] [NEW] Xbox One controller USB passthrough disconnections and stops

2018-12-24 Thread Saverio Miroddi
Public bug reported: I can't properly passthrough my Xbox One controller to a virtual machine; it causes USB disconnections on the host, ultimately preventing it to work (at all) on the guest I've seen a few other cases reported in other websites, which show the same symptoms: -

[Qemu-devel] do not lseek in qcow2 block_status

2018-12-24 Thread Vladimir Sementsov-Ogievskiy
Hi all! bdrv_co_block_status digs bs->file for additional, more accurate search for hole inside region, reported as DATA by bs since long-ago commit 5daa74a6ebce7543aaad178c4061dc087bb4c705 Author: Paolo Bonzini Date: Wed Sep 4 19:00:38 2013 +0200 block: look for zero blocks

[Qemu-devel] [PATCH] hw/core: fix whitespace in a sentence

2018-12-24 Thread Wainer dos Santos Moschetta
Signed-off-by: Wainer dos Santos Moschetta --- hw/core/machine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index 4439ea663f..a0beeeb2a9 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -591,7 +591,7 @@ static void

[Qemu-devel] [Bug 1809304] Re: qemu-img convert is freezing for some DMG files.

2018-12-24 Thread Julio Faracco
Hi Yu-Chen. The series looks good. It fixed the problems related to zero chunk. Nice work! I added a comment that I reviewed your patch considering my scenarios here. At least, It contributes to merge your changes. -- You received this bug notification because you are a member of qemu-

Re: [Qemu-devel] [PATCH v2 3/3] dmg: don't skip zero chunk

2018-12-24 Thread Julio Faracco
Looks good to me. Reviewed-by: Julio Faracco Em dom, 23 de dez de 2018 às 01:03, yuchenlin escreveu: > The dmg file has many tables which describe: "start from sector XXX to > sector XXX, the compression method is XXX and where the compressed data > resides on". > > Each sector in the

Re: [Qemu-devel] [PATCH v2 2/3] dmg: use enumeration type instead of hard coding number

2018-12-24 Thread Julio Faracco
Looks good to me. Reviewed-by: Julio Faracco Em dom, 23 de dez de 2018 às 01:03, yuchenlin escreveu: > Signed-off-by: yuchenlin > --- > block/dmg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/block/dmg.c b/block/dmg.c > index 0e05702f5d..6b0a057bf8 100644 >

Re: [Qemu-devel] [PATCH v2 1/3] dmg: fix binary search

2018-12-24 Thread Julio Faracco
Looks good to me. Reviewed-by: Julio Faracco Em dom, 23 de dez de 2018 às 01:04, yuchenlin escreveu: > There is a possible hang in original binary search implementation. That is > if chunk1 = 4, chunk2 = 5, chunk3 = 4, and we go else case. > > The chunk1 will be still 4, and so on. > >

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/3] dmg: fixing reading in dmg

2018-12-24 Thread Julio Faracco
The series looks good to me. I tested with existing DMGs and DMGs that I created by myself. Both are working fine now. Reviewed-by: Julio Faracco Em dom, 23 de dez de 2018 às 01:01, yuchenlin escreveu: > There are two bugs in dmg reading. > > First, it may hang in binary search. this problem

Re: [Qemu-devel] [PATCH 0/2] optimize waiting for free thread to do compression(Internet mail)

2018-12-24 Thread xiaoguangrong(Xiao Guangrong)
On 12/21/18 4:11 PM, Peter Xu wrote: > On Thu, Dec 13, 2018 at 03:57:25PM +0800, guangrong.x...@gmail.com wrote: >> From: Xiao Guangrong >> >> Currently we have two behaviors if all threads are busy to do compression, >> the main thread mush wait one of them becoming free if @compress-wait-thread

Re: [Qemu-devel] [PATCH v1] migration: add incremental mode on drive-mirror

2018-12-24 Thread 滴滴云
I redescribe details on cover letter and send a new mail in December 20, 2018. Please help me review again, thank you. 在 2018/12/19 下午10:48,“Eric Blake” 写入: On 12/19/18 12:50 AM, mahaocong wrote: > From: mahaocong > > Signed-off-by: mahaocong The subject line tells

Re: [Qemu-devel] what is the behavier precisely if a tb was interrupted by a interrupt or signal?

2018-12-24 Thread Peter Maydell
On Mon, 24 Dec 2018 at 10:11, tugouxp <13824125...@163.com> wrote: > think about the scenario like that, a tb block contain 9 native > instructions execute sequentially > > if a interrupt or a signal happens before instruction 6 executed, did the > tb be finished before response to the

[Qemu-devel] How to view guest window with "ssh -Y"

2018-12-24 Thread Mahmood Naderan via Qemu-devel
Hi Without specifying -vnc option, I can view the guest window normally. However, when I use "ssh -Y compute-0-0" where I want to run qemu-system-x86_64 on a node, it gives me a vnc port. Is that normal? How can I fix it in order to view the the guest window by ssh X11 forwarding?

Re: [Qemu-devel] [PATCH] ui: vnc: finish removing TABs

2018-12-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20181217231629.24147-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20181217231629.24147-1-pbonz...@redhat.com Type: series Subject: [Qemu-devel] [PATCH] ui: vnc: finish

Re: [Qemu-devel] [QEMU-devel][PATCH v4 0/2] Fix concurrent aio_poll/set_fd_handler.

2018-12-24 Thread Remy NOEL
On 12/21/18 12:34 PM, Paolo Bonzini wrote: FWIW, I had missed the early version that used RCU, but lockcnt is already very RCU-like, so not using RCU is the right thing to do. The difference between lockcnt and RCU is that cleanup is done by the reader instead of a separate thread. Because we

[Qemu-devel] [RFC PATCH 1/1] hw/core: add qom getter for kernel-irqchip property

2018-12-24 Thread Wainer dos Santos Moschetta
Allows to access the kernel-irqchip property of a Machine Class object via QOM get method. Before this patch the property cannot be read although it is listed by qom-list: qemu-system-x86_64 -M q35,accel=kvm,kernel-irqchip=split (...) -> {"execute": "qom-list", "arguments": {"path": "/machine"}}

[Qemu-devel] [RFC PATCH 0/1] qom-get access to kernel-irqchip property

2018-12-24 Thread Wainer dos Santos Moschetta
On preparing to test Peter Xu's "q35: change defaults for kernel irqchip and IR" patch [1] I realized that kernel-irqchip property of the Machine Class object cannot be read via qom-get api. Actually there isn't such as kernel_irqchip property, rather it is a compound of kernel_irqchip_allowed,

[Qemu-devel] what is the behavier precisely if a tb was interrupted by a interrupt or signal?

2018-12-24 Thread tugouxp
hi folks: think about the scenario like that, a tb block contain 9 native instructions execute sequentially if a interrupt or a signal happens before instruction 6 executed, did the tb be finished before response to the interrupt or the exited at once to response the interrupt?

Re: [Qemu-devel] [PATCH v11 09/10] qcow2: skip writing zero buffers to empty COW areas

2018-12-24 Thread Vladimir Sementsov-Ogievskiy
24.12.2018 11:21, Anton Nefedov wrote: > On 21/12/2018 7:16 PM, Vladimir Sementsov-Ogievskiy wrote: >> 18.12.2018 10:57, Anton Nefedov wrote: >>> If COW areas of the newly allocated clusters are zeroes on the backing >>> image, >>> efficient bdrv_write_zeroes(flags=BDRV_REQ_ALLOCATE) can be used

Re: [Qemu-devel] [PATCH v6 09/11] iotests: change qmp_log filters to expect QMP objects only

2018-12-24 Thread Vladimir Sementsov-Ogievskiy
21.12.2018 23:13, John Snow wrote: > > > On 12/21/18 7:41 AM, Vladimir Sementsov-Ogievskiy wrote: >> Hmm. This made me check, is enumerate applicable to dicts, >> and, yes it is. >> > > enumerate on dicts gives you a numerical index paired with the key, > so... k is the numerical index and v is

Re: [Qemu-devel] [PATCH v11 09/10] qcow2: skip writing zero buffers to empty COW areas

2018-12-24 Thread Anton Nefedov
On 21/12/2018 7:16 PM, Vladimir Sementsov-Ogievskiy wrote: > 18.12.2018 10:57, Anton Nefedov wrote: >> If COW areas of the newly allocated clusters are zeroes on the backing image, >> efficient bdrv_write_zeroes(flags=BDRV_REQ_ALLOCATE) can be used on the whole >> cluster instead of writing

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-24 Thread Yi Zhang
On 2018-12-21 at 11:36:07 -0500, Michael S. Tsirkin wrote: > On Fri, Dec 21, 2018 at 11:18:18AM +0800, Yi Zhang wrote: > > On 2018-12-20 at 09:06:41 -0500, Michael S. Tsirkin wrote: > > > On Thu, Dec 20, 2018 at 01:37:40PM +0800, Yi Zhang wrote: > > > > On 2018-12-19 at 22:42:07 -0500, Michael S.