[Qemu-devel] Passing NFS volume on host to win7 guest

2018-12-28 Thread liebrecht
Hope I dont have to use samba for this. From reading online searches, it seems the following could work where backup is the nfs exported volume to be shared. -virtfs local,path=/backup,mount_tag=host0,security_model=passthrough,id=host0 qemu boots into win7 with this string added so it

Re: [Qemu-devel] [V9fs-developer] d_off field in struct dirent and 32-on-64 emulation

2018-12-28 Thread Dominique Martinet
Theodore Y. Ts'o wrote on Fri, Dec 28, 2018: > On Sat, Dec 29, 2018 at 03:37:21AM +0100, Dominique Martinet wrote: > > > Are there going to be cases where a process or a thread will sometimes > > > want the 64-bit interface, and sometimes want the 32-bit interface? > > > Or is it always going to

Re: [Qemu-devel] d_off field in struct dirent and 32-on-64 emulation

2018-12-28 Thread Theodore Y. Ts'o
On Sat, Dec 29, 2018 at 03:37:21AM +0100, Dominique Martinet wrote: > > Are there going to be cases where a process or a thread will sometimes > > want the 64-bit interface, and sometimes want the 32-bit interface? > > Or is it always going to be one or the other? I wonder if we could > > simply

Re: [Qemu-devel] d_off field in struct dirent and 32-on-64 emulation

2018-12-28 Thread Dominique Martinet
Theodore Y. Ts'o wrote on Fri, Dec 28, 2018: > > The problem is that there is no 32-bit API in some cases > > (unless I have misunderstood the kernel code) -- not all > > host architectures implement compat syscalls or allow them > > to be called from 64-bit processes or implement all the older >

Re: [Qemu-devel] d_off field in struct dirent and 32-on-64 emulation

2018-12-28 Thread Theodore Y. Ts'o
On Fri, Dec 28, 2018 at 11:18:18AM +, Peter Maydell wrote: > In general inodes and offsets start from 0 and work up -- > so almost all of the time they don't actually overflow. > The problem with ext4 directory hash "offsets" is that they > overflow all the time and immediately, so instead of

Re: [Qemu-devel] d_off field in struct dirent and 32-on-64 emulation

2018-12-28 Thread Matthew Wilcox
On Sat, Dec 29, 2018 at 12:12:27AM +, Peter Maydell wrote: > On Fri, 28 Dec 2018 at 23:16, Andreas Dilger wrot > > On Dec 28, 2018, at 4:18 AM, Peter Maydell wrote: > > > The problem is that there is no 32-bit API in some cases > > > (unless I have misunderstood the kernel code) -- not all >

Re: [Qemu-devel] [PATCH] i386: mark the 'INTEL_PT' CPUID bit as unmigratable

2018-12-28 Thread Eduardo Habkost
On Fri, Dec 28, 2018 at 02:53:22PM +0100, Paolo Bonzini wrote: > On 25/12/18 09:23, Kang, Luwei wrote: > >> From: Qemu-devel > >> [mailto:qemu-devel-bounces+luwei.kang=intel@nongnu.org] On Behalf Of > >> Paolo Bonzini > >> Sent: Friday, December 21, 2018 8:44 PM > >> To:

Re: [Qemu-devel] [PATCH v3 1/2] intel-iommu: differentiate host address width from IOVA address width.

2018-12-28 Thread Eduardo Habkost
On Fri, Dec 28, 2018 at 10:32:59AM +0800, Yu Zhang wrote: > On Thu, Dec 27, 2018 at 01:14:11PM -0200, Eduardo Habkost wrote: > > On Wed, Dec 26, 2018 at 01:30:00PM +0800, Yu Zhang wrote: > > > On Tue, Dec 25, 2018 at 11:56:19AM -0500, Michael S. Tsirkin wrote: > > > > On Sat, Dec 22, 2018 at

Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches

2018-12-28 Thread Programmingkid
> On Dec 28, 2018, at 7:19 PM, Zoltán Kővágó wrote: > > On 2018-12-29 01:12, Programmingkid wrote: >> >>> On Dec 28, 2018, at 3:05 PM, Kővágó Zoltán wrote: >>> >>> On 2018-12-28 01:46, Programmingkid wrote: > On Dec 27, 2018, at 8:33 AM, Kővágó Zoltán wrote: > > Hi,

Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches

2018-12-28 Thread Programmingkid
> On Dec 28, 2018, at 3:05 PM, Kővágó Zoltán wrote: > > On 2018-12-28 01:46, Programmingkid wrote: >> >>> On Dec 27, 2018, at 8:33 AM, Kővágó Zoltán wrote: >>> >>> Hi, >>> >>> I've pushed it to my github (modulo some random fixes not yet on the >>> mailing list): >>>

Re: [Qemu-devel] d_off field in struct dirent and 32-on-64 emulation

2018-12-28 Thread Peter Maydell
On Fri, 28 Dec 2018 at 23:16, Andreas Dilger wrot > On Dec 28, 2018, at 4:18 AM, Peter Maydell wrote: > > The problem is that there is no 32-bit API in some cases > > (unless I have misunderstood the kernel code) -- not all > > host architectures implement compat syscalls or allow them > > to be

Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches

2018-12-28 Thread Zoltán Kővágó
On 2018-12-29 01:12, Programmingkid wrote: > >> On Dec 28, 2018, at 3:05 PM, Kővágó Zoltán wrote: >> >> On 2018-12-28 01:46, Programmingkid wrote: >>> On Dec 27, 2018, at 8:33 AM, Kővágó Zoltán wrote: Hi, I've pushed it to my github (modulo some random fixes not yet on

Re: [Qemu-devel] d_off field in struct dirent and 32-on-64 emulation

2018-12-28 Thread Andreas Dilger
On Dec 28, 2018, at 4:18 AM, Peter Maydell wrote: > > On Fri, 28 Dec 2018 at 00:23, Andreas Dilger wrote: >> On Dec 27, 2018, at 10:41 AM, Peter Maydell wrote: >>> As you note, this causes breakage for userspace programs which >>> need to implement an API/ABI with 32-bit offset but which only

[Qemu-devel] [Bug 1810000] [NEW] qemu system emulator crashed with the attachment of usb-bt-dongle device

2018-12-28 Thread PH
Public bug reported: I am testing usb-bt-dongle device on xchi host controller, and found that the qemu crashed directly with an assertion failer. Here is the information to reproduce the crash: Qemu git revision: 9b2e891ec5ccdb4a7d583b77988848282606fdea System emulator: qemu-x86_64 VM image:

[Qemu-devel] [PATCH 0/5 v2] RISC-V: Add gdb xml files and gdbstub support.

2018-12-28 Thread Jim Wilson
This is the second version of the patch set. I haven't gotten any bug reports for the patches in the several weeks that they have been available, and no review yet, so the only significant difference from the first version is that I ran them through checkpatch to fix style issues, and I sent them

[Qemu-devel] [PATCH 1/5 v2] RISC-V: Add 32-bit gdb xml files.

2018-12-28 Thread Jim Wilson
Signed-off-by: Jim Wilson --- configure | 1 + gdb-xml/riscv-32bit-cpu.xml | 43 gdb-xml/riscv-32bit-csr.xml | 250 gdb-xml/riscv-32bit-fpu.xml | 46 4 files changed, 340 insertions(+) create mode 100644

[Qemu-devel] [PATCH 4/5 v2] RISC-V: Add debug support for accessing CSRs.

2018-12-28 Thread Jim Wilson
Adds a debugger parameter to csr_read_helper and csr_write_helper. When this is true, we disable illegal instruction checks. Signed-off-by: Jim Wilson --- linux-user/riscv/signal.c | 5 ++- target/riscv/cpu.h| 7 +++- target/riscv/cpu_helper.c | 4 +- target/riscv/gdbstub.c| 4

[Qemu-devel] [PATCH 2/5 v2] RISC-V: Add 64-bit gdb xml files.

2018-12-28 Thread Jim Wilson
Signed-off-by: Jim Wilson --- configure | 1 + gdb-xml/riscv-64bit-cpu.xml | 43 gdb-xml/riscv-64bit-csr.xml | 250 gdb-xml/riscv-64bit-fpu.xml | 52 + 4 files changed, 346 insertions(+) create mode 100644

[Qemu-devel] [PATCH 5/5 v2] RISC-V: Add hooks to use the gdb xml files.

2018-12-28 Thread Jim Wilson
Signed-off-by: Jim Wilson --- target/riscv/cpu.c | 9 ++- target/riscv/gdbstub.c | 73 -- 2 files changed, 73 insertions(+), 9 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index a025a0a..b248e3e 100644 ---

[Qemu-devel] [PATCH 3/5 v2] RISC-V: Map gdb CSR reg numbers to hw reg numbers.

2018-12-28 Thread Jim Wilson
The gdb CSR xml file has registers in documentation order, not numerical order, so we need a table to map the register numbers. This also adds some missing CSR_* register macros. Signed-off-by: Jim Wilson --- target/riscv/cpu_bits.h | 35 ++- target/riscv/csr-map.h | 248

Re: [Qemu-devel] AVX support for TCG

2018-12-28 Thread Alex Bennée
On Fri, 28 Dec 2018, 13:46 Nick Renieris > Another question, are there existing discussions about this > refactoring effort or specifically AVX? I asked a similar question on > IRC a few days ago and got no answers. > You might want to try again next week. Most QEMU hackers are away for the

Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches

2018-12-28 Thread Kővágó Zoltán
On 2018-12-28 01:46, Programmingkid wrote: > >> On Dec 27, 2018, at 8:33 AM, Kővágó Zoltán wrote: >> >> Hi, >> >> I've pushed it to my github (modulo some random fixes not yet on the >> mailing list): >> https://github.com/DirtYiCE/qemu/tree/audio-51-2018 >> >> I don't have a mac so I have no

[Qemu-devel] [PATCH] qmp: Add examples to qom list, get, and set commands

2018-12-28 Thread Wainer dos Santos Moschetta
Added examples for the qom-list, qom-get, and qom-set commands in qapi misc JSON file. Signed-off-by: Wainer dos Santos Moschetta --- qapi/misc.json | 36 1 file changed, 36 insertions(+) diff --git a/qapi/misc.json b/qapi/misc.json index

[Qemu-devel] [PATCH v4 3/5] hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays

2018-12-28 Thread Philippe Mathieu-Daudé
GCC 8 added a -Wstringop-truncation warning: The -Wstringop-truncation warning added in GCC 8.0 via r254630 for bug 81117 is specifically intended to highlight likely unintended uses of the strncpy function that truncate the terminating NUL character from the source string. This new

[Qemu-devel] [PATCH v4 4/5] migration: Fix stringop-truncation warning

2018-12-28 Thread Philippe Mathieu-Daudé
From: Marc-André Lureau GCC 8 added a -Wstringop-truncation warning: The -Wstringop-truncation warning added in GCC 8.0 via r254630 for bug 81117 is specifically intended to highlight likely unintended uses of the strncpy function that truncate the terminating NUL character from the

[Qemu-devel] [PATCH v4 1/5] qemu/compiler: Define QEMU_NONSTRING

2018-12-28 Thread Philippe Mathieu-Daudé
GCC 8 introduced the -Wstringop-truncation checker to detect truncation by the strncat and strncpy functions (closely related to -Wstringop-overflow, which detect buffer overflow by string-modifying functions declared in ). In tandem of -Wstringop-truncation, the "nonstring" attribute was added:

[Qemu-devel] [PATCH v4 0/5] Fix strncpy() warnings for GCC8 new -Wstringop-truncation

2018-12-28 Thread Philippe Mathieu-Daudé
GCC 8 new warning prevents builds to success since quite some time. First report on the mailing list is in July 2018: https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03723.html Since v3: - patch 1: make sens of description (eblake) - patch 2: append QEMU_NONSTRING instead of prepending

[Qemu-devel] [PATCH v4 2/5] block/sheepdog: Use QEMU_NONSTRING for non NUL-terminated arrays

2018-12-28 Thread Philippe Mathieu-Daudé
GCC 8 added a -Wstringop-truncation warning: The -Wstringop-truncation warning added in GCC 8.0 via r254630 for bug 81117 is specifically intended to highlight likely unintended uses of the strncpy function that truncate the terminating NUL character from the source string. This new

[Qemu-devel] [PATCH v4 5/5] migration: Use strnlen() for fixed-size string

2018-12-28 Thread Philippe Mathieu-Daudé
GCC 8 introduced the -Wstringop-overflow, which detect buffer overflow by string-modifying functions declared in , such strncpy(), used in global_state_store_running(). GCC indeed found an incorrect use of strlen(), because this array is loaded by VMSTATE_BUFFER(runstate, GlobalState) then parsed

Re: [Qemu-devel] d_off field in struct dirent and 32-on-64 emulation

2018-12-28 Thread Andy Lutomirski
[sending again, slightly edited, due to email client issues] On Thu, Dec 27, 2018 at 9:25 AM Florian Weimer wrote: > > We have a bit of an interesting problem with respect to the d_off > field in struct dirent. > > When running a 64-bit kernel on certain file systems, notably ext4, > this field

Re: [Qemu-devel] [PATCH v2 6/8] tests: smbios: fetch whole table in one step instead of reading it step by step

2018-12-28 Thread Philippe Mathieu-Daudé
On 12/27/18 3:13 PM, Igor Mammedov wrote: > replace a bunch of ACPI_READ_ARRAY/ACPI_READ_FIELD macro, that read > SMBIOS table field by field with one memread() to fetch whole table > at once and drop no longer used ACPI_READ_ARRAY/ACPI_READ_FIELD macro. > > Signed-off-by: Igor Mammedov

Re: [Qemu-devel] AVX support for TCG

2018-12-28 Thread Nick Renieris
Στις Παρ, 28 Δεκ 2018 στις 4:39 μ.μ., ο/η Peter Maydell έγραψε: > If your editor can't show multiple views onto one file with > the same simplicity and UI as it has for multiple different > files then I would suggest getting a better editor :-) Apparently I just didn't know how to use my editor

Re: [Qemu-devel] [RFC PATCH 04/13] tests/tcg/mips: enable mips32-dsp/mips32-dspr2/mipsr5900 linux-user (WIP)

2018-12-28 Thread Aleksandar Markovic
> Will you be testing the build as is with the current Makefiles? I will, but they should be replaced with your versions - in new directories. v1 of my reorganization series seems to be broken on the list for some reason, but I will send v2 (hopefully more complete and improved) after New Year.

Re: [Qemu-devel] [PATCH] smbus_eeprom: Limit data writes to 255 bytes

2018-12-28 Thread Michael Hanselmann
Hi Paolo On 28.12.18 14:52, Paolo Bonzini wrote: > On 27/12/18 12:51, Michael Hanselmann wrote: >> The "eeprom_write_data" function in "smbus_eeprom.c" had no provisions >> to limit the length of data written. If a caller were able to manipulate >> the "len" parameter they could potentially write

Re: [Qemu-devel] [PATCH] smbus_eeprom: Limit data writes to 255 bytes

2018-12-28 Thread Michael Hanselmann
Hi Philippe On 27.12.18 20:03, Philippe Mathieu-Daudé wrote: > On Thu, Dec 27, 2018 at 12:53 PM Michael Hanselmann wrote: > The "eeprom_write_data" function in "smbus_eeprom.c" had no provisions > to limit the length of data written. If a caller were able to manipulate > the "len" parameter

Re: [Qemu-devel] [PATCH v3 06/16] virtio: split virtio 9p bits from virtio-pci

2018-12-28 Thread Greg Kurz
On Thu, 13 Dec 2018 22:00:47 +0100 Juan Quintela wrote: > Reviewed-by: Laurent Vivier > Signed-off-by: Juan Quintela > > --- > Acked-by: Greg Kurz > Also disable virtio9p test (lvivier) > --- > hw/virtio/Makefile.objs | 1 + > hw/virtio/virtio-9p-pci.c | 86

Re: [Qemu-devel] [PATCH v3 16/16] virtio: virtio 9p really requires CONFIG_VIRTFS to work

2018-12-28 Thread Greg Kurz
On Thu, 13 Dec 2018 22:00:57 +0100 Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- Reviewed-by: Greg Kurz > default-configs/virtio.mak | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/default-configs/virtio.mak b/default-configs/virtio.mak > index

[Qemu-devel] [Bug 1795100] Re: unix-domain socket unlink()ed prematurely

2018-12-28 Thread LukeShu
This is still a problem with 3.1.0. ** Summary changed: - unix-domain socket unlink()ed prematurely + VNC unix-domain socket unlink()ed prematurely -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] AVX support for TCG

2018-12-28 Thread Peter Maydell
On Fri, 28 Dec 2018 at 14:28, Nick Renieris wrote: > Right, thanks, that file looks better, though I still think splitting > to multiple files would absolutely be of value, if only for the > practicality of being able to have several parts of it open at the > same in a code editor (instead of

[Qemu-devel] [PATCH] dmg: Fixing wrong dmg block type value for block terminator.

2018-12-28 Thread Julio Faracco
This is a trivial patch to fix a wrong value for block terminator. The old value was 0x7fff which is wrong. It was not affecting the code because QEMU dmg block is not handling block terminator right now. Neverthless, it should be fixed. Signed-off-by: Julio Faracco --- block/dmg.c | 2 +-

Re: [Qemu-devel] AVX support for TCG

2018-12-28 Thread Nick Renieris
Right, thanks, that file looks better, though I still think splitting to multiple files would absolutely be of value, if only for the practicality of being able to have several parts of it open at the same in a code editor (instead of having to jump back and forth or find workarounds to open the

Re: [Qemu-devel] [PATCH 2/4] Add CET SHSTK and IBT CPUID feature-word definitions.

2018-12-28 Thread Paolo Bonzini
On 26/12/18 09:25, Yang Weijiang wrote: > @@ -1233,6 +1252,14 @@ static const ExtSaveArea x86_ext_save_areas[] = { >{ .feature = FEAT_7_0_ECX, .bits = CPUID_7_0_ECX_PKU, > .offset = offsetof(X86XSaveArea, pkru_state), > .size = sizeof(XSavePKRU) }, > +

Re: [Qemu-devel] AVX support for TCG

2018-12-28 Thread Peter Maydell
On Fri, 28 Dec 2018 at 13:45, Nick Renieris wrote: > Also, I hope you meant four months for me, not for you - I'm > completely new to the QEMU codebase. I expect it will take me weeks > just to understand x86's 'translate.c' (who thought it'd be a good > idea to put all this stuff in _one_

[Qemu-devel] [PATCH v2 2/8] target/ppc: rework vmrg{l, h}{b, h, w} instructions to use Vsr* macros

2018-12-28 Thread Mark Cave-Ayland
The current implementations make use of the endian-specific macros MRGLO/MRGHI and also reference HI_IDX and LO_IDX directly to calculate array offsets. Rework the implementation to use the Vsr* macros so that these per-endian references can be removed. Signed-off-by: Mark Cave-Ayland ---

[Qemu-devel] [PATCH v2 3/8] target/ppc: rework vmul{e, o}{s, u}{b, h, w} instructions to use Vsr* macros

2018-12-28 Thread Mark Cave-Ayland
The current implementations make use of the endian-specific macros HI_IDX and LO_IDX directly to calculate array offsets. Rework the implementation to use the Vsr* macros so that these per-endian references can be removed. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson ---

Re: [Qemu-devel] [PATCH 3/6] target/ppc: rework vmul{e, o}{s, u}{b, h, w} instructions to use Vsr* macros

2018-12-28 Thread Mark Cave-Ayland
On 25/12/2018 20:11, Richard Henderson wrote: > On 12/23/18 10:38 PM, Mark Cave-Ayland wrote: >> -#define VMUL_DO(name, mul_element, prod_element, cast, evenp) \ >> +#define VMUL_DO_EVN(name, mul_element, mul_access, prod_access, cast) \ >> void helper_v##name(ppc_avr_t *r,

Re: [Qemu-devel] [PATCH] smbus_eeprom: Limit data writes to 255 bytes

2018-12-28 Thread Paolo Bonzini
On 27/12/18 12:51, Michael Hanselmann wrote: > The "eeprom_write_data" function in "smbus_eeprom.c" had no provisions > to limit the length of data written. If a caller were able to manipulate > the "len" parameter they could potentially write before or after the > target buffer. > --- >

[Qemu-devel] [PATCH v2 4/8] target/ppc: eliminate use of HI_IDX and LO_IDX macros from int_helper.c

2018-12-28 Thread Mark Cave-Ayland
The original purpose of these macros was to correctly reference the high and low parts of the VSRs regardless of the host endianness. Replace these direct references to high and low parts with the relevant VsrD macro instead, and completely remove the now-unused HI_IDX and LO_IDX macros.

[Qemu-devel] [PATCH v2 8/8] target/ppc: remove various HOST_WORDS_BIGENDIAN hacks in int_helper.c

2018-12-28 Thread Mark Cave-Ayland
Following on from the previous work, there are numerous endian-related hacks in int_helper.c that can now be replaced with Vsr* macros. There are also a few places where the VECTOR_FOR_INORDER_I macro can be replaced with a normal iterator since the processing order is irrelevant. Signed-off-by:

[Qemu-devel] [PATCH v2 5/8] target/ppc: eliminate use of EL_IDX macros from int_helper.c

2018-12-28 Thread Mark Cave-Ayland
These macros can be eliminated by instead using the relavant Vsr* macros in the few locations where they appear. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson --- target/ppc/int_helper.c | 66 - 1 file changed, 27 insertions(+),

[Qemu-devel] [PATCH v2 6/8] target/ppc: simplify VEXT_SIGNED macro in int_helper.c

2018-12-28 Thread Mark Cave-Ayland
As pointed out by Richard: it does not need the mask argument, nor does it need the recast argument. The masking is implied by the cast argument, and the recast is implied by the assignment. Signed-off-by: Mark Cave-Ayland --- target/ppc/int_helper.c | 14 +++--- 1 file changed, 7

Re: [Qemu-devel] [PATCH] i386: mark the 'INTEL_PT' CPUID bit as unmigratable

2018-12-28 Thread Paolo Bonzini
On 25/12/18 09:23, Kang, Luwei wrote: >> From: Qemu-devel [mailto:qemu-devel-bounces+luwei.kang=intel@nongnu.org] >> On Behalf Of Paolo Bonzini >> Sent: Friday, December 21, 2018 8:44 PM >> To: qemu-devel@nongnu.org >> Cc: ehabk...@redhat.com; qemu-sta...@nongnu.org >> Subject: [Qemu-devel]

[Qemu-devel] [PATCH v2 7/8] target/ppc: remove ROTRu32 and ROTRu64 macros from int_helper.c

2018-12-28 Thread Mark Cave-Ayland
Richard points out that these macros suffer from a -fsanitize=shift bug in that they improperly handle n == 0 turning it into a shift by 32/64 respectively. Replace them with QEMU's existing ror32() and ror64() functions instead. Signed-off-by: Mark Cave-Ayland --- target/ppc/int_helper.c | 48

[Qemu-devel] [PATCH v2 0/8] target/ppc: remove various endian hacks from int_helper.c

2018-12-28 Thread Mark Cave-Ayland
>From working on the TCG vector operations patchset, it is apparent that there are a large number of endian-based hacks in int_helper.c which can be removed by making use of the various Vsr* macros. Patch 1 is simple enough, and implements the complete set of Vsr* macros for both big endian and

Re: [Qemu-devel] [Qemu-block] do not lseek in qcow2 block_status

2018-12-28 Thread Paolo Bonzini
On 25/12/18 10:45, Vladimir Sementsov-Ogievskiy wrote: >> >> What are the cases, when we really need digging for zeros in bs->file? It's needed for preallocation=metadata. Paolo

[Qemu-devel] [PATCH v2 1/8] target/ppc: implement complete set of Vsr* macros

2018-12-28 Thread Mark Cave-Ayland
This prepares us for eliminating the use of direct array access within the VMX instruction implementations. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson --- target/ppc/internal.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/target/ppc/internal.h

Re: [Qemu-devel] AVX support for TCG

2018-12-28 Thread Nick Renieris
>> Do you think this could work as a GSoC project? I'm potentially >> interested in working on it this summer. >Could be. My first guess is something like 4 months work for this. Four months full-time? If so I would say it's not viable for a GSoC project (it's 3 months), I've done the

Re: [Qemu-devel] d_off field in struct dirent and 32-on-64 emulation

2018-12-28 Thread Adhemerval Zanella
On 28/12/2018 10:01, Florian Weimer wrote: > * Florian Weimer: > >> * Adhemerval Zanella: >> >>> On 27/12/2018 16:09, Florian Weimer wrote: * Adhemerval Zanella: > Also for glibc standpoint, although reverting it back to use getdents > syscall for non-LFS mode might fix this

Re: [Qemu-devel] d_off field in struct dirent and 32-on-64 emulation

2018-12-28 Thread Adhemerval Zanella
On 27/12/2018 16:09, Florian Weimer wrote: > * Adhemerval Zanella: > >> Also for glibc standpoint, although reverting it back to use getdents >> syscall for non-LFS mode might fix this issue for architectures that >> provides non-LFS getdents syscall it won't be a fix for architectures >>

Re: [Qemu-devel] d_off field in struct dirent and 32-on-64 emulation

2018-12-28 Thread Florian Weimer
* Adhemerval Zanella: > On 27/12/2018 16:09, Florian Weimer wrote: >> * Adhemerval Zanella: >> >>> Also for glibc standpoint, although reverting it back to use getdents >>> syscall for non-LFS mode might fix this issue for architectures that >>> provides non-LFS getdents syscall it won't be a

Re: [Qemu-devel] d_off field in struct dirent and 32-on-64 emulation

2018-12-28 Thread Florian Weimer
* Florian Weimer: > * Adhemerval Zanella: > >> On 27/12/2018 16:09, Florian Weimer wrote: >>> * Adhemerval Zanella: >>> Also for glibc standpoint, although reverting it back to use getdents syscall for non-LFS mode might fix this issue for architectures that provides non-LFS

Re: [Qemu-devel] [PATCH v3 1/2] intel-iommu: differentiate host address width from IOVA address width.

2018-12-28 Thread Igor Mammedov
On Thu, 27 Dec 2018 12:54:02 -0200 Eduardo Habkost wrote: > On Fri, Dec 21, 2018 at 03:13:25PM +0100, Igor Mammedov wrote: > > On Thu, 20 Dec 2018 19:18:01 -0200 > > Eduardo Habkost wrote: > > > > > On Wed, Dec 19, 2018 at 11:40:37AM +0100, Igor Mammedov wrote: > > > > On Wed, 19 Dec 2018

Re: [Qemu-devel] d_off field in struct dirent and 32-on-64 emulation

2018-12-28 Thread Peter Maydell
On Fri, 28 Dec 2018 at 00:23, Andreas Dilger wrote: > On Dec 27, 2018, at 10:41 AM, Peter Maydell wrote: > > As you note, this causes breakage for userspace programs which > > need to implement an API/ABI with 32-bit offset but which only > > have access to the kernel's 64-bit offset API/ABI. >

Re: [Qemu-devel] [RFC PATCH 04/13] tests/tcg/mips: enable mips32-dsp/mips32-dspr2/mipsr5900 linux-user (WIP)

2018-12-28 Thread Alex Bennée
Aleksandar Markovic writes: > HI, Alex, just a heads up that I plan to submit directory and file > reorganization of tests/tcg/mips mini patch series today or tomorrow. > Aleksandar My current tree state is: https://github.com/stsquad/qemu/tree/testing/enable-system-tcg-tests-v2 But I'm

[Qemu-devel] [PULL 32/41] disas: nanoMIPS: Rename the decoder of 'gpr2.reg2' gpr encoding type

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename the decoder of 'gpr2.reg2' gpr encoding type in nanoMIPS disassembler. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 6 +++--- disas/nanomips.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PULL 34/41] disas: nanoMIPS: Rename the decoder of 'gpr1' gpr encoding type

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename the decoder of 'gpr1' gpr encoding type in nanoMIPS disassembler. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 4 ++-- disas/nanomips.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PULL 37/41] disas: nanoMIPS: Add a note on documentation

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Add "nanoMIPS32 Instruction Set Technical Reference Manual" as a reference. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git a/disas/nanomips.cpp b/disas/nanomips.cpp

[Qemu-devel] [PULL 41/41] tests/tcg: mips: Test R5900 three-operand MADDU1

2018-12-28 Thread Aleksandar Markovic
From: Fredrik Noring Test R5900 three-operand MADDU1. Reviewed-by: Aleksandar Markovic Signed-off-by: Aleksandar Markovic Signed-off-by: Fredrik Noring --- tests/tcg/mips/mipsr5900/maddu.c | 37 +++-- 1 file changed, 35 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PULL 40/41] tests/tcg: mips: Test R5900 three-operand MADDU

2018-12-28 Thread Aleksandar Markovic
From: Fredrik Noring Test R5900 three-operand MADDU. Reviewed-by: Aleksandar Markovic Signed-off-by: Aleksandar Markovic Signed-off-by: Fredrik Noring --- tests/tcg/mips/mipsr5900/Makefile | 1 + tests/tcg/mips/mipsr5900/maddu.c | 37 + 2 files changed,

[Qemu-devel] [PULL 30/41] disas: nanoMIPS: Rename the decoder of 'gpr2.reg1' gpr encoding type

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename the decoder of 'gpr2.reg1' gpr encoding type in nanoMIPS disassembler. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 6 +++--- disas/nanomips.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PULL 33/41] disas: nanoMIPS: Comment the decoder of 'gpr2.reg2' gpr encoding type

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Comment the decoder of 'gpr2.reg2' gpr encoding type in nanoMIPS disassembler. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 22 ++ 1 file changed, 22 insertions(+) diff --git a/disas/nanomips.cpp

[Qemu-devel] [PULL 36/41] disas: nanoMIPS: Reorder declarations and definitions of gpr decoders

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Reorder declarations and definitions of gpr decoders by number of input bits of corresponding encoding type. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 200 ++---

Re: [Qemu-devel] [PATCH 0/2] tests: Reorganize MIPS TCG directories and files

2018-12-28 Thread Aleksandar Markovic
> From: Philippe Mathieu-Daudé on behalf of > Philippe Mathieu-Daudé > Subject: Re: [Qemu-devel] [PATCH 0/2] tests: Reorganize MIPS TCG directories > and files > > Hi Aleksandar, > > It seems the list ate your patch 1/2... Thanks for bringing this to my attention, but not a big deal, I will

[Qemu-devel] [PULL 39/41] tests/tcg: mips: Test R5900 three-operand MADD1

2018-12-28 Thread Aleksandar Markovic
From: Fredrik Noring Test R5900 three-operand MADD1. Reviewed-by: Aleksandar Markovic Signed-off-by: Aleksandar Markovic Signed-off-by: Fredrik Noring --- tests/tcg/mips/mipsr5900/madd.c | 43 - 1 file changed, 38 insertions(+), 5 deletions(-) diff

[Qemu-devel] [PULL 31/41] disas: nanoMIPS: Comment the decoder of 'gpr2.reg1' gpr encoding type

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Comment the decoder of 'gpr2.reg1' gpr encoding type in nanoMIPS disassembler. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 22 ++ 1 file changed, 22 insertions(+) diff --git a/disas/nanomips.cpp

[Qemu-devel] [PULL 29/41] disas: nanoMIPS: Comment the decoder of 'gpr4.zero' gpr encoding type

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Comment the decoder of 'gpr4.zero' gpr encoding type in nanoMIPS disassembler. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 27 +++ 1 file changed, 27 insertions(+) diff --git

[Qemu-devel] [PULL 35/41] disas: nanoMIPS: Comment the decoder of 'gpr1' gpr encoding type

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Comment the decoder of 'gpr1' gpr encoding type in nanoMIPS disassembler. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 21 + 1 file changed, 21 insertions(+) diff --git a/disas/nanomips.cpp

[Qemu-devel] [PULL 18/41] disas: nanoMIPS: Fix an FP-related misnomer 2

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename NMD::extract_fs_15_14_13_12_11(uint64 instruction) to NMD::extract_fs_20_19_18_17_16(uint64 instruction). Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 242 ++---

[Qemu-devel] [PULL 16/41] disas: nanoMIPS: Name some functions in a more descriptive way

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename some functions that have names that are hard to understand. Reviewed-by: Aleksandar Rikalo Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 112 ++--- disas/nanomips.h

[Qemu-devel] [PULL 19/41] disas: nanoMIPS: Fix an FP-related misnomer 3

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename NMD::extract_ft_20_19_18_17_16(uint64 instruction) to NMD::extract_ft_25_24_23_22_21(uint64 instruction). Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 258 ++---

[Qemu-devel] [PULL 22/41] disas: nanoMIPS: Rename the decoder of 'gpr3' gpr encoding type

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename the decoder of 'gpr3' gpr encoding type in nanoMIPS disassembler. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 96 +++--- disas/nanomips.h | 2 +- 2 files

[Qemu-devel] [PULL 20/41] disas: nanoMIPS: Name more functions in a more descriptive way

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename more functions that have names that are hard to understand. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 212 ++--- disas/nanomips.h | 28 +++ 2 files

[Qemu-devel] [PULL 17/41] disas: nanoMIPS: Fix an FP-related misnomer 1

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename NMD::extract_fd_10_9_8_7_6(uint64 instruction) to NMD::extract_fd_15_14_13_12_11(uint64 instruction). Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 142 ++---

[Qemu-devel] [PULL 27/41] disas: nanoMIPS: Comment the decoder of 'gpr4' gpr encoding type

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Comment the decoder of 'gpr4' gpr encoding type in nanoMIPS disassembler. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 26 ++ 1 file changed, 26 insertions(+) diff --git a/disas/nanomips.cpp

[Qemu-devel] [PULL 21/41] disas: nanoMIPS: Fix order of more invocations

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix order of extraction function invocations so that extraction goes from MSB side to LSB side of the given instruction coding content. This is desireable because of consistency and easier visual spotting of errors. After this patch, all such invocations should be in

[Qemu-devel] [PULL 24/41] disas: nanoMIPS: Rename the decoder of 'gpr3.src.store' gpr encoding type

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename the decoder of 'gpr3.src.store' gpr encoding type in nanoMIPS disassembler. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 10 +- disas/nanomips.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-)

[Qemu-devel] [PULL 28/41] disas: nanoMIPS: Rename the decoder of 'gpr4.zero' gpr encoding type

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename the decoder of 'gpr4.zero' gpr encoding type in nanoMIPS disassembler. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 10 +- disas/nanomips.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff

[Qemu-devel] [PULL 14/41] disas: nanoMIPS: Fix a function misnomer

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix wrong function name. The convention in these files is that names of extraction functions should reflect bit patterns they are extracting. Reviewed-by: Aleksandar Rikalo Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 264

[Qemu-devel] [PULL 38/41] tests/tcg: mips: Test R5900 three-operand MADD

2018-12-28 Thread Aleksandar Markovic
From: Fredrik Noring Test R5900 three-operand MADD. Reviewed-by: Aleksandar Markovic Signed-off-by: Aleksandar Markovic Signed-off-by: Fredrik Noring --- tests/tcg/mips/mipsr5900/Makefile | 1 + tests/tcg/mips/mipsr5900/madd.c | 45 +++ 2 files

[Qemu-devel] [PULL 26/41] disas: nanoMIPS: Rename the decoder of 'gpr4' gpr encoding type

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename the decoder of 'gpr4' gpr encoding type in nanoMIPS disassembler. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 20 ++-- disas/nanomips.h | 2 +- 2 files changed, 11 insertions(+), 11

[Qemu-devel] [PULL 12/41] disas: nanoMIPS: Fix preamble text in nanomips.* files

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix several mistakes in preambles of nanomips disassembler source files. Reviewed-by: Aleksandar Rikalo Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 7 --- disas/nanomips.h | 7 --- 2 files changed, 8

[Qemu-devel] [PULL 00/41] MIPS pull request for December 2018

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic The following changes since commit 9b2e891ec5ccdb4a7d583b77988848282606fdea: Merge remote-tracking branch 'remotes/marcel/tags/rdma-pull-request' into staging (2018-12-22 11:25:31 +) are available in the git repository at: https://github.com/AMarkovic/qemu

[Qemu-devel] [PULL 23/41] disas: nanoMIPS: Comment the decoder of 'gpr3' gpr encoding type

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Comment the decoder of 'gpr3' gpr encoding type in nanoMIPS disassembler. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 51 --- 1 file changed, 48 insertions(+), 3

[Qemu-devel] [PULL 04/41] MAINTAINERS: Add Aleksandar Rikalo as a reviewer for MIPS content

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Add Aleksandar Rikalo as a reviewer for MIPS content. Aleksandar brings to us more than six years of experience in working on a variety of development tools for MIPS architectures, and will greatly help QEMU community understand and support intricacies of MIPS better.

[Qemu-devel] [PULL 25/41] disas: nanoMIPS: Comment the decoder of 'gpr3.src.store' gpr encoding type

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Comment the decoder of 'gpr3.src.store' gpr encoding type in nanoMIPS disassembler. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 32 1 file changed, 32 insertions(+) diff --git

[Qemu-devel] [PULL 01/41] MAINTAINERS: target/mips: Add MIPS files under default-configs directory

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Add following files as maintained within the main MIPS target section in MAINTAINERS: default-configs/mips64el-linux-user.mak default-configs/mips64-linux-user.mak default-configs/mipsn32el-linux-user.mak default-configs/mipsn32-linux-user.mak

[Qemu-devel] [PULL 07/41] target/mips: MXU: Add generic naming for optn2 constants

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Add generic naming involving generig suffixes OPTN0, OPTN1, OPTN2, OPTN3 for four optn2 constants. Existing suffixes WW, LW, HW, XW are not quite appropriate for some instructions using optn2. Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic ---

[Qemu-devel] [PULL 06/41] target/mips: MXU: Add missing opcodes/decoding for LX* instructions

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Add missing opcodes and decoding engine for LXB, LXH, LXW, LXBU, and LXHU instructions. They were for some reason forgotten in previous commits. The MXU opcode list and decoding engine should be now complete. Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar

[Qemu-devel] [PULL 13/41] disas: nanoMIPS: Remove functions that are not used

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Some functions were not used at all. Compiler doesn't complain since they are class memebers. Remove them - no future usage is planned. Reviewed-by: Aleksandar Rikalo Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 208

[Qemu-devel] [PULL 08/41] target/mips: MXU: Improve the comment containing MXU overview

2018-12-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Improve textual description of MXU extension. These are mostly comment formatting changes. Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 74 + 1 file changed, 44

  1   2   >