Re: [Qemu-devel] [PATCH] microbit: make -kernel optional

2019-01-02 Thread Stefan Hajnoczi
On Fri, Dec 14, 2018 at 02:51:52PM +, Stefan Hajnoczi wrote: > ARMv7M machine types support -kernel for ELF and raw image files. > Microbit programs are typically in Intel HEX (.hex) format. The generic > loader supports .hex files but it doesn't work as expected: > > $ qemu-system-arm -M

[Qemu-devel] Q: nested virtualization and VMX live migration

2019-01-02 Thread Syrone Wong
Hi all, The VMX live migration blocker is added via https://github.com/qemu/qemu/commit/d98f26073bebddcd3da0ba1b86c3a34e840c0fb8, it claims "Nested VMX does not support live migration yet". While a commit from Linux 4.20 states > With live migration support and finally a good solution for

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add some missing SPARC-related files

2019-01-02 Thread Thomas Huth
On 2019-01-02 20:34, Philippe Mathieu-Daudé wrote: > Hi Thomas, > > On 1/2/19 4:46 PM, Thomas Huth wrote: >> These files / devices are only used by SPARC machines, so we can sort >> them into the corresponding categories in the MAINTAINERS file. >> >> Signed-off-by: Thomas Huth >> --- >>

Re: [Qemu-devel] [PATCH v2 0/1] drive-mirror: add incremental mode

2019-01-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190102100415.24680-1-mahaocong_w...@163.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [Qemu-devel] [PATCH v2 0/1] drive-mirror: add incremental mode

2019-01-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190102100415.24680-1-mahaocong_w...@163.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [Qemu-devel] [PATCH 09/10] spapr: introduce a new sPAPR IRQ backend supporting XIVE and XICS

2019-01-02 Thread David Gibson
On Wed, Jan 02, 2019 at 06:57:42AM +0100, Cédric Le Goater wrote: > The 'dual' sPAPR IRQ backend supports both interrupt mode, XIVE > exploitation mode and the legacy compatibility mode (XICS). both modes > are not supported at the same time. > > The machine starts with the legacy mode and a new

Re: [Qemu-devel] [PATCH 08/10] ppc/xics: allow ICSState to have an offset 0

2019-01-02 Thread David Gibson
On Wed, Jan 02, 2019 at 06:57:41AM +0100, Cédric Le Goater wrote: > commit 15ed653fa49a ("ppc/xics: An ICS with offset 0 is assumed to be > uninitialized") introduced an extra check on the ICS offset which is > not strictly necessary. The commit message for that suggests it was added to make pnv

Re: [Qemu-devel] [PATCH 03/15] pci: allow cleanup/unregistration of PCI root buses

2019-01-02 Thread David Gibson
On Wed, Jan 02, 2019 at 10:27:14PM -0500, Michael S. Tsirkin wrote: > On Thu, Jan 03, 2019 at 11:36:33AM +1100, David Gibson wrote: > > On Fri, Dec 21, 2018 at 11:19:18AM -0500, Michael S. Tsirkin wrote: > > > On Fri, Dec 21, 2018 at 01:35:30AM +0100, Greg Kurz wrote: > > > > From: Michael Roth >

Re: [Qemu-devel] [PATCH for-4.0 v9 10/16] qemu_thread: supplement error handling for h_resize_hpt_prepare

2019-01-02 Thread David Gibson
On Wed, Jan 02, 2019 at 02:44:17PM +0800, 李菲 wrote: > > 在 2019/1/2 上午10:36, David Gibson 写道: > > On Tue, Dec 25, 2018 at 10:04:43PM +0800, Fei Li wrote: > > > Add a local_err to hold the error, and return the corresponding > > > error code to replace the temporary _abort. > > > > > > Cc: Markus

Re: [Qemu-devel] [PATCH 02/10] ppc/xive: introduce a XiveTCTX pointer under PowerPCCPU

2019-01-02 Thread David Gibson
On Wed, Jan 02, 2019 at 06:57:35AM +0100, Cédric Le Goater wrote: > which will be used by the machine only when the XIVE interrupt mode is > in use. I don't love the idea of putting a hook this specific into the PowerPCCPU structure, though it might be the easiest path in the short term. A

Re: [Qemu-devel] [PATCH 04/10] spapr/xive: simplify the sPAPR IRQ qirq method for XIVE

2019-01-02 Thread David Gibson
On Wed, Jan 02, 2019 at 06:57:37AM +0100, Cédric Le Goater wrote: > The qirq routines of the XiveSource and the sPAPRXive model are only > used under the sPAPR IRQ backend. Simplify the overall call stack and > gather all the code under spapr_qirq_xive(). It will ease future > changes. > >

Re: [Qemu-devel] [PATCH v2 1/3] tests: vhost-user-test: initialize 'fd' in chr_read

2019-01-02 Thread Li Qiang
Thomas Huth 于2019年1月2日周三 下午9:50写道: > On 2018-12-15 13:03, Li Qiang wrote: > > Currently when processing VHOST_USER_SET_VRING_CALL > > if 'qemu_chr_fe_get_msgfds' get no fd, the 'fd' will > > be a stack uninitialized value. > > > > Signed-off-by: Li Qiang > > --- > > tests/vhost-user-test.c | 2

Re: [Qemu-devel] [PATCH 03/15] pci: allow cleanup/unregistration of PCI root buses

2019-01-02 Thread Michael S. Tsirkin
On Thu, Jan 03, 2019 at 11:36:33AM +1100, David Gibson wrote: > On Fri, Dec 21, 2018 at 11:19:18AM -0500, Michael S. Tsirkin wrote: > > On Fri, Dec 21, 2018 at 01:35:30AM +0100, Greg Kurz wrote: > > > From: Michael Roth > > > > > > This adds cleanup counterparts to pci_register_root_bus(), > > >

Re: [Qemu-devel] [PATCH 15/15] spapr: add hotplug hooks for PHB hotplug

2019-01-02 Thread David Gibson
On Fri, Dec 21, 2018 at 07:36:12AM +0100, Greg Kurz wrote: > From: Michael Roth > > Hotplugging PHBs is a machine-level operation, but PHBs reside on the > main system bus, so we register spapr machine as the handler for the > main system bus. > > We re-get the phandle of the interrupt

Re: [Qemu-devel] [PATCH 14/15] spapr: Expose the name of the interrupt controller node

2019-01-02 Thread David Gibson
On Fri, Dec 21, 2018 at 10:53:13AM +0100, Greg Kurz wrote: > On Fri, 21 Dec 2018 09:12:24 +0100 > Cédric Le Goater wrote: > > > On 12/21/18 7:35 AM, Greg Kurz wrote: > > > This will be needed by PHB hotplug in order to access the phandle > > > property. > > > > > > Signed-off-by: Greg Kurz

Re: [Qemu-devel] [PATCH 03/15] pci: allow cleanup/unregistration of PCI root buses

2019-01-02 Thread David Gibson
On Fri, Dec 21, 2018 at 11:19:18AM -0500, Michael S. Tsirkin wrote: > On Fri, Dec 21, 2018 at 01:35:30AM +0100, Greg Kurz wrote: > > From: Michael Roth > > > > This adds cleanup counterparts to pci_register_root_bus(), > > pci_root_bus_new(), and pci_bus_irqs(). > > > > These cleanup routines

Re: [Qemu-devel] [PATCH 2/8] sam460ex: Clean up SPD EEPROM creation

2019-01-02 Thread David Gibson
On Wed, Jan 02, 2019 at 01:49:44PM +0100, BALATON Zoltan wrote: > On Wed, 2 Jan 2019, David Gibson wrote: > > On Wed, Jan 02, 2019 at 03:06:38AM +0100, BALATON Zoltan wrote: > > > +/* IIC controllers and devices */ > > > dev = sysbus_create_simple(TYPE_PPC4xx_I2C, 0x4ef600700, uic[0][2]);

Re: [Qemu-devel] [PATCH 06/15] spapr: enable PHB hotplug for default pseries machine type

2019-01-02 Thread David Gibson
On Fri, Dec 21, 2018 at 01:36:32AM +0100, Greg Kurz wrote: > From: Michael Roth > > The 'dr_phb_enabled' field of that class can be set as part of > machine-specific init code. It will be used to conditionally > enable creation of DRC objects and device-tree description to > facilitate hotplug

Re: [Qemu-devel] [PATCH 04/15] spapr_pci: add proper rollback on PHB realize error path

2019-01-02 Thread David Gibson
On Fri, Dec 21, 2018 at 01:35:52AM +0100, Greg Kurz wrote: > The current realize code assumes the PHB is coldplugged, ie, QEMU will > terminate if an error is detected, and does not bother to free anything > it has already allocated. > > In order to support PHB hotplug, let's first ensure

Re: [Qemu-devel] [PATCH 07/15] spapr_pci: Define SPAPR_MAX_PHBS in hw/pci-host/spapr.h

2019-01-02 Thread David Gibson
On Fri, Dec 21, 2018 at 01:36:53AM +0100, Greg Kurz wrote: > PHB hotplug will bring more users for it. Let's define it along with > the PHB defines from which it is derived for simplicity. > > While here fix a misleading comment about manual placement, which was > abandoned with 30b3bc5aa9f4. >

Re: [Qemu-devel] [PATCH 01/15] ppc/spapr: Receive and store device tree blob from SLOF

2019-01-02 Thread David Gibson
On Fri, Dec 21, 2018 at 01:34:48AM +0100, Greg Kurz wrote: > From: Alexey Kardashevskiy > > SLOF receives a device tree and updates it with various properties > before switching to the guest kernel and QEMU is not aware of any changes > made by SLOF. Since there is no real RTAS (QEMU implements

Re: [Qemu-devel] [PATCH 02/15] spapr: move spapr_create_phb() to core machine code

2019-01-02 Thread David Gibson
On Fri, Dec 21, 2018 at 01:35:09AM +0100, Greg Kurz wrote: > This function is only used when creating the default PHB. Let's rename > it and move it to the core machine code for clarity. > > Signed-off-by: Greg Kurz > Reviewed-by: Alexey Kardashevskiy > Reviewed-by: David Gibson Applied to

Re: [Qemu-devel] [PATCH 1/8] smbus: Add a helper to generate SPD EEPROM data

2019-01-02 Thread David Gibson
On Wed, Jan 02, 2019 at 01:36:04PM +0100, BALATON Zoltan wrote: > On Wed, 2 Jan 2019, David Gibson wrote: > > On Wed, Jan 02, 2019 at 03:06:38AM +0100, BALATON Zoltan wrote: > > > There are several boards with SPD EEPROMs that are now using > > > duplicated or slightly different hard coded data.

Re: [Qemu-devel] About live migration rollback

2019-01-02 Thread Gonglei (Arei)
Hi, > > * Gonglei (Arei) (arei.gong...@huawei.com) wrote: > > Hi Dave, > > > > We discussed some live migration fallback scenarios in this year's KVM > > forum, > > and now I can provide another scenario, perhaps the upstream should > consider rolling > > back for this situation. > > > >

Re: [Qemu-devel] [PATCH] MAINTAINERS: add qemu_vga.ndrv file entry for Mac machines

2019-01-02 Thread David Gibson
On Wed, Jan 02, 2019 at 10:22:43AM +, Mark Cave-Ayland wrote: > The VGA driver built from Ben's QemuMacDrivers repository is used exclusively > by the Mac machines. > > Signed-off-by: Mark Cave-Ayland Applied, thanks. > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff

Re: [Qemu-devel] [PATCH v5 0/9] target/ppc: prepare for conversion to TCG vector operations

2019-01-02 Thread David Gibson
On Wed, Jan 02, 2019 at 09:14:14AM +, Mark Cave-Ayland wrote: > This patchset is an attempt at trying to improve the VMX (Altivec) instruction > performance by laying the groundwork for use of the new TCG vector operations. > > Patches 1 and 2 fix a sign-extension error discovered in

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add some missing ppc-related files

2019-01-02 Thread David Gibson
On Wed, Jan 02, 2019 at 04:57:56PM +0100, Thomas Huth wrote: > hw/gpio/mpc8xxx.c is only used by the e500 machine, so add it there. > And the hw/input/adb* files are specific to the Mac machines, so > they should be assigned to these categories. > > Signed-off-by: Thomas Huth Applied to

Re: [Qemu-devel] [PATCH] qemu-io: Reinitialize optind correctly before parsing inner command.

2019-01-02 Thread Eric Blake
On 12/30/18 12:09 PM, Richard W.M. Jones wrote: > On FreeBSD 11.2: > > $ ./qemu-io -f raw -c "aio_write 0 512" "nbd:localhost:10809" > Parsing error: non-numeric argument, or extraneous/unrecognized suffix -- > aio_write > > After main option parsing, we reinitialize optind so we can parse

[Qemu-devel] [Bug 1810343] [NEW] qemu-nbd -l and -s options don't work together

2019-01-02 Thread Michael
Public bug reported: When using qemu-nbd with -l to load a snapshot along with -s to create new active layer the tool fails to find the snapshot specified on the command line: For example the following does not work: sudo qemu-nbd -s --load-snapshot=files --connect /dev/nbd0 rootfs.qcow2

Re: [Qemu-devel] [PULL 00/42] tcg queued patches

2019-01-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20181225205529.10874-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181225205529.10874-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PULL

Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating

2019-01-02 Thread Eric Blake
On 1/2/19 12:01 PM, Christophe Fergeau wrote: > Adding Markus to cc: list, I forgot to do it when sending the patch. Also worth backporting via qemu-stable, now in cc. > > Christophe > > On Wed, Jan 02, 2019 at 03:05:35PM +0100, Christophe Fergeau wrote: >> commit 8bca4613 added support for %%

Re: [Qemu-devel] [PATCH 09/21] configure: use pkg-config for obtaining xen version

2019-01-02 Thread Stefano Stabellini
On Tue, 11 Dec 2018, Daniel wrote: > On Tue, Dec 11, 2018 at 10:34:52AM +, Peter Maydell wrote: > > On Tue, 25 Apr 2017 at 19:35, Stefano Stabellini > > wrote: > > > > > > From: Juergen Gross > > > > > > Instead of trying to guess the Xen version to use by compiling various > > > test

Re: [Qemu-devel] [PATCH v15 23/26] sched: early boot clock

2019-01-02 Thread Salvatore Bonaccorso
Hi, On Tue, Nov 06, 2018 at 06:35:36AM -0500, Steven Sistare wrote: > Pavel has a new email address, cc'd - steve > > On 11/6/2018 12:42 AM, Dominique Martinet wrote: > > (added various kvm/virtualization lists in Cc as well as qemu as I don't > > know who's "wrong" here) > > > > Pavel Tatashin

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add some missing SPARC-related files

2019-01-02 Thread Philippe Mathieu-Daudé
Hi Thomas, On 1/2/19 4:46 PM, Thomas Huth wrote: > These files / devices are only used by SPARC machines, so we can sort > them into the corresponding categories in the MAINTAINERS file. > > Signed-off-by: Thomas Huth > --- > MAINTAINERS | 6 +- > 1 file changed, 5 insertions(+), 1

Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating

2019-01-02 Thread Christophe Fergeau
Adding Markus to cc: list, I forgot to do it when sending the patch. Christophe On Wed, Jan 02, 2019 at 03:05:35PM +0100, Christophe Fergeau wrote: > commit 8bca4613 added support for %% in json strings when interpolating, > but in doing so, this broke handling of % when not interpolating as the

Re: [Qemu-devel] [PATCH 0/3] cutils: Cleanup, improve documentation

2019-01-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20181226171538.21984-1-phi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181226171538.21984-1-phi...@redhat.com Subject: [Qemu-devel] [PATCH 0/3] cutils: Cleanup,

[Qemu-devel] [PATCH] MAINTAINERS: Add some missing ppc-related files

2019-01-02 Thread Thomas Huth
hw/gpio/mpc8xxx.c is only used by the e500 machine, so add it there. And the hw/input/adb* files are specific to the Mac machines, so they should be assigned to these categories. Signed-off-by: Thomas Huth --- MAINTAINERS | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff

Re: [Qemu-devel] [PATCH v2 0/1] drive-mirror: add incremental mode

2019-01-02 Thread Eric Blake
On 1/2/19 4:04 AM, mahaocong wrote: > From: mahaocong > > This patch adds possibility to start mirroring with user-created-bitmap. > Compare with v1, this patch fix some shortcomings. > 1.separate feature about copy dirty-bitmap to an individual patch. > 2.remove checking for cancelled after

Re: [Qemu-devel] [PATCH v2 1/1] drive-mirror: add incremental mode

2019-01-02 Thread Eric Blake
On 1/2/19 4:04 AM, mahaocong wrote: > From: mahaocong > > Signed-off-by: mahaocong The subject line says "what" changed, but you are missing a commit body that says "why" the change is useful. Much of the content in your cover letter should be copied into this commit body, as the cover letter

[Qemu-devel] [PATCH] MAINTAINERS: Add some missing SPARC-related files

2019-01-02 Thread Thomas Huth
These files / devices are only used by SPARC machines, so we can sort them into the corresponding categories in the MAINTAINERS file. Signed-off-by: Thomas Huth --- MAINTAINERS | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [Qemu-devel] [PATCH v4 0/5] Fix strncpy() warnings for GCC8 new -Wstringop-truncation

2019-01-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20181228173356.15359-1-phi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181228173356.15359-1-phi...@redhat.com Subject: [Qemu-devel] [PATCH v4 0/5] Fix strncpy()

[Qemu-devel] [Bug 1809665] Re: Xbox One controller USB passthrough disconnections and stops

2019-01-02 Thread Saverio Miroddi
So! These are the options and respective logs; they still don't make the controller work - it doesn't work at all. # option 1 -device nec-usb-xhci \ -device usb-tablet \ -device usb-host,vendorid=0x$VGAPT_XBOX_PAD_VEND_ID,productid=0x$VGAPT_XBOX_PAD_PROD_ID \ # log libusb: error

Re: [Qemu-devel] [PATCH v2 3/3] util: check the return value of fcntl in qemu_set_{block, nonblock}

2019-01-02 Thread Michael S. Tsirkin
On Wed, Jan 02, 2019 at 03:07:24PM +0100, Thomas Huth wrote: > On 2018-12-15 13:03, Li Qiang wrote: > > Assert that the return value is not an error. This is like commit > > 7e6478e7d4f for qemu_set_cloexec. > > > > Signed-off-by: Li Qiang > > --- > > util/oslib-posix.c | 8 ++-- > > 1 file

Re: [Qemu-devel] [PATCH v2 1/3] tests: vhost-user-test: initialize 'fd' in chr_read

2019-01-02 Thread Michael S. Tsirkin
On Wed, Jan 02, 2019 at 02:50:50PM +0100, Thomas Huth wrote: > On 2018-12-15 13:03, Li Qiang wrote: > > Currently when processing VHOST_USER_SET_VRING_CALL > > if 'qemu_chr_fe_get_msgfds' get no fd, the 'fd' will > > be a stack uninitialized value. > > > > Signed-off-by: Li Qiang > > --- > >

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add ARM-related files for hw/[misc|input|timer]/

2019-01-02 Thread Thomas Huth
On 2019-01-02 15:42, Philippe Mathieu-Daudé wrote: > On 1/2/19 1:53 PM, Thomas Huth wrote: >> Some of the files in hw/input/, hw/misc/ and hw/timer/ are only >> used by one of the ARM machines, so we can assign these files to >> the corresponding boards. >> >> Signed-off-by: Thomas Huth >> --- >>

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add ARM-related files for hw/[misc|input|timer]/

2019-01-02 Thread Philippe Mathieu-Daudé
On 1/2/19 1:53 PM, Thomas Huth wrote: > Some of the files in hw/input/, hw/misc/ and hw/timer/ are only > used by one of the ARM machines, so we can assign these files to > the corresponding boards. > > Signed-off-by: Thomas Huth > --- > MAINTAINERS | 16 ++-- > 1 file changed, 14

Re: [Qemu-devel] [PATCH] cpus: ignore ESRCH in qemu_cpu_kick_thread()

2019-01-02 Thread Philippe Mathieu-Daudé
On 1/2/19 3:16 PM, Laurent Vivier wrote: > We can have a race condition between qemu_cpu_kick_thread() and > qemu_kvm_cpu_thread_fn() when we hotunplug a CPU. In this case, > qemu_cpu_kick_thread() can try to kick a thread that is exiting. > pthread_kill() returns an error and qemu is stopped by

[Qemu-devel] [Bug 1795100] Re: VNC unix-domain socket unlink()ed prematurely

2019-01-02 Thread Dr. David Alan Gilbert
Added Daniel to the bug. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1795100 Title: VNC unix-domain socket unlink()ed prematurely Status in QEMU: New Bug description: With qemu 3.0.0 (I

Re: [Qemu-devel] [Qemu-block] [PATCH] dmg: fix binary search

2019-01-02 Thread Julio Faracco
Hi Stefan, I created a simple DMG file from MacOS to reproduce the problem: https://bugs.launchpad.net/qemu/+bug/1809304 Em qua, 2 de jan de 2019 às 08:47, Stefan Hajnoczi escreveu: > On Fri, Dec 21, 2018 at 09:58:03PM +0800, yuchenlin wrote: > > There is a possible hang in original binary

[Qemu-devel] [PATCH] cpus: ignore ESRCH in qemu_cpu_kick_thread()

2019-01-02 Thread Laurent Vivier
We can have a race condition between qemu_cpu_kick_thread() and qemu_kvm_cpu_thread_fn() when we hotunplug a CPU. In this case, qemu_cpu_kick_thread() can try to kick a thread that is exiting. pthread_kill() returns an error and qemu is stopped by an exit(1). qemu:qemu_cpu_kick_thread: No such

Re: [Qemu-devel] [PATCH] dmg: Fixing wrong dmg block type value for block terminator.

2019-01-02 Thread Stefan Hajnoczi
On Fri, Dec 28, 2018 at 12:50:55PM -0200, Julio Faracco wrote: > This is a trivial patch to fix a wrong value for block terminator. > The old value was 0x7fff which is wrong. It was not affecting the > code because QEMU dmg block is not handling block terminator right now. > Neverthless, it

Re: [Qemu-devel] [PATCH v2 3/3] util: check the return value of fcntl in qemu_set_{block, nonblock}

2019-01-02 Thread Thomas Huth
On 2018-12-15 13:03, Li Qiang wrote: > Assert that the return value is not an error. This is like commit > 7e6478e7d4f for qemu_set_cloexec. > > Signed-off-by: Li Qiang > --- > util/oslib-posix.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git

[Qemu-devel] [PATCH] json: Fix % handling when not interpolating

2019-01-02 Thread Christophe Fergeau
commit 8bca4613 added support for %% in json strings when interpolating, but in doing so, this broke handling of % when not interpolating as the '%' is skipped in both cases. This commit ensures we only try to handle %% when interpolating. Signed-off-by: Christophe Fergeau ---

Re: [Qemu-devel] [PATCH] scripts/qemugdb: support coroutine backtrace in coredumps

2019-01-02 Thread Stefan Hajnoczi
On Thu, Dec 27, 2018 at 05:36:04PM +, Vladimir Sementsov-Ogievskiy wrote: > 23.04.2018 16:28, Pedro Alves wrote: > > On 04/23/2018 02:37 AM, Simon Marchi wrote: > >> On 2018-04-09 10:08 PM, Stefan Hajnoczi wrote: > >>> I wonder what the point of select-frame is then... > >>> > >>> I have CCed

Re: [Qemu-devel] [PATCH for-4.0 v9 00/16] qemu_thread_create: propagate the error to callers to handle

2019-01-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20181225140449.15786-1-...@suse.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH v2 1/3] tests: vhost-user-test: initialize 'fd' in chr_read

2019-01-02 Thread Thomas Huth
On 2018-12-15 13:03, Li Qiang wrote: > Currently when processing VHOST_USER_SET_VRING_CALL > if 'qemu_chr_fe_get_msgfds' get no fd, the 'fd' will > be a stack uninitialized value. > > Signed-off-by: Li Qiang > --- > tests/vhost-user-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH v2 0/8] tests: apci: consolidate and cleanup ACPI test code

2019-01-02 Thread Michael S. Tsirkin
On Wed, Jan 02, 2019 at 02:11:23PM +0100, Thomas Huth wrote: > On 2018-12-27 15:13, Igor Mammedov wrote: > > Changes since v1: > > * rebase on top of current master due to a lots of conflicts with > > 'qtest global' removal being merged first > > Sorry for that ... I hope it was not too

Re: [Qemu-devel] live migration

2019-01-02 Thread Dr. David Alan Gilbert
* ? ? (zach_tur...@outlook.com) wrote: > > Hello, I have a question I would like to ask. > If I add the -incoming parameter when starting the qemu virtual machine, the > virtual machine will block all the time, waiting for the migration connection > request to arrive. > I want to modify the

Re: [Qemu-devel] [RFC v2 4/4] pvh: Boot uncompressed kernel using direct boot ABI

2019-01-02 Thread Stefan Hajnoczi
On Fri, Dec 21, 2018 at 08:03:52PM +, Liam Merwick wrote: > @@ -1336,7 +1470,7 @@ void pc_memory_init(PCMachineState *pcms, > int linux_boot, i; > MemoryRegion *ram, *option_rom_mr; > MemoryRegion *ram_below_4g, *ram_above_4g; > -FWCfgState *fw_cfg; > +FWCfgState *fw_cfg

Re: [Qemu-devel] d_off field in struct dirent and 32-on-64 emulation

2019-01-02 Thread Adhemerval Zanella
On 31/12/2018 15:03, Joseph Myers wrote: > On Fri, 28 Dec 2018, Adhemerval Zanella wrote: > Currently we only have nios2 and csky (unfortunately). But since generic definition for off_t and off64_t still assumes non-LFS support, all new 32-bits ports potentially might carry

Re: [Qemu-devel] [RFC v2 2/4] elf-ops.h: Add get_elf_note_type()

2019-01-02 Thread Stefan Hajnoczi
On Fri, Dec 21, 2018 at 08:03:50PM +, Liam Merwick wrote: > +while (note_type != elf_note_type) { > +nhdr_namesz = nhdr->n_namesz; > +nhdr_descsz = nhdr->n_descsz; > + > +elf_note_entry_offset = nhdr_size + > +QEMU_ALIGN_UP(nhdr_namesz, phdr_align) + > +

Re: [Qemu-devel] [PATCH v2 0/8] tests: apci: consolidate and cleanup ACPI test code

2019-01-02 Thread Thomas Huth
On 2018-12-27 15:13, Igor Mammedov wrote: > Changes since v1: > * rebase on top of current master due to a lots of conflicts with > 'qtest global' removal being merged first Sorry for that ... I hope it was not too much trouble! > * drop explicit cast to uint8_t* as sdt->aml is uint8_t*

Re: [Qemu-devel] [RFC v2 1/4] elf: Add optional function ptr to load_elf() to parse ELF notes

2019-01-02 Thread Stefan Hajnoczi
On Fri, Dec 21, 2018 at 08:03:49PM +, Liam Merwick wrote: > diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops.h > index 74679ff8da3a..37d20a3800c1 100644 > --- a/include/hw/elf_ops.h > +++ b/include/hw/elf_ops.h > @@ -266,6 +266,7 @@ fail: > } > > static int glue(load_elf, SZ)(const

[Qemu-devel] [PATCH] MAINTAINERS: Add ARM-related files for hw/[misc|input|timer]/

2019-01-02 Thread Thomas Huth
Some of the files in hw/input/, hw/misc/ and hw/timer/ are only used by one of the ARM machines, so we can assign these files to the corresponding boards. Signed-off-by: Thomas Huth --- MAINTAINERS | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS

Re: [Qemu-devel] [PATCH 2/8] sam460ex: Clean up SPD EEPROM creation

2019-01-02 Thread BALATON Zoltan
On Wed, 2 Jan 2019, David Gibson wrote: On Wed, Jan 02, 2019 at 03:06:38AM +0100, BALATON Zoltan wrote: +/* IIC controllers and devices */ dev = sysbus_create_simple(TYPE_PPC4xx_I2C, 0x4ef600700, uic[0][2]); -i2c[0] = PPC4xx_I2C(dev); -object_property_set_bool(OBJECT(dev),

Re: [Qemu-devel] [PATCH v2 3/3] dmg: don't skip zero chunk

2019-01-02 Thread Stefan Hajnoczi
On Sun, Dec 23, 2018 at 10:59:39AM +0800, yuchenlin wrote: > The dmg file has many tables which describe: "start from sector XXX to > sector XXX, the compression method is XXX and where the compressed data > resides on". > > Each sector in the expanded file should be covered by a table. The table

Re: [Qemu-devel] [PATCH 1/8] smbus: Add a helper to generate SPD EEPROM data

2019-01-02 Thread BALATON Zoltan
On Wed, 2 Jan 2019, David Gibson wrote: On Wed, Jan 02, 2019 at 03:06:38AM +0100, BALATON Zoltan wrote: There are several boards with SPD EEPROMs that are now using duplicated or slightly different hard coded data. Add a helper to generate SPD data for a memory module of given type and size

Re: [Qemu-devel] [PATCH v2 1/3] dmg: fix binary search

2019-01-02 Thread 林育辰
Hi, Stefan Thank you for your reviewing. This series is focus on fixing bug #1809304 (see: https://bugs.launchpad.net/qemu/+bug/1809304). There is an example dmg file in #1809304 which will trigger this bug. About your case, I think we can simply check whether chunk3 is zero before we decrease

Re: [Qemu-devel] [PATCH v4 5/5] migration: Use strnlen() for fixed-size string

2019-01-02 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > GCC 8 introduced the -Wstringop-overflow, which detect buffer overflow > by string-modifying functions declared in , such strncpy(), > used in global_state_store_running(). > > GCC indeed found an incorrect use of strlen(), because this array

Re: [Qemu-devel] [PATCH v2 2/3] dmg: use enumeration type instead of hard coding number

2019-01-02 Thread Stefan Hajnoczi
On Sun, Dec 23, 2018 at 10:59:38AM +0800, yuchenlin wrote: > Signed-off-by: yuchenlin > --- > block/dmg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH v2 1/3] dmg: fix binary search

2019-01-02 Thread Stefan Hajnoczi
On Sun, Dec 23, 2018 at 10:59:37AM +0800, yuchenlin wrote: > There is a possible hang in original binary search implementation. That is > if chunk1 = 4, chunk2 = 5, chunk3 = 4, and we go else case. > > The chunk1 will be still 4, and so on. > > Signed-off-by: yuchenlin > --- > block/dmg.c | 6

Re: [Qemu-devel] [PATCH v3 4/5] migration: Use QEMU_NONSTRING for non NUL-terminated arrays

2019-01-02 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > GCC 8 added a -Wstringop-truncation warning: > > The -Wstringop-truncation warning added in GCC 8.0 via r254630 for > bug 81117 is specifically intended to highlight likely unintended > uses of the strncpy function that truncate the

Re: [Qemu-devel] About live migration rollback

2019-01-02 Thread Dr. David Alan Gilbert
* Gonglei (Arei) (arei.gong...@huawei.com) wrote: > Hi Dave, > > We discussed some live migration fallback scenarios in this year's KVM forum, > and now I can provide another scenario, perhaps the upstream should consider > rolling > back for this situation. > > Environments information: > >

Re: [Qemu-devel] [PATCH] gitdm: Add other IBMers

2019-01-02 Thread Andrew Jeffery
On Wed, 2 Jan 2019, at 21:36, Joel Stanley wrote: > Here are some IBMers who use their personal addresses when submitting > patches. > > Signed-off-by: Joel Stanley For the addition of my address: Acked-by: Andrew Jeffery > --- > contrib/gitdm/group-map-ibm | 5 + > 1 file changed, 5

[Qemu-devel] [Bug 1810000] Re: qemu system emulator crashed with the attachment of usb-bt-dongle device

2019-01-02 Thread Thomas Huth
Thanks for the bug report! Unfortunately, the bluetooth code in QEMU is completely unmaintained and quite bit-rotten already, so it is already marked as deprecated and will be removed soon unless somebody steps up and volunteers to maintain it:

[Qemu-devel] [PATCH 1/1] include: Auto-generate the sizes lookup table

2019-01-02 Thread Leonid Bloch
The lookup table for power-of-two sizes is now auto-generated during the build, and not hard-coded into the units.h file. Signed-off-by: Leonid Bloch --- .gitignore | 1 + Makefile | 5 +++ block/qcow2.h| 2 +- block/vdi.c | 1 + include/qemu/units.h |

[Qemu-devel] [PATCH 0/1] include: Auto-generate the sizes lookup table

2019-01-02 Thread Leonid Bloch
Following the conversations here: https://patchwork.kernel.org/patch/10665157 and here: https://patchwork.kernel.org/patch/10666975 Making the lookup table for power-of-two sizes auto-generated, instead of being hard-coded into the units.h file. I'm not sure if the changes I've made to Makefile

[Qemu-devel] [PATCH] gitdm: Add other IBMers

2019-01-02 Thread Joel Stanley
Here are some IBMers who use their personal addresses when submitting patches. Signed-off-by: Joel Stanley --- contrib/gitdm/group-map-ibm | 5 + 1 file changed, 5 insertions(+) diff --git a/contrib/gitdm/group-map-ibm b/contrib/gitdm/group-map-ibm index b66db5f4a825..6c0570107d65 100644

[Qemu-devel] [Bug 1793275] Re: Hosts fail to start after update to QEMU 3.0

2019-01-02 Thread Thomas Huth
Ok, thanks for the update. Closing this bug since it seems to be fixed in 3.1. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1793275 Title:

[Qemu-devel] [Bug 1809665] Re: Xbox One controller USB passthrough disconnections and stops

2019-01-02 Thread Thomas Huth
Do you get a different behavior if you use "-device usb-ehci" or "-device nec-usb-xhci" instead of the "-usb" parameter? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1809665 Title: Xbox One

Re: [Qemu-devel] [PATCH] MAINTAINERS: add qemu_vga.ndrv file entry for Mac machines

2019-01-02 Thread Philippe Mathieu-Daudé
On 1/2/19 11:22 AM, Mark Cave-Ayland wrote: > The VGA driver built from Ben's QemuMacDrivers repository is used exclusively > by the Mac machines. > > Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff

Re: [Qemu-devel] [PATCH] qom: cpu: destroy work_mutex in cpu_common_finalize

2019-01-02 Thread Philippe Mathieu-Daudé
On 1/2/19 8:41 AM, Li Qiang wrote: > Commit 376692b9dc6(cpus: protect work list with work_mutex) > initialize a work_mutex in cpu_common_initfn, however forget > to destroy it. This will cause resource leak when hotunplug cpu > or hotplug cpu fails. > Long standing leak ;) Maybe add: Fixes:

Re: [Qemu-devel] [PATCH for-4.0 v9 10/16] qemu_thread: supplement error handling for h_resize_hpt_prepare

2019-01-02 Thread 李菲
在 2019/1/2 上午10:36, David Gibson 写道: On Tue, Dec 25, 2018 at 10:04:43PM +0800, Fei Li wrote: Add a local_err to hold the error, and return the corresponding error code to replace the temporary _abort. Cc: Markus Armbruster Cc: David Gibson Signed-off-by: Fei Li This looks like a good

Re: [Qemu-devel] Patchew down?

2019-01-02 Thread Philippe Mathieu-Daudé
On 1/2/19 2:17 AM, Fam Zheng wrote: >> On Dec 30, 2018, at 08:09, Philippe Mathieu-Daudé wrote: >> >> I think patchew is having some trouble since at least 1 week: >> new series aren't added. > > Thanks for the reminder, Phil. I fixed https on patches.org but forgot to > switch the importer

Re: [Qemu-devel] [PATCH] dmg: fix binary search

2019-01-02 Thread Stefan Hajnoczi
On Fri, Dec 21, 2018 at 09:58:03PM +0800, yuchenlin wrote: > There is a possible hang in original binary searsh implemtation. That is > if chunk1 = 4, chunk2 = 5, chunk3 = 4, and we go else case. > > The chunk1 will be still 4, and so on. > > Signed-off-by: yuchenlin > --- > block/dmg.c | 6

[Qemu-devel] [PATCH] MAINTAINERS: add qemu_vga.ndrv file entry for Mac machines

2019-01-02 Thread Mark Cave-Ayland
The VGA driver built from Ben's QemuMacDrivers repository is used exclusively by the Mac machines. Signed-off-by: Mark Cave-Ayland --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 344cb2d7fd..3da3d103b1 100644 --- a/MAINTAINERS +++

Re: [Qemu-devel] [PATCH v3 09/16] virtio: split vhost scsi bits from virtio-pci

2019-01-02 Thread Stefan Hajnoczi
On Fri, Dec 14, 2018 at 10:19:38AM +0100, Thomas Huth wrote: > On 2018-12-13 22:00, Juan Quintela wrote: > > Reviewed-by: Laurent Vivier > > Signed-off-by: Juan Quintela > > --- > > hw/virtio/Makefile.objs| 1 + > > hw/virtio/vhost-scsi-pci.c | 95 ++ > >

[Qemu-devel] [PATCH v2 1/1] drive-mirror: add incremental mode

2019-01-02 Thread mahaocong
From: mahaocong Signed-off-by: mahaocong --- block/mirror.c| 55 --- blockdev.c| 37 +-- include/block/block_int.h | 3 ++- qapi/block-core.json | 9 +++- 4 files changed, 88

[Qemu-devel] [PATCH v2 0/1] drive-mirror: add incremental mode

2019-01-02 Thread mahaocong
From: mahaocong This patch adds possibility to start mirroring with user-created-bitmap. Compare with v1, this patch fix some shortcomings. 1.separate feature about copy dirty-bitmap to an individual patch. 2.remove checking for cancelled after mirror_dirty_init_incremental for bitmap copyimg

[Qemu-devel] [PATCH v1] add new function to copy dirty-bitmap

2019-01-02 Thread mahaocong
From: mahaocong This patch adds new function to copy the hbitmap from an exist dirty-bitmap to another. The destination bitmap should have the same size and granularity with the source bitmap, or the copy will fail. Signed-off-by: mahaocong --- block/dirty-bitmap.c | 14 ++

[Qemu-devel] [PATCH v5 8/9] target/ppc: move FP and VMX registers into aligned vsr register array

2019-01-02 Thread Mark Cave-Ayland
The VSX register array is a block of 64 128-bit registers where the first 32 registers consist of the existing 64-bit FP registers extended to 128-bit using new VSR registers, and the last 32 registers are the VMX 128-bit registers as show below: 64-bit 64-bit

[Qemu-devel] [PATCH v5 9/9] target/ppc: replace AVR* macros with Vsr* macros

2019-01-02 Thread Mark Cave-Ayland
Now that the VMX and VSR register sets have been combined, the same macros can be used to access both AVR and VSR field members. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson --- target/ppc/int_helper.c | 30 +- 1 file changed, 13 insertions(+), 17

[Qemu-devel] [PATCH v5 6/9] target/ppc: switch FPR, VMX and VSX helpers to access data directly from cpu_env

2019-01-02 Thread Mark Cave-Ayland
Instead of accessing the FPR, VMX and VSX registers through static arrays of TCGv_i64 globals, remove them and change the helpers to load/store data directly within cpu_env. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson Acked-by: David Gibson --- target/ppc/translate.c

[Qemu-devel] [PATCH v5 7/9] target/ppc: merge ppc_vsr_t and ppc_avr_t union types

2019-01-02 Thread Mark Cave-Ayland
Since the VSX registers are actually a superset of the VMX registers then they can be represented by the same type. Merge ppc_avr_t into ppc_vsr_t and change ppc_avr_t to be a simple typedef alias. Note that due to a difference in the naming of the float32 member between ppc_avr_t and ppc_vsr_t,

[Qemu-devel] [PATCH v5 5/9] target/ppc: introduce get_cpu_vsr{l, h}() and set_cpu_vsr{l, h}() helpers for VSR register access

2019-01-02 Thread Mark Cave-Ayland
These helpers allow us to move VSR register values to/from the specified TCGv_i64 argument. To prevent VSX helpers accessing the cpu_vsr array directly, add extra TCG temporaries as required. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson Acked-by: David Gibson ---

[Qemu-devel] [PATCH v5 0/9] target/ppc: prepare for conversion to TCG vector operations

2019-01-02 Thread Mark Cave-Ayland
This patchset is an attempt at trying to improve the VMX (Altivec) instruction performance by laying the groundwork for use of the new TCG vector operations. Patches 1 and 2 fix a sign-extension error discovered in EXTRACT_SHELPER and an associated typo in the SIMM5 macro which were discovered

[Qemu-devel] [PATCH v5 2/9] target/ppc: switch EXTRACT_HELPER macros over to use sextract32/extract32

2019-01-02 Thread Mark Cave-Ayland
These ensure that we consistently handle signed and unsigned extensions correctly when decoding immediates from instruction opcodes. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson --- target/ppc/internal.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[Qemu-devel] [PATCH v5 4/9] target/ppc: introduce get_avr64() and set_avr64() helpers for VMX register access

2019-01-02 Thread Mark Cave-Ayland
These helpers allow us to move AVR register values to/from the specified TCGv_i64 argument. To prevent VMX helpers accessing the cpu_avr{l,h} arrays directly, add extra TCG temporaries as required. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson Acked-by: David Gibson ---

[Qemu-devel] [PATCH v5 3/9] target/ppc: introduce get_fpr() and set_fpr() helpers for FP register access

2019-01-02 Thread Mark Cave-Ayland
These helpers allow us to move FP register values to/from the specified TCGv_i64 argument in the VSR helpers to be introduced shortly. To prevent FP helpers accessing the cpu_fpr array directly, add extra TCG temporaries as required. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard

[Qemu-devel] [PATCH v5 1/9] target/ppc: fix typo in SIMM5 extraction helper

2019-01-02 Thread Mark Cave-Ayland
As the macro name suggests, the argument should be signed and not unsigned. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson --- target/ppc/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/internal.h b/target/ppc/internal.h index

  1   2   >