[Qemu-devel] [PULL 13/28] compat: replace PC_COMPAT_2_7 & HW_COMPAT_2_7 macros

2019-01-04 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 3 +++ include/hw/compat.h| 23 --- include/hw/i386/pc.h

[Qemu-devel] [PULL 24/28] qdev-props: convert global_props to GPtrArray

2019-01-04 Thread Marc-André Lureau
A step towards being able to call a common function, object_apply_global_props(). Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- hw/core/qdev-properties.c | 29 - 1 file changed, 20

[Qemu-devel] [PULL 15/28] compat: replace PC_COMPAT_2_5 & HW_COMPAT_2_5 macros

2019-01-04 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 3 +++ include/hw/compat.h| 24 include/hw/i386/pc.h

[Qemu-devel] [PULL 11/28] compat: replace PC_COMPAT_2_9 & HW_COMPAT_2_9 macros

2019-01-04 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 3 +++ include/hw/compat.h| 19 --- include/hw/i386/pc.h

[Qemu-devel] [PULL 22/28] qdev: make a separate helper function to apply compat properties

2019-01-04 Thread Marc-André Lureau
This will allow to apply compat properties on other objects than QDev easily. Signed-off-by: Marc-André Lureau Reviewed-by: Cornelia Huck Reviewed-by: Igor Mammedov Acked-by: Eduardo Habkost --- include/hw/qdev-core.h | 2 ++ hw/core/qdev.c | 6 +- 2 files changed, 7

[Qemu-devel] [PULL 23/28] qdev: all globals are now user-provided

2019-01-04 Thread Marc-André Lureau
All globals are now either provided via -global or through -cpu features (CPU features are implemented by registering globals). If the global isn't being used, it should warn in either case. We can thus consider that all global_props are "user-provided" globals. No need to track this per-globals

[Qemu-devel] [PULL 08/28] compat: replace PC_COMPAT_2_12 & HW_COMPAT_2_12 macros

2019-01-04 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 3 +++ include/hw/compat.h| 27 ---

[Qemu-devel] [PULL 09/28] compat: replace PC_COMPAT_2_11 & HW_COMPAT_2_11 macros

2019-01-04 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 3 +++ include/hw/compat.h| 19 --- include/hw/i386/pc.h

[Qemu-devel] [PULL 14/28] compat: replace PC_COMPAT_2_6 & HW_COMPAT_2_6 macros

2019-01-04 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 3 +++ include/hw/compat.h| 15 --- include/hw/i386/pc.h | 23

[Qemu-devel] [PULL 21/28] compat: remove remaining PC_COMPAT macros

2019-01-04 Thread Marc-André Lureau
Use static arrays instead. I decided to rename the conflicting pc_compat_2_1() function with pc_compat_2_1_fn(). Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/i386/pc.h | 236

[Qemu-devel] [PULL 04/28] machine: move compat properties out of globals

2019-01-04 Thread Marc-André Lureau
Move the compat arrays inside functions that use them. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- hw/arm/virt.c | 94 +++--- hw/i386/pc_piix.c | 607 ++---

[Qemu-devel] [PULL 06/28] compat: replace PC_COMPAT_3_1 & HW_COMPAT_3_1 macros

2019-01-04 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 3 +++ include/hw/compat.h| 11 --- include/hw/i386/pc.h | 9

[Qemu-devel] [PULL 12/28] compat: replace PC_COMPAT_2_8 & HW_COMPAT_2_8 macros

2019-01-04 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 3 +++ include/hw/compat.h| 43 ---

[Qemu-devel] [PULL 17/28] compat: replace PC_COMPAT_2_3 & HW_COMPAT_2_3 macros

2019-01-04 Thread Marc-André Lureau
Use static arrays instead. I decided to rename the conflicting pc_compat_2_3() function with pc_compat_2_3_fn(). Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h | 3 ++

[Qemu-devel] [PULL 07/28] compat: replace PC_COMPAT_3_0 & HW_COMPAT_3_0 macros

2019-01-04 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 3 +++ include/hw/compat.h| 3 --- include/hw/i386/pc.h | 17

[Qemu-devel] [PULL 05/28] hw: remove SET_MACHINE_COMPAT

2019-01-04 Thread Marc-André Lureau
No longer needed. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h | 12 1 file changed, 12 deletions(-) diff --git a/include/hw/boards.h b/include/hw/boards.h index f14c38bb63..0566742412

[Qemu-devel] [PULL 02/28] machines: replace COMPAT define with a static array

2019-01-04 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 10 +- hw/arm/virt.c | 45 ++-- hw/i386/pc_piix.c | 474 + hw/i386/pc_q35.c |

[Qemu-devel] [PULL 10/28] compat: replace PC_COMPAT_2_10 & HW_COMPAT_2_10 macros

2019-01-04 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 3 +++ include/hw/compat.h| 11 --- include/hw/i386/pc.h | 17

[Qemu-devel] [PULL 03/28] hw: apply machine compat properties without touching globals

2019-01-04 Thread Marc-André Lureau
Similarly to accel properties, move compat properties out of globals registration, and apply the machine compat properties during device_post_init(). Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h

[Qemu-devel] [PULL 01/28] hw: apply accel compat properties without touching globals

2019-01-04 Thread Marc-André Lureau
Instead of registering compat properties as globals, let's keep them in their own array, to avoid mixing with user globals. Introduce object_apply_global_props() function, to apply compatibility properties from a GPtrArray. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov

[Qemu-devel] [PULL 00/28] Machine props patches

2019-01-04 Thread Marc-André Lureau
The following changes since commit 6395fe0c2c7d9f336d87960a7c9924b630c57c91: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-01-04 13:22:51 +) are available in the Git repository at: https://github.com/elmarco/qemu.git

Re: [Qemu-devel] [PATCH v2 12/27] target/arm: Decode PAuth within disas_uncond_b_reg

2019-01-04 Thread Peter Maydell
On Fri, 14 Dec 2018 at 05:24, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 82 +- > 1 file changed, 81 insertions(+), 1 deletion(-) Reviewed-by: Peter Maydell thanks -- PMM

[Qemu-devel] [PATCH v3 0/2] tests: Reorganize MIPS TCG directories and files

2019-01-04 Thread Aleksandar Markovic
From: Aleksandar Markovic Reorganize MIPS TCG directories and files. The file movement is done using "git mv" command, so "git blame" will still display the original information, regardles of the new names and locations of involved files. Also, command "git config diff.renames true" was used to

[Qemu-devel] [PATCH v3 2/2] tests: tcg: mips: Remove old directories after moving source files

2019-01-04 Thread Aleksandar Markovic
From: Aleksandar Markovic Remove old directories after reorganization of MIPS TCG tests. Signed-off-by: Aleksandar Markovic --- tests/tcg/mips/mips32-dsp/Makefile| 136 - tests/tcg/mips/mips32-dspr2/Makefile | 71 --- tests/tcg/mips/mips64-dsp/Makefile|

Re: [Qemu-devel] [PATCH v2 11/27] target/arm: Rearrange decode in disas_uncond_b_reg

2019-01-04 Thread Peter Maydell
On Fri, 14 Dec 2018 at 05:24, Richard Henderson wrote: > > This will enable PAuth decode in a subsequent patch. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 47 +- > 1 file changed, 36 insertions(+), 11 deletions(-) Applied to

Re: [Qemu-devel] [PATCH v2 07/27] target/arm: Decode PAuth within disas_data_proc_1src

2019-01-04 Thread Peter Maydell
On Fri, 14 Dec 2018 at 05:24, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 146 + > 1 file changed, 146 insertions(+) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v2 05/27] target/arm: Decode PAuth within system hint space

2019-01-04 Thread Peter Maydell
On Fri, 14 Dec 2018 at 05:24, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 93 +- > 1 file changed, 81 insertions(+), 12 deletions(-) > > diff --git a/target/arm/translate-a64.c

[Qemu-devel] [PATCH 2/2] tests: tcg: mips: Remove old directories after moving source files

2019-01-04 Thread Aleksandar Markovic
From: Aleksandar Markovic Remove old directories after reorganization of MIPS TCG tests. Signed-off-by: Aleksandar Markovic --- tests/tcg/mips/mips32-dsp/Makefile| 136 - tests/tcg/mips/mips32-dspr2/Makefile | 71 --- tests/tcg/mips/mips64-dsp/Makefile|

[Qemu-devel] [PATCH 0/2] tests: Reorganize MIPS TCG directories and files

2019-01-04 Thread Aleksandar Markovic
From: Aleksandar Markovic Reorganize MIPS TCG directories and files. The file movement is done using "git mv" command, so "git blame" will still display the original information, regardles of the new names and locations of involved files. Also, command "git config diff.renames true" was used to

Re: [Qemu-devel] [PATCH for-4.0 v4 3/4] i386: import & use bootparam.h

2019-01-04 Thread Stefano Garzarella
Hi Li, On Thu, Dec 6, 2018 at 3:24 AM Li Zhijian wrote: > > it's from v4.20-rc5. > > CC: Michael S. Tsirkin > Signed-off-by: Li Zhijian > > --- > V4: use scirpt to import bootparam.h (Michael S. Tsirkin) > V3: new patch > > Signed-off-by: Li Zhijian > --- > hw/i386/pc.c

Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s

2019-01-04 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 04 January 2019 16:31 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; qemu-bl...@nongnu.org; xen- > de...@lists.xenproject.org; Kevin Wolf ; Max Reitz > ; Stefano Stabellini > Subject: Re: [PATCH v7

[Qemu-devel] [Bug 1809546] Re: Writing a byte to a pl011 SFR overwrites the whole SFR

2019-01-04 Thread Daniels Umanovskis
Thanks for the response. I don't think section 3.1 applies to 8-bit accesses. That is specifically about reserved locations, and neither offset 0x38 nor 0x39 are reserved, so I think it's a matter of whether 32-bit access is required or not. >From what I usually see in ARM documentation, 32-bit

Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s

2019-01-04 Thread Anthony PERARD
Almost done, there is one thing left which I believe is an issue. Whenever I attach a raw file to QEMU, it print: qemu-system-i386: warning: Opening a block device as a file using the 'file' driver is deprecated So, I think the comment below isn't true. We should create a "raw" driver for

[Qemu-devel] [PULL 0/4] fw_cfg 20190104 patches

2019-01-04 Thread Philippe Mathieu-Daudé
-20190104-pull-request for you to fetch changes up to 19bcc4bc3213e78c303ad480a7a578f62258252d: fw_cfg: Make qemu_extra_params_fw locally (2019-01-04 15:30:52 +0100) fw_cfg patches for 2019-01-04 Two fixes from Li Qiang: - Improve

[Qemu-devel] [PULL 4/4] fw_cfg: Make qemu_extra_params_fw locally

2019-01-04 Thread Philippe Mathieu-Daudé
From: Li Qiang qemu_extra_params_fw[] has external linkage, but is used only in fw_cfg_bootsplash(), it makes sense to make it locally. Signed-off-by: Li Qiang Reviewed-by: Markus Armbruster Reviewed-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[Qemu-devel] [PULL 1/4] fw_cfg: Improve error message when can't load splash file

2019-01-04 Thread Philippe Mathieu-Daudé
From: Li Qiang read_splashfile() reports "failed to read splash file" without further details. Get the details from g_file_get_contents(), and include them in the error message. Also remove unnecessary 'res' variable. Signed-off-by: Li Qiang Reviewed-by: Markus Armbruster Reviewed-by:

Re: [Qemu-devel] [PATCH v2 01/27] target/arm: Add state for the ARMv8.3-PAuth extension

2019-01-04 Thread Peter Maydell
On Fri, 14 Dec 2018 at 05:24, Richard Henderson wrote: > > Add storage space for the 5 encryption keys. > > Signed-off-by: Richard Henderson > > v2: Remove pointless double migration. > Use a struct to make it clear which half is which. > --- Reviewed-by: Peter Maydell thanks -- PMM

[Qemu-devel] [PULL 3/4] fw_cfg: Fix -boot reboot-timeout error checking

2019-01-04 Thread Philippe Mathieu-Daudé
From: Li Qiang fw_cfg_reboot() gets option parameter "reboot-timeout" with qemu_opt_get(), then converts it to an integer by hand. It neglects to check that conversion for errors, and fails to reject negative values. Positive values above the limit get reported and replaced by the limit. This

[Qemu-devel] [PULL 2/4] fw_cfg: Fix -boot bootsplash error checking

2019-01-04 Thread Philippe Mathieu-Daudé
From: Li Qiang fw_cfg_bootsplash() gets option parameter "splash-time" with qemu_opt_get(), then converts it to an integer by hand. It neglects to check that conversion for errors. This is needlessly complicated and error-prone. But as "splash-time not specified" is not the same as

Re: [Qemu-devel] [PATCH v2 04/27] target/arm: Add PAuth helpers

2019-01-04 Thread Peter Maydell
On Fri, 14 Dec 2018 at 05:24, Richard Henderson wrote: > > The cryptographic internals are stubbed out for now, > but the enable and trap bits are checked. > > Signed-off-by: Richard Henderson > > +static void QEMU_NORETURN pauth_trap(CPUARMState *env, int target_el, > +

Re: [Qemu-devel] [PATCH v2] qemu: avoid memory leak while remove disk

2019-01-04 Thread Eric Blake
On 12/22/18 4:27 AM, w00426999 wrote: > Memset vhost_dev to zero in the vhost_dev_cleanup function. > This causes dev.vqs to be NULL, so that > vqs does not free up space when calling the g_free function. > This will result in a memory leak. But you can't release vqs > directly in the

Re: [Qemu-devel] [PATCH v7 00/28] Generalize machine compatibility properties

2019-01-04 Thread Eduardo Habkost
On Fri, Jan 04, 2019 at 03:42:08PM +0400, Marc-André Lureau wrote: > Hi > > On Fri, Dec 21, 2018 at 1:04 PM Marc-André Lureau > wrote: > > > > Hi, > > > > During "[PATCH v2 05/10] qom/globals: generalize > > object_property_set_globals()" review, Eduardo suggested to rework the > >

Re: [Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6

2019-01-04 Thread Eduardo Habkost
On Fri, Jan 04, 2019 at 10:49:19AM +0100, Cornelia Huck wrote: > On Fri, 4 Jan 2019 01:22:26 -0200 > Eduardo Habkost wrote: > > > The virtio-pci entries in HW_COMPAT_2_6 had an implicit > > assumption: that all virtio-pci subclasses support the > > disable-legacy and disable-modern options. > >

Re: [Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6

2019-01-04 Thread Eduardo Habkost
On Thu, Jan 03, 2019 at 11:23:45PM -0500, Michael S. Tsirkin wrote: > On Fri, Jan 04, 2019 at 01:22:26AM -0200, Eduardo Habkost wrote: > > The virtio-pci entries in HW_COMPAT_2_6 had an implicit > > assumption: that all virtio-pci subclasses support the > > disable-legacy and disable-modern

Re: [Qemu-devel] [PATCH v7 09/18] xen: remove unnecessary code from dataplane/xen-block.c

2019-01-04 Thread Anthony PERARD
On Thu, Dec 20, 2018 at 05:14:30PM +, Paul Durrant wrote: > Not all of the code duplicated from xen_disk.c is required as the basis for > the new dataplane implementation so this patch removes extraneous code, > along with the legacy #includes and calls to the legacy xen_pv_printf() >

[Qemu-devel] [Bug 1701835] Re: floating-point operation bugs in qemu-alpha

2019-01-04 Thread Stefan Ring
This is likely expected/correct behavior. You should try building with -mieee. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1701835 Title: floating-point operation bugs in qemu-alpha Status in

Re: [Qemu-devel] [PATCH v4] log: Make glib logging go through QEMU

2019-01-04 Thread Stefan Hajnoczi
On Thu, Jan 03, 2019 at 03:14:55PM +0100, Christophe Fergeau wrote: > Hey, > > On Thu, Jan 03, 2019 at 10:54:25AM +, Stefan Hajnoczi wrote: > > On Fri, Dec 14, 2018 at 11:56:42AM +0100, Christophe Fergeau wrote: > > > +static void qemu_log_func(const gchar *log_domain, > > > +

[Qemu-devel] [RFC PATCH] osdep: Make MIN/MAX evaluate arguments only once

2019-01-04 Thread Eric Blake
Use the __auto_type keyword to make sure our min/max macros only evaluate their arguments once. Signed-off-by: Eric Blake --- RFC because __auto_type didn't exist until gcc 4.9, and I don't know which clang version introduced it (other than that it went in during 2015:

Re: [Qemu-devel] [RFC PATCH 20/25] hyperv: express dependencies with kconfig

2019-01-04 Thread Thomas Huth
On 2018-12-27 07:34, Yang Zhong wrote: > remove default-configs/hyperv.mak and make dependencies > with Kconfig. > > Signed-off-by: Yang Zhong > --- > default-configs/hyperv.mak | 2 -- > default-configs/i386-softmmu.mak | 1 - > hw/hyperv/Kconfig| 1 + > hw/i386/Kconfig

Re: [Qemu-devel] [PATCH] cpus.c: Fix race condition in cpu_stop_current()

2019-01-04 Thread Peter Maydell
On Fri, 7 Dec 2018 at 16:00, Peter Maydell wrote: > > We use cpu_stop_current() to ensure the current CPU has stopped > from places like qemu_system_reset_request(). Unfortunately its > current implementation has a race. It calls qemu_cpu_stop(), > which sets cpu->stopped to true even though the

Re: [Qemu-devel] [RFC PATCH 19/25] edid: express dependencies with kconfig

2019-01-04 Thread Thomas Huth
On 2018-12-27 07:34, Yang Zhong wrote: > Signed-off-by: Yang Zhong > --- > hw/display/Kconfig | 2 ++ > hw/i2c/Kconfig | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/hw/display/Kconfig b/hw/display/Kconfig > index 8ddce09ead..8b8f1027b1 100644 > --- a/hw/display/Kconfig > +++

Re: [Qemu-devel] [PATCH v1 2/2] target/arm: defer setting up of aarch64 gdb until arm_cpu_realize

2019-01-04 Thread Peter Maydell
On Thu, 13 Dec 2018 at 11:55, Alex Bennée wrote: > > If we setup earlier we miss the parsing of the aarch64 state of the > CPU. If the user has booted up with: > > qemu-system-aarch64 -cpu host,aarch64=off -enable-kvm > > we end up presenting an aarch64 view of the world via the gdbstub and >

[Qemu-devel] [PATCH] trivial: Don't include isa.h if it is not really necessary

2019-01-04 Thread Thomas Huth
These files don't seem to do anything related to ISA directly, so there is no need to include isa.h here. Signed-off-by: Thomas Huth --- hw/display/ramfb-standalone.c | 1 - hw/ide/pci.c | 1 - hw/ide/piix.c | 1 - hw/ide/via.c | 1 -

Re: [Qemu-devel] [RFC PATCH 17/25] i2c: express dependencies with Kconfig

2019-01-04 Thread Thomas Huth
On 2018-12-27 07:34, Yang Zhong wrote: > From: Paolo Bonzini > > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > --- [...] > diff --git a/hw/display/Kconfig b/hw/display/Kconfig > index 8ce968bfff..8ddce09ead 100644 > --- a/hw/display/Kconfig > +++ b/hw/display/Kconfig > @@ -24,9

Re: [Qemu-devel] [PATCH] tests/hexloader-test: Don't pass -nographic to the QEMU under test

2019-01-04 Thread Thomas Huth
On 2019-01-04 15:50, Peter Maydell wrote: > The hexloader test invokes QEMU with the -nographic argument. This > is unnecessary, because the qtest_initf() function will pass it > -display none, which suffices to disable the graphical window. > It also means that the QEMU process will make the

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add ARM-related files for hw/[misc|input|timer]/

2019-01-04 Thread Peter Maydell
On Wed, 2 Jan 2019 at 12:53, Thomas Huth wrote: > > Some of the files in hw/input/, hw/misc/ and hw/timer/ are only > used by one of the ARM machines, so we can assign these files to > the corresponding boards. > > Signed-off-by: Thomas Huth > --- > MAINTAINERS | 16 ++-- > 1 file

Re: [Qemu-devel] [PATCH v1 0/1] hw/arm: versal: Fix memory leaks

2019-01-04 Thread Peter Maydell
On Fri, 4 Jan 2019 at 10:47, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > This series fixes the memory leaks in versal board creation > reported by Peter Maydell. > > Best regards, > Edgar > > Edgar E. Iglesias (1): > hw/arm: versal: Plug memory leaks > Applied to

Re: [Qemu-devel] [PATCH 0/2] include: update Linux headers to 4.21-rc1/5.0-rc1

2019-01-04 Thread Michael S. Tsirkin
On Fri, Jan 04, 2019 at 09:27:29AM +0100, Paolo Bonzini wrote: > This is the same patch I've sent, except that scripts/update-linux-headers.sh > changes are split to a separate commit. > > Paolo Reviewed-by: Michael S. Tsirkin > Paolo Bonzini (2): > scripts/update-linux-headers.sh: adjust

Re: [Qemu-devel] [PATCH] include: update Linux headers to 4.21/5.0

2019-01-04 Thread Michael S. Tsirkin
On Fri, Jan 04, 2019 at 09:07:23AM +0100, Paolo Bonzini wrote: > On 03/01/19 20:26, Peter Maydell wrote: > > On Thu, 3 Jan 2019 at 18:19, Michael S. Tsirkin wrote: > >> > >> On Thu, Jan 03, 2019 at 06:51:13PM +0100, Paolo Bonzini wrote: > >>> Signed-off-by: Paolo Bonzini > >> > >> Note that in

Re: [Qemu-devel] [PATCH] Revert "armv7m: Guard against no -kernel argument"

2019-01-04 Thread Peter Maydell
On Thu, 3 Jan 2019 at 14:41, Stefan Hajnoczi wrote: > > This reverts commit 01fd41ab3fb69971c24a69ed49cde96086d81278. > > The generic loader device (-device loader,file=kernel.bin) can be used > to load a kernel instead of the -kernel option. Some boards have flash > memory (pflash) that is set

Re: [Qemu-devel] Qemu the right way.

2019-01-04 Thread Stefan Hajnoczi
On Tue, Dec 25, 2018 at 05:48:50PM -0500, liebre...@grossmann-venter.com wrote: > I have been using Qemu in the past about 8 years ago or so to run legacy > windows software. > > I installed the latest qemu and noticed a lot changed and cant find > conclusive answers online. > > I am writing

Re: [Qemu-devel] [PATCH v8 00/16] gdbstub: support for the multiprocess extension

2019-01-04 Thread Peter Maydell
On Fri, 7 Dec 2018 at 09:01, Luc Michel wrote: > This series adds support for the multiprocess extension of the GDB > remote protocol in the QEMU GDB stub. > > This extension is useful to split QEMU emulated CPUs in different > processes from the point of view of the GDB client. It adds the >

Re: [Qemu-devel] [PATCH v2] qemu: avoid memory leak while remove disk

2019-01-04 Thread Stefan Hajnoczi
On Sat, Dec 22, 2018 at 06:27:28PM +0800, w00426999 wrote: > Memset vhost_dev to zero in the vhost_dev_cleanup function. > This causes dev.vqs to be NULL, so that > vqs does not free up space when calling the g_free function. > This will result in a memory leak. But you can't release vqs >

Re: [Qemu-devel] [qemu-s390x] [PATCH v2] s390: avoid potential null dereference in s390_pcihost_unplug()

2019-01-04 Thread Halil Pasic
On Fri, 4 Jan 2019 15:10:05 +0100 Cornelia Huck wrote: > On Thu, 3 Jan 2019 07:16:12 -0800 > Li Qiang wrote: > > > When getting the 'pbdev', the if...else has no default branch. > > From Coverity, the 'pbdev' maybe null when the 'dev' is not > > the

Re: [Qemu-devel] [PATCH v2 09/12] tests/tcg/mips: Test R5900 three-operand MADDU1

2019-01-04 Thread Aleksandar Markovic
> From: Fredrik Noring > Sent: Tuesday, January 1, 2019 7:27 PM > To: Aleksandar Markovic > Cc: Aurelien Jarno; Philippe Mathieu-Daudé; Jürgen Urban; Maciej W. Rozycki; > qemu-devel@nongnu.org > Subject: Re: [PATCH v2 09/12] tests/tcg/mips: Test R5900 three-operand MADDU1 > > Thanks Aleksandar!

[Qemu-devel] [PATCH] hw/audio/marvell: Don't include unnecessary i2c.h header file

2019-01-04 Thread Thomas Huth
This device does not use I2C, so no need to include the header file here. Signed-off-by: Thomas Huth --- hw/audio/marvell_88w8618.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/audio/marvell_88w8618.c b/hw/audio/marvell_88w8618.c index 6600ab4..035dd76 100644 ---

Re: [Qemu-devel] [PATCH v2 4/8] qcow2-threads: split out generic path

2019-01-04 Thread Alberto Garcia
On Fri 14 Dec 2018 09:51:12 AM CET, Vladimir Sementsov-Ogievskiy wrote: > 14.12.2018 2:28, Paolo Bonzini wrote: >> On 11/12/18 17:43, Vladimir Sementsov-Ogievskiy wrote: >>> +ThreadPool *pool = aio_get_thread_pool(bdrv_get_aio_context(bs)); >>> + >>> +while (s->nb_threads >=

Re: [Qemu-devel] [PULL 0/4] Block patches

2019-01-04 Thread Peter Maydell
On Fri, 4 Jan 2019 at 11:21, Stefan Hajnoczi wrote: > > The following changes since commit 20d6c7312f1b812bb9c750f4087f69ac8485cc90: > > Merge remote-tracking branch > 'remotes/palmer/tags/riscv-for-master-3.2-part1' into staging (2019-01-03 > 13:26:30 +) > > are available in the Git

[Qemu-devel] [PATCH] tests/hexloader-test: Don't pass -nographic to the QEMU under test

2019-01-04 Thread Peter Maydell
The hexloader test invokes QEMU with the -nographic argument. This is unnecessary, because the qtest_initf() function will pass it -display none, which suffices to disable the graphical window. It also means that the QEMU process will make the stdin/stdout O_NONBLOCK. Since O_NONBLOCK is not

[Qemu-devel] [Bug 1809546] Re: Writing a byte to a pl011 SFR overwrites the whole SFR

2019-01-04 Thread Peter Maydell
Yes, our PL011 implementation assumes that you only ever access the 32-bit registers with full width 32-bit word reads and writes. Don't try to do byte accesses to them. The PL011 data sheet doesn't specifically say that partial-width accesses to registers are permitted, so I think that trying to

Re: [Qemu-devel] [PATCH v6] s390x/pci: add common function measurement block

2019-01-04 Thread Cornelia Huck
On Thu, 3 Jan 2019 11:17:00 +0100 Pierre Morel wrote: > +static void fmb_update(void *opaque) > +{ > +S390PCIBusDevice *pbdev = opaque; > +int64_t t = qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL); > +int i; > + > +/* Update U bit */ > +pbdev->fmb.last_update *= 2; > +

[Qemu-devel] 答复: [PATCH v2] s390: avoid potential null dereference ins390_pcihost_unplug()

2019-01-04 Thread Li Qiang
What do you think of ‘g_assert_not_reached();’. For example: else { g_assert_not_reached(); } Thanks, Li Qiang 发件人: Cornelia Huck 发送时间: 2019年1月4日 22:10 收件人: Li Qiang 抄送: wall...@linux.ibm.com; r...@twiddle.net; da...@redhat.com; pa...@linux.ibm.com; borntrae...@de.ibm.com;

[Qemu-devel] [PATCH v1 0/2] target/microblaze: Add properties to enable exceptions on failed bus accesses

2019-01-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This adds the necessary properties to MicroBlaze cores to enable exceptions on failed bus accesses. There's no board that acutally uses this yet. This also adds an unimplemented device to the s3adsp1800 board since I used that board to test this feature. The s3adsp1800

[Qemu-devel] [PATCH v2] hw/arm/allwinner-a10: Add the 'A' SRAM and the SRAM controller

2019-01-04 Thread Philippe Mathieu-Daudé
>From the "A10 User Manual V1.20" p.29: "3.2. Memory Mapping" and: 7. System Control 7.1. Overview A10 embeds a high-speed SRAM which has been split into five segments. See detailed memory mapping in following table: Area AddressSize (Bytes) A1

[Qemu-devel] [PATCH v1 2/2] target/microblaze: Add props enabling exceptions on failed bus accesses

2019-01-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add MicroBlaze CPU properties to enable exceptions on failed bus accesses. Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 12 +++- target/microblaze/cpu.h | 2 ++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH 1/2] scripts/update-linux-headers.sh: adjust for Linux 4.21-rc1 (or 5.0-rc1)

2019-01-04 Thread Aleksandar Markovic
On Friday, January 4, 2019, Paolo Bonzini wrote: > There are three new indirect inclusions: vhost_types.h, which we'll > shortly put to use as a portable header and thus is copied to > standard-headers; and new per-subtarget versions of MIPS unistd.h > and PowerPC unistd.h. > > Because vhost.h

Re: [Qemu-devel] [PATCH] hw/arm/allwinner-a10: Add the 'A' SRAM and the SRAM controller

2019-01-04 Thread Philippe Mathieu-Daudé
On Fri, Jan 4, 2019 at 3:10 PM Peter Maydell wrote: > On Sun, 9 Dec 2018 at 19:37, Philippe Mathieu-Daudé wrote: > > From the "A10 User Manual V1.20" p.29: "3.2. Memory Mapping" and: > > > > 7. System Control > > 7.1. Overview > > > > A10 embeds a high-speed SRAM which has been split into

Re: [Qemu-devel] [RFC PATCH 04/25] minikconfig: add AST

2019-01-04 Thread Paolo Bonzini
On 27/12/18 07:33, Yang Zhong wrote: > +self.clauses.append(KconfigData.DependsOnClause(var, expr)) > > def do_select(self, var, symbol, cond=None): > -pass > +cond = (cond & var) if not (cond is None) else var A better way to write this in Python is cond =

Re: [Qemu-devel] [PATCH v2] s390: avoid potential null dereference in s390_pcihost_unplug()

2019-01-04 Thread Cornelia Huck
On Thu, 3 Jan 2019 07:16:12 -0800 Li Qiang wrote: > When getting the 'pbdev', the if...else has no default branch. > From Coverity, the 'pbdev' maybe null when the 'dev' is not > the TYPE_PCI_BRIDGE/TYPE_PCI_DEVICE/TYPE_S390_PCI_DEVICE. > This patch adds a default branch for device plug and

Re: [Qemu-devel] [PATCH] hw/arm/allwinner-a10: Add the 'A' SRAM and the SRAM controller

2019-01-04 Thread Peter Maydell
On Sun, 9 Dec 2018 at 19:37, Philippe Mathieu-Daudé wrote: > > From the "A10 User Manual V1.20" p.29: "3.2. Memory Mapping" and: > > 7. System Control > 7.1. Overview > > A10 embeds a high-speed SRAM which has been split into five segments. > See detailed memory mapping in following table:

Re: [Qemu-devel] [PATCH v15 23/26] sched: early boot clock (was Re: Bug#918036: linux: uptime after reboot wrong (kvm-clock related?))

2019-01-04 Thread Thorsten Glaser
Hi Salvatore, >p.s.: my earlier reply to you seem to have been rejected and never > reached you, hope this one does now. if you sent from Googlemail, it may reach me in the next weeks or never *shrug* they don’t play nice with greylisting. The -submitter or @d.o works, though. I’m following

Re: [Qemu-devel] barebox on Canon A1100

2019-01-04 Thread Sascha Hauer
On Fri, Jan 04, 2019 at 01:56:41AM +0300, Antony Pavlov wrote: > Hi Sascha! > > I have some good news and some bad news. > > First the good news. > > Barebox was used for Day 18 of QEMU 2018 advent > (https://www.qemu-advent-calendar.org/2018/). > > Here is a quote: > > > This is an image

Re: [Qemu-devel] [RFC PATCH 00/25] Support Kconfig in QEMU

2019-01-04 Thread Paolo Bonzini
On 27/12/18 07:33, Yang Zhong wrote: > (*) defconfig > "randconfig" build has some issues, which are mostly related > with CONFIG* in Kconfig.host abd configure. In randconfig mode, > some CONFIG* has different setting value in config-host.mak and > %/config-device.mak, which make

Re: [Qemu-devel] [RFC PATCH 00/13] Enabling tcg/tests for xtensa, mips and cris

2019-01-04 Thread Edgar E. Iglesias
On Mon, Dec 10, 2018 at 03:28:16PM +, Alex Bennée wrote: > Hi, > > This is very much a work in progress but I'm posting it in the hope of > getting some feedback from the architecture maintainers. > > When I originally enabled tcg tests I only enabled linux-user tests for > architectures

Re: [Qemu-devel] [RFC PATCH 11/13] tests/tcg/cris: comment out the ccs test

2019-01-04 Thread Edgar E. Iglesias
On Mon, Dec 10, 2018 at 03:28:27PM +, Alex Bennée wrote: > Evidently upstream gcc doesn't like this opcode. > > Signed-off-by: Alex Bennée Hi Alex, this is probably an example of missmatching CRISv10 vs CRISv32 versions in toolchain usage. Cheers, Edgar > --- >

Re: [Qemu-devel] [RFC PATCH 22/25] i386-softmmu.mak: remove all CONFIG_* except boards definitions

2019-01-04 Thread Paolo Bonzini
On 27/12/18 07:34, Yang Zhong wrote: > %-softmmu.mak only keep boards definitions in Kconfig mode. > > Signed-off-by: Yang Zhong > --- > default-configs/i386-softmmu.mak | 30 -- > hw/i386/Kconfig | 30 ++ > hw/ide/Kconfig

Re: [Qemu-devel] [RFC PATCH 00/13] Enabling tcg/tests for xtensa, mips and cris

2019-01-04 Thread Edgar E. Iglesias
On Mon, Dec 10, 2018 at 03:28:16PM +, Alex Bennée wrote: > Hi, > > This is very much a work in progress but I'm posting it in the hope of > getting some feedback from the architecture maintainers. > > When I originally enabled tcg tests I only enabled linux-user tests for > architectures

Re: [Qemu-devel] [RFC PATCH 15/25] isa: express dependencies with kconfig

2019-01-04 Thread Thomas Huth
On 2018-12-27 07:34, Yang Zhong wrote: > From: Paolo Bonzini > > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > --- [...] > diff --git a/hw/display/Kconfig b/hw/display/Kconfig > index 5e73277cc2..e0d7919a06 100644 > --- a/hw/display/Kconfig > +++ b/hw/display/Kconfig > @@ -9,6

Re: [Qemu-devel] [RFC PATCH 10/25] build: convert pci.mak to Kconfig

2019-01-04 Thread Thomas Huth
On 2018-12-27 07:34, Yang Zhong wrote: > From: Paolo Bonzini > > Instead of including the same list of devices for each target, > set CONFIG_PCI to true, and make the devices default to present > whenever PCI is available. > > Done mostly with the following script: > > while read i; do >

Re: [Qemu-devel] [PULL v4 00/35] Misc patches for 2018-12-21

2019-01-04 Thread Peter Maydell
On Fri, 4 Jan 2019 at 13:03, Peter Maydell wrote: > > On Fri, 4 Jan 2019 at 07:59, Paolo Bonzini wrote: > > I don't know... I tried running make check under "strace -e fcntl" and I > > didn't find any occurrences of fcntl(1, O_SETFL, ...|O_NONBLOCK). > > I found this strace command worked to

Re: [Qemu-devel] [RFC PATCH 14/25] bluetooth: express dependencies with Kconfig

2019-01-04 Thread Thomas Huth
On 2018-12-27 07:34, Yang Zhong wrote: > From: Paolo Bonzini > > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > --- > hw/Makefile.objs | 2 +- > hw/usb/Kconfig | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/Makefile.objs b/hw/Makefile.objs > index

Re: [Qemu-devel] [RFC PATCH 13/25] scsi: express dependencies with Kconfig

2019-01-04 Thread Thomas Huth
On 2018-12-27 07:34, Yang Zhong wrote: > From: Paolo Bonzini > > This lets you disable SCSI altogether with "CONFIG_SCSI=n". > > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > --- > hw/scsi/Kconfig | 11 ++- > hw/scsi/Makefile.objs | 2 +- > 2 files changed, 11

Re: [Qemu-devel] [RFC PATCH 13/25] scsi: express dependencies with Kconfig

2019-01-04 Thread Paolo Bonzini
On 27/12/18 07:34, Yang Zhong wrote: > From: Paolo Bonzini > > This lets you disable SCSI altogether with "CONFIG_SCSI=n". USB_STORAGE_BOT and USB_STORAGE_UAS must also select SCSI. Paolo

Re: [Qemu-devel] [RFC PATCH 03/25] minikconfig: add parser skeleton

2019-01-04 Thread Paolo Bonzini
On 27/12/18 07:33, Yang Zhong wrote: > + > +# --- > +# KconfigParser implements a recursive descent parser for (simplified) > +# Kconfig syntax. The static parse() method returns a KconfigData > +# object, from which it is possible to build a BDD and

Re: [Qemu-devel] [RFC PATCH 11/25] build: convert sound.mak to Kconfig

2019-01-04 Thread Thomas Huth
On 2018-12-27 07:34, Yang Zhong wrote: > From: Paolo Bonzini > > There is really nothing special in these devices; they are just > ISA devices. Instead of including them for each target, > set CONFIG_ISA to true, and make the devices default to present > whenever ISA is available. More

Re: [Qemu-devel] [PULL v4 00/35] Misc patches for 2018-12-21

2019-01-04 Thread Paolo Bonzini
On 04/01/19 14:03, Peter Maydell wrote: > On Fri, 4 Jan 2019 at 07:59, Paolo Bonzini wrote: >> I don't know... I tried running make check under "strace -e fcntl" and I >> didn't find any occurrences of fcntl(1, O_SETFL, ...|O_NONBLOCK). > > I found this strace command worked to track down some

Re: [Qemu-devel] [RFC PATCH 12/25] build: convert usb.mak to Kconfig

2019-01-04 Thread Thomas Huth
On 2018-12-27 07:34, Yang Zhong wrote: > From: Paolo Bonzini > > Instead of including the same list of devices for each target, > let the host controllers select CONFIG_USB and make the devices > default to present whenever USB is available. > > Done with the following script: > while read i;

[Qemu-devel] [PATCH v2] spapr: return from post_load method when RTC import fails

2019-01-04 Thread Cédric Le Goater
The error value can be squashed by the section handling radix migration. Simply bail out if an error occurs when the RTC offset is imported. This fixes the Coverity issue CID 1398591. Fixes: d39c90f5f3ae ("spapr: Fix migration of Radix guests") Signed-off-by: Cédric Le Goater --- Changes

Re: [Qemu-devel] [PULL v3 00/44] MIPS pull request for December 2018 - v3

2019-01-04 Thread Peter Maydell
On Thu, 3 Jan 2019 at 17:08, Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > The following changes since commit 1b3e80082bcd9b760113bbc023496cd22efad2dc: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20181226' into > staging (2019-01-03 10:42:21 +) > > are

Re: [Qemu-devel] [RFC] target/microblaze: Switch to transaction_failed hook

2019-01-04 Thread Edgar E. Iglesias
On Mon, Dec 10, 2018 at 06:32:49PM +, Peter Maydell wrote: > On Mon, 10 Dec 2018 at 18:31, Peter Maydell wrote: > > > > On Mon, 10 Dec 2018 at 17:57, Peter Maydell > > wrote: > > > > > > Switch the microblaze target from the old unassigned_access hook > > > to the transaction_failed hook. >

<    1   2   3   >