Re: [Qemu-devel] [PATCH v3 03/19] qemu-nbd: Sanity check partition bounds

2019-01-15 Thread Vladimir Sementsov-Ogievskiy
12.01.2019 20:57, Eric Blake wrote: > When the user requests a partition, we were using data read > from the disk as disk offsets without a bounds check. We got > lucky that even when computed offsets are out-of-bounds, > blk_pread() will gracefully catch the error later (so I don't > think a

Re: [Qemu-devel] [RFC PATCH v2 04/37] hw/m68k/Makefile.objs: Conditionally build boards

2019-01-15 Thread Thomas Huth
On 2019-01-15 15:10, Yang Zhong wrote: > From: Ákos Kovács > > CONFIG_AN5206, CONFIG_MCF5206 and CONFIG_MCF5208 make > variables created for m68k boards, and added to > default-configs/m86k-softmmu.mak. > > Signed-off-by: Ákos Kovács > Signed-off-by: Paolo Bonzini > --- >

Re: [Qemu-devel] [RFC PATCH v2 03/37] hw/arm/Makefile.objs: CONFIG_VIRT created for virt board

2019-01-15 Thread Thomas Huth
On 2019-01-15 15:10, Yang Zhong wrote: > make virt code configurable and the new CONFIG_VIRT definitions > added to the default-configs/arm-softmmu.mak to replace CONFIG_ACPI > in arm board. > > Signed-off-by: Yang Zhong > --- > default-configs/arm-softmmu.mak | 2 +- > hw/arm/Makefile.objs

Re: [Qemu-devel] [PATCH] .cirrus.yml: basic compile and test for FreeBSD

2019-01-15 Thread Thomas Huth
On 2019-01-15 19:42, Ed Maste wrote: > From: Ed Maste > > Cirrus-CI (https://cirrus-ci.org) is a hosted CI service which supports > several platforms, including FreeBSD. Later on we could build for other > hosts in Cirrus-CI, but I'm starting with only FreeBSD as it is not > supported by other

Re: [Qemu-devel] [PATCH] .cirrus.yml: basic compile and test for FreeBSD

2019-01-15 Thread Thomas Huth
On 2019-01-15 20:14, Ed Maste wrote: > On Tue, 15 Jan 2019 at 13:59, Marc-André Lureau > wrote: >> >> Hi >> >> On Tue, Jan 15, 2019 at 10:42 PM Ed Maste >> wrote: >>> >>> From: Ed Maste >>> >>> Cirrus-CI (https://cirrus-ci.org) is a hosted CI service which supports >>> several platforms,

Re: [Qemu-devel] [PATCH] include/fpu/softfloat: Fix compilation with Clang on s390x

2019-01-15 Thread Thomas Huth
On 2019-01-15 21:05, Emilio G. Cota wrote: > On Tue, Jan 15, 2019 at 16:01:32 +, Alex Bennée wrote: >> Ahh I should have mentioned we already have the technology for this ;-) >> >> If you build the fpu/next tree on a s390x you can then run: >> >> ./tests/fp/fp-bench f64_div >> >> with and

Re: [Qemu-devel] [PATCH v2 3/3] migration: introduce adaptive model for waiting thread

2019-01-15 Thread Peter Xu
On Fri, Jan 11, 2019 at 02:37:32PM +0800, guangrong.x...@gmail.com wrote: [...] > +static int get_compress_wait_thread(const MigrationParameters *params) > +{ > +Visitor *v = string_input_visitor_new(params->compress_wait_thread); > +Error *err = NULL; > +int wait_thread =

Re: [Qemu-devel] [PATCH 06/12] chardev: remove unused 'sioc' variable & cleanup paths

2019-01-15 Thread Thomas Huth
On 2019-01-16 06:47, Peter Xu wrote: > On Wed, Jan 16, 2019 at 06:24:49AM +0100, Thomas Huth wrote: >> On 2019-01-15 15:52, Daniel P. Berrangé wrote: >>> The 'sioc' variable in qmp_chardev_open_socket was unused since >>> >>> commit 3e7d4d20d3a528b1ed10b1dc3d83119bfb0c5f24 >>> Author: Peter Xu

Re: [Qemu-devel] [PATCH qemu] spapr: Fix fdt warnings

2019-01-15 Thread Richard Henderson
On 1/16/19 3:19 PM, Alexey Kardashevskiy wrote: > because TARGET_FMT_lx is defined as "%016"PRIx64. > > This uses simple "%lx" to suppress the warning. Since it is spapr which > is always 64bit, we assume here that hwaddr is always "long". This file is not solely for kvm, i.e. ppc64 hosts. Thus

Re: [Qemu-devel] [PATCH v3 0/4] Introduce attributes for timers subsystem and remove QEMU_CLOCK_VIRTUAL_EXT clock type

2019-01-15 Thread Pavel Dovgalyuk
> From: Artem Pisarenko [mailto:artem.k.pisare...@gmail.com] > > It seems, that this approach is not always correct. > > Now timerlist_deadline_ns uses all virtual timers for deadline calculation > > (including > external > > ones). > > qemu_start_warp_timer uses the deadline for setting warp

Re: [Qemu-devel] [PATCH v2 2/3] migration: fix memory leak when updating tls-creds and tls-hostname

2019-01-15 Thread Peter Xu
On Tue, Jan 15, 2019 at 10:03:53AM -0600, Eric Blake wrote: > On 1/15/19 4:24 AM, Dr. David Alan Gilbert wrote: > > > I think the problem is that > > migrate_params_check checks a MigrationParameters > > > > while the QMP command gives us a MigrateSetParameters; but we also use > >

Re: [Qemu-devel] [PATCH] egl-helpers.h: add a missing X11 include

2019-01-15 Thread Gerd Hoffmann
On Tue, Jan 15, 2019 at 09:47:08PM +0100, Alexander Kanavin wrote: > On Tue, 15 Jan 2019 at 20:58, Philippe Mathieu-Daudé > wrote: > > Cc'ing Gerd (the maintainer) and Marc-André. > > > > > | EGLSurface qemu_egl_init_surface_x11(EGLContext ectx, Window win); > > > |

[Qemu-devel] [Bug 1811782] Re: QEMU Windows fails to mount rootfs on an ISO where QEMU Linux works normally

2019-01-15 Thread Thomas Huth
Ok, thanks for the update. So I'm closing this now. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1811782 Title: QEMU Windows fails to mount

Re: [Qemu-devel] Devdax backend for vnvdimm not working

2019-01-15 Thread Yi Zhang
On 2019-01-15 at 22:51:09 +, Kamal Kakri via Qemu-devel wrote: > My devdax device is 2MB aligned so I dont think this is alignment related.# > ndctl list -X -n namespace0.0 > [ >   { >     "dev":"namespace0.0", >     "mode":"devdax", >     "map":"dev", >     "size":16909336576, >    

Re: [Qemu-devel] [PATCH 06/12] chardev: remove unused 'sioc' variable & cleanup paths

2019-01-15 Thread Peter Xu
On Wed, Jan 16, 2019 at 06:24:49AM +0100, Thomas Huth wrote: > On 2019-01-15 15:52, Daniel P. Berrangé wrote: > > The 'sioc' variable in qmp_chardev_open_socket was unused since > > > > commit 3e7d4d20d3a528b1ed10b1dc3d83119bfb0c5f24 > > Author: Peter Xu > > Date: Tue Mar 6 13:33:17 2018

Re: [Qemu-devel] [PATCH v4 for-4.0 1/7] char-socket: Enable "nowait" option on client sockets

2019-01-15 Thread Yongji Xie
On Tue, 15 Jan 2019 at 23:39, Daniel P. Berrangé wrote: > > On Fri, Jan 11, 2019 at 04:36:11PM +0800, Yongji Xie wrote: > > On Fri, 11 Jan 2019 at 16:32, Daniel P. Berrangé > > wrote: > > > > > > On Fri, Jan 11, 2019 at 03:50:40PM +0800, Yongji Xie wrote: > > > > On Fri, 11 Jan 2019 at 00:41,

Re: [Qemu-devel] [PATCH 3/5] tests: remove rule for nonexisting qdev-monitor-test

2019-01-15 Thread Thomas Huth
On 2019-01-15 19:19, Paolo Bonzini wrote: > This test was merged into drive_del-test in 2014. > > Signed-off-by: Paolo Bonzini > --- > tests/Makefile.include | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 195af1f..8b88cd5 100644

Re: [Qemu-devel] [PATCH 06/12] chardev: remove unused 'sioc' variable & cleanup paths

2019-01-15 Thread Thomas Huth
On 2019-01-15 15:52, Daniel P. Berrangé wrote: > The 'sioc' variable in qmp_chardev_open_socket was unused since > > commit 3e7d4d20d3a528b1ed10b1dc3d83119bfb0c5f24 > Author: Peter Xu > Date: Tue Mar 6 13:33:17 2018 +0800 > > chardev: use chardev's gcontext for async connect [...] >

Re: [Qemu-devel] [PATCH 01/12] chardev: fix validation of options for QMP created chardevs

2019-01-15 Thread Thomas Huth
On 2019-01-15 15:52, Daniel P. Berrangé wrote: > The TLS creds option is not valid with certain address types. The user > config was only checked for errors when parsing legacy QemuOpts, thus > the user could pass unsupported values via QMP. > > Pull all code for validating options out into a new

Re: [Qemu-devel] [PATCH 02/12] chardev: forbid 'reconnect' option with server sockets

2019-01-15 Thread Thomas Huth
On 2019-01-15 15:52, Daniel P. Berrangé wrote: > The 'reconnect' option is used to give the sleep time, in seconds, > before a client socket attempts to re-establish a connection to the > server. It does not make sense to set this for server sockets, as they > will always accept a new client

Re: [Qemu-devel] [PATCH v2 2/3] target/ppc: Add GDB callbacks for SPRs

2019-01-15 Thread Alexey Kardashevskiy
On 16/01/2019 06:10, Fabiano Rosas wrote: > Fabiano Rosas writes: > >> These will be used to let GDB know about PPC's Special Purpose >> Registers (SPR). >> >> They take an index based on the order the registers appear in the XML >> file sent by QEMU to GDB. This index does not match the

Re: [Qemu-devel] [PATCH 03/12] chardev: forbid 'wait' option with client sockets

2019-01-15 Thread Thomas Huth
On 2019-01-15 15:52, Daniel P. Berrangé wrote: > The 'wait'/'nowait' parameter is used to tell server sockets whether to > block until a client is accepted during initialization. Client chardevs > have always silently ignored this option. Various tests were mistakenly > passing this option for

[Qemu-devel] [PATCH v2 3/3] vhost-user-blk: add discard/write zeroes features support

2019-01-15 Thread Changpeng Liu
Linux commit 1f23816b8 "virtio_blk: add discard and write zeroes support" added the support in the Guest kernel, while here also enable the features support with vhost-user-blk driver. Also enable the test example utility with DISCARD and WRITE ZEROES commands. Signed-off-by: Changpeng Liu ---

[Qemu-devel] [PATCH v2 1/3] contrib: compile vhost-user-blk tool by default

2019-01-15 Thread Changpeng Liu
Signed-off-by: Changpeng Liu --- configure | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure b/configure index 3eee3fc..3d5af97 100755 --- a/configure +++ b/configure @@ -5763,6 +5763,9 @@ if test "$want_tools" = "yes" ; then if [ "$posix" = "yes" ] && [ "$curl" = "yes" ]; then

[Qemu-devel] [PATCH v2 2/3] contrib/vhost-user-blk: fix the compilation issue

2019-01-15 Thread Changpeng Liu
Signed-off-by: Changpeng Liu --- contrib/vhost-user-blk/vhost-user-blk.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/contrib/vhost-user-blk/vhost-user-blk.c b/contrib/vhost-user-blk/vhost-user-blk.c index 858221a..49640df 100644 ---

Re: [Qemu-devel] [RFC PATCH 1/1] target/ppc: support single stepping with KVM HV

2019-01-15 Thread Alexey Kardashevskiy
Fabiano, Are you planning on reposting this any time soon? I am interested in the feature. Thanks. On 20/11/2018 23:40, Philippe Mathieu-Daudé wrote: > Hi Fabiano, > > You should Cc the relevant maintainers to get more attention. > You can check this wiki page: >

Re: [Qemu-devel] [PATCH for-4.0 0/5] fix some segmentation faults and migration issues

2019-01-15 Thread Fei Li
Hi all, Kindly ping. :) As my v10 of qemu_thread_create partly rely on this patch series, I'd like to know when will these 5 patches be merged, or I join them with v10 of qemu_thread_create and send together. Could anyone shed light on me? Thanks for the advice in advance. Have a nice day

Re: [Qemu-devel] [PATCH for-4.0 v9 09/16] qemu_thread: supplement error handling for pci_edu_realize

2019-01-15 Thread Fei Li
在 2019/1/15 下午8:55, Markus Armbruster 写道: Fei Li writes: 在 2019/1/14 下午8:36, Markus Armbruster 写道: Fei Li writes: Just to make sure about how to do the cleanup. I notice that in device_set_realized(), the current code does not call "dc->unrealize(dev, NULL);" when dc->realize() fails.

Re: [Qemu-devel] [PATCH qemu RFC 3/7] pci: Move NVIDIA vendor id to the rest of ids

2019-01-15 Thread Alexey Kardashevskiy
Ping, anyone? On 14/12/2018 14:36, Alexey Kardashevskiy wrote: > > > On 21/11/2018 05:27, Alistair Francis wrote: >> On Tue, Nov 13, 2018 at 12:42 AM Alexey Kardashevskiy wrote: >>> >>> sPAPR code will use it too so move it from VFIO to the common code. >>> >>> Signed-off-by: Alexey

[Qemu-devel] [Bug 1777252] Re: tests/Makefile.include trying to add linking library '-lutil' that break the build on Solaris

2019-01-15 Thread WHR
>>> Does something like this work for you? Yes, this fix works; but I don't think this is a clean fix, since libutil may also missing in other OS. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [PATCH qemu] spapr: Fix fdt warnings

2019-01-15 Thread Alexey Kardashevskiy
The FDT blob which the spapr machine renders at reset time produces warnings like this: my-181211-154309.dts: Warning (unit_address_format): Node /memory@8000 unit name should not have leading 0s my-181211-154309.dts: Warning (unit_address_format): Node /memory@4000 unit

[Qemu-devel] [PATCH qemu 0/2] linux-headers: Update to v5.0-rc2

2019-01-15 Thread Alexey Kardashevskiy
Here is the update script update and what it did to the v5.0-rc2 kernel. This is based on sha1 a0a8bff Greg Kurz "target/ppc/kvm: Drop useless include directive". Please comment. Thanks. Alexey Kardashevskiy (2): update-linux-headers.sh: Copy new headers linux-headers: Update to v5.0-rc2

[Qemu-devel] [PATCH qemu 1/2] update-linux-headers.sh: Copy new headers

2019-01-15 Thread Alexey Kardashevskiy
Since Linux'es ab66dcc76d "powerpc: generate uapi header and system call table files" there are 2 new files: unistd_32.h and unistd_64.h. These files content is moved from unistd.h so now we have to copy new files as well, just like we already do for other architectures; this does it for MIPS as

[Qemu-devel] [Bug 1811916] [NEW] SDL2 interface didn't follow the current X11 keyboard layout for hotkeys

2019-01-15 Thread WHR
Public bug reported: My X11 was configured to use Dvorak keyboard layout, with setxkbmap(1). Despite the window title said 'Press Ctrl-Alt-G to exit grab' after it grabbed the mouse, pressing this hotkey don't have any effects, and I has to switch to a virtual terminal to kill(1) that qemu

[Qemu-devel] [PATCH v2 0/4] intel_iommu: misc fixes for error exposed after error_report_once()

2019-01-15 Thread Peter Xu
v2: - dropping the last vfio patch - add acked-by for Jason on 1&2 patches Recently we have switched quite a few VT-d trace points into error_report_once()s and this does expose some errors that we didn't detect before (previously tracepoints won't trigger as long as tracepoints weren't enabled).

[Qemu-devel] [PATCH v2 1/4] intel_iommu: fix operator in vtd_switch_address_space

2019-01-15 Thread Peter Xu
When calculating use_iommu, we wanted to first detect whether DMAR is enabled, then check whether PT is enabled if DMAR is enabled. However in the current code we used "&" rather than "&&" so the ordering requirement is lost (instead it'll be an "AND" operation). This could introduce errors

[Qemu-devel] [PATCH v2 4/4] i386/kvm: ignore masked irqs when update msi routes

2019-01-15 Thread Peter Xu
When we are with intel-iommu device and with IR on, KVM will register an IEC notifier to detect interrupt updates from the guest and we'll kick off kvm_update_msi_routes_all() when it happens to make sure kernel IRQ cache is matching the latest. Though, kvm_update_msi_routes_all() is buggy in

[Qemu-devel] [PATCH v2 2/4] intel_iommu: reset intr_enabled when system reset

2019-01-15 Thread Peter Xu
This is found when I was debugging another problem. Until now no bug is reported with this but we'd better reset the IR status correctly after a system reset. Acked-by: Jason Wang Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PATCH v2 3/4] pci/msi: export msi_is_masked()

2019-01-15 Thread Peter Xu
It is going to be used later on outside MSI code to detect whether one MSI vector is masked out. Signed-off-by: Peter Xu --- hw/pci/msi.c | 2 +- include/hw/pci/msi.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/pci/msi.c b/hw/pci/msi.c index

Re: [Qemu-devel] [RFC] Questions on the I/O performance of emulated host cdrom device

2019-01-15 Thread Ying Fang
On 2019/1/16 4:15, John Snow wrote: > > > On 1/8/19 10:20 PM, Ying Fang wrote: >> >> >> On 2019/1/8 20:46, Kevin Wolf wrote: >>> Am 29.12.2018 um 07:33 hat Ying Fang geschrieben: Hi. Recently one of our customer complained about the I/O performance of QEMU emulated host cdrom

Re: [Qemu-devel] Devdax backend for vnvdimm not working

2019-01-15 Thread Yi Zhang
On 2019-01-16 at 09:12:33 +0800, Wei Yang wrote: > On Tue, Jan 15, 2019 at 08:13:27PM +, Kamal Kakri via Qemu-devel wrote: > >Hi, > > > >I have a namespace (backed by real nvdimm h/w) configured in devdax mode: > ># ndctl list -N -n namespace0.0 > >[ > >  { > >    "dev":"namespace0.0", > >   

Re: [Qemu-devel] Devdax backend for vnvdimm not working

2019-01-15 Thread Wei Yang
On Wed, Jan 16, 2019 at 10:18:05AM +0800, Yi Zhang wrote: >On 2019-01-16 at 09:12:33 +0800, Wei Yang wrote: >> On Tue, Jan 15, 2019 at 08:13:27PM +, Kamal Kakri via Qemu-devel wrote: >> >Hi, >> > >> >I have a namespace (backed by real nvdimm h/w) configured in devdax mode: >> ># ndctl list -N

Re: [Qemu-devel] Devdax backend for vnvdimm not working

2019-01-15 Thread Wei Yang
On Tue, Jan 15, 2019 at 08:13:27PM +, Kamal Kakri via Qemu-devel wrote: >Hi, > >I have a namespace (backed by real nvdimm h/w) configured in devdax mode: ># ndctl list -N -n namespace0.0 >[ >  { >    "dev":"namespace0.0", >    "mode":"devdax", >    "map":"dev", >    "size":16909336576, >   

[Qemu-devel] [PULL 7/8] Revert "test-hbitmap: Add non-advancing iter_next tests"

2019-01-15 Thread John Snow
From: Vladimir Sementsov-Ogievskiy This reverts commit 269576848ec3d57d2d958cf5ac69b08c44adf816. The functionality is unused. Drop tests. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Signed-off-by: John Snow --- tests/test-hbitmap.c | 36

[Qemu-devel] [PULL 8/8] Revert "hbitmap: Add @advance param to hbitmap_iter_next()"

2019-01-15 Thread John Snow
From: Vladimir Sementsov-Ogievskiy This reverts commit a33fbb4f8b64226becf502a123733776ce319b24. The functionality is unused. Note: in addition to automatic revert, drop second parameter in hbitmap_iter_next() call from hbitmap_next_dirty_area() too. Signed-off-by: Vladimir

[Qemu-devel] [PULL 0/8] Bitmaps patches

2019-01-15 Thread John Snow
The following changes since commit 4b9f0b0f7c84eea2dfb0d5be3e0254bc91319dbc: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-01-15 17:24:00 +) are available in the Git repository at: https://github.com/jnsnow/qemu.git tags/bitmaps-pull-request

[Qemu-devel] [PULL 2/8] tests: add tests for hbitmap_next_zero with specified end parameter

2019-01-15 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: John Snow --- tests/test-hbitmap.c | 32 1 file changed, 28 insertions(+), 4 deletions(-) diff --git a/tests/test-hbitmap.c b/tests/test-hbitmap.c index

[Qemu-devel] [PULL 6/8] Revert "block/dirty-bitmap: Add bdrv_dirty_iter_next_area"

2019-01-15 Thread John Snow
From: Vladimir Sementsov-Ogievskiy This reverts commit 72d10a94213a954ad569095cb4491f2ae0853c40. The function is unused now. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Signed-off-by: John Snow --- block/dirty-bitmap.c | 55

[Qemu-devel] [PULL 3/8] dirty-bitmap: add bdrv_dirty_bitmap_next_dirty_area

2019-01-15 Thread John Snow
From: Vladimir Sementsov-Ogievskiy The function alters bdrv_dirty_iter_next_area(), which is wrong and less efficient (see further commit "block/mirror: fix and improve do_sync_target_write" for description). Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: John Snow ---

[Qemu-devel] [PULL 5/8] block/mirror: fix and improve do_sync_target_write

2019-01-15 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Use bdrv_dirty_bitmap_next_dirty_area() instead of bdrv_dirty_iter_next_area(), because of the following problems of bdrv_dirty_iter_next_area(): 1. Using HBitmap iterators we should carefully handle unaligned offset, as first call to hbitmap_iter_next() may

[Qemu-devel] [PULL 1/8] dirty-bitmap: improve bdrv_dirty_bitmap_next_zero

2019-01-15 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Add bytes parameter to the function, to limit searched range. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: John Snow --- block/backup.c | 3 ++- block/dirty-bitmap.c | 5 +++-- include/block/dirty-bitmap.h | 3 ++-

[Qemu-devel] [PULL 4/8] tests: add tests for hbitmap_next_dirty_area

2019-01-15 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: John Snow --- tests/test-hbitmap.c | 107 +++ 1 file changed, 107 insertions(+) diff --git a/tests/test-hbitmap.c b/tests/test-hbitmap.c index

Re: [Qemu-devel] [PATCH v3 4/9] qcow2-threads: qcow2_co_do_compress: protect queuing by mutex

2019-01-15 Thread Paolo Bonzini
On 08/01/19 18:06, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2-threads.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/block/qcow2-threads.c b/block/qcow2-threads.c > index 20b2616529..156e0667be

Re: [Qemu-devel] [PATCH] KVM: MMU: fast cleanup D bit based on fast write protect

2019-01-15 Thread Paolo Bonzini
On 12/01/19 09:20, Zhuangyanying wrote: > From: Zhuang Yanying > > Recently I tested live-migration with large-memory guests, find vcpu may hang > for a long time while starting migration, such as 9s for > 2048G(linux-4.20.1+qemu-3.1.0). > The reason is memory_global_dirty_log_start() taking

Re: [Qemu-devel] [RFC PATCH v2 00/37] Support Kconfig in QEMU

2019-01-15 Thread Paolo Bonzini
On 15/01/19 15:10, Yang Zhong wrote: > This Kconfig implementation is rebased from Paolo's branch > https://github.com/bonzini/qemu/commits/kconfig > > I rebased most of patches except other ARCHs board definitions > this time. > https://github.com/yangzhon/qemu/commits/topic/upstream/Kconfig >

Re: [Qemu-devel] [RFC PATCH v2 07/37] hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*

2019-01-15 Thread Paolo Bonzini
On 15/01/19 15:10, Yang Zhong wrote: > CONFIG_PCSPK=y > CONFIG_IDE_ISA=y > CONFIG_CS4231A=y > + > +CONFIG_PPC405=y > +CONFIG_PPC440=y > +CONFIG_MAC_OLDWORLD=y > +CONFIG_MAC_NEWWORLD=y > +CONFIG_VIRTEX= CONFIG_XILINX is "y", so CONFIG_VIRTEX should too. Paolo > diff --git

Re: [Qemu-devel] [PATCH v3 0/4] QEMU changes to do PVH boot

2019-01-15 Thread Paolo Bonzini
On 15/01/19 13:18, Liam Merwick wrote: > For certain applications it is desirable to rapidly boot a KVM virtual > machine. In cases where legacy hardware and software support within the > guest is not needed, QEMU should be able to boot directly into the > uncompressed Linux kernel binary with

Re: [Qemu-devel] [PATCH 0/5] Refactor common PCI IDE functions from CMD646

2019-01-15 Thread John Snow
On 1/10/19 7:36 PM, BALATON Zoltan wrote: > Hello, > > This series is a small refactoring that moves some common PCI IDE io > mem ops functions from the CMD646 model to the PCI IDE model so a > CMD646 specific type can be dropped from PCIIDEState, removes code > duplication from SiI3112 model

Re: [Qemu-devel] [PATCH v2 4/6] s390x/pci: Ignore the unplug call if we already have a release_timer

2019-01-15 Thread Collin Walling
On 1/14/19 5:31 AM, David Hildenbrand wrote: ... otherwise two successive calls to qdev_unplug() (e.g. by an impatient user) will effectively overwrite pbdev->release_timer, resulting in a memory leak. We are already processing the unplug. Does QEMU not have a way to detect if a device is

Re: [Qemu-devel] Devdax backend for vnvdimm not working

2019-01-15 Thread Kamal Kakri via Qemu-devel
My devdax device is 2MB aligned so I dont think this is alignment related.# ndctl list -X -n namespace0.0 [   {     "dev":"namespace0.0",     "mode":"devdax",     "map":"dev",     "size":16909336576,     "uuid":"e5265c0a-d902-41ce-b1d1-87a78c358aa4",     "daxregion":{   "id":0,  

Re: [Qemu-devel] [PATCH v2 3/6] s390x/pci: Always delete and free the release_timer

2019-01-15 Thread Collin Walling
On 1/14/19 5:31 AM, David Hildenbrand wrote: We should always get rid of it. I don't see a reason to keep the timer alive if the devices are going away. This looks like a memory leak. (hmp) device_add virtio-mouse-pci,id=test (hmp) device_del test -> guest notified, timer pending. -> guest does

Re: [Qemu-devel] [PATCH v1 7/8] RISC-V: Add misa.MAFD checks to translate

2019-01-15 Thread Richard Henderson
On 1/15/19 10:58 AM, Alistair Francis wrote: > From: Michael Clark > > Add misa checks for M, A, F and D extensions and if they are > not present generate illegal instructions. This improves > emulation accurary for harts with a limited set of extensions. > > Cc: Palmer Dabbelt > Cc: Sagar

Re: [Qemu-devel] [PATCH v1 5/8] RISC-V: Add priv_ver to DisasContext

2019-01-15 Thread Alistair Francis
On Tue, Jan 15, 2019 at 2:24 PM Richard Henderson wrote: > > On 1/15/19 10:58 AM, Alistair Francis wrote: > > -static void riscv_tr_init_disas_context(DisasContextBase *dcbase, CPUState > > *cs) > > +static void riscv_tr_init_disas_context(DisasContextBase *dcbase, CPUState > > *cpu) > > Why

Re: [Qemu-devel] [PATCH v1 5/8] RISC-V: Add priv_ver to DisasContext

2019-01-15 Thread Richard Henderson
On 1/15/19 10:58 AM, Alistair Francis wrote: > -static void riscv_tr_init_disas_context(DisasContextBase *dcbase, CPUState > *cs) > +static void riscv_tr_init_disas_context(DisasContextBase *dcbase, CPUState > *cpu) Why change this? I know there is variation in the naming, but my preferred

Re: [Qemu-devel] [PATCH 0/2] cpu-exec fixes

2019-01-15 Thread Paolo Bonzini
On 15/01/19 23:00, Richard Henderson wrote: > Reviewed-by: Richard Henderson Queued, thanks. Paolo

Re: [Qemu-devel] [PATCH v1 4/8] RISC-V: Use riscv prefix consistently on cpu helpers

2019-01-15 Thread Richard Henderson
On 1/15/19 10:58 AM, Alistair Francis wrote: > From: Michael Clark > > * Add riscv prefix to raise_exception function > * Add riscv prefix to CSR read/write functions > * Add riscv prefix to signal handler function > * Add riscv prefix to get fflags function > * Remove redundant declaration of

Re: [Qemu-devel] [PATCH] include/fpu/softfloat: Fix compilation with Clang on s390x

2019-01-15 Thread Richard Henderson
On 1/16/19 2:29 AM, Thomas Huth wrote: > ... but at least it gives the same results as the DLGR instruction. The 64-bit > version gives different results - do we have a bug here? Yes, on your inputs. udiv_qrnnd3 requires that D be "normalized", i.e. have the most siginificant bit set. (And thus

Re: [Qemu-devel] [PATCH 0/2] cpu-exec fixes

2019-01-15 Thread Richard Henderson
On 1/16/19 6:47 AM, Emilio G. Cota wrote: > Just a couple of small fixes. > > The first adds an assert that we should have added when performing > the conversion from tb_lock to per-page locks. > > The second adds a missing reset of the BQL after the longjmp in > cpu_exec_step_atomic returns.

Re: [Qemu-devel] [PATCH 9/9] tests/tcg/mips: Test R5900 multimedia instruction SQ

2019-01-15 Thread Aleksandar Markovic
> From: Fredrik Noring > Sent: Sunday, January 13, 2019 8:09 PM > To: Aleksandar Markovic; Aurelien Jarno; Philippe Mathieu-Daudé > Cc: Jürgen Urban; Maciej W. Rozycki; qemu-devel@nongnu.org > Subject: [PATCH 9/9] tests/tcg/mips: Test R5900 multimedia instruction SQ > > Signed-off-by: Fredrik

Re: [Qemu-devel] [RFC PATCH] stm32f103: Add initial skeleton of STM32 F103 SoC

2019-01-15 Thread Alistair Francis
On Sun, Jan 6, 2019 at 1:03 PM Priit Laes wrote: > > On Thu, Jan 03, 2019 at 01:33:08PM -0800, Alistair Francis wrote: > > On Wed, Dec 26, 2018 at 11:08 AM Priit Laes wrote: > > > > > > Initial barebone SoC implementation for STM32F103 > > > with "Blue Pill" board source for testing. > > > > > >

Re: [Qemu-devel] [PATCH 8/9] tests/tcg/mips: Test R5900 multimedia instruction LQ

2019-01-15 Thread Aleksandar Markovic
> From: Fredrik Noring > Sent: Sunday, January 13, 2019 8:08 PM > To: Aleksandar Markovic; Aurelien Jarno; Philippe Mathieu-Daudé > Cc: Jürgen Urban; Maciej W. Rozycki; qemu-devel@nongnu.org > Subject: [PATCH 8/9] tests/tcg/mips: Test R5900 multimedia instruction LQ > > Signed-off-by: Fredrik

Re: [Qemu-devel] [PATCH 11/12] chardev: disallow TLS/telnet/websocket with tcp_chr_wait_connected

2019-01-15 Thread Marc-André Lureau
On Tue, Jan 15, 2019 at 6:54 PM Daniel P. Berrangé wrote: > > In the previous commit > > commit 1dc8a6695c731abb7461c637b2512c3670d82be4 > Author: Marc-André Lureau > Date: Tue Aug 16 12:33:32 2016 +0400 > > char: fix waiting for TLS and telnet connection > > the

Re: [Qemu-devel] [PATCH] hw/core/generic-loader: Fix PC overwriting

2019-01-15 Thread Alistair Francis
On Tue, Jan 15, 2019 at 7:04 AM Julia Suvorova via Qemu-devel wrote: > > If the memory is set using a file, and PC is specified on the command > line, it will be overwritten with the value 'entry'. This is not only > illogical, but also incorrect, because the load_ * functions do not take > into

Re: [Qemu-devel] [PATCH v2 4/4] hw/i386/pc: use PVH option rom

2019-01-15 Thread Paolo Bonzini
On 15/01/19 21:05, Michael S. Tsirkin wrote: > On Tue, Jan 15, 2019 at 01:12:21PM -0600, Eric Blake wrote: >> On 1/15/19 12:57 PM, Michael S. Tsirkin wrote: >>> On Tue, Jan 15, 2019 at 11:00:58AM +0100, Stefano Garzarella wrote: Use pvh.bin option rom when we are booting an uncompressed

Re: [Qemu-devel] [PATCH 5/9] target/mips: Support the R5900 LQ multimedia instruction

2019-01-15 Thread Aleksandar Markovic
> From: Fredrik Noring > Sent: Sunday, January 13, 2019 8:05 PM > To: Aleksandar Markovic; Aurelien Jarno; Philippe Mathieu-Daudé > Cc: Jürgen Urban; Maciej W. Rozycki; qemu-devel@nongnu.org > Subject: [PATCH 5/9] target/mips: Support the R5900 LQ multimedia instruction > > Signed-off-by:

Re: [Qemu-devel] [PATCH 6/9] target/mips: Support the R5900 SQ multimedia instruction

2019-01-15 Thread Aleksandar Markovic
> From: Fredrik Noring > Sent: Sunday, January 13, 2019 8:06 PM > To: Aleksandar Markovic; Aurelien Jarno; Philippe Mathieu-Daudé > Cc: Jürgen Urban; Maciej W. Rozycki; qemu-devel@nongnu.org > Subject: [PATCH 6/9] target/mips: Support the R5900 SQ multimedia instruction > > Signed-off-by:

Re: [Qemu-devel] [PATCH 7/9] tests/tcg/mips: Test R5900 multimedia instructions PCPYUD and PCPYLD

2019-01-15 Thread Aleksandar Markovic
> From: Fredrik Noring > Sent: Sunday, January 13, 2019 8:07 PM > To: Aleksandar Markovic; Aurelien Jarno; Philippe Mathieu-Daudé > Cc: Jürgen Urban; Maciej W. Rozycki; qemu-devel@nongnu.org > Subject: [PATCH 7/9] tests/tcg/mips: Test R5900 multimedia instructions > PCPYUD and PCPYLD > >

Re: [Qemu-devel] [PATCH 4/9] target/mips: Support the R5900 PCPYUD multimedia instruction

2019-01-15 Thread Aleksandar Markovic
> From: Fredrik Noring > Sent: Sunday, January 13, 2019 8:04 PM > To: Aleksandar Markovic; Aurelien Jarno; Philippe Mathieu-Daudé > Cc: Jürgen Urban; Maciej W. Rozycki; qemu-devel@nongnu.org > Subject: [PATCH 4/9] target/mips: Support the R5900 PCPYUD multimedia > instruction > > Signed-off-by:

Re: [Qemu-devel] [PATCH 3/9] target/mips: Support the R5900 PCPYLD multimedia instruction

2019-01-15 Thread Aleksandar Markovic
> From: Fredrik Noring > Sent: Sunday, January 13, 2019 8:03 PM > To: Aleksandar Markovic; Aurelien Jarno; Philippe Mathieu-Daudé > Cc: Jürgen Urban; Maciej W. Rozycki; qemu-devel@nongnu.org > Subject: [PATCH 3/9] target/mips: Support the R5900 PCPYLD multimedia > instruction > > Signed-off-by:

Re: [Qemu-devel] [PATCH 10/12] chardev: honour the reconnect setting in tcp_chr_wait_connected

2019-01-15 Thread Marc-André Lureau
Hi On Tue, Jan 15, 2019 at 6:54 PM Daniel P. Berrangé wrote: > > If establishing a client connection fails, the tcp_chr_wait_connected > method should sleep for the reconnect timeout and then retry the > attempt. This ensures the callers don't immediately abort with an > error when the initial

Re: [Qemu-devel] Hosted CI for FreeBSD - Cirrus CI

2019-01-15 Thread Ed Maste
On Tue, 15 Jan 2019 at 13:58, Ed Maste wrote: > > From the log[1] it looks like it's building the libfdt from dtc/. > Unfortunately I'm unable to dig in deeper into the hosted build (I > have only the logs), and my local build attempts are currently failing > due to unrelated issues. I'll

Re: [Qemu-devel] [RFC PATCH] tests: use g_usleep instead of rem = sleep(time)

2019-01-15 Thread Richard Henderson
On 1/14/19 9:46 PM, Alex Bennée wrote: > Relying on sleep to always return having slept isn't safe as a signal > may have occurred. If signals are constantly incoming the program will > never reach it's termination condition. This is believed to be the > mechanism causing time outs for qht-test in

Re: [Qemu-devel] [PATCH v2 3/4] accel/tcg: Add cluster number to TCG TB hash

2019-01-15 Thread Richard Henderson
On 1/14/19 10:56 PM, Peter Maydell wrote: > Include the cluster number in the hash we use to look > up TBs. This is important because a TB that is valid > for one cluster at a given physical address and set > of CPU flags is not necessarily valid for another: > the two clusters may have different

Re: [Qemu-devel] [PATCH 2/9] target/mips: Introduce 32 R5900 128-bit multimedia registers

2019-01-15 Thread Aleksandar Markovic
> From: Fredrik Noring > Sent: Sunday, January 13, 2019 8:03 PM > To: Aleksandar Markovic; Aurelien Jarno; Philippe Mathieu-Daudé > Cc: Jürgen Urban; Maciej W. Rozycki; qemu-devel@nongnu.org > Subject: [PATCH 2/9] target/mips: Introduce 32 R5900 128-bit multimedia > registers > > The 32 R5900

[Qemu-devel] Devdax backend for vnvdimm not working

2019-01-15 Thread Kamal Kakri via Qemu-devel
Hi, I have a namespace (backed by real nvdimm h/w) configured in devdax mode: # ndctl list -N -n namespace0.0 [   {     "dev":"namespace0.0",     "mode":"devdax",     "map":"dev",     "size":16909336576,     "uuid":"e5265c0a-d902-41ce-b1d1-87a78c358aa4",     "chardev":"dax0.0"   } ] When I try

[Qemu-devel] [Bug 1811782] Re: QEMU Windows fails to mount rootfs on an ISO where QEMU Linux works normally

2019-01-15 Thread Chris Ward
This turned out to be not enough memory allocated to the virtual machine. When I added "-m 1024" to the parameters, all was well. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1811782 Title: QEMU

[Qemu-devel] [Bug 1811888] [NEW] Qemu refuses to multiboot Elf64 kernels

2019-01-15 Thread Lukasz Janyst
Public bug reported: Qemu does not multiboot Elf64 bit kernels when emulating x86_64 systems. This is unfortunate because it renders the `-kernel` option quite useless. It's true that a multiboot compatible bootloader puts you in protected mode by default, and you have to set up the long mode

Re: [Qemu-devel] [PATCH v2 1/1] riscv: Ensure the kernel start address is correctly cast

2019-01-15 Thread Alistair Francis
On Mon, Jan 14, 2019 at 2:58 AM Philippe Mathieu-Daudé wrote: > > Hi Alistair, > > On 1/12/19 2:17 AM, Alistair Francis wrote: > > Cast the kernel start address to the target bit length. > > > > This ensures that we calculate the initrd offset to a valid address for > > the architecture. > > Can

Re: [Qemu-devel] [PATCH 09/12] chardev: use a state machine for socket connection state

2019-01-15 Thread Marc-André Lureau
Hi On Tue, Jan 15, 2019 at 6:54 PM Daniel P. Berrangé wrote: > > The socket connection state is indicated via the 'bool connected' field > in the SocketChardev struct. This variable is somewhat misleading > though, as it is only set to true once the connection has completed all > required

Re: [Qemu-devel] [PATCH 1/9] target/mips: Require TARGET_MIPS64 for R5900 multimedia instructions

2019-01-15 Thread Aleksandar Markovic
> From: Fredrik Noring > Sent: Sunday, January 13, 2019 8:02 PM > To: Aleksandar Markovic; Aurelien Jarno; Philippe Mathieu-Daudé > Cc: Jürgen Urban; Maciej W. Rozycki; qemu-devel@nongnu.org > Subject: [PATCH 1/9] target/mips: Require TARGET_MIPS64 for R5900 multimedia > instructions > > The

Re: [Qemu-devel] [PATCH 08/12] chardev: split up qmp_chardev_open_socket connection code

2019-01-15 Thread Marc-André Lureau
On Tue, Jan 15, 2019 at 6:53 PM Daniel P. Berrangé wrote: > > In qmp_chardev_open_socket the code for connecting client chardevs is > split across two conditionals far apart with some server chardev code in > the middle. Split up the method so that code for client connection setup > is separate

Re: [Qemu-devel] [PATCH 11/14] tests: acpi: add AVMF firmware blobs

2019-01-15 Thread Laszlo Ersek
On 01/15/19 16:41, Igor Mammedov wrote: > Add firmware blobs built with PcdAcpiTestSupport=TRUE, > that puts RSDP address in RAM after 1Mb aligned GUID > AB87A6B1-2034-BDA0-71BD-375007757785 > so that tests could scan and find it in RAM once firmware's > initialized ACPI tables. > >

Re: [Qemu-devel] [PATCH v2 1/6] s390x/pci: Use hotplug_dev instead of looking up the host bridge

2019-01-15 Thread Collin Walling
On 1/14/19 5:31 AM, David Hildenbrand wrote: We directly have it in our hands. Signed-off-by: David Hildenbrand --- hw/s390x/s390-pci-bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index 7f911b216a..86dda831f9

[Qemu-devel] [PULL v2 48/49] migration: Fix stringop-truncation warning

2019-01-15 Thread Michael S. Tsirkin
From: Marc-André Lureau GCC 8 added a -Wstringop-truncation warning: The -Wstringop-truncation warning added in GCC 8.0 via r254630 for bug 81117 is specifically intended to highlight likely unintended uses of the strncpy function that truncate the terminating NUL character from the

Re: [Qemu-devel] [PATCH v3 0/5] kvm "virtio pmem" device

2019-01-15 Thread Dave Chinner
On Tue, Jan 15, 2019 at 12:35:06AM -0500, Pankaj Gupta wrote: > > > > > On Mon, Jan 14, 2019 at 02:15:40AM -0500, Pankaj Gupta wrote: > > > > > > > > > > > > Until you have images (and hence host page cache) shared between > > > > > > > multiple guests. People will want to do this, because it

Re: [Qemu-devel] [PATCH] egl-helpers.h: add a missing X11 include

2019-01-15 Thread Alexander Kanavin
On Tue, 15 Jan 2019 at 20:58, Philippe Mathieu-Daudé wrote: > Cc'ing Gerd (the maintainer) and Marc-André. > > On 1/15/19 12:50 PM, Alexander Kanavin wrote: > > Otherwise these errors occur, when qemu is built in the Yocto project: > > | In file included from > >

[Qemu-devel] [PULL v2 47/49] hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays

2019-01-15 Thread Michael S. Tsirkin
From: Philippe Mathieu-Daudé GCC 8 added a -Wstringop-truncation warning: The -Wstringop-truncation warning added in GCC 8.0 via r254630 for bug 81117 is specifically intended to highlight likely unintended uses of the strncpy function that truncate the terminating NUL character from

[Qemu-devel] [PULL v2 49/49] migration: Use strnlen() for fixed-size string

2019-01-15 Thread Michael S. Tsirkin
From: Philippe Mathieu-Daudé GCC 8 introduced the -Wstringop-overflow, which detect buffer overflow by string-modifying functions declared in , such strncpy(), used in global_state_store_running(). GCC indeed found an incorrect use of strlen(), because this array is loaded by

[Qemu-devel] [PULL v2 40/49] acpi: build TPM Physical Presence interface

2019-01-15 Thread Michael S. Tsirkin
From: Stefan Berger The TPM Physical Presence interface consists of an ACPI part, a shared memory part, and code in the firmware. Users can send messages to the firmware by writing a code into the shared memory through invoking the ACPI code. When a reboot happens, the firmware looks for the

[Qemu-devel] [PULL v2 32/49] virtio: split virtio crypto bits from virtio-pci.h

2019-01-15 Thread Michael S. Tsirkin
From: Juan Quintela Reviewed-by: Laurent Vivier Signed-off-by: Juan Quintela Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.h| 14 -- hw/virtio/virtio-crypto-pci.c | 14 ++ 2 files changed, 14 insertions(+), 14

  1   2   3   4   >