Re: [Qemu-devel] [PATCH 5/8] target/mips: Provide R/W access to SAARI and SAAR CP0 registers

2019-01-18 Thread Aleksandar Markovic
On Thursday, January 17, 2019, Stefan Markovic wrote: > > On 3.1.19. 17:34, Aleksandar Markovic wrote: > > From: Yongbok Kim > > > > Provide R/W access to SAARI and SAAR CP0 registers. > > > > Signed-off-by: Yongbok Kim > > Signed-off-by: Aleksandar Markovic > > --- > > target/mips/cpu.h

[Qemu-devel] [PATCH v1] GLib sucks - Remove any connections between me and GLib

2019-01-18 Thread Michael Clark via Qemu-devel
One has a basic command of English but one cannot think of a more or less glib commit message for this commit so this is it. Palmer, I would like to send you an invoice for this commit but I do not know what value to place on it. 2^64-1, (-1) or 0x in hex, sounds too little or too

Re: [Qemu-devel] [PATCH 1/8] target/mips: Move comment containing summary of CP0 registers

2019-01-18 Thread Aleksandar Markovic
On Thursday, January 17, 2019, Stefan Markovic wrote: > > On 3.1.19. 17:34, Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > > > Move comment containing summary of CP0 registers. Checkpatch > > script reported some tabs in the resutling diff, so convert > > these tabs to spaces too.

Re: [Qemu-devel] [PATCH 10/14] tests: acpi: ignore SMBIOS tests when UEFI firmware is used

2019-01-18 Thread Laszlo Ersek
On 01/17/19 16:11, Igor Mammedov wrote: > On Wed, 16 Jan 2019 17:22:31 +0100 > Laszlo Ersek wrote: > >> On 01/16/19 13:31, Igor Mammedov wrote: >>> On Wed, 16 Jan 2019 12:52:17 +0100 >>> Gerd Hoffmann wrote: >>> Hi, > This approach allows the UEFI app source to live in the

Re: [Qemu-devel] [PATCH 11/14] tests: acpi: add AVMF firmware blobs

2019-01-18 Thread Laszlo Ersek
On 01/17/19 15:09, Gerd Hoffmann wrote: > On Thu, Jan 17, 2019 at 01:54:51PM +0100, Laszlo Ersek wrote: >> On 01/17/19 11:22, Gerd Hoffmann wrote: >>> Hi, >>> create mode 100644 pc-bios/avmf.img create mode 100644 pc-bios/avmf_vars.img >>> >>> "AVMF" is not a great

Re: [Qemu-devel] [PATCH v7 3/3] tcg/i386: enable dynamic TLB sizing

2019-01-18 Thread Richard Henderson
On 1/19/19 2:04 AM, Alex Bennée wrote: > > Emilio G. Cota writes: > >> As the following experiments show, this series is a net perf gain, >> particularly for memory-heavy workloads. Experiments are run on an >> Intel(R) Xeon(R) Gold 6142 CPU @ 2.60GHz. >> >> 1. System boot + shudown, debian

Re: [Qemu-devel] [PATCH v2 3/4] trace: forbid use of %m in trace event format strings

2019-01-18 Thread Alex Williamson
On Fri, 18 Jan 2019 11:50:39 -0600 Eric Blake wrote: > On 1/18/19 11:31 AM, Daniel P. Berrangé wrote: > > The '%m' format specifier instructs glibc's printf() implementation to > > insert the contents of strerror(errno). > > That is a glibc-only extension in printf(), but mandatory (and

Re: [Qemu-devel] [PATCH v4 00/21] nbd: add qemu-nbd --list

2019-01-18 Thread Eric Blake
On 1/18/19 7:47 AM, Vladimir Sementsov-Ogievskiy wrote: > > > Only expose MBR partition @var{num}. Understands physical partitions > > 1-4 and logical partitions 5-8. > > I'm afraid, I'm too lazy to sort out these things I don't know, so just > believe. It at least > corresponds to limits

Re: [Qemu-devel] [RFC] Questions on the I/O performance of emulated host cdrom device

2019-01-18 Thread John Snow
On 1/15/19 9:48 PM, Ying Fang wrote: > > > On 2019/1/16 4:15, John Snow wrote: >> >> >> On 1/8/19 10:20 PM, Ying Fang wrote: >>> >>> >>> On 2019/1/8 20:46, Kevin Wolf wrote: Am 29.12.2018 um 07:33 hat Ying Fang geschrieben: > Hi. > Recently one of our customer complained about

[Qemu-devel] [PATCH 5/5] tests/data: introduce "uefi-boot-images" with the "bios-tables-test" ISOs

2019-01-18 Thread Laszlo Ersek
Add UEFI-bootable qcow2-compressed ISO images built from: tests/uefi-test-tools/UefiTestToolsPkg/BiosTablesTest Cc: "Michael S. Tsirkin" Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Igor Mammedov Cc: Philippe Mathieu-Daudé Cc: Shannon Zhao Signed-off-by: Laszlo Ersek --- Notes: Again,

[Qemu-devel] [PATCH 4/5] tests/uefi-test-tools: add build scripts

2019-01-18 Thread Laszlo Ersek
Introduce the following build scripts under "tests/uefi-test-tools": * "build.sh" builds a single module (a UEFI application) from UefiTestToolsPkg, for a single QEMU emulation target. "build.sh" relies on cross-compilers when the emulation target and the build host architecture don't

[Qemu-devel] [PATCH 2/5] roms: build the EfiRom utility from the roms/edk2 submodule

2019-01-18 Thread Laszlo Ersek
Building the EfiRom utility from "roms/edk2/BaseTools" should make "roms/Makefile" more self-contained. Otherwise, we'd call the system-wide EfiRom for building the combined iPXE option ROMs, but call the sibling utilities from "roms/edk2/BaseTools" for building "roms/edk2" content. Cc: "Michael

[Qemu-devel] [PATCH 3/5] tests: introduce "uefi-test-tools" with the BiosTablesTest UEFI app

2019-01-18 Thread Laszlo Ersek
The "bios-tables-test" program in QEMU's test suite locates the RSD PTR ACPI table in guest RAM, and (chasing pointers to other ACPI tables) performs various sanity checks on the QEMU-generated and firmware-installed tables. Currently this set of test cases doesn't work with UEFI guests. The ACPI

[Qemu-devel] [PATCH 1/5] roms: add the edk2 project as a git submodule

2019-01-18 Thread Laszlo Ersek
The roms/edk2 submodule can help with three goals: - build the OVMF and ArmVirtQemu virtual UEFI firmware platforms (to be implemented later), - build the EfiRom tool on the fly, which is used in roms/Makefile, for building the "efirom" target, - build UEFI test applications (to be run in

[Qemu-devel] [PATCH 0/5] add the BiosTablesTest UEFI app, build it with the new roms/edk2 submodule

2019-01-18 Thread Laszlo Ersek
Igor's series [Qemu-devel] [PATCH 00/14] tests: acpi: add UEFI (ARM) testing support 1547566866-129386-1-git-send-email-imammedo@redhat.com">http://mid.mail-archive.com/1547566866-129386-1-git-send-email-imammedo@redhat.com worked with my edk2 (guest firmware) series [edk2] [PATCH 0/4]

[Qemu-devel] [PATCH] fw_cfg: fix the life cycle and the name of "qemu_extra_params_fw"

2019-01-18 Thread Laszlo Ersek
Commit 19bcc4bc3213 ("fw_cfg: Make qemu_extra_params_fw locally", 2019-01-04) changed the storage duration of the "qemu_extra_params_fw" array from static to automatic. This broke the interface contract on the fw_cfg_add_file() function, which is documented as follows, in

Re: [Qemu-devel] [PATCH] target/s390x: define TCG_GUEST_DEFAULT_MO for MTTCG

2019-01-18 Thread Richard Henderson
On 1/19/19 4:18 AM, Alex Bennée wrote: > MTTCG should be enabled by default whenever the memory model allows > it. s390x was missing its definition of TCG_GUEST_DEFAULT_MO meaning > the user had to manually specify --accel tcg,thread=multi. > > Signed-off-by: Alex Bennée > Cc: David Hildenbrand

Re: [Qemu-devel] [PATCH v10 14/14] target/arm: Send interrupts on PMU counter overflow

2019-01-18 Thread Aaron Lindsay
On Jan 18 07:26, Richard Henderson wrote: > On 12/12/18 2:20 AM, Aaron Lindsay wrote: > > Setup a QEMUTimer to get a callback when we expect counters to next > > overflow and trigger an interrupt at that time. > > > > Signed-off-by: Aaron Lindsay > > Signed-off-by: Aaron Lindsay > > --- > >

[Qemu-devel] [PATCH v6 47/49] linux-user: Move syscall_init to the end

2019-01-18 Thread Richard Henderson
No functional change. This will aid moving everything related to ioctls to a separate file. Signed-off-by: Richard Henderson --- linux-user/syscall.c | 113 +++ 1 file changed, 61 insertions(+), 52 deletions(-) diff --git a/linux-user/syscall.c

[Qemu-devel] [PATCH v6 44/49] linux-user: Split out pipe, pipe2

2019-01-18 Thread Richard Henderson
Note that pipe2 is universally available for guests. Implement host support with syscall when !CONFIG_PIPE2. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 10 ++ linux-user/syscall-file.inc.c | 51 +++ linux-user/syscall.c | 65

[Qemu-devel] [PATCH v6 40/49] linux-user: Split out kill

2019-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h| 1 + linux-user/syscall.h | 7 +++- linux-user/strace.c | 76 ++-- linux-user/syscall-sig.inc.c | 5 +++ linux-user/syscall.c | 2 - linux-user/strace.list | 3

[Qemu-devel] [PATCH v6 33/49] linux-user: Split out umount, umount2

2019-01-18 Thread Richard Henderson
Note that umount2 is unconditionally available. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 4 linux-user/syscall.h | 1 + linux-user/strace.c | 30 -- linux-user/syscall-file.inc.c | 25 +

[Qemu-devel] [PATCH v6 29/49] linux-user: Split out chmod, fchmod, fchmodat

2019-01-18 Thread Richard Henderson
Note that fchmodat is universally provided. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 5 + linux-user/strace.c | 28 linux-user/syscall-file.inc.c | 30 ++ linux-user/syscall.c | 18

[Qemu-devel] [PATCH v6 28/49] linux-user: Split out mknod, mknodat

2019-01-18 Thread Richard Henderson
Note that mknodat is universally provided. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 4 linux-user/strace.c | 39 --- linux-user/syscall-file.inc.c | 26 +++ linux-user/syscall.c | 16

[Qemu-devel] [PATCH v6 24/49] linux-user: Split out execve

2019-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 1 + linux-user/strace.c | 32 -- linux-user/syscall-proc.inc.c | 110 ++ linux-user/syscall.c | 97 -- linux-user/strace.list|

[Qemu-devel] [PATCH v6 42/49] linux-user: Split out mkdir, mkdirat

2019-01-18 Thread Richard Henderson
Note that mkdirat is universally available. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 4 linux-user/strace.c | 27 --- linux-user/syscall-file.inc.c | 25 + linux-user/syscall.c | 16

Re: [Qemu-devel] [PATCH v10 14/14] target/arm: Send interrupts on PMU counter overflow

2019-01-18 Thread Richard Henderson
On 1/19/19 8:40 AM, Aaron Lindsay wrote: > In practice, I think only the 32nd bit would ever need to be cleared, > but I agree it is more correct to clear them all. > >> Given that it is architecturally defined to 32-bits, I think you could really >> just drop the define and use >> >>

[Qemu-devel] [PATCH v6 41/49] linux-user: Split out rename, renameat, renameat2

2019-01-18 Thread Richard Henderson
Note that renameat2 is universally available for guests. Merge sys_renameat2 into the new do_renameat2 helper. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 8 + linux-user/syscall.h | 1 + linux-user/strace.c | 39 ++---

[Qemu-devel] [PATCH v6 26/49] linux-user: Split out chdir

2019-01-18 Thread Richard Henderson
Note that chdir is universally provided. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 1 + linux-user/strace.c | 12 linux-user/syscall-file.inc.c | 14 ++ linux-user/syscall.c | 6 -- linux-user/strace.list| 3

[Qemu-devel] [PATCH v6 37/49] linux-user: Split out access, faccessat

2019-01-18 Thread Richard Henderson
Note that faccessat is unconditionally available. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 4 linux-user/syscall.h | 1 + linux-user/strace.c | 33 - linux-user/syscall-file.inc.c | 25

[Qemu-devel] [PATCH v6 48/49] linux-user: Split out ioctl

2019-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 1 + linux-user/syscall-ioctl.inc.c | 873 + linux-user/syscall.c | 843 +-- linux-user/strace.list | 3 - 4 files changed, 875 insertions(+),

[Qemu-devel] [PATCH v6 21/49] linux-user: Split out creat

2019-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 3 +++ linux-user/strace.c | 13 - linux-user/syscall-file.inc.c | 16 linux-user/syscall.c | 9 - linux-user/strace.list| 3 --- 5 files changed, 19

[Qemu-devel] [PATCH v6 20/49] linux-user: Implement rusage argument to waitid

2019-01-18 Thread Richard Henderson
The kernel interface, which we are supposed to be implementing, takes a fifth argument: an rusage pointer akin to wait4. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 2 +- linux-user/syscall-proc.inc.c | 27 +++ 2 files changed, 20 insertions(+),

[Qemu-devel] [PATCH v6 34/49] linux-user: Split out stime

2019-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 3 +++ linux-user/syscall-time.inc.c | 12 linux-user/syscall.c | 9 - linux-user/strace.list| 3 --- 4 files changed, 15 insertions(+), 12 deletions(-) diff --git

[Qemu-devel] [PATCH v6 49/49] linux-user: Split out fcntl, fcntl64

2019-01-18 Thread Richard Henderson
Preserving strace functionality is tricky with this one. Rearrange to lookup structures that contain the data for both execution and strace for each command. Do not allow lookup of 64-bit fcntl commands from 32-bit fcntl. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h |

[Qemu-devel] [PATCH v6 31/49] linux-user: Split out getpid, getppid, getxpid

2019-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 9 + linux-user/syscall-proc.inc.c | 23 +++ linux-user/syscall.c | 14 -- linux-user/strace.list| 9 - 4 files changed, 32 insertions(+), 23 deletions(-) diff

[Qemu-devel] [PATCH v6 19/49] linux-user: Split out wait4, waitid, waitpid

2019-01-18 Thread Richard Henderson
Note that waitid is universally provided and need not be conditional. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 5 ++ linux-user/syscall-proc.inc.c | 88 +++ linux-user/syscall.c | 67 --

[Qemu-devel] [PATCH v6 45/49] linux-user: Split out times

2019-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 1 + linux-user/syscall-proc.inc.c | 25 + linux-user/syscall.c | 18 -- linux-user/strace.list| 3 --- 4 files changed, 26 insertions(+), 21 deletions(-) diff --git

[Qemu-devel] [PATCH v6 13/49] linux-user: Split out name_to_handle_at, open_by_handle_at

2019-01-18 Thread Richard Henderson
All targets have these syscalls, so they need not be ifdefed. If we provide safe syscalls for the host, we can remove the configure test for this too. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 3 + linux-user/syscall.h | 1 + linux-user/strace.c

[Qemu-devel] [PATCH v6 46/49] linux-user: Split out acct

2019-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 1 + linux-user/syscall-file.inc.c | 18 ++ linux-user/syscall.c | 11 --- linux-user/strace.list| 3 --- 4 files changed, 19 insertions(+), 14 deletions(-) diff --git

[Qemu-devel] [PATCH v6 30/49] linux-user: Split out lseek, llseek

2019-01-18 Thread Richard Henderson
Canonicalise the target syscall name on llseek (new kernels) instead of _llseek (old kernels). Always use host lseek(3) rather than attempting to use the host llseek(2). Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 6 ++ linux-user/syscall.h | 1 +

[Qemu-devel] [PATCH v6 39/49] linux-user: Split out sync, syncfs

2019-01-18 Thread Richard Henderson
Note that syncfs is universally available. If !CONFIG_SYNCFS, provide our own syscall replacement. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 2 ++ linux-user/syscall-file.inc.c | 11 +++ linux-user/syscall.c | 20

[Qemu-devel] [PATCH v6 43/49] linux-user: Split out dup, dup2, dup3

2019-01-18 Thread Richard Henderson
Note that dup3 is universally available for guests. Implement host support with syscall when !CONFIG_DUP3. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 5 + linux-user/syscall-file.inc.c | 42 +++ linux-user/syscall.c | 33

[Qemu-devel] [PATCH v6 11/49] linux-user: Split out pread64, pwrite64

2019-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 6 linux-user/syscall-file.inc.c | 62 +++ linux-user/syscall.c | 36 linux-user/strace.list| 6 4 files changed, 68 insertions(+), 42

[Qemu-devel] [PATCH v6 23/49] linux-user: Split out unlink, unlinkat, rmdir

2019-01-18 Thread Richard Henderson
Note that unlinkat is universally provided. Implement rmdir in terms of unlinkat. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 7 ++ linux-user/syscall.h | 1 + linux-user/strace.c | 43 ---

[Qemu-devel] [PATCH v6 35/49] linux-user: Split out alarm, pause

2019-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h| 6 ++ linux-user/syscall-sig.inc.c | 36 linux-user/syscall.c | 12 +--- linux-user/strace.list | 6 -- 4 files changed, 43 insertions(+), 17 deletions(-)

[Qemu-devel] [PATCH v6 38/49] linux-user: Split out nice

2019-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 3 +++ linux-user/syscall-proc.inc.c | 7 +++ linux-user/syscall.c | 4 linux-user/strace.list| 3 --- 4 files changed, 10 insertions(+), 7 deletions(-) diff --git a/linux-user/syscall-defs.h

[Qemu-devel] [PATCH v6 32/49] linux-user: Split out mount

2019-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 1 + linux-user/syscall.h | 1 + linux-user/strace.c | 21 +++-- linux-user/syscall-file.inc.c | 48 ++ linux-user/syscall.c | 55

[Qemu-devel] [PATCH v6 22/49] linux-user: Split out link, linkat

2019-01-18 Thread Richard Henderson
Note that linkat is universally provided. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 4 linux-user/strace.c | 29 - linux-user/syscall-file.inc.c | 28 linux-user/syscall.c | 32

[Qemu-devel] [PATCH v6 03/49] linux-user: Split out open, open_at

2019-01-18 Thread Richard Henderson
For the moment, leave a forward declaration for is_proc_myself until the readlink syscalls are also moved to syscall-file.inc.c. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 5 + linux-user/strace.c | 35 linux-user/syscall-file.inc.c | 319

[Qemu-devel] [PATCH v6 15/49] linux-user: Split out memory syscalls

2019-01-18 Thread Richard Henderson
This includes mmap, mmap2, munmap, mlock, mlockall, munlock, munlockall, mprotect, mremap, msync. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h| 24 ++ linux-user/syscall.h | 2 + linux-user/strace.c | 55 ++--- linux-user/syscall-mem.inc.c

[Qemu-devel] [PATCH v6 36/49] linux-user: Split out utime, utimes, futimesat

2019-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 9 linux-user/strace.c | 41 --- linux-user/syscall-file.inc.c | 95 +++ linux-user/syscall.c | 63 --- linux-user/strace.list| 9

[Qemu-devel] [PATCH v6 01/49] linux-user: Setup split syscall infrastructure

2019-01-18 Thread Richard Henderson
Defines a unified structure for implementation and strace. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 17 ++ linux-user/syscall.h | 89 + linux-user/strace.c | 388 +++--- linux-user/syscall.c | 103 +- 4

[Qemu-devel] [PATCH v6 18/49] linux-user: Split out clone, fork, vfork

2019-01-18 Thread Richard Henderson
Rename do_fork to do_clone, since that is what it does. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 8 ++ linux-user/syscall.h | 1 + linux-user/strace.c | 36 + linux-user/syscall-proc.inc.c | 259 ++

[Qemu-devel] [PATCH v6 27/49] linux-user: Split out time

2019-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 3 +++ linux-user/syscall-time.inc.c | 32 linux-user/syscall.c | 13 + linux-user/strace.list| 3 --- 4 files changed, 36 insertions(+), 15 deletions(-) create

[Qemu-devel] [PATCH v6 16/49] linux-user: Split out exit

2019-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 1 + linux-user/syscall-proc.inc.c | 61 +++ linux-user/syscall.c | 38 +- 3 files changed, 63 insertions(+), 37 deletions(-) create mode 100644

[Qemu-devel] [PATCH v6 08/49] linux-user: Split out read, write

2019-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 2 ++ linux-user/syscall-file.inc.c | 58 +++ linux-user/syscall.c | 34 linux-user/strace.list| 6 4 files changed, 60 insertions(+), 40 deletions(-)

[Qemu-devel] [PATCH v6 14/49] linux-user: Split out ipc syscalls

2019-01-18 Thread Richard Henderson
Because of the ipc multiplex syscall, these must be done all at once. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h| 38 ++ linux-user/strace.c | 83 --- linux-user/syscall-ipc.inc.c | 1086 ++ linux-user/syscall.c | 972

[Qemu-devel] [PATCH v6 25/49] linux-user: Implement execveat

2019-01-18 Thread Richard Henderson
A trivial extension to our current execve implementation to support the new(ish) syscall. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 1 + linux-user/syscall-proc.inc.c | 19 ++- linux-user/syscall.c | 3 ++- linux-user/strace.list| 3

[Qemu-devel] [PATCH v6 10/49] linux-user: Split out readv, writev

2019-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 2 ++ linux-user/syscall-file.inc.c | 34 ++ linux-user/syscall.c | 22 -- linux-user/strace.list| 6 -- 4 files changed, 36 insertions(+), 28

[Qemu-devel] [PATCH v6 06/49] linux-user: Split out readlink, readlinkat

2019-01-18 Thread Richard Henderson
Split out a shared implementation for both of these; unify the best parts of /proc/self/exe checking. Remove the temporary forward declaration for is_proc_self. Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 6 linux-user/strace.c | 29 --

[Qemu-devel] [PATCH v6 17/49] linux-user: Split out brk

2019-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h| 3 ++ linux-user/strace.c | 35 -- linux-user/syscall-mem.inc.c | 90 ++ linux-user/syscall.c | 93 linux-user/strace.list

[Qemu-devel] [PATCH v6 07/49] linux-user: Split out close

2019-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 1 + linux-user/syscall-file.inc.c | 8 linux-user/syscall.c | 4 linux-user/strace.list| 3 --- 4 files changed, 9 insertions(+), 7 deletions(-) diff --git a/linux-user/syscall-defs.h

[Qemu-devel] [PATCH v6 12/49] linux-user: Split out preadv, pwritev

2019-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 6 linux-user/syscall-file.inc.c | 64 +++ linux-user/syscall.c | 49 --- linux-user/strace.list| 6 4 files changed, 70 insertions(+), 55

[Qemu-devel] [PATCH v6 04/49] linux-user: Share more code for open and openat

2019-01-18 Thread Richard Henderson
The do_openat helper can have all of the code that is not directly related to the argument ordering of these two syscalls. Signed-off-by: Richard Henderson --- linux-user/syscall-file.inc.c | 69 --- 1 file changed, 31 insertions(+), 38 deletions(-) diff --git

[Qemu-devel] [PATCH v6 09/49] linux-user: Reduce regpairs_aligned & target_offset64 ifdefs

2019-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/syscall.c | 54 1 file changed, 25 insertions(+), 29 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index d4d5c25803..c236a80437 100644 --- a/linux-user/syscall.c +++

[Qemu-devel] [PATCH v6 00/49] linux-user: Split do_syscall

2019-01-18 Thread Richard Henderson
Since v5, I've split the patches into smaller pieces, and done a few more syscalls. But I've also been approaching them in a more "systematic" way -- taking from the top of the switch. I've been trying to fix up checkpatch failures as I've moved code, but I've surely missed some. I've also been

[Qemu-devel] [PATCH v6 05/49] linux-user: Tidy do_openat loop over fakes

2019-01-18 Thread Richard Henderson
Cleaner to use ARRAY_SIZE to loop over elements instead of using a sentinel within the data structure. Signed-off-by: Richard Henderson --- linux-user/syscall-file.inc.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/linux-user/syscall-file.inc.c

Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes

2019-01-18 Thread Emilio G. Cota
On Fri, Jan 18, 2019 at 17:41:15 +, Alex Bennée wrote: > > Emilio G. Cota writes: > > > On Thu, Jan 17, 2019 at 18:55:33 +, Peter Maydell wrote: > >> On Thu, 17 Jan 2019 at 18:30, Emilio G. Cota wrote: > >> > What are the contents of "int-to-float.err"? > >> > >> linux1@lxub05:~$ cat

Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes

2019-01-18 Thread Alex Bennée
Peter Maydell writes: > On Fri, 18 Jan 2019 at 18:16, Emilio G. Cota wrote: >> >> On Fri, Jan 18, 2019 at 17:00:17 +, Alex Bennée wrote: >> > Philippe Mathieu-Daudé writes: >> > > Can you modify the Makefile.include to use: >> > > "fp-test ... 2>int-to-float.err || {cat int-to-float.err

Re: [Qemu-devel] [PATCH] qemu-gdb: add a QObject pretty printer

2019-01-18 Thread Eduardo Habkost
On Fri, Jan 18, 2019 at 05:48:43PM +0400, Marc-André Lureau wrote: > Inspired by GObject/GType pretty printer. > > Example: > machine_set_accel (obj=0x56807550 [pc-i440fx-4.0-machine],... > > Signed-off-by: Marc-André Lureau > --- > scripts/qemu-gdb.py | 58

Re: [Qemu-devel] Live migration from Qemu 2.12 hosts to Qemu 3.2 hosts, with VMX flag enabled in the guest?

2019-01-18 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 18/01/19 14:41, Mark Mielke wrote: > > It is useful to understand the risk. However, this is the same risk we > > have been successfully living with for several years now, and it seems > > abrupt to declare 3.1 and 3.2 as the Qemu version beyond

Re: [Qemu-devel] [RFC PATCH v3 28/43] hw/pci/Makefile.objs: make pcie configurable

2019-01-18 Thread Michael S. Tsirkin
On Fri, Jan 18, 2019 at 06:28:37PM +0100, Paolo Bonzini wrote: > > > I think PCIE should depend on PCI or something like this. > That's because there are places in code that test CONFIG_PCI, > you want PCIE to enable them as well. > > > I agree, it should select PCI, so that PCIe

Re: [Qemu-devel] [RFC PATCH v3 29/43] build: convert pci.mak to Kconfig

2019-01-18 Thread Michael S. Tsirkin
On Fri, Jan 18, 2019 at 06:03:46PM +0100, Paolo Bonzini wrote: > On 18/01/19 17:36, Michael S. Tsirkin wrote: > >> config PCI_GENERIC > >> bool > >> +select PCIE > >> > > > > why is this? > > > > PCI_GENERIC is hw/pci-host/gpex.c, the "QEMU Generic PCI Express Bridge > Emulation".

Re: [Qemu-devel] [PATCH] hw/virtio/virtio-balloon: zero-initialize the virtio_balloon_config struct

2019-01-18 Thread Michael S. Tsirkin
On Fri, Jan 18, 2019 at 06:36:03PM +, Peter Maydell wrote: > In virtio_balloon_get_config() we initialize a struct virtio_balloon_config > which we then copy to guest memory. However, the local variable is not > zero initialized. This works OK at the moment because we initialize > all the

Re: [Qemu-devel] [PULL 00/11] s390x updates

2019-01-18 Thread Peter Maydell
in the Git repository at: > > https://github.com/cohuck/qemu tags/s390x-20190118 > > for you to fetch changes up to 6e92c70c37547b6a247a206651dfcc583a57f484: > > s390x/pci: add common function measurement block (2019-01-18 11:52:01 +0100) > > ---

[Qemu-devel] [PATCH] tests: Disable ipmi-bt-test

2019-01-18 Thread Peter Maydell
The ipmi-bt-test fails intermittently, especially on the NetBSD VM. The frequency of this failure has recently gone up sharply to the point that I'm having to retry the NetBSD build multiple times to get a pass when merging pull requests. Disable the test until we can figure out why it's failing.

[Qemu-devel] [PATCH] hw/virtio/virtio-balloon: zero-initialize the virtio_balloon_config struct

2019-01-18 Thread Peter Maydell
In virtio_balloon_get_config() we initialize a struct virtio_balloon_config which we then copy to guest memory. However, the local variable is not zero initialized. This works OK at the moment because we initialize all the fields in it; however an upcoming kernel header change will add some new

Re: [Qemu-devel] [PULL v3 00/28] ivshmem deprecation, qtests, typedefs and gnu99

2019-01-18 Thread Peter Maydell
On Fri, 18 Jan 2019 at 18:26, Philippe Mathieu-Daudé wrote: > > On 1/18/19 3:20 PM, Peter Maydell wrote: > > I tried the "raise the timeout" change you suggested on IRC. > > That gave me a pass the first time around but the same failure > > second time I tried it: > > > >

[Qemu-devel] Implementing Memory Tag Extention - ARM

2019-01-18 Thread Vishnu Dev
Hello, I am a undergraduate Binary Exploitation enthusiast who would like to participate in GSoC with qemu on some security related project . While enquiring on IRC @agraf suggested a idea of implementing memory tag extension on ARM, this seems to be a good project . I have some experience

Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes

2019-01-18 Thread Peter Maydell
On Fri, 18 Jan 2019 at 18:16, Emilio G. Cota wrote: > > On Fri, Jan 18, 2019 at 17:00:17 +, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > > > Can you modify the Makefile.include to use: > > > "fp-test ... 2>int-to-float.err || {cat int-to-float.err && exit 1;}" > > > > Well it's

Re: [Qemu-devel] [PULL v3 00/28] ivshmem deprecation, qtests, typedefs and gnu99

2019-01-18 Thread Philippe Mathieu-Daudé
On 1/18/19 3:20 PM, Peter Maydell wrote: > On Fri, 18 Jan 2019 at 11:47, Peter Maydell wrote: >> >> On Thu, 17 Jan 2019 at 13:38, Thomas Huth wrote: >>> >>> Hi Peter! >>> >>> The following changes since commit 6f2f34177a25bffd6fd92a05e6e66c8d22d97094: >>> >>> Merge remote-tracking branch

Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes

2019-01-18 Thread Emilio G. Cota
On Fri, Jan 18, 2019 at 17:00:17 +, Alex Bennée wrote: > Philippe Mathieu-Daudé writes: > > Can you modify the Makefile.include to use: > > "fp-test ... 2>int-to-float.err || {cat int-to-float.err && exit 1;}" > > Well it's in the test-softfloat macro but sure... Actually, can we do &>

Re: [Qemu-devel] [PATCH v2 4/4] trace: add ability to do simple printf logging via systemtap

2019-01-18 Thread Eric Blake
On 1/18/19 11:31 AM, Daniel P. Berrangé wrote: > The dtrace systemtap trace backend for QEMU is very powerful but it is > also somewhat unfriendly to users who aren't familiar with systemtap, > or who don't need its power right now. > > stap -e "some strange script" > > We go one step

Re: [Qemu-devel] [PATCH V9 4/6] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-01-18 Thread Eduardo Habkost
On Wed, Jan 16, 2019 at 10:58:44AM -0500, Michael S. Tsirkin wrote: > On Wed, Jan 16, 2019 at 04:10:58PM +0800, Zhang Yi wrote: > > When a file supporting DAX is used as vNVDIMM backend, mmap it with > > MAP_SYNC flag in addition which can ensure file system metadata > > synced in each guest

Re: [Qemu-devel] [PATCH v2] Fix linux-user crashes in ioctl(SIOCGIFCONF) when ifc_buf is NULL.

2019-01-18 Thread Laurent Vivier
On 18/01/2019 18:09, Peter Maydell wrote: On Wed, 24 Oct 2018 at 22:05, Laurent Vivier wrote: On 24/10/2018 21:13, Kan Li wrote: Summary: This is to fix bug https://bugs.launchpad.net/qemu/+bug/1796754. It is valid for ifc_buf to be NULL according to

Re: [Qemu-devel] [PATCH v2 3/4] trace: forbid use of %m in trace event format strings

2019-01-18 Thread Eric Blake
On 1/18/19 11:31 AM, Daniel P. Berrangé wrote: > The '%m' format specifier instructs glibc's printf() implementation to > insert the contents of strerror(errno). That is a glibc-only extension in printf(), but mandatory (and supported in ALL platforms) in syslog(). However, you are correct that:

Re: [Qemu-devel] [PATCH v2 1/4] display: ensure qxl log_buf is a nul terminated string

2019-01-18 Thread Daniel P . Berrangé
On Fri, Jan 18, 2019 at 11:40:29AM -0600, Eric Blake wrote: > On 1/18/19 11:31 AM, Daniel P. Berrangé wrote: > > The QXL_IO_LOG command allows the guest to send log messages to the host > > via a buffer in the QXLRam struct. QEMU prints these to the console if > > the qxl 'guestdebug' option is

Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes

2019-01-18 Thread Peter Maydell
On Fri, 18 Jan 2019 at 17:41, Alex Bennée wrote: > > > Emilio G. Cota writes: > > > On Thu, Jan 17, 2019 at 18:55:33 +, Peter Maydell wrote: > >> configure has logic to check whether it can use particular > >> warning enable/disable flags. Newer gcc (and I hope clang > >> but forget) will

Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes

2019-01-18 Thread Alex Bennée
Emilio G. Cota writes: > On Thu, Jan 17, 2019 at 18:55:33 +, Peter Maydell wrote: >> On Thu, 17 Jan 2019 at 18:30, Emilio G. Cota wrote: >> > What are the contents of "int-to-float.err"? >> >> linux1@lxub05:~$ cat qemu/build/all/tests/fp/int-to-float.err >> >> Testing i32_to_f16, rounding

Re: [Qemu-devel] [PATCH v2 2/4] trace: enforce that every trace-events file has a final newline

2019-01-18 Thread Eric Blake
On 1/18/19 11:31 AM, Daniel P. Berrangé wrote: > When generating the trace-events-all file, the build system simply > concatenates all the individual trace-events files. If any one of those > files does not have a final newline, the printf format string will have > the contents of the first line

Re: [Qemu-devel] [PATCH v2 1/4] display: ensure qxl log_buf is a nul terminated string

2019-01-18 Thread Eric Blake
On 1/18/19 11:31 AM, Daniel P. Berrangé wrote: > The QXL_IO_LOG command allows the guest to send log messages to the host > via a buffer in the QXLRam struct. QEMU prints these to the console if > the qxl 'guestdebug' option is set to non-zero. It will also feed them > to the trace subsystem if

Re: [Qemu-devel] [PATCH V9 1/6] numa: Fixed the memory leak of numa error message

2019-01-18 Thread Eduardo Habkost
On Wed, Jan 16, 2019 at 10:56:14AM -0500, Michael S. Tsirkin wrote: > On Wed, Jan 16, 2019 at 04:10:17PM +0800, Zhang Yi wrote: > > object_get_canonical_path_component() returns a string which > > must be freed using g_free(). > > > > Signed-off-by: Zhang Yi > > Reviewed-by: Pankaj gupta > >

[Qemu-devel] [Bug 1801073] Re: util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werro

2019-01-18 Thread Peter Maydell
This bug would be better reported to the upstream for the ipxe rom -- we just ship the source code because we ship the binary. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1801073 Title:

Re: [Qemu-devel] [PATCH] target/s390x: define TCG_GUEST_DEFAULT_MO for MTTCG

2019-01-18 Thread David Hildenbrand
On 18.01.19 18:18, Alex Bennée wrote: > MTTCG should be enabled by default whenever the memory model allows > it. s390x was missing its definition of TCG_GUEST_DEFAULT_MO meaning > the user had to manually specify --accel tcg,thread=multi. > > Signed-off-by: Alex Bennée > Cc: David Hildenbrand

[Qemu-devel] [PATCH v2 3/4] trace: forbid use of %m in trace event format strings

2019-01-18 Thread Daniel P . Berrangé
The '%m' format specifier instructs glibc's printf() implementation to insert the contents of strerror(errno). This is not something that should ever be used in trace-events files because several of the backends do not use the format string and so this error information is invisible to them. The

[Qemu-devel] [Bug 1798659] Re: Replace comma with semicolon in trace/simple.c

2019-01-18 Thread Peter Maydell
Fixed in commit 7ff5920717d413d8b7c3ba13d9, which will be in the upcoming 4.0 release. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1798659

Re: [Qemu-devel] [PATCH v2 4/4] hw/i386/pc: use PVH option rom

2019-01-18 Thread Eduardo Habkost
On Tue, Jan 15, 2019 at 01:57:22PM -0500, Michael S. Tsirkin wrote: > On Tue, Jan 15, 2019 at 11:00:58AM +0100, Stefano Garzarella wrote: > > Use pvh.bin option rom when we are booting an uncompressed > > kernel using the x86/HVM direct boot ABI. > > > > Signed-off-by: Stefano Garzarella > >

[Qemu-devel] [PATCH v2 0/4] trace: make systemtap easier to use for simple logging

2019-01-18 Thread Daniel P . Berrangé
This is a followup to v1: https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg04173.html Changed in v2: - Fix safety of QXL logging - Handle format specifier macros is a more reliable manner - Fix trace-events files missing newline - Remove use of %m formats Daniel P. Berrangé (4):

[Qemu-devel] [PATCH v2 2/4] trace: enforce that every trace-events file has a final newline

2019-01-18 Thread Daniel P . Berrangé
When generating the trace-events-all file, the build system simply concatenates all the individual trace-events files. If any one of those files does not have a final newline, the printf format string will have the contents of the first line of the next file appended to it, which is usually a '#'

  1   2   3   4   5   >