Re: [Qemu-devel] [PATCH v3 00/19] spapr: Add support for PHB hotplug

On Tue, 22 Jan 2019 16:44:02 +1100 Alexey Kardashevskiy wrote: > On 18/01/2019 04:14, Greg Kurz wrote: > > This allows to hotplug/unplug PHBs. I could successfully test: > > - using in-kernel XICS, emulated XICS and XIVE > > - using experimental in-kernel XIVE from Cedric > > - hotplug/unplug

Re: [Qemu-devel] Live migration from Qemu 2.12 hosts to Qemu 3.2 hosts, with VMX flag enabled in the guest?

On 2019/1/18 14:18, Christian Ehrhardt wrote: On Fri, Jan 18, 2019 at 7:33 AM Mark Mielke wrote: Thank you for the work on nested virtualization. Having had live migrations fail in the past when nested virtualization has been active, it is great to see that clever people have been working on

[Qemu-devel] [PULL v4 26/26] tests: remove rule for nonexisting qdev-monitor-test

From: Paolo Bonzini This test was merged into drive_del-test in 2014. Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Fixes: e2f3f221885a90de766ce9a3 ("Merge of qdev-monitor-test, blockdev-test") Signed-off-by: Thomas

[Qemu-devel] [PULL v4 01/26] tests/Makefile: Use some more CONFIG switches for x86 tests

To be able to build and test QEMU binaries where certain devices are disabled, we have to use the right CONFIG_* switches to run certain tests only if the corresponding device really has been compiled into the binary. Signed-off-by: Thomas Huth --- tests/Makefile.include | 10 +- 1 file

[Qemu-devel] [PULL v4 00/26] qtests, typedefs and gnu99

Hi Peter! The following changes since commit 166609e6070fab3424510ac7292ecb585f8b80fb: Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-january-17-2019-v2' into staging (2019-01-21 17:53:28 +) are available in the git repository at: https://gitlab.com/huth/qemu.git

[Qemu-devel] Bottom halves VS timers

Hi! I recently debugged record/replay for some platform which uses PIO access for IDE. Handlers for these operations are called through BHs. Scheduling new BH does not create a signal for the vCPU to suspend the execution and process the main loop events (in record/replay we synchronize

[Qemu-devel] [PULL v4 20/26] virtio-net: Fix VirtIONet typedef redefinition

From: Philippe Mathieu-Daudé Commit 2974e916df8 introduced the VirtioNetRscChain structure which refer to a VirtIONet, declared later, thus required VirtIONet typedef to use a forward declaration. However, when compiling with Clang in -std=gnu99 mode, this triggers the following warning/error:

[Qemu-devel] [PULL 0/1] Ipxe 20190122 patches

The following changes since commit 681d61362d3f766a00806b89d6581869041f73cb: Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-01-17 12:48:42 +) are available in the git repository at: git://git.kraxel.org/qemu tags/ipxe-20190122-pull-request

Re: [Qemu-devel] Bug#920032: qemu-user uses wrong struct timeval on sparc

Hi Ben, could you please submit this as a proper patch to the qemu-devel mailing list, with Signed-off-by line? (see https://wiki.qemu.org/Contribute/SubmitAPatch for details) Thanks, Thomas On 2019-01-22 06:42, Michael Tokarev wrote: > Forwarding to qemu-devel@. >

Re: [Qemu-devel] Bug#920032: qemu-user uses wrong struct timeval on sparc

Forwarding to qemu-devel@. http://bugs.debian.org/920032 Thanks! 21.01.2019 22:09, Ben Hutchings wrote: Package: qemu-user Version: 1:3.1+dfsg-2 Severity: important Tags: patch On sparc (only) Linux defines timeval::tv_usec with type int, not long. However qemu-user's definition of struct

Re: [Qemu-devel] Bug#919921: qemu-user Linux ELF loader fails to handle pure BSS segments

Forwarding to qemu-devel@ http://bugs.debian.org/919921 Thanks! 20.01.2019 20:55, Ben Hutchings wrote: Package: qemu-user Version: 1:3.1+dfsg-2 Severity: normal Tags: patch I've been building and testing klibc across many architectures using qemu-user, and I found that qemu-user fails to load

Re: [Qemu-devel] [PATCH v3 00/19] spapr: Add support for PHB hotplug

On 18/01/2019 04:14, Greg Kurz wrote: > This allows to hotplug/unplug PHBs. I could successfully test: > - using in-kernel XICS, emulated XICS and XIVE > - using experimental in-kernel XIVE from Cedric > - hotplug/unplug with e1000 device to validate LSIs > - hotplug/unplug with virtio-net

Re: [Qemu-devel] [RFC] Questions on the I/O performance of emulated host cdrom device

Hi, I am not intended to send a patch now, I use the ‘read-only’ code snippet to prove that the I/O performance can increase from 30% to 80% compared to host side if we do not call cdrom_is_inserted here. Obviously it is not suitable to skip over checking cdrom drive status. However I cannot

Re: [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS

21.01.2019 18:17, Peter Maydell wrote: On Mon, 21 Jan 2019 at 14:49, Anthony PERARD wrote: When Xen is detected via pkg-config, it isn't necessary to modify LDFLAGS as modifying libs_softmmu is enough. Reported-by: Peter Maydell Signed-off-by: Anthony PERARD --- configure | 1 - 1 file

Re: [Qemu-devel] [PATCH v3] dump: Set correct vaddr for ELF dump

ping, so this means that the patch will be merged in? Thanks, -- Jon. On Wed, Jan 9, 2019 at 12:38 PM Laszlo Ersek wrote: > > On 01/09/19 09:25, Marc-André Lureau wrote: > > On Wed, Jan 9, 2019 at 12:22 PM Jon Doron wrote: > >> > >> vaddr needs to be equal to the paddr since the dump file

Re: [Qemu-devel] [PATCH] virtio-net: Fix VirtIONet typedef redefinition

On 2019-01-22 06:05, Michael S. Tsirkin wrote: > On Tue, Jan 22, 2019 at 05:28:12AM +0100, Thomas Huth wrote: >> On 2019-01-21 20:46, Philippe Mathieu-Daudé wrote: >>> On 1/21/19 8:22 PM, Eric Blake wrote: On 1/21/19 12:10 PM, Philippe Mathieu-Daudé wrote: > Commit 2974e916df8 introduced

Re: [Qemu-devel] [PATCH] virtio-net: Fix VirtIONet typedef redefinition

On Tue, Jan 22, 2019 at 05:28:12AM +0100, Thomas Huth wrote: > On 2019-01-21 20:46, Philippe Mathieu-Daudé wrote: > > On 1/21/19 8:22 PM, Eric Blake wrote: > >> On 1/21/19 12:10 PM, Philippe Mathieu-Daudé wrote: > >>> Commit 2974e916df8 introduced the VirtioNetRscChain structure which > >>> refer

Re: [Qemu-devel] [PATCH] virtio-net: Fix VirtIONet typedef redefinition

On Mon, Jan 21, 2019 at 07:10:30PM +0100, Philippe Mathieu-Daudé wrote: > Commit 2974e916df8 introduced the VirtioNetRscChain structure which > refer to a VirtIONet, declared later, thus required VirtIONet typedef > to be declarated forward. > However, when compiling with Clang in -std=gnu99 mode,

Re: [Qemu-devel] [PATCH] virtio-net: Fix VirtIONet typedef redefinition

On 2019-01-21 20:46, Philippe Mathieu-Daudé wrote: > On 1/21/19 8:22 PM, Eric Blake wrote: >> On 1/21/19 12:10 PM, Philippe Mathieu-Daudé wrote: >>> Commit 2974e916df8 introduced the VirtioNetRscChain structure which >>> refer to a VirtIONet, declared later, thus required VirtIONet typedef >>> to

[Qemu-devel] 答复: [PATCH] qga: check length of command-line & environment variables

Hi, Is this issue fixed? Br， Guoxiang Niu 华为技术有限公司 Huawei Technologies Co., Ltd. 本邮件及其附件含有华为公司的保密信息，仅限于发送给上面地址中列出的个人或群组。禁 止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制、或散发）本邮件中 的信息。如果您错收了本邮件，请您立即电话或邮件通知发件人并删除本邮件！ This e-mail and its attachments contain confidential information from HUAWEI, which is

Re: [Qemu-devel] [PATCH V9 4/6] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

On Tue, Jan 22, 2019 at 11:21:25AM +0800, Yi Zhang wrote: > On 2019-01-21 at 12:44:00 -0200, Eduardo Habkost wrote: > > On Mon, Jan 21, 2019 at 01:15:36PM +0800, Yi Zhang wrote: > > > On 2019-01-18 at 16:11:47 -0200, Eduardo Habkost wrote: > > [...] > > > > Anyway, I see a more fundamental problem

Re: [Qemu-devel] [RFC] Questions on the I/O performance of emulated host cdrom device

方应 M：+86-15925605092 E：fangyi...@huawei.com 2012实验室-欧拉五部 2012 Laboratories-Euler Dept 5 发件人： John Snow 收件人： fangyingmailto:fangyi...@huawei.com>>;Kevin Wolfmailto:kw...@redhat.com>> 抄送： Zhoujian

Re: [Qemu-devel] [PATCH V9 2/6] memory: use sparse feature define RAM_FLAG.

On 2019-01-21 at 15:24:17 -0500, Michael S. Tsirkin wrote: > On Mon, Jan 21, 2019 at 02:35:57PM +0800, Yi Zhang wrote: > > On 2019-01-16 at 10:55:33 -0500, Michael S. Tsirkin wrote: > > > On Wed, Jan 16, 2019 at 04:10:29PM +0800, Zhang Yi wrote: > > > > Signed-off-by: Zhang Yi > > > >

Re: [Qemu-devel] [PATCH V9 4/6] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

On 2019-01-21 at 12:44:00 -0200, Eduardo Habkost wrote: > On Mon, Jan 21, 2019 at 01:15:36PM +0800, Yi Zhang wrote: > > On 2019-01-18 at 16:11:47 -0200, Eduardo Habkost wrote: > [...] > > > Anyway, I see a more fundamental problem in each version of this > > > patch: the semantics of the

Re: [Qemu-devel] [PATCH v2 0/4] intel_iommu: misc fixes for error exposed after error_report_once()

On Tue, Jan 22, 2019 at 01:57:50PM +1100, Alexey Kardashevskiy wrote: > > > On 21/01/2019 20:35, Peter Xu wrote: > > On Mon, Jan 21, 2019 at 12:32:07AM -0800, no-re...@patchew.org wrote: > >> Patchew URL: > >> https://patchew.org/QEMU/20190116030815.27273-1-pet...@redhat.com/ > >> > >> > >> >

Re: [Qemu-devel] [PATCH v2 0/4] intel_iommu: misc fixes for error exposed after error_report_once()

On 21/01/2019 20:35, Peter Xu wrote: > On Mon, Jan 21, 2019 at 12:32:07AM -0800, no-re...@patchew.org wrote: >> Patchew URL: >> https://patchew.org/QEMU/20190116030815.27273-1-pet...@redhat.com/ >> >> >> >> Hi, >> >> This series failed the docker-mingw@fedora build test. Please find the >>

Re: [Qemu-devel] [PATCH 0/5] Refactor common PCI IDE functions from CMD646

On 1/10/19 7:36 PM, BALATON Zoltan wrote: > Hello, > > This series is a small refactoring that moves some common PCI IDE io > mem ops functions from the CMD646 model to the PCI IDE model so a > CMD646 specific type can be dropped from PCIIDEState, removes code > duplication from SiI3112 model

Re: [Qemu-devel] [PATCH 2/2] tests: fw_cfg: add reboot_timeout test case

Laszlo Ersek 于2019年1月22日周二 上午5:38写道： > On 01/20/19 08:13, Li Qiang wrote: > > Signed-off-by: Li Qiang > > --- > > tests/fw_cfg-test.c | 13 - > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > > diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c > > index

Re: [Qemu-devel] [PATCH 1/2] tests: fw_cfg: add a function to get the fw_cfg file entry

Laszlo Ersek 于2019年1月22日周二 上午5:32写道： > On 01/20/19 08:13, Li Qiang wrote: > > This is useful to write qtest about fw_cfg file entry. > > > > Signed-off-by: Li Qiang > > --- > > tests/libqos/fw_cfg.c | 33 + > > tests/libqos/fw_cfg.h | 2 ++ > > 2 files changed,

Re: [Qemu-devel] [PATCH v4 26/35] target/riscv: Remove shift and slt insn manual decoding

On 1/21/19 1:10 AM, Bastian Koppelmann wrote: > > On 1/20/19 2:43 AM, Richard Henderson wrote: >> On 1/19/19 12:14 AM, Bastian Koppelmann wrote: >>> Signed-off-by: Bastian Koppelmann >>> Signed-off-by: Peer Adelt >>> --- >>> v3 -> v4: >>> - refactor tcg_gen_set_cond_tl(TCG_COND_LT,..) into

Re: [Qemu-devel] [RFC PATCH 3/3] tests/vm: expose BUILD_TARGET, TARGET_LIST and EXTRA_CONFIGURE_OPTS

On 1/21/19 6:15 PM, Alex Bennée wrote: > Now the underlying basevm support passes these along we can expose > some additional variables to our Makefile to allow more customised > tweaking of the build. For example: > > make vm-build-freebsd TARGET_LIST=aarch64-softmmu \ >

[Qemu-devel] [PULL 14/21] nbd/client: Split handshake into two functions

An upcoming patch will add the ability for qemu-nbd to list the services provided by an NBD server. Share the common code of the TLS handshake by splitting the initial exchange into a separate function, leaving only the export handling in the original function. Functionally, there should be no

[Qemu-devel] [PULL 10/21] nbd/client: Change signature of nbd_negotiate_simple_meta_context()

Pass 'info' instead of three separate parameters related to info, when requesting the server to set the meta context. Update the NBDExportInfo struct to rename the received id field to match the fact that we are currently overloading the field to match whatever context the user supplied through

[Qemu-devel] [PULL 18/21] nbd/client: Add meta contexts to nbd_receive_export_list()

We want to be able to detect whether a given qemu NBD server is exposing the right export(s) and dirty bitmaps, at least for regression testing. We could use 'nbd-client -l' from the upstream NBD project to list exports, but it's annoying to rely on out-of-tree binaries; furthermore, nbd-client

[Qemu-devel] [PULL 12/21] nbd/client: Split out nbd_receive_one_meta_context()

Extract portions of nbd_negotiate_simple_meta_context() to a new function nbd_receive_one_meta_context() that copies the pattern of nbd_receive_list() for performing the argument validation of one reply. The error message when the server replies with more than one context changes slightly, but

[Qemu-devel] [PULL 11/21] nbd/client: Split out nbd_send_meta_query()

Refactor nbd_negotiate_simple_meta_context() to pull out the code that can be reused to send a LIST request for 0 or 1 query. No semantic change. The old comment about 'sizeof(uint32_t)' being equivalent to '/* number of queries */' is no longer needed, now that we are computing 'sizeof(queries)'

Re: [Qemu-devel] [RFC PATCH 2/3] tests/vm: add --build-target option

On 1/21/19 6:15 PM, Alex Bennée wrote: > This allows us to invoke the build with a custom target (for the VMs > that use the {target} format string specifier). Currently OpenBSD is > still hardwired due to problems running check > > Signed-off-by: Alex Bennée > --- > tests/vm/basevm.py | 3 +++

[Qemu-devel] [PULL 13/21] nbd/client: Refactor return of nbd_receive_negotiate()

The function could only ever return 0 or -EINVAL; make this clearer by dropping a useless 'fail:' label. Signed-off-by: Eric Blake Reviewed-by: Richard W.M. Jones Reviewed-by: Vladimir Sementsov-Ogievskiy Message-Id: <20190117193658.16413-14-ebl...@redhat.com> --- nbd/client.c | 51

[Qemu-devel] [PULL 20/21] nbd/client: Work around 3.0 bug for listing meta contexts

Commit 3d068aff forgot to advertise available qemu: contexts when the client requests a list with 0 queries. Furthermore, 3.0 shipped with a qemu-img hack of x-dirty-bitmap (commit 216ee365) that _silently_ acts as though the entire image is clean if a requested bitmap is not present. Both bugs

Re: [Qemu-devel] [RFC PATCH 1/3] tests/vm: call make check directly for netbsd/freebsd

On 1/21/19 6:15 PM, Alex Bennée wrote: > The "make check" target calls check-qtest which has the appropriate > system binaries as dependencies so we shouldn't need to do two steps > of make invocation. > > Signed-off-by: Alex Bennée > --- > tests/vm/freebsd | 1 - > 1 file changed, 1

[Qemu-devel] [PULL 15/21] nbd/client: Pull out oldstyle size determination

Another refactoring creating nbd_negotiate_finish_oldstyle() for further reuse during 'qemu-nbd --list'. Signed-off-by: Eric Blake Reviewed-by: Richard W.M. Jones Message-Id: <20190117193658.16413-16-ebl...@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy --- nbd/client.c | 49

[Qemu-devel] [PULL 16/21] nbd/client: Refactor nbd_opt_go() to support NBD_OPT_INFO

Rename the function to nbd_opt_info_or_go() with an added parameter and slight changes to comments and trace messages, in order to reuse the function for NBD_OPT_INFO. Signed-off-by: Eric Blake Message-Id: <20190117193658.16413-17-ebl...@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy ---

[Qemu-devel] [PULL 06/21] nbd/server: Favor [u]int64_t over off_t

Although our compile-time environment is set up so that we always support long files with 64-bit off_t, we have no guarantee whether off_t is the same type as int64_t. This requires casts when printing values, and prevents us from directly using qemu_strtoi64() (which will be done in the next

[Qemu-devel] [PULL 19/21] qemu-nbd: Add --list option

We want to be able to detect whether a given qemu NBD server is exposing the right export(s) and dirty bitmaps, at least for regression testing. We could use 'nbd-client -l' from the upstream NBD project to list exports, but it's annoying to rely on out-of-tree binaries; furthermore, nbd-client

[Qemu-devel] [PULL 05/21] nbd/server: Hoist length check to qmp_nbd_server_add

We only had two callers to nbd_export_new; qemu-nbd.c always passed a valid offset/length pair (because it already checked the file length, to ensure that offset was in bounds), while blockdev-nbd.c always passed 0/-1. Then nbd_export_new reduces the size to a multiple of BDRV_SECTOR_SIZE (can

[Qemu-devel] [PULL 09/21] nbd/client: Move export name into NBDExportInfo

Refactor the 'name' parameter of nbd_receive_negotiate() from being a separate parameter into being part of the in-out 'info'. This also spills over to a simplification of nbd_opt_go(). The main driver for this refactoring is that an upcoming patch would like to add support to qemu-nbd to list

[Qemu-devel] [PULL 07/21] qemu-nbd: Avoid strtol open-coding

Our copy-and-pasted open-coding of strtol handling forgot to handle overflow conditions. Use qemu_strto*() instead. In the case of --partition, since we insist on a user-supplied partition to be non-zero, we can use 0 rather than -1 for our initial value to distinguish when a partition is not

[Qemu-devel] [PULL 21/21] iotests: Enhance 223, 233 to cover 'qemu-nbd --list'

Any good new feature deserves some regression testing :) Coverage includes: - 223: what happens when there are 0 or more than 1 export, proof that we can see multiple contexts including qemu:dirty-bitmap - 233: proof that we can list over TLS, and that mix-and-match of plain/TLS listings will

[Qemu-devel] [PULL 03/21] qemu-nbd: Enhance man page

Document some useful qemu-nbd command lines. Mention some restrictions on particular options, like -p being only for MBR images, or -c/-d being Linux-only. Update some text given the recent change to no longer serve oldstyle protocol (missed in commit 7f7dfe2a). Also, consistently use trailing

[Qemu-devel] [PULL 08/21] nbd/client: Refactor nbd_receive_list()

Right now, nbd_receive_list() is only called by nbd_receive_query_exports(), which in turn is only called if the server lacks NBD_OPT_GO but has working option negotiation, and is merely used as a quality-of-implementation trick since servers can't give decent errors for NBD_OPT_EXPORT_NAME.

[Qemu-devel] [PULL 02/21] maint: Allow for EXAMPLES in texi2pod

The next commit will add an EXAMPLES section to qemu-nbd.8; for that to work, we need to recognize EXAMPLES in texi2pod. We also need to add a dependency from all man pages against the generator script, since a change to the generator may cause the resulting man page to differ. Signed-off-by:

[Qemu-devel] [PULL 17/21] nbd/client: Add nbd_receive_export_list()

We want to be able to detect whether a given qemu NBD server is exposing the right export(s) and dirty bitmaps, at least for regression testing. We could use 'nbd-client -l' from the upstream NBD project to list exports, but it's annoying to rely on out-of-tree binaries; furthermore, nbd-client

[Qemu-devel] [PULL 01/21] iotests: Make 233 output more reliable

We have a race between the nbd server and the client both trying to report errors at once which can make the test sometimes fail if the output lines swap order under load. Break the race by collecting server messages into a file and then replaying that at the end of the test. We may yet want to

[Qemu-devel] [PULL 04/21] qemu-nbd: Sanity check partition bounds

When the user requests a partition, we were using data read from the disk as disk offsets without a bounds check. We got lucky that even when computed offsets are out-of-bounds, blk_pread() will gracefully catch the error later (so I don't think a malicious image can crash or exploit qemu-nbd, and

[Qemu-devel] [PULL 00/21] NBD patches through 2019-01-21

The following changes since commit 166609e6070fab3424510ac7292ecb585f8b80fb: Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-january-17-2019-v2' into staging (2019-01-21 17:53:28 +) are available in the Git repository at: https://repo.or.cz/qemu/ericb.git

Re: [Qemu-devel] [PATCH 00/18] Acceptance Tests: target architecture support

> From: Cleber Rosa > class My(Test): > def test_nx_cpu_flag(self): > """ > :avocado: tags=arch:x86_64 > """ > test_code() > The value of the "arch" key, in this case, "x86_64" will be used when > selecting the QEMU binary to use in the test. At

Re: [Qemu-devel] [PATCH] virtio-net: Fix VirtIONet typedef redefinition

On Mon, 21 Jan 2019 19:10:30 +0100 Philippe Mathieu-Daudé wrote: > Commit 2974e916df8 introduced the VirtioNetRscChain structure which > refer to a VirtIONet, declared later, thus required VirtIONet typedef > to be declarated forward. > However, when compiling with Clang in -std=gnu99 mode, this

Re: [Qemu-devel] [PATCH 2/2] tests: fw_cfg: add reboot_timeout test case

On 01/20/19 08:13, Li Qiang wrote: > Signed-off-by: Li Qiang > --- > tests/fw_cfg-test.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c > index 1c5103fe1c..c28e6c3fb5 100644 > --- a/tests/fw_cfg-test.c > +++

Re: [Qemu-devel] [PATCH 00/12] chardev: refactoring & many bugfixes related tcp_chr_wait_connected

Patchew URL: https://patchew.org/QEMU/20190115145256.9593-1-berra...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH 1/2] tests: fw_cfg: add a function to get the fw_cfg file entry

On 01/20/19 08:13, Li Qiang wrote: > This is useful to write qtest about fw_cfg file entry. > > Signed-off-by: Li Qiang > --- > tests/libqos/fw_cfg.c | 33 + > tests/libqos/fw_cfg.h | 2 ++ > 2 files changed, 35 insertions(+) > > diff --git

Re: [Qemu-devel] [PATCH 3/3] iotests: Allow 147 to be run concurrently

On 12/21/18 5:47 PM, Max Reitz wrote: > To do this, we need to allow creating the NBD server on various ports > instead of a single one (which may not even work if you run just one > instance, because something entirely else might be using that port). Can you instead reuse the ideas from

Re: [Qemu-devel] [PATCH 2/3] iotests: Bind qemu-nbd to localhost in 147

On 12/21/18 5:47 PM, Max Reitz wrote: > By default, qemu-nbd binds to 0.0.0.0. However, we then proceed to > connect to "localhost". Usually, this works out fine; but if this test > is run concurrently, some other test function may have bound a different > server to ::1 (on the same port -- you

Re: [Qemu-devel] [PATCH 1/3] iotests.py: Add qemu_nbd_pipe()

On 12/21/18 5:47 PM, Max Reitz wrote: > In some cases, we may want to deal with qemu-nbd errors (e.g. by > launching it in a different configuration until it no longer throws > any). In that case, we do not want its output ending up in the test > output. > > It may still be useful for handling

Re: [Qemu-devel] [Qemu-block] [PATCH 3/3] iotests: Allow 147 to be run concurrently

On 12/21/18 6:47 PM, Max Reitz wrote: > To do this, we need to allow creating the NBD server on various ports > instead of a single one (which may not even work if you run just one > instance, because something entirely else might be using that port). > > So we just pick a random port in

Re: [Qemu-devel] [PATCH 17/18] Boot Linux Console Test: add a test for s390x + s390-ccw-virtio

On Thu, Jan 17, 2019 at 01:56:27PM -0500, Cleber Rosa wrote: > Just like the previous tests, boots a Linux kernel on a s390x target > using the s390-ccw-virtio machine. > > Because it's not possible to have multiple VT220 consoles, > '-nodefaults' is used, so that the one set with set_console()

Re: [Qemu-devel] [PATCH 12/18] Boot Linux Console Test: add a test for mips + malta

On Thu, Jan 17, 2019 at 01:56:22PM -0500, Cleber Rosa wrote: > From: Philippe Mathieu-Daudé > > Similar to the x86_64 + pc test, it boots a Linux kernel on a Malta > board and verify the serial is working. Also, it relies on the serial > device set by the machine itself. > > If mips is a

Re: [Qemu-devel] [PATCH 16/18] Boot Linux Console Test: add a test for arm + virt

On Thu, Jan 17, 2019 at 01:56:26PM -0500, Cleber Rosa wrote: > Just like the previous tests, boots a Linux kernel on an arm target > using the virt machine. > > Signed-off-by: Cleber Rosa Reviewed-by: Caio Carrara > --- > .travis.yml| 2 +- >

Re: [Qemu-devel] [PATCH 11/18] scripts/qemu.py: support adding a console with the default serial device

On Thu, Jan 17, 2019 at 01:56:21PM -0500, Cleber Rosa wrote: > The set_console() utility function traditionally adds a device either > based on the explicitly given device type, or based on the machine type, > a known good type of device. > > But, for a number of machine types, it may be

Re: [Qemu-devel] [PATCH 14/18] Boot Linux Console Test: add a test for ppc64 + pseries

On Thu, Jan 17, 2019 at 01:56:24PM -0500, Cleber Rosa wrote: > Just like the previous tests, boots a Linux kernel on a ppc64 target > using the pseries machine. > > Signed-off-by: Cleber Rosa Reviewed-by: Caio Carrara > --- > .travis.yml| 2 +- > scripts/qemu.py

Re: [Qemu-devel] [PATCH 01/18] scripts/qemu.py: log QEMU launch command line

On Thu, Jan 17, 2019 at 01:56:11PM -0500, Cleber Rosa wrote: > Even when the launch of QEMU succeeds, it's useful to have the command > line recorded. > > Signed-off-by: Cleber Rosa Reviewed-by: Caio Carrara > --- > scripts/qemu.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [Qemu-devel] [PATCH 15/18] Boot Linux Console Test: add a test for aarch64 + virt

On Thu, Jan 17, 2019 at 01:56:25PM -0500, Cleber Rosa wrote: > Just like the previous tests, boots a Linux kernel on a aarch64 target > using the virt machine. > > One special option added is the CPU type, given that the kernel > selected fails to boot on the virt machine's default CPU

Re: [Qemu-devel] [PATCH 13/18] Boot Linux Console Test: add a test for mips64el + malta

On Thu, Jan 17, 2019 at 01:56:23PM -0500, Cleber Rosa wrote: > Similar to the x86_64 + pc test, it boots a Linux kernel on a Malta > board and verify the serial is working. > > If mips64el is a target being built, "make check-acceptance" will > automatically include this test by the use of the

Re: [Qemu-devel] [PATCH 18/18] Boot Linux Console Test: add a test for alpha + clipper

On Thu, Jan 17, 2019 at 01:56:28PM -0500, Cleber Rosa wrote: > Similar to the x86_64 + pc test, it boots a Linux kernel on a Malta > board and verify the serial is working. One extra command added to > the QEMU command line is '-vga std', because the kernel used is > known to crash without it. >

Re: [Qemu-devel] [PATCH 02/23] armv7m: Make cpu object a child of the armv7m container

On 1/21/19 7:50 PM, Peter Maydell wrote: > Rather than just creating the CPUs with object_new, make them child > objects of the armv7m container. This will allow the cluster code to > find the CPUs if an armv7m object is made a child of a cluster object. > object_new_with_props() will do the

Re: [Qemu-devel] [PATCH 08/18] Boot Linux Console Test: rename the x86_64 after the arch and machine

On Thu, Jan 17, 2019 at 01:56:18PM -0500, Cleber Rosa wrote: > Given that the test is specific to x86_64 and pc, and new tests are > going to be added to the same class, let's rename it accordingly. > Also, let's make the class documentation not architecture specific. > > Signed-off-by: Cleber

Re: [Qemu-devel] [PATCH 03/18] Acceptance tests: improve docstring on pick_default_qemu_bin()

On Thu, Jan 17, 2019 at 01:56:13PM -0500, Cleber Rosa wrote: > Making it clear what is returned by this utility function. > > Signed-off-by: Cleber Rosa > Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Caio Carrara > --- > tests/acceptance/avocado_qemu/__init__.py | 4 > 1 file

Re: [Qemu-devel] [PATCH 04/23] hw/arm/iotkit: Rename IoTKit to ARMSSE

On 1/21/19 7:50 PM, Peter Maydell wrote: > The Arm IoTKit was effectively the forerunner of a series of > subsystems for embedded SoCs, named the SSE-050, SSE-100 and SSE-200: > https://developer.arm.com/products/system-design/subsystems > These are generally quite similar, though later iterations

Re: [Qemu-devel] [PATCH 01/23] armv7m: Don't assume the NVIC's CPU is CPU 0

On 1/21/19 7:50 PM, Peter Maydell wrote: > Currently the ARMv7M NVIC object's realize method assumes that the > CPU the NVIC is attached to is CPU 0, because it thinks there can > only ever be one CPU in the system. To allow a dual-Cortex-M33 > setup we need to remove this assumption; instead the

Re: [Qemu-devel] [PATCH 02/18] Acceptance tests: show avocado test execution by default

On Thu, Jan 17, 2019 at 01:56:12PM -0500, Cleber Rosa wrote: > The current version of the "check-acceptance" target will only show > one line for execution of all tests. That's probably OK if the tests > to be run are quick enough and they're always the same. > > But, there's already one test

Re: [Qemu-devel] [PATCH 10/18] Boot Linux Console Test: refactor the console watcher into utility method

On Thu, Jan 17, 2019 at 01:56:20PM -0500, Cleber Rosa wrote: > This introduces a utility method that monitors the console device and > looks for either a message that signals the test success or failure. > > Signed-off-by: Cleber Rosa Reviewed-by: Caio Carrara > --- >

Re: [Qemu-devel] [PATCH 09/18] Boot Linux Console Test: update the x86_64 kernel

On Thu, Jan 17, 2019 at 01:56:19PM -0500, Cleber Rosa wrote: > To the stock Fedora 29 kernel, from the Fedora 28. New tests will be > added using the 29 kernel, so for consistency, let's also update it > here. > > Signed-off-by: Cleber Rosa Reviewed-by: Caio Carrara > --- >

Re: [Qemu-devel] [PATCH v3 4/4] gdbstub: Simplify gdb_get_cpu_pid() to use cpu->cluster_index

On Mon, Jan 21, 2019 at 03:22:18PM +, Peter Maydell wrote: > Now we're keeping the cluster index in the CPUState, we don't > need to jump through hoops in gdb_get_cpu_pid() to find the > associated cluster object. > > Signed-off-by: Peter Maydell > Reviewed-by: Luc Michel Reviewed-by:

Re: [Qemu-devel] [PATCH 07/18] Acceptance tests: look for target architecture in test tags first

On Thu, Jan 17, 2019 at 01:56:17PM -0500, Cleber Rosa wrote: > A test can, optionally, be tagged for one or many architectures. If a > test has been tagged for a single architecture, there's a high chance > that the test won't run on other architectures. This changes the > default order of

Re: [Qemu-devel] [PATCH 06/18] Acceptance tests: use "arch:" tag to filter target specific tests

On Thu, Jan 17, 2019 at 01:56:16PM -0500, Cleber Rosa wrote: > Currently, the only test that contains some target architecture > information is "boot_linux_console.py" which test contains a "x86_64" > tag. But that tag is not respected in the default execution, that is, > "make check-acceptance"

Re: [Qemu-devel] [PATCH V9 2/6] memory: use sparse feature define RAM_FLAG.

On Mon, Jan 21, 2019 at 02:35:57PM +0800, Yi Zhang wrote: > On 2019-01-16 at 10:55:33 -0500, Michael S. Tsirkin wrote: > > On Wed, Jan 16, 2019 at 04:10:29PM +0800, Zhang Yi wrote: > > > Signed-off-by: Zhang Yi > > > Signed-off-by: Michael S. Tsirkin > > > > OK so if you apply this patch, do

Re: [Qemu-devel] [PATCH 4/6] target/mips: Correct the second argument type of cpu_supports_isa()

On 1/21/19 8:08 PM, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > "insn_flags" bitfield was expanded from 32-bit to 64-bit at one moment. "at one moment" -> "in f9c9cd63e3" > However, this was not reflected at the second argument of the function > cpu_supports_isa(). By chance,

Re: [Qemu-devel] [PATCH 04/18] Acceptance tests: fix doc reference to avocado_qemu directory

On Thu, Jan 17, 2019 at 01:56:14PM -0500, Cleber Rosa wrote: > The "this directory" reference is misleading and confusing, it's a > leftover from when this text was proposed in a README file inside > the "tests/acceptance/avocado_qemu" directory. > > When that text was moved to the top level docs

Re: [Qemu-devel] [PATCH 2/6] target/mips: nanoMIPS: Remove an unused macro

On 1/21/19 8:08 PM, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Remove a macro that is never used. > > Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [Qemu-devel] [PATCH v2 2/5] vfio-ccw: concurrent I/O handling

On Mon, 21 Jan 2019 12:03:51 +0100 Cornelia Huck wrote: > Rework handling of multiple I/O requests to return -EAGAIN if > we are already processing an I/O request. Introduce a mutex > to disallow concurrent writes to the I/O region. > > The expectation is that userspace simply retries the

Re: [Qemu-devel] [PATCH 1/6] target/mips: nanoMIPS: Remove duplicate macro definitions

On 1/21/19 8:08 PM, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Several macros were defined twice, with identical values. > Remove duplicates. "Previously added in 80845edf37b." "This reverts commit 6bfa9f4c9cf24d6cfaaa227722e9cdcca1ad6fe9." > > Signed-off-by: Aleksandar

Re: [Qemu-devel] [PATCH] xlnx-zynqmp: Don't create rpu-cluster if there are no RPUs

Hi Peter, On 1/21/19 7:43 PM, Peter Maydell wrote: > If we aren't going to create any RPUs, then don't create the > rpu-cluster unit. This allows us to add an assertion to the > cluster object that it contains at least one CPU, which helps > to avoid bugs in creating clusters and putting CPUs in

Re: [Qemu-devel] [PATCH v3 3/4] accel/tcg: Add cluster number to TCG TB hash

On Mon, Jan 21, 2019 at 03:22:17PM +, Peter Maydell wrote: > Include the cluster number in the hash we use to look > up TBs. This is important because a TB that is valid > for one cluster at a given physical address and set > of CPU flags is not necessarily valid for another: > the two

Re: [Qemu-devel] [PATCH v3 2/4] qom/cpu: Add cluster_index to CPUState

On Mon, Jan 21, 2019 at 03:22:16PM +, Peter Maydell wrote: > For TCG we want to distinguish which cluster a CPU is in, and > we need to do it quickly. Cache the cluster index in the CPUState > struct, by having the cluster object set cpu->cluster_index for > each CPU child when it is realized.

Re: [Qemu-devel] test-filter-mirror hangs

* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Thu, 17 Jan 2019 at 09:46, Jason Wang wrote: > > > > > > On 2019/1/15 上午12:33, Zhang Chen wrote: > > > > > > > > > On Sat, Jan 12, 2019 at 12:15 AM Dr. David Alan Gilbert > > > mailto:dgilb...@redhat.com>> wrote: > > > > > > * Peter

Re: [Qemu-devel] [Qemu-trivial] [PATCH] virtio-net: Fix a typo

On 21/01/2019 19:13, Philippe Mathieu-Daudé wrote: > Fixes: 2974e916df8 > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/virtio/virtio-net.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/virtio/virtio-net.h b/include/hw/virtio/virtio-net.h > index

Re: [Qemu-devel] [PATCH] xlnx-zynqmp: Don't create rpu-cluster if there are no RPUs

On Mon, Jan 21, 2019 at 06:43:14PM +, Peter Maydell wrote: > If we aren't going to create any RPUs, then don't create the > rpu-cluster unit. This allows us to add an assertion to the > cluster object that it contains at least one CPU, which helps > to avoid bugs in creating clusters and

Re: [Qemu-devel] [PATCH] virtio-net: Fix VirtIONet typedef redefinition

On 1/21/19 8:22 PM, Eric Blake wrote: > On 1/21/19 12:10 PM, Philippe Mathieu-Daudé wrote: >> Commit 2974e916df8 introduced the VirtioNetRscChain structure which >> refer to a VirtIONet, declared later, thus required VirtIONet typedef >> to be declarated forward. > > s/be declarated forward/use a

Re: [Qemu-devel] [PATCH 1/5] roms: add the edk2 project as a git submodule

On 1/21/19 7:41 PM, Laszlo Ersek wrote: > On 01/21/19 12:25, Philippe Mathieu-Daudé wrote: >> Cc'ing Daniel & Alex. >> >> On 1/18/19 11:33 PM, Laszlo Ersek wrote: >>> The roms/edk2 submodule can help with three goals: >>> - build the OVMF and ArmVirtQemu virtual UEFI firmware platforms (to be >>>

Re: [Qemu-devel] [PULL v2 00/12] MIPS queue for January 17, 2019 - v2

On Fri, 18 Jan 2019 at 16:59, Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > The following changes since commit 681d61362d3f766a00806b89d6581869041f73cb: > > Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' > into staging (2019-01-17 12:48:42 +) > >

[Qemu-devel] [PATCH 6/6] disas: nanoMIPS: Amend DSP instructions related comments

From: Aleksandar Markovic Amend some DSP instructions related comments. Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 119 + 1 file changed, 75 insertions(+), 44 deletions(-) diff --git a/disas/nanomips.cpp

  1   2   3   4   >