Re: [Qemu-devel] [PATCH] m25p80: add basic support for the SFPD command

2019-01-31 Thread Francisco Iglesias
Hi Cedric, On [2019 Jan 21] Mon 17:00:02, Cédric Le Goater wrote: > JEDEC STANDARD JESD216 for Serial Flash Discovery Parameters (SFDP) > provides a mean to describe the features of a serial flash device > using a set of internal parameter tables. > > This is the initial framework for the RDSFPD

Re: [Qemu-devel] [PATCH 0/5] misc fixes to deal with icon location changes

2019-01-31 Thread Stefan Weil
On 29.01.19 12:39, Daniel P. Berrangé wrote: > This is a few misc fixes identified after the icon location changes > were merged. Most importantly it deals with the nsis installer file > manifest. > > Daniel P. Berrangé (5): > nsis: don't install files into /tmp > make: don't insert a '/'

Re: [Qemu-devel] [PATCH 07/10] monitor: Expose pvrdma device statistics counters

2019-01-31 Thread Markus Armbruster
Eric Blake writes: > On 1/31/19 2:08 PM, Yuval Shaia wrote: >> On Thu, Jan 31, 2019 at 07:17:16AM -0600, Eric Blake wrote: >>> On 1/31/19 7:08 AM, Yuval Shaia wrote: Signed-off-by: Yuval Shaia --- hmp-commands-info.hx | 14 ++ monitor.c| 6 ++

Re: [Qemu-devel] [PATCH 1/5] nsis: don't install files into /tmp

2019-01-31 Thread Stefan Weil
On 29.01.19 22:07, Eric Blake wrote: > On 1/29/19 5:39 AM, Daniel P. Berrangé wrote: >> The nsis installer target has to run 'make install' to populate a >> directory tree with content for the package. Replace the current >> usage of '/tmp/qemu-nsis' with a location underneath the build >>

Re: [Qemu-devel] [PATCH 3/5] nsis: ensure we always pass -W64 flag to nsis installer script

2019-01-31 Thread Stefan Weil
On 29.01.19 12:39, Daniel P. Berrangé wrote: > The code to set the -W64 flag is inside a conditional block that only > executes when we are bundling DLLs with the installer. This results in > QEMU being installed in the wrong location on 64-bit hosts when DLLs > are not bundled. > >

Re: [Qemu-devel] [PATCH RFCv2 4/9] virtio-pmem: Prototype

2019-01-31 Thread Markus Armbruster
David Hildenbrand writes: > On 31.01.19 19:19, Markus Armbruster wrote: >> David Hildenbrand writes: >> >>> From: Pankaj Gupta >>> >>> This is the current protoype of virtio-pmem. Support will require >>> machine changes for the architectures that will support it, so it will >>> not yet be

[Qemu-devel] [PATCH] ui/cocoa.m: Fix macOS 10.14 deprecation warnings

2019-01-31 Thread Brendan Shanks
macOS 10.14 deprecated NSOnState/NSOffState in favour of NSControlStateValueOn/NSControlStateValueOff. Use the new constants, and #define them to the old ones when compiling against a pre-10.13 SDK. Also [NSGraphicsContext graphicsPort] is now deprecated, use [NSGraphicsContext CGContext] when

Re: [Qemu-devel] [PATCH] hw/s390x: Fix the function arguments in the pci stub file

2019-01-31 Thread Thomas Huth
On 2019-02-01 07:14, Thomas Huth wrote: > On 2019-01-31 19:08, Paolo Bonzini wrote: >> On 31/01/19 19:00, Thomas Huth wrote: > (and the prototypes in the header) anymore, so if you try to compile s390x > without CONFIG_PCI, the build currently fails. > Fixes: 468a93898a97

Re: [Qemu-devel] [PATCH 0/2] archive-source.sh: Clone the submodules locally and add to MAINTAINERS

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190124010023.24397-1-phi...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH v3 0/8] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190131071658.29120-1-tao3...@intel.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH v3] scripts: use git archive in archive-source

2019-01-31 Thread Gerd Hoffmann
Hi, > > tar_file=$(realpath "$1") > > -list_file="${tar_file}.list" > > -vroot_dir="${tar_file}.vroot" > > +sub_file=$(mktemp "${tar_file%.tar}.sub..tar") > > +sub_tdir=$(mktemp -d "${tar_file%.tar}.sub.") > > mktemp is not specified by POSIX; and FreeBSD man pages for mktemp

Re: [Qemu-devel] [PATCH] hw/s390x: Fix the function arguments in the pci stub file

2019-01-31 Thread Thomas Huth
On 2019-01-31 19:08, Paolo Bonzini wrote: > On 31/01/19 19:00, Thomas Huth wrote: (and the prototypes in the header) anymore, so if you try to compile s390x without CONFIG_PCI, the build currently fails. >>> Fixes: 468a93898a97 ("s390x/pci: pass the retaddr to all PCI instructions")

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Fix invalidate_cache error path for parent activation

2019-01-31 Thread Stefan Hajnoczi
On Thu, Jan 31, 2019 at 03:31:51PM +0100, Kevin Wolf wrote: > bdrv_co_invalidate_cache() clears the BDRV_O_INACTIVE flag before > actually activating a node so that the correct permissions etc. are > taken. In case of errors, the flag must be restored so that the next > call to

Re: [Qemu-devel] [Qemu-block] [PATCH] qtest.py: Wait for the result of qtest commands

2019-01-31 Thread Stefan Hajnoczi
On Thu, Jan 31, 2019 at 02:38:10PM +0200, Alberto Garcia wrote: > The cmd() method of the QEMUQtestProtocol class sends a qtest command > to QEMU but doesn't wait for the return message ("OK", "FAIL", "ERR"). > Because of this, it can return control to the caller before the > command has actually

Re: [Qemu-devel] [Qemu-block] Guest unresponsive after Virtqueue size exceeded error

2019-01-31 Thread Stefan Hajnoczi
On Thu, Jan 31, 2019 at 11:32:32AM +, Fernando Casas Schössow wrote: > Sorry for resurrecting this thread after so long but I just upgraded the host > to Qemu 3.1 and libvirt 4.10 and I'm still facing this problem. > At the moment I cannot use virtio disks (virtio-blk nor virtio-scsi) with my

Re: [Qemu-devel] [PATCH v11 for-4.0 11/11] qemu_thread: supplement error handling for touch_all_pages

2019-01-31 Thread Fei Li
It seems that this poor patch is left alone. :( I sent all, but this patch failed to join them, so sorry for that.. Could we just let it be? Have a nice day, thanks Fei 在 2019/2/1 下午1:25, Fei Li 写道: From: Fei Li Supplement the error handling for touch_all_pages: add an Error parameter for

Re: [Qemu-devel] [PATCH v11 for-4.0 09/11] qemu_thread: supplement error handling for migration

2019-01-31 Thread Fei Li
在 2019/2/1 下午1:18, Fei Li 写道: From: Fei Li Update qemu_thread_create()'s callers by - setting an error on qemu_thread_create() failure for callers that set an error on failure; - reporting the error and returning failure for callers that return an error code on failure; - reporting the

[Qemu-devel] [PATCH v11 for-4.0 11/11] qemu_thread: supplement error handling for touch_all_pages

2019-01-31 Thread Fei Li
From: Fei Li Supplement the error handling for touch_all_pages: add an Error parameter for it to propagate the error to its caller to do the handling in case it fails. Cc: Markus Armbruster Signed-off-by: Fei Li --- util/oslib-posix.c | 26 -- 1 file changed, 16

[Qemu-devel] [PATCH v11 for-4.0 09/11] qemu_thread: supplement error handling for migration

2019-01-31 Thread Fei Li
From: Fei Li Update qemu_thread_create()'s callers by - setting an error on qemu_thread_create() failure for callers that set an error on failure; - reporting the error and returning failure for callers that return an error code on failure; - reporting the error and setting some state for

Re: [Qemu-devel] [PATCH v2 1/5] virtio-blk: add acct_failed param to virtio_blk_handle_rw_error()

2019-01-31 Thread Stefan Hajnoczi
On Thu, Jan 31, 2019 at 04:19:10PM +0100, Stefano Garzarella wrote: > We add acct_failed param in order to use virtio_blk_handle_rw_error() > also when is not required to call block_acct_failed(). (eg. a discard > operation is failed) > > Signed-off-by: Stefano Garzarella > --- >

Re: [Qemu-devel] [PATCH v5 2/8] target/ppc: rework vmrg{l, h}{b, h, w} instructions to use Vsr* macros

2019-01-31 Thread Richard Henderson
On 1/30/19 12:36 PM, Mark Cave-Ayland wrote: > The current implementations make use of the endian-specific macros MRGLO/MRGHI > and also reference HI_IDX and LO_IDX directly to calculate array offsets. > > Rework the implementation to use the Vsr* macros so that these per-endian > references can

[Qemu-devel] [PATCH v11 for-4.0 06/11] qemu_thread: supplement error handling for emulated_realize

2019-01-31 Thread Fei Li
From: Fei Li Utilize the existed errp to propagate the error and do the corresponding cleanup to replace the temporary _abort. Cc: Markus Armbruster Cc: Gerd Hoffmann Signed-off-by: Fei Li --- hw/usb/ccid-card-emulated.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-)

Re: [Qemu-devel] [PATCH 00/18] Acceptance Tests: target architecture support

2019-01-31 Thread Aleksandar Markovic
>> I think, the term "arch" is a little problematic in QEMU parlance. IMHO, >> "target" should be used instead. ("arch" is used in Linux kernel community) > Naming things is hard, so this is a valid discussion. But, I have to > say that I also find "arch" in this context to be descriptive

[Qemu-devel] [PATCH v11 for-4.0 00/11] qemu_thread_create: propagate the error to callers to handle

2019-01-31 Thread Fei Li
Hi, This idea comes from BiteSizedTasks, and this patch series implement the error checking of qemu_thread_create: make qemu_thread_create return a flag to indicate if it succeeded rather than failing with an error; make all callers check it. The first patch modifies the qemu_thread_create() by

[Qemu-devel] [PATCH v11 for-4.0 01/11] qemu_thread: make qemu_thread_create() take Error ** argument

2019-01-31 Thread Fei Li
From: Fei Li qemu_thread_create() abort()s on error. Not nice. Give it a return value and an Error ** argument, so it can return success/failure. Considering qemu_thread_create() is quite widely used in qemu, split this into two steps: this patch passes the _abort to qemu_thread_create()

[Qemu-devel] [PATCH v11 for-4.0 08/11] qemu_thread: supplement error handling for qemu_signalfd_compat

2019-01-31 Thread Fei Li
From: Fei Li For qemu_signalfd_compat: set errno, do some cleanup, and return -1 to replace the temporary _abort when failing to create sigwait_compat. Cc: Markus Armbruster Cc: Eric Blake Signed-off-by: Fei Li --- util/compatfd.c | 13 ++--- 1 file changed, 10 insertions(+), 3

[Qemu-devel] [PATCH v11 for-4.0 05/11] qemu_thread: supplement error handling for h_resize_hpt_prepare

2019-01-31 Thread Fei Li
From: Fei Li Add a local_err to hold the error, and return the corresponding error code to replace the temporary _abort. Cc: Markus Armbruster Cc: David Gibson Signed-off-by: Fei Li Acked-by: David Gibson --- hw/ppc/spapr_hcall.c | 12 1 file changed, 8 insertions(+), 4

[Qemu-devel] [PATCH v11 for-4.0 03/11] qemu_thread: supplement error handling for qmp_dump_guest_memory

2019-01-31 Thread Fei Li
From: Fei Li Utilize the existed errp to propagate the error instead of the temporary _abort. Cc: Markus Armbruster Cc: Marc-André Lureau Signed-off-by: Fei Li --- dump.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dump.c b/dump.c index e4886bc9c3..92cc277015

[Qemu-devel] [PATCH v11 for-4.0 07/11] qemu_thread: supplement error handling for iothread_complete

2019-01-31 Thread Fei Li
From: Fei Li For iothread_complete: utilize the existed errp to propagate the error and do the corresponding cleanup to replace the temporary _abort. Cc: Markus Armbruster Cc: Stefan Hajnoczi Cc: Eric Blake Signed-off-by: Fei Li --- iothread.c | 19 +-- 1 file changed, 13

[Qemu-devel] [PATCH v11 for-4.0 10/11] qemu_thread: supplement error handling for vnc_start_worker_thread

2019-01-31 Thread Fei Li
From: Fei Li Supplement the error handling for vnc_thread_worker_thread: add an Error parameter for it to propagate the error to its caller to handle in case it fails, and make it return a Boolean to indicate whether it succeeds. Cc: Markus Armbruster Cc: Gerd Hoffmann Signed-off-by: Fei Li

[Qemu-devel] [PATCH v11 for-4.0 04/11] qemu_thread: supplement error handling for pci_edu_realize

2019-01-31 Thread Fei Li
From: Fei Li Utilize the existed errp to propagate the error and do the corresponding cleanup to replace the temporary _abort. Cc: Markus Armbruster Cc: Jiri Slaby Signed-off-by: Fei Li --- hw/misc/edu.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v11 for-4.0 02/11] qemu_thread: supplement error handling for qemu_X_start_vcpu

2019-01-31 Thread Fei Li
From: Fei Li The callers of qemu_init_vcpu() already passed the **errp to handle errors. In view of this, add a new Error parameter to qemu_init_vcpu() and all qemu_X_start_vcpu() functions called by qemu_init_vcpu() to propagate the error and let the further callers check it. Besides, make

Re: [Qemu-devel] [PATCH v2 5/5] tests/virtio-blk: add test for WRITE_ZEROES command

2019-01-31 Thread Stefan Hajnoczi
On Thu, Jan 31, 2019 at 04:19:14PM +0100, Stefano Garzarella wrote: > If the WRITE_ZEROES feature is enabled, we check this command > in the test_basic(). > > Signed-off-by: Stefano Garzarella > --- > tests/virtio-blk-test.c | 60 + > 1 file changed, 60

Re: [Qemu-devel] [PATCH v11 for-4.0 00/11] qemu_thread_create: propagate the error to callers to handle

2019-01-31 Thread Fei Li
Sorry again! Please omit this email. It seems there's something wrong with my send-email.. :( Have a nice day Fei 在 2019/2/1 下午1:09, Fei Li 写道: Hi, This idea comes from BiteSizedTasks, and this patch series implement the error checking of qemu_thread_create: make qemu_thread_create return a

Re: [Qemu-devel] [PATCH v2 4/5] tests/virtio-blk: change assert on data_size in virtio_blk_request()

2019-01-31 Thread Stefan Hajnoczi
On Thu, Jan 31, 2019 at 04:19:13PM +0100, Stefano Garzarella wrote: > The size of data in the virtio_blk_request must be a multiple > of 512 bytes for IN and OUT requests, or a multiple of the size > of struct virtio_blk_discard_write_zeroes for DISCARD and > WRITE_ZEROES requests. > >

[Qemu-devel] [PATCH v11 for-4.0 00/11] qemu_thread_create: propagate the error to callers to handle

2019-01-31 Thread Fei Li
Hi, This idea comes from BiteSizedTasks, and this patch series implement the error checking of qemu_thread_create: make qemu_thread_create return a flag to indicate if it succeeded rather than failing with an error; make all callers check it. The first patch modifies the qemu_thread_create() by

Re: [Qemu-devel] [PATCH v1 00/14] testing/next (binfmt_misc, vm-build and BSD CI)

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190125140017.6092-1-alex.ben...@linaro.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [Qemu-devel] [PATCH v2 3/5] virtio-blk: add DISCARD and WRITE ZEROES features

2019-01-31 Thread Stefan Hajnoczi
On Thu, Jan 31, 2019 at 04:19:12PM +0100, Stefano Garzarella wrote: > diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c > index 542ec52536..34ee676895 100644 > --- a/hw/block/virtio-blk.c > +++ b/hw/block/virtio-blk.c > @@ -147,6 +147,30 @@ out: >

Re: [Qemu-devel] [PATCH for-4.0 00/11] qemu_thread_create: propagate the error to callers to handle

2019-01-31 Thread Fei Li
在 2019/2/1 上午2:05, Markus Armbruster 写道: I'm afraid you made a bit of a mess :) "[PATCH for-4.0 00/11]" suggests this is v1 of eleven patches. Awkward, I forgot the v10.. =-O Fei Li writes: Hi, This idea comes from BiteSizedTasks, and this patch series implement the error checking of

Re: [Qemu-devel] [PATCH v2 2/5] virtio-blk: add "discard-wzeroes" boolean property

2019-01-31 Thread Stefan Hajnoczi
On Thu, Jan 31, 2019 at 04:19:11PM +0100, Stefano Garzarella wrote: > In order to avoid migration issues, we enable DISCARD and > WRITE ZEROES features only for machine type >= 4.0 Please use two separate properties that correspond to the VIRTIO_BLK_F_DISCARD and VIRTIO_BLK_F_WRITE_ZEROES

Re: [Qemu-devel] [RFC PATCH v3 2/7] target/ppc: Add ppc_get_trace_int_handler_addr

2019-01-31 Thread Alexey Kardashevskiy
On 19/01/2019 01:07, Fabiano Rosas wrote: > The upcoming single step functionality (KVM HV) needs to write to the > Trace Interrupt handler's address for its mechanism to work. The > address is calculated by applying an offset according to the value of > the Alternate Interrupt Location (AIL)

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 2/3] target/ppc: Add GDB callbacks for SPRs

2019-01-31 Thread Alexey Kardashevskiy
On 01/02/2019 08:57, Fabiano Rosas wrote: > Alexey Kardashevskiy writes: > >> On 31/01/2019 03:30, Fabiano Rosas wrote: >>> Alexey Kardashevskiy writes: >>> but this is a register which does not have endianness, the endianness appears here because the interface between gdb and

Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/ppc: Don't include m48t59.h if it is not necessary

2019-01-31 Thread David Gibson
On Thu, Jan 31, 2019 at 03:12:48PM +0100, Thomas Huth wrote: > On 2019-01-30 18:21, Philippe Mathieu-Daudé wrote: > > On 1/30/19 5:39 PM, Thomas Huth wrote: > >> These files don't use anything from m48t59.h, so no need to include > >> this header here. > >> > >> Signed-off-by: Thomas Huth > >>

Re: [Qemu-devel] [PATCH qemu] spapr_pci: Fix endianness in assigned-addresses property

2019-01-31 Thread David Gibson
On Fri, Feb 01, 2019 at 11:56:22AM +1100, Alexey Kardashevskiy wrote: > reg->phys_hi and assigned->phys_hi are big endian but we do an extra > byteswap anyway when copying reg->phys_hi to assigned->phys_hi. > To make things slightly more messy, we also add a relocatable bit (b_n()) > although in

Re: [Qemu-devel] [PATCH] monitor: Add whitelist support for QMP commands

2019-01-31 Thread Stefan Hajnoczi
On Thu, Jan 31, 2019 at 11:26:37PM +0300, Julia Suvorova wrote: > The whitelist option allows to run a reduced monitor with a subset of > QMP commands. This allows the monitor to run in secure mode, which is > convenient for sending commands via the WebSocket monitor using the > web UI. This is

Re: [Qemu-devel] Configuring pflash devices for OVMF firmware

2019-01-31 Thread Ning, Yu
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Friday, February 1, 2019 7:55 > To: Alexandro Sanchez Bach ; 'Markus Armbruster' > > Cc: 'Peter Maydell' ; 'Peter Krempa' > ; 'Qemu-block' ; 'Libvirt' > ; 'QEMU Developers' ; > 'László Érsek' ; 'Justin Terry

[Qemu-devel] [PATCH v4 1/3] hw/nvram/nrf51_nvm: Add nRF51 non-volatile memories

2019-01-31 Thread Stefan Hajnoczi
From: Steffen Görtz The nRF51 contains three regions of non-volatile memory (NVM): - CODE (R/W): contains code - FICR (R): Factory information like code size, chip id etc. - UICR (R/W): Changeable configuration data. Lock bits, Code protection configuration, Bootloader address, Nordic

[Qemu-devel] [PATCH v4 3/3] tests/microbit-test: Add tests for nRF51 NVMC

2019-01-31 Thread Stefan Hajnoczi
From: Steffen Görtz Signed-off-by: Steffen Görtz Signed-off-by: Stefan Hajnoczi Acked-by: Thomas Huth Reviewed-by: Peter Maydell --- tests/microbit-test.c | 108 ++ 1 file changed, 108 insertions(+) diff --git a/tests/microbit-test.c

[Qemu-devel] [PATCH v4 2/3] arm: Instantiate NRF51 special NVM's and NVMC

2019-01-31 Thread Stefan Hajnoczi
From: Steffen Görtz Instantiates UICR, FICR, FLASH and NVMC in nRF51 SOC. Signed-off-by: Steffen Görtz Reviewed-by: Peter Maydell Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi --- include/hw/arm/nrf51_soc.h | 2 ++ hw/arm/nrf51_soc.c | 41

[Qemu-devel] [PATCH v4 0/3] arm: microbit Non-Volatile Memory Controller

2019-01-31 Thread Stefan Hajnoczi
v4: * assert(offset + size <= s->flash_size) [Peter] v3: * Fix endianness of s->storage[], tested by Joel Stanley on big-endian ppc [Peter] * Fix off-by-one that prevented clearing the last page of flash * Add missing memory_region_flush_rom_device() call to flash_write() v2: * Add Patch

Re: [Qemu-devel] [PATCH v5 3/6] libvhost-user: Support tracking inflight I/O in shared memory

2019-01-31 Thread Jason Wang
On 2019/1/30 下午1:48, Yongji Xie wrote: On Wed, 30 Jan 2019 at 10:32, Jason Wang wrote: On 2019/1/22 下午4:31, elohi...@gmail.com wrote: +static int +vu_queue_inflight_get(VuDev *dev, VuVirtq *vq, int desc_idx) +{ +if (!has_feature(dev->protocol_features, +

Re: [Qemu-devel] [PATCH v5 3/6] libvhost-user: Support tracking inflight I/O in shared memory

2019-01-31 Thread Jason Wang
On 2019/1/30 上午11:58, Yongji Xie wrote: On Wed, 30 Jan 2019 at 10:32, Jason Wang wrote: On 2019/1/22 下午4:31, elohi...@gmail.com wrote: +static int +vu_queue_inflight_get(VuDev *dev, VuVirtq *vq, int desc_idx) +{ +if (!has_feature(dev->protocol_features, +

[Qemu-devel] [RFC PATCH] target/arm: Fix int128_make128 lo, hi order in paired_cmpxchg64_be

2019-01-31 Thread Catherine Ho
The lo,hi order is different from the comments. And in commit 1ec182c33379 ("target/arm: Convert to HAVE_CMPXCHG128"), it changes the original code logic. So just restore the old code logic before this commit: do_paired_cmpxchg64_be(): cmpv = int128_make128(env->exclusive_high,

[Qemu-devel] [PATCH] pc-dimm: use same mechanism for [get|set]_addr

2019-01-31 Thread Wei Yang
[get|set]_addr are two counterpart to access PCDIMMDevice.addr. Since we have already set up a property PC_DIMM_ADDR_PROP for this field and use this mechanism in set_addr, it would be more proper to use the same mechanism in set_addr. This patch uses object_property_get_uint() to replace the

[Qemu-devel] [PATCH qemu] spapr_pci: Fix endianness in assigned-addresses property

2019-01-31 Thread Alexey Kardashevskiy
reg->phys_hi and assigned->phys_hi are big endian but we do an extra byteswap anyway when copying reg->phys_hi to assigned->phys_hi. To make things slightly more messy, we also add a relocatable bit (b_n()) although in the right endianness. This fixes endianness of assigned->phys_hi. This is

[Qemu-devel] [PATCH qemu] spapr/rtas: Force big endian compile for rtas

2019-01-31 Thread Alexey Kardashevskiy
At the moment the rtas's Makefile uses generic QEMU rules which means that when QEMU is compiled on a little endian system, the spapr-rtas.bin is compiled as little endian too which is incorrect as it is always executed in big endian mode. This enforces -mbig by defining %.o:%.S rule as

Re: [Qemu-devel] Configuring pflash devices for OVMF firmware

2019-01-31 Thread Paolo Bonzini
On 01/02/19 00:28, Alexandro Sanchez Bach wrote: > (CC'd Yu Ning @ Intel's HAXM team) > > Not sure, if I'm understanding the issue correctly, but isn't > `HAX_VM_IOCTL_SET_RAM2` with the `HAX_RAM_INFO_ROM` flag precisely > what you are looking for? > > More precisely, HAX_VM_IOCTL_SET_RAM2 maps

Re: [Qemu-devel] Configuring pflash devices for OVMF firmware

2019-01-31 Thread Alexandro Sanchez Bach
>> This is all greek to me. I take it there's something wrong with these >> accelerators that makes (read-only?) flash memory not work, even >> though the read-only mapping we now create for traditional BIOS works. >> Weird, but I'm of course willing to take your word for it. > Yes, as I

Re: [Qemu-devel] [PATCH] target/arm: Make FPSCR/FPCR trapped-exception bits RAZ/WI

2019-01-31 Thread Richard Henderson
On 1/31/19 5:07 AM, Peter Maydell wrote: > The {IOE, DZE, OFE, UFE, IXE, IDE} bits in the FPSCR/FPCR are for > enabling trapped IEEE floating point exceptions (where IEEE exception > conditions cause a CPU exception rather than updating the FPSR status > bits). QEMU doesn't implement this (and nor

Re: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190122092909.5341-1-kbast...@mail.uni-paderborn.de Subject: [Qemu-devel]

Re: [Qemu-devel] Configuring pflash devices for OVMF firmware

2019-01-31 Thread Paolo Bonzini
On 31/01/19 13:12, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 31/01/19 10:41, Markus Armbruster wrote: >>> Paolo Bonzini writes: >>> On 31/01/19 09:40, Markus Armbruster wrote: >> Maybe we should just add pflash block properties to the machine? And >> then it can

Re: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree Type: series Message-id:

Re: [Qemu-devel] [PATCH 0/5] hw/arm/boot: Support DTB autoload for firmware-only boots

2019-01-31 Thread Richard Henderson
On 1/31/19 3:22 AM, Peter Maydell wrote: > Peter Maydell (5): > hw/arm/boot: Fix block comment style in arm_load_kernel() > hw/arm/boot: Factor out "direct kernel boot" code into its own > function > hw/arm/boot: Factor out "set up firmware boot" code > hw/arm/boot: Clarify why

Re: [Qemu-devel] [RFC PATCH 10/11] qcow2: Store data file name in the image

2019-01-31 Thread Nir Soffer
On Thu, Jan 31, 2019 at 8:20 PM Kevin Wolf wrote: > Rather than requiring that the external data file node is passed > explicitly when creating the qcow2 node, store the filename in the > designated header extension during .bdrv_create and read it from there > as a default during .bdrv_open. >

Re: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1548410831-19553-1-git-send-email-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU Message-id:

Re: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1548410831-19553-1-git-send-email-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1548410831-19553-1-git-send-email-pbonz...@redhat.com Subject: [Qemu-devel]

Re: [Qemu-devel] [PATCH 41/52] isa: express dependencies with kconfig

2019-01-31 Thread Philippe Mathieu-Daudé
On 1/31/19 11:14 PM, Paolo Bonzini wrote: > On 31/01/19 22:22, Philippe Mathieu-Daudé wrote: >> I kinda disagree with the SuperIO generated configs here, but partly my >> fault because the previous Makefile.objs missed the CONFIG_ISA_SUPERIO >> (I missed to review eae2e2e96bf from Thomas where is

Re: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1548410831-19553-1-git-send-email-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU Type: series Message-id:

Re: [Qemu-devel] [PATCH 43/52] i2c: express dependencies with Kconfig

2019-01-31 Thread Paolo Bonzini
On 31/01/19 23:10, Philippe Mathieu-Daudé wrote: > config SMBUS > bool > select I2C > > config SMBUS_EEPROM > bool > select SMBUS > > (or 'depends on') Sure. Paolo

Re: [Qemu-devel] [PATCH 41/52] isa: express dependencies with kconfig

2019-01-31 Thread Paolo Bonzini
On 31/01/19 22:22, Philippe Mathieu-Daudé wrote: > I kinda disagree with the SuperIO generated configs here, but partly my > fault because the previous Makefile.objs missed the CONFIG_ISA_SUPERIO > (I missed to review eae2e2e96bf from Thomas where is introduced > CONFIG_SMC37C669). > So

Re: [Qemu-devel] [PATCH] monitor: Add whitelist support for QMP commands

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190131202637.4062-1-jus...@mail.ru/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190131202637.4062-1-jus...@mail.ru Subject: [Qemu-devel] [PATCH] monitor: Add whitelist

Re: [Qemu-devel] [PATCH 40/52] scsi: express dependencies with Kconfig

2019-01-31 Thread Paolo Bonzini
On 31/01/19 22:23, Philippe Mathieu-Daudé wrote: > You missed: > > -common-obj-y += scsi-disk.o emulation.o > -common-obj-y += scsi-generic.o scsi-bus.o > +common-obj-$(CONFIG_SCSI) += scsi-disk.o emulation.o > +common-obj-$(CONFIG_SCSI) += scsi-generic.o scsi-bus.o > I didn't: :)

Re: [Qemu-devel] [RFC PATCH v4 00/44] Support Kconfig in QEMU

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190123065618.3520-1-yang.zh...@intel.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [Qemu-devel] [PATCH 33/52] build: switch to Kconfig

2019-01-31 Thread Paolo Bonzini
On 31/01/19 22:48, Philippe Mathieu-Daudé wrote: > There is something I don't understand here: Does CONFIG_XEN in > Kconfig.host take precedence over the target configs? I'm looking at > these configs: > > if supported_xen_target $target; then > echo "CONFIG_XEN=n" >> $config_target_mak >

Re: [Qemu-devel] [PATCH 31/52] hw/display: make edid configurable

2019-01-31 Thread Philippe Mathieu-Daudé
On 1/25/19 11:06 AM, Paolo Bonzini wrote: > From: Yang Zhong > > Use CONFIG_EDID to make edid-generate.c and edid-region.c > configurable. > > Signed-off-by: Yang Zhong > Reviewed-by: Thomas Huth > Message-Id: <20190123065618.3520-26-yang.zh...@intel.com> > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH 43/52] i2c: express dependencies with Kconfig

2019-01-31 Thread Philippe Mathieu-Daudé
Hi Paolo, On 1/25/19 11:07 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > Acked-by: Thomas Huth > Message-Id: <20190123065618.3520-38-yang.zh...@intel.com> > Signed-off-by: Paolo Bonzini > --- > default-configs/i386-softmmu.mak | 2 -- >

[Qemu-devel] [RFC PATCH 0/3] lm32: convert to new common tcg infrastructure

2019-01-31 Thread Michael Walle
The main problem here is, that there is no prebuilt compiler packages. Thus I have to build the toolchain from scratch. I don't know if this is OK in the docker image. For now only binutils is built. But then, I'll have to pass the LD and AS environment variables, too. And it won't work with the

[Qemu-devel] [RFC PATCH 2/3] tests/tcg: also pass AS and LD variables

2019-01-31 Thread Michael Walle
The lm32 architecture doesn't need the complete compiler. In fact, only the building of GCC is skipped to make building the docker image faster. Signed-off-by: Michael Walle --- tests/tcg/Makefile.include | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] target/s390x: Fix LGPL version in the file header comments

2019-01-31 Thread Richard Henderson
On 1/30/19 7:01 AM, Eric Blake wrote: > On 1/29/19 7:51 AM, Cornelia Huck wrote: >> Given that there have been several of these cases (and that there's a >> lot of boilerplate in general): Should we adopt SPDX license >> identifiers for QEMU, as the Linux kernel did? They also discovered and >>

[Qemu-devel] [RFC PATCH 3/3] tests/tcg/lm32: enable system tests

2019-01-31 Thread Michael Walle
Convert the existing to the new common cross build infrastructure. Signed-off-by: Michael Walle --- tests/tcg/lm32/Makefile| 106 - tests/tcg/lm32/Makefile.include| 8 +++ tests/tcg/lm32/Makefile.softmmu-target | 33 ++ 3 files

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 2/3] target/ppc: Add GDB callbacks for SPRs

2019-01-31 Thread Fabiano Rosas
Alexey Kardashevskiy writes: > On 31/01/2019 03:30, Fabiano Rosas wrote: >> Alexey Kardashevskiy writes: >> >>> >>> but this is a register which does not have endianness, the endianness >>> appears here because the interface between gdb and qemu is >>> uint8_t*==bytestream but this interface

Re: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1548410831-19553-1-git-send-email-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU Type: series Message-id:

[Qemu-devel] [RFC PATCH 1/3] tests/docker: add debian-lm32-cross image

2019-01-31 Thread Michael Walle
Unfortunately, there is no debian package for the lm32 toolchain. To keep the build times short, only build the binutils from scratch. Signed-off-by: Michael Walle --- tests/docker/Makefile.include | 5 ++-- tests/docker/dockerfiles/debian-lm32-cross.docker | 31

Re: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1548410831-19553-1-git-send-email-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1548410831-19553-1-git-send-email-pbonz...@redhat.com Subject: [Qemu-devel]

Re: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1548410831-19553-1-git-send-email-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU Message-id:

Re: [Qemu-devel] [PATCH] monitor: Add whitelist support for QMP commands

2019-01-31 Thread Julia Suvorova via Qemu-devel
On 01.02.2019 0:03, Eric Blake wrote: On 1/31/19 2:26 PM, Julia Suvorova via Qemu-devel wrote: The whitelist option allows to run a reduced monitor with a subset of QMP commands. This allows the monitor to run in secure mode, which is convenient for sending commands via the WebSocket monitor

Re: [Qemu-devel] [PATCH 05/52] build: actually use CONFIG_PAM

2019-01-31 Thread Philippe Mathieu-Daudé
On 1/25/19 11:06 AM, Paolo Bonzini wrote: > Do not link it unconditionally into all binaries. Nice :) > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > Reviewed-by: Thomas Huth > Message-Id: <20190123065618.3520-3-yang.zh...@intel.com> > Signed-off-by: Paolo Bonzini Reviewed-by:

Re: [Qemu-devel] [PATCH 10/52] hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards

2019-01-31 Thread Philippe Mathieu-Daudé
On 1/25/19 11:06 AM, Paolo Bonzini wrote: > From: Ákos Kovács > > Add the new configs to default-configs/mips*-sofmmu.mak. > > Signed-off-by: Ákos Kovács > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > Message-Id: <20190123065618.3520-8-yang.zh...@intel.com> > Reviewed-by:

Re: [Qemu-devel] [Qemu-block] [RFC PATCH 00/11] qcow2: External data files

2019-01-31 Thread Nir Soffer
On Thu, Jan 31, 2019 at 7:57 PM Kevin Wolf wrote: This will be very useful for new oVirt Cinder based storage. Thanks for working on this! I did not see any discussion about this here, but I did not follow this list closely lately. Do we have more info on this? a feature page describing the use

Re: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree Message-id:

Re: [Qemu-devel] [PATCH 33/52] build: switch to Kconfig

2019-01-31 Thread Philippe Mathieu-Daudé
Hi Paolo, On 1/25/19 11:06 AM, Paolo Bonzini wrote: > The make_device_config.sh script is replaced by minikconf, which > is modified to support the same command line as its predecessor. > > The roots of the parsing are default-configs/*.mak, Kconfig.host and > hw/Kconfig. One difference with

Re: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree Type: series Message-id:

Re: [Qemu-devel] [Qemu-block] [RFC PATCH 01/11] qcow2: Extend spec for external data files

2019-01-31 Thread Nir Soffer
On Thu, Jan 31, 2019 at 8:43 PM Eric Blake wrote: ... > > @@ -450,8 +461,10 @@ Standard Cluster Descriptor: > > 1 - 8:Reserved (set to 0) > > > > 9 - 55:Bits 9-55 of host cluster offset. Must be aligned > to a > > -cluster boundary. If the offset

Re: [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1)

2019-01-31 Thread Stefan Berger
On 1/31/19 1:51 PM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20190121170731.2500692-1-stef...@linux.ibm.com/ Seems unrelated to the series I sent...

Re: [Qemu-devel] [PATCH] tcg: add early clober modifier in atomic16_cmpxchg on aarch64

2019-01-31 Thread Richard Henderson
On 1/30/19 12:59 AM, Catherine Ho wrote: > Without this patch, gcc might up the Input/Output registers and > cause unpredictable error. > > Fixes: 1ec182c33379 ("target/arm: Convert to HAVE_CMPXCHG128") > > Signed-off-by: Catherine Ho Queued, thanks. r~

Re: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190122092909.5341-1-kbast...@mail.uni-paderborn.de Subject: [Qemu-devel]

Re: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree Type: series Message-id:

Re: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree Message-id:

Re: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree Message-id:

Re: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190122092909.5341-1-kbast...@mail.uni-paderborn.de Subject: [Qemu-devel]

  1   2   3   4   5   >