Thank you for your review and feedback, Richard.
As Eric mentioned, this is the first time contribution. I have been
exploring Qemu for some time and try to understand main flow, internals,
..etc.
> You cannot manipulate env like this during translation.
> Neither the write to env->pc_next nor
On Fri, Feb 22, 2019 at 10:53:54AM -0500, Michael S. Tsirkin wrote:
> On Fri, Feb 22, 2019 at 03:47:36PM +, Peter Maydell wrote:
> > On Fri, 22 Feb 2019 at 02:40, Michael S. Tsirkin wrote:
> > >
> > > The following changes since commit
> > > fc3dbb90f2eb069801bfb4cfe9cbc83cf9c5f4a9:
> > >
>
On Sat, Feb 23, 2019 at 09:10:01PM +0800, Yongji Xie wrote:
> On Fri, 22 Feb 2019 at 22:54, Michael S. Tsirkin wrote:
> >
> > On Fri, Feb 22, 2019 at 03:05:23PM +0800, Yongji Xie wrote:
> > > On Fri, 22 Feb 2019 at 14:21, Michael S. Tsirkin wrote:
> > > >
> > > > On Fri, Feb 22, 2019 at
On 2/24/19 12:29 AM, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> docs/decodetree.rst | 58 +
> scripts/decodetree.py | 144 ++
> 2 files changed, 191 insertions(+), 11 deletions(-)
>
> diff --git
On 2/24/19 12:29 AM, Richard Henderson wrote:
> As a consequence, the 'return false' gets pushed up one level.
>
> This will allow us to perform some other action when the
> translator returns failure.
>
> Signed-off-by: Richard Henderson
Tested-by: Philippe Mathieu-Daudé
Reviewed-by:
Signed-off-by: Richard Henderson
---
docs/decodetree.rst | 58 +
scripts/decodetree.py | 144 ++
2 files changed, 191 insertions(+), 11 deletions(-)
diff --git a/docs/decodetree.rst b/docs/decodetree.rst
index d9be30b2db..391069c105
As a consequence, the 'return false' gets pushed up one level.
This will allow us to perform some other action when the
translator returns failure.
Signed-off-by: Richard Henderson
---
scripts/decodetree.py | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
From: Philippe Mathieu-Daudé
Reproduced with "scripts/decodetree.py /dev/null".
Reviewed-by: Eduardo Habkost
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
scripts/decodetree.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
One great big block comment isn't the best way to document
the syntax of a language.
Signed-off-by: Richard Henderson
---
MAINTAINERS | 1 +
docs/decodetree.rst | 156 ++
scripts/decodetree.py | 134 +---
3
It seems clearer to decode specializations of OR within decodetree
instead of by hand within the translation function.
Signed-off-by: Richard Henderson
---
target/hppa/translate.c | 106 ---
target/hppa/insns.decode | 10 +++-
2 files changed, 64
Signed-off-by: Richard Henderson
---
target/riscv/insn_trans/trans_rvc.inc.c | 60 +
target/riscv/insn16.decode | 23 +++---
target/riscv/insn32.decode | 18
3 files changed, 48 insertions(+), 53 deletions(-)
diff --git
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20181110211313.6922-2-f4...@amsat.org>
Signed-off-by: Richard Henderson
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b1d786cfd8..ad007748b9 100644
---
Two of these have been sitting around on a branch for too long.
Then, split out the documentation to a new file.
Finally, support overlapping patterns. To demonstrate, I convert two
decodetree users: hppa and riscv, rfc patches appended to the series.
r~
Philippe Mathieu-Daudé (2):
On 2/22/19 8:26 PM, Aleksandar Markovic wrote:
> From: Aleksandar Markovic
>
> Add section on MIPS' Boston board in QEMU user documentation.
>
> Signed-off-by: Aleksandar Markovic
> ---
> qemu-doc.texi | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/qemu-doc.texi
On 2/22/19 8:26 PM, Aleksandar Markovic wrote:
> From: Aleksandar Markovic
>
> Move section on MIPS' mipssim pseudo board to the more
> appropriate place.
>
> Signed-off-by: Aleksandar Markovic
Reviewed-by: Philippe Mathieu-Daudé
> ---
> qemu-doc.texi | 26 +-
> 1
On 2/22/19 8:26 PM, Aleksandar Markovic wrote:
> From: Aleksandar Markovic
>
> Add section on MIPS' Fulong 2E board in QEMU user documentation.
>
> Signed-off-by: Aleksandar Markovic
Reviewed-by: Philippe Mathieu-Daudé
> ---
> qemu-doc.texi | 13 +
> 1 file changed, 13
On 2/22/19 6:06 PM, John Snow wrote:
> This adds a simple test that ensures the busy bit works for push backups,
> as well as doubling as bonus test for incremental backups that get interrupted
> by EIO errors.
This makes 124 longer to run, but it is not in the 'quick' group, so
that's okay.
The
On 2/22/19 5:38 PM, michelhe...@gmail.com wrote:
> From: Michel Heily
>
> Signed-off-by: Michel Heily
This appears to be your first contribution to qemu. Welcome to the
community!
Your commit message doesn't give any details beyond the "what" in the
subject line. The body of the commit
On 2/22/19 10:25 AM, amagdy.af...@gmail.com wrote:
> From: ahmed_magdy
>
> Signed-off-by: ahmed_magdy
This appears to be your first contribution to qemu. Welcome to the
community!
Typically, a Signed-off-by designation should be a proper name (what you
would sign a legal document with, as it
On 2/22/19 6:06 PM, John Snow wrote:
> Simply move the big status enum comment block to above the status
> function, and document it as being deprecated. The whole confusing
> block can get deleted in three releases time.
>
> Signed-off-by: John Snow
> ---
> block/dirty-bitmap.c | 36
On 2/22/19 6:06 PM, John Snow wrote:
> This field isn't present anymore.
>
> Signed-off-by: John Snow
> ---
> blockdev.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Eric Blake
>
> diff --git a/blockdev.c b/blockdev.c
> index 1aaadb6128..cbce44877d 100644
> --- a/blockdev.c
> +++
On 2/22/19 6:06 PM, John Snow wrote:
> These mean the same thing now. Unify them and rename the merged call
> bdrv_dirty_bitmap_busy to indicate semantically what we are describing,
> as well as help disambiguate from the various _locked and _unlocked
> versions of bitmap helpers that refer to
On 2/22/19 6:06 PM, John Snow wrote:
> Check that the bitmap is not in use prior to it checking if it is
> not enabled/recording guest writes. The bitmap being busy was likely
> at the behest of the user, so this error has a greater chance of being
> understood by the user.
>
> Signed-off-by:
On 2/22/19 6:06 PM, John Snow wrote:
> Currently, the enabled predicate means something like:
> "the QAPI status of the bitmap is ACTIVE."
> After this patch, it should mean exclusively:
> "This bitmap is recording guest writes, and is allowed to do so."
>
> In many places, this is how this
On 2/22/19 6:06 PM, John Snow wrote:
> bdrv_set_dirty_bitmap and bdrv_reset_dirty_bitmap are only used as an
> internal API by the mirror and migration areas of our code. These
> calls modify the bitmap, but do so at the behest of QEMU and not the
> guest.
>
> Presently, these bitmaps are always
On 2/22/19 6:06 PM, John Snow wrote:
> "Frozen" was a good description a long time ago, but it isn't adequate now.
> Rename the frozen predicate to has_successor to make the semantics of the
> predicate more clear to outside callers.
>
> In the process, remove some calls to frozen() that no
On 2/22/19 6:06 PM, John Snow wrote:
> The current API allows us to report a single status, which we've defined as:
>
> Frozen: has a successor, treated as qmp_locked, may or may not be enabled.
> Locked: no successor, qmp_locked. may or may not be enabled.
> Disabled: Not frozen or locked,
Hi all.
I've found two problems during my developing of backup-top filter.
The first one was already discussed in context of backup-top series,
so, here is patch 01 taken from it, previously it was
03 of [PATCH v5 00/11] backup-top filter driver for backup
bdrv_check_perm in it's recursion checks each node in context of new
permissions for one parent, because of nature of DFS. It works well,
while children subgraph of top-most updated node is a tree, i.e. it
doesn't have any kind of loops. But if we have a loop (not oriented,
of course), i.e. we
Add two tests of node graph modification.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/test-bdrv-graph-mod.c | 198
tests/Makefile.include | 2 +
2 files changed, 200 insertions(+)
create mode 100644 tests/test-bdrv-graph-mod.c
diff --git
As it already said in the comment, we don't want to create loops in
parent->child relations. So, when we try to append @to to @c, we should
check that @c is not in @to children subtree, and we should check it
recursively, not only the first level. The patch provides BFS-based
search, to check the
On Fri, 22 Feb 2019 at 14:07, Stefan Hajnoczi wrote:
> Richard: Commit 7db2145a6826b14efceb8dd64bfe6ad8647072eb ("bswap: Add
> host endian unaligned access functions") introduced the unaligned
> memory access functions in question here. Please see below for
> details on the bug - basically QEMU
Hi Natanael,
The package information is the following:
https://pkgs.alpinelinux.org/package/v3.9/main/x86_64/qemu-system-x86_64
The binary is for x86_64 architecture and dynamically linked:
fernando@vmsvr01:~$ file /usr/bin/qemu-system-x86_64
/usr/bin/qemu-system-x86_64: ELF 64-bit LSB shared
On Sat, 23 Feb 2019 at 16:05, Natanael Copa wrote:
> I was thinking of something in the lines of:
>
> typedef volatile uint16_t __attribute__((__may_alias__)) volatile_uint16_t;
> static inline int lduw_he_p(const void *ptr)
> {
> volatile_uint16_t r = *(volatile_uint16_t*)ptr;
> return
On Fri, 22 Feb 2019 14:04:20 +
Stefan Hajnoczi wrote:
> On Fri, Feb 22, 2019 at 12:57 PM Fernando Casas Schössow
> wrote:
>
> I have CCed Natanael Copa, qemu package maintainer in Alpine Linux.
>
> Fernando: Can you confirm that the bug occurs with an unmodified
> Alpine Linux qemu
This adds a handler for ibm,get-vpd RTAS calls, allowing pseries
guest to collect host information. It is disabled by default to
avoid unwanted information leakage. To enable it, use:
‘-M pseries,vpd-export=on’
Only the SE and TM keywords are returned at the moment:
SE for Machine or Cabinet
From: Yuval Shaia
This hook was installed to close the device when VM is going down.
After the device is closed there is no need to be informed on VM
shutdown.
Signed-off-by: Yuval Shaia
Reviewed-by: Marcel Apfelbaum
Message-Id: <20190213065357.16076-11-yuval.sh...@oracle.com>
Signed-off-by:
Configuring QEMU with:
configure --target-list="x86_64-softmmu" --cc=clang --enable-pvrdma
Results in:
qemu/hw/rdma/rdma_rm_defs.h:108:3: error: redefinition of typedef
'RdmaDeviceResources' is a C11 feature [-Werror,-Wtypedef-redefinition]
} RdmaDeviceResources;
^
From: Yuval Shaia
Utilize error_report for all pr_err calls and some pr_dbg that are
considered as errors.
For the remaining pr_dbg calls, the important ones were replaced by
trace points while other deleted.
Signed-off-by: Yuval Shaia
Reviewed-by: Marcel Apfelbaum
Message-Id:
From: Yuval Shaia
Allow interrogating device internals through HMP interface.
The exposed indicators can be used for troubleshooting by developers or
sysadmin.
There is no need to expose these attributes to a management system (e.x.
libvirt) because (1) most of them are not "device-management'
From: Yuval Shaia
The function rdma_poll_cq is called from two contexts - completion
handler thread which sense new completion on backend channel and
explicitly as result of guest issuing poll_cq command.
Add lock to protect against concurrent executions.
Signed-off-by: Yuval Shaia
From: Yuval Shaia
The function argument rdma_dev_res is not needed as it is stored in the
backend_dev object at init.
Signed-off-by: Yuval Shaia
Reviewed-by: Marcel Apfelbaum
Message-Id: <20190213065357.16076-9-yuval.sh...@oracle.com>
Signed-off-by: Marcel Apfelbaum
---
From: Yuval Shaia
When QP is destroyed the backend QP is destroyed as well. This ensures
we clean all received buffer we posted to it.
However, a contexts of these buffers are still remain in the device.
Fix it by maintaining a list of buffer's context and free them when QP
is destroyed.
From: Yuval Shaia
The function get_fd extract context from the received MAD message and
uses it as a key to fetch the destination fd from the mapping table.
A context can be dgid in case of CM request message or comm_id in case
of CM SIDR response message.
When MAD message with a smaller size
From: Yuval Shaia
When device is going down free all saved MAD buffers.
Signed-off-by: Yuval Shaia
Reviewed-by: Marcel Apfelbaum
Message-Id: <20190213065357.16076-7-yuval.sh...@oracle.com>
Signed-off-by: Marcel Apfelbaum
---
hw/rdma/rdma_backend.c| 34 +-
From: Yuval Shaia
To make code more readable move handling of protected list to a
rdma_utils
Signed-off-by: Yuval Shaia
Message-Id: <20190213065357.16076-4-yuval.sh...@oracle.com>
Reviewed-by: Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum
---
hw/rdma/rdma_backend.c | 20
From: Yuval Shaia
This hook is not called and was implemented by mistake.
Signed-off-by: Yuval Shaia
Reviewed-by: Marcel Apfelbaum
Message-Id: <20190213065357.16076-10-yuval.sh...@oracle.com>
Signed-off-by: Marcel Apfelbaum
---
hw/rdma/vmw/pvrdma_main.c | 6 --
1 file changed, 6
The following changes since commit 8eb29f1bf5a974dc4c11d2d1f5e7c7f7a62be116:
Merge remote-tracking branch 'remotes/awilliam/tags/vfio-updates-20190221.0'
into staging (2019-02-22 15:48:04 +)
are available in the Git repository at:
https://github.com/marcel-apf/qemu
On Fri, 22 Feb 2019 at 22:54, Michael S. Tsirkin wrote:
>
> On Fri, Feb 22, 2019 at 03:05:23PM +0800, Yongji Xie wrote:
> > On Fri, 22 Feb 2019 at 14:21, Michael S. Tsirkin wrote:
> > >
> > > On Fri, Feb 22, 2019 at 10:47:03AM +0800, Yongji Xie wrote:
> > > > > > +
> > > > > > +To track inflight
On Fri, 22 Feb 2019 at 21:48, Roman Bolshakov wrote:
>
> On Fri, Feb 22, 2019 at 03:41:05PM +, Peter Maydell wrote:
> > On Fri, 22 Feb 2019 at 15:19, Roman Bolshakov wrote:
> > >
> > > On Thu, Feb 14, 2019 at 10:28:10AM +, Peter Maydell wrote:
> > > > The Cocoa UI should run on the main
On Fri, 22 Feb 2019 14:04:20 +
Stefan Hajnoczi wrote:
> On Fri, Feb 22, 2019 at 12:57 PM Fernando Casas Schössow
> wrote:
>
> I have CCed Natanael Copa, qemu package maintainer in Alpine Linux.
Hi!
...
> Richard: Commit 7db2145a6826b14efceb8dd64bfe6ad8647072eb ("bswap: Add
> host endian
On 2/15/19 1:15 PM, Thomas Huth wrote:
> On 14/02/2019 21.35, Paolo Bonzini wrote:
>> On 14/02/19 20:17, Peter Maydell wrote:
>>> On Wed, 13 Feb 2019 at 08:38, Thomas Huth wrote:
Add Kconfig dependencies for the highbank machine (and the midway
machine).
This patch is slightly
update copyright notice to reflect my full legal name. looks better to
me that way.
also, that way people are not under the impression i *own* qemu AMD
IOMMU.
thanks.
David Kiarie (1):
hw/i386: update copyright notice
hw/i386/amd_iommu.c | 2 +-
hw/i386/amd_iommu.h | 2 +-
2 files changed,
Signed-off-by: David Kiarie
---
hw/i386/amd_iommu.c | 2 +-
hw/i386/amd_iommu.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
index 8ad707a..4f179da 100644
--- a/hw/i386/amd_iommu.c
+++ b/hw/i386/amd_iommu.c
@@ -2,7 +2,7 @@
*
Richard Henderson writes:
> On 2/22/19 12:45 PM, Alex Bennée wrote:
>> @@ -3526,6 +3551,8 @@ static float32 roundAndPackFloat32(flag zSign, int
>> zExp, uint32_t zSig,
>> case float_round_down:
>> roundIncrement = zSign ? 0x7f : 0;
>> break;
>> +case
Richard Henderson writes:
> On 2/22/19 12:45 PM, Alex Bennée wrote:
>> @@ -3526,6 +3551,8 @@ static float32 roundAndPackFloat32(flag zSign, int
>> zExp, uint32_t zSig,
>> case float_round_down:
>> roundIncrement = zSign ? 0x7f : 0;
>> break;
>> +case
Richard Henderson writes:
> On 2/22/19 12:44 PM, Alex Bennée wrote:
>> Needed to test: softfloat: add float128_is_{normal,denormal}
Obviously I was reading the title of the other patch.. will fix.
>
> Eh?
>
>>
>> Signed-off-by: Alex Bennée
>> ---
>> tests/fp/fp-test.c | 3 ++-
>>
22.02.2019 14:26, Andrey Shinkevich wrote:
> The data type for bytes in Python3 differs from the one in Python2.
> Those cases should be managed separately.
>
> v1:
> In the first version, the TypeError in Python3 was handled as the
> exception.
> Discussed in the e-mail thread with the Message
The PCI devices should be pulled in by default if PCI_DEVICES
is set, so there is no need anymore to enforce them in the configs
file.
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 8
1 file changed, 8 deletions(-)
diff --git a/default-configs/arm-softmmu.mak
Add Kconfig dependencies for the NRF51 / microbit machine.
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 3 +--
hw/arm/Kconfig | 6 ++
hw/arm/Makefile.objs| 3 ++-
3 files changed, 9 insertions(+), 3 deletions(-)
diff --git
This cleans up most settings in default-configs/aarch64-softmmu.mak.
Signed-off-by: Thomas Huth
---
default-configs/aarch64-softmmu.mak | 4
hw/arm/Kconfig | 11 +++
hw/display/Kconfig | 1 +
3 files changed, 12 insertions(+), 4 deletions(-)
Dependencies have been determined with trial-and-error and by
looking at the xlnx-versal.c source file.
Signed-off-by: Thomas Huth
---
hw/arm/Kconfig | 4
1 file changed, 4 insertions(+)
diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 744b5ff..06e9e9a 100644
--- a/hw/arm/Kconfig
+++
Add Kconfig dependencies for the emcraft-sf2 machine - we also
distinguish between the machine (CONFIG_EMCRAFT_SF2) and the SoC
(CONFIG_MSF2) now.
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 3 +--
hw/arm/Kconfig | 12 ++--
hw/arm/Makefile.objs
Dependencies have been determined with trial-and-error and by
looking at the musca.c source file.
Signed-off-by: Thomas Huth
---
hw/arm/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 06e9e9a..8105587 100644
--- a/hw/arm/Kconfig
+++
Most of the code is directly controlled by the CONFIG_RASPI switch,
so not much to add here additionally.
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 4 +---
hw/arm/Kconfig | 3 +++
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git
Add dependencies for the Cubitech Cubieboard.
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 6 +-
hw/arm/Kconfig | 9 +
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/default-configs/arm-softmmu.mak
IMX25, IMX7 and IMX6UL were still missing the Kconfig dependencies.
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 2 --
hw/arm/Kconfig | 18 ++
2 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/default-configs/arm-softmmu.mak
Netduino only depends on the stm32f205 SoC which in turn depends on
its components.
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 9 +
hw/arm/Kconfig | 7 +++
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git
Dependencies have been determined by looking at hw/arm/aspeed.c
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 7 +--
hw/arm/Kconfig | 10 ++
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/default-configs/arm-softmmu.mak
Add Kconfig dependencies for the DIGIC / canon-a1100 machine.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 2 +-
hw/arm/Kconfig | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git
Add Kconfig dependencies for the Sabrelite / iMX6 machine.
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 4 +---
hw/arm/Kconfig | 7 +++
hw/arm/Makefile.objs| 3 ++-
3 files changed, 10 insertions(+), 4 deletions(-)
diff --git
Add Kconfig dependencies for the xilinx-zynq-a9 board.
This patch is based on earlier work by Ákos Kovács (i.e.
his "hw/arm/Kconfig: Add ARM Kconfig" patch).
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 7 +--
hw/arm/Kconfig | 14 ++
2 files
This patch is slightly based on earlier work by Ákos Kovács (i.e.
his "hw/arm/Kconfig: Add ARM Kconfig" patch).
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 21 +++---
hw/arm/Kconfig | 47 +
Dependencies have been determined by looking at hw/arm/virt.c
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 14 +-
hw/arm/Kconfig | 19 +++
hw/arm/Makefile.objs| 3 ++-
3 files changed, 22 insertions(+), 14
This patch is slightly based on earlier work by Ákos Kovács (i.e.
his "hw/arm/Kconfig: Add ARM Kconfig" patch).
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 7 +--
hw/arm/Kconfig | 10 ++
2 files changed, 11 insertions(+), 6 deletions(-)
diff
Add Kconfig dependencies for the mps2-an* machines.
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 19 +--
hw/arm/Kconfig | 17 +
2 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/default-configs/arm-softmmu.mak
Some machines have an SDHCI device, but no PCI. To be able to
compile hw/sd/sdhci.c without CONFIG_PCI, we must not call functions
like pci_get_address_space() and pci_allocate_irq() there. Thus
move the PCI-related code into a separate file.
This is required for the new Kconfig-like build
77 matches
Mail list logo
