[Qemu-devel] [PULL 45/57] qos-test: ac97 test node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/ac97-test to a driver node; currently it runs the PCI nop test only, therefore we're not placing it in tests/libqos. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 3 +-- tests/ac97-test.c

Re: [Qemu-devel] [RFC PATCH v6 2/4] hw/block: Pad undersized read-only images with 0xFF

2019-03-07 Thread Eric Blake
On 3/7/19 8:55 AM, Kevin Wolf wrote: >> 0ff0: 79 0a 79 0a 79 0a 79 0a 79 0a 00 00 00 00 00 00 >> y.y.y.y.y... >> read 96/96 bytes at offset 4000 >> 96 bytes, 1 ops; 0.0001 sec (694.444 KiB/sec and 7407.4074 ops/sec) >> >>This patch then pads some more with 0xFF to the

[Qemu-devel] [PATCH v2 0/2] target/mips: Minor cleanups in test infrastructure

2019-03-07 Thread Aleksandar Markovic
From: Aleksandar Markovic This series contains some minor cleanups in MIPS-specific test infrastructure, done mostly for consistency and clarity. v1->v2: - few more details cleaned-up Aleksandar Markovic (2): tests/tcg: target/mips: Correct preambles of test source files tests/tcg:

[Qemu-devel] [PULL 50/57] qos-test: pcnet test node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/pcnet-test to a driver node; currently it runs the PCI nop test only, therefore we're not placing it in tests/libqos. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 3 +-- tests/pcnet-test.c

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-07 Thread Alex Williamson
Hi Yan, Sorry for the delay, I've been on PTO... On Sun, 24 Feb 2019 21:22:56 -0500 Zhao Yan wrote: > On Thu, Feb 21, 2019 at 01:40:51PM -0700, Alex Williamson wrote: > > Hi Yan, > > > > Thanks for working on this! > > > > On Tue, 19 Feb 2019 16:50:54 +0800 > > Yan Zhao wrote: > > > > >

[Qemu-devel] [PULL 46/57] qos-test: tpci200 test node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/tpci200-test to a driver node; currently it runs the PCI nop test only, but it also produces the ipack interface. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 3 +-- tests/libqos/tpci200.c

[Qemu-devel] [PULL 35/57] qos-test: virtio-blk test node

2019-03-07 Thread Paolo Bonzini
Convert tests/virtio-blk-test in qgraph test node, virtio-blk-test. This test consumes a virtio-blk interface and checks that its function return the expected values. Some functions are implemented only for virtio-blk-pci, so they don't consume virtio-blk, but virtio-blk-pci Note that this test

Re: [Qemu-devel] [PATCH v2 07/12] vl: Create block backends before setting machine properties

2019-03-07 Thread Philippe Mathieu-Daudé
On 3/7/19 6:23 PM, Markus Armbruster wrote: > qemu-system-FOO's main() acts on command line arguments in its own > idiosyncratic order. There's not much method to its madness. > Whenever we find a case where one kind of command line argument needs > to refer to something created for another kind

Re: [Qemu-devel] [PATCH v2 00/12] pc: Support firmware configuration with -blockdev

2019-03-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190307172401.29451-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190307172401.29451-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/12] pc: Support

[Qemu-devel] [PULL 41/57] tests/libqos: virtio-scsi driver and interface nodes

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add qgraph nodes for virtio-scsi-pci and virtio-scsi-device. Both nodes produce virtio-scsi, but virtio-scsi-pci receives a pci-bus and uses virtio-pci QOSGraphObject and its functions, while virtio-scsi-device receives a virtio and implements its own functions

[Qemu-devel] [PULL 37/57] qos-test: virtio-net test node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/virtio-net-test in qgraph test node, virtio-net-test. This test consumes a virtio-net interface and checks that its function return the expected values. Some functions are implemented only for virtio-net-pci, so they don't consume virtio-net, but

Re: [Qemu-devel] [PATCH] qcow2 spec: Describe string header extensions

2019-03-07 Thread Eric Blake
On 3/7/19 10:53 AM, Kevin Wolf wrote: > Be more specific about the string representation in header extensions. > > Suggested-by: Stefan Hajnoczi > Signed-off-by: Kevin Wolf > --- > docs/interop/qcow2.txt | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > Based-on:

Re: [Qemu-devel] [PATCH v2 11/12] pc: Support firmware configuration with -blockdev

2019-03-07 Thread Philippe Mathieu-Daudé
On 3/7/19 6:24 PM, Markus Armbruster wrote: > The PC machines put firmware in ROM by default. To get it put into > flash memory (required by OVMF), you have to use -drive > if=pflash,unit=0,... and optionally -drive if=pflash,unit=1,... > > Why two -drive? This permits setting up one part of

[Qemu-devel] [PULL 36/57] tests/libqos: virtio-net driver and interface nodes

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add qgraph nodes for virtio-net-pci and virtio-net-device. Both nodes produce virtio-net, but virtio-net-pci receives a pci-bus and overrides virtio-pci QOSGraphObject and its functions, while virtio-net-device receives a virtio and implements its own functions

[Qemu-devel] [PULL 29/57] qos-test: virtio-9p test node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/virtio-9p-test into a qgraph test node. This test consumes a virtio-9p interface and checks that its functions return the expected values. Note that this test does not allocate any virtio-9p structure, it's all done by the qtest walking graph

[Qemu-devel] [PULL 56/57] qos-test: e1000 test node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/e1000-test to a driver node; currently it runs the PCI nop test only, therefore we're not placing it in tests/libqos. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 3 +-- tests/e1000-test.c

[Qemu-devel] [PULL 34/57] tests/libqos: virtio-blk driver and interface nodes

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add qgraph nodes for virtio-blk-pci and virtio-blk-device. Both nodes produce virtio-blk, but virtio-blk-pci receives a pci-bus and uses virtio-pci QOSGraphObject and functions, while virtio-blk-device receives a virtio and implements its own functions

Re: [Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU

2019-03-07 Thread Aleksandar Markovic
> From: Alex Bennée > Subject: Re: [PATCH] target/mips: Fix minor bug in FPU > > Mateja Marjanovic writes: > > > From: Mateja Marjanovic > > > > Wrong type of NaN was generated by maddf and msubf insturctions > > when the arguments were inf, zero, nan or zero, inf, nan > > respectively. > > >

[Qemu-devel] [PULL 27/57] qos-test: virtio-console and virtio-serial test node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/virtio-console-test and tests/virtio-serial-test in qgraph test node. This test consumes a virtio-serial interface and checks that its function return the expected values. Note that this test does not allocate any virtio-console or virtio-serial

[Qemu-devel] [PULL 55/57] qos-test: eepro100 test node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/eepro100-test to a driver node; currently it runs the PCI nop test only, therefore we're not placing it in tests/libqos. For now, all nodes share the same constructor and destructor. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo

[Qemu-devel] [PULL 33/57] qos-test: virtio-rng test node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/virtio-rng-test in qgraph test node, virtio-rng-test. This test consumes a virtio-rng interface and checks that its function return the expected values. Some functions are implemented only for virtio-rng-pci, so they don't consume virtio-rng, but

[Qemu-devel] [PULL 44/57] tests: move virtio entirely to qos-test

2019-03-07 Thread Paolo Bonzini
The only remaining test that needs libqos-virtio-obj-y is drive_del-test, which really only needs a function. Move that function to the test and remove libqos-virtio-obj-y. Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 9 - tests/drive_del-test.c | 25

[Qemu-devel] [PULL 23/57] tests/libqos: virtio-mmio driver and interface nodes

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add virtio-mmio node in qgraph framework. virtio-mmio produces virtio-bus, the interface consumed by all virtio-*-device nodes. Being a memory-mapped device, it doesn't have to provide a constructor to qgraph, since it's always "contained" inside some other

[Qemu-devel] [PULL 53/57] qos-test: vmxnet3 test node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/vmxnet3-test to a driver node; currently it runs the PCI nop test only, therefore we're not placing it in tests/libqos. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 3 +--

[Qemu-devel] [PULL 30/57] tests/libqos: virtio-balloon driver and interface nodes

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add qgraph nodes for virtio-balloon-pci and virtio-balloon-device. Both nodes produce virtio-balloon, but virtio-balloon-pci receives a pci-bus and uses virtio-pci QOSGraphObject and functions, while virtio-balloon-device receives a virtio and implements its own

[Qemu-devel] [PULL 40/57] qos-test: vhost-user test node

2019-03-07 Thread Paolo Bonzini
Convert tests/virtio-net-test in qgraph test node, virtio-net-test. This test consumes a virtio-net interface and checks that its function return the expected values. Note that this test does not allocate any virtio-net structure, it's all done by the qtest walking graph mechanism. Nevertheless,

[Qemu-devel] [PULL 19/57] tests/libqos: e1000e driver and interface nodes

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add qgraph nodes for virtio-e1000e. It consumes a pci-bus, and it's directly used by tests (e1000e is pci based). Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 1 + tests/libqos/e1000e.c | 260

[Qemu-devel] [PULL 24/57] tests/libqos: arm/virt machine node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add arm/virt machine to the graph. This machine contains virtio-mmio, so its constructor must take care of setting it properly when called. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 1 +

[Qemu-devel] [PULL 49/57] qos-test: nvme test node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/nvme-test to a driver node; the code to discover the PCI device is replaced by generic qgraph code, therefore we're not placing it in tests/libqos. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PULL 38/57] tests/libqos: support multiqueue for virtio-net

2019-03-07 Thread Paolo Bonzini
Initialize the additional virtqueues if they are supported. This is needed to switch vhost-user-test's multiqueue test to the virtio-net qgraph. Signed-off-by: Paolo Bonzini --- tests/libqos/virtio-net.c | 21 + tests/libqos/virtio-net.h | 4 ++-- tests/virtio-net-test.c

[Qemu-devel] [PULL 18/57] tests/libqos: has_buggy_msi flag

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito The Qgraph framework makes any test using pci bus run the same function using pci-pci and pci-spapr bus. However, some tests are not ready to use the spapr bus, due to a MSI bug. Until it does not get fixed, this flag allows them to skip the test Signed-off-by:

[Qemu-devel] [PULL 20/57] qos-test: e1000e test node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/e1000e-test in qgraph test node, e1000e-test. This test consumes an e1000e interface and checks that its function return the expected values. Note that this test does not allocate any e1000e structure, it's all done by the qtest walking graph

[Qemu-devel] [PULL 48/57] qos-test: ne2k_pci test node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/ne2000-test to a driver node; currently it runs the PCI nop test only, therefore we're not placing it in tests/libqos. The actual device consumed by the test is ne2k_pci. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PULL 31/57] tests/qgraph: remove virtio-balloon-test

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito The tests/virtio-balloon-test is covered by generic virtio tests, so remove it. Signed-off-by: Paolo Bonzini Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 3 --- tests/virtio-balloon-test.c | 33 -

[Qemu-devel] [PULL 16/57] tests/libqos: pci-spapr driver and interface nodes

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add pci-bus-spapr node, that produces pci-bus. Move QPCIBusSPAPR struct declaration in its header (since it will be needed by other drivers) and introduce a setter method for drivers that do not need to allocate but have to initialize QPCIBusSPAPR.

[Qemu-devel] [PULL 43/57] tests/libqos: remove pre-qgraph QVirtioPCIDevice API

2019-03-07 Thread Paolo Bonzini
Remove the qvirtio_pci_device_find* and qvirtio_pci_device_free APIs, now that they do not have any users. Signed-off-by: Paolo Bonzini --- tests/libqos/virtio-pci.c | 112 +++--- tests/libqos/virtio-pci.h | 4 -- 2 files changed, 17 insertions(+), 99

[Qemu-devel] [PULL 05/57] tests: qgraph API for the qtest driver framework

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add qgraph API that allows to add/remove nodes and edges from the graph, implementation of Depth First Search to discover the paths and basic unit test to check correctness of the API. Included also a main executable that takes care of starting the framework,

[Qemu-devel] [PULL 13/57] tests/libqos: aarch64/xlnx-zcu102 machine node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add xlnx-zcu102 machine to the graph. This machine contains generic-sdhci, so its constructor must take care of setting it properly when called. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include

[Qemu-devel] [PULL 28/57] tests/libqos: virtio-9p driver and interface nodes

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add qgraph nodes for virtio-9p-pci and virtio-9p-device. Both nodes produce virtio-9p, but virtio-9p-pci receives a pci-bus and overrides virtio-pci QOSGraphObject and its functions, while virtio-9p-device receives a virtio and implements its own functions

[Qemu-devel] [PULL 42/57] qos-test: virtio-scsi test node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/virtio-scsi-test in qgraph test node, virtio-scsi-test. This test consumes a virtio-scsi interface and checks that its function return the expected values. Some functions are implemented only for virtio-scsi-pci, so they don't consume virtio-scsi,

[Qemu-devel] [PULL 14/57] qos-test: sdhci test node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/sdhci-test in first qgraph test node, sdhci-test. This test consumes an sdhci interface and checks that its function return the expected values. Note that this test does not allocate any sdhci structure, it's all done by the qtest walking graph

[Qemu-devel] [PULL 09/57] tests/libqos: arm/raspi2 machine node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add arm/raspi2 machine to the graph. This machine contains a generic-sdhci, so its constructor must take care of setting it properly when called. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include| 1

[Qemu-devel] [PULL 26/57] tests/libqos: virtio-serial driver and interface nodes

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add qgraph nodes for virtio-serial-pci and virtio-serial-device. Both nodes produce virtio-serial, but virtio-serial-pci receives a pci-bus and uses virtio-pci QOSGraphObject and functions, while virtio-serial-device receives a virtio-bus and implements its own

[Qemu-devel] [PULL 39/57] vhost-user-test: always use 256 MiB of guest memory

2019-03-07 Thread Paolo Bonzini
Some tests are using a small amount of RAM for the guest (2 MiB) in order to save host memory, others are using 512 MiB. However, pSeries machines only support multiples of 256 MiB. Using 256 MiB of memory does not use more host memory than now, even for the migration test that starts two

[Qemu-devel] [PULL 15/57] tests/qgraph: add generic PCI testcases

2019-03-07 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 1 + tests/pci-test.c | 25 + 2 files changed, 26 insertions(+) create mode 100644 tests/pci-test.c diff --git a/tests/Makefile.include b/tests/Makefile.include index 4b545ac..4391b7f 100644 ---

[Qemu-devel] [PULL 08/57] tests/libqos: sdhci driver and interface nodes

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add qgraph nodes for sdhci-pci and generic-sdhci (memory mapped) drivers. Both drivers implement (produce) the same interface sdhci, that provides the readw - readq - writeq functions. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PULL 22/57] tests/libqos: remove global_qtest from virtio endianness checks

2019-03-07 Thread Paolo Bonzini
This is needed to support migration tests with qgraph. Signed-off-by: Paolo Bonzini --- tests/libqos/virtio-pci.c | 11 ++- tests/libqos/virtio.c | 5 + tests/libqos/virtio.h | 8 ++-- 3 files changed, 17 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PULL 32/57] tests/libqos: virtio-rng driver and interface nodes

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add qgraph nodes for virtio-rng-pci and virtio-rng-device. Both nodes produce virtio-rng, but virtio-rng-pci receives a pci-bus and uses virtio-pci QOSGraphObject and functions, while virtio-rng-device receives a virtio and implements its own functions

[Qemu-devel] [PULL 12/57] tests/libqos: arm/xilinx-zynq-a9 machine node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add xilinx-zynq-a9 machine to the graph. This machine contains generic-sdhci, so its constructor must take care of setting it properly when called. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include

[Qemu-devel] [PULL 21/57] tests/libqos: virtio-pci driver and interface nodes

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add QOSGraphObject to QVirtioPCIDevice structure, with a basic constructor. virtio-pci is not present in qgraph, since it will be used as starting point by its subclasses (virtio-*-pci) Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PULL 03/57] tests/libqos: rename qpci_init_pc and qpci_init_spapr functions

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Rename qpci_init_pc in qpci_pc_new and qpci_init_spapr in qpci_spapr_new, since these function actually allocate a new pci struct and initialize it (compare to object_new and object_initialize). Changed QOSOps field name from qpci_init to qpci_new.

[Qemu-devel] [PULL 25/57] tests/qgraph: add generic virtio testcases

2019-03-07 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 1 + tests/virtio-test.c| 25 + 2 files changed, 26 insertions(+) create mode 100644 tests/virtio-test.c diff --git a/tests/Makefile.include b/tests/Makefile.include index 4a9e2e4..ec929cc 100644 ---

[Qemu-devel] [PULL 07/57] tests/libqos: x86_64/pc machine node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add pc machine for the x86_64 QEMU binary. This machine contains an i440FX-pcihost driver, that contains itself a pci-bus-pc that produces the pci-bus interface. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PULL 02/57] tests/libqos: introduce virtio_start_device

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito This function is intended to group all the qvirtio_* functions that start the qvirtio devices. Applied in all tests using this combination of functions. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Laurent Vivier Reviewed-by: Thomas Huth

[Qemu-devel] [PULL 10/57] tests/libqos: arm/smdkc210 machine node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add arm/smdkc210 machine machine to the graph. This machine contains generic-sdhci, so its constructor must take care of setting it properly when called. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include

[Qemu-devel] [PULL 17/57] tests/qgraph: ppc64/pseries machine node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add pseries machine for the ppc64 QEMU binary. This machine contains a spapr-pci-host-bridge driver, that contains itself a pci-bus-spapr that produces the pci-bus interface. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PULL 06/57] tests/libqos: pci-pc driver and interface nodes

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add pci-bus-pc node, move QPCIBusPC struct declaration in its header (since it will be needed by other drivers) and introduce a setter method for drivers that do not need to allocate but have to initialize QPCIBusPC. Signed-off-by: Emanuele Giuseppe Esposito

[Qemu-devel] [PATCH v2 08/12] pflash_cfi01: Add pflash_cfi01_get_blk() helper

2019-03-07 Thread Markus Armbruster
From: Philippe Mathieu-Daudé Add an helper to access the opaque struct PFlashCFI01. Signed-off-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Laszlo Ersek --- hw/block/pflash_cfi01.c | 5 + include/hw/block/flash.h | 1 + 2 files changed, 6 insertions(+) diff

[Qemu-devel] [PULL 04/57] tests/libqos: embed allocators instead of malloc-ing them separately

2019-03-07 Thread Paolo Bonzini
qgraph will embed these objects instead of allocating them in a separate object. Expose a new API "generic_alloc_init" and "generic_alloc_destroy" for that, and rename the existing API with s/init/new/ and s/uninit/free/. Signed-off-by: Paolo Bonzini --- tests/ahci-test.c | 6 ++--

[Qemu-devel] [PULL 11/57] tests/libqos: arm/sabrelite machine node

2019-03-07 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add arm/sabrelite machine to the graph. This machine contains generic-sdhci, so its constructor must take care of setting it properly when called. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include

[Qemu-devel] [PULL 00/57] qgraph merge

2019-03-07 Thread Paolo Bonzini
The following changes since commit 3a75ef6a0fe397b0d36930415be6b123750a6afe: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20190307-pull-request' into staging (2019-03-07 14:06:42 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream

[Qemu-devel] [PATCH v2 11/12] pc: Support firmware configuration with -blockdev

2019-03-07 Thread Markus Armbruster
The PC machines put firmware in ROM by default. To get it put into flash memory (required by OVMF), you have to use -drive if=pflash,unit=0,... and optionally -drive if=pflash,unit=1,... Why two -drive? This permits setting up one part of the flash memory read-only, and the other part

[Qemu-devel] [PULL 01/57] chardev-socket: do not blindly reset handlers when switching GMainContext

2019-03-07 Thread Paolo Bonzini
If the socket is connecting or connected, tcp_chr_update_read_handler will be called but it should not set the NetListener's callbacks again. Otherwise, tcp_chr_accept is invoked while the socket is in connected state and you get an assertion failure. Reviewed-by: Daniel P. Berrangé Reviewed-by:

Re: [Qemu-devel] [PATCH v2] machine: Move acpi_nvdimm_state into struct MachineState

2019-03-07 Thread Eduardo Habkost
On Thu, Mar 07, 2019 at 10:06:39AM +0100, Eric Auger wrote: > As NVDIMM support is looming for ARM and SPAPR, let's > move the acpi_nvdimm_state to the generic machine struct > instead of duplicating the same code in several machines. > It is also renamed into nvdimms_state. > > nvdimm and

[Qemu-devel] [PATCH v2 05/12] vl: Improve legibility of BlockdevOptions queue

2019-03-07 Thread Markus Armbruster
Give the queue head type a name: BlockdevOptionsQueue. Rename the queue entry type from BlockdevOptions_queue to BlockdevOptionsQueueEntry. Signed-off-by: Markus Armbruster # Conflicts: # vl.c --- vl.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff

[Qemu-devel] [PATCH v2 02/12] qom: Move compat_props machinery from qdev to QOM

2019-03-07 Thread Markus Armbruster
See the previous commit for rationale. Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- hw/core/qdev.c | 39 --- include/hw/qdev-core.h | 4 include/qom/object.h | 3 +++ qom/object.c

[Qemu-devel] [PATCH v2 07/12] vl: Create block backends before setting machine properties

2019-03-07 Thread Markus Armbruster
qemu-system-FOO's main() acts on command line arguments in its own idiosyncratic order. There's not much method to its madness. Whenever we find a case where one kind of command line argument needs to refer to something created for another kind later, we rejigger the order. Block devices get

[Qemu-devel] [PATCH v2 09/12] pc_sysfw: Remove unused PcSysFwDevice

2019-03-07 Thread Markus Armbruster
From: Philippe Mathieu-Daudé This structure is not used since commit 6dd2a5c98a. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Laszlo Ersek Signed-off-by: Markus Armbruster --- hw/i386/pc_sysfw.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/i386/pc_sysfw.c

[Qemu-devel] [PATCH v2 12/12] docs/interop/firmware.json: Prefer -machine to if=pflash

2019-03-07 Thread Markus Armbruster
The previous commit added a way to configure firmware with -blockdev rather than -drive if=pflash. Document it as the preferred way. Signed-off-by: Markus Armbruster --- docs/interop/firmware.json | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH v2 04/12] sysbus: Fix latent bug with onboard devices

2019-03-07 Thread Markus Armbruster
The first call of sysbus_get_default() creates the main system bus and stores it in QOM as "/machine/unattached/sysbus". This must not happen before main() creates "/machine", or else container_get() would "helpfully" create it as "container" object, and the real creation of "/machine" would

[Qemu-devel] [PATCH v2 00/12] pc: Support firmware configuration with -blockdev

2019-03-07 Thread Markus Armbruster
Based-on: <20190307130323.9353-1-arm...@redhat.com> v2: * PATCH 05,06: New [Philippe] * PATCH 07: Old PATCH 5 rebased onto new patches, with new comment [Philippe] * PATCH 08+10: New, factored out of old PATCH 6 [by Philippe] * PATCH 09: New [by Philippe] * PATCH 11: Remainder of old PATCH 6,

[Qemu-devel] [PATCH v2 10/12] pc_sysfw: Pass PCMachineState to pc_system_firmware_init()

2019-03-07 Thread Markus Armbruster
From: Philippe Mathieu-Daudé pc_system_firmware_init() parameter @isapc_ram_fw is PCMachineState member pci_enabled negated. The next commit will need more of PCMachineState. To prepare for that, pass a PCMachineState *, and drop the now redundant parameter @isapc_ram_fw. Signed-off-by:

Re: [Qemu-devel] [PATCH] mirror: Confirm we're quiesced only if the job is paused or cancelled

2019-03-07 Thread Eric Blake
On 3/7/19 8:03 AM, Sergio Lopez wrote: > While child_job_drained_begin() calls to job_pause(), the job doesn't > actually transition between states until it runs again and reaches a > pause point. This means bdrv_drained_begin() may return with some jobs > using the node still having 'busy ==

[Qemu-devel] [PATCH v4 10/22] target/arm: Define arm_cpu_do_unaligned_access for CONFIG_USER_ONLY

2019-03-07 Thread Richard Henderson
We will need this to raise unaligned exceptions from user mode. Signed-off-by: Richard Henderson --- target/arm/op_helper.c | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/target/arm/op_helper.c b/target/arm/op_helper.c index

Re: [Qemu-devel] [RFC PATCH v6 1/4] hw/block: better reporting on pflash backing file mismatch

2019-03-07 Thread Markus Armbruster
Alex Bennée writes: > Markus Armbruster writes: > >> From: Alex Bennée >> >> It looks like there was going to be code to check we had some sort of >> alignment so let's replace it with an actual check. Reject undersized >> images with "device needs N bytes, backing file provides only M >>

[Qemu-devel] [PATCH v2 06/12] vl: Factor configure_blockdev() out of main()

2019-03-07 Thread Markus Armbruster
Signed-off-by: Markus Armbruster # Conflicts: # vl.c --- vl.c | 71 +--- 1 file changed, 39 insertions(+), 32 deletions(-) diff --git a/vl.c b/vl.c index 00cb8ea7ca..5a19d2a8ec 100644 --- a/vl.c +++ b/vl.c @@ -1201,6 +1201,44 @@

[Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU

2019-03-07 Thread Mateja Marjanovic
From: Mateja Marjanovic Wrong type of NaN was generated by maddf and msubf insturctions when the arguments were inf, zero, nan or zero, inf, nan respectively. Mateja Marjanovic (1): target/mips: Fix minor bug in FPU fpu/softfloat-specialize.h | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PATCH v4 13/22] target/arm: Implement the LDGM and STGM instructions

2019-03-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- v3: Require pre-cleaned addresses. --- target/arm/helper-a64.h| 3 ++ target/arm/mte_helper.c| 96 ++ target/arm/translate-a64.c | 42 + 3 files changed, 132 insertions(+), 9 deletions(-) diff

[Qemu-devel] [PATCH v2 03/12] vl: Fix latent bug with -global and onboard devices

2019-03-07 Thread Markus Armbruster
main() registers the user's -global only after we create the machine object, i.e. too late for devices created in the machine's .instance_init(). Fortunately, we know the bug is only latent: the commit before previous fixed a bug that would've crashed any attempt to create a device in an

[Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU

2019-03-07 Thread Mateja Marjanovic
From: Mateja Marjanovic Wrong type of NaN was generated by maddf and msubf insturctions when the arguments were inf, zero, nan or zero, inf, nan respectively. Signed-off-by: Mateja Marjanovic --- fpu/softfloat-specialize.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v4 15/22] target/arm: Clean address for DC ZVA

2019-03-07 Thread Richard Henderson
This data access was forgotten in the previous patch. Fixes: 3a471103ac1823ba Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index e02d85f317..a02c829db2

[Qemu-devel] [PATCH v4 11/22] target/arm: Implement LDG, STG, ST2G instructions

2019-03-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- v2: Split out allocation_tag_mem. Handle atomicity of stores. v3: Add X[t] input to these insns; require pre-cleaned addresses. --- target/arm/helper-a64.h| 5 ++ target/arm/mte_helper.c| 151 +

[Qemu-devel] [PATCH v2 01/12] qdev: Fix latent bug with compat_props and onboard devices

2019-03-07 Thread Markus Armbruster
Compatibility properties started life as a qdev property thing: we supported them only for qdev properties, and implemented them with the machinery backing command line option -global. Recent commit fa0cb34d221 put them to use (tacitly) with memory backend objects (subtypes of

Re: [Qemu-devel] [PATCH 0/2] target/mips: Minor cleanups in test infrastructure

2019-03-07 Thread Aleksandar Rikalo
> From: Aleksandar Markovic > > This series contains some minor cleanups in MIPS-specific test > infrastructure, done mostly for consistency and clarity. > > Aleksandar Markovic (2): > tests/tcg: target/mips: Correct preambles of test source files > tests/tcg: target/mips: Rename two header

[Qemu-devel] [PATCH v4 18/22] target/arm: Cache the Tagged bit for a page in MemTxAttrs

2019-03-07 Thread Richard Henderson
This "bit" is a particular value of the page's MemAttr. Signed-off-by: Richard Henderson --- target/arm/helper.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index a529d30700..fcab7f99be 100644 ---

[Qemu-devel] [PATCH v4 06/22] target/arm: Implement the IRG instruction

2019-03-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- v2: Update to 00eac5. Merge choose_random_nonexcluded_tag into helper_irg since that pseudo function no longer exists separately. --- target/arm/helper-a64.h| 1 + target/arm/mte_helper.c| 57 ++

[Qemu-devel] [PATCH v4 16/22] target/arm: Implement data cache set allocation tags

2019-03-07 Thread Richard Henderson
This is DC GVA and DC GZVA. Signed-off-by: Richard Henderson --- v2: Use allocation_tag_mem + memset. v3: Require pre-cleaned addresses. --- target/arm/cpu.h | 4 +++- target/arm/helper-a64.h| 1 + target/arm/helper.c| 16 target/arm/mte_helper.c| 28

[Qemu-devel] [PATCH v4 08/22] target/arm: Implement the GMI instruction

2019-03-07 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper-a64.h| 1 + target/arm/mte_helper.c| 6 ++ target/arm/translate-a64.c | 6 ++ 3 files changed, 13 insertions(+) diff --git a/target/arm/helper-a64.h b/target/arm/helper-a64.h index

[Qemu-devel] [PATCH v4 19/22] target/arm: Create tagged ram when MTE is enabled

2019-03-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu.h | 4 hw/arm/virt.c| 33 + target/arm/cpu.c | 21 ++--- 3 files changed, 55 insertions(+), 3 deletions(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index e24d1e082c..6d60d2f37d

[Qemu-devel] [PATCH v4 22/22] target/arm: Enable MTE

2019-03-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu64.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c index 228906f267..27c85370c0 100644 --- a/target/arm/cpu64.c +++ b/target/arm/cpu64.c @@ -332,6 +332,7 @@ static void aarch64_max_initfn(Object

[Qemu-devel] [PATCH v4 09/22] target/arm: Implement the SUBP instruction

2019-03-07 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v2: Fix extraction length. --- target/arm/translate-a64.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index

[Qemu-devel] [PATCH v4 21/22] target/arm: Add allocation tag storage for system mode

2019-03-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/mte_helper.c | 56 + 1 file changed, 56 insertions(+) diff --git a/target/arm/mte_helper.c b/target/arm/mte_helper.c index 6d0f82eb99..6657f57ca6 100644 --- a/target/arm/mte_helper.c +++

[Qemu-devel] [PATCH v4 17/22] target/arm: Set PSTATE.TCO on exception entry

2019-03-07 Thread Richard Henderson
R0085 specifies that exception handlers begin with tag checks overridden. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v2: Only set if MTE feature present. --- target/arm/helper.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/target/arm/helper.c

Re: [Qemu-devel] [PATCH v2] machine: Move acpi_nvdimm_state into struct MachineState

2019-03-07 Thread Philippe Mathieu-Daudé
On 3/7/19 5:58 PM, Eduardo Habkost wrote: > On Thu, Mar 07, 2019 at 04:15:21PM +0100, Auger Eric wrote: >> Hi Philippe, Eduardo, >> >> On 3/7/19 11:56 AM, Philippe Mathieu-Daudé wrote: >>> Hi Eric, Eduardo, >>> >>> On 3/7/19 10:06 AM, Eric Auger wrote: As NVDIMM support is looming for ARM and

[Qemu-devel] [PATCH v4 01/22] target/arm: Add MTE_ACTIVE to tb_flags

2019-03-07 Thread Richard Henderson
When MTE is fully enabled, i.e. access to tags are enabled and tag checks affect the PE, then arrange to perform the check while stripping the TBI. The check is not yet implemented, just the plumbing to that point. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v2: Clean TBI

[Qemu-devel] [PATCH v4 05/22] target/arm: Suppress tag check for sp+offset

2019-03-07 Thread Richard Henderson
R0078 specifies that base register, or base register plus immediate offset, is unchecked when the base register is SP. Signed-off-by: Richard Henderson --- v2: Include writeback addresses as checked. --- target/arm/translate-a64.c | 36 ++-- 1 file changed, 18

[Qemu-devel] [PATCH v4 12/22] target/arm: Implement the STGP instruction

2019-03-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- v3: Handle atomicity, require pre-cleaned address. --- target/arm/translate-a64.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index b94a5571e0..b7175897e4

[Qemu-devel] [PATCH v4 20/22] target/arm: Create a TLB entry for tag physical address space

2019-03-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu.h| 45 ++--- target/arm/helper.c | 20 +++- 2 files changed, 57 insertions(+), 8 deletions(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 6d60d2f37d..3647c5bb55 100644 ---

Re: [Qemu-devel] [PATCH v3 3/8] multifd: Create new next_packet_size field

2019-03-07 Thread Eric Blake
On 3/7/19 6:28 AM, Juan Quintela wrote: > "Dr. David Alan Gilbert" wrote: >> * Juan Quintela (quint...@redhat.com) wrote: >>> We need to send this field when we add compression support. As we are >>> still on x- stage, we can do this kind of changes. >>> >>> Signed-off-by: Juan Quintela >> >>

[Qemu-devel] [PATCH v4 02/22] target/arm: Extract TCMA with ARMVAParameters

2019-03-07 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/internals.h | 1 + target/arm/helper.c| 8 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/target/arm/internals.h b/target/arm/internals.h index 6c018e773c..2922324f63 100644 ---

<    1   2   3   4   5   6   7   >