Re: [Qemu-devel] converting build system to Meson?

2019-03-07 Thread Daniel P . Berrangé
On Wed, Mar 06, 2019 at 07:50:49PM +0100, Marc-André Lureau wrote: > Hi Paolo > > On Wed, Mar 6, 2019 at 7:12 PM Paolo Bonzini wrote: > > > > Hi all, > > > > lately I have been thinking of converting the QEMU build system to > > Meson. Meson is a relatively new build system that can replace > >

Re: [Qemu-devel] [Qemu-block] [PATCH] tcmu: Introduce qemu-tcmu utility

2019-03-07 Thread Stefan Hajnoczi
On Wed, Mar 06, 2019 at 10:56:33PM +0100, Kevin Wolf wrote: > Am 21.12.2018 um 11:16 hat Yaowei Bai geschrieben: > * The first priority should be adding an in-process iscsi target that > can be managed with QMP, similar to the built-in NBD server. Using the in-kernel SCSI target with TCMU, or

Re: [Qemu-devel] converting build system to Meson?

2019-03-07 Thread Daniel P . Berrangé
On Thu, Mar 07, 2019 at 07:39:46AM +0100, Thomas Huth wrote: > On 06/03/2019 19.12, Paolo Bonzini wrote: > > Hi all, > > > > lately I have been thinking of converting the QEMU build system to > > Meson. Meson is a relatively new build system that can replace > > Autotools or hand-written

Re: [Qemu-devel] [PATCH] hw/block/virtio-blk: Clean req->dev repetitions

2019-03-07 Thread Stefan Hajnoczi
On Wed, Mar 06, 2019 at 07:00:25PM +0200, Anastasiia Rusakova wrote: > @@ -260,9 +260,10 @@ static int virtio_blk_handle_scsi_req(VirtIOBlockReq > *req) > { > int status = VIRTIO_BLK_S_OK; > struct virtio_scsi_inhdr *scsi = NULL; > -VirtIODevice *vdev = VIRTIO_DEVICE(req->dev); > +

Re: [Qemu-devel] [Qemu-block] [PATCH 03/20] qcow2: Extend spec for external data files

2019-03-07 Thread Stefan Hajnoczi
On Wed, Mar 06, 2019 at 04:06:33PM +0100, Kevin Wolf wrote: > Maybe add a new section "String header extensions" that covers both? > > If this remains the only patch in the series that would need a > significant change, I'd prefer a follow-up patch indeed. A follow-up patch sounds good. Stefan

[Qemu-devel] [PULL 8/9] linux-user: Nicer strace output of chroot() syscall

2019-03-07 Thread Laurent Vivier
From: Helge Deller Signed-off-by: Helge Deller Reviewed-by: Laurent Vivier Message-Id: <20190227191115.ga20...@ls3530.dellerweb.de> Signed-off-by: Laurent Vivier --- linux-user/strace.c| 12 linux-user/strace.list | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-)

Re: [Qemu-devel] [multiprocess RFC PATCH 20/37] multi-process: Add QMP & HMP commands to list remote processes

2019-03-07 Thread Dr. David Alan Gilbert
* elena.ufimts...@oracle.com (elena.ufimts...@oracle.com) wrote: > From: Jagannathan Raman > > Add query-remote QMP command and remote-proc-list HMP command, to list > the remote processes spawned by QEMU. > > Signed-off-by: Jagannathan Raman > Signed-off-by: John G Johnson > Signed-off-by:

Re: [Qemu-devel] converting build system to Meson?

2019-03-07 Thread Peter Maydell
On Thu, 7 Mar 2019 at 06:39, Thomas Huth wrote: > On 06/03/2019 19.12, Paolo Bonzini wrote: > > lately I have been thinking of converting the QEMU build system to > > Meson. Meson is a relatively new build system that can replace > > Autotools or hand-written Makefiles such as QEMU; as a

[Qemu-devel] [PULL 6/9] linux-user: don't short-circuit read with zero length

2019-03-07 Thread Laurent Vivier
From: Andreas Schwab A zero-length read still needs to do the usual checks, thus it may return errors like EBADF. This makes the read syscall emulation consistent with the pread64 syscall emulation. Signed-off-by: Andreas Schwab Reviewed-by: Laurent Vivier Message-Id: Signed-off-by: Laurent

[Qemu-devel] [PULL 1/9] linux-user: fix recvmsg emulation

2019-03-07 Thread Laurent Vivier
From: Andreas Schwab Set msg_flags in the returned struct msghdr. Signed-off-by: Andreas Schwab Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Message-Id: Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PULL 5/9] Fix breakpoint support in Nios II user-mode emulation.

2019-03-07 Thread Laurent Vivier
From: Sandra Loosemore Nios II user-mode emulation was missing handling for EXCP_DEBUG, making the gdb stub essentially useless. This patch adds the missing piece. The new code was copied from the existing EXCP_TRAP handling and is also similar to what other targets (e.g., arm) do with

[Qemu-devel] [PULL 2/9] linux-user: Add ELF_PLATFORM for arm

2019-03-07 Thread Laurent Vivier
From: Richard Henderson The 32-bit kernel has strings for v4, v5, v6, v7, v7m. The 64-bit kernel, in compat mode, has strings for v8. Fixes: https://bugs.launchpad.net/bugs/1813034 Signed-off-by: Richard Henderson Reviewed-by: Laurent Vivier Message-Id:

[Qemu-devel] [PULL 3/9] linux-user: Fix ELF_PLATFORM for aarch64_be-linux-user

2019-03-07 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Laurent Vivier Message-Id: <20190212074840.13542-3-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/elfload.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PULL 7/9] linux-user: fix "may be used uninitialized" warnings

2019-03-07 Thread Laurent Vivier
From: Marc-André Lureau Fixes: /home/elmarco/src/qemu/linux-user/syscall.c: In function ‘do_ioctl_rt’: /home/elmarco/src/qemu/linux-user/syscall.c:4773:9: error: ‘host_rt_dev_ptr’ may be used uninitialized in this function [-Werror=maybe-uninitialized] if (*host_rt_dev_ptr != 0) {

[Qemu-devel] [PULL 0/9] Linux user for 4.0 patches

2019-03-07 Thread Laurent Vivier
The following changes since commit 32694e98b8d7a246345448a8f707d2e11d6c65e2: Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2019-03-06 18:52:19 +) are available in the Git repository at: git://github.com/vivier/qemu.git

[Qemu-devel] [PULL 4/9] linux-user: fix emulation of accept4/getpeername/getsockname/recvfrom syscalls

2019-03-07 Thread Laurent Vivier
From: Andreas Schwab System calls that return a socket address do so by writing the (possibly truncated) address into the provided buffer space, but setting the addrlen parameter to the actual size of the address. To determine how much to copy back to the target memory the emulation needs to

[Qemu-devel] [PULL 9/9] linux-user: add new netlink types

2019-03-07 Thread Laurent Vivier
Add QEMU_IFLA_BR_VLAN_STATS_PER_PORT (from linux v4.20), QEMU_IFLA_BR_MULTI_BOOLOPT (from linux v5.0). The first new entry fixes the following error: Unknown QEMU_IFLA_BR type 45 Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Message-Id:

Re: [Qemu-devel] [PATCH v2] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.

2019-03-07 Thread Daniel P . Berrangé
On Wed, Mar 06, 2019 at 07:54:17PM +0100, Igor Mammedov wrote: > On Wed, 6 Mar 2019 18:16:08 + > Daniel P. Berrangé wrote: > > > On Wed, Mar 06, 2019 at 06:33:25PM +0100, Igor Mammedov wrote: > > > Amend -numa option docs and print warnings if 'mem' option or default RAM > > > splitting

Re: [Qemu-devel] [RFC PATCH v6 2/4] hw/block: Pad undersized read-only images with 0xFF

2019-03-07 Thread Markus Armbruster
Markus Armbruster writes: > From: Alex Bennée > > We reject undersized images. As of the previous commit, even with a > decent error message. Still, this is a potentially confusing > stumbling block when you move from using -bios to using -drive > if=pflash,file=blob,format=raw,readonly for

Re: [Qemu-devel] [PATCH] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.

2019-03-07 Thread Daniel P . Berrangé
On Wed, Mar 06, 2019 at 07:48:22PM +0100, Igor Mammedov wrote: > On Wed, 6 Mar 2019 17:10:37 + > Daniel P. Berrangé wrote: > > > On Wed, Mar 06, 2019 at 05:58:35PM +0100, Igor Mammedov wrote: > > > On Wed, 6 Mar 2019 16:39:38 + > > > Daniel P. Berrangé wrote: > > > > > > > On Wed, Mar

[Qemu-devel] [Bug 1818483] Re: qemu user mode does not support binfmt_misc config with flags include "P"

2019-03-07 Thread Peter Maydell
The question is: can we have one set of QEMU code that copes correctly with both 'binfmt_misc with P flag' and 'binfmt_misc without P flag' ? Your patch makes -P work but breaks some cases without it. That means it's not backwards compatible with all the existing QEMU installations and use cases

Re: [Qemu-devel] [libvirt] [PATCH 1/2] numa: deprecate 'mem' parameter of '-numa node' option

2019-03-07 Thread Daniel P . Berrangé
On Wed, Mar 06, 2019 at 08:03:48PM +0100, Igor Mammedov wrote: > On Mon, 4 Mar 2019 16:35:16 + > Daniel P. Berrangé wrote: > > > On Mon, Mar 04, 2019 at 05:20:13PM +0100, Michal Privoznik wrote: > > > We couldn't have done that. How we would migrate from older qemu? > > > > > > Anyway, now

[Qemu-devel] [PULL 2/4] usb-mtp: fix some usb_mtp_write_data return paths

2019-03-07 Thread Gerd Hoffmann
From: Bandan Das During a write, free up the "path" before getting more data. Also, while we at it, remove the confusing usage of d->fd for storing mkdir status Spotted by Coverity: CID 1398642 Signed-off-by: Bandan Das Message-id: 20190306210409.14842-3-...@redhat.com Signed-off-by: Gerd

[Qemu-devel] [PULL 1/4] usb-mtp: return incomplete transfer on a lstat failure

2019-03-07 Thread Gerd Hoffmann
From: Bandan Das MTP writes objects in small chunks and at the end gets the real file size to update the object metadata. If this fails for any reason, return an INCOMPLETE_TRANSFER to the initiator Spotted by Coverity: CID 1398651 Signed-off-by: Bandan Das Message-id:

[Qemu-devel] [PULL 4/4] Introduce new "no_guest_reset" parameter for usb-host device

2019-03-07 Thread Gerd Hoffmann
From: Alexander Kappner With certain USB devices passed through via usb-host, a guest attempting to reset a usb-host device can trigger a reset loop that renders the USB device unusable. In my use case, the device was an iPhone XR that was passed through to a Mac OS X Mojave guest. Upon

[Qemu-devel] [PULL 3/4] usb-mtp: prevent null dereference while deleting objects

2019-03-07 Thread Gerd Hoffmann
From: Bandan Das Spotted by Coverity: CID 1399144 Signed-off-by: Bandan Das Message-id: 20190306210409.14842-4-...@redhat.com Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index

[Qemu-devel] [PULL 0/4] Usb 20190307 patches

2019-03-07 Thread Gerd Hoffmann
The following changes since commit 32694e98b8d7a246345448a8f707d2e11d6c65e2: Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2019-03-06 18:52:19 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/usb-20190307-pull

Re: [Qemu-devel] [PATCH v4 4/9] {hmp, hw/pvrdma}: Expose device internals via monitor interface

2019-03-07 Thread Marcel Apfelbaum
Hi Yuval, On 3/3/19 10:33 PM, Yuval Shaia wrote: Allow interrogating device internals through HMP interface. The exposed indicators can be used for troubleshooting by developers or sysadmin. There is no need to expose these attributes to a management system (e.x. libvirt) because (1) most of

Re: [Qemu-devel] [PATCH v2] machine: Move acpi_nvdimm_state into struct MachineState

2019-03-07 Thread Igor Mammedov
On Thu, 7 Mar 2019 10:06:39 +0100 Eric Auger wrote: > As NVDIMM support is looming for ARM and SPAPR, let's > move the acpi_nvdimm_state to the generic machine struct > instead of duplicating the same code in several machines. > It is also renamed into nvdimms_state. > > nvdimm and

Re: [Qemu-devel] [PATCH v3 08/12] docs: Provide separate conf.py for each manual we want

2019-03-07 Thread Peter Maydell
On Thu, 7 Mar 2019 at 01:40, Cleber Rosa wrote: > I have the impression that this can be simplified by making use of > "only" tags: > > https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-only > > So, conf.py could detect if it's being run on readthedocs.org: > >

Re: [Qemu-devel] [PATCH v3 01/12] docs/cpu-hotplug.rst: Fix rST markup issues

2019-03-07 Thread Peter Maydell
On Thu, 7 Mar 2019 at 00:04, Cleber Rosa wrote: > But I'm assuming the extended sphinx roles/directives will be used, so > the only way to check against future breakage would be to build the > docs. > > Do we have strong position in favor or against putting that into the > "common" `make check`

Re: [Qemu-devel] [RFC PATCH v6 0/4] hw/block: better reporting on pflash backing file mismatch

2019-03-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190307093723.655-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190307093723.655-1-arm...@redhat.com Subject: [Qemu-devel] [RFC PATCH v6 0/4] hw/block:

[Qemu-devel] [RFC PATCH v6 2/4] hw/block: Pad undersized read-only images with 0xFF

2019-03-07 Thread Markus Armbruster
From: Alex Bennée We reject undersized images. As of the previous commit, even with a decent error message. Still, this is a potentially confusing stumbling block when you move from using -bios to using -drive if=pflash,file=blob,format=raw,readonly for loading your firmware code. To mitigate

[Qemu-devel] [RFC PATCH v6 1/4] hw/block: better reporting on pflash backing file mismatch

2019-03-07 Thread Markus Armbruster
From: Alex Bennée It looks like there was going to be code to check we had some sort of alignment so let's replace it with an actual check. Reject undersized images with "device needs N bytes, backing file provides only M bytes". This is a bit more useful than the enigmatic "failed to read the

[Qemu-devel] [RFC PATCH v6 3/4] fixup! hw/block: better reporting on pflash backing file mismatch

2019-03-07 Thread Markus Armbruster
--- hw/block/pflash_cfi02.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c index 33779ce807..d30a351472 100644 --- a/hw/block/pflash_cfi02.c +++ b/hw/block/pflash_cfi02.c @@ -39,6 +39,7 @@

[Qemu-devel] [RFC PATCH v6 4/4] fixup! hw/block: Pad undersized read-only images with 0xFF

2019-03-07 Thread Markus Armbruster
--- hw/block/pflash_cfi02.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c index d30a351472..db1c39499c 100644 --- a/hw/block/pflash_cfi02.c +++ b/hw/block/pflash_cfi02.c @@ -578,8 +578,9 @@ static void

[Qemu-devel] [RFC PATCH v6 0/4] hw/block: better reporting on pflash backing file mismatch

2019-03-07 Thread Markus Armbruster
This is Alex's "[PATCH v5] hw/block: better reporting on pflash backing file mismatch" with the padding split off into its own patch, and both resulting patches applied to pflash_cfi02.c. I downgraded it to RFC for two reasons: 1. I think the padding patches should not be applied. I'll reply to

Re: [Qemu-devel] [PATCH v5] hw/block: better reporting on pflash backing file mismatch

2019-03-07 Thread Markus Armbruster
One more thing... Alex Bennée writes: > It looks like there was going to be code to check we had some sort of > alignment so lets replace it with an actual check. This is a bit more > useful than the enigmatic "failed to read the initial flash content" > when we attempt to read the number of

[Qemu-devel] [PATCH] scsi-disk: Fix crash if request is invaild or disk is no medium

2019-03-07 Thread Zhengui li
From: Zhengui Li Qemu will crash with the assertion error that "assert(r->req.aiocb != NULL)" in scsi_read_complete if request is invaild or disk is no medium. The error is below: qemu-kvm: hw/scsi/scsi_disk.c:299: scsi_read_complete: Assertion `r->req.aiocb != NULL' failed. This patch add a

[Qemu-devel] [PATCH v2] machine: Move acpi_nvdimm_state into struct MachineState

2019-03-07 Thread Eric Auger
As NVDIMM support is looming for ARM and SPAPR, let's move the acpi_nvdimm_state to the generic machine struct instead of duplicating the same code in several machines. It is also renamed into nvdimms_state. nvdimm and nvdimm-persistence become generic machine options. We also add a description

Re: [Qemu-devel] [PATCH] scsi-disk: Fix crash if request is invaild or disk is no medium

2019-03-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1551949037-15528-1-git-send-email-lizhen...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1551949037-15528-1-git-send-email-lizhen...@huawei.com Subject: [Qemu-devel]

[Qemu-devel] [PATCH] scsi-disk: Fix crash if request is invaild or disk is no medium

2019-03-07 Thread Zhengui li
From: Zhengui Li Qemu will crash with the assertion error that "assert(r->req.aiocb != NULL)" in scsi_read_complete if request is invaild or disk is no medium. The error is below: qemu-kvm: hw/scsi/scsi_disk.c:299: scsi_read_complete: Assertion `r->req.aiocb != NULL' failed. This patch add a

Re: [Qemu-devel] [Qemu-block] [PATCH] tcmu: Introduce qemu-tcmu utility

2019-03-07 Thread Yaowei Bai
Add Fam. On Wed, Mar 06, 2019 at 10:56:33PM +0100, Kevin Wolf wrote: > Am 21.12.2018 um 11:16 hat Yaowei Bai geschrieben: > > This patch introduces a new utility, qemu-tcmu. Apart from the > > underlaying protocol it interacts with the world much like > > qemu-nbd. This patch bases on Fam's

Re: [Qemu-devel] [PATCH 0/3] migration: add sztd compression

2019-03-07 Thread Denis Plotnikov
ping ping On 04.03.2019 18:10, Denis Plotnikov wrote: > ping! > > On 26.02.2019 16:15, Denis Plotnikov wrote: >> zstd date compression algorithm shows better performance on data compression. >> It might be useful to employ the algorithm in VM migration to reduce CPU >> usage. >> A user will be

Re: [Qemu-devel] [Qemu-block] [PATCH] tcmu: Introduce qemu-tcmu utility

2019-03-07 Thread Yaowei Bai
On Wed, Mar 06, 2019 at 10:56:33PM +0100, Kevin Wolf wrote: > Am 21.12.2018 um 11:16 hat Yaowei Bai geschrieben: > > This patch introduces a new utility, qemu-tcmu. Apart from the > > underlaying protocol it interacts with the world much like > > qemu-nbd. This patch bases on Fam's version. > > >

Re: [Qemu-devel] [multiprocess RFC PATCH 36/37] multi-process: add the concept description to docs/devel/qemu-multiprocess

2019-03-07 Thread Thomas Huth
On 07/03/2019 08.22, elena.ufimts...@oracle.com wrote: > From: Elena Ufimtseva > > TODO: Make relevant changes to the doc. > > Signed-off-by: John G Johnson > Signed-off-by: Elena Ufimtseva > Signed-off-by: Jagannathan Raman > --- > docs/devel/qemu-multiprocess.txt | 1109 >

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 08/16] s390-bios: Map low core memory

2019-03-07 Thread Cornelia Huck
On Wed, 6 Mar 2019 14:28:42 -0500 "Jason J. Herne" wrote: > On 3/5/19 1:27 AM, Thomas Huth wrote: > > On 01/03/2019 19.59, Jason J. Herne wrote: > >> +PSW return_psw; /* 0x200 */ > >> +uint8_t irb[64]; /* 0x210 */ > >> +uint64_t

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 06/16] s390-bios: Clean up cio.h

2019-03-07 Thread Cornelia Huck
On Wed, 6 Mar 2019 13:42:17 -0500 "Jason J. Herne" wrote: > On 3/5/19 12:51 AM, Thomas Huth wrote: > > On 01/03/2019 19.59, Jason J. Herne wrote: > >> Add proper typedefs to all structs and modify all bit fields to use > >> consistent > >> formatting. > >> > >> Signed-off-by: Jason J. Herne

[Qemu-devel] [PATCH 1/3] virtio: add class_size to VirtioPCIDeviceTypeInfo

2019-03-07 Thread Gerd Hoffmann
Needed when VirtioPCIClass subclasses have their own class struct with some extra fields. Signed-off-by: Gerd Hoffmann --- hw/virtio/virtio-pci.h | 1 + hw/virtio/virtio-pci.c | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/virtio/virtio-pci.h b/hw/virtio/virtio-pci.h index

[Qemu-devel] [PATCH 0/3] virtio-gpu: fix reset.

2019-03-07 Thread Gerd Hoffmann
Gerd Hoffmann (3): virtio: add class_size to VirtioPCIDeviceTypeInfo virtio-vga: fix reset. virtio-gpu: make virtio_gpu_reset static hw/virtio/virtio-pci.h | 1 + include/hw/virtio/virtio-gpu.h | 1 - hw/display/virtio-gpu.c| 2 +- hw/display/virtio-vga.c| 17

[Qemu-devel] [PATCH 3/3] virtio-gpu: make virtio_gpu_reset static

2019-03-07 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/hw/virtio/virtio-gpu.h | 1 - hw/display/virtio-gpu.c| 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h index 98504f907583..ce0ca7217175 100644 ---

[Qemu-devel] [PATCH 2/3] virtio-vga: fix reset.

2019-03-07 Thread Gerd Hoffmann
Store reset handler of the parent class and just call that for a complete virtio reset. When taking the shortcut and calling virtio_gpu_reset() directly the generic virtio reset code (for virtqueues etc) will not be executed. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1597621

<    2   3   4   5   6   7