[Qemu-devel] [Bug 1812694] Re: qemu-system-x86_64 version 3.0+ is 20 times slower than version 2.12

2019-03-22 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1812694 Title:

Re: [Qemu-devel] [PATCH v8 05/16] gdbstub: add multiprocess support to vCont packets

2019-03-22 Thread Lucien Anti-Spam via Qemu-devel
> On Friday, March 22, 2019, 11:01:34 PM GMT+9, Luc Michel wrote: > Lucien: do you plan to send a re-roll? Otherwise I'll do it on next > Monday (25/03) because I would like this bug to be fixed before it hits 4.0. I am on assignment in China which is why I havent gotten to it, I will

[Qemu-devel] [Bug 1821430] [NEW] qemu-user-arm (4.0.0-rc0) crashes

2019-03-22 Thread asavah
Public bug reported: I'm using qemu-user-arm for crosscompilation needs, usually via a wrapper. qemu-user-arm (4.0.0-rc0) crashes with SIGILL on at least 2 instructions: first case (sadly I don't have more data handy, can reproduce at a later time if needed): (gdb) x/i $pc => 0xfffce314:

[Qemu-devel] [PATCH for-4.0] target/arm: Fix non-parallel expansion of CASP

2019-03-22 Thread Richard Henderson
The second word has been loaded from the unincremented address since the first commit. Fixes: 44ac14b06fa Reported-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/translate-a64.c

Re: [Qemu-devel] [PATCH] virtio-vga: only enable for specific boards

2019-03-22 Thread Paolo Bonzini
- Original Message - > From: "Laszlo Ersek" > To: "Paolo Bonzini" , qemu-devel@nongnu.org > Cc: th...@redhat.com > Sent: Thursday, March 21, 2019 8:34:46 PM > Subject: Re: [PATCH] virtio-vga: only enable for specific boards > > On 03/21/19 15:29, Paolo Bonzini wrote: > > When

Re: [Qemu-devel] [PATCH v2 0/3] qemu-img: removing created when img_create fails

2019-03-22 Thread Daniel Henrique Barboza
On 3/22/19 4:02 PM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20190322175241.5954-1-danielhb...@gmail.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can

[Qemu-devel] [PATCH v2 for-4.0] hardfloat: fix float32/64 fused multiply-add

2019-03-22 Thread Emilio G. Cota
From: Kito Cheng Before falling back to softfloat FMA, we do not restore the original values of inputs A and C. Fix it. This bug was caught by running gcc's testsuite on RISC-V qemu. Note that this change gives a small perf increase for fp-bench: Host: Intel(R) Core(TM) i7-4790K CPU @

Re: [Qemu-devel] [PATCH 0/6] block: Fix slow pre-zeroing in qemu-img convert

2019-03-22 Thread Eric Blake
On 3/22/19 3:22 PM, Nir Soffer wrote: > Thanks for fixing this! This will be a very important performance fix for > importing > VMs. > > The change description sounds good to me. > > Can you make these patches available on some git repo to make it easy to > test? Based on commit titles, this

Re: [Qemu-devel] [PATCH 0/6] block: Fix slow pre-zeroing in qemu-img convert

2019-03-22 Thread Nir Soffer
On Fri, Mar 22, 2019 at 3:22 PM Kevin Wolf wrote: > If qemu-img convert sees that the target image isn't zero-initialised > yet, it tries to do an efficient zero write for the whole image first > to save the overhead of repeated explicit zero writes during the > conversion. Obviously, this

Re: [Qemu-devel] [PATCH] hardfloat: fix float32/64 fused multiply-add

2019-03-22 Thread Emilio G. Cota
On Sat, Mar 23, 2019 at 01:39:26 +0800, Kito Cheng wrote: > hardfloat fused multiply-add might fallback to softfloat mode in some > situation, but it might already changed the value of input operands, > so we must restore those value before fallback. > > This bug is catched by running gcc

[Qemu-devel] [PATCH] target/xtensa: don't announce exit simcall

2019-03-22 Thread Max Filippov
Don't announce that exit simcall has been invoked: this is just noise. Signed-off-by: Max Filippov --- target/xtensa/xtensa-semi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/xtensa/xtensa-semi.c b/target/xtensa/xtensa-semi.c index 2f762162768c..5f5ce4f344c6 100644 ---

[Qemu-devel] [PATCH] tests/tcg/xtensa: clean up test set

2019-03-22 Thread Max Filippov
Drop test_fail: we know that exit simcall works. Now that it's not run automatically there's no point in keeping it. Drop test_pipeline: we're not modeling pipeline, we don't control ccount and there's no plan to do so. Enable test_boolean: it won't break on cores without boolean option, it will

[Qemu-devel] [PULL 6/8] slirp: clarify license of slirp files using SPDX: implicit via unstated

2019-03-22 Thread Marc-André Lureau
Add SPDX license identifier to clarify the license of files without explicit license header. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- slirp/src/bootp.h | 1 + slirp/src/ip6.h| 1 + slirp/src/ip6_icmp.h | 1 + slirp/src/libslirp.h | 1 + slirp/src/slirp.h

[Qemu-devel] [PULL 4/8] slirp: clarify license of slirp files using SPDX: explicit MIT

2019-03-22 Thread Marc-André Lureau
Add SPDX license identifier to clarify the license of files with explicit MIT license header. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- slirp/src/util.h | 1 + slirp/src/arp_table.c | 1 + slirp/src/bootp.c | 1 + slirp/src/dnssearch.c | 1 + slirp/src/slirp.c

[Qemu-devel] [PULL 1/8] slirp: update COPYRIGHT to use full 3-Clause BSD License

2019-03-22 Thread Marc-André Lureau
According to commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove the advertising clause from the slirp license"), Danny Gasparovski gave permission to license slirp code under 3-clause BSD license: Subject: RE: Slirp license Date: Thu, 8 Jan 2009 10:51:00 +1100 From:

[Qemu-devel] [PULL 0/8] Slirp patches

2019-03-22 Thread Marc-André Lureau
The following changes since commit d97a39d903fe33c45be83ac6943a2f82a3649a11: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' into staging (2019-03-22 09:37:38 +) are available in the Git repository at: https://github.com/elmarco/qemu.git

Re: [Qemu-devel] [Xen-devel] [PATCH 6/6] xen-pt: Round pci regions sizes to XEN_PAGE_SIZE

2019-03-22 Thread Jason Andryuk
On Thu, Mar 21, 2019 at 11:09 PM Roger Pau Monné wrote: > > On Wed, Mar 20, 2019 at 01:28:47PM -0400, Jason Andryuk wrote: > > On Fri, Mar 15, 2019 at 12:28 PM Andrew Cooper > > wrote: > > > > > > On 15/03/2019 09:17, Paul Durrant wrote: > > > >> -Original Message- > > > >> From: Jason

[Qemu-devel] [PULL 5/8] slirp: clarify license of slirp files using SPDX: implicit via COPYRIGHT

2019-03-22 Thread Marc-André Lureau
Add SPDX license identifier to clarify the license of files with reference to BSD license from slirp COPYRIGHT file. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- slirp/src/debug.h | 1 + slirp/src/if.h | 1 + slirp/src/main.h | 1 + slirp/src/misc.h | 1 +

[Qemu-devel] [PULL 3/8] slirp: clarify license of slirp files using SPDX: explicit BSD

2019-03-22 Thread Marc-André Lureau
Add SPDX license identifier to clarify the license of files with explicit 3-clause BSD license header. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- slirp/src/dhcpv6.h | 1 + slirp/src/ip.h | 1 + slirp/src/ip_icmp.h| 1 + slirp/src/mbuf.h | 1 +

[Qemu-devel] [PULL 2/8] slirp: relicense GPL files to BSD-3

2019-03-22 Thread Marc-André Lureau
In order to make slirp a standalone project, the project must have a clear license, and be compatible with the GPL or LGPL. Since commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove the advertising clause from the slirp license"), slirp is BSD-3. But new files have been added under slirp/

[Qemu-devel] [PULL 7/8] slirp: remove reference to COPYRIGHT file

2019-03-22 Thread Marc-André Lureau
The slirp COPYRIGHT file is a BSD-3 license. Instead of referring to another project file, the SPDX license notice present in all source files states that unequivocally. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- slirp/src/debug.h | 3 --- slirp/src/if.h | 3 ---

[Qemu-devel] [PULL 8/8] slirp: is not maintained by Kelly Price for a long time

2019-03-22 Thread Marc-André Lureau
slirp has been maintained by the QEMU maintainers and will be maintained under an independent project soon. Reviewed-by: Eric Blake Signed-off-by: Kelly Price Signed-off-by: Marc-André Lureau --- slirp/COPYRIGHT | 2 -- 1 file changed, 2 deletions(-) diff --git a/slirp/COPYRIGHT

Re: [Qemu-devel] [PATCH v2 0/3] qemu-img: removing created when img_create fails

2019-03-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190322175241.5954-1-danielhb...@gmail.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [Qemu-devel] [PATCH 2/4] target/mips: Fix copy_s. for MIPS big endian host

2019-03-22 Thread Mateja Marjanovic
On 22.3.19. 18:45, Aleksandar Markovic wrote: From: Mateja Marjanovic Subject: [PATCH 2/4] target/mips: Fix copy_s. for MIPS big endian host From: Mateja Marjanovic Signed element copy from MSA registers to GPR when executed on a MIPS big endian CPU, didn't pick the right element, and was

Re: [Qemu-devel] [PATCH 4/4] target/mips: Fix insert. for MIPS big endian host

2019-03-22 Thread Mateja Marjanovic
On 22.3.19. 19:04, Aleksandar Markovic wrote: @@ -1511,9 +1518,11 @@ void helper_msa_insert_df(CPUMIPSState *env, uint32_t df, uint32_t wd, case DF_WORD: pwd->w[n] = (int32_t)rs; break; +#ifdef TARGET_MIPS64 case DF_DOUBLE: pwd->d[n] =

Re: [Qemu-devel] [PATCH 1/2] iotests: 030 TestParallelOps non-shared base node

2019-03-22 Thread Andrey Shinkevich
On 22/03/2019 18:54, Alberto Garcia wrote: > On Thu 21 Mar 2019 03:51:12 PM CET, Alberto Garcia wrote: > >> I was checking the tests that run commit and stream in parallel in >> 030, but they do commit on the upper images and stream on the lower >> ones, so that's safe. I'll try to run them

Re: [Qemu-devel] [PATCH 4/4] target/mips: Fix insert. for MIPS big endian host

2019-03-22 Thread Aleksandar Markovic
> >> @@ -1511,9 +1518,11 @@ void helper_msa_insert_df(CPUMIPSState *env, > >> uint32_t df, uint32_t wd, > >> case DF_WORD: > >> pwd->w[n] = (int32_t)rs; > >> break; > >> +#ifdef TARGET_MIPS64 > >> case DF_DOUBLE: > >> pwd->d[n] = (int64_t)rs; > >>

[Qemu-devel] [PATCH for-4.0 3/3] target/ppc: Consolidate 64-bit server processor detection in a helper

2019-03-22 Thread Greg Kurz
We use PPC_SEGMENT_64B in various places to guard code that is specific to 64-bit server processors compliant with arch 2.x. Consolidate the logic in a helper macro with an explicit name. Signed-off-by: Greg Kurz --- hw/ppc/ppc.c |2 +- target/ppc/cpu.h |6 ++

[Qemu-devel] [PATCH v2 0/3] qemu-img: removing created when img_create fails

2019-03-22 Thread Daniel Henrique Barboza
This is a patch series that follows up the patch [1] after the review from Daniel P. Berrange. The new interface is being implemented only by the LUKS driver because this is the error condition I'm trying to fix. My first idea when coding it was to implement this interface in all drivers that

[Qemu-devel] [PATCH for-4.0 1/3] target/ppc: Fix TCG temporary leaks in gen_bcond()

2019-03-22 Thread Greg Kurz
Signed-off-by: Greg Kurz --- target/ppc/translate.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 98b37cebc2f5..aaafa3a715d8 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -3749,6 +3749,8 @@ static void

[Qemu-devel] [PATCH v2 1/3] block: introducing 'bdrv_co_delete_file' interface

2019-03-22 Thread Daniel Henrique Barboza
Adding to Block Drivers the capability of being able to clean up its created files can be useful in certain situations. For the LUKS driver, for instance, a failure in one of its authentication steps can leave files in the host that weren't there before. This patch adds the 'bdrv_co_delete_file'

[Qemu-devel] [PATCH for-4.0 0/3] target/ppc: Fix pseries.cap-ibs=workaround with TCG

2019-03-22 Thread Greg Kurz
Since recent commit 2782ad4c4102 "target/ppc/spapr: Enable mitigations by default for pseries-4.0 machine type", some recent distros, eg. fedora29, fail to boot under TCG because of a kernel panic: [0.614425] Oops: Exception in kernel mode, sig: 4 [#1] [0.618832] LE SMP NR_CPUS=1024 NUMA

[Qemu-devel] [PATCH for-4.0 2/3] target/ppc: Enable "decrement and test CTR" version of bcctr

2019-03-22 Thread Greg Kurz
Even if all ISAs up to v3 indeed mention: If the "decrement and test CTR" option is specified (BO2=0), the instruction form is invalid. The UMs of all existing 64-bit server class processors say: If BO[2] = 0, the contents of CTR (before any update) are used as the target

[Qemu-devel] [PATCH v2 2/3] block.c: adding bdrv_delete_file

2019-03-22 Thread Daniel Henrique Barboza
Using the new 'bdrv_co_delete_file' interface, bdrv_delete_file can be used in a way similar of the existing bdrv_create_file to invoke a driver, given by a format @fmt, to clean up a created file. The logic is also similar to what is already done in bdrv_create_file: a qemu_coroutine is created

[Qemu-devel] [PATCH v2 3/3] qemu-img.c: clean up created file on img_create failure

2019-03-22 Thread Daniel Henrique Barboza
When using a non-UTF8 secret to create a volume using qemu-img, the following error happens: $ qemu-img create -f luks --object secret,id=vol_1_encrypt0,file=vol_resize_pool.vol_1.secret.qzVQrI -o key-secret=vol_1_encrypt0 /var/tmp/pool_target/vol_1 10240K Formatting

Re: [Qemu-devel] [PATCH 2/4] target/mips: Fix copy_s. for MIPS big endian host

2019-03-22 Thread Aleksandar Markovic
> From: Mateja Marjanovic > Subject: [PATCH 2/4] target/mips: Fix copy_s. for MIPS big endian host > > From: Mateja Marjanovic > > Signed element copy from MSA registers to GPR when > executed on a MIPS big endian CPU, didn't pick the > right element, and was behaving like on little endian. >

Re: [Qemu-devel] [PATCH 4/4] target/mips: Fix insert. for MIPS big endian host

2019-03-22 Thread Mateja Marjanovic
On 22.3.19. 18:16, Aleksandar Markovic wrote: From: Mateja Marjanovic Subject: [PATCH 4/4] target/mips: Fix insert. for MIPS big endian host From: Mateja Marjanovic Inserting from GPR to an element in a MSA register when executed on a MIPS big endian CPU, didn't pick the right element, and

Re: [Qemu-devel] [PATCH 1/4] Clean up wrong usage of FALSE and TRUE in places that use bool from stdbool.h

2019-03-22 Thread Eric Blake
On 3/22/19 7:05 AM, JafarAbdi wrote: > Signed-off-by: JafarAbdi > --- Thank you for your submission - it looks like your first contribution to qemu. However, I have some suggestions that will make it easier to get your patches applied: - Use a cover letter. Since you sent a series, including a

[Qemu-devel] [PATCH] hardfloat: fix float32/64 fused multiply-add

2019-03-22 Thread Kito Cheng
hardfloat fused multiply-add might fallback to softfloat mode in some situation, but it might already changed the value of input operands, so we must restore those value before fallback. This bug is catched by running gcc testsuite on RISC-V qemu. Signed-off-by: Kito Cheng --- fpu/softfloat.c

Re: [Qemu-devel] [PATCH 4/4] target/mips: Fix insert. for MIPS big endian host

2019-03-22 Thread Aleksandar Markovic
> From: Mateja Marjanovic > Subject: [PATCH 4/4] target/mips: Fix insert. for MIPS big endian host > > From: Mateja Marjanovic > > Inserting from GPR to an element in a MSA register when > executed on a MIPS big endian CPU, didn't pick the > right element, and was behaving like on little

[Qemu-devel] [PATCH 3/3] target/arm: make pmccntr_op_start/finish static

2019-03-22 Thread Andrew Jones
These functions are not used outside helper.c Signed-off-by: Andrew Jones --- target/arm/cpu.h| 11 --- target/arm/helper.c | 4 ++-- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 5f23c621325c..d4d2836923df 100644 ---

[Qemu-devel] [PATCH] target/arm: default config

2019-03-22 Thread Andrew Jones
In the kconfig shuffle arm lost pci-testdev which is used by kvm-unit-tests. Let's add it back. Signed-off-by: Andrew Jones --- default-configs/arm-softmmu.mak | 1 + 1 file changed, 1 insertion(+) diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak index

[Qemu-devel] target/arm: kvm-unit-tests gicv2 test failures on tcg

2019-03-22 Thread Andrew Jones
Hi TCG GIC developers, There are a few gicv2 test failures when running over TCG that we don't see when running over KVM. I don't believe these are regressions - I'm pretty sure they've been failing since Andre first introduced the tests. I'm just pointing them out now in case anybody would

Re: [Qemu-devel] target/arm: kvm-unit-tests gicv2 test failures on tcg

2019-03-22 Thread Peter Maydell
On Fri, 22 Mar 2019 at 16:40, Andrew Jones wrote: > Hi TCG GIC developers, > > There are a few gicv2 test failures when running over TCG that we don't > see when running over KVM. I don't believe these are regressions - I'm > pretty sure they've been failing since Andre first introduced the

Re: [Qemu-devel] [PATCH v4 0/8] slirp: clarify license of slirp as BSD-3

2019-03-22 Thread Marc-André Lureau
Hi On Fri, Mar 22, 2019 at 5:43 PM Marc-André Lureau wrote: > > Hi, > > In order to make slirp a standalone project, the project must have a > clear license, and be compatible with the GPL or LGPL. > > Since commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove the > advertising clause from

[Qemu-devel] [PATCH v4 5/8] slirp: clarify license of slirp files using SPDX: implicit via COPYRIGHT

2019-03-22 Thread Marc-André Lureau
Add SPDX license identifier to clarify the license of files with reference to BSD license from slirp COPYRIGHT file. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- slirp/src/debug.h | 1 + slirp/src/if.h | 1 + slirp/src/main.h | 1 + slirp/src/misc.h | 1 +

Re: [Qemu-devel] [PATCH 0/3] target/arm: pmu fixes

2019-03-22 Thread Andrew Jones
On Fri, Mar 22, 2019 at 05:23:30PM +0100, Andrew Jones wrote: > The first two patches fix a regression I found when running > the arm (as opposed to arm64) pmu kvm-unit-tests test on tcg, > > $ git clone git://git.kernel.org/pub/scm/virt/kvm/kvm-unit-tests.git > $ cd kvm-unit-tests > $

[Qemu-devel] [PATCH v4 6/8] slirp: clarify license of slirp files using SPDX: implicit via unstated

2019-03-22 Thread Marc-André Lureau
Add SPDX license identifier to clarify the license of files without explicit license header. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- slirp/src/bootp.h | 1 + slirp/src/ip6.h| 1 + slirp/src/ip6_icmp.h | 1 + slirp/src/libslirp.h | 1 + slirp/src/slirp.h

[Qemu-devel] [PATCH v4 1/8] slirp: update COPYRIGHT to use full 3-Clause BSD License

2019-03-22 Thread Marc-André Lureau
According to commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove the advertising clause from the slirp license"), Danny Gasparovski gave permission to license slirp code under 3-clause BSD license: Subject: RE: Slirp license Date: Thu, 8 Jan 2009 10:51:00 +1100 From:

[Qemu-devel] [PATCH v4 3/8] slirp: clarify license of slirp files using SPDX: explicit BSD

2019-03-22 Thread Marc-André Lureau
Add SPDX license identifier to clarify the license of files with explicit 3-clause BSD license header. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- slirp/src/dhcpv6.h | 1 + slirp/src/ip.h | 1 + slirp/src/ip_icmp.h| 1 + slirp/src/mbuf.h | 1 +

Re: [Qemu-devel] [PATCH v4 0/8] slirp: clarify license of slirp as BSD-3

2019-03-22 Thread Samuel Thibault
Marc-André Lureau, le ven. 22 mars 2019 17:46:12 +0100, a ecrit: > On Fri, Mar 22, 2019 at 5:43 PM Marc-André Lureau > wrote: > > > > Hi, > > > > In order to make slirp a standalone project, the project must have a > > clear license, and be compatible with the GPL or LGPL. > > > > Since commit

[Qemu-devel] [PATCH v4 4/8] slirp: clarify license of slirp files using SPDX: explicit MIT

2019-03-22 Thread Marc-André Lureau
Add SPDX license identifier to clarify the license of files with explicit MIT license header. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- slirp/src/util.h | 1 + slirp/src/arp_table.c | 1 + slirp/src/bootp.c | 1 + slirp/src/dnssearch.c | 1 + slirp/src/slirp.c

[Qemu-devel] [PATCH v4 7/8] slirp: remove reference to COPYRIGHT file

2019-03-22 Thread Marc-André Lureau
The slirp COPYRIGHT file is a BSD-3 license. Instead of referring to another project file, the SPDX license notice present in all source files states that unequivocally. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- slirp/src/debug.h | 3 --- slirp/src/if.h | 3 ---

[Qemu-devel] [PATCH v4 8/8] slirp: is not maintained by Kelly Price for a long time

2019-03-22 Thread Marc-André Lureau
slirp has been maintained by the QEMU maintainers and will be maintained under an independent project soon. Reviewed-by: Eric Blake Signed-off-by: Kelly Price Signed-off-by: Marc-André Lureau --- slirp/COPYRIGHT | 2 -- 1 file changed, 2 deletions(-) diff --git a/slirp/COPYRIGHT

[Qemu-devel] [PATCH v4 0/8] slirp: clarify license of slirp as BSD-3

2019-03-22 Thread Marc-André Lureau
Hi, In order to make slirp a standalone project, the project must have a clear license, and be compatible with the GPL or LGPL. Since commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove the advertising clause from the slirp license"), slirp is BSD-3. But new files have been added under

[Qemu-devel] [PATCH v4 2/8] slirp: relicense GPL files to BSD-3

2019-03-22 Thread Marc-André Lureau
In order to make slirp a standalone project, the project must have a clear license, and be compatible with the GPL or LGPL. Since commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove the advertising clause from the slirp license"), slirp is BSD-3. But new files have been added under slirp/

[Qemu-devel] [PATCH 0/3] target/arm: pmu fixes

2019-03-22 Thread Andrew Jones
The first two patches fix a regression I found when running the arm (as opposed to arm64) pmu kvm-unit-tests test on tcg, $ git clone git://git.kernel.org/pub/scm/virt/kvm/kvm-unit-tests.git $ cd kvm-unit-tests $ ./configure --arch=arm --cross-prefix=arm-linux-gnu- $ make -j $ export

[Qemu-devel] [PATCH 2/3] target/arm: cortex-a7 and cortex-a15 have pmus

2019-03-22 Thread Andrew Jones
cortex-a7 and cortex-a15 have pmus (PMUv2) and they advertise them in ID_DFR0. Let's allow them to function. This also enables the pmu cpu property to work with these cpu types, i.e. we can now do '-cpu cortex-a15,pmu=off' to remove the pmu. Signed-off-by: Andrew Jones --- target/arm/cpu.c | 3

Re: [Qemu-devel] [PATCH] qcow2: avoid lseek on block_status if possible

2019-03-22 Thread Vladimir Sementsov-Ogievskiy
25.01.2019 17:21, Vladimir Sementsov-Ogievskiy wrote: > drv_co_block_status digs bs->file for additional, more accurate search > for hole inside region, reported as DATA by bs since 5daa74a6ebc. > > This accuracy is not free: assume we have qcow2 disk. Actually, qcow2 > knows, where are holes and

Re: [Qemu-devel] [PATCH 0/5] trace-events: Clean up

2019-03-22 Thread Stefan Hajnoczi
On Thu, Mar 14, 2019 at 07:09:24PM +0100, Markus Armbruster wrote: > Markus Armbruster (5): > trace-events: Consistently point to docs/devel/tracing.txt > trace-events: Shorten file names in comments > scripts/cleanup-trace-events: Update for current practice > trace-events: Delete unused

[Qemu-devel] [PATCH 1/3] target/arm: fix crash on pmu register access

2019-03-22 Thread Andrew Jones
Fix a QEMU NULL derefence that occurs when the guest attempts to enable PMU counters with a non-v8 cpu model or a v8 cpu model which has not configured a PMU. Fixes: 4e7beb0cc0f3 ("target/arm: Add a timer to predict PMU counter overflow") Signed-off-by: Andrew Jones --- target/arm/helper.c | 4

[Qemu-devel] [PATCH 3/4] target/mips: Fix copy_u. for MIPS big endian host

2019-03-22 Thread Mateja Marjanovic
From: Mateja Marjanovic Unsigned element copy from MSA registers to GPR when executed on a MIPS big endian CPU, didn't pick the right element, and was behaving like on little endian. Signed-off-by: Mateja Marjanovic --- target/mips/msa_helper.c | 7 +++ 1 file changed, 7 insertions(+)

Re: [Qemu-devel] [PATCH 0/2] trace: fix compilation issues for QEMU 4.0.0

2019-03-22 Thread Stefan Hajnoczi
On Thu, Mar 21, 2019 at 05:08:29PM +, Stefan Hajnoczi wrote: > These patches fix compilation issues spotted by Markus Armbruster > . See the patches for details. > > Stefan Hajnoczi (2): > trace: handle tracefs path truncation > trace: avoid SystemTap dtrace(1) warnings on empty files >

[Qemu-devel] [PATCH 4/4] target/mips: Fix insert. for MIPS big endian host

2019-03-22 Thread Mateja Marjanovic
From: Mateja Marjanovic Inserting from GPR to an element in a MSA register when executed on a MIPS big endian CPU, didn't pick the right element, and was behaving like on little endian. Signed-off-by: Mateja Marjanovic --- target/mips/msa_helper.c | 9 + 1 file changed, 9

Re: [Qemu-devel] [PATCH] RISC-V: fix single stepping over ret and other branching instructions

2019-03-22 Thread Richard Henderson
On 3/22/19 4:22 AM, Fabien Chouteau wrote: > +/* Wrapper around tcg_gen_exit_tb that handles single stepping */ > +static void exit_tb(DisasContext *ctx, TranslationBlock *tb, unsigned idx) > +{ > +if (ctx->base.singlestep_enabled) { > +gen_exception_debug(); > +} else { > +

[Qemu-devel] [PATCH 2/4] target/mips: Fix copy_s. for MIPS big endian host

2019-03-22 Thread Mateja Marjanovic
From: Mateja Marjanovic Signed element copy from MSA registers to GPR when executed on a MIPS big endian CPU, didn't pick the right element, and was behaving like on little endian. Signed-off-by: Mateja Marjanovic --- target/mips/msa_helper.c | 7 +++ 1 file changed, 7 insertions(+) diff

[Qemu-devel] [PATCH 1/4] target/mips: Fix . MSA instructions for MIPS big endian host

2019-03-22 Thread Mateja Marjanovic
From: Mateja Marjanovic Load and store MSA instructions when executed on a MIPS big endian CPU, didn't change the endianness, and were behaving like on little endian. Signed-off-by: Mateja Marjanovic --- target/mips/op_helper.c | 79 ++--- 1 file

[Qemu-devel] [PATCH 0/4] target/mips: Add support for MSA instructions on a big endian host

2019-03-22 Thread Mateja Marjanovic
From: Mateja Marjanovic Change endianness when the host machine has a big endian CPU, for MSA instructions ., copy_., insert.. Mateja Marjanovic (4): target/mips: Fix . MSA instructions for MIPS big endian host target/mips: Fix copy_s. for MIPS big endian host target/mips: Fix copy_u.

Re: [Qemu-devel] [PATCH 1/2] iotests: 030 TestParallelOps non-shared base node

2019-03-22 Thread Alberto Garcia
On Thu 21 Mar 2019 03:51:12 PM CET, Alberto Garcia wrote: > I was checking the tests that run commit and stream in parallel in > 030, but they do commit on the upper images and stream on the lower > ones, so that's safe. I'll try to run them the other way around > because we might have a problem

Re: [Qemu-devel] [qemu-s390x] [PATCH] hw/s390x: fix clang compilation on 32bit machines

2019-03-22 Thread Halil Pasic
On Mon, 18 Mar 2019 22:08:50 +0100 Philippe Mathieu-Daudé wrote: > Le lun. 18 mars 2019 11:34, Marcel Apfelbaum a > écrit : > > > Hi Christian, > > > > On 3/18/19 11:27 AM, Christian Borntraeger wrote: > > > > > > On 16.03.19 12:09, Philippe Mathieu-Daudé wrote: > > >> Hi Marcel, > > >> > > >>

Re: [Qemu-devel] [PULL 0/5] x86 queue for -rc1

2019-03-22 Thread Peter Maydell
On Thu, 21 Mar 2019 at 19:36, Eduardo Habkost wrote: > > The following changes since commit 62a172e6a77d9072bb1a18f295ce0fcf4b90a4f2: > > Update version for v4.0.0-rc0 release (2019-03-19 17:17:22 +) > > are available in the Git repository at: > > git://github.com/ehabkost/qemu.git

Re: [Qemu-devel] [PATCH] migration: avoid copying ignore-shared ramblock when in incoming migration

2019-03-22 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Fri, 22 Mar 2019 at 10:12, Dr. David Alan Gilbert > wrote: > > Right, so in Catherine's patch there's a simple in_incoming_migration > > and checking ramblock_is_ignored > > Mmm, but I think it is in the wrong place. It is being checked > in

Re: [Qemu-devel] [PATCH for-4.0? 0/6] block: Fix slow pre-zeroing in qemu-img convert

2019-03-22 Thread Eric Blake
On 3/22/19 9:21 AM, Eric Blake wrote: > On 3/22/19 8:21 AM, Kevin Wolf wrote: >> If qemu-img convert sees that the target image isn't zero-initialised >> yet, it tries to do an efficient zero write for the whole image first >> to save the overhead of repeated explicit zero writes during the >>

[Qemu-devel] [PATCH 2/3] filemon: ensure watch IDs are unique to QFileMonitor scope

2019-03-22 Thread Daniel P . Berrangé
The watch IDs are mistakenly only unique within the scope of the directory being monitored. This is not useful for clients which are monitoring multiple directories. They require watch IDs to be unique globally within the QFileMonitor scope. Reviewed-by: Marc-André Lureau Tested-by: Bandan Das

[Qemu-devel] [PATCH 0/3] filemon: various fixes / improvements to file monitor for USB MTP

2019-03-22 Thread Daniel P . Berrangé
Previously posted in 2 separate pieces at https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04885.html https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg05833.html And a failed pull request https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg06035.html The last patch

Re: [Qemu-devel] [PATCH v8 05/16] gdbstub: add multiprocess support to vCont packets

2019-03-22 Thread Luc Michel
On 3/22/19 2:29 PM, Jan Kiszka wrote: > On 07.12.18 10:01, Luc Michel wrote: >> Add the gdb_first_attached_cpu() and gdb_next_attached_cpu() to iterate >> over all the CPUs in currently attached processes. >> >> Add the gdb_first_cpu_in_process() and gdb_next_cpu_in_process() to >> iterate over

Re: [Qemu-devel] [RFC PATCH] scripts/decodetree.py: Fix variable-length ISA

2019-03-22 Thread Yoshinori Sato
On Thu, 21 Mar 2019 10:43:37 +0900, Richard Henderson wrote: > > On 3/20/19 7:27 AM, Yoshinori Sato wrote: > > Hi. > > I found some problem in tested RX instructions. > > It is usable in RX instructions, but I think that there > > is a better fix because I am not familiar with Python. > > The

[Qemu-devel] [PATCH 3/3] filemon: fix watch IDs to avoid potential wraparound issues

2019-03-22 Thread Daniel P . Berrangé
Watch IDs are allocated from incrementing a int counter against the QFileMonitor object. In very long life QEMU processes with a huge amount of USB MTP activity creating & deleting directories it is just about conceivable that the int counter can wrap around. This would result in incorrect

Re: [Qemu-devel] [PATCH RFC v3 00/11] Add RX archtecture support

2019-03-22 Thread Yoshinori Sato
On Thu, 21 Mar 2019 10:35:07 +0900, Richard Henderson wrote: > > On 3/20/19 7:05 AM, Yoshinori Sato wrote: > > OK. fixed another way. > > But RX big-endian mode only data access. > > So operand value always little-endian order. > > Oh that is convenient. > Therefore the operand can always be put

[Qemu-devel] [PATCH 1/3] tests: refactor file monitor test to make it more understandable

2019-03-22 Thread Daniel P . Berrangé
The current file monitor unit tests are too clever for their own good making it hard to understand the desired output. Instead of trying to infer the expected events, explicitly list the events we expect in the operation sequence. Instead of dynamically building a matrix of tests, just have one

Re: [Qemu-devel] [PATCH v8 05/16] gdbstub: add multiprocess support to vCont packets

2019-03-22 Thread Jan Kiszka
On 22.03.19 15:01, Luc Michel wrote: On 3/22/19 2:29 PM, Jan Kiszka wrote: On 07.12.18 10:01, Luc Michel wrote: Add the gdb_first_attached_cpu() and gdb_next_attached_cpu() to iterate over all the CPUs in currently attached processes. Add the gdb_first_cpu_in_process() and

Re: [Qemu-devel] question about 9pfs fsdriver types

2019-03-22 Thread Greg Kurz
On Fri, 22 Mar 2019 11:57:04 +0200 "П, Алексей" wrote: > Hi there. Cannot find any info and examples about "proxy" and "handle" > types of fsdriver of virtfs. Can anyone advise me description of? > Witrh regards/ Hi, The "handle" backend was deprecated in QEMU 2.12, for various reasons...

Re: [Qemu-devel] [PATCH 0/6] block: Fix slow pre-zeroing in qemu-img convert

2019-03-22 Thread Eric Blake
On 3/22/19 8:21 AM, Kevin Wolf wrote: > If qemu-img convert sees that the target image isn't zero-initialised > yet, it tries to do an efficient zero write for the whole image first > to save the overhead of repeated explicit zero writes during the > conversion. Obviously, this provides only an

Re: [Qemu-devel] [RFC PATCH 0/2] implement the failover feature for assigned network devices

2019-03-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190322134447.14831-1-jfreim...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190322134447.14831-1-jfreim...@redhat.com Subject: [Qemu-devel] [RFC PATCH 0/2]

[Qemu-devel] [PATCH 1/6] block: Remove error messages in bdrv_make_zero()

2019-03-22 Thread Kevin Wolf
There is only a single caller of bdrv_make_zero(), which is qemu-img convert. If the function fails, we just fall back to a different method of zeroing out blocks on the target image. There is no good reason to print error messages on stderr when the higher level operation will actually succeed.

[Qemu-devel] [RFC PATCH 2/2] net/virtio: add failover support

2019-03-22 Thread Jens Freimann
From: Sameeh Jubran --- hw/net/virtio-net.c| 95 ++ include/hw/virtio/virtio-net.h | 7 +++ 2 files changed, 102 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 7e2c2a6f6a..880420a673 100644 --- a/hw/net/virtio-net.c +++

[Qemu-devel] [RFC PATCH 1/2] qdev/qbus: Add hidden device support

2019-03-22 Thread Jens Freimann
From: Sameeh Jubran Signed-off-by: Jens Freimann --- hw/core/qdev.c | 27 hw/pci/pci.c | 1 + include/hw/pci/pci.h | 2 ++ include/hw/qdev-core.h | 8 +++ qdev-monitor.c | 48 ++ vl.c

[Qemu-devel] [PATCH 3/6] block: Advertise BDRV_REQ_NO_FALLBACK in filter drivers

2019-03-22 Thread Kevin Wolf
Filter drivers that support .bdrv_co_pwrite_zeroes can safely advertise BDRV_REQ_NO_FALLBACK because they just forward the request flags to their child node. Signed-off-by: Kevin Wolf --- block/blkdebug.c | 2 +- block/copy-on-read.c | 7 +++ block/mirror.c | 3 ++-

[Qemu-devel] [PATCH 2/6] block: Add BDRV_REQ_NO_FALLBACK

2019-03-22 Thread Kevin Wolf
For qemu-img convert, we want an operation that zeroes out the whole image if this can be done efficiently, but that returns an error otherwise so we don't write explicit zeroes and immediately overwrite them with the real data, potentially doubling the amount of data to be written.

[Qemu-devel] [PATCH 5/6] qemu-img: Use BDRV_REQ_NO_FALLBACK for pre-zeroing

2019-03-22 Thread Kevin Wolf
If qemu-img convert sees that the target image isn't zero-initialised yet, it tries to do an efficient zero write for the whole image first to save the overhead of repeated explicit zero writes during the conversion. Obviously, this provides only an advantage if the pre-zeroing is actually

[Qemu-devel] [RFC PATCH 0/2] implement the failover feature for assigned network devices

2019-03-22 Thread Jens Freimann
This is another attempt at implementing the host side of the net_failover concept (https://www.kernel.org/doc/html/latest/networking/net_failover.html) The general idea is that we have a pair of devices, a vfio-pci and a emulated device. Before migration the vfio device is unplugged and data

Re: [Qemu-devel] [PATCH v1] exec: check the range in the address_space_unmap routine

2019-03-22 Thread Peter Maydell
On Fri, 22 Mar 2019 at 13:19, Dima Stepanov wrote: > > In case of the virtio-blk communication, can get the following assertion > for the specifically crafted virtio packet: > qemu-system-x86_64: exec.c:3725: address_space_unmap: Assertion `mr != > NULL' failed. > This assertion is triggered

[Qemu-devel] [PATCH 6/6] qemu-io: Add write -n for BDRV_REQ_NO_FALLBACK

2019-03-22 Thread Kevin Wolf
This makes the new BDRV_REQ_NO_FALLBACK flag available in the qemu-io write command. Signed-off-by: Kevin Wolf --- qemu-io-cmds.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index 35dcdcf413..09750a23ce 100644 ---

[Qemu-devel] [PATCH 0/6] block: Fix slow pre-zeroing in qemu-img convert

2019-03-22 Thread Kevin Wolf
If qemu-img convert sees that the target image isn't zero-initialised yet, it tries to do an efficient zero write for the whole image first to save the overhead of repeated explicit zero writes during the conversion. Obviously, this provides only an advantage if the pre-zeroing is actually

[Qemu-devel] [PATCH 4/6] file-posix: Support BDRV_REQ_NO_FALLBACK for zero writes

2019-03-22 Thread Kevin Wolf
We know that the kernel implements a slow fallback code path for BLKZEROOUT, so if BDRV_REQ_NO_FALLBACK is given, we shouldn't call it. The other operations we call in the context of .bdrv_co_pwrite_zeroes should usually be quick, so no modification should be needed for them. If we ever notice

Re: [Qemu-devel] [PATCH v8 05/16] gdbstub: add multiprocess support to vCont packets

2019-03-22 Thread Jan Kiszka
On 07.12.18 10:01, Luc Michel wrote: > Add the gdb_first_attached_cpu() and gdb_next_attached_cpu() to iterate > over all the CPUs in currently attached processes. > > Add the gdb_first_cpu_in_process() and gdb_next_cpu_in_process() to > iterate over CPUs of a given process. > > Use them to add

[Qemu-devel] [PATCH v1] exec: check the range in the address_space_unmap routine

2019-03-22 Thread Dima Stepanov
In case of the virtio-blk communication, can get the following assertion for the specifically crafted virtio packet: qemu-system-x86_64: exec.c:3725: address_space_unmap: Assertion `mr != NULL' failed. This assertion is triggered if the length of the first descriptor in the block request chain

[Qemu-devel] question about 9pfs fsdriver types

2019-03-22 Thread П , Алексей
Hi there. Cannot find any info and examples about "proxy" and "handle" types of fsdriver of virtfs. Can anyone advise me description of? Witrh regards/

Re: [Qemu-devel] [BUG] [low severity] a strange appearance of message involving slirp while doing "empty" make

2019-03-22 Thread Peter Maydell
On Fri, 22 Mar 2019 at 04:59, Thomas Huth wrote: > On 20/03/2019 22.08, Aleksandar Markovic wrote: > > $ make > > make[1]: Entering directory '/home/build/malta-mips64r6/qemu-4.0/slirp' > > make[1]: Nothing to be done for 'all'. > > make[1]: Leaving directory

Re: [Qemu-devel] [PATCH] acpi: verify file entries in bios_linker_loader_add_pointer()

2019-03-22 Thread Igor Mammedov
On Thu, 21 Mar 2019 20:13:49 + Liam Merwick wrote: > The callers to bios_linker_find_file() assert that the file entry returned > is not NULL, except for those in bios_linker_loader_add_pointer(). Add two > asserts in that case for completeness and to facilitate static code analysis. > >

  1   2   >