[Qemu-devel] [Bug 1812091] Re: gdbstub memory accesses performed with wrong attributes

2019-03-26 Thread Peter Maydell
This fix is now in git master and will be in the upcoming 4.0 QEMU release. ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1812091

[Qemu-devel] [Bug 1806824] Re: SIE-200 (TrustZone) MPC: BLK_MAX returns an incorrect value

2019-03-26 Thread Peter Maydell
This is now fixed in git master, in commit 619d54a8d854e797bf562, and will be in the upcoming 4.0 release. ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PULL 26/27] pc: Support firmware configuration with -blockdev

2019-03-26 Thread Laszlo Ersek
Hi Markus, (+Michal, Peter) On 03/11/19 23:08, Markus Armbruster wrote: > The PC machines put firmware in ROM by default. To get it put into > flash memory (required by OVMF), you have to use -drive > if=pflash,unit=0,... and optionally -drive if=pflash,unit=1,... > > Why two -drive? This

Re: [Qemu-devel] [PULL 0/2] target-arm queue

2019-03-26 Thread Peter Maydell
te-tracking branch > 'remotes/palmer/tags/riscv-for-master-4.0-rc1-v2' into staging (2019-03-26 > 10:27:20 +) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20190326 > > for you to fet

Re: [Qemu-devel] [PULL 0/2] Fixes 20190326 patches

2019-03-26 Thread Peter Maydell
in the Git repository at: > > git://git.kraxel.org/qemu tags/fixes-20190326-pull-request > > for you to fetch changes up to 339534d402524d75209df5d287464e17feb6941f: > > ati-vga: Fix indexed access to

Re: [Qemu-devel] [PULL 14/15] Migration/colo.c: Make user obtain the last COLO mode info after failover

2019-03-26 Thread Eric Blake
On 3/25/19 12:47 PM, Juan Quintela wrote: > From: Zhang Chen > > Add the last_colo_mode to save the status after failover. > This patch can solve the issue that user want to get last colo mode > use query_colo_status after failover. > > Signed-off-by: Zhang Chen > Reviewed-by: Juan Quintela >

[Qemu-devel] [Bug 1772075] Re: Segmentation fault on aarch64 vm at powerdown

2019-03-26 Thread Peter Maydell
Thanks for the repro instructions. I think this bug was fixed by commit 41b6513436d2ebb64c7d, which should be in QEMU version 3.0 or later. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [Bug 1772075] Re: Segmentation fault on aarch64 vm at powerdown

2019-03-26 Thread Peter Maydell
PS: if you can still reproduce with current QEMU please do let me know and I'll reopen the bug and investigate further. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1772075 Title: Segmentation

Re: [Qemu-devel] [multiprocess RFC PATCH 36/37] multi-process: add the concept description to docs/devel/qemu-multiprocess

2019-03-26 Thread Jag Raman
On 3/26/2019 4:08 AM, Stefan Hajnoczi wrote: On Fri, Mar 08, 2019 at 09:50:36AM +, Stefan Hajnoczi wrote: On Thu, Mar 07, 2019 at 03:29:41PM -0800, John G Johnson wrote: On Mar 7, 2019, at 11:27 AM, Stefan Hajnoczi wrote: On Thu, Mar 07, 2019 at 02:51:20PM +, Daniel P. Berrangé

Re: [Qemu-devel] [PATCH for 4.1 v2 10/13] tests: acpi: add simple arm/virt testcase

2019-03-26 Thread Laszlo Ersek
On 03/26/19 14:09, Igor Mammedov wrote: > adds simple arm/virt test case that starts guest with > bios-tables-test.aarch64.iso.qcow2 boot image which > initializes UefiTestSupport* structure in RAM once > guest is booted. > > * see commit: tests: acpi: add acpi_find_rsdp_address_uefi() helper >

Re: [Qemu-devel] [PATCH for 4.1 v2 08/13] tests: acpi: add a way to start tests with UEFI firmware

2019-03-26 Thread Laszlo Ersek
On 03/26/19 14:09, Igor Mammedov wrote: > For testcase to use UEFI firmware, one needs to provide and specify > firmwarei and varstore blobs names in test_data { uefi_fl1, uefi_fl2) } > fields respectively and RAM start address plus size where to look for > test structure signature. Additionally

Re: [Qemu-devel] [PATCH for 4.1 v2 09/13] tests: acpi: ignore SMBIOS tests when UEFI firmware is used

2019-03-26 Thread Laszlo Ersek
On 03/26/19 14:09, Igor Mammedov wrote: > once FW provides a pointer to SMBIOS entry point like it does for > RSDP it should be possible to enable this one the same way. > > Signed-off-by: Igor Mammedov > --- > tests/bios-tables-test.c | 7 +-- > 1 file changed, 5 insertions(+), 2

[Qemu-devel] [PATCH] target/riscv: Fix wrong expanding for c.fswsp

2019-03-26 Thread Kito Cheng
From: Kito Cheng base register is no rs1 not rs2 for fsw. Signed-off-by: Kito Cheng --- target/riscv/insn_trans/trans_rvc.inc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/insn_trans/trans_rvc.inc.c b/target/riscv/insn_trans/trans_rvc.inc.c index

Re: [Qemu-devel] QEMU and vIOMMU support for emulated VF passthrough to nested (L2) VM

2019-03-26 Thread Elijah Shakkour
Adding QEMU-devel -Original Message- From: Michael S. Tsirkin Sent: Tuesday, March 26, 2019 2:53 PM To: Elijah Shakkour Cc: Knut Omang ; Alex Williamson ; Marcel Apfelbaum ; Stefan Hajnoczi ; pet...@redhat.com Subject: Re: QEMU and vIOMMU support for emulated VF passthrough to nested

Re: [Qemu-devel] QEMU event loop optimizations

2019-03-26 Thread Paolo Bonzini
On 26/03/19 14:18, Stefan Hajnoczi wrote: > Hi Sergio, > Here are the forgotten event loop optimizations I mentioned: > > https://github.com/stefanha/qemu/commits/event-loop-optimizations > > The goal was to eliminate or reorder syscalls so that useful work (like > executing BHs) occurs as

[Qemu-devel] [Bug 1772075] Re: Segmentation fault on aarch64 vm at powerdown

2019-03-26 Thread FFO
You can reproduce the bug without any Linux image. you can quit Qemu (CTRL-A C quit) without the bug reported qemu-system-aarch64 -M virt -cpu cortex-a57 -nographic -net none -parallel none -bios QEMU_EFI.fd or generate the bug with: qemu-system-aarch64 -M virt -cpu cortex-a57 -nographic -net

[Qemu-devel] [Bug 1821430] Re: qemu-user-arm (4.0.0-rc0) crashes

2019-03-26 Thread Peter Maydell
I think this bug should be fixed by commit c8877d0f2f662bf01346a (which has just landed in git master and should be in rc1 when we tag it, probably later today). Please let us know if it hasn't fixed all the regressions for you. ** Changed in: qemu Status: New => Fix Committed -- You

[Qemu-devel] [PULL 1/2] ohci: don't die on ED_LINK_LIMIT overflow

2019-03-26 Thread Gerd Hoffmann
From: Laurent Vivier Stop processing the descriptor list instead. The next frame timer tick will resume the work Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1686705 Suggested-by: Gerd Hoffmann Signed-off-by: Laurent Vivier Message-id: 20190321085212.10796-1-lviv...@redhat.com

Re: [Qemu-devel] [PATCH v6 1/2] Add generic Nios II board.

2019-03-26 Thread Peter Maydell
On Thu, 21 Mar 2019 at 18:40, Sandra Loosemore wrote: > > This patch adds support for a generic MMU-less Nios II board that can > be used e.g. for bare-metal compiler testing with the linker script > and startup code provided by libgloss. Nios II booting is also > tweaked so that bare-metal

Re: [Qemu-devel] [PATCH for-4.0?] exec: Only count mapped memory backends for qemu_getrampagesize()

2019-03-26 Thread Igor Mammedov
On Tue, 26 Mar 2019 14:50:58 +1100 David Gibson wrote: > qemu_getrampagesize() works out the minimum host page size backing any of > guest RAM. This is required in a few places, such as for POWER8 PAPR KVM > guests, because limitations of the hardware virtualization mean the guest > can't use

[Qemu-devel] [PULL 2/2] ati-vga: Fix indexed access to video memory

2019-03-26 Thread Gerd Hoffmann
From: BALATON Zoltan Coverity (CID 1399700) found that this was wrong so instead of trying to do it by hand use existing access functions that should work better. Signed-off-by: BALATON Zoltan Message-id: 20190318223842.427cb745...@zero.eik.bme.hu Signed-off-by: Gerd Hoffmann ---

Re: [Qemu-devel] [PATCH v6 2/2] Add Nios II semihosting support.

2019-03-26 Thread Peter Maydell
On Thu, 21 Mar 2019 at 18:40, Sandra Loosemore wrote: > > This patch adds support for libgloss semihosting to Nios II bare-metal > emulation. The specification for the protocol can be found in the > libgloss sources. > > Signed-off-by: Sandra Loosemore > Signed-off-by: Julian Brown > ---

[Qemu-devel] [PULL 0/2] Fixes 20190326 patches

2019-03-26 Thread Gerd Hoffmann
The following changes since commit 4aef51963924fd58ffe88daebbe8055a360d7c10: Merge remote-tracking branch 'remotes/palmer/tags/riscv-for-master-4.0-rc1' into staging (2019-03-26 08:51:35 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/fixes-20190326-pull

Re: [Qemu-devel] [PATCH V2 4/4] hw/tpm: fix usage of bool in tpm-tis.c

2019-03-26 Thread Stefan Berger
On 3/24/19 3:41 PM, Thomas Huth wrote: On 23/03/2019 15.26, Jafar Abdi wrote: Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h. FALSE and TRUE (with capital letters) are the constants defined by glib for being used with the "gboolean" type of glib. But some parts

Re: [Qemu-devel] [RFC] arm/cpu: fix soft lockup panic after resuming from stop

2019-03-26 Thread Heyi Guo
I also tested save/restore operations, and observed that clock in guest would not jump after restoring either. If we consider guest clock not being synchronized with real wall clock as an issue, does it mean save/restore function has the same issue? Thanks, Heyi On 2019/3/26 19:54, Heyi

Re: [Qemu-devel] [PATCH 1/2] target/arm: Put system registers in "system" group

2019-03-26 Thread Peter Maydell
On Thu, 7 Mar 2019 at 20:12, Richard Henderson wrote: > > The system group is predefined within gdb. While the spec > seems to allow arbitrary group names, that seems to mess up > the addition of all registers to any groups. > > Signed-off-by: Richard Henderson > --- > target/arm/gdbstub.c | 2

Re: [Qemu-devel] [PATCH v3 0/4] target/arm: Implement ARMv8.5-BTI

2019-03-26 Thread Peter Maydell
On Mon, 4 Feb 2019 at 13:12, Richard Henderson wrote: > > One fixup to the set of patches applied to target-arm.next. > One adjustment to what is now patch 3 wrt EXCP_SEMIHOST. > > > r~ > > > Richard Henderson (4): > fixup! target/arm: Cache the GP bit for a page in MemTxAttrs > target/arm:

Re: [Qemu-devel] [PATCH] Categorize devices

2019-03-26 Thread Stefan Berger
On 3/24/19 2:05 PM, Ernest Esene wrote: Categorize devices in "uncategorised devices" section This patch is based on BiteSizedTask. Signed-off-by: Ernest Esene TPM part: Reviewed-by: Stefan Berger --- hw/dma/i82374.c | 2 ++ hw/i386/amd_iommu.c | 2 ++

Re: [Qemu-devel] [PATCH 2/2] target/arm: Don't add system-registers.xml for user-only

2019-03-26 Thread Peter Maydell
On Thu, 7 Mar 2019 at 20:12, Richard Henderson wrote: > > The system registers aren't that interesting for debugging > user binaries. Avoid adding them in this case. > > Signed-off-by: Richard Henderson I think a better approach would be to arrange to only expose to the gdbstub for linux-user

Re: [Qemu-devel] [PATCH 2/9] tcg: Add INDEX_op_extract2_{i32,i64}

2019-03-26 Thread Peter Maydell
On Tue, 26 Mar 2019 at 13:35, Peter Maydell wrote: > > On Thu, 7 Mar 2019 at 14:47, Richard Henderson > wrote: > > > > This will let backends implement the double-word shift operation. > > > > Signed-off-by: Richard Henderson > > diff --git a/tcg/README b/tcg/README > > index

Re: [Qemu-devel] QEMU event loop optimizations

2019-03-26 Thread Paolo Bonzini
On 26/03/19 14:18, Stefan Hajnoczi wrote: > Hi Sergio, > Here are the forgotten event loop optimizations I mentioned: > > https://github.com/stefanha/qemu/commits/event-loop-optimizations > > The goal was to eliminate or reorder syscalls so that useful work (like > executing BHs) occurs as

Re: [Qemu-devel] [PATCH 2/9] tcg: Add INDEX_op_extract2_{i32,i64}

2019-03-26 Thread Peter Maydell
On Thu, 7 Mar 2019 at 14:47, Richard Henderson wrote: > > This will let backends implement the double-word shift operation. > > Signed-off-by: Richard Henderson > diff --git a/tcg/README b/tcg/README > index 603f4df659..ddabf33017 100644 > --- a/tcg/README > +++ b/tcg/README > @@ -343,6 +343,11

Re: [Qemu-devel] [PATCH 8/9] target/arm: Use extract2 for EXTR

2019-03-26 Thread Peter Maydell
On Thu, 7 Mar 2019 at 14:41, Richard Henderson wrote: > > This is, after all, how we implement extract2 in tcg/aarc64. "aarch64". > > Cc: qemu-...@nongnu.org > Cc: Peter Maydell > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 38 --

[Qemu-devel] [PATCH for 4.1 v2 00/13] tests: acpi: add UEFI (ARM) testing support

2019-03-26 Thread Igor Mammedov
Changelog: - from v1: * rebase on top (1) [PATCH for-4.1 v3 00/12] bundle edk2 platform firmware with QEMU let me to drop edk2 images and drop Makefile magic to unpack them, Laszlo's series conveniently does it all for me. * use new path/names for firmware

[Qemu-devel] [PATCH for 4.1 v2 01/13] tests: acpi: make RSDT test routine handle XSDT

2019-03-26 Thread Igor Mammedov
If RSDP revision is more than 0 fetch table pointed by XSDT and fallback to legacy RSDT table otherwise. While at it drop unused acpi_get_xsdt_address(). Signed-off-by: Igor Mammedov --- PS: it doesn't affect existing pc/q35 machines as they use RSDP.revision == 0 but it will be used by

Re: [Qemu-devel] About making QEMU to LIBs!

2019-03-26 Thread Paolo Bonzini
On 26/03/19 12:38, Yang Zhong wrote: > On Tue, Mar 26, 2019 at 10:07:35AM +0100, Paolo Bonzini wrote: >> Would separate QEMU binaries be a solution? I think I am not as opposed >> to a "q35-lite" machine type these days, I find it preferrable to share >> the northbridge and southbridge with Q35

Re: [Qemu-devel] [PATCH 0/2] kconfig: add fine-grained dependencies for MSI

2019-03-26 Thread Paolo Bonzini
On 26/03/19 13:57, Michael S. Tsirkin wrote: > On Thu, Mar 14, 2019 at 03:30:30PM +0100, Paolo Bonzini wrote: >> RISC-V targets did not include PCIe ports before the Kconfig transition, >> and grew them afterwards, but they are nonfunctional because the interrupt >> controller does not support

[Qemu-devel] [PATCH for 4.1 v2 03/13] tests: acpi: make pointer to RSDP 64bit

2019-03-26 Thread Igor Mammedov
In case of UEFI, RSDP doesn't have to be located in lowmem, it could be placed at any address. Make sure that test won't break if it is placed above the first 4Gb of address space. PS: While at it cleanup some local variables as we don't really need them. Signed-off-by: Igor Mammedov

[Qemu-devel] [PATCH for 4.1 v2 04/13] tests: acpi: fetch X_DSDT if pointer to DSDT is 0

2019-03-26 Thread Igor Mammedov
that way it would be possible to test a DSDT pointed by 64bit X_DSDT field in FADT. PS: it will allow to enable testing arm/virt board, which sets only newer X_DSDT field. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- v2: add 'val = le32_to_cpu(val)' even if it doesn't

[Qemu-devel] [PATCH for 4.1 v2 05/13] tests: acpi: skip FACS table if board uses hw reduced ACPI profile

2019-03-26 Thread Igor Mammedov
If FADT has HW_REDUCED_ACPI flag set, do not attempt to fetch FACS as it's not provided by the board. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- tests/bios-tables-test.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH for 4.1 v2 02/13] tests: acpi: rename acpi_parse_rsdp_table() into acpi_fetch_rsdp_table()

2019-03-26 Thread Igor Mammedov
so name would reflect what the function does Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- tests/acpi-utils.h | 2 +- tests/acpi-utils.c | 2 +- tests/bios-tables-test.c | 2 +- tests/vmgenid-test.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)

[Qemu-devel] [PULL 0/2] target-arm queue

2019-03-26 Thread Peter Maydell
+) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20190326 for you to fetch changes up to c99ef792dc9ec6d8a5061428faf396ea9ceb8f57: gdbstub: fix vCont packet handling when no thread is specified (2019-03-26 12:53:26

[Qemu-devel] [PATCH for 4.1 v2 07/13] tests: acpi: add acpi_find_rsdp_address_uefi() helper

2019-03-26 Thread Igor Mammedov
introduce UEFI specific counterpart to acpi_find_rsdp_address() that will help to find RSDP address when [OA]VMF is used as firmware. It requires guest firmware or other guest app to place 1Mb aligned UefiTestSupport structure (defined in this patch) in RAM with UefiTestSupport::signature_guid set

[Qemu-devel] [PATCH for 4.1 v2 08/13] tests: acpi: add a way to start tests with UEFI firmware

2019-03-26 Thread Igor Mammedov
For testcase to use UEFI firmware, one needs to provide and specify firmwarei and varstore blobs names in test_data { uefi_fl1, uefi_fl2) } fields respectively and RAM start address plus size where to look for test structure signature. Additionally testcase should specify bootable cdrom image

[Qemu-devel] [PULL 1/2] target/arm: Set SIMDMISC and FPMISC for 32-bit -cpu max

2019-03-26 Thread Peter Maydell
From: Richard Henderson Fixes: https://bugs.launchpad.net/bugs/1821430 Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Message-id: 20190325161338.6536-1-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/cpu.c | 5 + 1

[Qemu-devel] [PATCH for 4.1 v2 06/13] tests: acpi: move boot_sector_init() into x86 tests branch

2019-03-26 Thread Igor Mammedov
boot_sector_init() won't be used by arm/virt board, so move it from global scope to x86 branch that uses it. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- tests/bios-tables-test.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH for 4.1 v2 10/13] tests: acpi: add simple arm/virt testcase

2019-03-26 Thread Igor Mammedov
adds simple arm/virt test case that starts guest with bios-tables-test.aarch64.iso.qcow2 boot image which initializes UefiTestSupport* structure in RAM once guest is booted. * see commit: tests: acpi: add acpi_find_rsdp_address_uefi() helper Signed-off-by: Igor Mammedov --- v3: * use

[Qemu-devel] [PATCH for 4.1 v2 12/13] tests: acpi: print error unable to dump ACPI table during rebuild

2019-03-26 Thread Igor Mammedov
Instead of just asserting print the error that lead to assert first. While at it move assert into rebuild branch, which removes reduntant check done in case of !rebuild branch is taken (the later is taken care of by g_assert_no_error). Signed-off-by: Igor Mammedov --- tests/bios-tables-test.c |

[Qemu-devel] [PULL 2/2] gdbstub: fix vCont packet handling when no thread is specified

2019-03-26 Thread Peter Maydell
From: Luc Michel The vCont packet accepts a series of actions, each being applied on a given thread ID. Giving no thread ID for an action is valid and means "all threads". This commit fixes vCont packets being incorrectly rejected when no thread ID was given for an action. In multiprocess

[Qemu-devel] [PATCH for 4.1 v2 11/13] tests: acpi: refactor rebuild-expected-aml.sh to dump ACPI tables for a specified list of targets

2019-03-26 Thread Igor Mammedov
Make initial list contain aarch64 and x86_64 targets. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- v2: * fix up error message (Philippe Mathieu-Daudé ) --- tests/data/acpi/rebuild-expected-aml.sh | 23 +++ 1 file changed, 11 insertions(+), 12

[Qemu-devel] [PATCH for 4.1 v2 09/13] tests: acpi: ignore SMBIOS tests when UEFI firmware is used

2019-03-26 Thread Igor Mammedov
once FW provides a pointer to SMBIOS entry point like it does for RSDP it should be possible to enable this one the same way. Signed-off-by: Igor Mammedov --- tests/bios-tables-test.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/bios-tables-test.c

[Qemu-devel] [PATCH for 4.1 v2 13/13] tests: add expected ACPI tables for arm/virt board

2019-03-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- tests/data/acpi/virt/APIC | Bin 0 -> 168 bytes tests/data/acpi/virt/DSDT | Bin 0 -> 18476 bytes tests/data/acpi/virt/FACP | Bin 0 -> 268 bytes tests/data/acpi/virt/GTDT | Bin 0 -> 96 bytes tests/data/acpi/virt/MCFG | Bin 0 -> 60 bytes

[Qemu-devel] QEMU event loop optimizations

2019-03-26 Thread Stefan Hajnoczi
Hi Sergio, Here are the forgotten event loop optimizations I mentioned: https://github.com/stefanha/qemu/commits/event-loop-optimizations The goal was to eliminate or reorder syscalls so that useful work (like executing BHs) occurs as soon as possible after an event is detected. I remember

Re: [Qemu-devel] [PATCH 0/2] kconfig: add fine-grained dependencies for MSI

2019-03-26 Thread Michael S. Tsirkin
On Thu, Mar 14, 2019 at 03:30:30PM +0100, Paolo Bonzini wrote: > RISC-V targets did not include PCIe ports before the Kconfig transition, > and grew them afterwards, but they are nonfunctional because the interrupt > controller does not support MSI. This patch restores the situation prior to >

[Qemu-devel] [PATCH v2 3/4] hw/rdma: Modify create/destroy QP to support SRQ

2019-03-26 Thread Kamal Heib
Modify create/destroy QP to support shared receive queue. Signed-off-by: Kamal Heib --- hw/rdma/rdma_backend.c | 9 -- hw/rdma/rdma_backend.h | 6 ++-- hw/rdma/rdma_rm.c| 23 +-- hw/rdma/rdma_rm.h| 3 +- hw/rdma/rdma_rm_defs.h | 1 +

[Qemu-devel] [PATCH v2 2/4] hw/rdma: Add support for managing SRQ resource

2019-03-26 Thread Kamal Heib
Adding the required functions and definitions for support managing the shared receive queues (SRQs). Signed-off-by: Kamal Heib --- hw/rdma/rdma_rm.c | 83 ++ hw/rdma/rdma_rm.h | 10 + hw/rdma/rdma_rm_defs.h | 8 3 files changed, 101

[Qemu-devel] [PATCH v2 4/4] hw/pvrdma: Add support for SRQ

2019-03-26 Thread Kamal Heib
Implement the pvrdma device commands for supporting SRQ Signed-off-by: Kamal Heib --- hw/rdma/vmw/pvrdma_cmd.c| 147 hw/rdma/vmw/pvrdma_main.c | 16 hw/rdma/vmw/pvrdma_qp_ops.c | 46 ++- hw/rdma/vmw/pvrdma_qp_ops.h | 1 + 4 files

[Qemu-devel] [PATCH v2 1/4] hw/rdma: Add SRQ support to backend layer

2019-03-26 Thread Kamal Heib
Add the required function and definitions for support shared receive queues (SRQs) in the backend layer. Signed-off-by: Kamal Heib --- hw/rdma/rdma_backend.c | 116 +++- hw/rdma/rdma_backend.h | 12 hw/rdma/rdma_backend_defs.h | 5 ++ 3 files

[Qemu-devel] [PATCH v2 0/4] pvrdma: Add support for SRQ

2019-03-26 Thread Kamal Heib
This series implements the SRQ (Shared Receive Queue) for the pvrdma device, It also includes all the needed functions and definitions for support SRQ in the backend and resource management layers. Changes from v1->v2: - Handle checkpatch.pl warnings. Kamal Heib (4): hw/rdma: Add SRQ support

Re: [Qemu-devel] [PATCH V2 RFT] vhost_net: don't set backend for the uninitialized virtqueue

2019-03-26 Thread Michael S. Tsirkin
On Tue, Mar 26, 2019 at 02:59:19PM +0800, Jason Wang wrote: > > On 2019/3/25 下午8:32, Michael S. Tsirkin wrote: > > On Mon, Mar 25, 2019 at 11:56:13AM +0800, Jason Wang wrote: > > > We used to set backend unconditionally, this won't work for some > > > guests (e.g windows driver) who may not

Re: [Qemu-devel] [PATCH RFC v4 01/12] target/rx: TCG translation

2019-03-26 Thread Yoshinori Sato
On Tue, 26 Mar 2019 00:50:53 +0900, Richard Henderson wrote: > > On 3/25/19 2:38 AM, Yoshinori Sato wrote: > >>> +static bool trans_EMUL_mr(DisasContext *ctx, arg_EMUL_mr *a) > >>> +{ > >>> +TCGv val, mem; > >>> +mem = tcg_temp_new(); > >>> +val = rx_load_source(ctx, mem, a->ld,

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 01/15] s390 vfio-ccw: Add bootindex property and IPLB data

2019-03-26 Thread Thomas Huth
On 13/03/2019 17.31, Jason J. Herne wrote: > Add bootindex property and iplb data for vfio-ccw devices. This allows us to > forward boot information into the bios for vfio-ccw devices. > > Refactor s390_get_ccw_device() to return device type. This prevents us from > having to use messy casting

Re: [Qemu-devel] [PATCH] migration/block-dirty-bitmap: Silence coverity CID 1390625

2019-03-26 Thread Peter Maydell
On Fri, 16 Nov 2018 at 18:43, John Snow wrote: > > Coverity warns that backing_bs() could give us a NULL pointer, which > we then use without checking that it isn't. > > In our loop condition, we check bs && bs->drv as a point of habit, but > by nature of the block graph, we cannot have null bs

Re: [Qemu-devel] [PULL 05/15] multifd: Be flexible about packet size

2019-03-26 Thread Peter Maydell
On Mon, 25 Mar 2019 at 18:13, Juan Quintela wrote: > > This way we can change the packet size in the future and everything > will work. We choose an arbitrary big number (100 times configured > size) as a limit about how big we will reallocate. > > Signed-off-by: Juan Quintela > Reviewed-by:

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 10/15] s390-bios: Support for running format-0/1 channel programs

2019-03-26 Thread Thomas Huth
On 13/03/2019 17.31, Jason J. Herne wrote: > Introduce a library function for executing format-0 and format-1 > channel programs and waiting for their completion before continuing > execution. > > Add cu_type() to channel io library. This will be used to query control > unit type which is used to

Re: [Qemu-devel] [RFC] arm/cpu: fix soft lockup panic after resuming from stop

2019-03-26 Thread Heyi Guo
Hi Steven, Thanks for your explanation. Please see my comments below. On 2019/3/21 0:29, Steven Price wrote: On 19/03/2019 14:39, Heyi Guo wrote: Hi Christoffer and Steve, On 2019/3/15 16:59, Christoffer Dall wrote: Hi Steve, On Wed, Mar 13, 2019 at 10:11:30AM +, Steven Price wrote:

Re: [Qemu-devel] About making QEMU to LIBs!

2019-03-26 Thread Yang Zhong
On Tue, Mar 26, 2019 at 10:07:35AM +0100, Paolo Bonzini wrote: > On 26/03/19 08:00, Xiao Guangrong wrote: > > On 3/26/19 7:18 AM, Paolo Bonzini wrote: > >> Also, what is the use case?  Is it to reduce the attack surface without > >> having multiple QEMU binaries? > > > > Security is one story we

Re: [Qemu-devel] [Qemu-block] [PATCH] thread-pool: Use an EventNotifier to coordinate with AioContext

2019-03-26 Thread Sergio Lopez
Stefan Hajnoczi writes: > On Mon, Mar 25, 2019 at 02:34:36PM +0100, Sergio Lopez wrote: >> Our current ThreadPool implementation lacks support for AioContext's >> event notifications. This not only means that it can't take advantage >> from the IOThread's adaptive polling, but also that the

Re: [Qemu-devel] [PATCH v2 1/7] target/mips: Fix . MSA instructions for MIPS big endian host

2019-03-26 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Subject: Re: [PATCH v2 1/7] target/mips: Fix . MSA > instructions for MIPS big endian host > > > From: Mateja Marjanovic > > Subject: Re: [PATCH v2 1/7] target/mips: Fix . MSA > > instructions for MIPS big endian host > > On 25.3.19. 22:21, Aleksandar Markovic

Re: [Qemu-devel] [PATCH] ati-vga: Fix indexed access to video memory

2019-03-26 Thread Gerd Hoffmann
On Mon, Mar 18, 2019 at 11:34:46PM +0100, BALATON Zoltan wrote: > Coverity (CID 1399700) found that this was wrong so instead of trying > to do it by hand use existing access functions that should work better. Added to patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH] ohci: don't die on ED_LINK_LIMIT overflow

2019-03-26 Thread Gerd Hoffmann
On Thu, Mar 21, 2019 at 09:52:12AM +0100, Laurent Vivier wrote: > Stop processing the descriptor list instead. The next frame timer tick will > resume the work > > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1686705 > Suggested-by: Gerd Hoffmann > Signed-off-by: Laurent Vivier Added

Re: [Qemu-devel] [PATCH v2 1/7] target/mips: Fix . MSA instructions for MIPS big endian host

2019-03-26 Thread Aleksandar Markovic
> From: Mateja Marjanovic > Subject: Re: [PATCH v2 1/7] target/mips: Fix . MSA > instructions for MIPS big endian host > On 25.3.19. 22:21, Aleksandar Markovic wrote: >> From: Mateja Marjanovic >> Subject: [PATCH v2 1/7] target/mips: Fix . MSA instructions >> for MIPS big endian host >> Please

Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: use variable size of flash device to save memory

2019-03-26 Thread Laszlo Ersek
On 03/26/19 07:17, Markus Armbruster wrote: > Zheng Xiang writes: > >> Hi Peter, >> >> Thanks for your reply! >> >> On 2019/3/25 21:11, Peter Maydell wrote: >>> On Mon, 25 Mar 2019 at 12:53, Xiang Zheng wrote: Currently we fill the VIRT_FLASH space with two 64MB NOR images when

Re: [Qemu-devel] [PULL] A second RISC-V Patch for 4.0.0-rc1

2019-03-26 Thread Peter Maydell
On Tue, 26 Mar 2019 at 10:25, Palmer Dabbelt wrote: > > merged tag 'riscv-for-master-4.0-rc1' > The following changes since commit 4aef51963924fd58ffe88daebbe8055a360d7c10: > > Merge remote-tracking branch 'remotes/palmer/tags/riscv-for-master-4.0-rc1' > into staging (2019-03-26 08:51:35

Re: [Qemu-devel] [PATCH 1/2] usb-mtp: remove usb_mtp_object_free_one

2019-03-26 Thread Peter Maydell
On Tue, 19 Mar 2019 at 21:46, Bandan Das wrote: > > This function is used in the delete path only and can > be replaced by a call to usb_mtp_object_free. > > Signed-off-by: Bandan Das > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH 2/2] usb-mtp: refactor the flow of usb_mtp_write_data

2019-03-26 Thread Peter Maydell
On Tue, 19 Mar 2019 at 21:46, Bandan Das wrote: > > There's no functional change but the flow is (hopefully) > more consistent for both file and folder object types. > > Signed-off-by: Bandan Das > --- > hw/usb/dev-mtp.c | 58 +--- > 1 file changed,

Re: [Qemu-devel] [PATCH for-4.0] gdbstub: fix vCont packet handling when no thread is specified

2019-03-26 Thread Peter Maydell
On Mon, 25 Mar 2019 at 11:05, Luc Michel wrote: > > The vCont packet accepts a series of actions, each being applied on a > given thread ID. Giving no thread ID for an action is valid and means > "all threads". > > This commit fixes vCont packets being incorrectly rejected when no > thread ID was

Re: [Qemu-devel] [PATCH] target/arm: Set SIMDMISC and FPMISC for 32-bit -cpu max

2019-03-26 Thread Peter Maydell
On Mon, 25 Mar 2019 at 16:13, Richard Henderson wrote: > > Fixes: https://bugs.launchpad.net/bugs/1821430 > Signed-off-by: Richard Henderson > --- > target/arm/cpu.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/target/arm/cpu.c b/target/arm/cpu.c > index 96f0ff0ec7..d9b8658921

Re: [Qemu-devel] [PATCH] RFC: build-sys: move slirp as git submodule project

2019-03-26 Thread Daniel P . Berrangé
On Tue, Mar 26, 2019 at 06:39:40AM +, Peter Maydell wrote: > On Mon, 25 Mar 2019 at 18:51, Eric Blake wrote: > > On 3/25/19 1:04 PM, Marc-André Lureau wrote: > > > RFC: is this acceptable during freeze? (not a feature or code change) > > > > It's a big enough change that I'd personally feel

Re: [Qemu-devel] [PATCH 4/4] build: don't build hardware objects with linux-user

2019-03-26 Thread Paolo Bonzini
On 26/03/19 10:35, Laurent Vivier wrote: > The change was based on the comments in the file. Right, but the comments do not imply that crypto is being built in the user-only case. In fact, only char/ is being built for --disable-system --disable-tools, and even that is because: 1)

Re: [Qemu-devel] [PULL 0/2] Pflash and firmware configuration patches for 2019-03-26

2019-03-26 Thread Peter Maydell
On Tue, 26 Mar 2019 at 09:10, Markus Armbruster wrote: > > The following changes since commit d132baa05ed7a647067c807fd452ec794cc2ecb7: > > Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' > into staging (2019-03-25 17:01:10 +) > > are available in the Git

[Qemu-devel] [PULL] A second RISC-V Patch for 4.0.0-rc1

2019-03-26 Thread Palmer Dabbelt
merged tag 'riscv-for-master-4.0-rc1' The following changes since commit 4aef51963924fd58ffe88daebbe8055a360d7c10: Merge remote-tracking branch 'remotes/palmer/tags/riscv-for-master-4.0-rc1' into staging (2019-03-26 08:51:35 +) are available in the Git repository at:

[Qemu-devel] [PULL] target/riscv: Fix wrong expanding for c.fswsp

2019-03-26 Thread Palmer Dabbelt
From: Kito Cheng base register is no rs1 not rs2 for fsw. Signed-off-by: Kito Cheng Reviewed-by: Palmer Dabbelt Signed-off-by: Palmer Dabbelt --- target/riscv/insn_trans/trans_rvc.inc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH] target/ppc: Improve comment of bcctr used for spectre v2 mitigation

2019-03-26 Thread Greg Kurz
Signed-off-by: Greg Kurz --- target/ppc/translate.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 576210d901ad..badc1ae1a35d 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -3753,7

Re: [Qemu-devel] [PATCH] target/arm: Set SIMDMISC and FPMISC for 32-bit -cpu max

2019-03-26 Thread Alex Bennée
Richard Henderson writes: > Fixes: https://bugs.launchpad.net/bugs/1821430 > Signed-off-by: Richard Henderson > --- > target/arm/cpu.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/target/arm/cpu.c b/target/arm/cpu.c > index 96f0ff0ec7..d9b8658921 100644 > ---

[Qemu-devel] [Bug 1821006] Re: qemu: Unsupported syscall: 382

2019-03-26 Thread Alexey Gavrilov
Unfortunately I was only able to check in 3.1. There is no problem with the call. root@unit6:/mnt/build/chroot# dpkg -l | grep qemu-user-static ii qemu-user-static 1:3.1+dfsg-5amd64QEMU user mode emulation

Re: [Qemu-devel] [PULL 0/4] Miscellaneous patches for 2019-03-26

2019-03-26 Thread Peter Maydell
On Tue, 26 Mar 2019 at 07:16, Markus Armbruster wrote: > > The following changes since commit d132baa05ed7a647067c807fd452ec794cc2ecb7: > > Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' > into staging (2019-03-25 17:01:10 +) > > are available in the Git

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 4/6] target/ppc: Build rtas error log

2019-03-26 Thread Greg Kurz
On Tue, 26 Mar 2019 14:45:57 +0530 Aravinda Prasad wrote: > On Tuesday 26 March 2019 02:00 PM, Greg Kurz wrote: > > On Tue, 26 Mar 2019 10:32:35 +1100 > > David Gibson wrote: > > > >> On Mon, Mar 25, 2019 at 01:56:50PM +0530, Aravinda Prasad wrote: > >>> > >>> > >>> On Monday 25 March 2019

Re: [Qemu-devel] [Qemu-block] [PATCH] block/vhdx: Use IEC binary prefixes from "qemu/units.h"

2019-03-26 Thread Stefano Garzarella
On Tue, Mar 26, 2019 at 10:13:54AM +0100, Kevin Wolf wrote: > Am 26.03.2019 um 08:55 hat Stefano Garzarella geschrieben: > > On Mon, Mar 25, 2019 at 10:56:57PM +0100, Philippe Mathieu-Daudé wrote: > > > Le lun. 25 mars 2019 21:53, John Snow a écrit : > > > > On 3/21/19 5:40 AM, Stefano Garzarella

Re: [Qemu-devel] [PATCH 4/4] build: don't build hardware objects with linux-user

2019-03-26 Thread Laurent Vivier
On 26/03/2019 10:00, Paolo Bonzini wrote: > On 21/03/19 13:46, Laurent Vivier wrote: >> + >> +ifneq ($(CONFIG_USER_ONLY),y) >> ### >> # authz-obj-y is code used by both qemu system emulation and qemu-img >> >> @@ -21,21 +27,11

Re: [Qemu-devel] [Qemu-block] [PATCH] block/vhdx: Use IEC binary prefixes from "qemu/units.h"

2019-03-26 Thread Philippe Mathieu-Daudé
Le mar. 26 mars 2019 10:14, Kevin Wolf a écrit : > Am 26.03.2019 um 08:55 hat Stefano Garzarella geschrieben: > > On Mon, Mar 25, 2019 at 10:56:57PM +0100, Philippe Mathieu-Daudé wrote: > > > Le lun. 25 mars 2019 21:53, John Snow a écrit : > > > > On 3/21/19 5:40 AM, Stefano Garzarella wrote: >

Re: [Qemu-devel] [PULL] A Single RISC-V Patch for 4.0-rc1

2019-03-26 Thread Peter Maydell
On Tue, 26 Mar 2019 at 06:54, Palmer Dabbelt wrote: > > The following changes since commit 62a172e6a77d9072bb1a18f295ce0fcf4b90a4f2: > > Update version for v4.0.0-rc0 release (2019-03-19 17:17:22 +) > > are available in the Git repository at: > > git://github.com/palmer-dabbelt/qemu.git

Re: [Qemu-devel] About making QEMU to LIBs!

2019-03-26 Thread Xiao Guangrong
On 3/26/19 5:07 PM, Paolo Bonzini wrote: On 26/03/19 08:00, Xiao Guangrong wrote: On 3/26/19 7:18 AM, Paolo Bonzini wrote: Also, what is the use case?  Is it to reduce the attack surface without having multiple QEMU binaries? Security is one story we concern, only the essential and

Re: [Qemu-devel] [Qemu-block] [PATCH] block/vhdx: Use IEC binary prefixes from "qemu/units.h"

2019-03-26 Thread Kevin Wolf
Am 26.03.2019 um 08:55 hat Stefano Garzarella geschrieben: > On Mon, Mar 25, 2019 at 10:56:57PM +0100, Philippe Mathieu-Daudé wrote: > > Le lun. 25 mars 2019 21:53, John Snow a écrit : > > > On 3/21/19 5:40 AM, Stefano Garzarella wrote: > > > > IEC binary prefixes are defined in "qemu/units.h",

Re: [Qemu-devel] About making QEMU to LIBs!

2019-03-26 Thread Stefan Hajnoczi
On Tue, Mar 26, 2019 at 03:00:05PM +0800, Xiao Guangrong wrote: > On 3/26/19 7:18 AM, Paolo Bonzini wrote: > > On 25/03/19 12:46, Yang Zhong wrote: > > > Hello all, > > > > > > Rust-VMM has started to make all features and common modules to crates, > > > and CSP can > > > deploy their VMM on

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 4/6] target/ppc: Build rtas error log

2019-03-26 Thread Aravinda Prasad
On Tuesday 26 March 2019 02:00 PM, Greg Kurz wrote: > On Tue, 26 Mar 2019 10:32:35 +1100 > David Gibson wrote: > >> On Mon, Mar 25, 2019 at 01:56:50PM +0530, Aravinda Prasad wrote: >>> >>> >>> On Monday 25 March 2019 12:00 PM, David Gibson wrote: On Fri, Mar 22, 2019 at 12:04:07PM

Re: [Qemu-devel] [PATCH 2/4] ui: build keymap only with softmmu targets

2019-03-26 Thread Paolo Bonzini
On 26/03/19 10:04, Laurent Vivier wrote: > On 26/03/2019 09:44, Paolo Bonzini wrote: >> On 21/03/19 13:46, Laurent Vivier wrote: >>> we don't need to generate the files for linux-user or for the tools >>> >>> Signed-off-by: Laurent Vivier >>> --- >>> Makefile | 2 ++ >>> 1 file changed, 2

Re: [Qemu-devel] [PATCH] Replace calls to object_child_foreach() with object_child_foreach_recursive()

2019-03-26 Thread Paolo Bonzini
On 26/03/19 08:43, Stefan Hajnoczi wrote: > On Sun, Mar 10, 2019 at 02:39:13AM +0100, Ernest Esene wrote: >> Replace calls to object_child_foreach() with object_child_foreach_recursive() >> when applicable: nvdimm_device_list, nmi_monitor_handle, find_sysbus_device, >> pc_dimm_slot2bitmap,

[Qemu-devel] [PULL 0/2] Pflash and firmware configuration patches for 2019-03-26

2019-03-26 Thread Markus Armbruster
The following changes since commit d132baa05ed7a647067c807fd452ec794cc2ecb7: Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2019-03-25 17:01:10 +) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git

Re: [Qemu-devel] [PATCH 2/4] ui: build keymap only with softmmu targets

2019-03-26 Thread Laurent Vivier
On 26/03/2019 09:44, Paolo Bonzini wrote: > On 21/03/19 13:46, Laurent Vivier wrote: >> we don't need to generate the files for linux-user or for the tools >> >> Signed-off-by: Laurent Vivier >> --- >> Makefile | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Makefile b/Makefile >>

<    1   2   3   >