[Qemu-devel] [Bug 1826827] Re: dtc crash; pnv_dt_serial cannot find lpc's phandle

2019-04-28 Thread Amol Surati
** Description changed: Qemu version: QEMU emulator version 4.0.50 (v4.0.0-142-ge0fb2c3d89) Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers dtc version: Version: DTC 1.5.0-g5c3513f6 -

[Qemu-devel] [Bug 1826827] [NEW] dtc crash; pnv_dt_serial cannot find lpc's phandle

2019-04-28 Thread Amol Surati
Public bug reported: Qemu version: QEMU emulator version 4.0.50 (v4.0.0-142-ge0fb2c3d89) Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers dtc version: Version: DTC 1.5.0-g5c3513f6 - pnv_dt_serial has

[Qemu-devel] [Bug 1826827] Re: dtc crash; pnv_dt_serial cannot find lpc's phandle

2019-04-28 Thread Amol Surati
** Attachment added: "the powernv dtb" https://bugs.launchpad.net/qemu/+bug/1826827/+attachment/5259834/+files/dtb ** Description changed: - pnv_dt_serial has a line which is supposed to set the interrupt-parent - of the "isa-serial@i3f8" node to the phandle of "lpc@0". + Qemu version: + QEMU

[Qemu-devel] [PATCH v1 4/5] hw/arm: Add the STM32F4xx SoC

2019-04-28 Thread Alistair Francis
Signed-off-by: Alistair Francis --- MAINTAINERS | 8 + default-configs/arm-softmmu.mak | 1 + hw/arm/Kconfig | 3 + hw/arm/Makefile.objs| 1 + hw/arm/stm32f405_soc.c | 292

[Qemu-devel] [PATCH v1 3/5] hw/misc: Add the STM32F4xx EXTI device

2019-04-28 Thread Alistair Francis
Signed-off-by: Alistair Francis --- default-configs/arm-softmmu.mak | 1 + hw/misc/Kconfig | 3 + hw/misc/Makefile.objs| 1 + hw/misc/stm32f4xx_exti.c | 175 +++ include/hw/misc/stm32f4xx_exti.h | 57 ++ 5 files

[Qemu-devel] [PATCH v1 5/5] hw/arm: Add the Netduino Plus 2

2019-04-28 Thread Alistair Francis
Signed-off-by: Alistair Francis --- MAINTAINERS | 6 +++ default-configs/arm-softmmu.mak | 1 + hw/arm/Kconfig | 3 ++ hw/arm/Makefile.objs| 1 + hw/arm/netduinoplus2.c | 77 + 5 files changed, 88

[Qemu-devel] [PATCH v1 0/5] Add the STM32F405 and Netduino Plus 2 machine

2019-04-28 Thread Alistair Francis
Now that the Arm-M4 CPU has been added to QEMU we can add the Netduino Plus 2 machine. This is very similar to the STM32F205 and Netduino 2 SoC and machine. Alistair Francis (5): armv7m: Allow entry information to be returned hw/misc: Add the STM32F4xx Sysconfig device hw/misc: Add the

[Qemu-devel] [PATCH v1 2/5] hw/misc: Add the STM32F4xx Sysconfig device

2019-04-28 Thread Alistair Francis
Signed-off-by: Alistair Francis --- default-configs/arm-softmmu.mak| 1 + hw/misc/Kconfig| 3 + hw/misc/Makefile.objs | 1 + hw/misc/stm32f4xx_syscfg.c | 275 + include/hw/misc/stm32f4xx_syscfg.h | 62 +++ 5

[Qemu-devel] [PATCH v1 1/5] armv7m: Allow entry information to be returned

2019-04-28 Thread Alistair Francis
Allow the kernel's entry point information to be returned when loading a kernel. Signed-off-by: Alistair Francis --- hw/arm/armv7m.c | 6 +++--- hw/arm/microbit.c| 2 +- hw/arm/mps2-tz.c | 3 ++- hw/arm/mps2.c| 2 +- hw/arm/msf2-som.c| 2 +- hw/arm/musca.c | 3 ++-

Re: [Qemu-devel] [PATCH v2 0/8] tests/qemu-iotests: Run basic iotests during "make check"

2019-04-28 Thread Thomas Huth
On 29/04/2019 05.47, no-re...@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20190428155451.15653-1-th...@redhat.com/ > > This series failed the asan build test. Please find the testing commands and > their output below. If you have Docker installed, you can probably reproduce > it >

Re: [Qemu-devel] [PATCH v2 0/5] fw_cfg_test refactor and add two test cases

2019-04-28 Thread Li Qiang
Li Qiang 于2019年4月25日周四 下午10:29写道: > > > Thomas Huth 于2019年4月25日周四 下午5:57写道: > >> On 24/04/2019 16.06, Li Qiang wrote: >> > In the disscuss of adding reboot timeout test case: >> > https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg03304.html >> > >> > Philippe suggested we should uses the

Re: [Qemu-devel] [PATCH v2 0/8] tests/qemu-iotests: Run basic iotests during "make check"

2019-04-28 Thread Thomas Huth
On 28/04/2019 18.10, no-re...@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20190428155451.15653-1-th...@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id:

Re: [Qemu-devel] [PATCH v6 5/5] block/backup: refactor: split out backup_calculate_cluster_size

2019-04-28 Thread Vladimir Sementsov-Ogievskiy
26.04.2019 21:30, Max Reitz wrote: > On 15.04.19 16:49, Vladimir Sementsov-Ogievskiy wrote: >> Split out cluster_size calculation. Move copy-bitmap creation above >> block-job creation, as we are going to share it with upcoming >> backup-top filter, which also should be created before actual block

Re: [Qemu-devel] [PATCH] trace: fix runstate tracing

2019-04-28 Thread Vladimir Sementsov-Ogievskiy
Oops, my fault, sorry:( Thank you for fixing! May be added, that it is broken since ff12e3ae3d0. Reviewed-by: Vladimir Sementsov-Ogievskiy 26.04.2019 13:21, Yury Kotov wrote: > Signed-off-by: Yury Kotov > --- > vl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Qemu-devel] [PATCH v2 0/8] tests/qemu-iotests: Run basic iotests during "make check"

2019-04-28 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190428155451.15653-1-th...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash time

[Qemu-devel] Apple Hypervisor - unimplemented handler

2019-04-28 Thread Programmingkid
When running Windows 7 using "-M accel=hvf --cpu host", Windows 7 would crash. What was printed to the console was this: Unimplemented handler (f8000c0c2050) for 0 (f c3) This message is from target/i386/hvf/x86_emu.c. The c3 seems to indicate this is a problem with the MOVNTI or RETN

[Qemu-devel] [PATCH 3/4] util/cacheinfo.c: Use uintptr_t instead of unsigned long in AArch64 arch_cache_info()

2019-04-28 Thread driver1998
Windows ARM64 uses LLP64 model, which breaks current assumptions. Signed-off-by: driver1998 --- util/cacheinfo.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/util/cacheinfo.c b/util/cacheinfo.c index 3cd080b83d..a815cb0722 100644 --- a/util/cacheinfo.c +++

[Qemu-devel] [PATCH 1/4] Initial Windows on ARM (AArch64 64-Bit) host support

2019-04-28 Thread driver1998
This series of patches is for initial support of Windows 10 on ARM as a QEMU host. Currently only TCG intepreter is working correctly, it crashes when TCG JIT is enabled. For now we assume it is built using the clang aarch64-w64-mingw32 toolchain, you can get a prebuilt toolchain at

[Qemu-devel] [PATCH 2/4] qga: Fix an enum conversion warning in commands-win32.c, hit by clang.

2019-04-28 Thread driver1998
Signed-off-by: driver1998 --- qga/commands-win32.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index d40d61f605..4cdd2950bf 100644 --- a/qga/commands-win32.c +++ b/qga/commands-win32.c @@

[Qemu-devel] [PATCH 4/4] include/qemu/osdep.h: Move the __USE_MINGW_ANSI_STDIO define up to avoid confliction.

2019-04-28 Thread driver1998
Signed-off-by: driver1998 --- include/qemu/osdep.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 303d315c5d..af2b91f0b8 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -85,17 +85,17 @@ extern int

Re: [Qemu-devel] [PATCH v5 00/10] qcow2: encryption threads

2019-04-28 Thread Max Reitz
On 02.04.19 17:37, Vladimir Sementsov-Ogievskiy wrote: > v5: rebase on master, some conflicts resolved due to data-file feature > > 01: new patch, just move test from cover letter to a file. I really hope that > it > will not hang the whole series, so, if we don't want it as is or with >

Re: [Qemu-devel] [PATCH v5 00/10] qcow2: encryption threads

2019-04-28 Thread Max Reitz
On 29.04.19 02:37, Max Reitz wrote: > On 02.04.19 17:37, Vladimir Sementsov-Ogievskiy wrote: >> v5: rebase on master, some conflicts resolved due to data-file feature (Forgot to note that I'll look at the more interesting patches in this series later today. I just got so hung up on the

Re: [Qemu-devel] [PATCH] hw/tpm: Only build tpm_ppi.o if any of TPM_TIS/TPM_CRB is built

2019-04-28 Thread Stefan Berger
On 4/27/19 11:49 AM, Marc-André Lureau wrote: Hi On Sat, Apr 27, 2019 at 3:19 PM Philippe Mathieu-Daudé wrote: The TPM Physical Presence Interface routines are only used by the CRB/TIS interfaces. Do not compile this file if any of them is built. Signed-off-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH v5 01/10] tests/perf: Test qemu-img convert from raw to encrypted qcow2

2019-04-28 Thread Max Reitz
On 02.04.19 17:37, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/perf/block/qcow2/convert-to-encrypted | 48 + > 1 file changed, 48 insertions(+) > create mode 100755 tests/perf/block/qcow2/convert-to-encrypted Thanks for

Re: [Qemu-devel] [PATCH] [RFC] qcow2: add compression type feature

2019-04-28 Thread Max Reitz
On 05.02.19 10:08, Denis Plotnikov wrote: > The patch adds some preparation parts for incompatible compression type > feature into QCOW2 header that indicates that *all* compressed clusters > must be (de)compressed using a certain compression type. > > It is implied that the compression type is

Re: [Qemu-devel] [PATCH v2 0/8] tests/qemu-iotests: Run basic iotests during "make check"

2019-04-28 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190428155451.15653-1-th...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190428155451.15653-1-th...@redhat.com Subject: [Qemu-devel] [PATCH v2 0/8]

[Qemu-devel] [PATCH v2 6/8] tests/qemu-iotests: Remove the "_supported_os Linux" line from many tests

2019-04-28 Thread Thomas Huth
A lot of tests run fine on FreeBSD and macOS, too - the limitation to Linux here was likely just copied-and-pasted from other tests. Thus remove the "_supported_os Linux" line from tests that run successful in our CI pipelines on FreeBSD and macOS. Signed-off-by: Thomas Huth ---

[Qemu-devel] [PATCH v2 8/8] tests: Run the iotests during "make check" again

2019-04-28 Thread Thomas Huth
People often forget to run the iotests before submitting patches or pull requests - this is likely due to the fact that we do not run the tests during our mandatory "make check" tests yet. Now that we've got a proper "auto" group of iotests that should be fine to run in every environment, we can

[Qemu-devel] [PATCH v2 3/8] tests/qemu-iotests/check: Pick a default machine if necessary

2019-04-28 Thread Thomas Huth
qemu-system-arm, qemu-system-aarch64 and qemu-system-tricore do not have a default machine, so when running the qemu-iotests with such a binary, lots of tests are failing. Fix it by picking a default machine in the "check" script instead. Signed-off-by: Thomas Huth --- tests/qemu-iotests/check

[Qemu-devel] [PATCH v2 4/8] tests/qemu-iotests: Do not hard-code the path to bash

2019-04-28 Thread Thomas Huth
bash is installed in a different directory on non-Linux systems like FreeBSD. Do not hard-code /bin/bash here so that the tests can run there, too. Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- tests/qemu-iotests/239 | 2 +- tests/qemu-iotests/240

[Qemu-devel] [PATCH v2 5/8] cirrus / travis: Add gnu-sed and bash for macOS and FreeBSD

2019-04-28 Thread Thomas Huth
We are going to enable the qemu-iotests during "make check" again, and for running the iotests, we need bash and gnu-sed. Signed-off-by: Thomas Huth --- .cirrus.yml | 4 ++-- .travis.yml | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index

[Qemu-devel] [PATCH v2 7/8] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run

2019-04-28 Thread Thomas Huth
Currently, all tests are in the "auto" group. This is a little bit pointless. OTOH, we need a group for the tests that we can automatically run during "make check" each time, too. Tests in this new group are supposed to run with every possible QEMU configuration, for example they must run with

[Qemu-devel] [PATCH v2 1/8] tests/qemu-iotests: Fix output of qemu-io related tests

2019-04-28 Thread Thomas Huth
One of the recent commits changed the way qemu-io prints out its errors and warnings - they are now prefixed with the program name. We've got to adapt the iotests accordingly to prevent that they are failing. Fixes: 99e98d7c9fc1a1639fad ("qemu-io: Use error_[gs]et_progname()") Signed-off-by:

[Qemu-devel] [PATCH v2 0/8] tests/qemu-iotests: Run basic iotests during "make check"

2019-04-28 Thread Thomas Huth
People often forget to run the iotests before submitting patches or pull requests - this is likely due to the fact that we do not run the tests during our mandatory "make check" tests yet. This patch series now changes the "auto" group to only include tests that should be safe to run in all CI

[Qemu-devel] [PATCH v2 2/8] tests/qemu-iotests/005: Add a sanity check for large sparse file support

2019-04-28 Thread Thomas Huth
"check -raw 005" fails when running on ext4 filesystems - these do not support such large sparse files. Use the same check as in test 220 to skip the test in this case. Suggested-by: Eric Blake Signed-off-by: Thomas Huth --- tests/qemu-iotests/005 | 9 + 1 file changed, 9 insertions(+)

[Qemu-devel] Failing qemu-iotest 211 with -vdi

2019-04-28 Thread Thomas Huth
QEMU iotest 211 is failing for me, too, when I run it with -vdi: tests/qemu-iotests$ ./check -vdi 211 QEMU -- "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" -nodefaults -machine accel=qtest QEMU_IMG --

[Qemu-devel] Failing QEMU iotest 221

2019-04-28 Thread Thomas Huth
QEMU iotest 221 is failing for me, too, when I run it with -raw: tests/qemu-iotests$ ./check -raw 221 QEMU -- "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" -nodefaults -machine accel=qtest QEMU_IMG --

[Qemu-devel] Failing QEMU iotest 175

2019-04-28 Thread Thomas Huth
QEMU iotest 175 is failing for me when I run it with -raw: $ ./check -raw 175 QEMU -- "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" -nodefaults -machine accel=qtest QEMU_IMG -- "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-img"

[Qemu-devel] [PATCH 11/14] target/ppc: decode target register in VSX_VECTOR_LOAD_STORE_LENGTH at translation time

2019-04-28 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- target/ppc/helper.h | 8 target/ppc/mem_helper.c | 6 ++ target/ppc/translate/vsx-impl.inc.c | 7 --- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/target/ppc/helper.h b/target/ppc/helper.h index

[Qemu-devel] [PATCH 13/14] target/ppc: improve VSX_TEST_DC with new generator macros

2019-04-28 Thread Mark Cave-Ayland
The source and destination registers can now be decoded in the generator function using the new GEN_VSX_HELPER_X2 and GEN_VSX_HELPER_R2 macros. Signed-off-by: Mark Cave-Ayland --- target/ppc/fpu_helper.c | 16 +++- target/ppc/helper.h | 8

[Qemu-devel] [PATCH 12/14] target/ppc: decode target register in VSX_EXTRACT_INSERT at translation time

2019-04-28 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- target/ppc/helper.h | 4 ++-- target/ppc/int_helper.c | 12 target/ppc/translate/vsx-impl.inc.c | 10 +- 3 files changed, 11 insertions(+), 15 deletions(-) diff --git a/target/ppc/helper.h

[Qemu-devel] [PATCH 14/14] target/ppc: improve VSX_FMADD with new GEN_VSX_HELPER_VSX_MADD macro

2019-04-28 Thread Mark Cave-Ayland
Introduce a new GEN_VSX_HELPER_VSX_MADD macro for the generator function which enables the source and destination registers to be decoded at translation time. Signed-off-by: Mark Cave-Ayland --- target/ppc/fpu_helper.c | 12 + target/ppc/helper.h | 64

[Qemu-devel] [PATCH 10/14] target/ppc: introduce GEN_VSX_HELPER_R2_AB macro to fpu_helper.c

2019-04-28 Thread Mark Cave-Ayland
Rather than perform the VSR register decoding within the helper itself, introduce a new GEN_VSX_HELPER_R2_AB macro which performs the decode based upon rA and rB at translation time. Signed-off-by: Mark Cave-Ayland --- target/ppc/fpu_helper.c | 10 -- target/ppc/helper.h

Re: [Qemu-devel] [PULL 0/2] target/hppa patch queue

2019-04-28 Thread Peter Maydell
On Fri, 26 Apr 2019 at 19:22, Richard Henderson wrote: > > The following changes since commit 3284aa128153750f14a61e8a96fd085e6f2999b6: > > Merge remote-tracking branch 'remotes/lersek/tags/edk2-pull-2019-04-22' > into staging (2019-04-24 13:19:41 +0100) > > are available in the Git repository

Re: [Qemu-devel] [PULL 00/15] tcg patch queue

2019-04-28 Thread Peter Maydell
On Fri, 26 Apr 2019 at 18:24, Richard Henderson wrote: > > The following changes since commit 3284aa128153750f14a61e8a96fd085e6f2999b6: > > Merge remote-tracking branch 'remotes/lersek/tags/edk2-pull-2019-04-22' > into staging (2019-04-24 13:19:41 +0100) > > are available in the Git repository

[Qemu-devel] [PATCH 05/14] target/ppc: introduce GEN_VSX_HELPER_X2 macro to fpu_helper.c

2019-04-28 Thread Mark Cave-Ayland
Rather than perform the VSR register decoding within the helper itself, introduce a new GEN_VSX_HELPER_X2 macro which performs the decode based upon xT and xB at translation time. Signed-off-by: Mark Cave-Ayland --- target/ppc/fpu_helper.c | 50 ++--- target/ppc/helper.h

[Qemu-devel] [PATCH 08/14] target/ppc: introduce GEN_VSX_HELPER_R3 macro to fpu_helper.c

2019-04-28 Thread Mark Cave-Ayland
Rather than perform the VSR register decoding within the helper itself, introduce a new GEN_VSX_HELPER_X3 macro which performs the decode based upon rD, rA and rB at translation time. Signed-off-by: Mark Cave-Ayland --- target/ppc/fpu_helper.c | 36

[Qemu-devel] [PATCH 04/14] target/ppc: introduce GEN_VSX_HELPER_X3 macro to fpu_helper.c

2019-04-28 Thread Mark Cave-Ayland
Rather than perform the VSR register decoding within the helper itself, introduce a new GEN_VSX_HELPER_X3 macro which performs the decode based upon xT, xA and xB at translation time. Signed-off-by: Mark Cave-Ayland --- target/ppc/fpu_helper.c | 48 --- target/ppc/helper.h

[Qemu-devel] [PATCH 01/14] target/ppc: remove getVSR()/putVSR() from fpu_helper.c

2019-04-28 Thread Mark Cave-Ayland
Since commit 8a14d31b00 "target/ppc: switch fpr/vsrl registers so all VSX registers are in host endian order" functions getVSR() and putVSR() which used to convert the VSR registers into host endian order are no longer required. Signed-off-by: Mark Cave-Ayland --- target/ppc/fpu_helper.c | 707

[Qemu-devel] [PATCH 06/14] target/ppc: introduce GEN_VSX_HELPER_X2_AB macro to fpu_helper.c

2019-04-28 Thread Mark Cave-Ayland
Rather than perform the VSR register decoding within the helper itself, introduce a new GEN_VSX_HELPER_X2_AB macro which performs the decode based upon xA and xB at translation time. Signed-off-by: Mark Cave-Ayland --- target/ppc/fpu_helper.c | 15 ++-

[Qemu-devel] [PATCH 09/14] target/ppc: introduce GEN_VSX_HELPER_R2 macro to fpu_helper.c

2019-04-28 Thread Mark Cave-Ayland
Rather than perform the VSR register decoding within the helper itself, introduce a new GEN_VSX_HELPER_X3 macro which performs the decode based upon rD and rB at translation time. Signed-off-by: Mark Cave-Ayland --- target/ppc/fpu_helper.c | 31 --

[Qemu-devel] [PATCH 00/14] target/ppc: remove getVSR()/putVSR() and further tidy-up

2019-04-28 Thread Mark Cave-Ayland
With the conversion of PPC VSX registers to host endian during the 4.0 development cycle, the VSX helpers getVSR() and putVSR() which were used to convert between big endian and host endian (and are currently just a no-op) can now be removed. This eliminates an extra copy for each VSX source and

[Qemu-devel] [PATCH 07/14] target/ppc: introduce GEN_VSX_HELPER_X1 macro to fpu_helper.c

2019-04-28 Thread Mark Cave-Ayland
Rather than perform the VSR register decoding within the helper itself, introduce a new GEN_VSX_HELPER_X1 macro which performs the decode based upon xB at translation time. Signed-off-by: Mark Cave-Ayland --- target/ppc/fpu_helper.c | 6 ++ target/ppc/helper.h |

[Qemu-devel] [PATCH 02/14] target/ppc: remove getVSR()/putVSR() from mem_helper.c

2019-04-28 Thread Mark Cave-Ayland
Since commit 8a14d31b00 "target/ppc: switch fpr/vsrl registers so all VSX registers are in host endian order" functions getVSR() and putVSR() which used to convert the VSR registers into host endian order are no longer required. Signed-off-by: Mark Cave-Ayland --- target/ppc/mem_helper.c

[Qemu-devel] [PATCH 03/14] target/ppc: remove getVSR()/putVSR() from int_helper.c

2019-04-28 Thread Mark Cave-Ayland
Since commit 8a14d31b00 "target/ppc: switch fpr/vsrl registers so all VSX registers are in host endian order" functions getVSR() and putVSR() which used to convert the VSR registers into host endian order are no longer required. Now that there are now no more users of getVSR()/putVSR() these

Re: [Qemu-devel] [PATCH] hw/tpm: Only build tpm_ppi.o if any of TPM_TIS/TPM_CRB is built

2019-04-28 Thread Stefan Berger
On 4/27/19 9:18 AM, Philippe Mathieu-Daudé wrote: The TPM Physical Presence Interface routines are only used by the CRB/TIS interfaces. Do not compile this file if any of them is built. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Berger --- Marc-André: You might want to

Re: [Qemu-devel] [PATCH] tests/tpm-tests: Use g_test_skip() to mark skipped tests

2019-04-28 Thread Stefan Berger
On 4/24/19 5:45 AM, Thomas Huth wrote: Since we do not use gtester anymore (which had a bug here), we can now use g_test_skip() to mark skipped tests. Signed-off-by: Thomas Huth Reviewed-by: Stefan Berger --- tests/tpm-tests.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Qemu-devel] Failing qemu-iotest 005 with raw

2019-04-28 Thread Thomas Huth
On 28/04/2019 04.36, Eric Blake wrote: > On 4/26/19 5:53 AM, Kevin Wolf wrote: > >>> creating large image >>> +qemu-img: TEST_DIR/t.IMGFMT: The image size is too large for file >>> format 'IMGFMT' >>> Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=536870912 >>> [...] >>> >>> Could this be

[Qemu-devel] [PATCH V1] Introducing virtio-example.

2019-04-28 Thread Yoni Bettan
The main goal is to create an example to be used as template or guideline for contributors when they wish to create a new virtio device and to document "the right way" to do so. It consists of several parts: 1. The device specification * it can be found in the device header *

[Qemu-devel] [PATCH] virtio-mmio: Always compile debug prints

2019-04-28 Thread Boxuan Li
Wrap printf calls inside debug macros (DPRINTF) in `if` statement, and change output to stderr as well. This will ensure that printf function will always compile and prevent bitrot of the format strings. Signed-off-by: Boxuan Li --- hw/virtio/virtio-mmio.c | 17 - 1 file

Re: [Qemu-devel] [PULL 00/36] ppc-for-4.1 queue 20190426

2019-04-28 Thread Peter Maydell
On Fri, 26 Apr 2019 at 07:06, David Gibson wrote: > > The following changes since commit 3284aa128153750f14a61e8a96fd085e6f2999b6: > > Merge remote-tracking branch 'remotes/lersek/tags/edk2-pull-2019-04-22' > into staging (2019-04-24 13:19:41 +0100) > > are available in the Git repository at:

[Qemu-devel] [PATCH 1/2] backup: buffer COW request and delay the write operation

2019-04-28 Thread Liang Li
If the backup target is a slow device like ceph rbd, the backup process will affect guest BLK write IO performance seriously, it's cause by the drawback of COW mechanism, if guest overwrite the backup BLK area, the IO can only be processed after the data has been written to backup target. The

[Qemu-devel] [PATCH 2/2] qapi: add interface for setting backup cow buffer size

2019-04-28 Thread Liang Li
Cc: John Snow Cc: Kevin Wolf Cc: Max Reitz Cc: Wen Congyang Cc: Xie Changlong Cc: Markus Armbruster Cc: Eric Blake Cc: Fam Zheng Signed-off-by: Liang Li --- block/backup.c| 3 ++- block/replication.c | 2 +- blockdev.c| 5 + include/block/block_int.h

[Qemu-devel] [PATCH 0/2] buffer and delay backup COW write operation

2019-04-28 Thread Liang Li
If the backup target is a slow device like ceph rbd, the backup process will affect guest BLK write IO performance seriously, it's cause by the drawback of COW mechanism, if guest overwrite the backup BLK area, the IO can only be processed after the data has been written to backup target. The

[Qemu-devel] [PATCH v2 6/6] vl: Do not set acpi_enabled when ACPI is disabled at build time

2019-04-28 Thread Philippe Mathieu-Daudé
When building with CONFIG_ACPI disabled, the 'acpi_enabled' is still initialized to '1' (enabled). Remove the confusion by moving the variable to hw/core/acpi.c, and adding a similar stub. Signed-off-by: Philippe Mathieu-Daudé --- hw/acpi/core.c | 1 + stubs/acpi.c | 2 ++ vl.c | 1

[Qemu-devel] [PATCH v2 5/6] stubs: Add missing ACPI symbols

2019-04-28 Thread Philippe Mathieu-Daudé
When building with ACPI disabled, we get: /usr/bin/ld: hw/i386/pc.o: in function `bochs_bios_init': /source/qemu/hw/i386/pc.c:1017: undefined reference to `acpi_tables_len' /usr/bin/ld: /source/qemu/hw/i386/pc.c:1017: undefined reference to `acpi_tables' collect2: error: ld returned 1

[Qemu-devel] [PATCH v2 3/6] hw/acpi: Simplify the Makefile logic

2019-04-28 Thread Philippe Mathieu-Daudé
Simplify the Makefile logic to ease further modifications/reviews. Signed-off-by: Philippe Mathieu-Daudé --- hw/acpi/Makefile.objs | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/hw/acpi/Makefile.objs b/hw/acpi/Makefile.objs index 73eca4f7dff..b5515c626a6

[Qemu-devel] [PATCH v2 4/6] hw/acpi: Always build the 'core' ACPI functions

2019-04-28 Thread Philippe Mathieu-Daudé
The 'core' ACPI functions are not X86-specific. Let this file be built unconditionally, this will allow us to use ACPI on non-X86 architectures. Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé --- hw/acpi/Makefile.objs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH v2 1/6] hw/acpi: Move the IPMI stub to the stubs/ directory

2019-04-28 Thread Philippe Mathieu-Daudé
Move the IPMI stub file to the stubs/ directory to simplify the hw/acpi Makefile. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + hw/acpi/Makefile.objs | 3 +-- stubs/Makefile.objs | 1 + hw/acpi/ipmi-stub.c => stubs/ipmi.c | 0

[Qemu-devel] [PATCH v2 0/6] hw/acpi: Improve build modularity (targeting MIPS/PPC)

2019-04-28 Thread Philippe Mathieu-Daudé
Hi, This series is not related to the previous one I just send: hw/i386/acpi: Improve build modularity (isapc/q35/...) https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg04678.html While the first only concern X86 (changes within the architecture), this one allow the core ACPI feature to

[Qemu-devel] [PATCH v2 2/6] hw/acpi: Move the ACPI stub to the stubs/ directory

2019-04-28 Thread Philippe Mathieu-Daudé
Move the ACPI stub file to the stubs/ directory to greatly simplify the hw/acpi Makefile. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + hw/acpi/Makefile.objs | 5 - stubs/Makefile.objs | 1 + hw/acpi/acpi-stub.c =>