[Qemu-devel] [PATCH v3 06/31] tcg/arm: Use tcg_out_mov_reg in tcg_out_mov

2019-05-03 Thread Richard Henderson
We have a function that takes an additional condition parameter over the standard backend interface. It already takes care of eliding no-op moves. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.inc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v3 07/31] tcg: Return bool success from tcg_out_mov

2019-05-03 Thread Richard Henderson
This patch merely changes the interface, aborting on all failures, of which there are currently none. Reviewed-by: Alex Bennée Reviewed-by: David Hildenbrand Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: David Gibson Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 5

[Qemu-devel] [PATCH v3 15/31] tcg: Add gvec expanders for variable shift

2019-05-03 Thread Richard Henderson
The gvec expanders perform a modulo on the shift count. If the target requires alternate behaviour, then it cannot use the generic gvec expanders anyway, and will have to have its own custom code. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- accel/tcg/tcg-runtime.h | 15

[Qemu-devel] [PATCH v3 09/31] tcg: Promote tcg_out_{dup, dupi}_vec to backend interface

2019-05-03 Thread Richard Henderson
The i386 backend already has these functions, and the aarch64 backend could easily split out one. Nothing is done with these functions yet, but this will aid register allocation of INDEX_op_dup_vec in a later patch. Adjust the aarch64 tcg_out_dupi_vec signature to match the new interface.

[Qemu-devel] [PATCH v3 05/31] tcg: Assert fixed_reg is read-only

2019-05-03 Thread Richard Henderson
The only fixed_reg is cpu_env, and it should not be modified during any TB. Therefore code that tries to special-case moves into a fixed_reg is dead. Remove it. Reviewed-by: Alex Bennée Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- tcg/tcg.c | 87

[Qemu-devel] [PATCH v3 14/31] tcg: Add INDEX_op_dupm_vec

2019-05-03 Thread Richard Henderson
Allow the backend to expand dup from memory directly, instead of forcing the value into a temp first. This is especially important if integer/vector register moves do not exist. Note that officially tcg_out_dupm_vec is allowed to fail. If it did, we could fix this up relatively easily: VECE

[Qemu-devel] [PATCH v3 02/31] tcg: Do not recreate INDEX_op_neg_vec unless supported

2019-05-03 Thread Richard Henderson
Use tcg_can_emit_vec_op instead of just TCG_TARGET_HAS_neg_vec, so that we check the type and vece for the actual operation. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/optimize.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tcg/optimize.c

[Qemu-devel] [PATCH v3 08/31] tcg: Support cross-class moves without instruction support

2019-05-03 Thread Richard Henderson
PowerPC Altivec does not support direct moves between vector registers and general registers. So when tcg_out_mov fails, we can use the backing memory for the temporary to perform the move. Acked-by: David Hildenbrand Signed-off-by: Richard Henderson --- tcg/tcg.c | 31

[Qemu-devel] [PATCH v3 10/31] tcg: Manually expand INDEX_op_dup_vec

2019-05-03 Thread Richard Henderson
This case is similar to INDEX_op_mov_* in that we need to do different things depending on the current location of the source. Signed-off-by: Richard Henderson --- v3: Added some commentary to the tcg_reg_alloc_* functions. --- tcg/aarch64/tcg-target.inc.c | 9 ++- tcg/i386/tcg-target.inc.c

[Qemu-devel] [PATCH v3 01/31] tcg: Implement tcg_gen_gvec_3i()

2019-05-03 Thread Richard Henderson
From: David Hildenbrand Let's add tcg_gen_gvec_3i(), similar to tcg_gen_gvec_2i(), however without introducing "gen_helper_gvec_3i *fnoi", as it isn't needed for now. Reviewed-by: Alex Bennée Signed-off-by: David Hildenbrand Message-Id: <20190416185301.25344-2-da...@redhat.com> Signed-off-by:

[Qemu-devel] [PATCH v3 03/31] tcg: Allow add_vec, sub_vec, neg_vec, not_vec to be expanded

2019-05-03 Thread Richard Henderson
Reviewed-by: Alex Bennée Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- tcg/tcg-op-vec.c | 49 1 file changed, 33 insertions(+), 16 deletions(-) diff --git a/tcg/tcg-op-vec.c b/tcg/tcg-op-vec.c index 27f65600c3..cfb18682b1

[Qemu-devel] [PATCH v3 00/31] tcg vector improvements

2019-05-03 Thread Richard Henderson
Changes since v2 (stsquad review): * Split out a tcg/arm/ change to tcg_out_mov. * Add some additional commentary for tcg_reg_alloc_foo. Patches missing ack/review: 0006-tcg-arm-Use-tcg_out_mov_reg-in-tcg_out_mov.patch (new) 0010-tcg-Manually-expand-INDEX_op_dup_vec.patch

[Qemu-devel] [PATCH] migration: don't set MIGRATION dirty range for ignored block

2019-05-03 Thread Wei Yang
The ignored blocks are not migrated and those ranges are not used. Signed-off-by: Wei Yang --- exec.c | 4 +++- include/exec/ram_addr.h | 2 ++ migration/ram.c | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/exec.c b/exec.c index

Re: [Qemu-devel] [PATCH v1 5/5] hw/arm: Add the Netduino Plus 2

2019-05-03 Thread Alistair Francis
On Fri, May 3, 2019 at 9:26 PM Alistair wrote: > > On Thu, May 2, 2019, at 3:06 AM, Peter Maydell wrote: > > On Tue, 30 Apr 2019 at 21:29, Alistair Francis wrote: > > > > > > On Tue, Apr 30, 2019 at 9:02 AM Peter Maydell > > > wrote: > > > > Can you explain the purpose of the reset code? None

Re: [Qemu-devel] [PATCH v2] target/arm: Stop using variable length array in dc_zva

2019-05-03 Thread Philippe Mathieu-Daudé
On 5/3/19 2:04 PM, Peter Maydell wrote: > Currently the dc_zva helper function uses a variable length > array. In fact we know (as the comment above remarks) that > the length of this array is bounded because the architecture > limits the block size and QEMU limits the target page size. > Use a

Re: [Qemu-devel] [PATCH v1 5/5] hw/arm: Add the Netduino Plus 2

2019-05-03 Thread Alistair
On Thu, May 2, 2019, at 3:06 AM, Peter Maydell wrote: > On Tue, 30 Apr 2019 at 21:29, Alistair Francis wrote: > > > > On Tue, Apr 30, 2019 at 9:02 AM Peter Maydell > > wrote: > > > Can you explain the purpose of the reset code? None of the other > > > v7m boards seem to need to do a manual

Re: [Qemu-devel] [PATCH 2/2] hw/arm/boot: Honour image size field in AArch64 Image format kernels

2019-05-03 Thread Richard Henderson
On 5/3/19 10:13 AM, Peter Maydell wrote: > Since Linux v3.17, the kernel's Image header includes a field image_size, > which gives the total size of the kernel including unpopulated data > sections such as the BSS). If this is present, then return it from > load_aarch64_image() as the true size of

Re: [Qemu-devel] [PATCH for-4.1] block: Use bdrv_unref_child() for all children in bdrv_close()

2019-05-03 Thread Max Reitz
On 31.03.19 13:17, Alberto Garcia wrote: > bdrv_unref_child() does the following things: > > - Updates the child->bs->inherits_from pointer. > - Calls bdrv_detach_child() to remove the BdrvChild from bs->children. > - Calls bdrv_unref() to unref the child BlockDriverState. > > When

Re: [Qemu-devel] [PATCH] chardev/char-i2c: Implement Linux I2C character device

2019-05-03 Thread Ernest Esene
On Fri, May 03, 2019 at 03:24:06PM -0500, Eric Blake wrote: > On 5/3/19 2:31 PM, Ernest Esene wrote: > > Add support for Linux I2C character device for I2C device passthrough > > For example: > > -chardev linux-i2c,address=0x46,path=/dev/i2c-N,id=i2c-chardev > > > > Signed-off-by: Ernest Esene >

Re: [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is available

2019-05-03 Thread Eduardo Habkost
On Fri, May 03, 2019 at 06:00:11PM -0300, Eduardo Habkost wrote: > On Fri, May 03, 2019 at 06:41:43PM +0200, Thomas Huth wrote: > > On 03/05/2019 02.41, Eduardo Habkost wrote: > > > From: Daniel P. Berrangé > > > > > > Unless overridden via an env var or configure arg, QEMU will only look > > >

Re: [Qemu-devel] Failing QEMU iotest 175

2019-05-03 Thread Nir Soffer
On Fri, May 3, 2019, 23:21 Eric Blake wrote: > On 5/2/19 11:37 PM, Thomas Huth wrote: > > On 02/05/2019 23.56, Eric Blake wrote: > >> On 4/28/19 10:18 AM, Thomas Huth wrote: > >>> QEMU iotest 175 is failing for me when I run it with -raw: > >>> > >> > >>> == creating image with default

Re: [Qemu-devel] [PATCH] qcow2: Assert that host cluster offsets fit in L2 table entries

2019-05-03 Thread Eric Blake
On 5/3/19 4:38 AM, Alberto Garcia wrote: > The standard cluster descriptor in L2 table entries has a field to > store the host cluster offset. When we need to get that offset from an > entry we use L2E_OFFSET_MASK to ensure that we only use the bits that > belong to that field. > > But while that

Re: [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is available

2019-05-03 Thread Eduardo Habkost
On Fri, May 03, 2019 at 06:41:43PM +0200, Thomas Huth wrote: > On 03/05/2019 02.41, Eduardo Habkost wrote: > > From: Daniel P. Berrangé > > > > Unless overridden via an env var or configure arg, QEMU will only look > > for the 'python' binary in $PATH. This is unhelpful on distros which > > are

Re: [Qemu-devel] Failing QEMU iotest 221

2019-05-03 Thread Eric Blake
On 5/2/19 11:43 PM, Thomas Huth wrote: > On 03/05/2019 00.02, Eric Blake wrote: >> On 4/28/19 10:21 AM, Thomas Huth wrote: >>> QEMU iotest 221 is failing for me, too, when I run it with -raw: >> >> Which filesystem? > > ext4 again. > > $ stat -f /home/thuth/tmp/qemu-build/tests/qemu-iotests/ >

Re: [Qemu-devel] [PATCH] VirtIO-RNG: Update default entropy source to `/dev/urandom`

2019-05-03 Thread Kashyap Chamarthy
On Fri, May 03, 2019 at 04:49:05PM +0100, Daniel P. Berrangé wrote: > On Fri, May 03, 2019 at 05:46:13PM +0200, Kashyap Chamarthy wrote: > > When QEMU exposes a VirtIO-RNG device to the guest, that device needs a > > source of entropy, and that source needs to be "non-blocking", like > >

Re: [Qemu-devel] [PATCH] chardev/char-i2c: Implement Linux I2C character device

2019-05-03 Thread Eric Blake
On 5/3/19 2:31 PM, Ernest Esene wrote: > Add support for Linux I2C character device for I2C device passthrough > For example: > -chardev linux-i2c,address=0x46,path=/dev/i2c-N,id=i2c-chardev > > Signed-off-by: Ernest Esene > --- Just an interface review: > +++ b/qapi/char.json > @@ -240,6

Re: [Qemu-devel] [PATCH v2 1/3] q35: set split kernel irqchip as default

2019-05-03 Thread Eduardo Habkost
On Fri, May 03, 2019 at 04:00:33PM -0400, Michael S. Tsirkin wrote: > On Mon, Apr 29, 2019 at 11:55:56AM -0300, Eduardo Habkost wrote: > > irqchip=split and irqchip=kernel aren't guest ABI compatible, are > > they? > > Can you remind me why they aren't? We have the code introduced by patch 3/3

Re: [Qemu-devel] Failing QEMU iotest 175

2019-05-03 Thread Eric Blake
On 5/2/19 11:37 PM, Thomas Huth wrote: > On 02/05/2019 23.56, Eric Blake wrote: >> On 4/28/19 10:18 AM, Thomas Huth wrote: >>> QEMU iotest 175 is failing for me when I run it with -raw: >>> >> >>> == creating image with default preallocation == >>> Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT

Re: [Qemu-devel] [PATCH v2 1/3] q35: set split kernel irqchip as default

2019-05-03 Thread Michael S. Tsirkin
On Mon, Apr 29, 2019 at 11:55:56AM -0300, Eduardo Habkost wrote: > irqchip=split and irqchip=kernel aren't guest ABI compatible, are > they? Can you remind me why they aren't? > -- > Eduardo

[Qemu-devel] [PATCH] Deprecate Python 2 support

2019-05-03 Thread Eduardo Habkost
Python 2 will reach end of life in January 1 2020. Declare it as deprecated. Signed-off-by: Eduardo Habkost --- configure| 8 qemu-deprecated.texi | 8 2 files changed, 16 insertions(+) diff --git a/configure b/configure index 5b183c2e39..50385061ed 100755 ---

Re: [Qemu-devel] [PATCH v5 00/15] demacro softmmu (plus tests/coverage)

2019-05-03 Thread Alex Bennée
Richard Henderson writes: > On 4/30/19 9:52 AM, Alex Bennée wrote: >> I've also moved the existing system memory test and made it multiarch >> and added the bootstrapping for aarch64 system tests. I would like to >> add support for Big Endian as well but I didn't want to delay the >> posting

[Qemu-devel] [PATCH] chardev/char-i2c: Implement Linux I2C character device

2019-05-03 Thread Ernest Esene
Add support for Linux I2C character device for I2C device passthrough For example: -chardev linux-i2c,address=0x46,path=/dev/i2c-N,id=i2c-chardev Signed-off-by: Ernest Esene --- chardev/Makefile.objs | 1 + chardev/char-i2c.c | 142 +

Re: [Qemu-devel] [PATCH RFC v8 01/12] target/rx: TCG translation

2019-05-03 Thread Richard Henderson
On 5/2/19 7:33 AM, Yoshinori Sato wrote: > +/* conditional branch helper */ > +static void rx_bcnd_main(DisasContext *ctx, int cd, int dst) > +{ > +DisasCompare dc; > +TCGLabel *t, *done; > + > +switch (cd) { > +case 0 ... 13: > +dc.temp = tcg_temp_new(); > +

Re: [Qemu-devel] [PATCH v2] mips: Decide to map PAGE_EXEC in map_address

2019-05-03 Thread Aleksandar Markovic
> (ping) > > Is there anything else I can do to help to get this merged? > > https://patchew.org/QEMU/20190423110034.1260142-1-jakub.jer...@kernkonzept.com/ Hello, Jakub. I will be reviewing your patch next week, please be patient. In any case, thanks for your involving in solving this issue!

Re: [Qemu-devel] [PATCH v2 1/3] q35: set split kernel irqchip as default

2019-05-03 Thread Eduardo Habkost
On Mon, Apr 29, 2019 at 09:22:12AM -0600, Alex Williamson wrote: [...] > > > What's a good 4.0.1 strategy to resolve this? Re-instate KVM irqchip > > > as the Q35 default? I can't see that simply switching to current QEMU > > > handling is a viable option for performance? What about 4.1? We

Re: [Qemu-devel] [PATCH RFC v8 12/12] hw/registerfields.h: Add 8bit and 16bit register macros.

2019-05-03 Thread Richard Henderson
On 5/3/19 8:27 AM, Alex Bennée wrote: > > Yoshinori Sato writes: > >> Some RX peripheral using 8bit and 16bit registers. >> Added 8bit and 16bit APIs. > > Doesn't this mean the build breaks at some point? Features used by other > patches should be introduced first so the build remains

Re: [Qemu-devel] [PATCH RFC v8 04/12] target/rx: RX disassembler

2019-05-03 Thread Richard Henderson
On 5/2/19 7:34 AM, Yoshinori Sato wrote: > +static int32_t li(DisasContext *ctx, int sz) > +{ > +int32_t addr; > +bfd_byte buf[4]; > +addr = ctx->addr; > + > +switch (sz) { > +case 1: > +ctx->addr += 1; > +ctx->dis->read_memory_func(addr, buf, 1, ctx->dis); > +

Re: [Qemu-devel] [PATCH] qom/object: Display more helpful message when an object type is missing

2019-05-03 Thread Eduardo Habkost
On Sat, Apr 27, 2019 at 03:56:42PM +0200, Philippe Mathieu-Daudé wrote: > When writing a new board, adding device which uses other devices > (container) or simply refactoring, one can discover the hard way > his machine misses some devices. In the case of containers, the > error is not obvious: >

Re: [Qemu-devel] [PATCH 1/3] ram-encrypted-notifier: Introduce a RAM block encrypted notifier

2019-05-03 Thread Eduardo Habkost
On Fri, Apr 26, 2019 at 02:32:51PM +, Janakarajan Natarajan wrote: > On 4/26/19 7:29 AM, Igor Mammedov wrote: [...] > >> diff --git a/numa.c b/numa.c > >> index 3875e1efda..08601366c5 100644 > >> --- a/numa.c > >> +++ b/numa.c > > looks like wrong file to put RAMBlock code in. I though that we

Re: [Qemu-devel] [PATCH v3 36/40] s390x/tcg: Implement VECTOR SUBTRACT WITH BORROW COMPUTE BORROW INDICATION

2019-05-03 Thread Richard Henderson
On 5/2/19 7:10 AM, David Hildenbrand wrote: > Mostly courtesy of Richard H. > > Signed-off-by: David Hildenbrand > --- > target/s390x/insn-data.def | 2 ++ > target/s390x/translate_vx.inc.c | 34 + > 2 files changed, 36 insertions(+) Reviewed-by: Richard

Re: [Qemu-devel] Following up questions related to QEMU and I/O Thread

2019-05-03 Thread Wei Li
Hi Paolo, That will be great, I would like to hear more details about the design and implementation once you get those ready. Thanks a lot, Wei On 5/3/19, 11:05 AM, "Paolo Bonzini" wrote: On 03/05/19 10:21, Wei Li wrote: > Got it, thanks Stefan for your clarification! Hi

Re: [Qemu-devel] Following up questions related to QEMU and I/O Thread

2019-05-03 Thread Paolo Bonzini
On 03/05/19 10:21, Wei Li wrote: > Got it, thanks Stefan for your clarification! Hi Wei, Stefan and I should be posting a patch to add Linux SCSI driver batching, and an implementation for virtio-scsi. Paolo > Wei > > On 5/1/19, 9:36 AM, "Stefan Hajnoczi" wrote: > > On Mon, Apr 29,

[Qemu-devel] [PATCH v4 3/5] linux-user: Add support the SIOCIFPFLAGS ioctls for all targets

2019-05-03 Thread Aleksandar Markovic
From: Neng Chen Add support for getting and setting extended private flags of a network device via SIOCSIFPFLAGS and SIOCGIFPFLAGS ioctls. The ioctl numeric values are platform-independent and determined by the file include/uapi/linux/sockios.h in Linux kernel source code: #define

[Qemu-devel] [PATCH v4 4/5] linux-user: Add support for setsockopt() options IPV6__MEMBERSHIP

2019-05-03 Thread Aleksandar Markovic
From: Neng Chen Add support for options IPV6_ADD_MEMBERSHIP and IPV6_DROP_MEMPEMBERSHIP of the syscall setsockopt(). These options control membership in multicast groups. Their argument is a pointer to a struct ipv6_mreq, which is in turn defined as: struct ipv6_mreq { /* IPv6 multicast

[Qemu-devel] [PATCH v4 5/5] linux-user: Sanitize interp_info and, for mips only, init field fp_abi

2019-05-03 Thread Aleksandar Markovic
From: Daniel Santos Sanitize interp_info structure in load_elf_binary() and, for MIPS only, init its field fp_abi to MIPS_ABI_FP_UNKNOWN. This fixes appearances of "Unexpected FPU mode" message in some MIPS use cases. Currently, this bug is a complete stopper for some MIPS binaries. In

[Qemu-devel] [PATCH v4 1/5] linux-user: Fix support for the SIOCATMARK and SIOCGPGRP ioctls for xtensa

2019-05-03 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix support for the SIOCATMARK and SIOCGPGRP ioctls for xtensa by correcting corresponding macro definition. Values for TARGET_SIOCATMARK and TARGET_SIOCGPGRP are determined by Linux kernel. Following relevant lines (obtained by grep) are from the kernel source tree:

[Qemu-devel] [PATCH v4 2/5] linux-user: Add support for the SIOCSPGRP ioctl for all targets

2019-05-03 Thread Aleksandar Markovic
From: Aleksandar Markovic Add support for setting the process (or process group) to receive SIGIO or SIGURG signals when I/O becomes possible or urgent data is available, using SIOCSPGRP ioctl. The ioctl numeric values for SIOCSPGRP are platform-dependent and are determined by following files

[Qemu-devel] [PATCH v4 0/5] linux-user: A set of miscellaneous patches

2019-05-03 Thread Aleksandar Markovic
From: Aleksandar Markovic This is a collection of misc patches for Linux user that I recently accumulated from variuous sources. All of them originate from problems observed on mips target. However, these changes actually affect and fix problems on multiple targets. v3->v4: - improved commit

[Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

2019-05-03 Thread Peter Maydell
Antonio has submitted a patchset here: https://patchew.org/QEMU/20190503082728.16485-1-...@ao2.it/ ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH 1/2] hw/arm/boot: Avoid placing the initrd on top of the kernel

2019-05-03 Thread Peter Maydell
On Fri, 3 May 2019 at 18:13, Peter Maydell wrote: > > We currently put the initrd at the smaller of: > * 128MB into RAM > * halfway into the RAM > (with the dtb following it). > > However for large kernels this might mean that the kernel > overlaps the initrd. For some kinds of kernel

Re: [Qemu-devel] [PATCH v2] security.rst: add Security Guide to developer docs

2019-05-03 Thread Stefan Hajnoczi
On Fri, May 03, 2019 at 10:04:10AM +0100, Alex Bennée wrote: > Stefan Hajnoczi writes: > > +Isolation mechanisms > > + > > +Several isolation mechanisms are available to realize this architecture of > > +guest isolation and the principle of least privilege. With the exception

Re: [Qemu-devel] [PATCH v2] security.rst: add Security Guide to developer docs

2019-05-03 Thread Stefan Hajnoczi
On Fri, May 03, 2019 at 11:35:29AM +0100, Daniel P. Berrangé wrote: > On Fri, May 03, 2019 at 11:28:53AM +0100, Peter Maydell wrote: > > On Fri, 3 May 2019 at 11:19, Daniel P. Berrangé wrote: > > > Everything above here is useful to QEMU devs, app devs & end users and > > > should be made part of

[Qemu-devel] [Bug 1823998] Re: qemu-system-aarch64: support kernels bigger than 128MiB

2019-05-03 Thread Peter Maydell
I've submitted a patchset which I think should fix this, but if you could test that it actually does handle large images correctly that would be great. https://patchew.org/QEMU/20190503171347.13747-1-peter.mayd...@linaro.org/ ** Changed in: qemu Status: New => In Progress -- You

Re: [Qemu-devel] [PATCH] target/arm: Implement NSACR gating of floating point

2019-05-03 Thread Richard Henderson
On 5/3/19 6:13 AM, Peter Maydell wrote: > On Sat, 13 Apr 2019 at 08:07, Richard Henderson >> This one does do the right thing, but better to clear the bits on write to >> NSACR. This lets you avoid the change to fp_exception_el, and the missing >> change to sve_exception_el. > > Hi Richard -- I

Re: [Qemu-devel] [PATCH v2] block/rbd: increase dynamically the image size

2019-05-03 Thread Jason Dillaman
On Fri, May 3, 2019 at 12:30 PM Stefano Garzarella wrote: > > RBD APIs don't allow us to write more than the size set with > rbd_create() or rbd_resize(). > In order to support growing images (eg. qcow2), we resize the > image before write operations that exceed the current size. > >

[Qemu-devel] [PATCH v3 1/5] linux-user: Fix support for the SIOCATMARK and SIOCGPGRP ioctls for xtensa

2019-05-03 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix support for the SIOCATMARK and SIOCGPGRP ioctls for xtensa by correcting corresponding macro definition. Values for TARGET_SIOCATMARK and TARGET_SIOCGPGRP are determined by Linux kernel. Following relevant lines are from kernel source tree:

[Qemu-devel] [PATCH 2/2] hw/arm/boot: Honour image size field in AArch64 Image format kernels

2019-05-03 Thread Peter Maydell
Since Linux v3.17, the kernel's Image header includes a field image_size, which gives the total size of the kernel including unpopulated data sections such as the BSS). If this is present, then return it from load_aarch64_image() as the true size of the kernel rather than just using the size of

Re: [Qemu-devel] [PATCH v4] hw/virtio/virtio-mmio: Convert DPRINTF to trace and log

2019-05-03 Thread LI, BO XUAN
Gotcha, thanks for the tip! Best regards, Boxuan Li On Sat, May 4, 2019 at 1:00 AM Alex Bennée wrote: > > LI, BO XUAN writes: > > > Hi Alex, > > > > Sorry about that, I am still trying to get familiar with the patch > > submission process. Since my patch has been changed from your last >

[Qemu-devel] [PATCH 1/2] blockjob: Fix coroutine thread after AioContext change

2019-05-03 Thread Kevin Wolf
Commit 463e0be10 ('blockjob: add AioContext attached callback') tried to make block jobs robust against AioContext changes of their main node, but it never made sure that the job coroutine actually runs in the new thread. Instead of waking up the job coroutine in whatever thread it ran before,

[Qemu-devel] [PATCH v3 4/5] linux-user: Add support for setsockopt() options IPV6__MEMBERSHIP

2019-05-03 Thread Aleksandar Markovic
From: Neng Chen Add support for options IPV6_ADD_MEMBERSHIP and IPV6_ADD_MEMBERSHIP of the syscall setsockopt(). These options control membership in multicast groups. Their argument is a pointer to a struct ipv6_mreq, which is in turn defined as: struct ipv6_mreq { /* IPv6 multicast address

[Qemu-devel] [PATCH 0/2] blockjob: Fix coroutine thread after AioContext change

2019-05-03 Thread Kevin Wolf
Kevin Wolf (2): blockjob: Fix coroutine thread after AioContext change test-block-iothread: Job coroutine thread after AioContext switch job.c | 2 +- tests/test-block-iothread.c | 107 2 files changed, 108 insertions(+), 1

[Qemu-devel] [PATCH 2/2] test-block-iothread: Job coroutine thread after AioContext switch

2019-05-03 Thread Kevin Wolf
This tests that a job coroutine always runs in the right iothread after the AioContext of its main node has changed. Signed-off-by: Kevin Wolf --- tests/test-block-iothread.c | 107 1 file changed, 107 insertions(+) diff --git a/tests/test-block-iothread.c

[Qemu-devel] [PATCH 0/2] hw/arm/boot: handle large Images more gracefully

2019-05-03 Thread Peter Maydell
This patchset attempts to fix https://bugs.launchpad.net/qemu/+bug/1823998 which reports that we don't handle kernels larger than 128MB correctly, because we allow the initrd to be placed over the tail end of the kernel. AArch64 kernel Image files (since v3.17) report the total size they require

[Qemu-devel] [PATCH v3 2/5] linux-user: Add support for the SIOCSPGRP ioctl

2019-05-03 Thread Aleksandar Markovic
From: Aleksandar Markovic Add support for setting the process (or process group) to receive SIGIO or SIGURG signals when I/O becomes possible or urgent data is available, using SIOCSPGRP ioctl. The ioctl numeric values for SIOCSPGRP are platform-dependent and are determined by following files

Re: [Qemu-devel] [RFC 0/3] target/m68k: convert to transaction_failed hook

2019-05-03 Thread Laurent Vivier
On 10/12/2018 17:56, Peter Maydell wrote: This patchset converts the m68k target from the deprecated unassigned_access hook to the new transaction_failed hook. It's RFC for a couple of reasons: * it's untested, since I don't have an m68k test image * the second patch just makes "bus error

[Qemu-devel] [PATCH 1/2] hw/arm/boot: Avoid placing the initrd on top of the kernel

2019-05-03 Thread Peter Maydell
We currently put the initrd at the smaller of: * 128MB into RAM * halfway into the RAM (with the dtb following it). However for large kernels this might mean that the kernel overlaps the initrd. For some kinds of kernel (self-decompressing 32-bit kernels, and ELF images with a BSS section at

[Qemu-devel] [PATCH v3 3/5] linux-user: Add support the SIOCSIFPFLAGS and SIOCGIFPFLAGS ioctls

2019-05-03 Thread Aleksandar Markovic
From: Neng Chen Add support for setting and getting extended (private) flags of a network device via SIOCSIFPFLAGS and SIOCGIFPFLAGS ioctls. The ioctl numeric value is platform-independent and determined by the file include/uapi/linux/sockios.h in Linux kernel source code: #define

[Qemu-devel] [PATCH v3 0/5] linux-user: A set of miscellaneous patches

2019-05-03 Thread Aleksandar Markovic
From: Aleksandar Markovic This is a collection of misc patches for Linux user that I recently accumulated from variuous sources. All of them originate from problems observed on mips target. However, these changes actually affect and fix problems on multiple targets. v1->v2: - updated and

[Qemu-devel] [PATCH v3 5/5] linux-user: Sanitize interp_info and, for mips only, init field fp_abi

2019-05-03 Thread Aleksandar Markovic
From: Daniel Santos Sanitize interp_info structure in load_elf_binary() and, for MIPS only, init its field fp_abi to MIPS_ABI_FP_UNKNOWN. This fixes appearances of "Unexpected FPU mode" message in some MIPS use cases. Currently, this bug is a complete stopper for some MIPS binaries. In

Re: [Qemu-devel] [PATCH] tests/tcg/alpha: add system boot.S

2019-05-03 Thread Alex Bennée
Richard Henderson writes: > This provides the bootstrap and low level helper functions for an > alpha kernel. We use direct access to the DP264 serial port for > test output, and hard machine halt to exit the emulation. Queued to testing/next, thanks. I've also added tests/tcg/alpha/system/

Re: [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is available

2019-05-03 Thread Philippe Mathieu-Daudé
On 5/3/19 6:41 PM, Thomas Huth wrote: > On 03/05/2019 02.41, Eduardo Habkost wrote: >> From: Daniel P. Berrangé >> >> Unless overridden via an env var or configure arg, QEMU will only look >> for the 'python' binary in $PATH. This is unhelpful on distros which >> are only shipping Python 3.x (eg

[Qemu-devel] [PATCH] net: avoid to use variable length array in net_client_init()

2019-05-03 Thread Stefano Garzarella
net_client_init() uses a variable length array to store the prefix of 'ipv6-net' parameter (e.g. if ipv6-net=fec0::0/64, the prefix is 'fec0::0'). Since the IPv6 prefix can be at most as long as an IPv6 address, we can use an array with fixed size equals to INET6_ADDRSTRLEN. Signed-off-by:

Re: [Qemu-devel] [PATCH v4] hw/virtio/virtio-mmio: Convert DPRINTF to trace and log

2019-05-03 Thread Alex Bennée
LI, BO XUAN writes: > Hi Alex, > > Sorry about that, I am still trying to get familiar with the patch > submission process. Since my patch has been changed from your last review, > I thought it would be safe to not include the r-b tag from last time. Will > take care next time! That's ok. As

Re: [Qemu-devel] [PATCH] tests/docker: add ubuntu 18.04

2019-05-03 Thread Philippe Mathieu-Daudé
On 5/3/19 6:42 PM, Alex Bennée wrote: > > Gerd Hoffmann writes: > >> Based on the ubuntu.docker file. >> Used to reproduce the build failure Peter was seeing. >> Others might find this useful too ;) >> >> Signed-off-by: Gerd Hoffmann >> --- >> tests/docker/dockerfiles/ubuntu1804.docker | 57

Re: [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is available

2019-05-03 Thread Daniel P . Berrangé
On Fri, May 03, 2019 at 05:54:35PM +0100, Daniel P. Berrangé wrote: > On Fri, May 03, 2019 at 06:41:43PM +0200, Thomas Huth wrote: > > On 03/05/2019 02.41, Eduardo Habkost wrote: > > > From: Daniel P. Berrangé > > > > > > Unless overridden via an env var or configure arg, QEMU will only look > >

Re: [Qemu-devel] [RFC 3/3] target/m68k: Switch to transaction_failed hook

2019-05-03 Thread Laurent Vivier
On 10/12/2018 17:56, Peter Maydell wrote: Switch the m68k target from the old unassigned_access hook to the transaction_failed hook. The notable difference is that rather than it being called for all physical memory accesses which fail (including those made by DMA devices or by the gdbstub), it

Re: [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is available

2019-05-03 Thread Daniel P . Berrangé
On Fri, May 03, 2019 at 06:41:43PM +0200, Thomas Huth wrote: > On 03/05/2019 02.41, Eduardo Habkost wrote: > > From: Daniel P. Berrangé > > > > Unless overridden via an env var or configure arg, QEMU will only look > > for the 'python' binary in $PATH. This is unhelpful on distros which > > are

[Qemu-devel] [Bug 1823998] Re: qemu-system-aarch64: support kernels bigger than 128MiB

2019-05-03 Thread Peter Maydell
** Tags added: arm -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1823998 Title: qemu-system-aarch64: support kernels bigger than 128MiB Status in QEMU: New Bug description: Presently QEMU

Re: [Qemu-devel] [RFC 2/3] target/m68k: In get_physical_address() check for memory access failures

2019-05-03 Thread Laurent Vivier
On 10/12/2018 17:56, Peter Maydell wrote: In get_physical_address(), use address_space_ldl() and address_space_stl() instead of ldl_phys() and stl_phys(). This allows us to check whether the memory access failed. For the moment, we simply return -1 in this case; add a TODO comment that we should

Re: [Qemu-devel] [PATCH] tests/docker: add ubuntu 18.04

2019-05-03 Thread Alex Bennée
Gerd Hoffmann writes: > Based on the ubuntu.docker file. > Used to reproduce the build failure Peter was seeing. > Others might find this useful too ;) > > Signed-off-by: Gerd Hoffmann > --- > tests/docker/dockerfiles/ubuntu1804.docker | 57 ++ > 1 file changed, 57

Re: [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is available

2019-05-03 Thread Thomas Huth
On 03/05/2019 02.41, Eduardo Habkost wrote: > From: Daniel P. Berrangé > > Unless overridden via an env var or configure arg, QEMU will only look > for the 'python' binary in $PATH. This is unhelpful on distros which > are only shipping Python 3.x (eg Fedora) in their default install as, > if

[Qemu-devel] [Bug 1825359] Re: cpu_ld*_code() triggers MMU_DATA_LOAD i.s.o. MMU_INST_FETCH

2019-05-03 Thread Peter Maydell
Your patch is now in git master as commit ef5dae6805cce7b59d129 -- thanks! ** Changed in: qemu Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1825359

[Qemu-devel] [Bug 1824853] Re: 4.0.0-rc3 crashes with tcg/tcg.c:3952: tcg_gen_code: Assertion `s->gen_insn_end_off[num_insns] == off' failed

2019-05-03 Thread Peter Maydell
The fix should now be in git master (commits 8b86d6d25807e13a6 and 6e6c4efed995d9ec), so it will be in the 4.1 release. ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH v3] hw/usb/hcd-xhci: Fix GCC 9 build warning

2019-05-03 Thread Alistair Francis
On Fri, May 3, 2019 at 2:24 AM Daniel P. Berrangé wrote: > > On Fri, May 03, 2019 at 12:42:04AM +, Alistair Francis wrote: > > Fix this build warning with GCC 9 on Fedora 30: > > hw/usb/hcd-xhci.c:3339:66: error: ‘%d’ directive output may be truncated > > writing between 1 and 10 bytes into

Re: [Qemu-devel] [RFC 1/3] target/m68k: In dump_address_map() check for memory access failures

2019-05-03 Thread Laurent Vivier
On 10/12/2018 17:56, Peter Maydell wrote: In dump_address_map(), use address_space_ldl() instead of ldl_phys(). This allows us to check whether the memory access failed. Signed-off-by: Peter Maydell --- target/m68k/helper.c | 22 +++--- 1 file changed, 15 insertions(+), 7

[Qemu-devel] [PATCH v2 4/4] 9p: use variable length suffixes for inode mapping

2019-05-03 Thread Christian Schoenebeck via Qemu-devel
This patch introduces variable length suffixes for being used for inode mapping instead of the fixed 16 bit size prefixes of patch 1. With this patch the inode numbers on guest will typically be much smaller (e.g. around >2^1 .. >2^7 instead of >2^48 with patch 1). I preserved both solutions in

Re: [Qemu-devel] [PATCH v4] hw/virtio/virtio-mmio: Convert DPRINTF to trace and log

2019-05-03 Thread LI, BO XUAN
Hi Alex, Sorry about that, I am still trying to get familiar with the patch submission process. Since my patch has been changed from your last review, I thought it would be safe to not include the r-b tag from last time. Will take care next time! Best regards, Boxuan Li On Sat, May 4, 2019 at

[Qemu-devel] [PATCH v2] block/rbd: increase dynamically the image size

2019-05-03 Thread Stefano Garzarella
RBD APIs don't allow us to write more than the size set with rbd_create() or rbd_resize(). In order to support growing images (eg. qcow2), we resize the image before write operations that exceed the current size. Signed-off-by: Stefano Garzarella --- v2: - use bs->total_sectors instead of

Re: [Qemu-devel] [PATCH v3 1/4] QEMU_PACKED: Remove gcc_struct attribute in Windows non x86 targets

2019-05-03 Thread Philippe Mathieu-Daudé
On 5/3/19 5:56 PM, Marc-André Lureau wrote: > Hi > > Le ven. 3 mai 2019 à 17:23, Peter Maydell a > écrit : > >> On Fri, 3 May 2019 at 06:07, Thomas Huth wrote: >>> >>> On 03/05/2019 02.36, Cao Jiaxi wrote: gcc_struct is for x86 only, and it generates an warning on ARM64 >> Clang/MinGW

Re: [Qemu-devel] Following up questions related to QEMU and I/O Thread

2019-05-03 Thread Wei Li
Got it, thanks Stefan for your clarification! Wei On 5/1/19, 9:36 AM, "Stefan Hajnoczi" wrote: On Mon, Apr 29, 2019 at 10:56:31AM -0700, Wei Li wrote: >Does this mean the performance could be improved via adding Batch I/O submission support in Guest driver side which will be able to

[Qemu-devel] [PATCH v2 3/4] 9p: persistency of QID path beyond reboots / suspensions

2019-05-03 Thread Christian Schoenebeck via Qemu-devel
This patch aims to keep QID path identical beyond the scope of reboots and guest suspensions. With the 1st patch alone the QID path of the same files might change after reboots / suspensions, since 9p would restart with empty qpp_table and the resulting QID path depends on the precise sequence of

[Qemu-devel] [PATCH v2 2/4] 9P: trivial cleanup of QID path collision mitigation

2019-05-03 Thread Christian Schoenebeck via Qemu-devel
Addresses trivial changes regarding the previous patch as requested on the mailing list a while ago. * Removed unneccessary parantheses: https://lists.gnu.org/archive/html/qemu-devel/2018-02/msg02661.html * Removed unneccessary g_malloc() result checks:

[Qemu-devel] [PATCH v2 0/4] 9p: Fix file ID collisions

2019-05-03 Thread Christian Schoenebeck via Qemu-devel
Hi! This is v2 of a proposed patch set for fixing file ID collisions with 9pfs. Patch 1 to 3 are identical to the previous version. New in this v2 is patch 4 which introduces variable length suffixes for inode mapping instead of fixed length prefixes. Also: patch 4 disables file ID persistency

[Qemu-devel] [PATCH v2 1/4] 9p: mitigates most QID path collisions

2019-05-03 Thread Christian Schoenebeck via Qemu-devel
This first patch here is an updated version of Antonios Motakis' original 4-patch set, merged to one patch: https://lists.gnu.org/archive/html/qemu-devel/2018-02/msg02283.html * Updated to latest git master, specifically to new qht interface. * Merged the original 4 patches to this single

Re: [Qemu-devel] [PATCH] qxl: fix -Waddress-of-packed-member

2019-05-03 Thread Philippe Mathieu-Daudé
On 4/8/19 10:12 PM, Marc-André Lureau wrote: > The GCC9 compiler complains about QXL code that takes the address of > members of the 'struct QXLReleaseRing' which is marked packed: > > CC hw/display/qxl.o > /home/elmarco/src/qemu/hw/display/qxl.c: In function ‘init_qxl_ram’: >

Re: [Qemu-devel] [PATCH v4] hw/virtio/virtio-mmio: Convert DPRINTF to trace and log

2019-05-03 Thread Alex Bennée
Boxuan Li writes: > Use traces for debug message and qemu_log_mask for errors. > > Signed-off-by: Boxuan Li You didn't add my r-b tags from last time. Anyway: Reviewed-by: Alex Bennée > --- > v1: https://patchew.org/QEMU/20190428110258.86681-1-libox...@connect.hku.hk/ > v2:

Re: [Qemu-devel] [RFC PATCH] tests/qemu-iotests: re-format output to for make check-block

2019-05-03 Thread Alex Bennée
Thomas Huth writes: > On 03/05/2019 16.39, Alex Bennée wrote: >> This attempts to clean-up the output to better match the output of the >> rest of the QEMU check system. This includes: >> >> - formatting as " TESTiotest: nnn" >> - calculating time diff at the end >> - only dumping

Re: [Qemu-devel] [PATCH RFC v8 00/12] Add RX archtecture support

2019-05-03 Thread Alex Bennée
Yoshinori Sato writes: > Hello. > This patch series is added Renesas RX target emulation. I think the series is almost there - it's mostly just nits and clean build fixes to sort out now. If you run the branch through CI you will see where things fail to build. However once that is all

Re: [Qemu-devel] [PATCH] VirtIO-RNG: Update default entropy source to `/dev/urandom`

2019-05-03 Thread Richard W.M. Jones
On Fri, May 03, 2019 at 05:46:13PM +0200, Kashyap Chamarthy wrote: > When QEMU exposes a VirtIO-RNG device to the guest, that device needs a > source of entropy, and that source needs to be "non-blocking", like > `/dev/urandom`. However, currently QEMU defaults to the problematic > `/dev/random`,

Re: [Qemu-devel] [PATCH RFC v8 05/12] target/rx: Miscellaneous files

2019-05-03 Thread Alex Bennée
Yoshinori Sato writes: > Signed-off-by: Yoshinori Sato > --- > target/rx/gdbstub.c | 112 > > target/rx/monitor.c | 38 > target/rx/Makefile.objs | 11 + > 3 files changed, 161 insertions(+) > create mode

  1   2   3   >