Re: [Qemu-devel] [PATCH] target/openrisc: Fix LGPL information in the file headers

2019-05-05 Thread Thomas Huth
On 13/02/2019 16.59, Thomas Huth wrote: > It's either "GNU *Library* General Public License version 2" or "GNU > Lesser General Public License version *2.1*", but there was no "version > 2.0" of the "Lesser" license. So assume that version 2.1 is meant here. > > Signed-off-by: Thomas Huth > ---

Re: [Qemu-devel] [PATCH] hw/i2c/smbus_ich9: Fix the confusing contributions-after-2012 statement

2019-05-05 Thread Thomas Huth
On 29/03/2019 09.42, Thomas Huth wrote: > On 06/02/2019 17.43, Thomas Huth wrote: >> The license information in this file is rather confusing. The text >> declares LGPL first, but then says that contributions after Jan 2012 >> are licensed under the GPL instead. How should the average user who >>

[Qemu-devel] [PATCH] tests/Makefile: Remove unused test-obj-y variable

2019-05-05 Thread Thomas Huth
I recently noticed that test-obj-y contains a file called tests/check-block-qtest.o which simply does not belong to any .c file and thus wondered why this is not causing any trouble. Well, if I get the Makefile magic right, test-obj-y is not really used for anything - and "make check" still works

Re: [Qemu-devel] [PATCH 0/2] buffer and delay backup COW write operation

2019-05-05 Thread Liang Li
On Tue, Apr 30, 2019 at 10:35:32AM +, Vladimir Sementsov-Ogievskiy wrote: > 28.04.2019 13:01, Liang Li wrote: > > If the backup target is a slow device like ceph rbd, the backup > > process will affect guest BLK write IO performance seriously, > > it's cause by the drawback of COW mechanism,

Re: [Qemu-devel] [PATCH] hw/timer: Compile devices not target-dependent as common objects

2019-05-05 Thread Thomas Huth
On 05/05/2019 20.07, Philippe Mathieu-Daudé wrote: > All these devices do not contain any target-specific code. While > most of them are arch-specific, they are shared between different > targets of the same arch family (ARM and AArch64, MIPS32/MIPS64, > multiple endianess, ...). > Put them into

Re: [Qemu-devel] [PATCH] hw/display/cirrus_vga: Remove unused include

2019-05-05 Thread Thomas Huth
On 06/05/2019 00.56, Philippe Mathieu-Daudé wrote: > Commit ce3cf70edaaf split the ISA device out of the PCI one, > but forgot to remove the "hw/loader.h" header inclusion (the ISA > device calls rom_add_vga()). Remove the now unused include. > > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [Qemu-devel] [PATCH 1/1] MAINTAINERS: Add an entry for the Parallel NOR Flash devices

2019-05-05 Thread Thomas Huth
On 06/05/2019 00.47, Philippe Mathieu-Daudé wrote: > Step in to maintain it, since I have some familiarity with > the technology. > > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index

Re: [Qemu-devel] [PATCH v4 01/10] block/pflash_cfi02: Add test for supported commands

2019-05-05 Thread Thomas Huth
On 26/04/2019 18.26, Stephen Checkoway wrote: > Test the AMD command set for parallel flash chips. This test uses an > ARM musicpal board with a pflash drive to test the following list of > currently-supported commands. > - Autoselect > - CFI > - Sector erase > - Chip erase > - Program > - Unlock

Re: [Qemu-devel] [PATCH 2/2] ppc: Add dump-stack implementation

2019-05-05 Thread David Gibson
On Thu, May 02, 2019 at 01:47:32PM +1000, Alexey Kardashevskiy wrote: > > > On 02/05/2019 10:43, David Gibson wrote: > > On Wed, May 01, 2019 at 07:48:48PM +1000, Alexey Kardashevskiy wrote: > >> > >> > >> On 01/05/2019 15:35, Suraj Jitindar Singh wrote: > >>> The monitor function dump-stack is

Re: [Qemu-devel] [PATCH] virtfs: Add missing "id" parameter in documentation

2019-05-05 Thread Thomas Huth
On 05/05/2019 20.32, Greg Kurz wrote: > Hi Thomas, > > Thanks for the janitoring :) > > On Sun, 5 May 2019 16:45:27 +0200 > Thomas Huth wrote: > >> ... and remove the square brackets from "path" and "security_model", >> since these parameters are not optional. >> > > Well this is only true

Re: [Qemu-devel] [PATCH 0/3] hw/ppc/40p: Move the MC146818 RTC to the board where it belongs

2019-05-05 Thread David Gibson
On Sun, May 05, 2019 at 05:28:36PM +0200, Philippe Mathieu-Daudé wrote: > Hi, > > This series is to properly do the fix sent by Artyom here: > https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg02264.html > > There is no RTC on the i82378, move it to the board code, > set the base year

Re: [Qemu-devel] [QEMU-PPC] [PATCH] target/ppc: Add ibm, purr and ibm, spurr device-tree properties

2019-05-05 Thread David Gibson
On Mon, May 06, 2019 at 11:48:03AM +1000, Suraj Jitindar Singh wrote: > The ibm,purr and ibm,spurr device tree properties are used to indicate > that the processor implements the Processor Utilisation of Resources > Register (PURR) and Scaled Processor Utilisation of Resources Registers > (SPURR),

Re: [Qemu-devel] [PATCH 1/3] hw/ppc/prep: use TYPE_MC146818_RTC instead of a hardcoded string

2019-05-05 Thread David Gibson
On Sun, May 05, 2019 at 05:28:37PM +0200, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Certainly a good fix, but looks like there's places in hw/timer/mc146818rtc.c itself and in vl.c which could also do with this. > --- > hw/ppc/prep.c | 2 +- > 1 file changed, 1

Re: [Qemu-devel] [PATCH v2 2/2] drm/i915/gvt: export mdev device version to sysfs for Intel vGPU

2019-05-05 Thread Zhenyu Wang
On 2019.05.05 21:51:02 -0400, Yan Zhao wrote: > This feature implements the version attribute for Intel's vGPU mdev > devices. > > version attribute is rw. > It's used to check device compatibility for two mdev devices. > version string format and length are private for vendor driver. vendor >

Re: [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

2019-05-05 Thread Xiang Zheng
On 2019/5/5 23:37, Peter Maydell wrote: > On Sun, 5 May 2019 at 08:02, Xiang Zheng wrote: >> >> Currently we fill the memory space with two 64MB NOR images when >> using persistent UEFI variables on virt board. Actually we only use >> a very small(non-zero) part of the memory while the rest

[Qemu-devel] [PATCH v2 2/2] drm/i915/gvt: export mdev device version to sysfs for Intel vGPU

2019-05-05 Thread Yan Zhao
This feature implements the version attribute for Intel's vGPU mdev devices. version attribute is rw. It's used to check device compatibility for two mdev devices. version string format and length are private for vendor driver. vendor driver is able to define them freely. For Intel vGPU of gen8

[Qemu-devel] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-05 Thread Yan Zhao
version attribute is used to check two mdev devices' compatibility. The key point of this version attribute is that it's rw. User space has no need to understand internal of device version and no need to compare versions by itself. Compared to reading version strings from both two mdev devices

[Qemu-devel] [PATCH v2 0/2] introduction of version attribute for VFIO live migration

2019-05-05 Thread Yan Zhao
This patchset introduces a version attribute under sysfs of VFIO Mediated devices. This version attribute is used to check whether two mdev devices are compatible. user space software can take advantage of this version attribute to determine whether to launch live migration between two mdev

[Qemu-devel] [QEMU-PPC] [PATCH] target/ppc: Add ibm, purr and ibm, spurr device-tree properties

2019-05-05 Thread Suraj Jitindar Singh
The ibm,purr and ibm,spurr device tree properties are used to indicate that the processor implements the Processor Utilisation of Resources Register (PURR) and Scaled Processor Utilisation of Resources Registers (SPURR), respectively. Each property has a single value which represents the level of

Re: [Qemu-devel] [PATCH 5/5] hw/block/pflash_cfi02: Add the DeviceReset() handler

2019-05-05 Thread Wei Yang
On Sun, May 05, 2019 at 10:06:02PM +0200, Philippe Mathieu-Daudé wrote: >The pflash device is a child of TYPE_DEVICE, so it can implement >the DeviceReset handler. Actually it has to implement it, else >on machine reset it might stay in an incoherent state, as it has >been reported in the buglink

Re: [Qemu-devel] [PATCH 4/5] hw/block/pflash_cfi02: Extract the pflash_reset() code

2019-05-05 Thread Wei Yang
On Sun, May 05, 2019 at 10:06:01PM +0200, Philippe Mathieu-Daudé wrote: >The reset() code is used in various places, refactor it. > >Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Wei Yang >--- > hw/block/pflash_cfi02.c | 25 +++-- > 1 file changed, 15 insertions(+), 10

Re: [Qemu-devel] [PATCH 3/5] hw/block/pflash_cfi01: Add the DeviceReset() handler

2019-05-05 Thread Wei Yang
On Sun, May 05, 2019 at 10:06:00PM +0200, Philippe Mathieu-Daudé wrote: >The pflash device is a child of TYPE_DEVICE, so it can implement >the DeviceReset handler. Actually it has to implement it, else >on machine reset it might stay in an incoherent state, as it has >been reported in the buglink

Re: [Qemu-devel] [PATCH 2/5] hw/block/pflash_cfi01: Extract the pflash_reset() code

2019-05-05 Thread Wei Yang
On Sun, May 05, 2019 at 10:05:59PM +0200, Philippe Mathieu-Daudé wrote: >The reset() code is used in various places, refactor it. > >Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Wei Yang >--- > hw/block/pflash_cfi01.c | 21 - > 1 file changed, 12 insertions(+), 9

Re: [Qemu-devel] [PATCH 1/5] hw/block/pflash_cfi01: Removed an unused timer

2019-05-05 Thread Wei Yang
On Sun, May 05, 2019 at 10:05:58PM +0200, Philippe Mathieu-Daudé wrote: >The 'CFI01' NOR flash was introduced in commit 29133e9a0fff, with >timing modelled. One year later, the CFI02 model was introduced >(commit 05ee37ebf630) based on the CFI01 model. As noted in the >header, "It does not support

[Qemu-devel] [PATCH] hw/sd/sdcard: Use the available enums

2019-05-05 Thread Philippe Mathieu-Daudé
We already define SDCardModes/SDCardStates as enums. Declare the mode/state as enums too, this make gdb debugging sessions friendlier: instead of numbers, the mode/state name is displayed. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[Qemu-devel] [PATCH] hw/display/cirrus_vga: Remove unused include

2019-05-05 Thread Philippe Mathieu-Daudé
Commit ce3cf70edaaf split the ISA device out of the PCI one, but forgot to remove the "hw/loader.h" header inclusion (the ISA device calls rom_add_vga()). Remove the now unused include. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/cirrus_vga.c | 1 - 1 file changed, 1 deletion(-) diff

[Qemu-devel] [PATCH 1/1] MAINTAINERS: Add an entry for the Parallel NOR Flash devices

2019-05-05 Thread Philippe Mathieu-Daudé
Step in to maintain it, since I have some familiarity with the technology. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 66ddbda9c95..633f6315536 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[Qemu-devel] [PATCH 0/1] MAINTAINERS: Step in as maintainer for the parallel NOR flash devices

2019-05-05 Thread Philippe Mathieu-Daudé
The parallel NOR flash models don't have a specific maintainer and default to the 'Block layer core' section. Step in to maintain them. The section still get covered by the Block layer team, but the idea is to offload them. The two devices are very similar (same technology), the difference is

[Qemu-devel] [PATCH 12/13] hw/block/pflash_cfi02: Fix command address comparison

2019-05-05 Thread Philippe Mathieu-Daudé
From: Stephen Checkoway Most AMD commands only examine 11 bits of the address. This masks the addresses used in the comparison to 11 bits. The exceptions are word or sector addresses which use offset directly rather than the shifted offset, boff. Signed-off-by: Stephen Checkoway Acked-by:

[Qemu-devel] [PATCH 07/13] hw/block/pflash_cfi02: Simplify a statement using fall through

2019-05-05 Thread Philippe Mathieu-Daudé
Signed-off-by: Stephen Checkoway Message-Id: <20190426162624.55977-3-stephen.checko...@oberlin.edu> Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé [PMD: Extracted from bigger patch] Signed-off-by: Philippe Mathieu-Daudé --- hw/block/pflash_cfi02.c | 6 +++--- 1 file

[Qemu-devel] [PATCH 13/13] hw/block/pflash_cfi02: Use the chip erase time specified in the CFI table

2019-05-05 Thread Philippe Mathieu-Daudé
From: Stephen Checkoway When erasing the chip, use the typical time specified in the CFI table rather than arbitrarily selecting 5 seconds. Since the currently unconfigurable value set in the table is 12, this means a chip erase takes 4096 ms so this isn't a big change in behavior.

[Qemu-devel] [PATCH 03/13] tests/pflash-cfi02: Use IEC binary prefixes for size constants

2019-05-05 Thread Philippe Mathieu-Daudé
Using IEC binary prefixes in order to make the code more readable. Signed-off-by: Philippe Mathieu-Daudé --- tests/pflash-cfi02-test.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/pflash-cfi02-test.c b/tests/pflash-cfi02-test.c index ff775618c02..3c37465499a

[Qemu-devel] [PATCH 01/13] tests/pflash-cfi02: Add test for supported CFI commands

2019-05-05 Thread Philippe Mathieu-Daudé
From: Stephen Checkoway Test the AMD command set for parallel flash chips. This test uses an ARM musicpal board with a pflash drive to test the following list of currently-supported commands. - Autoselect - CFI - Sector erase - Chip erase - Program - Unlock bypass - Reset Signed-off-by: Stephen

[Qemu-devel] [PATCH 09/13] hw/block/pflash_cfi02: Use the ldst API in pflash_read()

2019-05-05 Thread Philippe Mathieu-Daudé
The load/store API eases code review. Signed-off-by: Stephen Checkoway Message-Id: <20190426162624.55977-3-stephen.checko...@oberlin.edu> Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé [PMD: Extracted from bigger patch] Signed-off-by: Philippe Mathieu-Daudé ---

[Qemu-devel] [PATCH 06/13] hw/block/pflash_cfi02: Add helpers to manipulate the status bits

2019-05-05 Thread Philippe Mathieu-Daudé
Pull out all of the code to modify the status into simple helper functions. Status handling becomes more complex once multiple chips are interleaved to produce a single device. No change in functionality is intended with this commit. Signed-off-by: Stephen Checkoway Message-Id:

[Qemu-devel] [PATCH 11/13] hw/block/pflash_cfi02: Unify the MemoryRegionOps

2019-05-05 Thread Philippe Mathieu-Daudé
The pflash_read()/pflash_write() can check the device endianess via the pfl->be variable, so remove the 'int be' argument. Since the big/little MemoryRegionOps are now identical, it is pointless to declare them both. Unify them. Signed-off-by: Stephen Checkoway Message-Id:

[Qemu-devel] [PATCH 04/13] hw/block/pflash_cfi02: Fix debug format string

2019-05-05 Thread Philippe Mathieu-Daudé
Always compile the debug code to prevent format string to bitrot. Signed-off-by: Stephen Checkoway Message-Id: <20190426162624.55977-3-stephen.checko...@oberlin.edu> Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé [PMD: Extracted from bigger patch, use PRIx32]

[Qemu-devel] [PATCH 08/13] hw/block/pflash_cfi02: Use the ldst API in pflash_write()

2019-05-05 Thread Philippe Mathieu-Daudé
The load/store API eases code review. Signed-off-by: Stephen Checkoway Message-Id: <20190426162624.55977-3-stephen.checko...@oberlin.edu> Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé [PMD: Extracted from bigger patch] Signed-off-by: Philippe Mathieu-Daudé ---

[Qemu-devel] [PATCH 05/13] hw/block/pflash_cfi02: Add an enum to define the write cycles

2019-05-05 Thread Philippe Mathieu-Daudé
No change in functionality is intended with this commit. Signed-off-by: Stephen Checkoway Message-Id: <20190426162624.55977-3-stephen.checko...@oberlin.edu> Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé [PMD: Extracted from bigger patch] Signed-off-by: Philippe

[Qemu-devel] [PATCH 10/13] hw/block/pflash_cfi02: Extract the pflash_data_read() function

2019-05-05 Thread Philippe Mathieu-Daudé
Extract the code block in a new function, remove a goto statement. Signed-off-by: Stephen Checkoway Message-Id: <20190426162624.55977-3-stephen.checko...@oberlin.edu> Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé [PMD: Extracted from bigger patch, remove the XXX tracing

[Qemu-devel] [PATCH 02/13] tests/pflash-cfi02: Use the GLib API

2019-05-05 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/pflash-cfi02-test.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/tests/pflash-cfi02-test.c b/tests/pflash-cfi02-test.c index 40af1bb523e..ff775618c02 100644 --- a/tests/pflash-cfi02-test.c +++

[Qemu-devel] [PATCH 00/13] hw/block/pflash_cfi02: Clean-up and fixes

2019-05-05 Thread Philippe Mathieu-Daudé
Hi, While reviewing Stephen Checkoway's v4 "Implement missing AMD pflash functionality" [*] I found it hard (for me) to digest, so I took step by step notes. This series is the result of those notes. Regarding Stephen's series, this series only contains the generic code movement and trivial

Re: [Qemu-devel] [PATCH RFC v8 12/12] hw/registerfields.h: Add 8bit and 16bit register macros.

2019-05-05 Thread Alex Bennée
Richard Henderson writes: > On 5/3/19 8:27 AM, Alex Bennée wrote: >> >> Yoshinori Sato writes: >> >>> Some RX peripheral using 8bit and 16bit registers. >>> Added 8bit and 16bit APIs. >> >> Doesn't this mean the build breaks at some point? Features used by other >> patches should be

Re: [Qemu-devel] [PATCH v1 8/8] target/avr: Register AVR support with the rest of QEMU, the build system, and the MAINTAINERS file

2019-05-05 Thread Michael Rolnik
Hi Richard. I can maintain it Sent from my cell phone, please ignore typos On Sun, May 5, 2019, 8:57 AM Richard Henderson wrote: > On 5/4/19 1:36 AM, Sarah Harris wrote: > > Signed-off-by: Sarah Harris > ... > > > > +AVR > > +M: Michael Rolnik > > +S: Odd Fixes > > +F: target-avr/ > > +F:

[Qemu-devel] [Bug 1774830] Re: qemu monitor disassembled memory dump produces incorrect output

2019-05-05 Thread felix
** Patch added: "disas.patch" https://bugs.launchpad.net/qemu/+bug/1774830/+attachment/5261663/+files/disas.patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1774830 Title: qemu monitor

[Qemu-devel] [PATCH 5/5] hw/block/pflash_cfi02: Add the DeviceReset() handler

2019-05-05 Thread Philippe Mathieu-Daudé
The pflash device is a child of TYPE_DEVICE, so it can implement the DeviceReset handler. Actually it has to implement it, else on machine reset it might stay in an incoherent state, as it has been reported in the buglink listed below. Add the DeviceReset handler and remove its call from the

[Qemu-devel] [PATCH 4/5] hw/block/pflash_cfi02: Extract the pflash_reset() code

2019-05-05 Thread Philippe Mathieu-Daudé
The reset() code is used in various places, refactor it. Signed-off-by: Philippe Mathieu-Daudé --- hw/block/pflash_cfi02.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c index

[Qemu-devel] [PATCH 2/5] hw/block/pflash_cfi01: Extract the pflash_reset() code

2019-05-05 Thread Philippe Mathieu-Daudé
The reset() code is used in various places, refactor it. Signed-off-by: Philippe Mathieu-Daudé --- hw/block/pflash_cfi01.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index 6dc04f156a7..073cd14978f

[Qemu-devel] [PATCH 3/5] hw/block/pflash_cfi01: Add the DeviceReset() handler

2019-05-05 Thread Philippe Mathieu-Daudé
The pflash device is a child of TYPE_DEVICE, so it can implement the DeviceReset handler. Actually it has to implement it, else on machine reset it might stay in an incoherent state, as it has been reported in the buglink listed below. Add the DeviceReset handler and remove its call from the

[Qemu-devel] [PATCH 1/5] hw/block/pflash_cfi01: Removed an unused timer

2019-05-05 Thread Philippe Mathieu-Daudé
The 'CFI01' NOR flash was introduced in commit 29133e9a0fff, with timing modelled. One year later, the CFI02 model was introduced (commit 05ee37ebf630) based on the CFI01 model. As noted in the header, "It does not support timings". 12 years later, we never had to model the device timings. Time to

[Qemu-devel] [PATCH 0/5] hw/block/pflash: Add DeviceReset() handlers

2019-05-05 Thread Philippe Mathieu-Daudé
The pflash device lacks a reset() function. When a machine is resetted, the flash might be in an inconsistent state, leading to unexpected behavior: https://bugzilla.redhat.com/show_bug.cgi?id=1678713 Resolve this issue by adding a DeviceReset() handler. Both CFI01/CFI02 devices are fixed by

Re: [Qemu-devel] [PATCH v4 10/10] block/pflash_cfi02: Use the chip erase time specified in the CFI table

2019-05-05 Thread Philippe Mathieu-Daudé
On 4/26/19 6:26 PM, Stephen Checkoway wrote: > When erasing the chip, use the typical time specified in the CFI table > rather than arbitrarily selecting 5 seconds. > > Since the currently unconfigurable value set in the table is 12, this > means a chip erase takes 4096 ms so this isn't a big

Re: [Qemu-devel] [PATCH] virtfs: Add missing "id" parameter in documentation

2019-05-05 Thread Greg Kurz
Hi Thomas, Thanks for the janitoring :) On Sun, 5 May 2019 16:45:27 +0200 Thomas Huth wrote: > ... and remove the square brackets from "path" and "security_model", > since these parameters are not optional. > Well this is only true when fsdriver == local, but the other fs drivers, ie. proxy

[Qemu-devel] [PATCH] hw/timer: Compile devices not target-dependent as common objects

2019-05-05 Thread Philippe Mathieu-Daudé
All these devices do not contain any target-specific code. While most of them are arch-specific, they are shared between different targets of the same arch family (ARM and AArch64, MIPS32/MIPS64, multiple endianess, ...). Put them into common-obj-y to compile them once for all targets.

Re: [Qemu-devel] [PATCH 8/9] tcg/i386: add support for IBT

2019-05-05 Thread Richard Henderson
On 5/4/19 5:05 AM, Paolo Bonzini wrote: > Add endbr annotations before indirect branch targets. This lets QEMU enable > IBT even for TCG-enabled builds. > > Signed-off-by: Paolo Bonzini > --- > Makefile.target | 2 ++ > configure | 9 + >

Re: [Qemu-devel] [PATCH 5/9] coroutine: add host specific coroutine backend for 64-bit s390

2019-05-05 Thread Richard Henderson
On 5/4/19 5:05 AM, Paolo Bonzini wrote: > + "bras %%r3, 1f\n"/* source PC will be after the BR */ \ > + "1: aghi %%r3, 12\n" /* 4 */ \ > + "stg %%r3, %[SCRATCH](%%r1)\n" /* 6 save switch-back PC */ \ > + "br %%r4\n"

Re: [Qemu-devel] [PATCH 4/9] coroutine: add host specific coroutine backend for 64-bit ARM

2019-05-05 Thread Richard Henderson
On 5/4/19 5:05 AM, Paolo Bonzini wrote: > The speedup is similar to x86, 120 ns vs 180 ns on an APM Mustang. > > Signed-off-by: Paolo Bonzini > --- > configure| 2 +- > scripts/qemugdb/coroutine_asm.py | 6 - > util/Makefile.objs | 2 ++ >

Re: [Qemu-devel] [PATCH 3/9] coroutine: add host specific coroutine backend for 64-bit x86

2019-05-05 Thread Richard Henderson
On 5/4/19 5:05 AM, Paolo Bonzini wrote: > This backend is faster (100ns vs 150ns per switch on my laptop), but > especially it will be possible to add CET support to it. Most of the > code is actually not architecture specific. > > Signed-off-by: Paolo Bonzini > --- > configure

Re: [Qemu-devel] [PATCH RFC v8 08/12] hw/char: RX62N serical communication interface (SCI)

2019-05-05 Thread Yoshinori Sato
On Sat, 04 May 2019 00:22:44 +0900, Alex Bennée wrote: > > > Yoshinori Sato writes: > > > nit: typo in subject (serical->serial) > > > This module supported only non FIFO type. > > Hardware manual. > > https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf

Re: [Qemu-devel] [PATCH RFC v8 00/12] Add RX archtecture support

2019-05-05 Thread Yoshinori Sato
On Sat, 04 May 2019 01:11:48 +0900, Alex Bennée wrote: > > > Yoshinori Sato writes: > > > Hello. > > This patch series is added Renesas RX target emulation. > > I think the series is almost there - it's mostly just nits and clean > build fixes to sort out now. If you run the branch through CI

Re: [Qemu-devel] [PATCH RFC v8 12/12] hw/registerfields.h: Add 8bit and 16bit register macros.

2019-05-05 Thread Yoshinori Sato
On Sat, 04 May 2019 00:27:29 +0900, Alex Bennée wrote: > > > Yoshinori Sato writes: > > > Some RX peripheral using 8bit and 16bit registers. > > Added 8bit and 16bit APIs. > > Doesn't this mean the build breaks at some point? Features used by other > patches should be introduced first so the

Re: [Qemu-devel] [PATCH RFC v8 01/12] target/rx: TCG translation

2019-05-05 Thread Yoshinori Sato
On Sat, 04 May 2019 03:43:23 +0900, Richard Henderson wrote: > > On 5/2/19 7:33 AM, Yoshinori Sato wrote: > > +/* conditional branch helper */ > > +static void rx_bcnd_main(DisasContext *ctx, int cd, int dst) > > +{ > > +DisasCompare dc; > > +TCGLabel *t, *done; > > + > > +switch (cd)

Re: [Qemu-devel] [PATCH RFC v8 05/12] target/rx: Miscellaneous files

2019-05-05 Thread Yoshinori Sato
On Sat, 04 May 2019 01:06:44 +0900, Alex Bennée wrote: > > > Yoshinori Sato writes: > > > Signed-off-by: Yoshinori Sato > > --- > > target/rx/gdbstub.c | 112 > > > > target/rx/monitor.c | 38 > >

Re: [Qemu-devel] [PATCH RFC v8 09/12] hw/rx: RX Target hardware definition

2019-05-05 Thread Yoshinori Sato
On Sat, 04 May 2019 00:38:38 +0900, Alex Bennée wrote: > > > Yoshinori Sato writes: > > > rx62n - RX62N cpu. > > rxqemu - QEMU virtual target. > > > > Signed-off-by: Yoshinori Sato > > --- > > include/hw/rx/rx.h| 7 ++ > > include/hw/rx/rx62n.h | 54 > > hw/rx/rx62n.c

Re: [Qemu-devel] [PATCH RFC v8 07/12] hw/timer: RX62N internal timer modules

2019-05-05 Thread Yoshinori Sato
On Sat, 04 May 2019 00:20:47 +0900, Alex Bennée wrote: > > > Yoshinori Sato writes: > > > renesas_tmr: 8bit timer modules. > > renesas_cmt: 16bit compare match timer modules. > > This part use many renesas's CPU. > > Hardware manual. > >

Re: [Qemu-devel] [RFC PATCH] tests/qemu-iotests: re-format output to for make check-block

2019-05-05 Thread Thomas Huth
On 03/05/2019 16.39, Alex Bennée wrote: > This attempts to clean-up the output to better match the output of the > rest of the QEMU check system. This includes: > > - formatting as " TESTiotest: nnn" > - calculating time diff at the end > - only dumping config on failure > >

Re: [Qemu-devel] [PATCH 02/14] target/ppc: remove getVSR()/putVSR() from mem_helper.c

2019-05-05 Thread Richard Henderson
On 5/5/19 8:49 AM, Mark Cave-Ayland wrote: > Okay in that case I'll leave it as-is. So just to satisfy my curiosity here: > is the > problem here the mixing and matching of offsets and TCG globals, rather than > the use > of offsets as done for the VMX/VSX registers? Correct. r~

Re: [Qemu-devel] [PATCH v1 8/8] target/avr: Register AVR support with the rest of QEMU, the build system, and the MAINTAINERS file

2019-05-05 Thread Richard Henderson
On 5/4/19 1:36 AM, Sarah Harris wrote: > Signed-off-by: Sarah Harris ... > > +AVR > +M: Michael Rolnik > +S: Odd Fixes > +F: target-avr/ > +F: hw/avr/ > + This is not how things work. Michael wasn't up to maintaining the code 2 years ago; that's why it was never committed. You would need to

Re: [Qemu-devel] [RFC PATCH] tests/qemu-iotests: re-format output to for make check-block

2019-05-05 Thread Thomas Huth
On 03/05/2019 18.15, Alex Bennée wrote: > > Thomas Huth writes: > >> On 03/05/2019 16.39, Alex Bennée wrote: >>> This attempts to clean-up the output to better match the output of the >>> rest of the QEMU check system. This includes: >>> >>> - formatting as " TESTiotest: nnn" >>> -

Re: [Qemu-devel] [PATCH 14/14] target/ppc: improve VSX_FMADD with new GEN_VSX_HELPER_VSX_MADD macro

2019-05-05 Thread Mark Cave-Ayland
On 05/05/2019 16:17, Richard Henderson wrote: > On 5/5/19 3:20 AM, Mark Cave-Ayland wrote: >>> The afrm argument is no longer used. >>> This also means that e.g. >>> >>> VSX_MADD(xsmaddadp, 1, float64, VsrD(0), MADD_FLGS, 1, 1, 0) >>> VSX_MADD(xsmaddmdp, 1, float64, VsrD(0), MADD_FLGS, 0, 1, 0)

Re: [Qemu-devel] [PATCH 02/14] target/ppc: remove getVSR()/putVSR() from mem_helper.c

2019-05-05 Thread Mark Cave-Ayland
On 05/05/2019 15:34, Richard Henderson wrote: > On 5/5/19 2:34 AM, Mark Cave-Ayland wrote: EA = tcg_temp_new();\ -xt = tcg_const_tl(xT(ctx->opcode)); \ gen_set_access_type(ctx, ACCESS_INT);

Re: [Qemu-devel] [PATCH v1 1/8] target/avr: Add instruction decoder

2019-05-05 Thread Richard Henderson
On 5/4/19 1:36 AM, Sarah Harris wrote: > This utility module builds a decision tree to decode instructions, starting > from a human readable list of instruction bit patterns. > Automatic tree generation will hopefully be more efficient and more > maintainable than a hand-designed opcode parser.

Re: [Qemu-devel] [PATCH 01/14] target/ppc: remove getVSR()/putVSR() from fpu_helper.c

2019-05-05 Thread Mark Cave-Ayland
On 05/05/2019 15:31, Richard Henderson wrote: > On 5/5/19 2:27 AM, Mark Cave-Ayland wrote: >> I've spent a bit of time today going through the functions and it seems that >> all >> functions which have an xt parameter, minus a couple of the TEST macros, >> require the >> result to be calculated

Re: [Qemu-devel] [PATCH 0/9] Assembly coroutine backend and x86 CET support

2019-05-05 Thread Alex Bennée
Paolo Bonzini writes: > *** BLURB HERE *** I assume there was going to be a bit more background here? -- Alex Bennée

Re: [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

2019-05-05 Thread Peter Maydell
On Sun, 5 May 2019 at 08:02, Xiang Zheng wrote: > > Currently we fill the memory space with two 64MB NOR images when > using persistent UEFI variables on virt board. Actually we only use > a very small(non-zero) part of the memory while the rest significant > large(zero) part of memory is wasted.

Re: [Qemu-devel] [PATCH v1 5/5] hw/arm: Add the Netduino Plus 2

2019-05-05 Thread Peter Maydell
On Sat, 4 May 2019 at 06:26, Alistair Francis wrote: > Ah, it seems like -device loader doesn't work, it looks like not > setting the thumb register causes this core dump: > > qemu: fatal: Lockup: can't escalate 3 to HardFault (current priority -1) > > R00=2000 R01=0574 R02=200015d0

[Qemu-devel] [PATCH 2/3] hw/ppc/40p: Move the MC146818 RTC to the board where it belongs

2019-05-05 Thread Philippe Mathieu-Daudé
The MC146818 RTC was incorrectly added to the i82378 chipset in commit a04ff940974a. In the next commit (506b7ddf8893) the PReP machine use the i82378. Since the MC146818 is specific to the PReP machine, move its use there. Fixes: a04ff940974a Signed-off-by: Philippe Mathieu-Daudé ---

[Qemu-devel] [PATCH 1/3] hw/ppc/prep: use TYPE_MC146818_RTC instead of a hardcoded string

2019-05-05 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/prep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c index b7f459d4754..ebee3211480 100644 --- a/hw/ppc/prep.c +++ b/hw/ppc/prep.c @@ -601,7 +601,7 @@ static int

[Qemu-devel] [PATCH 3/3] hw/ppc/40p: use 1900 as a base year

2019-05-05 Thread Philippe Mathieu-Daudé
From: Artyom Tarasenko AIX 5.1 expects the base year to be 1900. Adjust accordingly. Signed-off-by: Artyom Tarasenko Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/prep.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c index

[Qemu-devel] [PATCH 0/3] hw/ppc/40p: Move the MC146818 RTC to the board where it belongs

2019-05-05 Thread Philippe Mathieu-Daudé
Hi, This series is to properly do the fix sent by Artyom here: https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg02264.html There is no RTC on the i82378, move it to the board code, set the base year there. Regards, Phil. Artyom Tarasenko (1): hw/ppc/40p: use 1900 as a base year

Re: [Qemu-devel] [PATCH v2 3/3] hw/isa/i82378.c: use 1900 as a base year

2019-05-05 Thread Philippe Mathieu-Daudé
Hi Mark, Artyom. On 5/5/19 12:46 PM, Mark Cave-Ayland wrote: > On 04/05/2019 22:02, Artyom Tarasenko wrote: > >> AIX 5.1 expects the base year to be 1900. Adjust accordingly. >> >> Signed-off-by: Artyom Tarasenko >> Reviewed-by: Hervé Poussineau >> --- >> hw/isa/i82378.c | 4 +++- >> 1 file

Re: [Qemu-devel] [PATCH 14/14] target/ppc: improve VSX_FMADD with new GEN_VSX_HELPER_VSX_MADD macro

2019-05-05 Thread Richard Henderson
On 5/5/19 3:20 AM, Mark Cave-Ayland wrote: >> The afrm argument is no longer used. >> This also means that e.g. >> >> VSX_MADD(xsmaddadp, 1, float64, VsrD(0), MADD_FLGS, 1, 1, 0) >> VSX_MADD(xsmaddmdp, 1, float64, VsrD(0), MADD_FLGS, 0, 1, 0) >> >> are redundant. Similarly with all of the other

Re: [Qemu-devel] [PATCH] tests/docker: Test more components on the Fedora default image

2019-05-05 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Install optional dependencies of QEMU to get better coverage. > > The following components are now enabled: > > $ ./configure > ... > Multipath support yes > VNC SASL support yes > RDMA support yes > PVRDMA supportyes > libiscsi support

[Qemu-devel] [Bug 1462640] Re: shmat fails on 32-to-64 setup

2019-05-05 Thread Thomas Huth
Which version of QEMU did you use here? Does it still reproduce with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH 05/14] target/ppc: introduce GEN_VSX_HELPER_X2 macro to fpu_helper.c

2019-05-05 Thread Richard Henderson
On 5/5/19 2:57 AM, Mark Cave-Ayland wrote: > For reference the culprits here is helper_xscvqpdp(). But again if you agree > that it > makes sense to create separate gen/helper functions then I can remove the > opcode > later on in the series. Yes. Or indeed in a completely separate series.

Re: [Qemu-devel] [PATCH] qcow2: Fix error handling in the compression code

2019-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190430100802.15368-1-be...@igalia.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

[Qemu-devel] [Bug 1583421] Re: Please provide an option to print the default hardware configuration as command-line options, to make -nodefaults easier to use

2019-05-05 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1583421 Title: Please provide an option to print the default hardware configuration as

Re: [Qemu-devel] [PATCH 04/14] target/ppc: introduce GEN_VSX_HELPER_X3 macro to fpu_helper.c

2019-05-05 Thread Richard Henderson
On 5/5/19 2:52 AM, Mark Cave-Ayland wrote: > Right, it looks like VSX_CMP is the culprit here. Am I right in thinking that > it's > best to remove the opc parameter from GEN_VSX_HELPER_X3 above, and then have a > separate gen and helper function for just the VSX_CMP instructions? > Presumably

[Qemu-devel] [PATCH] virtfs: Add missing "id" parameter in documentation

2019-05-05 Thread Thomas Huth
... and remove the square brackets from "path" and "security_model", since these parameters are not optional. Buglink: https://bugs.launchpad.net/qemu/+bug/1581976 Signed-off-by: Thomas Huth --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx

Re: [Qemu-devel] [PATCH 02/14] target/ppc: remove getVSR()/putVSR() from mem_helper.c

2019-05-05 Thread Richard Henderson
On 5/5/19 2:34 AM, Mark Cave-Ayland wrote: >>> EA = tcg_temp_new();\ >>> -xt = tcg_const_tl(xT(ctx->opcode)); \ >>> gen_set_access_type(ctx, ACCESS_INT); \ >>> gen_addr_register(ctx, EA);

Re: [Qemu-devel] [PATCH 01/14] target/ppc: remove getVSR()/putVSR() from fpu_helper.c

2019-05-05 Thread Richard Henderson
On 5/5/19 2:27 AM, Mark Cave-Ayland wrote: > I've spent a bit of time today going through the functions and it seems that > all > functions which have an xt parameter, minus a couple of the TEST macros, > require the > result to be calculated in a local variable first. > > I think the best

[Qemu-devel] [PULL 23/28] hw/arm: Express dependencies of the remaining IMX boards with Kconfig

2019-05-05 Thread Thomas Huth
IMX25, IMX7 and IMX6UL were still missing the Kconfig dependencies. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 2 -- hw/arm/Kconfig | 19 +++ 2 files changed, 19

[Qemu-devel] [PULL 27/28] hw/arm: Express dependencies of the musca machines with Kconfig

2019-05-05 Thread Thomas Huth
Dependencies have been determined with trial-and-error and by looking at the musca.c source file. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- hw/arm/Kconfig | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PULL 25/28] hw/arm: Express dependencies of the ZynqMP zcu102 machine with Kconfig

2019-05-05 Thread Thomas Huth
This cleans up most settings in default-configs/aarch64-softmmu.mak. Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/aarch64-softmmu.mak | 4 hw/arm/Kconfig | 11

[Qemu-devel] [PULL 28/28] hw/arm: Remove hard-enablement of the remaining PCI devices

2019-05-05 Thread Thomas Huth
The PCI devices should be pulled in by default if PCI_DEVICES is set, so there is no need anymore to enforce them in the configs file. Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 8 1 file changed, 8 deletions(-) diff --git

[Qemu-devel] [PULL 24/28] hw/arm: Express dependencies of the microbit / nrf51 machine with Kconfig

2019-05-05 Thread Thomas Huth
Add Kconfig dependencies for the NRF51 / microbit machine. Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 3 +-- hw/arm/Kconfig | 6 ++

[Qemu-devel] [PULL 22/28] hw/arm: Express dependencies of the MSF2 / EMCRAFT_SF2 machine with Kconfig

2019-05-05 Thread Thomas Huth
Add Kconfig dependencies for the emcraft-sf2 machine - we also distinguish between the machine (CONFIG_EMCRAFT_SF2) and the SoC (CONFIG_MSF2) now. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 3 +--

[Qemu-devel] [PULL 26/28] hw/arm: Express dependencies of the xlnx-versal-virt machine with Kconfig

2019-05-05 Thread Thomas Huth
Dependencies have been determined with trial-and-error and by looking at the xlnx-versal.c source file. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- hw/arm/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/hw/arm/Kconfig

[Qemu-devel] [PULL 21/28] hw/arm: Express dependencies of sabrelite with Kconfig

2019-05-05 Thread Thomas Huth
Add Kconfig dependencies for the Sabrelite / iMX6 machine. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 4 +--- hw/arm/Kconfig | 9 + hw/arm/Makefile.objs| 3 ++- 3

[Qemu-devel] [PULL 20/28] hw/arm: Express dependencies of canon-a1100 with Kconfig

2019-05-05 Thread Thomas Huth
Add Kconfig dependencies for the DIGIC / canon-a1100 machine. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 2 +- hw/arm/Kconfig | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)

  1   2   >