Re: [Qemu-devel] [PATCH v3 0/5] build: cleanup in Makefile.objs

Will send it out this week. Paolo Il lun 13 mag 2019, 16:18 Laurent Vivier ha scritto: > On 02/04/2019 10:08, Paolo Bonzini wrote: > > On 01/04/19 16:12, Laurent Vivier wrote: > >> This cleanup removes hardware objects from the list of files to be > >> built for linux-user only targets. > >>

Re: [Qemu-devel] [PATCH 05/13] target/arm/kvm: Add kvm_arch_get/put_sve

On Mon, May 13, 2019 at 04:40:52PM +0100, Peter Maydell wrote: > On Mon, 13 May 2019 at 16:31, Dave Martin wrote: > > > > On Mon, May 13, 2019 at 02:55:01PM +0100, Andrew Jones wrote: > > > QEMU keeps its 128-bit and larger words in the same order (least > > > significant word first) for both

Re: [Qemu-devel] [PULL 0/9] Miscellaneous patches for 2019-05-13

On Mon, 13 May 2019 at 09:24, Markus Armbruster wrote: > > This is actually a fixed rebase of "[PULL for-4.1 0/9] Miscellaneous > patches for 2019-04-18", but that subject has since become misleading, > so I changed it. > > v2: > * Back out the change to tests/fp/platform.h that breaks big endian

[Qemu-devel] [PATCH] tests/libqtest: Fix description of qtest_vinitf() and qtest_initf()

These functions are convenience wrappers of qtest_init() and not of qtest_start(). Signed-off-by: Thomas Huth --- tests/libqtest.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/libqtest.h b/tests/libqtest.h index 3f7675fcf0..a98ea15b7d 100644 ---

Re: [Qemu-devel] [PATCH v3 2/2] block: Make bdrv_root_attach_child() unref child_bs on failure

On Mon 13 May 2019 04:31:16 PM CEST, Max Reitz wrote: >> @@ -2569,10 +2582,6 @@ BdrvChild *bdrv_open_child(const char *filename, >> } >> >> c = bdrv_attach_child(parent, bs, bdref_key, child_role, errp); >> -if (!c) { >> -bdrv_unref(bs); >> -return NULL; >> -}

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Make block error codes consistent

On 5/12/19 11:46 AM, Wensheng Tang wrote: > (The last email does not include signed-off-by line. Please ignoreit) > > We should keep the error handling consistent. ENOMEDIUM is more meaningful > than ENOENT a when driver cannot be loaded. > Consistent with what? Why is it more meaningful?

[Qemu-devel] [PATCH v2] iotests: Filter 175's allocation information

It is possible for an empty file to take up blocks on a filesystem. Make iotest 175 take this into account. Reported-by: Thomas Huth Signed-off-by: Max Reitz --- v2: [Nir] - Use a function for filtering - s/empty_blocks/extra_blocks/ --- tests/qemu-iotests/175 | 26

Re: [Qemu-devel] [PATCH v3 2/2] block: Make bdrv_root_attach_child() unref child_bs on failure

On 13.05.19 17:52, Alberto Garcia wrote: > On Mon 13 May 2019 04:31:16 PM CEST, Max Reitz wrote: >>> @@ -2569,10 +2582,6 @@ BdrvChild *bdrv_open_child(const char *filename, >>> } >>> >>> c = bdrv_attach_child(parent, bs, bdref_key, child_role, errp); >>> -if (!c) { >>> -

Re: [Qemu-devel] [PATCH 05/13] target/arm/kvm: Add kvm_arch_get/put_sve

On Mon, 13 May 2019 at 16:31, Dave Martin wrote: > > On Mon, May 13, 2019 at 02:55:01PM +0100, Andrew Jones wrote: > > QEMU keeps its 128-bit and larger words in the same order (least > > significant word first) for both host endian types. We need to > > do word swapping every time we set/get

Re: [Qemu-devel] [PATCH] iotests: Filter 175's allocation information

On 13.05.19 17:33, John Snow wrote: > > > On 5/13/19 9:20 AM, Max Reitz wrote: >> On 10.05.19 23:45, Nir Soffer wrote: >>> On Sat, May 11, 2019 at 12:19 AM Max Reitz >> > wrote: >>> >>> It is possible for an empty file to take up blocks on a filesystem. >>> Make

[Qemu-devel] Porting NATS test cases to Avocado

Hi, NEMU has test cases written with the NATS framework. They could be upstreamed into qemu.git and converted to use the Avocado framework. This way the existing NATS test cases can become part of qemu.git and also run by upstream CI. At the OpenStack Denver PTG event I suggested to Samuel that

Re: [Qemu-devel] [PATCH 13/13] target/arm/kvm: host cpu: Add support for sve-vls-map

Andrew Jones writes: > Allow the host cpu type to enable SVE in guests with the sve-vls-map > cpu property. > > Signed-off-by: Andrew Jones > --- > target/arm/cpu.c | 1 + > target/arm/cpu.h | 2 ++ > target/arm/cpu64.c | 12 +--- > 3 files changed, 12 insertions(+), 3

Re: [Qemu-devel] [PATCH] iotests: Filter 175's allocation information

On 5/13/19 9:20 AM, Max Reitz wrote: > On 10.05.19 23:45, Nir Soffer wrote: >> On Sat, May 11, 2019 at 12:19 AM Max Reitz > > wrote: >> >> It is possible for an empty file to take up blocks on a filesystem. >> Make iotest 175 take this into account. >> >>

Re: [Qemu-devel] [PATCH 05/13] target/arm/kvm: Add kvm_arch_get/put_sve

On Mon, May 13, 2019 at 02:55:01PM +0100, Andrew Jones wrote: > On Mon, May 13, 2019 at 01:31:11PM +0100, Dave Martin wrote: > > On Sun, May 12, 2019 at 09:36:16AM +0100, Andrew Jones wrote: > > > These are the SVE equivalents to kvm_arch_get/put_fpsimd. > > > > > > Signed-off-by: Andrew Jones >

Re: [Qemu-devel] [libvirt] QMP; unsigned 64-bit ints; JSON standards compliance

On 5/13/19 8:53 AM, Markus Armbruster wrote: >> We have a few options >> >> 1. Use string format for values > 2^53-1, int format below that >> 2. Use string format for all fields which are 64-bit ints whether >> signed or unsigned >> 3. Use string format for all fields which are integers,

Re: [Qemu-devel] [PATCH v3] chardev/char-i2c: Implement Linux I2C character device

Ernest Esene writes: > Add support for Linux I2C character device for I2C device passthrough > For example: > -chardev i2c,address=0x46,path=/dev/i2c-N,id=i2c-chardev > > QEMU supports emulation of I2C devices in software but currently can't > passthrough to real I2C devices. This feature is

Re: [Qemu-devel] [PATCH v3 0/5] build: cleanup in Makefile.objs

On 02/04/2019 10:08, Paolo Bonzini wrote: On 01/04/19 16:12, Laurent Vivier wrote: This cleanup removes hardware objects from the list of files to be built for linux-user only targets. It also builds traces files only when the related file is built. Tested with all combinations of

Re: [Qemu-devel] [PATCH 11/13] target/arm/cpu64: max cpu: Introduce sve-vls-map

Andrew Jones writes: > Introduce another cpu property to control SVE vector lengths, > sve-vls-map, which allows the user to explicitly select the > set of vector lengths the guest can use. The map must conform > to QEMU's limits and architectural constraints, checked when > the property is set.

[Qemu-devel] [PATCH v2] blockdev: fix missed target unref for drive-backup

If the bitmap can't be used for whatever reason, we skip putting down the reference. Fix that. In practice, this means that if you attempt to gracefully exit QEMU after a backup command being rejected, bdrv_close_all will fail and tell you some unpleasant things via assert(). Reported-by: aihua

Re: [Qemu-devel] [PULL SUBSYSTEM s390x 0/3] s390-ccw-bios: Skip bootmap signature entries

On Wed, 8 May 2019 11:48:54 +0200 Thomas Huth wrote: > This pull request is not for master. > > > Hi Cornelia, > > the following changes since commit a6f6d24757a73f7176989134b97284a1a7df11e5: > > Merge remote-tracking branch > 'remotes/kraxel/tags/vga-20190507-pull-request' into staging

Re: [Qemu-devel] [PATCH] blockdev: fix missed target unref for drive-backup

On 5/13/19 7:13 AM, Kevin Wolf wrote: > Am 10.05.2019 um 23:52 hat John Snow geschrieben: >> If the bitmap can't be used for whatever reason, we skip putting down >> the reference. Fix that. >> >> In practice, this means that if you attempt to gracefully exit QEMU >> after a backup command

Re: [Qemu-devel] [PATCH] nbd/server: Nicer spelling of max BLOCK_STATUS reply length

13.05.2019 17:31, Eric Blake wrote: > On 5/13/19 5:03 AM, Vladimir Sementsov-Ogievskiy wrote: >> 10.05.2019 18:17, Eric Blake wrote: >>> Commit 3d068aff (3.0) introduced NBD_MAX_BITMAP_EXTENTS as a limit on >>> how large we would allow a reply to NBD_CMD_BLOCK_STATUS to grow when >>> it is

Re: [Qemu-devel] [PATCH 05/13] target/arm/kvm: Add kvm_arch_get/put_sve

On Mon, May 13, 2019 at 03:07:26PM +0100, Andrew Jones wrote: > On Mon, May 13, 2019 at 01:43:56PM +0100, Dave Martin wrote: > > On Sun, May 12, 2019 at 09:36:16AM +0100, Andrew Jones wrote: > > > These are the SVE equivalents to kvm_arch_get/put_fpsimd. > > > > > > Signed-off-by: Andrew Jones >

Re: [Qemu-devel] [PATCH 11/13] target/arm/cpu64: max cpu: Introduce sve-vls-map

On Mon, May 13, 2019 at 02:45:12PM +0100, Andrew Jones wrote: > On Mon, May 13, 2019 at 02:12:48PM +0100, Dave Martin wrote: > > On Mon, May 13, 2019 at 01:57:40PM +0100, Andrew Jones wrote: > > > On Mon, May 13, 2019 at 01:41:26PM +0100, Dave Martin wrote: > > > > On Mon, May 13, 2019 at

Re: [Qemu-devel] [PATCH v3 0/2] block: Use bdrv_unref_child() for all children in bdrv_close()

On 13.05.19 15:46, Alberto Garcia wrote: > Hi, > > the first patch is the same as in v2 (with an updated commit > message). The second patch is new and makes bdrv_root_attach_child() > unref child_bs on failure, as suggested by Max. > > Regards, > > Berto > > v2:

Re: [Qemu-devel] [PATCH] nbd/server: Nicer spelling of max BLOCK_STATUS reply length

On 5/13/19 5:03 AM, Vladimir Sementsov-Ogievskiy wrote: > 10.05.2019 18:17, Eric Blake wrote: >> Commit 3d068aff (3.0) introduced NBD_MAX_BITMAP_EXTENTS as a limit on >> how large we would allow a reply to NBD_CMD_BLOCK_STATUS to grow when >> it is visiting a qemu:dirty-bitmap: context. Later,

Re: [Qemu-devel] [PATCH v3 2/2] block: Make bdrv_root_attach_child() unref child_bs on failure

On 13.05.19 15:46, Alberto Garcia wrote: > A consequence of the previous patch is that bdrv_attach_child() > transfers the reference to child_bs from the caller to parent_bs, > which will drop it on bdrv_close() or when someone calls > bdrv_unref_child(). > > But this only happens when

Re: [Qemu-devel] [PATCH 05/13] target/arm/kvm: Add kvm_arch_get/put_sve

On Mon, May 13, 2019 at 01:43:56PM +0100, Dave Martin wrote: > On Sun, May 12, 2019 at 09:36:16AM +0100, Andrew Jones wrote: > > These are the SVE equivalents to kvm_arch_get/put_fpsimd. > > > > Signed-off-by: Andrew Jones > > --- > > target/arm/kvm64.c | 127

[Qemu-devel] [PATCH v11 01/12] target/rx: TCG translation

From: Yoshinori Sato This part only supported RXv1 instructions. Instruction manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01us0032ej0120_rxsm.pdf Signed-off-by: Yoshinori Sato Signed-off-by: Yoshinori Sato --- target/rx/Makefile.objs | 12 +

[Qemu-devel] [PATCH v11 02/12] target/rx: TCG helper

From: Yoshinori Sato Signed-off-by: Yoshinori Sato Signed-off-by: Yoshinori Sato --- target/rx/helper.c| 148 target/rx/helper.h| 31 target/rx/op_helper.c | 481 ++ 3 files changed, 660 insertions(+) create mode

Re: [Qemu-devel] QMP; unsigned 64-bit ints; JSON standards compliance

On Mon, May 13, 2019 at 03:53:19PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Wed, May 08, 2019 at 02:44:07PM +0200, Markus Armbruster wrote: > [...] > >> Double-checking: do you propose to encode *all* numbers as strings, or > >> just certain "problematic" numbers? >

[Qemu-devel] [PATCH v11 06/12] hw/timer: RX62N internal timer modules

From: Yoshinori Sato renesas_tmr: 8bit timer modules. renesas_cmt: 16bit compare match timer modules. This part use many renesas's CPU. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Signed-off-by:

[Qemu-devel] [PATCH v11 07/12] hw/char: RX62N serial communication interface (SCI)

From: Yoshinori Sato This module supported only non FIFO type. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Signed-off-by: Yoshinori Sato --- hw/char/Kconfig | 3 +

Re: [Qemu-devel] QMP; unsigned 64-bit ints; JSON standards compliance

Daniel P. Berrangé writes: > On Mon, May 13, 2019 at 01:29:34PM +0100, Dr. David Alan Gilbert wrote: >> * Daniel P. Berrangé (berra...@redhat.com) wrote: >> > On Wed, May 08, 2019 at 02:44:07PM +0200, Markus Armbruster wrote: >> > > Daniel P. Berrangé writes: >> > > >> > > > On Tue, May 07,

[Qemu-devel] [PATCH v11 03/12] target/rx: CPU definition

From: Yoshinori Sato Signed-off-by: Yoshinori Sato Signed-off-by: Yoshinori Sato --- target/rx/cpu.c | 222 ++ target/rx/cpu.h | 227 target/rx/gdbstub.c | 112

[Qemu-devel] [PATCH v11 05/12] hw/intc: RX62N interrupt controller (ICUa)

From: Yoshinori Sato This implementation supported only ICUa. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Signed-off-by: Yoshinori Sato --- hw/intc/Kconfig | 3 + hw/intc/Makefile.objs

[Qemu-devel] [PATCH v11 10/12] qemu/bitops.h: Add extract8 and extract16

From: Yoshinori Sato Signed-off-by: Yoshinori Sato Signed-off-by: Yoshinori Sato --- include/qemu/bitops.h | 38 ++ 1 file changed, 38 insertions(+) diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h index 3f0926cf40..764f9d1ea0 100644 ---

[Qemu-devel] [PATCH v11 11/12] Add rx-softmmu

From: Yoshinori Sato Signed-off-by: Yoshinori Sato Signed-off-by: Yoshinori Sato --- arch_init.c| 2 ++ configure | 8 default-configs/rx-softmmu.mak | 3 +++ hw/Kconfig | 1 + include/sysemu/arch_init.h | 1 + 5 files

[Qemu-devel] [PATCH v11 08/12] hw/rx: RX Target hardware definition

From: Yoshinori Sato rx62n - RX62N cpu. rx-virt - RX QEMU virtual target. Signed-off-by: Yoshinori Sato Signed-off-by: Yoshinori Sato --- hw/rx/Kconfig | 14 +++ hw/rx/Makefile.objs | 2 + hw/rx/rx-virt.c | 105 ++ hw/rx/rx62n.c | 238

[Qemu-devel] [PATCH v11 09/12] hw/registerfields.h: Add 8bit and 16bit register macros.

From: Yoshinori Sato Some RX peripheral using 8bit and 16bit registers. Added 8bit and 16bit APIs. Signed-off-by: Yoshinori Sato Signed-off-by: Yoshinori Sato --- include/hw/registerfields.h | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v11 00/12] Add RX archtecture support

Hello. This patch series is added Renesas RX target emulation. Fixed build errors and cleaned up the code. My git repository is bellow. git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git tags/rx-20190513 Testing binaries bellow. u-boot Download - https://osdn.net/users/ysato/pf/qemu/dl/u

[Qemu-devel] [PATCH v11 04/12] target/rx: RX disassembler

From: Yoshinori Sato Signed-off-by: Yoshinori Sato Signed-off-by: Yoshinori Sato --- include/disas/dis-asm.h |5 + target/rx/disas.c | 1480 +++ 2 files changed, 1485 insertions(+) create mode 100644 target/rx/disas.c diff --git

[Qemu-devel] [PATCH v11 12/12] MAINTAINERS: Add RX

From: Yoshinori Sato Signed-off-by: Yoshinori Sato Signed-off-by: Yoshinori Sato --- MAINTAINERS | 19 +++ 1 file changed, 19 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 66ddbda9c9..1599eb6a72 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -272,6 +272,13 @@ F:

Re: [Qemu-devel] [PATCH 1/6] qemu-bridge-helper: Fix misuse of isspace()

On Mon, 13 May 2019 at 14:21, Markus Armbruster wrote: > Perhaps I should do it just for this file while I touch it anyway. The > question to ask: should parse_acl_file() obey the locale for whitespace > recognition? I vote for "no". Q: do we document the format of the ACL file anywhere ?

Re: [Qemu-devel] [PATCH 05/13] target/arm/kvm: Add kvm_arch_get/put_sve

On Mon, May 13, 2019 at 01:31:11PM +0100, Dave Martin wrote: > On Sun, May 12, 2019 at 09:36:16AM +0100, Andrew Jones wrote: > > These are the SVE equivalents to kvm_arch_get/put_fpsimd. > > > > Signed-off-by: Andrew Jones > > --- > > target/arm/kvm64.c | 127

Re: [Qemu-devel] QMP; unsigned 64-bit ints; JSON standards compliance

Daniel P. Berrangé writes: > On Wed, May 08, 2019 at 02:44:07PM +0200, Markus Armbruster wrote: [...] >> Double-checking: do you propose to encode *all* numbers as strings, or >> just certain "problematic" numbers? >> >> If the latter, I guess your idea of "problematic" is "not representable >>

Re: [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

Kevin Wolf writes: > Am 13.05.2019 um 13:59 hat Markus Armbruster geschrieben: >> Xiang Zheng writes: >> >> > On 2019/5/10 23:16, Markus Armbruster wrote: >> >> Xiang Zheng writes: >> >> >> >>> On 2019/5/9 19:59, Markus Armbruster wrote: >> Xiang Zheng writes: >> >> > On

Re: [Qemu-devel] [PATCH v7 0/5] backup-top: preparing refactoring

On 29.04.19 11:08, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here some refactoring patches, as a first step for backup-top filter > introduction. > > v7: > 01,03,04: add Max's r-b > 05: fix s/return NULL/goto error/ [Max] > > v6: > 01: - use end_cluster instead of last_cluster and fix

[Qemu-devel] [PATCH v3 2/2] block: Make bdrv_root_attach_child() unref child_bs on failure

A consequence of the previous patch is that bdrv_attach_child() transfers the reference to child_bs from the caller to parent_bs, which will drop it on bdrv_close() or when someone calls bdrv_unref_child(). But this only happens when bdrv_attach_child() succeeds. If it fails then the caller is

Re: [Qemu-devel] [PATCH 11/13] target/arm/cpu64: max cpu: Introduce sve-vls-map

On Mon, May 13, 2019 at 02:12:48PM +0100, Dave Martin wrote: > On Mon, May 13, 2019 at 01:57:40PM +0100, Andrew Jones wrote: > > On Mon, May 13, 2019 at 01:41:26PM +0100, Dave Martin wrote: > > > On Mon, May 13, 2019 at 01:30:23PM +0100, Andrew Jones wrote: > > > > On Mon, May 13, 2019 at

[Qemu-devel] [PATCH v3 1/2] block: Use bdrv_unref_child() for all children in bdrv_close()

bdrv_unref_child() does the following things: - Updates the child->bs->inherits_from pointer. - Calls bdrv_detach_child() to remove the BdrvChild from bs->children. - Calls bdrv_unref() to unref the child BlockDriverState. When bdrv_unref_child() was introduced in commit 33a604075c it was

[Qemu-devel] [PATCH v3 0/2] block: Use bdrv_unref_child() for all children in bdrv_close()

Hi, the first patch is the same as in v2 (with an updated commit message). The second patch is new and makes bdrv_root_attach_child() unref child_bs on failure, as suggested by Max. Regards, Berto v2: https://lists.gnu.org/archive/html/qemu-block/2019-05/msg00325.html v1:

Re: [Qemu-devel] [PATCH] qcow2: Define and use QCOW2_COMPRESSED_SECTOR_SIZE

On Mon 13 May 2019 03:14:40 PM CEST, Stefano Garzarella wrote: >> Since the maximum allowed cluster size is 2MB, the value of the >> 'size' variable can never be larger than 4MB, which fits comfortably >> on a 32-bit integer. We would need to support 512MB clusters in order >> to have problems

Re: [Qemu-devel] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

On Fri, May 10, 2019 at 11:48:38AM +0200, Cornelia Huck wrote: > On Fri, 10 May 2019 10:36:09 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Cornelia Huck (coh...@redhat.com) wrote: > > > On Thu, 9 May 2019 17:48:26 +0100 > > > "Dr. David Alan Gilbert" wrote: > > > > > > > * Cornelia Huck

Re: [Qemu-devel] [RFC PATCH] target/arm: semihosting docs, formatting and return clean-ups

On Fri, 10 May 2019 at 20:10, Alex Bennée wrote: > > This is a clean-up of the semihosting calls after reading ver 2.0 of > the specification. There are a number of small fixes that seemed too > insignificant to split into smaller patches: > > - add reference to the ARM semihosting spec > -

Re: [Qemu-devel] [PATCH 11/13] target/arm/cpu64: max cpu: Introduce sve-vls-map

On Mon, May 13, 2019 at 01:57:40PM +0100, Andrew Jones wrote: > On Mon, May 13, 2019 at 01:41:26PM +0100, Dave Martin wrote: > > On Mon, May 13, 2019 at 01:30:23PM +0100, Andrew Jones wrote: > > > On Mon, May 13, 2019 at 12:26:36PM +0100, Dave Martin wrote: > > > > On Sun, May 12, 2019 at

Re: [Qemu-devel] [PATCH] iotests: Filter 175's allocation information

On 10.05.19 23:45, Nir Soffer wrote: > On Sat, May 11, 2019 at 12:19 AM Max Reitz > wrote: > > It is possible for an empty file to take up blocks on a filesystem. > Make iotest 175 take this into account. > > Reported-by: Thomas Huth

Re: [Qemu-devel] [PATCH] qcow2: Define and use QCOW2_COMPRESSED_SECTOR_SIZE

On Mon, May 13, 2019 at 01:48:27PM +0200, Alberto Garcia wrote: > On Mon 13 May 2019 01:28:46 PM CEST, Stefano Garzarella wrote: > >> +int size = QCOW2_COMPRESSED_SECTOR_SIZE * > >> +(((l2_entry >> s->csize_shift) & s->csize_mask) + 1); > > > > What about using int64_t

Re: [Qemu-devel] [PATCH 1/6] qemu-bridge-helper: Fix misuse of isspace()

Philippe Mathieu-Daudé writes: > On 4/18/19 4:53 PM, Markus Armbruster wrote: >> parse_acl_file() passes char values to isspace(). Undefined behavior >> when the value is negative. Not a security issue, because the >> characters come from trusted $prefix/etc/qemu/bridge.conf and the >> files

[Qemu-devel] [PATCH v16 03/10] acpi: add build_append_ghes_notify() helper for Hardware Error Notification

It will help to add Hardware Error Notification to ACPI tables without using packed C structures and avoid endianness issues as API doesn't need explicit conversion. Signed-off-by: Dongjiu Geng --- hw/acpi/aml-build.c | 22 ++ include/hw/acpi/aml-build.h | 8

Re: [Qemu-devel] [PATCH 3/6] gdbstub: Reject invalid RLE repeat counts

On 5/13/19 2:39 PM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> On 4/18/19 4:53 PM, Markus Armbruster wrote: >>> "Debugging with GDB / Appendix E GDB Remote Serial Protocol / >>> Overview" specifies "The printable characters '#' and '$' or with a >>> numeric value greater than

Re: [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

Am 13.05.2019 um 13:59 hat Markus Armbruster geschrieben: > Xiang Zheng writes: > > > On 2019/5/10 23:16, Markus Armbruster wrote: > >> Xiang Zheng writes: > >> > >>> On 2019/5/9 19:59, Markus Armbruster wrote: > Xiang Zheng writes: > > > On 2019/5/8 21:20, Markus Armbruster

[Qemu-devel] [PATCH v16 06/10] docs: APEI GHES generation and CPER record description

Add APEI/GHES detailed design document Signed-off-by: Dongjiu Geng --- docs/specs/acpi_hest_ghes.txt | 97 +++ 1 file changed, 97 insertions(+) create mode 100644 docs/specs/acpi_hest_ghes.txt diff --git a/docs/specs/acpi_hest_ghes.txt

[Qemu-devel] [PATCH v16 05/10] acpi: add build_append_ghes_generic_status() helper for Generic Error Status Block

It will help to add Generic Error Status Block to ACPI tables without using packed C structures and avoid endianness issues as API doesn't need explicit conversion. Signed-off-by: Dongjiu Geng --- hw/acpi/aml-build.c | 14 ++ include/hw/acpi/aml-build.h | 6 ++ 2 files

[Qemu-devel] [PATCH v16 09/10] target-arm: kvm64: inject synchronous External Abort

Add synchronous external abort injection logic, setup exception type and syndrome value. When switch to guest, it will jump to the synchronous external abort vector table entry. The ESR_ELx.DFSC is set to synchronous external abort(0x10), and ESR_ELx.FnV is set to not valid(0x1), which will tell

[Qemu-devel] [PATCH v16 04/10] acpi: add build_append_ghes_generic_data() helper for Generic Error Data Entry

It will help to add Generic Error Data Entry to ACPI tables without using packed C structures and avoid endianness issues as API doesn't need explicit conversion. Signed-off-by: Dongjiu Geng --- hw/acpi/aml-build.c | 32 include/hw/acpi/aml-build.h | 6

[Qemu-devel] [PATCH v16 07/10] ACPI: Add APEI GHES table generation support

This implements APEI GHES Table generation via fw_cfg blobs. Now it only support GPIO-Signal and ARMv8 SEA two types of GHESv2 error source. Afterwards, we can extend the supported types if needed. For the CPER section type, currently it is memory section because kernel mainly wants userspace to

[Qemu-devel] [PATCH v16 01/10] hw/arm/virt: Add RAS platform version for migration

Support this feature since version 4.1, disable it by default in the old version. Signed-off-by: Dongjiu Geng --- hw/arm/virt.c | 6 ++ include/hw/arm/virt.h | 1 + 2 files changed, 7 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 5331ab7..7bdd41b 100644 ---

[Qemu-devel] [PATCH v16 02/10] ACPI: add some GHES structures and macros definition

Add Generic Error Status Block structures and some macros definitions, which is referred to the ACPI 4.0 or ACPI 6.2. The HEST table generation and CPER record will use them. Signed-off-by: Dongjiu Geng --- include/hw/acpi/acpi-defs.h | 52 + 1 file

Re: [Qemu-devel] [PATCH v6 24/25] target/ppc: Use gen_io_start/end around DARN

On 10/05/2019 19:30, Richard Henderson wrote: Generating a random number counts as I/O, as it cannot be replayed and produce the same results. Cc: David Gibson Suggested-by: Peter Maydell Signed-off-by: Richard Henderson --- target/ppc/translate.c | 21 +++-- 1 file

[Qemu-devel] [PATCH v16 00/10] Add ARMv8 RAS virtualization support in QEMU

In the ARMv8 platform, the CPU error type are synchronous external abort(SEA) and SError Interrupt (SEI). If exception happens to guest, sometimes guest itself do the recovery is better, because host does not know guest's detailed information. For example, if a guest user-space application happen

[Qemu-devel] [PATCH v16 10/10] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

Add SIGBUS signal handler. In this handler, it checks the SIGBUS type, translates the host VA delivered by host to guest PA, then fill this PA to guest APEI GHES memory, then notify guest according to the SIGBUS type. If guest accesses the poisoned memory, it generates Synchronous External

[Qemu-devel] [PATCH v16 08/10] KVM: Move related hwpoison page functions to accel/kvm/ folder

kvm_hwpoison_page_add() and kvm_unpoison_all() will be used both by X86 and ARM platforms, so move these functions to a common accel/kvm/ folder to avoid duplicate code. Signed-off-by: Dongjiu Geng --- accel/kvm/kvm-all.c | 33 + include/exec/ram_addr.h | 24

Re: [Qemu-devel] [PULL 0/7] Input 20190513 v2 patches

in the Git repository at: > > git://git.kraxel.org/qemu tags/input-20190513-v2-pull-request > > for you to fetch changes up to 503591cb6c28c3ddbe38ea50cab2f0dd3d6cd929: > > virtio-input: fix Kconfig dependency and

Re: [Qemu-devel] [PATCH 00/13] target/arm/kvm: enable SVE in guests

On Mon, May 13, 2019 at 01:38:57PM +0100, Andrew Jones wrote: > On Mon, May 13, 2019 at 12:15:56PM +0100, Dave Martin wrote: > > On Mon, May 13, 2019 at 10:32:46AM +0100, Andrea Bolognani wrote: > > > On Sun, 2019-05-12 at 10:36 +0200, Andrew Jones wrote: [...] > > > > The QMP query returns a

Re: [Qemu-devel] [PATCH v16 10/10] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

On Mon, 13 May 2019 at 13:46, Dongjiu Geng wrote: > > Add SIGBUS signal handler. In this handler, it checks the SIGBUS type, > translates the host VA delivered by host to guest PA, then fill this PA > to guest APEI GHES memory, then notify guest according to the SIGBUS type. > > If guest accesses

Re: [Qemu-devel] [PATCH 11/13] target/arm/cpu64: max cpu: Introduce sve-vls-map

On Mon, May 13, 2019 at 01:41:26PM +0100, Dave Martin wrote: > On Mon, May 13, 2019 at 01:30:23PM +0100, Andrew Jones wrote: > > On Mon, May 13, 2019 at 12:26:36PM +0100, Dave Martin wrote: > > > On Sun, May 12, 2019 at 09:36:22AM +0100, Andrew Jones wrote: > > > > Introduce another cpu property

Re: [Qemu-devel] [PATCH] qcow2: Define and use QCOW2_COMPRESSED_SECTOR_SIZE

Am 10.05.2019 um 18:22 hat Alberto Garcia geschrieben: > When an L2 table entry points to a compressed cluster the space used > by the data is specified in 512-byte sectors. This size is independent > from BDRV_SECTOR_SIZE and is specific to the qcow2 file format. > > The

Re: [Qemu-devel] [PATCH 11/13] target/arm/cpu64: max cpu: Introduce sve-vls-map

On Mon, May 13, 2019 at 01:30:23PM +0100, Andrew Jones wrote: > On Mon, May 13, 2019 at 12:26:36PM +0100, Dave Martin wrote: > > On Sun, May 12, 2019 at 09:36:22AM +0100, Andrew Jones wrote: > > > Introduce another cpu property to control SVE vector lengths, > > > sve-vls-map, which allows the

Re: [Qemu-devel] [PATCH 05/13] target/arm/kvm: Add kvm_arch_get/put_sve

On Sun, May 12, 2019 at 09:36:16AM +0100, Andrew Jones wrote: > These are the SVE equivalents to kvm_arch_get/put_fpsimd. > > Signed-off-by: Andrew Jones > --- > target/arm/kvm64.c | 127 +++-- > 1 file changed, 123 insertions(+), 4 deletions(-) [...] >

Re: [Qemu-devel] [PATCH 00/13] target/arm/kvm: enable SVE in guests

On Mon, May 13, 2019 at 10:52:06AM +0100, Peter Maydell wrote: > On Sun, 12 May 2019 at 09:36, Andrew Jones wrote: > > > > With the recent KVM guest SVE support pull request [1] KVM will be > > ready for guests with SVE. This series provides the QEMU bits for > > that enablement. The series

Re: [Qemu-devel] [PATCH 3/6] gdbstub: Reject invalid RLE repeat counts

Philippe Mathieu-Daudé writes: > On 4/18/19 4:53 PM, Markus Armbruster wrote: >> "Debugging with GDB / Appendix E GDB Remote Serial Protocol / >> Overview" specifies "The printable characters '#' and '$' or with a >> numeric value greater than 126 must not be used." gdb_read_byte() >> only

Re: [Qemu-devel] [PATCH 00/13] target/arm/kvm: enable SVE in guests

On Mon, May 13, 2019 at 12:15:56PM +0100, Dave Martin wrote: > On Mon, May 13, 2019 at 10:32:46AM +0100, Andrea Bolognani wrote: > > On Sun, 2019-05-12 at 10:36 +0200, Andrew Jones wrote: > > [...] > > >CPU type | accel | sve-max-vq | sve-vls-map > > >

Re: [Qemu-devel] [PATCH 00/13] target/arm/kvm: enable SVE in guests

On Mon, May 13, 2019 at 11:32:46AM +0200, Andrea Bolognani wrote: > On Sun, 2019-05-12 at 10:36 +0200, Andrew Jones wrote: > [...] > >CPU type | accel | sve-max-vq | sve-vls-map > >--- > > 1) max | tcg | $MAX_VQ | $VLS_MAP > > 2) max

Re: [Qemu-devel] [PATCH 11/13] target/arm/cpu64: max cpu: Introduce sve-vls-map

On Mon, May 13, 2019 at 12:26:36PM +0100, Dave Martin wrote: > On Sun, May 12, 2019 at 09:36:22AM +0100, Andrew Jones wrote: > > Introduce another cpu property to control SVE vector lengths, > > sve-vls-map, which allows the user to explicitly select the > > set of vector lengths the guest can

Re: [Qemu-devel] [PATCH 05/13] target/arm/kvm: Add kvm_arch_get/put_sve

On Sun, May 12, 2019 at 09:36:16AM +0100, Andrew Jones wrote: > These are the SVE equivalents to kvm_arch_get/put_fpsimd. > > Signed-off-by: Andrew Jones > --- > target/arm/kvm64.c | 127 +++-- > 1 file changed, 123 insertions(+), 4 deletions(-) [...] >

Re: [Qemu-devel] QMP; unsigned 64-bit ints; JSON standards compliance

On Mon, May 13, 2019 at 01:29:34PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Wed, May 08, 2019 at 02:44:07PM +0200, Markus Armbruster wrote: > > > Daniel P. Berrangé writes: > > > > > > > On Tue, May 07, 2019 at 10:47:06AM +0200, Markus

Re: [Qemu-devel] QMP; unsigned 64-bit ints; JSON standards compliance

* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Wed, May 08, 2019 at 02:44:07PM +0200, Markus Armbruster wrote: > > Daniel P. Berrangé writes: > > > > > On Tue, May 07, 2019 at 10:47:06AM +0200, Markus Armbruster wrote: > > > > > >> >> > I can think of some options: > > >> >> > > > >> >>

Re: [Qemu-devel] [PATCH v3 0/3] rng-builtin: add an RNG backend that uses qemu_guest_getrandom()

Kashyap Chamarthy writes: > On Mon, May 13, 2019 at 08:36:23AM +0200, Laurent Vivier wrote: >> On 12/05/2019 20:21, Michael S. Tsirkin wrote: > > [...] > >> > > Kashyap Chamarthy (1): >> > >VirtIO-RNG: Update default entropy source to `/dev/urandom` >> > > >> > > Laurent Vivier (2): >> > >

Re: [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

Xiang Zheng writes: > On 2019/5/10 23:16, Markus Armbruster wrote: >> Xiang Zheng writes: >> >>> On 2019/5/9 19:59, Markus Armbruster wrote: Xiang Zheng writes: > On 2019/5/8 21:20, Markus Armbruster wrote: >> Laszlo Ersek writes: >> >>> Hi Markus, >>> >>>

Re: [Qemu-devel] QMP; unsigned 64-bit ints; JSON standards compliance

On Wed, May 08, 2019 at 02:44:07PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Tue, May 07, 2019 at 10:47:06AM +0200, Markus Armbruster wrote: > > > >> >> > I can think of some options: > >> >> > > >> >> > 1. Encode unsigned 64-bit integers as signed 64-bit integers.

Re: [Qemu-devel] [PATCH v4 4/5] linux-user: Add support for setsockopt() options IPV6__MEMBERSHIP

On 03/05/2019 19:50, Aleksandar Markovic wrote: From: Neng Chen Add support for options IPV6_ADD_MEMBERSHIP and IPV6_DROP_MEMPEMBERSHIP of the syscall setsockopt(). These options control membership in multicast groups. Their argument is a pointer to a struct ipv6_mreq, which is in turn defined

[Qemu-devel] [PATCH V3 1/3] hw/display/ramfb: fix guest memory un-mapping

From: Hou Qiming Pulled back the `qemu_create_displaysurface_guestmem` function to create the display surface so that the guest memory gets properly unmapped. Signed-off-by: HOU Qiming [rename the new functions and use QEMU coding style] Signed-off-by: Marcel Apfelbaum --- hw/display/ramfb.c

[Qemu-devel] [PATCH V3 3/3] hw/display/ramfb: initialize fw-config space with xres/ yres

From: Hou Qiming If xres / yres were specified in QEMU command line, write them as an initial resolution to the fw-config space on guest reset, which a later BIOS / OVMF patch can take advantage of. Signed-off-by: HOU Qiming [fixed malformed patch] Signed-off-by: Marcel Apfelbaum ---

Re: [Qemu-devel] [PATCH v4 3/8] hw/acpi: Add ACPI Generic Event Device Support

Hi Igor, > -Original Message- > From: Shameerali Kolothum Thodi > Sent: 03 May 2019 13:46 > To: 'Igor Mammedov' > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; > eric.au...@redhat.com; peter.mayd...@linaro.org; > shannon.zha...@gmail.com; sa...@linux.intel.com; >

Re: [Qemu-devel] [PULL 0/5] demacro SoftMMU

On Fri, 10 May 2019 at 21:01, Alex Bennée wrote: > > The following changes since commit a6ae23831b05a11880b40f7d58e332c45a6b04f7: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/python-next-pull-request' into staging (2019-05-03 > 15:26:09 +0100) > > are available in the Git

[Qemu-devel] [PATCH V3 0/3] ramfb improvements

Please see the description in each patch. Qiming, thanks for taking the time to upstream your patches! Marcel V2 - V3: - rebase to latest master - send as new series - use QEMU coding conventions - fixed malformed patches (maybe I didn't import them right) Hou Qiming (3):

[Qemu-devel] [PATCH V3 2/3] hw/display/ramfb: lock guest resolution after it's set

From: Hou Qiming Only allow one resolution change per guest boot, which prevents a crash when the guest writes garbage to the configuration space (e.g. when rebooting). Signed-off-by: HOU Qiming [fixed malformed patch] Signed-off-by: Marcel Apfelbaum --- hw/display/ramfb.c | 26

Re: [Qemu-devel] [PATCH v4 3/5] linux-user: Add support the SIOCIFPFLAGS ioctls for all targets

On 03/05/2019 19:50, Aleksandar Markovic wrote: From: Neng Chen Add support for getting and setting extended private flags of a network device via SIOCSIFPFLAGS and SIOCGIFPFLAGS ioctls. The ioctl numeric values are platform-independent and determined by the file include/uapi/linux/sockios.h

Re: [Qemu-devel] [PATCH] qcow2: Define and use QCOW2_COMPRESSED_SECTOR_SIZE

On Mon 13 May 2019 01:28:46 PM CEST, Stefano Garzarella wrote: >> +int size = QCOW2_COMPRESSED_SECTOR_SIZE * >> +(((l2_entry >> s->csize_shift) & s->csize_mask) + 1); > > What about using int64_t type for the 'size' variable? > (because the qcow2_free_clusters() 'size'

<    1   2   3   4   >