[Qemu-devel] [PATCH] spapr/xive: Sanity checks of OV5 during CAS

2019-05-15 Thread Greg Kurz
If a machine is started with ic-mode=xive but the guest only knows about XICS, eg. an RHEL 7.6 guest, the kernel panics. This is expected but a bit unfortunate since the crash doesn't provide much information for the end user to guess what's happening. Detect that during CAS and exit QEMU with a p

Re: [Qemu-devel] [PATCH 1/6] qemu-bridge-helper: Fix misuse of isspace()

2019-05-15 Thread Markus Armbruster
Markus Armbruster writes: > Daniel P. Berrangé writes: > >> On Wed, May 15, 2019 at 08:34:17AM +0200, Markus Armbruster wrote: >>> Jason Wang writes: >>> >>> > On 2019/5/14 下午8:18, Markus Armbruster wrote: >>> >> Peter Maydell writes: >>> >> >>> >>> On Mon, 13 May 2019 at 14:21, Markus Armbru

Re: [Qemu-devel] [PATCH v9 16/27] gdbstub: Implement step (s pkt) with new infra

2019-05-15 Thread Alex Bennée
Jon Doron writes: > Signed-off-by: Jon Doron Reviewed-by: Alex Bennée > --- > gdbstub.c | 25 +++-- > 1 file changed, 19 insertions(+), 6 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index 9fe130f30d..9b0556f8be 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -

Re: [Qemu-devel] [PATCH v9 15/27] gdbstub: Implement file io (F pkt) with new infra

2019-05-15 Thread Alex Bennée
Jon Doron writes: There is a bit more going on here than a simple conversion. I think we need some additional commentary about the format of the data coming back. > Signed-off-by: Jon Doron > --- > gdbstub.c | 62 +++ > 1 file changed, 40

Re: [Qemu-devel] [PATCH v7 01/24] build: Link user-only with crypto-rng-obj-y

2019-05-15 Thread Daniel P . Berrangé
On Tue, May 14, 2019 at 12:16:30PM -0700, Richard Henderson wrote: > For user-only, we require only the random number bits of the > crypto subsystem. > > We need to preserve --static linking, which for many recent Linux > distributions precludes using GnuTLS or GCrypt. Instead, use our > random-p

Re: [Qemu-devel] [PATCH v7 01/24] build: Link user-only with crypto-rng-obj-y

2019-05-15 Thread Richard Henderson
On 5/15/19 9:42 AM, Laurent Vivier wrote: > On 14/05/2019 21:16, Richard Henderson wrote: >> For user-only, we require only the random number bits of the >> crypto subsystem. >> >> We need to preserve --static linking, which for many recent Linux >> distributions precludes using GnuTLS or GCrypt.

Re: [Qemu-devel] [PATCH v12 00/12] Add RX archtecture support

2019-05-15 Thread Richard Henderson
On 5/13/19 11:14 PM, Yoshinori Sato wrote: > This patch series is added Renesas RX target emulation. > > I fixed the ROM address because v11 was incorrect. > > My git repository is bellow. > git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git tags/rx-20190514 > > Testing binaries bellow. > u-boot

Re: [Qemu-devel] [PATCH v7 01/24] build: Link user-only with crypto-rng-obj-y

2019-05-15 Thread Laurent Vivier
On 14/05/2019 21:16, Richard Henderson wrote: > For user-only, we require only the random number bits of the > crypto subsystem. > > We need to preserve --static linking, which for many recent Linux > distributions precludes using GnuTLS or GCrypt. Instead, use our > random-platform module uncond

Re: [Qemu-devel] [PATCH v12 12/12] MAINTAINERS: Add RX

2019-05-15 Thread Richard Henderson
On 5/13/19 11:14 PM, Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato > --- > MAINTAINERS | 19 +++ > 1 file changed, 19 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v12 11/12] qemu/bitops.h: Add extract8 and extract16

2019-05-15 Thread Richard Henderson
On 5/13/19 11:14 PM, Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato > --- > include/qemu/bitops.h | 38 ++ > 1 file changed, 38 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2] net/slirp: fix the IPv6 prefix length error message

2019-05-15 Thread Philippe Mathieu-Daudé
On 5/15/19 3:01 PM, Stefano Garzarella wrote: > On Wed, May 15, 2019 at 02:33:03PM +0200, Markus Armbruster wrote: >> Stefano Garzarella writes: >> >>> Reword and add a missing parentheses at the end of the >>> error message. >>> >>> Signed-off-by: Stefano Garzarella >>> Reviewed-by: Marc-André L

Re: [Qemu-devel] [PATCH v9 14/27] gdbstub: Implement read all registers (g pkt) with new infra

2019-05-15 Thread Alex Bennée
Jon Doron writes: > Signed-off-by: Jon Doron > --- > gdbstub.c | 31 +++ > 1 file changed, 23 insertions(+), 8 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index adfe39b3a3..3478ac778d 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -1757,6 +1757,21 @@ sta

Re: [Qemu-devel] [PATCH v9 13/27] gdbstub: Implement write all registers (G pkt) with new infra

2019-05-15 Thread Alex Bennée
Jon Doron writes: > Signed-off-by: Jon Doron > --- > gdbstub.c | 41 +++-- > 1 file changed, 31 insertions(+), 10 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index daa602edc3..adfe39b3a3 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -1734,6 +173

[Qemu-devel] [Bug 1829079] Re: Can't build static on ARM (Raspbian)

2019-05-15 Thread Peter Maydell
No, --disable-tools won't change the qemu-* binaries that are built. It just stops us trying to build some binaries like the 'ivshmem-client' one that was causing a problem for you. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. http

Re: [Qemu-devel] [PATCH 1/6] qemu-bridge-helper: Fix misuse of isspace()

2019-05-15 Thread Richard Henderson
On 5/15/19 7:54 AM, Markus Armbruster wrote: > We don't want to deprecate qemu-bridge-helper while libvirt has a > sensible use for it. > > We can still deprecate -netdev tap parameter "helper" and -netdev bridge > entirely. > > Once they're gone, qemu-bridge-helper wull have no user within QEMU.

[Qemu-devel] [Bug 1829079] Re: Can't build static on ARM (Raspbian)

2019-05-15 Thread Dariusz Zyzański
Well, the symlinks didn't resolve the issue. I just tried them to see if this will solve the issue. And I installed a lot of packages, blindly trying to solve this issue. Using full Raspbian instead of Raspbian Lite was also an attempt to do so. I'm just an advanced Linux user, not a developer! I

Re: [Qemu-devel] [PATCH v3 5/8] migration: Add multifd-compress parameter

2019-05-15 Thread Markus Armbruster
Juan Quintela writes: > Signed-off-by: Juan Quintela > > --- > Rename it to NONE > Fix typos (dave) > --- > hmp.c| 17 + > hw/core/qdev-properties.c| 13 + > include/hw/qdev-properties.h | 1 + > migration/migration.c| 16

Re: [Qemu-devel] [PATCH v9 12/27] gdbstub: Implement read memory (m pkt) with new infra

2019-05-15 Thread Alex Bennée
Jon Doron writes: > Signed-off-by: Jon Doron > --- > gdbstub.c | 48 > 1 file changed, 32 insertions(+), 16 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index 8dc2e1d507..daa602edc3 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -1710

Re: [Qemu-devel] [PATCH v9 23/27] gdbstub: Implement qemu physical memory mode

2019-05-15 Thread Alex Bennée
Jon Doron writes: > Add a new query/set which changes the memory GDB sees to physical memory > only. > > gdb> maint packet qqemu.PhyMemMode > will reply the current phy_mem_mode state (1 for enabled, 0 for disabled) > gdb> maint packet Qqemu.PhyMemMode:1 > Will make GDB read/write only to physi

Re: [Qemu-devel] [PATCH v9 11/27] gdbstub: Implement write memory (M pkt) with new infra

2019-05-15 Thread Alex Bennée
Jon Doron writes: > Signed-off-by: Jon Doron Reviewed-by: Alex Bennée > --- > gdbstub.c | 51 +-- > 1 file changed, 33 insertions(+), 18 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index e9a3d0c2bc..8dc2e1d507 100644 > --- a/gdbstub

Re: [Qemu-devel] Failing QEMU iotest 175

2019-05-15 Thread Stefan Hajnoczi
On Mon, May 06, 2019 at 12:44:56PM -0500, Eric Blake wrote: > On 5/4/19 1:51 AM, Thomas Huth wrote: > > >> Hmm, it's passing for me on ext4, but that probably means we have > >> different configuration parameters. I'm not sure how to easily show what > >> parameters a particular ext4 partition use

Re: [Qemu-devel] Question about the vfio device interrupt

2019-05-15 Thread Li Qiang
Alex Williamson 于2019年5月15日周三 下午10:54写道: > On Wed, 15 May 2019 17:27:52 +0300 > Maxim Levitsky wrote: > > > Hi! > > > > Let me add my 0.2 cents to this discussion by sharing my summary of INTx > emulation in VFIO: > > > > COMMON: > > * real interrupt is signaled in the kernel > > * vfio-pci kern

Re: [Qemu-devel] [PATCH 1/6] qemu-bridge-helper: Fix misuse of isspace()

2019-05-15 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, May 15, 2019 at 08:34:17AM +0200, Markus Armbruster wrote: >> Jason Wang writes: >> >> > On 2019/5/14 下午8:18, Markus Armbruster wrote: >> >> Peter Maydell writes: >> >> >> >>> On Mon, 13 May 2019 at 14:21, Markus Armbruster >> >>> wrote: >> Perhaps I

Re: [Qemu-devel] Question about the vfio device interrupt

2019-05-15 Thread Alex Williamson
On Wed, 15 May 2019 17:27:52 +0300 Maxim Levitsky wrote: > Hi! > > Let me add my 0.2 cents to this discussion by sharing my summary of INTx > emulation in VFIO: > > COMMON: > * real interrupt is signaled in the kernel > * vfio-pci kernel interrupt hanlder (vfio_intx_handler), masks the INTx fl

Re: [Qemu-devel] [PATCH 1/6] qemu-bridge-helper: Fix misuse of isspace()

2019-05-15 Thread Daniel P . Berrangé
On Wed, May 15, 2019 at 04:54:04PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Wed, May 15, 2019 at 08:34:17AM +0200, Markus Armbruster wrote: > >> Jason Wang writes: > >> > >> > On 2019/5/14 下午8:18, Markus Armbruster wrote: > >> >> Peter Maydell writes: > >> >> > >>

Re: [Qemu-devel] [RISU PATCH 0/5] Fix RISU build for i386

2019-05-15 Thread Jan Bobek
Hi Alex, I'm very sorry for the late reply, your emails got mixed up with everything else in qemu-devel; I didn't setup my mail filters very well (my bad). On 4/25/19 9:45 AM, Alex Bennée wrote: > > Jan Bobek writes: > >> Hi all, >> > >> Thanks, >> -Jan Bobek >> >> P.S. This is my first time

Re: [Qemu-devel] Question about the vfio device interrupt

2019-05-15 Thread Maxim Levitsky
Hi! Let me add my 0.2 cents to this discussion by sharing my summary of INTx emulation in VFIO: COMMON: * real interrupt is signaled in the kernel * vfio-pci kernel interrupt hanlder (vfio_intx_handler), masks the INTx flag * vfio-pci kernel interrupt handler triggers an eventfd, if the interrup

Re: [Qemu-devel] [PATCH v3] chardev/char-i2c: Implement Linux I2C character device

2019-05-15 Thread Stefan Hajnoczi
On Fri, May 10, 2019 at 07:04:10PM +0100, Ernest Esene wrote: > Add support for Linux I2C character device for I2C device passthrough > For example: > -chardev i2c,address=0x46,path=/dev/i2c-N,id=i2c-chardev > > QEMU supports emulation of I2C devices in software but currently can't > passthrough t

[Qemu-devel] [PATCH 2/2] docs: recommend use of md-clear feature on all Intel CPUs

2019-05-15 Thread Daniel P . Berrangé
Update x86 CPU model guidance to recommend that the md-clear feature is manually enabled with all Intel CPU models, when supported by the host microcode. Signed-off-by: Daniel P. Berrangé --- docs/qemu-cpu-models.texi | 12 1 file changed, 12 insertions(+) diff --git a/docs/qemu-cp

[Qemu-devel] [PATCH 0/2] x86/cpu: add "md-clear" feature for MDS security flaws

2019-05-15 Thread Daniel P . Berrangé
This patch series provides the new "md-clear" feature that is used for mitigation with CVE-2018-12126, CVE-2018-12127, CVE-2018-12130, CVE-2019-11091. Assuming you have the updated microcode and kernel to support the md-clear feature, then using "-cpu host" will expose the new feature to guests. F

[Qemu-devel] [PATCH 1/2] target/i386: define md-clear bit

2019-05-15 Thread Daniel P . Berrangé
From: Paolo Bonzini md-clear is a new CPUID bit which is set when microcode provides the mechanism to invoke a flush of various exploitable CPU buffers by invoking the VERW instruction. Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[Qemu-devel] [Bug 1829242] [NEW] qemu on windows host exits after savevm command

2019-05-15 Thread Alex
Public bug reported: I'm running qemu-system-i386.exe 3.1.0 with this command line: "C:\Program Files\qemu\qemu-system-i386.exe" -L C:\user\qemu\pc-bios\ -name win7 -m 4G -uuid 564db62e-e031-b5cf-5f34-a75f8cefa98e -rtc base=localtime -accel hax -hdd C:\VirtualMachines\Dev\Win10x64_VS17\swap.qco

Re: [Qemu-devel] [PATCH 1/4] qapi: Support features for structs

2019-05-15 Thread Markus Armbruster
Kevin Wolf writes: > Am 18.04.2019 um 22:03 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Sometimes, the behaviour of QEMU changes compatibly, but without a >> > change in the QMP syntax (usually by allowing values or operations that >> > previously resulted in an error). QMP

Re: [Qemu-devel] Question about the vfio device interrupt

2019-05-15 Thread Alex Williamson
On Wed, 15 May 2019 18:22:54 +0800 Li Qiang wrote: > Auger Eric 于2019年5月15日周三 下午6:16写道: > > > Hi, > > > > On 5/15/19 12:01 PM, Li Qiang wrote: > > > Hello Paolo, Alex and all, > > > > > > In vfio_intx_enable_kvm(qemu) I see we associate a resamplefd with the > > > umask function(vfio_pci_intx

Re: [Qemu-devel] [PATCH 1/6] qemu-bridge-helper: Fix misuse of isspace()

2019-05-15 Thread Paolo Bonzini
On 15/05/19 08:34, Markus Armbruster wrote: >>> qemu-bridge-helper should have a manual page, and its handling of errors >>> in ACL include files needs work. There's probably more; I just glanced >>> at it. I'm not volunteering, though. It lacks a maintainer. Should we >>> add it to Jason's "Ne

Re: [Qemu-devel] [PATCH for-4.1 v2] q35: Revert to kernel irqchipQEM

2019-05-15 Thread Alex Williamson
On Wed, 15 May 2019 14:15:03 +0800 Peter Xu wrote: > On Tue, May 14, 2019 at 02:14:41PM -0600, Alex Williamson wrote: > > Commit b2fc91db8447 ("q35: set split kernel irqchip as default") changed > > the default for the pc-q35-4.0 machine type to use split irqchip, which > > turned out to have dis

Re: [Qemu-devel] [PATCH v9 00/27] gdbstub: Refactor command packets handler

2019-05-15 Thread Alex Bennée
Jon Doron writes: > This patch series refactors the old gdbstub command packets handler > with a new infrastructure which should ease extending and adding new > and missing gdb command packets. There seems to be some compiler errors and variants that this breaks the CI on: https://travis-ci

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 1/1] target/arm: Fix vector operation segfault

2019-05-15 Thread Alex Bennée
Alistair Francis writes: > Commit 89e68b575 "target/arm: Use vector operations for saturation" > causes this abort() when booting QEMU ARM with a Cortex-A15: You may want to check your email settings because when I tried to apply this patch it failed because the message is base64 encoded which

Re: [Qemu-devel] [PATCH v2] net/slirp: fix the IPv6 prefix length error message

2019-05-15 Thread Stefano Garzarella
On Wed, May 15, 2019 at 02:33:03PM +0200, Markus Armbruster wrote: > Stefano Garzarella writes: > > > Reword and add a missing parentheses at the end of the > > error message. > > > > Signed-off-by: Stefano Garzarella > > Reviewed-by: Marc-André Lureau > > --- > > v2: > > - Reworded the error

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Dave Martin
On Wed, May 15, 2019 at 12:09:04PM +0100, Dr. David Alan Gilbert wrote: > * Dave Martin (dave.mar...@arm.com) wrote: > > On Wed, May 15, 2019 at 09:18:54AM +0100, Andrew Jones wrote: > > > On Tue, May 14, 2019 at 04:48:38PM +0200, Igor Mammedov wrote: > > > > On Tue, 14 May 2019 11:02:25 +0200 > >

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Dave Martin
On Wed, May 15, 2019 at 12:42:44PM +0100, Andrew Jones wrote: > On Wed, May 15, 2019 at 12:00:45PM +0100, Dave Martin wrote: > > On Wed, May 15, 2019 at 09:18:54AM +0100, Andrew Jones wrote: > > > On Tue, May 14, 2019 at 04:48:38PM +0200, Igor Mammedov wrote: > > > > On Tue, 14 May 2019 11:02:25 +0

Re: [Qemu-devel] [PATCH 00/13] target/arm/kvm: enable SVE in guests

2019-05-15 Thread Dave Martin
On Wed, May 15, 2019 at 12:28:20PM +0100, Andrea Bolognani wrote: > On Wed, 2019-05-15 at 12:14 +0100, Dave Martin wrote: > > On Wed, May 15, 2019 at 09:03:58AM +0100, Andrea Bolognani wrote: > > > On Tue, 2019-05-14 at 13:14 -0700, Richard Henderson wrote: > > > > Why is =4 less user-friendly than

[Qemu-devel] [PATCH v3 3/7] grlib, gptimer: get rid of the old-style create function

2019-05-15 Thread KONRAD Frederic
Suggested-by: Mark Cave-Ayland Signed-off-by: KONRAD Frederic --- hw/sparc/leon3.c | 17 - hw/timer/grlib_gptimer.c | 4 ++-- include/hw/sparc/grlib.h | 27 +-- 3 files changed, 19 insertions(+), 29 deletions(-) diff --git a/hw/sparc/leon3.c b/hw

Re: [Qemu-devel] [PATCH v2] net/slirp: fix the IPv6 prefix length error message

2019-05-15 Thread Markus Armbruster
Stefano Garzarella writes: > Reword and add a missing parentheses at the end of the > error message. > > Signed-off-by: Stefano Garzarella > Reviewed-by: Marc-André Lureau > --- > v2: > - Reworded the error message (Markus) > - Added Marc-André's R-b > I made a little change to the erro

[Qemu-devel] [PATCH v3 2/7] grlib, irqmp: get rid of the old-style create function

2019-05-15 Thread KONRAD Frederic
Suggested-by: Mark Cave-Ayland Signed-off-by: KONRAD Frederic --- hw/intc/grlib_irqmp.c| 3 +-- hw/sparc/leon3.c | 12 ++-- include/hw/sparc/grlib.h | 31 ++- 3 files changed, 13 insertions(+), 33 deletions(-) diff --git a/hw/intc/grlib_irqmp.c b

[Qemu-devel] [PATCH v3 6/7] leon3: introduce the plug and play mechanism

2019-05-15 Thread KONRAD Frederic
This adds the AHB and APB plug and play devices. They are scanned during the linux boot to discover the various peripheral. Reviewed-by: Fabien Chouteau Signed-off-by: KONRAD Frederic --- MAINTAINERS | 2 +- hw/misc/Makefile.objs | 2 + hw/misc/grlib_ah

[Qemu-devel] [PATCH v3 7/7] MAINTAINERS: add myself for leon3

2019-05-15 Thread KONRAD Frederic
Reviewed-by: Fabien Chouteau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland Signed-off-by: KONRAD Frederic --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index bc54c6d..9424a49 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1158

[Qemu-devel] [PATCH v3 4/7] grlib, apbuart: get rid of the old-style create function

2019-05-15 Thread KONRAD Frederic
Suggested-by: Mark Cave-Ayland Signed-off-by: KONRAD Frederic --- hw/char/grlib_apbuart.c | 4 ++-- hw/sparc/leon3.c | 9 - include/hw/sparc/grlib.h | 20 +--- 3 files changed, 11 insertions(+), 22 deletions(-) diff --git a/hw/char/grlib_apbuart.c b/hw/char/gr

[Qemu-devel] [PATCH v3 5/7] leon3: add a little bootloader

2019-05-15 Thread KONRAD Frederic
This adds a little bootloader to the leon3_machine when a ram image is given through the kernel parameter and no bios are provided: * The UART transmiter is enabled. * The TIMER is initialized. Reviewed-by: Fabien Chouteau Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: KONRAD Frederic -

[Qemu-devel] [PATCH v3 1/7] leon3: fix the error message when no bios are provided

2019-05-15 Thread KONRAD Frederic
The leon3 board is looking for u-boot.bin by default (LEON3_PROM_FILENAME).. But in the case this file is not found and no other file are given on the command line we get the following error: $ ./qemu-system-sparc -M leon3_generic qemu-system-sparc: Can't read bios image (null) So use LEON3_P

[Qemu-devel] [PATCH v3 0/7] Leon3 patches

2019-05-15 Thread KONRAD Frederic
Hi all, Those are some little fixes for the leon3 machine: * The first patch makes an error message more friendly when no kernel / bios are provided. * The three next one remove the old-style create function as suggested by Mark. * The fifth part initializes the uart and the timer wh

[Qemu-devel] qemu vga crash

2019-05-15 Thread Vladimir Sementsov-Ogievskiy
Hi Gerd! Writing to you, as you were the last one who committed to vga_draw_graphic, hope you can help. We faced the following crash in 2.12-based Qemu, but code seems not really changed: #0 __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1 __GI_abort () at abort.

Re: [Qemu-devel] [PATCH 2/4] migration/savevm: use migration_is_blocked to validate

2019-05-15 Thread Wei Yang
On Wed, May 15, 2019 at 10:38:37AM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> On Wed, May 15, 2019 at 02:38:27PM +0800, Wei Yang wrote: >> >On Tue, May 14, 2019 at 04:18:14PM +0100, Dr. David Alan Gilbert wrote: >> >>* Wei Yang (richardw.y...@linux.in

Re: [Qemu-devel] [PATCH v2 6/8] migration: Add multifd-compress parameter

2019-05-15 Thread Markus Armbruster
Juan Quintela writes: > Markus Armbruster wrote: >> Juan Quintela writes: >> >>> Signed-off-by: Juan Quintela >>> >>> --- >>> Rename it to NONE > >>> @@ -1822,6 +1826,19 @@ void hmp_migrate_set_parameter(Monitor *mon, const >>> QDict *qdict) >>> p->has_multifd_channels = true; >>>

[Qemu-devel] [PATCH v3 8/8] multifd: rest of zlib compression

2019-05-15 Thread Juan Quintela
This is still a work in progress, but get everything sent as expected and it is faster than the code that is already there. Signed-off-by: Juan Quintela --- migration/ram.c | 106 +++- 1 file changed, 104 insertions(+), 2 deletions(-) diff --git a/mig

[Qemu-devel] [PATCH v3 6/8] migration: Make none operations into its own structure

2019-05-15 Thread Juan Quintela
It will be used later. Signed-off-by: Juan Quintela --- migration/ram.c | 54 - 1 file changed, 49 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 1ca9ba77b6..6679e4f213 100644 --- a/migration/ram.c +++ b/migrati

[Qemu-devel] [PATCH v3 7/8] multifd: Add zlib compression support

2019-05-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/core/qdev-properties.c | 2 +- migration/migration.c | 9 migration/migration.h | 1 + migration/ram.c | 47 +++ qapi/migration.json | 2 +- tests/migration-test.c| 6 + 6 files c

[Qemu-devel] [PATCH v3 5/8] migration: Add multifd-compress parameter

2019-05-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- Rename it to NONE Fix typos (dave) --- hmp.c| 17 + hw/core/qdev-properties.c| 13 + include/hw/qdev-properties.h | 1 + migration/migration.c| 16 qapi/migration.json | 30

[Qemu-devel] [PATCH v3 4/8] migration-test: introduce functions to handle string parameters

2019-05-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/migration-test.c | 37 + 1 file changed, 37 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c index ff480e0682..65d5e256a7 100644 --- a/tests/migration-test.c +++ b/tests/migration-test.c @@ -427,

[Qemu-devel] [PATCH v3 2/8] migration-test: rename parameter to parameter_int

2019-05-15 Thread Juan Quintela
We would need _str ones on the next patch. Signed-off-by: Juan Quintela --- tests/migration-test.c | 49 +- 1 file changed, 25 insertions(+), 24 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index bd3f5c3125..0b25aa3d6c 100644

[Qemu-devel] [PATCH v3 0/8] WIP: Multifd compression support

2019-05-15 Thread Juan Quintela
v3: - improve the code - address David and Markus comments - make compression code into methods so we can add any other method ading just three functions Please review, as far as I know everything is ok now. Todo: Add zstd support v2: - improve the code left and right - Split better the zlib c

[Qemu-devel] [PATCH v3 1/8] migration: fix multifd_recv event typo

2019-05-15 Thread Juan Quintela
It uses num in multifd_send(). Make it coherent. Signed-off-by: Juan Quintela --- migration/trace-events | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/trace-events b/migration/trace-events index de2e136e57..cd50a1e659 100644 --- a/migration/trace-events +++ b/mig

[Qemu-devel] [PATCH v3 3/8] tests: Add migration multifd test

2019-05-15 Thread Juan Quintela
We set multifd-channels. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Thomas Huth Signed-off-by: Juan Quintela --- tests/migration-test.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c index 0b

Re: [Qemu-devel] [PATCH v9 09/27] gdbstub: Implement set register (P pkt) with new infra

2019-05-15 Thread Alex Bennée
Jon Doron writes: > Signed-off-by: Jon Doron > --- > gdbstub.c | 39 ++- > 1 file changed, 30 insertions(+), 9 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index b42425b24c..10e3f12a68 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -1634,6 +1634,2

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Andrew Jones
On Wed, May 15, 2019 at 12:52:29PM +0200, Igor Mammedov wrote: > On Wed, 15 May 2019 10:18:54 +0200 > Andrew Jones wrote: > > > On Tue, May 14, 2019 at 04:48:38PM +0200, Igor Mammedov wrote: > > > On Tue, 14 May 2019 11:02:25 +0200 > > > Andrew Jones wrote: > > > > My thought is primarily mach

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Andrew Jones
On Wed, May 15, 2019 at 12:00:45PM +0100, Dave Martin wrote: > On Wed, May 15, 2019 at 09:18:54AM +0100, Andrew Jones wrote: > > On Tue, May 14, 2019 at 04:48:38PM +0200, Igor Mammedov wrote: > > > On Tue, 14 May 2019 11:02:25 +0200 > > > Andrew Jones wrote: > > > > My thought is primarily machine

Re: [Qemu-devel] [PATCH 00/13] target/arm/kvm: enable SVE in guests

2019-05-15 Thread Andrea Bolognani
On Wed, 2019-05-15 at 12:14 +0100, Dave Martin wrote: > On Wed, May 15, 2019 at 09:03:58AM +0100, Andrea Bolognani wrote: > > On Tue, 2019-05-14 at 13:14 -0700, Richard Henderson wrote: > > > Why is =4 less user-friendly than =512? > > > > > > I don't actually see "total bits in vector" as more us

Re: [Qemu-devel] [PATCH 1/4] qapi: Support features for structs

2019-05-15 Thread Peter Krempa
On Wed, May 15, 2019 at 12:58:46 +0200, Kevin Wolf wrote: > Am 18.04.2019 um 22:03 hat Markus Armbruster geschrieben: > > Kevin Wolf writes: > > > > > Sometimes, the behaviour of QEMU changes compatibly, but without a > > > change in the QMP syntax (usually by allowing values or operations that >

Re: [Qemu-devel] [PATCH 00/13] target/arm/kvm: enable SVE in guests

2019-05-15 Thread Dave Martin
On Wed, May 15, 2019 at 09:03:58AM +0100, Andrea Bolognani wrote: > On Tue, 2019-05-14 at 13:14 -0700, Richard Henderson wrote: > > On 5/14/19 9:03 AM, Andrea Bolognani wrote: > > > On Tue, 2019-05-14 at 14:53 +0200, Andrew Jones wrote: > > > > We already have sve-max-vq, so I'm not sure we want to

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Dr. David Alan Gilbert
* Dave Martin (dave.mar...@arm.com) wrote: > On Wed, May 15, 2019 at 09:18:54AM +0100, Andrew Jones wrote: > > On Tue, May 14, 2019 at 04:48:38PM +0200, Igor Mammedov wrote: > > > On Tue, 14 May 2019 11:02:25 +0200 > > > Andrew Jones wrote: > > > > My thought is primarily machines. If a human want

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Dave Martin
On Wed, May 15, 2019 at 09:18:54AM +0100, Andrew Jones wrote: > On Tue, May 14, 2019 at 04:48:38PM +0200, Igor Mammedov wrote: > > On Tue, 14 May 2019 11:02:25 +0200 > > Andrew Jones wrote: > > > My thought is primarily machines. If a human wants to use the command > > > line and SVE, then I'm ass

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Dr. David Alan Gilbert
* Dave Martin (dave.mar...@arm.com) wrote: > On Wed, May 15, 2019 at 09:15:20AM +0100, Andrew Jones wrote: > > On Tue, May 14, 2019 at 03:32:13PM +0200, Markus Armbruster wrote: > > > Syntax that can support such growth would be nice. > > > > > > To grow a single unsigned number, we can make it wi

Re: [Qemu-devel] [PATCH 1/4] qapi: Support features for structs

2019-05-15 Thread Kevin Wolf
Am 18.04.2019 um 22:03 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Sometimes, the behaviour of QEMU changes compatibly, but without a > > change in the QMP syntax (usually by allowing values or operations that > > previously resulted in an error). QMP clients may still need to k

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Igor Mammedov
On Wed, 15 May 2019 10:18:54 +0200 Andrew Jones wrote: > On Tue, May 14, 2019 at 04:48:38PM +0200, Igor Mammedov wrote: > > On Tue, 14 May 2019 11:02:25 +0200 > > Andrew Jones wrote: > > > My thought is primarily machines. If a human wants to use the command > > > line and SVE, then I'm assumi

Re: [Qemu-devel] [PATCH v2 6/8] migration: Add multifd-compress parameter

2019-05-15 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> Signed-off-by: Juan Quintela >> >> --- >> Rename it to NONE >> @@ -1822,6 +1826,19 @@ void hmp_migrate_set_parameter(Monitor *mon, const >> QDict *qdict) >> p->has_multifd_channels = true; >> visit_type_int(v, param, &p->m

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Dave Martin
On Wed, May 15, 2019 at 09:15:20AM +0100, Andrew Jones wrote: > On Tue, May 14, 2019 at 03:32:13PM +0200, Markus Armbruster wrote: > > Syntax that can support such growth would be nice. > > > > To grow a single unsigned number, we can make it wider (but we don't > > have infrastructure for numbers

Re: [Qemu-devel] [PATCH] monitor: Fix gva2gpa coverityism

2019-05-15 Thread Stefan Hajnoczi
On Fri, May 10, 2019 at 08:01:40PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Coverity is complaining that while I'm checking the return > value of mon_get_cpu(), I'm not actually using the checked value, > I'm calling it again and thus it's worried I might ge

Re: [Qemu-devel] [PATCH] tests/libqtest: Remove unused global_qtest-related wrapper functions

2019-05-15 Thread Stefan Hajnoczi
On Fri, May 10, 2019 at 07:22:39AM +0200, Thomas Huth wrote: > A bunch of the wrapper functions that use global_qtest are not used > anymore. Remove them to avoid that they are used in new code again. > > Signed-off-by: Thomas Huth > --- > tests/libqtest.c | 11 + > tests/libqtest.h | 108 -

Re: [Qemu-devel] [PATCH 1/3] migration: Add multifd-compress parameter

2019-05-15 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Signed-off-by: Juan Quintela >> +case MIGRATION_PARAMETER_MULTIFD_COMPRESS: >> +p->has_multifd_compress = true; >> +visit_type_enum(v, param, &compress_type, >> +&Multifd

Re: [Qemu-devel] [PATCH v9 08/27] gdbstub: Implement remove breakpoint (z pkt) with new infra

2019-05-15 Thread Alex Bennée
Jon Doron writes: > Signed-off-by: Jon Doron Merge with previous patch as per comments there. > --- > gdbstub.c | 49 - > 1 file changed, 32 insertions(+), 17 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index 36c7353a22..b42425b24c 1

[Qemu-devel] [Bug 1829079] Re: Can't build static on ARM (Raspbian)

2019-05-15 Thread Peter Maydell
You might find that adding --disable-tools to your configure line also helps in not trying to statically link random binaries you don't really want. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/18290

Re: [Qemu-devel] [PATCH 1/6] qemu-bridge-helper: Fix misuse of isspace()

2019-05-15 Thread Daniel P . Berrangé
On Wed, May 15, 2019 at 08:34:17AM +0200, Markus Armbruster wrote: > Jason Wang writes: > > > On 2019/5/14 下午8:18, Markus Armbruster wrote: > >> Peter Maydell writes: > >> > >>> On Mon, 13 May 2019 at 14:21, Markus Armbruster wrote: > Perhaps I should do it just for this file while I touch

Re: [Qemu-devel] [PATCH v9 07/27] gdbstub: Implement insert breakpoint (Z pkt) with new infra

2019-05-15 Thread Alex Bennée
Jon Doron writes: > Signed-off-by: Jon Doron > --- > gdbstub.c | 33 + > 1 file changed, 33 insertions(+) > > diff --git a/gdbstub.c b/gdbstub.c > index 21cdaf4678..36c7353a22 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -1588,6 +1588,29 @@ static void handl

Re: [Qemu-devel] Question about the vfio device interrupt

2019-05-15 Thread Li Qiang
Auger Eric 于2019年5月15日周三 下午6:16写道: > Hi, > > On 5/15/19 12:01 PM, Li Qiang wrote: > > Hello Paolo, Alex and all, > > > > In vfio_intx_enable_kvm(qemu) I see we associate a resamplefd with the > > umask function(vfio_pci_intx_unmask_handler in linux). > > > > irq_set = g_malloc0(argsz); > >

Re: [Qemu-devel] [Bug 1828508] [NEW] qemu-img created VMDK files lead to "Unsupported or invalid disk type 7"

2019-05-15 Thread Stefan Hajnoczi
On Fri, May 10, 2019 at 06:06:32AM -, Jake Mikelson wrote: > Public bug reported: > > Using qemu-img version 3.1.50 (v3.1.0-13607-geb2db0f7ba-dirty) on a > Windows 10 machine. > > Converting a VHD to VMDK. > qemu-img.exe convert "c:\test\AppD-VM01.vhd" -O vmdk -o adapter_type=buslogic > -p "

Re: [Qemu-devel] Question about the vfio device interrupt

2019-05-15 Thread Auger Eric
Hi, On 5/15/19 12:01 PM, Li Qiang wrote: > Hello Paolo, Alex and all, > > In vfio_intx_enable_kvm(qemu) I see we associate a resamplefd with the > umask function(vfio_pci_intx_unmask_handler in linux). > > irq_set = g_malloc0(argsz); > irq_set->argsz = argsz; > irq_set->flags = VFIO_

Re: [Qemu-devel] [PATCH 1/6] qemu-bridge-helper: Fix misuse of isspace()

2019-05-15 Thread Peter Maydell
On Wed, 15 May 2019 at 07:34, Markus Armbruster wrote: > > Jason Wang writes: > > > On 2019/5/14 下午8:18, Markus Armbruster wrote: > >> -netdev's helper parameter is seriously underdocumented. Document or > >> deprecate? > > > > > > I believe management should only use fd parameter of TAP. If we

Re: [Qemu-devel] [PATCH] configure: Disable slirp if --disable-system

2019-05-15 Thread Peter Maydell
On Tue, 14 May 2019 at 20:16, Aleksandar Markovic wrote: > > On May 13, 2019 11:14 PM, "Richard Henderson" > wrote: > > > > On 5/11/19 5:47 AM, Aleksandar Markovic wrote: > > > If no, the patch shoud be amended. If yes, the commit message should be > > > extended. > > > > Like what? I think it's

Re: [Qemu-devel] [PATCH v9 06/27] gdbstub: Implement set_thread (H pkt) with new infra

2019-05-15 Thread Alex Bennée
Jon Doron writes: > Signed-off-by: Jon Doron > --- > gdbstub.c | 79 ++- > 1 file changed, 49 insertions(+), 30 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index 469aaeb875..21cdaf4678 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @

[Qemu-devel] Question about the vfio device interrupt

2019-05-15 Thread Li Qiang
Hello Paolo, Alex and all, In vfio_intx_enable_kvm(qemu) I see we associate a resamplefd with the umask function(vfio_pci_intx_unmask_handler in linux). irq_set = g_malloc0(argsz); irq_set->argsz = argsz; irq_set->flags = VFIO_IRQ_SET_DATA_EVENTFD | VFIO_IRQ_SET_ACTION_UNMASK; irq

Re: [Qemu-devel] [Qemu-block] [PATCH 0/9] Assembly coroutine backend and x86 CET support

2019-05-15 Thread Stefan Hajnoczi
On Thu, May 09, 2019 at 02:44:39PM +0100, Peter Maydell wrote: > On Sun, 5 May 2019 at 16:41, Alex Bennée wrote: > > > > > > Paolo Bonzini writes: > > > > > *** BLURB HERE *** > > > > I assume there was going to be a bit more background here? > > Mmm, could we have the rationale, please ? Paolo

Re: [Qemu-devel] [PATCH v9 05/27] gdbstub: Implement continue with signal (C pkt) with new infra

2019-05-15 Thread Alex Bennée
Jon Doron writes: > Signed-off-by: Jon Doron > --- > gdbstub.c | 30 +- > 1 file changed, 25 insertions(+), 5 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index 89f1ab6524..469aaeb875 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -1532,6 +1532,21 @@ stat

Re: [Qemu-devel] [PATCH V1] Introducing virtio-example.

2019-05-15 Thread Stefan Hajnoczi
On Sun, Apr 28, 2019 at 04:26:31PM +0300, Yoni Bettan wrote: > The main goal is to create an example to be used as template or > guideline for contributors when they wish to create a new virtio > device and to document "the right way" to do so. > > It consists of several parts: > > 1. The dev

Re: [Qemu-devel] [PATCH v17 00/10] Add ARMv8 RAS virtualization support in QEMU

2019-05-15 Thread gengdongjiu
Hi All, for this series patch, we can use below simple method to test: 1). Apply below hard code change after applying this series patch: diff --git a/cpus.c b/cpus.c index e58e7ab..7149f54 100644 --- a/cpus.c +++ b/cpus.c @@ -1131,6 +1131,8 @@ static void sigbus_reraise(void) static void sigbu

Re: [Qemu-devel] [PATCH 2/4] migration/savevm: use migration_is_blocked to validate

2019-05-15 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > On Wed, May 15, 2019 at 02:38:27PM +0800, Wei Yang wrote: > >On Tue, May 14, 2019 at 04:18:14PM +0100, Dr. David Alan Gilbert wrote: > >>* Wei Yang (richardw.y...@linux.intel.com) wrote: > >>> > >>> Well, when you look into the source side of mig

[Qemu-devel] [PATCH v2] net/slirp: fix the IPv6 prefix length error message

2019-05-15 Thread Stefano Garzarella
Reword and add a missing parentheses at the end of the error message. Signed-off-by: Stefano Garzarella Reviewed-by: Marc-André Lureau --- v2: - Reworded the error message (Markus) - Added Marc-André's R-b I made a little change to the error message, let me now if I should remove yuo

Re: [Qemu-devel] [PATCH 00/13] target/arm/kvm: enable SVE in guests

2019-05-15 Thread Andrew Jones
On Tue, May 14, 2019 at 06:03:09PM +0200, Andrea Bolognani wrote: > I thought about it a bit more and perhaps the simplified design is > better after all. > > Whatever the interface looks like on the QEMU side, we're going to > want to offer libvirt users two options for configuring vector > lengt

[Qemu-devel] ping Re: [PATCH v6 0/7] NBD reconnect

2019-05-15 Thread Vladimir Sementsov-Ogievskiy
ping 11.04.2019 20:27, Vladimir Sementsov-Ogievskiy wrote: > Here is NBD reconnect. Previously, if connection failed all current > and future requests will fail. After the series, nbd-client driver > will try to reconnect unlimited times. During first @reconnect-delay > seconds of reconnecting all

Re: [Qemu-devel] [PATCH 1/3] migration/ram.c: start of migration_bitmap_sync_range is always 0

2019-05-15 Thread Wei Yang
On Wed, May 15, 2019 at 09:04:51AM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> On Tue, May 14, 2019 at 03:27:02PM +0100, Dr. David Alan Gilbert wrote: >> >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> >> We can eliminate to pass 0. >> >> >> >>

Re: [Qemu-devel] [PATCH v4 6/6] acpi: pci: use build_append_foo() API to construct MCFG

2019-05-15 Thread Wei Yang
On Wed, May 15, 2019 at 07:29:17AM +0200, Philippe Mathieu-Daudé wrote: >On 5/15/19 3:10 AM, Michael S. Tsirkin wrote: >> On Fri, Apr 19, 2019 at 08:30:53AM +0800, Wei Yang wrote: >>> build_append_foo() API doesn't need explicit endianness conversions >>> which eliminates a source of errors and it

<    1   2   3   >