[Qemu-devel] [PULL 10/37] contrib/vhost-user-blk: enable inflight I/O tracking

2019-05-16 Thread Michael S. Tsirkin
From: Xie Yongji This patch enables inflight I/O tracking for vhost-user-blk backend so that we could restart it safely. Signed-off-by: Xie Yongji Signed-off-by: Zhang Yu Message-Id: <20190320112646.3712-8-xieyon...@baidu.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL 27/37] tests: acpi: fetch X_DSDT if pointer to DSDT is 0

2019-05-16 Thread Michael S. Tsirkin
From: Igor Mammedov that way it would be possible to test a DSDT pointed by 64bit X_DSDT field in FADT. PS: it will allow to enable testing arm/virt board, which sets only newer X_DSDT field. Signed-off-by: Igor Mammedov Message-Id: <1556808723-226478-6-git-send-email-imamm...@redhat.com> Revi

[Qemu-devel] [PULL 04/37] virtio: Introduce started flag to VirtioDevice

2019-05-16 Thread Michael S. Tsirkin
From: Xie Yongji The virtio 1.0 transitional devices support driver uses the device before setting the DRIVER_OK status bit. So we introduce a started flag to indicate whether driver has started the device or not. Signed-off-by: Xie Yongji Signed-off-by: Zhang Yu Message-Id: <20190320112646.37

[Qemu-devel] [PULL 09/37] vhost-user-blk: Add support to reconnect backend

2019-05-16 Thread Michael S. Tsirkin
From: Xie Yongji Since we now support the message VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD. The backend is able to restart safely because it can track inflight I/O in shared memory. This patch allows qemu to reconnect the backend after connection closed. Signed-off-by: Xie Yongj

[Qemu-devel] [PULL 05/37] virtio: Use started flag in virtio_vmstate_change()

2019-05-16 Thread Michael S. Tsirkin
From: Xie Yongji Currently, we use DRIVER_OK status bit to check whether guest driver has started the device in virtio_vmstate_change(). But it's not the case for virtio 1.0 transitional devices. If migration completes between kicking virtqueue and setting VIRTIO_CONFIG_S_DRIVER_OK, guest may be

[Qemu-devel] [PULL 23/37] tests: acpi: rename acpi_parse_rsdp_table() into acpi_fetch_rsdp_table()

2019-05-16 Thread Michael S. Tsirkin
From: Igor Mammedov so name would reflect what the function does Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Wei Yang Message-Id: <1556808723-226478-2-git-send-email-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[Qemu-devel] [PULL 08/37] vhost-user-blk: Add return value for vhost_user_blk_start()

2019-05-16 Thread Michael S. Tsirkin
From: Xie Yongji Add a return value for vhost_user_blk_start() to check whether we start vhost-user backend successfully or not. Signed-off-by: Xie Yongji Signed-off-by: Zhang Yu Message-Id: <20190320112646.3712-6-xieyon...@baidu.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S.

[Qemu-devel] [PULL 03/37] docs: reST-ify vhost-user documentation

2019-05-16 Thread Michael S. Tsirkin
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20190315180735.13096-1-marcandre.lur...@redhat.com> Reviewed-by: Jens Freimann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- docs/interop/vhost-user.txt | 1219 --- MAINT

[Qemu-devel] [PULL 01/37] hw: report invalid disable-legacy|modern usage for virtio-1-only devs

2019-05-16 Thread Michael S. Tsirkin
From: Daniel P. Berrangé A number of virtio devices (gpu, crypto, mouse, keyboard, tablet) only support the virtio-1 (aka modern) mode. Currently if the user launches QEMU, setting those devices to enable legacy mode, QEMU will silently create them in modern mode, ignoring the user's (mistaken) r

[Qemu-devel] [PULL 15/37] do not call vhost_net_cleanup() on running net from char user event

2019-05-16 Thread Michael S. Tsirkin
From: Dan Streetman Buglink: https://launchpad.net/bugs/1823458 Currently, a user CHR_EVENT_CLOSED event will cause net_vhost_user_event() to call vhost_user_cleanup(), which calls vhost_net_cleanup() for all its queues. However, vhost_net_cleanup() must never be called like this for fully-init

[Qemu-devel] [PULL 02/37] Revert "globals: Allow global properties to be optional"

2019-05-16 Thread Michael S. Tsirkin
From: Daniel P. Berrangé This reverts commit d7741743f4f3d2683d1bb6938f88dc0167c21afa. Relying on setting properties on parents types which may not be relevant to certain sub-classes had unexpected side-effects causing bugs in device config defaults. It is preferrable to be explicit about which

[Qemu-devel] [PULL 06/37] vhost-user-blk: Use started flag in vhost_user_blk_set_status()

2019-05-16 Thread Michael S. Tsirkin
From: Xie Yongji Use started flag in vhost_user_blk_set_status() to decide if starting vhost-user backend or not. Signed-off-by: Xie Yongji Signed-off-by: Zhang Yu Message-Id: <20190320112646.3712-4-xieyon...@baidu.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- h

[Qemu-devel] [PULL 00/37] pci, pc, virtio: features, fixes

2019-05-16 Thread Michael S. Tsirkin
The following changes since commit efb4f3b62c69383a7308d7b739a3193e7c0ccae8: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-05-10 14:49:36 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_u

Re: [Qemu-devel] [PULL 00/21] Misc patches for 2019-05-15

2019-05-16 Thread Peter Maydell
On Wed, 15 May 2019 at 21:52, Paolo Bonzini wrote: > > The following changes since commit e329ad2ab72c43b56df88b34954c2c7d839bb373: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190513' into > staging (2019-05-14 10:08:47 +0100) > > are available in the git repository at: > > >

Re: [Qemu-devel] [PATCH] spapr/xive: Sanity checks of OV5 during CAS

2019-05-16 Thread David Gibson
On Thu, May 16, 2019 at 08:58:14AM +0200, Greg Kurz wrote: > On Thu, 16 May 2019 12:09:57 +0530 > Satheesh Rajendran wrote: > > > On Wed, May 15, 2019 at 07:04:24PM +0200, Greg Kurz wrote: > > > If a machine is started with ic-mode=xive but the guest only knows > > > about XICS, eg. an RHEL 7.6 g

Re: [Qemu-devel] [PULL 22/27] vl: Create block backends before setting machine properties

2019-05-16 Thread Markus Armbruster
Michal Privoznik writes: > On 3/11/19 11:08 PM, Markus Armbruster wrote: >> qemu-system-FOO's main() acts on command line arguments in its own >> idiosyncratic order. There's not much method to its madness. >> Whenever we find a case where one kind of command line argument needs >> to refer to s

Re: [Qemu-devel] [Qemu-block] [PATCH v3 1/3] block: introducing 'bdrv_co_delete_file' interface

2019-05-16 Thread Daniel Henrique Barboza
Hi John, On 5/13/19 4:47 PM, John Snow wrote: It looks like this one has gone un-noticed for a little while. On 3/26/19 5:17 PM, Daniel Henrique Barboza wrote: Adding to Block Drivers the capability of being able to clean up its created files can be useful in certain situations. For the LUKS d

Re: [Qemu-devel] [PATCH v2 2/4] net: avoid using variable length array in net_client_init()

2019-05-16 Thread Stefano Garzarella
On Thu, May 16, 2019 at 10:44:20AM +0200, Markus Armbruster wrote: > Stefano Garzarella writes: > > > net_client_init() uses a variable length array to store the prefix > > of 'ipv6-net' parameter (e.g. if ipv6-net=fec0::0/64, the prefix > > is 'fec0::0'). > > This patch introduces g_strsplit() t

[Qemu-devel] [PATCH] configure: only link capstone to emulation targets

2019-05-16 Thread Daniel P . Berrangé
Only the emulators link to code that uses capstone, so adding it to the global LIBs places undesirable dependancies on other binaries, in particular the tools. There is no variable that covers both user emulation and machine emulation, so add a new "$libs_cpu" for this purpose. In particular this

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 6/6] migration: Block migration while handling machine check

2019-05-16 Thread Aravinda Prasad
On Thursday 16 May 2019 04:24 PM, Greg Kurz wrote: > On Mon, 22 Apr 2019 12:33:45 +0530 > Aravinda Prasad wrote: > >> Block VM migration requests until the machine check >> error handling is complete as (i) these errors are >> specific to the source hardware and is irrelevant on >> the target

Re: [Qemu-devel] [PATCH v2] iotests: Filter 175's allocation information

2019-05-16 Thread Max Reitz
On 13.05.19 17:52, Max Reitz wrote: > It is possible for an empty file to take up blocks on a filesystem. > Make iotest 175 take this into account. > > Reported-by: Thomas Huth > Signed-off-by: Max Reitz > --- > v2: [Nir] > - Use a function for filtering > - s/empty_blocks/extra_blocks/ > --- >

Re: [Qemu-devel] [PATCH v4 6/6] acpi: pci: use build_append_foo() API to construct MCFG

2019-05-16 Thread Philippe Mathieu-Daudé
On Thu, May 16, 2019 at 9:41 AM Wei Yang wrote: > > On Wed, May 15, 2019 at 07:29:17AM +0200, Philippe Mathieu-Daudé wrote: > > > >Thanks Michael for testing... > > > >Wei, can you add a MCFG test in tests/bios-tables-test.c? > > > > I took a look into the test, current q35 has already has a refer

[Qemu-devel] [PATCH] migration: Fix typo in migrate_add_blocker() error message

2019-05-16 Thread Greg Kurz
Signed-off-by: Greg Kurz --- migration/migration.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index 609e0df5d0c0..c15e75e0eebe 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -1714,7 +1714,7 @@ int migrate

Re: [Qemu-devel] [PATCH] [RFC] qcow2: add compression type feature

2019-05-16 Thread Denis Plotnikov
On 16.05.2019 13:40, Max Reitz wrote: > On 16.05.19 09:50, Denis Plotnikov wrote: >> >> >> On 29.04.2019 1:32, Max Reitz wrote: >>> On 05.02.19 10:08, Denis Plotnikov wrote: The patch adds some preparation parts for incompatible compression type feature into QCOW2 header that indicates

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 6/6] migration: Block migration while handling machine check

2019-05-16 Thread Greg Kurz
On Mon, 22 Apr 2019 12:33:45 +0530 Aravinda Prasad wrote: > Block VM migration requests until the machine check > error handling is complete as (i) these errors are > specific to the source hardware and is irrelevant on > the target hardware, (ii) these errors cause data > corruption and should b

Re: [Qemu-devel] [PATCH] [RFC] qcow2: add compression type feature

2019-05-16 Thread Max Reitz
On 16.05.19 09:50, Denis Plotnikov wrote: > > > On 29.04.2019 1:32, Max Reitz wrote: >> On 05.02.19 10:08, Denis Plotnikov wrote: >>> The patch adds some preparation parts for incompatible compression type >>> feature into QCOW2 header that indicates that *all* compressed clusters >>> must be (de

Re: [Qemu-devel] [PATCH v12 00/12] Add RX archtecture support

2019-05-16 Thread Philippe Mathieu-Daudé
Hi Yoshinori, On 5/16/19 6:13 AM, Yoshinori Sato wrote: > On Thu, 16 May 2019 01:48:29 +0900, > Richard Henderson wrote: [...]>> Rather than having you send out a v13 with only changes to the tags, I will >> apply them myself while preparing an initial pull request for this. >> >> Thanks for your

Re: [Qemu-devel] [PATCH v13 09/12] Add rx-softmmu

2019-05-16 Thread Philippe Mathieu-Daudé
On 5/16/19 7:52 AM, Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato > Tested-by: Philippe Mathieu-Daudé > > Using only CONFIG_RX=y: Richard: Can you drop the previous "Using only CONFIG_RX=y" line? It was related to an older series. Thanks! > Reviewed-by: Philippe Mathieu-Daudé > > Sig

Re: [Qemu-devel] [PATCH v2] migration/dirty-bitmaps: change bitmap enumeration method

2019-05-16 Thread Vladimir Sementsov-Ogievskiy
14.05.2019 23:19, John Snow wrote: > Shift from looking at every root BDS to *every* BDS. This will migrate > bitmaps that are attached to blockdev created nodes instead of just ones > attached to emulated storage devices. > > Note that this will not migrate anonymous or internal-use bitmaps, as >

Re: [Qemu-devel] [PATCH 00/11] kvm/migration: support KVM_CLEAR_DIRTY_LOG

2019-05-16 Thread Peter Xu
On Thu, May 09, 2019 at 10:33:19AM +0800, Peter Xu wrote: > On Wed, May 08, 2019 at 01:55:07PM +0200, Paolo Bonzini wrote: > > On 08/05/19 06:39, Peter Xu wrote: > > >> The disadvantage of this is that you won't clear in the kernel those > > >> dirty bits that come from other sources (e.g. vhost or

Re: [Qemu-devel] [RFC] hw/core/bus.c: Only the main system bus can have no parent

2019-05-16 Thread Peter Maydell
On Thu, 16 May 2019 at 06:37, Markus Armbruster wrote: > > Peter Maydell writes: > > > In commit 80376c3fc2c38fdd453 in 2010 we added a workaround for > > some qbus buses not being connected to qdev devices -- if the > > bus has no parent object then we register a reset function which > > resets

Re: [Qemu-devel] [PATCH 3/5] s390: vfio_pci: Use a PCI Group structure

2019-05-16 Thread Pierre Morel
On 14/05/2019 13:49, Cornelia Huck wrote: On Fri, 10 May 2019 16:38:51 +0200 Pierre Morel wrote: We use a S390PCIGroup structure to hold the information related to zPCI Function group. This allows us to be ready to support multiple groups and to retrieve the group information from the host.

Re: [Qemu-devel] [PATCH 1/5] vfio: vfio_iommu_type1: linux header place holder

2019-05-16 Thread Pierre Morel
On 12/05/2019 20:22, Michael S. Tsirkin wrote: On Fri, May 10, 2019 at 04:38:49PM +0200, Pierre Morel wrote: This should be copied from Linux kernel UAPI includes. Signed-off-by: Pierre Morel pls add a note which linux version did you sync with. I will, thanks. Pierre --- linux-heade

Re: [Qemu-devel] [PATCH v2 4/4] net: remove unused get_str_sep() function

2019-05-16 Thread Markus Armbruster
Stefano Garzarella writes: > Since the get_str_sep() function is no longer used in > net/net.c, we can remove it. > > Signed-off-by: Stefano Garzarella Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2 3/4] net: use g_strsplit() for parsing host address and port

2019-05-16 Thread Markus Armbruster
Stefano Garzarella writes: > Use the glib function to split host address and port in > the parse_host_port() function. > > Suggested-by: Markus Armbruster > Signed-off-by: Stefano Garzarella Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH] spapr: Print out extra hints when CAS negotiation of interrupt mode fails

2019-05-16 Thread Greg Kurz
On Thu, 16 May 2019 10:22:26 +0200 Cédric Le Goater wrote: > On 5/16/19 9:45 AM, Satheesh Rajendran wrote: > > On Thu, May 16, 2019 at 09:36:57AM +0200, Greg Kurz wrote: > >> Let's suggest to the user how the machine should be configured to allow > >> the guest to boot successfully. > >> > >> S

Re: [Qemu-devel] [PATCH] spapr: Print out extra hints when CAS negotiation of interrupt mode fails

2019-05-16 Thread Satheesh Rajendran
On Thu, May 16, 2019 at 10:32:15AM +0200, Greg Kurz wrote: > On Thu, 16 May 2019 10:22:26 +0200 > Cédric Le Goater wrote: > > > On 5/16/19 9:45 AM, Satheesh Rajendran wrote: > > > On Thu, May 16, 2019 at 09:36:57AM +0200, Greg Kurz wrote: > > >> Let's suggest to the user how the machine should

Re: [Qemu-devel] [PATCH v2 2/4] net: avoid using variable length array in net_client_init()

2019-05-16 Thread Markus Armbruster
Stefano Garzarella writes: > net_client_init() uses a variable length array to store the prefix > of 'ipv6-net' parameter (e.g. if ipv6-net=fec0::0/64, the prefix > is 'fec0::0'). > This patch introduces g_strsplit() to split the 'ipv6-net' parameter, > so we can remove the variable length array.

Re: [Qemu-devel] [PULL 22/27] vl: Create block backends before setting machine properties

2019-05-16 Thread Michal Privoznik
On 3/11/19 11:08 PM, Markus Armbruster wrote: qemu-system-FOO's main() acts on command line arguments in its own idiosyncratic order. There's not much method to its madness. Whenever we find a case where one kind of command line argument needs to refer to something created for another kind later

Re: [Qemu-devel] [PATCH v2 1/4] net: fix assertion failure when ipv6-prefixlen is not a number

2019-05-16 Thread Markus Armbruster
Stefano Garzarella writes: > If 'ipv6-prefixlen' is not a number, the current behaviour > produces an assertion failure: > $ qemu-system-x86_64 -net user,ipv6-net=feca::0/a > qemu-system-x86_64: qemu/util/qemu-option.c:1175: qemu_opts_foreach: > Assertion `!errp || !*errp' failed. >

Re: [Qemu-devel] [PATCH] spapr: Print out extra hints when CAS negotiation of interrupt mode fails

2019-05-16 Thread Cédric Le Goater
On 5/16/19 9:45 AM, Satheesh Rajendran wrote: > On Thu, May 16, 2019 at 09:36:57AM +0200, Greg Kurz wrote: >> Let's suggest to the user how the machine should be configured to allow >> the guest to boot successfully. >> >> Suggested-by: Satheesh Rajendran >> Signed-off-by: Greg Kurz >> --- >> hw

Re: [Qemu-devel] [PATCH v9 2/7] virtio-pmem: Add virtio pmem driver

2019-05-16 Thread Pankaj Gupta
> >> + vpmem->vdev = vdev; > >> + vdev->priv = vpmem; > >> + err = init_vq(vpmem); > >> + if (err) { > >> + dev_err(&vdev->dev, "failed to initialize virtio pmem vq's\n"); > >> + goto out_err; > >> + } > >> + > >> + virtio_cread(vpmem->vdev, struct virtio_pmem_config, > >>

Re: [Qemu-devel] [PATCH] [RFC] qcow2: add compression type feature

2019-05-16 Thread Denis Plotnikov
On 29.04.2019 1:32, Max Reitz wrote: > On 05.02.19 10:08, Denis Plotnikov wrote: >> The patch adds some preparation parts for incompatible compression type >> feature into QCOW2 header that indicates that *all* compressed clusters >> must be (de)compressed using a certain compression type. >> >>

Re: [Qemu-devel] [PATCH v9 2/7] virtio-pmem: Add virtio pmem driver

2019-05-16 Thread Pankaj Gupta
> > > + vpmem->vdev = vdev; > > + vdev->priv = vpmem; > > + err = init_vq(vpmem); > > + if (err) { > > + dev_err(&vdev->dev, "failed to initialize virtio pmem vq's\n"); > > + goto out_err; > > + } > > + > > + virtio_cread(vpmem->vdev, struct virtio_pmem_config, >

Re: [Qemu-devel] [PATCH] spapr: Print out extra hints when CAS negotiation of interrupt mode fails

2019-05-16 Thread Satheesh Rajendran
On Thu, May 16, 2019 at 09:36:57AM +0200, Greg Kurz wrote: > Let's suggest to the user how the machine should be configured to allow > the guest to boot successfully. > > Suggested-by: Satheesh Rajendran > Signed-off-by: Greg Kurz > --- > hw/ppc/spapr_hcall.c |4 ++-- > 1 file changed, 2 in

Re: [Qemu-devel] [PATCH v4 6/6] acpi: pci: use build_append_foo() API to construct MCFG

2019-05-16 Thread Wei Yang
On Wed, May 15, 2019 at 07:29:17AM +0200, Philippe Mathieu-Daudé wrote: > >Thanks Michael for testing... > >Wei, can you add a MCFG test in tests/bios-tables-test.c? > I took a look into the test, current q35 has already has a reference MCFG in tests/data/acpi/q35/MCFG. And there would be a warn

[Qemu-devel] [PATCH] spapr: Print out extra hints when CAS negotiation of interrupt mode fails

2019-05-16 Thread Greg Kurz
Let's suggest to the user how the machine should be configured to allow the guest to boot successfully. Suggested-by: Satheesh Rajendran Signed-off-by: Greg Kurz --- hw/ppc/spapr_hcall.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spa

<    1   2   3