Re: [Qemu-devel] [RFC v4 5/7] tests: New make target check-source

2019-05-23 Thread Philippe Mathieu-Daudé
On 5/23/19 10:15 AM, Markus Armbruster wrote: > Make target check-source is for checking the source code itself. For > now, there's just one such check, make target check-headers. It > checks basic header sanity: for each header "FOO.h", test whether > > #include "qemu/osdep.h" >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/8] spapr: Clean up dt creation for PCI buses

2019-05-23 Thread Alexey Kardashevskiy
On 23/05/2019 15:29, David Gibson wrote: > Device nodes for PCI bridges (both host and P2P) describe both the bridge > device itself and the bus hanging off it, handling of this is a bit of a > mess. > > spapr_dt_pci_device() has a few things it only adds for non-bridges, but > always adds

Re: [Qemu-devel] [PATCH] hw/rdma: Delete unused headers inclusion

2019-05-23 Thread Marcel Apfelbaum
Hi Markus, On 5/23/19 6:24 PM, Markus Armbruster wrote: Looks stuck. Let's try qemu-trivial. Thanks, that is a great idea. I didn't want to send a single-patch pull request, especially while another is waiting for reviews. Anyway, trivial queue can be used indeed. Thanks, Marcel Yuval

Re: [Qemu-devel] [RFC v4 3/7] Makefile: Rename targets for make recursion

2019-05-23 Thread Philippe Mathieu-Daudé
On 5/23/19 10:15 AM, Markus Armbruster wrote: > We make a few sub-directories recursively, in particular > $(TARGET_DIRS). > > For goal "all", we do it the nice way: "all" has a prerequisite > subdir-T for each T in $(TARGET_DIRS), and T's recipe runs make > recursively. Behaves nicely with -j

Re: [Qemu-devel] [PATCH] hw/rdma: Add support for GID state changes for non-qmp frameworks

2019-05-23 Thread Marcel Apfelbaum
Hi Yuval, On 5/5/19 1:55 PM, Yuval Shaia wrote: Any GID change in guest must be propogate to host. This is already done by firing QMP event to managment system such as libvirt which in turn will update the host with the relevant change. Agreed, *any* management software can do that. When

Re: [Qemu-devel] [RFC v4 2/7] Makefile: Drop bogus cleaning of $(ALL_SUBDIRS)/qemu-options.def

2019-05-23 Thread Philippe Mathieu-Daudé
On 5/23/19 10:15 AM, Markus Armbruster wrote: > When commit df2943ba3c7 moved "rm -f qemu-options.def" from distclean > to clean, it also added "rm -f $$d/qemu-options.def" to the for d in > $(ALL_SUBDIRS) loop. That file doesn't exist. Remove the mistaken > rm. > > Signed-off-by: Markus

Re: [Qemu-devel] [RFC v4 1/7] Makefile: Remove code to smooth transition to config.status

2019-05-23 Thread Philippe Mathieu-Daudé
Hi Markus, On 5/23/19 10:15 AM, Markus Armbruster wrote: > When commit bdf523e6923 made configure generate config.status, it > added a fallback to Makefile to smooth the transition, with a TODO > "code can be removed after QEMU 1.7." It's been more than five years. > Remove it. > >

Re: [Qemu-devel] [PATCH 0/4] tests/docker: add podman support

2019-05-23 Thread Gerd Hoffmann
On Fri, May 24, 2019 at 01:40:07AM +0200, Marc-André Lureau wrote: > Hi, > > podman allows to run containers in a similar fashion as docker, but > without daemon or root privileges. Thank you podman! Well, I saw a rather dramatic increase on disk usage when running podman rootless. Looked like

Re: [Qemu-devel] [PULL 00/38] ppc-for-4.1 queue 20190522

2019-05-23 Thread David Gibson
On Fri, May 24, 2019 at 10:46:16AM +1000, David Gibson wrote: > On Thu, May 23, 2019 at 10:29:57AM +0100, Peter Maydell wrote: > > On Wed, 22 May 2019 at 05:46, David Gibson > > wrote: > > > > > > The following changes since commit > > > a4f667b6714916683408b983cfe0a615a725775f: > > > > > >

[Qemu-devel] [PATCH] BootLinuxConsoleTest: Test the RX-Virt machine

2019-05-23 Thread Philippe Mathieu-Daudé
Add two tests for the rx-virt machine, based on the recommended test setup from Yoshinori Sato: https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg03586.html - U-Boot prompt - Linux kernel with Sash shell These are very quick tests: $ avocado run -t arch:rx

Re: [Qemu-devel] [PULL 07/13] hw/char: RX62N serial communication interface (SCI)

2019-05-23 Thread Philippe Mathieu-Daudé
Hi Paolo, Marc-André, On 5/23/19 4:00 PM, Richard Henderson wrote: > From: Yoshinori Sato > > This module supported only non FIFO type. > Hardware manual. > https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf > > Signed-off-by: Yoshinori Sato >

[Qemu-devel] Patch causing qemu-system-ppc to crash

2019-05-23 Thread Programmingkid
Recently I have noticed that qemu-system-ppc is crashing while booting up my Mac OS X VM. A bit of git bisecting shows this is the patch that causes this issue: commit 1e262b49b5331441f697461e4305fe06719758a7 Author: Richard Henderson Date: Mon Mar 18 12:02:54 2019 -0700 tcg/i386:

Re: [Qemu-devel] [PULL 05/15] hw/ppc: Implement fw_cfg_arch_key_name()

2019-05-23 Thread David Gibson
On Thu, May 23, 2019 at 02:43:10PM +0200, Philippe Mathieu-Daudé wrote: > Implement fw_cfg_arch_key_name(), which returns the name of a > ppc-specific key. > > The fw_cfg device is used by the machine using OpenBIOS: > - 40p > - mac99 (oldworld) > - g3beige (newworld) > > Reviewed-by: Laszlo

Re: [Qemu-devel] [PULL 00/38] ppc-for-4.1 queue 20190522

2019-05-23 Thread David Gibson
On Thu, May 23, 2019 at 10:29:57AM +0100, Peter Maydell wrote: > On Wed, 22 May 2019 at 05:46, David Gibson > wrote: > > > > The following changes since commit a4f667b6714916683408b983cfe0a615a725775f: > > > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into > >

[Qemu-devel] [PATCH 4/4] qemu-sockets: do not require configured ipv4/ipv6 address

2019-05-23 Thread Marc-André Lureau
podman containers without network don't have ipv4/ipv6 addresses other than loopback address. However, some of our tests require getaddrinfo("127.0.0.1") to succeed. Alternatively, we may want to treat 127.0.0.1 as a special case, to keep the AI_ADDRCONFIG convenience. Signed-off-by: Marc-André

[Qemu-devel] [PATCH 2/4] tests/docker: add podman support

2019-05-23 Thread Marc-André Lureau
Allow to specify the container engine to run with ENGINE variable. By default, ENGINE=auto and will select either podman or docker. With current podman, we have to use a uidmap trick in order to be able to rw-share the ccache directory with the container user. With a user 1000, the default

[Qemu-devel] [PATCH 3/4] docker: update fedora to f30

2019-05-23 Thread Marc-André Lureau
Released last month. Signed-off-by: Marc-André Lureau --- tests/docker/dockerfiles/fedora.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker index 69d4a7f5d7..1496b68ba1 100644 ---

[Qemu-devel] [PATCH 0/4] tests/docker: add podman support

2019-05-23 Thread Marc-André Lureau
Hi, podman allows to run containers in a similar fashion as docker, but without daemon or root privileges. Thank you podman! I haven't done extensive testing. Basic make docker-test rules work. There seems to be a few issues with permissions at run time (podman ps fails), but that seems not

[Qemu-devel] [PATCH 1/4] docker.py: add podman support

2019-05-23 Thread Marc-André Lureau
Add a --engine option to select either docker, podman or auto. Among other advantages, podman allows to run rootless & daemonless containers, fortunately sharing compatible CLI with docker. Signed-off-by: Marc-André Lureau --- tests/docker/docker.py | 43

Re: [Qemu-devel] [PATCH 0/4] mips: Add more Avocado tests

2019-05-23 Thread Eduardo Habkost
On Thu, May 23, 2019 at 09:28:00AM -0400, Cleber Rosa wrote: > > > - Original Message - > > From: "Philippe Mathieu-Daudé" > > To: "Eduardo Habkost" , "Cleber Rosa" > > > > Cc: "Aleksandar Rikalo" , "Philippe Mathieu-Daudé" > > , "Wainer dos Santos > > Moschetta" ,

Re: [Qemu-devel] [PATCH] i386: Fix nested SVM on older Opterons

2019-05-23 Thread Eduardo Habkost
On Thu, May 23, 2019 at 07:57:38PM +0100, Dr. David Alan Gilbert wrote: > * Bernhard M. Wiedemann (bwiedem...@suse.de) wrote: > > Without this patch, a VM on a Opteron G3 host will have the svm flag, but > > the kvm-amd module fails to load in there, complaining that it needs > > cpuid 0x800a

Re: [Qemu-devel] [PULL v3 47/55] linux headers: update against Linux 5.2-rc1

2019-05-23 Thread Aleksandar Markovic
On May 22, 2019 3:50 PM, "Cornelia Huck" wrote: > > On Wed, 22 May 2019 15:22:23 +0200 > Aleksandar Markovic wrote: > > > On May 22, 2019 2:24 PM, "Cornelia Huck" wrote: > > > > > > On Wed, 22 May 2019 14:10:39 +0200 > > > Laurent Vivier wrote: > > > > > > > On 22/05/2019 14:07, Cornelia Huck

[Qemu-devel] [PATCH v2 2/2] capstone: Enable disassembly for s390x

2019-05-23 Thread Richard Henderson
Enable s390x, aka SYSZ, in the git submodule build. Set the capstone parameters for both s390x host and guest. Signed-off-by: Richard Henderson --- Makefile | 1 + disas.c| 3 +++ target/s390x/cpu.c | 4 3 files changed, 8 insertions(+) diff --git a/Makefile

[Qemu-devel] [PATCH v2 0/2] Update capstone module

2019-05-23 Thread Richard Henderson
There has recently been some good progress in the upstream capstone repository, syncing the instruction sets from the (further) upstream llvm. In particular, there are Power9 and System z13 instructions. Both of which were missing from our current snapshot and from our (ancient) binutils opcodes

[Qemu-devel] [PATCH v2 1/2] capstone: Update to master

2019-05-23 Thread Richard Henderson
Update to fbb20ea83c5a. Choose this over the 4.0.1 tag because master now includes the s390x z13 vector opcodes. Acked-by: David Hildenbrand Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- capstone | 2 +- configure | 2 +- 2 files

[Qemu-devel] [RISU v3 09/11] i386: Add avx512 state to reginfo_t

2019-05-23 Thread Jan Bobek
From: Richard Henderson The state expected for a given test must be specifically requested with the --xfeatures=mask command-line argument. This is recorded with the saved state so that it is obvious if the apprentice is given a different argument. Any features beyond what are present on the

[Qemu-devel] [RISU v3 11/11] risu_reginfo_i386: rework --xfeatures value parsing

2019-05-23 Thread Jan Bobek
Have the --xfeatures option accept "sse", "avx" and "avx512" in addition to a plain numerical value, purely for users' convenience. Don't fail silently when an incorrect value is specified, to avoid confusion. Suggested-by: Richard Henderson Signed-off-by: Jan Bobek --- risu_reginfo_i386.c |

[Qemu-devel] [RISU v3 07/11] test_i386: change syntax from nasm to gas

2019-05-23 Thread Jan Bobek
This allows us to drop dependency on NASM and build the test image with GCC only. Adds support for x86_64, too. Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Signed-off-by: Jan Bobek --- Makefile| 3 +++ test_i386.S | 41 +

[Qemu-devel] [RISU v3 10/11] risu_reginfo_i386: replace xfeature constants with symbolic names

2019-05-23 Thread Jan Bobek
The original code used "magic numbers", which made it unclear in some places. Include a reference to the Intel manual where the constants' meaning is discussed. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Jan Bobek --- risu_reginfo_i386.c | 48

[Qemu-devel] [RISU v3 04/11] risu_reginfo_i386: implement arch-specific reginfo interface

2019-05-23 Thread Jan Bobek
CPU-specific code in risu_reginfo_* is expected to define and export the following symbols: - arch_long_opts, arch_extra_help, process_arch_opt - reginfo_size - reginfo_init - reginfo_is_eq - reginfo_dump, reginfo_dump_mismatch Make risu_reginfo_i386.c implement this interface; and while we're

[Qemu-devel] [RISU v3 05/11] risu_i386: implement missing CPU-specific functions

2019-05-23 Thread Jan Bobek
risu_i386.c is expected to implement the following functions: - advance_pc - get_reginfo_paramreg, set_ucontext_paramreg - get_risuop - get_pc This patch adds the necessary code. We use EAX as the parameter register and opcode "UD1 %xxx,%eax" for triggering RISU actions. Suggested-by: Richard

[Qemu-devel] [RISU v3 02/11] risu_i386: move reginfo_t and related defines to risu_reginfo_i386.h

2019-05-23 Thread Jan Bobek
In order to build risu successfully for i386, we need files risu_reginfo_i386.{h,c}; this patch adds the former by extracting the relevant code from risu_i386.c. This patch is pure code motion; no functional changes were made. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson

[Qemu-devel] [RISU v3 08/11] configure: add i386/x86_64 architectures

2019-05-23 Thread Jan Bobek
Now that i386 and x86_64 architectures are supported by RISU, we want to detect them and build RISU for them automatically. Suggested-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Jan Bobek --- configure | 10 ++ 1 file changed, 6

[Qemu-devel] [RISU v3 03/11] risu_i386: move reginfo-related code to risu_reginfo_i386.c

2019-05-23 Thread Jan Bobek
In order to build risu successfully for i386, we need files risu_reginfo_i386.{h,c}; this patch adds the latter by extracting the relevant code from risu_i386.c. This patch is pure code motion; no functional changes were made. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson

[Qemu-devel] [RISU v3 01/11] Makefile: undefine the arch name symbol

2019-05-23 Thread Jan Bobek
At least GCC defines the symbol "i386" to 1 to signal the target platform. We need to use "i386" as an undefined symbol in order to correctly include risu_reginfo_i386.h from risu.h. Add an -U option to the build command to make sure the symbol remains undefined. Suggested-by: Richard Henderson

[Qemu-devel] [RISU v3 06/11] risu_i386: remove old unused code

2019-05-23 Thread Jan Bobek
The code being removed is a remnant of the past implementation; it has since been replaced by its more powerful, architecture-independent counterpart in reginfo.c. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Jan Bobek --- risu_i386.c | 58

[Qemu-devel] [RISU v3 00/11] Support for i386/x86_64 with vector extensions

2019-05-23 Thread Jan Bobek
This patch series adds support for i386 and x86_64 architectures to RISU. Notably, vector registers (SSE, AVX, AVX-512) are supported for verification of the apprentice. This is V3 of the series posted in [1] and [2]. Changes is V3: - fix a matching bug caused by misplaced index multiplication

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/1] spapr: Do not re-read the clock on pre_save handler on migration

2019-05-23 Thread Maxiwell S. Garcia
On Thu, May 23, 2019 at 09:29:52AM +1000, David Gibson wrote: > On Mon, May 20, 2019 at 05:43:40PM -0300, Maxiwell S. Garcia wrote: > > This handler was added in the commit: > > 42043e4f1241: spapr: clock should count only if vm is running > > > > In a scenario without migration, this pre_save

Re: [Qemu-devel] [PATCH v2 11/28] MAINTAINERS: update for semihostings new home

2019-05-23 Thread Richard Henderson
On 5/23/19 6:25 AM, Alex Bennée wrote: > Seeing as I touched it I should at least keep an eye on it. > > Signed-off-by: Alex Bennée > Reviewed-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2 17/28] tests/tcg/aarch64: add system boot.S

2019-05-23 Thread Richard Henderson
On 5/23/19 6:25 AM, Alex Bennée wrote: > This provides the bootstrap and low level helper functions for an > aarch64 kernel. We use semihosting to handle test output and exiting > the emulation. semihosting's parameter passing is a little funky so we > end up using the stack and pointing to that

Re: [Qemu-devel] [PATCH v2 09/28] target/mips: only build mips-semi for softmmu

2019-05-23 Thread Richard Henderson
On 5/23/19 6:25 AM, Alex Bennée wrote: > The is_uhi gates all semihosting calls and always returns false for > CONFIG_USER_ONLY builds. There is no reason to build and link > mips-semi for these builds so lets fix that. > > Signed-off-by: Alex Bennée > Reviewed-by: Philippe Mathieu-Daudé >

Re: [Qemu-devel] [RFC v4 5/7] tests: New make target check-source

2019-05-23 Thread Markus Armbruster
Paolo Bonzini writes: > On 23/05/19 10:15, Markus Armbruster wrote: >> A large number of headers don't pass this test, by design or by >> accident. To keep things more manageable, exclude all headers outside >> include/ for now. > > A lot of these, either in include/ or outside, are _meant_ to

Re: [Qemu-devel] [PATCH 00/15] block: AioContext management, part 2

2019-05-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190523160104.21258-1-kw...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 00/15] block: AioContext management, part 2 Type: series Message-id:

Re: [Qemu-devel] [PATCH 3/3] capstone: Enable disassembly for s390x

2019-05-23 Thread Richard Henderson
On 5/23/19 3:26 PM, Richard Henderson wrote: > On 5/22/19 10:42 PM, Richard Henderson wrote: >> Enable s390x, aka SYSZ, in the git submodule build. >> Set the capstone parameters for both s390x host and guest. >> Install a skipdata hook to keep capstone in sync with the >> instruction stream for

Re: [Qemu-devel] [PATCH 3/3] capstone: Enable disassembly for s390x

2019-05-23 Thread Richard Henderson
On 5/22/19 10:42 PM, Richard Henderson wrote: > Enable s390x, aka SYSZ, in the git submodule build. > Set the capstone parameters for both s390x host and guest. > Install a skipdata hook to keep capstone in sync with the > instruction stream for unknown opcodes. > > Signed-off-by: Richard

Re: [Qemu-devel] [PATCH 1/3] capstone: Adjust include of capstone.h

2019-05-23 Thread Richard Henderson
On 5/23/19 7:07 AM, Daniel P. Berrangé wrote: > On Wed, May 22, 2019 at 10:42:27PM -0400, Richard Henderson wrote: >> Since v4.0, capstone.h has moved to . > NB this was a regression bug in capstone pkg-config file which has been > fixed upstream > >

Re: [Qemu-devel] [PULL v3 47/55] linux headers: update against Linux 5.2-rc1

2019-05-23 Thread Laurent Vivier
On 23/05/2019 21:16, Alex Bennée wrote: > > Laurent Vivier writes: > >> On 23/05/2019 13:56, Cornelia Huck wrote: >>> On Wed, 22 May 2019 15:22:23 +0200 >>> Aleksandar Markovic wrote: >>> The alternative way of invoking via IPCV6 (else part of “ifdef __NR_MSGSND”) should work for

Re: [Qemu-devel] [PULL v3 47/55] linux headers: update against Linux 5.2-rc1

2019-05-23 Thread Alex Bennée
Laurent Vivier writes: > On 23/05/2019 13:56, Cornelia Huck wrote: >> On Wed, 22 May 2019 15:22:23 +0200 >> Aleksandar Markovic wrote: >> >>> The alternative way of invoking via IPCV6 (else part of “ifdef >>> __NR_MSGSND”) should work for MIPS in the present stage of headers and >>> kernel.

Re: [Qemu-devel] [PATCH] i386: Fix nested SVM on older Opterons

2019-05-23 Thread Dr. David Alan Gilbert
* Bernhard M. Wiedemann (bwiedem...@suse.de) wrote: > Without this patch, a VM on a Opteron G3 host will have the svm flag, but > the kvm-amd module fails to load in there, complaining that it needs > cpuid 0x800a > > I have successfully built and tested this for 3+ years in production > on

[Qemu-devel] [PATCH] bios-tables-test: add diff allowed list

2019-05-23 Thread Michael S. Tsirkin
Expected table change is then handled like this: 1. add table to diff allowed list 2. change generating code (can be combined with 1) 3. maintainer runs a script to update expected + blows away allowed diff list Signed-off-by: Michael S. Tsirkin --- So I got tired of manual "remember to

Re: [Qemu-devel] [PATCH 2/4] qemu-common: Move qemu_isalnum() etc. to qemu/ctype.h

2019-05-23 Thread Richard Henderson
On 5/23/19 10:35 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > block/ssh.c| 1 + > block/vvfat.c | 1 + > gdbstub.c | 2 ++ > hw/core/bus.c | 2 +- > hw/core/qdev-properties.c | 1 + >

Re: [Qemu-devel] [PATCH 1/4] qemu-common: Move tcg_enabled() etc. to sysemu/tcg.h

2019-05-23 Thread Richard Henderson
On 5/23/19 10:35 AM, Markus Armbruster wrote: > Other accelerators have their own headers: sysemu/hax.h, sysemu/hvf.h, > sysemu/kvm.h, sysemu/whpx.h. Only tcg_enabled() & friends sit in > qemu-common.h. This necessitates inclusion of qemu-common.h into > headers, which is against the rules

Re: [Qemu-devel] Running linux on qemu omap

2019-05-23 Thread Aaro Koskinen
Hi, On Thu, May 23, 2019 at 02:00:41PM +0200, Philippe Mathieu-Daudé wrote: > On 5/23/19 1:27 PM, Thomas Huth wrote: > > On 22/05/2019 20.19, Aaro Koskinen wrote: > >> On Wed, May 22, 2019 at 11:33:41AM +0200, Corentin Labbe wrote: > >>> qemu-system-arm -M help |grep OMAP > >>> cheetah

Re: [Qemu-devel] [PATCH] linux-user: fix __NR_semtimedop undeclared error

2019-05-23 Thread Philippe Mathieu-Daudé
On Thu, May 23, 2019 at 8:29 PM Philippe Mathieu-Daudé wrote: > On 5/23/19 7:54 PM, Laurent Vivier wrote: > > In current code, __NR_msgrcv and__NR_semtimedop are supposed to be > > defined if __NR_msgsnd is defined. > > > > But linux headers 5.2-rc1 for MIPS define __NR_msgsnd without defining >

Re: [Qemu-devel] [PATCH] linux-user: fix __NR_semtimedop undeclared error

2019-05-23 Thread Philippe Mathieu-Daudé
On 5/23/19 7:54 PM, Laurent Vivier wrote: > In current code, __NR_msgrcv and__NR_semtimedop are supposed to be > defined if __NR_msgsnd is defined. > > But linux headers 5.2-rc1 for MIPS define __NR_msgsnd without defining > __NR_semtimedop and it breaks the QEMU build. > > __NR_semtimedop is

Re: [Qemu-devel] [RISU v2 00/11] Support for i386/x86_64 with vector extensions

2019-05-23 Thread Richard Henderson
On 5/23/19 2:03 PM, Jan Bobek wrote: > I ran some experiments on my laptop's Intel(R) Core(TM) i5-4210U to > find out what actually happens. This CPU supports AVX (but not > AVX-512) and doesn't support XSAVEC, so I only looked at XSAVE and > XSAVEOPT (XSAVES is kernel-mode only). I found out

Re: [Qemu-devel] [RISU v2 00/11] Support for i386/x86_64 with vector extensions

2019-05-23 Thread Jan Bobek
On 5/21/19 12:49 PM, Richard Henderson wrote: > SSE2 is a mandatory part of the x86_64 ABI. > > I sincerely doubt we care about testing 32-bit that does not have SSE, but > even > then this patch set will not fail, as the kernel will not include the SSE > registers into the signal frame. It

Re: [Qemu-devel] [PATCH v3 3/5] QEMUMachine: add events_wait method

2019-05-23 Thread John Snow
On 5/23/19 1:49 PM, Max Reitz wrote: > On 23.05.19 19:06, John Snow wrote: >> Instead of event_wait which looks for a single event, add an events_wait >> which can look for any number of events simultaneously. However, it >> will still only return one at a time, whichever happens first. >> >>

[Qemu-devel] [PATCH] linux-user: fix __NR_semtimedop undeclared error

2019-05-23 Thread Laurent Vivier
In current code, __NR_msgrcv and__NR_semtimedop are supposed to be defined if __NR_msgsnd is defined. But linux headers 5.2-rc1 for MIPS define __NR_msgsnd without defining __NR_semtimedop and it breaks the QEMU build. __NR_semtimedop is defined in asm-mips/unistd_n64.h and asm-mips/unistd_n32.h

Re: [Qemu-devel] [PATCH v3 0/5] blockdev-backup: don't check aio_context too early

2019-05-23 Thread Max Reitz
On 23.05.19 19:06, John Snow wrote: > See patch one's commit message for justification. > Patches 2-5 are for testing, because that's always how these things go. > > 001/5:[] [--] 'blockdev-backup: don't check aio_context too early' > 002/5:[0004] [FC] 'iotests.py: do not use infinite waits'

Re: [Qemu-devel] [PATCH v3 3/5] QEMUMachine: add events_wait method

2019-05-23 Thread Max Reitz
On 23.05.19 19:06, John Snow wrote: > Instead of event_wait which looks for a single event, add an events_wait > which can look for any number of events simultaneously. However, it > will still only return one at a time, whichever happens first. > > Signed-off-by: John Snow > --- >

Re: [Qemu-devel] [PATCH 0/4] mips: Add more Avocado tests

2019-05-23 Thread Aleksandar Markovic
On May 23, 2019 7:27 PM, "Philippe Mathieu-Daudé" wrote: > > On 5/23/19 7:11 PM, Aleksandar Markovic wrote: > > On May 23, 2019 3:45 PM, "Cleber Rosa" wrote: > >>> From: "Aleksandar Markovic" > >>> On May 22, 2019 11:46 PM, "Cleber Rosa" wrote: > > From: "Eduardo Habkost" > > > >

Re: [Qemu-devel] [PATCH v5 0/3] qemu-img: rebase: Improve/optimize rebase operation

2019-05-23 Thread Max Reitz
On 23.05.19 18:33, Sam Eiderman wrote: > This patch series aims to improve the speed of qemu-img rebase. > > 1. Mainly by removing unnecessary reads when rebasing on the same > chain. > 2. But also by minimizing the number of bdrv_open calls rebase > requires. > > v2: > > * Added

Re: [Qemu-devel] [PULL 00/10] Linux user for 4.1 patches

2019-05-23 Thread Aleksandar Markovic
On May 23, 2019 6:51 PM, wrote: > > Patchew URL: https://patchew.org/QEMU/20190523144336.13960-1-laur...@vivier.eu/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Message-id: 20190523144336.13960-1-laur...@vivier.eu > Type:

Re: [Qemu-devel] [PATCH v4 02/11] block: Filtered children access functions

2019-05-23 Thread Max Reitz
On 17.05.19 16:50, Vladimir Sementsov-Ogievskiy wrote: > 10.04.2019 23:20, Max Reitz wrote: >> What bs->file and bs->backing mean depends on the node. For filter >> nodes, both signify a node that will eventually receive all R/W >> accesses. For format nodes, bs->file contains metadata and data,

Re: [Qemu-devel] [PATCH 0/4] mips: Add more Avocado tests

2019-05-23 Thread Philippe Mathieu-Daudé
On 5/23/19 7:11 PM, Aleksandar Markovic wrote: > On May 23, 2019 3:45 PM, "Cleber Rosa" wrote: >>> From: "Aleksandar Markovic" >>> On May 22, 2019 11:46 PM, "Cleber Rosa" wrote: > From: "Eduardo Habkost" > > Until we actually have a mechanism to exclude the test case on >

[Qemu-devel] [PATCH v3 5/5] iotests: add iotest 250 for testing blockdev-backup across iothread contexts

2019-05-23 Thread John Snow
Signed-off-by: John Snow --- tests/qemu-iotests/250 | 122 + tests/qemu-iotests/250.out | 119 tests/qemu-iotests/group | 1 + 3 files changed, 242 insertions(+) create mode 100755 tests/qemu-iotests/250 create

[Qemu-devel] [PATCH v3 3/5] QEMUMachine: add events_wait method

2019-05-23 Thread John Snow
Instead of event_wait which looks for a single event, add an events_wait which can look for any number of events simultaneously. However, it will still only return one at a time, whichever happens first. Signed-off-by: John Snow --- python/qemu/__init__.py | 69

Re: [Qemu-devel] [PATCH 0/4] mips: Add more Avocado tests

2019-05-23 Thread Aleksandar Markovic
On May 23, 2019 3:45 PM, "Cleber Rosa" wrote: > > > > - Original Message - > > From: "Aleksandar Markovic" > > To: "Cleber Rosa" > > Cc: "Wainer dos Santos Moschetta" , "Aleksandar Markovic" , > > qemu-devel@nongnu.org, "Aleksandar Rikalo" , "Eduardo Habkost" , > > "Aurelien Jarno" ,

[Qemu-devel] [PATCH v3 2/5] iotests.py: do not use infinite waits

2019-05-23 Thread John Snow
Cap waits to 60 seconds so that iotests can fail gracefully if something goes wrong. Signed-off-by: John Snow --- tests/qemu-iotests/iotests.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index

[Qemu-devel] [PATCH v3 0/5] blockdev-backup: don't check aio_context too early

2019-05-23 Thread John Snow
See patch one's commit message for justification. Patches 2-5 are for testing, because that's always how these things go. 001/5:[] [--] 'blockdev-backup: don't check aio_context too early' 002/5:[0004] [FC] 'iotests.py: do not use infinite waits' 003/5:[down] 'QEMUMachine: add

[Qemu-devel] [PATCH v3 4/5] iotests.py: rewrite run_job to be pickier

2019-05-23 Thread John Snow
Don't pull events out of the queue that don't belong to us; be choosier so that we can use this method to drive jobs that were launched by transactions that may have more jobs. Signed-off-by: John Snow --- tests/qemu-iotests/iotests.py | 48 +-- 1 file changed,

[Qemu-devel] [PATCH v3 1/5] blockdev-backup: don't check aio_context too early

2019-05-23 Thread John Snow
in blockdev_backup_prepare, we check to make sure that the target is associated with a compatible aio context. However, do_blockdev_backup is called later and has some logic to move the target to a compatible aio_context. The transaction version will fail certain commands needlessly early as a

Re: [Qemu-devel] [PATCH] vmstate: Add VMSTATE_OPAQUE to save/load complex data structures

2019-05-23 Thread Roman Kiryanov via Qemu-devel
Hi Dave, thank you for looking. > Can you give me an example of where you would use it? We use it in our host memory sharing device. I used the existing macros for all fields I could, but unfortunately some state does not fit into them. We use this new macro to save/load memory allocators (for

Re: [Qemu-devel] [RFC v4 5/7] tests: New make target check-source

2019-05-23 Thread Paolo Bonzini
On 23/05/19 10:15, Markus Armbruster wrote: > A large number of headers don't pass this test, by design or by > accident. To keep things more manageable, exclude all headers outside > include/ for now. A lot of these, either in include/ or outside, are _meant_ to be included many times. What

Re: [Qemu-devel] [PATCH 3/3] block/gluster: update .help of BLOCK_OPT_PREALLOC option

2019-05-23 Thread Markus Armbruster
Stefano Garzarella writes: > Show 'falloc' and 'full' among the allowed values of > 'preallocation' option, only when they are supported > ('falloc' is support if defined CONFIG_GLUSTERFS_FALLOCATE, > 'full' is support if defined CONFIG_GLUSTERFS_ZEROFILL) You could mention that 'falloc' is

Re: [Qemu-devel] [PATCH 2/3] block/file-posix: update .help of BLOCK_OPT_PREALLOC option

2019-05-23 Thread Markus Armbruster
Stefano Garzarella writes: > Show 'falloc' among the allowed values of 'preallocation' > option, only when it is supported (if defined CONFIG_POSIX_FALLOCATE) > > Signed-off-by: Stefano Garzarella > --- > block/file-posix.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff

Re: [Qemu-devel] [PULL 00/10] Linux user for 4.1 patches

2019-05-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190523144336.13960-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190523144336.13960-1-laur...@vivier.eu Type: series Subject: [Qemu-devel] [PULL 00/10] Linux user for

Re: [Qemu-devel] [PATCH v4 2/3] qemu-img: rebase: Reduce reads on in-chain rebase

2019-05-23 Thread Sam Eiderman
Yes, my bad, resending as v5. Sam > On 23 May 2019, at 19:14, Max Reitz wrote: > > On 23.05.19 17:44, Sam Eiderman wrote: >> In the following case: >> >> (base) A <- B <- C (tip) >> >> when running: >> >>qemu-img rebase -b A C >> >> QEMU would read all sectors not allocated in the file

Re: [Qemu-devel] [PATCH 1/2] net/announce: Allow optional list of interfaces

2019-05-23 Thread Markus Armbruster
"Dr. David Alan Gilbert (git)" writes: > From: "Dr. David Alan Gilbert" > > Allow the caller to restrict the set of interfaces that announces are > sent on. The default is still to send on all interfaces. > > e.g. > > { "execute": "announce-self", "arguments": { "initial": 50, "max": 550, >

[Qemu-devel] [PATCH v5 3/3] qemu-img: rebase: Reuse in-chain BlockDriverState

2019-05-23 Thread Sam Eiderman
If a chain was detected, don't open a new BlockBackend from the target backing file which will create a new BlockDriverState. Instead, create an empty BlockBackend and attach the already open BlockDriverState. Permissions for blk_new() were copied from blk_new_open() when flags = 0. Reviewed-by:

[Qemu-devel] [PATCH v5 0/3] qemu-img: rebase: Improve/optimize rebase operation

2019-05-23 Thread Sam Eiderman
This patch series aims to improve the speed of qemu-img rebase. 1. Mainly by removing unnecessary reads when rebasing on the same chain. 2. But also by minimizing the number of bdrv_open calls rebase requires. v2: * Added missing g_free in "qemu-img: rebase: Reuse in-chain

[Qemu-devel] [PATCH v5 1/3] qemu-img: rebase: Reuse parent BlockDriverState

2019-05-23 Thread Sam Eiderman
In safe mode we open the entire chain, including the parent backing file of the rebased file. Do not open a new BlockBackend for the parent backing file, which saves opening the rest of the chain twice, which for long chains saves many "pricy" bdrv_open() calls. Permissions for blk_new() were

Re: [Qemu-devel] [PATCH 1/3] qapi/block-core: update documentation of preallocation parameter

2019-05-23 Thread Markus Armbruster
Stefano Garzarella writes: > Add default and available values in the documentation block of > each block device or protocol that supports the 'preallocation' > parameter during the image creation. > > Suggested-by: Markus Armbruster > Signed-off-by: Stefano Garzarella > --- >

Re: [Qemu-devel] [PATCH 1/2] net/announce: Allow optional list of interfaces

2019-05-23 Thread Eric Blake
On 5/23/19 9:58 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Allow the caller to restrict the set of interfaces that announces are > sent on. The default is still to send on all interfaces. > > e.g. > > { "execute": "announce-self", "arguments": { "initial":

[Qemu-devel] [PATCH v5 2/3] qemu-img: rebase: Reduce reads on in-chain rebase

2019-05-23 Thread Sam Eiderman
In the following case: (base) A <- B <- C (tip) when running: qemu-img rebase -b A C QEMU would read all sectors not allocated in the file being rebased (C) and compare them to the new base image (A), regardless of whether they were changed or even allocated anywhere along the chain

[Qemu-devel] [PATCH v2 1/4] BootLinuxConsoleTest: Let extract_from_deb handle various compressions

2019-05-23 Thread Philippe Mathieu-Daudé
Debian binary package format supports various compressions. Per man deb(5): NAME deb - Debian binary package format FORMAT ... The third, last required member is named data.tar. It contains the filesystem as a tar archive, either not compressed (supported since dpkg

Re: [Qemu-devel] [PATCH v2 0/4] mips: Add more Avocado tests

2019-05-23 Thread Philippe Mathieu-Daudé
On Thu, May 23, 2019 at 6:18 PM Philippe Mathieu-Daudé wrote: > > Hi, > > It was a rainy week-end here, so I invested it to automatize some > of my MIPS tests. > > The BootLinuxSshTest is not Global warming friendly, it is not > meant to run on a CI system but rather on a workstation previous >

[Qemu-devel] [PATCH v2 0/4] mips: Add more Avocado tests

2019-05-23 Thread Philippe Mathieu-Daudé
Hi, It was a rainy week-end here, so I invested it to automatize some of my MIPS tests. The BootLinuxSshTest is not Global warming friendly, it is not meant to run on a CI system but rather on a workstation previous to post a pull request. It can surely be improved, but it is a good starting

Re: [Qemu-devel] [PATCH v2 3/4] iotests.py: rewrite run_job to be pickier

2019-05-23 Thread John Snow
On 5/23/19 8:39 AM, Max Reitz wrote: > On 10.05.19 21:03, John Snow wrote: >> Don't pull events out of the queue that don't belong to us; >> be choosier so that we can use this method to drive jobs that >> were launched by transactions that may have more jobs. >> >> Signed-off-by: John Snow >>

[Qemu-devel] [PATCH v2 4/4] BootLinuxSshTest: Test some userspace commands on Malta

2019-05-23 Thread Philippe Mathieu-Daudé
This tests boot a full VM and check the serial console until the SSH daemon is running, then start a SSH session and run some commands. This test can be run using: $ avocado --show=ssh run -t arch:mips tests/acceptance/linux_ssh_mips_malta.py ssh: Entering interactive session. ssh: # uname

Re: [Qemu-devel] [PATCH v4 1/3] qemu-img: rebase: Reuse parent BlockDriverState

2019-05-23 Thread Max Reitz
On 23.05.19 17:44, Sam Eiderman wrote: > In safe mode we open the entire chain, including the parent backing > file of the rebased file. > Do not open a new BlockBackend for the parent backing file, which > saves opening the rest of the chain twice, which for long chains > saves many "pricy"

Re: [Qemu-devel] [PATCH v4 3/3] qemu-img: rebase: Reuse in-chain BlockDriverState

2019-05-23 Thread Max Reitz
On 23.05.19 17:44, Sam Eiderman wrote: > If a chain was detected, don't open a new BlockBackend from the target > backing file which will create a new BlockDriverState. Instead, create > an empty BlockBackend and attach the already open BlockDriverState. > > Permissions for blk_new() were copied

[Qemu-devel] [PATCH v2 2/4] BootLinuxConsoleTest: Test nanoMIPS kernels on the I7200 CPU

2019-05-23 Thread Philippe Mathieu-Daudé
Similar to the x86_64/pc test, it boots a Linux kernel on a Malta machine and verify the serial is working. Use the documentation added in commit f7d257cb4a17 to test nanoMIPS kernels and the I7200 CPU. This test can be run using: $ avocado --show=console run -t arch:mipsel

[Qemu-devel] [PATCH 03/15] block: Add BlockBackend.ctx

2019-05-23 Thread Kevin Wolf
This adds a new parameter to blk_new() which requires its callers to declare from which AioContext this BlockBackend is going to be used (or the locks of which AioContext need to be taken anyway). The given context is only stored and kept up to date when changing AioContexts. Actually applying

[Qemu-devel] qapi/misc.json is too big, let's bite off a few chunks

2019-05-23 Thread Markus Armbruster
It's nice when QAPI schema modules clearly belong to a single subsystem in addition to "QAPI Schema". misc.json doesn't, and it's grown fat: 3000+ lines. Let's move out some stuff. Here are a few candidates: * Dump (Marc-André) dump-guest-memory, query-dump, DUMP_COMPLETED,

[Qemu-devel] [PATCH v2 3/4] BootLinuxConsoleTest: Run kerneltests BusyBox on Malta

2019-05-23 Thread Philippe Mathieu-Daudé
This tests boots a Linux kernel on a Malta machine up to a busybox shell on the serial console. Few commands are executed before halting the machine (via reboot). We use the initrd cpio image from the kerneltests project: https://kerneltests.org/ If MIPS is a target being built, "make

Re: [Qemu-devel] [PATCH v4 2/3] qemu-img: rebase: Reduce reads on in-chain rebase

2019-05-23 Thread Max Reitz
On 23.05.19 17:44, Sam Eiderman wrote: > In the following case: > > (base) A <- B <- C (tip) > > when running: > > qemu-img rebase -b A C > > QEMU would read all sectors not allocated in the file being rebased (C) > and compare them to the new base image (A), regardless of whether they >

[Qemu-devel] [PATCH 08/15] test-block-iothread: BlockBackend AioContext across root node change

2019-05-23 Thread Kevin Wolf
Test that BlockBackends preserve their assigned AioContext even when the root node goes away. Inserting a new root node will move it to the right AioContext. Signed-off-by: Kevin Wolf --- tests/test-block-iothread.c | 33 + 1 file changed, 33 insertions(+) diff

[Qemu-devel] [PATCH 07/15] test-block-iothread: Test adding parent to iothread node

2019-05-23 Thread Kevin Wolf
Opening a new parent node for a node that has already been moved into a different AioContext must cause the new parent ot move into the same context. Signed-off-by: Kevin Wolf --- tests/test-block-iothread.c | 33 + 1 file changed, 33 insertions(+) diff --git

  1   2   3   4   >