[Qemu-devel] [Bug 504368] Re: sdl window intermittently scales instead of resizing

2019-05-24 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/504368 Title: sdl window

[Qemu-devel] [Bug 1313816] Re: qemu should close sound device when no more needs.

2019-05-24 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1313816 Title: qemu

[Qemu-devel] [Bug 504368] Re: sdl window intermittently scales instead of resizing

2019-05-24 Thread Launchpad Bug Tracker
[Expired for qemu-kvm (Ubuntu) because there has been no activity for 60 days.] ** Changed in: qemu-kvm (Ubuntu) Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1617114] Re: Qemu 2.6.0 freezes with windows guests

2019-05-24 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1617114 Title: Qemu 2.6.0

[Qemu-devel] [Bug 1730099] Re: Sometimes, when not touching the SDL window, the guest freezes

2019-05-24 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1730099 Title: Sometimes,

[Qemu-devel] [Bug 1730101] Re: The guest is only starting after its SDL window gets focus

2019-05-24 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1730101 Title: The guest

[Qemu-devel] Question about wrong ram-node0 reference

2019-05-24 Thread liujunjie (A)
Hi, I have met a problem: The QEMU version is 2.8.1, the virtual machine is configured with 1G huge pages, two NUMA nodes and four pass-through NVME SSDs. After we started the VM, in addition to some QMP queries nothing more has been done, the QEMU aborted after some months later. After that,

[Qemu-devel] [PATCH 1/2] Implement Floating Point flag Fraction Rounded

2019-05-24 Thread John Arbuckle
Signed-off-by: John Arbuckle --- fpu/softfloat.c | 15 --- include/fpu/softfloat-types.h | 1 + 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 2ba36ec370..ac34f6a2de 100644 --- a/fpu/softfloat.c +++

[Qemu-devel] [PATCH 0/2] Implement PowerPC FPSCR flag Fraction Rounded

2019-05-24 Thread John Arbuckle
In IEEE 754 math, the arithmetic, rounding, and conversion instructions produce an intermediate result that can be regarded as having infinite precision and unbounded exponent range. When the final result has its fraction part incremented is when the Fraction Rounded bit is set. This patch

[Qemu-devel] [PATCH 2/2] Implement the PowerPC Floating Point Status and Control Register Fraction Rounded bit

2019-05-24 Thread John Arbuckle
Signed-off-by: John Arbuckle --- target/ppc/fpu_helper.c | 4 1 file changed, 4 insertions(+) diff --git a/target/ppc/fpu_helper.c b/target/ppc/fpu_helper.c index 0b7308f539..0baf1ce8e4 100644 --- a/target/ppc/fpu_helper.c +++ b/target/ppc/fpu_helper.c @@ -630,6 +630,10 @@ static void

[Qemu-devel] [RFC v1 01/23] target/riscv: Don't set write permissions on dirty PTEs

2019-05-24 Thread Alistair Francis
Setting write permission on dirty PTEs results in userspace inside a Hypervisor guest (VU) becoming corrupted. This appears to be becuase it ends up with write permission in the second stage translation in cases where we aren't doing a store. Signed-off-by: Alistair Francis ---

[Qemu-devel] [RFC v1 03/23] target/riscv: Add the virtulisation mode

2019-05-24 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/cpu.h| 4 target/riscv/cpu_bits.h | 6 ++ target/riscv/cpu_helper.c | 23 +++ 3 files changed, 33 insertions(+) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index 3337d1aef3..de4843b879 100644 ---

[Qemu-devel] [RFC v1 05/23] target/riscv: Add the Hypervisor CSRs to CPUState

2019-05-24 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/cpu.h | 17 + 1 file changed, 17 insertions(+) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index eeb3756c91..b99d2b7af2 100644 --- a/target/riscv/cpu.h +++ b/target/riscv/cpu.h @@ -169,12 +169,29 @@ struct CPURISCVState {

[Qemu-devel] [RFC v1 06/23] target/riscv: Dump Hypervisor registers if enabled

2019-05-24 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 65556ac543..c1495ef037 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -220,14 +220,41 @@ static void

[Qemu-devel] [RFC v1 09/23] target/riscv: Add Hypervisor CSR access functions

2019-05-24 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/csr.c | 68 ++ 1 file changed, 68 insertions(+) diff --git a/target/riscv/csr.c b/target/riscv/csr.c index c1fcb795cd..c52fde6e7f 100644 --- a/target/riscv/csr.c +++ b/target/riscv/csr.c @@ -82,6 +82,20

[Qemu-devel] [RFC v1 02/23] target/riscv: Add the Hypervisor extension

2019-05-24 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index 8937bda918..3337d1aef3 100644 --- a/target/riscv/cpu.h +++ b/target/riscv/cpu.h @@ -81,6 +81,7 @@ #define RVC RV('C') #define RVS RV('S')

[Qemu-devel] [RFC v1 11/23] target/riscv: Add background register swapping function

2019-05-24 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/cpu.h| 1 + target/riscv/cpu_bits.h | 5 target/riscv/cpu_helper.c | 52 +++ 3 files changed, 58 insertions(+) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index b99d2b7af2..9897392ab7

[Qemu-devel] [RFC v1 12/23] target/ricsv: Flush the TLB on virtulisation mode changes

2019-05-24 Thread Alistair Francis
To ensure our TLB isn't out-of-date we flush it on all virt mode changes. Unlike priv mode this isn't saved in the mmu_idx as all guests share V=1. The easiest option is just to flush on all changes. Signed-off-by: Alistair Francis --- target/riscv/cpu_helper.c | 5 + 1 file changed, 5

[Qemu-devel] [RFC v1 13/23] target/riscv: Generate illegal instruction on WFI when V=1

2019-05-24 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/op_helper.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/riscv/op_helper.c b/target/riscv/op_helper.c index 644d0fb35f..e08bb8dd5a 100644 --- a/target/riscv/op_helper.c +++ b/target/riscv/op_helper.c @@ -130,9

[Qemu-devel] [RFC v1 07/23] target/riscv: Remove strict perm checking for CSR R/W

2019-05-24 Thread Alistair Francis
The privledge check based on the CSR address mask 0x300 doesn't work when using Hypervisor extensions so remove the check Signed-off-by: Alistair Francis --- target/riscv/csr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/riscv/csr.c b/target/riscv/csr.c index

[Qemu-devel] [RFC v1 14/23] riscv: plic: Remove unused interrupt functions

2019-05-24 Thread Alistair Francis
Signed-off-by: Alistair Francis --- hw/riscv/sifive_plic.c | 12 include/hw/riscv/sifive_plic.h | 3 --- 2 files changed, 15 deletions(-) diff --git a/hw/riscv/sifive_plic.c b/hw/riscv/sifive_plic.c index 07a032d93d..1e7e4c8d51 100644 --- a/hw/riscv/sifive_plic.c +++

[Qemu-devel] [RFC v1 00/23] Add RISC-V Hypervisor Extension

2019-05-24 Thread Alistair Francis
This patch series adds the RISC-V Hypervisor extension 0.3. This is the latest draft spec of the Hypervisor extension. This series applies ontop of the RISC-V tree as it requires the previous Hypervisor extension patches as well as the CPU parsing patches, both of which have been accepted to the

[Qemu-devel] [RFC v1 18/23] target/riscv: Add hfence instructions

2019-05-24 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/insn32.decode| 23 ++- .../riscv/insn_trans/trans_privileged.inc.c | 40 +++ 2 files changed, 54 insertions(+), 9 deletions(-) diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode

[Qemu-devel] [RFC v1 08/23] target/riscv: Add support for background interrupt setting

2019-05-24 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/cpu_helper.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index 0fdc81f71f..1f466effcf 100644 --- a/target/riscv/cpu_helper.c +++

[Qemu-devel] [RFC v1 15/23] riscv: plic: Always set sip.SEIP bit for HS

2019-05-24 Thread Alistair Francis
When the PLIC generates an interrupt ensure we always set it for the SIP CSR that corresponds to the HS (V=0) register. Signed-off-by: Alistair Francis --- hw/riscv/sifive_plic.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/hw/riscv/sifive_plic.c

[Qemu-devel] [RFC v1 19/23] target/riscv: Allow specifying MMU stage

2019-05-24 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/cpu_helper.c | 35 +++ 1 file changed, 27 insertions(+), 8 deletions(-) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index b7e47b97f5..3c963d26bc 100644 --- a/target/riscv/cpu_helper.c +++

[Qemu-devel] [RFC v1 04/23] target/riscv: Add the force HS exception mode

2019-05-24 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/cpu.h| 2 ++ target/riscv/cpu_bits.h | 6 ++ target/riscv/cpu_helper.c | 23 +++ 3 files changed, 31 insertions(+) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index de4843b879..eeb3756c91 100644 ---

[Qemu-devel] [RFC v1 16/23] target/riscv: Add hypvervisor trap support

2019-05-24 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/cpu_bits.h | 4 +-- target/riscv/cpu_helper.c | 71 +-- target/riscv/csr.c| 4 +-- 3 files changed, 65 insertions(+), 14 deletions(-) diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h

[Qemu-devel] [RFC v1 17/23] target/riscv: Add Hypervisor trap return support

2019-05-24 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/op_helper.c | 66 1 file changed, 54 insertions(+), 12 deletions(-) diff --git a/target/riscv/op_helper.c b/target/riscv/op_helper.c index e08bb8dd5a..60dcd73fc7 100644 --- a/target/riscv/op_helper.c +++

[Qemu-devel] [RFC v1 10/23] target/riscv: Add background CSRs accesses

2019-05-24 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/cpu_bits.h | 11 target/riscv/csr.c | 119 2 files changed, 130 insertions(+) diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h index c898bb1102..9c27727e6f 100644 ---

[Qemu-devel] [RFC v1 20/23] target/riscv: Allow specifying number of MMU stages

2019-05-24 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/cpu_helper.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index 3c963d26bc..f57e49c973 100644 --- a/target/riscv/cpu_helper.c +++ b/target/riscv/cpu_helper.c @@

[Qemu-devel] [RFC v1 22/23] target/riscv: Call the second stage MMU in virtualisation mode

2019-05-24 Thread Alistair Francis
The qemu_log_mask(CPU_LOG_MMU,... calls trigger false positive checkpatch errors which are being ignored. Signed-off-by: Alistair Francis --- target/riscv/cpu_helper.c | 118 -- 1 file changed, 99 insertions(+), 19 deletions(-) diff --git

[Qemu-devel] [RFC v1 21/23] target/riscv: Implement second stage MMU

2019-05-24 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/cpu_helper.c | 87 +++ 1 file changed, 78 insertions(+), 9 deletions(-) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index f57e49c973..387c12547b 100644 --- a/target/riscv/cpu_helper.c +++

[Qemu-devel] [RFC v1 23/23] target/riscv: Allow enabling the Hypervisor extension

2019-05-24 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 4 target/riscv/cpu.h | 1 + 2 files changed, 5 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index c1495ef037..b17dfb86c6 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -436,6 +436,9 @@ static void

Re: [Qemu-devel] [RFC v1 00/23] Add RISC-V Hypervisor Extension

2019-05-24 Thread Alistair Francis
On Fri, May 24, 2019 at 4:47 PM Alistair Francis wrote: > > This patch series adds the RISC-V Hypervisor extension 0.3. This is the > latest draft spec of the Hypervisor extension. Argh! I forgot to CC Atish and Anup, they are CCed now. Just an FYI I will be on vacation next week, so any replys

Re: [Qemu-devel] Patch causing qemu-system-ppc to crash

2019-05-24 Thread Programmingkid
> On May 24, 2019, at 2:56 AM, Mark Cave-Ayland > wrote: > > On 24/05/2019 03:48, Programmingkid wrote: > >> Recently I have noticed that qemu-system-ppc is crashing while booting up my >> Mac OS X VM. A bit of git bisecting shows this is the patch that causes this >> issue: >> >> commit

Re: [Qemu-devel] [PATCH 2/3] block/qcow2-bitmap: get rid of bdrv_has_changed_persistent_bitmaps

2019-05-24 Thread John Snow
On 5/23/19 11:47 AM, Vladimir Sementsov-Ogievskiy wrote: > Firstly, no reason to optimize failure path. Then, function name is > ambiguous: it checks for readonly and similar things, but someone may > think that it will ignore normal bitmaps which was just unchanged, and > this is in bad

Re: [Qemu-devel] [PATCH 1/3] iotests: add test 255 to check bitmap life after snapshot + commit

2019-05-24 Thread John Snow
On 5/23/19 11:47 AM, Vladimir Sementsov-Ogievskiy wrote: > Two testcases with persistent bitmaps are not added here, as there are > bugs to be fixed soon. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > python/qemu/__init__.py| 4 +- > tests/qemu-iotests/255 | 81

Re: [Qemu-devel] [PATCH 0/4] mips: Add more Avocado tests

2019-05-24 Thread Eduardo Habkost
On Fri, May 24, 2019 at 10:32:36PM +0200, Aleksandar Markovic wrote: > On May 24, 2019 9:40 PM, "Eduardo Habkost" wrote: > > > > On Thu, May 23, 2019 at 07:27:35PM +0200, Philippe Mathieu-Daudé wrote: > > > On 5/23/19 7:11 PM, Aleksandar Markovic wrote: > > > > On May 23, 2019 3:45 PM, "Cleber

Re: [Qemu-devel] [PATCH v3] numa: improve cpu hotplug error message with a wrong node-id

2019-05-24 Thread Eduardo Habkost
On Fri, May 24, 2019 at 04:39:12PM +0200, Laurent Vivier wrote: > On 24/05/2019 16:10, Igor Mammedov wrote: > > On Fri, 24 May 2019 12:35:21 +0200 > > Laurent Vivier wrote: > > > > > On pseries, core-ids are strongly binded to a node-id by the command > > > line option. If an user tries to add a

Re: [Qemu-devel] [PATCH 0/4] mips: Add more Avocado tests

2019-05-24 Thread Aleksandar Markovic
On May 24, 2019 9:40 PM, "Eduardo Habkost" wrote: > > On Thu, May 23, 2019 at 07:27:35PM +0200, Philippe Mathieu-Daudé wrote: > > On 5/23/19 7:11 PM, Aleksandar Markovic wrote: > > > On May 23, 2019 3:45 PM, "Cleber Rosa" wrote: > > >>> From: "Aleksandar Markovic" > > >>> On May 22, 2019 11:46

Re: [Qemu-devel] Introducing GSoC project: API Documentation Generation

2019-05-24 Thread Paolo Bonzini
On 24/05/19 21:08, Eduardo Habkost wrote: > On Fri, May 24, 2019 at 08:34:23PM +0200, Paolo Bonzini wrote: >> On 23/05/19 14:20, John Snow wrote: >>> OK, if that's where we're at! I just saw the RFC from Peter Maydell and >>> assumed we were a little further along the decision making process, but

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-24 Thread David Hildenbrand
On 24.05.19 21:45, Christian Borntraeger wrote: > > > On 24.05.19 21:00, David Hildenbrand wrote: >> On 24.05.19 20:36, David Hildenbrand wrote: >>> On 24.05.19 20:28, Christian Borntraeger wrote: On 24.05.19 20:04, David Hildenbrand wrote: > On 24.05.19 19:54, Philippe

Re: [Qemu-devel] [PATCH 0/4] mips: Add more Avocado tests

2019-05-24 Thread Eduardo Habkost
On Fri, May 24, 2019 at 03:45:56PM +0200, Aleksandar Markovic wrote: > On May 23, 2019 11:31 PM, "Eduardo Habkost" wrote: > > > > On Thu, May 23, 2019 at 09:28:00AM -0400, Cleber Rosa wrote: > > > > > > > > > - Original Message - > > > > From: "Philippe Mathieu-Daudé" > > > > To:

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-24 Thread Christian Borntraeger
On 24.05.19 21:00, David Hildenbrand wrote: > On 24.05.19 20:36, David Hildenbrand wrote: >> On 24.05.19 20:28, Christian Borntraeger wrote: >>> >>> >>> On 24.05.19 20:04, David Hildenbrand wrote: On 24.05.19 19:54, Philippe Mathieu-Daudé wrote: > Hi Christian, > > I'm having

Re: [Qemu-devel] [PATCH 0/4] mips: Add more Avocado tests

2019-05-24 Thread Eduardo Habkost
On Thu, May 23, 2019 at 07:27:35PM +0200, Philippe Mathieu-Daudé wrote: > On 5/23/19 7:11 PM, Aleksandar Markovic wrote: > > On May 23, 2019 3:45 PM, "Cleber Rosa" wrote: > >>> From: "Aleksandar Markovic" > >>> On May 22, 2019 11:46 PM, "Cleber Rosa" wrote: > > From: "Eduardo Habkost" >

Re: [Qemu-devel] [PATCH v2 0/3] aspeed: cleanups and extensions

2019-05-24 Thread Eduardo Habkost
On Thu, May 23, 2019 at 03:03:11PM +0200, Cédric Le Goater wrote: > On 5/23/19 2:52 PM, Peter Maydell wrote: > > On Mon, 20 May 2019 at 17:32, Philippe Mathieu-Daudé > > wrote: > >> > >> On 5/20/19 3:32 PM, Cédric Le Goater wrote: > Peter, > > do you want me to resend with only

Re: [Qemu-devel] Introducing GSoC project: API Documentation Generation

2019-05-24 Thread Eduardo Habkost
On Fri, May 24, 2019 at 08:34:23PM +0200, Paolo Bonzini wrote: > On 23/05/19 14:20, John Snow wrote: > > OK, if that's where we're at! I just saw the RFC from Peter Maydell and > > assumed we were a little further along the decision making process, but > > maybe not. I'll stay tuned. > > For the

Re: [Qemu-devel] [RFC v3 0/3] scsi: restart dma after vm change state handlers

2019-05-24 Thread Michael S. Tsirkin
On Fri, May 24, 2019 at 08:47:18PM +0200, Paolo Bonzini wrote: > On 24/05/19 20:36, Stefan Hajnoczi wrote: > > v3: > > * Fix s/k->vmstate_change/vdc->vmstate_change/ > > * Still RFC, waiting for customer to confirm this fixes the issue > > v2: > > * Do it properly with a clean API instead of

Re: [Qemu-devel] [PATCH v6 05/10] esp: add pseudo-DMA as used by Macintosh

2019-05-24 Thread Laurent Vivier
On 25/01/2019 06:48, Thomas Huth wrote: On 2018-11-02 16:22, Mark Cave-Ayland wrote: From: Laurent Vivier I'd suggest to add a patch description that contains the text that Laurent provided as a reply to this patch in v5: 8<

Re: [Qemu-devel] qapi/misc.json is too big, let's bite off a few chunks

2019-05-24 Thread Eduardo Habkost
On Thu, May 23, 2019 at 06:14:18PM +0200, Markus Armbruster wrote: > It's nice when QAPI schema modules clearly belong to a single subsystem > in addition to "QAPI Schema". misc.json doesn't, and it's grown fat: > 3000+ lines. Let's move out some stuff. Here are a few candidates: > > * Dump

Re: [Qemu-devel] [RFC v3 0/3] scsi: restart dma after vm change state handlers

2019-05-24 Thread Paolo Bonzini
On 24/05/19 20:36, Stefan Hajnoczi wrote: > v3: > * Fix s/k->vmstate_change/vdc->vmstate_change/ > * Still RFC, waiting for customer to confirm this fixes the issue > v2: > * Do it properly with a clean API instead of deferring to a BH! >Thanks for encouraging me to do this, Kevin. > >

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-24 Thread David Hildenbrand
On 24.05.19 20:36, David Hildenbrand wrote: > On 24.05.19 20:28, Christian Borntraeger wrote: >> >> >> On 24.05.19 20:04, David Hildenbrand wrote: >>> On 24.05.19 19:54, Philippe Mathieu-Daudé wrote: Hi Christian, I'm having hard time to understand why the S390_IPL object calls

[Qemu-devel] [PULL 17/17] hw/intc/nvic: Use object_initialize_child for correct reference counting

2019-05-24 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé As explained in commit aff39be0ed97: Both functions, object_initialize() and object_property_add_child() increase the reference counter of the new object, so one of the references has to be dropped afterwards to get the reference counting right. Otherwise

Re: [Qemu-devel] Running linux on qemu omap

2019-05-24 Thread Aaro Koskinen
Hi, On Fri, May 24, 2019 at 06:00:18PM +0300, Aaro Koskinen wrote: > Please don't delete OMAP boards quite yet :) In the mainline kernel > they are not orphaned, they frequently get tested using actual hardware, > and QEMU would help in additional testing. I'll try to get N8x0 boot to > work with

[Qemu-devel] [PULL 14/17] hw/microblaze/zynqmp: Use object_initialize_child for correct ref. counting

2019-05-24 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé As explained in commit aff39be0ed97: Both functions, object_initialize() and object_property_add_child() increase the reference counter of the new object, so one of the references has to be dropped afterwards to get the reference counting right. Otherwise

[Qemu-devel] [PULL 15/17] hw/microblaze/zynqmp: Use object_initialize_child for correct ref. counting

2019-05-24 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé As explained in commit aff39be0ed97: Both functions, object_initialize() and object_property_add_child() increase the reference counter of the new object, so one of the references has to be dropped afterwards to get the reference counting right. Otherwise

Re: [Qemu-devel] [PATCH] configure: remove tpm_passthrough & tpm_emulator

2019-05-24 Thread Paolo Bonzini
On 24/05/19 20:14, Marc-André Lureau wrote: > This is a left-over from commit 7aaa6a16373 "tpm: express dependencies > with Kconfig". > > Signed-off-by: Marc-André Lureau > --- > configure | 10 -- > 1 file changed, 10 deletions(-) > > diff --git a/configure b/configure > index

[Qemu-devel] [PULL 11/17] hw/mips: Use object_initialize_child for correct reference counting

2019-05-24 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé As explained in commit aff39be0ed97: Both functions, object_initialize() and object_property_add_child() increase the reference counter of the new object, so one of the references has to be dropped afterwards to get the reference counting right. Otherwise

[Qemu-devel] [PULL 10/17] hw/mips: Use object_initialize() on MIPSCPSState

2019-05-24 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé Initialize the MIPSCPSState with object_initialize() instead of object_new(). This will allow us to add it as children of the machine container. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190507163416.24647-10-phi...@redhat.com> Reviewed-by: Paolo Bonzini

[Qemu-devel] [PULL 09/17] hw/arm: Use object_initialize_child for correct reference counting

2019-05-24 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé As explained in commit aff39be0ed97: Both functions, object_initialize() and object_property_add_child() increase the reference counter of the new object, so one of the references has to be dropped afterwards to get the reference counting right. Otherwise

[Qemu-devel] [PULL 08/17] hw/arm/aspeed: Use object_initialize_child for correct ref. counting

2019-05-24 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé As explained in commit aff39be0ed97: Both functions, object_initialize() and object_property_add_child() increase the reference counter of the new object, so one of the references has to be dropped afterwards to get the reference counting right. Otherwise

[Qemu-devel] [PULL 16/17] hw/arm/mps2: Use object_initialize_child for correct reference counting

2019-05-24 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé As explained in commit aff39be0ed97: Both functions, object_initialize() and object_property_add_child() increase the reference counter of the new object, so one of the references has to be dropped afterwards to get the reference counting right. Otherwise

[Qemu-devel] [PULL 07/17] hw/arm/bcm2835: Use object_initialize_child for correct ref. counting

2019-05-24 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé As explained in commit aff39be0ed97: Both functions, object_initialize() and object_property_add_child() increase the reference counter of the new object, so one of the references has to be dropped afterwards to get the reference counting right. Otherwise

[Qemu-devel] [PULL 13/17] hw/microblaze/zynqmp: Let the SoC manage the IPI devices

2019-05-24 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé The Inter Processor Interrupt is a block part of the SoC, not the "machine" (See Zynq UltraScale+ Device TRM UG1085, "Platform Management Unit", Power Domains and Islands). Move the IPI management from the machine to the SoC. Signed-off-by: Philippe Mathieu-Daudé

[Qemu-devel] [PULL 06/17] hw/arm/bcm2835: Use object_initialize() on PL011State

2019-05-24 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé To be coherent with the other peripherals contained in the BCM2835PeripheralState structure, directly allocate the PL011State (instead of using the pl011 uart as a pointer to a SysBusDevice). Initialize the PL011State with object_initialize() instead of

[Qemu-devel] [PULL 04/17] hw/virtio: Use object_initialize_child for correct reference counting

2019-05-24 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé As explained in commit aff39be0ed97: Both functions, object_initialize() and object_property_add_child() increase the reference counter of the new object, so one of the references has to be dropped afterwards to get the reference counting right. Otherwise

[Qemu-devel] [PULL 05/17] hw/arm/bcm2835: Use TYPE_PL011 instead of hardcoded string

2019-05-24 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190507163416.24647-5-phi...@redhat.com> Reviewed-by: Paolo Bonzini Reviewed-by: Alistair Francis Signed-off-by: Eduardo Habkost --- include/hw/arm/bcm2835_peripherals.h | 1 + hw/arm/bcm2835_peripherals.c

[Qemu-devel] [PULL 03/17] hw/misc/macio: Use object_initialize_child for correct ref. counting

2019-05-24 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé As explained in commit aff39be0ed97: Both functions, object_initialize() and object_property_add_child() increase the reference counter of the new object, so one of the references has to be dropped afterwards to get the reference counting right. Otherwise

[Qemu-devel] [PULL 12/17] hw/microblaze/zynqmp: Move the IPI state into the PMUSoC state

2019-05-24 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé The Inter Processor Interrupt is a block part of the SoC, not the "machine" (talking about machine is borderline with the PMU, since it is embedded into the ZynqMP SoC, but currentl QEMU doesn't support multi-arch cores). Move the IPI state to the SoC state, this

[Qemu-devel] [PULL 02/17] hw/ppc/pnv: Use object_initialize_child for correct reference counting

2019-05-24 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé As explained in commit aff39be0ed97: Both functions, object_initialize() and object_property_add_child() increase the reference counter of the new object, so one of the references has to be dropped afterwards to get the reference counting right. Otherwise

[Qemu-devel] [PULL 00/17] Machine Core queue, 2019-05-24

2019-05-24 Thread Eduardo Habkost
The following changes since commit a7b21f6762a2d6ec08106d8a7ccb11829914523f: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-4.1-pull-request' into staging (2019-05-24 12:47:49 +0100) are available in the Git repository at: git://github.com/ehabkost/qemu.git

[Qemu-devel] [PULL 01/17] qom/object: Display more helpful message when an object type is missing

2019-05-24 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé When writing a new board, adding device which uses other devices (container) or simply refactoring, one can discover the hard way his machine misses some devices. In the case of containers, the error is not obvious: $ qemu-system-microblaze -M xlnx-zynqmp-pmu **

Re: [Qemu-devel] [PATCH v2 4/4] BootLinuxSshTest: Test some userspace commands on Malta

2019-05-24 Thread Eduardo Habkost
On Thu, May 23, 2019 at 06:18:32PM +0200, Philippe Mathieu-Daudé wrote: > This tests boot a full VM and check the serial console until > the SSH daemon is running, then start a SSH session and run > some commands. > > This test can be run using: > > $ avocado --show=ssh run -t arch:mips >

[Qemu-devel] [RFC v3 3/3] virtio-scsi: fix iothread deadlock on 'cont'

2019-05-24 Thread Stefan Hajnoczi
When the 'cont' command resumes guest execution the vm change state handlers are invoked. Unfortunately there is no explicit ordering between vm change state handlers. When two layers of code both use vm change state handlers, we don't control which handler runs first. virtio-scsi with

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-24 Thread David Hildenbrand
On 24.05.19 20:28, Christian Borntraeger wrote: > > > On 24.05.19 20:04, David Hildenbrand wrote: >> On 24.05.19 19:54, Philippe Mathieu-Daudé wrote: >>> Hi Christian, >>> >>> I'm having hard time to understand why the S390_IPL object calls >>> qemu_register_reset(qdev_reset_all_fn) in its

[Qemu-devel] [RFC v3 2/3] scsi: add scsi_bus_dma_restart()

2019-05-24 Thread Stefan Hajnoczi
By default scsi-bus.c registers vm change state handlers for SCSIDevice instances and restarts DMA when guest execution is resumed. Unfortunately virtio-scsi with iothreads has a special ordering requirement that the core virtio code's vm change state handler runs before scsi-bus.c's vm change

[Qemu-devel] [RFC v3 1/3] virtio: add vdc->vmchange_state() callback

2019-05-24 Thread Stefan Hajnoczi
The core virtio code invokes ->set_status() followed by ->ioeventfd_start() when the guest resumes execution. Both of these functions are also called in other cases unrelated to vm change state. This patch introduces ->vmstate_change() so that devices can act on guest pause/resume. The existing

[Qemu-devel] [RFC v3 0/3] scsi: restart dma after vm change state handlers

2019-05-24 Thread Stefan Hajnoczi
v3: * Fix s/k->vmstate_change/vdc->vmstate_change/ * Still RFC, waiting for customer to confirm this fixes the issue v2: * Do it properly with a clean API instead of deferring to a BH! Thanks for encouraging me to do this, Kevin. These patches solve a deadlock when the 'cont' command is

Re: [Qemu-devel] Introducing GSoC project: API Documentation Generation

2019-05-24 Thread Paolo Bonzini
On 23/05/19 14:20, John Snow wrote: > OK, if that's where we're at! I just saw the RFC from Peter Maydell and > assumed we were a little further along the decision making process, but > maybe not. I'll stay tuned. For the decision making, yes; I think there's consensus to use kerneldoc. For the

Re: [Qemu-devel] qapi/misc.json is too big, let's bite off a few chunks

2019-05-24 Thread Paolo Bonzini
On 23/05/19 18:14, Markus Armbruster wrote: > * Machine core (Eduardo, Marcel) > > query-machines, query-current-machine, > > ~60 lines. Hardly worthwhile from a "let's shrink misc.json" point of > view. Might be worthwhile from a "let's make get_maintainers.pl > work". > > * CPUs

[Qemu-devel] [PATCH] configure: remove tpm_passthrough & tpm_emulator

2019-05-24 Thread Marc-André Lureau
This is a left-over from commit 7aaa6a16373 "tpm: express dependencies with Kconfig". Signed-off-by: Marc-André Lureau --- configure | 10 -- 1 file changed, 10 deletions(-) diff --git a/configure b/configure index 528b9ff705..4da99ee750 100755 --- a/configure +++ b/configure @@

Re: [Qemu-devel] [RFC v2 1/3] virtio: add vdc->vmchange_state() callback

2019-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2019 at 2:55 PM Stefan Hajnoczi wrote: > @@ -2253,10 +2254,18 @@ static void virtio_vmstate_change(void *opaque, int > running, RunState state) > virtio_set_status(vdev, vdev->status); > } > > +if (!backend_run && k->vmstate_change) { > +

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-24 Thread Eduardo Habkost
On Thu, May 23, 2019 at 10:35:24AM +0200, Andrea Bolognani wrote: > On Wed, 2019-05-15 at 13:54 +0200, Andrew Jones wrote: > > On Wed, May 15, 2019 at 12:52:29PM +0200, Igor Mammedov wrote: > > > since using magic numbers is not very descriptive > > > (but if there is some spec where they come

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-24 Thread Philippe Mathieu-Daudé
On 5/24/19 8:04 PM, David Hildenbrand wrote: > On 24.05.19 19:54, Philippe Mathieu-Daudé wrote: >> Hi Christian, >> >> I'm having hard time to understand why the S390_IPL object calls >> qemu_register_reset(qdev_reset_all_fn) in its realize() method, while >> being QOM'ified (it has a reset

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-24 Thread Christian Borntraeger
On 24.05.19 20:04, David Hildenbrand wrote: > On 24.05.19 19:54, Philippe Mathieu-Daudé wrote: >> Hi Christian, >> >> I'm having hard time to understand why the S390_IPL object calls >> qemu_register_reset(qdev_reset_all_fn) in its realize() method, while >> being QOM'ified (it has a reset

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-24 Thread David Hildenbrand
On 24.05.19 19:54, Philippe Mathieu-Daudé wrote: > Hi Christian, > > I'm having hard time to understand why the S390_IPL object calls > qemu_register_reset(qdev_reset_all_fn) in its realize() method, while > being QOM'ified (it has a reset method). > > It doesn't seem to have a qdev children

[Qemu-devel] [PATCH] event_match: always match on None value

2019-05-24 Thread John Snow
Before, event_match didn't always recurse if the event value was not a dictionary, and would instead check for equality immediately. By delaying equality checking to post-recursion, we can allow leaf values like "5" to match "None" and take advantage of the generic None-returns-True clause. This

Re: [Qemu-devel] [RFC 0/3] block: Inquire images’ rotational info

2019-05-24 Thread Eric Blake
On 5/24/19 12:28 PM, Max Reitz wrote: > Hi, > > http://lists.nongnu.org/archive/html/qemu-block/2019-05/msg00569.html > shows that optimizations affect HDDs and SSDs differently. It would be > nice if we could differentiate between the two and then choose to adjust > our behavior depending on

Re: [Qemu-devel] [PATCH v3 3/5] QEMUMachine: add events_wait method

2019-05-24 Thread John Snow
On 5/24/19 8:38 AM, Max Reitz wrote: > On 23.05.19 20:03, John Snow wrote: >> >> >> On 5/23/19 1:49 PM, Max Reitz wrote: >>> On 23.05.19 19:06, John Snow wrote: Instead of event_wait which looks for a single event, add an events_wait which can look for any number of events

[Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-24 Thread Philippe Mathieu-Daudé
Hi Christian, I'm having hard time to understand why the S390_IPL object calls qemu_register_reset(qdev_reset_all_fn) in its realize() method, while being QOM'ified (it has a reset method). It doesn't seem to have a qdev children added explicitly to it. I see it is used as a singleton, what else

[Qemu-devel] [Bug 1830415] [NEW] linux-user elf loader issue

2019-05-24 Thread antonio barbalace
Public bug reported: all versions up to 4.0 (I didn't test others) file affected linux-user/elfload.c function load_elf_image if (phdr[i].p_type == PT_LOAD) { -abi_ulong a = phdr[i].p_vaddr - phdr[i].p_offset; +abi_ulong a = phdr[i].p_vaddr ; // -

Re: [Qemu-devel] [PATCH v2] hw/core/bus.c: Only the main system bus can have no parent

2019-05-24 Thread Philippe Mathieu-Daudé
On 5/23/19 5:05 PM, Peter Maydell wrote: > In commit 80376c3fc2c38fdd453 in 2010 we added a workaround for > some qbus buses not being connected to qdev devices -- if the > bus has no parent object then we register a reset function which > resets the bus on system reset (and unregister it when the

[Qemu-devel] [Bug 1574327] Re: qemu-system-x86_64 -net nic, model=help outputs to stderr instead of std

2019-05-24 Thread Thomas Huth
Finally fixed here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=7b71e03af98fd7b5e1 ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1574327

[Qemu-devel] [Bug 1585971] Re: Host system crashes on qemu with DMA remapping

2019-05-24 Thread Thomas Huth
Triaging old bug tickets ... Can you still reproduce the issue with the latest version of QEMU and the kernel, or could we close this bug nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [RFC 0/3] block: Inquire images’ rotational info

2019-05-24 Thread Max Reitz
Hi, http://lists.nongnu.org/archive/html/qemu-block/2019-05/msg00569.html shows that optimizations affect HDDs and SSDs differently. It would be nice if we could differentiate between the two and then choose to adjust our behavior depending on whether a given image is stored on an HDD or not.

[Qemu-devel] [Bug 1586229] Re: seabios hell

2019-05-24 Thread Thomas Huth
** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1586229 Title: seabios hell Status in QEMU: Invalid Bug description: getting weird annoying

Re: [Qemu-devel] ?==?utf-8?q? ?==?utf-8?q? [PATCH 0/5]?==?utf-8?q? linux-user: Support signal passing for targets having more signals than host

2019-05-24 Thread Milos Stojanovic
Hello, Peter. For this implemenation rt_sigqueueinfo()/rt_tgsigqueueinfo() were used to multiplex signals that are out of the host range. This enabled the use of a wider signal range with rt_sigqueueinfo(), rt_tgsigqueueinfo(), as well as kill() (for pid > 0) and tgkill(). A process can now

[Qemu-devel] [RFC 1/3] block: Add ImageRotationalInfo

2019-05-24 Thread Max Reitz
This enum indicates whether a file is stored on a rotating disk or a solid-state drive. Drivers report it via the .bdrv_get_info() callback, and if they do not, the global bdrv_get_info() implementation automatically takes it from bs->file or bs->backing, if available. On the QAPI side, we

[Qemu-devel] [RFC 2/3] file-posix: Inquire rotational status

2019-05-24 Thread Max Reitz
On Linux, we can inquire whether the file is stored on a rotating disk or on a solid-state drive through the sysfs. (The BLKROTATIONAL ioctl only works on device files themselves.) Signed-off-by: Max Reitz --- block/file-posix.c | 73 ++ 1 file

  1   2   3   4   >