Re: [Qemu-devel] kvm / virsh snapshot management

On 2019-06-10 8:10 p.m., Eric Blake wrote: On 6/10/19 6:00 PM, Gary Dale wrote: Any ideas on what I'm doing wrong? Do you know for sure whether you have internal or external snapshots? And at this point, your questions are starting to wander more into libvirt territory. Yes. I'm using

Re: [Qemu-devel] [PULL 23/44] target/ppc: Use vector variable shifts for VSL, VSR, VSRA

On Fri, Jun 07, 2019 at 09:28:49AM -0500, Richard Henderson wrote: > On 6/7/19 9:09 AM, Laurent Vivier wrote: > > On 07/06/2019 11:29, Laurent Vivier wrote: > >> On 29/05/2019 08:49, David Gibson wrote: > >>> From: Richard Henderson > >>> > >>> The gvec expanders take care of masking the shift

Re: [Qemu-devel] [Qemu-block] [PATCH] file-posix: unlock qemu_global_mutex before pread when attach disk

-- Would the "open" hang as well in that case? The "open" doesn't hang in that case. Do you have any better solutions to solve this problem in the case? On 2019/6/11 0:03, Paolo Bonzini wrote: On 10/06/19 16:51, l00284672 wrote: The pread will hang in attaching disk just when backend

[Qemu-devel] [Bug 1832281] [NEW] tcg bug master / 4.0.0 v8 operation >>> and |=

Public bug reported: vm guest is linux, executed with tcg running this Node.js snippet leads to $ node > a = undefined undefined > a >>> 0 4294967295 host node $ node > a = undefined undefined > a >>> 0 0 same with |= node Welcome to Node.js v12.4.0. Type ".help" for more information. > let

Re: [Qemu-devel] kvm / virsh snapshot management

On 6/10/19 6:00 PM, Gary Dale wrote: >>> Any ideas on what I'm doing wrong? >> Do you know for sure whether you have internal or external snapshots? >> And at this point, your questions are starting to wander more into >> libvirt territory. >> > Yes. I'm using internal snapshots. From your other

Re: [Qemu-devel] [PATCH] tests/acceptance: Improve failure reporting in linux_ssh_mips_malta.py

On Mon, Jun 10, 2019 at 09:49:10PM +0200, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Rather than optputing a cryptic message: > > FAIL: True not found in [False], > > the following will be reported too, if the command output does not meet > specified expectations: > > 'lspci

Re: [Qemu-devel] kvm / virsh snapshot management

On 2019-06-10 6:07 p.m., Eric Blake wrote: On 6/10/19 4:27 PM, Gary Dale wrote: Trying this against a test VM, I ran into a roadblock. My command line and the results are: # virsh blockcommit stretch "/home/secure/virtual/stretch.qcow2" --top stretchS3 --delete --wait error: unsupported flags

Re: [Qemu-devel] kvm / virsh snapshot management

On 6/10/19 5:47 PM, Gary Dale wrote: >>> >>> Since blockcommit would make it impossible for me to revert to an >>> earlier state (because I'm committing the oldest snapshot, if it screws >>> up, I can't undo within virsh), I need to make sure this command is >>> correct. >>> >>> > Interesting.

Re: [Qemu-devel] kvm / virsh snapshot management

On 2019-06-10 6:04 p.m., Eric Blake wrote: On 6/10/19 10:54 AM, Gary Dale wrote: One explanation I've seen of the process is if I delete a snapshot, the changes it contains are merged with its immediate child. Nope.  Deleting a snapshot decrements the reference count on all its data clusters. 

Re: [Qemu-devel] kvm / virsh snapshot management

On 6/10/19 4:27 PM, Gary Dale wrote: >> > Trying this against a test VM, I ran into a roadblock. My command line > and the results are: > > # virsh blockcommit stretch "/home/secure/virtual/stretch.qcow2" --top > stretchS3 --delete --wait > error: unsupported flags (0x2) in function

Re: [Qemu-devel] kvm / virsh snapshot management

On 6/10/19 10:54 AM, Gary Dale wrote: >>> One explanation I've seen of the process is if I delete a snapshot, the >>> changes it contains are merged with its immediate child. >> Nope.  Deleting a snapshot decrements the reference count on all its >> data clusters.  If a data cluster's reference

Re: [Qemu-devel] [PATCH 1/2] docs/specs/index.rst: Fix minor syntax issues

On Jun 10, 2019 5:25 PM, "Peter Maydell" wrote: > > The docs/specs/index.rst has a couple of minor issues which > we didn't notice because we weren't building the manual: > * the ToC entry for the new PPC XIVE docs points to >a nonexistent file > * the initial comment needs to be marked by

Re: [Qemu-devel] [PATCH 2/2] docs: Build and install specs manual

On Jun 10, 2019 5:25 PM, "Peter Maydell" wrote: > > Now we have some rST format docs in the docs/specs/ manual, we should > actually build and install it. > > Signed-off-by: Peter Maydell > --- Acked-by: Aleksandar Markovic > Makefile | 7 ++- > docs/specs/conf.py | 16

Re: [Qemu-devel] [PATCH v21 4/7] target/avr: Add instruction translation

On 6/6/19 12:30 PM, Michael Rolnik wrote: > +if (ctx.check_skip > 0) { > +TCGLabel *skip = gen_new_label(); > +TCGLabel *done = gen_new_label(); > + > +tcg_gen_brcondi_tl(TCG_COND_NE, cpu_skip, 0, skip); > +translate(); > +

Re: [Qemu-devel] kvm / virsh snapshot management

On 2019-06-10 11:54 a.m., Gary Dale wrote: On 2019-06-10 8:19 a.m., Stefan Hajnoczi wrote: On Sat, Jun 01, 2019 at 08:12:01PM -0400, Gary Dale wrote: A while back I converted a raw disk image to qcow2 to be able to use snapshots. However I realize that I may not really understand exactly how

Re: [Qemu-devel] [Qemu-arm] [PATCH 28/42] target/arm: Convert VMOV (imm) to decodetree

Re: [Qemu-devel] [PULL 8/8] travis: Make check-acceptance job more verbose

Hi Eduardo, On 06/07/2019 06:15 PM, Eduardo Habkost wrote: It will help us debug issues when tests fail. Signed-off-by: Eduardo Habkost --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 75e017a5cf..82c74673e1 100644 ---

[Qemu-devel] [PATCH qemu v2] aspeed: Add support for the swift-bmc board

From: Adriana Kobylak The Swift board is an OpenPOWER system hosting POWER processors. Add support for their BMC including the I2C devices as found on HW. Signed-off-by: Adriana Kobylak Reviewed-by: Cédric Le Goater --- hw/arm/aspeed.c | 50 ++

Re: [Qemu-devel] [PATCH v21 4/7] target/avr: Add instruction translation

On 6/6/19 12:30 PM, Michael Rolnik wrote: > +if ((ctx.cpc & (TARGET_PAGE_SIZE - 1)) == 0) { > +break; /* page boundary */ > +} This test isn't right, because this ended the TB if the *first* instruction was located on the page boundary. It also fails to allow for a

Re: [Qemu-devel] [PATCH 7/8] VNC Acceptance test: check protocol version

On 06/07/2019 12:22 PM, Cleber Rosa wrote: This goes a bit further than the other tests, and does a basic (read only) interaction with the VNC protocol. This is not a enough to perform a handshake, but enough to make sure that the socket is somewhat operational and that the expected initial

Re: [Qemu-devel] [PATCH v21 4/7] target/avr: Add instruction translation

On 6/6/19 12:30 PM, Michael Rolnik wrote: > +enum { > +BS_NONE = 0, /* Nothing special (none of the below) */ > +BS_STOP = 1, /* We want to stop translation for any reason */ > +BS_BRANCH = 2, /* A branch condition is reached */ > +BS_EXCP = 3, /* An exception condition is reached

Re: [Qemu-devel] [PATCH 6/8] VNC Acceptance test: simplify test names

On 06/07/2019 12:22 PM, Cleber Rosa wrote: The test name is composed of the class name and method name, so it looks like there's some redundancy here that we can eliminate. Signed-off-by: Cleber Rosa --- tests/acceptance/vnc.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH 5/8] VNC Acceptance test: use UNIX domain sockets to avoid port collisions

On 06/07/2019 12:22 PM, Cleber Rosa wrote: While running in parallel, the VNC tests that use a TCP port easily collide. There's a number of possibilities to reduce the probability of collisions, but none that completely prevents it from happening. So, to avoid those collisions, and given

Re: [Qemu-devel] [PATCH v21 4/7] target/avr: Add instruction translation

On 6/6/19 12:30 PM, Michael Rolnik wrote: > +target_long cpc; > +target_long npc; CPC gets copied back and forth to NPC, but is now otherwise unused. You can drop that. > +static void translate(DisasContext *ctx) > +{ > +uint32_t opcode; > +int res; > +/* PC points to words.

Re: [Qemu-devel] [PATCH 4/8] Boot Linux Console Test: add a test for ppc64 + pseries

Hi Cleber, On 06/07/2019 12:22 PM, Cleber Rosa wrote: Just like the previous tests, boots a Linux kernel on a ppc64 target using the pseries machine. Signed-off-by: Cleber Rosa Reviewed-by: Caio Carrara CC: Daniel P. Berrangé --- .travis.yml| 2 +-

Re: [Qemu-devel] [PATCH v3 3/4] net/announce: Add optional ID

On 6/10/19 1:44 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Previously there was a single instance of the timer used by > monitor triggered announces, that's OK, but when combined with the > previous change that lets you have announces for subsets of interfaces >

Re: [Qemu-devel] [PATCH 3/8] Acceptance tests: drop left over usage of ":avocado: enable"

On 06/07/2019 12:22 PM, Cleber Rosa wrote: Commit 9531d26c10 removed all of ":avocado: enable" tags, but then a new entry was added with the introduction of migration.py. Let's remove it for consistency. Signed-off-by: Cleber Rosa --- tests/acceptance/migration.py | 3 --- 1 file

Re: [Qemu-devel] [PATCH 2/8] tests/requirements.txt: pin paramiko version requirement

On 06/07/2019 12:22 PM, Cleber Rosa wrote: It's a good practice (I'd really say a must) to pin as much as possible of the software versions used during test, so let's apply that to paramiko. According to https://pypi.org/project/paramiko/, 2.4.2 is the latest released version. It's also

[Qemu-devel] [PATCH] tests/acceptance: Improve failure reporting in linux_ssh_mips_malta.py

From: Aleksandar Markovic Rather than optputing a cryptic message: FAIL: True not found in [False], the following will be reported too, if the command output does not meet specified expectations: 'lspci -d 11ab:4620' output doesn't contain the word 'GT-64120' Signed-off-by: Aleksandar

Re: [Qemu-devel] [PATCH v3 1/4] net/announce: Allow optional list of interfaces

On 6/10/19 1:43 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Allow the caller to restrict the set of interfaces that announces are > sent on. The default is still to send on all interfaces. > > e.g. > > { "execute": "announce-self", "arguments": { "initial":

Re: [Qemu-devel] [PATCH 1/8] Travis: print acceptance tests logs in case of job failure

On 06/07/2019 12:22 PM, Cleber Rosa wrote: Because Travis doesn't allow us to keep files produced during tests (such as log files), let's print the complete job log to the "console" in case of job failures. This is a debugging aid, and given that there's been some timeouts happening on some

Re: [Qemu-devel] [PATCH v11 4/7] dm: enable synchronous dax

On Mon, Jun 10 2019 at 5:07am -0400, Pankaj Gupta wrote: > This patch sets dax device 'DAXDEV_SYNC' flag if all the target > devices of device mapper support synchrononous DAX. If device > mapper consists of both synchronous and asynchronous dax devices, > we don't set 'DAXDEV_SYNC' flag. >

[Qemu-devel] [PATCH v3 4/4] net/announce: Add HMP optional ID

From: "Dr. David Alan Gilbert" Add the optional ID to the HMP command. e.g. # start an announce for a long time on eth1 migrate_set_parameter announce-rounds 1000 announce_self "eth1" e1 # start an announce on eth2 announce_self "eth2" e2 # Change e1 to be announcing on eth1

[Qemu-devel] [PATCH v3 3/4] net/announce: Add optional ID

From: "Dr. David Alan Gilbert" Previously there was a single instance of the timer used by monitor triggered announces, that's OK, but when combined with the previous change that lets you have announces for subsets of interfaces it's a bit restrictive if you want to do different things to

[Qemu-devel] [PATCH v3 0/4] network announce; interface selection & IDs

From: "Dr. David Alan Gilbert" Laine asked for some extra features on the network announce support; The first allows the announce timer to announce on a subset of the interfaces. The second allows there to be multiple timers, each with their own parameters (including the interface list).

[Qemu-devel] [PATCH v3 1/4] net/announce: Allow optional list of interfaces

From: "Dr. David Alan Gilbert" Allow the caller to restrict the set of interfaces that announces are sent on. The default is still to send on all interfaces. e.g. { "execute": "announce-self", "arguments": { "initial": 50, "max": 550, "rounds": 5, "step": 50, "interfaces": ["vn2","vn1"] }

[Qemu-devel] [PATCH v3 2/4] net/announce: Add HMP optional interface list

From: "Dr. David Alan Gilbert" Add the optional interface list to the HMP command. i.e. All interfaces announce_self Just the named interfaces: announce_self vn1,vn2 Signed-off-by: Dr. David Alan Gilbert --- hmp-commands.hx | 6 -- hmp.c | 38

Re: [Qemu-devel] [PATCH 28/42] target/arm: Convert VMOV (imm) to decodetree

On 6/10/19 10:12 AM, Peter Maydell wrote: > On Sat, 8 Jun 2019 at 20:29, Richard Henderson > wrote: >> >> On 6/6/19 12:45 PM, Peter Maydell wrote: >>> +n = (a->imm4h << 28) & 0x8000; >>> +i = ((a->imm4h << 4) & 0x70) | a->imm4l; >>> +if (i & 0x40) { >>> +i |= 0x780; >>> +

[Qemu-devel] [Bug 1832250] [NEW] arm32v6/golang:1.10-alpine is broken for qemu 2.8 on MacOS cross-compilation

Public bug reported: FROM arm32v6/golang:1.10-alpine docker build -t openhorizon/ibm.gps_arm:2.0.7 -f ./Dockerfile.arm . Sending build context to Docker daemon 110.6kB Step 1/12 : FROM arm32v6/golang:1.10-alpine 1.10-alpine: Pulling from arm32v6/golang 05276f4299f2: Pull complete 5657e63df536:

Re: [Qemu-devel] [PATCH] hw: misc: Add Aspeed XDMA device

On 6/6/19 6:34 PM, Philippe Mathieu-Daudé wrote: Hi Eddie, On 6/4/19 12:09 AM, Eddie James wrote: The XDMA engine embedded in the Aspeed SOCs performs PCI DMA operations between the SOC (acting as a BMC) and a host processor in a server. If I got your model correctly, it does no DMA

Re: [Qemu-devel] kvm / virsh snapshot management

On 2019-06-10 8:19 a.m., Stefan Hajnoczi wrote: On Sat, Jun 01, 2019 at 08:12:01PM -0400, Gary Dale wrote: A while back I converted a raw disk image to qcow2 to be able to use snapshots. However I realize that I may not really understand exactly how snapshots work. In this particular case, I'm

Re: [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07

On Mon, Jun 10, 2019 at 06:38:05PM +0100, Peter Maydell wrote: > On Mon, 10 Jun 2019 at 18:30, Daniel P. Berrangé wrote: > > Do you have access to any machine in the compile farm or is access > > granted on a per-machine basis ? If i'm reading this page right: > > > >

Re: [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07

On Mon, 10 Jun 2019 at 18:30, Daniel P. Berrangé wrote: > Do you have access to any machine in the compile farm or is access > granted on a per-machine basis ? If i'm reading this page right: > > https://cfarm.tetaneutral.net/machines/list/ > > there is now one aarch64 machine (gcc117) that

Re: [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07

On Mon, Jun 10, 2019 at 06:15:46PM +0100, Peter Maydell wrote: > On Mon, 10 Jun 2019 at 18:12, Daniel P. Berrangé wrote: > > There's been two new LTS releases of Ubuntu since then > > with Xenial and Bionic, so IMHO, it is pretty reasonable > > to want to drop Trusty rather than continuing to

Re: [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07

On Mon, 10 Jun 2019 at 18:12, Daniel P. Berrangé wrote: > There's been two new LTS releases of Ubuntu since then > with Xenial and Bionic, so IMHO, it is pretty reasonable > to want to drop Trusty rather than continuing to spend time > on software versions from 2014 and before. Both our Travis >

Re: [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07

On Mon, Jun 10, 2019 at 02:21:57PM +0100, Peter Maydell wrote: > On Mon, 10 Jun 2019 at 14:11, Eduardo Habkost wrote: > > > > On Mon, Jun 10, 2019 at 01:58:50PM +0100, Peter Maydell wrote: > > > Hi. This fails to build on one of my buildtest machines: > > > > > > ERROR: Cannot use 'python3',

Re: [Qemu-devel] [PATCH 28/42] target/arm: Convert VMOV (imm) to decodetree

On Sat, 8 Jun 2019 at 20:29, Richard Henderson wrote: > > On 6/6/19 12:45 PM, Peter Maydell wrote: > > +n = (a->imm4h << 28) & 0x8000; > > +i = ((a->imm4h << 4) & 0x70) | a->imm4l; > > +if (i & 0x40) { > > +i |= 0x780; > > +} else { > > +i |= 0x800; > > +}

[Qemu-devel] Ubuntu Trusty as supported build platform (was Re: [PULL 0/8] Python queue, 2019-06-07)

On Mon, Jun 10, 2019 at 02:21:57PM +0100, Peter Maydell wrote: > On Mon, 10 Jun 2019 at 14:11, Eduardo Habkost wrote: > > > > On Mon, Jun 10, 2019 at 01:58:50PM +0100, Peter Maydell wrote: > > > Hi. This fails to build on one of my buildtest machines: > > > > > > ERROR: Cannot use 'python3',

Re: [Qemu-devel] [PATCH 15/18] Boot Linux Console Test: add a test for aarch64 + virt

On Mon, Jun 10, 2019 at 09:53:03AM +0100, Daniel P. Berrangé wrote: > On Fri, Jun 07, 2019 at 03:58:57PM -0300, Eduardo Habkost wrote: > > CCing Daniel, who wrote commit 6ab3fc32ea64. > > > > On Fri, Jun 07, 2019 at 11:44:32AM -0400, Cleber Rosa wrote: > > > On Fri, Jun 07, 2019 at 12:42:14AM

Re: [Qemu-devel] [PATCH 1/2] docs/specs/index.rst: Fix minor syntax issues

On 10/06/2019 17:24, Peter Maydell wrote: > The docs/specs/index.rst has a couple of minor issues which > we didn't notice because we weren't building the manual: > * the ToC entry for the new PPC XIVE docs points to >a nonexistent file > * the initial comment needs to be marked by '..', not

Re: [Qemu-devel] qgraph

On 10/06/19 18:12, Andreas Färber wrote: > Am 10.06.19 um 15:52 schrieb Paolo Bonzini: >> On 10/06/19 15:28, Andreas Färber wrote: >>> So if we want a new QMP operation, the most sense would probably make >>> where-can-I-attach-type(foo) returning a list of QOM paths, showing only >>> the first

Re: [Qemu-devel] qgraph

Am 10.06.19 um 15:52 schrieb Paolo Bonzini: > On 10/06/19 15:28, Andreas Färber wrote: >> So if we want a new QMP operation, the most sense would probably make >> where-can-I-attach-type(foo) returning a list of QOM paths, showing only >> the first free slot per bus. That would allow a more

[Qemu-devel] [PATCH v2] qapi: InitSocketAddress: add keepalive option

It's needed to provide keepalive for nbd client to track server availability. Signed-off-by: Vladimir Sementsov-Ogievskiy --- v2: [by Markus's comments] - improve commit message - s/keepalive/keep-alive - update inet_parse() qapi/sockets.json | 5 - util/qemu-sockets.c | 22

Re: [Qemu-devel] [Qemu-block] [PATCH] file-posix: unlock qemu_global_mutex before pread when attach disk

On 10/06/19 16:51, l00284672 wrote: > The pread will hang in attaching disk just when backend storage network > disconnection . Would the "open" hang as well in that case? > I think the locking range of qemu_global_mutex is too large when do qmp > operation. what > does the qemu_global_mutex 

Re: [Qemu-devel] [PATCH v2] Incorrect Stack Pointer shadow register support on some m68k CPUs

Le 09/06/2019 à 18:43, Lucien Murray-Pitts a écrit : > Brief overview; > - Added "CPU class" m68k_feature to each CPU init > so MOVEC can detect wrong CR (Control Register) access > - Added cascaded "inheritance" of m68k_features by calling m680xx_cpu_initfn() > of previous CPU so that 68060

Re: [Qemu-devel] [PATCH] qapi: InitSocketAddress: add keepalive option

07.06.2019 20:22, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> 06.06.2019 14:17, Daniel P. Berrangé wrote: >>> On Thu, Jun 06, 2019 at 01:15:33PM +0300, Vladimir Sementsov-Ogievskiy >>> wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all!

Re: [Qemu-devel] [PULL v2 00/39] tcg: Move softmmu tlb into CPUNegativeOffsetState

request' into staging (2019-06-10 > 11:53:19 +0100) > > are available in the Git repository at: > > https://github.com/rth7680/qemu.git tags/pull-tcg-20190610 > > for you to fetch changes up to 43b3952dea0f763ceeaa2f119c473b5cc6d29c90: > > tcg/arm: Remove mostly u

Re: [Qemu-devel] [QUESTION] How to reduce network latency to improve netperf TCP_RR drastically?

On Tue, Jun 04, 2019 at 03:10:43PM +0800, Like Xu wrote: > Hi Michael， > > At https://www.linux-kvm.org/page/NetworkingTodo, there is an entry for > network latency saying: > > --- > reduce networking latency: > allow handling short packets from softirq or VCPU context > Plan: >We are

Re: [Qemu-devel] [PATCH 1/7] iotests: allow Valgrind checking all QEMU processes

On 6/10/19 10:02 AM, Andrey Shinkevich wrote: > > > On 10/06/2019 17:24, Eric Blake wrote: >> On 6/9/19 1:35 PM, Andrey Shinkevich wrote: >>> With the '-valgrind' option, let all the QEMU processes be run under >>> the Valgrind tool. The Valgrind own parameters may be set with its >>>

[Qemu-devel] [PATCH 2/2] docs: Build and install specs manual

Now we have some rST format docs in the docs/specs/ manual, we should actually build and install it. Signed-off-by: Peter Maydell --- Makefile | 7 ++- docs/specs/conf.py | 16 2 files changed, 22 insertions(+), 1 deletion(-) create mode 100644

[Qemu-devel] [PATCH 0/2] docs: build and install the 'specs' manual

(Sorry for the initial send where I sent only the cover letter and forgot to tell git send-email to send the patches as well...) With the recent addition of the XIVE documentation, we now have some actual .rST format documentation in docs/specs, so we should start building and installing this

[Qemu-devel] [PATCH 1/2] docs/specs/index.rst: Fix minor syntax issues

The docs/specs/index.rst has a couple of minor issues which we didn't notice because we weren't building the manual: * the ToC entry for the new PPC XIVE docs points to a nonexistent file * the initial comment needs to be marked by '..', not '.', or it will appear in the output * the

[Qemu-devel] [PATCH 0/2] docs: build and install the 'specs' manual

With the recent addition of the XIVE documentation, we now have some actual .rST format documentation in docs/specs, so we should start building and installing this manual. Patch 1 in this series fixes up some minor problems with docs/specs/index.rst which we didn't notice because we weren't

Re: [Qemu-devel] [PATCH v21 4/7] target/avr: Add instruction translation

On 6/6/19 12:30 PM, Michael Rolnik wrote: > +void avr_cpu_tcg_init(void) > +{ > +int i; > + > +#define AVR_REG_OFFS(x) offsetof(CPUAVRState, x) > +cpu_pc = tcg_global_mem_new_i32(cpu_env, AVR_REG_OFFS(pc_w), "pc"); > +cpu_Cf = tcg_global_mem_new_i32(cpu_env, AVR_REG_OFFS(sregC), "Cf");

Re: [Qemu-devel] [PATCH v21 3/7] target/avr: Add instruction decoding

On 6/6/19 12:30 PM, Michael Rolnik wrote: > +STS 1001 001 . @ldst_s > + > -- checkpatch error for extra blank line at end of file. r~

Re: [Qemu-devel] [PATCH 1/7] iotests: allow Valgrind checking all QEMU processes

On 10/06/2019 17:24, Eric Blake wrote: > On 6/9/19 1:35 PM, Andrey Shinkevich wrote: >> With the '-valgrind' option, let all the QEMU processes be run under >> the Valgrind tool. The Valgrind own parameters may be set with its >> environment variable VALGRIND_OPTS, e.g. >>

[Qemu-devel] [PULL v2 00/39] tcg: Move softmmu tlb into CPUNegativeOffsetState

://github.com/rth7680/qemu.git tags/pull-tcg-20190610 for you to fetch changes up to 43b3952dea0f763ceeaa2f119c473b5cc6d29c90: tcg/arm: Remove mostly unreachable tlb special case (2019-06-10 07:03:42 -0700) Move softmmu tlb

[Qemu-devel] [PATCH 14/39] target/i386: Use env_cpu, env_archcpu

Cleanup in the boilerplate that each target must define. Replace x86_env_get_cpu with env_archcpu. The combination CPU(x86_env_get_cpu) should have used ENV_GET_CPU to begin; use env_cpu now. Reviewed-by: Alistair Francis Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson ---

Re: [Qemu-devel] [PATCH] qemu-ga: Convert invocation documentation to rST

On Mon, 10 Jun 2019 at 14:45, Peter Maydell wrote: > > The qemu-ga documentation is currently in qemu-ga.texi in > Texinfo format, which we present to the user as: > * a qemu-ga manpage > * a section of the main qemu-doc HTML documentation > > Convert the documentation to rST format, and

Re: [Qemu-devel] [Qemu-block] [PATCH] file-posix: unlock qemu_global_mutex before pread when attach disk

The pread will hang in attaching disk just when backend storage network disconnection . I think the locking range of qemu_global_mutex is too large when do qmp operation. what does the qemu_global_mutex  really protect?  what is the risk of unlocking qemu_global_mutex in qmp? On

Re: [Qemu-devel] Need help generating instruction traces from the emulator.

On Mon, 10 Jun 2019 at 15:24, Nisarg Ujjainkar wrote: > > Hello, > > I am using qemu based aosp (emu-master-dev branch of the aosp) to generate > the instruction traces for android os running on the ARM architecture. > > I am able to generate the CPU instruction using the qemu invocation >

Re: [Qemu-devel] [PATCH] RFC: qio: Improve corking of TLS sessions

On 6/10/19 9:02 AM, Eric Blake wrote: > > send(MSG_MORE) > send() > > is ideal; under the hood, we can translate it to: > > send(MSG_MORE) > gnutls_record_cork() > gnutls_record_send() > send() > if (size > threshold) { > gnutls_record_uncork() > gnutls_record_send() > } else {

Re: [Qemu-devel] [PATCH 1/7] iotests: allow Valgrind checking all QEMU processes

On 6/9/19 1:35 PM, Andrey Shinkevich wrote: > With the '-valgrind' option, let all the QEMU processes be run under > the Valgrind tool. The Valgrind own parameters may be set with its > environment variable VALGRIND_OPTS, e.g. > VALGRIND_OPTS="--leak-check=yes" ./check -qcow2 -valgrind Let's

Re: [Qemu-devel] [PATCH v3 0/8] WIP: Multifd compression support

On 5/20/19 1:35 AM, Wei Yang wrote: > On Wed, May 15, 2019 at 02:15:36PM +0200, Juan Quintela wrote: >> v3: >> - improve the code >> - address David and Markus comments >> - make compression code into methods >> so we can add any other method ading just three functions >> >> Please review, as far

Re: [Qemu-devel] [PATCH v6 6/7] block/nbd-client: nbd reconnect

On 6/10/19 8:29 AM, Vladimir Sementsov-Ogievskiy wrote: >> Hmm, and then, include it into BDRVNBDState? I don't remember why didn't do >> it, and now I don't see any reason for it. We store this information anyway >> for the whole life of the driver.. >> >> So, if I'm going to refactor it, I have

[Qemu-devel] Need help generating instruction traces from the emulator.

Hello, I am using qemu based aosp (emu-master-dev branch of the aosp) to generate the instruction traces for android os running on the ARM architecture. I am able to generate the CPU instruction using the qemu invocation flags. For the

Re: [Qemu-devel] [PATCH] file-posix: unlock qemu_global_mutex before pread when attach disk

Patchew URL: https://patchew.org/QEMU/1560173684-6264-1-git-send-email-lizhen...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] file-posix: unlock qemu_global_mutex before pread when attach disk

Re: [Qemu-devel] [PATCH] qemu-ga: Convert invocation documentation to rST

On Mon, 10 Jun 2019 at 14:56, Paolo Bonzini wrote: > > On 10/06/19 15:45, Peter Maydell wrote: > > +# Canned command to build manpages from a single manual > > +build-manpages = $(call quiet-command,CONFDIR="$(qemu_confdir)" > > sphinx-build $(if $(V),,-q) -W -n -b man -D version=$(VERSION) -D

Re: [Qemu-devel] [PATCH] RFC: qio: Improve corking of TLS sessions

On 6/10/19 4:08 AM, Daniel P. Berrangé wrote: > On Fri, Jun 07, 2019 at 05:14:14PM -0500, Eric Blake wrote: >> Our current implementation of qio_channel_set_cork() is pointless for >> TLS sessions: we block the underlying channel, but still hand things >> piecemeal to gnutls which then produces

Re: [Qemu-devel] qgraph

On 10/06/19 15:28, Andreas Färber wrote: > So if we want a new QMP operation, the most sense would probably make > where-can-I-attach-type(foo) returning a list of QOM paths, showing only > the first free slot per bus. That would allow a more efficient lookup > implementation inside QEMU than

Re: [Qemu-devel] [PATCH] qemu-ga: Convert invocation documentation to rST

On 10/06/19 15:45, Peter Maydell wrote: > +# Canned command to build manpages from a single manual > +build-manpages = $(call quiet-command,CONFDIR="$(qemu_confdir)" sphinx-build > $(if $(V),,-q) -W -n -b man -D version=$(VERSION) -D > release="$(FULL_VERSION)" -d .doctrees/$1

Re: [Qemu-devel] [Qemu-block] [PATCH] file-posix: unlock qemu_global_mutex before pread when attach disk

On 10/06/19 15:34, Zhengui li wrote: > > when do qmp sush as drive_add, qemu main thread locks the > qemu_global_mutex and do pread in raw_probe_alignmen. Pread is a > synchronous operation. If backend storage network has a large delay > or IO pressure is too large, the pread operation will

Re: [Qemu-devel] [PATCH] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size()

On 10/06/19 15:50, Igor Mammedov wrote: > QEMU will crash when device-memory-region-size property is read if > ms->device_memory > wasn't initialized yet. > > Crash can be reproduced with: > $QEMU -preconfig -qmp unix:qmp_socket,server,nowait & > ./scripts/qmp/qom-get -s qmp_socket

[Qemu-devel] [PATCH v5 11/12] qemu-io: adds support for io_uring

Signed-off-by: Aarushi Mehta --- qemu-io.c | 13 + 1 file changed, 13 insertions(+) diff --git a/qemu-io.c b/qemu-io.c index 8d5d5911cb..54b82151c4 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -129,6 +129,7 @@ static void open_help(void) " -n, -- disable host cache, short for -t

[Qemu-devel] [PATCH v5 10/12] block/io_uring: adds userspace completion polling

Signed-off-by: Aarushi Mehta --- block/io_uring.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/block/io_uring.c b/block/io_uring.c index 47e027364a..acfaa48151 100644 --- a/block/io_uring.c +++ b/block/io_uring.c @@ -142,6 +142,21 @@ static void

[Qemu-devel] [PATCH v5 12/12] qemu-iotests/087: checks for io_uring

Signed-off-by: Aarushi Mehta --- tests/qemu-iotests/087 | 26 ++ tests/qemu-iotests/087.out | 10 ++ 2 files changed, 36 insertions(+) diff --git a/tests/qemu-iotests/087 b/tests/qemu-iotests/087 index d6c8613419..0cc7283ad8 100755 ---

[Qemu-devel] [PATCH v5 07/12] blockdev: accept io_uring as option

Signed-off-by: Aarushi Mehta Reviewed-by: Stefan Hajnoczi --- blockdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index 3f44b891eb..a2a5b32604 100644 --- a/blockdev.c +++ b/blockdev.c @@ -386,6 +386,8 @@ static void

[Qemu-devel] [PATCH v5 08/12] block/file-posix.c: extend to use io_uring

Signed-off-by: Aarushi Mehta --- block/file-posix.c | 85 +- 1 file changed, 69 insertions(+), 16 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index d018429672..211dfe5337 100644 --- a/block/file-posix.c +++ b/block/file-posix.c

[Qemu-devel] [PATCH v5 06/12] util/async: add aio interfaces for io_uring

Signed-off-by: Aarushi Mehta Reviewed-by: Stefan Hajnoczi --- util/async.c | 36 1 file changed, 36 insertions(+) diff --git a/util/async.c b/util/async.c index c10642a385..2709f0edc3 100644 --- a/util/async.c +++ b/util/async.c @@ -277,6 +277,14 @@

[Qemu-devel] [PATCH v5 09/12] block: add trace events for io_uring

Signed-off-by: Aarushi Mehta --- block/io_uring.c | 14 -- block/trace-events | 8 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/block/io_uring.c b/block/io_uring.c index f327c7ef96..47e027364a 100644 --- a/block/io_uring.c +++ b/block/io_uring.c @@

[Qemu-devel] [PATCH v5 03/12] block/block: add BDRV flag for io_uring

Signed-off-by: Aarushi Mehta Reviewed-by: Stefan Hajnoczi Reviewed-by: Maxim Levitsky --- include/block/block.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/block/block.h b/include/block/block.h index f9415ed740..5e08df716f 100644 --- a/include/block/block.h +++

[Qemu-devel] [PATCH v5 05/12] stubs: add stubs for io_uring interface

Signed-off-by: Aarushi Mehta Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 1 + stubs/Makefile.objs | 1 + stubs/io_uring.c| 32 3 files changed, 34 insertions(+) create mode 100644 stubs/io_uring.c diff --git a/MAINTAINERS b/MAINTAINERS index

[Qemu-devel] [PATCH v5 04/12] block/io_uring: implements interfaces for io_uring

Aborts when sqe fails to be set as sqes cannot be returned to the ring. Signed-off-by: Aarushi Mehta --- MAINTAINERS | 7 + block/Makefile.objs | 3 + block/io_uring.c| 314 include/block/aio.h | 16 +-

[Qemu-devel] [PATCH] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size()

QEMU will crash when device-memory-region-size property is read if ms->device_memory wasn't initialized yet. Crash can be reproduced with: $QEMU -preconfig -qmp unix:qmp_socket,server,nowait & ./scripts/qmp/qom-get -s qmp_socket /machine.device-memory-region-size Instead of crashing return 0

[Qemu-devel] [PATCH v5 01/12] configure: permit use of io_uring

Signed-off-by: Aarushi Mehta Reviewed-by: Stefan Hajnoczi Reviewed-by: Maxim Levitsky --- configure | 27 +++ 1 file changed, 27 insertions(+) diff --git a/configure b/configure index b091b82cb3..7aa18d308d 100755 --- a/configure +++ b/configure @@ -365,6 +365,7 @@

[Qemu-devel] [PATCH v5 02/12] qapi/block-core: add option for io_uring

Option only enumerates for hosts that support it. Signed-off-by: Aarushi Mehta Reviewed-by: Stefan Hajnoczi --- qapi/block-core.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 1defcde048..db7eedd058 100644 ---

[Qemu-devel] [PATCH v5 00/12] Add support for io_uring

This patch series adds support for the newly developed io_uring Linux AIO interface. Linux io_uring is faster than Linux's AIO asynchronous I/O code, offers efficient buffered asynchronous I/O support, the ability to do I/O without performing a system call via polled I/O, and other efficiency

Re: [Qemu-devel] [PULL 00/39] tcg: Move the softmmu tlb to CPUNegativeOffsetState

On Mon, 10 Jun 2019 at 03:02, Richard Henderson wrote: > > The following changes since commit 185b7ccc11354cbd69b6d53bf8d831dd964f6c88: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190607-2' into > staging (2019-06-07 15:24:13 +0100) > > are available in the Git repository at:

[Qemu-devel] [PATCH] qemu-ga: Convert invocation documentation to rST

The qemu-ga documentation is currently in qemu-ga.texi in Texinfo format, which we present to the user as: * a qemu-ga manpage * a section of the main qemu-doc HTML documentation Convert the documentation to rST format, and present it to the user as: * a qemu-ga manpage * part of the interop/

Re: [Qemu-devel] [PATCH v2 1/5] target/i386: Add cpu die-level topology support for X86CPU

On 2019/6/6 11:32, Eduardo Habkost wrote: On Tue, May 21, 2019 at 12:50:52AM +0800, Like Xu wrote: The die-level as the first PC-specific cpu topology is added to the leagcy cpu topology model which only covers sockets/cores/threads. In the new model with die-level support, the total number of

  1   2   >