Re: [Qemu-devel] [PULL 0/9] target-arm queue

2019-07-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190704160802.12419-1-peter.mayd...@linaro.org/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a

Re: [Qemu-devel] [PULL 0/4] Vga 20190705 patches

2019-07-05 Thread Peter Maydell
are available in the Git repository at: > > git://git.kraxel.org/qemu tags/vga-20190705-pull-request > > for you to fetch changes up to 146dd326c1ff5869ba9e243e30325c44d696c996: > > ati-vga: Fix setting offset together with pitch

[Qemu-devel] [Bug 1462640] Re: shmat fails on 32-to-64 setup

2019-07-05 Thread Alex Bennée
Erm isn't your 64bit pointer being truncated when you build for 32 bit? ** Tags added: mips testcase -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1462640 Title: shmat fails on 32-to-64 setup

[Qemu-devel] [Bug 1835477] Re: Converting qcow2 to vmdk on MacOSX results in a non-bootable image

2019-07-05 Thread Moshe Immerman
Try the solutions in 1828508 ( -o adapter_type=lsilogic,subformat=monolithicFlat) 1776920 ( -S 0 ) do not work either What other steps can I take to troubleshoot? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-07-05 Thread Alexander Popov
This assertion was introduced in the commit a718978ed58a in July 2015. It implies that the size of successful DMA transfers handled in ide_dma_cb() should be multiple of 512 (the size of a sector). But guest systems can initiate DMA transfers that don't fit this requirement. Let's improve the

Re: [Qemu-devel] [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-07-05 Thread Alexander Popov
On 05.07.2019 17:07, Alexander Popov wrote: > This assertion was introduced in the commit a718978ed58a in July 2015. > It implies that the size of successful DMA transfers handled in > ide_dma_cb() should be multiple of 512 (the size of a sector). > > But guest systems can initiate DMA transfers

Re: [Qemu-devel] [PATCH v3 5/6] monitor: adding info tb and tbs to monitor

2019-07-05 Thread Alex Bennée
Markus Armbruster writes: > vandersonmr writes: > I'll leave Vanderson to address your other comments. > > Debugging commands are kind of borderline. Debugging is commonly a > human activity, where HMP is just fine. However, humans create tools to > assist with their activities, and then

[Qemu-devel] [PATCH v2 2/2] hw/i386: Fix linker error when ISAPC is disabled

2019-07-05 Thread Julio Montes
v2: include config-devices.h to use CONFIG_IDE_ISA --- In pc_init1(), ISA IDE is initialized without checking if ISAPC or IDE_ISA configs are enabled. This results in a link error when CONFIG_ISAPC is set to 'n' in the file default-configs/i386-softmmu.mak: hw/i386/pc_piix.o: In function

[Qemu-devel] [PATCH v2 1/2] Makefile: generate header file with the list of devices enabled

2019-07-05 Thread Julio Montes
v2: generate config-devices.h which contains the list of devices enabled --- config-devices.h is an auto-generated header file that will use config-devices.mak to define the list of devices enabled. Configs that are set to 'n' are ignored. Signed-off-by: Julio Montes --- Makefile.target

Re: [Qemu-devel] [PATCH v2 04/18] qapi: add BitmapSyncMode enum

2019-07-05 Thread Markus Armbruster
John Snow writes: > Depending on what a user is trying to accomplish, there might be a few > bitmap cleanup actions that occur when an operation is finished that > could be useful. > > I am proposing three: > - NEVER: The bitmap is never synchronized against what was copied. > - ALWAYS: The

Re: [Qemu-devel] [PATCH for 4.1] gdbstub: revert to previous set_reg behaviour

2019-07-05 Thread Philippe Mathieu-Daudé
On 7/5/19 3:29 PM, Alex Bennée wrote: > The refactoring of handle_set_reg missed the fact we previously had > responded with an empty packet when we were not using XML based > protocols. This broke the fallback behaviour for architectures that > don't have registers defined in QEMU's gdb-xml

[Qemu-devel] [PATCH v15 7/7] xfs: disable map_sync for async flush

2019-07-05 Thread Pankaj Gupta
Dont support 'MAP_SYNC' with non-DAX files and DAX files with asynchronous dax_device. Virtio pmem provides asynchronous host page cache flush mechanism. We don't support 'MAP_SYNC' with virtio pmem and xfs. Signed-off-by: Pankaj Gupta Reviewed-by: Darrick J. Wong --- fs/xfs/xfs_file.c | 9

Re: [Qemu-devel] [PATCH-for-4.1 v2] hw/ssi/xilinx_spips: Avoid AXI writes to the LQSPI linear memory

2019-07-05 Thread Francisco Iglesias
Hi Philippe, On [2019 Jul 05] Fri 12:42:55, Philippe Mathieu-Daudé wrote: > Lei Sun found while auditing the code than a CPU write would > trigger a NULL pointer deference. > > From UG1085 datasheet [*] AXI writes in this region are ignored > and generates an External Slave Error (SLVERR). > >

Re: [Qemu-devel] [PATCH v2 01/18] qapi/block-core: Introduce BackupCommon

2019-07-05 Thread Markus Armbruster
John Snow writes: > drive-backup and blockdev-backup have an awful lot of things in common > that are the same. Let's fix that. > > I don't deduplicate 'target', because the semantics actually did change > between each structure. Leave that one alone so it can be documented > separately. > >

Re: [Qemu-devel] [PATCH] target/arm/vfp_helper: Call set_fpscr_to_host before updating to FPSCR

2019-07-05 Thread Laurent Desnogues
On Fri, Jul 5, 2019 at 2:43 PM Philippe Mathieu-Daudé wrote: > > In commit e9d652824b0 we extracted the vfp_set_fpscr_to_host() > function but failed at calling it in the correct place, we call > it after xregs[ARM_VFP_FPSCR] is modified. > > Fix by calling this function before we update FPSCR. >

[Qemu-devel] [PATCH v15 5/7] dax: check synchronous mapping is supported

2019-07-05 Thread Pankaj Gupta
This patch introduces 'daxdev_mapping_supported' helper which checks if 'MAP_SYNC' is supported with filesystem mapping. It also checks if corresponding dax_device is synchronous. Virtio pmem device is asynchronous and does not not support VM_SYNC. Suggested-by: Jan Kara Signed-off-by: Pankaj

[Qemu-devel] [PATCH v15 6/7] ext4: disable map_sync for async flush

2019-07-05 Thread Pankaj Gupta
Dont support 'MAP_SYNC' with non-DAX files and DAX files with asynchronous dax_device. Virtio pmem provides asynchronous host page cache flush mechanism. We don't support 'MAP_SYNC' with virtio pmem and ext4. Signed-off-by: Pankaj Gupta Reviewed-by: Jan Kara --- fs/ext4/file.c | 10 ++

[Qemu-devel] [PATCH v15 4/7] dm: enable synchronous dax

2019-07-05 Thread Pankaj Gupta
This patch sets dax device 'DAXDEV_SYNC' flag if all the target devices of device mapper support synchrononous DAX. If device mapper consists of both synchronous and asynchronous dax devices, we don't set 'DAXDEV_SYNC' flag. 'dm_table_supports_dax' is refactored to pass 'iterate_devices_fn' as

[Qemu-devel] [PATCH v15 3/7] libnvdimm: add dax_dev sync flag

2019-07-05 Thread Pankaj Gupta
This patch adds 'DAXDEV_SYNC' flag which is set for nd_region doing synchronous flush. This later is used to disable MAP_SYNC functionality for ext4 & xfs filesystem for devices don't support synchronous flush. Signed-off-by: Pankaj Gupta --- drivers/dax/bus.c| 2 +-

[Qemu-devel] [PATCH v15 2/7] virtio-pmem: Add virtio pmem driver

2019-07-05 Thread Pankaj Gupta
This patch adds virtio-pmem driver for KVM guest. Guest reads the persistent memory range information from Qemu over VIRTIO and registers it on nvdimm_bus. It also creates a nd_region object with the persistent memory range information so that existing 'nvdimm/pmem' driver can reserve this into

[Qemu-devel] [PATCH v15 0/7] virtio pmem driver

2019-07-05 Thread Pankaj Gupta
Hi Dan, This series has only change in patch 2 for linux-next build failure. There is no functional change. Keeping all the existing review/acks and reposting the patch series for merging via libnvdimm tree. --- This patch series has implementation for "virtio pmem". "virtio pmem" is

[Qemu-devel] [PATCH v15 1/7] libnvdimm: nd_region flush callback support

2019-07-05 Thread Pankaj Gupta
This patch adds functionality to perform flush from guest to host over VIRTIO. We are registering a callback based on 'nd_region' type. virtio_pmem driver requires this special flush function. For rest of the region types we are registering existing flush function. Report error returned by host

Re: [Qemu-devel] [PATCH] RISC-V: Select FPU gdb xml file based on the supported extensions

2019-07-05 Thread Georg Kotheimer
> While this appears reasonable, I wonder if RVF w/o RVD actually works? > > Examining the two get/set functions, they always transfer 64 bits for the fpu > registers. Wouldn't that implicate that FPU debugging has never been working properly on RV32, as prior to my changes the FPU registers on

Re: [Qemu-devel] [PATCH] ati-vga: Add registers for getting apertures

2019-07-05 Thread Gerd Hoffmann
On Fri, Jul 05, 2019 at 12:02:26PM +0200, BALATON Zoltan wrote: > Some drivers (e.g. Linux radeon drm and MacOS) access these to find > apertures to access card. Try to implement these but not sure these > are correct yet. > +case CONFIG_APER_SIZE: > +val = s->vga.vram_size; > +

Re: [Qemu-devel] [PATCH v3 5/6] monitor: adding info tb and tbs to monitor

2019-07-05 Thread Markus Armbruster
vandersonmr writes: > adding options to list tbs by some metric and > investigate their code. What's "tbs"? Why is listing them useful? What do you mean by "some metric"? What do you mean by "and investigate their code?" > Signed-off-by: Vanderson M. do Rosario > --- >

Re: [Qemu-devel] [PULL v2 04/36] virtio: Introduce started flag to VirtioDevice

2019-07-05 Thread Greg Kurz
On Mon, 24 Jun 2019 19:54:27 +0200 Laurent Vivier wrote: > On 01/06/2019 17:49, Greg Kurz wrote: > > On Fri, 31 May 2019 16:36:33 -0300 > > Eduardo Habkost wrote: > > > >> On Tue, May 28, 2019 at 10:48:09AM +0800, Yongji Xie wrote: > >>> On Tue, 28 May 2019 at 02:54, Michael S. Tsirkin wrote:

Re: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support

2019-07-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190705083141.106254-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support Message-id:

[Qemu-devel] [PULL 3/4] ati-vga: Fix reverse bit blts

2019-07-05 Thread Gerd Hoffmann
From: BALATON Zoltan The pixman library only supports blts with left to right, top to bottom order but the ATI VGA engine can also do different directions. Fix support for these via a temporary buffer for now. This fixes rendering issues related to such blts (such as moving windows) but some

Re: [Qemu-devel] [PATCH v4] block/nvme: add support for discard

2019-07-05 Thread Max Reitz
On 03.07.19 18:07, Maxim Levitsky wrote: > Signed-off-by: Maxim Levitsky > --- > block/nvme.c | 81 ++ > block/trace-events | 2 ++ > 2 files changed, 83 insertions(+) > > diff --git a/block/nvme.c b/block/nvme.c > index 02e0846643..96a715dcc1

Re: [Qemu-devel] [Qemu-block] [PATCH 16/16] nvme: support multiple namespaces

2019-07-05 Thread Daniel P . Berrangé
On Fri, Jul 05, 2019 at 03:36:17PM +0200, Klaus Birkelund wrote: > On Fri, Jul 05, 2019 at 09:23:33AM +0200, Klaus Birkelund Jensen wrote: > > This adds support for multiple namespaces by introducing a new 'nvme-ns' > > device model. The nvme device creates a bus named from the device name > >

[Qemu-devel] [PULL 1/4] ati-vga: Improve readability of ati_2d_blt function

2019-07-05 Thread Gerd Hoffmann
From: BALATON Zoltan Move common parts before the switch to remove code duplication and improve readibility. Signed-off-by: BALATON Zoltan Message-id: 04b67ff483223d4722b0b044192558e7d17b36b5.1562151410.git.bala...@eik.bme.hu Signed-off-by: Gerd Hoffmann --- hw/display/ati_2d.c | 80

[Qemu-devel] [PULL 2/4] ati-vga: Fix frame buffer endianness for big endian target

2019-07-05 Thread Gerd Hoffmann
From: BALATON Zoltan The extended mode frame buffer should be little endian even when emulating big endian machine (such as PPC). This fixes color problems with MorphOS. Signed-off-by: BALATON Zoltan Message-id: 439aa85061f103446df7b42632d730971a372432.1562151410.git.bala...@eik.bme.hu

[Qemu-devel] [PULL 4/4] ati-vga: Fix setting offset together with pitch for r128pro

2019-07-05 Thread Gerd Hoffmann
From: BALATON Zoltan Turns out my last fix to this broke one case for Rage 128 Pro so revert that part of previous patch. This now fixes the remaining rendering problems for MorphOS which now can produce picture with -device ati-vga (although it may not be optimised yet and video overlay

[Qemu-devel] [PULL 0/4] Vga 20190705 patches

2019-07-05 Thread Gerd Hoffmann
The following changes since commit 57dfc2c4d51e770ed3f617e5d1456d1e2bacf3f0: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20190704-1' into staging (2019-07-04 17:32:24 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/vga-20190705-pull

Re: [Qemu-devel] [PATCH for-4.2] xics/kvm: Convert assert() to error_setg()

2019-07-05 Thread Greg Kurz
On Fri, 5 Jul 2019 14:56:23 +1000 David Gibson wrote: > On Thu, Jul 04, 2019 at 10:12:04AM +0200, Greg Kurz wrote: > > On Thu, 4 Jul 2019 10:23:57 +1000 > > David Gibson wrote: > > > > > On Wed, Jul 03, 2019 at 07:50:12PM +0200, Greg Kurz wrote: > > > > ics_set_kvm_state_one() is called either

Re: [Qemu-devel] [PATCH] target/arm/vfp_helper: Call set_fpscr_to_host before updating to FPSCR

2019-07-05 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Correct subject: "Call set_fpscr_to_host before updating FPSCR reg" > (or without "reg"). Queued to testing/next, thanks. > > On 7/5/19 2:43 PM, Philippe Mathieu-Daudé wrote: >> In commit e9d652824b0 we extracted the vfp_set_fpscr_to_host() >> function but

Re: [Qemu-devel] [Qemu-block] [PATCH 16/16] nvme: support multiple namespaces

2019-07-05 Thread Klaus Birkelund
On Fri, Jul 05, 2019 at 09:23:33AM +0200, Klaus Birkelund Jensen wrote: > This adds support for multiple namespaces by introducing a new 'nvme-ns' > device model. The nvme device creates a bus named from the device name > ('id'). The nvme-ns devices then connect to this and registers > themselves

Re: [Qemu-devel] [PATCH v3 5/6] block/nvme: add support for write zeros

2019-07-05 Thread Max Reitz
On 03.07.19 17:59, Maxim Levitsky wrote: > Signed-off-by: Maxim Levitsky > --- > block/nvme.c | 69 +++- > block/trace-events | 1 + > include/block/nvme.h | 19 +++- > 3 files changed, 87 insertions(+), 2 deletions(-) > > diff --git

[Qemu-devel] [PATCH for 4.1] gdbstub: revert to previous set_reg behaviour

2019-07-05 Thread Alex Bennée
The refactoring of handle_set_reg missed the fact we previously had responded with an empty packet when we were not using XML based protocols. This broke the fallback behaviour for architectures that don't have registers defined in QEMU's gdb-xml directory. Revert to the previous behaviour and

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10 2/6] ppc: spapr: Introduce FWNMI capability

2019-07-05 Thread Greg Kurz
On Fri, 5 Jul 2019 16:49:17 +0530 Aravinda Prasad wrote: > > > On Friday 05 July 2019 06:37 AM, David Gibson wrote: > > On Thu, Jul 04, 2019 at 10:33:11AM +0530, Aravinda Prasad wrote: > >> > >> > >> On Thursday 04 July 2019 06:37 AM, David Gibson wrote: > >>> On Wed, Jul 03, 2019 at

Re: [Qemu-devel] [RFC PATCH-for-4.2] tracing: Allow to tune tracing options via the environment

2019-07-05 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 7/5/19 10:07 AM, Stefan Hajnoczi wrote: >> On Thu, Jul 04, 2019 at 11:28:37AM +0100, Daniel P. Berrangé wrote: >>> On Thu, Jul 04, 2019 at 11:24:57AM +0100, Stefan Hajnoczi wrote: On Wed, Jul 03, 2019 at 06:25:01PM +0100, Daniel P. Berrangé wrote: >

[Qemu-devel] [Bug 1462640] Re: shmat fails on 32-to-64 setup

2019-07-05 Thread Ari Sundholm
I can confirm that this bug still exists in the current qemu master (short commit ID 0050f9978e): ~/qemu$ gcc -m32 shm_bug.c -o shm_bug32 shm_bug.c: In function ‘main’: shm_bug.c:12:24: warning: initialization makes pointer from integer without a cast [-Wint-conversion] const void *at =

Re: [Qemu-devel] Unable to set register on qemu-system-sparc64 via gdbstub

2019-07-05 Thread Alex Bennée
Mark Cave-Ayland writes: > Hi all, > > It looks as if the recent gdbstub code rework has broken the ability to set > registers > under qemu-system-sparc64: > > $ sparc64-linux-gdb obj-sparc64/openbios-builtin.elf.nostrip > GNU gdb (GDB) 8.1 > Copyright (C) 2018 Free Software Foundation, Inc.

Re: [Qemu-devel] [PATCH] target/arm/vfp_helper: Call set_fpscr_to_host before updating to FPSCR

2019-07-05 Thread Philippe Mathieu-Daudé
Correct subject: "Call set_fpscr_to_host before updating FPSCR reg" (or without "reg"). On 7/5/19 2:43 PM, Philippe Mathieu-Daudé wrote: > In commit e9d652824b0 we extracted the vfp_set_fpscr_to_host() > function but failed at calling it in the correct place, we call > it after

[Qemu-devel] [PATCH] target/arm/vfp_helper: Call set_fpscr_to_host before updating to FPSCR

2019-07-05 Thread Philippe Mathieu-Daudé
In commit e9d652824b0 we extracted the vfp_set_fpscr_to_host() function but failed at calling it in the correct place, we call it after xregs[ARM_VFP_FPSCR] is modified. Fix by calling this function before we update FPSCR. Reported-by: Laurent Desnogues Signed-off-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10 6/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-07-05 Thread Greg Kurz
On Fri, 5 Jul 2019 16:41:25 +0530 Aravinda Prasad wrote: > > > On Friday 05 July 2019 12:07 AM, Greg Kurz wrote: > > On Thu, 4 Jul 2019 10:49:05 +0530 > > Aravinda Prasad wrote: > > > >> > >> > >> On Thursday 04 July 2019 06:42 AM, David Gibson wrote: > >>> On Wed, Jul 03, 2019 at 02:30:31PM

Re: [Qemu-devel] [PULL v3 00/19] testing/next for 4.1 (tests/vm, Travis and hyperv build fix)

2019-07-05 Thread Peter Maydell
On Fri, 5 Jul 2019 at 11:18, Alex Bennée wrote: > > The following changes since commit 57dfc2c4d51e770ed3f617e5d1456d1e2bacf3f0: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20190704-1' into staging (2019-07-04 > 17:32:24 +0100) > > are available in the Git

Re: [Qemu-devel] [PULL 0/4] Build system patches for 2019-07-02

2019-07-05 Thread Philippe Mathieu-Daudé
Hi Markus, On 7/2/19 1:34 PM, Markus Armbruster wrote: > The following changes since commit ab200dafc0e8a9925bb0ad0be478621f5f117c95: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2019-07-02 10:17:54 +0100) > > are available in the Git repository

Re: [Qemu-devel] [PATCH v3 3/3] net: tap: refactor net_bridge_run_helper routine

2019-07-05 Thread P J P
+-- On Tue, 2 Jul 2019, P J P wrote --+ | |-netdev bridge,helper="/path/to/helper myarg otherarg" | | | | In theory any parts could contain shell meta characters, but even if | | they don't we'll have slightly broken compat with this change. | | I wonder if anybody uses it like that. Because

Re: [Qemu-devel] [PATCH v3 4/6] block/nvme: add support for image creation

2019-07-05 Thread Max Reitz
On 03.07.19 17:59, Maxim Levitsky wrote: > Tesed on a nvme device like that: > > # create preallocated qcow2 image > $ qemu-img create -f qcow2 nvme://:06:00.0/1 10G -o preallocation=metadata > Formatting 'nvme://:06:00.0/1', fmt=qcow2 size=10737418240 > cluster_size=65536

Re: [Qemu-devel] [PATCH v3 3/6] block/nvme: support larger that 512 bytes sector devices

2019-07-05 Thread Max Reitz
On 03.07.19 17:59, Maxim Levitsky wrote: > Currently the driver hardcodes the sector size to 512, > and doesn't check the underlying device. Fix that. > > Also fail if underlying nvme device is formatted with metadata > as this needs special support. > > Signed-off-by: Maxim Levitsky > --- >

[Qemu-devel] Unable to set register on qemu-system-sparc64 via gdbstub

2019-07-05 Thread Mark Cave-Ayland
Hi all, It looks as if the recent gdbstub code rework has broken the ability to set registers under qemu-system-sparc64: $ sparc64-linux-gdb obj-sparc64/openbios-builtin.elf.nostrip GNU gdb (GDB) 8.1 Copyright (C) 2018 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later

Re: [Qemu-devel] [PATCH-for-4.1 v2] hw/ssi/xilinx_spips: Avoid AXI writes to the LQSPI linear memory

2019-07-05 Thread P J P
+-- On Fri, 5 Jul 2019, Philippe Mathieu-Daudé wrote --+ | +static bool lqspi_accepts(void *opaque, hwaddr addr, | + unsigned size, bool is_write, | + MemTxAttrs attrs) | +{ | +/* | + * From UG1085, Chapter 24 (Quad-SPI controllers): | +

Re: [Qemu-devel] [PATCH v10 2/6] ppc: spapr: Introduce FWNMI capability

2019-07-05 Thread Aravinda Prasad
On Friday 05 July 2019 06:37 AM, David Gibson wrote: > On Thu, Jul 04, 2019 at 10:33:11AM +0530, Aravinda Prasad wrote: >> >> >> On Thursday 04 July 2019 06:37 AM, David Gibson wrote: >>> On Wed, Jul 03, 2019 at 02:58:24PM +0530, Aravinda Prasad wrote: On Wednesday 03 July 2019

Re: [Qemu-devel] [PATCH] hw/net: fix vmxnet3 live migration

2019-07-05 Thread Marcel Apfelbaum
On 7/5/19 2:14 PM, Sukrit Bhatnagar wrote: On Fri, 5 Jul 2019 at 16:29, Dmitry Fleytman wrote: On 5 Jul 2019, at 4:07, Marcel Apfelbaum wrote: At some point vmxnet3 live migration stopped working and git-bisect didn't help finding a working version. The issue is the PCI configuration

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10 6/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-07-05 Thread Aravinda Prasad
On Friday 05 July 2019 12:07 AM, Greg Kurz wrote: > On Thu, 4 Jul 2019 10:49:05 +0530 > Aravinda Prasad wrote: > >> >> >> On Thursday 04 July 2019 06:42 AM, David Gibson wrote: >>> On Wed, Jul 03, 2019 at 02:30:31PM +0530, Aravinda Prasad wrote: On Wednesday 03 July 2019 08:50

Re: [Qemu-devel] [PATCH] hw/net: fix vmxnet3 live migration

2019-07-05 Thread Sukrit Bhatnagar
On Fri, 5 Jul 2019 at 16:29, Dmitry Fleytman wrote: > > > > On 5 Jul 2019, at 4:07, Marcel Apfelbaum wrote: > > > > At some point vmxnet3 live migration stopped working and git-bisect > > didn't help finding a working version. > > The issue is the PCI configuration space is not being migrated >

Re: [Qemu-devel] [PATCH v3 2/6] block/nvme: fix doorbell stride

2019-07-05 Thread Max Reitz
On 05.07.19 13:09, Max Reitz wrote: > On 03.07.19 17:59, Maxim Levitsky wrote: >> Fix the math involving non standard doorbell stride >> >> Signed-off-by: Maxim Levitsky >> --- >> block/nvme.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/block/nvme.c b/block/nvme.c

Re: [Qemu-devel] [PATCH v3 2/6] block/nvme: fix doorbell stride

2019-07-05 Thread Max Reitz
On 03.07.19 17:59, Maxim Levitsky wrote: > Fix the math involving non standard doorbell stride > > Signed-off-by: Maxim Levitsky > --- > block/nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/nvme.c b/block/nvme.c > index 6d4e7f3d83..52798081b2 100644 > ---

Re: [Qemu-devel] [PATCH v4 09/11] tests/vm: netbsd autoinstall, using serial console

2019-07-05 Thread Alex Bennée
Peter Maydell writes: > On Fri, 5 Jul 2019 at 11:43, Kamil Rytarowski wrote: >> >> On 05.07.2019 12:24, Alex Bennée wrote: >> > >> > Gerd Hoffmann writes: >> > >> >> Instead of fetching the prebuilt image from patchew download the install >> >> iso and prepare the image locally. Install to

Re: [Qemu-devel] [PATCH v4 09/11] tests/vm: netbsd autoinstall, using serial console

2019-07-05 Thread Daniel P . Berrangé
On Fri, Jul 05, 2019 at 11:52:20AM +0100, Peter Maydell wrote: > On Fri, 5 Jul 2019 at 11:43, Kamil Rytarowski wrote: > > > > On 05.07.2019 12:24, Alex Bennée wrote: > > > > > > Gerd Hoffmann writes: > > > > > >> Instead of fetching the prebuilt image from patchew download the install > > >> iso

Re: [Qemu-devel] [PATCH v3 1/6] block/nvme: don't touch the completion entries

2019-07-05 Thread Max Reitz
On 03.07.19 17:59, Maxim Levitsky wrote: > Completion entries are meant to be only read by the host and written by the > device. > The driver is supposed to scan the completions from the last point where it > left, > and until it sees a completion with non flipped phase bit. (Disclaimer: This

Re: [Qemu-devel] [PATCH] hw/net: fix vmxnet3 live migration

2019-07-05 Thread Dmitry Fleytman
> On 5 Jul 2019, at 4:07, Marcel Apfelbaum wrote: > > At some point vmxnet3 live migration stopped working and git-bisect > didn't help finding a working version. > The issue is the PCI configuration space is not being migrated > successfully and MSIX remains masked at destination. > > Remove

Re: [Qemu-devel] [PATCH] hw/net: fix vmxnet3 live migration

2019-07-05 Thread Sukrit Bhatnagar
On Fri, 5 Jul 2019 at 06:38, Marcel Apfelbaum wrote: > > At some point vmxnet3 live migration stopped working and git-bisect > didn't help finding a working version. > The issue is the PCI configuration space is not being migrated > successfully and MSIX remains masked at destination. > > Remove

Re: [Qemu-devel] [PATCH v4 09/11] tests/vm: netbsd autoinstall, using serial console

2019-07-05 Thread Kamil Rytarowski
On 05.07.2019 12:47, Philippe Mathieu-Daudé wrote: > On 7/5/19 12:43 PM, Kamil Rytarowski wrote: >> On 05.07.2019 12:24, Alex Bennée wrote: >>> >>> Gerd Hoffmann writes: >>> Instead of fetching the prebuilt image from patchew download the install iso and prepare the image locally.

Re: [Qemu-devel] [PATCH v4 09/11] tests/vm: netbsd autoinstall, using serial console

2019-07-05 Thread Peter Maydell
On Fri, 5 Jul 2019 at 11:43, Kamil Rytarowski wrote: > > On 05.07.2019 12:24, Alex Bennée wrote: > > > > Gerd Hoffmann writes: > > > >> Instead of fetching the prebuilt image from patchew download the install > >> iso and prepare the image locally. Install to disk, using the serial > >>

Re: [Qemu-devel] [PATCH v4 09/11] tests/vm: netbsd autoinstall, using serial console

2019-07-05 Thread Kamil Rytarowski
On 05.07.2019 12:24, Alex Bennée wrote: > > Gerd Hoffmann writes: > >> Instead of fetching the prebuilt image from patchew download the install >> iso and prepare the image locally. Install to disk, using the serial >> console. Create qemu user, configure ssh login. Install packages >>

Re: [Qemu-devel] [PATCH v4 09/11] tests/vm: netbsd autoinstall, using serial console

2019-07-05 Thread Philippe Mathieu-Daudé
On 7/5/19 12:43 PM, Kamil Rytarowski wrote: > On 05.07.2019 12:24, Alex Bennée wrote: >> >> Gerd Hoffmann writes: >> >>> Instead of fetching the prebuilt image from patchew download the install >>> iso and prepare the image locally. Install to disk, using the serial >>> console. Create qemu

Re: [Qemu-devel] pl031 time across vm save/reload

2019-07-05 Thread Peter Maydell
On Fri, 5 Jul 2019 at 11:32, Paolo Bonzini wrote: > > On 05/07/19 12:21, Peter Maydell wrote: > > On Fri, 5 Jul 2019 at 11:13, Paolo Bonzini wrote: > >> Yes, something like that but I would just bump the version. Version 1 > >> has the old meaning for the first field, version 2 has the new

Re: [Qemu-devel] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback

2019-07-05 Thread Stefano Garzarella
On Fri, Jul 05, 2019 at 11:58:43AM +0200, Max Reitz wrote: > On 05.07.19 11:32, Stefano Garzarella wrote: > > This patch allows 'qemu-img info' to show the 'disk size' for > > the RBD images that have the fast-diff feature enabled. > > > > If this feature is enabled, we use the

[Qemu-devel] [PATCH-for-4.1 v2] hw/ssi/xilinx_spips: Avoid AXI writes to the LQSPI linear memory

2019-07-05 Thread Philippe Mathieu-Daudé
Lei Sun found while auditing the code than a CPU write would trigger a NULL pointer deference. >From UG1085 datasheet [*] AXI writes in this region are ignored and generates an External Slave Error (SLVERR). Fix by checking the access is a READ before calling the region callback. [*]

Re: [Qemu-devel] [PATCH v2 RFC] qemu-nbd: Permit TLS with Unix sockets

2019-07-05 Thread Daniel P . Berrangé
On Wed, Jul 03, 2019 at 05:47:07PM -0500, Eric Blake wrote: > +== check TLS works over Unix == > +image: nbd+unix://?socket=SOCKET > +file format: nbd > +virtual size: 64 MiB (67108864 bytes) > +disk size: unavailable > +image: nbd+unix://?socket=SOCKET > +file format: nbd > +virtual size: 64 MiB

Re: [Qemu-devel] [PATCH v2 RFC] qemu-nbd: Permit TLS with Unix sockets

2019-07-05 Thread Daniel P . Berrangé
On Fri, Jul 05, 2019 at 11:31:51AM +0200, Max Reitz wrote: > On 04.07.19 00:47, Eric Blake wrote: > > diff --git a/tests/qemu-iotests/233.out b/tests/qemu-iotests/233.out > > index 9b46284ab0de..b86bee020649 100644 > > --- a/tests/qemu-iotests/233.out > > +++ b/tests/qemu-iotests/233.out > >

Re: [Qemu-devel] pl031 time across vm save/reload

2019-07-05 Thread Paolo Bonzini
On 05/07/19 12:21, Peter Maydell wrote: > On Fri, 5 Jul 2019 at 11:13, Paolo Bonzini wrote: >> >> On 05/07/19 11:58, Peter Maydell wrote: >>> On Fri, 5 Jul 2019 at 10:48, Paolo Bonzini wrote: You're right, the compatibility causes wrong behavior for the default -rtc settings (the RC

Re: [Qemu-devel] [PATCH v1 1/1] hw/scsi: Report errors and sense to guests through scsi-block

2019-07-05 Thread Shinichiro Kawasaki
On 7/2/19 7:23 PM, Paolo Bonzini wrote: > On 02/07/19 08:44, Shinichiro Kawasaki wrote: >> On 7/1/19 8:56 PM, Paolo Bonzini wrote: >>> On 01/07/19 12:14, Shinichiro Kawasaki wrote: I observe four of them listed below in sense data, when I ran basic operations to the zoned storage from

Re: [Qemu-devel] [PATCH v2 RFC] qemu-nbd: Permit TLS with Unix sockets

2019-07-05 Thread Daniel P . Berrangé
On Wed, Jul 03, 2019 at 05:47:07PM -0500, Eric Blake wrote: > Although you generally won't use encryption with a Unix socket (after > all, everything is local, so why waste the CPU power), there are > situations in testsuites where Unix sockets are much nicer than TCP > sockets. Since nbdkit

Re: [Qemu-devel] pl031 time across vm save/reload

2019-07-05 Thread Peter Maydell
On Fri, 5 Jul 2019 at 10:48, Paolo Bonzini wrote: > By the way, the data sheet says "the counter and match values are > compared in a comparator. When both values are equal, the RTCINTR > interrupt is asserted HIGH"; QEMU compares the RTC value (read from > RTC_DR) and not the counter value, but

Re: [Qemu-devel] [PATCH v4 09/11] tests/vm: netbsd autoinstall, using serial console

2019-07-05 Thread Alex Bennée
Gerd Hoffmann writes: > Instead of fetching the prebuilt image from patchew download the install > iso and prepare the image locally. Install to disk, using the serial > console. Create qemu user, configure ssh login. Install packages > needed for qemu builds. I've had to drop this from my

Re: [Qemu-devel] pl031 time across vm save/reload

2019-07-05 Thread Peter Maydell
On Fri, 5 Jul 2019 at 11:13, Paolo Bonzini wrote: > > On 05/07/19 11:58, Peter Maydell wrote: > > On Fri, 5 Jul 2019 at 10:48, Paolo Bonzini wrote: > >> You're right, the compatibility causes wrong behavior for the default > >> -rtc settings (the RC pauses across migration). The right thing to

Re: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support

2019-07-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190705083141.106254-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support Message-id:

[Qemu-devel] [PATCH v7] qemu-io: add pattern file for write command

2019-07-05 Thread Denis Plotnikov
The patch allows to provide a pattern file for write command. There was no similar ability before. Signed-off-by: Denis Plotnikov --- v7: * fix variable naming * make code more readable * extend help for write command v6: * the pattern file is read once to reduce io v5: * file name

Re: [Qemu-devel] No symbols in LeakSanitizer output (was Re: [RFC PATCH 0/7] target/i386: support VMX features in "-cpu")

2019-07-05 Thread Paolo Bonzini
On 02/07/19 23:38, Eduardo Habkost wrote: > Can the asan build test in Patchew be updated to include > symbolize=1? > > For reference, below is the full stack trace of the leak. It > looks like it existed for a long time. Sure, just add the "export" lines to tests/docker/test-debug and Patchew

[Qemu-devel] [PULL v3 00/19] testing/next for 4.1 (tests/vm, Travis and hyperv build fix)

2019-07-05 Thread Alex Bennée
The following changes since commit 57dfc2c4d51e770ed3f617e5d1456d1e2bacf3f0: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20190704-1' into staging (2019-07-04 17:32:24 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git

Re: [Qemu-devel] pl031 time across vm save/reload

2019-07-05 Thread Paolo Bonzini
On 05/07/19 11:58, Peter Maydell wrote: > On Fri, 5 Jul 2019 at 10:48, Paolo Bonzini wrote: >> You're right, the compatibility causes wrong behavior for the default >> -rtc settings (the RC pauses across migration). The right thing to do >> would be to store the base rather than the offset: that

[Qemu-devel] [PATCH] ati-vga: Add registers for getting apertures

2019-07-05 Thread BALATON Zoltan
Some drivers (e.g. Linux radeon drm and MacOS) access these to find apertures to access card. Try to implement these but not sure these are correct yet. Signed-off-by: BALATON Zoltan --- hw/display/ati.c | 15 +++ hw/display/ati_dbg.c | 5 + hw/display/ati_regs.h | 5

Re: [Qemu-devel] pl031 time across vm save/reload

2019-07-05 Thread Peter Maydell
On Fri, 5 Jul 2019 at 10:48, Paolo Bonzini wrote: > You're right, the compatibility causes wrong behavior for the default > -rtc settings (the RC pauses across migration). The right thing to do > would be to store the base rather than the offset: that is, you store > the time at which LR was

Re: [Qemu-devel] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback

2019-07-05 Thread Max Reitz
On 05.07.19 11:32, Stefano Garzarella wrote: > This patch allows 'qemu-img info' to show the 'disk size' for > the RBD images that have the fast-diff feature enabled. > > If this feature is enabled, we use the rbd_diff_iterate2() API > to calculate the allocated size for the image. > >

Re: [Qemu-devel] pl031 time across vm save/reload

2019-07-05 Thread Paolo Bonzini
On 04/07/19 18:02, Peter Maydell wrote: > I've had a report that the way the PL031 model handles time > across a vm save/reload fails to correctly advance the guest > RTC when the host RTC has advanced between the save and reload. > I looked at the code and my correspondent's analysis (which > I

Re: [Qemu-devel] [RFC PATCH-for-4.2] tracing: Allow to tune tracing options via the environment

2019-07-05 Thread Philippe Mathieu-Daudé
On 7/5/19 10:07 AM, Stefan Hajnoczi wrote: > On Thu, Jul 04, 2019 at 11:28:37AM +0100, Daniel P. Berrangé wrote: >> On Thu, Jul 04, 2019 at 11:24:57AM +0100, Stefan Hajnoczi wrote: >>> On Wed, Jul 03, 2019 at 06:25:01PM +0100, Daniel P. Berrangé wrote: On Wed, Jul 03, 2019 at 07:10:05PM

[Qemu-devel] [PATCH v2 for-4.1] target/arm: NS BusFault on vector table fetch escalates to NS HardFault

2019-07-05 Thread Peter Maydell
In the M-profile architecture, when we do a vector table fetch and it fails, we need to report a HardFault. Whether this is a Secure HF or a NonSecure HF depends on several things. If AIRCR.BFHFNMINS is 0 then HF is always Secure, because there is no NonSecure HardFault. Otherwise, the answer

Re: [Qemu-devel] [PULL 00/22] virtio, pc, pci: features, fixes, cleanups

2019-07-05 Thread Peter Maydell
On Thu, 4 Jul 2019 at 22:29, Michael S. Tsirkin wrote: > > On Thu, Jul 04, 2019 at 10:25:48AM +0100, Peter Maydell wrote: > > On Tue, 2 Jul 2019 at 16:06, Michael S. Tsirkin wrote: > > > > > > The following changes since commit > > > 7fec76a02267598a4e437ddfdaeaeb6de09b92f3: > > > > > > Merge

Re: [Qemu-devel] [PULL 00/22] virtio, pc, pci: features, fixes, cleanups

2019-07-05 Thread Pankaj Gupta
> > > > The following changes since commit > > > > 7fec76a02267598a4e437ddfdaeaeb6de09b92f3: > > > > > > > > Merge remote-tracking branch > > > > 'remotes/maxreitz/tags/pull-block-2019-06-24' into staging > > > > (2019-07-01 > > > > 11:28:28 +0100) > > > > > > > > are available in the

[Qemu-devel] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback

2019-07-05 Thread Stefano Garzarella
This patch allows 'qemu-img info' to show the 'disk size' for the RBD images that have the fast-diff feature enabled. If this feature is enabled, we use the rbd_diff_iterate2() API to calculate the allocated size for the image. Signed-off-by: Stefano Garzarella --- v3: - return -ENOTSUP

Re: [Qemu-devel] [PATCH v2 RFC] qemu-nbd: Permit TLS with Unix sockets

2019-07-05 Thread Max Reitz
On 04.07.19 00:47, Eric Blake wrote: > Although you generally won't use encryption with a Unix socket (after > all, everything is local, so why waste the CPU power), there are > situations in testsuites where Unix sockets are much nicer than TCP > sockets. Since nbdkit allows encryption over both

[Qemu-devel] [Bug 1835466] Re: qemu 4.0.0 abort()s in audio_get_pdo_in (poisoned drv->driver?)

2019-07-05 Thread Gerd Hoffmann
Can you set a watchpoint for (*dev)->driver and see where it fires? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1835466 Title: qemu 4.0.0 abort()s in audio_get_pdo_in (poisoned drv->driver?)

Re: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support

2019-07-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190705083141.106254-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support Message-id:

Re: [Qemu-devel] [PATCH 00/16] nvme: support NVMe v1.3d, SGLs and multiple namespaces

2019-07-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190705072333.17171-1-kl...@birkelund.eu/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make

Re: [Qemu-devel] [PULL 41/46] target/arm/vfp_helper: Extract vfp_set_fpscr_to_host()

2019-07-05 Thread Philippe Mathieu-Daudé
On 7/5/19 9:24 AM, Laurent Desnogues wrote: > Hello, > > On Tue, Jul 2, 2019 at 4:18 AM Peter Maydell wrote: >> >> From: Philippe Mathieu-Daudé >> >> The vfp_set_fpscr() helper contains code specific to the host >> floating point implementation (here the SoftFloat library). >> Extract this code

Re: [Qemu-devel] [PATCH 00/16] nvme: support NVMe v1.3d, SGLs and multiple namespaces

2019-07-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190705072333.17171-1-kl...@birkelund.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH 00/16] nvme: support NVMe v1.3d, SGLs and multiple namespaces

[Qemu-devel] [PATCH v22 15/22] hw/timer: RX62N internal timer modules

2019-07-05 Thread Yoshinori Sato
renesas_tmr: 8bit timer modules. renesas_cmt: 16bit compare match timer modules. This part use many renesas's CPU. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Alex Bennée Reviewed-by:

<    1   2   3   4   >