Re: [Qemu-devel] [GIT PULL for qemu-pseries] spapr: Render full FDT on ibm, client-architecture-support

gt; > The following changes since commit > > > > d6bb8b27204eaa58f1da948b65454e3a598ab2a4: > > > > > > > >pseries: Update SLOF firmware image (2019-08-27 16:47:04 +1000) > > > > > > > > are available in the Git repository at: &

Re: [Qemu-devel] libvhost-user: undefined reference to MADV_NOHUGEPAGE

On 8/27/19 9:01 PM, Richard Henderson wrote: On 8/27/19 6:42 PM, Sandra Loosemore wrote: Sorry if that was not clear.  The target is aarch64-none-elf with the provided semihosting facilities in QEMU.  The host is x86_64-linux-gnu. We deliberately link against a pretty old glibc sysroot (looks

Re: [Qemu-devel] QEMU as ISS (Instruction Set Simulator)

Hi Aleksandar, Thank you for the link to Loongson2F documentation. It has been very useful:) I have spent several days immersing myself in the source code, now I think I have a more solid understanding about it. Just like Loongson Multimedia Instructions, I need to implement some sort of

Re: [Qemu-devel] [RFC 3/3] virt: Check KVM_CAP_ARM_IRQ_LINE_LAYOUT_2 for smp_cpus > 256

On 8/27/19 9:05 AM, Eric Auger wrote: > +++ b/target/arm/kvm_arm.h > @@ -233,6 +233,14 @@ bool kvm_arm_pmu_supported(CPUState *cs); > */ > int kvm_arm_get_max_vm_ipa_size(MachineState *ms); > > +/** > + * kvm_arm_irq_line_layout_2 - Returns whether more than 256 > + * vcpus are supported by

Re: [Qemu-devel] [GIT PULL for qemu-pseries] spapr: Render full FDT on ibm, client-architecture-support

(2019-08-27 16:47:04 +1000) are available in the Git repository at: g...@github.com:aik/qemu.git tags/qemu-slof-20190827 for you to fetch changes up to da9960a5aaa25d27c9798c3d94c7b4c2d8af31ac: spapr: Render full FDT on ibm,client-architecture-support (2019-08-27 16:47:46 +1000

Re: [Qemu-devel] [PATCH V3] gdbstub: Fix handler for 'F' packet

On 8/27/19 3:33 PM, Sandra Loosemore wrote: > Handling of the 'F' packet has been broken since commit > 4b20fab101b9e2d0fb47454209637a17fc7a13d5, which converted it to use > the new packet parsing infrastructure. Per the GDB RSP specification > >

Re: [Qemu-devel] [PATCH] target/arm: Free TCG temps in trans_VMOV_64_sp()

On 8/27/19 5:19 AM, Peter Maydell wrote: > The function neon_store_reg32() doesn't free the TCG temp that it > is passed, so the caller must do that. We got this right in most > places but forgot to free the TCG temps in trans_VMOV_64_sp(). > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Peter

Re: [Qemu-devel] libvhost-user: undefined reference to MADV_NOHUGEPAGE

On 8/27/19 6:42 PM, Sandra Loosemore wrote: > Sorry if that was not clear.  The target is aarch64-none-elf with the provided > semihosting facilities in QEMU.  The host is x86_64-linux-gnu. We deliberately > link against a pretty old glibc sysroot (looks like version 2.11.1), but we > did > that

Re: [Qemu-devel] [GIT PULL for qemu-pseries] spapr: Render full FDT on ibm, client-architecture-support

g...@github.com:aik/qemu.git tags/qemu-slof-20190827 > > for you to fetch changes up to da9960a5aaa25d27c9798c3d94c7b4c2d8af31ac: > > spapr: Render full FDT on ibm,client-architecture-support (2019-08-27 > 16:47:46 +1000) > >

Re: [Qemu-devel] [PATCH qemu v3] spapr_pci: Advertise BAR reallocation capability

On Fri, Jul 19, 2019 at 02:37:34PM +1000, Alexey Kardashevskiy wrote: > The pseries guests do not normally allocate PCI resources and rely on > the system firmware doing so. Furthermore at least at some point in > the past the pseries guests won't even allowed to change BARs, probably > it is

Re: [Qemu-devel] [QEMU-PPC] [PATCH V4] powerpc/spapr: Add host threads parameter to ibm, get_system_parameter

On Tue, Aug 27, 2019 at 02:57:51PM +1000, Suraj Jitindar Singh wrote: > The ibm,get_system_parameter rtas call is used by the guest to retrieve > data relating to certain parameters of the system. The SPLPAR > characteristics option (token 20) is used to determine characteristics of > the

Re: [Qemu-devel] [GIT PULL for qemu-pseries] spapr: Render full FDT on ibm, client-architecture-support

-08-27 16:47:04 +1000) > > > > are available in the Git repository at: > > > > g...@github.com:aik/qemu.git tags/qemu-slof-20190827 > > > > for you to fetch changes up to da9960a5aaa25d27c9798c3d94c7b4c2d8af31ac: > > > > spapr: Render full F

Re: [Qemu-devel] [PATCH v6 3/3] target/ppc: Refactor emulation of vmrgew and vmrgow instructions

On Tue, Aug 27, 2019 at 12:19:27PM -0700, Richard Henderson wrote: > On 8/27/19 2:37 AM, Stefan Brankovic wrote: > > Since I found this two instructions implemented with tcg, I refactored > > them so they are consistent with other similar implementations that > > I introduced in this patch. > > >

Re: [Qemu-devel] libvhost-user: undefined reference to MADV_NOHUGEPAGE

On 8/27/19 6:39 PM, Richard Henderson wrote: On 8/27/19 5:26 PM, Sandra Loosemore wrote: Yesterday I tried to build the recent 4.1 release system-mode QEMU for aarch64-none-elf and ran into a compilation error in ./contrib/libvhost-user/libvhost-user.c. Why are you attempting to compile qemu

Re: [Qemu-devel] [PATCH v4] riscv: hmp: Add a command to show virtual memory mappings

Hi Palmer, On Wed, Aug 28, 2019 at 7:18 AM Palmer Dabbelt wrote: > > On Sun, 18 Aug 2019 22:59:54 PDT (-0700), bmeng...@gmail.com wrote: > > On Wed, Aug 14, 2019 at 11:33 PM Bin Meng wrote: > >> > >> This adds 'info mem' command for RISC-V, to show virtual memory > >> mappings that aids

Re: [Qemu-devel] [PATCH v9 05/11] numa: Extend CLI to provide initiator information for numa nodes

On 8/27/2019 9:12 PM, Igor Mammedov wrote: On Tue, 20 Aug 2019 16:34:44 +0800 Tao Xu wrote: On 8/16/2019 10:57 PM, Igor Mammedov wrote: On Wed, 14 Aug 2019 19:31:27 -0700 Dan Williams wrote: On Wed, Aug 14, 2019 at 6:57 PM Tao Xu wrote: On 8/15/2019 5:29 AM, Dan Williams wrote: On

Re: [Qemu-devel] libvhost-user: undefined reference to MADV_NOHUGEPAGE

On 8/27/19 5:26 PM, Sandra Loosemore wrote: > Yesterday I tried to build the recent 4.1 release system-mode QEMU for > aarch64-none-elf and ran into a compilation error in > ./contrib/libvhost-user/libvhost-user.c. Why are you attempting to compile qemu for a non-hosted (aka bare metal)

[Qemu-devel] libvhost-user: undefined reference to MADV_NOHUGEPAGE

Yesterday I tried to build the recent 4.1 release system-mode QEMU for aarch64-none-elf and ran into a compilation error in ./contrib/libvhost-user/libvhost-user.c. It's complaining about MADV_NOHUGEPAGE not being defined. I'm not familiar with that code or even what it does; should that bit

Re: [Qemu-devel] RISC-V: Vector && DSP Extension

On Thu, 22 Aug 2019 15:37:15 PDT (-0700), alistai...@gmail.com wrote: On Wed, Aug 21, 2019 at 6:56 PM liuzhiwei wrote: On 2019/8/22 上午3:31, Palmer Dabbelt wrote: > On Thu, 15 Aug 2019 14:37:52 PDT (-0700), alistai...@gmail.com wrote: >> On Thu, Aug 15, 2019 at 2:07 AM Peter Maydell >>

Re: [Qemu-devel] [Qemu-riscv] [PATCH v1 02/28] target/riscv: Add the virtulisation mode

On Tue, Aug 27, 2019 at 8:44 AM Chih-Min Chao wrote: > > > > On Sat, Aug 24, 2019 at 7:41 AM Alistair Francis > wrote: >> >> Signed-off-by: Alistair Francis >> --- >> target/riscv/cpu.h| 4 >> target/riscv/cpu_bits.h | 6 ++ >> target/riscv/cpu_helper.c | 23

Re: [Qemu-devel] [PATCH v2 66/68] target/arm: Convert T16, long branches

On 8/27/19 2:34 AM, Peter Maydell wrote: >> +tcg_gen_andi_i32(tmp, tmp, -4); > > Minor nit, but can we use 0xfffc like the old code did, > to avoid the reader having to do 2s-complement arithmetic > in their head to figure out that we're clearing the low 2 bits? I always preferred "x &

Re: [Qemu-devel] [PATCH v2] riscv: rv32: Root page table address can be larger than 32-bit

On Sun, 18 Aug 2019 23:00:40 PDT (-0700), bmeng...@gmail.com wrote: On Wed, Aug 14, 2019 at 5:46 PM Bin Meng wrote: Hi Palmer, On Sat, Aug 10, 2019 at 9:49 AM Alistair Francis wrote: > > On Wed, Aug 7, 2019 at 7:50 PM Bin Meng wrote: > > > > For RV32, the root page table's PPN has 22 bits

Re: [Qemu-devel] [PATCH v4] riscv: hmp: Add a command to show virtual memory mappings

On Sun, 18 Aug 2019 22:59:54 PDT (-0700), bmeng...@gmail.com wrote: On Wed, Aug 14, 2019 at 11:33 PM Bin Meng wrote: This adds 'info mem' command for RISC-V, to show virtual memory mappings that aids debugging. Rather than showing every valid PTE, the command compacts the output by merging

Re: [Qemu-devel] [PATCH v2 4/4] audio: paaudio: ability to specify stream name

On 2019-08-27 07:42, Gerd Hoffmann wrote: > On Mon, Aug 26, 2019 at 09:59:04PM +0200, Kővágó, Zoltán wrote: >> This can be used to identify stream in tools like pavucontrol when one >> creates multiple -audiodevs or runs multiple qemu instances. > > Hmm, can we create an useful name

[Qemu-devel] [PATCH V3] gdbstub: Fix handler for 'F' packet

Handling of the 'F' packet has been broken since commit 4b20fab101b9e2d0fb47454209637a17fc7a13d5, which converted it to use the new packet parsing infrastructure. Per the GDB RSP specification https://sourceware.org/gdb/current/onlinedocs/gdb/The-F-Reply-Packet.html the second parameter may be

Re: [Qemu-devel] [PATCH 2/2] block/nvme: add support for discard

On 8/25/19 3:15 AM, Maxim Levitsky wrote: > Signed-off-by: Maxim Levitsky > --- > block/nvme.c | 83 ++ > block/trace-events | 2 ++ > 2 files changed, 85 insertions(+) > > diff --git a/block/nvme.c b/block/nvme.c > index

Re: [Qemu-devel] [PATCH v2 18/68] target/arm: Convert the rest of A32 Miscelaneous instructions

On 8/27/19 1:01 PM, Richard Henderson wrote: > Other constraints, such as rd != 15 or imod != 0, should continue to return > false so that a (potential) grouped insn can match. Eh. This is not the answer that the TT example suggests. So far we are able to order the grouped insns such that

Re: [Qemu-devel] [PATCH V2] gdbstub: Fix handler for 'F' packet

On 8/27/19 3:30 PM, no-re...@patchew.org wrote: === OUTPUT BEGIN === ERROR: space prohibited before that close parenthesis ')' #37: FILE: gdbstub.c:1827: +if (gdb_ctx->num_params >= 2 ) { Arggghh, I am sorry. I fixed this and then screwed up and resent the old patch over again.

Re: [Qemu-devel] [PATCH 1/2] block/nvme: add support for write zeros

Without a commit message, I have no real hope of reviewing this. I was CC'd, though, so I'll give it a blind shot. We want to add write_zeroes support for block/nvme, but I can't really verify any of that is correct or working without a unit test, a spec, or some instructions to help me verify

Re: [Qemu-devel] [PATCH] gdbstub: Send a reply to the vKill packet.

14.02.2019. 19.27, "Sandra Loosemore" је написао/ла: > > On 2/14/19 10:48 AM, Peter Maydell wrote: >> >> On Tue, 12 Feb 2019 at 21:52, Sandra Loosemore wrote: >>> >>> >>> Per the GDB remote protocol documentation >>> >>>

Re: [Qemu-devel] [PATCH V2] gdbstub: Fix handler for 'F' packet

Patchew URL: https://patchew.org/QEMU/20190827211753.7936-1-san...@codesourcery.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190827211753.7936-1-san...@codesourcery.com Type: series Subject: [Qemu-devel] [PATCH V2]

[Qemu-devel] [PATCH V2] gdbstub: Fix handler for 'F' packet

Handling of the 'F' packet has been broken since commit 4b20fab101b9e2d0fb47454209637a17fc7a13d5, which converted it to use the new packet parsing infrastructure. Per the GDB RSP specification https://sourceware.org/gdb/current/onlinedocs/gdb/The-F-Reply-Packet.html the second parameter may be

Re: [Qemu-devel] [PATCH 0/2] block: Let blockdev-create return 0 on success

On 8/23/19 2:47 PM, Max Reitz wrote: > Jobs are expected to return 0 on success. .bdrv_co_create() on the > other hand is a block layer function, and as such returns a non-negative > value on success. > > blockdev_create_run() should translate between the two (patch 1). > > Without patch 1,

Re: [Qemu-devel] [PATCH 2/2] iotests: Test blockdev-create for vpc

On 8/23/19 2:47 PM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/266 | 182 + > tests/qemu-iotests/266.out | 107 ++ > tests/qemu-iotests/group | 1 + > 3 files changed, 290 insertions(+) > create mode

Re: [Qemu-devel] GSoC project: API Documentation Generation links and comments

On 8/27/19 4:56 PM, Peter Maydell wrote: > On Tue, 27 Aug 2019 at 21:52, John Snow wrote: >> - For theming, I'm a fan of the RTD theme, because I think it makes the >> TOC tree stand out better and makes for nicer browsing than the default >> alabaster theme. Maybe when there's a better

Re: [Qemu-devel] [PATCH 0/1] Fix cacheline detection on FreeBSD/powerpc

On Wed, 21 Aug 2019 10:25:45 +0200 Laurent Vivier wrote: > This is the patch originally sent by Justin, modified > to change the parameter size on FreeBSD only. > > Justin, could you review and test on FreeBSD? > Peter, could you run "make check" on your MacOS X host? > > Thanks, > Laurent >

Re: [Qemu-devel] GSoC project: API Documentation Generation links and comments

On Tue, 27 Aug 2019 at 21:52, John Snow wrote: > - For theming, I'm a fan of the RTD theme, because I think it makes the > TOC tree stand out better and makes for nicer browsing than the default > alabaster theme. Maybe when there's a better over-arching TOC laid out > with better organization we

Re: [Qemu-devel] GSoC project: API Documentation Generation links and comments

On 8/26/19 2:51 PM, Gabriel Barreto wrote: > I've uploaded to my github repository¹ the work done so far. Using > Peter's patches as a starting point, we were able to generate > kernel-docs documentation for some of QEMU's APIs. After studying the > available options, we found a nice solution

[Qemu-devel] [PULL 1/1] trace: Clarify DTrace/SystemTap help message

From: Philippe Mathieu-Daudé Most tracing backends are implemented within QEMU, except the DTrace/SystemTap backends. One side effect is when running 'qemu -trace help', an incomplete list of trace events is displayed when using the DTrace/SystemTap backends. This is partly due to trace events

[Qemu-devel] [PULL 0/1] Tracing patches

The following changes since commit dac03af5d5482ec7ee9c23db467bb7230b33c0d9: Merge remote-tracking branch 'remotes/rth/tags/pull-axp-20190825' into staging (2019-08-27 10:00:51 +0100) are available in the Git repository at: https://github.com/stefanha/qemu.git tags/tracing-pull-request

[Qemu-devel] [PULL 10/12] block/qcow2: refactor qcow2_co_preadv to use buffer-based io

From: Vladimir Sementsov-Ogievskiy Use buffer based io in encrypted case. Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Stefan Hajnoczi Message-id: 20190604161514.262241-11-vsement...@virtuozzo.com Message-Id: <20190604161514.262241-11-vsement...@virtuozzo.com> Signed-off-by: Stefan

[Qemu-devel] [PULL 07/12] block/io: bdrv_aligned_preadv: use and support qiov_offset

From: Vladimir Sementsov-Ogievskiy Use and support new API in bdrv_co_do_copy_on_readv. Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Stefan Hajnoczi Message-id: 20190604161514.262241-8-vsement...@virtuozzo.com Message-Id: <20190604161514.262241-8-vsement...@virtuozzo.com>

[Qemu-devel] [PULL 06/12] block/io: bdrv_co_do_copy_on_readv: lazy allocation

From: Vladimir Sementsov-Ogievskiy Allocate bounce_buffer only if it is really needed. Also, sub-optimize allocation size (why not?). Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Stefan Hajnoczi Message-id: 20190604161514.262241-7-vsement...@virtuozzo.com Message-Id:

[Qemu-devel] [PULL 12/12] block/qcow2: implement .bdrv_co_pwritev(_compressed)_part

From: Vladimir Sementsov-Ogievskiy Implement and use new interface to get rid of hd_qiov. Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Stefan Hajnoczi Message-id: 20190604161514.262241-13-vsement...@virtuozzo.com Message-Id: <20190604161514.262241-13-vsement...@virtuozzo.com>

[Qemu-devel] [PULL 04/12] block: define .*_part io handlers in BlockDriver

From: Vladimir Sementsov-Ogievskiy Add handlers supporting qiov_offset parameter: bdrv_co_preadv_part bdrv_co_pwritev_part bdrv_co_pwritev_compressed_part This is used to reduce need of defining local_qiovs and hd_qiovs in all corners of block layer code. The following patches will

[Qemu-devel] [PULL 11/12] block/qcow2: implement .bdrv_co_preadv_part

From: Vladimir Sementsov-Ogievskiy Implement and use new interface to get rid of hd_qiov. Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Stefan Hajnoczi Message-id: 20190604161514.262241-12-vsement...@virtuozzo.com Message-Id: <20190604161514.262241-12-vsement...@virtuozzo.com>

Re: [Qemu-devel] [PATCH] gdbstub: Fix handler for 'F' packet

Patchew URL: https://patchew.org/QEMU/20190827194849.7076-1-san...@codesourcery.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190827194849.7076-1-san...@codesourcery.com Type: series Subject: [Qemu-devel] [PATCH] gdbstub:

[Qemu-devel] [PULL 09/12] block/io: introduce bdrv_co_p{read, write}v_part

From: Vladimir Sementsov-Ogievskiy Introduce extended variants of bdrv_co_preadv and bdrv_co_pwritev with qiov_offset parameter. Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Stefan Hajnoczi Message-id: 20190604161514.262241-10-vsement...@virtuozzo.com Message-Id:

[Qemu-devel] [PULL 08/12] block/io: bdrv_aligned_pwritev: use and support qiov_offset

From: Vladimir Sementsov-Ogievskiy Use and support new API in bdrv_aligned_pwritev. Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Stefan Hajnoczi Message-id: 20190604161514.262241-9-vsement...@virtuozzo.com Message-Id: <20190604161514.262241-9-vsement...@virtuozzo.com> Signed-off-by:

[Qemu-devel] [PULL 03/12] block/io: refactor padding

From: Vladimir Sementsov-Ogievskiy We have similar padding code in bdrv_co_pwritev, bdrv_co_do_pwrite_zeroes and bdrv_co_preadv. Let's combine and unify it. [Squashed in Vladimir's qemu-iotests 077 fix --Stefan] Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Stefan Hajnoczi

[Qemu-devel] [PULL 05/12] block/io: bdrv_co_do_copy_on_readv: use and support qiov_offset

From: Vladimir Sementsov-Ogievskiy Use and support new API in bdrv_co_do_copy_on_readv. Note that in case of allocated-in-top we need to shrink read size to MIN(..) by hand, as pre-patch this was actually done implicitly by qemu_iovec_concat (and we used local_qiov.size). Signed-off-by:

[Qemu-devel] [PULL 02/12] util/iov: improve qemu_iovec_is_zero

From: Vladimir Sementsov-Ogievskiy We'll need to check a part of qiov soon, so implement it now. Optimization with align down to 4 * sizeof(long) is dropped due to: 1. It is strange: it aligns length of the buffer, but where is a guarantee that buffer pointer is aligned itself? 2.

[Qemu-devel] [PULL 01/12] util/iov: introduce qemu_iovec_init_extended

From: Vladimir Sementsov-Ogievskiy Introduce new initialization API, to create requests with padding. Will be used in the following patch. New API uses qemu_iovec_init_buf if resulting io vector has only one element, to avoid extra allocations. So, we need to update qemu_iovec_destroy to support

[Qemu-devel] [PULL 00/12] Block patches

The following changes since commit dac03af5d5482ec7ee9c23db467bb7230b33c0d9: Merge remote-tracking branch 'remotes/rth/tags/pull-axp-20190825' into staging (2019-08-27 10:00:51 +0100) are available in the Git repository at: https://github.com/stefanha/qemu.git tags/block-pull-request for

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

On 8/23/19 5:22 AM, Vladimir Sementsov-Ogievskiy wrote: > 14.08.2019 13:07, Vladimir Sementsov-Ogievskiy wrote: >> To get rid of implicit filters related workarounds in future let's >> deprecate them now. > > Interesting, could we deprecate implicit filter without deprecation of > unnecessity

Re: [Qemu-devel] [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

On 08/27/19 18:23, Igor Mammedov wrote: > On Mon, 26 Aug 2019 17:30:43 +0200 > Laszlo Ersek wrote: > >> On 08/23/19 17:25, Kinney, Michael D wrote: >>> Hi Jiewen, >>> >>> If a hot add CPU needs to run any code before the >>> first SMI, I would recommend is only executes code >>> from a write

Re: [Qemu-devel] [PATCH v2] configure: more resilient Python version capture

On Mon, Aug 26, 2019 at 11:58:32AM -0400, Cleber Rosa wrote: > The current approach to capture the Python version is fragile, as it > was demonstrated by a very specific build of Python 3 on Fedora 29 > that, under non-interactive shells would print multiline version > information. > > The

Re: [Qemu-devel] [PATCH v2 18/68] target/arm: Convert the rest of A32 Miscelaneous instructions

On 8/27/19 3:32 AM, Peter Maydell wrote: >> +static bool trans_HVC(DisasContext *s, arg_HVC *a) >> +{ >> +if (!ENABLE_ARCH_7 || IS_USER(s) || arm_dc_feature(s, ARM_FEATURE_M)) { >> +return false; >> +} >> +gen_hvc(s, a->imm); >> +return true; >> +} > > I was wondering

Re: [Qemu-devel] [Qemu-block] [PATCH v5 1/6] iotests: allow Valgrind checking all QEMU processes

On 8/25/19 11:26 AM, Andrey Shinkevich wrote: > > > On 16/08/2019 01:49, John Snow wrote: >> >> >> On 7/19/19 12:30 PM, Andrey Shinkevich wrote: >>> With the '-valgrind' option, let all the QEMU processes be run under >>> the Valgrind tool. The Valgrind own parameters may be set with its >>>

Re: [Qemu-devel] [PATCH] i386/vmmouse: Properly reset state

On Sun, Aug 25, 2019 at 04:58:18PM +0200, Jan Kiszka wrote: > On 21.07.19 10:58, Jan Kiszka wrote: > > From: Jan Kiszka > > > > nb_queue was not zeroed so that we no longer delivered events if a > > previous guest left the device in an overflow state. > > > > The state of absolute does not

[Qemu-devel] [PATCH] gdbstub: Fix handler for 'F' packet

Handling of the 'F' packet has been broken since commit 4b20fab101b9e2d0fb47454209637a17fc7a13d5, which converted it to use the new packet parsing infrastructure. Per the GDB RSP specification https://sourceware.org/gdb/current/onlinedocs/gdb/The-F-Reply-Packet.html the second parameter may be

Re: [Qemu-devel] [Qemu-block] [PATCH v5 4/6] iotests: Valgrind fails with nonexistent directory

On 8/25/19 11:24 AM, Andrey Shinkevich wrote: > > > On 16/08/2019 03:55, John Snow wrote: >> >> >> On 7/19/19 12:30 PM, Andrey Shinkevich wrote: >>> The Valgrind uses the exported variable TMPDIR and fails if the >>> directory does not exist. Let us exclude such a test case from >>> being run

Re: [Qemu-devel] [Qemu-block] [PATCH v5 6/6] iotests: extend sleeping time under Valgrind

On 8/23/19 11:27 AM, Vladimir Sementsov-Ogievskiy wrote: > 16.08.2019 4:01, John Snow wrote: >> >> >> On 7/19/19 12:30 PM, Andrey Shinkevich wrote: >>> To synchronize the time when QEMU is running longer under the Valgrind, >>> increase the sleeping time in the test 247. >>> >>> Signed-off-by:

Re: [Qemu-devel] [PATCH v2 21/68] target/arm: Convert Synchronization primitives

On 8/27/19 4:10 AM, Peter Maydell wrote: > On Tue, 27 Aug 2019 at 11:46, Peter Maydell wrote: >> ...OK, not this specific function, as I just noticed it's the _a32 >> one, but trans_STREXB(), trans_STREXH(), etc are wrong. > > I did a quick grep through for places checking the 6K condition, >

[Qemu-devel] [RFC,Draft] ui: add an embedded Barrier client

This allows to receive mouse and keyboard events from a Barrier server. This is enabled by adding the following parameter on the command line ... -object input-barrier,id=$id,name=$name ... Where $name is the name declared in the screens section of barrier.conf The barrier server

Re: [Qemu-devel] [PATCH v6 3/3] target/ppc: Refactor emulation of vmrgew and vmrgow instructions

On 8/27/19 2:37 AM, Stefan Brankovic wrote: > Since I found this two instructions implemented with tcg, I refactored > them so they are consistent with other similar implementations that > I introduced in this patch. > > Also, a new dual macro GEN_VXFORM_TRANS_DUAL is added. This macro is > used

Re: [Qemu-devel] [PATCH v6 2/3] target/ppc: Optimize emulation of vclzh and vclzb instructions

On 8/27/19 2:37 AM, Stefan Brankovic wrote: > +for (i = 0; i < 2; i++) { > +if (i == 0) { > +/* Get high doubleword of vB in avr. */ > +get_avr64(avr, VB, true); > +} else { > +/* Get low doubleword of vB in avr. */ > +

Re: [Qemu-devel] [PATCH v6 1/3] target/ppc: Optimize emulation of vpkpx instruction

On Tue, 27 Aug 2019, Richard Henderson wrote: On 8/27/19 2:37 AM, Stefan Brankovic wrote: +for (i = 0; i < 4; i++) { +switch (i) { +case 0: +/* + * Get high doubleword of vA to perfrom 6-5-5 pack of pixels + * 1 and 2. + */ +

[Qemu-devel] [PATCH v2 0/2] Alignment checks cleanup

While working on 4k support, I noticed that there is lot of code using BDRV_SECTOR_SIZE (512) for checking alignment. I wonder how this can work with 4k storage. Lets start by cleaning up to make the code easier to understand: - Use QEMU_IS_ALIGNED macro to check alignment - Remove unneeded masks

[Qemu-devel] [PATCH v2 1/2] block: Use QEMU_IS_ALIGNED

Replace instances of: (n & (BDRV_SECTOR_SIZE - 1)) == 0 And: (n & ~BDRV_SECTOR_MASK) == 0 With: QEMU_IS_ALIGNED(n, BDRV_SECTOR_SIZE) Which reveals the intent of the code better, and makes it easier to locate the code checking alignment. Signed-off-by: Nir Soffer ---

[Qemu-devel] [PATCH v2 2/2] block: Remove unused masks

Replace confusing usage: ~BDRV_SECTOR_MASK With more clear: (BDRV_SECTOR_SIZE - 1) Remove BDRV_SECTOR_MASK and the unused BDRV_BLOCK_OFFSET_MASK which was it's last user. Signed-off-by: Nir Soffer --- include/block/block.h | 2 -- migration/block.c | 2 +- 2 files changed, 1

Re: [Qemu-devel] [PATCH v6 1/3] target/ppc: Optimize emulation of vpkpx instruction

On 8/27/19 2:37 AM, Stefan Brankovic wrote: > +for (i = 0; i < 4; i++) { > +switch (i) { > +case 0: > +/* > + * Get high doubleword of vA to perfrom 6-5-5 pack of pixels > + * 1 and 2. > + */ > +get_avr64(avr, VA,

Re: [Qemu-devel] [PATCH] iotests: Unify cache mode quoting

Patchew URL: https://patchew.org/QEMU/20190827173432.7656-1-nsof...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190827173432.7656-1-nsof...@redhat.com Type: series Subject: [Qemu-devel] [PATCH] iotests: Unify cache

Re: [Qemu-devel] [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

On Sat, 24 Aug 2019 01:48:09 + "Yao, Jiewen" wrote: > I give my thought. > Paolo may add more. Here are some ideas I have on the topic. > > > -Original Message- > > From: Kinney, Michael D > > Sent: Friday, August 23, 2019 11:25 PM > > To: Yao, Jiewen ; Paolo Bonzini > > ; Laszlo

[Qemu-devel] [PULL 13/15] iotests: Check for enabled drivers before testing them

From: Thomas Huth It is possible to enable only a subset of the block drivers with the "--block-drv-rw-whitelist" option of the "configure" script. All other drivers are marked as unusable (or only included as read-only with the "--block-drv-ro-whitelist" option). If an iotest is now using such

[Qemu-devel] [PULL 10/15] iotests: Disable 110 for vmdk.twoGbMaxExtentSparse

The error message for the test case where we have a quorum node for which no directory name can be generated is different: For twoGbMaxExtentSparse, it complains that it cannot open the extent file. For other (sub)formats, it just notes that it cannot determine the backing file path. Both are

[Qemu-devel] [PULL 15/15] iotests: Unify cache mode quoting

From: Nir Soffer Quoting cache mode is not needed, and most tests use unquoted values. Unify all test to use the same style. Message-id: 20190827173432.7656-1-nsof...@redhat.com Signed-off-by: Nir Soffer Signed-off-by: Max Reitz --- tests/qemu-iotests/026 | 4 ++-- tests/qemu-iotests/039 | 4

[Qemu-devel] [PULL 08/15] vmdk: Reject invalid compressed writes

Compressed writes generally have to write full clusters, not just in theory but also in practice when it comes to vmdk's streamOptimized subformat. It currently is just silently broken for writes with non-zero in-cluster offsets: $ qemu-img create -f vmdk -o subformat=streamOptimized foo.vmdk 1M

[Qemu-devel] [PULL 12/15] file-posix: fix request_alignment typo

From: Stefan Hajnoczi Fixes: a6b257a08e3d72219f03e461a52152672fec0612 ("file-posix: Handle undetectable alignment") Signed-off-by: Stefan Hajnoczi Message-id: 20190827101328.4062-1-stefa...@redhat.com Reviewed-by: Thomas Huth Signed-off-by: Max Reitz --- block/file-posix.c | 2 +- 1

[Qemu-devel] [PULL 07/15] iotests: Keep testing broken relative extent paths

We had a test for a case where relative extent paths did not work, but unfortunately we just fixed the underlying problem, so it works now. This patch adds a new test case that still fails. Signed-off-by: Max Reitz Reviewed-by: John Snow Message-id: 20190815153638.4600-4-mre...@redhat.com

[Qemu-devel] [PULL 14/15] tests/check-block: Skip iotests when sanitizers are enabled

From: Thomas Huth The sanitizers (especially the address sanitizer from Clang) are sometimes printing out warnings or false positives - this spoils the output of the iotests, causing some of the tests to fail. Thus let's skip the automatic iotests during "make check" when the user configured

[Qemu-devel] [PULL 04/15] iotests: Test allocate_first_block() with O_DIRECT

From: Nir Soffer Using block_resize we can test allocate_first_block() with file descriptor opened with O_DIRECT, ensuring that it works for any size larger than 4096 bytes. Testing smaller sizes is tricky as the result depends on the filesystem used for testing. For example on NFS any size

[Qemu-devel] [PULL 11/15] iotests: Disable 126 for flat vmdk subformats

iotest 126 requires backing file support, which flat vmdks cannot offer. Skip this test for such subformats. Signed-off-by: Max Reitz Message-id: 20190815153638.4600-8-mre...@redhat.com Reviewed-by: John Snow Signed-off-by: Max Reitz --- tests/qemu-iotests/126 | 2 ++ 1 file changed, 2

[Qemu-devel] [PULL 05/15] iotests: Fix _filter_img_create()

fe646693acc changed qemu-img create's output so that it no longer prints single quotes around parameter values. The subformat and adapter_type filters in _filter_img_create() have never been adapted to that change. Fixes: fe646693acc13ac48b98435d14149ab04dc597bc Signed-off-by: Max Reitz

[Qemu-devel] [PULL 06/15] vmdk: Use bdrv_dirname() for relative extent paths

This makes iotest 033 pass with e.g. subformat=monolithicFlat. It also turns a former error in 059 into success. Signed-off-by: Max Reitz Message-id: 20190815153638.4600-3-mre...@redhat.com Reviewed-by: John Snow Signed-off-by: Max Reitz --- block/vmdk.c | 54

[Qemu-devel] [PULL 00/15] Block patches

The following changes since commit 23919ddfd56135cad3cb468a8f54d5a595f024f4: Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20190827' into staging (2019-08-27 15:52:36 +0100) are available in the Git repository at: https://github.com/XanClic/qemu.git tags/pull-block-2019-08-27

[Qemu-devel] [PULL 09/15] iotests: Disable broken streamOptimized tests

streamOptimized does not support writes that do not span exactly one cluster. Furthermore, it cannot rewrite already allocated clusters. As such, many iotests do not work with it. Disable them. Signed-off-by: Max Reitz Message-id: 20190815153638.4600-6-mre...@redhat.com Reviewed-by: John Snow

[Qemu-devel] [PULL 02/15] block: fix permission update in bdrv_replace_node

From: Vladimir Sementsov-Ogievskiy It's wrong to OR shared permissions. It may lead to crash on further permission updates. Also, no needs to consider previously calculated permissions, as at this point we already bind all new parents and bdrv_get_cumulative_perm result is enough. So fix the bug

[Qemu-devel] [PULL 01/15] qemu-io: add pattern file for write command

From: Denis Plotnikov The patch allows to provide a pattern file for write command. There was no similar ability before. Signed-off-by: Denis Plotnikov Message-id: 20190820164616.4072-1-dplotni...@virtuozzo.com Reviewed-by: Eric Blake [mreitz: Keep optstring in alphabetical order]

[Qemu-devel] [PULL 03/15] block: posix: Always allocate the first block

From: Nir Soffer When creating an image with preallocation "off" or "falloc", the first block of the image is typically not allocated. When using Gluster storage backed by XFS filesystem, reading this block using direct I/O succeeds regardless of request length, fooling alignment detection. In

Re: [Qemu-devel] [PATCH] iotests: Unify cache mode quoting

On Tue, Aug 27, 2019 at 8:43 PM Max Reitz wrote: > > On 27.08.19 19:38, Nir Soffer wrote: > > On Tue, Aug 27, 2019 at 8:36 PM Max Reitz > > wrote: > > > > On 27.08.19 19:34, Nir Soffer wrote: > > > Quoting cache mode is not needed, and most tests use unquoted

Re: [Qemu-devel] [PATCH] iotests: Unify cache mode quoting

On 27.08.19 19:38, Nir Soffer wrote: > On Tue, Aug 27, 2019 at 8:36 PM Max Reitz > wrote: > > On 27.08.19 19:34, Nir Soffer wrote: > > Quoting cache mode is not needed, and most tests use unquoted values. > > Unify all test to use the same style. > >

Re: [Qemu-devel] [PATCH] iotests: Unify cache mode quoting

On Tue, Aug 27, 2019 at 8:36 PM Max Reitz wrote: > On 27.08.19 19:34, Nir Soffer wrote: > > Quoting cache mode is not needed, and most tests use unquoted values. > > Unify all test to use the same style. > > S-o-b is missing, shall I add it? > Thanks! Signed-off-by: Nir Soffer > > Max > > >

Re: [Qemu-devel] [PATCH] iotests: Unify cache mode quoting

On 27.08.19 19:34, Nir Soffer wrote: > Quoting cache mode is not needed, and most tests use unquoted values. > Unify all test to use the same style. S-o-b is missing, shall I add it? Max > --- > tests/qemu-iotests/026 | 4 ++-- > tests/qemu-iotests/039 | 4 ++-- > tests/qemu-iotests/052 | 2 +-

Re: [Qemu-devel] [PATCH] tests/check-block: Skip iotests when sanitizers are enabled

On 23.08.19 10:42, Thomas Huth wrote: > The sanitizers (especially the address sanitizer from Clang) are > sometimes printing out warnings or false positives - this spoils > the output of the iotests, causing some of the tests to fail. > Thus let's skip the automatic iotests during "make check"

[Qemu-devel] [PATCH] iotests: Unify cache mode quoting

Quoting cache mode is not needed, and most tests use unquoted values. Unify all test to use the same style. --- tests/qemu-iotests/026 | 4 ++-- tests/qemu-iotests/039 | 4 ++-- tests/qemu-iotests/052 | 2 +- tests/qemu-iotests/091 | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff

Re: [Qemu-devel] [PATCH v2] iotests: Check for enabled drivers before testing them

On 23.08.19 15:35, Thomas Huth wrote: > It is possible to enable only a subset of the block drivers with the > "--block-drv-rw-whitelist" option of the "configure" script. All other > drivers are marked as unusable (or only included as read-only with the > "--block-drv-ro-whitelist" option). If an

Re: [Qemu-devel] [PATCH] file-posix: fix request_alignment typo

On 27.08.19 12:13, Stefan Hajnoczi wrote: > Fixes: a6b257a08e3d72219f03e461a52152672fec0612 >("file-posix: Handle undetectable alignment") > Signed-off-by: Stefan Hajnoczi > --- > block/file-posix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my block

Re: [Qemu-devel] [PATCH v2 0/7] vmdk: Misc fixes

On 15.08.19 17:36, Max Reitz wrote: > I made the mistake of trying to run the iotests with all non-default > subformats our vmdk driver has to offer: > - monolithicFlat > - twoGbMaxExtentSparse > - twoGbMaxExtentFlat > - streamOptimized > > Many things broke, so this series fixes what I found.

Re: [Qemu-devel] [PATCH v3 1/2] block: posix: Always allocate the first block

On 27.08.19 18:58, Max Reitz wrote: > On 27.08.19 03:05, Nir Soffer wrote: >> When creating an image with preallocation "off" or "falloc", the first >> block of the image is typically not allocated. When using Gluster >> storage backed by XFS filesystem, reading this block using direct I/O >>

  1   2   3   >