Re: [Qemu-devel] [PATCH 3/4] RFC target/arm: Do not build pre-ARMv7 cpus when using KVM

2019-08-29 Thread Thomas Huth
On 29/08/2019 20.19, Philippe Mathieu-Daudé wrote: > Hi Thomas, > > On 8/23/19 4:28 PM, Thomas Huth wrote: >> On 8/23/19 3:58 PM, Philippe Mathieu-Daudé wrote: >>> A KVM-only build won't be able to run pre-ARMv7 cpus, disable them. >>> >>> If KVM is not enabled, they are enabled by default. >>

Re: [Qemu-devel] [PATCH v3 0/4] Introduce the microvm machine type

2019-08-29 Thread Jing Liu
Hi Sergio, On 8/29/2019 11:46 PM, Sergio Lopez wrote: Jing Liu writes: Hi Sergio, The idea is interesting and I tried to launch a guest by your guide but seems failed to me. I tried both legacy and normal modes, but the vncviewer connected and told me that: The vm has no graphic display

Re: [Qemu-devel] [PATCH v2 4/8] exec: Factor out cpu_watchpoint_address_matches

2019-08-29 Thread Richard Henderson
On 8/29/19 10:20 AM, Philippe Mathieu-Daudé wrote: >> +/* Avoid trapping reads of pages with a write breakpoint. */ >> +match = (prot & PAGE_READ ? BP_MEM_READ : 0) >> + | (prot & PAGE_WRITE ? BP_MEM_WRITE : 0); > > Isn't it cheaper to do here: > >if (!match) { >

Re: [Qemu-devel] [PATCH for-4.2 v10 03/15] virtio-iommu: Add skeleton

2019-08-29 Thread Peter Xu
On Thu, Aug 29, 2019 at 02:18:42PM +0200, Auger Eric wrote: > Hi Peter, > > First of all, please forgive me for the delay. > On 8/15/19 3:54 PM, Peter Xu wrote: > > On Tue, Jul 30, 2019 at 07:21:25PM +0200, Eric Auger wrote: > >> +static void virtio_iommu_handle_command(VirtIODevice *vdev,

Re: [Qemu-devel] [PATCH v2 2/8] exec: Factor out core logic of check_watchpoint()

2019-08-29 Thread Richard Henderson
On 8/29/19 10:26 AM, Philippe Mathieu-Daudé wrote: >> -wp->hitaddr = vaddr; >> +wp->hitaddr = MAX(addr, wp->vaddr); > > When is addr > wp->vaddr? Both the watchpoint and the access are arbitrary ranges. wp:[ 1000 - 1008 ] store: [ 1002 - 1004 ]

Re: [Qemu-devel] [PATCH] RISCV: support riscv vector extension 0.7.1

2019-08-29 Thread Alistair Francis
On Thu, Aug 29, 2019 at 5:05 AM liuzhiwei wrote: > > On 2019/8/29 上午5:34, Alistair Francis wrote: > > On Wed, Aug 28, 2019 at 12:04 AM liuzhiwei wrote: > >> Change-Id: I3cf891bc400713b95f47ecca82b1bf773f3dcb25 > >> Signed-off-by: liuzhiwei > >> --- > >> fpu/softfloat.c

Re: [Qemu-devel] [PATCH] migration: Do not re-read the clock on pre_save in case of paused guest

2019-08-29 Thread Eduardo Habkost
CCing Marcelo, who wrote kvm_update_clock() and kvmclock_pre_save(). On Thu, Aug 29, 2019 at 06:07:11PM -0300, Maxiwell S. Garcia wrote: > The clock move makes the guest knows about the paused time between the > 'stop' and 'migrate' commands. This is an issue in an already-paused > VM because

[Qemu-devel] [PATCH] migration: Do not re-read the clock on pre_save in case of paused guest

2019-08-29 Thread Maxiwell S. Garcia
The clock move makes the guest knows about the paused time between the 'stop' and 'migrate' commands. This is an issue in an already-paused VM because some side effects, like process stalls, could happen after migration. So, this patch checks the runstate of guest in the pre_save handler and do

Re: [Qemu-devel] [PATCH 0/2] tests/acceptance: Update MIPS Malta ssh test

2019-08-29 Thread Eduardo Habkost
On Fri, Aug 02, 2019 at 05:35:56PM +0200, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > This little series improves linux_ssh_mips_malta.py, both in the sense > of code organization and in the sense of quantity of executed tests. Thanks! I'm queueing it on python-next. The

[Qemu-devel] [Bug 1841990] [NEW] instruction 'denbcdq' misbehaving

2019-08-29 Thread Paul Clarke
Public bug reported: Instruction 'denbcdq' appears to have no effect. Test case attached. On ppc64le native: -- gcc -g -O -mcpu=power9 bcdcfsq.c test-denbcdq.c -o test-denbcdq $ ./test-denbcdq 0x 0x000c

Re: [Qemu-devel] [PATCH] target/arm: Free TCG temps in trans_VMOV_64_sp()

2019-08-29 Thread Alex Bennée
Aleksandar Markovic writes: > 27.08.2019. 14.20, "Peter Maydell" је написао/ла: >> >> The function neon_store_reg32() doesn't free the TCG temp that it >> is passed, so the caller must do that. We got this right in most >> places but forgot to free the TCG temps in trans_VMOV_64_sp(). >> >>

Re: [Qemu-devel] [PATCH v3 1/4] iotests: add script_initialize

2019-08-29 Thread John Snow
On 8/29/19 2:58 PM, Philippe Mathieu-Daudé wrote: > On 8/29/19 8:43 PM, John Snow wrote: >> On 8/29/19 2:27 PM, Philippe Mathieu-Daudé wrote: >>> This restrict test 208 to the Linux platform, is this OK? >>> >>> The rest looks good. >> >> I forgot about that, so good catch. >> >> I don't know.

Re: [Qemu-devel] [PATCH v3 1/4] iotests: add script_initialize

2019-08-29 Thread Philippe Mathieu-Daudé
On 8/29/19 8:43 PM, John Snow wrote: > On 8/29/19 2:27 PM, Philippe Mathieu-Daudé wrote: >> This restrict test 208 to the Linux platform, is this OK? >> >> The rest looks good. > > I forgot about that, so good catch. > > I don't know. We seem to already restrict a LOT of tests to the Linux >

Re: [Qemu-devel] [PATCH] target/arm: Free TCG temps in trans_VMOV_64_sp()

2019-08-29 Thread Aleksandar Markovic
27.08.2019. 14.20, "Peter Maydell" је написао/ла: > > The function neon_store_reg32() doesn't free the TCG temp that it > is passed, so the caller must do that. We got this right in most > places but forgot to free the TCG temps in trans_VMOV_64_sp(). > > Cc: qemu-sta...@nongnu.org >

Re: [Qemu-devel] [PATCH v3 4/4] iotests: use python logging for iotests.log()

2019-08-29 Thread John Snow
On 8/29/19 2:34 PM, Philippe Mathieu-Daudé wrote: > On 8/21/19 1:52 AM, John Snow wrote: >> We can turn logging on/off globally instead of per-function. >> >> Remove use_log from run_job, and use python logging to turn on >> diffable output when we run through a script entry point. >> >> iotest

Re: [Qemu-devel] [PATCH v3 1/4] iotests: add script_initialize

2019-08-29 Thread John Snow
On 8/29/19 2:27 PM, Philippe Mathieu-Daudé wrote: > This restrict test 208 to the Linux platform, is this OK? > > The rest looks good. I forgot about that, so good catch. I don't know. We seem to already restrict a LOT of tests to the Linux platform. Does this one actually work on other

Re: [Qemu-devel] [PATCH] RISCV: support riscv vector extension 0.7.1

2019-08-29 Thread Aleksandar Markovic
29.08.2019. 15.02, "liuzhiwei" је написао/ла: > > > On 2019/8/29 上午3:20, Aleksandar Markovic wrote: >> >> >> >> > On Wed, Aug 28, 2019 at 9:04 AM liuzhiwei wrote: >>> >>> Change-Id: I3cf891bc400713b95f47ecca82b1bf773f3dcb25 >>> Signed-off-by: liuzhiwei >>> --- >> >> >> Such large patch and

Re: [Qemu-devel] [PATCH] i386/vmmouse: Properly reset state

2019-08-29 Thread Philippe Mathieu-Daudé
On 8/29/19 8:12 PM, Jan Kiszka wrote: > On 29.08.19 20:00, Philippe Mathieu-Daudé wrote: >> Hi Jan, >> >> On 8/27/19 9:49 PM, Eduardo Habkost wrote: >>> On Sun, Aug 25, 2019 at 04:58:18PM +0200, Jan Kiszka wrote: On 21.07.19 10:58, Jan Kiszka wrote: > From: Jan Kiszka > >

Re: [Qemu-devel] [PATCH v3 4/4] iotests: use python logging for iotests.log()

2019-08-29 Thread Philippe Mathieu-Daudé
On 8/21/19 1:52 AM, John Snow wrote: > We can turn logging on/off globally instead of per-function. > > Remove use_log from run_job, and use python logging to turn on > diffable output when we run through a script entry point. > > iotest 245 changes output order due to buffering reasons. > --- >

Re: [Qemu-devel] [PATCH v3 2/4] iotest 258: use script_main

2019-08-29 Thread Philippe Mathieu-Daudé
On 8/21/19 1:52 AM, John Snow wrote: > Since this one is nicely factored to use a single entry point, > use script_main to run the tests. With your Signed-off-by: Reviewed-by: Philippe Mathieu-Daudé > --- > tests/qemu-iotests/258 | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-)

Re: [Qemu-devel] [PATCH v3 3/4] iotests: add protocol support to initialization info

2019-08-29 Thread Philippe Mathieu-Daudé
On 8/21/19 1:52 AM, John Snow wrote: > This will add supported_protocols and unsupported_protocols to all of > iotests.main, iotests.script_main, and iotests.script_initialize. With your Signed-off-by: Reviewed-by: Philippe Mathieu-Daudé > --- > tests/qemu-iotests/207| 4 ++-- >

Re: [Qemu-devel] [PATCH v3 1/4] iotests: add script_initialize

2019-08-29 Thread Philippe Mathieu-Daudé
On 8/21/19 1:52 AM, John Snow wrote: > Like script_main, but doesn't require a single point of entry. > Replace all existing initialization sections with this drop-in replacement. > > This brings debug support to all existing script-style iotests. > > Note: supported_oses=['linux'] was omitted,

Re: [Qemu-devel] [PATCH 0/2] tests/acceptance: Update MIPS Malta ssh test

2019-08-29 Thread Aleksandar Markovic
28.08.2019. 23.24, "Cleber Rosa" је написао/ла: > > On Thu, Aug 22, 2019 at 07:59:07PM +0200, Aleksandar Markovic wrote: > > 22.08.2019. 05.15, "Aleksandar Markovic" је > > написао/ла: > > > > > > > > > 21.08.2019. 23.00, "Eduardo Habkost" је написао/ла: > > > > > > > > On Wed, Aug 21, 2019 at

Re: [Qemu-devel] [PATCH v2 0/4] docs: add docs about use of automatic cleanup functions

2019-08-29 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190829160710.8792-1-berra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v2 0/4] docs: add docs about use of automatic cleanup functions

Re: [Qemu-devel] [PATCH 3/4] RFC target/arm: Do not build pre-ARMv7 cpus when using KVM

2019-08-29 Thread Philippe Mathieu-Daudé
Hi Thomas, On 8/23/19 4:28 PM, Thomas Huth wrote: > On 8/23/19 3:58 PM, Philippe Mathieu-Daudé wrote: >> A KVM-only build won't be able to run pre-ARMv7 cpus, disable them. >> >> If KVM is not enabled, they are enabled by default. > [...] >> config CHEETAH >> bool >> +select ARM_V4 >>

Re: [Qemu-devel] [PATCH v5 2/2] hw/vfio/common: Fail on VFIO/HW nested paging detection

2019-08-29 Thread Alex Williamson
On Thu, 29 Aug 2019 11:01:41 +0200 Eric Auger wrote: > As of today, VFIO only works along with vIOMMU supporting > caching mode. The SMMUv3 does not support this mode and > requires HW nested paging to work properly with VFIO. > > So any attempt to run a VFIO device protected by such IOMMU >

Re: [Qemu-devel] [PATCH] i386/vmmouse: Properly reset state

2019-08-29 Thread Jan Kiszka
On 29.08.19 20:00, Philippe Mathieu-Daudé wrote: Hi Jan, On 8/27/19 9:49 PM, Eduardo Habkost wrote: On Sun, Aug 25, 2019 at 04:58:18PM +0200, Jan Kiszka wrote: On 21.07.19 10:58, Jan Kiszka wrote: From: Jan Kiszka nb_queue was not zeroed so that we no longer delivered events if a previous

Re: [Qemu-devel] [PATCH 3/4] RFC target/arm: Do not build pre-ARMv7 cpus when using KVM

2019-08-29 Thread Philippe Mathieu-Daudé
On 8/23/19 7:12 PM, Richard Henderson wrote: > On 8/23/19 6:58 AM, Philippe Mathieu-Daudé wrote: >> A KVM-only build won't be able to run pre-ARMv7 cpus, disable them. >> >> If KVM is not enabled, they are enabled by default. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> Sadly this does

Re: [Qemu-devel] [PATCH 1/4] target/arm: Restrict pre-ARMv7 cpus to TCG

2019-08-29 Thread Philippe Mathieu-Daudé
On 8/23/19 7:04 PM, Richard Henderson wrote: > On 8/23/19 6:58 AM, Philippe Mathieu-Daudé wrote: >> @@ -2535,6 +2544,7 @@ static const ARMCPUInfo arm_cpus[] = { >> { .name = "arm1176", .initfn = arm1176_initfn }, >> { .name = "arm11mpcore", .initfn = arm11mpcore_initfn }, >> {

Re: [Qemu-devel] [PATCH] i386/vmmouse: Properly reset state

2019-08-29 Thread Philippe Mathieu-Daudé
Hi Jan, On 8/27/19 9:49 PM, Eduardo Habkost wrote: > On Sun, Aug 25, 2019 at 04:58:18PM +0200, Jan Kiszka wrote: >> On 21.07.19 10:58, Jan Kiszka wrote: >>> From: Jan Kiszka >>> >>> nb_queue was not zeroed so that we no longer delivered events if a >>> previous guest left the device in an

Re: [Qemu-devel] [libvirt] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-29 Thread John Snow
On 8/29/19 12:45 PM, Christophe de Dinechin wrote: > > Markus Armbruster writes: > >> Peter Krempa writes: >> > [...] >>> From my experience users report non-fatal messages mostly only if it is >>> spamming the system log. One of instances are very unlikely to be >>> noticed. >>> >>> In my

Re: [Qemu-devel] [PATCH v8 08/11] Adding tb_stats [start|pause|stop|filter] command to hmp.

2019-08-29 Thread Vanderson Martins do Rosario
Ops, this commit shouldn't exist. My mistake. The series still work though. I will remove this on v9. Vanderson M. Rosario On Thu, Aug 29, 2019 at 2:35 PM vandersonmr wrote: > This allows controlling the collection of statistics. > It is also possible to set the level of collection: > all,

Re: [Qemu-devel] [PATCH] target/arm: Free TCG temps in trans_VMOV_64_sp()

2019-08-29 Thread Philippe Mathieu-Daudé
On 8/27/19 2:19 PM, Peter Maydell wrote: > The function neon_store_reg32() doesn't free the TCG temp that it > is passed, so the caller must do that. We got this right in most > places but forgot to free the TCG temps in trans_VMOV_64_sp(). > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Peter

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-29 Thread John Snow
On 8/29/19 11:17 AM, Vladimir Sementsov-Ogievskiy wrote: > Aren't you going to deprecate and drop it at some moment? Libvirt's going to keep supporting older versions of QEMU in perpetuity. Apparently, there are still some barriers (SD cards?) to using only blockdev API for new versions, too:

Re: [Qemu-devel] [Virtio-fs] [PATCH] virtiofsd: add man page

2019-08-29 Thread Liu Bo
On Thu, Aug 29, 2019 at 11:41:33AM +0100, Stefan Hajnoczi wrote: Looks good to me, thanks for working this out. Reviewed-by: Liu Bo thanks, -liubo > Signed-off-by: Stefan Hajnoczi > --- > Makefile | 7 +++ > contrib/virtiofsd/virtiofsd.texi | 85

[Qemu-devel] [PATCH v8 08/11] Adding tb_stats [start|pause|stop|filter] command to hmp.

2019-08-29 Thread vandersonmr
This allows controlling the collection of statistics. It is also possible to set the level of collection: all, jit, or exec. tb_stats filter allow to only collect statistics for the TB in the last_search list. The goal of this command is to allow the dynamic exploration of the TCG behavior and

[Qemu-devel] [PATCH v8 09/11] Adding info [tb-list|tb|coverset] commands to HMP.

2019-08-29 Thread vandersonmr
These commands allow the exploration of TBs generated by the TCG. Understand which one hotter, with more guest/host instructions... and examine their guest, host and IR code. The goal of this command is to allow the dynamic exploration of TCG behavior and code quality. Therefore, for now, a

[Qemu-devel] [PATCH v8 05/11] accel: adding TB_JIT_TIME and full replacing CONFIG_PROFILER

2019-08-29 Thread vandersonmr
Replace all others CONFIG_PROFILER statistics and migrate it to TBStatistics system. However, TCGProfiler still exists and can be use to store global statistics and times. All TB related statistics goes to TBStatistics. Signed-off-by: Vanderson M. do Rosario --- accel/tcg/tb-stats.c | 91

[Qemu-devel] [PATCH v8 07/11] monitor: adding tb_stats hmp command

2019-08-29 Thread vandersonmr
Adding tb_stats [start|pause|stop|filter] command to hmp. This allows controlling the collection of statistics. It is also possible to set the level of collection: all, jit, or exec. tb_stats filter allow to only collect statistics for the TB in the last_search list. The goal of this command is

Re: [Qemu-devel] [PATCH 0/2] git.orderfile: Order Python/shell scripts before unordered files

2019-08-29 Thread John Snow
On 8/29/19 6:05 AM, Philippe Mathieu-Daudé wrote: > This series update the git.orderfile to order Python and shell > scripts before unordered files. > This is particularly useful for changes in tests/qemu-iotests. > > Regards, > > Phil. > > Philippe Mathieu-Daudé (2): >

[Qemu-devel] [PATCH v8 10/11] monitor: adding new info cfg command

2019-08-29 Thread vandersonmr
Adding "info cfg id depth" commands to HMP. This command allow the exploration a TB neighbors by dumping [and opening] a .dot file with the TB CFG neighbors colorized by their hotness. The goal of this command is to allow the dynamic exploration of TCG behavior and code quality. Therefore, for

[Qemu-devel] [PATCH v8 06/11] Adding -d tb_stats to control TBStatistics collection:

2019-08-29 Thread vandersonmr
-d tb_stats[[,level=(+all+jit+exec+time)][,dump_limit=]] "dump_limit" is used to limit the number of dumped TBStats in linux-user mode. [all+jit+exec+time] control the profilling level used by the TBStats. Can be used as follow: -d tb_stats -d tb_stats,level=jit+time -d tb_stats,dump_limit=15

[Qemu-devel] [PATCH v8 11/11] linux-user: dumping hot TBs at the end of the execution

2019-08-29 Thread vandersonmr
dumps, in linux-user mode, the hottest TBs if -d tb_stats is used. Example of output for the 3 hottest TBs: TB id:1 | phys:0x34d54 virt:0x00034d54 flags:0xf0 | exec:4828932/0 guest inst cov:16.38% | trans:1 ints: g:3 op:82 op_opt:34 spills:3 | h/g (host bytes

[Qemu-devel] [PATCH v8 02/11] accel: collecting TB execution count

2019-08-29 Thread vandersonmr
If a TB has a TBS (TBStatistics) with the TB_EXEC_STATS enabled, then we instrument the start code of this TB to atomically count the number of times it is executed. We count both the number of "normal" executions and atomic executions of a TB. The execution count of the TB is stored in its

[Qemu-devel] [PATCH v8 03/11] accel: collecting JIT statistics

2019-08-29 Thread vandersonmr
If a TB has a TBS (TBStatistics) with the TB_JIT_STATS enabled then we collect statistics of its translation processes and code translation. Collecting the number of host instructions seems to be not simple as it would imply in having to modify several target source files. So, for now, we are

[Qemu-devel] [PATCH v8 04/11] accel: replacing part of CONFIG_PROFILER with TBStats

2019-08-29 Thread vandersonmr
We add some of the statistics collected in the TCGProfiler into the TBStats, having the statistics not only for the whole emulation but for each TB. Then, we removed these stats from TCGProfiler and reconstruct the information for the "info jit" using the sum of all TBStats statistics. The goal

[Qemu-devel] [PATCH v8 01/11] accel: introducing TBStatistics structure

2019-08-29 Thread vandersonmr
To store statistics for each TB, we created a TBStatistics structure which is linked with the TBs. TBStatistics can stay alive after tb_flush and be relinked to a regenerated TB. So the statistics can be accumulated even through flushes. The goal is to have all present and future qemu/tcg

[Qemu-devel] [PATCH v8 00/11] Measure Tiny Code Generation Quality

2019-08-29 Thread vandersonmr
This patch is part of Google Summer of Code (GSoC) 2019. More about the project can be found in: https://wiki.qemu.org/Internships/ProjectIdeas/TCGCodeQuality The goal of this patch is to add infrastructure to collect execution and JIT statistics during the emulation with accel/TCG. The

Re: [Qemu-devel] [PATCH v6 1/6] iotests: allow Valgrind checking all QEMU processes

2019-08-29 Thread John Snow
On 8/29/19 6:50 AM, Andrey Shinkevich wrote: > > > On 29/08/2019 03:30, Eric Blake wrote: >> On 8/28/19 5:58 PM, John Snow wrote: >> +++ b/tests/qemu-iotests/common.rc @@ -60,61 +60,132 @@ if ! . ./common.config exit 1 fi +# Unset the variables to turn

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-doc: Do not hard-code the name of the QEMU binary

2019-08-29 Thread John Snow
On 8/29/19 1:41 AM, Thomas Huth wrote: > On 28/08/2019 21.18, John Snow wrote: >> >> >> On 8/28/19 5:34 AM, Thomas Huth wrote: >>> In our documentation, we use a mix of "$QEMU", "qemu-system-i386" and >>> "qemu-system-x86_64" when we give examples to the users how to run >>> QEMU. Some more

Re: [Qemu-devel] [PATCH 0/3] Acceptance test x86_cpu_model_versions: fixes and minor improvements

2019-08-29 Thread Eduardo Habkost
On Wed, Aug 28, 2019 at 03:36:25PM -0400, Cleber Rosa wrote: > This corrects some of the messages given on failures (aligning them to > the test code), and splits a larger test into smaller and more > manageable pieces. Thanks! I'm queueing this on python-next. -- Eduardo

Re: [Qemu-devel] [PATCH v2 2/8] exec: Factor out core logic of check_watchpoint()

2019-08-29 Thread Philippe Mathieu-Daudé
Hi Richard, David, On 8/29/19 1:16 AM, Richard Henderson wrote: > From: David Hildenbrand > > We want to perform the same checks in probe_write() to trigger a cpu > exit before doing any modifications. We'll have to pass a PC. > > Signed-off-by: David Hildenbrand > Reviewed-by: Richard

Re: [Qemu-devel] [PATCH v2 4/8] exec: Factor out cpu_watchpoint_address_matches

2019-08-29 Thread Philippe Mathieu-Daudé
On 8/29/19 1:16 AM, Richard Henderson wrote: > We want to move the check for watchpoints from > memory_region_section_get_iotlb to tlb_set_page_with_attrs. > Isolate the loop over watchpoints to an exported function. > > Rename the existing cpu_watchpoint_address_matches to >

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-29 Thread John Snow
On 8/29/19 11:59 AM, Christophe de Dinechin wrote: > > John Snow writes: > [...] >> >> This might be OK to do right away, though. >> >> I asked Markus this not too long ago; do we want to amend the QAPI >> schema specification to allow commands to return with "Warning" strings, >> or

Re: [Qemu-devel] [PATCH v2 7/8] cputlb: Handle watchpoints via TLB_WATCHPOINT

2019-08-29 Thread Philippe Mathieu-Daudé
On 8/29/19 1:16 AM, Richard Henderson wrote: > The raising of exceptions from check_watchpoint, buried inside > of the I/O subsystem, is fundamentally broken. We do not have > the helper return address with which we can unwind guest state. > > Replace PHYS_SECTION_WATCH and io_mem_watch with

Re: [Qemu-devel] [PATCH v2 0/4] docs: add docs about use of automatic cleanup functions

2019-08-29 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190829160710.8792-1-berra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v2 0/4] docs: add docs about use of automatic cleanup functions

Re: [Qemu-devel] [PATCH v2 3/4] docs: document use of automatic cleanup functions in glib

2019-08-29 Thread Alex Bennée
Daniel P. Berrangé writes: > Document the use of g_autofree and g_autoptr in glib for automatic > freeing of memory. > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Alex Bennée > --- > CODING_STYLE.rst | 85 > 1 file changed, 85

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-08-29 Thread Greg Kurz
On Thu, 22 Aug 2019 15:18:54 -0700 (PDT) no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/cover.1566503584.git.qemu_...@crudebyte.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series >

Re: [Qemu-devel] [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-29 Thread Laszlo Ersek
On 08/27/19 20:31, Igor Mammedov wrote: > On Sat, 24 Aug 2019 01:48:09 + > "Yao, Jiewen" wrote: >> (05) Host CPU: (OS) Port 0xB2 write, all CPUs enter SMM (NOTE: New CPU >> will not enter CPU because SMI is disabled) > I think only CPU that does the write will enter SMM That used to be

Re: [Qemu-devel] [PATCH v2 5/8] cputlb: Fix size operand for tlb_fill on unaligned store

2019-08-29 Thread Philippe Mathieu-Daudé
On 8/29/19 1:16 AM, Richard Henderson wrote: > We are currently passing the size of the full write to > the tlb_fill for the second page. Instead pass the real > size of the write to that page. > > This argument is unused within all tlb_fill, except to be > logged via tracing, so in practice

Re: [Qemu-devel] [PATCH v6 2/4] 9p: Added virtfs option 'multidevs=remap|forbid|warn'

2019-08-29 Thread Greg Kurz
On Thu, 22 Aug 2019 21:33:37 +0200 Christian Schoenebeck wrote: > 'warn' (default): Only log an error message (once) on host if more than one > device is shared by same export, except of that just ignore this config > error though. This is the default behaviour for not breaking existing >

Re: [Qemu-devel] [PATCH v2 6/8] cputlb: Remove double-alignment in store_helper

2019-08-29 Thread Philippe Mathieu-Daudé
On 8/29/19 1:16 AM, Richard Henderson wrote: > We have already aligned page2 to the start of the next page. > There is no reason to do that a second time. > > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > accel/tcg/cputlb.c | 3 +-- > 1 file changed, 1

Re: [Qemu-devel] [PATCH v2 1/8] exec: Move user-only watchpoint stubs inline

2019-08-29 Thread Philippe Mathieu-Daudé
On 8/29/19 1:16 AM, Richard Henderson wrote: > Let the user-only watchpoint stubs resolve to empty inline functions. > > Reviewed-by: David Hildenbrand > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > include/hw/core/cpu.h | 23 +++ > exec.c

[Qemu-devel] [PATCH v2] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-08-29 Thread Sergio Lopez
Implement the modern (v2) personality, according to the VirtIO 1.0 specification. Support for v2 among guests is not as widespread as it'd be desirable. While the Linux driver has had it for a while, support is missing, at least, from Tianocore EDK II, NetBSD and FreeBSD. For this reason, the v2

[Qemu-devel] [PATCH v3 0/4] docs: add docs about use of automatic cleanup functions

2019-08-29 Thread Daniel P . Berrangé
This is ostensibly about adding docs for the g_autofree/g_autoptr macros. As part of doing that, however, the existing HACKING doc is merged into the CODING_STYLE doc and the text is converted to rst with a table of contents. Changed in v3: - Make checkpatch.pl aware of README.rst rename

Re: [Qemu-devel] [PATCH v2 2/4] docs: merge HACKING.rst contents into CODING_STYLE.rst

2019-08-29 Thread Alex Bennée
Daniel P. Berrangé writes: > The split of information between the two docs is rather arbitary and > unclear. It is simpler for contributors if all the information is in > one file. > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Alex Bennée > --- > CODING_STYLE.rst | 296

[Qemu-devel] [PATCH v3 2/4] docs: merge HACKING.rst contents into CODING_STYLE.rst

2019-08-29 Thread Daniel P . Berrangé
The split of information between the two docs is rather arbitary and unclear. It is simpler for contributors if all the information is in one file. Signed-off-by: Daniel P. Berrangé --- CODING_STYLE.rst | 296 ++ HACKING.rst | 300

Re: [Qemu-devel] [PATCH v1 0/9] arm semih-hosting cleanups and other misc cleanups

2019-08-29 Thread Philippe Mathieu-Daudé
On 8/28/19 6:52 PM, Alex Bennée wrote: > Hi Peter, > > Here are the ARM semi-hosting cleanup patches and a small selection of > miscellaneous TCG clean-ups. If your happy taking them all through > your tree please do otherwise I'll poke Richard. I'm just trying to > reduce the delta for my next

[Qemu-devel] [PATCH v7 10/10] linux-user: dumping hot TBs at the end of the execution

2019-08-29 Thread vandersonmr
dumps, in linux-user mode, the hottest TBs if -d tb_stats is used. Example of output for the 3 hottest TBs: TB id:1 | phys:0x34d54 virt:0x00034d54 flags:0xf0 | exec:4828932/0 guest inst cov:16.38% | trans:1 ints: g:3 op:82 op_opt:34 spills:3 | h/g (host bytes

[Qemu-devel] [PATCH v7 08/10] Adding info [tb-list|tb|coverset] commands to HMP.

2019-08-29 Thread vandersonmr
These commands allow the exploration of TBs generated by the TCG. Understand which one hotter, with more guest/host instructions... and examine their guest, host and IR code. The goal of this command is to allow the dynamic exploration of TCG behavior and code quality. Therefore, for now, a

[Qemu-devel] [PATCH v3 4/4] docs: split the CODING_STYLE doc into distinct groups

2019-08-29 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- CODING_STYLE.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/CODING_STYLE.rst b/CODING_STYLE.rst index 39397f0f6f..427699e0e4 100644 --- a/CODING_STYLE.rst +++ b/CODING_STYLE.rst @@ -7,6 +7,9 @@ QEMU Coding Style Please use the script

Re: [Qemu-devel] [PATCH v2 1/4] docs: convert README, CODING_STYLE and HACKING to RST syntax

2019-08-29 Thread Alex Bennée
Daniel P. Berrangé writes: > Signed-off-by: Daniel P. Berrangé Reviewed-by: Alex Bennée > --- > CODING_STYLE => CODING_STYLE.rst | 121 +++--- > HACKING => HACKING.rst | 123 +-- > README => README.rst | 47

[Qemu-devel] [PATCH v7 09/10] monitor: adding new info cfg command

2019-08-29 Thread vandersonmr
Adding "info cfg id depth" commands to HMP. This command allow the exploration a TB neighbors by dumping [and opening] a .dot file with the TB CFG neighbors colorized by their hotness. The goal of this command is to allow the dynamic exploration of TCG behavior and code quality. Therefore, for

[Qemu-devel] [PATCH v3 3/4] docs: document use of automatic cleanup functions in glib

2019-08-29 Thread Daniel P . Berrangé
Document the use of g_autofree and g_autoptr in glib for automatic freeing of memory. Signed-off-by: Daniel P. Berrangé --- CODING_STYLE.rst | 85 1 file changed, 85 insertions(+) diff --git a/CODING_STYLE.rst b/CODING_STYLE.rst index

[Qemu-devel] [PATCH v7 06/10] monitor: adding tb_stats hmp command

2019-08-29 Thread vandersonmr
Adding tb_stats [start|pause|stop|filter] command to hmp. This allows controlling the collection of statistics. It is also possible to set the level of collection: all, jit, or exec. tb_stats filter allow to only collect statistics for the TB in the last_search list. The goal of this command is

[Qemu-devel] [PATCH v3 1/4] docs: convert README, CODING_STYLE and HACKING to RST syntax

2019-08-29 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- CODING_STYLE => CODING_STYLE.rst | 121 +++--- HACKING => HACKING.rst | 123 +-- README => README.rst | 47 +++- scripts/checkpatch.pl| 2 +- 4 files changed,

[Qemu-devel] [PATCH v7 03/10] accel: replacing part of CONFIG_PROFILER with TBStats

2019-08-29 Thread vandersonmr
We add some of the statistics collected in the TCGProfiler into the TBStats, having the statistics not only for the whole emulation but for each TB. Then, we removed these stats from TCGProfiler and reconstruct the information for the "info jit" using the sum of all TBStats statistics. The goal

[Qemu-devel] [PATCH v7 07/10] Adding tb_stats [start|pause|stop|filter] command to hmp.

2019-08-29 Thread vandersonmr
This allows controlling the collection of statistics. It is also possible to set the level of collection: all, jit, or exec. tb_stats filter allow to only collect statistics for the TB in the last_search list. The goal of this command is to allow the dynamic exploration of the TCG behavior and

[Qemu-devel] [PATCH v7 02/10] accel: collecting JIT statistics

2019-08-29 Thread vandersonmr
If a TB has a TBS (TBStatistics) with the TB_JIT_STATS enabled then we collect statistics of its translation processes and code translation. Collecting the number of host instructions seems to be not simple as it would imply in having to modify several target source files. So, for now, we are

[Qemu-devel] [PATCH v7 05/10] Adding -d tb_stats to control TBStatistics collection:

2019-08-29 Thread vandersonmr
-d tb_stats[[,level=(+all+jit+exec+time)][,dump_limit=]] "dump_limit" is used to limit the number of dumped TBStats in linux-user mode. [all+jit+exec+time] control the profilling level used by the TBStats. Can be used as follow: -d tb_stats -d tb_stats,level=jit+time -d tb_stats,dump_limit=15

[Qemu-devel] [PATCH v7 00/10] Measure Tiny Code Generation Quality

2019-08-29 Thread vandersonmr
This patch is part of Google Summer of Code (GSoC) 2019. More about the project can be found in: https://wiki.qemu.org/Internships/ProjectIdeas/TCGCodeQuality The goal of this patch is to add infrastructure to collect execution and JIT statistics during the emulation with accel/TCG. The

[Qemu-devel] [PATCH v7 04/10] accel: adding TB_JIT_TIME and full replacing CONFIG_PROFILER

2019-08-29 Thread vandersonmr
Replace all others CONFIG_PROFILER statistics and migrate it to TBStatistics system. However, TCGProfiler still exists and can be use to store global statistics and times. All TB related statistics goes to TBStatistics. Signed-off-by: Vanderson M. do Rosario --- accel/tcg/tb-stats.c | 91

[Qemu-devel] [PATCH v7 01/10] accel: collecting TB execution count

2019-08-29 Thread vandersonmr
If a TB has a TBS (TBStatistics) with the TB_EXEC_STATS enabled, then we instrument the start code of this TB to atomically count the number of times it is executed. We count both the number of "normal" executions and atomic executions of a TB. The execution count of the TB is stored in its

Re: [Qemu-devel] [PATCH v3 56/69] target/arm: Convert T16, extract

2019-08-29 Thread Philippe Mathieu-Daudé
On 8/28/19 9:04 PM, Richard Henderson wrote: > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/translate.c | 14 +- > target/arm/t16.decode | 10 ++ > 2 files changed, 11 insertions(+), 13 deletions(-)

Re: [Qemu-devel] [libvirt] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-29 Thread Christophe de Dinechin
Markus Armbruster writes: > Peter Krempa writes: > [...] >> From my experience users report non-fatal messages mostly only if it is >> spamming the system log. One of instances are very unlikely to be >> noticed. >> >> In my experience it's better to notify us in libvirt of such change and >>

Re: [Qemu-devel] [PATCH v3 64/69] target/arm: Convert T16, shift immediate

2019-08-29 Thread Philippe Mathieu-Daudé
On 8/28/19 9:04 PM, Richard Henderson wrote: > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/translate.c | 26 ++ > target/arm/t16.decode | 8 > 2 files changed, 10 insertions(+), 24

Re: [Qemu-devel] [PATCH v2 0/4] docs: add docs about use of automatic cleanup functions

2019-08-29 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190829160710.8792-1-berra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190829160710.8792-1-berra...@redhat.com Type: series Subject: [Qemu-devel] [PATCH v2 0/4] docs: add

Re: [Qemu-devel] [PATCH v3 35/69] target/arm: Convert Clear-Exclusive, Barriers

2019-08-29 Thread Philippe Mathieu-Daudé
On 8/28/19 9:04 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > v3: Check m-profile for all; fix missing isa check for ISB; > fix thumb isa check for CLREX and DSB. > --- > target/arm/translate.c | 127 --- >

Re: [Qemu-devel] [PATCH v6 1/4] 9p: Treat multiple devices on one export as an error

2019-08-29 Thread Greg Kurz
On Thu, 22 Aug 2019 21:28:19 +0200 Christian Schoenebeck via Qemu-devel wrote: > The QID path should uniquely identify a file. However, the > inode of a file is currently used as the QID path, which > on its own only uniquely identifies files within a device. > Here we track the device hosting

Re: [Qemu-devel] [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-29 Thread Laszlo Ersek
On 08/28/19 14:01, Igor Mammedov wrote: > On Tue, 27 Aug 2019 22:11:15 +0200 > Laszlo Ersek wrote: > >> On 08/27/19 18:23, Igor Mammedov wrote: >>> On Mon, 26 Aug 2019 17:30:43 +0200 >>> Laszlo Ersek wrote: >>> On 08/23/19 17:25, Kinney, Michael D wrote: > Hi Jiewen, > > If a

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 0/7] tcg: probe_write() refactorings

2019-08-29 Thread Richard Henderson
> On 8/27/19 9:09 AM, David Hildenbrand wrote: >> Richard, in case there is no more feedback, will you take these patches >> via your tree? Queued to tcg-next. r~

Re: [Qemu-devel] [PATCH] qga: add command guest-get-devices for reporting VirtIO devices

2019-08-29 Thread Eric Blake
On 8/29/19 11:03 AM, Tomáš Golembiovský wrote: > Add command for reporting devices on Windows guest. The intent is not so > much to report the devices but more importantly the driver (and its > version) that is assigned to the device. > > Signed-off-by: Tomáš Golembiovský > +++

Re: [Qemu-devel] git.qemu.org gitweb misrenders on git/ URLs

2019-08-29 Thread Andrea Bolognani
On Thu, 2019-08-29 at 16:48 +0100, Stefan Hajnoczi wrote: > Hi Jeff, > Philippe noticed that the git HTTPS clone URL > https://git.qemu.org/git/libslirp.git renders a gitweb page that looks > right but has broken links. The correct gitweb URL listed on > https://git.qemu.org/ is

[Qemu-devel] [PATCH v2 4/4] docs: split the CODING_STYLE doc into distinct groups

2019-08-29 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- CODING_STYLE.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/CODING_STYLE.rst b/CODING_STYLE.rst index 39397f0f6f..427699e0e4 100644 --- a/CODING_STYLE.rst +++ b/CODING_STYLE.rst @@ -7,6 +7,9 @@ QEMU Coding Style Please use the script

[Qemu-devel] [PATCH v2 3/4] docs: document use of automatic cleanup functions in glib

2019-08-29 Thread Daniel P . Berrangé
Document the use of g_autofree and g_autoptr in glib for automatic freeing of memory. Signed-off-by: Daniel P. Berrangé --- CODING_STYLE.rst | 85 1 file changed, 85 insertions(+) diff --git a/CODING_STYLE.rst b/CODING_STYLE.rst index

[Qemu-devel] [PATCH v2 2/4] docs: merge HACKING.rst contents into CODING_STYLE.rst

2019-08-29 Thread Daniel P . Berrangé
The split of information between the two docs is rather arbitary and unclear. It is simpler for contributors if all the information is in one file. Signed-off-by: Daniel P. Berrangé --- CODING_STYLE.rst | 296 ++ HACKING.rst | 300

Re: [Qemu-devel] [PATCH 0/2] git.orderfile: Order Python/shell scripts before unordered files

2019-08-29 Thread Philippe Mathieu-Daudé
Oops Cc'ing qemu-triv...@nongnu.org On 8/29/19 12:05 PM, Philippe Mathieu-Daudé wrote: > This series update the git.orderfile to order Python and shell > scripts before unordered files. > This is particularly useful for changes in tests/qemu-iotests. > > Regards, > > Phil. > > Philippe

[Qemu-devel] [PATCH v2 0/4] docs: add docs about use of automatic cleanup functions

2019-08-29 Thread Daniel P . Berrangé
This is ostensibly about adding docs for the g_autofree/g_autoptr macros. As part of doing that, however, the existing HACKING doc is merged into the CODING_STYLE doc and the text is converted to rst with a table of contents. Changed in v2: - Use RST instead of markdown - Also convert README

[Qemu-devel] [PATCH v2 1/4] docs: convert README, CODING_STYLE and HACKING to RST syntax

2019-08-29 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- CODING_STYLE => CODING_STYLE.rst | 121 +++--- HACKING => HACKING.rst | 123 +-- README => README.rst | 47 +++- 3 files changed, 190 insertions(+), 101 deletions(-) rename

[Qemu-devel] [PATCH] qga: add command guest-get-devices for reporting VirtIO devices

2019-08-29 Thread Tomáš Golembiovský
Add command for reporting devices on Windows guest. The intent is not so much to report the devices but more importantly the driver (and its version) that is assigned to the device. Signed-off-by: Tomáš Golembiovský --- qga/commands-posix.c | 11 +++ qga/commands-win32.c | 195

  1   2   3   >