[PULL 35/41] hw/arm/exynos4210: Use the Samsung s3c SDHCI controller

2019-10-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé The Exynos SoC has specific SDHCI registers. Use the s3c SDHCI model which handle these specific registers. This silents the following "SDHC ... not implemented" warnings so we can focus on the important registers missing: $ qemu-system-arm ... -d unimp \

[PULL 33/41] hw/sd/sdhci: Add a comment to distinct the i.MX eSDHC functions

2019-10-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé This file keeps the various QDev blocks separated by comments. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cleber Rosa Message-id: 20191005154748.21718-3-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/sdhci.c | 3 ++- 1 file changed, 2

[PULL 19/41] target/arm: Hoist XSCALE_CPAR, VECLEN, VECSTRIDE in cpu_get_tb_cpu_state

2019-10-22 Thread Peter Maydell
From: Richard Henderson We do not need to compute any of these values for M-profile. Further, XSCALE_CPAR overlaps VECSTRIDE so obviously the two sets must be mutually exclusive. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson Message-id:

[PULL 21/41] target/arm: Hoist computation of TBFLAG_A32.VFPEN

2019-10-22 Thread Peter Maydell
From: Richard Henderson There are 3 conditions that each enable this flag. M-profile always enables; A-profile with EL1 as AA64 always enables. Both of these conditions can easily be cached. The final condition relies on the FPEXC register which we are not prepared to cache. Reviewed-by:

[PULL 28/41] target/arm: Rebuild hflags at CPSR writes

2019-10-22 Thread Peter Maydell
From: Richard Henderson Continue setting, but not relying upon, env->hflags. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson Message-id: 20191018174431.1784-19-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/op_helper.c | 3 +++ 1 file changed, 3

[PULL 30/41] target/arm: Rebuild hflags for M-profile

2019-10-22 Thread Peter Maydell
From: Richard Henderson Continue setting, but not relying upon, env->hflags. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson Message-id: 20191018174431.1784-21-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/m_helper.c | 6 ++ target/arm/translate.c |

[PULL 18/41] target/arm: Split out rebuild_hflags_aprofile

2019-10-22 Thread Peter Maydell
From: Richard Henderson Create a function to compute the values of the TBFLAG_ANY bits that will be cached, and are used by A-profile. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson Message-id: 20191018174431.1784-9-richard.hender...@linaro.org Signed-off-by: Peter Maydell ---

[PULL 13/41] target/arm: Split out rebuild_hflags_common_32

2019-10-22 Thread Peter Maydell
From: Richard Henderson Create a function to compute the values of the TBFLAG_A32 bits that will be cached, and are used by all profiles. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson Message-id: 20191018174431.1784-4-richard.hender...@linaro.org Signed-off-by: Peter Maydell ---

[PULL 15/41] target/arm: Split out rebuild_hflags_m32

2019-10-22 Thread Peter Maydell
From: Richard Henderson Create a function to compute the values of the TBFLAG_A32 bits that will be cached, and are used by M-profile. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson Message-id: 20191018174431.1784-6-richard.hender...@linaro.org Signed-off-by: Peter Maydell ---

[PULL 27/41] target/arm: Rebuild hflags at MSR writes

2019-10-22 Thread Peter Maydell
From: Richard Henderson Continue setting, but not relying upon, env->hflags. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson Message-id: 20191018174431.1784-18-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/translate-a64.c | 13 +++--

[PULL 12/41] target/arm: Split out rebuild_hflags_a64

2019-10-22 Thread Peter Maydell
From: Richard Henderson Create a function to compute the values of the TBFLAG_A64 bits that will be cached. For now, the env->hflags variable is not used, and the results are fed back to cpu_get_tb_cpu_state. Note that not all BTI related flags are cached, so we have to test the BTI feature

[PULL 17/41] target/arm: Split out rebuild_hflags_a32

2019-10-22 Thread Peter Maydell
From: Richard Henderson Currently a trivial wrapper for rebuild_hflags_common_32. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson Message-id: 20191018174431.1784-8-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper.c | 8 +++- 1 file changed, 7

[PULL 14/41] target/arm: Split arm_cpu_data_is_big_endian

2019-10-22 Thread Peter Maydell
From: Richard Henderson Set TBFLAG_ANY.BE_DATA in rebuild_hflags_common_32 and rebuild_hflags_a64 instead of rebuild_hflags_common, where we do not need to re-test is_a64() nor re-compute the various inputs. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson Message-id:

[PULL 10/41] hw/m68k/mcf5208.c: Switch to transaction-based ptimer API

2019-10-22 Thread Peter Maydell
Switch the mcf5208 code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to create the timer. Signed-off-by: Peter Maydell

[PULL 11/41] target/arm: Split out rebuild_hflags_common

2019-10-22 Thread Peter Maydell
From: Richard Henderson Create a function to compute the values of the TBFLAG_ANY bits that will be cached. For now, the env->hflags variable is not used, and the results are fed back to cpu_get_tb_cpu_state. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson Message-id:

[PULL 06/41] hw/timer/sh_timer: Switch to transaction-based ptimer API

2019-10-22 Thread Peter Maydell
Switch the sh_timer code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to create the timer. Signed-off-by: Peter Maydell

[PULL 16/41] target/arm: Reduce tests vs M-profile in cpu_get_tb_cpu_state

2019-10-22 Thread Peter Maydell
From: Richard Henderson Hoist the computation of some TBFLAG_A32 bits that only apply to M-profile under a single test for ARM_FEATURE_M. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson Message-id: 20191018174431.1784-7-richard.hender...@linaro.org Signed-off-by: Peter Maydell ---

[PULL 08/41] hw/timer/altera_timer.c: Switch to transaction-based ptimer API

2019-10-22 Thread Peter Maydell
Switch the altera_timer code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to create the timer. Signed-off-by: Peter

[PULL 09/41] hw/watchdog/etraxfs_timer.c: Switch to transaction-based ptimer API

2019-10-22 Thread Peter Maydell
Switch the etraxfs_timer code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to create the timer. Signed-off-by: Peter

[PULL 05/41] hw/timer/puv3_ost.c: Switch to transaction-based ptimer API

2019-10-22 Thread Peter Maydell
Switch the puv3_ost code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to create the timer. Signed-off-by: Peter Maydell

[PULL 07/41] hw/timer/lm32_timer: Switch to transaction-based ptimer API

2019-10-22 Thread Peter Maydell
Switch the lm32_timer code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to create the ytimer. Signed-off-by: Peter Maydell

[PULL 03/41] hw/timer/exynos4210_mct: Initialize ptimer before starting it

2019-10-22 Thread Peter Maydell
From: Guenter Roeck When booting a recent Linux kernel, the qemu message "Timer with delta zero, disabling" is seen, apparently because a ptimer is started before being initialized. Fix the problem by initializing the offending ptimer before starting it. The bug is effectively harmless in the

[PULL 04/41] hw/timer/arm_mptimer.c: Undo accidental rename of arm_mptimer_init()

2019-10-22 Thread Peter Maydell
In commit b01422622b we did an automated rename of the ptimer_init() function to ptimer_init_with_bh(). Unfortunately this caught the unrelated arm_mptimer_init() function. Undo that accidental renaming. Fixes: b01422622b7c7293196fdaf1dbb4f495af44ecf9 Signed-off-by: Peter Maydell Reviewed-by:

[PULL 00/41] target-arm queue

2019-10-22 Thread Peter Maydell
-22 12:03:03 +0100) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20191022 for you to fetch changes up to 833043a060f7d0e95ded88e61e992466305c0345: hw/arm/digic4: Inline digic4_board_setup_ram() function (2019-10-22 14:21:57

[PULL 02/41] aspeed: Add an AST2600 eval board

2019-10-22 Thread Peter Maydell
From: Cédric Le Goater Define the board with 1 GiB of RAM but some boards can have up to 2 GiB. Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley Message-id: 20191016090745.15334-1-...@kaod.org Signed-off-by: Peter Maydell --- include/hw/arm/aspeed.h | 1 + hw/arm/aspeed.c

[PULL 01/41] target/arm: Fix sign-extension for SMLAL*

2019-10-22 Thread Peter Maydell
From: Richard Henderson The 32-bit product should be sign-extended, not zero-extended. Fixes: ea96b374641b Reported-by: Laurent Desnogues Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Tested-by: Laurent Desnogues Message-id:

Re: [PATCH v3 0/6] Enable more iotests during "make check-block"

2019-10-22 Thread Alex Bennée
Thomas Huth writes: > As discussed here: > > https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg00697.html > > and here: > > https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg01388.html Queued to testing/next, thanks. > > it would be good to have some more valuable iotests

Re: [PATCH] blockdev: modify blockdev-change-medium to change non-removable device

2019-10-22 Thread Denis Plotnikov
On 22.10.2019 16:18, Max Reitz wrote: > On 22.10.19 14:53, Denis Plotnikov wrote: >> On 22.10.2019 14:05, Max Reitz wrote: >>> On 21.10.19 08:50, Denis Plotnikov wrote: On 18.10.2019 18:02, Max Reitz wrote: > On 18.10.19 14:09, Denis Plotnikov wrote: >> The modification is useful to

Re: [PATCH] blockdev: modify blockdev-change-medium to change non-removable device

2019-10-22 Thread Max Reitz
On 22.10.19 14:53, Denis Plotnikov wrote: > > On 22.10.2019 14:05, Max Reitz wrote: >> On 21.10.19 08:50, Denis Plotnikov wrote: >>> On 18.10.2019 18:02, Max Reitz wrote: On 18.10.19 14:09, Denis Plotnikov wrote: > The modification is useful to workaround exclusive file access >

Re: [PATCH v14 1/9] esp: add pseudo-DMA as used by Macintosh

2019-10-22 Thread Laurent Vivier
Le 22/10/2019 à 14:21, Philippe Mathieu-Daudé a écrit : > Hi Laurent, > > On 10/22/19 1:17 PM, Laurent Vivier wrote: >> There is no DMA in Quadra 800, so the CPU reads/writes the data from the >> PDMA register (offset 0x100, ESP_PDMA in hw/m68k/q800.c) and copies them >> to/from the memory. >> >>

Re: [PATCH v3 0/6] Enable more iotests during "make check-block"

2019-10-22 Thread Alex Bennée
Thomas Huth writes: > On 22/10/2019 13.39, Alex Bennée wrote: >> >> Thomas Huth writes: >> >>> On 22/10/2019 09.21, Thomas Huth wrote: As discussed here: https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg00697.html and here:

Re: Python 2 and test/vm/netbsd

2019-10-22 Thread Samuel Thibault
Eduardo Habkost, le ven. 18 oct. 2019 13:41:43 -0300, a ecrit: > On Fri, Oct 18, 2019 at 06:00:19PM +0200, Samuel Thibault wrote: > > It was implemented at the time of introduction of IPv6 in SLIRP. Perhaps > > NetBSD has a slightly different behavior which makes the implementation > > fail to

Re: [PATCH v2 0/6] hw/arm: Create the RAM in the board

2019-10-22 Thread Peter Maydell
On Mon, 21 Oct 2019 at 20:07, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > This series contains the ARM patches extracted from the > "Let the machine be the owner of the system memory" series [1] > reviewed by Richard. > > These are cleanups moving the creation of the system ram at > the board

Re: Python 2 and test/vm/netbsd

2019-10-22 Thread Kamil Rytarowski
On 22.10.2019 15:16, Samuel Thibault wrote: > Eduardo Habkost, le ven. 18 oct. 2019 13:41:43 -0300, a ecrit: >> On Fri, Oct 18, 2019 at 06:00:19PM +0200, Samuel Thibault wrote: >>> It was implemented at the time of introduction of IPv6 in SLIRP. Perhaps >>> NetBSD has a slightly different behavior

[PATCH v2 09/10] nbd/server: use bdrv_dirty_bitmap_next_dirty_area

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
Use bdrv_dirty_bitmap_next_dirty_area for bitmap_to_extents. Since bdrv_dirty_bitmap_next_dirty_area is very accurate in its interface, we'll never exceed requested region with last chunk. So, we don't need dont_fragment, and bitmap_to_extents() interface becomes clean enough to not require any

[PATCH v2 00/10] Further bitmaps improvements

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
Hi! The main feature here is improvement of _next_dirty_area API, which I'm going to use then for backup / block-copy. v2: 01: just use INT64_MAX instead of adding new constant 08: add separate function nbd_extent_array_convert_to_be and converted state of NBDExtentArray, to make these

[PATCH v2 06/10] block/dirty-bitmap: add _next_dirty API

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
We have bdrv_dirty_bitmap_next_zero, let's add corresponding bdrv_dirty_bitmap_next_dirty, which is more comfortable to use than bitmap iterators in some cases. For test modify test_hbitmap_next_zero_check_range to check both next_zero and next_dirty and add some new checks. Signed-off-by:

[PATCH v2 05/10] block/dirty-bitmap: switch _next_dirty_area and _next_zero to int64_t

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
We are going to introduce bdrv_dirty_bitmap_next_dirty so that same variable may be used to store its return value and to be its parameter, so it would int64_t. Similarly, we are going to refactor hbitmap_next_dirty_area to use hbitmap_next_dirty together with hbitmap_next_zero, therefore we want

[PATCH v2 08/10] nbd/server: introduce NBDExtentArray

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
Introduce NBDExtentArray class, to handle extents list creation in more controlled way and with less OUT parameters in functions. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 201 --- 1 file changed, 109 insertions(+), 92

[PATCH v2 07/10] block/dirty-bitmap: improve _next_dirty_area API

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
Firstly, _next_dirty_area is for scenarios when we may contiguously search for next dirty area inside some limited region, so it is more comfortable to specify "end" which should not be recalculated on each iteration. Secondly, mirror wants to limit resulting are, and for this thing it limits

[Bug 1846427] Re: 4.1.0: qcow2 corruption on savevm/quit/loadvm cycle

2019-10-22 Thread Kevin Wolf
> But isn't that "if" at the core of this problem? What happens if the > detection misfires? The information that a block driver must give is just whether the given block is allocated by the image or whether it is taken from the backing file. Almost everything else is just a hint that can be

[PATCH v2 02/10] hbitmap: move hbitmap_iter_next_word to hbitmap.c

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
The function is definitely internal (it's not used by third party and it has complicated interface). Move it to .c file. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/qemu/hbitmap.h | 30 -- util/hbitmap.c | 29 + 2 files

[PATCH v2 03/10] hbitmap: unpublish hbitmap_iter_skip_words

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
Function is internal and even commented as internal. Drop its definition from .h file. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/qemu/hbitmap.h | 7 --- util/hbitmap.c | 2 +- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/include/qemu/hbitmap.h

[PATCH v2 10/10] block/qcow2-bitmap: use bdrv_dirty_bitmap_next_dirty

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
store_bitmap_data() loop does bdrv_set_dirty_iter() on each iteration, which means that we actually don't need iterator itself and we can use simpler bitmap API. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 11 +-- 1 file changed, 5 insertions(+), 6

[PATCH v2 01/10] hbitmap: assert that we don't create bitmap larger than INT64_MAX

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
We have APIs which returns signed int64_t, to be able to return error. Therefore we can't handle bitmaps with absolute size larger than (INT64_MAX+1). Still, keep maximum to be INT64_MAX which is a bit safer. Note, that bitmaps are used to represent disk images, which can't exceed INT64_MAX

Re: Python 2 and test/vm/netbsd

2019-10-22 Thread Samuel Thibault
Samuel Thibault, le ven. 18 oct. 2019 18:00:19 +0200, a ecrit: > Philippe Mathieu-Daudé, le ven. 18 oct. 2019 16:58:00 +0200, a ecrit: > > On 10/18/19 4:29 PM, Eduardo Habkost wrote: > > > In addition to that, the connect() error should be generating a > > > ICMP6_UNREACH message, and I'd expect

[PATCH v2 04/10] hbitmap: drop meta bitmaps as they are unused

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/qemu/hbitmap.h | 21 tests/test-hbitmap.c | 115 - util/hbitmap.c | 16 -- 3 files changed, 152 deletions(-) diff --git a/include/qemu/hbitmap.h b/include/qemu/hbitmap.h

Re: [PATCH v5 1/4] block: support compressed write at generic layer

2019-10-22 Thread Max Reitz
On 22.10.19 14:23, Vladimir Sementsov-Ogievskiy wrote: > 22.10.2019 14:31, Max Reitz wrote: >> On 22.10.19 12:46, Vladimir Sementsov-Ogievskiy wrote: >>> 22.10.2019 13:21, Andrey Shinkevich wrote: On 22/10/2019 12:28, Max Reitz wrote: > On 20.10.19 22:37, Andrey Shinkevich wrote:

Re: [PATCH 0/5] hw/arm/exynos4210: Add acceptance tests to the SMDKC210 board

2019-10-22 Thread Peter Maydell
On Fri, 18 Oct 2019 at 15:48, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 10/5/19 5:47 PM, Philippe Mathieu-Daudé wrote: > > Philippe Mathieu-Daudé (5): > >tests/boot_linux_console: Add initrd test for the Exynos4210 > >hw/sd/sdhci: Add a comment to distinct the i.MX eSDHC

Re: [PATCH] blockdev: modify blockdev-change-medium to change non-removable device

2019-10-22 Thread Denis Plotnikov
On 22.10.2019 14:05, Max Reitz wrote: > On 21.10.19 08:50, Denis Plotnikov wrote: >> On 18.10.2019 18:02, Max Reitz wrote: >>> On 18.10.19 14:09, Denis Plotnikov wrote: The modification is useful to workaround exclusive file access restrictions, e.g. to implement VM migration with

Re: [PATCH] qemu-options.hx: Update for reboot-timeout parameter

2019-10-22 Thread Philippe Mathieu-Daudé
On 10/22/19 8:18 AM, Markus Armbruster wrote: Han Han writes: Since ee5d0f89d, -1 is not valid for the value of reboot-timeout. Update that in qemu-options doc. Signed-off-by: Han Han --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v8 00/22] target/arm: Reduce overhead of cpu_get_tb_cpu_state

2019-10-22 Thread Peter Maydell
On Fri, 18 Oct 2019 at 18:44, Richard Henderson wrote: > > Changes since v7: > * Rebuild hflags for all successful nvic writes (Peter). > * Rebuild hflags for Xscale sctlr writes (Peter). > > Changes since v6: > * Regen hflags in two more places for m-profile (patch 19). > > Changes since

Re: [PULL 0/2] Trivial branch patches

2019-10-22 Thread Peter Maydell
On Tue, 22 Oct 2019 at 09:27, Laurent Vivier wrote: > > The following changes since commit e9d42461920f6f40f4d847a5ba18e90d095ed0b9: > > Merge remote-tracking branch > 'remotes/kraxel/tags/audio-20191018-pull-request' into staging (2019-10-18 > 14:13:11 +0100) > > are available in the Git

Re: [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-10-22 Thread Laszlo Ersek
On 10/21/19 15:06, Laszlo Ersek wrote: > On 10/18/19 18:18, Igor Mammedov wrote: >> On Thu, 10 Oct 2019 16:56:18 +0200 >> Laszlo Ersek wrote: [...] >>> Can I use the following sequence to detect whether the interface is >>> available? >>> >>> 1. Store 0x0 to command register. >>> 2. Store 0x0

[PULL v2 00/12] QAPI patches for 2019-10-22

2019-10-22 Thread Markus Armbruster
The following changes since commit e9d42461920f6f40f4d847a5ba18e90d095ed0b9: Merge remote-tracking branch 'remotes/kraxel/tags/audio-20191018-pull-request' into staging (2019-10-18 14:13:11 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git

Re: [PATCH v5 1/4] block: support compressed write at generic layer

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
22.10.2019 14:31, Max Reitz wrote: > On 22.10.19 12:46, Vladimir Sementsov-Ogievskiy wrote: >> 22.10.2019 13:21, Andrey Shinkevich wrote: >>> >>> On 22/10/2019 12:28, Max Reitz wrote: On 20.10.19 22:37, Andrey Shinkevich wrote: > To inform the block layer about writing all the data

Re: [PATCH v14 1/9] esp: add pseudo-DMA as used by Macintosh

2019-10-22 Thread Philippe Mathieu-Daudé
Hi Laurent, On 10/22/19 1:17 PM, Laurent Vivier wrote: There is no DMA in Quadra 800, so the CPU reads/writes the data from the PDMA register (offset 0x100, ESP_PDMA in hw/m68k/q800.c) and copies them to/from the memory. There is a nice assembly loop in the kernel to do that, see

Re: [PATCH] net: add tulip (dec21143) driver

2019-10-22 Thread Peter Maydell
On Tue, 22 Oct 2019 at 04:30, Jason Wang wrote: > > > On 2019/10/20 上午1:38, Sven Schnelle wrote: > > This adds the basic functionality to emulate a Tulip NIC. > > > > Implemented are: > > > > - RX and TX functionality > > - Perfect Frame Filtering > > - Big/Little Endian descriptor support > > -

Re: [PATCH] net: add tulip (dec21143) driver

2019-10-22 Thread Peter Maydell
On Sat, 19 Oct 2019 at 18:40, Sven Schnelle wrote: > > This adds the basic functionality to emulate a Tulip NIC. > > Implemented are: > > - RX and TX functionality > - Perfect Frame Filtering > - Big/Little Endian descriptor support > - 93C46 EEPROM support > - LXT970 PHY > > Not implemented,

Re: [PATCH v33 01/13] target/avr: Add outward facing interfaces and core CPU logic

2019-10-22 Thread Aleksandar Markovic
On Tuesday, October 22, 2019, Michael Rolnik wrote: > This includes: > - CPU data structures > - object model classes and functions > - migration functions > - GDB hooks > > Co-developed-by: Michael Rolnik > Co-developed-by: Sarah Harris > Signed-off-by: Michael Rolnik > Signed-off-by: Sarah

Re: [PATCH v33 01/13] target/avr: Add outward facing interfaces and core CPU logic

2019-10-22 Thread Aleksandar Markovic
On Tuesday, October 22, 2019, Michael Rolnik wrote: > This includes: > - CPU data structures > - object model classes and functions > - migration functions > - GDB hooks > > Co-developed-by: Michael Rolnik > Co-developed-by: Sarah Harris > Signed-off-by: Michael Rolnik > Signed-off-by: Sarah

Re: [PATCH v3 0/6] Enable more iotests during "make check-block"

2019-10-22 Thread Thomas Huth
On 22/10/2019 13.39, Alex Bennée wrote: > > Thomas Huth writes: > >> On 22/10/2019 09.21, Thomas Huth wrote: >>> As discussed here: >>> >>> https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg00697.html >>> >>> and here: >>> >>>

Re: [PATCH v3 3/4] ppc: reset the interrupt presenter from the CPU reset handler

2019-10-22 Thread Cédric Le Goater
On 22/10/2019 11:08, Philippe Mathieu-Daudé wrote: > Hi Cédric, > > On 10/22/19 9:22 AM, Cédric Le Goater wrote: >> On the sPAPR machine and PowerNV machine, the interrupt presenters are >> created by a machine handler at the core level and are reseted > > Typo "reset" > >> independently. This

Re: [PATCH v33 00/13] QEMU AVR 8 bit cores

2019-10-22 Thread Michael Rolnik
this revision has a bug, flag C is not calculated correctly. On Tue, Oct 22, 2019 at 1:37 AM Michael Rolnik wrote: > > This series of patches adds 8bit AVR cores to QEMU. > All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully tested > yet. > However I was able to execute

Re: [PATCH v2] hw/m68k/mcf5206.c: Switch to transaction-based ptimer API

2019-10-22 Thread Thomas Huth
On 21/10/2019 16.06, Peter Maydell wrote: > Switch the mcf5206 code away from bottom-half based ptimers to > the new transaction-based ptimer API. This just requires adding > begin/commit calls around the various places that modify the ptimer > state, and using the new ptimer_init() function to

Re: [PATCH v3 0/6] Enable more iotests during "make check-block"

2019-10-22 Thread Alex Bennée
Thomas Huth writes: > On 22/10/2019 09.21, Thomas Huth wrote: >> As discussed here: >> >> https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg00697.html >> >> and here: >> >> https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg01388.html >> >> it would be good to have some more

Re: [PATCH for 4.2 v6 00/54] Support for TCG plugins

2019-10-22 Thread Alex Bennée
Alex Bennée writes: > Hi, > > This is the latest iteration of the TCG plugins series. From the > documentation: > > QEMU TCG plugins provide a way for users to run experiments taking > advantage of the total system control emulation can have over a guest. > It provides a mechanism for

Re: [PATCH v13 00/12] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

2019-10-22 Thread Markus Armbruster
I just stumbled over this series. It touches the QAPI visitors and even the generator, without cc'ing its maintainers. Such changes require review. There's precious little time until the soft freeze now. I'll try, but no promises. Please cc me and Michael Roth on future revisions. In

[PATCH v14 5/9] hw/m68k: add Nubus support

2019-10-22 Thread Laurent Vivier
This patch adds basic support for the NuBus bus. This is used by 680x0 Macintosh. Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Thomas Huth --- include/hw/nubus/mac-nubus-bridge.h | 24 include/hw/nubus/nubus.h|

[PATCH v14 9/9] BootLinuxConsoleTest: Test the Quadra 800

2019-10-22 Thread Laurent Vivier
From: Philippe Mathieu-Daudé This test boots a Linux kernel on a Quadra 800 board and verify the serial is working. Example: $ avocado --show=app,console run -t machine:q800 tests/acceptance/boot_linux_console.py console: ABCFGHIJK console: Linux version 5.2.0-2-m68k

Re: [PATCH v2 3/6] ps2: accept 'Set Key Make and Break' commands

2019-10-22 Thread Sven Schnelle
Hi Philippe, On Tue, Oct 22, 2019 at 11:50:14AM +0200, Philippe Mathieu-Daudé wrote: > On 10/22/19 7:54 AM, Sven Schnelle wrote: > > HP-UX sends both the 'Set key make and break (0xfc) and > > 'Set all key typematic make and break' (0xfa). QEMU response > > with 'Resend' as it doesn't handle

[PATCH v14 3/9] hw/m68k: add VIA support

2019-10-22 Thread Laurent Vivier
Inside the 680x0 Macintosh, VIA (Versatile Interface Adapter) is used to interface the keyboard, Mouse, and real-time clock. It also provides control line for the floppy disk driver, video interface, sound circuitry and serial interface. This implementation is based on the MOS6522 object.

Re: [PATCH v5 1/4] block: support compressed write at generic layer

2019-10-22 Thread Max Reitz
On 22.10.19 12:46, Vladimir Sementsov-Ogievskiy wrote: > 22.10.2019 13:21, Andrey Shinkevich wrote: >> >> On 22/10/2019 12:28, Max Reitz wrote: >>> On 20.10.19 22:37, Andrey Shinkevich wrote: To inform the block layer about writing all the data compressed, we introduce the 'compress'

[PATCH v14 1/9] esp: add pseudo-DMA as used by Macintosh

2019-10-22 Thread Laurent Vivier
There is no DMA in Quadra 800, so the CPU reads/writes the data from the PDMA register (offset 0x100, ESP_PDMA in hw/m68k/q800.c) and copies them to/from the memory. There is a nice assembly loop in the kernel to do that, see linux/drivers/scsi/mac_esp.c:MAC_ESP_PDMA_LOOP(). The start of the

Re: [PATCH 5/5] travis.yml: Compile on arm64, too

2019-10-22 Thread Thomas Huth
On 22/10/2019 12.41, Alex Bennée wrote: > > Thomas Huth writes: > >> Travis now features an arm64 build host, so let's check compilation >> there, too. >> >> Unfortunately, there are some quirks: >> - block/ssh.c does not compile properly in this environment, so we have >> to use

Re: [PATCH v3 4/4] spapr/xive: Set the OS CAM line at reset

2019-10-22 Thread Greg Kurz
On Tue, 22 Oct 2019 09:22:46 +0200 Cédric Le Goater wrote: > When a Virtual Processor is scheduled to run on a HW thread, the > hypervisor pushes its identifier in the OS CAM line. When running with > kernel_irqchip=off, QEMU needs to emulate the same behavior. > > Set the OS CAM line when the

[PATCH v3 2/6] block/block-copy: limit copy_range_size to 16 MiB

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
Large copy range may imply memory allocation and large io effort, so using 2G copy range request may be bad idea. Let's limit it to 16 MiB. It also helps the following patch to refactor copy-with-offload fallback to copy-with-bounce-buffer. Note, that total memory usage of backup is still not

[PATCH v14 8/9] hw/m68k: define Macintosh Quadra 800

2019-10-22 Thread Laurent Vivier
If you want to test the machine, it doesn't yet boot a MacROM, but you can boot a linux kernel from the command line. You can install your own disk using debian-installer with: ./qemu-system-m68k \ -M q800 \ -serial none -serial mon:stdio \ -m 1000M -drive

Re: [PATCH v3 3/4] ppc: reset the interrupt presenter from the CPU reset handler

2019-10-22 Thread Greg Kurz
On Tue, 22 Oct 2019 09:22:45 +0200 Cédric Le Goater wrote: > On the sPAPR machine and PowerNV machine, the interrupt presenters are > created by a machine handler at the core level and are reseted > independently. This is not consistent and it raises issues when it > comes to handle hot-plugged

[PATCH v14 2/9] dp8393x: manage big endian bus

2019-10-22 Thread Laurent Vivier
This is needed by Quadra 800, this card can run on little-endian or big-endian bus. Signed-off-by: Laurent Vivier Tested-by: Hervé Poussineau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Hervé Poussineau --- hw/net/dp8393x.c | 88 +++- 1 file

[PATCH v3 3/6] block/block-copy: refactor copying

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
Merge copying code into one function block_copy_do_copy, which only calls bdrv_ io functions and don't do any synchronization (like dirty bitmap set/reset). Refactor block_copy() function so that it takes full decision about size of chunk to be copied and does all the synchronization (checking

[PATCH v14 7/9] hw/m68k: add a dummy SWIM floppy controller

2019-10-22 Thread Laurent Vivier
SWIM (Sander-Wozniak Integrated Machine) is the floppy controller of the 680x0 Macintosh. This patch introduces only the basic support: it allows to switch from IWM (Integrated WOZ Machine) mode to the SWIM mode and makes the linux driver happy. It cannot read any floppy image. Co-developed-by:

[PATCH v3 4/6] util: introduce SharedResource

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
Introduce an API for some shared splittable resource, like memory. It's going to be used by backup. Backup uses both read/write io and copy_range. copy_range may consume memory implictly, so the new API is abstract: it doesn't allocate any real memory but only hands out tickets. The idea is that

[PATCH v14 4/9] hw/m68k: implement ADB bus support for via

2019-10-22 Thread Laurent Vivier
VIA needs to be able to poll the ADB interface and to read/write data from/to the bus. This patch adds functions allowing that. Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau Reviewed-by: Thomas Huth ---

[PATCH v14 6/9] hw/m68k: add Nubus macfb video card

2019-10-22 Thread Laurent Vivier
This patch adds support for a graphic framebuffer device. This device can be added as a sysbus device or as a NuBus device. It is accessed as a framebuffer but the color palette can be set. Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier

[PATCH v3 6/6] block/block-copy: increase buffered copy request

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
No reason to limit buffered copy to one cluster. Let's allow up to 1 MiB. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- include/block/block-copy.h | 2 +- block/block-copy.c | 48 +- 2 files changed, 33 insertions(+), 17

[PATCH v3 5/6] block/block-copy: add memory limit

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
Currently total allocation for parallel requests to block-copy instance is unlimited. Let's limit it to 128 MiB. For now block-copy is used only in backup, so actually we limit total allocation for backup job. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz ---

[PATCH v3 1/6] block/block-copy: allocate buffer in block_copy_with_bounce_buffer

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
Move bounce_buffer allocation block_copy_with_bounce_buffer. This commit simplifies further work on implementing copying by larger chunks (of different size) and further asynchronous handling of block_copy iterations (with help of block/aio_task API). Allocation works fast, a lot faster than disk

[PATCH v14 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

2019-10-22 Thread Laurent Vivier
I'm rebasing some of these patches for seven years now, too many years... if you want to test the machine, I'm sorry, it doesn't boot a MacROM, but you can boot a linux kernel from the command line. You can install your own disk using debian-installer, with: ... -M q800 \ -serial

[PATCH v3 0/6] block-copy: memory limit

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
I'm going to bring block-status driven, async copying process to block-copy, to make it fast. The first step is to limit memory usage of backup, here is it. v3: 03: add Max's r-b 04: fix commit message and include guards, add Max's r-b 05-06: add Max's r-b v2: [mostly by Max's comments] Now

Re: [PATCH 17/30] virtiofsd: Add main virtio loop

2019-10-22 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > On Mon, Oct 21, 2019 at 1:26 PM Dr. David Alan Gilbert (git) > wrote: > > > > From: "Dr. David Alan Gilbert" > > > > Processes incoming requests on the vhost-user fd. > > Is there a reason to avoid using glib & its main loop? Not

Re: [PATCH] runstate: ignore exit request in finish migrate state

2019-10-22 Thread Paolo Bonzini
On 17/10/19 12:18, Laurent Vivier wrote: > Trying to reboot a VM while a migration is running can > move to the prelaunch state (because of the reset) while > the runstate is in finish migrate state. > As the logical step after the finish migrate is postmigrate, > this can create an invalid state

Re: [PATCH] blockdev: modify blockdev-change-medium to change non-removable device

2019-10-22 Thread Max Reitz
On 21.10.19 08:50, Denis Plotnikov wrote: > > On 18.10.2019 18:02, Max Reitz wrote: >> On 18.10.19 14:09, Denis Plotnikov wrote: >>> The modification is useful to workaround exclusive file access restrictions, >>> e.g. to implement VM migration with shared disk stored on a storage with >>> the

Re: [PULL 00/11] Linux user for 4.2 patches

2019-10-22 Thread Peter Maydell
On Tue, 22 Oct 2019 at 09:20, Laurent Vivier wrote: > > The following changes since commit e9d42461920f6f40f4d847a5ba18e90d095ed0b9: > > Merge remote-tracking branch > 'remotes/kraxel/tags/audio-20191018-pull-request' into staging (2019-10-18 > 14:13:11 +0100) > > are available in the Git

Re: [PATCH] runstate: ignore exit request in finish migrate state

2019-10-22 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> On 17/10/19 12:18, Laurent Vivier wrote: >> > Trying to reboot a VM while a migration is running can >> > move to the prelaunch state (because of the reset) while >> > the runstate is in finish migrate state. >> >

Re: [PATCH v2 4/6] util: introduce SharedResource

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
22.10.2019 13:23, Max Reitz wrote: > On 16.10.19 19:09, Vladimir Sementsov-Ogievskiy wrote: >> Introduce an API for some shared splittable resource, like memory. >> It's going to be used by backup. Backup uses both read/write io and >> copy_range. copy_range may consume memory implictly, so the

Re: [PULL 00/12] QAPI patches for 2019-10-22

2019-10-22 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 22 Oct 2019 at 09:11, Markus Armbruster wrote: >> >> The following changes since commit e9d42461920f6f40f4d847a5ba18e90d095ed0b9: >> >> Merge remote-tracking branch >> 'remotes/kraxel/tags/audio-20191018-pull-request' into staging (2019-10-18 >> 14:13:11

Re: [PATCH v5 1/4] block: support compressed write at generic layer

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
22.10.2019 13:21, Andrey Shinkevich wrote: > > On 22/10/2019 12:28, Max Reitz wrote: >> On 20.10.19 22:37, Andrey Shinkevich wrote: >>> To inform the block layer about writing all the data compressed, we >>> introduce the 'compress' command line option. Based on that option, the >>> written data

Re: [PATCH 5/5] travis.yml: Compile on arm64, too

2019-10-22 Thread Alex Bennée
Thomas Huth writes: > Travis now features an arm64 build host, so let's check compilation > there, too. > > Unfortunately, there are some quirks: > - block/ssh.c does not compile properly in this environment, so we have > to use --disable-libssh until that problem is fixed. > -

Re: [PATCH v2 6/6] block/block-copy: increase buffered copy request

2019-10-22 Thread Max Reitz
On 16.10.19 19:09, Vladimir Sementsov-Ogievskiy wrote: > No reason to limit buffered copy to one cluster. Let's allow up to 1 > MiB. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/block-copy.h | 2 +- > block/block-copy.c | 48

<    1   2   3   4   5   >