On 12/11/2019 07:40, Joel Stanley wrote:
> The AST2600 control register sneakily changed the meaning of bit 4
> without anyone noticing. It no longer controls the 1MHz vs APB clock
> select, and instead always runs at 1MHz.
>
> The AST2500 was always 1MHz too, but it retained bit 4, making it
On 12/11/2019 07:40, Joel Stanley wrote:
> Users benefit from knowing which watchdog timer has expired. The address
> of the watchdog's registers unambiguously indicates which has expired,
> so log that.
>
> Signed-off-by: Joel Stanley
The format below should be using HWADDR_PRIx. No need to
Patchew URL:
https://patchew.org/QEMU/2019152808.13371-1-fran...@linux.ibm.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v2] s390x: Properly fetch the short psw on diag308 subc 0/1
Type: series
Message-id:
On 12/11/2019 07:40, Joel Stanley wrote:
> This models the clock write one to clear registers, and fixes up some
> incorrect behavior in all of the write to clear registers.
>
> There was also a typo in one of the register definitions.
>
> Signed-off-by: Joel Stanley
Reviewed-by: Cédric Le
On 12/11/2019 07:40, Joel Stanley wrote:
> Most boards have this much.
>
> Signed-off-by: Joel Stanley
Reviewed-by: Cédric Le Goater
> ---
> hw/misc/aspeed_sdmc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c
>
Hey Peter,
On 08.11.19 17:58, Peter Maydell wrote:
On Mon, 4 Nov 2019 at 11:52, Alexander Graf wrote:
The current pl031 RTCICR register implementation always clears the IRQ
pending status on a register write, regardless of the value it writes.
To justify that behavior, it references the
On Tue, Nov 12, 2019 at 02:53:49PM +1100, Alexey Kardashevskiy wrote:
> Hi!
>
> I am enabling IOMMU for virtio in the pseries firmware (SLOF) and seeing
> problems, one of them is SLOF does SCSI bus scan, then it stops the
> virtio-scsi by clearing MMIO|IO|BUSMASTER from PCI_COMMAND (as SLOF
>
Hi Peter,
the following changes since commit 654efcb511d394c1d3f5292c28503d1d19e5b1d3:
Merge remote-tracking branch 'remotes/vivier/tags/q800-branch-pull-request'
into staging (2019-11-11 09:23:46 +)
are available in the Git repository at:
https://gitlab.com/huth/qemu.git
From: Philippe Mathieu-Daudé
The EDK2 firmware blobs only target the X86/ARM architectures.
Define the DECOMPRESS_EDK2_BLOBS variable and only decompress
the blobs when the variable exists.
See also: 536d2173b2b ("roms: build edk2 firmware binaries ...")
Suggested-by: Thomas Huth
Patchew URL:
https://patchew.org/QEMU/2019135803.14414-1-peter.mayd...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PULL 0/3] target-arm queue
Type: series
Message-id:
From: "Dr. David Alan Gilbert"
We're seeing occasional asserts in 'wait_for_migraiton_fail', that
I can't reliably reproduce, and where the cores don't have any useful
state. Print the 'status' out, so we can see which unexpected state
we're ending up in.
Signed-off-by: Dr. David Alan Gilbert
From: Jan Kiszka
I haven't been doing anything here for a long time, nor does my git repo
still play a role.
Signed-off-by: Jan Kiszka
Message-Id: <759f8f44-9a01-a9f1-c7cf-65d40151a...@web.de>
Reviewed-by: Marc-André Lureau
Acked-by: Samuel Thibault
Signed-off-by: Thomas Huth
---
From: Philippe Mathieu-Daudé
The bzip2 tool is not included in default installations.
On freshly installed systems, ./configure succeeds but 'make'
might fail later:
BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2
/bin/sh: bzip2: command not found
make: *** [Makefile:305:
From: Marc-André Lureau
Spotted by ASAN.
Signed-off-by: Marc-André Lureau
Message-Id: <20191107192731.17330-4-marcandre.lur...@redhat.com>
Reviewed-by: Thomas Huth
Fixes: 021a007efc3 ("cpu-plug-test: fix device_add for pc/q35 machines")
Signed-off-by: Thomas Huth
---
tests/cpu-plug-test.c |
From: Marc-André Lureau
Spotted by ASAN.
Signed-off-by: Marc-André Lureau
Message-Id: <20191107192731.17330-3-marcandre.lur...@redhat.com>
Reviewed-by: Thomas Huth
Fixes: b4510bb4109f5f ("tests: add qtest_qmp_device_add_qdict() helper")
Signed-off-by: Thomas Huth
---
tests/libqtest.c | 1 +
The AST2600 control register sneakily changed the meaning of bit 4
without anyone noticing. It no longer controls the 1MHz vs APB clock
select, and instead always runs at 1MHz.
The AST2500 was always 1MHz too, but it retained bit 4, making it read
only. We can model both using the same fixed 1MHz
This models the clock write one to clear registers, and fixes up some
incorrect behavior in all of the write to clear registers.
There was also a typo in one of the register definitions.
Signed-off-by: Joel Stanley
---
hw/misc/aspeed_scu.c | 11 ---
1 file changed, 8 insertions(+), 3
Users benefit from knowing which watchdog timer has expired. The address
of the watchdog's registers unambiguously indicates which has expired,
so log that.
Signed-off-by: Joel Stanley
---
hw/watchdog/wdt_aspeed.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Three of these are fixes for ast2600 models that I found when testing
master. The forth is a usability improvement that is helpful when
diagnosing why a watchdog is biting.
Joel Stanley (4):
aspeed/sdmc: Make ast2600 default 1G
aspeed/scu: Fix W1C behavior
watchdog/aspeed: Improve watchdog
Most boards have this much.
Signed-off-by: Joel Stanley
---
hw/misc/aspeed_sdmc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c
index f3a63a2e01db..2df3244b53c8 100644
--- a/hw/misc/aspeed_sdmc.c
+++
> From: Peter Xu
> Sent: Wednesday, November 6, 2019 10:01 PM
> To: Liu, Yi L
> Subject: Re: [RFC v2 10/22] intel_iommu: add virtual command capability
> support
>
> On Wed, Nov 06, 2019 at 12:40:41PM +, Liu, Yi L wrote:
> > >
> > > Do you know what should happen on bare-metal from
On Tue, Nov 5, 2019 at 2:55 AM Gerd Hoffmann wrote:
> Each buffer also has some properties to carry metadata, some fixed (id, size,
> application), but
> also allow free form (name = value, framebuffers would have
> width/height/stride/format for example).
Sounds a lot like the recently added
ping
On 10/16/19 5:01 PM, Andrew Kelley wrote:
> Signed-off-by: Andrew Kelley
> ---
> linux-user/aarch64/syscall_nr.h | 13 ++
> linux-user/arm/syscall_nr.h | 38
> linux-user/i386/syscall_nr.h| 43
>
Hi!
I am enabling IOMMU for virtio in the pseries firmware (SLOF) and seeing
problems, one of them is SLOF does SCSI bus scan, then it stops the
virtio-scsi by clearing MMIO|IO|BUSMASTER from PCI_COMMAND (as SLOF
stopped using the devices) and when this happens, I see unassigned
memory access
New microcode introduces the "Flush L1D Cache" CPUID feature bit.
This needs to be exposed to guest OS to allow them to protect against
CVE-2018-3646.
Signed-off-by: Kyle Copperfield
---
docs/qemu-cpu-models.texi | 7 +++
target/i386/cpu.c | 2 +-
2 files changed, 8 insertions(+), 1
Recent git versions support worktrees where .git is not a directory but
a file with a path to the .git repository; however the get_maintainer.pl
script only recognises the .git directory, let's fix it.
Signed-off-by: Alexey Kardashevskiy
---
scripts/get_maintainer.pl | 2 +-
1 file changed, 1
On 11/11/2019 20:53, Eric Blake wrote:
> On 11/11/19 4:04 AM, Andrey Shinkevich wrote:
>> The test for an NBD client. The NBD server is disconnected after the
>> client write request. The NBD client should reconnect and complete
>> the write operation.
>>
>> Suggested-by: Denis V. Lunev
>>
The test for an NBD client. The NBD server is disconnected after the
client write request. The NBD client should reconnect and complete
the write operation.
Suggested-by: Denis V. Lunev
Suggested-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Andrey Shinkevich
Reviewed-by: Eric Blake
From: Tianyu Lan
Hyper-V direct tlb flush targets KVM on Hyper-V guest.
Enable direct TLB flush for its guests meaning that TLB
flush hypercalls are handled by Level 0 hypervisor (Hyper-V)
bypassing KVM in Level 1. Due to the different ABI for hypercall
parameters between Hyper-V and KVM, KVM
On Fri, Nov 08, 2019 at 02:20:45PM +0100, Philippe Mathieu-Daudé wrote:
> On 11/4/19 4:13 PM, Cleber Rosa wrote:
> > """
> > -self.vm.set_machine('none')
> > self.vm.add_args('-S')
> > self.vm.launch()
> > diff --git a/tests/acceptance/linux_initrd.py
> >
Patchew URL:
https://patchew.org/QEMU/cover.1573477032.git.jan.kis...@siemens.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [RFC][PATCH 0/3] IVSHMEM version 2 device for QEMU
Type: series
Message-id:
On 29/10/19 09:21, Wei Yang wrote:
> Thanks Dave
>
> Paolo
>
> Do you feel comfortable with this?
>
Queued now, thanks.
Paolo
On 24/09/19 14:45, Ilver Belletti wrote:
> We would like to install Windows XP 32 bit as a guest operating system
> in a Windows 10 64 bit host operating system. With the QEMU emulator
> will be the pcmcia slot available ?
>
> We would like to use an epp parallel port in the guest operating
On Thu, Nov 07, 2019 at 05:46:13PM -0200, Wainer dos Santos Moschetta wrote:
>
> On 11/4/19 1:13 PM, Cleber Rosa wrote:
> > So that when binaries such as qemu-img are searched for, those in the
> > build tree will be favored. As a clarification, SRC_ROOT_DIR is
> > dependent on the location from
On Thu, Nov 07, 2019 at 05:22:24PM -0200, Wainer dos Santos Moschetta wrote:
>
> On 11/4/19 1:13 PM, Cleber Rosa wrote:
> > This is related to the the differences in in-tree and out-of-tree
> > builds in QEMU. For simplification, means my build directory.
> >
> > Currently, by running a `make
On Mon, Nov 04, 2019 at 07:26:23PM +0100, Philippe Mathieu-Daudé wrote:
> On 11/4/19 4:13 PM, Cleber Rosa wrote:
> > An Avocado Test ID[1] is composed by a number of components, but it
> > starts with the Test Name, usually a file system location that was
> > given to the loader.
> >
> > Because
On Fri, Nov 08, 2019 at 02:20:45PM +0100, Philippe Mathieu-Daudé wrote:
> > @@ -310,7 +302,7 @@ class BootLinuxConsole(Test):
> > def test_arm_emcraft_sf2(self):
> > """
> > :avocado: tags=arch:arm
> > -:avocado: tags=machine:emcraft_sf2
> > +:avocado:
On Fri, Nov 08, 2019 at 02:14:58PM +0100, Philippe Mathieu-Daudé wrote:
> On 11/4/19 4:13 PM, Cleber Rosa wrote:
> > Currently a test can describe the target architecture binary that it
> > should primarily be run with, be setting a single tag value.
> >
> > The same approach is expected to be
On 11/11/19 10:04 AM, Andrey Shinkevich wrote:
Allow writing all the data compressed through the filter driver.
The written data will be aligned by the cluster size.
Based on the QEMU current implementation, that data can be written to
unallocated clusters only. May be used for a backup job.
Coverity warns that we store the address of a stack variable through a
pointer passed in by the caller, which would let the caller trivially
trigger use-after-free if that stored value is still present when we
finish execution. However, the way coroutines work is that after our
call to
On Mon, Nov 11, 2019 at 5:38 AM Anup Patel wrote:
>
> The SiFive test device found on virt machine can be used by
> generic syscon reboot and poweroff drivers available in Linux
> kernel.
>
> This patch updates FDT generation in virt machine so that
> Linux kernel can probe and use generic syscon
On Mon, 11 Nov 2019 at 06:35, Alex Bennée wrote:
>
> This is a very simple versioning API which allows the plugin
> infrastructure to check the API a plugin was built against. We also
> expose a min/cur API version to the plugin via the info block in case
> it wants to avoid using old deprecated
Public bug reported:
Building qemu latest git 654efcb511d on fedora rawhide fails with this
configure line:
./configure \
--static \
--disable-system \
--enable-linux-user \
--disable-werror \
--disable-tools \
--disable-capstone
make fails with:
On Mon, Nov 11, 2019 at 05:58:20PM +0200, Maxim Levitsky wrote:
> Hi!
>
> I would like to discuss the API for LUKS key management.
>
> First of all very brief overview of LUKS v1 format:
>
> Each sector of the image is encrypted with same master key, which
> is not stored directly on the disk.
On 11/11/19 4:04 AM, Andrey Shinkevich wrote:
The test for an NBD client. The NBD server is disconnected after the
client write request. The NBD client should reconnect and complete
the write operation.
Suggested-by: Denis V. Lunev
Suggested-by: Vladimir Sementsov-Ogievskiy
Signed-off-by:
On Mon, 2019-11-11 at 12:04 +0900, David Stevens wrote:
> Having a centralized buffer allocator device is one way to deal with
> sharing buffers, since it gives a definitive buffer identifier that
> can be used by all drivers/devices to refer to the buffer. That being
> said, I think the device as
available in the Git repository at:
>
> https://github.com/rth7680/qemu.git tags/pull-tcg-2019
>
> for you to fetch changes up to cb974c95df0e1c9e73a37facd3e13894bd3eedc2:
>
> tcg/LICENSE: Remove out of date claim about TCG subdirectory
On Wed, 2019-10-23 at 23:52 -0300, Eduardo Habkost wrote:
> On Tue, Oct 22, 2019 at 03:35:25PM +0800, Cathy Zhang wrote:
> > This patchset is to add CPU model for intel processor Cooper Lake.
> > It
> > will inherit features from the existing CPU model Cascadelake-
> > Server,
> > meanwhile, add
This patch adds a new test file to exercise the case where
qemu-img fails to complete for the LUKS format when a non-UTF8
secret is used.
Signed-off-by: Daniel Henrique Barboza
---
tests/qemu-iotests/273 | 67 ++
tests/qemu-iotests/273.out | 11 +++
Using the new 'bdrv_co_delete_file' interface, a pure co_routine function
'bdrv_co_delete_file' inside block.c can can be used in a way similar of
the existing bdrv_create_file to to clean up a created file.
We're creating a pure co_routine because the only caller of
'bdrv_co_delete_file' will be
changes from previous version 7 [1], all suggested by Kevin Wolf:
- patch 1:
* removed function comment of raw_co_delete_file;
* removed 'done' label from raw_co_delete_file;
* removed 'local' remark from bdrv_co_delete_file comment. The comment
is now single-lined;
* added
When using a non-UTF8 secret to create a volume using qemu-img, the
following error happens:
$ qemu-img create -f luks --object
secret,id=vol_1_encrypt0,file=vol_resize_pool.vol_1.secret.qzVQrI -o
key-secret=vol_1_encrypt0 /var/tmp/pool_target/vol_1 10240K
Formatting
> Am 11.11.2019 um 16:28 schrieb Janosch Frank :
>
> We need to actually fetch the cpu mask and set it. As we invert the
> short psw indication in the mask, SIE will report a specification
> exception, if it wasn't present in the reset psw.
>
> Signed-off-by: Janosch Frank
> ---
>
Peter Maydell writes:
> On Mon, 11 Nov 2019 at 14:41, Thomas Huth wrote:
>>
>> On 11/11/2019 15.11, Alex Bennée wrote:
>> >
>> > Thomas Huth writes:
>> >
>> >> On 11/11/2019 13.55, Alex Bennée wrote:
>> >>> Signed-off-by: Alex Bennée
>> >>
>> >> Could you please add at least a short patch
Adding to Block Drivers the capability of being able to clean up
its created files can be useful in certain situations. For the
LUKS driver, for instance, a failure in one of its authentication
steps can leave files in the host that weren't there before.
This patch adds the 'bdrv_co_delete_file'
efcb511d394c1d3f5292c28503d1d19e5b1d3:
>
> Merge remote-tracking branch 'remotes/vivier/tags/q800-branch-pull-request'
> into staging (2019-11-11 09:23:46 +)
>
> are available in the Git repository at:
>
> https://git.linaro.org/people/pmaydell/qemu-arm.git
>
> -Original Message-
> From: Bin Meng
> Sent: Monday, November 11, 2019 8:58 PM
> To: Anup Patel
> Cc: Peter Maydell ; Alistair Francis
> ; Sagar Karandikar ;
> Palmer Dabbelt ; qemu-devel@nongnu.org; Atish
> Patra ; qemu-ri...@nongnu.org; Christoph Hellwig
> ; Anup Patel
> Subject:
On Mon, Nov 11, 2019 at 04:42:52PM +0100, Jan Kiszka wrote:
> On 11.11.19 16:27, Daniel P. Berrangé wrote:
> > On Mon, Nov 11, 2019 at 10:08:20AM -0500, Michael S. Tsirkin wrote:
> > > On Mon, Nov 11, 2019 at 02:59:07PM +0100, Jan Kiszka wrote:
> > > > On 11.11.19 14:45, Michael S. Tsirkin wrote:
On Thu, Oct 24, 2019 at 05:08:48AM -0400, Jagannathan Raman wrote:
> +int mpqemu_msg_recv(MPQemuLinkState *s, MPQemuMsg *msg, MPQemuChannel *chan)
> +{
> +int rc;
> +uint8_t *data;
> +union {
> +char control[CMSG_SPACE(REMOTE_MAX_FDS * sizeof(int))];
> +struct cmsghdr
On 11.11.19 17:11, Michael S. Tsirkin wrote:
On Mon, Nov 11, 2019 at 03:27:43PM +, Daniel P. Berrangé wrote:
On Mon, Nov 11, 2019 at 10:08:20AM -0500, Michael S. Tsirkin wrote:
On Mon, Nov 11, 2019 at 02:59:07PM +0100, Jan Kiszka wrote:
On 11.11.19 14:45, Michael S. Tsirkin wrote:
On
Allow writing all the data compressed through the filter driver.
The written data will be aligned by the cluster size.
Based on the QEMU current implementation, that data can be written to
unallocated clusters only. May be used for a backup job.
Suggested-by: Max Reitz
Signed-off-by: Andrey
On Friday, October 11, 2019, Vladimir Sementsov-Ogievskiy <
vsement...@virtuozzo.com> wrote:
> Add script to automatically commit tree-wide changes per-subsystem.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
Great idea!
Can you just add a comment somewhere close to the top of the
Patchew URL: https://patchew.org/QEMU/2019122545.252478-1-...@irrelevant.dk/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v3 00/20] nvme: support NVMe v1.3d, SGLs and multiple namespaces
Type: series
Message-id:
On 11.11.19 17:14, Michael S. Tsirkin wrote:
On Mon, Nov 11, 2019 at 04:42:52PM +0100, Jan Kiszka wrote:
On 11.11.19 16:27, Daniel P. Berrangé wrote:
On Mon, Nov 11, 2019 at 10:08:20AM -0500, Michael S. Tsirkin wrote:
On Mon, Nov 11, 2019 at 02:59:07PM +0100, Jan Kiszka wrote:
On 11.11.19
On 11.11.19 11:57, Kevin Wolf wrote:
> Am 25.10.2019 um 18:04 hat Stefan Hajnoczi geschrieben:
>> From: Aarushi Mehta
>>
>> Signed-off-by: Aarushi Mehta
>> Reviewed-by: Maxim Levitsky
>> Signed-off-by: Stefan Hajnoczi
>> ---
>> include/block/block.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
Signed-off-by: Max Reitz
---
tests/qemu-iotests/041 | 235 +
tests/qemu-iotests/041.out | 4 +-
2 files changed, 237 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
index 9a00cf6f7b..0e43bb699d 100755
---
On Thu, Oct 24, 2019 at 05:09:11AM -0400, Jagannathan Raman wrote:
> +static void broadcast_msg(MPQemuMsg *msg, bool need_reply)
> +{
> +PCIProxyDev *entry;
> +unsigned int pid;
> +int wait;
> +
> +QLIST_FOREACH(entry, _dev_list.devices, next) {
> +if (need_reply) {
> +
On Thu, Oct 24, 2019 at 05:09:14AM -0400, Jagannathan Raman wrote:
> +void proxy_device_reset(DeviceState *dev)
> +{
> +PCIProxyDev *pdev = PCI_PROXY_DEV(dev);
> +MPQemuMsg msg;
> +
> +memset(, 0, sizeof(MPQemuMsg));
> +
> +msg.bytestream = 0;
> +msg.size = sizeof(msg.data1);
>
Add two tests to see that you cannot replace a Quorum child with the
mirror job while the child is in use by a different parent.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/041 | 70 +-
tests/qemu-iotests/041.out | 4 +--
2 files changed, 71
On Mon, 11 Nov 2019 at 14:41, Thomas Huth wrote:
>
> On 11/11/2019 15.11, Alex Bennée wrote:
> >
> > Thomas Huth writes:
> >
> >> On 11/11/2019 13.55, Alex Bennée wrote:
> >>> Signed-off-by: Alex Bennée
> >>
> >> Could you please add at least a short patch description? (Why is this
> >> change
Signed-off-by: Max Reitz
---
tests/qemu-iotests/041 | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
index 2ab59e9c53..d636cb7f1d 100755
--- a/tests/qemu-iotests/041
+++ b/tests/qemu-iotests/041
@@ -918,8 +918,7 @@ class
On Thu, Oct 24, 2019 at 05:09:13AM -0400, Jagannathan Raman wrote:
> Using a separate communication channel for MMIO helps
> with improving Performance
Why?
signature.asc
Description: PGP signature
On Mon, Nov 11, 2019 at 03:27:43PM +, Daniel P. Berrangé wrote:
> On Mon, Nov 11, 2019 at 10:08:20AM -0500, Michael S. Tsirkin wrote:
> > On Mon, Nov 11, 2019 at 02:59:07PM +0100, Jan Kiszka wrote:
> > > On 11.11.19 14:45, Michael S. Tsirkin wrote:
> > > > On Mon, Nov 11, 2019 at 01:57:11PM
On Thu, Oct 24, 2019 at 05:09:26AM -0400, Jagannathan Raman wrote:
> @@ -656,6 +657,19 @@ static void init_proxy(PCIDevice *dev, char *command,
> bool need_spawn, Error **e
> }
> }
>
> +static void proxy_vm_state_change(void *opaque, int running, RunState state)
> +{
> +PCIProxyDev
Add the case to the iotest #214 that checks possibility of writing
compressed data of more than one cluster size. The test case involves
the compress filter driver showing a sample usage of that.
Signed-off-by: Andrey Shinkevich
---
tests/qemu-iotests/214 | 43
We can use this decorator above TestRepairQuorum.setUp() to skip all
quorum tests with a single line.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/041 | 39 +++
1 file changed, 3 insertions(+), 36 deletions(-)
diff --git a/tests/qemu-iotests/041
On 11.11.19 15:02, Thomas Huth wrote:
> On 30/10/2019 12.21, Max Reitz wrote:
>> On 22.10.19 09:21, Thomas Huth wrote:
>>> The next patch is going to add some python-based tests to the "auto"
>>> group, and these tests require virtio-blk to work properly. Running
>>> iotests without virtio-blk
On Thu, Oct 24, 2019 at 05:09:28AM -0400, Jagannathan Raman wrote:
> @@ -93,7 +94,8 @@ static void process_config_write(MPQemuMsg *msg)
> struct conf_data_msg *conf = (struct conf_data_msg *)msg->data2;
>
> qemu_mutex_lock_iothread();
> -pci_default_write_config(remote_pci_dev,
QEMU currently supports writing compressed data of the size equal to
one cluster. This patch allows writing QCOW2 compressed data that
exceed one cluster. Now, we split buffered data into separate clusters
and write them compressed using the existing functionality.
Suggested-by: Pavel Butsykin
This way, we get to see errors during the completion phase.
Signed-off-by: Max Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/155 | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/tests/qemu-iotests/155 b/tests/qemu-iotests/155
index
While bdrv_replace_node() will not follow through with it, a specific
@replaces asks the mirror job to create a loop.
For example, say both the source and the target share a child where the
source is a filter; by letting @replaces point to the common child, you
ask for a loop.
Or if you use
The compression filter driver is introduced as suggested by Max.
A sample usage of the filter can be found in the test #214.
Now, multiple clusters can be written compressed.
It is useful for the backup job.
v6: The new approach to write compressed data was applied. The patch
v5 4/4 with the
There is no guarantee that we can still replace the node we want to
replace at the end of the mirror job. Double-check by calling
bdrv_recurse_can_replace().
Signed-off-by: Max Reitz
---
block/mirror.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git
Quorum is not a filter, for example because it cannot guarantee which of
its children will serve the next request. Thus, any of its children may
differ from the data visible to quorum's parents.
We have other filters with multiple children, but they differ in this
aspect:
- blkverify quits the
041's TestRepairQuorum has its own image_len, no need to refer to
TestSingleDrive. (This patch allows commenting out TestSingleDrive to
speed up 041 during test testing.)
Signed-off-by: Max Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/041 | 2 +-
1 file changed, 1
Signed-off-by: Max Reitz
---
tests/qemu-iotests/041 | 46 ++
tests/qemu-iotests/041.out | 4 ++--
2 files changed, 48 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
index ab0cb5b42f..9a00cf6f7b 100755
---
After a couple of follow-up patches, this function will replace
bdrv_recurse_is_first_non_filter() in check_to_replace_node().
bdrv_recurse_is_first_non_filter() is both not sufficiently specific for
check_to_replace_node() (it allows cases that should not be allowed,
like replacing child nodes
We will need this to verify that Quorum can let one of its children be
replaced without breaking anything else.
Signed-off-by: Max Reitz
---
block/quorum.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/block/quorum.c b/block/quorum.c
index 59cd524502..3a824e77e3
It no longer has any users.
Signed-off-by: Max Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block.c | 33 -
block/blkverify.c | 15 ---
block/copy-on-read.c | 9 -
block/quorum.c| 18
Signed-off-by: Max Reitz
---
block/blkverify.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/block/blkverify.c b/block/blkverify.c
index 304b0a1368..0add3ab483 100644
--- a/block/blkverify.c
+++ b/block/blkverify.c
@@ -282,6 +282,20 @@ static bool
Signed-off-by: Max Reitz
---
tests/qemu-iotests/iotests.py | 59 +++
1 file changed, 59 insertions(+)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index d34305ce69..3e03320ce3 100644
--- a/tests/qemu-iotests/iotests.py
+++
This will be useful when we want to store additional attributes for each
child.
Signed-off-by: Max Reitz
---
block/quorum.c | 64 --
1 file changed, 36 insertions(+), 28 deletions(-)
diff --git a/block/quorum.c b/block/quorum.c
index
Quorum cannot share WRITE or RESIZE on its children. Presumably, it
only does so because as a filter, it seemed intuitively correct to point
its .bdrv_child_perm to bdrv_filter_default_perm().
However, it is not really a filter, and bdrv_filter_default_perm() does
not work for it, so we have to
Using -drive with default options means that a virtio-blk drive will be
created that has write access to the to-be quorum children. Quorum
should have exclusive write access to them, so we should use -blockdev
instead.
Signed-off-by: Max Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
Block nodes that do not allow resizing should not share BLK_PERM_RESIZE.
It does not matter whether they are the first non-filter in their chain
or not.
Signed-off-by: Max Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
blockdev.c | 5 -
1 file changed, 5 deletions(-)
diff --git
Let check_to_replace_node() use the more specialized
bdrv_recurse_can_replace() instead of
bdrv_recurse_is_first_non_filter(), which is too restrictive.
Signed-off-by: Max Reitz
---
block.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
It is unused now. (And it was ugly because it needed to explore all BDS
chains from the top.)
Signed-off-by: Max Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block.c | 26 --
include/block/block.h | 1 -
2 files changed, 27 deletions(-)
diff
Wei Yang writes:
> On Mon, Nov 11, 2019 at 10:25:43AM +, Alex Benn??e wrote:
>>
>>Wei Yang writes:
>>
>>> This file uses quite a different code style and changing just one line
>>> would leads to some awkward appearance.
>>>
>>> This is a preparation for the following replacement of
>>>
Signed-off-by: Max Reitz
---
block/quorum.c | 62 ++
1 file changed, 62 insertions(+)
diff --git a/block/quorum.c b/block/quorum.c
index 3a824e77e3..8ee03e9baf 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -825,6 +825,67 @@ static bool
There is no good reason why we would allow external snapshots only on
the first non-filter node in a chain. Parent BDSs should not care
whether their child is replaced by a snapshot. (If they do care, they
should announce that via freezing the chain, which is checked in
bdrv_append() through
1 - 100 of 206 matches
Mail list logo
