Re: API definition for LUKS key management

2019-11-12 Thread Daniel P . Berrangé
On Mon, Nov 11, 2019 at 05:58:20PM +0200, Maxim Levitsky wrote: > I will try to explain the interface with bunch of examples: I want to fill in equiv examples from cryptsetup for sake of comparison > # adds a new password, defined by qemu secret 'sec0' to first unused slot > # give user a error

Re: [PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

2019-11-12 Thread Stefan Hajnoczi
On Wed, Oct 23, 2019 at 05:28:17PM -0400, Michael S. Tsirkin wrote: > On Fri, Oct 18, 2019 at 02:55:47PM +0300, Denis Plotnikov wrote: > > From: "Denis V. Lunev" > > > > Linux guests submit IO requests no longer than PAGE_SIZE * max_seg > > field reported by SCSI controler. Thus typical

Re: [PATCH] qemu-coroutine-sleep: Silence Coverity warning

2019-11-12 Thread Peter Maydell
On Mon, 11 Nov 2019 at 20:35, Eric Blake wrote: > > Coverity warns that we store the address of a stack variable through a > pointer passed in by the caller, which would let the caller trivially > trigger use-after-free if that stored value is still present when we > finish execution. However,

Re: [PATCH] i386: define the 'flush_l1d' CPUID feature bit (CVE-2018-3646)

2019-11-12 Thread Daniel P . Berrangé
On Tue, Nov 12, 2019 at 03:50:43AM +, Kyle Copperfield via wrote: > New microcode introduces the "Flush L1D Cache" CPUID feature bit. > This needs to be exposed to guest OS to allow them to protect against > CVE-2018-3646. My understanding was that this is only required in the L0 hypervisor,

Re: [PATCH qemu-web] Add a blog post on "Micro-Optimizing KVM VM-Exits"

2019-11-12 Thread Kashyap Chamarthy
[Cc: Rich Jones, addressing his feedback on IRC, below.] On Fri, Nov 08, 2019 at 10:22:47AM +0100, Kashyap Chamarthy wrote: > This blog post summarizes the talk "Micro-Optimizing KVM VM-Exits"[1], > given by Andrea Arcangeli at the recently concluded KVM Forum 2019. > > [1] >

Re: [RFC PATCH 16/18] qapi: Create 'pragma' module

2019-11-12 Thread Markus Armbruster
Kevin Wolf writes: > We want to share the whitelists between the system emulator schema and > the storage daemon schema, so move all the pragmas from the main schema > file into a separate file that can be included from both. Confusing because the storage daemon schema doesn't exist at this

Re: [PATCH v6 1/3] block: introduce compress filter driver

2019-11-12 Thread Kevin Wolf
Am 11.11.2019 um 17:04 hat Andrey Shinkevich geschrieben: > Allow writing all the data compressed through the filter driver. > The written data will be aligned by the cluster size. > Based on the QEMU current implementation, that data can be written to > unallocated clusters only. May be used for

Re: [PATCH v2] ivshmem-server: Clean up shmem on shutdown

2019-11-12 Thread Laurent Vivier
Le 08/11/2019 à 16:14, Markus Armbruster a écrit : > Jan Kiszka writes: > >> On 06.08.19 15:01, Claudio Fontana wrote: >>> On 8/5/19 7:54 AM, Jan Kiszka wrote: From: Jan Kiszka So far, the server leaves the posix shared memory object behind when terminating, requiring the

Re: [PATCH v2] ivshmem-server: Terminate also on SIGINT

2019-11-12 Thread Laurent Vivier
Le 08/11/2019 à 16:15, Markus Armbruster a écrit : > Jan Kiszka writes: > >> On 03.08.19 15:22, Jan Kiszka wrote: >>> From: Jan Kiszka >>> >>> Allows to shutdown a foreground session via ctrl-c. >>> >>> Signed-off-by: Jan Kiszka >>> --- >>> >>> Changes in v2: >>> - adjust error message >>>

Re: [PATCH] numa: Add missing \n to error message

2019-11-12 Thread Laurent Vivier
Le 06/11/2019 à 13:46, Greg Kurz a écrit : > If memory allocation fails when using -mem-path, QEMU is supposed to print > out a message to indicate that fallback to anonymous RAM is deprecated. This > is done with error_printf() which does output buffering. As a consequence, > the message is only

Re: [PATCH] qom: Fix error message in object_class_property_add()

2019-11-12 Thread Laurent Vivier
Le 05/11/2019 à 15:05, Laurent Vivier a écrit : > Le 04/11/2019 à 14:23, Greg Kurz a écrit : >> The error message in object_class_property_add() was copied from >> object_property_add() in commit 16bf7f522a2ff. Clarify that it is >> about a class, not an object. >> >> While here, have the format

Re: [PATCH] Makefile: install bios-microvm like other binary blobs

2019-11-12 Thread Laurent Vivier
Le 02/11/2019 à 12:43, Philippe Mathieu-Daudé a écrit : > From: Bruce Rogers > > Commit 0d5fae3e52e introduced bios-microvm.bin but forgot to add > it to the list of blobs being installed. > Add it to the list of BLOBS that get installed. > > Fixes: 0d5fae3e52e "roms: add microvm-bios (qboot)

Re: [PATCH] enable translating statx syscalls on more arches

2019-11-12 Thread Laurent Vivier
Le 12/11/2019 à 09:27, Aleksandar Markovic a écrit : > > > On Tuesday, November 12, 2019, Aleksandar Markovic > mailto:aleksandar.m.m...@gmail.com>> wrote: > > > > On Tuesday, November 12, 2019, Andrew Kelley > wrote: > > ping > > On

Re: [PATCH qemu] scripts: Detect git worktrees for get_maintainer.pl --git

2019-11-12 Thread Paolo Bonzini
On 12/11/19 04:45, Alexey Kardashevskiy wrote: > Recent git versions support worktrees where .git is not a directory but > a file with a path to the .git repository; however the get_maintainer.pl > script only recognises the .git directory, let's fix it. > > Signed-off-by: Alexey Kardashevskiy >

Re: API definition for LUKS key management

2019-11-12 Thread Kevin Wolf
Am 11.11.2019 um 19:34 hat Daniel P. Berrangé geschrieben: > On Mon, Nov 11, 2019 at 05:58:20PM +0200, Maxim Levitsky wrote: > > One of the concerns that was raised during the review was that amend > > interface for luks that I propose is > > different from the amend inteface used currently for

Re: virtio,iommu_platform=on

2019-11-12 Thread Laszlo Ersek
On 11/12/19 04:53, Alexey Kardashevskiy wrote: > Hi! > > I am enabling IOMMU for virtio in the pseries firmware (SLOF) and seeing > problems, one of them is SLOF does SCSI bus scan, then it stops the > virtio-scsi by clearing MMIO|IO|BUSMASTER from PCI_COMMAND (as SLOF > stopped using the

Re: [PATCH v6 1/3] block: introduce compress filter driver

2019-11-12 Thread Vladimir Sementsov-Ogievskiy
11.11.2019 23:47, Eric Blake wrote: > On 11/11/19 10:04 AM, Andrey Shinkevich wrote: >> Allow writing all the data compressed through the filter driver. >> The written data will be aligned by the cluster size. >> Based on the QEMU current implementation, that data can be written to >> unallocated

Re: [PATCH qemu] scripts: Detect git worktrees for get_maintainer.pl --git

2019-11-12 Thread Greg Kurz
On Tue, 12 Nov 2019 14:45:32 +1100 Alexey Kardashevskiy wrote: > Recent git versions support worktrees where .git is not a directory but > a file with a path to the .git repository; however the get_maintainer.pl > script only recognises the .git directory, let's fix it. > > Signed-off-by:

Re: [PATCH qemu] scripts: Detect git worktrees for get_maintainer.pl --git

2019-11-12 Thread Stefano Garzarella
On Tue, Nov 12, 2019 at 02:45:32PM +1100, Alexey Kardashevskiy wrote: > Recent git versions support worktrees where .git is not a directory but > a file with a path to the .git repository; however the get_maintainer.pl > script only recognises the .git directory, let's fix it. > > Signed-off-by:

Re: [RFC PATCH 15/18] qapi: Support empty modules

2019-11-12 Thread Markus Armbruster
Kevin Wolf writes: > If you added an include file that doesn't contain any definitions, no > source files would be generated for it. However, in other source files, > you would still get an #include for the header files of the empty > module. Bug. Cause: we generate #include module.h always,

Re: [PATCH] enable translating statx syscalls on more arches

2019-11-12 Thread Aleksandar Markovic
On Tuesday, November 12, 2019, Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Tuesday, November 12, 2019, Andrew Kelley wrote: > >> ping >> >> On 10/16/19 5:01 PM, Andrew Kelley wrote: >> > Signed-off-by: Andrew Kelley >> > --- >> > linux-user/aarch64/syscall_nr.h | 13

Re: [PATCH] enable translating statx syscalls on more arches

2019-11-12 Thread Aleksandar Markovic
On Tuesday, November 12, 2019, Andrew Kelley wrote: > ping > > On 10/16/19 5:01 PM, Andrew Kelley wrote: > > Signed-off-by: Andrew Kelley > > --- > > linux-user/aarch64/syscall_nr.h | 13 ++ > > linux-user/arm/syscall_nr.h | 38 > >

Re: [RFC][PATCH 2/3] docs/specs: Add specification of ivshmem device revision 2

2019-11-12 Thread Michael S. Tsirkin
On Mon, Nov 11, 2019 at 05:38:29PM +0100, Jan Kiszka wrote: > On 11.11.19 17:11, Michael S. Tsirkin wrote: > > On Mon, Nov 11, 2019 at 03:27:43PM +, Daniel P. Berrangé wrote: > > > On Mon, Nov 11, 2019 at 10:08:20AM -0500, Michael S. Tsirkin wrote: > > > > On Mon, Nov 11, 2019 at 02:59:07PM

<    1   2   3