[Bug 1746943] Re: qemu-aarch64-static: qemu: uncaught target signal 11 for ps/top cmd

2019-11-22 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1746943 Title:

[Bug 1849644] Re: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol

2019-11-22 Thread yuchenlin
I have sent a patch about this problem. Please see https://lists.nongnu.org/archive/html/qemu- devel/2019-11/msg03924.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1849644 Title: QEMU VNC

[PATCH] io/channel-websock: treat 'binary' and no sub-protocol as the same

2019-11-22 Thread Yu-Chen Lin
noVNC doesn't use 'binary' protocol by default after commit c912230309806aacbae4295faf7ad6406da97617. It will cause qemu return 400 when handshaking. To overcome this problem and remain compatibility of older noVNC client. We treat 'binary' and no sub-protocol as the same so that we can support

Re: [PATCH 0/6] Enable Travis builds on arm64, ppc64le and s390x

2019-11-22 Thread Alex Bennée
Thomas Huth writes: > Travis recently added build hosts for arm64, ppc64le and s390x, so > this is a welcome addition to our Travis testing matrix. > > Unfortunately, the builds are running in quite restricted LXD containers > there, for example it is not possible to create huge files there

Re: [PATCH v2 4/5] MAINTAINERS: Adjust maintainership for R4000 systems

2019-11-22 Thread Hervé Poussineau
Le 22/11/2019 à 16:29, Philippe Mathieu-Daudé a écrit : On 11/22/19 3:14 PM, Aleksandar Markovic wrote: On Fri, Nov 22, 2019 at 2:58 PM Philippe Mathieu-Daudé wrote: Hi Aleksandar, On 11/13/19 2:47 PM, Aleksandar Markovic wrote: From: Aleksandar Markovic Change the maintainership for

Re: [PATCH] riscv: virt: Allow PCI address 0

2019-11-22 Thread Palmer Dabbelt
On Fri, 22 Nov 2019 07:27:52 PST (-0800), bmeng...@gmail.com wrote: When testing e1000 with the virt machine, e1000's I/O space cannot be accessed. Debugging shows that the I/O BAR (BAR1) is correctly written with address 0 plus I/O enable bit, but QEMU's "info pci" shows that: Bus 0, device

Re: [PATCH for-5.0 v11 00/20] VIRTIO-IOMMU device

2019-11-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191122182943.4656-1-eric.au...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH] 9pfs: Fix divide by zero bug

2019-11-22 Thread Christian Schoenebeck
On Freitag, 22. November 2019 21:00:34 CET Dan Schatzberg wrote: > Some filesystems may return 0s in statfs (trivially, a FUSE filesystem > can do so). QEMU should handle this gracefully and just behave the > same as if statfs failed. Is that actually legal in non-error cases? Shouldn't a driver

Re: [PATCH] linux-user: fix translation of statx structures

2019-11-22 Thread Ariadne Conill
Hello, On Fri, Nov 22, 2019 at 12:27 PM Aleksandar Markovic wrote: > > On Fri, Nov 22, 2019 at 7:22 PM Ariadne Conill > wrote: > > > > All timestamps were copied to atime instead of to their respective > > fields. > > > > Signed-off-by: Ariadne Conill > > --- > > What a bug. Yes, in Alpine

[PATCH] 9pfs: Fix divide by zero bug

2019-11-22 Thread Dan Schatzberg
Some filesystems may return 0s in statfs (trivially, a FUSE filesystem can do so). QEMU should handle this gracefully and just behave the same as if statfs failed. Signed-off-by: Dan Schatzberg --- hw/9pfs/9p.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2 5/5] MAINTAINERS: Add two files to Malta section

2019-11-22 Thread Aleksandar Markovic
On Fri, Nov 22, 2019 at 9:28 PM Philippe Mathieu-Daudé wrote: > > On 11/13/19 2:47 PM, Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > > > Add two files that were recently introduced in a refactoring, > > that Malta emulation relies on. They are added by this patch > > to Malta

Re: [PATCH] linux-user: fix translation of statx structures

2019-11-22 Thread Laurent Vivier
Le 22/11/2019 à 18:40, Ariadne Conill a écrit : > All timestamps were copied to atime instead of to their respective > fields. > > Signed-off-by: Ariadne Conill > --- > linux-user/syscall.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git

Re: [PATCH v2 5/5] MAINTAINERS: Add two files to Malta section

2019-11-22 Thread Philippe Mathieu-Daudé
On 11/13/19 2:47 PM, Aleksandar Markovic wrote: From: Aleksandar Markovic Add two files that were recently introduced in a refactoring, that Malta emulation relies on. They are added by this patch to Malta section, but they are not added to the general MIPS section, since they are really not

Re: [RFC PATCH-for-5.0] hw/pci-host: Add Kconfig selector for IGD PCIe pass-through

2019-11-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191122172201.11456-1-phi...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH] linux-user: fix translation of statx structures

2019-11-22 Thread Philippe Mathieu-Daudé
On 11/22/19 7:27 PM, Aleksandar Markovic wrote: On Fri, Nov 22, 2019 at 7:22 PM Ariadne Conill wrote: All timestamps were copied to atime instead of to their respective fields. Fixes: efa921845c0 Signed-off-by: Ariadne Conill --- What a bug. Laurent, perhaps a good candidate for 4.2?

Re: [PATCH for-5.0 v11 12/20] qapi: Introduce DEFINE_PROP_INTERVAL

2019-11-22 Thread Dr. David Alan Gilbert
* Eric Auger (eric.au...@redhat.com) wrote: > Introduce a new property defining a labelled interval: > ,,label. > > This will be used to encode reserved IOVA regions. The label > is left undefined to ease reuse accross use cases. > > For instance, in virtio-iommu use case, reserved IOVA regions

Re: [RFC PATCH-for-5.0] hw/pci-host: Add Kconfig selector for IGD PCIe pass-through

2019-11-22 Thread Philippe Mathieu-Daudé
On 11/22/19 7:03 PM, Thomas Huth wrote: On 22/11/2019 18.22, Philippe Mathieu-Daudé wrote: Introduce a kconfig selector to allow builds without Intel Integrated Graphics Device GPU PCIe passthrough. We keep the default as enabled. Signed-off-by: Philippe Mathieu-Daudé --- RFC because to be

Re: [PATCH v2 0/9] RFC: [for 5.0]: HMP monitor handlers cleanups

2019-11-22 Thread Dr. David Alan Gilbert
* Maxim Levitsky (mlevi...@redhat.com) wrote: > This patch series is bunch of cleanups > to the hmp monitor code. > > This series only touched blockdev related hmp handlers. > > No functional changes expected other that > light error message changes by the last patch. > > This was inspired by

[PATCH for-5.0 v11 19/20] pc: Add support for virtio-iommu-pci

2019-11-22 Thread Eric Auger
The virtio-iommu-pci is instantiated through the -device QEMU option. However if instantiated it also requires an IORT ACPI table to describe the ID mappings between the root complex and the iommu. This patch adds the generation of the IORT table if the virtio-iommu-pci device is instantiated.

[PATCH for-5.0 v11 17/20] hw/arm/virt-acpi-build: Add virtio-iommu node in IORT table

2019-11-22 Thread Eric Auger
This patch builds the virtio-iommu node in the ACPI IORT table. The RID space of the root complex, which spans 0x0-0x1 maps to streamid space 0x0-0x1 in the virtio-iommu which in turn maps to deviceid space 0x0-0x1 in the ITS group. The iommu RID is excluded as described in

[PATCH for-5.0 v11 15/20] virtio-iommu-pci: Add array of Interval properties

2019-11-22 Thread Eric Auger
The machine may need to pass reserved regions to the virtio-iommu-pci device (such as the MSI window on x86). So let's add an array of Interval properties. Signed-off-by: Eric Auger --- hw/virtio/virtio-iommu-pci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH for-5.0 v11 18/20] virtio-iommu: Support migration

2019-11-22 Thread Eric Auger
Add Migration support. We rely on recently added gtree and qlist migration. Besides, we have to fixup end point <-> domain link. Indeed each domain has a list of endpoints attached to it. And each endpoint has a pointer to its domain. Raw gtree and qlist migration cannot handle this as it

[PATCH for-5.0 v11 10/20] virtio-iommu-pci: Add virtio iommu pci support

2019-11-22 Thread Eric Auger
This patch adds virtio-iommu-pci, which is the pci proxy for the virtio-iommu device. Signed-off-by: Eric Auger --- v10 -> v11: - add the reserved_regions array property v9 -> v10: - include "hw/qdev-properties.h" header v8 -> v9: - add the msi-bypass property - create virtio-iommu-pci.c ---

[PATCH for-5.0 v11 14/20] virtio-iommu: Handle reserved regions in the translation process

2019-11-22 Thread Eric Auger
When translating an address we need to check if it belongs to a reserved virtual address range. If it does, there are 2 cases: - it belongs to a RESERVED region: the guest should neither use this address in a MAP not instruct the end-point to DMA on them. We report an error - It belongs to

[PATCH for-5.0 v11 09/20] virtio-iommu: Implement fault reporting

2019-11-22 Thread Eric Auger
The event queue allows to report asynchronous errors. The translate function now injects faults when relevant. Signed-off-by: Eric Auger --- v10 -> v11: - change a virtio_error into an error_report_once (no buffer available for output faults) --- hw/virtio/trace-events | 1 +

[PATCH for-5.0 v11 13/20] virtio-iommu: Implement probe request

2019-11-22 Thread Eric Auger
This patch implements the PROBE request. At the moment, no reserved regions are returned as none are registered per device. Only a NONE property is returned. Signed-off-by: Eric Auger --- v9 -> v10 - fully rewrite the code in preparation of reserved_regions array property introduction v8 ->

[PATCH for-5.0 v11 20/20] tests: Add virtio-iommu test

2019-11-22 Thread Eric Auger
This adds the framework to test the virtio-iommu-pci device and tests exercising the attach/detach, map/unmap API. To run the tests: make tests/qos-test QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 tests/qos-test V=1 Signed-off-by: Eric Auger --- tests/Makefile.include | 2 +

[PATCH for-5.0 v11 02/20] virtio-iommu: Add skeleton

2019-11-22 Thread Eric Auger
This patchs adds the skeleton for the virtio-iommu device. Signed-off-by: Eric Auger --- v9 -> v10: - mutex initialized here - initialize tail - included hw/qdev-properties.h - removed g_memdup - removed s->config.domain_range.start = 0; v9 -> v10: - expose VIRTIO_IOMMU_F_MMIO feature -

[PATCH for-5.0 v11 12/20] qapi: Introduce DEFINE_PROP_INTERVAL

2019-11-22 Thread Eric Auger
Introduce a new property defining a labelled interval: ,,label. This will be used to encode reserved IOVA regions. The label is left undefined to ease reuse accross use cases. For instance, in virtio-iommu use case, reserved IOVA regions will be passed by the machine code to the virtio-iommu-pci

[PATCH for-5.0 v11 11/20] hw/arm/virt: Add the virtio-iommu device tree mappings

2019-11-22 Thread Eric Auger
Adds the "virtio,pci-iommu" node in the host bridge node and the RID mapping, excluding the IOMMU RID. Signed-off-by: Eric Auger --- v10 -> v11: - remove msi_bypass v8 -> v9: - disable msi-bypass property - addition of the subnode is handled is the hotplug handler and IOMMU RID is

Re: [PATCH] linux-user: fix translation of statx structures

2019-11-22 Thread Aleksandar Markovic
On Fri, Nov 22, 2019 at 7:22 PM Ariadne Conill wrote: > > All timestamps were copied to atime instead of to their respective > fields. > > Signed-off-by: Ariadne Conill > --- What a bug. Laurent, perhaps a good candidate for 4.2? Thanks for submitting this, Ariadne Conill! Reviewed-by:

[PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2019-11-22 Thread Eric Auger
This patch implements the translate callback Signed-off-by: Eric Auger --- v10 -> v11: - take into account the new value struct and use g_tree_lookup_extended - switched to error_report_once v6 -> v7: - implemented bypass-mode v5 -> v6: - replace error_report by qemu_log_mask v4 -> v5: -

[PATCH for-5.0 v11 16/20] hw/arm/virt-acpi-build: Introduce fill_iort_idmap helper

2019-11-22 Thread Eric Auger
To avoid code duplication, let's introduce an helper that fills one IORT ID mappings array index. Signed-off-by: Eric Auger --- v8: new --- hw/arm/virt-acpi-build.c | 43 1 file changed, 26 insertions(+), 17 deletions(-) diff --git

[PATCH for-5.0 v11 07/20] virtio-iommu: Implement map/unmap

2019-11-22 Thread Eric Auger
This patch implements virtio_iommu_map/unmap. Signed-off-by: Eric Auger --- v10 -> v11: - revisit the implementation of unmap according to Peter's suggestion - removed virt_addr and size from viommu_mapping struct - use g_tree_lookup_extended() - return VIRTIO_IOMMU_S_RANGE in case a mapping

Re: [PATCH v3 8/8] iotests: Test committing to short backing file

2019-11-22 Thread Eric Blake
On 11/22/19 10:05 AM, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- tests/qemu-iotests/274| 152 + tests/qemu-iotests/274.out| 203 ++ tests/qemu-iotests/group | 1 + tests/qemu-iotests/iotests.py | 2 +- 4

[PATCH for-5.0 v11 05/20] virtio-iommu: Endpoint and domains structs and helpers

2019-11-22 Thread Eric Auger
This patch introduce domain and endpoint internal datatypes. Both are stored in RB trees. The domain owns a list of endpoints attached to it. Helpers to get/put end points and domains are introduced. get() helpers will become static in subsequent patches. Signed-off-by: Eric Auger --- v10 ->

[PATCH for-5.0 v11 06/20] virtio-iommu: Implement attach/detach command

2019-11-22 Thread Eric Auger
This patch implements the endpoint attach/detach to/from a domain. Signed-off-by: Eric Auger --- --- hw/virtio/virtio-iommu.c | 43 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c index

[PATCH for-5.0 v11 04/20] virtio-iommu: Add the iommu regions

2019-11-22 Thread Eric Auger
This patch initializes the iommu memory regions so that PCIe end point transactions get translated. The translation function is not yet implemented though. Signed-off-by: Eric Auger --- v10 -> v11: - use g_hash_table_new_full for allocating as_by_busptr v9 -> v10: - remove pc/virt machine

[PATCH for-5.0 v11 03/20] virtio-iommu: Decode the command payload

2019-11-22 Thread Eric Auger
This patch adds the command payload decoding and introduces the functions that will do the actual command handling. Those functions are not yet implemented. Signed-off-by: Eric Auger --- v10 -> v11: - use a macro for handle command functions v9 -> v10: - make virtio_iommu_handle_* more

Re: [RFC PATCH-for-5.0] hw/pci-host: Add Kconfig selector for IGD PCIe pass-through

2019-11-22 Thread Thomas Huth
On 22/11/2019 18.22, Philippe Mathieu-Daudé wrote: > Introduce a kconfig selector to allow builds without Intel > Integrated Graphics Device GPU PCIe passthrough. > We keep the default as enabled. > > Signed-off-by: Philippe Mathieu-Daudé > --- > RFC because to be able to use the

[PATCH for-5.0 v11 00/20] VIRTIO-IOMMU device

2019-11-22 Thread Eric Auger
This series implements the QEMU virtio-iommu device. This matches the v0.12 spec and the corresponding virtio-iommu driver upstreamed in 5.3. The pci proxy for the virtio-iommu device is instantiated using "-device virtio-iommu-pci". This series still relies on ACPI IORT/DT integration. Note the

[PATCH for-5.0 v11 01/20] migration: Support QLIST migration

2019-11-22 Thread Eric Auger
Support QLIST migration using the same principle as QTAILQ: 94869d5c52 ("migration: migrate QTAILQ"). The VMSTATE_QLIST_V macro has the same proto as VMSTATE_QTAILQ_V. The change mainly resides in QLIST RAW macros: QLIST_RAW_INSERT_HEAD and QLIST_RAW_REVERSE. Tests also are provided.

Re: [PATCH 6/6] travis.yml: Enable builds on arm64, ppc64le and s390x

2019-11-22 Thread Alex Bennée
Thomas Huth writes: > Travis recently added the possibility to test on these architectures, > too, so let's enable them in our travis.yml file to extend our test > coverage. This is good as far as it goes but it would be nice to exercise the respective TCG backends. If added two commits to:

Re: [PATCH v2 4/5] s390x: Move clear reset

2019-11-22 Thread David Hildenbrand
On 22.11.19 18:15, Janosch Frank wrote: > On 11/22/19 3:30 PM, David Hildenbrand wrote: >> On 22.11.19 15:00, Janosch Frank wrote: >>> Let's also move the clear reset function into the reset handler. >>> >>> Signed-off-by: Janosch Frank >>> --- >>> target/s390x/cpu-qom.h | 1 + >>>

Re: [PATCH for-5.0 v5 00/23] ppc/pnv: add XIVE support for KVM guests

2019-11-22 Thread Cédric Le Goater
On 15/11/2019 17:24, Cédric Le Goater wrote: > Hello, > > The QEMU PowerNV machine emulates a baremetal OpenPOWER system and > acts as an hypervisor (L0). Supporting emulation of KVM to run guests > (L1) requires a few more extensions, among which guest support for the > XIVE interrupt controller

Re: [PATCH 2/4] virtiofd: Create a notification queue

2019-11-22 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > On Fri, Nov 22, 2019 at 10:19:03AM +, Stefan Hajnoczi wrote: > > On Fri, Nov 15, 2019 at 03:55:41PM -0500, Vivek Goyal wrote: > > > /* Callback from libvhost-user */ > > > static void fv_set_features(VuDev *dev, uint64_t features) > > > { > > > +

[PATCH] linux-user: fix translation of statx structures

2019-11-22 Thread Ariadne Conill
All timestamps were copied to atime instead of to their respective fields. Signed-off-by: Ariadne Conill --- linux-user/syscall.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index ce399a55f0..171c0caef3 100644 ---

[RFC PATCH-for-5.0] hw/pci-host: Add Kconfig selector for IGD PCIe pass-through

2019-11-22 Thread Philippe Mathieu-Daudé
Introduce a kconfig selector to allow builds without Intel Integrated Graphics Device GPU PCIe passthrough. We keep the default as enabled. Signed-off-by: Philippe Mathieu-Daudé --- RFC because to be able to use the Kconfig-generated "config-devices.h" header we have to move this device out of

Re: [PATCH v3 4/8] block: truncate: Don't make backing file data visible

2019-11-22 Thread Eric Blake
On 11/22/19 10:05 AM, Kevin Wolf wrote: When extending the size of an image that has a backing file larger than its old size, make sure that the backing file data doesn't become visible in the guest, but the added area is properly zeroed out. Consider the following scenario where the overlay is

Re: [PATCH v2 1/5] s390x: Don't do a normal reset on the initial cpu

2019-11-22 Thread Janosch Frank
On 11/22/19 5:17 PM, Cornelia Huck wrote: > On Fri, 22 Nov 2019 08:59:58 -0500 > Janosch Frank wrote: > >> The initiating cpu needs to be reset with an initial reset. While >> doing a normal reset followed by a initial reset is not wron per-se, > > s/wron per-se/wrong per se/ Ups > >> the

[PATCH v6] migration: Support QLIST migration

2019-11-22 Thread Eric Auger
Support QLIST migration using the same principle as QTAILQ: 94869d5c52 ("migration: migrate QTAILQ"). The VMSTATE_QLIST_V macro has the same proto as VMSTATE_QTAILQ_V. The change mainly resides in QLIST RAW macros: QLIST_RAW_INSERT_HEAD and QLIST_RAW_REVERSE. Tests also are provided.

Re: [PATCH v35 00/13] QEMU AVR 8 bit cores

2019-11-22 Thread Aleksandar Markovic
On Tue, Oct 29, 2019 at 10:25 PM Michael Rolnik wrote: > > This series of patches adds 8bit AVR cores to QEMU. > All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully tested > yet. > However I was able to execute simple code with functions. e.g fibonacci > calculation. > This

Re: [PATCH v3 3/8] qcow2: Declare BDRV_REQ_NO_FALLBACK supported

2019-11-22 Thread Eric Blake
On 11/22/19 10:05 AM, Kevin Wolf wrote: In the common case, qcow2_co_pwrite_zeroes() already only modifies metadata case, so we're fine with or without BDRV_REQ_NO_FALLBACK set. The only exception is when using an external data file, where the request is passed down to the block driver of the

Re: [PATCH v35 10/13] target/avr: Add limited support for USART and 16 bit timer peripherals

2019-11-22 Thread Aleksandar Markovic
On Tue, Oct 29, 2019 at 10:25 PM Michael Rolnik wrote: > > From: Sarah Harris > > These were designed to facilitate testing but should provide enough function > to be useful in other contexts. > Only a subset of the functions of each peripheral is implemented, mainly due > to the lack of a

Re: [RFC PATCH-for-5.0] hw/pci-host: Add Kconfig selector for IGD PCIe pass-through

2019-11-22 Thread Alex Williamson
On Fri, 22 Nov 2019 18:22:01 +0100 Philippe Mathieu-Daudé wrote: > Introduce a kconfig selector to allow builds without Intel > Integrated Graphics Device GPU PCIe passthrough. > We keep the default as enabled. > > Signed-off-by: Philippe Mathieu-Daudé > --- > RFC because to be able to use the

Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic

2019-11-22 Thread Aleksandar Markovic
> +/* Number of CPU registers */ > +#define NO_CPU_REGISTERS 32 > +/* Number of IO registers accessible by ld/st/in/out */ > +#define NO_IO_REGISTERS 64 Hi again, Michael. :) May I ask you to do a global replace of names of these two constants to CPU_REGISTERS_COUNT / IO_REGISTERS_COUNT or

Re: [PATCH 4/4] virtiofsd: Implement blocking posix locks

2019-11-22 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > As of now we don't support fcntl(F_SETLKW) and if we see one, we return > -EOPNOTSUPP. > > Change that by accepting these requests and returning a reply immediately > asking caller to wait. Once lock is available, send a notification to > the waiter

[PATCH v2 7/9] monitor/hmp: move remaining hmp_block* functions to block-hmp-cmds.c

2019-11-22 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- block/monitor/block-hmp-cmds.c | 63 + monitor/hmp-cmds.c | 64 -- 2 files changed, 63 insertions(+), 64 deletions(-) diff --git a/block/monitor/block-hmp-cmds.c

Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic

2019-11-22 Thread Aleksandar Markovic
> +#ifndef CONFIG_USER_ONLY > +/* Set the number of interrupts supported by the CPU. */ > +qdev_init_gpio_in(DEVICE(cpu), avr_cpu_set_int, 57); > +#endif Can you please, Michael, explain to me the origin of number "57" here? Thanks, Aleksandar

[PATCH v2 8/9] monitor/hmp: move hmp_info_block* to block-hmp-cmds.c

2019-11-22 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- block/monitor/block-hmp-cmds.c | 247 + monitor/hmp-cmds.c | 245 2 files changed, 247 insertions(+), 245 deletions(-) diff --git a/block/monitor/block-hmp-cmds.c

[PATCH v2 9/9] monitor/hmp: Prefer to use hmp_handle_error for error reporting in block hmp commands

2019-11-22 Thread Maxim Levitsky
This way they all will be prefixed with 'Error:' which some parsers (e.g libvirt) need Signed-off-by: Maxim Levitsky --- block/monitor/block-hmp-cmds.c | 35 -- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/block/monitor/block-hmp-cmds.c

Re: [PATCH v2 4/5] s390x: Move clear reset

2019-11-22 Thread Janosch Frank
On 11/22/19 3:30 PM, David Hildenbrand wrote: > On 22.11.19 15:00, Janosch Frank wrote: >> Let's also move the clear reset function into the reset handler. >> >> Signed-off-by: Janosch Frank >> --- >> target/s390x/cpu-qom.h | 1 + >> target/s390x/cpu.c | 50

Re: [PATCH v3 2/8] block: Add no_fallback parameter to bdrv_co_truncate()

2019-11-22 Thread Eric Blake
On 11/22/19 10:05 AM, Kevin Wolf wrote: This adds a no_fallback parameter to bdrv_co_truncate(), bdrv_truncate() and blk_truncate() in preparation for a fix that potentially needs to zero-write the new area. no_fallback will use BDRV_REQ_NO_FALLBACK for this operation and lets the truncate fail

[PATCH v2 3/9] monitor/hmp: move hmp_drive_del and hmp_commit to block-hmp-cmds.c

2019-11-22 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- block/monitor/block-hmp-cmds.c | 97 +- blockdev.c | 95 - 2 files changed, 96 insertions(+), 96 deletions(-) diff --git a/block/monitor/block-hmp-cmds.c

Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic

2019-11-22 Thread Aleksandar Markovic
> + > +static void avr_avr1_initfn(Object *obj) > +{ > +AVRCPU *cpu = AVR_CPU(obj); > +CPUAVRState *env = >env; > + > +avr_set_feature(env, AVR_FEATURE_LPM); > +avr_set_feature(env, AVR_FEATURE_2_BYTE_SP); > +avr_set_feature(env, AVR_FEATURE_2_BYTE_PC); > +} > + > +static void

[PATCH v2 4/9] monitor/hmp: move hmp_drive_mirror and hmp_drive_backup to block-hmp-cmds.c

2019-11-22 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- block/monitor/block-hmp-cmds.c | 61 ++ monitor/hmp-cmds.c | 58 2 files changed, 61 insertions(+), 58 deletions(-) diff --git a/block/monitor/block-hmp-cmds.c

[PATCH v2 5/9] monitor/hmp: move hmp_block_job* to block-hmp-cmds.c

2019-11-22 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- block/monitor/block-hmp-cmds.c | 52 ++ monitor/hmp-cmds.c | 52 -- 2 files changed, 52 insertions(+), 52 deletions(-) diff --git a/block/monitor/block-hmp-cmds.c

[PATCH v2 0/9] RFC: [for 5.0]: HMP monitor handlers cleanups

2019-11-22 Thread Maxim Levitsky
This patch series is bunch of cleanups to the hmp monitor code. This series only touched blockdev related hmp handlers. No functional changes expected other that light error message changes by the last patch. This was inspired by this bugzilla:

[PATCH v2 2/9] monitor/hmp: rename device-hotplug.c to block/monitor/block-hmp-cmds.c

2019-11-22 Thread Maxim Levitsky
These days device-hotplug.c only contains the hmp_drive_add In the next patch, rest of hmp_drive* functions will be moved there. Signed-off-by: Maxim Levitsky --- MAINTAINERS| 1 + Makefile.objs | 2 +-

Re: [PATCH v2 4/5] s390x: Move clear reset

2019-11-22 Thread Janosch Frank
On 11/22/19 3:30 PM, David Hildenbrand wrote: > On 22.11.19 15:00, Janosch Frank wrote: >> Let's also move the clear reset function into the reset handler. >> >> Signed-off-by: Janosch Frank >> --- >> target/s390x/cpu-qom.h | 1 + >> target/s390x/cpu.c | 50

Re: [PATCH 0/5] ppc/pnv: fix Homer/Occ mappings on multichip systems

2019-11-22 Thread Balamuruhan S
On Thu, Nov 21, 2019 at 11:00:12AM +0100, Cédric Le Goater wrote: > On 21/11/2019 10:11, Balamuruhan S wrote: > > On Wed, Nov 20, 2019 at 08:46:30AM +0100, Cédric Le Goater wrote: > >> Hello, > >> > >> On 19/11/2019 18:50, Balamuruhan S wrote: > >>> Hi All, > >>> > >>> PowerNV fails to boot in

[PATCH v2 6/9] monitor/hmp: move hmp_snapshot_* to block-hmp-cmds.c

2019-11-22 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- block/monitor/block-hmp-cmds.c | 47 ++ monitor/hmp-cmds.c | 46 - 2 files changed, 47 insertions(+), 46 deletions(-) diff --git a/block/monitor/block-hmp-cmds.c

[PATCH v2 1/9] monitor/hmp: uninline add_init_drive

2019-11-22 Thread Maxim Levitsky
This is only used by hmp_drive_add. The code is just a bit shorter this way. No functional changes Signed-off-by: Maxim Levitsky --- device-hotplug.c | 33 + 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/device-hotplug.c b/device-hotplug.c

Re: [PATCH for-4.2? v3 0/8] block: Fix resize (extending) of short overlays

2019-11-22 Thread Eric Blake
On 11/22/19 10:17 AM, Peter Maydell wrote: On Fri, 22 Nov 2019 at 16:08, Kevin Wolf wrote: See patch 4 for the description of the bug fixed. I guess my questions for trying to answer the "for-4.2?" question in the subject are: 1) is this a security (leaking data into the guest) bug ? 2)

Re: [PATCH] target/arm: Fix ISR_EL1 tracking when executing at EL2

2019-11-22 Thread Quentin Perret
On Friday 22 Nov 2019 at 13:58:33 (+), Marc Zyngier wrote: > The ARMv8 ARM states when executing at EL2, EL3 or Secure EL1, > ISR_EL1 shows the pending status of the physical IRQ, FIQ, or > SError interrupts. > > Unfortunately, QEMU's implementation only considers the HCR_EL2 > bits, and

Re: [PATCH 4/6] tests/test-util-filemonitor: Skip test on non-x86 Travis containers

2019-11-22 Thread Alex Bennée
Thomas Huth writes: > test-util-filemonitor fails in restricted non-x86 Travis containers > since they apparently blacklisted some required system calls there. > Let's simply skip the test if we detect such an environment. > > Signed-off-by: Thomas Huth Reviewed-by: Alex Bennée > --- >

Re: [PATCH 3/6] tests/hd-geo-test: Skip test when images can not be created

2019-11-22 Thread Alex Bennée
Thomas Huth writes: > In certain environments like restricted containers, we can not create > huge test images. To be able to use "make check" in such container > environments, too, let's skip the hd-geo-test instead of failing when > the test images could not be created. > > Signed-off-by:

Re: [PATCH for-4.2? v3 0/8] block: Fix resize (extending) of short overlays

2019-11-22 Thread Peter Maydell
On Fri, 22 Nov 2019 at 16:08, Kevin Wolf wrote: > > See patch 4 for the description of the bug fixed. I guess my questions for trying to answer the "for-4.2?" question in the subject are: 1) is this a security (leaking data into the guest) bug ? 2) is this a regression? 3) is this something a

Re: [PATCH] target/arm: Fix ISR_EL1 tracking when executing at EL2

2019-11-22 Thread Richard Henderson
On 11/22/19 2:16 PM, Peter Maydell wrote: > RTH: vaguely wondering if this might be related to the > bug you ran into trying to test your VHE emulation > patchset... Thanks for the thought. It might be related, but it isn't the final cause: the inner guest does not yet succeed including this

Re: [PATCH v2 1/5] s390x: Don't do a normal reset on the initial cpu

2019-11-22 Thread Cornelia Huck
On Fri, 22 Nov 2019 08:59:58 -0500 Janosch Frank wrote: > The initiating cpu needs to be reset with an initial reset. While > doing a normal reset followed by a initial reset is not wron per-se, s/wron per-se/wrong per se/ > the Ultravisor will only allow the correct reset to be performed.

[PATCH v3 5/8] iotests: Add qemu_io_log()

2019-11-22 Thread Kevin Wolf
Add a function that runs qemu-io and logs the output with the appropriate filters applied. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Reviewed-by: Stefan Hajnoczi --- tests/qemu-iotests/iotests.py | 5 + 1 file

[PATCH v3 7/8] iotests: Support job-complete in run_job()

2019-11-22 Thread Kevin Wolf
Automatically complete jobs that have a 'ready' state and need an explicit job-complete. Without this, run_job() would hang for such jobs. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Reviewed-by: Stefan Hajnoczi ---

Re: [Qemu-devel] [PATCH v4 03/14] qapi: Introduce default values for struct members

2019-11-22 Thread Kevin Wolf
Am 22.11.2019 um 15:40 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 22.11.2019 um 08:29 hat Markus Armbruster geschrieben: > >> > At any rate, your counterpoint is taken - whatever we pick, we'll want > >> > to make sure that introspection can expose semantics, and whether we

[PATCH v3 4/8] block: truncate: Don't make backing file data visible

2019-11-22 Thread Kevin Wolf
When extending the size of an image that has a backing file larger than its old size, make sure that the backing file data doesn't become visible in the guest, but the added area is properly zeroed out. Consider the following scenario where the overlay is shorter than its backing file:

[PATCH v3 6/8] iotests: Fix timeout in run_job()

2019-11-22 Thread Kevin Wolf
run_job() accepts a wait parameter for a timeout, but it doesn't actually use it. The only thing that is missing is passing it to events_wait(), so do that now. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Reviewed-by:

[PATCH v3 8/8] iotests: Test committing to short backing file

2019-11-22 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/qemu-iotests/274| 152 + tests/qemu-iotests/274.out| 203 ++ tests/qemu-iotests/group | 1 + tests/qemu-iotests/iotests.py | 2 +- 4 files changed, 357 insertions(+), 1 deletion(-)

[PATCH v3 3/8] qcow2: Declare BDRV_REQ_NO_FALLBACK supported

2019-11-22 Thread Kevin Wolf
In the common case, qcow2_co_pwrite_zeroes() already only modifies metadata case, so we're fine with or without BDRV_REQ_NO_FALLBACK set. The only exception is when using an external data file, where the request is passed down to the block driver of the external data file. We are forwarding the

[PATCH v3 2/8] block: Add no_fallback parameter to bdrv_co_truncate()

2019-11-22 Thread Kevin Wolf
This adds a no_fallback parameter to bdrv_co_truncate(), bdrv_truncate() and blk_truncate() in preparation for a fix that potentially needs to zero-write the new area. no_fallback will use BDRV_REQ_NO_FALLBACK for this operation and lets the truncate fail if an efficient zero write isn't possible.

[PATCH for-4.2? v3 0/8] block: Fix resize (extending) of short overlays

2019-11-22 Thread Kevin Wolf
See patch 4 for the description of the bug fixed. v3: - Don't allow blocking the monitor for a zero write in block_resize (even though we can already blockfor other reasons there). This is mainly responsible for the increased complexity compared to v2. Personally, I think this is not an

Re: [QUESTION] Usage of '0b' as a prefix for numerical constants?

2019-11-22 Thread Peter Maydell
On Fri, 22 Nov 2019 at 14:57, Aleksandar Markovic wrote: > I remember a while ago, something stopped me from using '0b' as a > prefix in my own code (was it checkpatch.pl, or perhaps some statement > on coding style, or a compiler, or something else - I don't really > remember), so I didn't use

[PATCH v3 1/8] block: bdrv_co_do_pwrite_zeroes: 64 bit 'bytes' parameter

2019-11-22 Thread Kevin Wolf
bdrv_co_do_pwrite_zeroes() can already cope with maximum request sizes by calling the driver in a loop until everything is done. Make the small remaining change that is necessary to let it accept a 64 bit byte count. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Vladimir

Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support

2019-11-22 Thread Beata Michalska
Hi, On Mon, 18 Nov 2019 at 12:50, gengdongjiu wrote: > > Hi,Igor, >Thanks for you review and time. > > > > >> +/* > >> + * Type: > >> + * Generic Hardware Error Source version 2(GHESv2 - Type 10) > >> + */ > >> +build_append_int_noprefix(table_data, > >>

Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support

2019-11-22 Thread Beata Michalska
Hi Xiang, On Mon, 11 Nov 2019 at 01:48, Xiang Zheng wrote: > > From: Dongjiu Geng > > This patch implements APEI GHES Table generation via fw_cfg blobs. Now > it only supports ARMv8 SEA, a type of GHESv2 error source. Afterwards, > we can extend the supported types if needed. For the CPER

Re: [PATCH v35 10/13] target/avr: Add limited support for USART and 16 bit timer peripherals

2019-11-22 Thread Philippe Mathieu-Daudé
On 11/22/19 3:41 PM, Aleksandar Markovic wrote: On Tue, Oct 29, 2019 at 10:25 PM Michael Rolnik wrote: From: Sarah Harris These were designed to facilitate testing but should provide enough function to be useful in other contexts. Only a subset of the functions of each peripheral is

Re: [RESEND PATCH v21 5/6] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

2019-11-22 Thread Beata Michalska
Hi, On Mon, 11 Nov 2019 at 01:48, Xiang Zheng wrote: > > From: Dongjiu Geng > > Add a SIGBUS signal handler. In this handler, it checks the SIGBUS type, > translates the host VA delivered by host to guest PA, then fills this PA > to guest APEI GHES memory, then notifies guest according to the

Re: [PATCH] ipmi: add SET_SENSOR_READING command

2019-11-22 Thread Cédric Le Goater
On 22/11/2019 15:28, Corey Minyard wrote: > On Mon, Nov 18, 2019 at 10:24:29AM +0100, Cédric Le Goater wrote: >> SET_SENSOR_READING is a complex IPMI command (see IPMI spec 35.17) >> which enables the host software to set the reading value and the event >> status of sensors supporting it. >> >>

Re: [RESEND PATCH v21 5/6] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

2019-11-22 Thread Beata Michalska
Hi, On Fri, 15 Nov 2019 at 16:54, Igor Mammedov wrote: > > On Mon, 11 Nov 2019 09:40:47 +0800 > Xiang Zheng wrote: > > > From: Dongjiu Geng > > > > Add a SIGBUS signal handler. In this handler, it checks the SIGBUS type, > > translates the host VA delivered by host to guest PA, then fills this

Re: [PATCH] target/arm: Fix ISR_EL1 tracking when executing at EL2

2019-11-22 Thread Philippe Mathieu-Daudé
On 11/22/19 3:16 PM, Peter Maydell wrote: On Fri, 22 Nov 2019 at 13:59, Marc Zyngier wrote: The ARMv8 ARM states when executing at EL2, EL3 or Secure EL1, ISR_EL1 shows the pending status of the physical IRQ, FIQ, or SError interrupts. Unfortunately, QEMU's implementation only considers the

Re: [QUESTION] Usage of '0b' as a prefix for numerical constants?

2019-11-22 Thread Philippe Mathieu-Daudé
On 11/22/19 4:10 PM, Eric Blake wrote: On 11/22/19 8:56 AM, Aleksandar Markovic wrote: Hello, all. I am currently reviewing some code, and I see it uses '0b' as a prefix of numerical constants, similar to these examples: switch (((inst >> 22) & 0b111000) | ((inst >> 12) & 0b000111)) {

Re: [PATCH v2 4/5] MAINTAINERS: Adjust maintainership for R4000 systems

2019-11-22 Thread Philippe Mathieu-Daudé
On 11/22/19 3:14 PM, Aleksandar Markovic wrote: On Fri, Nov 22, 2019 at 2:58 PM Philippe Mathieu-Daudé wrote: Hi Aleksandar, On 11/13/19 2:47 PM, Aleksandar Markovic wrote: From: Aleksandar Markovic Change the maintainership for R4000 systems to improve its quality. Acked-by: Aurelien

  1   2   3   >