Re: [PATCH] vhost-user-test: fix a memory leak

Hi! On 11/12/2019 01.55, pannengy...@huawei.com wrote: [...] > diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c > index 91ea373..54be931 100644 > --- a/tests/vhost-user-test.c > +++ b/tests/vhost-user-test.c > @@ -717,6 +717,8 @@ static void test_migrate(void *obj, void *arg, >

Re: [PATCH 0/5] ARM virt: Add NVDIMM support

On Mon, 9 Dec 2019 17:39:15 + Shameerali Kolothum Thodi wrote: > Hi Igor/ xiaoguangrong, > > > -Original Message- > > From: Shameerali Kolothum Thodi > > Sent: 28 November 2019 12:36 > > To: 'Igor Mammedov' ; > > xiaoguangrong.e...@gmail.com > > Cc: peter.mayd...@linaro.org;

Re: [PATCH] vhost-user-test: fix a memory leak

On 11/12/2019 01:55, pannengy...@huawei.com wrote: > From: Pan Nengyuan > > Spotted by ASAN. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan > --- > tests/vhost-user-test.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/vhost-user-test.c

Re: [PATCH for-4.2? v3 0/8] block: Fix resize (extending) of short overlays

On 10.12.19 18:46, Kevin Wolf wrote: > Am 22.11.2019 um 17:05 hat Kevin Wolf geschrieben: >> See patch 4 for the description of the bug fixed. > > I'm applying patches 3 and 5-7 to the block branch because they make > sense on their own. > > The real fix will need another approach because the

Re: [RFC PATCH 4/9] vfio-pci: register default dynamic-trap-bar-info region

On Wed, Dec 11, 2019 at 12:38:05AM +0800, Alex Williamson wrote: > On Tue, 10 Dec 2019 02:44:44 -0500 > Yan Zhao wrote: > > > On Tue, Dec 10, 2019 at 05:16:08AM +0800, Alex Williamson wrote: > > > On Mon, 9 Dec 2019 01:22:12 -0500 > > > Yan Zhao wrote: > > > > > > > On Fri, Dec 06, 2019 at

Re: [PATCH v1 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest

On Wed, Dec 11, 2019 at 10:38:24AM +0530, Bharata B Rao wrote: > On Wed, Dec 11, 2019 at 10:41:32AM +1100, David Gibson wrote: > > On Tue, Dec 10, 2019 at 12:20:07PM +0530, Bharata B Rao wrote: > > > On Tue, Dec 10, 2019 at 04:05:36PM +1100, David Gibson wrote: > > > > On Tue, Dec 10, 2019 at

Re: [PATCH v1 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest

On Wed, Dec 11, 2019 at 10:41:32AM +1100, David Gibson wrote: > On Tue, Dec 10, 2019 at 12:20:07PM +0530, Bharata B Rao wrote: > > On Tue, Dec 10, 2019 at 04:05:36PM +1100, David Gibson wrote: > > > On Tue, Dec 10, 2019 at 03:03:01PM +1100, Alexey Kardashevskiy wrote: > > > > > > > > > > > > On

Re: guest / host buffer sharing ...

There are three issues being discussed here that aren't being clearly delineated: sharing guest allocated memory with the host, sharing host allocated memory with the guest, and sharing buffers between devices. Right now, guest allocated memory can be shared with the host through the virtqueues

Re: [PATCH v3 2/3] spapr: Add NVDIMM device support

On 12/06/2019 07:22 AM, David Gibson wrote: On Wed, Nov 27, 2019 at 09:50:54AM +0530, Bharata B Rao wrote: On Fri, Nov 22, 2019 at 10:42 AM David Gibson wrote: Ok. A number of queries about this. 1) The PAPR spec for ibm,dynamic-memory-v2 says that the first word in each entry is the

Re: [RFC PATCH 1/9] vfio/pci: introduce mediate ops to intercept vfio-pci ops

On Wed, Dec 11, 2019 at 12:58:24AM +0800, Alex Williamson wrote: > On Mon, 9 Dec 2019 21:44:23 -0500 > Yan Zhao wrote: > > > > > > > Currently, yes, i40e has build dependency on vfio-pci. > > > > > > It's like this, if i40e decides to support SRIOV and compiles in vf > > > > > > related code who

[PATCH] vhost-user-test: fix a memory leak

From: Pan Nengyuan Spotted by ASAN. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan --- tests/vhost-user-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index 91ea373..54be931 100644 --- a/tests/vhost-user-test.c +++

Re: [PATCH] ppc: Drop useless extern annotation for functions

On Tue, Dec 10, 2019 at 09:09:20AM +0100, Greg Kurz wrote: Applied to ppc-for-5.0. > Signed-off-by: Greg Kurz > --- > include/hw/ppc/pnv_xscom.h | 22 +++--- > include/hw/ppc/spapr_vio.h |6 +++--- > 2 files changed, 14 insertions(+), 14 deletions(-) > > diff --git

Re: [PATCH 1/2] ppc/pnv: Loop on the whole hierarchy to populate the DT with the XSCOM nodes

On Tue, Dec 10, 2019 at 05:49:01PM +0100, Greg Kurz wrote: > On Tue, 10 Dec 2019 14:58:44 +0100 > Cédric Le Goater wrote: > > > Some PnvXScomInterface objects lie a bit deeper (PnvPBCQState) than > > I didn't find any trace of PnvPBCQState in the code... what is it ? > > > the first layer, so

Re: [PATCH 0/2] ppc/pnv: minor XSCOM fixes

On Tue, Dec 10, 2019 at 02:58:43PM +0100, Cédric Le Goater wrote: > Hello, > > Here are a couple of fixes/cleanups for the PowerNV XSCOM bus. Applied to ppc-for-5.0, thanks. > > Thanks, > > C. > > Cédric Le Goater (2): > ppc/pnv: Loop on the whole hierarchy to populate the DT with the

Re: [PATCH 2/5] ppc/pnv: Introduce a POWER10 PnvChip and a powernv10 machine

On Tue, Dec 10, 2019 at 09:52:05AM +0100, Cédric Le Goater wrote: > On 10/12/2019 04:34, David Gibson wrote: > >> +static inline bool pnv_chip_is_power10(const PnvChip *chip) > >> +{ > >> +return PNV_CHIP_GET_CLASS(chip)->chip_type == PNV_CHIP_POWER10; > >> +} > >> + > >> +static inline bool

Re: [PATCH v1 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest

On Tue, Dec 10, 2019 at 12:20:07PM +0530, Bharata B Rao wrote: > On Tue, Dec 10, 2019 at 04:05:36PM +1100, David Gibson wrote: > > On Tue, Dec 10, 2019 at 03:03:01PM +1100, Alexey Kardashevskiy wrote: > > > > > > > > > On 10/12/2019 14:50, Bharata B Rao wrote: > > > > On Tue, Dec 10, 2019 at

Re: [PATCH v2 1/1] display/bochs-display: fix memory leak

On 12/11/19 12:28 AM, Aleksandar Markovic wrote: On Wednesday, December 11, 2019, Philippe Mathieu-Daudé mailto:phi...@redhat.com>> wrote: On 12/10/19 10:27 PM, Cameron Esfahani via wrote: Fix memory leak in bochs_display_update().  Leaks 304 bytes per frame.

Re: [PATCH v2 1/1] display/bochs-display: fix memory leak

On Wednesday, December 11, 2019, Philippe Mathieu-Daudé wrote: > On 12/10/19 10:27 PM, Cameron Esfahani via wrote: > >> Fix memory leak in bochs_display_update(). Leaks 304 bytes per frame. >> >> Signed-off-by: Cameron Esfahani >> > > Funny to have a dirty@ email fixing a DirtyBitmapSnapshot

Re: [PATCH v2 1/1] display/bochs-display: fix memory leak

On 12/10/19 10:27 PM, Cameron Esfahani via wrote: Fix memory leak in bochs_display_update(). Leaks 304 bytes per frame. Signed-off-by: Cameron Esfahani Funny to have a dirty@ email fixing a DirtyBitmapSnapshot leak =) Fixes: 33ebad54056 Reviewed-by: Philippe Mathieu-Daudé ---

Re: [PATCH 0/2] hw/arm: ast2600: Wire up eMMC controller

On Tue, 10 Dec 2019, at 19:23, Cédric Le Goater wrote: > On 10/12/2019 01:52, Andrew Jeffery wrote: > > Hello, > > > > The AST2600 has an additional SDHCI intended for use as an eMMC boot source. > > Have you also considered booting the QEMU Aspeed AST2600 machine > from the eMMC device ? >

Re: [PATCH 1/2] hw/sd: Configure number of slots exposed by the ASPEED SDHCI model

On Tue, 10 Dec 2019, at 19:26, Cédric Le Goater wrote: > On 10/12/2019 01:52, Andrew Jeffery wrote: > > The AST2600 includes a second cut-down version of the SD/MMC controller > > found in the AST2500, named the eMMC controller. It's cut down in the > > sense that it only supports one slot

Re: [PATCH 2/2] hw/arm: ast2600: Wire up the eMMC controller

On Tue, 10 Dec 2019, at 23:22, Cédric Le Goater wrote: > On 10/12/2019 01:52, Andrew Jeffery wrote: > > Initialise another SDHCI model instance for the AST2600's eMMC > > controller and use the SDHCI's num_slots value introduced previously to > > determine whether we should create an SD card

[PATCH v2 0/1] Fix bochs memory leak

Fix a small memory leak in the Bochs display driver. Each frame would leak about 304 bytes. v2: Add missing signed-off-by line. Cameron Esfahani (1): display/bochs-display: fix memory leak hw/display/bochs-display.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.24.0

[PATCH v2 1/1] display/bochs-display: fix memory leak

Fix memory leak in bochs_display_update(). Leaks 304 bytes per frame. Signed-off-by: Cameron Esfahani --- hw/display/bochs-display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c index dc1bd1641d..215db9a231 100644 ---

Re: [PATCH 2/2] ppc/pnv: populate the DT with realized XSCOM devices

On Tue, 10 Dec 2019 14:58:45 +0100 Cédric Le Goater wrote: > Some devices could be initialized in the instance_init handler but not > realized for configuration reasons. Nodes should not be added in the DT > for such devices. > > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz

Re: [PATCH 1/2] ppc/pnv: Loop on the whole hierarchy to populate the DT with the XSCOM nodes

On Tue, 10 Dec 2019 14:58:44 +0100 Cédric Le Goater wrote: > Some PnvXScomInterface objects lie a bit deeper (PnvPBCQState) than > the first layer, so we need to loop on the whole object hierarchy to > catch them. > > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz >

Re: [PATCH v1 0/1] Fix bochs memory leak

Patchew URL: https://patchew.org/QEMU/cover.1576012190.git.di...@apple.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v1 0/1] Fix bochs memory leak Type: series Message-id: cover.1576012190.git.di...@apple.com === TEST

[PATCH v1 1/1] display/bochs-display: fix memory leak

Fix memory leak in bochs_display_update(). Leaks 304 bytes per frame. --- hw/display/bochs-display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c index dc1bd1641d..215db9a231 100644 --- a/hw/display/bochs-display.c +++

[PATCH v1 0/1] Fix bochs memory leak

Fix a small memory leak in the Bochs display driver. Each frame would leak about 304 bytes. Cameron Esfahani (1): display/bochs-display: fix memory leak hw/display/bochs-display.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.24.0

Re: [PATCH v38 04/22] target/avr: Add instruction translation - Registers definition

On Sun, Dec 8, 2019 at 7:40 PM Michael Rolnik wrote: > > Signed-off-by: Michael Rolnik > Reviewed-by: Philippe Mathieu-Daudé > Tested-by: Philippe Mathieu-Daudé > --- > target/avr/translate.c | 143 + > 1 file changed, 143 insertions(+) > create mode

Re: [PATCH v38 17/22] target/avr: Register AVR support with the rest of QEMU

On Mon, Dec 9, 2019 at 7:31 PM Michael Rolnik wrote: > > I prefer to remove it, as nobody uses it. what do you think? the full list is > in target/avr/cpu.h file > I have mixed filings about that. I can just imagine someone in future might make a "superassembler" that uses this header, and

Re: [PATCH v38 05/22] target/avr: Add instruction translation - Arithmetic and Logic Instructions

On Sun, Dec 8, 2019 at 7:40 PM Michael Rolnik wrote: > + > +/* > + * Performs the logical AND between the contents of register Rd and register > + * Rr and places the result in the destination register Rd. > + */ > +static bool trans_AND(DisasContext *ctx, arg_AND *a) > +{ > +TCGv Rd =

[ANNOUNCE] QEMU 4.2.0-rc5 is now available

Hello, On behalf of the QEMU Team, I'd like to announce the availability of the sixth release candidate for the QEMU 4.2 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-4.2.0-rc5.tar.xz

Re: [bugfix ping2] Re: [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap

On 12/10/19 8:24 AM, Max Reitz wrote: > On 10.12.19 09:11, Max Reitz wrote: >> On 09.12.19 23:03, Eric Blake wrote: >>> On 12/9/19 11:58 AM, Max Reitz wrote: On 09.12.19 17:30, Max Reitz wrote: > On 02.12.19 15:09, Vladimir Sementsov-Ogievskiy wrote: >> Hi again! >> >>

Re: [PATCH 00/10] Add Allwinner H3 SoC and Orange Pi PC Machine

Hi Philippe, On Tue, Dec 10, 2019 at 9:26 AM Philippe Mathieu-Daudé wrote: > On 12/9/19 10:37 PM, Niek Linnenbank wrote: > > Hi Philippe, > > > > On Tue, Dec 3, 2019 at 9:47 AM Philippe Mathieu-Daudé > > wrote: > > > > On 12/2/19 10:09 PM, Niek Linnenbank wrote: >

Re: [PATCH for-5.0 v11 18/20] virtio-iommu: Support migration

On Fri, Nov 22, 2019 at 07:29:41PM +0100, Eric Auger wrote: > +static const VMStateDescription vmstate_virtio_iommu_device = { > +.name = "virtio-iommu-device", > +.minimum_version_id = 1, > +.version_id = 1, > +.post_load = iommu_post_load, > +.fields = (VMStateField[]) { > +

Re: [PATCH 00/10] Add Allwinner H3 SoC and Orange Pi PC Machine

Hi Frederic, On Tue, Dec 10, 2019 at 11:34 AM KONRAD Frederic < frederic.kon...@adacore.com> wrote: > > > Le 12/2/19 à 10:09 PM, Niek Linnenbank a écrit : > > Dear QEMU developers, > > > > Hereby I would like to contribute the following set of patches to QEMU > > which add support for the

Re: BeagleBone support, omap1, omap2, omap3, etc.

Hello Philippe and Esteban, On Tue, Dec 10, 2019 at 10:55 AM Philippe Mathieu-Daudé wrote: > Hi Esteban, > > On 12/3/19 4:24 PM, Esteban Bosse wrote: > > Ping > > > > El mié., 6 nov. 2019 16:04, Esteban Bosse > > escribió: > > > > Hello! > > > > Some

Re: [PATCH for-5.0 v11 14/20] virtio-iommu: Handle reserved regions in the translation process

On Fri, Nov 22, 2019 at 07:29:37PM +0100, Eric Auger wrote: > When translating an address we need to check if it belongs to > a reserved virtual address range. If it does, there are 2 cases: > > - it belongs to a RESERVED region: the guest should neither use > this address in a MAP not instruct

Re: [PATCH for-5.0 v11 13/20] virtio-iommu: Implement probe request

On Fri, Nov 22, 2019 at 07:29:36PM +0100, Eric Auger wrote: > This patch implements the PROBE request. At the moment, > no reserved regions are returned as none are registered > per device. Only a NONE property is returned. > > Signed-off-by: Eric Auger Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

On Fri, Nov 22, 2019 at 07:29:31PM +0100, Eric Auger wrote: > This patch implements the translate callback > > Signed-off-by: Eric Auger > > --- > > v10 -> v11: > - take into account the new value struct and use > g_tree_lookup_extended > - switched to error_report_once > > v6 -> v7: > -

Re: [PATCH 2/2] analyze-migration.py: replace numpy with python 3.2

On Tue, Dec 10, 2019 at 12:57:28PM -0500, Cleber Rosa wrote: > On Tue, Dec 10, 2019 at 12:49:11PM -0500, Cleber Rosa wrote: > > On Tue, Dec 10, 2019 at 02:14:18PM +0400, Marc-André Lureau wrote: > > > Hi > > > > > > On Tue, Dec 10, 2019 at 6:59 AM Eduardo Habkost > > > wrote: > > > > > > > > On

Re: Avocado notes from KVM forum 2019

On Mon, Nov 25, 2019 at 3:10 PM Cleber Rosa wrote: > > On Mon, Nov 25, 2019 at 10:58:02AM -0300, Eduardo Habkost wrote: > > Thank you, Philippe, those are great ideas. I have copied them > > to the Avocado+QEMU Trello board so we don't forget about them: > >

Re: [PATCH for-5.0 v11 04/20] virtio-iommu: Add the iommu regions

On Fri, Nov 22, 2019 at 07:29:27PM +0100, Eric Auger wrote: > This patch initializes the iommu memory regions so that > PCIe end point transactions get translated. The translation > function is not yet implemented though. > > Signed-off-by: Eric Auger Either with/without Jean's comment

Re: [PATCH 01/10] hw: arm: add Allwinner H3 System-on-Chip

Hi Philippe, On Tue, Dec 10, 2019 at 10:02 AM Philippe Mathieu-Daudé wrote: > On 12/2/19 10:09 PM, Niek Linnenbank wrote: > > The Allwinner H3 is a System on Chip containing four ARM Cortex A7 > > processor cores. Features and specifications include DDR2/DDR3 memory, > > SD/MMC storage cards,

Re: [PATCH 02/10] hw: arm: add Xunlong Orange Pi PC machine

Hi Philippe, On Tue, Dec 10, 2019 at 9:59 AM Philippe Mathieu-Daudé wrote: > On 12/6/19 11:15 PM, Niek Linnenbank wrote: > [...] > > > > +static void orangepi_machine_init(MachineClass *mc) > > > > +{ > > > > +mc->desc = "Orange Pi PC"; > > > > +

Re: [PATCH for-5.0 v11 03/20] virtio-iommu: Decode the command payload

On Fri, Nov 22, 2019 at 07:29:26PM +0100, Eric Auger wrote: > This patch adds the command payload decoding and > introduces the functions that will do the actual > command handling. Those functions are not yet implemented. > > Signed-off-by: Eric Auger I would simply squash this into previous

Re: [PATCH 04/10] arm: allwinner-h3: add USB host controller

Hi Gerd, On Tue, Dec 10, 2019 at 9:29 AM Gerd Hoffmann wrote: > On Tue, Dec 10, 2019 at 08:56:02AM +0100, Philippe Mathieu-Daudé wrote: > > On 12/2/19 10:09 PM, Niek Linnenbank wrote: > > > The Allwinner H3 System on Chip contains multiple USB 2.0 bus > > > connections which provide software

Re: [PATCH v1 00/36] Add RISC-V Hypervisor Extension v0.5

On Tue, Dec 10, 2019 at 1:04 AM Alistair Francis wrote: > > On Mon, Dec 9, 2019 at 2:55 PM Aleksandar Markovic > wrote: > > > > > > > > On Monday, December 9, 2019, Alistair Francis > > wrote: > >> > >> This patch series adds the RISC-V Hypervisor extension v0.5. This is the > >> latest draft

Re: [PATCH] riscv/sifive_u: fix a memory leak in soc_realize()

On Mon, Dec 9, 2019 at 11:15 PM wrote: > > From: Pan Nengyuan > > Fix a minor memory leak in riscv_sifive_u_soc_realize() > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan Reviewed-by: Alistair Francis Alistair > --- > hw/riscv/sifive_u.c | 1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH 1/2] ppc/pnv: Loop on the whole hierarchy to populate the DT with the XSCOM nodes

On 10/12/2019 18:08, Cédric Le Goater wrote: > On 10/12/2019 17:49, Greg Kurz wrote: >> On Tue, 10 Dec 2019 14:58:44 +0100 >> Cédric Le Goater wrote: >> >>> Some PnvXScomInterface objects lie a bit deeper (PnvPBCQState) than >> >> I didn't find any trace of PnvPBCQState in the code... what is it

Re: [PATCH 2/2] analyze-migration.py: replace numpy with python 3.2

On Tue, Dec 10, 2019 at 12:49:11PM -0500, Cleber Rosa wrote: > On Tue, Dec 10, 2019 at 02:14:18PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Tue, Dec 10, 2019 at 6:59 AM Eduardo Habkost wrote: > > > > > > On Fri, Dec 06, 2019 at 09:27:23AM -0500, Cleber Rosa wrote: > > > > On Wed, Nov 27,

Re: [PATCH 2/2] analyze-migration.py: replace numpy with python 3.2

On Tue, Dec 10, 2019 at 02:14:18PM +0400, Marc-André Lureau wrote: > Hi > > On Tue, Dec 10, 2019 at 6:59 AM Eduardo Habkost wrote: > > > > On Fri, Dec 06, 2019 at 09:27:23AM -0500, Cleber Rosa wrote: > > > On Wed, Nov 27, 2019 at 02:10:38PM +0400, Marc-André Lureau wrote: > > > > Use

Re: [PATCH for-4.2? v3 0/8] block: Fix resize (extending) of short overlays

Am 22.11.2019 um 17:05 hat Kevin Wolf geschrieben: > See patch 4 for the description of the bug fixed. I'm applying patches 3 and 5-7 to the block branch because they make sense on their own. The real fix will need another approach because the error handling is broken in this one: If zeroing out

Re: [PATCH v2 15/18] xen: convert "-machine igd-passthru" to an accelerator property

On 10/12/19 13:56, Marc-André Lureau wrote: >> +if (g_str_equal(qom_name, "igd-passthru")) { >> +object_register_sugar_prop(ACCEL_CLASS_NAME("xen"), qom_name, >> value); > > shouldn't it warn about deprecation? The old version is not deprecated (I'm only deprecating -tb-size because

Re: [PATCH v6] migration: Support QLIST migration

On Fri, Nov 22, 2019 at 06:16:21PM +0100, Eric Auger wrote: > Support QLIST migration using the same principle as QTAILQ: > 94869d5c52 ("migration: migrate QTAILQ"). > > The VMSTATE_QLIST_V macro has the same proto as VMSTATE_QTAILQ_V. > The change mainly resides in QLIST RAW macros:

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

On Tue, 2019-12-10 at 17:08 +0100, Andrew Jones wrote: > I don't have a strong enough opinion about kvm-adjvtime vs. > kvm-no-adjvtime to insist one way or another. I agree double inversions > are easier to mess up, but I also like the way the '-no-' better > communicates that the default is

Re: [PATCH 2/2] ppc/pnv: populate the DT with realized XSCOM devices

On 10/12/2019 17:53, Greg Kurz wrote: > On Tue, 10 Dec 2019 14:58:45 +0100 > Cédric Le Goater wrote: > >> Some devices could be initialized in the instance_init handler but not >> realized for configuration reasons. Nodes should not be added in the DT >> for such devices. >> > > Do you have

Re: [PATCH 1/2] ppc/pnv: Loop on the whole hierarchy to populate the DT with the XSCOM nodes

On 10/12/2019 17:49, Greg Kurz wrote: > On Tue, 10 Dec 2019 14:58:44 +0100 > Cédric Le Goater wrote: > >> Some PnvXScomInterface objects lie a bit deeper (PnvPBCQState) than > > I didn't find any trace of PnvPBCQState in the code... what is it ? PHB4, which is not merged yet. C. > >> the

Re: [PATCH v3] qga: fence guest-set-time if hwclock not available

On Thu, 5 Dec 2019 12:53:50 +0100 Cornelia Huck wrote: > The Posix implementation of guest-set-time invokes hwclock to > set/retrieve the time to/from the hardware clock. If hwclock > is not available, the user is currently informed that "hwclock > failed to set hardware clock to system time",

Re: [PATCH 2/2] ppc/pnv: populate the DT with realized XSCOM devices

On Tue, 10 Dec 2019 14:58:45 +0100 Cédric Le Goater wrote: > Some devices could be initialized in the instance_init handler but not > realized for configuration reasons. Nodes should not be added in the DT > for such devices. > Do you have examples of such devices to share ? > Signed-off-by:

Re: [RFC PATCH 1/9] vfio/pci: introduce mediate ops to intercept vfio-pci ops

On Mon, 9 Dec 2019 21:44:23 -0500 Yan Zhao wrote: > > > > > Currently, yes, i40e has build dependency on vfio-pci. > > > > > It's like this, if i40e decides to support SRIOV and compiles in vf > > > > > related code who depends on vfio-pci, it will also have build > > > > > dependency > > > > >

Re: [PATCH] hw/arm/virt: Second uart for normal-world

On Mon, Dec 09, 2019 at 05:10:30PM +, Peter Maydell wrote: > On Mon, 9 Dec 2019 at 17:08, Daniel Thompson > wrote: > > I don't object to making it command line dependant (it is certainly > > lower risk) but, out of interest, has using /aliases to force the > > kernel to enumerate the serial

Re: [PATCH for-5.0 v11 19/20] pc: Add support for virtio-iommu-pci

On Fri, Nov 22, 2019 at 07:29:42PM +0100, Eric Auger wrote: > The virtio-iommu-pci is instantiated through the -device QEMU > option. However if instantiated it also requires an IORT ACPI table > to describe the ID mappings between the root complex and the iommu. > > This patch adds the

Re: [PATCH for-5.0 v11 17/20] hw/arm/virt-acpi-build: Add virtio-iommu node in IORT table

On Fri, Nov 22, 2019 at 07:29:40PM +0100, Eric Auger wrote: > This patch builds the virtio-iommu node in the ACPI IORT table. > > The RID space of the root complex, which spans 0x0-0x1 > maps to streamid space 0x0-0x1 in the virtio-iommu which in > turn maps to deviceid space 0x0-0x1

Re: [PATCH for-5.0 v11 13/20] virtio-iommu: Implement probe request

On Fri, Nov 22, 2019 at 07:29:36PM +0100, Eric Auger wrote: > This patch implements the PROBE request. At the moment, > no reserved regions are returned as none are registered > per device. Only a NONE property is returned. > > Signed-off-by: Eric Auger Reviewed-by: Jean-Philippe Brucker

Re: [PATCH for-5.0 v11 16/20] hw/arm/virt-acpi-build: Introduce fill_iort_idmap helper

On Fri, Nov 22, 2019 at 07:29:39PM +0100, Eric Auger wrote: > build_iort(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) > { > @@ -426,13 +437,12 @@ build_iort(GArray *table_data, BIOSLinker *linker, > VirtMachineState *vms) > smmu->gerr_gsiv = cpu_to_le32(irq + 2); >

Re: [PATCH 1/2] ppc/pnv: Loop on the whole hierarchy to populate the DT with the XSCOM nodes

On Tue, 10 Dec 2019 14:58:44 +0100 Cédric Le Goater wrote: > Some PnvXScomInterface objects lie a bit deeper (PnvPBCQState) than I didn't find any trace of PnvPBCQState in the code... what is it ? > the first layer, so we need to loop on the whole object hierarchy to > catch them. > >

Re: [PATCH for-5.0 v11 11/20] hw/arm/virt: Add the virtio-iommu device tree mappings

On Fri, Nov 22, 2019 at 07:29:34PM +0100, Eric Auger wrote: > diff --git a/hw/virtio/virtio-iommu-pci.c b/hw/virtio/virtio-iommu-pci.c > index 280230b31e..4cfae1f9df 100644 > --- a/hw/virtio/virtio-iommu-pci.c > +++ b/hw/virtio/virtio-iommu-pci.c > @@ -31,9 +31,6 @@ struct VirtIOIOMMUPCI { > >

Re: [PATCH for-5.0 v11 18/20] virtio-iommu: Support migration

On Fri, Nov 22, 2019 at 07:29:41PM +0100, Eric Auger wrote: > +static const VMStateDescription vmstate_virtio_iommu_device = { > +.name = "virtio-iommu-device", > +.minimum_version_id = 1, > +.version_id = 1, > +.post_load = iommu_post_load, > +.fields = (VMStateField[]) { > +

Re: [PATCH for-5.0 v11 15/20] virtio-iommu-pci: Add array of Interval properties

On Fri, Nov 22, 2019 at 07:29:38PM +0100, Eric Auger wrote: > The machine may need to pass reserved regions to the > virtio-iommu-pci device (such as the MSI window on x86). > So let's add an array of Interval properties. > > Signed-off-by: Eric Auger Reviewed-by: Jean-Philippe Brucker

Re: [PATCH for-5.0 v11 14/20] virtio-iommu: Handle reserved regions in the translation process

On Fri, Nov 22, 2019 at 07:29:37PM +0100, Eric Auger wrote: > +for (i = 0; i < s->nb_reserved_regions; i++) { > +if (interval.low >= s->reserved_regions[i].low && > +interval.low <= s->reserved_regions[i].high) { > +switch (s->reserved_regions[i].type) { > +

Re: [PATCH for-5.0 v11 10/20] virtio-iommu-pci: Add virtio iommu pci support

On Fri, Nov 22, 2019 at 07:29:33PM +0100, Eric Auger wrote: > This patch adds virtio-iommu-pci, which is the pci proxy for > the virtio-iommu device. > > Signed-off-by: Eric Auger Reviewed-by: Jean-Philippe Brucker

Re: [PATCH for-5.0 v11 09/20] virtio-iommu: Implement fault reporting

On Fri, Nov 22, 2019 at 07:29:32PM +0100, Eric Auger wrote: > @@ -443,6 +489,8 @@ static IOMMUTLBEntry > virtio_iommu_translate(IOMMUMemoryRegion *mr, hwaddr addr, > if (!ep) { > if (!bypass_allowed) { > error_report_once("%s sid=%d is not known!!", __func__, sid); > +

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

On Fri, Nov 22, 2019 at 07:29:31PM +0100, Eric Auger wrote: > This patch implements the translate callback > > Signed-off-by: Eric Auger Reviewed-by: Jean-Philippe Brucker

Re: [PATCH for-5.0 v11 07/20] virtio-iommu: Implement map/unmap

On Fri, Nov 22, 2019 at 07:29:30PM +0100, Eric Auger wrote: > @@ -238,10 +244,35 @@ static int virtio_iommu_map(VirtIOIOMMU *s, > uint64_t virt_start = le64_to_cpu(req->virt_start); > uint64_t virt_end = le64_to_cpu(req->virt_end); > uint32_t flags = le32_to_cpu(req->flags); > +

Re: [PATCH for-5.0 v11 06/20] virtio-iommu: Implement attach/detach command

On Fri, Nov 22, 2019 at 07:29:29PM +0100, Eric Auger wrote: > diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c > index 235bde2203..138d5b2a9c 100644 > --- a/hw/virtio/virtio-iommu.c > +++ b/hw/virtio/virtio-iommu.c > @@ -77,11 +77,12 @@ static gint interval_cmp(gconstpointer a,

Re: [PATCH v1 2/5] timer: arm: Introduce functions to get the host cntfrq

On Tue, Dec 10, 2019 at 03:47:39PM +, Peter Maydell wrote: > On Wed, 16 Oct 2019 at 15:34, Andrew Jones wrote: > > > > When acceleration like KVM is in use it's necessary to use the host's > > counter frequency when converting ticks to or from time units. > > > > Signed-off-by: Andrew Jones

Re: [RFC PATCH 4/9] vfio-pci: register default dynamic-trap-bar-info region

On Tue, 10 Dec 2019 02:44:44 -0500 Yan Zhao wrote: > On Tue, Dec 10, 2019 at 05:16:08AM +0800, Alex Williamson wrote: > > On Mon, 9 Dec 2019 01:22:12 -0500 > > Yan Zhao wrote: > > > > > On Fri, Dec 06, 2019 at 11:20:38PM +0800, Alex Williamson wrote: > > > > On Fri, 6 Dec 2019 01:04:07

Re: [PATCH v3] qga: fence guest-set-time if hwclock not available

On 12/9/19 7:33 PM, Cornelia Huck wrote: On Fri, 06 Dec 2019 08:17:27 +0100 Markus Armbruster wrote: Cornelia Huck writes: On Thu, 5 Dec 2019 14:05:19 +0100 Philippe Mathieu-Daudé wrote: Hi Cornelia, On 12/5/19 12:53 PM, Cornelia Huck wrote: The Posix implementation of

Re: [PATCH for-5.0 v11 05/20] virtio-iommu: Endpoint and domains structs and helpers

On Fri, Nov 22, 2019 at 07:29:28PM +0100, Eric Auger wrote: > +typedef struct viommu_domain { > +uint32_t id; > +GTree *mappings; > +QLIST_HEAD(, viommu_endpoint) endpoint_list; > +} viommu_domain; > + > +typedef struct viommu_endpoint { > +uint32_t id; > +viommu_domain

Re: [PATCH for-5.0 v11 04/20] virtio-iommu: Add the iommu regions

Two small things below, but looks good overall Reviewed-by: Jean-Philippe Brucker On Fri, Nov 22, 2019 at 07:29:27PM +0100, Eric Auger wrote: > +static AddressSpace *virtio_iommu_find_add_as(PCIBus *bus, void *opaque, > + int devfn) > +{ > +

Re: [for-5.0 PATCH v2 1/3] cpu: Introduce CPUReset callback typedef

On Tue, 10 Dec 2019 10:42:51 + Peter Maydell wrote: > On Tue, 10 Dec 2019 at 10:39, Markus Armbruster wrote: > > > > Greg Kurz writes: > > > diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h > > > index 77c6f0529903..047e3972ecaf 100644 > > > --- a/include/hw/core/cpu.h > > > +++

Re: [PATCH v38 15/22] target/avr: Add example board configuration

On Mon, Dec 9, 2019 at 7:38 PM Michael Rolnik wrote: > > I will check again. > On my test bed: ... CC riscv32-softmmu/hw/virtio/virtio-serial-pci.o CC riscv32-softmmu/hw/riscv/boot.o /home/rtrk/Build/qemu-rolnik/hw/riscv/boot.c: In function ‘riscv_load_kernel’:

Re: [PATCH for-5.0 v11 03/20] virtio-iommu: Decode the command payload

On Fri, Nov 22, 2019 at 07:29:26PM +0100, Eric Auger wrote: > This patch adds the command payload decoding and > introduces the functions that will do the actual > command handling. Those functions are not yet implemented. > > Signed-off-by: Eric Auger Reviewed-by: Jean-Philippe Brucker Which

Re: [PATCH for-5.0 v11 02/20] virtio-iommu: Add skeleton

Hi Eric, On Fri, Nov 22, 2019 at 07:29:25PM +0100, Eric Auger wrote: > +typedef struct VirtIOIOMMU { > +VirtIODevice parent_obj; > +VirtQueue *req_vq; > +VirtQueue *event_vq; > +struct virtio_iommu_config config; > +uint64_t features; > +uint64_t acked_features; We

Re: [for-5.0 PATCH v2 1/3] cpu: Introduce CPUReset callback typedef

On Tue, 10 Dec 2019 11:39:00 +0100 Markus Armbruster wrote: > Greg Kurz writes: > > > Use it in include/hw/core/cpu.h and convert all targets to use it as > > well with: > > > > perl -pi \ > > -e 's/void\s+\(\*(parent_reset)\)\(CPUState\s+\*\w+\)/CPUReset \1/;' \ > > $(git ls-files

Re: [PATCH v38 00/22] QEMU AVR 8 bit cores

On Sun, Dec 8, 2019 at 7:39 PM Michael Rolnik wrote: > > This series of patches adds 8bit AVR cores to QEMU. I get several strange messages about "new blank lines at EOF" while applying this series via patchwork: (check the last line of involved files) rtrk@rtrkw774-lin:~/Build/qemu-rolnik$

Re: [PATCH v1 3/5] target/arm/kvm: Implement cpu feature kvm-adjvtime

On Tue, Dec 10, 2019 at 03:54:11PM +, Peter Maydell wrote: > On Wed, 16 Oct 2019 at 15:34, Andrew Jones wrote: > > > > When kvm-adjvtime is enabled the guest's cntvct[_el0] won't count > > the time when the VM is stopped. That time is skipped by updating > > cntvoff[_el2] on each transition

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

On Tue, Dec 10, 2019 at 04:47:49PM +0100, Andrea Bolognani wrote: > On Tue, 2019-12-10 at 15:33 +0100, Andrew Jones wrote: > > On Tue, Dec 10, 2019 at 03:21:02PM +0100, Andrea Bolognani wrote: > > > I agree with everything except the naming: why would > > > > > > kvm-no-adjvtime=off vtime is

Re: [PATCH v1 3/5] target/arm/kvm: Implement cpu feature kvm-adjvtime

On Wed, 16 Oct 2019 at 15:34, Andrew Jones wrote: > > When kvm-adjvtime is enabled the guest's cntvct[_el0] won't count > the time when the VM is stopped. That time is skipped by updating > cntvoff[_el2] on each transition to vm_running using the current > QEMU_CLOCK_VIRTUAL time.

Re: [PATCH v1 2/5] timer: arm: Introduce functions to get the host cntfrq

On Wed, 16 Oct 2019 at 15:34, Andrew Jones wrote: > > When acceleration like KVM is in use it's necessary to use the host's > counter frequency when converting ticks to or from time units. > > Signed-off-by: Andrew Jones > Reviewed-by: Richard Henderson > --- > include/qemu/timer.h | 16

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

On Tue, 2019-12-10 at 15:33 +0100, Andrew Jones wrote: > On Tue, Dec 10, 2019 at 03:21:02PM +0100, Andrea Bolognani wrote: > > I agree with everything except the naming: why would > > > > kvm-no-adjvtime=off vtime is adjusted (default) > > kvm-no-adjvtime=on vtime is not adjusted > >

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

On Tue, 10 Dec 2019 at 13:33, Andrew Jones wrote: > So the ins and outs of this particular timekeeping issue (to the best of > my knowledge) is that x86 has implemented this behavior since > 00f4d64ee76e ("kvmclock: clock should count only if vm is running"), which > was committed over six years

Re: [PATCH] qemu-img: fix info --backing-chain --image-opts

Am 05.12.2019 um 14:46 hat Stefan Hajnoczi geschrieben: > Only apply --image-opts to the topmost image when listing an entire > backing chain. It is incorrect to treat backing filenames as image > options. Assuming we have the backing chain t.IMGFMT.base <- > t.IMGFMT.mid <- t.IMGFMT, qemu-img

Re: [PATCH] qapi: better document NVMe blockdev @device parameter

Am 06.12.2019 um 15:38 hat Daniel P. Berrangé geschrieben: > Mention that this is a PCI device address & give the format it is > expected it. Also mention that it must be first unbound from any > host kernel driver. > > Signed-off-by: Daniel P. Berrangé Thanks, applied to the block branch.

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

On Tue, Dec 10, 2019 at 03:21:02PM +0100, Andrea Bolognani wrote: > On Tue, 2019-12-10 at 14:32 +0100, Andrew Jones wrote: > > After having done this git mining, it looks more and more like we should > > at least consider naming this feature 'kvm-no-adjvtime' and probably > > also change arm's

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

On Tue, 2019-12-10 at 14:32 +0100, Andrew Jones wrote: > After having done this git mining, it looks more and more like we should > at least consider naming this feature 'kvm-no-adjvtime' and probably > also change arm's default. I agree with everything except the naming: why would

[PATCH v3] net/imx_fec: Adding support for MAC filtering in the FEC IP implementation.

From: bwasim This addition ensures that the IP does NOT boot up in promiscuous mode by default, and so the software only receives the desired packets(Unicast, Broadcast, Unicast / Multicast hashed) by default. The software running on-top of QEMU can also modify these settings and disable

Re: 回复: 回复: 答复: [Qemu-devel] migrate_set_speed has no effect if the guest is using hugepages.

* Lin Ma (l...@suse.com) wrote: > Hi Dave, > > The patch fixed the issue, The rate limit with hugepages works well. > Thanks for your help! No problem; thank you for reporting and testing it. Dave > Lin > > > -邮件原件- > > 发件人: Dr. David Alan Gilbert > > 发送时间: 2019年12月5日 18:32 > > 收件人:

  1   2   >