[PATCH 2/2] virtio-net: delete also control queue when TX/RX deleted

2019-12-25 Thread Yuri Benditovich
https://bugzilla.redhat.com/show_bug.cgi?id=1708480 If the control queue is not deleted together with TX/RX, it later will be ignored in freeing cache resources and hot unplug will not be completed. Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c | 3 ++- 1 file changed, 2 insertions(+),

[PATCH 1/2] virtio: reset region cache when on queue deletion

2019-12-25 Thread Yuri Benditovich
https://bugzilla.redhat.com/show_bug.cgi?id=1708480 Fix leak of region reference that prevents complete device deletion on hot unplug. Signed-off-by: Yuri Benditovich --- hw/virtio/virtio.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 047

[PATCH 0/2] Solve problem of hot removal of virtio-net-pci

2019-12-25 Thread Yuri Benditovich
There is regression of hotplug removal of virtio-net-pci on q35 introduced long time ago in 3.0.0 with commit: 48564041a73adbbff52834f9edbe3806fceefab7 exec: reintroduce MemoryRegion caching virtio-net does not destroy some of caching resources upon hot unplug and on further hot plug the device

Re: [PATCH] target/ppc: fix memory dump endianness in QEMU monitor

2019-12-25 Thread David Gibson
On Tue, Dec 24, 2019 at 01:10:34PM -0300, Fabiano Rosas wrote: > David Gibson writes: > > >> It looks like the hflags MSR_LE is being updated correctly with TCG. But > >> with KVM we only touch it on system_reset > > > > Ah.. right. I think to fix that we'd want an hreg_compute_hflags() at > > t

Re: [PATCH] block: nbd: Fix dirty bitmap context name

2019-12-25 Thread Nir Soffer
On Thu, Dec 19, 2019 at 5:55 PM Nir Soffer wrote: > > On Thu, Dec 19, 2019 at 5:17 PM Vladimir Sementsov-Ogievskiy > wrote: ... > > Note also, that client may use NBD_OPT_LIST_META_CONTEXT with query > > "qemu:dirty-bitmap:", to get list of all exported bitmaps. > > This is another option, I did

Re: [PATCH] qapi/block: fix nbd-server-add spec

2019-12-25 Thread Vladimir Sementsov-Ogievskiy
21.12.2019 1:04, Eric Blake wrote: > On 12/19/19 10:14 AM, Nir Soffer wrote: > > 1. Using disk name as a bitmap name is a bad behavior, as they are > completely > different concepts. Especially keeping in mind that user already knows > disk name anyway > and no reason to writ

[Bug 1838390] Re: vmx_write_mem: mmu_gva_to_gpa failed when using hvf

2019-12-25 Thread Jimmy
Ubuntu 18.04 VM crashes after login. Works when the RAM is 4 Gb. Posting this here as the error message looked very similar. qemu-system-x86_64 -m 6G -vga virtio -show-cursor -usb -device usb-tablet -enable-kvm -drive file=~/QEMU/ubuntu- desktop-18.04.qcow2,if=virtio -accel hvf -c

[Bug 1838390] Re: vmx_write_mem: mmu_gva_to_gpa failed when using hvf

2019-12-25 Thread Jimmy
Crash report ** Attachment added: "mac_qemu_crash_report.txt" https://bugs.launchpad.net/qemu/+bug/1838390/+attachment/5315306/+files/mac_qemu_crash_report.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpa

Re: [Qemu-devel] [PATCH] RISCV: support riscv vector extension 0.7.1

2019-12-25 Thread LIU Zhiwei
On 2019/12/20 4:38, Richard Henderson wrote: On 12/18/19 11:11 PM, LIU Zhiwei wrote: I'm sorry that it's really hard to absorb your opinion. I don't know why clang will fail when index beyond the end of vreg[n] into vreg[n+1]. I thought sure one of the address sanitizer checks would detect ar

Re: [PATCH v2] target/m68k: only change valid bits in CACR

2019-12-25 Thread Thomas Huth
Am Fri, 20 Dec 2019 18:24:15 +0100 schrieb Laurent Vivier : > This is used by netBSD (and MacOS ROM) to detect the MMU type > > Signed-off-by: Laurent Vivier > --- > > Notes: > v2: change accordingly to Thomas' comments > - Replace MMU feature id by a CPU feature id > - fix 6803