On Wed, Jan 8, 2020 at 7:52 PM Alberto Garcia wrote:
>
> The qcow2 header specifies the virtual size of the image in bytes, but
> BlockDriverState stores it as a number of 512-byte sectors.
>
> If the user tries to create an image with a size that is not a
> multiple of the sector size then this
Yes, it looks like. virtio_pci_config_read is called via a pointer
from memory_region_read_accessor and memory_region_write_accessor
calls virtio_pci_config_write.
I tested the patch in a linux/ppc64 host with a FreeBSD/ppc64 guest
and VirtIO 0.9 (legacy) driver and from what I saw the config area
On Wed, Jan 8, 2020 at 7:50 PM Alberto Garcia wrote:
>
> This replaces all remaining instances in the qcow2 code.
>
> Signed-off-by: Alberto Garcia
> ---
> block/qcow2-cluster.c | 2 +-
> block/qcow2.c | 16 +---
> 2 files changed, 10 insertions(+), 8 deletions(-)
>
> diff
The no_quit variable has been removed in commit 78782712a62d56 ("vl: drop
no_quit variable"), so let's remove the extern declaration in the header
now, too.
Signed-off-by: Thomas Huth
---
include/sysemu/sysemu.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/sysemu/sysemu.h
It seems this might be related to buffer/sample size, spice works and uses
timed audio with a larger buffer.
GUS I have not gotten to work.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1858488
Scott Cheloha wrote:
> Create a function to abstract common logic needed when removing a
> SaveStateEntry element from the savevm_state.handlers queue.
>
> For now we just remove the element. Soon it will involve additional
> cleanup.
>
> Signed-off-by: Scott Cheloha
Reviewed-by: Juan Quintela
Also, can you please add more info on "emerge" problem, so that I can
repro it with the current QEMU. I would prefer to know the roots cause,
rather than just accept that the problem disappeared.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is
Andrew,
Thanks for your input regarding linked patch. The patch is still under
review, and it is normal for patches under review to perhaps have some
faults, and that is improved in the process of reviewing - that is,
among other things, one of benefits of open source development. I will
take
Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau
Reviewed-by: Juan Quintela
queuing it without the SLOF bits
On 1/8/20 6:34 AM, David Gibson wrote:
On Tue, Jan 07, 2020 at 11:57:08AM +0530, Ganesh wrote:
On 1/3/20 7:49 AM, David Gibson wrote:
On Thu, Jan 02, 2020 at 01:21:09PM +0530, Ganesh Goudar wrote:
From: Aravinda Prasad
This patch adds support in QEMU to handle "ibm,nmi-register"
and
Hi,
I am trying to fix DMA support with Exynos4210. The original commit
59520dc65e ("hw/arm/exynos4210: Add DMA support for the Exynos4210") doesn't
really work, primarily because it assigns wrong interrupt lines (no idea
how I thought I tested that).
Problem I have right now is that the pl330
On Wed, 8 Jan 2020 15:59:55 +0100
Cornelia Huck wrote:
> On Tue, 7 Jan 2020 11:56:02 -0700
> Alex Williamson wrote:
>
> > On Tue, 7 Jan 2020 23:23:17 +0530
> > Kirti Wankhede wrote:
>
> > > There are 3 invalid states:
> > > * 101b => Invalid state
> > > * 110b => Invalid state
> > >
After applying my patch it seems like another issue was fixed: "emerge"
inside qemu has no permissions bug. Without that patch I was able to
reproduce "emerge" program can't apply any patch (permission denied). So
it looks like old hardcoded table has some wrong values that are not
compatible with
We use SeaBIOS as firmware, and pass the RAM size in a 32-bit
wide register. When using 4GB of RAM, the register is truncated
to 0, SeaBIOS is confused and halts the machine:
$ qemu-system-hppa -m 4g -serial stdio
SeaBIOS: Machine configured with too little memory (0 MB), minimum is 16 MB.
The firmware has to reside in the PDC range. If the Elf file
expects to load it below FIRMWARE_START, it is incorrect,
regardless the RAM size.
Signed-off-by: Philippe Mathieu-Daudé
---
Note we define FIRMWARE_END=0xf080 but in the specs
the PDC ends at 0xf100.
---
hw/hppa/machine.c | 2
The hardware expects DIMM slots of 1 or 2 GB, allowing up to
4 GB of memory. Accept the same amount of memory the hardware
can deal with.
The CPU doesn't have access to the RAM mapped in the
[0xf000 - 0xf100] range because this is the PDC area
(Processor Dependent Code) where the firmware
Following the discussion of Igor's patch "hppa: allow max
ram size upto 4Gb" [*], I tried to simplify the current
code so Igor's series doesn't change the CLI with this
machine.
Last patch is tagged RFC because it is odd to limit a machine
to 4095MB instead of 4G, but this is a current limitation
On Wed, 8 Jan 2020 at 17:06, puchuu <1858...@bugs.launchpad.net> wrote:
> I think about the following development flow:
>
> 1. Kernel updates and maintains "tbl".
> 2. Qemu developer wants to implement new syscall (like clone3) in
> "linux-user/syscall.c".
> 3. Developer clones new kernel into
The L1 table is read from disk using the byte-based bdrv_pread() and
is never accessed beyond its last element, so there's no need to
allocate more memory than that.
Signed-off-by: Alberto Garcia
---
block/qcow2-cluster.c | 5 ++---
block/qcow2-refcount.c | 2 +-
block/qcow2-snapshot.c | 3 +--
On Wed, 8 Jan 2020 at 16:20, Andre Silva wrote:
>
> Remove the bswap function calls after reading and before writing
> memory bytes in virtio_pci_config_read and virtio_pci_config_write
> because they are reverting back an already swapped bytes
Is "because we wrote it via
The qcow2 header specifies the virtual size of the image in bytes, but
BlockDriverState stores it as a number of 512-byte sectors.
If the user tries to create an image with a size that is not a
multiple of the sector size then this is fixed on creation by
silently rounding the image size up (see
This replaces all remaining instances in the qcow2 code.
Signed-off-by: Alberto Garcia
---
block/qcow2-cluster.c | 2 +-
block/qcow2.c | 16 +---
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index
This small series gets rid of all the remaining instances of hardcoded
sector sizes in the qcow2 code and adds a check for images whose
virtual size is not a multiple of the sector size.
See the individual patches for details.
Berto
Alberto Garcia (3):
qcow2: Require that the virtual size is
I have applied these patches on qemu 4.2 and it seems they do fix the
problem: no more vhost_region_add_section in the log, and I haven't
observed network or general performance loss in the span of one hour.
--
You received this bug notification because you are a member of qemu-
devel-ml, which
I've just written these generators in ruby, but it can be rewritten in
python, perl, etc.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1858461
Title:
Please refactor linux-user/mips/cpu_loop.c
On 03/01/20 08:43, Philippe Mathieu-Daudé wrote:
> On 1/3/20 8:39 AM, Marc-André Lureau wrote:
>> Signed-off-by: Marc-André Lureau
>> ---
>> exec.c | 4 ++--
>> roms/SLOF | 2 +-
>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/exec.c b/exec.c
>> index
On Sun, Jan 05, 2020 at 02:55:44PM -0500, Alexander Bulekov wrote:
> On 200103 1115, Stefan Hajnoczi wrote:
> > On Fri, Nov 29, 2019 at 09:34:47PM +, Oleinik, Alexander wrote:
> > > +QTestState *qtest_inproc_init(QTestState **s, bool log, const char* arch,
> > > +void
** Patch added: "mips_syscall_generators.patch"
https://bugs.launchpad.net/qemu/+bug/1858461/+attachment/5318622/+files/mips_syscall_generators.patch
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Hello, thank you. I want to introduce another patch with syscalls
related generator. Please review it.
I think about the following development flow:
1. Kernel updates and maintains "tbl".
2. Qemu developer wants to implement new syscall (like clone3) in
"linux-user/syscall.c".
3. Developer
On Sun, Jan 05, 2020 at 12:06:17AM +0800, Coiby Xu wrote:
> Hi Stefan,
>
> Thank you for reviewing my work! All the improvements have been
> applied except for a small issue regarding object_add.
Excellent, thanks for your work!
> > (qemu) object_add
On Sat, Jan 04, 2020 at 02:00:02PM +0800, Coiby Xu wrote:
> Thank you for the advice! I've skipped test cases regarding resizing the
> disk. The remaining tests are "indirect" and "basic". vhost-user-blk device
> has now passed the "basic" test
>
Hi Jean-Philippe, Peter,
On 1/7/20 11:10 AM, Jean-Philippe Brucker wrote:
> On Mon, Jan 06, 2020 at 12:58:50PM -0500, Peter Xu wrote:
>> On Mon, Jan 06, 2020 at 06:06:34PM +0100, Jean-Philippe Brucker wrote:
>>> On Fri, Dec 20, 2019 at 11:51:00AM -0500, Peter Xu wrote:
On Fri, Dec 20, 2019
Andrew,
Please take a look at the patch:
http://patchwork.ozlabs.org/patch/1217454/
Once you apply the patch, it should be straightforward to add
getdents64_x32() (right after clone3()) for all MIPS ABIs.
The thing is, kernel folks recently made some rearrangements of syscall
numbers, so that
On Wed, 8 Jan 2020 04:02:10 +
"Zengtao (B)" wrote:
> > -Original Message-
> > From: Igor Mammedov [mailto:imamm...@redhat.com]
> > Sent: Tuesday, January 07, 2020 11:50 PM
> > To: Zengtao (B)
> > Cc: Michael S. Tsirkin; qemu-devel@nongnu.org; qemu-triv...@nongnu.org;
> > Shannon
On Thu, Jan 02, 2020 at 10:55:46PM +0400, Marc-André Lureau wrote:
> On Thu, Jan 2, 2020 at 3:03 PM Felipe Franciosi wrote:
> > I even recall highlighting that vhost-user could be moved underneath
> > that later, greatly simplifying lots of other Qemu code.
>
> That would eventually be an
On 1/7/20 12:47 PM, Liang Yan wrote:
> Kindly Ping.
> Just wondering if there are any plans for it.
Yes. Waiting for the feedback or acceptance. Probably delay is due to
December holidays. Hopefully all are back now.
>
> Best,
> Liang
>
>
> On 11/7/19 1:00 PM, Moger, Babu wrote:
>> The
Remove the bswap function calls after reading and before writing
memory bytes in virtio_pci_config_read and virtio_pci_config_write
because they are reverting back an already swapped bytes.
Consider the table below in the context of virtio_pci_config_read
function.
Host Target
From: Stefan Berger
Implement support for TPM on ppc64 by implementing the vTPM CRQ interface
as a frontend. It can use the tpm_emulator driver backend with the external
swtpm.
The Linux vTPM driver for ppc64 works with this emulation.
This TPM emulator also handles the TPM 2 case.
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
---
docs/specs/index.rst | 1 +
docs/specs/tpm.rst | 503 +++
docs/specs/tpm.txt | 445 --
3 files changed, 504 insertions(+),
Public bug reported:
On a fresh clone, 'make -C roms efi' fails because submodule is not
initialized [1]:
/builds/philmd/qemu/roms/edk2/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf(-1):
error 000E: File/directory not found in workspace
From: Stefan Berger
Extend the tpm_spapr frontend with VM suspend and resume support.
Signed-off-by: Stefan Berger
---
hw/tpm/tpm_spapr.c | 67 -
hw/tpm/trace-events | 2 ++
2 files changed, 68 insertions(+), 1 deletion(-)
diff --git
From: Stefan Berger
Signed-off-by: Stefan Berger
---
hw/ppc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
index f927ec9c74..b5b3519158 100644
--- a/hw/ppc/Kconfig
+++ b/hw/ppc/Kconfig
@@ -10,6 +10,7 @@ config PSERIES
select XICS_SPAPR
The following series of patches adds vTPM emulator support for the
ppc64 platform (pSeries).
It can be tested as follows with swtpm/libtpms:
mkdir /tmp/mytpm1
swtpm socket --tpmstate dir=/tmp/mytpm1 \
--ctrl type=unixio,path=/tmp/mytpm1/swtpm-sock \
--log level=20
If TPM 2 is desired,
From: Stefan Berger
Signed-off-by: Stefan Berger
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: David Gibson
---
hw/tpm/tpm_tis.c| 32
hw/tpm/tpm_util.c | 25 +
hw/tpm/tpm_util.h | 3 +++
hw/tpm/trace-events | 2 +-
4 files
From: Stefan Berger
For devices that cannot be statically initialized, implement a
get_dt_compatible() callback that allows us to ask the device for
the 'compatible' value.
Signed-off-by: Stefan Berger
---
hw/ppc/spapr_vio.c | 11 +--
include/hw/ppc/spapr_vio.h | 1 +
2 files
From: Pan Nengyuan
spotted by ASAN
Fixes: 81d8ccb1bea4fb9eaaf4c8e30bd4021180a9a39f
Reported-by: Euler Robot
Signed-off-by: Pan Nengyuan
Reviewed-by: Markus Armbruster
Message-Id: <1576805650-16380-1-git-send-email-pannengy...@huawei.com>
Signed-off-by: Laurent Vivier
---
util/module.c | 1
From: Chen Qun
The accel_list forgot to free, the asan output:
Direct leak of 16 byte(s) in 1 object(s) allocated from:
#0 0x919331cb in __interceptor_malloc (/lib64/libasan.so.4+0xd31cb)
#1 0x913f7163 in g_malloc (/lib64/libglib-2.0.so.0+0x57163)
#2 0x91413d9b in
From: Pan Nengyuan
Fixes:
target/arm/translate-a64.c: In function 'disas_crypto_three_reg_sha512':
target/arm/translate-a64.c:13625:9: error: 'genfn' may be used uninitialized in
this function [-Werror=maybe-uninitialized]
genfn(tcg_rd_ptr, tcg_rn_ptr, tcg_rm_ptr);
From: Yuval Shaia
Use gmail account for maintainer tasks.
Signed-off-by: Yuval Shaia
Acked-by: Marcel Apfelbaum
Message-Id: <20191126102637.2038-1-yuval.sh...@oracle.com>
Signed-off-by: Laurent Vivier
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The following changes since commit 035eed4c0d257c905a556fa0f4865a0c077b4e7f:
Merge remote-tracking branch 'remotes/vivier/tags/q800-for-5.0-pull-request'
into staging (2020-01-07 17:08:21 +)
are available in the Git repository at:
git://github.com/vivier/qemu.git
From: Pan Nengyuan
Fixes:
/mnt/sdb/qemu/nbd/server.c: In function 'nbd_handle_request':
/mnt/sdb/qemu/nbd/server.c:2313:9: error: 'ret' may be used uninitialized in
this function [-Werror=maybe-uninitialized]
int ret;
Reported-by: Euler Robot
Signed-off-by: Pan Nengyuan
Reviewed-by:
> On 20 Dec 2019, at 13:18, Luis Machado wrote:
>
> On 12/20/19 10:14 AM, Alex Bennée wrote:
>> Luis Machado writes:
>>> On 12/19/19 4:15 PM, Alex Bennée wrote:
Richard Henderson writes:
> On 12/11/19 9:05 AM, Alex Bennée wrote:
>> +static struct TypeSize vec_lanes[] = {
On 1/8/20 4:32 PM, Sai Pavan Boddu wrote:
Hi Gred/Philippe,
In the process of making hcd-xhci.c free of pci wrapper, I came across a dma command
" ldq_le_pci_dma" for which I don’t see any low level alternative to replace.
Even I cannot find the source of it, do you have any thoughts on this ?
Patchew URL:
https://patchew.org/QEMU/20200108125658.208480-2-afscoe...@gmail.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH] virtio: Prevent double swap due to target pre 1.0 VirtIO
Type: series
Message-id:
On 12/19/19 6:12 AM, David Gibson wrote:
> On Thu, Nov 28, 2019 at 02:46:59PM +0100, Cédric Le Goater wrote:
>> The privileged message send and clear instructions (msgsndp & msgclrp)
>> are privileged, but will generate a hypervisor facility unavailable
>> exception if not enabled in the HFSCR and
On Wed, 8 Jan 2020 at 09:23, Ian Jiang wrote:
>
> Problem
> ==
> The next instruction after executing "ret" (i.e. jalr x0, 0(x1)) is not at
> 0x856c (x1/ra) as expected, but at 0x856c.
> How to debug this issue? Any suggestion is appreciated.
>
> QEMU command
>
On 12/17/19 5:00 AM, David Gibson wrote:
> On Thu, Nov 28, 2019 at 02:46:58PM +0100, Cédric Le Goater wrote:
>> From: Suraj Jitindar Singh
>>
>> Privileged message send facilities exist on POWER8 processors and
>> later and include a register and instructions which can be used to
>> generate,
Hi Gred/Philippe,
In the process of making hcd-xhci.c free of pci wrapper, I came across a dma
command " ldq_le_pci_dma" for which I don’t see any low level alternative to
replace.
Even I cannot find the source of it, do you have any thoughts on this ?
Regards,
Sai Pavan
> -Original
On Wed, Jan 8, 2020 at 7:28 PM Tomáš Golembiovský wrote:
>
> Add command for reporting devices on Windows guest. The intent is not so
> much to report the devices but more importantly the driver (and its
> version) that is assigned to the device. This gives caller the
> information whether VirtIO
Add command for reporting devices on Windows guest. The intent is not so
much to report the devices but more importantly the driver (and its
version) that is assigned to the device. This gives caller the
information whether VirtIO drivers are installed and/or whether
inadequate driver is used on a
Le 08/01/2020 à 12:42, kuhn.chen...@huawei.com a écrit :
> From: Chen Qun
>
> The accel_list forgot to free, the asan output:
>
> Direct leak of 16 byte(s) in 1 object(s) allocated from:
> #0 0x919331cb in __interceptor_malloc (/lib64/libasan.so.4+0xd31cb)
> #1 0x913f7163 in
Le 08/01/2020 à 03:39, pannengy...@huawei.com a écrit :
> From: Pan Nengyuan
>
> Fixes:
> target/arm/translate-a64.c: In function 'disas_crypto_three_reg_sha512':
> target/arm/translate-a64.c:13625:9: error: 'genfn' may be used uninitialized
> in this function [-Werror=maybe-uninitialized]
>
* Peter Lieven (p...@kamp.de) wrote:
> Hi,
>
>
> I have a Qemu 4.0.1 machine with vhost-net network adapter, thats polluting
> the log with the above message.
>
> Is this something known? Googling revealed the following patch in Nemu (with
> seems to be a Qemu fork from Intel):
>
>
From: Keith Packard
Provides a blocking call to read a character from the console using
semihosting.chardev, if specified. This takes some careful command
line options to use stdio successfully as the serial ports, monitor
and semihost all want to use stdio. Here's a sample set of command
line
On Wed, Jan 8, 2020 at 5:23 PM Ian Jiang wrote:
>
> Problem
> ==
> The next instruction after executing "ret" (i.e. jalr x0, 0(x1)) is not at
> 0x856c (x1/ra) as expected, but at 0x856c.
I don't get this. is not at address A but at address B, but you wrote
A and B
Le 08/01/2020 à 03:51, pannengy...@huawei.com a écrit :
> From: Pan Nengyuan
>
> Fixes:
> /mnt/sdb/qemu/nbd/server.c: In function 'nbd_handle_request':
> /mnt/sdb/qemu/nbd/server.c:2313:9: error: 'ret' may be used uninitialized in
> this function [-Werror=maybe-uninitialized]
> int ret;
>
Before we introduce blocking semihosting calls we need to ensure we
can restart the system on semi hosting exception. To be able to do
this the EXCP_SEMIHOST operation should be idempotent until it finally
completes. Practically this means ensureing we only update the pc
after the semihosting call
There are two types of ARM semicall - lets test them both. Putting the
logic in a header will make re-using the functions easier later.
Signed-off-by: Alex Bennée
---
tests/tcg/arm/semicall.h | 35 +++
tests/tcg/arm/semihosting.c | 21 +
There are linux-user users of semihosting so we'd better check things
work for them as well.
Signed-off-by: Alex Bennée
---
v3
- include aarch64 version
v4
- use common semicall.h, test thumb & arm
---
tests/tcg/arm/semiconsole.c | 27 +++
On 08/01/20 15:56, Philippe Mathieu-Daudé wrote:
> On 1/8/20 12:42 PM, kuhn.chen...@huawei.com wrote:
>> From: Chen Qun
>>
>> The accel_list forgot to free, the asan output:
>>
>> Direct leak of 16 byte(s) in 1 object(s) allocated from:
>> #0 0x919331cb in __interceptor_malloc
>>
All semihosting exceptions are dealt with earlier in the common code
so we should never get here.
Signed-off-by: Alex Bennée
Reviewed-by: Richard Henderson
Reviewed-by: Keith Packard
Tested-by: Keith Packard
---
target/arm/helper.c | 6 --
1 file changed, 6 deletions(-)
diff --git
Hi,
No major changes from the previous version except some tweaking of the
tests to exercise both thumb and arm modes. There is a minor
refactoring so the __semi_call helper can be re-used. I'm planning on
sending the PR in with my gdbstub fixes later this week.
The following patches need review
We don't run this during check-tcg as we would need to check stuff is
echoed back. However we can still build the binary so people can test
it manually.
Signed-off-by: Alex Bennée
Reviewed-by: Richard Henderson
---
v8
- actually return the result!
---
tests/tcg/aarch64/system/semiconsole.c
On Tue, 7 Jan 2020 11:56:02 -0700
Alex Williamson wrote:
> On Tue, 7 Jan 2020 23:23:17 +0530
> Kirti Wankhede wrote:
> > There are 3 invalid states:
> > * 101b => Invalid state
> > * 110b => Invalid state
> > * 111b => Invalid state
> >
> > why only 110b should be used to report
On 1/8/20 12:42 PM, kuhn.chen...@huawei.com wrote:
From: Chen Qun
The accel_list forgot to free, the asan output:
Direct leak of 16 byte(s) in 1 object(s) allocated from:
#0 0x919331cb in __interceptor_malloc (/lib64/libasan.so.4+0xd31cb)
#1 0x913f7163 in g_malloc
bdrv_mark_request_serialising is writing the overlap_offset and
overlap_bytes fields of BdrvTrackedRequest. Take bs->reqs_lock
for the whole duration of it, and not just when waiting for
serialising requests, so that tracked_request_overlaps does not
look at a half-updated request.
The new code
Marking without waiting would not result in actual serialising behavior.
Thus, make a call bdrv_mark_request_serialising sufficient for
serialisation to happen.
Signed-off-by: Paolo Bonzini
---
block/file-posix.c| 1 -
block/io.c| 40
Peter Lieven noticed that reqs->overlap_offset and reqs->overlap_bytes
are written outside bs->reqs_lock. Patch 3 fixes it, while patches 1
and 2 are preparatory cleanups.
v1->v2: fix comment in patch 2, commit message in patch 3 [Kevin]
Paolo Bonzini (3):
block: eliminate
It is unused since commit 00e30f0 ("block/backup: use backup-top instead
of write notifiers", 2019-10-01), drop it to simplify the code.
While at it, drop redundant assertions on flags.
Signed-off-by: Paolo Bonzini
---
block/io.c| 18 --
include/block/block.h | 12
On 1/8/20 1:13 PM, pavlica.nik...@gmail.com wrote:
From: Nikola Pavlica
Because some VMs in QEMU can get GPU virtualization (using technologies
such as iGVT-g, as mentioned previously), they could produce a video
output that had a higher display refresh rate than of what the GTK
display was
'out' label from write_event_mask() and and write_event_data()
can be replaced by 'return'.
The 'out' label from read_event_data() can also be replaced.
However, as suggested by Cornelia Huck, instead of simply
replacing the 'out' label, let's also change the code flow
a bit to make it clearer
On 1/8/20 3:47 PM, Thomas Huth wrote:
We already print availabled devices with "-device help", or available
backends with "-netdev help" or "-chardev help". Let's provide a way
for the users to query the available display backends, too.
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe
We already print availabled devices with "-device help", or available
backends with "-netdev help" or "-chardev help". Let's provide a way
for the users to query the available display backends, too.
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Signed-off-by: Thomas Huth
On 1/8/20 2:35 PM, Paolo Bonzini wrote:
From: Marc-André Lureau
Fix Unix socket connection & skip commands that are not implemented.
Signed-off-by: Marc-André Lureau
Signed-off-by: Paolo Bonzini
---
tests/Makefile.include | 2 +-
tests/test-qga.c | 25 ++---
2
external_snapshot_abort() calls to bdrv_set_backing_hd(), which
returns state->old_bs to the main AioContext, as it's intended to be
used then the BDS is going to be released. As that's not the case when
aborting an external snapshot, return it to the AioContext it was
before the call.
This issue
Includes the following tests:
- Adding a dirty bitmap.
* RHBZ: 1782175
- Starting a drive-mirror to an NBD-backed target.
* RHBZ: 1746217, 1773517
- Aborting an external snapshot transaction.
* RHBZ: 1779036
- Aborting a blockdev backup transaction.
* RHBZ: 1782111
For each
Dirty map addition and removal functions are not acquiring to BDS
AioContext, while they may call to code that expects it to be
acquired.
This may trigger a crash with a stack trace like this one:
#0 0x7f0ef146370f in __GI_raise (sig=sig@entry=6)
at
Issuing a drive-backup from qmp_drive_backup takes a slightly
different path than when it's issued from a transaction. In the code,
this is manifested as some redundancy between do_drive_backup() and
drive_backup_prepare().
This change unifies both paths, merging do_drive_backup() and
Issuing a blockdev-backup from qmp_blockdev_backup takes a slightly
different path than when it's issued from a transaction. In the code,
this is manifested as some redundancy between do_blockdev_backup() and
blockdev_backup_prepare().
This change unifies both paths, merging do_blockdev_backup()
All paths that lead to bdrv_backup_top_drop(), except for the call
from backup_clean(), imply that the BDS AioContext has already been
acquired, so doing it there too can potentially lead to QEMU hanging
on AIO_WAIT_WHILE().
An easy way to trigger this situation is by issuing a two actions
bdrv_try_set_aio_context() requires that the old context is held, and
the new context is not held. Fix all the occurrences where it's not
done this way.
Suggested-by: Max Reitz
Signed-off-by: Sergio Lopez
---
blockdev.c | 68 +++---
1 file
This patch series includes fixes for various issues related to
AioContext mismanagement for various blockdev-initiated actions.
It also adds tests for those actions when executed on drives running
on an IOThread AioContext.
---
Changelog:
v6:
- Rename the patch series.
- Add
Fix a couple of minor coding style issues in drive_backup_prepare.
Signed-off-by: Sergio Lopez
Reviewed-by: Max Reitz
Reviewed-by: Kevin Wolf
---
blockdev.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 8e029e9c01..553e315972 100644
Patchew URL:
https://patchew.org/QEMU/1578486775-52247-1-git-send-email-pbonz...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PULL 00/38] Misc patches for 2020-01-08
Type: series
Message-id:
"Dr. David Alan Gilbert (git)" writes:
> From: "Dr. David Alan Gilbert"
>
> Hyperv's synic (that we emulate) is a feature that allows the guest
> to place some magic (4k) pages of RAM anywhere it likes in GPA.
> This confuses vhost's RAM section merging when these pages
> land over the top of
On 1/8/20 9:46 AM, Cornelia Huck wrote:
On Mon, 6 Jan 2020 15:24:03 -0300
Daniel Henrique Barboza wrote:
[..]
I think read_event_data() is still a bit confusing, even if we get rid
of the 'out:' label, as the flow remains the same. How about something
like the following, which makes it
On Tue, 07 Jan 2020 13:14:20 +0100
Christian Schoenebeck wrote:
> On Montag, 6. Januar 2020 19:24:11 CET Daniel Henrique Barboza wrote:
> > 'out' label in v9fs_xattr_write() and 'out_nofid' label in
> > v9fs_complete_rename() can be replaced by appropriate return
> > calls.
> >
> > CC: Greg
Can you try the pair of patches I've just posted:
vhost: Don't pass ram device sections
hyperv/synic: Allocate as ram_device
and let me know if it helps please.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
On 08/01/2020 14.35, Paolo Bonzini wrote:
> From: Marc-André Lureau
>
> Fix Unix socket connection & skip commands that are not implemented.
>
> Signed-off-by: Marc-André Lureau
> Signed-off-by: Paolo Bonzini
> ---
> tests/Makefile.include | 2 +-
> tests/test-qga.c | 25
Hi Juan,
On 1/8/20 2:51 PM, Juan Quintela wrote:
> Auger Eric wrote:
>> Hi Juan,
>>
>> On 1/8/20 2:19 PM, Juan Quintela wrote:
>>> "Dr. David Alan Gilbert" wrote:
* Eric Auger (eric.au...@redhat.com) wrote:
> Support QLIST migration using the same principle as QTAILQ:
> 94869d5c52
101 - 200 of 343 matches
Mail list logo
