RE: sysbus usb xhci

2020-01-17 Thread Sai Pavan Boddu
Hi Gred/Philippe, @Philippe Mathieu-Daudé, thanks I found the alternative "ldq_le_dma". Moving forward, for testing the new model. I ran through qtest:usb-hcd-xhci-test.c, are there any other test which I need to consider as first level validation ? Regards, Sai Pavan > -Original

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-17 Thread Greg Kurz
On Fri, 17 Jan 2020 19:16:08 +1000 David Gibson wrote: > On Thu, Jan 16, 2020 at 07:29:02PM +0100, Greg Kurz wrote: > > On Thu, 16 Jan 2020 13:14:35 +0100 > > Greg Kurz wrote: > > > > > On Thu, 16 Jan 2020 11:37:24 +0100 > > > Laurent Vivier wrote: > > > > > > > On 16/01/2020 09:48, Greg

Re: [PATCH v2 66/86] ppc/{ppc440_bamboo, sam460x}: drop RAM size fixup

2020-01-17 Thread Philippe Mathieu-Daudé
On 1/17/20 11:46 AM, Igor Mammedov wrote: On Wed, 15 Jan 2020 22:33:46 +0100 (CET) BALATON Zoltan wrote: [...] v2 basically works the same as original code, except of that instead of fixing up ram_size, it ask user to fix CLI to the same value. but I've not yet given up to keep current

Re: [PATCH] target/s390x/kvm: Enable adapter interruption suppression again

2020-01-17 Thread Thomas Huth
On 17/01/2020 12.05, Christian Borntraeger wrote: > > > On 17.01.20 11:38, Thomas Huth wrote: >> On 16/01/2020 21.26, Cornelia Huck wrote: >>> On Thu, 16 Jan 2020 15:19:13 -0500 >>> Matthew Rosato wrote: >>> On 1/16/20 7:20 AM, Thomas Huth wrote: > The AIS feature has been disabled

Re: [PATCH 101/104] virtiofsd: prevent FUSE_INIT/FUSE_DESTROY races

2020-01-17 Thread Philippe Mathieu-Daudé
On 1/17/20 4:28 PM, Dr. David Alan Gilbert wrote: * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: On 12/12/19 5:39 PM, Dr. David Alan Gilbert (git) wrote: From: Stefan Hajnoczi When running with multiple threads it can be tricky to handle FUSE_INIT/FUSE_DESTROY in parallel with other

Re: [PATCH 101/104] virtiofsd: prevent FUSE_INIT/FUSE_DESTROY races

2020-01-17 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > On 12/12/19 5:39 PM, Dr. David Alan Gilbert (git) wrote: > > From: Stefan Hajnoczi > > > > When running with multiple threads it can be tricky to handle > > FUSE_INIT/FUSE_DESTROY in parallel with other request types or in > > parallel with

Re: [PATCH v3 02/11] 9pfs: require msize >= 4096

2020-01-17 Thread Greg Kurz
On Fri, 17 Jan 2020 13:01:30 +0100 Christian Schoenebeck wrote: > On Freitag, 17. Januar 2020 11:24:21 CET Greg Kurz wrote: > > On Thu, 16 Jan 2020 22:39:19 +0100 > > > > Christian Schoenebeck wrote: > > > On Donnerstag, 16. Januar 2020 19:07:48 CET Greg Kurz wrote: > > > > > The point here

[Bug 1859384] Re: arm gic: gic_acknowledge_irq doesn't clear line level for other cores for 1-n level-sensitive interrupts and gic_clear_pending uses GIC_DIST_TEST_MODEL (even on v2 where it always re

2020-01-17 Thread Alex Longwall
** Summary changed: - arm gic: interrupt model never 1 on non-mpcore and race condition in gic_acknowledge_irq + arm gic: gic_acknowledge_irq doesn't clear line level for other cores for 1-n level-sensitive interrupts and gic_clear_pending uses GIC_DIST_TEST_MODEL (even on v2 where it always

Re: [PATCH v3 2/2] vhost: Only align sections for vhost-user

2020-01-17 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 17/01/20 14:40, Michael S. Tsirkin wrote: > > We don't really need v2 just to add a field. Compatibility is maintained > > using feature bits. Adding that is a subject for another patch. > > But I'm not sure I understand why does remote need to

Re: [PATCH v3 2/2] vhost: Only align sections for vhost-user

2020-01-17 Thread Paolo Bonzini
On 17/01/20 15:25, Michael S. Tsirkin wrote: > On Fri, Jan 17, 2020 at 02:58:47PM +0100, Paolo Bonzini wrote: >> On 17/01/20 14:40, Michael S. Tsirkin wrote: >>> We don't really need v2 just to add a field. Compatibility is maintained >>> using feature bits. Adding that is a subject for another

Re: [PATCH] multifd: Be consistente about using uint64_t

2020-01-17 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We transmit ram_addr_t always as uint64_t. Be consistent in its > use (on 64bit system, it is always uint64_t problem is 32bits). > > Signed-off-by: Juan Quintela (Note typo in subject ) Reviewed-by: Dr. David Alan Gilbert > --- >

Re: [PULL 0/1] target/openrisc patch queue

2020-01-17 Thread Peter Maydell
On Fri, 17 Jan 2020 at 00:54, Richard Henderson wrote: > > The following changes since commit 28b58f19d269633b3d14b6aebf1e92b3cd3ab56e: > > ui/gtk: Get display refresh rate with GDK version 3.22 or later (2020-01-16 > 14:03:45 +) > > are available in the Git repository at: > >

Re: [PATCH v6 03/11] scripts: add coccinelle script to use auto propagated errp

2020-01-17 Thread Vladimir Sementsov-Ogievskiy
10.01.2020 22:41, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > CC: Cornelia Huck > CC: Eric Blake > CC: Kevin Wolf > CC: Max Reitz > CC: Greg Kurz > CC: Stefan Hajnoczi > CC: Stefano Stabellini > CC: Anthony Perard > CC: Paul Durrant > CC:

Re: [RFC] QEMU Gating CI

2020-01-17 Thread Peter Maydell
On Mon, 2 Dec 2019 at 14:06, Cleber Rosa wrote: > > RFC: QEMU Gating CI > === > > This RFC attempts to address most of the issues described in > "Requirements/GatinCI"[1]. An also relevant write up is the "State of > QEMU CI as we enter 4.0"[2]. > > The general approach is one to

Re: [PATCH v2 4/4] qcow2: Use BDRV_SECTOR_SIZE instead of the hardcoded value

2020-01-17 Thread Alberto Garcia
On Fri 17 Jan 2020 12:51:04 PM CET, Kevin Wolf wrote: >> > Now, what's wrong about the logic to avoid the RMW is that it assumes >> > a fixed required alignment of 512. What it should do is looking at >> > bs->file->bl.request_alignment and rounding accordingly. >> >> Yes. > > Who'll write the

[PULL 15/15] target/arm: Set ISSIs16Bit in make_issinfo

2020-01-17 Thread Peter Maydell
From: Richard Henderson During the conversion to decodetree, the setting of ISSIs16Bit got lost. This causes the guest os to incorrectly adjust trapping memory operations. Cc: qemu-sta...@nongnu.org Fixes: 46beb58efbb8a2a32 ("target/arm: Convert T16, load (literal)") Reported-by: Jeff Kubascik

[PULL 11/15] i.MX: add an emulation for RNGC

2020-01-17 Thread Peter Maydell
From: Martin Kaiser Add an emulation for the RNGC random number generator and the compatible RNGB variant. These peripherals are included (at least) in imx25 and imx35 chipsets. The emulation supports the initial self test, reseeding the prng and reading random numbers. Signed-off-by: Martin

[PULL 08/15] hw/arm/allwinner-a10: Simplify by passing IRQs with qdev_pass_gpios()

2020-01-17 Thread Peter Maydell
From: Philippe Mathieu-Daudé By calling qdev_pass_gpios() we don't need to hold a copy of the IRQs from the INTC into the SoC state. Instead of filling an array of qemu_irq and passing it around, we can now directly call qdev_get_gpio_in() on the SoC. Signed-off-by: Philippe Mathieu-Daudé

[PULL 07/15] hw/arm/allwinner-a10: Move SoC definitions out of header

2020-01-17 Thread Peter Maydell
From: Philippe Mathieu-Daudé These definitions are specific to the A10 SoC and don't need to be exported to the different Allwinner peripherals. Signed-off-by: Philippe Mathieu-Daudé Message-id: 20191230110953.25496-4-f4...@amsat.org Signed-off-by: Peter Maydell Reviewed-by: Peter Maydell

[PULL 13/15] arm/gicv3: update virtual irq state after IAR register read

2020-01-17 Thread Peter Maydell
From: Jeff Kubascik The IAR0/IAR1 register is used to acknowledge an interrupt - a read of the register activates the highest priority pending interrupt and provides its interrupt ID. Activating an interrupt can change the CPU's virtual interrupt state - this change makes sure the virtual irq

[PULL 03/15] hw/arm: Add the STM32F4xx SoC

2020-01-17 Thread Peter Maydell
From: Alistair Francis Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell Message-id: 1d145c4c13e5fa140caf131232a6f524c88fcd72.1576658572.git.alist...@alistair23.me Signed-off-by: Peter Maydell --- hw/arm/Makefile.objs | 1 + include/hw/arm/stm32f405_soc.h | 73

[PULL 14/15] target/arm: Return correct IL bit in merge_syn_data_abort

2020-01-17 Thread Peter Maydell
From: Jeff Kubascik The IL bit is set for 32-bit instructions, thus passing false with the is_16bit parameter to syn_data_abort_with_iss() makes a syn mask that always has the IL bit set. Pass is_16bit as true to make the initial syn mask have IL=0, so that the final IL value comes from or'ing

[PULL 10/15] target/arm/arm-semi: fix SYS_OPEN to return nonzero filehandle

2020-01-17 Thread Peter Maydell
From: Masahiro Yamada According to the specification "Semihosting for AArch32 and Aarch64", the SYS_OPEN operation should return: - A nonzero handle if the call is successful - -1 if the call is not successful So, it should never return 0. Prior to commit 35e9a0a8ce4b ("target/arm/arm-semi:

[PULL 05/15] tests/boot_linux_console: Add initrd test for the CubieBoard

2020-01-17 Thread Peter Maydell
From: Philippe Mathieu-Daudé This test boots a Linux kernel on a CubieBoard and verify the serial output is working. The kernel image and DeviceTree blob are built by the Armbian project (based on Debian): https://docs.armbian.com/Developer-Guide_Build-Preparation/ The cpio image used comes

[PULL 09/15] hw/arm/allwinner-a10: Remove local qemu_irq variables

2020-01-17 Thread Peter Maydell
From: Philippe Mathieu-Daudé We won't reuse the CPU IRQ/FIQ variables. Simplify by calling qdev_get_gpio_in() in place. Signed-off-by: Philippe Mathieu-Daudé Message-id: 20191230110953.25496-6-f4...@amsat.org Signed-off-by: Peter Maydell Reviewed-by: Peter Maydell --- hw/arm/allwinner-a10.c

[PULL 12/15] target/arm: adjust program counter for wfi exception in AArch32

2020-01-17 Thread Peter Maydell
From: Jeff Kubascik The wfi instruction can be configured to be trapped by a higher exception level, such as the EL2 hypervisor. When the instruction is trapped, the program counter should contain the address of the wfi instruction that caused the exception. The program counter is adjusted for

[PULL 04/15] hw/arm: Add the Netduino Plus 2

2020-01-17 Thread Peter Maydell
From: Alistair Francis Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell Message-id: dad8d8d47f7625913e35e27a1c00f603a6b08f9a.1576658572.git.alist...@alistair23.me Signed-off-by: Peter Maydell --- hw/arm/Makefile.objs | 1 + hw/arm/netduinoplus2.c | 52

[PULL 01/15] hw/misc: Add the STM32F4xx Sysconfig device

2020-01-17 Thread Peter Maydell
From: Alistair Francis Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell Message-id: 49b01423a09cef2ca832ff73a84a996568f1a8fc.1576658572.git.alist...@alistair23.me Signed-off-by: Peter Maydell --- hw/misc/Makefile.objs | 1 + include/hw/misc/stm32f4xx_syscfg.h | 61

[PULL 02/15] hw/misc: Add the STM32F4xx EXTI device

2020-01-17 Thread Peter Maydell
From: Alistair Francis Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell Message-id: ef941d59fd8658589d34ed432e1d6dfdcf7fb1d0.1576658572.git.alist...@alistair23.me Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell --- hw/misc/Makefile.objs| 1 +

[PULL 06/15] tests/boot_linux_console: Add a SD card test for the CubieBoard

2020-01-17 Thread Peter Maydell
From: Philippe Mathieu-Daudé The kernel image and DeviceTree blob are built by the Armbian project (based on Debian): https://docs.armbian.com/Developer-Guide_Build-Preparation/ The cpio image used comes from the linux-build-test project: https://github.com/groeck/linux-build-test If ARM is a

[PULL 00/15] target-arm queue

2020-01-17 Thread Peter Maydell
at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20200117-1 for you to fetch changes up to 1a1fbc6cbb34c26d43d8360c66c1d21681af14a9: target/arm: Set ISSIs16Bit in make_issinfo (2020-01-17 14:27:16 +

Re: [PATCH v3 2/2] vhost: Only align sections for vhost-user

2020-01-17 Thread Michael S. Tsirkin
On Fri, Jan 17, 2020 at 02:58:47PM +0100, Paolo Bonzini wrote: > On 17/01/20 14:40, Michael S. Tsirkin wrote: > > We don't really need v2 just to add a field. Compatibility is maintained > > using feature bits. Adding that is a subject for another patch. > > But I'm not sure I understand why does

Re: [PATCH v6 04/11] hw/sd/ssi-sd: fix error handling in ssi_sd_realize

2020-01-17 Thread Eric Blake
On 1/10/20 1:41 PM, Vladimir Sementsov-Ogievskiy wrote: It's wrong to use same err object as errp parameter for several function calls without intermediate checking for error: we'll crash if try to set err object twice. Fix that, using new ERRP_AUTO_PROPAGATE macro. Signed-off-by: Vladimir

Re: [PATCH v6 03/11] scripts: add coccinelle script to use auto propagated errp

2020-01-17 Thread Eric Blake
On 1/10/20 1:41 PM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- Rather light on the commit message. If nothing else, a comment about typical command-line usage would be helpful (yes, it's in the patch body, but sometimes I just refer to git log).

Re: [PATCH v6 02/11] error: auto propagated local_err

2020-01-17 Thread Eric Blake
On 1/10/20 1:41 PM, Vladimir Sementsov-Ogievskiy wrote: Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of functions with errp OUT parameter. s/with/with an/ It has three goals: 1. Fix issue with error_fatal & error_prepend/error_append_hint: user maybe s/&/and/ so it

[PATCH] qemu-img: Add --target-is-zero to convert

2020-01-17 Thread David Edmondson
In many cases the target of a convert operation is a newly provisioned target that the user knows is blank (filled with zeroes). In this situation there is no requirement for qemu-img to wastefully zero out the entire device. Add a new option, --target-is-zero, allowing the user to indicate that

Re: [PATCH v1 2/2] tests/tcg: add a vtimer test for aarch64

2020-01-17 Thread Peter Maydell
On Fri, 10 Jan 2020 at 16:16, Alex Bennée wrote: > > Bug: https://bugs.launchpad.net/bugs/1859021 > > Signed-off-by: Alex Bennée > --- > tests/tcg/aarch64/system/vtimer.c | 80 +++ > tests/tcg/aarch64/Makefile.softmmu-target | 4 ++ > 2 files changed, 84

Re: [PATCH] multifd: Be consistente about using uint64_t

2020-01-17 Thread Philippe Mathieu-Daudé
On 1/17/20 2:56 PM, Juan Quintela wrote: We transmit ram_addr_t always as uint64_t. Be consistent in its use (on 64bit system, it is always uint64_t problem is 32bits). Signed-off-by: Juan Quintela --- migration/ram.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-)

Re: [PATCH v3 3/4] qmp: Move dispatcher to a coroutine

2020-01-17 Thread Kevin Wolf
Am 17.01.2020 um 13:20 hat Markus Armbruster geschrieben: > > @@ -579,9 +580,16 @@ void monitor_cleanup(void) > > } > > qemu_mutex_unlock(_lock); > > > > -/* QEMUBHs needs to be deleted before destroying the I/O thread */ > > -qemu_bh_delete(qmp_dispatcher_bh); > > -

Re: [PATCH v2 83/86] tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups

2020-01-17 Thread Igor Mammedov
On Fri, 17 Jan 2020 14:52:35 +0100 Thomas Huth wrote: > On 17/01/2020 14.33, Igor Mammedov wrote: > > On Fri, 17 Jan 2020 12:14:11 +0100 > > Thomas Huth wrote: > > > >> On 16/01/2020 18.06, Igor Mammedov wrote: > >>> On Thu, 16 Jan 2020 17:35:32 +0100 > >>> Thomas Huth wrote: > >>> >

Re: [RFC PATCH] hw/arm/virt: Support NMI injection

2020-01-17 Thread Peter Maydell
On Thu, 19 Dec 2019 at 04:06, Gavin Shan wrote: > This supports NMI injection for virtual machine and currently it's only > supported on GICv3 controller, which is emulated by qemu or host kernel. > The design is highlighted as below: > >* The NMI is identified by its priority (0x20). In the

Re: [PATCH 035/104] virtiofsd: passthrough_ll: add dirp_map to hide lo_dirp pointers

2020-01-17 Thread Philippe Mathieu-Daudé
On 12/12/19 5:37 PM, Dr. David Alan Gilbert (git) wrote: From: Stefan Hajnoczi Do not expose lo_dirp pointers to clients. Signed-off-by: Stefan Hajnoczi --- tools/virtiofsd/passthrough_ll.c | 103 +++ 1 file changed, 76 insertions(+), 27 deletions(-) diff

Re: [PATCH 091/104] libvhost-user: Fix some memtable remap cases

2020-01-17 Thread Marc-André Lureau
Hi On Thu, Dec 12, 2019 at 10:05 PM Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > If a new setmemtable command comes in once the vhost threads are > running, it will remap the guests address space and the threads > will now be looking in the wrong place. > >

Re: [PATCH v3 2/2] vhost: Only align sections for vhost-user

2020-01-17 Thread Paolo Bonzini
On 17/01/20 14:40, Michael S. Tsirkin wrote: > We don't really need v2 just to add a field. Compatibility is maintained > using feature bits. Adding that is a subject for another patch. > But I'm not sure I understand why does remote need to know about alignment. > This patch seems to handle it

[PATCH] multifd: Be consistente about using uint64_t

2020-01-17 Thread Juan Quintela
We transmit ram_addr_t always as uint64_t. Be consistent in its use (on 64bit system, it is always uint64_t problem is 32bits). Signed-off-by: Juan Quintela --- migration/ram.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c

Re: [PATCH 2/2] iotests: Test snapshot -l field separation

2020-01-17 Thread Eric Blake
On 1/17/20 4:58 AM, Max Reitz wrote: Add a test that all fields in "qemu-img snapshot -l"s output are separated by spaces. Signed-off-by: Max Reitz --- tests/qemu-iotests/284 | 76 ++ tests/qemu-iotests/284.out | 8 tests/qemu-iotests/group |

Re: [PATCH 090/104] virtiofsd: rename inode->refcount to inode->nlookup

2020-01-17 Thread Philippe Mathieu-Daudé
On 12/12/19 5:38 PM, Dr. David Alan Gilbert (git) wrote: From: Stefan Hajnoczi This reference counter plays a specific role in the FUSE protocol. It's not a generic object reference counter and the FUSE kernel code calls it "nlookup". Signed-off-by: Stefan Hajnoczi ---

Re: [PATCH v2 83/86] tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups

2020-01-17 Thread Thomas Huth
On 17/01/2020 14.33, Igor Mammedov wrote: > On Fri, 17 Jan 2020 12:14:11 +0100 > Thomas Huth wrote: > >> On 16/01/2020 18.06, Igor Mammedov wrote: >>> On Thu, 16 Jan 2020 17:35:32 +0100 >>> Thomas Huth wrote: >>> On 15/01/2020 16.07, Igor Mammedov wrote: > Use GString to pass

Re: [PATCH 089/104] virtiofsd: prevent races with lo_dirp_put()

2020-01-17 Thread Philippe Mathieu-Daudé
On 12/12/19 5:38 PM, Dr. David Alan Gilbert (git) wrote: From: Stefan Hajnoczi Introduce lo_dirp_put() so that FUSE_RELEASEDIR does not cause use-after-free races with other threads that are accessing lo_dirp. Also make lo_releasedir() atomic to prevent FUSE_RELEASEDIR racing with itself.

Re: [PATCH 1/2] block: Fix VM size field width in snapshot dump

2020-01-17 Thread Eric Blake
On 1/17/20 4:58 AM, Max Reitz wrote: When printing the snapshot list (e.g. with qemu-img snapshot -l), the VM size field is only seven characters wide. As of de38b5005e9, this is not necessarily sufficient: We generally print three digits, and this may require a decimal point. Also, the unit

Re: Extraneous nesting in QAPI schema

2020-01-17 Thread Eric Blake
On 12/16/19 10:59 AM, Markus Armbruster wrote: Extra nesting is merely another set of braces in QMP. It's bloody annoying in QAPIfied CLI using dotted keys syntax. Example: QMP command {"execute": "chardev-add", Let's start with trying to understand the sources of extra nesting.

Re: [PATCH v8 4/6] tpm_spapr: Support suspend and resume

2020-01-17 Thread Marc-André Lureau
On Fri, Jan 17, 2020 at 5:41 PM Stefan Berger wrote: > > On 1/17/20 8:31 AM, Marc-André Lureau wrote: > > Hi > > > > On Wed, Jan 8, 2020 at 8:14 PM Stefan Berger wrote: > >> From: Stefan Berger > >> > >> Extend the tpm_spapr frontend with VM suspend and resume support. > >> > >> Signed-off-by:

Re: [PATCH 6/6] hw/arm/exynos4210: Connect serial port DMA busy signals with pl330

2020-01-17 Thread Peter Maydell
On Fri, 10 Jan 2020 at 20:39, Guenter Roeck wrote: > > The Exynos4210 serial driver uses an interrupt line to signal if receive > data is available. Connect that interrupt with the DMA controller's > 'peripheral busy' gpio pin. > > Signed-off-by: Guenter Roeck > --- > hw/arm/exynos4210.c | 39

Re: [PATCH v2 1/2] virtio-9p-device: fix memleak in virtio_9p_device_unrealize

2020-01-17 Thread Michael S. Tsirkin
On Fri, Jan 17, 2020 at 01:52:53PM +0100, Christian Schoenebeck wrote: > On Freitag, 17. Januar 2020 07:09:26 CET pannengy...@huawei.com wrote: > > From: Pan Nengyuan > > > > v->vq forgot to cleanup in virtio_9p_device_unrealize, the memory leak > > stack is as follow: > > > > Direct leak of

Re: [PATCH 5/6] hw/char/exynos4210_uart: Add receive DMA support

2020-01-17 Thread Peter Maydell
On Fri, 10 Jan 2020 at 20:39, Guenter Roeck wrote: > > To support receive DMA, we need to inform the DMA controller if receive data > is available. Otherwise the DMA controller keeps requesting data, causing > receive errors. > > Implement this using an interrupt line. The instantiating code then

Re: [PATCH 102/104] virtiofsd: fix lo_destroy() resource leaks

2020-01-17 Thread Philippe Mathieu-Daudé
On 12/12/19 5:39 PM, Dr. David Alan Gilbert (git) wrote: From: Stefan Hajnoczi Now that lo_destroy() is serialized we can call unref_inode() so that all inode resources are freed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/passthrough_ll.c |

Re: [PATCH 4/6] hw/char/exynos4210_uart: Implement receive FIFO

2020-01-17 Thread Peter Maydell
On Fri, 10 Jan 2020 at 20:39, Guenter Roeck wrote: The subject just says "implement receive FIFO", but the existing code clearly has an "Exynos4210UartFIFO rx" which it does some storing and retrieving data from. Could the patch be more accurately described as something like "Implement

Re: [PATCH v3 2/2] vhost: Only align sections for vhost-user

2020-01-17 Thread Michael S. Tsirkin
On Fri, Jan 17, 2020 at 01:52:44PM +0100, Paolo Bonzini wrote: > On 16/01/20 21:24, Dr. David Alan Gilbert (git) wrote: > > +if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) { > > +/* Round the section to it's page size */ > > +/* First align the start down to a

Re: [PATCH v8 4/6] tpm_spapr: Support suspend and resume

2020-01-17 Thread Stefan Berger
On 1/17/20 8:31 AM, Marc-André Lureau wrote: Hi On Wed, Jan 8, 2020 at 8:14 PM Stefan Berger wrote: From: Stefan Berger Extend the tpm_spapr frontend with VM suspend and resume support. Signed-off-by: Stefan Berger --- hw/tpm/tpm_spapr.c | 67

Re: [PATCH 101/104] virtiofsd: prevent FUSE_INIT/FUSE_DESTROY races

2020-01-17 Thread Philippe Mathieu-Daudé
On 12/12/19 5:39 PM, Dr. David Alan Gilbert (git) wrote: From: Stefan Hajnoczi When running with multiple threads it can be tricky to handle FUSE_INIT/FUSE_DESTROY in parallel with other request types or in parallel with themselves. Serialize FUSE_INIT and FUSE_DESTROY so that malicious

Re: [PATCH v2 83/86] tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups

2020-01-17 Thread Igor Mammedov
On Fri, 17 Jan 2020 12:14:11 +0100 Thomas Huth wrote: > On 16/01/2020 18.06, Igor Mammedov wrote: > > On Thu, 16 Jan 2020 17:35:32 +0100 > > Thomas Huth wrote: > > > >> On 15/01/2020 16.07, Igor Mammedov wrote: > >>> Use GString to pass argument to make_cli() so that it would be easy > >>>

Re: [PATCH 104/104] virtiofsd: Convert lo_destroy to take the lo->mutex lock itself

2020-01-17 Thread Philippe Mathieu-Daudé
On 12/12/19 5:39 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" lo_destroy was relying on some implicit knowledge of the locking; we can avoid this if we create an unref_inode that doesn't take the lock and then grab it for the whole of the lo_destroy. Suggested-by:

[PATCH 105/104] virtiofsd: Unref old/new inodes with the same mutex lock in lo_rename()

2020-01-17 Thread Philippe Mathieu-Daudé
We can unref both old/new inodes with the same mutex lock. Signed-off-by: Philippe Mathieu-Daudé --- Based-on: <20191212163904.159893-1-dgilb...@redhat.com> "virtiofs daemon" https://www.mail-archive.com/qemu-devel@nongnu.org/msg664652.html tools/virtiofsd/passthrough_ll.c | 6 -- 1 file

Re: [PATCH 103/104] virtiofsd: add --thread-pool-size=NUM option

2020-01-17 Thread Philippe Mathieu-Daudé
On 12/12/19 5:39 PM, Dr. David Alan Gilbert (git) wrote: From: Stefan Hajnoczi Add an option to control the size of the thread pool. Requests are now processed in parallel by default. Signed-off-by: Stefan Hajnoczi --- tools/virtiofsd/fuse_i.h| 1 +

riscv: How to get more CSR information in debug trace?

2020-01-17 Thread Ian Jiang
The following registers are given in QEMU debug trace with "-d cpu" parameter. pc 1000 mhartid mstatus mip 0x0 mie mideleg medeleg mtvec mepc

Re: [PATCH v8 5/6] hw/ppc/Kconfig: Enable TPM_SPAPR as part of PSERIES config

2020-01-17 Thread Marc-André Lureau
On Wed, Jan 8, 2020 at 8:13 PM Stefan Berger wrote: > > From: Stefan Berger > > Signed-off-by: Stefan Berger (trivial conflict on master) Reviewed-by: Marc-André Lureau > --- > hw/ppc/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig > index

Re: [PATCH 3/6] hw/char/exynos4210_uart: Convert to support tracing

2020-01-17 Thread Peter Maydell
On Fri, 10 Jan 2020 at 20:39, Guenter Roeck wrote: > > Replace debug code with tracing to aid debugging. > > Signed-off-by: Guenter Roeck > --- > hw/char/exynos4210_uart.c | 96 --- > hw/char/trace-events | 17 +++ > 2 files changed, 47

Re: [PATCH v8 4/6] tpm_spapr: Support suspend and resume

2020-01-17 Thread Marc-André Lureau
Hi On Wed, Jan 8, 2020 at 8:14 PM Stefan Berger wrote: > > From: Stefan Berger > > Extend the tpm_spapr frontend with VM suspend and resume support. > > Signed-off-by: Stefan Berger > --- > hw/tpm/tpm_spapr.c | 67 - > hw/tpm/trace-events | 2 ++ >

Re: [PATCH 2/6] hw/arm/exynos4210: Fix DMA initialization

2020-01-17 Thread Peter Maydell
On Fri, 10 Jan 2020 at 20:39, Guenter Roeck wrote: > > First parameter to exynos4210_get_irq() is not the SPI port number, > but the interrupt group number. Interrupt groups are 20 for mdma > and 21 for pdma. Interrupts are not inverted. Controllers support 32 > events (pdma) or 31 events (mdma).

Re: [PATCH 1/6] dma/pl330: Convert to support tracing

2020-01-17 Thread Peter Maydell
On Fri, 10 Jan 2020 at 20:39, Guenter Roeck wrote: > > Replace debug logging code with tracing. > > Signed-off-by: Guenter Roeck > --- > hw/dma/pl330.c | 88 +++-- > hw/dma/trace-events | 24 + > +static void pl330_hexdump(uint8_t *buf,

Re: [PATCH] docs: qemu-cpu-models: Document '-noTSX' variants and 'mds-no'

2020-01-17 Thread Kashyap Chamarthy
On Thu, Jan 16, 2020 at 06:36:38PM +0100, Kashyap Chamarthy wrote: [...] > (2) There are _three_ variants[+] of CascadeLake CPUs, with different > stepping levels: 5, 6, and 7. To quite wikichip.org[*]: s/quite/quote/ > > "note that while steppings 6 & 7 are fully mitigated,

Re: [EXTERNAL] Re: [PATCH] MAINTAINERS: update Leif Lindholm's address

2020-01-17 Thread Leif Lindholm
On Thu, Jan 16, 2020 at 19:25:52 +0100, Philippe Mathieu-Daudé wrote: > On 1/16/20 6:42 PM, Leif Lindholm wrote: > > Update address to reflect new employer. > > > > Signed-off-by: Leif Lindholm > > --- > > MAINTAINERS | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff

Re: [PATCH v6 01/11] qapi/error: add (Error **errp) cleaning APIs

2020-01-17 Thread Eric Blake
On 1/10/20 1:41 PM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- Sparse commit message; it might be nice (for future 'git log' greppability) to at least mention the names of the functions being added. +/* + * Functions to clean Error **errp: call

Re: [PATCH v2] s390x: adapter routes error handling

2020-01-17 Thread Cornelia Huck
On Fri, 17 Jan 2020 12:11:47 +0100 Cornelia Huck wrote: > If the kernel irqchip has been disabled, we don't want the > {add,release}_adapter_routes routines to call any kvm_irqchip_* > interfaces, as they may rely on an irqchip actually having been > created. Just take a quick exit in that case

Re: [PULL v2 00/34] tcg patch queue

2020-01-17 Thread Peter Maydell
On Thu, 16 Jan 2020 at 01:40, Richard Henderson wrote: > > For version 2, drop the -static and -pie changes, > i.e. patches 1-7 from version 1. > > I'll come back to those after the required linux-user changes are > upstream. In the meantime, it's still a large enough set of patches. > > > r~ >

Re: [PATCH v3 18/86] arm:kzm: drop RAM size fixup

2020-01-17 Thread Philippe Mathieu-Daudé
On 1/17/20 10:50 AM, Igor Mammedov wrote: On Thu, 16 Jan 2020 19:22:08 +0100 Philippe Mathieu-Daudé wrote: On 1/16/20 6:26 PM, Igor Mammedov wrote: If the user provided too large a RAM size, the code used to complain and trim it to the max size. Now tht RAM is allocated by generic code,

Re: [PATCH v2] hw/i386: disable smbus migration for xenfv

2020-01-17 Thread Olaf Hering
Am Fri, 17 Jan 2020 11:27:59 +0100 schrieb Paolo Bonzini : > It doesn't even try to be compatible for all existing and future guests. This looks like the underlying bug. What would future domUs lose if 'xenfv' would be locked to 'pc-i440fx-3.0'? Olaf pgpcvh3cEqCHz.pgp Description: Digitale

Re: [PATCH v2 2/2] virtio-9p-device: convert to new virtio_delete_queue

2020-01-17 Thread Christian Schoenebeck
On Freitag, 17. Januar 2020 07:09:27 CET pannengy...@huawei.com wrote: > From: Pan Nengyuan > > Use virtio_delete_queue to make it more clear. > > Signed-off-by: Pan Nengyuan > --- > Changes V2 to V1: > - replace virtio_del_queue to virtio_delete_queue to make it more clear. > --- >

Re: [PATCH v8 2/6] spapr: Implement get_dt_compatible() callback

2020-01-17 Thread Marc-André Lureau
On Wed, Jan 8, 2020 at 8:11 PM Stefan Berger wrote: > > From: Stefan Berger > > For devices that cannot be statically initialized, implement a > get_dt_compatible() callback that allows us to ask the device for > the 'compatible' value. > > Signed-off-by: Stefan Berger Reviewed-by: Marc-André

Re: [PATCH v2 1/2] virtio-9p-device: fix memleak in virtio_9p_device_unrealize

2020-01-17 Thread Christian Schoenebeck
On Freitag, 17. Januar 2020 07:09:26 CET pannengy...@huawei.com wrote: > From: Pan Nengyuan > > v->vq forgot to cleanup in virtio_9p_device_unrealize, the memory leak > stack is as follow: > > Direct leak of 14336 byte(s) in 2 object(s) allocated from: > #0 0x7f819ae43970

Re: [PATCH v3 2/2] vhost: Only align sections for vhost-user

2020-01-17 Thread Paolo Bonzini
On 16/01/20 21:24, Dr. David Alan Gilbert (git) wrote: > +if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) { > +/* Round the section to it's page size */ > +/* First align the start down to a page boundary */ > +size_t mrs_page =

Re: [PATCH v3 0/2] Fix hyperv synic on vhost

2020-01-17 Thread Dr. David Alan Gilbert
* no-re...@patchew.org (no-re...@patchew.org) wrote: > Patchew URL: > https://patchew.org/QEMU/20200116202414.157959-1-dgilb...@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Message-id:

Re: [PATCH 1/2] target/ppc: Add privileged message send facilities

2020-01-17 Thread Cédric Le Goater
On 1/17/20 10:46 AM, David Gibson wrote: > On Thu, Jan 09, 2020 at 05:33:45PM +0100, Cédric Le Goater wrote: >> The Processor Control facility POWER8 processors and later provides >> a mechanism for the hypervisor to send messages to other threads >> in the system (msgsnd instruction) and cause

Re: [PULL 00/30] Migration pull patches (take 4)

2020-01-17 Thread Juan Quintela
Juan Quintela wrote: > Peter Maydell wrote: >> On Tue, 14 Jan 2020 at 12:53, Juan Quintela wrote: >> >> I think you need to find a system which has 32-bit ram_addr_t >> and test this, because this is about the fourth time round >> for this patchset failing on this configuration. > > That is

Re: [PATCH v2 0/3] exclude hyperv synic sections from vhost

2020-01-17 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 13/01/20 18:36, Dr. David Alan Gilbert (git) wrote: > > > > Hyperv's synic (that we emulate) is a feature that allows the guest > > to place some magic (4k) pages of RAM anywhere it likes in GPA. > > This confuses vhost's RAM section merging when

Re: [PATCH v6 2/3] kvm-all: Introduce kvm_set_singlestep

2020-01-17 Thread David Gibson
On Fri, Jan 17, 2020 at 07:27:48PM +1000, David Gibson wrote: > On Fri, Jan 10, 2020 at 12:13:43PM -0300, Fabiano Rosas wrote: > > For single stepping (via KVM) of a guest vcpu to work, KVM needs not > > only to support the SET_GUEST_DEBUG ioctl but to also recognize the > >

Re: [PATCH] tests/vhost-user-bridge: Fix build

2020-01-17 Thread Thomas Huth
On 17/01/2020 13.26, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > vhost-user-bridge isn't actually a test, it's just a helper > (that should probably move somewhere else) - but the build was > broken in the qtest move. > > Fixes: 833884f37adc9f125fa2 > Signed-off-by:

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-17 Thread David Gibson
On Thu, Jan 16, 2020 at 07:29:02PM +0100, Greg Kurz wrote: > On Thu, 16 Jan 2020 13:14:35 +0100 > Greg Kurz wrote: > > > On Thu, 16 Jan 2020 11:37:24 +0100 > > Laurent Vivier wrote: > > > > > On 16/01/2020 09:48, Greg Kurz wrote: > > > > On Wed, 15 Jan 2020 19:10:37 +0100 > > > > Laurent

Re: [PATCH 2/2] target/ppc: add support for Hypervisor Facility Unavailable Exception

2020-01-17 Thread David Gibson
On Thu, Jan 09, 2020 at 05:33:46PM +0100, Cédric Le Goater wrote: > The privileged message send and clear instructions (msgsndp & msgclrp) > are privileged, but will generate a hypervisor facility unavailable > exception if not enabled in the HFSCR and executed in privileged > non-hypervisor

[PATCH] tests/vhost-user-bridge: Fix build

2020-01-17 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" vhost-user-bridge isn't actually a test, it's just a helper (that should probably move somewhere else) - but the build was broken in the qtest move. Fixes: 833884f37adc9f125fa2 Signed-off-by: Dr. David Alan Gilbert --- tests/Makefile.include | 1 +

Re: [PATCH v6 1/3] target/ppc: Clarify the meaning of return values in kvm_handle_debug

2020-01-17 Thread David Gibson
On Fri, Jan 10, 2020 at 12:13:42PM -0300, Fabiano Rosas wrote: > The kvm_handle_debug function can return 0 to go back into the guest > or return 1 to notify the gdbstub thread and pass control to GDB. > > Signed-off-by: Fabiano Rosas Good change regardless of the rest of the series. Applied

Re: [PATCH 1/2] target/ppc: Add privileged message send facilities

2020-01-17 Thread David Gibson
On Thu, Jan 09, 2020 at 05:33:45PM +0100, Cédric Le Goater wrote: > The Processor Control facility POWER8 processors and later provides > a mechanism for the hypervisor to send messages to other threads > in the system (msgsnd instruction) and cause hypervisor-level > exceptions. Privileged

Re: [PATCH v6 2/3] kvm-all: Introduce kvm_set_singlestep

2020-01-17 Thread David Gibson
On Fri, Jan 10, 2020 at 12:13:43PM -0300, Fabiano Rosas wrote: > For single stepping (via KVM) of a guest vcpu to work, KVM needs not > only to support the SET_GUEST_DEBUG ioctl but to also recognize the > KVM_GUESTDBG_SINGLESTEP bit in the control field of the > kvm_guest_debug struct. > > This

Re: [PULL 00/30] Migration pull patches (take 4)

2020-01-17 Thread Juan Quintela
Peter Maydell wrote: > On Tue, 14 Jan 2020 at 12:53, Juan Quintela wrote: >> >> The following changes since commit 3c8a6575985b1652b45bfa670b5e1907d642cfa0: >> >> Merge remote-tracking branch >> 'remotes/kraxel/tags/usb-20200113-pull-request' into staging >> (2020-01-13 14:19:57 +) >> >>

Re: [PATCH v3 3/4] qmp: Move dispatcher to a coroutine

2020-01-17 Thread Markus Armbruster
Kevin Wolf writes: > This moves the QMP dispatcher to a coroutine and runs all QMP command > handlers that declare 'coroutine': true in coroutine context so they > can avoid blocking the main loop while doing I/O or waiting for other > events. > > For commands that are not declared safe to run

Re: [PATCH v22 9/9] MAINTAINERS: Add ACPI/HEST/GHES entries

2020-01-17 Thread Michael S. Tsirkin
On Fri, Jan 17, 2020 at 11:09:07AM +, Peter Maydell wrote: > On Fri, 17 Jan 2020 at 07:22, Philippe Mathieu-Daudé > wrote: > > > > Hi Peter, > > > > On 1/16/20 5:46 PM, Peter Maydell wrote: > > > On Wed, 8 Jan 2020 at 11:32, Dongjiu Geng wrote: > > >> > > >> I and Xiang are willing to

Re: qemu-4.0.1: vhost_region_add_section:Section rounded to 0 prior to previous a0000

2020-01-17 Thread Peter Lieven
Am 16.01.20 um 21:26 schrieb Dr. David Alan Gilbert: > * Peter Lieven (p...@kamp.de) wrote: >> Am 16.01.20 um 13:47 schrieb Peter Lieven: >>> Am 13.01.20 um 17:25 schrieb Peter Lieven: Am 09.01.20 um 19:44 schrieb Dr. David Alan Gilbert: > * Peter Lieven (p...@kamp.de) wrote: >> Am

Re: [PULL 0/5] 9p patches 2020-01-14

2020-01-17 Thread Peter Maydell
On Tue, 14 Jan 2020 at 16:02, Greg Kurz wrote: > > The following changes since commit 3c8a6575985b1652b45bfa670b5e1907d642cfa0: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20200113-pull-request' into staging (2020-01-13 > 14:19:57 +) > > are available in the Git repository

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-17 Thread Laurent Vivier
On 17/01/2020 12:49, Greg Kurz wrote: > On Wed, 15 Jan 2020 19:26:18 +0100 > Laurent Vivier wrote: > >> On 15/01/2020 19:10, Laurent Vivier wrote: >>> Hi, >>> >>> On 15/01/2020 18:48, Greg Kurz wrote: Migration can potentially race with CAS reboot. If the migration thread completes

Re: [Qemu-devel] [PATCH v3] RISC-V: Select FPU gdb xml file based on the supported extensions

2020-01-17 Thread Alistair Francis
On Tue, Jan 7, 2020 at 10:21 PM Alex Bennée wrote: > > > Georg Kotheimer writes: > > > The size of the FPU registers depends solely on the floating point > > extensions supported by the target architecture. > > However, in the previous implementation the floating point register > > size was

<    1   2   3   >