Re: [PATCH v4 6/7] disas: mips: Add micromips R6 disassembler - infrastructure and 16-bit instructions

2020-01-24 Thread Richard Henderson
On 1/24/20 1:38 PM, Aleksandar Markovic wrote: > On Friday, January 24, 2020, Richard Henderson > wrote: > The thing I'm concerned about here is any future maintenance of this > file.  One > would surely prefer to edit the original decodetree input

Re: [PATCH v3 00/21] Multifd Migration Compression

2020-01-24 Thread Markus Armbruster
Juan Quintela writes: > [v3] > - rebased on top of upstream + previous multifd cancel series > - split multifd code into its own file (multifd.[ch]) > - split zstd/zlib compression methods (multifd-zstd/zlib.c) > - use qemu module feauture to avoid ifdefs > (my understanding is that zlib needs

Re: Integrating QOM into QAPI

2020-01-24 Thread Marc-André Lureau
Hi Le ven. 24 janv. 2020 à 19:32, Paolo Bonzini a écrit : > On 22/01/20 13:42, Marc-André Lureau wrote: > > From the top of my mind, this is the pain point when trying to use > GObject: > > - static/inlined object, not supported by GObject, unlikely to ever be > > - few users in qemu,

[Bug 1852781] Re: qemu s390x on focal - applications breaking

2020-01-24 Thread Launchpad Bug Tracker
[Expired for Ubuntu on IBM z Systems because there has been no activity for 60 days.] ** Changed in: ubuntu-z-systems Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Bug 1852781] Re: qemu s390x on focal - applications breaking

2020-01-24 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1852781 Title: qemu s390x

[Bug 1849879] Re: qemu-arm should accept vmrs apsr_nzcv, fpscr on M-profile

2020-01-24 Thread Richard Henderson
Fixed in 2529ab43b8a05534494704e803e0332d111d8b91, which is in 4.2. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1849879 Title: qemu-arm

Re: [PATCH v4 6/7] disas: mips: Add micromips R6 disassembler - infrastructure and 16-bit instructions

2020-01-24 Thread Aleksandar Markovic
On Friday, January 24, 2020, Richard Henderson wrote: > On 1/24/20 10:56 AM, Aleksandar Markovic wrote: > > > > > > On Friday, January 24, 2020, Richard Henderson < > richard.hender...@linaro.org > > > wrote: > > > > On 1/24/20 6:38 AM, Aleksandar

[PULL v3 11/11] target/hppa: Allow, but diagnose, LDCW aligned only mod 4

2020-01-24 Thread Richard Henderson
The PA-RISC 1.1 specification says that LDCW must be aligned mod 16 or the operation is undefined. However, real hardware only generates an unaligned access trap for unaligned mod 4. Match real hardware, but diagnose with GUEST_ERROR a violation of the specification. At the same time fix a bug

[PULL v3 09/11] hw/hppa/machine: Restrict the total memory size to 3GB

2020-01-24 Thread Richard Henderson
From: Philippe Mathieu-Daudé The hardware expects DIMM slots of 1 or 2 GB, allowing up to 4 GB of memory. We want to accept the same amount of memory the hardware can deal with. DIMMs of 768MB are not available. However we have to deal with a firmware limitation: currently SeaBIOS only supports

[PULL v3 04/11] hppa: add emulation of LASI PS2 controllers

2020-01-24 Thread Richard Henderson
From: Sven Schnelle Signed-off-by: Sven Schnelle Message-Id: <20191220211512.3289-5-sv...@stackframe.org> Signed-off-by: Richard Henderson --- include/hw/input/lasips2.h | 16 ++ include/hw/input/ps2.h | 1 + hw/hppa/lasi.c | 10 +- hw/input/lasips2.c | 291

[PULL v3 07/11] hppa: Add emulation of Artist graphics

2020-01-24 Thread Richard Henderson
From: Sven Schnelle This adds emulation of Artist graphics good enough to get a text console on both Linux and HP-UX. The X11 server from HP-UX also works. Adjust boot-serial-test to disable graphics, so that SeaBIOS outputs to the serial port, as expected by the test. Signed-off-by: Sven

[PULL v3 08/11] hw/hppa/machine: Correctly check the firmware is in PDC range

2020-01-24 Thread Richard Henderson
From: Philippe Mathieu-Daudé The firmware has to reside in the PDC range. If the Elf file expects to load it below FIRMWARE_START, it is incorrect, regardless the RAM size. Acked-by: Helge Deller Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id:

[PULL v3 05/11] hppa: Switch to tulip NIC by default

2020-01-24 Thread Richard Henderson
From: Helge Deller Most HP PA-RISC machines have a Digital DS21142/43 Tulip network card, only some very latest generation machines have an e1000 NIC. Since qemu now provides an emulated tulip card, use that one instead. Signed-off-by: Helge Deller Message-Id:

[PULL v3 03/11] ps2: accept 'Set Key Make and Break' commands

2020-01-24 Thread Richard Henderson
From: Sven Schnelle HP-UX sends both the 'Set key make and break (0xfc) and 'Set all key typematic make and break' (0xfa). QEMU response with 'Resend' as it doesn't handle these commands. HP-UX than reports an PS/2 max retransmission exceeded error. Add these commands and just reply with ACK.

[PULL v3 01/11] hw/hppa/dino.c: Improve emulation of Dino PCI chip

2020-01-24 Thread Richard Henderson
From: Helge Deller The tests of the dino chip with the Online-diagnostics CD ("ODE DINOTEST") now succeeds. Additionally add some qemu trace events. Signed-off-by: Helge Deller Signed-off-by: Sven Schnelle Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[PULL v3 02/11] hppa: Add support for LASI chip with i82596 NIC

2020-01-24 Thread Richard Henderson
From: Helge Deller LASI is a built-in multi-I/O chip which supports serial, parallel, network (Intel i82596 Apricot), sound and other functionalities. LASI has been used in many HP PARISC machines. This patch adds the necessary parts to allow Linux and HP-UX to detect LASI and the network card.

[PULL v3 00/11] target/hppa patch queue

2020-01-24 Thread Richard Henderson
12:34:04 +) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-pa-20200124 for you to fetch changes up to 5b33eecce852658121b1190fee466f01a69e1910: target/hppa: Allow, but diagnose, LDCW aligned only mod 4 (2020-01-24 14:35:58 -0800

[PULL v3 10/11] hw/hppa/machine: Map the PDC memory region with higher priority

2020-01-24 Thread Richard Henderson
From: Philippe Mathieu-Daudé The region in range [0xf000 - 0xf100] is the PDC area (Processor Dependent Code), where the firmware is loaded. This region has higher priority than the main memory. When the machine has more than 3840MB of RAM, there is an overlap. Since the PDC is closer

Re: [PATCH] bsd-user: improve support for sparc syscall flags

2020-01-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200124223118.58596-1-salva...@qindel.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200124223118.58596-1-salva...@qindel.com Subject: [PATCH] bsd-user: improve support

[PATCH] bsd-user: improve support for sparc syscall flags

2020-01-24 Thread salvador
From: Salvador Fandino Under sparc and sparc64, both NetBSD and OpenSSH use two bits of the syscall number as flags. Until now, those bits where only supported for sparc64 when emulating OpenBSD. This patch extends support for syscall flags to the sparc architecture and NetBSD emulation. It had

Re: [PATCH v1 12/13] tests/docker: re-enable cross-compiling for x86_64 hosts

2020-01-24 Thread Richard Henderson
On 1/24/20 10:40 AM, Alex Bennée wrote: > +../dockerfiles.cross/fedora-i386-build-qemu.docker > \ No newline at end of file Lots of no trailing newlines. Probably not intentional? r~

Re: [PATCH] bsd-user: improve support for sparc syscall flags

2020-01-24 Thread Salvador Fandiño
On 24/1/20 20:44, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200124183113.58039-1-salva...@qindel.com/ Hi, This series seems to have some coding style problems. See output below for more information: A new patch is coming fixing the errors found by patchew in

Re: [PATCH v6 0/2] Use DIAG318 to set Control Program Name & Version Codes

2020-01-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1579904044-20790-1-git-send-email-wall...@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1579904044-20790-1-git-send-email-wall...@linux.ibm.com Subject: [PATCH v6

[PATCH v6 1/2] s390/kvm: header sync for diag318

2020-01-24 Thread Collin Walling
Signed-off-by: Collin Walling Acked-by: David Hildenbrand --- linux-headers/asm-s390/kvm.h | 4 1 file changed, 4 insertions(+) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index 0138ccb..4633090 100644 --- a/linux-headers/asm-s390/kvm.h +++

[PATCH v6 0/2] Use DIAG318 to set Control Program Name & Version Codes

2020-01-24 Thread Collin Walling
Changes from v5 -> v6 Migration and DeviceObject Code: - load/save/needed functions now check if kvm_enabled before calling kvm_get/set and has_feat (respectively) QEMU->KVM Code: - added kvm_s390_* stubs for get/set functions for TCG compilation VCPU

[PATCH v6 2/2] s390: diagnose 318 info reset and migration support

2020-01-24 Thread Collin Walling
DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must be intercepted by SIE and handled via KVM. Let's introduce some functions to communicate between QEMU and KVM via ioctls. These will be used to get/set the diag318 information. The availability of this instruction is determined

Re: [PATCH] tests/acceptance: Add boot tests for some of the QEMU advent calendar images

2020-01-24 Thread Wainer dos Santos Moschetta
On 1/24/20 3:03 PM, Thomas Huth wrote: The 2018 edition of the QEMU advent calendar 2018 featured Linux images for various non-x86 machines. We can use them for a boot tests in our acceptance test suite. Let's also make sure that we build the corresponding machines in Travis, and while we're

Re: [PATCH v3 4/4] travis.yml: Enable acceptance KVM tests

2020-01-24 Thread Wainer dos Santos Moschetta
On 1/22/20 7:22 AM, Thomas Huth wrote: On 22/01/2020 02.27, Wainer dos Santos Moschetta wrote: Some acceptance tests require KVM or they are skipped. Travis enables nested virtualization by default with Ubuntu 18.04 (Bionic) on x86_64. So in order to run the kvm tests, this changed the

Re: [PATCH v4 6/7] disas: mips: Add micromips R6 disassembler - infrastructure and 16-bit instructions

2020-01-24 Thread Richard Henderson
On 1/24/20 10:56 AM, Aleksandar Markovic wrote: > > > On Friday, January 24, 2020, Richard Henderson > wrote: > > On 1/24/20 6:38 AM, Aleksandar Markovic wrote: > > The basic disassembly logic was obtained by somewhat modified script > >

[PATCH] bcm2835_dma: Fix TD mode

2020-01-24 Thread Rene Stange
TD (two dimensions) DMA mode did not work, because the xlen variable has not been re-initialized before each additional ylen run through in bcm2835_dma_update(). Furthermore ylen has to be increased by one after reading it from the TXFR_LEN register, because a value of zero has to result in one

Re: [PATCH v4 6/7] disas: mips: Add micromips R6 disassembler - infrastructure and 16-bit instructions

2020-01-24 Thread Aleksandar Markovic
On Friday, January 24, 2020, Richard Henderson wrote: > On 1/24/20 6:38 AM, Aleksandar Markovic wrote: > > The basic disassembly logic was obtained by somewhat modified script > > decodetree.py, and such output was further manually modified to > > handle numerous details of micromips 32R6

Re: Booting Debian in qemu-system-alpha

2020-01-24 Thread John Paul Adrian Glaubitz
On 1/24/20 9:19 PM, Richard Henderson wrote: > Oh. Hah! I just tried again, cutting and pasting your command-line. You've > got unicode quotes, not ascii ' (\x27). That gets passed through to the > kernel > as-is and prevents console=ttyS0 from being parsed properly. Good catch. That helped.

[PATCH v1 09/13] tests/docker: switch to multiarch aware container support

2020-01-24 Thread Alex Bennée
We drop support for DOCKER_PARTIAL_IMAGE and related hacks in favour of explicit building of lists of images by type. Currently we can't do any of the QEMU builds but the docker-image target will allow us to test that every docker image we declare can actually be built. Later commits will

[PATCH v1 12/13] tests/docker: re-enable cross-compiling for x86_64 hosts

2020-01-24 Thread Alex Bennée
Now we have moved everything around we can re-enable the builds for x86_64. Thanks to the descriptive names we are able to sort out QEMU build and tests build dockerfiles and ensure the correct debian dependencies. Move the fedora, mxe and travis dockerfiles into the x86_64 directory as they

[PATCH v1 08/13] tests/docker: search the tests/docker tree to inline parent dockerfile

2020-01-24 Thread Alex Bennée
The changes to a multi-directory set of dockerfiles means we can't rely on hardcoding any more. Just search down the tree until we find the file we are looking for. Signed-off-by: Alex Bennée --- tests/docker/docker.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH v1 13/13] tests/docker: enable cross-compilers for aarch64

2020-01-24 Thread Alex Bennée
While Debian's aarch64 mainly only packages other ARM compilers we do have access to x86_64 cross compilers and a few system compilers for various micro controllers. Signed-off-by: Alex Bennée --- .../dockerfiles.aarch64/Makefile.include | 24 +++

[PATCH v1 06/13] tests/docker: move all cross-compilers images into dockerfiles.cross

2020-01-24 Thread Alex Bennée
These images will no longer be visible to the main container build process. This is because we will want to selectively include them for each supported architecture later. Signed-off-by: Alex Bennée --- .../{dockerfiles => dockerfiles.cross}/debian-alpha-cross.docker | 0 .../{dockerfiles =>

[PATCH v1 07/13] tests/docker: move all multiarch containers into dockerfiles.multiarch

2020-01-24 Thread Alex Bennée
We define multiarch as base distributions that are likely to have images for any given host architecture. They will shortly be re-included in the make Makefile. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 4 +--- .../dockerfiles.multiarch/Makefile.include

[PATCH v1 11/13] tests/docker: rename the cross builds

2020-01-24 Thread Alex Bennée
The fact they are cross builds is known by virtue of where they are in the system. Simplify the naming to a new scheme: $(BASEOS)-$(ARCH)-build-(qemu|tests) Ultimately we will be able to build again $ARCH with something like: make docker-test-build@debian10-arm64-build-qemu On whatever

[PATCH v1 05/13] .shippable: --disable-docs for cross-compile tests

2020-01-24 Thread Alex Bennée
The sphinx support is fairly new and we don't seem to have all the bugs worked out for cross development environments right now. Signed-off-by: Alex Bennée --- .shippable.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.shippable.yml b/.shippable.yml index

[PATCH v1 00/13] docker multiarch awareness

2020-01-24 Thread Alex Bennée
Hi, This is a series I've had on the back-burner for awhile. The idea is to make the docker build system fully multiarch aware. Much like the check-tcg system this involves a bunch of included Makefile fragments. It also tries to address the need to track docker dependencies in the Makefile

[PATCH v1 01/13] tests/docker: move most cross compilers to buster base

2020-01-24 Thread Alex Bennée
This includes fixing up the dependencies (Which were already wrong for one of the mips variants). Signed-off-by: Alex Bennée --- tests/docker/Makefile.include| 16 tests/docker/dockerfiles/debian-amd64.docker | 2 +-

[PATCH v1 10/13] tests/docker: add debian10-native-qemu-build

2020-01-24 Thread Alex Bennée
This is a new dockerfile which can build the native architecture QEMU on a Debian 10 based image whatever architecture that may be. Signed-off-by: Alex Bennée --- .../dockerfiles/debian10-native-qemu-build.docker | 15 +++ 1 file changed, 15 insertions(+) create mode 100644

[PATCH v1 03/13] gitlab-ci: Refresh the list of iotests

2020-01-24 Thread Alex Bennée
From: Thomas Huth iotest 147 and 205 have recently been marked as "NBD-only", so they are currently simply skipped and thus can be removed. iotest 129 occasionally fails in the gitlab-CI, and according to Max, there are some known issues with this test (see for example this URL:

[PATCH v1 02/13] tests/docker: better handle symlinked libs

2020-01-24 Thread Alex Bennée
When we are copying we want to ensure we grab the first resolution (the found in path section). However even that binary might be a symlink so lets make sure we chase the symlinks to copy the right binary to where it can be found. Signed-off-by: Alex Bennée --- tests/docker/docker.py | 5 +++--

[PATCH v1 04/13] travis.yml: Install genisoimage package

2020-01-24 Thread Alex Bennée
From: Wainer dos Santos Moschetta The genisoimage program is required for tests/cdrom-test tests, otherwise they are skipped. The current Travis environments do not provide it by default, so let's explicitly require the genisoimage package. Signed-off-by: Wainer dos Santos Moschetta

Re: [PATCH v2 0/2] Add support for 2nd generation AMD EPYC processors

2020-01-24 Thread Babu Moger
Its been a while. Pinging again. Please review. On 11/7/19 12:00 PM, Moger, Babu wrote: > The following series adds the support for 2nd generation AMD EPYC Processors > on qemu guests. The model display name for 2nd generation will be EPYC-Rome. > > Also fixes few missed cpu feature bits in 1st

Re: Making QEMU easier for management tools and applications

2020-01-24 Thread John Snow
On 1/24/20 2:59 AM, Markus Armbruster wrote: > Digression: JSON is a poor choice for configuration files. YAML is a > complex and confusing beast (it's spec is printed 116 pages, and > yaml-0.2.2/src is ~7kSLOC). XML is XML, 'nuff said. TOML is much > simpler than either of the two. JSON has

Re: Booting Debian in qemu-system-alpha

2020-01-24 Thread Richard Henderson
On 1/24/20 6:16 AM, John Paul Adrian Glaubitz wrote: > Hi! > > Has anyone had any success recently booting Debian on qemu-system-alpha? > > I just built qemu-system using the alpha-softmmu target from git and tried > to run Debian's Alpha port but the output hangs very early: > >

[PULL v4 00/58] Misc (x86 and QOM) patches for 2020-01-23

2020-01-24 Thread Paolo Bonzini
The following changes since commit 3e08b2b9cb64bff2b73fa9128c0e49bfcde0dd40: Merge remote-tracking branch 'remotes/philmd-gitlab/tags/edk2-next-20200121' into staging (2020-01-21 15:29:25 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream

Re: [PULL v2 00/59] Misc (x86 and QOM) patches for 2020-01-23

2020-01-24 Thread Paolo Bonzini
On 24/01/20 17:32, Peter Maydell wrote: > On Fri, 24 Jan 2020 at 09:18, Paolo Bonzini wrote: >> >> The following changes since commit 3e08b2b9cb64bff2b73fa9128c0e49bfcde0dd40: >> >> Merge remote-tracking branch >> 'remotes/philmd-gitlab/tags/edk2-next-20200121' into staging (2020-01-21 >>

Re: [PATCH] target/arm/arm-semi: Don't let the guest close stdin/stdout/stderr

2020-01-24 Thread Alex Bennée
Peter Maydell writes: > The guest can use the semihosting API to open a handle > corresponding to QEMU's own stdin, stdout, or stderr. > When the guest closes this handle, we should not > close the underlying host stdin/stdout/stderr > the way we would do if the handle corresponded to > a host

Re: [PATCH v3 4/4] travis.yml: Enable acceptance KVM tests

2020-01-24 Thread Wainer dos Santos Moschetta
On 1/24/20 7:54 AM, Philippe Mathieu-Daudé wrote: On 1/24/20 10:44 AM, Thomas Huth wrote: On 24/01/2020 10.38, Philippe Mathieu-Daudé wrote: On 1/22/20 2:27 AM, Wainer dos Santos Moschetta wrote: Some acceptance tests require KVM or they are skipped. Travis enables nested virtualization by

Re: [PATCH] bsd-user: improve support for sparc syscall flags

2020-01-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200124183113.58039-1-salva...@qindel.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200124183113.58039-1-salva...@qindel.com Subject: [PATCH] bsd-user: improve support

Re: [PATCH v4 6/7] disas: mips: Add micromips R6 disassembler - infrastructure and 16-bit instructions

2020-01-24 Thread Richard Henderson
On 1/24/20 6:38 AM, Aleksandar Markovic wrote: > The basic disassembly logic was obtained by somewhat modified script > decodetree.py, and such output was further manually modified to > handle numerous details of micromips 32R6 instruction coding scheme. What modifications to the script? What

Re: [EXTERNAL] Re: QEMU for aarch64 with plugins seems to fail basic consistency checks

2020-01-24 Thread Alex Bennée
Robert Henry writes: > I found at least one problem with my plugin. > > I was assuming that the insn data from > struct qemu_plugin_insn *insn = qemu_plugin_tb_get_insn(tb, i); > could be passed into qemu_plugin_register_vcpu_insn_exec_cb both as the 1st > argument AND as the user data

[Bug 1860553] Re: cmake crashes on qemu-alpha-user with Illegal Instruction

2020-01-24 Thread Richard Henderson
There is no call insn in your listing at 0x40007fd988, so the easy assumption is that the return address has been corrupted on the stack. You'll have to dig deeper than just the insn listing. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [PATCH REPOST v3 78/80] hostmem: fix strict bind policy

2020-01-24 Thread Halil Pasic
On Thu, 23 Jan 2020 12:38:43 +0100 Igor Mammedov wrote: > With main RAM now converted to hostmem backends, there is no > point in keeping global mem_prealloc around, so alias > -mem-prealloc to "memory-backend.prealloc=on" > machine compat[*] property and make mem_prealloc a local > variable to

[Bug 1860553] Re: cmake crashes on qemu-alpha-user with Illegal Instruction

2020-01-24 Thread Richard Henderson
Of course. Trying to use halt from userland on hw will SIGILL as well. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1860553 Title: cmake crashes on qemu-alpha-user with Illegal Instruction

Re: [PATCH] tests/acceptance: Add boot tests for some of the QEMU advent calendar images

2020-01-24 Thread Liam Merwick
On 24/01/2020 17:03, Thomas Huth wrote: The 2018 edition of the QEMU advent calendar 2018 featured Linux images for various non-x86 machines. We can use them for a boot tests in our acceptance test suite. Let's also make sure that we build the corresponding machines in Travis, and while we're

Re: [PATCH 2/8] tests/vm: increased max timeout for vm boot.

2020-01-24 Thread Robert Foley
Hi Phil, > I once suggested "When using TCG, wait longer for a VM to start" > https://www.mail-archive.com/qemu-devel@nongnu.org/msg550610.html > Thanks for the pointer. This increase in timeout under TCG seems just right for the case we saw. I will incorporate this into the patch. Thanks &

Re: Making QEMU easier for management tools and applications

2020-01-24 Thread John Snow
On 1/24/20 1:52 PM, Dr. David Alan Gilbert wrote: > * John Snow (js...@redhat.com) wrote: >> >> >> On 1/24/20 1:30 PM, Dr. David Alan Gilbert wrote: >>> However, I caution that too many people think that QMP has all the type >>> of diagnostic stuff people want - it's just way too hard and

Re: [PATCH v3 16/21] migration: Add support for modules

2020-01-24 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> So we don't have to compile everything in, or have ifdefs > > Can you explain to me what this is allowing us to do? See the zstd support. We don't need to do anything in any other file. If you compile-in the

Re: Making QEMU easier for management tools and applications

2020-01-24 Thread Dr. David Alan Gilbert
* John Snow (js...@redhat.com) wrote: > > > On 1/24/20 1:30 PM, Dr. David Alan Gilbert wrote: > > However, I caution that too many people think that QMP has all the type > > of diagnostic stuff people want - it's just way too hard and beuracratic > > to add a simple diagnostic command to QMP,

Re: [PATCH v3 21/21] migration: Add zstd compression multifd support

2020-01-24 Thread Juan Quintela
Eric Blake wrote: > On 1/23/20 5:58 AM, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> hw/core/qdev-properties.c| 2 +- >> migration/Makefile.objs | 1 + >> migration/migration.c| 6 + >> migration/multifd-zstd.c | 304

Re: Making QEMU easier for management tools and applications

2020-01-24 Thread John Snow
On 1/24/20 1:30 PM, Dr. David Alan Gilbert wrote: > However, I caution that too many people think that QMP has all the type > of diagnostic stuff people want - it's just way too hard and beuracratic > to add a simple diagnostic command to QMP, when you just want to add > something to print some

Re: [PULL v2 11/14] semihosting: add qemu_semihosting_console_inc for SYS_READC

2020-01-24 Thread Keith Packard
Peter Maydell writes: > I'm not sure what we should do with EOF, but presumably > we should handle it in some way. There's no correct answer here, which is why the current implementation just ignores it. Here are a couple of options: 1. Just return whatever getchar() provides; if it returns

RE: [Question] Regarding containers "unattached/peripheral/anonymous" - their relation with hot(un)plug of devices

2020-01-24 Thread Salil Mehta
> From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: Friday, January 24, 2020 4:07 PM > > On Fri, 24 Jan 2020 15:02:10 + > Salil Mehta wrote: > > > > From: Igor Mammedov [mailto:imamm...@redhat.com] > > > Sent: Friday, January 24, 2020 1:54 PM > > > To: Salil Mehta > > > > > > On

Re: [PATCH v3 20/21] configure: Enable test and libs for zstd

2020-01-24 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > configure | 30 ++ > 1 file changed, 30 insertions(+) > > diff --git a/configure b/configure > index 557e4382ea..56ddfd7f8a 100755 > ---

Re: [EXTERNAL]Re: [PULL v2 0/7] MIPS queue for Jan 24th, 2020

2020-01-24 Thread Aleksandar Markovic
> I don't think the patches from Igor are suitable for cherry-picking > into your tree, because they depend on earlier patches from the > start of his series which haven't yet gone into master. Auch. Sorry. In that case, please ignore this pull request. I will send a new one hopefully next week.

Re: [PULL v2 0/7] MIPS queue for Jan 24th, 2020

2020-01-24 Thread Peter Maydell
On Fri, 24 Jan 2020 at 18:07, Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > The following changes since commit ba2ed84fe6a78f64b2da441750fc6e925d94106a: > > Merge remote-tracking branch 'remotes/palmer/tags/riscv-for-master-5.0-sf1' > into staging (2020-01-24 12:34:04 +) >

Re: Integrating QOM into QAPI

2020-01-24 Thread Paolo Bonzini
On 22/01/20 13:42, Marc-André Lureau wrote: > From the top of my mind, this is the pain point when trying to use GObject: > - static/inlined object, not supported by GObject, unlikely to ever be > - few users in qemu, transition possible. > - 64k limit of GObject, for some reason, unlikely to

[PATCH] bsd-user: improve support for sparc syscall flags

2020-01-24 Thread salvador
From: Salvador Fandino Under sparc and sparc64, both NetBSD and OpenSSH use two bits of the syscall number as flags. Until now, those bits where only supported for sparc64 when emulating OpenBSD. This patch extends support for syscall flags to the sparc architecture and NetBSD emulation. It had

Re: Making QEMU easier for management tools and applications

2020-01-24 Thread Dr. David Alan Gilbert
* John Snow (js...@redhat.com) wrote: > > > On 1/24/20 9:38 AM, Kevin Wolf wrote: > > Hi! :-) > > > > Well, not fighting for it to the death and I'm certainly not married to > > its exact syntax, but I use HMP all the time because it's convenient to > > use manually and QMP isn't. > > > > If

Re: [PATCH v2 3/8] docs/sphinx: Add new hxtool Sphinx extension

2020-01-24 Thread Alex Bennée
Peter Maydell writes: > Some of our documentation includes sections which are created > by assembling fragments of texinfo from a .hx source file into > a .texi file, which is then included from qemu-doc.texi or > qemu-img.texi. > > For Sphinx, rather than creating a file to include, the most

Re: Making QEMU easier for management tools and applications

2020-01-24 Thread John Snow
On 1/24/20 9:38 AM, Kevin Wolf wrote: > Hi! :-) > > Well, not fighting for it to the death and I'm certainly not married to > its exact syntax, but I use HMP all the time because it's convenient to > use manually and QMP isn't. > > If you want to remove HMP, get us a decent QMP shell first.

Re: [PATCH v3 16/21] migration: Add support for modules

2020-01-24 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > So we don't have to compile everything in, or have ifdefs Can you explain to me what this is allowing us to do? Dave > Signed-off-by: Juan Quintela > --- > include/qemu/module.h | 2 ++ > vl.c | 1 + > 2 files changed, 3

[PULL v2 7/7] mips/mips_r4k: use memdev for RAM

2020-01-24 Thread Aleksandar Markovic
From: Igor Mammedov memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead

[PULL v2 3/7] mips-semi.c: remove 'uhi_done' label in helper_do_semihosting()

2020-01-24 Thread Aleksandar Markovic
From: Daniel Henrique Barboza The label 'uhi_done' is a simple 'return' call and can be removed for a bit more clarity in the code. CC: Aurelien Jarno CC: Aleksandar Markovic CC: Aleksandar Rikalo Reviewed-by: Aleksandar Markovic Signed-off-by: Aleksandar Markovic Signed-off-by: Daniel

Re: [PATCH v4 0/7] target/mips: Misc MIPS fixes and improvements for 5.0

2020-01-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1579883929-1517-1-git-send-email-aleksandar.marko...@rt-rk.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1579883929-1517-1-git-send-email-aleksandar.marko...@rt-rk.com

Re: [PATCH v2 2/8] hxtool: Support SRST/ERST directives

2020-01-24 Thread Alex Bennée
Peter Maydell writes: > We want to add support for including rST document fragments > in our .hx files, in the same way we currently have texinfo > fragments. These will be delimited by SRST and ERST directives, > in the same way the texinfo is delimited by STEXI/ETEXI. > The rST fragments

[PULL v2 5/7] mips/mips_malta: use memdev for RAM

2020-01-24 Thread Aleksandar Markovic
From: Igor Mammedov memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead

[PULL v2 1/7] target/mips: Rectify documentation on deprecating r4k machine

2020-01-24 Thread Aleksandar Markovic
From: Aleksandar Markovic Change the documented (in file qemu-deprecated.texi) release since r4k machine is deprecated from 4.2 to 5.0. Fixes: d32dc61421b Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Aleksandar Markovic Message-Id:

[PULL v2 0/7] MIPS queue for Jan 24th, 2020

2020-01-24 Thread Aleksandar Markovic
From: Aleksandar Markovic The following changes since commit ba2ed84fe6a78f64b2da441750fc6e925d94106a: Merge remote-tracking branch 'remotes/palmer/tags/riscv-for-master-5.0-sf1' into staging (2020-01-24 12:34:04 +) are available in the git repository at:

[PULL v2 4/7] mips/mips_jazz: use memdev for RAM

2020-01-24 Thread Aleksandar Markovic
From: Igor Mammedov memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead

[PULL v2 2/7] disas: Add a field for target-dependant data

2020-01-24 Thread Aleksandar Markovic
From: Aleksandar Markovic This patch adds a field "target_info" to the structure disassemble_info. The purpose of this field is to enable targets to pass to disassembler code any additional data thet deem suitable. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id:

[PULL v2 6/7] mips/mips_mipssim: use memdev for RAM

2020-01-24 Thread Aleksandar Markovic
From: Igor Mammedov memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead

Re: [EXTERNAL] Re: QEMU for aarch64 with plugins seems to fail basic consistency checks

2020-01-24 Thread Robert Henry
I found at least one problem with my plugin. I was assuming that the insn data from struct qemu_plugin_insn *insn = qemu_plugin_tb_get_insn(tb, i); could be passed into qemu_plugin_register_vcpu_insn_exec_cb both as the 1st argument AND as the user data last argument. This assumed that

Re: [EXTERNAL][PULL 0/7] MIPS queue for January 24th, 2020

2020-01-24 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Cc: peter.mayd...@linaro.org; Aleksandar Markovic > Subject: [EXTERNAL][PULL 0/7] MIPS queue for January 24th, 2020 I forgot one "Signed-off-by:". Will send v2 shortly. Thanks, Aleksandar

[PULL 7/7] mips/mips_r4k: use memdev for RAM

2020-01-24 Thread Aleksandar Markovic
From: Igor Mammedov memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead

[PULL 6/7] mips/mips_mipssim: use memdev for RAM

2020-01-24 Thread Aleksandar Markovic
From: Igor Mammedov memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead

[PULL 0/7] MIPS queue for January 24th, 2020

2020-01-24 Thread Aleksandar Markovic
From: Aleksandar Markovic The following changes since commit ba2ed84fe6a78f64b2da441750fc6e925d94106a: Merge remote-tracking branch 'remotes/palmer/tags/riscv-for-master-5.0-sf1' into staging (2020-01-24 12:34:04 +) are available in the git repository at:

[PULL 2/7] disas: Add a field for target-dependant data

2020-01-24 Thread Aleksandar Markovic
From: Aleksandar Markovic This patch adds a field "target_info" to the structure disassemble_info. The purpose of this field is to enable targets to pass to disassembler code any additional data thet deem suitable. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id:

[PULL 5/7] mips/mips_malta: use memdev for RAM

2020-01-24 Thread Aleksandar Markovic
From: Igor Mammedov memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead

[PULL 3/7] mips-semi.c: remove 'uhi_done' label in helper_do_semihosting()

2020-01-24 Thread Aleksandar Markovic
From: Daniel Henrique Barboza The label 'uhi_done' is a simple 'return' call and can be removed for a bit more clarity in the code. CC: Aurelien Jarno CC: Aleksandar Markovic CC: Aleksandar Rikalo Signed-off-by: Daniel Henrique Barboza Reviewed-by: Aleksandar Markovic Message-Id:

[PULL 4/7] mips/mips_jazz: use memdev for RAM

2020-01-24 Thread Aleksandar Markovic
From: Igor Mammedov memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead

[PULL 1/7] target/mips: Rectify documentation on deprecating r4k machine

2020-01-24 Thread Aleksandar Markovic
From: Aleksandar Markovic Change the documented (in file qemu-deprecated.texi) release since r4k machine is deprecated from 4.2 to 5.0. Fixes: d32dc61421b Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Aleksandar Markovic Message-Id:

[PATCH] target/arm/arm-semi: Don't let the guest close stdin/stdout/stderr

2020-01-24 Thread Peter Maydell
The guest can use the semihosting API to open a handle corresponding to QEMU's own stdin, stdout, or stderr. When the guest closes this handle, we should not close the underlying host stdin/stdout/stderr the way we would do if the handle corresponded to a host fd we'd opened on behalf of the guest

Re: [PATCH 1/8] tests/vm: Debug mode shows ssh output.

2020-01-24 Thread Alex Bennée
Robert Foley writes: > Add changes to tests/vm/basevm.py so that during debug > mode we show ssh output. nit: space > > Signed-off-by: Robert Foley > Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée > --- > tests/vm/basevm.py | 7 ++- > 1 file changed, 6 insertions(+), 1

Re: [PATCH v4 5/7] disas: Add a field for target-dependant data

2020-01-24 Thread Aleksandar Rikalo
> From: Aleksandar Markovic > > This patch adds a field "target_info" to the structure > disassemble_info. The purpose of this field is to enable targets > to pass to disassembler code any additional data thet deem suitable. > > Signed-off-by: Aleksandar Markovic > --- > 

  1   2   3   >