>-Original Message-
>From: Viktor Prutyanov [mailto:viktor.prutya...@phystech.edu]
>Sent: Friday, March 6, 2020 7:48 PM
>To: Chenqun (kuhn)
>Cc: qemu-triv...@nongnu.org; pbonz...@redhat.com; qemu-
>de...@nongnu.org; Zhanghailiang
>Subject: Re: [PATCH] contrib/elf2dmp: prevent
Kevin Wolf writes:
> Am 05.03.2020 um 19:25 hat John Snow geschrieben:
[...]
>> So in summary:
>>
>> - Avoid nested hanging indents from format operators
>> - Use a line break before the % format operator.
>> - OPTIONALLY(?), use a hanging indent for the entire format string to
>> reduce
On 2020/2/28 3:17, Richard Henderson wrote:
On 2/25/20 2:35 AM, LIU Zhiwei wrote:
+static bool vext_check_reg(DisasContext *s, uint32_t reg, bool widen)
+{
+int legal = widen ? 2 << s->lmul : 1 << s->lmul;
+
+return !((s->lmul == 0x3 && widen) || (reg % legal));
+}
+
+static bool
On 2020/2/28 3:36, Richard Henderson wrote:
On 2/25/20 2:35 AM, LIU Zhiwei wrote:
+GEN_VEXT_LD_ELEM(vlsb_v_b, int8_t, int8_t, H1, ldsb)
+GEN_VEXT_LD_ELEM(vlsb_v_h, int8_t, int16_t, H2, ldsb)
+GEN_VEXT_LD_ELEM(vlsb_v_w, int8_t, int32_t, H4, ldsb)
+GEN_VEXT_LD_ELEM(vlsb_v_d, int8_t,
Patchew URL:
https://patchew.org/QEMU/20200307030756.5913-1-pannengy...@huawei.com/
Hi,
This series failed the docker-clang@ubuntu build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN
Fix a memory leak in qdev_get_gpio_out_connector().
Reported-by: Euler Robot
Signed-off-by: Pan Nengyuan
---
hw/core/qdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index 3937d1eb1a..85f062def7 100644
--- a/hw/core/qdev.c
+++
On Thu, Mar 5, 2020 at 5:06 PM Stephanos Ioannidis wrote:
>
> > These should at least be numbers (if not macros) instead of binary.
>
> Just wanted to follow the convention that the reference manual uses (it lists
> the field values in binary).
The one I read was both, in this case I think the
On Thu, Mar 5, 2020 at 4:48 PM Stephanos Ioannidis wrote:
>
> > Is it portable, though? I thought C bitfield order and packing was
> > implementation-defined, which would mean that you can't guarantee that this
> > union will give you the required thing in the uint32_t half.
>
> They are indeed
Patchew URL: https://patchew.org/QEMU/20200307010051.97022-1-yua...@google.com/
Hi,
This series failed the docker-clang@ubuntu build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
On Sat, Mar 7, 2020 at 5:44 AM Alistair Francis
wrote:
>
> Split the file into clear machine and SoC sections.
>
> Signed-off-by: Alistair Francis
> ---
> hw/riscv/sifive_u.c | 109 ++--
> 1 file changed, 55 insertions(+), 54 deletions(-)
>
Reviewed-by:
This allows gdb to access the target’s auxiliary vector,
which can be helpful for telling system libraries important details
about the hardware, operating system, and process.
Signed-off-by: Lirong Yuan
---
gdbstub.c | 55 +++
1 file changed,
Hi Folks,
I have been working on an emulation of the dwc-otg USB controller
(host mode only for now), as implemented on the Raspberry Pi 3 and
below, and on numerous other embedded platforms. I have it to a point
where it works pretty well with the dwc2 driver in the mainline Linux
kernel, and
On 3/7/20 1:04 AM, Lirong Yuan wrote:
This allows gdb to access the target’s auxiliary vector,
which can be helpful for telling system libraries important details
about the hardware, operating system, and process.
Signed-off-by: Lirong Yuan
---
gdbstub.c | 50
This allows gdb to access the target’s auxiliary vector,
which can be helpful for telling system libraries important details
about the hardware, operating system, and process.
Signed-off-by: Lirong Yuan
---
gdbstub.c | 50 ++
1 file changed, 50
On Fri, 6 Mar 2020, Mark Cave-Ayland wrote:
On 06/03/2020 19:38, BALATON Zoltan wrote:
On Fri, 6 Mar 2020, Mark Cave-Ayland wrote:
On 06/03/2020 12:06, BALATON Zoltan wrote:
On Fri, 6 Mar 2020, Mark Cave-Ayland wrote:
On 05/03/2020 23:35, BALATON Zoltan wrote:
On real hardware this may be
For qcow2 and qed, we want to encourage the use of -F always, as these
formats can suffer from data corruption or security holes if backing
format is probed. But for other formats, the backing format cannot be
recorded. Making the user decide on a per-format basis whether to
supply a backing
Creating an image that requires format probing of the backing image is
inherently unsafe (we've had several CVEs over the years based on
probes leaking information to the guest on a subsequent boot, although
these days tools like libvirt are aware of the issue enough to prevent
the worst effects).
For now, this is a mechanical addition; all callers pass false. But
the next patch will use it to improve 'qemu-img rebase -u' when
selecting a backing file with no format.
Signed-off-by: Eric Blake
Reviewed-by: Peter Krempa
Reviewed-by: Ján Tomko
---
include/block/block.h | 4 ++--
block.c
In v3:
- patch 1 is new [Jan]
- patch 2:
- add test 225 for vmdk [Jan]
- add a few more tests where raw backing files are used [Peter]
- patch 3 add R-b
- patch 4:
- more tweaks on which messages are emitted [Peter]
- more test coverage in 114 of new messages
- rebase to .rst conversion
This patch introduces support for PMR that has been defined as part of NVMe 1.4
spec. User can now specify a pmr_file which will be mmap'ed into qemu address
space and subsequently in PCI BAR 2. Guest OS can perform mmio read and writes
to the PMR region that will stay persistent accross system
On Fri, Mar 6, 2020 at 6:05 PM Philippe Mathieu-Daudé wrote:
>
> Currently the print-variable rule can only be used in the
> root directory:
>
> $ make print-vhost-user-json-y
> vhost-user-json-y= contrib/vhost-user-gpu/50-qemu-gpu.json
> tools/virtiofsd/50-qemu-virtiofsd.json
>
> $ make
At present the board serial number is hard-coded to 1, and passed
to OTP model during initialization. Firmware (FSBL, U-Boot) uses
the serial number to generate a unique MAC address for the on-chip
ethernet controller. When multiple QEMU 'sifive_u' instances are
created and connected to the same
From: Bin Meng
At present the board serial number is hard-coded to 1, and passed
to OTP model during initialization. Firmware (FSBL, U-Boot) uses
the serial number to generate a unique MAC address for the on-chip
ethernet controller. When multiple QEMU 'sifive_u' instances are
created and
At present the board serial number is hard-coded to 1, and passed
to OTP model during initialization. Firmware (FSBL, U-Boot) uses
the serial number to generate a unique MAC address for the on-chip
ethernet controller. When multiple QEMU 'sifive_u' instances are
created and connected to the same
Split the file into clear machine and SoC sections.
Signed-off-by: Alistair Francis
---
hw/riscv/sifive_u.c | 109 ++--
1 file changed, 55 insertions(+), 54 deletions(-)
diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c
index 156a003642..4688837216
Patchew URL:
https://patchew.org/QEMU/cover.1583518447.git.alistair.fran...@wdc.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v6 0/4] linux-user: generate syscall_nr.sh for RISC-V
Message-id:
Le 06/03/2020 à 19:24, Alistair Francis a écrit :
> New y2038 safe 32-bit architectures (like RISC-V) don't support old
> syscalls with a 32-bit time_t. The kernel defines new *_time64 versions
> of these syscalls. Add some more #ifdefs to syscall.c in linux-user to
> allow us to compile without
On 06/03/2020 19:38, BALATON Zoltan wrote:
> On Fri, 6 Mar 2020, Mark Cave-Ayland wrote:
>> On 06/03/2020 12:06, BALATON Zoltan wrote:
>>> On Fri, 6 Mar 2020, Mark Cave-Ayland wrote:
On 05/03/2020 23:35, BALATON Zoltan wrote:
> On real hardware this may be true but in QEMU how would it
On Thu, Mar 5, 2020 at 4:09 PM Bin Meng wrote:
>
> Hi Alistair,
>
> On Fri, Mar 6, 2020 at 12:53 AM Alistair Francis wrote:
> >
> > On Thu, Mar 5, 2020 at 1:31 AM Bin Meng wrote:
> > >
> > > Hi Alistair,
> > >
> > > On Thu, Mar 5, 2020 at 7:13 AM Alistair Francis
> > > wrote:
> > > >
> > > >
Patchew URL:
https://patchew.org/QEMU/20200306171749.10756-1-peter.mayd...@linaro.org/
Hi,
This series failed the docker-clang@ubuntu build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT
On Fri, 6 Mar 2020, Mark Cave-Ayland wrote:
On 06/03/2020 12:06, BALATON Zoltan wrote:
On Fri, 6 Mar 2020, Mark Cave-Ayland wrote:
On 05/03/2020 23:35, BALATON Zoltan wrote:
On real hardware this may be true but in QEMU how would it otherwise raise the
correct interrupt line the guest
On Fri, 6 Mar 2020 at 17:15, Kevin Wolf wrote:
>
> The following changes since commit f4c4357fbfca0fb14e477bf661ae7384b4b9b283:
>
> Merge remote-tracking branch 'remotes/pmaydell/tags/pull-docs-20200306'
> into staging (2020-03-06 11:11:54 +)
>
> are available
Patchew URL: https://patchew.org/QEMU/20200306171458.1848-1-kw...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PULL 00/29] Block layer patches
Message-id: 20200306171458.1848-1-kw...@redhat.com
Type: series
=== TEST
* David Hildenbrand (da...@redhat.com) wrote:
> On 06.03.20 17:30, Dr. David Alan Gilbert wrote:
> > * David Hildenbrand (da...@redhat.com) wrote:
> >> Let's consolidate resetting the variables.
> >>
> >> Cc: "Dr. David Alan Gilbert"
> >> Cc: Juan Quintela
> >> Cc: Peter Xu
> >> Signed-off-by:
On 06.03.20 17:30, Dr. David Alan Gilbert wrote:
> * David Hildenbrand (da...@redhat.com) wrote:
>> Let's consolidate resetting the variables.
>>
>> Cc: "Dr. David Alan Gilbert"
>> Cc: Juan Quintela
>> Cc: Peter Xu
>> Signed-off-by: David Hildenbrand
>
> Thanks, I think that's actually fixing
* David Hildenbrand (da...@redhat.com) wrote:
> On 06.03.20 17:56, Dr. David Alan Gilbert wrote:
> > * David Hildenbrand (da...@redhat.com) wrote:
> >> Resizing while migrating is dangerous and does not work as expected.
> >> The whole migration code works on the usable_length of ram blocks and
* David Hildenbrand (da...@redhat.com) wrote:
> On 06.03.20 17:20, David Hildenbrand wrote:
> > On 06.03.20 17:05, Dr. David Alan Gilbert wrote:
> >> * David Hildenbrand (da...@redhat.com) wrote:
> >>> Add two new helper functions. This will in come handy once we want to
> >>> handle ram block
On 06.03.20 17:20, David Hildenbrand wrote:
> On 06.03.20 17:05, Dr. David Alan Gilbert wrote:
>> * David Hildenbrand (da...@redhat.com) wrote:
>>> Add two new helper functions. This will in come handy once we want to
>>> handle ram block resizes while postcopy is active.
>>>
>>> Cc: "Dr. David
On 06.03.20 17:56, Dr. David Alan Gilbert wrote:
> * David Hildenbrand (da...@redhat.com) wrote:
>> Resizing while migrating is dangerous and does not work as expected.
>> The whole migration code works on the usable_length of ram blocks and does
>> not expect this to change at random points in
On 06/03/2020 12:40, BALATON Zoltan wrote:
> On Fri, 6 Mar 2020, Mark Cave-Ayland wrote:
>> On 06/03/2020 00:21, BALATON Zoltan wrote:
>>> On Fri, 6 Mar 2020, BALATON Zoltan wrote:
On Thu, 5 Mar 2020, Mark Cave-Ayland wrote:
> On 04/03/2020 22:33, BALATON Zoltan wrote:
> another
Patchew URL: https://patchew.org/QEMU/20200306170456.21977-1-phi...@redhat.com/
Hi,
This series failed the docker-clang@ubuntu build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
On 06/03/2020 12:06, BALATON Zoltan wrote:
> On Fri, 6 Mar 2020, Mark Cave-Ayland wrote:
>> On 05/03/2020 23:35, BALATON Zoltan wrote:
>>> On real hardware this may be true but in QEMU how would it otherwise raise
>>> the
>>> correct interrupt line the guest expects? This probably does not
Signed-off-by: Alistair Francis
Reviewed-by: Laurent Vivier
---
linux-user/riscv/syscall32_nr.h | 295 +++
linux-user/riscv/syscall64_nr.h | 301
linux-user/riscv/syscall_nr.h | 294 +--
3 files changed,
On 3/6/20 5:14 AM, Kevin Wolf wrote:
> Am 05.03.2020 um 19:25 hat John Snow geschrieben:
>> On 3/5/20 6:55 AM, Kevin Wolf wrote:
>>> Am 05.03.2020 um 00:14 hat John Snow geschrieben:
On 3/4/20 4:58 PM, Philippe Mathieu-Daudé wrote:
>>>
>>> Adding back the context:
>>>
-
Add support for host and target futex_time64. If futex_time64 exists on
the host we try that first before falling back to the standard futux
syscall.
Signed-off-by: Alistair Francis
---
linux-user/syscall.c | 98
1 file changed, 80 insertions(+), 18
New y2038 safe 32-bit architectures (like RISC-V) don't support old
syscalls with a 32-bit time_t. The kernel defines new *_time64 versions
of these syscalls. Add some more #ifdefs to syscall.c in linux-user to
allow us to compile without these old syscalls.
Signed-off-by: Alistair Francis
---
Add support for the clock_gettime64/clock_settime64 syscalls.
If your host is 64-bit or is 32-bit with the *_time64 syscall then the
timespec will correctly be a 64-bit time_t. Otherwise the host will
return a 32-bit time_t which will be rounded to 64-bits. This will be
incorrect after y2038.
This series updates the RISC-V syscall_nr.sh based on the 5.5 kernel.
There are two parts to this. One is just adding the new syscalls, the
other part is updating the RV32 syscalls to match the fact that RV32 is
a 64-bit time_t architectures (y2038) safe.
We need to make some changes to
On Wed, 26 Feb 2020 09:55:34 PST (-0800), alistai...@gmail.com wrote:
On Wed, Feb 26, 2020 at 12:54 AM Rajnesh Kanwal
wrote:
Here is the link to the patch
https://lists.nongnu.org/archive/html/qemu-riscv/2020-01/msg00191.html
Ah, it doesn't look like it made it to the QEMU-devel list. Can
Add the Python source files of our Sphinx extensions to the
dependencies of the Sphinx manuals, so that if we edit the
extension source code the manuals get rebuilt.
Adding this dependency unconditionally means that we'll rebuild
a manual even if it happens to not use the extension whose
source
On Tue, 25 Feb 2020 at 14:04, Peter Maydell wrote:
>
> This series switches all our QAPI doc comments over from
> texinfo format to rST.
> Git branch of this series also available at
> https://git.linaro.org/people/peter.maydell/qemu-arm.git sphinx-conversions
I've just updated this git branch
Now that qemu-doc.html is no longer present, the ordering of manuals
within the top-level index page looks a bit odd. Reshuffle so that
the manuals the user is most likely to be interested in are at the
top of the list, and the reference material is at the bottom.
Similarly, we reorder the
Now that none of our input .hx files have STEXI/ETEXI blocks,
we can remove the code in the Sphinx hxtool extension that
supported parsing them.
Signed-off-by: Peter Maydell
---
docs/sphinx/hxtool.py | 28
1 file changed, 4 insertions(+), 24 deletions(-)
diff --git
The Texinfo version of the tracing options documentation has now
been deleted, so we can remove the now-redundant comment at the top
of the rST version that was reminding us that the two should be
kept in sync.
Signed-off-by: Peter Maydell
---
docs/qemu-option-trace.rst.inc | 4
1 file
This series has some small cleanups now that the conversion
of qemu-doc to rST has gone into master:
* reorder the index.html.in/index.rst as it looks a bit odd
now that qemu-doc.html has gone from the top of the list
* remove various bits of redundant code, makefile runes, etc
* update some
Update the header comments in .hx files that mention STEXI/ETEXI
markup; this is now SRST/ERST as all these files have been
converted to rST.
Signed-off-by: Peter Maydell
---
hmp-commands-info.hx | 8
hmp-commands.hx | 8
qemu-options.hx | 8
3 files
On Fri, Mar 6, 2020 at 11:13 AM wrote:
>
> Patchew URL:
> https://patchew.org/QEMU/20200306140917.26726-1-jandr...@gmail.com/
>
>
>
> Hi,
>
> This series failed the docker-clang@ubuntu build test. Please find the
> testing commands and
> their output below. If you have Docker installed, you can
All the STEXI/ETEXI blocks and the Makfile rules that use them have now
been removed from the codebase. We can remove the code from the hxtool
script which handles the STEXI/ETEXI directives and the '-t' option.
Signed-off-by: Peter Maydell
---
scripts/hxtool | 78
These commands make only sense for system emulators and their
implementations call functions that don't exist in tools (e.g. to
resolve qdev IDs). Move them out so that blockdev.c can be linked to
qemu-storage-daemon.
Signed-off-by: Kevin Wolf
Message-Id:
Patchew URL: https://patchew.org/QEMU/20200306165751.18986-1-phi...@redhat.com/
Hi,
This series failed the docker-clang@ubuntu build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
QMP commands that are related to the system emulator and don't make
sense in the context of tools such as qemu-storage-daemon should live in
qapi/block.json rather than qapi/block-core.json. Move them there.
The associated data types are actually also used in code shared with the
tools, so they
This adds and parses the --monitor option, so that a QMP monitor can be
used in the storage daemon. The monitor offers commands defined in the
QAPI schema at storage-daemon/qapi/qapi-schema.json.
The --monitor options currently allows to create multiple monitors with
the same ID. This part of the
Trying to attach a HMP monitor to a chardev that is already in use
results in a crash because monitor_init_hmp() passes _abort to
qemu_chr_fe_init():
$ ./x86_64-softmmu/qemu-system-x86_64 --chardev stdio,id=foo --mon foo --mon foo
QEMU 4.2.50 monitor - type 'help' for more information
(qemu)
This adds a new QAPI-based monitor_init() function. The existing
monitor_init_opts() is rewritten to simply put its QemuOpts parameter
into a visitor and pass the resulting QAPI object to monitor_init().
This will cause some change in those error messages for the monitor
options in the system
From: Florian Florensa
Starting from ceph Nautilus, RBD has support for namespaces, allowing
for finer grain ACLs on images inside a pool, and tenant isolation.
In the rbd cli tool documentation, the new image-spec and snap-spec are :
- [pool-name/[namespace-name/]]image-name
-
Add a new parameter allow_hmp to monitor_init() so that the storage
daemon can disable HMP.
Signed-off-by: Kevin Wolf
Message-Id: <20200224143008.13362-20-kw...@redhat.com>
Acked-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
qapi/control.json | 3 ++-
include/monitor/monitor.h |
The recent conversion of qemu-doc.texi to rST forgot a few stray bits
of makefile code that are now redundant. Remove them.
Signed-off-by: Peter Maydell
---
Makefile | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/Makefile b/Makefile
index
Trying to attach a QMP monitor to a chardev that is already in use
results in a crash because monitor_init_qmp() passes _abort to
qemu_chr_fe_init():
$ ./x86_64-softmmu/qemu-system-x86_64 --chardev stdio,id=foo --mon
foo,mode=control --mon foo,mode=control
Unexpected error in qemu_chr_fe_init()
This patch allows bdrv_reopen() (and therefore the x-blockdev-reopen QMP
command) to attach a node as the new backing file even if the node is in
a different AioContext than the parent if one of both nodes can be moved
to the AioContext of the other node.
Signed-off-by: Kevin Wolf
Tested-by:
Before we can add the monitor to qemu-storage-daemon, we need to add a
stubs for monitor_fdsets_cleanup().
We also need to make sure that stubs that are actually implemented in
the monitor core aren't linked to qemu-storage-daemon so that we don't
get linker errors because of duplicate symbols.
Instead of exiting after processing all command line options, start a
main loop and keep processing events until exit is requested with a
signal (e.g. SIGINT).
Now qemu-storage-daemon can be used as an alternative for qemu-nbd that
provides a few features that were previously only available from
This adds a --chardev option to the storage daemon that works the same
as the -chardev option of the system emulator.
The syntax of the --chardev option is still considered unstable. We want
to QAPIfy it and will potentially make changes to its syntax while
converting it. However, we haven't
This adds a --blockdev option to the storage daemon that works the same
as the -blockdev option of the system emulator.
In order to be able to link with blockdev.o, we also need to change
stream.o from common-obj to block-obj, which is where all other block
jobs already are.
In contrast to the
We'll want to test more than one successful case in the future, so
prepare the test for that by a refactoring that runs each scenario in a
separate VM.
test_iothreads_switch_{backing,overlay} currently produce errors, but
these are cases that should actually work, by switching either the
backing
From: Peter Krempa
The bitmap code requires writing the 'file' child when the qcow2 driver
is reopened in read-write mode.
If the 'file' child is being reopened due to a permissions change, the
modification is commited yet when qcow2_reopen_commit is called. This
means that any attempt to write
Mapping object-add to the command line as is doesn't result in nice
syntax because of the nesting introduced with 'props'. This becomes
nicer and more consistent with device_add and netdev_add when we accept
properties for the object on the top level instead.
'props' is still accepted after this
We want to share the whitelists between the system emulator schema and
the storage daemon schema, so move all the pragmas from the main schema
file into a separate file that can be included from both.
Signed-off-by: Kevin Wolf
Message-Id: <20200224143008.13362-16-kw...@redhat.com>
Acked-by:
block-core is for everything that isn't related to the system emulator.
Internal snapshots, the NBD server and quorum events make sense in the
tools, too, so move them to block-core.
Signed-off-by: Kevin Wolf
Message-Id: <20200224143008.13362-5-kw...@redhat.com>
Acked-by: Stefan Hajnoczi
Add a --nbd-server option to qemu-storage-daemon to start the built-in
NBD server right away. It maps the arguments for nbd-server-start to the
command line, with the exception that it uses SocketAddress instead of
SocketAddressLegacy: New interfaces shouldn't use legacy types, and the
additional
Add a command line option to create user-creatable QOM objects.
Signed-off-by: Kevin Wolf
Message-Id: <20200224143008.13362-9-kw...@redhat.com>
Acked-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
qemu-storage-daemon.c | 47 +++
Makefile.objs
Add a --export option to qemu-storage-daemon to export a block node. For
now, only NBD exports are implemented. Apart from the 'type' option
(which is the implied key), it maps the arguments for nbd-server-add to
the command line. Example:
--export nbd,device=disk,name=test-export,writable=on
Move the arguments of nbd-server-add to a new struct BlockExportNbd and
convert the command to 'boxed': true. This makes it easier to share code
with the storage daemon.
Signed-off-by: Kevin Wolf
Message-Id: <20200224143008.13362-11-kw...@redhat.com>
Acked-by: Stefan Hajnoczi
Signed-off-by:
From: Max Reitz
Test what happens when writing data to an external data file, where the
write requires an L2 entry to be allocated, but the data write fails.
Signed-off-by: Max Reitz
Message-Id: <20200225143130.111267-4-mre...@redhat.com>
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/026
From: Max Reitz
@options is leaked by the first two return statements in this function.
Note that blk_new_open() takes the reference to @options even on
failure, so all we need to do to fix the leak is to move the QDict
allocation down to where we actually need it.
Reported-by: Coverity (CID
blockdev.c uses the arch_type constant, so before we can use the file in
tools (i.e. outside of the system emulator), we need to add a stub for
it. A new QEMU_ARCH_NONE is introduced for this case.
Signed-off-by: Kevin Wolf
Message-Id: <20200224143008.13362-3-kw...@redhat.com>
Acked-by: Stefan
This adds a new binary qemu-storage-daemon that doesn't yet do more than
some typical initialisation for tools and parsing the basic command
options --version, --help and --trace.
Even though this doesn't add any options yet that create things (like
--object or --blockdev), already document that
From: Max Reitz
handle_alloc() reuses preallocated zero clusters. If anything goes
wrong during the data write, we do not change their L2 entry, so we
must not let qcow2_alloc_cluster_abort() free them.
Fixes: 8b24cd141549b5b264baeddd4e72902cfb5de23b
Cc: qemu-sta...@nongnu.org
Signed-off-by:
The following changes since commit f4c4357fbfca0fb14e477bf661ae7384b4b9b283:
Merge remote-tracking branch 'remotes/pmaydell/tags/pull-docs-20200306' into
staging (2020-03-06 11:11:54 +)
are available in the Git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you
From: Peter Krempa
Add another step in the reopen process where driver can execute code
after permission changes are comitted.
Signed-off-by: Peter Krempa
Message-Id:
Signed-off-by: Kevin Wolf
---
include/block/block_int.h | 1 +
block.c | 9 +
2 files changed, 10
From: Max Reitz
Test what happens when writing data to a preallocated zero cluster, but
the data write fails.
Signed-off-by: Max Reitz
Message-Id: <20200225143130.111267-3-mre...@redhat.com>
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/026 | 21 +
Currently the print-variable rule can only be used in the
root directory:
$ make print-vhost-user-json-y
vhost-user-json-y= contrib/vhost-user-gpu/50-qemu-gpu.json
tools/virtiofsd/50-qemu-virtiofsd.json
$ make -C i386-softmmu print-obj-y
make: Entering directory 'build/i386-softmmu'
On Fri, 6 Mar 2020 at 14:23, Stefan Hajnoczi wrote:
>
> The following changes since commit ef9f8fcbec6276414921dcd042575129a6331a2d:
>
> Merge remote-tracking branch
> 'remotes/stefanberger/tags/pull-tpm-2020-03-04-2' into staging (2020-03-05
> 19:39:47 +)
>
> are available in the Git
* David Hildenbrand (da...@redhat.com) wrote:
> We never read or write beyond the used_length of memory blocks when
> migrating. Make this clearer by using offset_in_ramblock() consistently.
>
> Cc: "Dr. David Alan Gilbert"
> Cc: Juan Quintela
> Cc: Peter Xu
> Signed-off-by: David Hildenbrand
The socket_scm_helper path got corrupted during the mechanical
refactor moving the qtests files into their own sub-directory.
Fixes: 1e8a1fae7 ("test: Move qtests to a separate directory")
Signed-off-by: Philippe Mathieu-Daudé
---
tests/Makefile.include | 1 +
tests/qtest/Makefile.include
* David Hildenbrand (da...@redhat.com) wrote:
> We actually want to print the used_length, against which we check.
>
> Cc: "Dr. David Alan Gilbert"
> Cc: Juan Quintela
> Cc: Peter Xu
> Signed-off-by: David Hildenbrand
Reviewed-by: Dr. David Alan Gilbert
> ---
> migration/multifd.c | 2 +-
* David Hildenbrand (da...@redhat.com) wrote:
> Resizing while migrating is dangerous and does not work as expected.
> The whole migration code works on the usable_length of ram blocks and does
> not expect this to change at random points in time.
>
> In the case of postcopy, relying on
This went unanswered in the last revision:
On Thu, Nov 21, 2019 at 12:31:42PM +, Stefan Hajnoczi wrote:
> On Wed, Nov 13, 2019 at 11:14:50AM -0500, Jag Raman wrote:
> > On 11/11/2019 11:21 AM, Stefan Hajnoczi wrote:
> > > On Thu, Oct 24, 2019 at 05:09:13AM -0400, Jagannathan Raman wrote:
> >
Nested Configuration check
tstrike39@islandhealthcenter-media:~$ sudo cat
/sys/module/kvm_intel/parameters/nested
[sudo] password for tstrike39:
Y
Not UEFI enabled
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
On Fri, Feb 28, 2020 at 10:43:44AM -0800, Elena Ufimtseva wrote:
> On Thu, Feb 27, 2020 at 04:58:04PM +, Stefan Hajnoczi wrote:
> > On Mon, Feb 24, 2020 at 03:55:41PM -0500, Jagannathan Raman wrote:
> > > +* The devices to be emulated in the separate process are defined as
> > > + before with
* David Hildenbrand (da...@redhat.com) wrote:
> Let's consolidate resetting the variables.
>
> Cc: "Dr. David Alan Gilbert"
> Cc: Juan Quintela
> Cc: Peter Xu
> Signed-off-by: David Hildenbrand
Thanks, I think that's actually fixing a case where huge zero pages
weren't placed as zero pages?
1 - 100 of 287 matches
Mail list logo
