Re: [PATCH v2] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write()

2020-03-09 Thread Peter Maydell
On Thu, 5 Mar 2020 at 10:53, Chen Qun wrote: > > The current code causes clang static code analyzer generate warning: > hw/net/imx_fec.c:858:9: warning: Value stored to 'value' is never read > value = value & 0x000f; > ^ ~~ > hw/net/imx_fec.c:864:9:

[Bug 1813165] Re: KVM internal error. Suberror: 1 emulation failure

2020-03-09 Thread Vitaly Kuznetsov
'nested' parameter for kvm_intel module controls whether you're able to run nested configurations and it is enabled by default, it doesn't say anything about whether your configuration is nested or not. Could you please describe your environment? In case it is nested, it will look like: L0(host)

Re: [kvm-unit-tests PATCH v4 07/13] arm/arm64: ITS: its_enable_defaults

2020-03-09 Thread Andrew Jones
On Mon, Mar 09, 2020 at 11:24:14AM +0100, Eric Auger wrote: > its_enable_defaults() enable LPIs at distributor level > and ITS level. > > gicv3_enable_defaults must be called before. > > Signed-off-by: Eric Auger > > --- > v3 -> v4: > - use GITS_BASER_INDIRECT & GITS_BASER_VALID in

[PATCH v7 13/15] s390x: protvirt: Handle SIGP store status correctly

2020-03-09 Thread Janosch Frank
For protected VMs status storing is not done by QEMU anymore. Signed-off-by: Janosch Frank Reviewed-by: Thomas Huth Reviewed-by: David Hildenbrand --- target/s390x/helper.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/s390x/helper.c b/target/s390x/helper.c index

Re: [PATCH] build-sys: Move the print-variable rule to rules.mak

2020-03-09 Thread Laurent Vivier
Le 06/03/2020 à 18:04, Philippe Mathieu-Daudé a écrit : > Currently the print-variable rule can only be used in the > root directory: > > $ make print-vhost-user-json-y > vhost-user-json-y= contrib/vhost-user-gpu/50-qemu-gpu.json > tools/virtiofsd/50-qemu-virtiofsd.json > > $ make -C

Re: [PATCH] tests/qemu-iotests: Fix socket_scm_helper build path

2020-03-09 Thread Laurent Vivier
Le 06/03/2020 à 17:57, Philippe Mathieu-Daudé a écrit : > The socket_scm_helper path got corrupted during the mechanical > refactor moving the qtests files into their own sub-directory. > > Fixes: 1e8a1fae7 ("test: Move qtests to a separate directory") > Signed-off-by: Philippe Mathieu-Daudé >

[PATCH v7 15/15] s390x: Add unpack facility feature to GA1

2020-03-09 Thread Janosch Frank
From: Christian Borntraeger The unpack facility is an indication that diagnose 308 subcodes 8-10 are available to the guest. That means, that the guest can put itself into protected mode. Once it is in protected mode, the hardware stops any attempt of VM introspection by the hypervisor. Some

[PATCH v7 12/15] s390x: protvirt: Move IO control structures over SIDA

2020-03-09 Thread Janosch Frank
For protected guests, we need to put the IO emulation results into the SIDA, so SIE will write them into the guest at the next entry. Signed-off-by: Janosch Frank --- target/s390x/ioinst.c | 87 ++- 1 file changed, 61 insertions(+), 26 deletions(-) diff

[PATCH v7 14/15] docs: Add protvirt docs

2020-03-09 Thread Janosch Frank
Lets add some documentation for the Protected VM functionality. Signed-off-by: Janosch Frank --- docs/system/index.rst| 1 + docs/system/protvirt.rst | 56 2 files changed, 57 insertions(+) create mode 100644 docs/system/protvirt.rst diff --git

[PATCH v7 05/15] s390x: protvirt: KVM intercept changes

2020-03-09 Thread Janosch Frank
Secure guests no longer intercept with code 4 for an instruction interception. Instead they have codes 104 and 108 for secure instruction interception and secure instruction notification respectively. The 104 mirrors the 4 interception. The 108 is a notification interception to let KVM and QEMU

[PATCH v7 09/15] s390x: protvirt: Set guest IPL PSW

2020-03-09 Thread Janosch Frank
Handling of CPU reset and setting of the IPL psw from guest storage at offset 0 is done by a Ultravisor call. Let's only fetch it if necessary. Signed-off-by: Janosch Frank Reviewed-by: Thomas Huth Reviewed-by: David Hildenbrand --- target/s390x/cpu.c | 23 ++- 1 file

[PATCH v7 07/15] s390x: protvirt: Move STSI data over SIDAD

2020-03-09 Thread Janosch Frank
For protected guests, we need to put the STSI emulation results into the SIDA, so SIE will write them into the guest at the next entry. Signed-off-by: Janosch Frank Reviewed-by: David Hildenbrand --- target/s390x/kvm.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff

[PATCH v7 02/15] s390x: protvirt: Support unpack facility

2020-03-09 Thread Janosch Frank
The unpack facility provides the means to setup a protected guest. A protected guest can not be introspected by the hypervisor or any user/administrator of the machine it is running on. Protected guests are encrypted at rest and need a special boot mechanism via diag308 subcode 8 and 10. Code 8

[PATCH v7 11/15] s390x: protvirt: Disable address checks for PV guest IO emulation

2020-03-09 Thread Janosch Frank
IO instruction data is routed through SIDAD for protected guests, so adresses do not need to be checked, as this is kernel memory. Signed-off-by: Janosch Frank Reviewed-by: Thomas Huth Reviewed-by: David Hildenbrand --- target/s390x/ioinst.c | 32 +--- 1 file

[PATCH v7 10/15] s390x: protvirt: Move diag 308 data over SIDA

2020-03-09 Thread Janosch Frank
For protected guests the IPIB is written/read to/from the SIDA, so we need those accesses to go through s390_cpu_pv_mem_read/write(). Signed-off-by: Janosch Frank --- target/s390x/diag.c | 30 +++--- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git

[PATCH v7 03/15] s390x: protvirt: Add migration blocker

2020-03-09 Thread Janosch Frank
Migration is not yet supported. Signed-off-by: Janosch Frank --- hw/s390x/s390-virtio-ccw.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index f718cfc591..4bb38704ff 100644 ---

[PATCH v7 08/15] s390x: protvirt: SCLP interpretation

2020-03-09 Thread Janosch Frank
SCLP for a protected guest is done over the SIDAD, so we need to use the s390_cpu_pv_mem_* functions to access the SIDAD instead of guest memory when reading/writing SCBs. To not confuse the sclp emulation, we set 0x4000 as the SCCB address, since the function that injects the sclp external

[PATCH v7 01/15] Sync pv

2020-03-09 Thread Janosch Frank
Signed-off-by: Janosch Frank --- linux-headers/linux/kvm.h | 45 +-- 1 file changed, 43 insertions(+), 2 deletions(-) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index 265099100e..c30344ab00 100644 --- a/linux-headers/linux/kvm.h +++

Re: [PATCH v6 18/18] docs: add Orange Pi PC document

2020-03-09 Thread Peter Maydell
On Wed, 4 Mar 2020 at 20:55, Niek Linnenbank wrote: > > Hello Alex, > > On Wed, Mar 4, 2020 at 11:35 AM Alex Bennée wrote: >> >> >> Niek Linnenbank writes: >> > --- >> > docs/orangepi.rst | 226 >> > ++ >> >> I suspect there is a better place to put

[PATCH v7 06/15] s390x: Add SIDA memory ops

2020-03-09 Thread Janosch Frank
Protected guests save the instruction control blocks in the SIDA instead of QEMU/KVM directly accessing the guest's memory. Let's introduce new functions to access the SIDA. Also the new memops are available with KVM_CAP_S390_PROTECTED, so let's check for that. Signed-off-by: Janosch Frank

[PATCH v7 04/15] s390x: protvirt: Inhibit balloon when switching to protected mode

2020-03-09 Thread Janosch Frank
Ballooning in protected VMs can only be done when the guest shares the pages it gives to the host. If pages are not shared, the integrity checks will fail once those pages have been altered and are given back to the guest. Hence, until we have a solution for this in the guest kernel, we inhibit

[PATCH v7 00/15] s390x: Protected Virtualization support

2020-03-09 Thread Janosch Frank
Most of the QEMU changes for PV are related to the new IPL type with subcodes 8 - 10 and the execution of the necessary Ultravisor calls to IPL secure guests. Note that we can only boot into secure mode from normal mode, i.e. stfle 161 is not active in secure mode. The other changes related to

Re: [kvm-unit-tests PATCH v4 06/13] arm/arm64: ITS: Introspection tests

2020-03-09 Thread Andrew Jones
On Mon, Mar 09, 2020 at 11:24:13AM +0100, Eric Auger wrote: > Detect the presence of an ITS as part of the GICv3 init > routine, initialize its base address and read few registers > the IIDR, the TYPER to store its dimensioning parameters. > Parse the BASER registers. As part of the init sequence

Re: [PATCH v6 06/18] hw/arm/allwinner: add CPU Configuration module

2020-03-09 Thread Peter Maydell
On Tue, 3 Mar 2020 at 20:15, Niek Linnenbank wrote: > On Tue, Mar 3, 2020 at 1:09 PM Alex Bennée wrote: >> Niek Linnenbank writes: >> > +static void allwinner_cpucfg_cpu_reset(AwCpuCfgState *s, uint8_t cpu_id) >> > +{ >> > +int ret; >> > + >> > +trace_allwinner_cpucfg_cpu_reset(cpu_id,

Re: Re: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail)

2020-03-09 Thread 陈蒙蒙
Thanks,  in fact,do_touch_pages is called just when vm starts up, but using init flag and Gonce maybe more elegant ! if needed,I can submit a new patch ! thanks very much! bauerchen   From: Christian Borntraeger Date: 2020-03-09 19:01 To: Paolo Bonzini; Igor Mammedov CC: qemu-devel; qemu-s390x;

Re: [PATCH] cpu: Use DeviceClass reset instead of a special CPUClass reset

2020-03-09 Thread Christian Borntraeger
On 03.03.20 11:05, Peter Maydell wrote: > The CPUClass has a 'reset' method. This is a legacy from when > TYPE_CPU used not to inherit from TYPE_DEVICE. We don't need it any > more, as we can simply use the TYPE_DEVICE reset. The 'cpu_reset()' > function is kept as the API which most places

Re: [PATCH] mem-prealloc: initialize cond and mutex

2020-03-09 Thread Christian Borntraeger
On 09.03.20 11:05, Paolo Bonzini wrote: > On 09/03/20 11:03, Igor Mammedov wrote: >>> +qemu_cond_init(_cond); >>> +qemu_mutex_init(_mutex); >> Is it possible for touch_all_pages to be called several times? >> If it's then it probably needs a guard against that to make >> sure it won't

Re: [PATCH 2/2] hw/arm/armv7m: Downgrade CPU reset handler priority

2020-03-09 Thread Philippe Mathieu-Daudé
Hi Peter, On 2/27/20 2:35 PM, Philippe Mathieu-Daudé wrote: On 2/27/20 1:13 PM, Peter Maydell wrote: On Thu, 27 Feb 2020 at 11:27, Stephanos Ioannidis wrote: The ARMv7-M CPU reset handler, which loads the initial SP and PC register values from the vector table, is currently executed before

Re: [kvm-unit-tests PATCH v4 03/13] arm/arm64: gic: Introduce setup_irq() helper

2020-03-09 Thread Andrew Jones
On Mon, Mar 09, 2020 at 11:24:10AM +0100, Eric Auger wrote: > ipi_enable() code would be reusable for other interrupts > than IPI. Let's rename it setup_irq() and pass an interrupt > handler pointer. > > Signed-off-by: Eric Auger > > --- > > v2 -> v3: > - do not export setup_irq anymore > ---

Re: [PATCH v32 21/22] BootLinuxConsoleTest: Test the RX-Virt machine

2020-03-09 Thread Philippe Mathieu-Daudé
On 3/9/20 7:30 AM, Yoshinori Sato wrote: On Mon, 09 Mar 2020 01:20:05 +0900, Philippe Mathieu-Daudé wrote: On 2/24/20 3:19 PM, Yoshinori Sato wrote: From: Philippe Mathieu-Daudé Add two tests for the rx-virt machine, based on the recommended test setup from Yoshinori Sato:

Re: [PATCH] core/qdev: fix memleak in qdev_get_gpio_out_connector()

2020-03-09 Thread Laurent Vivier
Le 09/03/2020 à 11:41, Pan Nengyuan a écrit : > > > On 3/9/2020 5:16 PM, Laurent Vivier wrote: >> Le 07/03/2020 à 11:39, Marc-André Lureau a écrit : >>> Hi >>> >>> On Sat, Mar 7, 2020 at 3:53 AM Pan Nengyuan wrote: Fix a memory leak in qdev_get_gpio_out_connector().

Re: [PATCH] core/qdev: fix memleak in qdev_get_gpio_out_connector()

2020-03-09 Thread Daniel P . Berrangé
On Mon, Mar 09, 2020 at 10:16:28AM +0100, Laurent Vivier wrote: > Le 07/03/2020 à 11:39, Marc-André Lureau a écrit : > > Hi > > > > On Sat, Mar 7, 2020 at 3:53 AM Pan Nengyuan wrote: > >> > >> Fix a memory leak in qdev_get_gpio_out_connector(). > >> > >> Reported-by: Euler Robot > >>

Re: [PATCH v5 0/5] vhost-user block device backend implementation

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309100342.14921-1-coiby...@gmail.com/ Hi, This series failed the docker-clang@ubuntu build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH 2/3] configure: Fix building with SASL on Windows

2020-03-09 Thread Philippe Mathieu-Daudé
On 3/9/20 10:57 AM, Daniel P. Berrangé wrote: On Sat, Mar 07, 2020 at 06:22:21PM +0100, Philippe Mathieu-Daudé wrote: The Simple Authentication and Security Layer (SASL) library re-defines the struct iovec on Win32 [*]. QEMU also re-defines it in "qemu/osdep.h". The two definitions then clash

Re: [PATCH v2] gdbstub: Fix single-step issue by confirming 'vContSupported+' feature to gdb

2020-03-09 Thread Changbin Du
hello, is this patch ready to merge now? Thanks! On Fri, Feb 21, 2020 at 08:25:59AM +0800, Changbin Du wrote: > Recently when debugging an arm32 system on qemu, I found sometimes the > single-step command (stepi) is not working. This can be reproduced by > below steps: > 1) start qemu-system-arm

Re: [PATCH] core/qdev: fix memleak in qdev_get_gpio_out_connector()

2020-03-09 Thread Pan Nengyuan
On 3/9/2020 5:16 PM, Laurent Vivier wrote: > Le 07/03/2020 à 11:39, Marc-André Lureau a écrit : >> Hi >> >> On Sat, Mar 7, 2020 at 3:53 AM Pan Nengyuan wrote: >>> >>> Fix a memory leak in qdev_get_gpio_out_connector(). >>> >>> Reported-by: Euler Robot >>> Signed-off-by: Pan Nengyuan >> >>

[kvm-unit-tests PATCH v4 10/13] arm/arm64: ITS: INT functional tests

2020-03-09 Thread Eric Auger
Triggers LPIs through the INT command. the test checks the LPI hits the right CPU and triggers the right LPI intid, ie. the translation is correct. Updates to the config table also are tested, along with inv and invall commands. Signed-off-by: Eric Auger --- v3 -> v4: - assert in lpi_handler

[kvm-unit-tests PATCH v4 07/13] arm/arm64: ITS: its_enable_defaults

2020-03-09 Thread Eric Auger
its_enable_defaults() enable LPIs at distributor level and ITS level. gicv3_enable_defaults must be called before. Signed-off-by: Eric Auger --- v3 -> v4: - use GITS_BASER_INDIRECT & GITS_BASER_VALID in its_setup_baser() - don't parse BASERs again in its_enable_defaults - rename

Re: [PATCH v2] stdvga+bochs-display: add dummy mmio handler

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/2020030919.17624-1-kra...@redhat.com/ Hi, This series failed the docker-clang@ubuntu build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

[kvm-unit-tests PATCH v4 11/13] arm/run: Allow Migration tests

2020-03-09 Thread Eric Auger
Let's link getchar.o to use puts and getchar from the tests. Then allow tests belonging to the migration group to trigger the migration from the test code by putting "migrate" into the uart. Then the code can wait for the migration completion by using getchar(). The __getchar implement is

[kvm-unit-tests PATCH v4 06/13] arm/arm64: ITS: Introspection tests

2020-03-09 Thread Eric Auger
Detect the presence of an ITS as part of the GICv3 init routine, initialize its base address and read few registers the IIDR, the TYPER to store its dimensioning parameters. Parse the BASER registers. As part of the init sequence we also init all the requested tables. This is our first ITS test,

[kvm-unit-tests PATCH v4 12/13] arm/arm64: ITS: migration tests

2020-03-09 Thread Eric Auger
This test maps LPIs (populates the device table, the collection table, interrupt translation tables, configuration table), migrates and make sure the translation is correct on the destination. Signed-off-by: Eric Auger --- v3 -> v4: - assert in its_get_device/collection if the id is not found

[kvm-unit-tests PATCH v4 09/13] arm/arm64: ITS: Commands

2020-03-09 Thread Eric Auger
Implement main ITS commands. The code is largely inherited from the ITS driver. Signed-off-by: Eric Auger --- v3 -> v4: - device's itt now is a VGA - pass verbose to choose whether we shall print the cmd - use printf instead of report_info v2 -> v3: - do not use report() anymore - assert if

[kvm-unit-tests PATCH v4 04/13] arm/arm64: gicv3: Add some re-distributor defines

2020-03-09 Thread Eric Auger
PROPBASER, PENDBASE and GICR_CTRL will be used for LPI management. Signed-off-by: Eric Auger Reviewed-by: Zenghui Yu --- v3 -> v4: - replace some spaces by tabs and added Zenghui's R-b --- lib/arm/asm/gic-v3.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/arm/asm/gic-v3.h

[kvm-unit-tests PATCH v4 05/13] arm/arm64: gicv3: Set the LPI config and pending tables

2020-03-09 Thread Eric Auger
Allocate the LPI configuration and per re-distributor pending table. Set redistributor's PROPBASER and PENDBASER. The LPIs are enabled by default in the config table. Also introduce a helper routine that allows to set the pending table bit for a given LPI. Signed-off-by: Eric Auger --- v2 ->

[kvm-unit-tests PATCH v4 08/13] arm/arm64: ITS: Device and collection Initialization

2020-03-09 Thread Eric Auger
Introduce an helper functions to register - a new device, characterized by its device id and the max number of event IDs that dimension its ITT (Interrupt Translation Table). The function allocates the ITT. - a new collection, characterized by its ID and the target processing engine (PE).

[kvm-unit-tests PATCH v4 03/13] arm/arm64: gic: Introduce setup_irq() helper

2020-03-09 Thread Eric Auger
ipi_enable() code would be reusable for other interrupts than IPI. Let's rename it setup_irq() and pass an interrupt handler pointer. Signed-off-by: Eric Auger --- v2 -> v3: - do not export setup_irq anymore --- arm/gic.c | 20 +++- 1 file changed, 7 insertions(+), 13

[kvm-unit-tests PATCH v4 13/13] arm/arm64: ITS: pending table migration test

2020-03-09 Thread Eric Auger
Add two new migration tests. One testing the migration of a topology where collection were unmapped. The second test checks the migration of the pending table. Signed-off-by: Eric Auger --- v3 -> v4: - do not talk about odd/even CPUs, use pe0 and pe1 - comment the delay v2 -> v3: - tests

[kvm-unit-tests PATCH v4 01/13] libcflat: Add other size defines

2020-03-09 Thread Eric Auger
Introduce additional SZ_256, SZ_8K, SZ_16K macros that will be used by ITS tests. Signed-off-by: Eric Auger Reviewed-by: Thomas Huth --- lib/libcflat.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/libcflat.h b/lib/libcflat.h index ea19f61..7092af2 100644 --- a/lib/libcflat.h +++

[kvm-unit-tests PATCH v4 02/13] page_alloc: Introduce get_order()

2020-03-09 Thread Eric Auger
Compute the power of 2 order of a size. Use it in page_memalign. Other users are looming. Signed-off-by: Eric Auger --- lib/alloc_page.c | 7 ++- lib/alloc_page.h | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/alloc_page.c b/lib/alloc_page.c index ed23638..7c8461a

[kvm-unit-tests PATCH v4 00/13] arm/arm64: Add ITS tests

2020-03-09 Thread Eric Auger
This series is a revival of an RFC series sent in Dec 2016 [1]. Given the amount of code and the lack of traction at that time, I haven't respinned until now. However a recent bug found related to the ITS migration convinced me that this work may deserve to be respinned and enhanced. Tests

Re: [PATCH] qom-qmp-cmds: fix two memleaks in qmp_object_add

2020-03-09 Thread Pan Nengyuan
On 3/9/2020 6:15 PM, Daniel P. Berrangé wrote: > On Mon, Mar 09, 2020 at 10:51:45AM +0100, Igor Mammedov wrote: >> On Mon, 9 Mar 2020 17:22:12 +0800 >> Pan Nengyuan wrote: >> >>> 'type/id' forgot to free in qmp_object_add, this patch fix that. >>> >>> The leak stack: >>> Direct leak of 84

Re: [PATCH] qom-qmp-cmds: fix two memleaks in qmp_object_add

2020-03-09 Thread Pan Nengyuan
On 3/9/2020 5:51 PM, Igor Mammedov wrote: > On Mon, 9 Mar 2020 17:22:12 +0800 > Pan Nengyuan wrote: > >> 'type/id' forgot to free in qmp_object_add, this patch fix that. >> >> The leak stack: >> Direct leak of 84 byte(s) in 6 object(s) allocated from: >> #0 0x7fe2a5ebf768 in

Re: [PATCH] qom-qmp-cmds: fix two memleaks in qmp_object_add

2020-03-09 Thread Daniel P . Berrangé
On Mon, Mar 09, 2020 at 10:51:45AM +0100, Igor Mammedov wrote: > On Mon, 9 Mar 2020 17:22:12 +0800 > Pan Nengyuan wrote: > > > 'type/id' forgot to free in qmp_object_add, this patch fix that. > > > > The leak stack: > > Direct leak of 84 byte(s) in 6 object(s) allocated from: > > #0

Re: [PATCH v2 12/13] usb/hcd-ehci: Remove redundant statements

2020-03-09 Thread Gerd Hoffmann
On Wed, Feb 26, 2020 at 04:46:46PM +0800, kuhn.chen...@huawei.com wrote: > From: Chen Qun > > The "again" assignment is meaningless before g_assert_not_reached. > In addition, the break statements no longer needs to be after > g_assert_not_reached. > > Clang static code analyzer show warning: >

Re: [PATCH] usb-serial: wakeup device on input

2020-03-09 Thread Gerd Hoffmann
On Fri, Mar 06, 2020 at 09:09:17AM -0500, Jason Andryuk wrote: > Currently usb-serial devices are unable to send data into guests with > the xhci controller. Data is copied into the usb-serial's buffer, but > it is not sent into the guest. Data coming out of the guest works > properly.

Re: [PATCH v4 2/3] mac_via: fix incorrect creation of mos6522 device in mac_via

2020-03-09 Thread Peter Maydell
On Mon, 9 Mar 2020 at 10:02, Pan Nengyuan wrote: > On 3/9/2020 5:21 PM, Peter Maydell wrote: > > Could you explain more? My thought is that we should be using > > sysbus_init_child_obj() and we should be doing it in the init method. > > Why does that break the tests ? It's the same thing various

Re: [PATCH] qom-qmp-cmds: fix two memleaks in qmp_object_add

2020-03-09 Thread Markus Armbruster
Cc'ing Kevin in the hope of a review. Pan Nengyuan writes: > 'type/id' forgot to free in qmp_object_add, this patch fix that. > > The leak stack: > Direct leak of 84 byte(s) in 6 object(s) allocated from: > #0 0x7fe2a5ebf768 in __interceptor_malloc (/lib64/libasan.so.5+0xef768) > #1

Re: [PATCH] mem-prealloc: initialize cond and mutex

2020-03-09 Thread Paolo Bonzini
On 09/03/20 11:03, Igor Mammedov wrote: >> +qemu_cond_init(_cond); >> +qemu_mutex_init(_mutex); > Is it possible for touch_all_pages to be called several times? > If it's then it probably needs a guard against that to make > sure it won't explode, something like: > > static bool

[PATCH v5 2/5] generic vhost user server

2020-03-09 Thread Coiby Xu
Sharing QEMU devices via vhost-user protocol Signed-off-by: Coiby Xu --- util/Makefile.objs | 3 + util/vhost-user-server.c | 360 +++ util/vhost-user-server.h | 57 ++ 3 files changed, 420 insertions(+) create mode 100644

[PATCH v5 5/5] new qTest case to test the vhost-user-blk-server

2020-03-09 Thread Coiby Xu
This test case has the same tests as tests/virtio-blk-test.c except for tests have block_resize. Signed-off-by: Coiby Xu --- tests/Makefile.include | 3 +- tests/qtest/Makefile.include| 2 + tests/qtest/libqos/vhost-user-blk.c | 126 +

[PATCH v5 1/5] allow vu_message_read to be replaced

2020-03-09 Thread Coiby Xu
Allow vu_message_read to be replaced by one which will make use of the QIOChannel functions. Thus reading vhost-user message won't stall the guest. Remove watch for kick fd in vu_deinit. When QEMU as vhost-user client process is restarted in gdb, QEMU as vhost-user-server will still dispatch the

[PATCH v5 3/5] vhost-user block device backend server

2020-03-09 Thread Coiby Xu
By making use of libvhost, multiple block device drives can be exported and each drive can serve multiple clients simultaneously. Since vhost-user-server needs a block drive to be created first, delay the creation of this object. Signed-off-by: Coiby Xu --- block/Makefile.objs

[PATCH v5 4/5] a standone-alone tool to directly share disk image file via vhost-user protocol

2020-03-09 Thread Coiby Xu
vhost-user-blk could have played as vhost-user backend but it only supports raw file and don't support VIRTIO_BLK_T_DISCARD and VIRTIO_BLK_T_WRITE_ZEROES operations on raw file (ioctl(fd, BLKDISCARD) is only valid for real block device). Kevin's qemu-storage-daemon will be used to replace this

Re: [PATCH] mem-prealloc: initialize cond and mutex

2020-03-09 Thread Igor Mammedov
On Fri, 6 Mar 2020 03:50:14 -0500 Christian Borntraeger wrote: > Guests with mem-prealloc do fail with > qemu-system-s390x: /home/cborntra/REPOS/qemu/util/qemu-thread-posix.c:76: > qemu_mutex_lock_impl: Assertion `mutex->initialized' failed. > qemu-system-s390x:

[PATCH v5 0/5] vhost-user block device backend implementation

2020-03-09 Thread Coiby Xu
v5: * re-use vu_kick_cb in libvhost-user * keeping processing VhostUserMsg in the same coroutine until there is detachment/attachment of AIOContext * Spawn separate coroutine for each VuVirtqElement * Other changes including relocating vhost-user-blk-server.c, coding style etc. v4: *

Re: [PATCH v4 2/3] mac_via: fix incorrect creation of mos6522 device in mac_via

2020-03-09 Thread Pan Nengyuan
On 3/9/2020 5:21 PM, Peter Maydell wrote: > On Mon, 9 Mar 2020 at 00:56, Pan Nengyuan wrote: >> >> >> >> On 3/8/2020 9:29 PM, Peter Maydell wrote: >>> On Thu, 5 Mar 2020 at 06:39, Pan Nengyuan wrote: -/* Init VIAs 1 and 2 */ -sysbus_init_child_obj(OBJECT(dev), "via1",

[PATCH v2] stdvga+bochs-display: add dummy mmio handler

2020-03-09 Thread Gerd Hoffmann
The bochs-display mmio bar has some sub-regions with the actual hardware registers. What happens when the guest access something outside those regions depends on the archirecture. On x86 those reads succeed (and return 0xff I think). On risc-v qemu aborts. This patch adds handlers for the

Re: [PATCH 2/3] configure: Fix building with SASL on Windows

2020-03-09 Thread Daniel P . Berrangé
On Sat, Mar 07, 2020 at 06:22:21PM +0100, Philippe Mathieu-Daudé wrote: > The Simple Authentication and Security Layer (SASL) library > re-defines the struct iovec on Win32 [*]. QEMU also re-defines > it in "qemu/osdep.h". The two definitions then clash on a MinGW > build. > We can avoid the SASL

Re: [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

2020-03-09 Thread Markus Armbruster
Suggest scripts: Coccinelle script to use auto-propagated errp or scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE() Vladimir Sementsov-Ogievskiy writes: > Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and > does corresponding changes in code (look for

Re: [PATCH 3/3] tests/docker: Install SASL library to extend code coverage on amd64

2020-03-09 Thread Daniel P . Berrangé
On Sat, Mar 07, 2020 at 06:22:22PM +0100, Philippe Mathieu-Daudé wrote: > Install the SASL library to build the VNC SASL auth protocol code. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/docker/dockerfiles/debian-amd64.docker | 1 + > 1 file changed, 1 insertion(+) Reviewed-by:

Re: [PATCH] qom-qmp-cmds: fix two memleaks in qmp_object_add

2020-03-09 Thread Igor Mammedov
On Mon, 9 Mar 2020 17:22:12 +0800 Pan Nengyuan wrote: > 'type/id' forgot to free in qmp_object_add, this patch fix that. > > The leak stack: > Direct leak of 84 byte(s) in 6 object(s) allocated from: > #0 0x7fe2a5ebf768 in __interceptor_malloc (/lib64/libasan.so.5+0xef768) > #1

Re: [PATCH v6 17/18] docs: Add protvirt docs

2020-03-09 Thread Janosch Frank
On 3/4/20 8:09 PM, David Hildenbrand wrote: > On 04.03.20 12:42, Janosch Frank wrote: >> Lets add some documentation for the Protected VM functionality. >> >> Signed-off-by: Janosch Frank >> --- >> docs/system/index.rst| 1 + >> docs/system/protvirt.rst | 57

Re: [PATCH V4 0/5] Introduce Advanced Watch Dog module

2020-03-09 Thread Zhang, Chen
On 3/4/2020 9:37 PM, Paolo Bonzini wrote: On 04/03/20 09:06, Zhang, Chen wrote: Hi Eric and Paolo, Can you give some comments about this series? No news for a while... We already have some users(Cloud Service Provider) try to use is module in their product. But they also need to follow

Re: [PATCH v4 2/3] mac_via: fix incorrect creation of mos6522 device in mac_via

2020-03-09 Thread Peter Maydell
On Mon, 9 Mar 2020 at 00:56, Pan Nengyuan wrote: > > > > On 3/8/2020 9:29 PM, Peter Maydell wrote: > > On Thu, 5 Mar 2020 at 06:39, Pan Nengyuan wrote: > >> -/* Init VIAs 1 and 2 */ > >> -sysbus_init_child_obj(OBJECT(dev), "via1", >mos6522_via1, > >> -

[PATCH v3 03/60] target/riscv: support vector extension csr

2020-03-09 Thread LIU Zhiwei
The v0.7.1 specification does not define vector status within mstatus. A future revision will define the privileged portion of the vector status. Signed-off-by: LIU Zhiwei --- target/riscv/cpu_bits.h | 15 + target/riscv/csr.c | 75 - 2 files

[PATCH v3 02/60] target/riscv: implementation-defined constant parameters

2020-03-09 Thread LIU Zhiwei
vlen is the vector register length in bits. elen is the max element size in bits. vext_spec is the vector specification version, default value is v0.7.1. Signed-off-by: LIU Zhiwei Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson --- target/riscv/cpu.c | 7 +++

[PATCH v3 01/60] target/riscv: add vector extension field in CPURISCVState

2020-03-09 Thread LIU Zhiwei
The 32 vector registers will be viewed as a continuous memory block. It avoids the convension between element index and (regno, offset). Thus elements can be directly accessed by offset from the first vector base address. Signed-off-by: LIU Zhiwei Acked-by: Alistair Francis Reviewed-by: Richard

[PATCH v3 00/60] target/riscv: support vector extension v0.7.1

2020-03-09 Thread LIU Zhiwei
This patchset implements the vector extension for RISC-V on QEMU. You can also find the patchset and all *test cases* in my repo(https://github.com/romanheros/qemu.git branch:vector-upstream-v3). All the test cases are in the directory qemu/tests/riscv/vector/. They are riscv64 linux user mode

Re: 回复: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail)

2020-03-09 Thread Christian Borntraeger
On 06.03.20 10:57, bauerchen(陈蒙蒙) wrote: > Very sorry for my fault, in fact,I test  in a old qemu version ,and patch > generated based a new one ;  > All in all,its my fault, and I will check and test patch carefully In the > future > If I  need to  submit the patch again ? Can you test and

Re: [PATCH] core/qdev: fix memleak in qdev_get_gpio_out_connector()

2020-03-09 Thread Laurent Vivier
Le 07/03/2020 à 11:39, Marc-André Lureau a écrit : > Hi > > On Sat, Mar 7, 2020 at 3:53 AM Pan Nengyuan wrote: >> >> Fix a memory leak in qdev_get_gpio_out_connector(). >> >> Reported-by: Euler Robot >> Signed-off-by: Pan Nengyuan > > good catch, > Reviewed-by: Marc-André Lureau trivial

[PATCH] qom-qmp-cmds: fix two memleaks in qmp_object_add

2020-03-09 Thread Pan Nengyuan
'type/id' forgot to free in qmp_object_add, this patch fix that. The leak stack: Direct leak of 84 byte(s) in 6 object(s) allocated from: #0 0x7fe2a5ebf768 in __interceptor_malloc (/lib64/libasan.so.5+0xef768) #1 0x7fe2a505 in g_malloc (/lib64/libglib-2.0.so.0+0x52445) #2

Re: [PATCH v2 0/4] reference implementation of RSS

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309083438.2389-1-yuri.benditov...@daynix.com/ Hi, This series failed the docker-clang@ubuntu build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [PATCH] maint: Include top-level *.rst files early in git diff

2020-03-09 Thread Laurent Vivier
Le 20/02/2020 à 17:22, Eric Blake a écrit : > We are converting more doc files to *.rst rather than *.texi. Most > doc files are already listed early in diffs due to our catchall > docs/*, but a few top-level files get missed by that glob. > > Signed-off-by: Eric Blake > --- > > Both *.texi

Re: [PATCH] dp8393x: Mask EOL bit from descriptor addresses, take 2

2020-03-09 Thread Laurent Vivier
Le 09/03/2020 à 03:51, Jason Wang a écrit : > > On 2020/3/8 下午5:52, Laurent Vivier wrote: >> Le 04/03/2020 à 04:23, Finn Thain a écrit : >>> A portion of a recent patch got lost due to a merge snafu. That patch is >>> now commit 88f632fbb1 ("dp8393x: Mask EOL bit from descriptor >>> addresses").

[PATCH v2 4/4] virtio-net: block migration if RSS feature negotiated

2020-03-09 Thread Yuri Benditovich
Block migration for reference implementation of RSS feature in QEMU. When we add support for RSS on backend side, we'll implement migration of current RSS settings. Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c| 18 ++ include/hw/virtio/virtio-net.h | 1 +

[PATCH v2 3/4] virtio-net: implement RX RSS processing

2020-03-09 Thread Yuri Benditovich
If VIRTIO_NET_F_RSS negotiated and RSS is enabled, process incoming packets, calculate packet's hash and place the packet into respective RX virtqueue. Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c| 86 +- include/hw/virtio/virtio-net.h | 1

[PATCH v3 32/60] target/riscv: vector widening floating-point multiply

2020-03-09 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 5 + target/riscv/insn32.decode | 2 ++ target/riscv/insn_trans/trans_rvv.inc.c | 4 target/riscv/vector_helper.c| 22 ++ 4 files changed, 33 insertions(+) diff --git

[PATCH v3 33/60] target/riscv: vector single-width floating-point fused multiply-add instructions

2020-03-09 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 49 + target/riscv/insn32.decode | 16 ++ target/riscv/insn_trans/trans_rvv.inc.c | 18 ++ target/riscv/vector_helper.c| 228 4 files changed, 311 insertions(+) diff

[PATCH v3 37/60] target/riscv: vector floating-point sign-injection instructions

2020-03-09 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 19 +++ target/riscv/insn32.decode | 6 ++ target/riscv/insn_trans/trans_rvv.inc.c | 8 +++ target/riscv/vector_helper.c| 76 + 4 files changed, 109 insertions(+) diff

[PATCH v3 43/60] target/riscv: narrowing floating-point/integer type-convert instructions

2020-03-09 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 11 +++ target/riscv/insn32.decode | 5 +++ target/riscv/insn_trans/trans_rvv.inc.c | 42 + target/riscv/vector_helper.c| 42 + 4 files changed,

[PATCH v3 36/60] target/riscv: vector floating-point min/max instructions

2020-03-09 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 13 target/riscv/insn32.decode | 4 target/riscv/insn_trans/trans_rvv.inc.c | 6 ++ target/riscv/vector_helper.c| 27 + 4 files changed, 50

[PATCH v3 41/60] target/riscv: vector floating-point/integer type-convert instructions

2020-03-09 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 13 ++ target/riscv/insn32.decode | 4 +++ target/riscv/insn_trans/trans_rvv.inc.c | 6 + target/riscv/vector_helper.c| 33 + 4 files changed, 56 insertions(+)

[PATCH v3 35/60] target/riscv: vector floating-point square-root instruction

2020-03-09 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 4 +++ target/riscv/insn32.decode | 3 ++ target/riscv/insn_trans/trans_rvv.inc.c | 37 +++ target/riscv/vector_helper.c| 40 + 4 files changed, 84

[PATCH v3 48/60] target/riscv: vector mask-register logical instructions

2020-03-09 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 9 ++ target/riscv/insn32.decode | 8 + target/riscv/insn_trans/trans_rvv.inc.c | 28 + target/riscv/vector_helper.c| 40 + 4 files changed, 85

[PATCH v2 2/4] virtio-net: implement RSS configuration command

2020-03-09 Thread Yuri Benditovich
Optionally report RSS feature. Handle RSS configuration command and keep RSS parameters in virtio-net device context. Signed-off-by: Yuri Benditovich --- hw/net/trace-events| 3 + hw/net/virtio-net.c| 148 +++--

[PATCH v3 11/60] target/riscv: vector integer add-with-carry / subtract-with-borrow instructions

2020-03-09 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 33 ++ target/riscv/insn32.decode | 10 ++ target/riscv/insn_trans/trans_rvv.inc.c | 108 ++ target/riscv/vector_helper.c| 140 4 files changed, 291

[PATCH v3 38/60] target/riscv: vector floating-point compare instructions

2020-03-09 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 37 target/riscv/insn32.decode | 12 ++ target/riscv/insn_trans/trans_rvv.inc.c | 33 target/riscv/vector_helper.c| 221 4 files changed, 303 insertions(+) diff

[PATCH v2 1/4] virtio-net: introduce RSS and hash report features

2020-03-09 Thread Yuri Benditovich
Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c | 95 + 1 file changed, 95 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 3627bb1717..9545b0e84f 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -71,6

[PATCH v3 15/60] target/riscv: vector integer comparison instructions

2020-03-09 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 57 +++ target/riscv/insn32.decode | 20 target/riscv/insn_trans/trans_rvv.inc.c | 66 target/riscv/vector_helper.c| 130 4 files changed, 273

<    1   2   3   4   5   6   >