Re: [PATCH 1/4] sam460ex: Revert change to SPD memory type for <= 128 MiB

2020-04-20 Thread Markus Armbruster
BALATON Zoltan writes: > On Mon, 20 Apr 2020, Markus Armbruster wrote: >> Requesting 32 or 64 MiB of RAM with the sam460ex machine type produces >> a useless warning: >> >>qemu-system-ppc: warning: Memory size is too small for SDRAM type, >> adjusting type > > Why is it useless? It lets

Re: [PATCH 2/4] smbus: Fix spd_data_generate() error API violation

2020-04-20 Thread Markus Armbruster
BALATON Zoltan writes: > On Mon, 20 Apr 2020, Markus Armbruster wrote: >> The Error ** argument must be NULL, _abort, _fatal, or a >> pointer to a variable containing NULL. Passing an argument of the >> latter kind twice without clearing it in between is wrong: if the >> first call sets an

Re: [PATCH v4 00/30] Add subcluster allocation to qcow2

2020-04-20 Thread Derek Su
Hello, This work is promising and interesting. I'd like to try this new feature. Could you please export a branch because the patches cannot be applied to current master? Thanks. Regards, Derek On 2020/3/18 上午2:15, Alberto Garcia wrote: Hi, here's the new version of the patches to add

Re: [PATCH 4/4] smbus: Fix spd_data_generate() for number of banks > 2

2020-04-20 Thread Markus Armbruster
BALATON Zoltan writes: > On Mon, 20 Apr 2020, Markus Armbruster wrote: >> spd_data_generate() splits @ram_size bytes into @nbanks RAM banks of >> 1 << sz_log2 MiB each, like this: >> >>size = ram_size >> 20; /* work in terms of megabytes */ >>[...] >>nbanks = 1; >>while (sz_log2

Re: [RFC v1 0/4] vDPA support in qemu

2020-04-20 Thread Jason Wang
On 2020/4/20 下午5:32, Cindy Lu wrote: vDPA device is a device that uses a datapath which complies with the virtio specifications with vendor specific control path. vDPA devices can be both physically located on the hardware or emulated by software. This RFC introduce the vDPA support in qemu

Re: [PATCH v3 0/7] dwc-hsotg (aka dwc2) USB host controller emulation

2020-04-20 Thread Paul Zimmerman
Just FYI I think I have the fix for this (missing a DEFINE_PROP_END_OF_LIST()). Thanks, Paul On Mon, Apr 20, 2020 at 8:15 PM wrote: > Patchew URL: > https://patchew.org/QEMU/20200421014551.10426-1-pauld...@gmail.com/ > > > > Hi, > > This series failed the asan build test. Please find the

Re: [RFC v1 0/4] vDPA support in qemu

2020-04-20 Thread Jason Wang
On 2020/4/20 下午5:32, Cindy Lu wrote: vDPA device is a device that uses a datapath which complies with the virtio specifications with vendor specific control path. vDPA devices can be both physically located on the hardware or emulated by software. This RFC introduce the vDPA support in qemu

Re: [RFC v1 4/4] vhost: introduce vhost_set_vring_ready method

2020-04-20 Thread Jason Wang
On 2020/4/20 下午5:32, Cindy Lu wrote: From: Jason Wang Vhost-vdpa introduces VHOST_VDPA_SET_VRING_ENABLE which complies the semantic of queue_enable defined in virtio spec. This method can be used for preventing device from executing request for a specific virtqueue. This patch introduces the

Re: [RFC v1 3/4] vhost-vdpa: implement vhost-vdpa backend

2020-04-20 Thread Jason Wang
On 2020/4/20 下午5:32, Cindy Lu wrote: Currently we have 2 types of vhost backends in QEMU: vhost kernel and vhost-user. The above patch provides a generic device for vDPA purpose, this vDPA device exposes to user space a non-vendor-specific configuration interface for setting up a vhost HW

Re: [RFC v1 2/4] vhost-vdpa: introduce vhost-vdpa net client

2020-04-20 Thread Jason Wang
On 2020/4/20 下午5:32, Cindy Lu wrote: This patch set introduces a new net client type: vhost-vdpa. vhost-vdpa net client will set up a vDPA device which is svhostdevpecified typo. by a "vhostdev" parameter. Author: Tiwei Bie Please keep the sobs from the original patch.

Re: [RFC v1 1/4] net: Introduce qemu_get_peer

2020-04-20 Thread Jason Wang
On 2020/4/20 下午5:32, Cindy Lu wrote: This is a small function that can get the peer from given NetClientState and queue_index Unnecessary space  between 'function' and 'that'. Signed-off-by: Cindy Lu Please split this patch into two parts: 1) introduce the function 2) the actual

Re: [PATCH v3 0/7] dwc-hsotg (aka dwc2) USB host controller emulation

2020-04-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200421014551.10426-1-pauld...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v3 0/7] dwc-hsotg (aka dwc2) USB host controller emulation Message-id:

[Bug 1873338] Re: Dos on the fly CD image replacement is not Working with DOS

2020-04-20 Thread ruthan
** Description changed: Im not able to exchange CD image on the fly (needed for some games). I messed with command like - in console(ATL+CRTL+2) eject ide1-cd0 and change ide-cd0 D:/Games/!Emulators/Dos-QEMU/ISOs/TestChangeISO.iso , but system so never able to find new CD data.. simply

Re: [PATCH v3 0/7] dwc-hsotg (aka dwc2) USB host controller emulation

2020-04-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200421014551.10426-1-pauld...@gmail.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

2020-04-20 Thread Yan Zhao
On Tue, Apr 21, 2020 at 06:56:00AM +0800, Alex Williamson wrote: > On Sun, 19 Apr 2020 21:24:57 -0400 > Yan Zhao wrote: > > > On Fri, Apr 17, 2020 at 07:24:57PM +0800, Cornelia Huck wrote: > > > On Fri, 17 Apr 2020 05:52:02 -0400 > > > Yan Zhao wrote: > > > > > > > On Fri, Apr 17, 2020 at

Re: [PATCH v3 0/3] hw/riscv: Add a serial property to sifive_u

2020-04-20 Thread Bin Meng
On Tue, Apr 21, 2020 at 3:26 AM Alistair Francis wrote: > > On Wed, Apr 1, 2020 at 10:39 PM Bin Meng wrote: > > > > On Tue, Mar 24, 2020 at 10:08 AM Bin Meng wrote: > > > > > > Hi Palmer, > > > > > > On Sat, Mar 7, 2020 at 5:45 AM Alistair Francis > > > wrote: > > > > > > > > At present the

Re: [PATCH v2] virtiofsd/passthrough_ll: don't remove O_DIRECT when cache=none

2020-04-20 Thread Catherine Ho
Ping :) --- B.R. Catherine On Sat, 11 Apr 2020 at 16:41, Catherine Ho wrote: > > cache=none means to bypass host cache. So we can't remove O_DIRECT flag in > unconditionally in update_open_flags(); > > Signed-off-by: Catherine Ho > --- > v2: Fix to keep flags unchanged if cache=none, otherwise

[PATCH v3 7/7] raspi2 acceptance test: add test for dwc-hsotg (dwc2) USB host

2020-04-20 Thread Paul Zimmerman
Add a check for functional dwc-hsotg (dwc2) USB host emulation to the Raspi 2 acceptance test Signed-off-by: Paul Zimmerman --- tests/acceptance/boot_linux_console.py | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/acceptance/boot_linux_console.py

[PATCH v3 5/7] usb: add short-packet handling to usb-storage driver

2020-04-20 Thread Paul Zimmerman
The dwc-hsotg (dwc2) USB host depends on a short packet to indicate the end of an IN transfer. The usb-storage driver currently doesn't provide this, so fix it. I have tested this change rather extensively using a PC emulation with xhci, ehci, and uhci controllers, and have not observed any

[PATCH v3 4/7] dwc-hsotg (dwc2) USB host controller emulation

2020-04-20 Thread Paul Zimmerman
Add the dwc-hsotg (dwc2) USB host controller emulation code. Based on hw/usb/hcd-ehci.c and hw/usb/hcd-ohci.c. Note that to use this with the dwc-otg driver in the Raspbian kernel, you must pass the option "dwc_otg.fiq_fsm_enable=0" on the kernel command line. Emulation of slave mode and of

[PATCH v3 6/7] wire in the dwc-hsotg (dwc2) USB host controller emulation

2020-04-20 Thread Paul Zimmerman
Wire the dwc-hsotg (dwc2) emulation into Qemu Signed-off-by: Paul Zimmerman --- hw/arm/bcm2835_peripherals.c | 21 - hw/usb/Kconfig | 5 + hw/usb/Makefile.objs | 1 + include/hw/arm/bcm2835_peripherals.h | 3 ++- 4 files

[PATCH v3 3/7] dwc-hsotg (dwc2) USB host controller state definitions

2020-04-20 Thread Paul Zimmerman
Add the dwc-hsotg (dwc2) USB host controller state definitions. Mostly based on hw/usb/hcd-ehci.h. Signed-off-by: Paul Zimmerman --- hw/usb/hcd-dwc2.h | 184 ++ 1 file changed, 184 insertions(+) create mode 100644 hw/usb/hcd-dwc2.h diff --git

[PATCH v3 2/7] dwc-hsotg (dwc2) USB host controller register definitions

2020-04-20 Thread Paul Zimmerman
Import the dwc-hsotg (dwc2) register definitions file from the Linux kernel. This is a copy of drivers/usb/dwc2/hw.h from the mainline Linux kernel, the only changes being two instances of 'u32' changed to 'uint32_t' to allow it to compile. Signed-off-by: Paul Zimmerman ---

[PATCH v3 1/7] raspi: add BCM2835 SOC MPHI emulation

2020-04-20 Thread Paul Zimmerman
Add BCM2835 SOC MPHI (Message-based Parallel Host Interface) emulation. It is very basic, only providing the FIQ interrupt needed to allow the dwc-otg USB host controller driver in the Raspbian kernel to function. Signed-off-by: Paul Zimmerman --- hw/arm/bcm2835_peripherals.c | 17 +++

[PATCH v3 0/7] dwc-hsotg (aka dwc2) USB host controller emulation

2020-04-20 Thread Paul Zimmerman
Since I'm sure everyone is just sitting around waiting for 5.0 to release ;) I thought I would submit v3 of my dwc-hsotg series. I think I have taken everyone's requests/comments into account, except for Peter's request to use the macros from registerfields.h to access the registers. I think that

Re: [PATCH] roms: opensbi: Upgrade from v0.6 to v0.7

2020-04-20 Thread Bin Meng
Hi Alistair, On Tue, Apr 21, 2020 at 2:41 AM Alistair Francis wrote: > > On Mon, Apr 20, 2020 at 6:25 AM Bin Meng wrote: > > > > Upgrade OpenSBI from v0.6 to v0.7 and the pre-built bios images. > > > > The v0.7 release includes the following commits: > > > > f64f4b9 lib: Add a new platform

Re: [PATCH 1/2] hax: Fix setting of FD_CLOEXEC

2020-04-20 Thread Colin Xu
Looks good to me. Reviewed-by: Colin Xu -- Best Regards, Colin Xu On Tue, 21 Apr 2020, Eric Blake wrote: Blindly setting FD_CLOEXEC without a read-modify-write will inadvertently clear any other intentionally-set bits, such as a proposed new bit for designating a fd that must behave in

Re: [PATCH v1 2/2] migration/xbzrle: add encoding rate

2020-04-20 Thread Wei Wang
On 04/20/2020 10:53 PM, Eric Blake wrote: On 4/19/20 10:06 PM, Wei Wang wrote: Users may need to check the xbzrle encoding rate to know if the guest memory is xbzrle encoding-friendly, and dynamically turn off the encoding if the encoding rate is low. Signed-off-by: Yi Sun Signed-off-by: Wei

Re: [PATCH-for-5.0?] target/ppc: Fix TCG temporary leaks in gen_slbia()

2020-04-20 Thread David Gibson
On Mon, Apr 20, 2020 at 10:53:48PM +, Dennis Clarke wrote: > On 4/20/20 6:56 PM, Peter Maydell wrote: > > On Fri, 17 Apr 2020 at 10:08, Philippe Mathieu-Daudé > > wrote: > > > > > > This fixes: > > > > > >$ qemu-system-ppc64 \ > > >-machine pseries-4.1 -cpu power9 \ > > >-smp 4

Re: [PATCH-for-5.0?] target/ppc: Fix TCG temporary leaks in gen_slbia()

2020-04-20 Thread Dennis Clarke
On 4/20/20 6:56 PM, Peter Maydell wrote: On Fri, 17 Apr 2020 at 10:08, Philippe Mathieu-Daudé wrote: This fixes: $ qemu-system-ppc64 \ -machine pseries-4.1 -cpu power9 \ -smp 4 -m 12G -accel tcg ... ... Quiescing Open Firmware ... Booting Linux via __start() @

Re: [PATCH-for-5.0?] target/ppc: Fix TCG temporary leaks in gen_slbia()

2020-04-20 Thread David Gibson
On Mon, Apr 20, 2020 at 07:56:50PM +0100, Peter Maydell wrote: > On Fri, 17 Apr 2020 at 10:08, Philippe Mathieu-Daudé wrote: > > > > This fixes: > > > > $ qemu-system-ppc64 \ > > -machine pseries-4.1 -cpu power9 \ > > -smp 4 -m 12G -accel tcg ... > > ... > > Quiescing Open Firmware ...

RE: [PATCH 11/11] migration/colo: Fix qmp_xen_colo_do_checkpoint() error handling

2020-04-20 Thread Zhang, Chen
> -Original Message- > From: Markus Armbruster > Sent: Monday, April 20, 2020 4:33 PM > To: qemu-devel@nongnu.org > Cc: Zhang, Chen ; zhanghailiang > > Subject: [PATCH 11/11] migration/colo: Fix qmp_xen_colo_do_checkpoint() > error handling > > The Error ** argument must be NULL,

Re: [PATCH] fcntl: Add 32bit filesystem mode

2020-04-20 Thread Andreas Dilger
> From 73471e01733dd1d998ff3cd41edebb4c78793193 Mon Sep 17 00:00:00 2001 > From: Peter Maydell > Date: Mon, 20 Apr 2020 11:54:22 +0100 > Subject: [RFC] linux-user: Use new F_SET_FILE_32BIT_FS fcntl for 32-bit guests > > If the guest is 32 bit then there is a potential problem if the > host

Re: [PATCH v4 0/9] block: Fix resize (extending) of short overlays

2020-04-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200420133214.28921-1-kw...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: Question on memory commit during MR finalize()

2020-04-20 Thread Peter Xu
On Mon, Apr 20, 2020 at 11:44:11PM +0200, Paolo Bonzini wrote: > On 20/04/20 23:00, Peter Xu wrote: > > > > I'm still uncertain how the dirty ring branch can easily trigger this, > > however > > the backtrace looks really odd to me in that we're going to do memory commit > > and even sending KVM

[Bug 1856335] Re: Cache Layout wrong on many Zen Arch CPUs

2020-04-20 Thread Babu Moger
Damir, Example of how to use numa configuration. -smp 16,maxcpus=16,cores=16,threads=1,sockets=1 -numa node,nodeid=0,cpus=0-7 -numa node,nodeid=1,cpus=8-15 This will help to put all the cores in correct L3 boundary. I strongly suggest to use the latest qemu release. -- You received this bug

[Bug 1873338] Re: Dos on the fly CD image replacement is not Working with DOS

2020-04-20 Thread ruthan
Host: I tried both Windows (10 64bit 19.09) and Linux host (Mint 19.3 64bit, kernel 5.40) system it really doesnt matters. Guest: Windows 98 - has integrated MS-DOS 7.1 you can boot into it through boot menu, which could be set by meditation of MSDOS.SYS, but you can install MS-DOS 7.1

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

2020-04-20 Thread Alex Williamson
On Sun, 19 Apr 2020 21:24:57 -0400 Yan Zhao wrote: > On Fri, Apr 17, 2020 at 07:24:57PM +0800, Cornelia Huck wrote: > > On Fri, 17 Apr 2020 05:52:02 -0400 > > Yan Zhao wrote: > > > > > On Fri, Apr 17, 2020 at 04:44:50PM +0800, Cornelia Huck wrote: > > > > On Mon, 13 Apr 2020 01:52:01 -0400

Re: [PATCH 1/1] vfio-ccw: Enable transparent CCW IPL from DASD

2020-04-20 Thread Jared Rossi
On 2020-04-20 08:29, Cornelia Huck wrote: On Mon, 20 Apr 2020 14:26:17 +0200 Cornelia Huck wrote: On Fri, 17 Apr 2020 14:38:38 -0400 Jared Rossi wrote: > Remove the explicit prefetch check when using vfio-ccw devices. > This check is not needed as all Linux channel programs are intended >

Re: [PATCH 1/2] hax: Fix setting of FD_CLOEXEC

2020-04-20 Thread Eduardo Habkost
On Mon, Apr 20, 2020 at 12:53:07PM -0500, Eric Blake wrote: > Blindly setting FD_CLOEXEC without a read-modify-write will > inadvertently clear any other intentionally-set bits, such as a > proposed new bit for designating a fd that must behave in 32-bit mode. > Use our wrapper function instead of

Re: Question on memory commit during MR finalize()

2020-04-20 Thread Paolo Bonzini
On 20/04/20 23:00, Peter Xu wrote: > > I'm still uncertain how the dirty ring branch can easily trigger this, however > the backtrace looks really odd to me in that we're going to do memory commit > and even sending KVM ioctls during finalize(), especially in the RCU thread... > I never expected

Re: [PATCH] hw/pci/pcie: Forbid hot-plug via QMP if it's disabled on the slot

2020-04-20 Thread Julia Suvorova
On Tue, Apr 14, 2020 at 10:07 AM Marcel Apfelbaum wrote: > > Hi Julia, > > On 4/7/20 5:50 PM, Julia Suvorova wrote: > > Raise an error when trying to hot-plug/unplug a device through QMP to a > > device > > with disabled hot-plug capability. This makes the device behaviour more > > consistent

[PATCH 3/4] linux-user/arm: Handle invalid arm-specific syscalls correctly

2020-04-20 Thread Peter Maydell
The kernel has different handling for syscalls with invalid numbers that are in the "arm-specific" range 0x9f and up: * 0x9f..0x9f07ff return -ENOSYS if not implemented * other out of range syscalls cause a SIGILL (see the kernel's arch/arm/kernel/traps.c:arm_syscall()) Implement this

[PATCH 1/4] linux-user/arm: BKPT should cause SIGTRAP, not be a syscall

2020-04-20 Thread Peter Maydell
In linux-user/arm/cpu-loop.c we incorrectly treat EXCP_BKPT similarly to EXCP_SWI, which means that if the guest executes a BKPT insn then QEMU will perform a syscall for it (which syscall depends on what value happens to be in r7...). The correct behaviour is that the guest process should take a

[PATCH 0/4] linux-user/arm: Fix BKPT, SVC immediate handling

2020-04-20 Thread Peter Maydell
This patchseries fixes issues with the code in linux-user/arm/cpu_loop.c: * it incorrectly thinks BKPT is a syscall instruction (https://bugs.launchpad.net/qemu/+bug/1873898, reported via irc) * a stale line of code means we incorrectly NOP SVC #0xf0002 * we don't implement the distinction

[PATCH 4/4] linux-user/arm: Fix identification of syscall numbers

2020-04-20 Thread Peter Maydell
Our code to identify syscall numbers has some issues: * for Thumb mode, we never need the immediate value from the insn, but we always read it anyway * bad immediate values in the svc insn should cause a SIGILL, but we were abort()ing instead (via "goto error") We can fix both these

[PATCH 2/4] linux-user/arm: Remove bogus SVC 0xf0002 handling

2020-04-20 Thread Peter Maydell
We incorrectly treat SVC 0xf0002 as a cacheflush request (which is a NOP for QEMU). This is the wrong syscall number, because in the svc-immediate OABI syscall numbers are all offset by the ARM_SYSCALL_BASE value and so the correct insn is SVC 0x9f0002. (This is handled further down in the code

Re: [PULL 0/3] ppc-for-5.0 queue 20200417

2020-04-20 Thread Peter Maydell
On Fri, 17 Apr 2020 at 06:05, David Gibson wrote: > > The following changes since commit 20038cd7a8412feeb49c01f6ede89e36c8995472: > > Update version for v5.0.0-rc3 release (2020-04-15 20:51:54 +0100) > > are available in the Git repository at: > > git://github.com/dgibson/qemu.git

Question on memory commit during MR finalize()

2020-04-20 Thread Peter Xu
Paolo & all, After my recent rebase and changes to my local QEMU kvm-dirty-ring tree, I can easily trigger a QEMU crash at boot with that: kvm_set_phys_mem: error registering slot: File exists With backtrace: #0 __GI_raise (sig=sig@entry=6) #1 0x7f29559088d9 in __GI_abort () #2

Re: [PATCH v1] target/m68k: fix gdb for m68xxx

2020-04-20 Thread Laurent Vivier
Le 20/04/2020 à 21:08, KONRAD Frederic a écrit : > > > Le 4/20/20 à 5:46 PM, Laurent Vivier a écrit : >> Le 20/04/2020 à 16:01, frederic.kon...@adacore.com a écrit : >>> From: KONRAD Frederic >>> >>> Currently "cf-core.xml" is sent to GDB when using any m68k flavor.  >>> Thing is >>> it uses

[PATCH] target/arm: Implement SVE2 scatter store insns

2020-04-20 Thread Stephen Long
Add decoding logic for SVE2 64-bit/32-bit scatter non-temporal store insns. 64-bit * STNT1B (vector plus scalar) * STNT1H (vector plus scalar) * STNT1W (vector plus scalar) * STNT1D (vector plus scalar) 32-bit * STNT1B (vector plus scalar) * STNT1H (vector plus scalar) * STNT1W (vector plus

[Bug 1872847] Re: qemu-alpha linux-user breaks python3.6

2020-04-20 Thread Laurent Vivier
386d38656889 ("linux-user/syscall.c: add target-to-host mapping for epoll_create1()") ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1872847

[Bug 1873338] Re: Dos on the fly CD image replacement is not Working with DOS

2020-04-20 Thread John Snow
I think I need a bit more detail, I'm sorry. Can you explain to me the full environment you are seeing the problem in? Host: Windows? Linux? what version? If Linux, what kernel version? Guest: what's the version of the guest you are running? Windows98, or a version of DOS directly? Command-line:

Re: [PATCH v1] target/m68k: fix gdb for m68xxx

2020-04-20 Thread Laurent Vivier
Le 20/04/2020 à 21:08, KONRAD Frederic a écrit : > > > Le 4/20/20 à 5:46 PM, Laurent Vivier a écrit : >> Le 20/04/2020 à 16:01, frederic.kon...@adacore.com a écrit : >>> From: KONRAD Frederic >>> >>> Currently "cf-core.xml" is sent to GDB when using any m68k flavor.  >>> Thing is >>> it uses

Re: [PATCH v1 3/3] hw/arm: xlnx-zcu102: Disable unsupported FDT firmware nodes

2020-04-20 Thread Alistair Francis
On Sun, Apr 19, 2020 at 9:27 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Disable unsupported FDT firmware nodes if a user passes us > a DTB with nodes enabled that the machine cannot support > due to lack of EL3 or EL2 support. > > Signed-off-by: Edgar E. Iglesias

Re: [PATCH v1 1/3] device_tree: Allow name wildcards in qemu_fdt_node_path()

2020-04-20 Thread Alistair Francis
On Sun, Apr 19, 2020 at 9:27 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Allow name wildcards in qemu_fdt_node_path(). This is useful > to find all nodes with a given compatibility string. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair > --- >

Re: [PATCH-for-5.1 v2] hw/core/register: Add register_init_block8 helper.

2020-04-20 Thread Alistair Francis
On Thu, Apr 2, 2020 at 3:45 PM Alistair Francis wrote: > > On Thu, Apr 2, 2020 at 9:29 AM Joaquin de Andres > wrote: > > > > There was no support for 8 bits block registers. Changed > > register_init_block32 to be generic and static, adding register > > size in bits as parameter. Created one

Re: [PATCH v2 4/6] dwc-hsotg USB host controller emulation

2020-04-20 Thread Paul Zimmerman
Hi Philippe, On Mon, Apr 20, 2020 at 12:16 AM Philippe Mathieu-Daudé wrote: > Hi Paul, > > On 3/29/20 1:17 AM, Paul Zimmerman wrote: > > Add the dwc-hsotg (dwc2) USB host controller emulation code. > > Based on hw/usb/hcd-ehci.c and hw/usb/hcd-ohci.c. > > > > Note that to use this with the

Re: [PATCH v2 0/2] Support different CPU types for the sifive_e machine

2020-04-20 Thread Alistair Francis
On Fri, Mar 13, 2020 at 12:36 PM Corey Wharton wrote: > > The purpose of this patch set is to allow the sifive_e machine to run > with different CPU targets to enable different ISA entensions. To that > end it also introduces a new sifive-e34 CPU type which provides the > same ISA as sifive-e31,

Re: [PATCH v2 4/6] dwc-hsotg USB host controller emulation

2020-04-20 Thread Paul Zimmerman
Hi Philippe, As the label says, these are the host FIFOs. The controller has a mode where DMA is not used, and instead the driver reads the data directly from the FIFOs. I have not implemented this feature yet, but as I recall one of the BSDs uses this in their driver, so I plan to implement this

Re: [PATCH] hw/riscv: Generate correct "mmu-type" for 32-bit machines

2020-04-20 Thread Alistair Francis
On Sun, Apr 5, 2020 at 6:28 AM Bin Meng wrote: > > Hi Palmer, > > On Tue, Mar 10, 2020 at 1:22 AM Alistair Francis wrote: > > > > On Sat, Mar 7, 2020 at 4:49 AM Bin Meng wrote: > > > > > > 32-bit machine should have its CPU's "mmu-type" set to "riscv,sv32". > > > > > > Signed-off-by: Bin Meng

Re: [PATCH v3 0/3] hw/riscv: Add a serial property to sifive_u

2020-04-20 Thread Alistair Francis
On Wed, Apr 1, 2020 at 10:39 PM Bin Meng wrote: > > On Tue, Mar 24, 2020 at 10:08 AM Bin Meng wrote: > > > > Hi Palmer, > > > > On Sat, Mar 7, 2020 at 5:45 AM Alistair Francis > > wrote: > > > > > > At present the board serial number is hard-coded to 1, and passed > > > to OTP model during

Re: [PATCH] riscv: Fix Stage2 SV32 page table walk

2020-04-20 Thread Alistair Francis
On Mon, Mar 30, 2020 at 9:25 AM Alistair Francis wrote: > > On Mon, Mar 30, 2020 at 1:28 AM Anup Patel wrote: > > > > As-per RISC-V H-Extension v0.5 draft, the Stage2 SV32 page table has > > 12bits of VPN[1] and 10bits of VPN[0]. The additional 2bits in VPN[1] > > is required to handle the 34bit

Re: [PATCH for 5.0 v1 0/2] RISC-V: Fix Hypervisor guest user space

2020-04-20 Thread Alistair Francis
On Thu, Mar 26, 2020 at 3:51 PM Alistair Francis wrote: > > This series fixes two bugs in the RISC-V two stage lookup > implementation. This fixes the Hypervisor userspace failing to start. > > Alistair Francis (2): > riscv: Don't use stage-2 PTE lookup protection flags > riscv: AND stage-1

Re: [PATCH 0/2] fix fcntl(F_SETFD) usage

2020-04-20 Thread Peter Maydell
On Mon, 20 Apr 2020 at 18:53, Eric Blake wrote: > > As recently pointed out: > https://lists.gnu.org/archive/html/qemu-devel/2020-04/msg03133.html > code that blindly calls fcntl(fd, F_SETFD, 1) rather than performing a > read-modify-write when it intends to add FD_CLOEXEC is broken, in that > it

Re: [PATCH v1] target/m68k: fix gdb for m68xxx

2020-04-20 Thread KONRAD Frederic
Le 4/20/20 à 5:46 PM, Laurent Vivier a écrit : Le 20/04/2020 à 16:01, frederic.kon...@adacore.com a écrit : From: KONRAD Frederic Currently "cf-core.xml" is sent to GDB when using any m68k flavor. Thing is it uses the "org.gnu.gdb.coldfire.core" feature name and gdb 8.3 then expects a

Re: [PATCH-for-5.0?] target/ppc: Fix TCG temporary leaks in gen_slbia()

2020-04-20 Thread Peter Maydell
On Fri, 17 Apr 2020 at 10:08, Philippe Mathieu-Daudé wrote: > > This fixes: > > $ qemu-system-ppc64 \ > -machine pseries-4.1 -cpu power9 \ > -smp 4 -m 12G -accel tcg ... > ... > Quiescing Open Firmware ... > Booting Linux via __start() @ 0x0200 ... > Opcode 1f 12 0f 00

Re: [PULL 0/1] Linux user for 5.0 patches

2020-04-20 Thread Peter Maydell
On Thu, 16 Apr 2020 at 20:08, Peter Maydell wrote: > > On Thu, 16 Apr 2020 at 18:16, Laurent Vivier wrote: > > > > Le 16/04/2020 à 18:03, Peter Maydell a écrit : > > > On Thu, 16 Apr 2020 at 16:29, Laurent Vivier wrote: > > >> > > >> The following changes since commit > > >>

Re: [PATCH v1] target/m68k: fix gdb for m68xxx

2020-04-20 Thread KONRAD Frederic
Le 4/20/20 à 6:13 PM, Alex Bennée a écrit : frederic.kon...@adacore.com writes: From: KONRAD Frederic Currently "cf-core.xml" is sent to GDB when using any m68k flavor. Thing is it uses the "org.gnu.gdb.coldfire.core" feature name and gdb 8.3 then expects a coldfire FPU instead of the

Re: [PATCH 5/7] qapi: add filter-node-name to block-stream

2020-04-20 Thread Eric Blake
On 4/20/20 1:36 PM, Andrey Shinkevich wrote: Provide the possibility to pass the 'filter-node-name' parameter to the block-stream job as it is done for the commit block job. Signed-off-by: Andrey Shinkevich --- block/stream.c| 5 +++-- blockdev.c| 8 +++-

Re: [PATCH v2 3/6] target/microblaze: Add the div-zero-exception property

2020-04-20 Thread Luc Michel
On 4/20/20 7:52 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add the div-zero-exception property to control if the core > traps divizions by zero. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Luc Michel > --- > target/microblaze/cpu.c | 4 >

Re: [PATCH] roms: opensbi: Upgrade from v0.6 to v0.7

2020-04-20 Thread Alistair Francis
On Mon, Apr 20, 2020 at 6:25 AM Bin Meng wrote: > > Upgrade OpenSBI from v0.6 to v0.7 and the pre-built bios images. > > The v0.7 release includes the following commits: > > f64f4b9 lib: Add a new platform feature to bringup secondary harts > b677a9b lib: Implement hart hotplug > 5b48240 lib: Add

[PATCH 2/7] stream: exclude a link to filter from freezing

2020-04-20 Thread Andrey Shinkevich
A node above the base can be the filter of the concurrent job. In that case, the filter cannot be removed being a part of the frozen chain. Exclude the link to filter node from freezing and provide the safety check for a concurrent job. Signed-off-by: Andrey Shinkevich --- block/stream.c | 16

[PATCH 5/7] qapi: add filter-node-name to block-stream

2020-04-20 Thread Andrey Shinkevich
Provide the possibility to pass the 'filter-node-name' parameter to the block-stream job as it is done for the commit block job. Signed-off-by: Andrey Shinkevich --- block/stream.c| 5 +++-- blockdev.c| 8 +++- include/block/block_int.h | 7 ++-

[PATCH 7/7] block: apply COR-filter to block-stream jobs

2020-04-20 Thread Andrey Shinkevich
The patch completes the series with the COR-filter insertion to any block-stream operation. It also makes changes to the iotests 030, 141 and 245. Signed-off-by: Andrey Shinkevich --- block/stream.c | 151 +++-- tests/qemu-iotests/030 |

[PATCH 1/7] block: prepare block-stream for using COR-filter

2020-04-20 Thread Andrey Shinkevich
This patch is the first one in the series where the COR-filter node will be hard-coded for using in the block-stream job. The job may be run with a block-commit job in parallel. Set the condition to avoid the job conflicts. Signed-off-by: Andrey Shinkevich --- blockdev.c | 7 +-- 1 file

[PATCH 4/7] copy-on-read: Support refreshing filename

2020-04-20 Thread Andrey Shinkevich
Signed-off-by: Andrey Shinkevich --- block/copy-on-read.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/block/copy-on-read.c b/block/copy-on-read.c index ad6577d..e45eab9 100644 --- a/block/copy-on-read.c +++ b/block/copy-on-read.c @@ -21,6 +21,7 @@ */ #include "qemu/osdep.h"

[PATCH 3/7] block: protect parallel jobs from overlapping

2020-04-20 Thread Andrey Shinkevich
When it comes to the check for the blocked operations, the node may be a filter linked to blk. In that case, do not miss to set blocked operations for the underlying node. Signed-off-by: Andrey Shinkevich --- blockjob.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff

[PATCH 6/7] iotests: prepare 245 for using filter in block-stream

2020-04-20 Thread Andrey Shinkevich
The preliminary patch modifies the test 245 to prepare the block-stream job for using COR-filter. The filter breaks the backing chain being connected to the underlying node by file child link. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/245 | 10 +++--- 1 file changed, 7

[PATCH 0/7] Apply COR-filter to the block-stream permanently

2020-04-20 Thread Andrey Shinkevich
Note: this series is based on the one "block: Deal with filters" by Max Reitz that can be found in the branches: https://git.xanclic.moe/XanClic/qemu child-access-functions-v6 https://github.com/XanClic/qemu child-access-functions-v6 When running iotests, apply

Re: [PATCH] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

2020-04-20 Thread Julia Suvorova
On Mon, Apr 20, 2020 at 5:38 PM Ani Sinha wrote: > > > > > On Apr 20, 2020, at 8:34 PM, Ani Sinha wrote: > > > > > > > >> On Apr 18, 2020, at 6:18 PM, Marcel Apfelbaum > >> wrote: > >> > >> A PCIe Root Port or a PCI slot can or cannot support hot-plugging. > >> Anything in the middle can't be

Re: [PATCH 00/16] tcg: Better handling of constants

2020-04-20 Thread Richard Henderson
On 4/20/20 8:39 AM, Alex Bennée wrote: > The series failed to apply at the first patch. Should it be based on any > other patches? While I had split it out of the middle of a branch, I had not realized there are dependencies. Best guess is the "tcg: Clean up tcg_gen_gvec_dupi interface​" series

Re: [PATCH v2 3/6] target/microblaze: Add the div-zero-exception property

2020-04-20 Thread Alistair Francis
On Mon, Apr 20, 2020 at 10:54 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Add the div-zero-exception property to control if the core > traps divizions by zero. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair > --- > target/microblaze/cpu.c

[PATCH v2 6/6] target/microblaze: Add the pvr-user2 property

2020-04-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add the pvr-user2 property to control the user-defined PVR1 User2 register. Reviewed-by: Alistair Francis Reviewed-by: Luc Michel Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 2 ++ target/microblaze/cpu.h | 1 + 2 files changed, 3 insertions(+)

[PATCH 1/2] hax: Fix setting of FD_CLOEXEC

2020-04-20 Thread Eric Blake
Blindly setting FD_CLOEXEC without a read-modify-write will inadvertently clear any other intentionally-set bits, such as a proposed new bit for designating a fd that must behave in 32-bit mode. Use our wrapper function instead of an incorrect hand-rolled version. Signed-off-by: Eric Blake ---

[PATCH 2/2] tools: Fix use of fcntl(F_SETFD) during socket activation

2020-04-20 Thread Eric Blake
Blindly setting FD_CLOEXEC without a read-modify-write will inadvertently clear any other intentionally-set bits, such as a proposed new bit for designating a fd that must behave in 32-bit mode. However, we cannot use our wrapper qemu_set_cloexec(), because that wrapper intentionally abort()s on

[PATCH v2 1/6] target/microblaze: Add the opcode-0x0-illegal CPU property

2020-04-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add the opcode-0x0-illegal CPU property to control if the core should trap opcode zero as illegal. Reviewed-by: Alistair Francis Reviewed-by: Luc Michel Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 6 +- target/microblaze/cpu.h | 1

[PATCH v2 4/6] target/microblaze: Add the unaligned-exceptions property

2020-04-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add the unaligned-exceptions property to control if the core traps unaligned memory accesses. Reviewed-by: Alistair Francis Reviewed-by: Luc Michel Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 4 target/microblaze/cpu.h | 1 +

[PATCH 0/2] fix fcntl(F_SETFD) usage

2020-04-20 Thread Eric Blake
As recently pointed out: https://lists.gnu.org/archive/html/qemu-devel/2020-04/msg03133.html code that blindly calls fcntl(fd, F_SETFD, 1) rather than performing a read-modify-write when it intends to add FD_CLOEXEC is broken, in that it can inadvertently clear other bits. Thankfully, the

[PATCH v2 0/6] target-microblaze: Misc configurability #2

2020-04-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This is another round of conversion from hardcoded regs to cpu properties. The property names are taken from the device-tree bindings. Cheers, Edgar ChangeLog: v1 -> v2: * Populate the pvr2 div-zero-exception bit Edgar E. Iglesias (6): target/microblaze: Add the

[PATCH v2 2/6] target/microblaze: Add the ill-opcode-exception property

2020-04-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add the ill-opcode-exception property to control if illegal instructions will raise exceptions. Reviewed-by: Alistair Francis Reviewed-by: Luc Michel Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 4 target/microblaze/cpu.h | 1 +

[PATCH v2 5/6] target/microblaze: Add the pvr-user1 property

2020-04-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add the pvr-user1 property to control the user-defined PVR0 User1 field. Reviewed-by: Alistair Francis Reviewed-by: Luc Michel Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 4 +++- target/microblaze/cpu.h | 1 + 2 files changed, 4 insertions(+), 1

[PATCH v2 3/6] target/microblaze: Add the div-zero-exception property

2020-04-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add the div-zero-exception property to control if the core traps divizions by zero. Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 4 target/microblaze/cpu.h | 1 + target/microblaze/op_helper.c | 5 +++-- 3 files changed, 8

Re: [PATCH v2 00/16] nvme: refactoring and cleanups

2020-04-20 Thread Keith Busch
The series looks good to me. Reviewed-by: Keith Busch

Re: [PATCH v1 3/6] target/microblaze: Add the div-zero-exception property

2020-04-20 Thread Edgar E. Iglesias
On Sun, Apr 19, 2020 at 09:25:28PM +0200, Luc Michel wrote: > Hi Edgar, > > On 4/17/20 9:10 PM, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Add the div-zero-exception property to control if the core > > traps divizions by zero. > > > > Signed-off-by: Edgar E. Iglesias > >

Re: [PATCH] fcntl: Add 32bit filesystem mode

2020-04-20 Thread Theodore Y. Ts'o
On Mon, Apr 20, 2020 at 04:29:32PM +0100, Peter Maydell wrote: > On Mon, 20 Apr 2020 at 16:24, Eric Blake wrote: > > It will be interesting to find how much code (wrongly) assumes it can > > use a blind assignment of fcntl(fd, F_SETFD, 1) and thereby accidentally > > wipes out other existing

[Bug 1873898] Re: arm linux-user: bkpt insn doesn't cause SIGTRAP

2020-04-20 Thread Peter Maydell
** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1873898 Title: arm linux-user: bkpt insn doesn't cause SIGTRAP Status in QEMU: In Progress

Re: [PATCH 6/9] block/io: expand in_flight inc/dec section: block-status

2020-04-20 Thread Stefan Hajnoczi
On Wed, Apr 08, 2020 at 12:30:48PM +0300, Vladimir Sementsov-Ogievskiy wrote: > It's safer to expand in_flight request to start before enter to > coroutine in synchronous wrappers and end after BDRV_POLL_WHILE loop. > Note that qemu_coroutine_enter may only schedule the coroutine in some >

Re: [PATCH 9/9] block/io: expand in_flight inc/dec section: bdrv_make_zero

2020-04-20 Thread Stefan Hajnoczi
On Wed, Apr 08, 2020 at 12:30:51PM +0300, Vladimir Sementsov-Ogievskiy wrote: > @@ -2768,6 +2772,49 @@ int bdrv_make_zero(BdrvChild *child, BdrvRequestFlags > flags) > } > } > > +typedef struct BdrvDoMakeZeroData { > +BdrvChild *child; > +BdrvRequestFlags flags; > +int ret; >

Re: [PATCH 8/9] block/io: move bdrv_make_zero under block-status

2020-04-20 Thread Stefan Hajnoczi
On Wed, Apr 08, 2020 at 12:30:50PM +0300, Vladimir Sementsov-Ogievskiy wrote: > We are going to use bdrv_co_block_status in bdrv_make_zero, so move it > now down. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/io.c | 82 +++--- > 1

  1   2   3   >