[PULL 6/6] riscv/sifive_u: Add a serial property to the sifive_u machine

From: Bin Meng At present the board serial number is hard-coded to 1, and passed to OTP model during initialization. Firmware (FSBL, U-Boot) uses the serial number to generate a unique MAC address for the on-chip ethernet controller. When multiple QEMU 'sifive_u' instances are created and

Re: [PATCH] hw/usb/hcd-dwc2: Simplified I/O memory regions

On 4/21/20 12:13 AM, Philippe Mathieu-Daudé wrote: Use 1 container holding 2 regions: - I/O registers - FIFOs Remove all the static base addresses. Name address space. Signed-off-by: Philippe Mathieu-Daudé --- Sometime a patch is cleaner/quicker than explanations. Suggestion to be squashed

[PATCH] fuzz: select fuzz target using executable name

The fuzzers are built into a binary (e.g. qemu-fuzz-i386). To select the device to fuzz/fuzz target, we usually use the --fuzz-target= argument. This commit allows the fuzz-target to be specified using the name of the executable. If the executable name ends with -target-FUZZ_TARGET, then we select

Re: [RFC PATCH 03/17] hw/misc/temp-sensor: Add 'info temp' HMP command

* Philippe Mathieu-Daudé (f4...@amsat.org) wrote: > Add a command to display current devices temperature in the monitor: > > (qemu) info temp > Temperatures (in C): > videocore 25.00 > bcm2835-thermal-0 25.00 > > Signed-off-by: Philippe

Re: [PATCH v3 0/3] hw/riscv: Add a serial property to sifive_u

On Tue, 21 Apr 2020 10:40:05 PDT (-0700), alistai...@gmail.com wrote: On Mon, Apr 20, 2020 at 7:17 PM Bin Meng wrote: On Tue, Apr 21, 2020 at 3:26 AM Alistair Francis wrote: > > On Wed, Apr 1, 2020 at 10:39 PM Bin Meng wrote: > > > > On Tue, Mar 24, 2020 at 10:08 AM Bin Meng wrote: > > > >

Re: [PATCH 3/7] target/ppc: Use tcg_gen_gvec_dup_imm

On 4/20/20 3:34 AM, Alex Bennée wrote: >> +GEN_VXFORM_VSPLTI(vspltisb, MO_8, 6, 12); >> +GEN_VXFORM_VSPLTI(vspltish, MO_16, 6, 13); >> +GEN_VXFORM_VSPLTI(vspltisw, MO_32, 6, 14); > > There are unused parameters opc2/opc3 parameters here. Yes, but all of the other GEN_* macros retain them as

Re: [PATCH v3 0/3] hw/riscv: Add a serial property to sifive_u

On Mon, Apr 20, 2020 at 7:17 PM Bin Meng wrote: > > On Tue, Apr 21, 2020 at 3:26 AM Alistair Francis wrote: > > > > On Wed, Apr 1, 2020 at 10:39 PM Bin Meng wrote: > > > > > > On Tue, Mar 24, 2020 at 10:08 AM Bin Meng wrote: > > > > > > > > Hi Palmer, > > > > > > > > On Sat, Mar 7, 2020 at

Re: [PATCH] tests/tcg: use EXTRA_RUNS to run gdbtests

On 4/20/20 6:34 AM, Alex Bennée wrote: > With --enable-plugins the gdb tests confuse things somewhat as the > plugin code attempts to enumerate tests with non-existent binaries. > Fortunately we already have a mechanism for these extra tests that > don't automatically include their own binaries.

[PATCH for-5.0?] slirp: update to fix CVE-2020-1983

This is an update on the stable-4.2 branch of libslirp.git: git shortlog 55ab21c9a3..2faae0f778f81 Marc-André Lureau (1): Fix use-afte-free in ip_reass() (CVE-2020-1983) CVE-2020-1983 is actually a follow up fix for commit 126c04acbabd7ad32c2b018fe10dfac2a3bc1210 ("Fix heap overflow in

Re: [PATCH v3 06/10] iotests: add testfinder.py

Am 21.04.2020 um 09:35 hat Vladimir Sementsov-Ogievskiy geschrieben: > Add python script with new logic of searching for tests: > > Current ./check behavior: > - tests are named [0-9][0-9][0-9] > - tests must be registered in group file (even if test doesn't belong >to any group, like 142)

Re: [RFC PATCH 02/17] hw/misc/temp-sensor: Add 'query-temperature-sensors' QMP command

* Philippe Mathieu-Daudé (f4...@amsat.org) wrote: > Add a command to query current temperature from all sensors able > to report it: > > { "execute": "query-temperature-sensors" } > { > "return": [ > { > "temperature": 25, > "name": "videocore" >

[PATCH 6/8] cpus: Introduce qemu_mutex_unlock_iothread_prepare()

The prepare function before unlocking BQL. There're only three places that can release the BQL: unlock(), cond_wait() or cond_timedwait(). Signed-off-by: Peter Xu --- cpus.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/cpus.c b/cpus.c index 5cbc3f30de..48aa295fea 100644 ---

[PATCH 8/8] memory: Delay the transaction pop() until commit completed

This should be functionally the same as before, but this allows the memory_region_transaction_depth to be non-zero during commit, which can help us to do sanity check on misuses. Since at it, fix an indentation issue on the bracket. Signed-off-by: Peter Xu --- memory.c | 12 +--- 1

[PATCH 4/8] cpus: Introduce qemu_cond_timedwait_iothread()

This is the sister function of qemu_cond_wait_iothread(). Use it at the only place where we do cond_timedwait() on BQL. Signed-off-by: Peter Xu --- cpus.c | 9 +++-- include/qemu/main-loop.h | 7 +++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git

[PATCH 7/8] memory: Assert on no ongoing memory transaction before release BQL

Make sure we don't have any more ongoing memory transaction when releasing the BQL. This will trigger an abort if we misuse the QEMU memory model, e.g., when calling run_on_cpu() during a memory commit. Signed-off-by: Peter Xu --- cpus.c | 2 ++

Re: [PATCH v2 00/16] nvme: refactoring and cleanups

On Wed, 2020-04-15 at 15:01 +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Changes since v1 > > * nvme: fix pci doorbell size calculation > - added some defines and a better comment (Philippe) > > * nvme: rename trace events to pci_nvme > - changed the prefix from

[PATCH 0/8] memory: Sanity checks memory transaction when releasing BQL

This is a continuous work of previous discussion on memory transactions [1]. It should be helpful to fail QEMU far earlier if there's misuse of BQL against the QEMU memory model. One example is run_on_cpu() during memory commit. That'll work previously, but it'll fail with very strange errors

[PATCH 3/8] cpus: Use qemu_cond_wait_iothread() where proper

The helper is introduced but we've still got plenty of places that are directly referencing the qemu_global_mutex itself. Spread the usage. Signed-off-by: Peter Xu --- cpus.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/cpus.c b/cpus.c index

[PATCH 5/8] cpus: Remove the mutex parameter from do_run_on_cpu()

We must use the BQL for do_run_on_cpu() without much choice, it means the parameter is helpless. Remove it. Meanwhile use the newly introduced qemu_cond_wait_iothread() in do_run_on_cpu(). Signed-off-by: Peter Xu --- cpus-common.c | 5 ++--- cpus.c| 2 +-

[PATCH 2/8] memory: Don't do topology update in memory finalize()

Topology update could be wrongly triggered in memory region finalize() if there's bug somewhere else. It'll be a very confusing stack when it happens (e.g., sending KVM ioctl within the RCU thread, and we'll observe it only until it fails!). Instead of that, we use the push()/pop() helper to

[PATCH 1/8] memory: Introduce memory_region_transaction_{push|pop}()

memory_region_transaction_{begin|commit}() could be too big when finalizing a memory region. E.g., we should never attempt to update address space topology during the finalize() of a memory region. Provide helpers for further use. Signed-off-by: Peter Xu --- memory.c | 14 -- 1

Re: [PATCH v2 16/16] nvme: factor out controller identify setup

On Wed, 2020-04-15 at 15:01 +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Signed-off-by: Klaus Jensen > Reviewed-by: Philippe Mathieu-Daudé > --- > hw/block/nvme.c | 52 +++-- > 1 file changed, 29 insertions(+), 23 deletions(-) > > diff --git

Re: [PATCH v2 15/16] nvme: factor out cmb setup

On Wed, 2020-04-15 at 15:01 +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Signed-off-by: Klaus Jensen > Reviewed-by: Philippe Mathieu-Daudé > --- > hw/block/nvme.c | 49 +++-- > 1 file changed, 27 insertions(+), 22 deletions(-) > > diff --git

Re: [PATCH-for-5.0?] target/ppc: Fix TCG temporary leaks in gen_slbia()

On 2020-04-21 03:17, Philippe Mathieu-Daudé wrote: On 4/21/20 12:53 AM, Dennis Clarke wrote: On 4/20/20 6:56 PM, Peter Maydell wrote: On Fri, 17 Apr 2020 at 10:08, Philippe Mathieu-Daudé wrote: This fixes:    $ qemu-system-ppc64 \    -machine pseries-4.1 -cpu power9 \    -smp 4 -m 12G

Re: [PATCH v3 04/10] iotests/check: move QEMU_VXHS_PROG to common.rc

Am 21.04.2020 um 09:35 hat Vladimir Sementsov-Ogievskiy geschrieben: > QEMU_VXHS_PROG is used only in common.rc. So, move it to common.rc, > simplifying a bit further conversion of check into python > > Signed-off-by: Vladimir Sementsov-Ogievskiy This feels inconsistent when every other

Re: [PATCH v2 14/16] nvme: factor out pci setup

On Wed, 2020-04-15 at 15:01 +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 30 ++ > 1 file changed, 18 insertions(+), 12 deletions(-) > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > index

Re: [PATCH v2 13/16] nvme: factor out namespace setup

On Wed, 2020-04-15 at 15:01 +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 46 ++ > 1 file changed, 26 insertions(+), 20 deletions(-) > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c >

Re: [PATCH v4 0/7] ARM virt: Add NVDIMM support

Patchew URL: https://patchew.org/QEMU/20200421125934.14952-1-shameerali.kolothum.th...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v4 0/7] ARM virt: Add NVDIMM support Message-id:

Re: [RFC v1 3/4] vhost-vdpa: implement vhost-vdpa backend

On 20/04/2020 11:32, Cindy Lu wrote: > Currently we have 2 types of vhost backends in QEMU: vhost kernel and > vhost-user. The above patch provides a generic device for vDPA purpose, > this vDPA device exposes to user space a non-vendor-specific configuration > interface for setting up a vhost HW

Re: [PATCH v2 00/16] nvme: refactoring and cleanups

Am 21.04.2020 um 08:38 hat Klaus Birkelund Jensen geschrieben: > On Apr 21 02:38, Keith Busch wrote: > > The series looks good to me. > > > > Reviewed-by: Keith Busch > > Thanks for the review Keith! > > Kevin, should I rebase this on block-next? I think it might have some > conflicts with the

Re: [Qemu-devel] Should memory hotplug work with vhost-user backends?

On Thu, Apr 09, 2020 at 08:21:16PM -0400, Raphael Norwitz wrote: > On Wed, Jul 03, 2019 at 11:04:31AM +0100, Stefan Hajnoczi wrote: > > On Tue, Jul 02, 2019 at 10:08:54PM +, Raphael Norwitz wrote: > > > For background I am trying to work around a ram slot limit imposed by the > > > vhost-user

Re: [RFC v1 2/4] vhost-vdpa: introduce vhost-vdpa net client

On 20/04/2020 11:32, Cindy Lu wrote: > This patch set introduces a new net client type: vhost-vdpa. > vhost-vdpa net client will set up a vDPA device which is svhostdevpecified > by a "vhostdev" parameter. > > Author: Tiwei Bie > Signed-off-by: Cindy Lu > --- > include/net/vhost-vdpa.h | 18

Re: [PATCH v2 12/16] nvme: add namespace helpers

On Wed, 2020-04-15 at 15:01 +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Introduce some small helpers to make the next patches easier on the eye. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 3 +-- > hw/block/nvme.h | 16 > 2 files changed, 17

[Bug 1874073] Re: openrisc_sim.c:87:42: error: 'cpu_irqs[0]' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Confirming Peter's suggestion does silent the warning. -- >8 -- diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c index d08ce61811..02f5259e5e 100644 --- a/hw/openrisc/openrisc_sim.c +++ b/hw/openrisc/openrisc_sim.c @@ -134,6 +134,7 @@ static void openrisc_sim_init(MachineState

Re: [RFC v1 2/4] vhost-vdpa: introduce vhost-vdpa net client

On 21/04/2020 11:46, Cindy Lu wrote: > > > On Tue, Apr 21, 2020 at 11:40 AM Jason Wang > wrote: > > > On 2020/4/20 下午5:32, Cindy Lu wrote: > > This patch set introduces a new net client type: vhost-vdpa. > > vhost-vdpa net client will set up a vDPA

Re: [PATCH v2 11/16] nvme: factor out block backend setup

On Wed, 2020-04-15 at 15:01 +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > index 45a352b63d89..80da0825d295

Re: [PATCH] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

On Tue, Apr 21, 2020 at 02:45:04PM +, Ani Sinha wrote: > > > > On Apr 20, 2020, at 8:32 PM, Michael S. Tsirkin wrote: > > > > But I for one would like to focus on keeping PIIX stable > > and focus development on q35. Not bloating PIIX with lots of new > > features is IMHO a good way to do

Re: [RFC v1 1/4] net: Introduce qemu_get_peer

On 20/04/2020 11:32, Cindy Lu wrote: > This is a small function that can get the peer from given NetClientState and > queue_index > > Signed-off-by: Cindy Lu > --- > hw/net/vhost_net.c | 16 ++-- > include/net/net.h | 1 + > net/net.c | 6 ++ > 3 files changed, 17

Re: [PATCH v2 10/16] nvme: factor out device state setup

On Wed, 2020-04-15 at 15:01 +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Signed-off-by: Klaus Jensen > Reviewed-by: Philippe Mathieu-Daudé > --- > hw/block/nvme.c | 22 +- > 1 file changed, 13 insertions(+), 9 deletions(-) > > diff --git a/hw/block/nvme.c

Re: [PATCH v2 09/16] nvme: factor out property/constraint checks

On Wed, 2020-04-15 at 15:01 +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 43 --- > 1 file changed, 28 insertions(+), 15 deletions(-) > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > index

[Bug 1874073] Re: openrisc_sim.c:87:42: error: 'cpu_irqs[0]' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Does adding "assert(smp_cpus >= 1 && smp_cpus <= 2);" after the assignment to smp_cpus give the compiler enough information to know there's no use of uninitialized data? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

> On Apr 20, 2020, at 8:32 PM, Michael S. Tsirkin wrote: > > But I for one would like to focus on keeping PIIX stable > and focus development on q35. Not bloating PIIX with lots of new > features is IMHO a good way to do that. Does this mean this patch is a no-go then? :(

RE: Avoid copying unallocated clusters during full backup

Vladimir Sementsov-Ogievskiy wrote on 04/20/2020 11:04:33 AM: > Yes, the problem is that copy_range subsystem handles block-status, > when generic backup copying loop doesn't. I'm not sure that adding > fallback into copy-range is a correct thing to do, at least it > should be optional,

hw/net/cadence_gem: TX checksum offload does not work for fragmented packets

Hi, The cadence_gem does the TX checksum offload by: /* Is checksum offload enabled? */ if (s->regs[GEM_DMACFG] & GEM_DMACFG_TXCSUM_OFFL) { net_checksum_calculate(tx_packet, total_bytes); } However this will only work for

[Bug 1874073] Re: openrisc_sim.c:87:42: error: 'cpu_irqs[0]' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Note that our -Wmaybe-uninitialized warnings tends to report false positives. We have a rich meta bug for it: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=24639 That's why it can't prove the variable is initialized in all possible execution paths. ** Bug watch added: GCC Bugzilla #24639

Re: [PATCH v1] target/m68k: fix gdb for m68xxx

Le 21/04/2020 à 11:47, KONRAD Frederic a écrit : > > > Le 4/20/20 à 10:43 PM, Laurent Vivier a écrit : >> Le 20/04/2020 à 21:08, KONRAD Frederic a écrit : >>> >>> >>> Le 4/20/20 à 5:46 PM, Laurent Vivier a écrit : Le 20/04/2020 à 16:01, frederic.kon...@adacore.com a écrit : > From:

[Bug 1874073] Re: openrisc_sim.c:87:42: error: 'cpu_irqs[0]' may be used uninitialized in this function [-Werror=maybe-uninitialized]

I'm not sure why the compiler thinks it might be uninitialized here -- is it just that it's not aware that smp_cpus can't be zero and so the loop will always initialize cpu_irqs[0] ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Bug 1874073] Re: openrisc_sim.c:87:42: error: 'cpu_irqs[0]' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Suggested patch: diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c index 79e7049..724dcd0 100644 --- a/hw/openrisc/openrisc_sim.c +++ b/hw/openrisc/openrisc_sim.c @@ -129,7 +129,7 @@ static void openrisc_sim_init(MachineState *machine) const char *kernel_filename =

[Bug 1874073] [NEW] openrisc_sim.c:87:42: error: 'cpu_irqs[0]' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Public bug reported: I see the warning since gcc10: static void openrisc_sim_init(MachineState *machine): ... qemu_irq *cpu_irqs[2]; ... serial_mm_init(get_system_memory(), 0x9000, 0, serial_irq, 115200, serial_hd(0), DEVICE_NATIVE_ENDIAN); I would initialize

[PATCH 5/6] target/arm/cpu: Update coding style to make checkpatch.pl happy

We will move this code in the next commit. Clean it up first to avoid checkpatch.pl errors. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/cpu.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 9023d9e2cf..1ddf850f00

[PATCH 1/6] target/arm: Restric the Address Translate write operation to TCG accel

Under KVM these registers are written by the hardware. Restrict the writefn handlers to TCG to avoid when building without TCG: LINKaarch64-softmmu/qemu-system-aarch64 target/arm/helper.o: In function `do_ats_write': target/arm/helper.c:3524: undefined reference to

[PATCH 6/6] target/arm: Restrict TCG cpus to TCG accel

A KVM-only build won't be able to run TCG cpus. Signed-off-by: Philippe Mathieu-Daudé --- This patch review is funnier using: 'git-diff --color-moved=dimmed-zebra' --- target/arm/cpu.c | 634 - target/arm/cpu_tcg.c | 663

[PATCH 4/6] target/arm/cpu: Use ARRAY_SIZE() to iterate over ARMCPUInfo[]

Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/arm/cpu.c | 8 +++- target/arm/cpu64.c | 8 +++- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 6c84e99a38..9023d9e2cf 100644 ---

[PATCH 2/6] target/arm: Make set_feature() available for other files

From: Thomas Huth Move the common set_feature() and unset_feature() functions from cpu.c and cpu64.c to cpu.h. Suggested-by: Peter Maydell Signed-off-by: Thomas Huth Reviewed-by: Richard Henderson Reviewed-by: Eric Auger Message-ID: <20190921150420.30743-2-th...@redhat.com> [PMD: Split

[PATCH 0/6] target/arm: Restrict TCG cpus to TCG accel

These are the uncontroversial patches from "Support disabling TCG on ARM (part 2)" https://www.mail-archive.com/qemu-devel@nongnu.org/msg689168.html The other patches are blocked by the "accel: Allow targets to use Kconfig" series: https://www.mail-archive.com/qemu-devel@nongnu.org/msg689024.html

[PATCH 3/6] target/arm: Make cpu_register() available for other files

From: Thomas Huth Make cpu_register() (renamed to arm_cpu_register()) available from internals.h so we can register CPUs also from other files in the future. Signed-off-by: Thomas Huth Reviewed-by: Richard Henderson Reviewed-by: Eric Auger Message-ID:

Re: [PATCH 0/7] Apply COR-filter to the block-stream permanently

20.04.2020 21:36, Andrey Shinkevich wrote: Note: this series is based on the one "block: Deal with filters" by Max Reitz that can be found in the branches: https://git.xanclic.moe/XanClic/qemu child-access-functions-v6 https://github.com/XanClic/qemu

Re: [edk2-discuss] Load Option passing. Either bugs or my confusion.

On 04/20/20 16:13, Gerd Hoffmann wrote: > Hi, > >> So I would say that the symptom you see is a QEMU v4.1.0 regression. >> The QemuRamfbGraphicsOutputSetMode() function in the OVMF ramfb >> driver certainly needs the QemuFwCfgWriteBytes() call to work, for >> changing the resolution. > > Oh?

[PATCH v4 6/7] bios-tables-test: test pc-dimm and nvdimm coldplug for arm/virt

Since we now have both pc-dimm and nvdimm support, update test_acpi_virt_tcg_memhp() to include those. Signed-off-by: Shameer Kolothum --- tests/qtest/bios-tables-test.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/qtest/bios-tables-test.c

[PATCH v4 7/7] tests/acpi: add expected tables for bios-tables-test

Because of the following changes, the expeacted tables for bios-tables-test needs to be updated. 1. Changed NVDIM DSM output buffer AML code. 2. Updated arm/virt test_acpi_virt_tcg_memhp() to add pc-dimm/nvdimm Signed-off-by: Shameer Kolothum --- tests/data/acpi/pc/SSDT.dimmpxm |

[PATCH v4 4/7] hw/arm/virt: Add nvdimm hotplug support

This adds support for nvdimm hotplug events through GED and enables nvdimm for the arm/virt. Now Guests with ACPI can have both cold and hot plug of nvdimms. Hot removal functionality is not yet supported. Signed-off-by: Shameer Kolothum Reviewed-by: Igor Mammedov Reviewed-by: Eric Auger ---

[PATCH v4 2/7] nvdimm: Use configurable ACPI IO base and size

From: Kwangwoo Lee This patch makes IO base and size configurable to create NPIO AML for ACPI NFIT. Since a different architecture like AArch64 does not use port-mapped IO, a configurable IO base is required to create correct mapping of ACPI IO address and size. Signed-off-by: Kwangwoo Lee

[PATCH v4 3/7] hw/arm/virt: Add nvdimm hot-plug infrastructure

From: Kwangwoo Lee This adds support to init nvdimm acpi state and build nvdimm acpi tables. Please note nvdimm_support is not yet enabled. Signed-off-by: Kwangwoo Lee Signed-off-by: Eric Auger Signed-off-by: Shameer Kolothum Reviewed-by: Igor Mammedov --- hw/arm/Kconfig | 1 +

Re: [PATCH v3 6/7] s390x/css: Refactor the css_queue_crw() routine

On 4/21/20 8:28 AM, Cornelia Huck wrote: > On Fri, 17 Apr 2020 04:34:39 +0200 > Eric Farman wrote: > >> We have a use case (vfio-ccw) where a CRW is already built and >> ready to use. Rather than teasing out the components just to >> reassemble it later, let's rework this code so we can

Re: [PATCH v3 01/10] iotests/277: use dot slash for nbd-fault-injector.py running

21.04.2020 15:54, Eric Blake wrote: On 4/21/20 2:35 AM, Vladimir Sementsov-Ogievskiy wrote: Somehow, this doesn't work if you just call ./277. But check 277 works. We are going to new iotests running framework, which will consider test files as self-executable, so let's just change it now.

[PATCH v4 5/7] tests: Update ACPI tables list for upcoming arm/virt test changes

This is in preparation to update test_acpi_virt_tcg_memhp() with pc-dimm and nvdimm. Update the bios-tables-test-allowed-diff.h with the affected ACPI tables so that "make check" doesn't fail. Also add empty files for new tables required for new test. Signed-off-by: Shameer Kolothum ---

[PATCH v4 1/7] hw/acpi/nvdimm: Fix for NVDIMM incorrect DSM output buffer length

As per ACPI spec 6.3, Table 19-419 Object Conversion Rules, if the Buffer Field <= to the size of an Integer (in bits), it will be treated as an integer. Moreover, the integer size depends on DSDT tables revision number. If revision number is < 2, integer size is 32 bits, otherwise it is 64 bits.

Re: [PATCH] fcntl: Add 32bit filesystem mode

On Tue, 21 Apr 2020 at 00:51, Andreas Dilger wrote: > Another question I had here is whether the filesystem needs to provide > 32-bit values for other syscalls, such as stat() and statfs()? For > ext4, stat() is not going to return a 64-bit inode number, but other > filesystems might (e.g.

[PATCH v4 0/7] ARM virt: Add NVDIMM support

This series adds NVDIMM support to arm/virt platform. The series reuses some of the patches posted by Eric in his earlier attempt here[1]. This series previously had few fixes to qemu in general which were discovered while adding nvdimm support to arm/virt. Those were sent out seperately[2] and

Re: [PATCH v3 4/7] vfio-ccw: Add support for the crw region

On 4/21/20 8:21 AM, Cornelia Huck wrote: > On Fri, 17 Apr 2020 04:34:37 +0200 > Eric Farman wrote: > >> From: Farhan Ali >> >> The crw region can be used to obtain information about >> Channel Report Words (CRW) from vfio-ccw driver. >> >> Currently only channel path related CRWs are passed

Re: [PATCH 7/7] block: apply COR-filter to block-stream jobs

20.04.2020 21:36, Andrey Shinkevich wrote: The patch completes the series with the COR-filter insertion to any block-stream operation. It also makes changes to the iotests 030, 141 and 245. Signed-off-by: Andrey Shinkevich --- block/stream.c | 151

Re: SLiRP: use-afte-free in ip_reass() [CVE-2020-1983]

21.04.2020 13:33, Daniel P. Berrangé wrote: [] > Admittedly this may be troublesome for Debian which, AFAICT, does not > add new packages to pre-existing stable releases. Presumably someone > can add it to the "backports" release archive if this is too hard to > get into a stable release ? Failing

Re: [PATCH v3 03/10] iotests/283: make executable

On 4/21/20 2:35 AM, Vladimir Sementsov-Ogievskiy wrote: All other test files are executable, except for this one. Fix that. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/283 | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755

Re: [PATCH v3 01/10] iotests/277: use dot slash for nbd-fault-injector.py running

On 4/21/20 2:35 AM, Vladimir Sementsov-Ogievskiy wrote: Somehow, this doesn't work if you just call ./277. But check 277 works. We are going to new iotests running framework, which will consider test files as self-executable, so let's just change it now. This is a rather vague explanation.

Re: [PATCH 0/5] QEMU Gating CI

On Thu, 19 Mar 2020 at 16:33, Markus Armbruster wrote: > Peter Maydell writes: > > I think we should start by getting the gitlab setup working > > for the basic "x86 configs" first. Then we can try adding > > a runner for s390 (that one's logistically easiest because > > it is a project machine,

Re: [PATCH 5/7] qapi: add filter-node-name to block-stream

21.04.2020 15:40, Vladimir Sementsov-Ogievskiy wrote: 20.04.2020 21:36, Andrey Shinkevich wrote: Provide the possibility to pass the 'filter-node-name' parameter to the block-stream job as it is done for the commit block job. So, you add it, but it actually do nothing for now. I'd prefer to

Re: [PATCH 5/7] qapi: add filter-node-name to block-stream

20.04.2020 21:36, Andrey Shinkevich wrote: Provide the possibility to pass the 'filter-node-name' parameter to the block-stream job as it is done for the commit block job. So, you add it, but it actually do nothing for now. I'd prefer to make this patch the last one, so it actually make the

Re: [PATCH 4/7] copy-on-read: Support refreshing filename

Some information about why we need it would be nice. Still I see same function in commit.c, so most probably it's OK. 20.04.2020 21:36, Andrey Shinkevich wrote: Signed-off-by: Andrey Shinkevich --- block/copy-on-read.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

Re: [PATCH 3/7] block: protect parallel jobs from overlapping

20.04.2020 21:36, Andrey Shinkevich wrote: When it comes to the check for the blocked operations, the node may be a filter linked to blk. "blk" commonly refers to BlockBackend, which is unrelated here. You mean just a filter. In that case, do not miss to set blocked operations for the

[RFC PATCH 16/17] hw/misc/imx6ul_ccm: Implement the 'temperature-sensor' qdev interface

The IMX6UL Clock Control Module can report few temperatures. While the model doesn't implement it, we can still let it implement the 'temperature-sensor' interface. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/imx6ul_ccm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

Re: [PATCH v3 6/7] s390x/css: Refactor the css_queue_crw() routine

On Fri, 17 Apr 2020 04:34:39 +0200 Eric Farman wrote: > We have a use case (vfio-ccw) where a CRW is already built and > ready to use. Rather than teasing out the components just to > reassemble it later, let's rework this code so we can queue a > fully-qualified CRW directly. > >

Re: [PATCH 1/7] block: prepare block-stream for using COR-filter

20.04.2020 21:36, Andrey Shinkevich wrote: This patch is the first one in the series where the COR-filter node will be hard-coded for using in the block-stream job. The job may be run with a block-commit job in parallel. Set the condition to avoid the job conflicts. I think, just skipping all

[RFC PATCH 12/17] hw/misc/bcm2835_property: Hold the temperature in the device state

We are going to modify this variable, move it to the device state. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/bcm2835_property.h | 1 + hw/misc/bcm2835_property.c | 8 +--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 2/7] stream: exclude a link to filter from freezing

20.04.2020 21:36, Andrey Shinkevich wrote: A node above the base can be the filter of the concurrent job. In that case, the filter cannot be removed being a part of the frozen chain. Exclude the link to filter node from freezing and provide the safety check for a concurrent job. Signed-off-by:

[RFC PATCH 17/17] tests/qtest/tmp105-test: Trivial test for TempSensorClass

The qmp_tmp105_set_temperature() call will trigger TempSensorClass::set_temperature(), then hmp_info_temperature() triggers TempSensorClass::get_temperature(). Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/tmp105-test.c | 18 ++ 1 file changed, 18 insertions(+) diff

[PATCH] MAINTAINERS: Update Keith Busch's email address

keith.bu...@intel.com address is being rejected. Replace by the email address Keith is actively using. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8cbc1fac2b..5dbf48d22e 100644 ---

[RFC PATCH 05/17] hw/misc/tmp105: Implement the 'temperature-sensor' qdev interface

The TMP105 is an I2C temperature sensor. Let it implement the 'temperature-sensor' interface. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/tmp105.c | 20 1 file changed, 20 insertions(+) diff --git a/hw/misc/tmp105.c b/hw/misc/tmp105.c index 754c8a6eb4..1f0cb28012

[RFC PATCH 15/17] hw/ide/qdev: Implement the 'temperature-sensor' qdev interface

IDE drives exposing a SMART interface report the air flow temperature. Let them implement the 'temperature-sensor' interface. Signed-off-by: Philippe Mathieu-Daudé --- hw/ide/qdev.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c index

[RFC PATCH 13/17] hw/misc/bcm2835_property: Implement the 'temperature-sensor' interface

The BCM2835 'property' QEMU device models the serialized responses from the VideoCore firmware. As we can query the VC for its current temperatyre, let this model implement the 'temperature-sensor' interface. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/bcm2835_property.c | 31

Re: [PATCH v3 4/7] vfio-ccw: Add support for the crw region

On Fri, 17 Apr 2020 04:34:37 +0200 Eric Farman wrote: > From: Farhan Ali > > The crw region can be used to obtain information about > Channel Report Words (CRW) from vfio-ccw driver. > > Currently only channel path related CRWs are passed to > QEMU from vfio-ccw driver. > > Signed-off-by:

[RFC PATCH 08/17] hw/misc/tmp421: Extract set_temp_mC() helper

Since we are going to reuse this code, extract it first. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/tmp421.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/hw/misc/tmp421.c b/hw/misc/tmp421.c index 8003356307..270e7d5510 100644 ---

[RFC PATCH 11/17] hw/misc/bcm2835_thermal: Implement the 'temperature-sensor' interface

The BCM2835 has a block that reports its temperature. Let it implement the 'temperature-sensor' interface. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/bcm2835_thermal.c | 24 1 file changed, 24 insertions(+) diff --git a/hw/misc/bcm2835_thermal.c

[RFC PATCH 10/17] hw/misc/bcm2835_thermal: Hold the temperature in the device state

We are going to modify this variable, move it to the device state. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/bcm2835_thermal.h | 1 + hw/misc/bcm2835_thermal.c | 18 +- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git

[RFC PATCH 14/17] hw/display/ads7846: Implement the 'temperature-sensor' qdev interface

The 4-wire ADS7846 Touch Screen Controller is able to report a pair of temperatures. Let it implement the 'temperature-sensor' interface. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/ads7846.c | 38 ++ 1 file changed, 38 insertions(+) diff --git

[RFC PATCH 06/17] hw/misc/tmp421: Add definition for SENSORS_COUNT

Use a definition instead of a magic value. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/tmp421.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/misc/tmp421.c b/hw/misc/tmp421.c index c0bc150bca..04c3b3ca6e 100644 --- a/hw/misc/tmp421.c +++ b/hw/misc/tmp421.c

[RFC PATCH 04/17] hw/misc/tmp105: Extract get_temp_mC() and set_temp_mC() helpers

Since we are going to reuse this code, extract it as helpers. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/tmp105.c | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/hw/misc/tmp105.c b/hw/misc/tmp105.c index 75ddad3a12..754c8a6eb4 100644

[RFC PATCH 09/17] hw/misc/tmp421: Implement the 'temperature-sensor' qdev interface

The TMP421 is an I2C device with multiple temperature sensors. Let it implement the 'temperature-sensor' interface. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/tmp421.c | 24 1 file changed, 24 insertions(+) diff --git a/hw/misc/tmp421.c b/hw/misc/tmp421.c index

[RFC PATCH 03/17] hw/misc/temp-sensor: Add 'info temp' HMP command

Add a command to display current devices temperature in the monitor: (qemu) info temp Temperatures (in C): videocore 25.00 bcm2835-thermal-0 25.00 Signed-off-by: Philippe Mathieu-Daudé --- include/monitor/hmp.h | 1 + hw/misc/temp-sensor.c |

[RFC PATCH 07/17] hw/misc/tmp421: Extract get_temp_mC() helper

Since we are going to reuse this code, extract it first. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/tmp421.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/hw/misc/tmp421.c b/hw/misc/tmp421.c index 04c3b3ca6e..8003356307 100644 --- a/hw/misc/tmp421.c

[RFC PATCH 01/17] hw/misc: Introduce the temperature sensor interface

Introduce an interface to set and get temperature from devices. A device can have multiple temperature sensors. Each sensor might have a custom name. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/temp-sensor.h | 69 +++ hw/misc/temp-sensor.c

<    1   2   3   >